1 2007-05-31 Murray Cumming <murrayc@murrayc.com>
4 * src/modest-ui-actions.c:
5 (modest_ui_actions_get_msgs_full_error_handler):
6 Renamed an enum, added comments, added an enum
7 for retrieve-limit errors.
9 * src/modest-mail-operation.c: (foreach_add_item),
10 (internal_folder_observer_update), (update_account_thread),
11 (modest_mail_operation_get_msgs_full):
12 (modest_mail_operation_update_account),
13 Added comments about how this works, and some code that should
14 (but does not) check the retrieve-limit. See the TODO comment.
16 2007-05-31 Murray Cumming <murrayc@murrayc.com>
18 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
19 Initialize help_id to fix the build. Warnings are good.
21 2007-05-31 Murray Cumming <murrayc@murrayc.com>
23 * src/widgets/modest-hbox-cell-renderer.c:
24 (modest_hbox_cell_renderer_append):
25 * src/widgets/modest-vbox-cell-renderer.c:
26 (modest_vbox_cell_renderer_append):
27 Fix the last commit by doing an extra ref.
29 2007-05-31 Murray Cumming <murrayc@murrayc.com>
31 * src/widgets/modest-hbox-cell-renderer.c:
32 (modest_hbox_cell_renderer_append):
33 * src/widgets/modest-vbox-cell-renderer.c:
34 (modest_vbox_cell_renderer_append):
35 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
36 to fix the build with Maemo Bora.
37 However, there seems to be a remaining crash, probably due to reference
40 2007-05-30 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-tny-account.c:
43 (modest_tny_account_new_for_local_folders):
44 Use hildon_file_system_info_async_new() to get a better name for
45 the memory card account, setting it as the account name.
46 The timing seems to work, but this is probably
47 not the best place to do this. See the TODO comment.
48 * src/maemo/modest-main-window.c: (create_details_widget):
49 * src/widgets/modest-folder-view.c: (text_cell_data):
50 Use the tny account name instead of hardcoding a name.
52 2007-05-30 Christian Kellner <ckellner@openismus.com>
54 * src/modest-search.c: (modest_search):
55 Correctly set part_search_func even if we have already parsed
56 the query and thus a valid OgsTextSearcher object.
58 2007-05-30 Christian Kellner <ckellner@openismus.com>
61 Search and check for libogs.
64 Incooparte the ogs build env.
66 * src/modest-mime-part-search-stream.c:
67 * src/modest-mime-part-search-stream.h:
68 Removed since we do the real searching now in modest-search.c.
70 * src/modest-search.c:
71 * src/modest-search.h:
72 Implement support for ogs. We use that if available and requested
73 and fall back to modest_text_utils_utf8_strcmp (). The search logic
74 should now handle the corner case when the search term is spread
75 across multiple reads.
76 Also the logic in modest_search () was corrected to search all
77 requested fields until one is found.
79 2007-05-30 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
84 * src/modest-init.c: Made modest_init_local_folders() take a
85 path and be public so we can iniitialize maildir folders on
88 * src/modest-local-folder-info.h:
89 * src/modest-local-folder-info.c:
90 (modest_local_folder_info_get_maildir_path): Add a path parameter.
92 * src/modest-tny-account.c:
93 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
94 still means the standard local-folders path on the local volume.
96 * src/modest-tny-account-store.c:
97 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
98 signal so we can detect mount/unmount of the MMC1 card, and do an update of
99 all accounts when that happens.
100 (get_server_accounts): If the MMC1 card is mounted, create a store account for
101 this too, so it shows up in the treeview.
103 2007-05-28 Murray Cumming <murrayc@murrayc.com>
105 * src/maemo/modest-maemo-global-settings-dialog.c:
106 (current_connection):
107 * src/widgets/modest-global-settings-dialog.c:
108 (current_connection_default):
109 Use the enum values instead of 0, 1 and -1,
110 to make the code clearer.
112 * src/modest-account-mgr-helpers.c:
113 (modest_account_mgr_get_connection_specific_smtp): Make this code
116 * src/modest-runtime.h:
117 * src/modest-runtime.c:
118 Added modest_runtime_remove_all_send_queues().
119 * src/maemo/modest-main-window.c:
120 (on_account_store_connecting_finished): Recreate the send queues,
121 using the appropriate transport accounts for this new connection.
122 Some futher adapting might be needed if the old send queues are not
123 automatically stopped at this point.
125 * src/modest-tny-account-store.c: (get_server_accounts):
126 Create the connection-specific transport accounts, so that they can
127 be found later by their ID.
129 * src/modest-tny-account.h:
130 * src/modest-tny-account.c:
131 Added modest_tny_account_new_from_server_account_name().
132 modest_tny_account_new_from_server_account(): Do not create the
133 send queues here, because they will be
134 recreated anyway when the connection changes for the first time.
136 2007-05-28 Murray Cumming <murrayc@murrayc.com>
138 * src/modest-local-folder-info.h:
139 * src/modest-local-folder-info.c:
140 (modest_per_account_local_outbox_folder_info_get_maildir_path),
141 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
142 tbox_folder): Take a modest account name instead of a server TnyAccount,
143 so we can have per-modest-account rather than per-transport-account
145 We must make sure that we change or recreate the exisitng send queues
146 when the connection changes for connection-specific transport accounts.
148 * src/modest-tny-account-store.c:
149 (create_per_account_local_outbox_folders): Create outboxed per modest
150 account, not per transport account.
152 * src/modest-tny-account.h:
153 * src/modest-tny-account.c:
154 (modest_tny_account_get_special_folder): For outboxes, get the
155 parent modest account name. The account is ignored for other folders.
156 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
157 modest account name rather than a server TnyAccount.
159 2007-05-25 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-tny-account.c:
162 (modest_tny_account_new_from_server_account):
163 Call modest_runtime_get_send_queue() immediately after creating transport
164 accounts, so that they start trying to send email from the outbox as soon
165 as possible at startup. This is probably what we want.
167 * src/modest-mail-operation.c: (update_account_thread):
168 * src/modest-runtime.c: (modest_runtime_get_send_queue):
169 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
170 * src/modest-tny-send-queue.h:
171 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
172 (modest_ui_actions_on_send):
173 Added comments about how sending works, though it needs some more work.
175 2007-05-25 Murray Cumming <murrayc@murrayc.com>
177 * src/modest-tny-account.c:
178 (modest_tny_account_get_special_folder): Add TODO because this fails when
180 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
181 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
182 Do not try to show this window when there is no active account. The UI
183 specs does not tell us what to do in this case.
185 2007-05-24 Murray Cumming <murrayc@murrayc.com>
189 * src/maemo/Makefile.am:
190 * src/widgets/Makefile.am: Some dist fixes.
192 2007-05-24 Murray Cumming <murrayc@murrayc.com>
194 * src/maemo/modest-connection-specific-smtp-window.c:
195 (on_button_edit): Make the code clearer, to prevent a double free.
197 2007-05-24 Murray Cumming <murrayc@murrayc.com>
199 * src/maemo/modest-account-settings-dialog.c:
200 (modest_account_settings_dialog_set_account_name),
201 Check the connection-specific smtp servers checkbox if there are any.
203 * src/maemo/modest-connection-specific-smtp-edit-window.c:
204 (modest_connection_specific_smtp_edit_window_init):
205 Start with a suitable port number.
207 * src/modest-account-mgr-helpers.h:
208 * src/modest-account-mgr-helpers.c: Added
209 modest_account_mgr_get_has_connection_specific_smtp().
211 (modest_account_mgr_set_connection_specific_smtp),
212 (modest_account_mgr_remove_connection_specific_smtp),
213 (modest_account_mgr_get_has_connection_specific_smtp),
214 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
215 connection-specific smtp server accounts in the account, rather than
216 the server account conf dir.
218 This fixes bug projects.maemo.org bug NB#58263 .
220 * src/modest-tny-account-store.c:
221 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
222 if there are no server accounts yet, to prevent an infinite loop when there
223 are no accounts. Document that one must be called before the other.
225 2007-05-24 Murray Cumming <murrayc@murrayc.com>
227 * src/modest-account-mgr-helpers.c:
228 (modest_account_mgr_get_default_account): Make sure that at least
229 one account is always the default, if there are any enabled accounts.
230 This is just a sanity check that shouldn't be necessary.
232 * src/modest-account-mgr-priv.c:
233 (_modest_account_mgr_account_from_key): Unescape the conf key to
234 get the real account name. For instance, this is an issue if a space
235 was in the account name, which can happen because the account name
236 is generated from the display name.
237 (_modest_account_mgr_get_account_keyname): Always escape the
239 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
240 Unescape the conf keys to get the real account names.
242 For instance, previously the is-default radio button in the accounts
243 list was not checked for any accounts at first. This fixes that,
244 and might fix several similar bugs.
246 2007-05-23 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
249 Removed some debug printfs.
251 2007-05-23 Murray Cumming <murrayc@murrayc.com>
253 Modest on-disk outbox directories are now here, for instance:
254 $HOME/.modest/outboxes/<account-id-1>/outbox
255 $HOME/.modest/outboxes/<account-id-2>/outbox
257 $HOME/.modest/local-folders/outbox
258 so we can have a separate outbox for each account.
259 But they are shown as one outbox in the GtkTreeView, by using a
260 TnyMergeFolder in a ModestTnySimpleFolderStore.
263 * src/modest-tny-simple-folder-store.c:
264 * src/modest-tny-simple-folder-store.h:
265 Added ModestTnySimpleFolderStore, used to contain folders from
266 other folder stores, such as other accounts.
268 * src/modest-tny-outbox-account.h:
269 * src/modest-tny-outbox-account.c:
270 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
271 used for the per-account local outbox folders.
273 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
274 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
275 only use this (internally) now for the non-outbox local folders.
278 * src/modest-init.c: Added modest_init_one_local_folder(), for
279 setting up the directory structure for each local folder.
281 * src/modest-local-folder-info.c:
282 (modest_per_account_local_outbox_folder_info_get_maildir_path),
283 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
285 * src/modest-local-folder-info.h:
286 * src/modest-tny-account-store.c: (on_account_removed),
287 (on_account_changed), (create_per_account_local_outbox_folders),
288 (get_server_accounts), (modest_tny_account_store_get_accounts),
289 (modest_tny_account_store_get_tny_account_by_account),
290 (modest_tny_folder_store_is_virtual_local_folders):
292 * src/modest-tny-account.h:
293 * src/modest-tny-account.c:
294 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
295 to create an on-disk per-account local outbox folder for each
297 (create_per_account_local_outbox_folders): Create a local outbox folder
298 for each transport account.
299 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
300 for all local folders.
302 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
303 instead of using g_object_get/set() directly. It is clearer.
305 (modest_tny_folder_store_get_message_count),
306 (modest_tny_folder_store_get_local_size
307 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
308 because we now use these with non-acount folder stores.
310 (modest_tny_account_get_special_folder),
311 (modest_tny_account_new_from_server_account),
312 (modest_tny_account_new_from_account):
313 (recurse_folders): Adjust to the new outbox system.
315 * src/modest-tny-folder.h:
316 * src/modest-tny-folder.c:
317 (modest_tny_folder_is_local_folder),
318 (modest_tny_folder_get_local_folder_type),
319 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
321 * src/widgets/modest-main-window.h:
322 * src/maemo/modest-main-window.c: (create_details_widget),
323 (modest_main_window_set_contents_style): Show details for any folder store,
326 (modest_tny_folder_get_rules):
327 Remove the const. C does not support constness enough for this.
329 * src/modest-ui-actions.c:
330 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
331 make all outboxes appear as one, in the usual local-folders tree node.
333 (set_active_account_from_tny_account),
334 (modest_ui_actions_on_folder_selection_changed):
335 * src/widgets/modest-folder-view.c: (text_cell_data),
336 (icon_cell_data), (filter_row),
337 (add_account_folders_to_merged_folder),
338 (add_account_folders_to_simple_folder_store), (),
339 (get_cmp_rows_type_pos), (cmp_rows),
340 (modest_folder_view_set_account_id_of_visible_server_account):
341 Adjust to the new outbox system, using generic folder stores and folders
344 2007-05-23 Christian Kellner <ckellner@openismus.com>
346 * src/modest-mail-operation.c:
347 (modest_mail_operation_update_account):
348 Use info->max_size instead of unintialized local var [small
349 build fix]. (Added TODO to review that change since I don't
352 2007-05-23 Marcus Bauer <marcusb@openismus.com>
354 * libmodest-dbus-client/libmodest-dbus-client.c:
355 (libmodest_dbus_client_compose_mail): function added
356 * src/dbus_api/modest-dbus-api.h:
357 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
358 (on_compose_mail): Implementation of the SendAsMail functionality
360 2007-05-22 Murray Cumming <murrayc@murrayc.com>
362 * src/modest-account-mgr.c:
363 (modest_account_mgr_add_server_account): Set the secure-connection
364 conf key for transport accounts as well as store accounts. I don't know
365 why the if was there. For instance, this makes sure that we use SSL
366 for the gmail preset from the easysetup wizard.
368 2007-05-22 Murray Cumming <murrayc@murrayc.com>
370 * src/gnome/modest-main-window.c:
371 (on_account_store_connecting_finished), (connect_signals):
372 * src/maemo/modest-main-window.c:
373 (on_account_store_connecting_finished), (connect_signals),
374 (modest_main_window_new):
375 Handle TnyAccountStore::connecting-finished instead of
376 TnyDevice::connection-changed, because we cannot actually perform
377 operations on accounts until TnyAccountStore has itself responded to
378 the TnyDevice::connection-changed signal. This prevents a GError from
380 Do not try to update at startup, because we (at least on scratchbox)
381 already do an update at startup when the device goes online.
382 This prevents a GError from tinymail.
383 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
384 Added TODO about stopping simultaneous operations.
386 2007-05-21 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
389 * src/modest-mail-operation-queue.c:
390 (modest_mail_operation_queue_remove):
391 * src/modest-tny-account-store.c: When GErrors happen, give more clues
392 about where they happened.
394 2007-05-21 Murray Cumming <murrayc@murrayc.com>
396 * src/modest-ui-actions.c:
397 (modest_ui_actions_on_password_requested): Make sure that the remember
398 output parameter is always TRUE.
400 2007-05-21 Murray Cumming <murrayc@murrayc.com>
402 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
403 Show a OK/Cancel dialog if the error is a question, though we still do not
404 know anything more about what we are asking the user.
405 * src/widgets/modest-folder-view.c: (on_drag_data_received):
406 Fix an uninitialized variable (helper). This is a logic error, however.
408 2007-05-21 Christian Kellner <ckellner@openismus.com>
410 * src/modest-search.h:
411 Correct bit shifting in the ModestSearchFlags enum.
413 2007-05-21 Murray Cumming <murrayc@murrayc.com>
415 * src/modest-tny-account.c:
416 (modest_tny_account_new_from_server_account): Do not use the lsub and
417 check-all hard-coded IMAP options when using POP.
419 2007-05-21 Murray Cumming <murrayc@murrayc.com>
421 * src/modest-tny-account.c:
422 (modest_tny_account_new_from_server_account):
423 Use NULL for the secure-auth method for POP when Password auth has been
424 specified by the user, as we already do for IMAP. "auth=Login" causes
425 an error from camel or the server.
427 2007-05-17 Murray Cumming <murrayc@murrayc.com>
429 * src/maemo/modest-account-settings-dialog.c:
430 (create_page_account_details),
431 (modest_account_settings_dialog_set_account_name):
432 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
433 for the leave-on-server checkbox, rathr than just the checkbox, when
434 the protocol is not POP.
436 2007-05-17 Murray Cumming <murrayc@murrayc.com>
438 * src/widgets/modest-account-view.c:
439 * src/widgets/modest-account-view.h:
440 Added modest_account_view_select_account() which will be useful later
441 to asynchronously re-select the edited account.
443 2007-05-17 Murray Cumming <murrayc@murrayc.com>
445 * src/maemo/modest-account-settings-dialog.c:
446 (modest_account_settings_dialog_set_account_name):
447 Automatically choose the port numbers based on the secure authentication
448 methods, if they have not been chosen before.
449 This fixes projects.maemo.org bug NB#56273 .
451 2007-05-17 Murray Cumming <murrayc@murrayc.com>
453 * src/maemo/modest-main-window-ui.h:
454 * src/modest-ui-actions.c:
455 * src/modest-ui-actions.h:
456 Connect the Tools/SMTP Servers menu item to
457 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
458 SMTP servers dialog, as in the UI specification and saves changes when it
459 is closed. This fixed projects.maemo.org bug NB#56305 .
461 2007-05-17 Murray Cumming <murrayc@murrayc.com>
463 * src/maemo/modest-connection-specific-smtp-window.c:
464 (modest_connection_specific_smtp_window_init):
465 Use gtk_window_set_default_size() to make this window big enough, so
466 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
468 2007-05-17 Murray Cumming <murrayc@murrayc.com>
470 * src/maemo/modest-connection-specific-smtp-edit-window.h:
471 * src/maemo/modest-connection-specific-smtp-edit-window.c:
472 (modest_connection_specific_smtp_edit_window_init),
473 Do not try to connect to a combobox signal before the combobox exists.
474 This fixes the cras in projects.maemo.org bug NB#56288 .
475 (modest_connection_specific_smtp_edit_window_get_settings):
476 Remove the server_account_name parameter which was being checked for NULL
477 though it was not used.
479 * src/maemo/modest-connection-specific-smtp-window.c:
480 (modest_connection_specific_smtp_window_fill_with_connections),
481 (on_button_edit), (modest_connection_specific_smtp_window_init):
482 Correct the number of treemodel columns to prevent a warning.
483 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
484 libconic does not work.
486 2007-05-16 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-tny-account.c:
489 (modest_tny_account_new_from_server_account):
490 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
491 SMTP when "None" was chosen by the user. However, with my SMTP server that
492 does not support ANONYMOUS, the emails do not leave the Outbox and I see
495 2007-05-16 Murray Cumming <murrayc@murrayc.com>
497 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
498 to explain the memory management issue with the ID in the ModestPair.
500 * src/gnome/modest-account-assistant.c: (add_receiving_page),
501 (add_sending_page), (modest_account_assistant_finalize):
502 * src/gnome/modest-gnome-global-settings-dialog.c:
503 (create_updating_page), (create_composing_page):
504 * src/gnome/modest-msg-edit-window.c: (get_transports),
505 (init_window), (modest_msg_edit_window_finalize),
506 (modest_msg_edit_window_get_msg_data):
507 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
508 * src/gnome/modest-transport-widget.c:
509 (modest_transport_widget_finalize), (smtp_configuration):
510 * src/maemo/modest-maemo-global-settings-dialog.c:
511 (create_updating_page), (create_composing_page):
512 * src/maemo/modest-msg-edit-window.c: (get_transports),
513 (init_window), (modest_msg_edit_window_finalize),
514 (modest_msg_edit_window_get_msg_data),
515 (modest_msg_edit_window_free_msg_data):
516 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
517 (modest_store_widget_finalize):
518 * src/maemo/modest-transport-widget.c:
519 (modest_transport_widget_finalize), (smtp_configuration):
520 * src/modest-main.c: (send_mail):
521 * src/widgets/modest-combo-box.h:
522 * src/widgets/modest-global-settings-dialog-priv.h:
523 * src/widgets/modest-global-settings-dialog.c:
524 (modest_global_settings_dialog_finalize):
525 * src/widgets/modest-msg-edit-window.h:
526 Whenever using modest_combo_box_new(), keep the ModestPairList alive
527 as long as the combo box, to prevent use of freed memory for the ID.
529 2007-05-15 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
532 get_accounts(), to make this clearer. Do not check for the enabled gconf
533 key, because we do not use this for server accounts (at least, not yet).
534 This allows us to send email again.
536 2007-05-15 Murray Cumming <murrayc@murrayc.com>
538 * src/maemo/modest-platform.c:
539 (on_modest_conf_update_interval_changed), (modest_platform_init):
540 Only respond to this particular key change. All these strcmp()s cannot be
543 2007-05-15 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/modest-maemo-global-settings-dialog.c:
546 (current_connection): Prevent a crash in scratchbox when
547 ny_maemo_conic_device_get_current_iap_id() returns NULL.
548 * src/maemo/modest-platform.c:
549 (on_modest_conf_update_interval_changed), (modest_platform_init):
550 Get the update interval from gconf and reset it when the gconf key changes.
552 2007-05-15 Murray Cumming <murrayc@murrayc.com>
554 * src/modest-protocol-info.c:
555 * src/modest-protocol-info.h: Adde enum-specific get functions,
556 instead of using a ModestProtocolType enum parameter.
558 * src/gnome/modest-account-assistant.c:
559 * src/gnome/modest-store-widget.c:
560 * src/gnome/modest-store-widget.h:
561 * src/gnome/modest-transport-widget.c:
562 * src/gnome/modest-transport-widget.h:
563 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
564 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
565 * src/maemo/easysetup/modest-easysetup-wizard.c:
566 * src/maemo/modest-account-settings-dialog.c:
567 * src/maemo/modest-account-settings-dialog.h:
568 * src/maemo/modest-store-widget.c:
569 * src/maemo/modest-store-widget.h:
570 * src/maemo/modest-transport-widget.c:
571 * src/maemo/modest-transport-widget.h:
572 * src/modest-account-mgr-helpers.c:
573 * src/modest-account-mgr-helpers.h:
574 * src/modest-account-mgr.c:
575 * src/modest-account-mgr.h:
576 * src/modest-tny-account.c:
577 * src/modest-tny-folder.c:
578 * src/widgets/modest-account-view.c:
579 * src/widgets/modest-retrieve-combo-box.c:
580 * src/widgets/modest-retrieve-combo-box.h:
581 * src/widgets/modest-secureauth-combo-box.c:
582 * src/widgets/modest-serversecurity-combo-box.c:
583 * src/widgets/modest-serversecurity-combo-box.h:
584 * tests/check_account-mgr.c:
585 Use the specific functions, and use the re-renamed enum values for GNOME too.
587 2007-05-15 Murray Cumming <murrayc@murrayc.com>
590 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
591 so we can get the second based on the first.
593 * src/maemo/modest-account-settings-dialog.h:
594 * src/maemo/modest-account-settings-dialog.c:
595 Added get_supported_secure_authentication_methods(), though it is mostly
596 commented-out for now until the necessary API is committed to tinymail.
597 (modest_account_settings_dialog_set_account_name),
598 (save_configuration): Request the supported authentication methods from the
599 server, so we can choose a working method.
601 * src/modest-tny-account-store.h:
602 * src/modest-tny-account-store.c:
603 (modest_tny_account_store_get_session): Rename from
604 tny_account_store_get_session().
606 2007-05-14 Murray Cumming <murrayc@murrayc.com>
608 * src/modest-protocol-info.h: Split the ModestProtocol enum
609 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
610 There was no need to have these unrelated values in one enum.
612 * src/: many files: Adapted to changed enum. This makes the code a bit
613 clearer, and the compiler could catch some errors.
615 2007-05-14 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
618 Show the detailed internal camel error message when an error happens
619 during the configuration, so that our testers can give us more clues.
620 For instance, in projects.maemo.org bug NB#56910 .
622 2007-05-14 Murray Cumming <murrayc@murrayc.com>
624 * src/modest-tny-account.c:
625 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
626 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
628 2007-05-14 Murray Cumming <murrayc@murrayc.com>
630 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
631 * src/maemo/modest-account-settings-dialog.c:
632 (modest_account_settings_dialog_set_account_name),
633 (save_configuration): For the incoming secure authentication checkbox,
634 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
635 the UI specification. PLAIN does not seem to be supported for most IMAP
636 servers anyway, and I am not sure what it would mean.
637 However, we probably need to discover which of the secure-authentication
638 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
639 * src/modest-account-mgr-helpers.c:
640 (modest_account_mgr_get_server_account_data):
642 * src/modest-tny-account.c:
643 (modest_tny_account_new_from_server_account):
644 Use tny_account_set_mech() to set secure-authentication methods,
645 with some special-casing for IMAP, based on my observations of how
648 * src/modest-account-mgr-helpers.h:
649 * src/modest-account-mgr.c:
650 * src/modest-defs.h: Comment that the URI is only used for local folders.
652 2007-05-11 Murray Cumming <murrayc@murrayc.com>
654 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
655 parameter const, just to be neat.
656 * src/modest-text-utils.c: (modest_text_utils_inline):
657 End g_strconcat() with NULL, as its documentation says. This is almost
658 certainly the cause of my crash at startup on the device. Interestingly,
659 valgrind doesn't tell us about these errors.
661 2007-05-11 Murray Cumming <murrayc@murrayc.com>
663 * scripts/build-packages: Added more precise comments about how to use
664 this script, though I still get this error:
665 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
666 error building tinymail
668 2007-05-11 Murray Cumming <murrayc@murrayc.com>
670 * src/maemo/modest-main-window.c: (on_account_update):
671 Very slight cleanup, hoping to make it simpler to discover what causes
672 a crash here sometimes.
674 * src/modest-tny-account.c:
675 (modest_tny_account_new_from_server_account): Set the port. Added
676 comments about the options and a TODO comment because I need to find out
677 how to specify the secure authentication method.
679 2007-05-11 Marcus Bauer <marcusb@openismus.com>
681 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
682 changed CFlags paths form modest to libmodest
684 2007-05-10 Murray Cumming <murrayc@murrayc.com>
686 * src/modest-account-mgr-helpers.c:
687 (modest_account_mgr_get_server_account_data),
688 (modest_account_mgr_free_server_account_data):
689 * src/modest-account-mgr-helpers.h:
690 * src/modest-account-mgr.c:
691 (modest_account_mgr_add_server_account):
693 * src/modest-tny-account.c:
694 (modest_tny_account_new_from_server_account):
695 Determine the options for tny_camel_account_add_option() here,
696 based on the settings, rather than storing them directly in gconf.
698 2007-05-10 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
701 Show a more friendly error dialog now that we expect (from the tinymail
702 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
704 2007-05-10 Murray Cumming <murrayc@murrayc.com>
706 * src/maemo/modest-main-window.c: (on_account_update): Check that
707 account_name is not NULL, to prevent a crash at startup that I am
708 seeing on the N800. I do wonder why it is NULL.
710 * src/maemo/easysetup/modest-easysetup-wizard.c:
711 (create_page_user_details):
712 * src/maemo/modest-account-settings-dialog.c:
713 (create_page_user_details), (create_page_outgoing):
714 * src/maemo/modest-connection-specific-smtp-edit-window.c:
715 (modest_connection_specific_smtp_edit_window_init):
716 * src/modest-ui-actions.c:
717 (modest_ui_actions_on_password_requested):
718 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
719 might do something useful with the on-screen keyboard.
721 2007-05-10 Murray Cumming <murrayc@murrayc.com>
723 * src/maemo/modest-main-window.c: (on_account_update):
724 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
725 NULL, to avoid lots of warnings. However, it probably should not be NULL.
727 2007-05-09 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-tny-account-store.c: (on_account_changed):
730 Correct the signature of this signal handler.
732 2007-05-09 Murray Cumming <murrayc@murrayc.com>
734 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
735 Show a HildonNote instead of a GtkDialog for Maemo.
737 2007-05-09 Murray Cumming <murrayc@murrayc.com>
739 * src/widgets/modest-account-view.h:
740 * src/widgets/modest-account-view.c: (on_account_changed),
741 (on_account_removed). Added a boolean flag, set/unset by
742 modest_account_view_block_conf_updates(),
743 modest_account_view_unblock_conf_updates() to prevent unnecessary
744 updates, but this is not very useful because the gconf notifications are
745 so delays (maybe only on Maemo Bora).
746 So auto-updating is turned off, and these functions do an explicit
747 update when necessary.
748 However, something else is still doing too much work when adding/removing
749 accounts, probably in another part of the application.
751 * src/maemo/modest-account-view-window.c:
752 (on_delete_button_clicked), (on_edit_button_clicked),
753 (on_new_button_clicked): Use the new functions.
755 2007-05-09 Murray Cumming <murrayc@murrayc.com>
757 * src/modest-account-mgr-helpers.c:
758 (modest_account_mgr_set_first_account_as_default):
759 Sort the list of names alphabetically-by-title, so we choose the first one
761 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
762 alphabetically by the title.
764 This fixes projects.maemo.org bug NB#56418 .
766 * src/modest-account-mgr-priv.c:
767 (_modest_account_mgr_account_from_key):
768 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
769 avoid a valgrind error, and possible random behaviour.
771 2007-05-09 Murray Cumming <murrayc@murrayc.com>
773 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
774 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
775 tinymail documentation to say that this can be expected.
776 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
777 pretty, and should not happen, but I would prefer to know when it does.
779 2007-05-09 Murray Cumming <murrayc@murrayc.com>
781 * configure.ac: When using the older hildon version, probably on Bora,
782 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
784 * src/widgets/modest-attachment-view.c:
785 (modest_attachment_view_set_part_default): Initialize variables, to fix the
788 2007-05-09 Marcus Bauer <marcusb@openismus.com>
790 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
791 Implemented the prototype. Can be tested with
792 tests/dbus_api/test_open_message:
794 2007-05-08 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-tny-account-store.c:
797 (modest_tny_account_store_instance_init), (get_password):
798 * src/modest-ui-actions.c:
799 (modest_ui_actions_on_password_requested):
800 Do not store the password in gconf, because this function is called
801 for non-remembered passwords. Actually use the cached (in the hash map)
802 password instead of releasing it.
803 The password will now not be remembered if it is asked via the protected
804 password dialog, as per the UI spec.
806 2007-05-08 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-account-mgr-helpers.h:
810 * src/modest-account-mgr-helpers.c:
811 Added modest_server_account_get_username_has_succeeded(),
812 modest_server_account_set_username_has_succeeded().
813 (modest_server_account_set_username),
814 Reset the has-succeeded flag if the username changes.
816 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
817 * src/maemo/modest-connection-specific-smtp-window.c:
818 (modest_connection_specific_smtp_window_save_server_accounts):
819 Use modest_server_account_set_username() instead of using
820 modest_conf_set_string() directly, so that the has-succeeded flag is always
823 * src/modest-ui-actions.c:
824 (modest_ui_actions_on_password_requested): Dim the username entry if
825 the username has ever worked, as per the UI spec.
827 2007-05-08 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-tny-account-store.c: (get_password):
830 * src/modest-ui-actions.c:
831 (modest_ui_actions_on_password_requested):
832 Allow the username to be changed too, though there is more work to
833 be done on exactly how this behaves.
835 2007-05-08 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-account-mgr-helpers.h:
838 * src/modest-account-mgr-helpers.c:
839 Added modest_account_mgr_get_display_name(),
840 modest_server_account_get_username(),
841 modest_server_account_set_username(),
842 modest_server_account_set_password(),
843 modest_server_account_get_hostname() functions so we do not need to
844 use the conf API directly.
846 * src/maemo/modest-main-window.c: (connect_signals):
847 Actually connect ot the ModestAccountStore::request-password signal,
848 so that we show the dialog when the password is requested by Tinymail,
849 for isntance if it is empty.
851 * src/modest-marshal.list:
852 * src/modest-tny-account-store.c:
853 (modest_tny_account_store_class_init), (get_password),
854 (modest_tny_account_store_alert):
855 * src/modest-tny-account-store.h:
856 * src/modest-ui-actions.h:
857 * src/modest-ui-actions.c:
858 (modest_ui_actions_on_password_requested):
859 Change the signal parameters, so it is obvious that we are providing
860 the non human-readable server name, and receiving both the username
861 and password, though changing of the username is not yet implemented.
862 Change the dialog UI to match the Maemo UI specifications, with #idfefing
863 for the GNOME version.
865 This should fix the projects.maemo.org bug NB#56209, though it does not
866 work on Bora, because the gconf_client_get() for the password fails
867 immediately after we save it with gconf_client_set().
869 2007-05-08 Murray Cumming <murrayc@murrayc.com>
872 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
873 caused an undefined symbol error:
874 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
876 2007-05-08 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-tny-account-store.c:
879 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
880 using a GError instead of a string message, so we can translate it in
883 2007-05-08 Murray Cumming <murrayc@murrayc.com>
885 * src/maemo/modest-address-book.c:
886 (modest_address_book_check_names):
887 * src/maemo/modest-msg-view-window.c:
888 (modest_msg_view_window_clipboard_owner_change):
889 * src/modest-init.c: (modest_init_init_ui):
890 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
891 (update_folders_cb), (modest_mail_operation_update_account):
892 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
893 (modest_ui_actions_on_msg_attachment_clicked),
894 (modest_ui_actions_on_msg_recpt_activated):
895 * src/widgets/modest-header-view.c: (drag_data_get_cb):
896 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
897 (modest_msg_view_search_next):
898 * src/widgets/modest-recpt-editor.c:
899 (modest_recpt_editor_on_button_release_event),
900 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
901 g_message(). At this point we should only be seeing interesting errors on
902 stdout. Debugging messages could be #ifdefed-out if they are still useful.
904 2007-05-07 Murray Cumming <murrayc@murrayc.com>
906 (modest_wizard_dialog_force_title_update):
907 * src/maemo/easysetup/modest-wizard-dialog.h:
908 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
909 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
910 can update the title when appropriate. Otherwise the title is wrong if the
911 pages are added after adding the notebook to the dialog.
912 This must be a problem in HildonWizardDialog too.
913 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
915 * src/maemo/easysetup/modest-easysetup-wizard.c:
916 (create_subsequent_customsetup_pages),
917 (create_subsequent_easysetup_pages):
918 Call modest_wizard_dialog_force_title_update() so that the title is
919 correct even with GTK+ < 2.10.
920 This fixes projects.maemo.org bug NB#56145 .
922 2007-05-07 Murray Cumming <murrayc@murrayc.com>
924 * src/maemo/modest-platform.c:
925 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
926 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
929 2007-05-07 Murray Cumming <murrayc@murrayc.com>
931 * src/widgets/modest-window.h:
932 * src/widgets/modest-window.c: Added a save_state_func vfunc,
933 and modest_window_save_state(), which invokes it.
935 * src/widgets/modest-window-mgr.h:
936 * src/widgets/modest-window-mgr.c:
937 Added modest_window_mgr_save_state_for_all_windows(), which calls
938 the save_state vfunc on all registered windows, if implemented.
940 * src/gnome/modest-msg-edit-window.c:
941 * src/gnome/modest-msg-view-window.c:
942 * src/maemo/modest-msg-edit-window.c:
943 * src/maemo/modest-msg-view-window.c:
944 * src/maemo/modest-main-window.c:
945 Specify the existing save_settings functions as implementations of
946 ModestWindow::save_state_func().
948 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
949 Call modest_window_mgr_save_state_for_all_windows(). This happens before
950 enabling hibernation, for instance.
952 We may need to do the same thing for restoring settings.
955 2007-05-07 Murray Cumming <murrayc@murrayc.com>
957 * src/widgets/modest-window-mgr.c:
958 * src/widgets/modest-window-mgr.h:
959 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
960 modest_window_mgr_get_hibernation_is_prevented().
962 * src/maemo/modest-main-window.c:
963 (on_hildon_program_is_topmost_notify): Prevent hibernation
964 (possible when the application goes to the background in the WM),
965 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
967 * src/maemo/easysetup/modest-easysetup-wizard.c:
968 (modest_easysetup_wizard_dialog_init):
969 * src/maemo/modest-account-settings-dialog.c:
970 (modest_account_settings_dialog_init):
971 * src/maemo/modest-connection-specific-smtp-edit-window.c:
972 (modest_connection_specific_smtp_edit_window_init):
973 * src/maemo/modest-connection-specific-smtp-window.c:
974 (modest_connection_specific_smtp_window_init):
975 * src/maemo/modest-signature-editor-dialog.c:
976 (modest_signature_editor_dialog_init):
977 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
978 prevent hibernation while any of these account settings dialogs are open.
980 2007-05-04 Murray Cumming <murrayc@murrayc.com>
982 * src/maemo/Makefile.am:
983 * src/maemo/modest-osso-state-saving.c:
984 * src/maemo/modest-osso-state-saving.h: Added
985 modest_osso_load_state() and modest_osso_save_state() though they do
986 nothing now. They should iterate through all the open windows and load/save
988 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
989 save state when closing.
991 * src/maemo/modest-main-window.c:
992 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
993 Add a notification handler for the HildonProgram::is-topmost property,
994 so we can allow hibernation when the application goes into the background.
995 But we still need to detect when the accounts setup windows are open so
996 we can stop hibernation when they are open.
997 To do this, I also added the main window the HildonProgram. This might have
998 other side-effects/benefits, and should maybe be done for other windows.
1000 * src/maemo/modest-osso-autosave-callbacks.h:
1001 * src/maemo/modest-osso-autosave-callbacks.c:
1002 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1003 though it does not do anything yet, and we might never need this to do
1004 anything. For instance, we already save drafts.
1006 * src/maemo/modest-platform.c: (modest_platform_init):
1007 Specify the libosso auto-save callback.
1009 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1011 * src/maemo/modest-platform.c:
1012 (modest_platform_set_update_interval):
1013 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1014 aparently stays valid between application instances, so we can use this
1015 to remove and reset it later. According to a maemo-developers email from
1018 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1020 * configure.ac: Depend on libalarm for Maemo.
1022 * src/dbus_api/modest-dbus-api.h:
1023 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1024 (on_send_receive), (modest_dbus_req_handler):
1025 Handle a SEND_RECEIVE D-Bus method.
1027 * libmodest-dbus-client/libmodest-dbus-client.c:
1028 (libmodest_dbus_client_send_and_receive):
1029 * libmodest-dbus-client/libmodest-dbus-client.h:
1030 Add C convenience functions for calling the new D-Bus method.
1032 * src/modest-platform.h:
1033 * src/gnome/modest-platform.c:
1034 * src/maemo/modest-platform.c:
1035 Added modest_platform_set_update_interval(), which uses the
1036 alarmd API on Maemo.
1037 (modest_platform_init),
1038 Call modest_platform_set_update_interval(), using a hard-coded
1039 interval for now (until the global settings dialog is implemented),
1040 though I am not sure that this makes sense yet.
1042 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1044 * src/dbus_api/modest-dbus-callbacks.c:
1045 (modest_osso_cb_hw_state_handler):
1046 * src/dbus_api/modest-dbus-callbacks.h:
1047 * src/maemo/modest-platform.c: (modest_platform_init):
1048 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1049 in case this has some effect on the ability for Maemo to ping the
1052 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1054 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1055 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1056 warning. It is probably a logic error, but I need to fix the build.
1058 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1060 * src/modest-account-mgr.h:
1061 * src/modest-account-mgr.c:
1062 (modest_account_mgr_account_names): Add a gboolean enabled_only
1063 parameter, so we can get lists of onlt the enabled accounts.
1065 (modest_account_mgr_add_account),,
1066 (modest_account_mgr_account_with_display_name_exists):
1067 * src/maemo/modest-msg-edit-window.c: (get_transports):
1068 * src/modest-account-mgr-helpers.c:
1069 (modest_account_mgr_set_first_account_as_default):
1070 * src/modest-init.c: (init_default_account_maybe):
1071 * src/modest-tny-account-store.c: (get_accounts):
1072 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1073 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1074 * tests/check_account-mgr.c: (START_TEST):
1075 Provide the extra parameter, as appropriate.
1077 * src/widgets/modest-account-view.c: (update_account_view):
1078 Do not show disabled accounts (meaning that there is no way to
1079 enable/disable accounts in the UI (the feature is not in our UI
1080 specification), so we can use this internally only to mark unfinished
1081 or temporary account data.
1083 * src/maemo/easysetup/modest-easysetup-wizard.c:
1084 (create_account): Add boolean enable parameter, so we can specify FALSE
1085 to create the temporary account.
1086 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1087 (on_before_next): When finishing, when there is a temporary account, just
1089 Also, use a timeout to delay the showing of the dialog until gconf is likely
1090 to return correct information, due to a maemo gconf bug that is fixed in
1091 osso 1.1, but not yet in Bora.
1092 However, the dialog stays on screen after it is destroyed.
1094 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1095 for invalid data when cancelling. Use a hildon note instead of a dialog
1096 to complain about invalid data. Do not show the account-saved note if the
1097 account is disabled (a temporary account that will not really be saved for use
1100 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1102 * src/modest-account-mgr-helpers.h:
1103 * src/modest-account-mgr-helpers.c:
1104 Added modest_account_mgr_unset_default_account(),
1105 Added modest_account_mgr_set_first_account_as_default().
1107 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1108 If it was the default account, unset the default account name.
1110 * src/maemo/modest-account-view-window.c:
1111 (on_delete_button_clicked): If it was the default account,
1112 set the first remaining account as the default instead.
1114 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1115 a NULL account or a NULL default account, to prevent a crash. This should
1116 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1119 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1121 * src/widgets/modest-recpt-editor.c:
1122 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1123 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1124 TODO comment for this. This fixes the build.
1126 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1127 be the best place for it. This will in future update all auto-update accounts,
1128 rather than just the current/default account, when that gconf key exists.
1129 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1130 if there are no accounts, before calling do_send_receive().
1131 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1133 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1134 * src/maemo/modest-main-window-ui.h:
1135 * src/maemo/modest-main-window.c: (on_connection_changed),
1136 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1137 directly, becaue the signal handler does more.
1139 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-account-mgr-helpers.c:
1142 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1143 for the case that the account does not exist.
1145 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1146 (equivalent to the modest account name) rather than the tinymail account name
1147 (equivalent to the modest account title - human readable) to get the account data.
1148 Check for null account data to prevent the crash, and add a TODO comment saying that
1149 this needs fixing because it is using the server account name instead of the account name.
1151 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1153 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1154 * src/maemo/modest-account-settings-dialog.c: (show_error),
1156 Use hildon_note_new_information() for informative and error messages,
1157 which seems to be expected for Maemo applications (no documentation that I know of
1158 says this). I am surprised that there is no distinction between info and error
1161 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1163 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1164 it is easy to find where this is used.
1166 * src/maemo/easysetup/modest-easysetup-wizard.c:
1167 (create_page_welcome), (create_page_account_details),
1168 (create_page_user_details), (create_page_complete_easysetup),
1169 (create_page_custom_incoming), (create_page_custom_outgoing),
1170 (create_page_complete_custom):
1171 * src/maemo/modest-account-settings-dialog.c:
1172 (create_page_account_details), (create_page_user_details),
1173 (create_page_incoming), (create_page_outgoing):
1174 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1175 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1176 (modest_connection_specific_smtp_edit_window_init):
1177 * src/maemo/modest-connection-specific-smtp-window.c:
1178 (modest_connection_specific_smtp_window_init):
1179 * src/maemo/modest-signature-editor-dialog.c:
1180 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1181 and scrolling policy as per the Email Application Layout Guide, if I have
1184 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1186 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1187 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1188 which were empty, because these vfuncs have been removed from TnyAccountStore.
1189 This fixes the build.
1191 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1193 * src/maemo/modest-main-window.c:
1194 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1195 showing/hiding it. Added TODO because it probably should not be NULL.
1196 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1197 because unnecessary g_warnings() make degugging difficult.
1199 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1201 * src/maemo/modest-msg-edit-window.c:
1202 (modest_msg_edit_window_select_color),
1203 (modest_msg_edit_window_select_background_color): 2 const corrections and
1204 moving 2 #endifs before closing brackets, to fix the build.
1206 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1208 * src/maemo/easysetup/modest-easysetup-wizard.h:
1209 * src/maemo/easysetup/modest-easysetup-wizard.c:
1210 (modest_easysetup_wizard_dialog_finalize),
1211 (on_button_edit_advanced_settings), (create_page_complete_custom),
1212 (on_response), (create_account):
1213 Implement the Advanced Settings edit button, by saving the account information,
1214 for the Advanded Settings dialog to use directly from gconf, and removing it
1215 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1216 Bug #5533 in the projects.maemo.org bugzilla.
1218 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1220 * src/maemo/modest-msg-view-window.c:
1221 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1222 when opening a message window.
1224 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1226 * src/maemo/easysetup/modest-easysetup-wizard.c:
1227 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1230 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1231 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1232 gconf settings. I probably added more checks than necessary, but that is safer.
1234 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1235 variable to fix the build, but this seems to be used when it is still NULL.
1237 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1239 * src/modest-platform.h:
1240 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1241 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1242 * src/modest-main.c: Implement this function so we can avoid using
1243 maemo-specific API from cross-platform code.
1245 * src/modest-tny-account-store.c:
1246 (get_smtp_specific_transport_account_for_open_connection):
1247 * src/modest-ui-actions.c: (check_for_connection),
1248 (modest_ui_actions_on_item_not_found):
1249 Use modest_platform_connect_and_wait() and put #idefs around other
1250 maemo-specific code, because only maemo currently has a way to
1251 identify connection names.
1253 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-tny-account-store.h:
1256 * src/modest-tny-account-store.c:
1257 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1258 the connection-specific SMTP server settings in the configuration.
1260 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1262 * src/maemo/modest-main-window.c: (on_connection_changed),
1264 * src/modest-main.c: (main), (start_ui), (send_mail):
1265 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1266 that is what is intended.
1268 * src/modest-ui-actions.c: (action_send), (action_receive),
1269 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1270 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1271 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1272 SMTP server is used when it is specified.
1274 (modest_ui_actions_on_send_receive):
1275 Check that a connection is open before proceeding.
1276 Receive and then send, instead of vice-versa, as per the specification.
1278 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1280 * src/modest-mail-operation.c:
1281 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1282 though I guess it should be something other than NULL.
1284 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1286 * src/maemo/easysetup/modest-easysetup-wizard.c:
1287 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1288 combo twice, to avoid an g_warning and to make it visible again.
1289 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1290 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1291 (already intended) dereference when detaching, because we then recreate the menu.
1292 But I am not sure why the warning was happening, and it is possible that this is a memory
1295 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1297 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1298 and uri_parse_mailto() utility functions.
1299 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1301 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1303 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1305 * src/dbus_api/modest-dbus-api.h:
1306 * src/dbus_api/modest-dbus-callbacks.c:
1307 Use an idle callback to execute the modest code in the application's own thread.
1308 Remove the helloworld example method.
1309 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1310 parsed, and the open-message method is not implemented because this is not yet implemented in
1312 * libmodest-dbus-client/libmodest-dbus-client.c:
1313 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1314 (libmodest_dbus_client_open_message):
1315 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1317 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1318 body without crashing.
1320 * tests/dbus_api/Makefile.am:
1321 * tests/dbus_api/test_mail_to.c:
1322 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1324 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1326 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1327 Added file to fix the build. Sorry.
1329 * src/dbus_api/Makefile.am:
1330 * src/dbus_api/modest-dbus-api.h:
1331 * src/dbus_api/modest-dbus-callbacks.h:
1332 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1333 (modest_dbus_req_handler):
1334 Put constants in a separate header so it can be reused by the
1335 client library, without duplication
1337 * libmodest-dbus-client/Makefile.am:
1338 * libmodest-dbus-client/libmodest-dbus-client.c:
1339 (libmodest_dbus_client_call_helloworld),
1340 (libmodfest_dbus_client_send_mail),
1341 (libmodfest_dbus_client_mailto),
1342 (libmodfest_dbus_client_open_message):
1343 * libmodest-dbus-client/libmodest-dbus-client.h:
1344 (Partly) Implement a send_mail D-Bus method.
1346 * tests/dbus_api/Makefile.am:
1347 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1348 the send_email D-Bus method.
1350 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1354 * libmodest-dbus-client/Makefile.am:
1355 * libmodest-dbus-client/libmodest-dbus-client.c:
1356 * libmodest-dbus-client/libmodest-dbus-client.h:
1357 * tests/dbus_api/Makefile.am:
1358 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1359 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1361 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1363 * src/maemo/easysetup/modest-easysetup-wizard.c:
1364 (create_page_account_details):
1365 * src/maemo/modest-account-settings-dialog.c:
1366 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1367 widgets, because this might not be the default in future versions of the Maemo GTK+.
1368 However, I can not not get capitalization to work even in a simple test case.
1370 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1372 * src/maemo/easysetup/modest-easysetup-wizard.c:
1373 (create_page_custom_incoming), (create_page_custom_outgoing):
1374 * src/maemo/modest-account-settings-dialog.c:
1375 (create_page_account_details), (create_page_incoming),
1376 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1377 instead of using gtk_check_button_with_label(), so they are aligned like the other
1378 widgets, as per the UI spec.
1380 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1382 * src/maemo/easysetup/modest-easysetup-wizard.c:
1383 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1384 * src/widgets/modest-validating-entry.c:
1385 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1386 Modest prefix instead of an EasySetup prefix.
1388 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1390 * src/widgets/modest-validating-entry.h:
1391 * src/widgets/modest-validating-entry.c: (on_insert_text),
1392 Added easysetup_validating_entry_set_max_func(), used to set a callback
1393 to call when the max number of characters is reached. GtkEntry has a max-length
1394 already but is silent about it.
1396 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1397 (create_page_account_details), (create_page_user_details),
1399 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1400 (create_page_account_details), (create_page_user_details),
1401 (create_page_outgoing):
1402 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1403 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1404 the UI spec, when the user tries to enter more than the max number of characters.
1406 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1408 * src/maemo/easysetup/modest-easysetup-wizard.c:
1409 (create_page_user_details), (create_page_custom_incoming),
1410 (create_page_custom_outgoing):
1411 * src/maemo/modest-account-settings-dialog.c:
1412 (create_page_user_details), (create_page_incoming),
1413 (create_page_outgoing):
1414 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1415 (modest_connection_specific_smtp_edit_window_init):
1416 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1417 not appropriate. Bad Maemo-specific defaults!.
1419 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1421 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1422 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1423 (modest_signature_editor_dialog_set_settings):
1424 Disable the label and textview when the checkbox is disabled, and use the
1425 specified (UI spec) default signature text.
1427 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1429 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1430 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1432 * src/modest-defs.h:
1433 * src/modest-account-mgr-helpers.h:
1434 * src/modest-account-mgr-helpers.c:
1435 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1437 * src/maemo/Makefile.am:
1438 * src/maemo/modest-signature-editor-dialog.c:
1439 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1442 * src/maemo/modest-account-settings-dialog.h:
1443 * src/maemo/modest-account-settings-dialog.c:
1444 (modest_account_settings_dialog_finalize), (on_button_signature),
1445 (save_configuration): Use the new dialog when the Edit button is pressed, and
1446 save the changes if necessary, as per the UI spec.
1448 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1450 * src/maemo/Makefile.am:
1451 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1452 based on maemo-develoers email from Dirk.
1454 * src/maemo/easysetup/modest-easysetup-wizard.c:
1455 (create_page_welcome), (create_page_account_details),
1456 (create_page_user_details), (create_page_complete_easysetup),
1457 (create_page_custom_incoming), (create_page_custom_outgoing),
1458 (create_page_complete_custom),
1459 (modest_easysetup_wizard_dialog_init):
1460 * src/maemo/modest-account-settings-dialog.c:
1461 (create_page_account_details), (create_page_user_details),
1462 (create_page_incoming), (create_page_outgoing),
1463 (modest_account_settings_dialog_init):
1464 * src/maemo/modest-connection-specific-smtp-window.c:
1465 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1467 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1469 * src/maemo/easysetup/modest-easysetup-wizard.c:
1470 (create_page_account_details), (create_page_custom_outgoing),
1471 (create_page_complete_custom):
1472 * src/maemo/modest-account-settings-dialog.c:
1473 (create_page_user_details), (create_page_incoming),
1474 (create_page_outgoing):
1475 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1476 (modest_connection_specific_smtp_edit_window_init):
1477 Use the correct (UI spec) port min/max, and use horizontal separators,
1480 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1482 * src/maemo/easysetup/modest-easysetup-wizard.c:
1483 (set_default_custom_servernames):
1484 * src/maemo/modest-account-settings-dialog.c:
1485 (create_page_incoming), (on_combo_outgoing_security_changed),
1486 (on_combo_incoming_security_changed), (create_page_outgoing),
1487 (modest_account_settings_dialog_set_account_name),
1488 (save_configuration):
1489 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1490 (on_combo_security_changed),
1491 (modest_connection_specific_smtp_edit_window_init),
1492 (modest_connection_specific_smtp_edit_window_set_connection),
1493 (modest_connection_specific_smtp_edit_window_get_settings):
1494 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1497 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1500 * src/maemo/easysetup/modest-easysetup-wizard.c:
1501 (create_page_custom_outgoing), (create_page_complete_custom):
1502 * src/maemo/modest-account-settings-dialog.c:
1503 (create_page_user_details), (create_page_outgoing):
1504 * src/maemo/modest-account-view-window.c: (button_box_new):
1505 Use changed logical IDs as per the most recent UI spec:
1506 mcen_bd_emailsetup_edit -> mcen_bd_edit
1507 mcen_bd_emailsetup_delete -> mcen_bd_delete
1508 mcen_bd_emailsetup_close -> mcen_bd_close
1510 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1514 * src/dbus_api/Makefile.am:
1515 * src/dbus_api/modest-dbus-callbacks.c:
1516 * src/dbus_api/modest-dbus-callbacks.h:
1517 * src/maemo/modest-platform.c: (modest_platform_init):
1518 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1520 * tests/Makefile.am:
1521 * tests/dbus_api/Makefile.am:
1522 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1524 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1526 * src/maemo/modest-account-settings-dialog.c:
1527 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1528 Removed unnecessary includes.
1530 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1532 * src/maemo/easysetup/modest-easysetup-wizard.c:
1533 * src/maemo/modest-account-settings-dialog.c:
1534 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1535 * src/widgets/Makefile.am:
1536 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1537 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1538 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1539 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1540 * src/widgets/modest-secureauth-combo-box.c:
1541 * src/widgets/modest-secureauth-combo-box.h:
1542 * src/widgets/modest-serversecurity-combo-box.c:
1543 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1544 made the GObject names more consistent with the rest of the Modest code.
1546 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1548 * src/maemo/easysetup/Makefile.am:
1549 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1550 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1551 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1552 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1553 * src/maemo/easysetup/modest-easysetup-wizard.c:
1554 * src/maemo/easysetup/modest-validating-entry.c:
1555 * src/maemo/easysetup/modest-validating-entry.h:
1556 * src/maemo/modest-account-settings-dialog.c:
1557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1558 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1559 widgets/ because they are used outside of easysetup too. After checking in,
1560 svn will allow me to rename them too.
1562 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1564 * src/gnome/modest-msg-edit-window.c:
1565 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1566 linker error, to fix the build on the GNOME platform.
1567 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1568 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1569 ifdefed out to avoid a warning.
1571 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1573 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1574 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1575 some alternative for GTK+ 2.6.
1577 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1579 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1581 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1582 specified for EmailAccountsDialog in UI spec.
1584 * src/maemo/easysetup/modest-easysetup-wizard.c:
1585 * src/maemo/easysetup/modest-easysetup-wizard.h:
1586 * src/maemo/modest-account-settings-dialog.c:
1587 * src/maemo/modest-account-settings-dialog.h:
1588 Reuse a member window widget for the connection-specific SMTP server accounts,
1589 so we can tell it to create/save the accounts only if we actually save changes.
1591 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1592 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1593 (modest_connection_specific_smtp_edit_window_get_settings):
1594 Return a struct instance for temporarily remembering the entered data.
1596 * src/maemo/modest-connection-specific-smtp-window.h:
1597 * src/maemo/modest-connection-specific-smtp-window.c:
1598 (modest_connection_specific_smtp_window_finalize),
1599 (modest_connection_specific_smtp_window_fill_with_connections),
1601 (modest_connection_specific_smtp_window_save_server_accounts),
1602 (update_model_server_names): Do not actually save data until asked,
1603 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1605 (on_selection_changed),
1606 (modest_connection_specific_smtp_window_init): Disable the edit
1607 button when nothing is selected.
1609 * src/modest-account-mgr-helpers.c:
1610 * src/modest-account-mgr-helpers.h:
1611 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1614 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1616 * src/modest-account-mgr-helpers.h:
1617 * src/modest-account-mgr-helpers.c:
1618 (modest_account_mgr_get_unused_account_name),
1619 (modest_account_mgr_get_unused_account_display_name): Added these
1620 utility functions, to avoid code duplication.
1622 * src/maemo/easysetup/modest-easysetup-wizard.c:
1623 (create_page_account_details), (create_account):
1624 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1625 (on_combo_security_changed),
1626 (modest_connection_specific_smtp_edit_window_init),
1627 (modest_connection_specific_smtp_edit_window_save_settings):
1628 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1629 * src/maemo/modest-connection-specific-smtp-window.c:
1630 (modest_connection_specific_smtp_window_finalize),
1631 (modest_connection_specific_smtp_window_fill_with_connections),
1632 (on_button_edit), (modest_connection_specific_smtp_window_init):
1633 * src/maemo/modest-connection-specific-smtp-window.h:
1634 Implementing saving of connection-specific server accounts.
1636 But I need to refactor this so we can save the data for each
1637 possible connection-specific account and only actually create the server accounts
1638 when the easysetup finished, or the OK button is pressed on the account settings
1641 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1644 (on_combo_security_changed):
1645 (modest_connection_specific_smtp_edit_window_init):
1646 Auto-fill the port number as in the account settings.
1648 (modest_connection_specific_smtp_edit_window_set_connection):
1649 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1650 * src/maemo/modest-connection-specific-smtp-window.c:
1651 (fill_with_connections), (on_button_edit),
1652 (modest_connection_specific_smtp_window_init):
1653 Turn the edit window into a dialog to simplify the code, and
1654 set a WM hint as in a GtkDialog, because only a popup can be on top of
1655 another window in Maemo, and popups usually have no WM decoration.
1657 * src/modest-defs.h:
1658 * src/modest-account-mgr-helpers.c:
1659 (modest_account_mgr_set_connection_specific_smtp),
1660 (modest_account_mgr_remove_connection_specific_smtp),
1661 (modest_account_mgr_get_connection_specific_smtp):
1662 * src/modest-account-mgr-helpers.h: Some functions to write the
1663 connection-specific SMTP server information. Not yet used.
1666 * src/widgets/modest-folder-view.c: (text_cell_data):
1667 Fix a warning about an uninitialized variable.
1668 (on_configuration_key_changed): Put an #ifdef around the use
1669 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1671 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1673 * src/maemo/modest-account-settings-dialog.h:
1674 * src/maemo/modest-account-settings-dialog.c:
1675 Added connect_for_modified() utility function to mark the new modified boolean.
1677 (create_page_account_details), (create_page_user_details),
1678 (create_page_incoming), (create_page_outgoing), (on_response),
1679 (modest_account_settings_dialog_init),
1680 (modest_account_settings_dialog_set_account_name):
1681 Only warn about unsaved changes when there are actually unsaved changes.
1683 * src/modest-account-mgr-helpers.c:
1684 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1685 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1686 to get the data from there in future.
1688 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1690 * src/modest-defs.h:
1692 * src/modest-account-mgr-helpers.h:
1693 * src/modest-account-mgr-helpers.c:
1694 Store the security account setting in a single conf key instead of using
1695 the options list, so that the list is left for just the to-be-removed camel hack,
1696 and because gconf_client_set_list() is failing for some reason.
1698 * src/modest-account-mgr.c:
1699 (modest_account_mgr_add_server_account):
1700 * src/maemo/modest-account-settings-dialog.c:
1701 (modest_account_settings_dialog_set_account_name),
1702 (save_configuration): Use the renamed functions.
1705 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1707 * src/widgets/Makefile.am:
1708 * src/widgets/modest-limit-retrieve-combo-box.c:
1709 * src/widgets/modest-limit-retrieve-combo-box.h:
1710 * src/widgets/modest-retrieve-combo-box.c:
1711 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1712 the account settings dialog.
1714 * src/modest-defs.h:
1715 * src/modest-account-mgr-helpers.h:
1716 * src/modest-account-mgr-helpers.c:
1717 (modest_server_account_get_option_secure_auth),
1718 (modest_server_account_set_option_secure_auth):
1719 * src/modest-account-mgr.c:
1720 (modest_account_mgr_add_server_account):
1721 Use the existing AUTH_MECH conf key for the secure-auth setting,
1722 instead of putting it in the list options, because this was actually used already.
1724 * src/maemo/modest-account-settings-dialog.c:
1725 (create_page_account_details),
1726 (modest_account_settings_dialog_set_account_name),
1727 (save_configuration):
1728 * src/maemo/modest-account-settings-dialog.h:
1729 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1730 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1732 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1734 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1735 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1736 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1738 * src/modest-defs.h:
1739 * src/maemo/modest-account-settings-dialog.c:
1740 (create_page_incoming), (on_combo_outgoing_security_changed),
1741 (on_combo_incoming_security_changed), (create_page_outgoing),
1742 (modest_account_settings_dialog_set_account_name),
1743 (save_configuration): Load/Save the port number, and change it when the
1744 security combo changes, to suitable defaults.
1746 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1748 * src/modest-account-mgr.c:
1749 (modest_account_mgr_add_server_account): Set the security and secure-auth
1750 options, and add a comment saying that the other camel-specific options should be
1753 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1755 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1757 * src/modest-tny-account-store.c: (account_list_free),
1758 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1759 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1762 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1764 * src/modest-protocol-info.c:
1765 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1766 is required by our UI spec. Maybe something in our implementation will use this eventually.
1767 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1768 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1769 instead of the previous 0 placeholder.
1771 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1772 secure-auth settings.
1773 * src/modest-account-mgr-helpers.h:
1774 * src/modest-account-mgr-helpers.c:
1775 (modest_server_account_data_get_option_secure_auth),
1776 (modest_server_account_set_option_secure_auth),
1777 (modest_server_account_data_get_option_security),
1778 (modest_server_account_set_option_security): Added this API for getting and setting the security
1779 and secure-auth settings.
1781 * src/maemo/modest-account-settings-dialog.h:
1782 * src/maemo/modest-account-settings-dialog.c:
1783 (modest_account_settings_dialog_finalize), (check_data),
1784 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1785 about changing titles.
1786 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1787 (save_configuration): Save the security and secure-auth settings.
1789 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1790 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1792 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1794 * src/modest-defs.h:
1795 * src/modest-account-mgr.c:
1796 (modest_account_mgr_add_server_account):
1797 Added and used defines for the options key and value pair strings,
1798 that are used so far, though they do not seem to correspond to anything in our
1799 UI specs or ModestProtocol enum.
1801 * src/modest-account-mgr-helpers.h:
1802 * src/modest-account-mgr-helpers.c:
1803 (compare_option_strings_for_name),
1804 (modest_server_account_data_get_option_value),
1805 (modest_server_account_data_get_option_bool),
1806 (modest_account_mgr_get_server_account_option):
1807 Added helper functions for parsing the options GSList.
1809 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1811 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1812 display name is based on the supplied account name.
1813 * src/modest-account-mgr.c:
1814 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1815 with an inefficient, but good-enough, implementation.
1817 * src/maemo/easysetup/modest-easysetup-wizard.c:
1818 (create_page_account_details), (on_before_next), (create_account):
1819 Check for existing display names rather than (non-user-visible) account names, and just
1820 create and set a unique account name at the end.
1822 * src/maemo/modest-account-settings-dialog.c:
1823 (modest_account_settings_dialog_init),
1824 (modest_account_settings_dialog_set_account_name),
1825 (create_page_incoming): Show the display name, instead of the account name.
1826 (on_response): Do some (not all) extra checks, as in the UI spec.
1827 (save_configuration): Save the display name if it was changed.
1829 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1831 * po/en_GB.po: Added needed logical ID and translation.
1832 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1833 (init_view): Made the is-default column clicking work.
1835 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1838 * src/maemo/easysetup/Makefile.am:
1839 * src/maemo/easysetup/modest-easysetup-wizard.c:
1840 (modest_easysetup_wizard_dialog_init):
1841 * src/maemo/easysetup/provider-data-test.keyfile:
1842 * src/maemo/easysetup/provider-data.keyfile:
1843 Moved the provider data file to the new modest-providers-data package and used it from there.
1845 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1847 * src/modest-local-folder-info.c:
1848 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1849 N_() was already used on the static strings, but this just marks it for translation without
1850 using the translation.
1852 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/modest-account-settings-dialog.c:
1855 (create_page_incoming),
1856 (modest_account_settings_dialog_set_account_name):
1857 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1858 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1859 I will do this if nobody else gets there first.
1861 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1863 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1864 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1865 save the security stuff.
1867 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1869 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1870 Set the email address and user fullname, which I now see must be
1873 * src/maemo/modest-account-settings-dialog.h:
1874 * src/maemo/modest-account-settings-dialog.c:
1876 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1877 leave-on-server and authentication.
1878 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1881 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1884 * src/maemo/modest-account-settings-dialog.c:
1885 * src/maemo/modest-account-settings-dialog.h:
1886 Most (but not all) of the widgets are now present as specified by the UI spec.
1887 No changes are yet saved, and some details are not properly shown yet.
1889 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1891 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/Makefile.am:
1894 * src/maemo/modest-account-settings-dialog.c:
1895 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1896 an existing account. Doesn't do much yet.
1898 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1899 Open the accounts settings dialog when Edit is clicked.
1901 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1903 * src/maemo/easysetup/Makefile.am:
1904 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1906 * src/maemo/easysetup/modest-easysetup-wizard.c:
1907 (modest_easysetup_wizard_dialog_init):
1908 Try to get the source directory from the build system,
1909 instead of hard-coding "./" into the source code, when opening our local
1910 copies of the configuration files.
1911 But this still fails when opening the wizard from the Accounts window,
1912 maybe because the working directory seems to change at runtime.
1913 So the wizard will fail the second time unless you copy the files into their
1914 proper locations - see the stdout warnings for the paths.
1916 (create_page_account_details),(on_before_next):
1917 Check for existing non-server accounts instead of server accounts,
1918 so the default account name is useful again, and to prevent trying to
1921 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1922 Show the wizard when New is clicked.
1924 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1925 (init_view): Show the column headers, and show the columns that are
1926 specified in the UI specs. However, something in Maemo's GTK+ prevents
1927 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1928 change the default account. This is despite unsetting the special properties.
1930 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1932 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1933 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1934 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1935 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1936 to make that clearer.
1937 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1939 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/modest-account-view-window.c:
1942 (modest_account_view_window_init),
1943 (modest_account_view_window_new):
1944 Use the same buttons as specified in the
1945 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1946 the existing widgets, which never had a chance of working.
1947 Put the ModestAccountView treeview in a scrolled window.
1948 Do not repeat the initialization in both _init() and _new().
1950 * src/widgets/modest-account-view.c: (update_account_view):
1951 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1952 this widget and window shows no accounts.
1954 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1956 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1958 * src/maemo/easysetup/modest-easysetup-wizard.c:
1959 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1960 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1961 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1964 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1965 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1966 accounts exist yet, as in the UI spec.
1968 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1970 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1972 * src/maemo/Makefile.am:
1973 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1974 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1975 New window for editing connection-specific smtp details.
1976 Not fully implemented.
1978 * src/maemo/modest-connection-specific-smtp-window.c:
1979 (modest_connection_specific_smtp_window_finalize) :
1980 unref the tree model.
1981 (on_button_edit): Show the edit window.
1983 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1985 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1988 * src/maemo/Makefile.am:
1989 * src/maemo/modest-connection-specific-smtp-window.c:
1990 * src/maemo/modest-connection-specific-smtp-window.h:
1991 New window for showing the list of connections, for connection-specific
1992 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1993 * src/maemo/easysetup/modest-easysetup-wizard.c:
1994 (create_page_custom_outgoing): Show the new window when the button is clicked.
1996 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1998 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1999 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2000 * src/maemo/modest-msg-edit-window.c:
2001 (modest_msg_edit_window_insert_image):
2002 * src/modest-conf.c: (modest_conf_key_escape):
2003 * src/modest-mail-operation.c:
2004 (modest_mail_operation_send_new_mail):
2005 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2006 (modest_ui_actions_on_new_account):
2007 * src/widgets/modest-attachment-view.c: (update_filename_request):
2008 * src/widgets/modest-mail-header-view.c:
2009 Corrected warnings that were breaking the build, by commenting out unused variables,
2010 and a function, and by including a header.
2012 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2014 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2015 so we can #ifdef around platform-specific code when necessary.
2016 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2017 to allow this to build for the GNOME platform too.
2019 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/easysetup/modest-easysetup-wizard.c:
2022 Added util_increment_name() and used it in create_page_account_details()
2023 to make sure that the default account name is always a new name.
2025 (modest_easysetup_wizard_dialog_init),
2026 (set_default_custom_servernames): Some minor memory management fixes.
2028 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2032 * src/modest-runtime.c: (init_i18n): Restored the translation
2033 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2034 are defined in config.h, and the translations are installed.
2036 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2037 is defined for translation.
2039 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2043 * src/maemo/easysetup/modest-easysetup-wizard.c:
2044 (modest_easysetup_wizard_dialog_init):
2045 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2046 Use realistic paths (though they should use $prefix generically) to the
2047 mcc_mapping and provider-data.keyfile files which might work when they
2048 are installed by the future version of the operator-wizard package,
2049 and then fallback to paths in our source code, with an explanatory
2052 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2056 * src/maemo/Makefile.am:
2057 * src/maemo/easysetup/: Added files from the previously-exernal
2058 osso-modest-easysetup.
2059 * src/maemo/modest-main-window-ui.h:
2060 * src/modest-ui-actions.c:
2061 * src/modest-ui-actions.h:
2062 Added modest_ui_actions_on_new_account() as a signal handler for the
2063 New Account menu item. It shows the easysetup wizard.
2064 * po/en_GB.po: Added additional needed logical IDs and translations.
2066 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2067 Apparently ChangeLog is not used for some vague Nokia legal reasons.