1 2007-07-05 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c:
4 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
5 a connection before asking anything else. Correct the check for the destination
6 folder so that it succeeds when online.
7 This fixed projects.maemo.org bug NB#61645.
9 2007-07-05 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
12 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
13 to fix projects.maemo.org bug NB#62439.
15 2007-07-05 Murray Cumming <murrayc@murrayc.com>
17 * src/modest-tny-account.c: (on_connection_status_changed):
18 Really do not use tny_device_force_offline() here. See the previous comment.
20 2007-07-04 Murray Cumming <murrayc@murrayc.com>
22 * src/modest-tny-account.c: (on_connection_status_changed):
23 Do not use tny_device_force_offline() when tinymail says that something
24 went wrong with the connection. It seems to report this unnecessarily.
26 2007-07-04 Murray Cumming <murrayc@murrayc.com>
28 * src/maemo/modest-connection-specific-smtp-window.c:
29 (modest_connection_specific_smtp_window_init):
30 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
31 does not seem to have any effect in osso 1.1 (though it works in
32 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
34 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
36 * src/maemo/modest-connection-specific-smtp-window.c:
37 Fix UI specification problems with projects.meamo.org NB#60479
39 2007-07-04 Murray Cumming <murrayc@murrayc.com>
41 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
42 clue when this has failed, because the error dialog is not always shown
43 (at least in earlier version).
45 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
46 GError message, because the generic error dialog is not helpful.
48 'This message is not currently available (can't let a new connection go online)'
49 when trying to open an IMAP message.
51 (_modest_ui_actions_open): Offer a connection when some messages would
52 have to be downloaded and we are offline.
54 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
56 * src/widgets/modest-folder-view.c:
57 Don't check for MERGE type anymore as we use the correct type
59 NOTE: For the last two changes you need to update your tinymail copy
60 because of API changes!
62 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
64 * src/modest-tny-local-folders-account.c:
65 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
66 (see projects.maemo.org NB#61580)
68 2007-07-04 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account.c: (on_connection_status_changed):
71 Commented out the call to modest_platform_connect_and_wait() because this
72 seems to always hang, and I would like to know if this is the only thing
73 that causes a hang when showing the connection dialog.
74 It is not very useful anyway.
76 2007-07-04 Murray Cumming <murrayc@murrayc.com>
78 * src/maemo/modest-msg-view-window.c:
79 (modest_msg_view_window_select_next_message):
81 * src/modest-platform.h:
82 * src/maemo/modest-platform.c:
83 Added modest_platform_connect_and_wait(), which calls
84 tny_maemo_conic_device_connect() always in the main thread, by calling it
85 in an idle handler and waiting for the idle handler to run. It should be
86 in the main thread because it uses GTK+ UI code. It just returns TRUE
87 if the device is already online.
89 There is some nasty code to ensure that subsequent calls to
90 modest_platform_connect_and_wait() just wait for the first one to finish,
91 by checking repeatedly in another idle handler. This is necessary,
92 because other threads (or even the main thread, via another idle handler)
93 can call modest_platform_connect_and_wait() while
94 modest_platform_connect_and_wait() is running.
96 (modest_platform_connect_and_wait_if_network_account),
97 (modest_platform_connect_and_wait_if_network_folderstore):
98 Convenience functions that calls modest_platform_connect_and_wait() if
99 the account or folder might want network access.
101 * src/modest-mail-operation.c:
102 (modest_mail_operation_update_account):
103 * src/modest-ui-actions.c: (download_uncached_messages),
104 (modest_ui_actions_on_rename_folder), (delete_folder),
105 (modest_ui_actions_on_main_window_move_to),
106 (modest_ui_actions_on_msg_view_window_move_to):
107 * src/widgets/modest-folder-view.c:
108 (drag_and_drop_from_folder_view):
109 Offer a connection if we are offline.
111 * src/modest-tny-account.c: (on_connection_status_changed):
112 Document this as only handling errors during network operations in progress,
113 and replace the idle code with a simple call to
114 modest_platform_connect_and_wait(), which does this instead.
116 2007-07-03 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-tny-account.c:
119 (modest_tny_account_get_special_folder): (util_on_idle),
120 Handle the GError so we can see when tny_folder_store_get_folders()
121 fails, as it currently does while something else is connecting.
123 Added util_run_in_main_thread_and_wait()
124 which uses an idlen handler and mainloop to ensure that the function
125 is called in the main thread.
126 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
127 to make sure that we call attempt the connection in the mainloop only,
128 which might solve some hangs.
130 2007-07-03 Murray Cumming <murrayc@murrayc.com>
132 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
133 be found by their display name. This is never useful.
134 * src/modest-tny-account-store.c: (on_account_removed): Find the account
135 by its ID, instead of trying to use its ID as its display name.
137 * src/modest-tny-account-store.h:
138 * src/modest-tny-account.c:
139 (modest_tny_account_get_special_folder): Add a g_warning() when
140 tny_folder_store_get_folders() returns an empty list for the maildir.
142 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
143 Add a g_warning() when this returns NULL, because that it not allowed
146 2007-07-02 Armin Burgmeier <armin@openismus.com>
148 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
149 note when trying to cancel the wizard. This fixes projects.maemo.org
152 2007-07-02 Murray Cumming <murrayc@murrayc.com>
154 * src/modest-tny-account.h:
155 * src/modest-tny-account.c:
156 (modest_tny_account_new_from_server_account),
157 (modest_tny_account_new_from_server_account_name),
158 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
159 because this must now be set before setting the proto. This is usd in
160 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
161 warning in camel_session_get_service() caused by
162 tny_camel_transport_account_prepare().
164 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
167 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
169 * src/maemo/modest-connection-specific-smtp-edit-window.c:
171 (modest_connection_specific_smtp_edit_window_init):
173 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
176 2007-06-29 Murray Cumming <murrayc@murrayc.com>
178 * src/modest-tny-account.c:
179 (modest_tny_account_new_from_server_account):
180 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
181 now uses to request a connection when it needs one, and which it uses
182 to tell us that something is wrong with the connection, so we can force
183 the accounts offline to prevent further problems.
186 * src/modest-init.c: (init_default_settings):
187 * src/modest-mail-operation.c:
188 (modest_mail_operation_update_account):
189 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
190 This should not be necessary anymore. Do not set the conf key that
191 determined this (it was always TRUE and not set anywhere else).
193 * src/modest-ui-actions.h: Remove unused and unimplemented
194 modest_ui_actions_on_online_toggle_toggled().
196 2007-06-29 Murray Cumming <murrayc@murrayc.com
198 * src/maemo/modest-main-window.c: (connect_signals):
199 Don't connect to delete_event twice. Maybe this was harmless.
201 2007-06-29 Murray Cumming <murrayc@murrayc.com
203 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
204 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
205 Debug output to give some more clue when a folder move is not allowed.
207 2007-06-28 Murray Cumming <murrayc@murrayc.com
209 * src/modest-tny-account.c: (on_modest_file_system_info),
210 (modest_tny_account_get_mmc_account_name):
211 Always call the callback, without checking whether the name has changed.
212 * src/widgets/modest-folder-view.c: (strings_are_equal),
213 (on_model_foreach_set_name), (on_get_mmc_account_name),
214 (text_cell_data): Compare the name here, and use the name from
215 the account rather than from the
216 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
217 if the name was changed after the account was added to the model.
218 That's a tinymail bug but not one that I want to fix now.
220 This finally fixes projects.maemo.org bug NB#59301.
222 2007-06-27 Armin Burgmeier <armin@openismus.com>
224 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
227 2007-06-27 Murray Cumming <murrayc@murrayc.com
229 * src/modest-tny-account.h:
230 * src/modest-tny-account.c:
231 Added modest_tny_account_get_mmc_account_name(), to set the memory
232 card name asynchronously for the given account and then notify.
233 (modest_tny_account_new_for_local_folders): Use this new function instead
234 of using hildon_file_system_info_async_new() directly.
236 * src/widgets/modest-folder-view.c: (text_cell_data):
237 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
238 gtk_tree_model_row_changed() when it is available.
240 This should fix projects.maemo.org bug NB#59301.
242 2007-06-27 Murray Cumming <murrayc@murrayc.com
244 * src/modest-mail-operation.c: (update_account_thread),
245 (get_msgs_full_thread): Fix typo failures in the revert
248 2007-06-27 Murray Cumming <murrayc@murrayc.com
250 * src/maemo/modest-maemo-global-settings-dialog.c:
251 (idle_select_default_focus):
252 * src/modest-mail-operation.c: (idle_notify_progress),
253 (idle_notify_progress_once), (set_last_updated_idle),
254 (update_account_thread), (get_msgs_full_thread):
255 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
256 * src/widgets/modest-header-view.c:
257 (idle_notify_headers_count_changed_destroy),
258 (idle_notify_headers_count_changed):
259 Reverted the additions of gdk_threads_enter/leave(), in case this
260 helps with a startup hang on the device.
262 2007-06-26 Armin Burgmeier <armin@openismus.com>
264 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
265 for supported secure authentication methods from server by
266 gtk_dialog_run(), saving CPU time and a potential race condition.
268 2007-06-26 Armin Burgmeier <armin@openismus.com>
270 * src/maemo/modest-maemo-utils.h:
271 * src/maemo/modest-maemo-utils.c: Added a
272 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
273 only error code to tell the calling code when the user canceled the
276 * src/maemo/modest-account-settings-dialog.h:
277 * src/maemo/modest-account-settings-dialog.c:
278 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
279 message if the retrieval of secure authentication methods was canceled
280 by the user. Perform the check before saving anything to configuration
281 to not end up with half-committed configuration changes, do not show
282 a "Saving to configuration failed" note when authentication methods
283 could not be retrieved.
285 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
288 2007-06-26 Murray Cumming <murrayc@murrayc.com>
290 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
291 Only return the first level of folders under accounts, because the
292 osso-global-search UI spec doesn't want the rest.
293 This fixed projects.maemo.org bug NB#61811.
295 2007-06-26 Murray Cumming <murrayc@murrayc.com>
297 * src/modest-tny-account-store.c:
298 * src/modest-tny-account-store.h:
299 Added modest_tny_account_is_memory_card_account().
300 * src/maemo/modest-main-window.c: (create_details_widget):
301 Show the same information items for the memory card as we show for the
302 local-folders, to fix projects.maemo.org bug NB#59307.
304 2007-06-26 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-tny-account-store.c: (get_password):
307 Added some checks for NULL to maybe prevent crashes, though I think
308 it was Philip's last commit that actually prevented the crash here
309 when creating a first new account.
310 But the new account is still not usable (no messages are shown)
311 until a restart of the application.
313 2007-06-26 Murray Cumming <murrayc@murrayc.com>
315 * src/maemo/modest-maemo-global-settings-dialog.c:
316 (idle_select_default_focus):
317 * src/modest-mail-operation.c: (idle_notify_progress),
318 (idle_notify_progress_once), (idle_notify_update_account_queue),
319 (set_last_updated_idle), (update_account_thread),
320 (notify_get_msgs_full), (get_msgs_full_destroyer),
321 (get_msgs_full_thread):
322 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
323 * src/widgets/modest-header-view.c:
324 (idle_notify_headers_count_changed_destroy),
325 (idle_notify_headers_count_changed):
326 Use gdk_threads_enter() and gdk_threads_enter_leave() in
327 all idle handlers, because some other thread could be blocking
328 the GDK lock, so that it can do GUI stuff.
330 2007-06-26 Murray Cumming <murrayc@murrayc.com>
332 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
333 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
334 (on_idle_send_receive), (on_idle_open_default_inbox):
335 * src/maemo/modest-msg-edit-window.c:
336 (modest_msg_edit_window_attach_file_noninteractive):
337 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
338 to prevent a hang. I don't quite understand why these are necessary,
339 beause we should already be in the main loop. I guess something outside
340 of the main loop is taking the lock.
342 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
343 we are really using URIs, and use files that are more likely to exist.
345 2007-06-26 Murray Cumming <murrayc@murrayc.com>
347 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
348 necessary because configure.ac now defines different variables.
350 2007-06-26 Murray Cumming <murrayc@murrayc.com>
352 * libmodest-dbus-client/libmodest-dbus-client.c:
353 * libmodest-dbus-client/libmodest-dbus-client.h:
354 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
355 libmodest_dbus_client_compose_mail() is what things actually use.
357 * src/dbus_api/modest-dbus-api.h:
358 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
359 * tests/dbus_api/Makefile.am:
360 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
363 2007-06-26 Murray Cumming <murrayc@murrayc.com>
365 * src/modest-init.c: (modest_init_local_folders):
366 For memory-card (or other non local-folders) maildir accounts,
367 always create an Archive folder, so that there is somewhere to put
368 messages. This should be less confusing, because the user does not need
369 to guess that the need to create a folder.
371 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
373 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
374 Fixed icon size by using (50, 50) which is the same as defined by
377 2007-06-25 Armin Burgmeier <armin@openismus.com>
379 * src/widgets/modest-window-mgr.c:
381 * configure.ac: Correctly recognize hildon-notify presence and fixed
382 the build without it being installed.
384 2007-06-25 Murray Cumming <murrayc@murrayc.com>
386 * libmodest-dbus-client/libmodest-dbus-client.c:
387 (libmodest_dbus_client_search): Fix the build. Sorry.
388 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
389 (reply_forward_cb): Initialize variables to fix the build.
391 * src/modest-tny-account-store.c:
392 (modest_tny_account_store_get_tny_account_by): Fix the account URI
393 comparison (a silly typo) so that email search results can be opened
394 when there are more than one account.
396 2007-06-25 Murray Cumming <murrayc@murrayc.com>
398 * libmodest-dbus-client/libmodest-dbus-client.c:
399 (libmodest_dbus_client_search),
400 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
401 instead of 1 second, because the search gets folders and messages from
402 the server, which can take a long time. When it times out,
403 osso-global-search will report no results.
405 We need to specify whether we should search only cached information
406 (maybe with a user preference), and the osso-email-search-plugin
407 API should really be improved to allow that option, and to allow results
408 to be delivered asynchronously in batches.
410 2007-06-25 Murray Cumming <murrayc@murrayc.com>
412 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
413 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
414 GTK_ICON_SIZE_DIALOG is probably the wrong size.
416 2007-06-25 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
419 that is an empty string. D-Bus seems to give us these instead of NULL.
421 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
423 * src/dbus_api/modest-dbus-callbacks.c:
424 * src/maemo/easysetup/modest-easysetup-wizard.h:
425 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
426 * src/maemo/modest-connection-specific-smtp-edit-window.c:
427 (modest_connection_specific_smtp_edit_window_init):
428 * src/maemo/modest-maemo-global-settings-dialog.c:
430 * src/maemo/modest-maemo-utils.c:
431 (modest_maemo_utils_setup_images_filechooser):
432 * src/maemo/modest-main-window.c: (create_details_widget):
433 * src/maemo/modest-msg-edit-window.c:
434 (modest_msg_edit_window_attach_file_noninteractive),
435 (modest_msg_edit_window_color_button_change),
436 (modest_msg_edit_window_set_zoom):
437 * src/modest-mail-operation.c: (update_account_thread):
438 * src/modest-tny-account-store.c:
439 * src/modest-tny-account.c:
440 * src/widgets/modest-global-settings-dialog.c:
441 * src/widgets/modest-window.h:
445 2007-06-25 Murray Cumming <murrayc@murrayc.com>
447 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
448 * src/modest-search.c: (modest_search_folder),
449 (modest_search_all_accounts): Actually search only in the specified folder,
450 doing a simple match on the folder ID.
451 * src/modest-search.h: Added a folder field to the ModestSearch struct,
452 and added some documentation.
454 2007-06-22 Armin Burgmeier <armin@openismus.com>
456 * src/maemo/modest-maemo-utils.h:
457 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
458 modest_maemo_utils_get_supported_secure_authentication_methods.
460 * src/maemo/easysetup/modest-easysetup-wizard.c:
461 * src/maemo/modest-account-settings-dialog.c: Show correct error if
462 one occured, not just "Server does not support secure authentication".
464 2007-06-22 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-tny-account-store.c: (get_password):
467 Restored the call to tny_account_set_user() because Philip seems to have
468 stopped this from crashing (by not using the freed string). It still does
469 not work, but now we can test it.
471 2007-06-22 Murray Cumming <murrayc@murrayc.com>
473 * src/maemo/modest-msg-edit-window.c: (init_window):
474 Comment out use of an uninitialzed GtkScrolledWindow variable,
475 to fix the build and stop a crash. Yet again.
477 2007-06-22 Murray Cumming <murrayc@murrayc.com>
479 * src/modest-tny-account-store.c: (get_password):
480 Remove the call to tny_account_set_user() because this actually crashes.
481 As mentioned in the last commit, it is known to not work anyway.
483 2007-06-22 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-tny-account-store.c: (get_password):
486 Use tny_account_set_username() to tell tinymail that the username might
487 have changed too. But tinymail ignores this: see projects.maemo.org
489 * src/modest-ui-actions.c:
490 (modest_ui_actions_on_password_requested): Remove the useless attempt to
491 reset the connection when changing the username, and improve the comments.
492 Save the changed username to gconf at least, so it is used when Modest is
495 2007-06-21 Murray Cumming <murrayc@murrayc.com>
497 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
498 Do not use a query, so that we get all folders, including for POP and
499 local-folders. They work as search criteria too.
500 This fixes projects.maemo.org bug NB#57740.
502 2007-06-21 Murray Cumming <murrayc@murrayc.com>
504 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
505 Comment out the use of hildon_notification_set_sound() because it is
506 not declared, to fix the build. Warnings are serious, people.
508 2007-06-21 Armin Burgmeier <armin@openismus.com>
510 * src/maemo/modest-maemo-utils.h:
511 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
512 modest_maemo_utils_get_supported_secure_authentication_methods()
513 to query authentication methods for a specific user. This should fix
514 projects.maemo.org bug NB#61369.
516 * src/maemo/easysetup/modest-easysetup-wizard.c:
517 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
520 2007-06-21 Murray Cumming <murrayc@murrayc.com>
522 * libmodest-dbus-client/libmodest-dbus-client.h:
523 * libmodest-dbus-client/libmodest-dbus-client.c:
524 (modest_dbus_message_iter_get_search_hit),
525 (libmodest_dbus_client_search):
526 Reorganised and commented this.
527 Removed modest_search_hit_free() from the public API because it
530 Added libmodest_dbus_client_get_folders() and
531 modest_folder_result_list_free().
533 * src/dbus_api/modest-dbus-api.h:
534 * src/dbus_api/modest-dbus-callbacks.c:
535 (modest_dbus_req_filter): Commented. Moved most code to
536 on_dbus_method_search() and added on_dbus_method_get_folders().
538 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
539 of the extra D-Bus handler.
541 * tests/dbus_api/Makefile.am:
542 * tests/dbus_api/test_get_folders.c: New test for
543 libmodest_dbus_client_get_folders(). This seems to return an empty list
544 at the moment. That could be the same error that causes the message list
545 to be empty sometimes.
546 This should help with projects.maemo.org bug NB#57740.
548 2007-06-21 Armin Burgmeier <armin@openismus.com>
550 * src/modest-mail-operation.c: Do not call
551 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
552 notify the operation's end after having set the status to CANCELED for
553 the operation queue to listen on. This fixes a deadlock when there
554 were mail operations in the queue during its finalization.
556 * src/modest-singletons.c: Reordered uninitialization of the account
557 manager to happen after the mail operation queue was uninitialized
558 because the mail operation's in the queue might still try to access
559 the account manager (see modest_mail_operation_notify_end()). This
560 fixes a potential crash when terminating the application.
562 2007-06-21 Murray Cumming <murrayc@murrayc.com>
564 * src/modest-search.c:
565 (search_mime_part_and_child_parts): Moved some code here so we
566 can search recursively in child folders.
567 (modest_search_folder): Search in the message as a mime part, instead
568 of just its child mime parts.
569 (read_chunk), (search_mime_part_ogs):
570 Check how many bytes were read, to prevent an endless loop.
571 Searching in message bodies now works. This finishes the fix for
572 projects.maemo.org bug NB#61007.
574 2007-06-20 Murray Cumming <murrayc@murrayc.com>
576 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
577 Add a g_warning when the item is not a folder.
579 * src/modest-ui-dimming-rules.c:
580 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
581 when selected item is not a folder (for instance, an account), because
582 the UI spec only talks about folders.
583 I am not sure what the UI spec wants, so this might not totally fix
584 projects.maemo.org bug NB#60794.
586 2007-06-20 Murray Cumming <murrayc@murrayc.com>
588 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
589 (load_from_file): Sort the list. The unsorted list would be more noticeable
590 in non-English locales.
592 * src/maemo/modest-msg-edit-window.c:
593 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
594 warning and fix the build.
596 * src/maemo/modest-progress-bar-widget.c:
597 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
598 avoid a g_warning, and probably to avoid a crash.
600 2007-06-20 Murray Cumming <murrayc@murrayc.com>
602 * src/modest-search.c: (modest_search_folder): Check for a GError
603 when calling tny_folder_get_headers(), to show that this is not the cause
606 2007-06-20 Murray Cumming <murrayc@murrayc.com>
608 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
609 Actually set the body query instead of the subject query.
611 * src/modest-search.c: (search_mime_part_ogs),
612 (search_mime_part_strcmp): Remove extra space from the text/* regex,
613 which would probably cause it to fail if we got this far.
615 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
616 to simplify the code.
617 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
618 be causing search-in-body to fail.
620 2007-06-20 Murray Cumming <murrayc@murrayc.com>
622 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
624 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
625 Better debug message when the folder cannot be found.
626 This should help with fixing projects.maemo.org bug #61287.
627 * src/modest-search.c: (add_hit): Do not leak the furl string.
629 2007-06-20 Murray Cumming <murrayc@murrayc.com>
631 * src/modest-ui-actions.c:
632 (modest_ui_actions_on_folder_selection_changed):
633 Do not special-case TNY_MERGE_FOLDER here, because
634 modest_tny_folder_get_account() already does that. This fixes
635 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
636 shown when the Outbox was selected).
638 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
640 * libmodest-dbus-client/libmodest-dbus-client.c:
641 (_dbus_iter_get_string_or_null): Initialize the string variable in
642 case this helps with Dirk's crash.
644 2007-06-19 Murray Cumming <murrayc@murrayc.com>
646 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
647 though it is not implemented yet (this function is maybe not even used),
648 to avoid breaking ABI in future.
649 * libmodest-dbus-client/libmodest-dbus-client.c:
650 (get_attachments_string): Moved some code into this generic function.
651 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
652 sends email. It is maybe not used.
653 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
654 (on_send_mail): Use attachments.
656 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
657 * src/maemo/modest-msg-edit-window.c:
658 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
659 a filename before using it, to fix projects.maemo.org bug NB#58233.
661 2007-06-19 Murray Cumming <murrayc@murrayc.com>
663 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
664 Initialize the continue_download variable to fix the build, and probably
665 to fix randome behaviour.
667 2007-06-18 Armin Burgmeier <armin@openismus.com>
669 * src/modest-tny-send-queue.h:
670 * src/modest-tny-send-queue.c: Keep track of the status of messages in
671 the queue so we can later show it in the UI. Replaced
672 modest_tny_send_queue_msg_is_being_sent() by
673 modest_tny_send_queue_get_msg_status().
675 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
677 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
678 gpointer. This probably was not harmful, but just to be sure.
680 2007-06-18 Murray Cumming <murrayc@murrayc.com>
682 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
683 Fix the build, but leave the function broken on Bora, because
684 hildon_uri_action_get_service() does not exist.
685 osso_uri_action_get_service() does not exist either, it seems.
687 2007-06-18 Murray Cumming <murrayc@murrayc.com>
689 * src/modest-tny-account.c:
690 (modest_tny_account_new_from_server_account):
691 Uncommented the url debug output again, because it is useful for
692 debugging, as I said in the comment.
694 2007-06-18 Murray Cumming <murrayc@murrayc.com>
696 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
698 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
699 for Mameo Bora, to fix the build.
701 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
704 Fixed build with hildon < 0.99
706 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
707 Check if the selected account is busy instead of checking all accounts
709 * src/modest-account-mgr-priv.h:
710 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
711 (modest_account_mgr_init), (compare_account_name),
712 (modest_account_mgr_set_account_busy),
713 (modest_account_mgr_account_is_busy):
714 * src/modest-account-mgr.h:
715 Added busy information to the account manager. It possible to
716 set an account to busy or not busy now.
718 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
719 (modest_mail_operation_update_account),
720 (modest_mail_operation_notify_end):
721 Set the account to busy/not busy depending on the operation state.
723 * src/widgets/modest-account-view.c:
724 (modest_account_view_finalize), (get_last_updated_string),
725 (update_account_view), (on_account_busy_changed), (init_view):
726 Show string "Refreshing..." if the account is currently busy.
728 All this fixes projects.maemo.org bug NB#59711
730 2007-06-14 Armin Burgmeier <armin@openismus.com>
732 * src/widgets/modest-attachments-view.h:
733 * src/widgets/modest-attachments-view.c: Added
734 modest_attachments_view_has_attachments() and fixed coordinate
735 transformation in get_att_view_at_coords(). This fixes attachment
738 * src/widgets/modest-msg-view.c: Make use of
739 modest_attachments_view_has_attachments() to decide whether to show
740 attachments in the header.
742 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
744 * src/maemo/modest-connection-specific-smtp-edit-window.c:
745 (on_change), (on_combo_security_changed),
746 (modest_connection_specific_smtp_edit_window_init),
747 (modest_connection_specific_smtp_edit_window_set_connection),
748 (modest_connection_specific_smtp_edit_window_is_dirty):
749 * src/maemo/modest-connection-specific-smtp-edit-window.h:
750 * src/maemo/modest-connection-specific-smtp-window.c:
753 Show an comfirmation dialog for the smpt-edit-window if there are
754 unsaved changes and the user hits cancel.
755 (projects.maemo.org bug NB#60479)
757 2007-06-14 Armin Burgmeier <armin@openismus.com>
759 * src/maemo/easysetup/modest-easysetup-wizard.c:
760 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
761 address" info in banner instead of node, and select all the text as
762 per UI spec. This fixes projects.maemo.org bug NB#60550.
764 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
766 reviewed by: <delete if not using a buddy>
768 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
769 * src/modest-ui-actions.c: (folder_refreshed_cb):
771 2007-06-14 Murray Cumming <murrayc@murrayc.com>
773 * src/widgets/modest-folder-view.c: (filter_row):
774 Explictly filter out the per-account outbox accounts. I don't know why
775 these only sometimes show up, but now they should never show up in the UI.
776 This should fix projects.maemo.org bug NB#60160.
778 2007-06-14 Murray Cumming <murrayc@murrayc.com>
780 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
781 when the toolbar does not exist yet.
782 * src/modest-widget-memory.c: (save_settings_header_view):
783 Added g_warnings() to help us to discover when we are trying to set
784 an empty columns list in gconf.
786 2007-06-14 Murray Cumming <murrayc@murrayc.com>
790 Added modest_init_get_default_header_view_column_ids().
792 * src/modest-widget-memory.c: (restore_settings_header_view):
793 Use the new function to get defaults, if the gconf key is empty,
794 instead of not creating any columns. This seems to fix the
795 empty right-hand pane problems.
797 * src/widgets/modest-header-view.h: Improved documentation.
799 2007-06-13 Murray Cumming <murrayc@murrayc.com>
801 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
802 Revert the use of the display name as the account name, because this
803 is generally wrong and would break the code that follows.
805 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
807 * src/maemo/easysetup/modest-easysetup-wizard.c:
808 (check_for_supported_auth_methods), (on_before_next),
811 More correct fix for projects.maemo.org bug NB# 58991
812 Do not longer accept AUTH_PASSWORD as secure method and choose
813 correct method when creating the account.
815 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
817 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
818 Fixed projects.maemo.org bug NB# 58991
820 2007-06-13 Murray Cumming <murrayc@murrayc.com>
822 * src/modest-init.c: (modest_init_init_core),
823 (modest_init_local_folders): Fixed compilation errors.
825 2007-06-13 Murray Cumming <murrayc@murrayc.com>
827 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
828 Remove unnecessary lib/include, though it is good in principle when needed.
830 * src/modest-init.c: (modest_init_one_local_folder),
831 (modest_init_local_folders):
832 * src/modest-init.h: Initialize the .modest library for memory cards,
833 instead of just doing nothing for them. This should allow us to create
834 folders there, fixing projects.maemo.org bug NB#59297.
836 2007-06-13 Murray Cumming <murrayc@murrayc.com>
838 * libmodest-dbus-client/libmodest-dbus-client.c:
839 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
840 (libmodest_dbus_client_compose_mail),
841 (libmodest_dbus_client_open_message),
842 (libmodest_dbus_client_send_and_receive),
843 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
845 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
846 (on_idle_open_message), (modest_dbus_req_handler),
847 (search_result_to_message), (modest_dbus_req_filter):
848 * src/modest-search.c: (add_hit), (modest_search_folder),
849 (modest_search_all_accounts): Improved debug messages.
851 * tests/dbus_api/test_open_message.c: (main): Improved comments.
853 * src/modest-tny-account-store.c:
854 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
857 2007-06-13 Murray Cumming <murrayc@murrayc.com>
860 2007-06-12 Murray Cumming <murrayc@murrayc.com>
862 * src/modest-tny-account-store.c: (get_server_accounts):
863 Call modest_tny_local_folders_account_add_merged_outbox_folders()
864 even when there are no accounts, so that the Outbox folder is always
865 visible. This fixes projects.maemo.org bug NB#60158.
867 2007-06-12 Murray Cumming <murrayc@murrayc.com>
869 * src/maemo/modest-main-window.c: (create_details_widget):
870 Use the mcen_va_never logical ID.
872 2007-06-12 Murray Cumming <murrayc@murrayc.com>
874 * src/dbus_api/modest-dbus-api.h:
875 * src/dbus_api/modest-dbus-callbacks.c:
876 (on_idle_open_default_inbox), (on_open_default_inbox),
877 (modest_dbus_req_handler):
878 Added a new OpenDefaultInbox method.
880 * libmodest-dbus-client/libmodest-dbus-client.h:
881 * libmodest-dbus-client/libmodest-dbus-client.c:
882 Added libmodest_dbus_client_open_default_inbox() to call the new
883 dbus method. This should be useful to projects.maemo.org bug NB#57214,
884 though it should maybe be used by a new osso-email-interface function.
886 * tests/dbus_api/Makefile.am:
887 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
890 2007-06-12 Murray Cumming <murrayc@murrayc.com>
892 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
893 NULL, so that the signals get all the keys. This should not actually
894 change any behaviour because we currently update everything when anything
897 2007-06-12 Murray Cumming <murrayc@murrayc.com>
899 * src/widgets/modest-folder-view.c: (text_cell_data),
900 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
901 (find_inbox_iter): If tinymail tells us that the folder is
902 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
903 This causes the inbox to be selected at startup, fixing part of
904 projects.maemo.org bug NB#56305.
906 * src/modest-ui-dimming-rules.c:
907 (modest_ui_dimming_rules_on_tools_smtp_servers):
908 * src/modest-ui-dimming-rules.h: Added a callback function to dim
909 the SMTP servers menu item.
910 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
911 that the SMTP Servers menu item is dimmed when there are no accounts,
912 as a future version of the UI spec will require. This fixes
913 projects.maemo.org bug NB#56305.
915 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
917 * src/maemo/modest-maemo-utils.c:
918 (modest_maemo_utils_get_supported_secure_authentication_methods):
919 Added label to dialog instead of unreadable title
921 * src/maemo/modest-main-window.c: (sync_accounts_cb),
922 (modest_main_window_new):
923 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
926 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
927 * src/modest-account-mgr.h:
928 Added method to avoid code duplication
930 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
931 (modest_ui_actions_on_send_receive):
932 Use modest_account_mgr_has_accounts
934 2007-06-11 Murray Cumming <murrayc@murrayc.com>
936 * src/maemo/easysetup/modest-presets.c:
937 (modest_presets_get_info_server_security): Do not report secure auth
939 * src/modest-protocol-info.c: Use the defines for the gconf key names
940 for secure authentication. This was not working because we were writing
941 Password and reading password, and the check was case sensitive.
942 With this, gmail now works for receiving and sending when created via
945 2007-06-11 Murray Cumming <murrayc@murrayc.com>
947 * src/maemo/easysetup/modest-presets.c:
948 (modest_presets_get_info_server_security): Correct the key name for
949 SecureSmtp, because it seems to be case-sensitive.
950 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
951 Do not try to get the 0th notebook page if there are 0 pages, to
954 2007-06-11 Murray Cumming <murrayc@murrayc.com>
956 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
957 Prevent use of the new notification feature for now, because it currently
958 shows one dialog for each new email, which is annoying.
960 2007-06-11 Murray Cumming <murrayc@murrayc.com>
962 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
963 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
964 when no country was selected, so that we show the global ones.
965 * src/maemo/easysetup/modest-presets.c:
966 (modest_presets_get_providers): Return only the global providers, not
967 all providers when mmc=0 was requested.
969 2007-06-11 Murray Cumming <murrayc@murrayc.com>
971 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
972 (easysetup_provider_combo_box_fill): Remove debug code that showed the
973 provider ID in the combo.
975 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
976 Do not show the page numbers, because it would be confusing when we add
977 the 2 extra pages for the custom setup, when the user chooses the "Other"
978 provider. This fixes projects.maemo.org bug NB#59028
980 * src/modest-init.c: (modest_init_init_core),
981 (modest_init_local_folders):
983 * src/modest-tny-account.c:
984 (modest_tny_account_new_for_local_folders): Do not create default folders
985 for the memory card. This should fix projects.maemo.org bug NB#59328.
987 2007-06-11 Murray Cumming <murrayc@murrayc.com>
989 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
990 Free the changed_conf_keys string items. They are already freed in the
991 idle handler if that runs first.
993 2007-06-11 Murray Cumming <murrayc@murrayc.com>
995 * src/modest-ui-actions.c:
996 (modest_ui_actions_on_password_requested): Check that the server name
997 is not NULL, because I just saw a password dialog with (null) as the
1000 * src/modest-tny-folder.[h|c]: Added
1001 modest_tny_folder_is_memory_card_folder().
1002 * src/modest-ui-dimming-rules.c:
1003 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1004 menu item for memory cards, as per the UI spec (section 7.4). This should
1005 fix projects.maemo.org bug NB#59297.
1007 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1009 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1010 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1011 is another problem with the code, see Murray's comment at line 772)
1013 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1015 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1016 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1017 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1018 (load_from_file), (easysetup_country_combo_box_init),
1019 (easysetup_country_combo_box_get_active_country_ids),
1020 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1021 instead of just one ID, to avoid duplicate country names in the UI.
1023 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1024 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1025 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1026 a single ID, avoiding duplicate providers.
1027 * src/maemo/easysetup/modest-easysetup-wizard.c:
1028 (on_combo_account_country): Adapt to use a list.
1030 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1033 keys changed in the last X seconds.
1035 * src/modest-account-mgr.h:
1036 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1037 (on_key_change), (modest_account_mgr_class_init),
1038 (modest_account_mgr_init), (modest_account_mgr_finalize):
1039 As the keys are changed, save them in a GSList* and signal that GSList*
1040 further every X seconds, to batch changes, to allow us to do just one
1041 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1042 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1044 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1045 changed signal signature.
1047 * src/modest-conf.c: (modest_conf_set_list),
1048 (modest_conf_on_change): Reenable notification.
1050 (modest_conf_maemo_fake_on_change): Comment out the hack that
1051 notified immediately instead of asynchronously.
1053 * src/widgets/modest-account-view.h:
1054 * src/widgets/modest-account-view.c:
1055 (update_account_view): Select the previously-selected account ID,
1056 if possible. This fixes projects.maemo.org bug NB#56933.
1058 (on_account_changed), (on_account_removed),
1059 (modest_account_view_select_account):
1061 Remove the block/unblock functions
1062 because they were not useful.
1064 * src/maemo/modest-account-view-window.c:
1065 (on_delete_button_clicked), (on_edit_button_clicked),
1066 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1068 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1070 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1071 Improve the error dialog to show Incorrect Account Settings, which seems
1072 clearer, and say that the internal error message (to be removed from the
1073 dialog later) is often misleading.
1074 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1076 * src/modest-tny-account.c:
1077 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1078 URL because this is so useful for debugging on the device.
1080 * src/widgets/modest-serversecurity-combo-box.c:
1081 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1083 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1085 * src/modest-mail-operation.c:
1086 (modest_mail_operation_send_new_mail):
1087 Added a comment about a nasty but apparently harmless message. Details
1088 added to the wiki g_warnings() page.
1090 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1092 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1093 (modest_tny_send_queue_class_init):
1094 Do not use the priv struct because it is empty, to avoid g_warnings
1095 about a non-existant priv struct.
1097 * src/modest-tny-account-store.c:
1098 (modest_tny_account_store_get_server_account),
1099 (modest_tny_account_store_get_transport_account_for_open_connection
1100 ): Do not try to get transport server accounts for local folders,
1101 because they don't have any. This avoids a g_warning().
1103 * src/maemo/modest-main-window.c:
1104 (modest_main_window_notify_send_receive_initied),
1105 (on_configuration_key_changed):
1106 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1107 * src/modest-defs.h:
1108 * src/modest-mail-operation.c:
1109 (modest_mail_operation_update_account):
1110 * src/modest-tny-account-store.h:
1111 * src/modest-tny-account.c:
1112 (modest_tny_account_get_special_folder),
1113 (modest_tny_account_new_for_local_folders),
1114 (modest_tny_account_new_for_per_account_local_outbox_folder):
1115 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1116 * src/modest-tny-local-folders-account.c:
1117 (add_account_folders_to_merged_folder):
1118 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1119 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1120 (modest_ui_actions_on_send):
1121 * src/widgets/modest-folder-view.c: (update_model):
1122 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1123 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1124 modest_tny_account_store_get_tny_account_by_account() to
1125 modest_tny_account_store_get_server_account() to make the code clearer.
1127 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1129 * src/dbus_api/modest-dbus-api.h:
1130 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1131 * src/maemo/modest-msg-edit-window.c:
1132 (modest_msg_edit_window_attach_file_noninteractive):
1133 added g_warning in case the file to be attached does not exist
1134 * tests/dbus_api/test_compose_mail.c: (main):
1135 removed obsolete comment, added generic files as test case
1137 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-tny-account-store.c: (get_server_accounts):
1140 Create the local folders account only once, not once for each outbox, and
1141 not only when there are some outboxes.
1143 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1145 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1146 code that is causing a crash at startup. Sergio says that he is fixing this.
1148 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1150 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1151 * src/maemo/modest-account-settings-dialog.c:
1152 (create_page_outgoing),
1153 (modest_account_settings_dialog_set_account_name),
1154 (save_configuration):
1155 - Fixed handling of the "Use secure authentication" toggle to comply with
1156 the ui specification. See also projects.maemo.org bug NB#58400
1158 - Restore the Secure connection setting combo correctly when loading
1161 * src/maemo/modest-maemo-utils.c:
1162 (on_camel_account_get_supported_secure_authentication),
1163 (modest_maemo_utils_get_supported_secure_authentication_methods):
1164 Fixed a crasher if operation is canceled
1166 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1167 (modest_protocol_info_auth_is_secure):
1168 * src/modest-protocol-info.h:
1170 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1171 the sense of the "Use secure authentication" toggle.
1173 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-tny-account-store.h:
1176 * src/modest-tny-account-store.c:
1177 Added modest_tny_account_store_get_local_folders_account().
1179 * src/modest-tny-folder.h:
1180 * src/modest-tny-folder.c:
1181 (modest_tny_folder_get_account):
1182 Added this replacement for tny_folder_get_account() which returns
1183 the local-folders account for TnyMergeFolders, to avoid the
1184 warning about the unimplemented get_account_func() vfunc().
1186 (modest_tny_folder_get_rules),
1187 * src/modest-ui-actions.c:
1188 (modest_ui_actions_on_folder_selection_changed):
1189 * src/modest-mail-operation.c:
1190 (modest_mail_operation_remove_folder),
1191 (modest_mail_operation_xfer_folder),
1192 (modest_mail_operation_rename_folder),
1193 (modest_mail_operation_get_msg),
1194 (modest_mail_operation_get_msgs_full),
1195 (modest_mail_operation_remove_msg),
1196 (modest_mail_operation_xfer_msgs),
1197 (modest_mail_operation_refresh_folder):
1198 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1200 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1202 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1203 (modest_server_account_set_security):
1204 * src/modest-defs.h: Add comments explaining that our
1205 UI spec means TLS when it says Normal, so these do not look like errors.
1207 * src/modest-tny-account.c:
1208 (modest_tny_account_new_from_server_account): Use the new tinymail
1209 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1210 for TLS. This should fix projects.maemo.org bug NB#58460.
1212 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1214 * src/maemo/easysetup/modest-easysetup-wizard.c:
1215 (create_account): Correct the position of the gconf sanity check warning.
1216 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1217 of using the g_idle_add() hack, because this does not seem to be necessary
1218 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1219 caused by something other than maemo's gconf.
1220 This fixes projects.maemo.org bug #59022.
1222 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1224 * src/modest-account-mgr-helpers.c:
1225 (modest_account_mgr_get_default_account): Do not check that the account
1226 exists if there is no default account (NULL), to fix a runtime warning.
1228 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1230 * src/widgets/modest-folder-view.c: (update_model):
1231 Do not unref the treemodel before we have finished with it.
1232 This prevents a valgrind warning and an occasional crash at startup.
1234 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1236 * libmodest-dbus-client/libmodest-dbus-client.h:
1237 added libmodest_dbus_client_compose_mail()
1238 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1240 added functions needed for SendAsMail() functionality
1241 * src/maemo/modest-msg-edit-window.c:
1242 (modest_msg_edit_window_attach_file_noninteractive):
1243 non interactively attaching files to message edit window
1244 * src/widgets/modest-msg-edit-window.h:
1245 * tests/dbus_api/Makefile.am:
1246 added test_compose_mail.c
1247 * tests/dbus_api/test_compose_mail.c: (main):
1249 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1251 * src/modest-account-view.c:
1252 Fixed bug projects.maemo.org bug NB#59307
1254 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1256 * src/maemo/easysetup/modest-easysetup-wizard.c:
1257 (get_serverport_incoming), (on_before_next), (create_account):
1258 * src/maemo/modest-account-settings-dialog.c:
1259 (modest_account_settings_dialog_set_account_name):
1260 * src/maemo/modest-maemo-utils.c:
1261 (on_camel_account_get_supported_secure_authentication_status),
1262 (on_camel_account_get_supported_secure_authentication),
1263 (on_secure_auth_cancel),
1264 (modest_maemo_utils_get_supported_secure_authentication_methods):
1266 Implemented security authentication for settings and easysetup.
1268 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/modest-main-window.c: (create_details_widget):
1271 Show the total size for memory card accounts too, instead of showing
1272 the name again. Fixes bug projects.maemo.org bug NB#59307.
1274 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1277 * src/modest-tny-simple-folder-store.c:
1278 * src/modest-tny-simple-folder-store.h: Removed.
1280 * src/modest-tny-local-folders-account.h
1281 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1282 for the local-folders maildir, with an extra TnyMergedFolder containing
1283 the folders of the per-account outbox store accounts.
1284 * src/modest-tny-account-store.c: (get_server_accounts):
1285 Add the outboxes to the special local folders account after creating it.
1287 * src/modest-tny-account.c:
1288 (modest_tny_account_new_for_local_folders): Create the derived
1289 account when creating the main local-folders account.
1291 * src/maemo/modest-main-window.c: (create_details_widget),
1292 (modest_main_window_set_contents_style):
1293 Adapted to the use of the derived account instead of the folder store.
1295 * src/modest-ui-actions.c:
1296 (modest_ui_actions_on_folder_selection_changed):
1297 * src/modest-ui-dimming-rules.c:
1298 (modest_ui_dimming_rules_on_new_folder):
1299 * src/widgets/modest-folder-view.c: (text_cell_data),
1300 (icon_cell_data), (filter_row), (update_model),
1301 (get_cmp_rows_type_pos):
1304 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1305 Do not get the priv struct, because no priv struct has been set,
1306 to avoid a runtime warning.
1308 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1309 #ifelse with #else, to fix a warning, to fix the build.
1312 2007-06-05 Christian Kellner <ckellner@openismus.com>
1314 * libmodest-dbus-client/libmodest-dbus-client.c:
1315 Fix small typo in doc (why do you always see them
1316 AFTER committing stuff?)
1319 2007-06-05 Christian Kellner <ckellner@openismus.com>
1321 * libmodest-dbus-client/libmodest-dbus-client.c:
1322 (libmodest_dbus_client_search):
1323 Initialize hit list with NULL. Also set folder list
1324 to "" if NULL was supplied.
1327 2007-06-03 Christian Kellner <ckellner@openismus.com>
1329 * libmodest-dbus-client/libmodest-dbus-client.c:
1330 (modest_search_hit_list_free):
1331 Make it save to call it with NULL.
1333 * src/dbus_api/modest-dbus-callbacks.c:
1334 * src/modest-search.c:
1335 Return full ModestSearchHits as the search result list not TnyHeader
1336 since can't be around withouth the correspoding TnyFolder.
1338 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1340 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1341 Added currently commented code to check for secure auth
1343 * src/maemo/modest-account-settings-dialog.c: (on_response),
1344 (save_configuration), (show_ok):
1345 Fixed projects.maemo.org bugs NB #59248 and #59251
1347 * src/maemo/modest-maemo-utils.c:
1348 (on_camel_account_get_supported_secure_authentication_status),
1349 (on_camel_account_get_supported_secure_authentication),
1350 (modest_maemo_utils_get_supported_secure_authentication_methods):
1351 * src/maemo/modest-maemo-utils.h:
1352 Moved get_supported_secure_authentication() method here to be able
1353 to use it from easysetup wizard.
1355 * src/modest-pair.c: (on_pair_compare_as_string):
1356 Should compare string with first part of pair and not
1357 strcmp pairs which will crash.
1359 * src/modest-protocol-info.c:
1360 (modest_protocol_info_protocol_is_store):
1361 * src/modest-protocol-info.h:
1362 Added modest_protocol_info_get_auth_protocol_name()
1364 2007-06-03 Armin Burgmeier <armin@openismus.com>
1366 * src/modest-mail-operation.c:
1367 (modest_mail_operation_get_msgs_full): Set priv->account also when
1368 only retrieving a single message. This avoids a crash when canceling
1371 (modest_mail_operation_notify_end): Do not explicitely remove the
1372 operation from the queue but only emit the progress_changed signal.
1373 The queue itself listens to that signal to remove the operation when
1374 it is finished. This reduces coupling and removes a potential deadlock
1375 when modest_mail_operation_notify_end() is called from the queue
1376 itself. If that is a problem performance-wise, I would suggest to
1377 implement a status-changed signal or something.
1379 * src/modest-mail-operation-queue.c: Make sure to never call a
1380 function from another file while the queue is locked. This (hopefully)
1381 fixes another deadlock when exiting the application while retrieving
1384 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1386 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1387 Fixed build if libogs is not available
1389 2007-06-03 Christian Kellner <ckellner@openismus.com>
1391 * libmodest-dbus-client/libmodest-dbus-client.h:
1392 * libmodest-dbus-client/libmodest-dbus-client.c:
1393 (libmodest_dbus_client_delete_message):
1394 Implement deletion of messages (Client side).
1396 (modest_search_hit_free),
1397 (modest_search_hit_list_free):
1398 Utility functions to free the result hits.
1400 * src/dbus_api/modest-dbus-api.h:
1401 * src/dbus_api/modest-dbus-callbacks.c:
1402 (on_delete_message),
1403 (modest_dbus_req_handler):
1404 Implement deletion of messages (Server side).
1406 * tests/dbus_api/test_search.c: (main):
1409 * tests/dbus_api/Makefile.am:
1410 * tests/dbus_api/test_delete_message:
1411 Add little test for the message deletion logic
1413 2007-06-03 Armin Burgmeier <armin@openismus.com>
1415 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1416 when the operation queue was not empty. projects.maemo.org bug
1419 2007-06-03 Armin Burgmeier <armin@openismus.com>
1421 * src/widgets/modest-account-view.c
1422 (on_account_default_toggled): Toggle default account column
1423 explicitely instead of waiting for gconf notification (which is
1424 currently ignored). This should fix projects.maemo.org bug NB#56910
1425 for now. It should probably be removed when gconf notifications are
1428 2007-06-03 Christian Kellner <ckellner@openismus.com>
1430 * libmodest-dbus-client/libmodest-dbus-client.c:
1431 Removed debugging spew.
1433 * src/dbus_api/modest-dbus-callbacks.c:
1434 Added debugging info.
1436 * src/modest-search.c:
1437 (modest_search_all_accounts):
1438 Use tny_account_store_get_accounts () on the account store
1439 to get all accounts which is the way to get all accounts.
1441 * tests/dbus_api/test_search.c: (main):
1442 Make it possible to supply the search term on the command line.
1444 2007-06-03 Christian Kellner <ckellner@openismus.com>
1446 * libmodest-dbus-client/libmodest-dbus-client.c:
1447 * libmodest-dbus-client/libmodest-dbus-client.h:
1448 Implement searching for mesages over raw dbus. (Client side)
1450 * src/dbus_api/Makefile.am:
1451 * src/dbus_api/modest-dbus-api.h:
1452 * src/dbus_api/modest-dbus-callbacks.c:
1453 * src/dbus_api/modest-dbus-callbacks.h:
1454 Search framework (Server side). Also implement on_idle_open_message().
1456 * src/maemo/modest-platform.c: (modest_platform_init):
1457 Prepare for raw dbus/osso rpc interaction.
1459 * src/modest-search.h:
1460 Changed minsize from unspecific guint to guint32.
1462 * src/modest-search.c:
1464 Added strange hack which magically made tnymail work.
1466 (modest_search_folder),
1467 (modest_search_account),
1468 (modest_search_all_accounts):
1469 Implement helper functions to search all accounts, specific account
1472 * tests/dbus_api/Makefile.am:
1473 * tests/dbus_api/test_open_message.c:
1474 Read url to open from commandline.
1476 * tests/dbus_api/test_search.c:
1477 Implement small test for dbus search stuff
1479 2007-06-02 Armin Burgmeier <armin@openismus.com>
1481 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1482 include account type and account title. This fixes projects.maemo.org
1485 * src/maemo/modest-account-view-window.c: Set a title for the window.
1487 2007-06-02 Armin Burgmeier <armin@openismus.com>
1489 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1490 incoming and outgoing server name based on email address and server
1491 types as long as the names have not been edited manually. This fixes
1492 projects.maemo.org bug NB#58671.
1494 2007-06-02 Armin Burgmeier <armin@openismus.com>
1496 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1497 server type cannot be changed in future to the incoming details page
1498 when creating an account. This fixes projects.maemo.org bug NB#59029.
1500 2007-06-02 Armin Burgmeier <armin@openismus.com>
1502 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1503 and assigned max width chars so that they wrap instead of being
1504 truncated. Fixes projects.maemo.org bug NB#56126.
1506 2007-06-02 Armin Burgmeier <armin@openismus.com>
1508 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1509 introductory note to the connection specific smtp servers dialog, as
1510 section 8.12 of the email UI specification requires. This fixes
1511 projects.maemo.org bug NB#59212.
1513 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1515 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1516 Check for running mail operations, and offer to cancel them, as per the UI
1517 spec. This fixes projects.maemo.org bug NB#59041 .
1518 However, I suspect that tinymail may still use the network connection
1519 in ways that we cannot detect or cancel. But it should at least adapt to
1520 changes fairly well.
1522 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1524 * src/modest-tny-account-store.c: (recreate_all_accounts),
1525 (get_cached_accounts), (get_server_accounts): Do more sensible
1526 ref-counting of the temporarily-cached outbox accounts list. This seems
1527 to fix a crash when entering the password when the password was wrong.
1529 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1531 * src/gnome/modest-main-window.c: (connect_signals):
1532 * src/modest-tny-account-store.c: (get_password),
1533 (modest_tny_account_store_alert): Added comments and clues and
1534 commented-out code about how we currently fail to deal with connection
1535 errors and wrong passwords, and how we should.
1537 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1539 * src/widgets/modest-retrieve-combo-box.c:
1540 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1541 This fixes projects.maemo.org bug NB#58472 .
1543 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1545 * src/maemo/easysetup/modest-easysetup-wizard.c:
1546 (create_page_complete_easysetup):
1547 (create_page_complete_custom): Correct the last commit,
1548 putting the correct sentences in the correct pages.
1550 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/easysetup/modest-easysetup-wizard.c:
1553 (create_page_complete_custom): Show the second sentence of text
1554 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1557 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1559 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1560 Set the leave-on-server conf key by default. This fixes
1561 projects.maemo.org bug NB#59258 .
1563 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1565 * src/maemo/modest-account-view-window.c:
1566 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1567 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1570 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1572 * src/maemo/easysetup/modest-easysetup-wizard.c:
1573 (create_caption_new_with_asterisk):
1574 * src/maemo/modest-account-settings-dialog.c:
1575 (create_caption_new_with_asterisk):
1576 Uncomment the code to add the asterisk, because they are no longer in the
1577 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1578 (update_incoming_server_title): Add an asterisk here too.
1580 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1582 * src/maemo/modest-maemo-global-settings-dialog.c:
1583 (current_connection): Check that we are even connected before trying to
1584 get the current connection name, to prevent a warning.
1586 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1587 Change the comments because tny_maemo_conic_device_connect() is now meant to
1589 * src/modest-mail-operation.c:
1590 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1591 make sure we have a connection and fail if we can't connect.
1593 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1595 * src/maemo/modest-main-window.c:
1596 (on_account_store_connecting_finished): Do not try to get the
1597 connection ID if we are not really connected. I am surprised that
1598 this signal handler is called when we are not connected.
1600 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1602 * src/modest-error.h:
1603 * src/modest-ui-actions.c:
1604 (modest_ui_actions_get_msgs_full_error_handler):
1605 Renamed an enum, added comments, added an enum
1606 for retrieve-limit errors.
1608 * src/modest-mail-operation.c: (foreach_add_item),
1609 (internal_folder_observer_update), (update_account_thread),
1610 (modest_mail_operation_get_msgs_full):
1611 (modest_mail_operation_update_account),
1612 Added comments about how this works, and some code that should
1613 (but does not) check the retrieve-limit. See the TODO comment.
1615 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1617 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1618 Initialize help_id to fix the build. Warnings are good.
1620 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1622 * src/widgets/modest-hbox-cell-renderer.c:
1623 (modest_hbox_cell_renderer_append):
1624 * src/widgets/modest-vbox-cell-renderer.c:
1625 (modest_vbox_cell_renderer_append):
1626 Fix the last commit by doing an extra ref.
1628 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1630 * src/widgets/modest-hbox-cell-renderer.c:
1631 (modest_hbox_cell_renderer_append):
1632 * src/widgets/modest-vbox-cell-renderer.c:
1633 (modest_vbox_cell_renderer_append):
1634 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1635 to fix the build with Maemo Bora.
1636 However, there seems to be a remaining crash, probably due to reference
1639 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1641 * src/modest-tny-account.c:
1642 (modest_tny_account_new_for_local_folders):
1643 Use hildon_file_system_info_async_new() to get a better name for
1644 the memory card account, setting it as the account name.
1645 The timing seems to work, but this is probably
1646 not the best place to do this. See the TODO comment.
1647 * src/maemo/modest-main-window.c: (create_details_widget):
1648 * src/widgets/modest-folder-view.c: (text_cell_data):
1649 Use the tny account name instead of hardcoding a name.
1651 2007-05-30 Christian Kellner <ckellner@openismus.com>
1653 * src/modest-search.c: (modest_search):
1654 Correctly set part_search_func even if we have already parsed
1655 the query and thus a valid OgsTextSearcher object.
1657 2007-05-30 Christian Kellner <ckellner@openismus.com>
1660 Search and check for libogs.
1663 Incooparte the ogs build env.
1665 * src/modest-mime-part-search-stream.c:
1666 * src/modest-mime-part-search-stream.h:
1667 Removed since we do the real searching now in modest-search.c.
1669 * src/modest-search.c:
1670 * src/modest-search.h:
1671 Implement support for ogs. We use that if available and requested
1672 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1673 should now handle the corner case when the search term is spread
1674 across multiple reads.
1675 Also the logic in modest_search () was corrected to search all
1676 requested fields until one is found.
1678 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1680 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1682 * src/modest-init.h:
1683 * src/modest-init.c: Made modest_init_local_folders() take a
1684 path and be public so we can iniitialize maildir folders on
1687 * src/modest-local-folder-info.h:
1688 * src/modest-local-folder-info.c:
1689 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1691 * src/modest-tny-account.c:
1692 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1693 still means the standard local-folders path on the local volume.
1695 * src/modest-tny-account-store.c:
1696 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1697 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1698 all accounts when that happens.
1699 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1700 this too, so it shows up in the treeview.
1702 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1704 * src/maemo/modest-maemo-global-settings-dialog.c:
1705 (current_connection):
1706 * src/widgets/modest-global-settings-dialog.c:
1707 (current_connection_default):
1708 Use the enum values instead of 0, 1 and -1,
1709 to make the code clearer.
1711 * src/modest-account-mgr-helpers.c:
1712 (modest_account_mgr_get_connection_specific_smtp): Make this code
1715 * src/modest-runtime.h:
1716 * src/modest-runtime.c:
1717 Added modest_runtime_remove_all_send_queues().
1718 * src/maemo/modest-main-window.c:
1719 (on_account_store_connecting_finished): Recreate the send queues,
1720 using the appropriate transport accounts for this new connection.
1721 Some futher adapting might be needed if the old send queues are not
1722 automatically stopped at this point.
1724 * src/modest-tny-account-store.c: (get_server_accounts):
1725 Create the connection-specific transport accounts, so that they can
1726 be found later by their ID.
1728 * src/modest-tny-account.h:
1729 * src/modest-tny-account.c:
1730 Added modest_tny_account_new_from_server_account_name().
1731 modest_tny_account_new_from_server_account(): Do not create the
1732 send queues here, because they will be
1733 recreated anyway when the connection changes for the first time.
1735 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1737 * src/modest-local-folder-info.h:
1738 * src/modest-local-folder-info.c:
1739 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1740 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1741 tbox_folder): Take a modest account name instead of a server TnyAccount,
1742 so we can have per-modest-account rather than per-transport-account
1744 We must make sure that we change or recreate the exisitng send queues
1745 when the connection changes for connection-specific transport accounts.
1747 * src/modest-tny-account-store.c:
1748 (create_per_account_local_outbox_folders): Create outboxed per modest
1749 account, not per transport account.
1751 * src/modest-tny-account.h:
1752 * src/modest-tny-account.c:
1753 (modest_tny_account_get_special_folder): For outboxes, get the
1754 parent modest account name. The account is ignored for other folders.
1755 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1756 modest account name rather than a server TnyAccount.
1758 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1760 * src/modest-tny-account.c:
1761 (modest_tny_account_new_from_server_account):
1762 Call modest_runtime_get_send_queue() immediately after creating transport
1763 accounts, so that they start trying to send email from the outbox as soon
1764 as possible at startup. This is probably what we want.
1766 * src/modest-mail-operation.c: (update_account_thread):
1767 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1768 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1769 * src/modest-tny-send-queue.h:
1770 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1771 (modest_ui_actions_on_send):
1772 Added comments about how sending works, though it needs some more work.
1774 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1776 * src/modest-tny-account.c:
1777 (modest_tny_account_get_special_folder): Add TODO because this fails when
1778 the network is busy.
1779 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1780 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1781 Do not try to show this window when there is no active account. The UI
1782 specs does not tell us what to do in this case.
1784 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1788 * src/maemo/Makefile.am:
1789 * src/widgets/Makefile.am: Some dist fixes.
1791 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1793 * src/maemo/modest-connection-specific-smtp-window.c:
1794 (on_button_edit): Make the code clearer, to prevent a double free.
1796 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1798 * src/maemo/modest-account-settings-dialog.c:
1799 (modest_account_settings_dialog_set_account_name),
1800 Check the connection-specific smtp servers checkbox if there are any.
1802 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1803 (modest_connection_specific_smtp_edit_window_init):
1804 Start with a suitable port number.
1806 * src/modest-account-mgr-helpers.h:
1807 * src/modest-account-mgr-helpers.c: Added
1808 modest_account_mgr_get_has_connection_specific_smtp().
1810 (modest_account_mgr_set_connection_specific_smtp),
1811 (modest_account_mgr_remove_connection_specific_smtp),
1812 (modest_account_mgr_get_has_connection_specific_smtp),
1813 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1814 connection-specific smtp server accounts in the account, rather than
1815 the server account conf dir.
1817 This fixes bug projects.maemo.org bug NB#58263 .
1819 * src/modest-tny-account-store.c:
1820 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1821 if there are no server accounts yet, to prevent an infinite loop when there
1822 are no accounts. Document that one must be called before the other.
1824 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-account-mgr-helpers.c:
1827 (modest_account_mgr_get_default_account): Make sure that at least
1828 one account is always the default, if there are any enabled accounts.
1829 This is just a sanity check that shouldn't be necessary.
1831 * src/modest-account-mgr-priv.c:
1832 (_modest_account_mgr_account_from_key): Unescape the conf key to
1833 get the real account name. For instance, this is an issue if a space
1834 was in the account name, which can happen because the account name
1835 is generated from the display name.
1836 (_modest_account_mgr_get_account_keyname): Always escape the
1838 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1839 Unescape the conf keys to get the real account names.
1841 For instance, previously the is-default radio button in the accounts
1842 list was not checked for any accounts at first. This fixes that,
1843 and might fix several similar bugs.
1845 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1847 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1848 Removed some debug printfs.
1850 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1852 Modest on-disk outbox directories are now here, for instance:
1853 $HOME/.modest/outboxes/<account-id-1>/outbox
1854 $HOME/.modest/outboxes/<account-id-2>/outbox
1856 $HOME/.modest/local-folders/outbox
1857 so we can have a separate outbox for each account.
1858 But they are shown as one outbox in the GtkTreeView, by using a
1859 TnyMergeFolder in a ModestTnySimpleFolderStore.
1862 * src/modest-tny-simple-folder-store.c:
1863 * src/modest-tny-simple-folder-store.h:
1864 Added ModestTnySimpleFolderStore, used to contain folders from
1865 other folder stores, such as other accounts.
1867 * src/modest-tny-outbox-account.h:
1868 * src/modest-tny-outbox-account.c:
1869 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1870 used for the per-account local outbox folders.
1872 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1873 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1874 only use this (internally) now for the non-outbox local folders.
1876 * src/modest-init.h:
1877 * src/modest-init.c: Added modest_init_one_local_folder(), for
1878 setting up the directory structure for each local folder.
1880 * src/modest-local-folder-info.c:
1881 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1882 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1884 * src/modest-local-folder-info.h:
1885 * src/modest-tny-account-store.c: (on_account_removed),
1886 (on_account_changed), (create_per_account_local_outbox_folders),
1887 (get_server_accounts), (modest_tny_account_store_get_accounts),
1888 (modest_tny_account_store_get_tny_account_by_account),
1889 (modest_tny_folder_store_is_virtual_local_folders):
1891 * src/modest-tny-account.h:
1892 * src/modest-tny-account.c:
1893 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1894 to create an on-disk per-account local outbox folder for each
1896 (create_per_account_local_outbox_folders): Create a local outbox folder
1897 for each transport account.
1898 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1899 for all local folders.
1901 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1902 instead of using g_object_get/set() directly. It is clearer.
1904 (modest_tny_folder_store_get_message_count),
1905 (modest_tny_folder_store_get_local_size
1906 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1907 because we now use these with non-acount folder stores.
1909 (modest_tny_account_get_special_folder),
1910 (modest_tny_account_new_from_server_account),
1911 (modest_tny_account_new_from_account):
1912 (recurse_folders): Adjust to the new outbox system.
1914 * src/modest-tny-folder.h:
1915 * src/modest-tny-folder.c:
1916 (modest_tny_folder_is_local_folder),
1917 (modest_tny_folder_get_local_folder_type),
1918 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1920 * src/widgets/modest-main-window.h:
1921 * src/maemo/modest-main-window.c: (create_details_widget),
1922 (modest_main_window_set_contents_style): Show details for any folder store,
1925 (modest_tny_folder_get_rules):
1926 Remove the const. C does not support constness enough for this.
1928 * src/modest-ui-actions.c:
1929 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1930 make all outboxes appear as one, in the usual local-folders tree node.
1932 (set_active_account_from_tny_account),
1933 (modest_ui_actions_on_folder_selection_changed):
1934 * src/widgets/modest-folder-view.c: (text_cell_data),
1935 (icon_cell_data), (filter_row),
1936 (add_account_folders_to_merged_folder),
1937 (add_account_folders_to_simple_folder_store), (),
1938 (get_cmp_rows_type_pos), (cmp_rows),
1939 (modest_folder_view_set_account_id_of_visible_server_account):
1940 Adjust to the new outbox system, using generic folder stores and folders
1941 in the GtkTreeModel.
1943 2007-05-23 Christian Kellner <ckellner@openismus.com>
1945 * src/modest-mail-operation.c:
1946 (modest_mail_operation_update_account):
1947 Use info->max_size instead of unintialized local var [small
1948 build fix]. (Added TODO to review that change since I don't
1951 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1953 * libmodest-dbus-client/libmodest-dbus-client.c:
1954 (libmodest_dbus_client_compose_mail): function added
1955 * src/dbus_api/modest-dbus-api.h:
1956 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1957 (on_compose_mail): Implementation of the SendAsMail functionality
1959 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1961 * src/modest-account-mgr.c:
1962 (modest_account_mgr_add_server_account): Set the secure-connection
1963 conf key for transport accounts as well as store accounts. I don't know
1964 why the if was there. For instance, this makes sure that we use SSL
1965 for the gmail preset from the easysetup wizard.
1967 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1969 * src/gnome/modest-main-window.c:
1970 (on_account_store_connecting_finished), (connect_signals):
1971 * src/maemo/modest-main-window.c:
1972 (on_account_store_connecting_finished), (connect_signals),
1973 (modest_main_window_new):
1974 Handle TnyAccountStore::connecting-finished instead of
1975 TnyDevice::connection-changed, because we cannot actually perform
1976 operations on accounts until TnyAccountStore has itself responded to
1977 the TnyDevice::connection-changed signal. This prevents a GError from
1979 Do not try to update at startup, because we (at least on scratchbox)
1980 already do an update at startup when the device goes online.
1981 This prevents a GError from tinymail.
1982 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1983 Added TODO about stopping simultaneous operations.
1985 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1988 * src/modest-mail-operation-queue.c:
1989 (modest_mail_operation_queue_remove):
1990 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1991 about where they happened.
1993 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1995 * src/modest-ui-actions.c:
1996 (modest_ui_actions_on_password_requested): Make sure that the remember
1997 output parameter is always TRUE.
1999 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2001 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2002 Show a OK/Cancel dialog if the error is a question, though we still do not
2003 know anything more about what we are asking the user.
2004 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2005 Fix an uninitialized variable (helper). This is a logic error, however.
2007 2007-05-21 Christian Kellner <ckellner@openismus.com>
2009 * src/modest-search.h:
2010 Correct bit shifting in the ModestSearchFlags enum.
2012 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2014 * src/modest-tny-account.c:
2015 (modest_tny_account_new_from_server_account): Do not use the lsub and
2016 check-all hard-coded IMAP options when using POP.
2018 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2020 * src/modest-tny-account.c:
2021 (modest_tny_account_new_from_server_account):
2022 Use NULL for the secure-auth method for POP when Password auth has been
2023 specified by the user, as we already do for IMAP. "auth=Login" causes
2024 an error from camel or the server.
2026 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/modest-account-settings-dialog.c:
2029 (create_page_account_details),
2030 (modest_account_settings_dialog_set_account_name):
2031 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2032 for the leave-on-server checkbox, rathr than just the checkbox, when
2033 the protocol is not POP.
2035 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2037 * src/widgets/modest-account-view.c:
2038 * src/widgets/modest-account-view.h:
2039 Added modest_account_view_select_account() which will be useful later
2040 to asynchronously re-select the edited account.
2042 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2044 * src/maemo/modest-account-settings-dialog.c:
2045 (modest_account_settings_dialog_set_account_name):
2046 Automatically choose the port numbers based on the secure authentication
2047 methods, if they have not been chosen before.
2048 This fixes projects.maemo.org bug NB#56273 .
2050 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2052 * src/maemo/modest-main-window-ui.h:
2053 * src/modest-ui-actions.c:
2054 * src/modest-ui-actions.h:
2055 Connect the Tools/SMTP Servers menu item to
2056 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2057 SMTP servers dialog, as in the UI specification and saves changes when it
2058 is closed. This fixed projects.maemo.org bug NB#56305 .
2060 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2062 * src/maemo/modest-connection-specific-smtp-window.c:
2063 (modest_connection_specific_smtp_window_init):
2064 Use gtk_window_set_default_size() to make this window big enough, so
2065 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2067 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2070 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2071 (modest_connection_specific_smtp_edit_window_init),
2072 Do not try to connect to a combobox signal before the combobox exists.
2073 This fixes the cras in projects.maemo.org bug NB#56288 .
2074 (modest_connection_specific_smtp_edit_window_get_settings):
2075 Remove the server_account_name parameter which was being checked for NULL
2076 though it was not used.
2078 * src/maemo/modest-connection-specific-smtp-window.c:
2079 (modest_connection_specific_smtp_window_fill_with_connections),
2080 (on_button_edit), (modest_connection_specific_smtp_window_init):
2081 Correct the number of treemodel columns to prevent a warning.
2082 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2083 libconic does not work.
2085 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2087 * src/modest-tny-account.c:
2088 (modest_tny_account_new_from_server_account):
2089 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2090 SMTP when "None" was chosen by the user. However, with my SMTP server that
2091 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2094 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2096 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2097 to explain the memory management issue with the ID in the ModestPair.
2099 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2100 (add_sending_page), (modest_account_assistant_finalize):
2101 * src/gnome/modest-gnome-global-settings-dialog.c:
2102 (create_updating_page), (create_composing_page):
2103 * src/gnome/modest-msg-edit-window.c: (get_transports),
2104 (init_window), (modest_msg_edit_window_finalize),
2105 (modest_msg_edit_window_get_msg_data):
2106 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2107 * src/gnome/modest-transport-widget.c:
2108 (modest_transport_widget_finalize), (smtp_configuration):
2109 * src/maemo/modest-maemo-global-settings-dialog.c:
2110 (create_updating_page), (create_composing_page):
2111 * src/maemo/modest-msg-edit-window.c: (get_transports),
2112 (init_window), (modest_msg_edit_window_finalize),
2113 (modest_msg_edit_window_get_msg_data),
2114 (modest_msg_edit_window_free_msg_data):
2115 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2116 (modest_store_widget_finalize):
2117 * src/maemo/modest-transport-widget.c:
2118 (modest_transport_widget_finalize), (smtp_configuration):
2119 * src/modest-main.c: (send_mail):
2120 * src/widgets/modest-combo-box.h:
2121 * src/widgets/modest-global-settings-dialog-priv.h:
2122 * src/widgets/modest-global-settings-dialog.c:
2123 (modest_global_settings_dialog_finalize):
2124 * src/widgets/modest-msg-edit-window.h:
2125 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2126 as long as the combo box, to prevent use of freed memory for the ID.
2128 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2130 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2131 get_accounts(), to make this clearer. Do not check for the enabled gconf
2132 key, because we do not use this for server accounts (at least, not yet).
2133 This allows us to send email again.
2135 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2137 * src/maemo/modest-platform.c:
2138 (on_modest_conf_update_interval_changed), (modest_platform_init):
2139 Only respond to this particular key change. All these strcmp()s cannot be
2142 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2144 * src/maemo/modest-maemo-global-settings-dialog.c:
2145 (current_connection): Prevent a crash in scratchbox when
2146 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2147 * src/maemo/modest-platform.c:
2148 (on_modest_conf_update_interval_changed), (modest_platform_init):
2149 Get the update interval from gconf and reset it when the gconf key changes.
2151 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2153 * src/modest-protocol-info.c:
2154 * src/modest-protocol-info.h: Adde enum-specific get functions,
2155 instead of using a ModestProtocolType enum parameter.
2157 * src/gnome/modest-account-assistant.c:
2158 * src/gnome/modest-store-widget.c:
2159 * src/gnome/modest-store-widget.h:
2160 * src/gnome/modest-transport-widget.c:
2161 * src/gnome/modest-transport-widget.h:
2162 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2163 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2164 * src/maemo/easysetup/modest-easysetup-wizard.c:
2165 * src/maemo/modest-account-settings-dialog.c:
2166 * src/maemo/modest-account-settings-dialog.h:
2167 * src/maemo/modest-store-widget.c:
2168 * src/maemo/modest-store-widget.h:
2169 * src/maemo/modest-transport-widget.c:
2170 * src/maemo/modest-transport-widget.h:
2171 * src/modest-account-mgr-helpers.c:
2172 * src/modest-account-mgr-helpers.h:
2173 * src/modest-account-mgr.c:
2174 * src/modest-account-mgr.h:
2175 * src/modest-tny-account.c:
2176 * src/modest-tny-folder.c:
2177 * src/widgets/modest-account-view.c:
2178 * src/widgets/modest-retrieve-combo-box.c:
2179 * src/widgets/modest-retrieve-combo-box.h:
2180 * src/widgets/modest-secureauth-combo-box.c:
2181 * src/widgets/modest-serversecurity-combo-box.c:
2182 * src/widgets/modest-serversecurity-combo-box.h:
2183 * tests/check_account-mgr.c:
2184 Use the specific functions, and use the re-renamed enum values for GNOME too.
2186 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2188 * src/modest-pair.h:
2189 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2190 so we can get the second based on the first.
2192 * src/maemo/modest-account-settings-dialog.h:
2193 * src/maemo/modest-account-settings-dialog.c:
2194 Added get_supported_secure_authentication_methods(), though it is mostly
2195 commented-out for now until the necessary API is committed to tinymail.
2196 (modest_account_settings_dialog_set_account_name),
2197 (save_configuration): Request the supported authentication methods from the
2198 server, so we can choose a working method.
2200 * src/modest-tny-account-store.h:
2201 * src/modest-tny-account-store.c:
2202 (modest_tny_account_store_get_session): Rename from
2203 tny_account_store_get_session().
2205 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2207 * src/modest-protocol-info.h: Split the ModestProtocol enum
2208 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2209 There was no need to have these unrelated values in one enum.
2211 * src/: many files: Adapted to changed enum. This makes the code a bit
2212 clearer, and the compiler could catch some errors.
2214 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2216 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2217 Show the detailed internal camel error message when an error happens
2218 during the configuration, so that our testers can give us more clues.
2219 For instance, in projects.maemo.org bug NB#56910 .
2221 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2223 * src/modest-tny-account.c:
2224 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2225 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2227 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2229 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2230 * src/maemo/modest-account-settings-dialog.c:
2231 (modest_account_settings_dialog_set_account_name),
2232 (save_configuration): For the incoming secure authentication checkbox,
2233 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2234 the UI specification. PLAIN does not seem to be supported for most IMAP
2235 servers anyway, and I am not sure what it would mean.
2236 However, we probably need to discover which of the secure-authentication
2237 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2238 * src/modest-account-mgr-helpers.c:
2239 (modest_account_mgr_get_server_account_data):
2241 * src/modest-tny-account.c:
2242 (modest_tny_account_new_from_server_account):
2243 Use tny_account_set_mech() to set secure-authentication methods,
2244 with some special-casing for IMAP, based on my observations of how
2247 * src/modest-account-mgr-helpers.h:
2248 * src/modest-account-mgr.c:
2249 * src/modest-defs.h: Comment that the URI is only used for local folders.
2251 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2253 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2254 parameter const, just to be neat.
2255 * src/modest-text-utils.c: (modest_text_utils_inline):
2256 End g_strconcat() with NULL, as its documentation says. This is almost
2257 certainly the cause of my crash at startup on the device. Interestingly,
2258 valgrind doesn't tell us about these errors.
2260 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2262 * scripts/build-packages: Added more precise comments about how to use
2263 this script, though I still get this error:
2264 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2265 error building tinymail
2267 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2269 * src/maemo/modest-main-window.c: (on_account_update):
2270 Very slight cleanup, hoping to make it simpler to discover what causes
2271 a crash here sometimes.
2273 * src/modest-tny-account.c:
2274 (modest_tny_account_new_from_server_account): Set the port. Added
2275 comments about the options and a TODO comment because I need to find out
2276 how to specify the secure authentication method.
2278 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2280 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2281 changed CFlags paths form modest to libmodest
2283 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2285 * src/modest-account-mgr-helpers.c:
2286 (modest_account_mgr_get_server_account_data),
2287 (modest_account_mgr_free_server_account_data):
2288 * src/modest-account-mgr-helpers.h:
2289 * src/modest-account-mgr.c:
2290 (modest_account_mgr_add_server_account):
2291 * src/modest-defs.h:
2292 * src/modest-tny-account.c:
2293 (modest_tny_account_new_from_server_account):
2294 Determine the options for tny_camel_account_add_option() here,
2295 based on the settings, rather than storing them directly in gconf.
2297 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2299 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2300 Show a more friendly error dialog now that we expect (from the tinymail
2301 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2303 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2305 * src/maemo/modest-main-window.c: (on_account_update): Check that
2306 account_name is not NULL, to prevent a crash at startup that I am
2307 seeing on the N800. I do wonder why it is NULL.
2309 * src/maemo/easysetup/modest-easysetup-wizard.c:
2310 (create_page_user_details):
2311 * src/maemo/modest-account-settings-dialog.c:
2312 (create_page_user_details), (create_page_outgoing):
2313 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2314 (modest_connection_specific_smtp_edit_window_init):
2315 * src/modest-ui-actions.c:
2316 (modest_ui_actions_on_password_requested):
2317 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2318 might do something useful with the on-screen keyboard.
2320 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2322 * src/maemo/modest-main-window.c: (on_account_update):
2323 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2324 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2326 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2328 * src/modest-tny-account-store.c: (on_account_changed):
2329 Correct the signature of this signal handler.
2331 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2333 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2334 Show a HildonNote instead of a GtkDialog for Maemo.
2336 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2338 * src/widgets/modest-account-view.h:
2339 * src/widgets/modest-account-view.c: (on_account_changed),
2340 (on_account_removed). Added a boolean flag, set/unset by
2341 modest_account_view_block_conf_updates(),
2342 modest_account_view_unblock_conf_updates() to prevent unnecessary
2343 updates, but this is not very useful because the gconf notifications are
2344 so delays (maybe only on Maemo Bora).
2345 So auto-updating is turned off, and these functions do an explicit
2346 update when necessary.
2347 However, something else is still doing too much work when adding/removing
2348 accounts, probably in another part of the application.
2350 * src/maemo/modest-account-view-window.c:
2351 (on_delete_button_clicked), (on_edit_button_clicked),
2352 (on_new_button_clicked): Use the new functions.
2354 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2356 * src/modest-account-mgr-helpers.c:
2357 (modest_account_mgr_set_first_account_as_default):
2358 Sort the list of names alphabetically-by-title, so we choose the first one
2360 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2361 alphabetically by the title.
2363 This fixes projects.maemo.org bug NB#56418 .
2365 * src/modest-account-mgr-priv.c:
2366 (_modest_account_mgr_account_from_key):
2367 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2368 avoid a valgrind error, and possible random behaviour.
2370 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2372 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2373 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2374 tinymail documentation to say that this can be expected.
2375 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2376 pretty, and should not happen, but I would prefer to know when it does.
2378 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2380 * configure.ac: When using the older hildon version, probably on Bora,
2381 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2383 * src/widgets/modest-attachment-view.c:
2384 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2387 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2389 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2390 Implemented the prototype. Can be tested with
2391 tests/dbus_api/test_open_message:
2393 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2395 * src/modest-tny-account-store.c:
2396 (modest_tny_account_store_instance_init), (get_password):
2397 * src/modest-ui-actions.c:
2398 (modest_ui_actions_on_password_requested):
2399 Do not store the password in gconf, because this function is called
2400 for non-remembered passwords. Actually use the cached (in the hash map)
2401 password instead of releasing it.
2402 The password will now not be remembered if it is asked via the protected
2403 password dialog, as per the UI spec.
2405 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2407 * src/modest-defs.h:
2408 * src/modest-account-mgr-helpers.h:
2409 * src/modest-account-mgr-helpers.c:
2410 Added modest_server_account_get_username_has_succeeded(),
2411 modest_server_account_set_username_has_succeeded().
2412 (modest_server_account_set_username),
2413 Reset the has-succeeded flag if the username changes.
2415 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2416 * src/maemo/modest-connection-specific-smtp-window.c:
2417 (modest_connection_specific_smtp_window_save_server_accounts):
2418 Use modest_server_account_set_username() instead of using
2419 modest_conf_set_string() directly, so that the has-succeeded flag is always
2422 * src/modest-ui-actions.c:
2423 (modest_ui_actions_on_password_requested): Dim the username entry if
2424 the username has ever worked, as per the UI spec.
2426 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2428 * src/modest-tny-account-store.c: (get_password):
2429 * src/modest-ui-actions.c:
2430 (modest_ui_actions_on_password_requested):
2431 Allow the username to be changed too, though there is more work to
2432 be done on exactly how this behaves.
2434 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2436 * src/modest-account-mgr-helpers.h:
2437 * src/modest-account-mgr-helpers.c:
2438 Added modest_account_mgr_get_display_name(),
2439 modest_server_account_get_username(),
2440 modest_server_account_set_username(),
2441 modest_server_account_set_password(),
2442 modest_server_account_get_hostname() functions so we do not need to
2443 use the conf API directly.
2445 * src/maemo/modest-main-window.c: (connect_signals):
2446 Actually connect ot the ModestAccountStore::request-password signal,
2447 so that we show the dialog when the password is requested by Tinymail,
2448 for isntance if it is empty.
2450 * src/modest-marshal.list:
2451 * src/modest-tny-account-store.c:
2452 (modest_tny_account_store_class_init), (get_password),
2453 (modest_tny_account_store_alert):
2454 * src/modest-tny-account-store.h:
2455 * src/modest-ui-actions.h:
2456 * src/modest-ui-actions.c:
2457 (modest_ui_actions_on_password_requested):
2458 Change the signal parameters, so it is obvious that we are providing
2459 the non human-readable server name, and receiving both the username
2460 and password, though changing of the username is not yet implemented.
2461 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2462 for the GNOME version.
2464 This should fix the projects.maemo.org bug NB#56209, though it does not
2465 work on Bora, because the gconf_client_get() for the password fails
2466 immediately after we save it with gconf_client_set().
2468 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2471 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2472 caused an undefined symbol error:
2473 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2475 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2477 * src/modest-tny-account-store.c:
2478 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2479 using a GError instead of a string message, so we can translate it in
2482 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2484 * src/maemo/modest-address-book.c:
2485 (modest_address_book_check_names):
2486 * src/maemo/modest-msg-view-window.c:
2487 (modest_msg_view_window_clipboard_owner_change):
2488 * src/modest-init.c: (modest_init_init_ui):
2489 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2490 (update_folders_cb), (modest_mail_operation_update_account):
2491 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2492 (modest_ui_actions_on_msg_attachment_clicked),
2493 (modest_ui_actions_on_msg_recpt_activated):
2494 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2495 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2496 (modest_msg_view_search_next):
2497 * src/widgets/modest-recpt-editor.c:
2498 (modest_recpt_editor_on_button_release_event),
2499 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2500 g_message(). At this point we should only be seeing interesting errors on
2501 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2503 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2505 (modest_wizard_dialog_force_title_update):
2506 * src/maemo/easysetup/modest-wizard-dialog.h:
2507 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2508 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2509 can update the title when appropriate. Otherwise the title is wrong if the
2510 pages are added after adding the notebook to the dialog.
2511 This must be a problem in HildonWizardDialog too.
2512 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2514 * src/maemo/easysetup/modest-easysetup-wizard.c:
2515 (create_subsequent_customsetup_pages),
2516 (create_subsequent_easysetup_pages):
2517 Call modest_wizard_dialog_force_title_update() so that the title is
2518 correct even with GTK+ < 2.10.
2519 This fixes projects.maemo.org bug NB#56145 .
2521 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2523 * src/maemo/modest-platform.c:
2524 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2525 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2528 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2530 * src/widgets/modest-window.h:
2531 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2532 and modest_window_save_state(), which invokes it.
2534 * src/widgets/modest-window-mgr.h:
2535 * src/widgets/modest-window-mgr.c:
2536 Added modest_window_mgr_save_state_for_all_windows(), which calls
2537 the save_state vfunc on all registered windows, if implemented.
2539 * src/gnome/modest-msg-edit-window.c:
2540 * src/gnome/modest-msg-view-window.c:
2541 * src/maemo/modest-msg-edit-window.c:
2542 * src/maemo/modest-msg-view-window.c:
2543 * src/maemo/modest-main-window.c:
2544 Specify the existing save_settings functions as implementations of
2545 ModestWindow::save_state_func().
2547 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2548 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2549 enabling hibernation, for instance.
2551 We may need to do the same thing for restoring settings.
2554 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2556 * src/widgets/modest-window-mgr.c:
2557 * src/widgets/modest-window-mgr.h:
2558 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2559 modest_window_mgr_get_hibernation_is_prevented().
2561 * src/maemo/modest-main-window.c:
2562 (on_hildon_program_is_topmost_notify): Prevent hibernation
2563 (possible when the application goes to the background in the WM),
2564 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2566 * src/maemo/easysetup/modest-easysetup-wizard.c:
2567 (modest_easysetup_wizard_dialog_init):
2568 * src/maemo/modest-account-settings-dialog.c:
2569 (modest_account_settings_dialog_init):
2570 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2571 (modest_connection_specific_smtp_edit_window_init):
2572 * src/maemo/modest-connection-specific-smtp-window.c:
2573 (modest_connection_specific_smtp_window_init):
2574 * src/maemo/modest-signature-editor-dialog.c:
2575 (modest_signature_editor_dialog_init):
2576 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2577 prevent hibernation while any of these account settings dialogs are open.
2579 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2581 * src/maemo/Makefile.am:
2582 * src/maemo/modest-osso-state-saving.c:
2583 * src/maemo/modest-osso-state-saving.h: Added
2584 modest_osso_load_state() and modest_osso_save_state() though they do
2585 nothing now. They should iterate through all the open windows and load/save
2587 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2588 save state when closing.
2590 * src/maemo/modest-main-window.c:
2591 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2592 Add a notification handler for the HildonProgram::is-topmost property,
2593 so we can allow hibernation when the application goes into the background.
2594 But we still need to detect when the accounts setup windows are open so
2595 we can stop hibernation when they are open.
2596 To do this, I also added the main window the HildonProgram. This might have
2597 other side-effects/benefits, and should maybe be done for other windows.
2599 * src/maemo/modest-osso-autosave-callbacks.h:
2600 * src/maemo/modest-osso-autosave-callbacks.c:
2601 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2602 though it does not do anything yet, and we might never need this to do
2603 anything. For instance, we already save drafts.
2605 * src/maemo/modest-platform.c: (modest_platform_init):
2606 Specify the libosso auto-save callback.
2608 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2610 * src/maemo/modest-platform.c:
2611 (modest_platform_set_update_interval):
2612 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2613 aparently stays valid between application instances, so we can use this
2614 to remove and reset it later. According to a maemo-developers email from
2617 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2619 * configure.ac: Depend on libalarm for Maemo.
2621 * src/dbus_api/modest-dbus-api.h:
2622 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2623 (on_send_receive), (modest_dbus_req_handler):
2624 Handle a SEND_RECEIVE D-Bus method.
2626 * libmodest-dbus-client/libmodest-dbus-client.c:
2627 (libmodest_dbus_client_send_and_receive):
2628 * libmodest-dbus-client/libmodest-dbus-client.h:
2629 Add C convenience functions for calling the new D-Bus method.
2631 * src/modest-platform.h:
2632 * src/gnome/modest-platform.c:
2633 * src/maemo/modest-platform.c:
2634 Added modest_platform_set_update_interval(), which uses the
2635 alarmd API on Maemo.
2636 (modest_platform_init),
2637 Call modest_platform_set_update_interval(), using a hard-coded
2638 interval for now (until the global settings dialog is implemented),
2639 though I am not sure that this makes sense yet.
2641 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2643 * src/dbus_api/modest-dbus-callbacks.c:
2644 (modest_osso_cb_hw_state_handler):
2645 * src/dbus_api/modest-dbus-callbacks.h:
2646 * src/maemo/modest-platform.c: (modest_platform_init):
2647 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2648 in case this has some effect on the ability for Maemo to ping the
2651 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2653 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2654 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2655 warning. It is probably a logic error, but I need to fix the build.
2657 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2659 * src/modest-account-mgr.h:
2660 * src/modest-account-mgr.c:
2661 (modest_account_mgr_account_names): Add a gboolean enabled_only
2662 parameter, so we can get lists of onlt the enabled accounts.
2664 (modest_account_mgr_add_account),,
2665 (modest_account_mgr_account_with_display_name_exists):
2666 * src/maemo/modest-msg-edit-window.c: (get_transports):
2667 * src/modest-account-mgr-helpers.c:
2668 (modest_account_mgr_set_first_account_as_default):
2669 * src/modest-init.c: (init_default_account_maybe):
2670 * src/modest-tny-account-store.c: (get_accounts):
2671 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2672 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2673 * tests/check_account-mgr.c: (START_TEST):
2674 Provide the extra parameter, as appropriate.
2676 * src/widgets/modest-account-view.c: (update_account_view):
2677 Do not show disabled accounts (meaning that there is no way to
2678 enable/disable accounts in the UI (the feature is not in our UI
2679 specification), so we can use this internally only to mark unfinished
2680 or temporary account data.
2682 * src/maemo/easysetup/modest-easysetup-wizard.c:
2683 (create_account): Add boolean enable parameter, so we can specify FALSE
2684 to create the temporary account.
2685 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2686 (on_before_next): When finishing, when there is a temporary account, just
2688 Also, use a timeout to delay the showing of the dialog until gconf is likely
2689 to return correct information, due to a maemo gconf bug that is fixed in
2690 osso 1.1, but not yet in Bora.
2691 However, the dialog stays on screen after it is destroyed.
2693 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2694 for invalid data when cancelling. Use a hildon note instead of a dialog
2695 to complain about invalid data. Do not show the account-saved note if the
2696 account is disabled (a temporary account that will not really be saved for use
2699 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2701 * src/modest-account-mgr-helpers.h:
2702 * src/modest-account-mgr-helpers.c:
2703 Added modest_account_mgr_unset_default_account(),
2704 Added modest_account_mgr_set_first_account_as_default().
2706 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2707 If it was the default account, unset the default account name.
2709 * src/maemo/modest-account-view-window.c:
2710 (on_delete_button_clicked): If it was the default account,
2711 set the first remaining account as the default instead.
2713 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2714 a NULL account or a NULL default account, to prevent a crash. This should
2715 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2718 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2720 * src/widgets/modest-recpt-editor.c:
2721 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2722 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2723 TODO comment for this. This fixes the build.
2725 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2726 be the best place for it. This will in future update all auto-update accounts,
2727 rather than just the current/default account, when that gconf key exists.
2728 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2729 if there are no accounts, before calling do_send_receive().
2730 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2732 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2733 * src/maemo/modest-main-window-ui.h:
2734 * src/maemo/modest-main-window.c: (on_connection_changed),
2735 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2736 directly, becaue the signal handler does more.
2738 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2740 * src/modest-account-mgr-helpers.c:
2741 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2742 for the case that the account does not exist.
2744 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2745 (equivalent to the modest account name) rather than the tinymail account name
2746 (equivalent to the modest account title - human readable) to get the account data.
2747 Check for null account data to prevent the crash, and add a TODO comment saying that
2748 this needs fixing because it is using the server account name instead of the account name.
2750 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2753 * src/maemo/modest-account-settings-dialog.c: (show_error),
2755 Use hildon_note_new_information() for informative and error messages,
2756 which seems to be expected for Maemo applications (no documentation that I know of
2757 says this). I am surprised that there is no distinction between info and error
2760 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2763 it is easy to find where this is used.
2765 * src/maemo/easysetup/modest-easysetup-wizard.c:
2766 (create_page_welcome), (create_page_account_details),
2767 (create_page_user_details), (create_page_complete_easysetup),
2768 (create_page_custom_incoming), (create_page_custom_outgoing),
2769 (create_page_complete_custom):
2770 * src/maemo/modest-account-settings-dialog.c:
2771 (create_page_account_details), (create_page_user_details),
2772 (create_page_incoming), (create_page_outgoing):
2773 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2774 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2775 (modest_connection_specific_smtp_edit_window_init):
2776 * src/maemo/modest-connection-specific-smtp-window.c:
2777 (modest_connection_specific_smtp_window_init):
2778 * src/maemo/modest-signature-editor-dialog.c:
2779 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2780 and scrolling policy as per the Email Application Layout Guide, if I have
2783 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2785 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2786 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2787 which were empty, because these vfuncs have been removed from TnyAccountStore.
2788 This fixes the build.
2790 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2792 * src/maemo/modest-main-window.c:
2793 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2794 showing/hiding it. Added TODO because it probably should not be NULL.
2795 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2796 because unnecessary g_warnings() make degugging difficult.
2798 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2800 * src/maemo/modest-msg-edit-window.c:
2801 (modest_msg_edit_window_select_color),
2802 (modest_msg_edit_window_select_background_color): 2 const corrections and
2803 moving 2 #endifs before closing brackets, to fix the build.
2805 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2807 * src/maemo/easysetup/modest-easysetup-wizard.h:
2808 * src/maemo/easysetup/modest-easysetup-wizard.c:
2809 (modest_easysetup_wizard_dialog_finalize),
2810 (on_button_edit_advanced_settings), (create_page_complete_custom),
2811 (on_response), (create_account):
2812 Implement the Advanced Settings edit button, by saving the account information,
2813 for the Advanded Settings dialog to use directly from gconf, and removing it
2814 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2815 Bug #5533 in the projects.maemo.org bugzilla.
2817 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2819 * src/maemo/modest-msg-view-window.c:
2820 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2821 when opening a message window.
2823 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2825 * src/maemo/easysetup/modest-easysetup-wizard.c:
2826 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2829 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2830 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2831 gconf settings. I probably added more checks than necessary, but that is safer.
2833 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2834 variable to fix the build, but this seems to be used when it is still NULL.
2836 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2838 * src/modest-platform.h:
2839 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2840 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2841 * src/modest-main.c: Implement this function so we can avoid using
2842 maemo-specific API from cross-platform code.
2844 * src/modest-tny-account-store.c:
2845 (get_smtp_specific_transport_account_for_open_connection):
2846 * src/modest-ui-actions.c: (check_for_connection),
2847 (modest_ui_actions_on_item_not_found):
2848 Use modest_platform_connect_and_wait() and put #idefs around other
2849 maemo-specific code, because only maemo currently has a way to
2850 identify connection names.
2852 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2854 * src/modest-tny-account-store.h:
2855 * src/modest-tny-account-store.c:
2856 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2857 the connection-specific SMTP server settings in the configuration.
2859 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2861 * src/maemo/modest-main-window.c: (on_connection_changed),
2863 * src/modest-main.c: (main), (start_ui), (send_mail):
2864 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2865 that is what is intended.
2867 * src/modest-ui-actions.c: (action_send), (action_receive),
2868 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2869 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2870 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2871 SMTP server is used when it is specified.
2873 (modest_ui_actions_on_send_receive):
2874 Check that a connection is open before proceeding.
2875 Receive and then send, instead of vice-versa, as per the specification.
2877 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2879 * src/modest-mail-operation.c:
2880 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2881 though I guess it should be something other than NULL.
2883 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2885 * src/maemo/easysetup/modest-easysetup-wizard.c:
2886 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2887 combo twice, to avoid an g_warning and to make it visible again.
2888 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2889 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2890 (already intended) dereference when detaching, because we then recreate the menu.
2891 But I am not sure why the warning was happening, and it is possible that this is a memory
2894 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2896 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2897 and uri_parse_mailto() utility functions.
2898 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2900 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2902 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2904 * src/dbus_api/modest-dbus-api.h:
2905 * src/dbus_api/modest-dbus-callbacks.c:
2906 Use an idle callback to execute the modest code in the application's own thread.
2907 Remove the helloworld example method.
2908 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2909 parsed, and the open-message method is not implemented because this is not yet implemented in
2911 * libmodest-dbus-client/libmodest-dbus-client.c:
2912 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2913 (libmodest_dbus_client_open_message):
2914 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2916 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2917 body without crashing.
2919 * tests/dbus_api/Makefile.am:
2920 * tests/dbus_api/test_mail_to.c:
2921 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2923 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2925 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2926 Added file to fix the build. Sorry.
2928 * src/dbus_api/Makefile.am:
2929 * src/dbus_api/modest-dbus-api.h:
2930 * src/dbus_api/modest-dbus-callbacks.h:
2931 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2932 (modest_dbus_req_handler):
2933 Put constants in a separate header so it can be reused by the
2934 client library, without duplication
2936 * libmodest-dbus-client/Makefile.am:
2937 * libmodest-dbus-client/libmodest-dbus-client.c:
2938 (libmodest_dbus_client_call_helloworld),
2939 (libmodfest_dbus_client_send_mail),
2940 (libmodfest_dbus_client_mailto),
2941 (libmodfest_dbus_client_open_message):
2942 * libmodest-dbus-client/libmodest-dbus-client.h:
2943 (Partly) Implement a send_mail D-Bus method.
2945 * tests/dbus_api/Makefile.am:
2946 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2947 the send_email D-Bus method.
2949 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2953 * libmodest-dbus-client/Makefile.am:
2954 * libmodest-dbus-client/libmodest-dbus-client.c:
2955 * libmodest-dbus-client/libmodest-dbus-client.h:
2956 * tests/dbus_api/Makefile.am:
2957 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2958 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2960 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2962 * src/maemo/easysetup/modest-easysetup-wizard.c:
2963 (create_page_account_details):
2964 * src/maemo/modest-account-settings-dialog.c:
2965 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2966 widgets, because this might not be the default in future versions of the Maemo GTK+.
2967 However, I can not not get capitalization to work even in a simple test case.
2969 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2971 * src/maemo/easysetup/modest-easysetup-wizard.c:
2972 (create_page_custom_incoming), (create_page_custom_outgoing):
2973 * src/maemo/modest-account-settings-dialog.c:
2974 (create_page_account_details), (create_page_incoming),
2975 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2976 instead of using gtk_check_button_with_label(), so they are aligned like the other
2977 widgets, as per the UI spec.
2979 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2981 * src/maemo/easysetup/modest-easysetup-wizard.c:
2982 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2983 * src/widgets/modest-validating-entry.c:
2984 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2985 Modest prefix instead of an EasySetup prefix.
2987 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2989 * src/widgets/modest-validating-entry.h:
2990 * src/widgets/modest-validating-entry.c: (on_insert_text),
2991 Added easysetup_validating_entry_set_max_func(), used to set a callback
2992 to call when the max number of characters is reached. GtkEntry has a max-length
2993 already but is silent about it.
2995 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2996 (create_page_account_details), (create_page_user_details),
2998 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2999 (create_page_account_details), (create_page_user_details),
3000 (create_page_outgoing):
3001 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3002 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3003 the UI spec, when the user tries to enter more than the max number of characters.
3005 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3007 * src/maemo/easysetup/modest-easysetup-wizard.c:
3008 (create_page_user_details), (create_page_custom_incoming),
3009 (create_page_custom_outgoing):
3010 * src/maemo/modest-account-settings-dialog.c:
3011 (create_page_user_details), (create_page_incoming),
3012 (create_page_outgoing):
3013 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3014 (modest_connection_specific_smtp_edit_window_init):
3015 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3016 not appropriate. Bad Maemo-specific defaults!.
3018 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3020 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3021 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3022 (modest_signature_editor_dialog_set_settings):
3023 Disable the label and textview when the checkbox is disabled, and use the
3024 specified (UI spec) default signature text.
3026 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3028 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3029 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3031 * src/modest-defs.h:
3032 * src/modest-account-mgr-helpers.h:
3033 * src/modest-account-mgr-helpers.c:
3034 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3036 * src/maemo/Makefile.am:
3037 * src/maemo/modest-signature-editor-dialog.c:
3038 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3041 * src/maemo/modest-account-settings-dialog.h:
3042 * src/maemo/modest-account-settings-dialog.c:
3043 (modest_account_settings_dialog_finalize), (on_button_signature),
3044 (save_configuration): Use the new dialog when the Edit button is pressed, and
3045 save the changes if necessary, as per the UI spec.
3047 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3049 * src/maemo/Makefile.am:
3050 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3051 based on maemo-develoers email from Dirk.
3053 * src/maemo/easysetup/modest-easysetup-wizard.c:
3054 (create_page_welcome), (create_page_account_details),
3055 (create_page_user_details), (create_page_complete_easysetup),
3056 (create_page_custom_incoming), (create_page_custom_outgoing),
3057 (create_page_complete_custom),
3058 (modest_easysetup_wizard_dialog_init):
3059 * src/maemo/modest-account-settings-dialog.c:
3060 (create_page_account_details), (create_page_user_details),
3061 (create_page_incoming), (create_page_outgoing),
3062 (modest_account_settings_dialog_init):
3063 * src/maemo/modest-connection-specific-smtp-window.c:
3064 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3066 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3068 * src/maemo/easysetup/modest-easysetup-wizard.c:
3069 (create_page_account_details), (create_page_custom_outgoing),
3070 (create_page_complete_custom):
3071 * src/maemo/modest-account-settings-dialog.c:
3072 (create_page_user_details), (create_page_incoming),
3073 (create_page_outgoing):
3074 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3075 (modest_connection_specific_smtp_edit_window_init):
3076 Use the correct (UI spec) port min/max, and use horizontal separators,
3079 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3081 * src/maemo/easysetup/modest-easysetup-wizard.c:
3082 (set_default_custom_servernames):
3083 * src/maemo/modest-account-settings-dialog.c:
3084 (create_page_incoming), (on_combo_outgoing_security_changed),
3085 (on_combo_incoming_security_changed), (create_page_outgoing),
3086 (modest_account_settings_dialog_set_account_name),
3087 (save_configuration):
3088 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3089 (on_combo_security_changed),
3090 (modest_connection_specific_smtp_edit_window_init),
3091 (modest_connection_specific_smtp_edit_window_set_connection),
3092 (modest_connection_specific_smtp_edit_window_get_settings):
3093 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3096 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3099 * src/maemo/easysetup/modest-easysetup-wizard.c:
3100 (create_page_custom_outgoing), (create_page_complete_custom):
3101 * src/maemo/modest-account-settings-dialog.c:
3102 (create_page_user_details), (create_page_outgoing):
3103 * src/maemo/modest-account-view-window.c: (button_box_new):
3104 Use changed logical IDs as per the most recent UI spec:
3105 mcen_bd_emailsetup_edit -> mcen_bd_edit
3106 mcen_bd_emailsetup_delete -> mcen_bd_delete
3107 mcen_bd_emailsetup_close -> mcen_bd_close
3109 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3113 * src/dbus_api/Makefile.am:
3114 * src/dbus_api/modest-dbus-callbacks.c:
3115 * src/dbus_api/modest-dbus-callbacks.h:
3116 * src/maemo/modest-platform.c: (modest_platform_init):
3117 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3119 * tests/Makefile.am:
3120 * tests/dbus_api/Makefile.am:
3121 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3123 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3125 * src/maemo/modest-account-settings-dialog.c:
3126 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3127 Removed unnecessary includes.
3129 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3131 * src/maemo/easysetup/modest-easysetup-wizard.c:
3132 * src/maemo/modest-account-settings-dialog.c:
3133 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3134 * src/widgets/Makefile.am:
3135 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3136 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3137 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3138 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3139 * src/widgets/modest-secureauth-combo-box.c:
3140 * src/widgets/modest-secureauth-combo-box.h:
3141 * src/widgets/modest-serversecurity-combo-box.c:
3142 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3143 made the GObject names more consistent with the rest of the Modest code.
3145 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3147 * src/maemo/easysetup/Makefile.am:
3148 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3149 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3150 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3151 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3152 * src/maemo/easysetup/modest-easysetup-wizard.c:
3153 * src/maemo/easysetup/modest-validating-entry.c:
3154 * src/maemo/easysetup/modest-validating-entry.h:
3155 * src/maemo/modest-account-settings-dialog.c:
3156 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3157 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3158 widgets/ because they are used outside of easysetup too. After checking in,
3159 svn will allow me to rename them too.
3161 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3163 * src/gnome/modest-msg-edit-window.c:
3164 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3165 linker error, to fix the build on the GNOME platform.
3166 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3167 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3168 ifdefed out to avoid a warning.
3170 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3172 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3173 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3174 some alternative for GTK+ 2.6.
3176 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3178 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3180 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3181 specified for EmailAccountsDialog in UI spec.
3183 * src/maemo/easysetup/modest-easysetup-wizard.c:
3184 * src/maemo/easysetup/modest-easysetup-wizard.h:
3185 * src/maemo/modest-account-settings-dialog.c:
3186 * src/maemo/modest-account-settings-dialog.h:
3187 Reuse a member window widget for the connection-specific SMTP server accounts,
3188 so we can tell it to create/save the accounts only if we actually save changes.
3190 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3191 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3192 (modest_connection_specific_smtp_edit_window_get_settings):
3193 Return a struct instance for temporarily remembering the entered data.
3195 * src/maemo/modest-connection-specific-smtp-window.h:
3196 * src/maemo/modest-connection-specific-smtp-window.c:
3197 (modest_connection_specific_smtp_window_finalize),
3198 (modest_connection_specific_smtp_window_fill_with_connections),
3200 (modest_connection_specific_smtp_window_save_server_accounts),
3201 (update_model_server_names): Do not actually save data until asked,
3202 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3204 (on_selection_changed),
3205 (modest_connection_specific_smtp_window_init): Disable the edit
3206 button when nothing is selected.
3208 * src/modest-account-mgr-helpers.c:
3209 * src/modest-account-mgr-helpers.h:
3210 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3213 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3215 * src/modest-account-mgr-helpers.h:
3216 * src/modest-account-mgr-helpers.c:
3217 (modest_account_mgr_get_unused_account_name),
3218 (modest_account_mgr_get_unused_account_display_name): Added these
3219 utility functions, to avoid code duplication.
3221 * src/maemo/easysetup/modest-easysetup-wizard.c:
3222 (create_page_account_details), (create_account):
3223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3224 (on_combo_security_changed),
3225 (modest_connection_specific_smtp_edit_window_init),
3226 (modest_connection_specific_smtp_edit_window_save_settings):
3227 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3228 * src/maemo/modest-connection-specific-smtp-window.c:
3229 (modest_connection_specific_smtp_window_finalize),
3230 (modest_connection_specific_smtp_window_fill_with_connections),
3231 (on_button_edit), (modest_connection_specific_smtp_window_init):
3232 * src/maemo/modest-connection-specific-smtp-window.h:
3233 Implementing saving of connection-specific server accounts.
3235 But I need to refactor this so we can save the data for each
3236 possible connection-specific account and only actually create the server accounts
3237 when the easysetup finished, or the OK button is pressed on the account settings
3240 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3243 (on_combo_security_changed):
3244 (modest_connection_specific_smtp_edit_window_init):
3245 Auto-fill the port number as in the account settings.
3247 (modest_connection_specific_smtp_edit_window_set_connection):
3248 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3249 * src/maemo/modest-connection-specific-smtp-window.c:
3250 (fill_with_connections), (on_button_edit),
3251 (modest_connection_specific_smtp_window_init):
3252 Turn the edit window into a dialog to simplify the code, and
3253 set a WM hint as in a GtkDialog, because only a popup can be on top of
3254 another window in Maemo, and popups usually have no WM decoration.
3256 * src/modest-defs.h:
3257 * src/modest-account-mgr-helpers.c:
3258 (modest_account_mgr_set_connection_specific_smtp),
3259 (modest_account_mgr_remove_connection_specific_smtp),
3260 (modest_account_mgr_get_connection_specific_smtp):
3261 * src/modest-account-mgr-helpers.h: Some functions to write the
3262 connection-specific SMTP server information. Not yet used.
3265 * src/widgets/modest-folder-view.c: (text_cell_data):
3266 Fix a warning about an uninitialized variable.
3267 (on_configuration_key_changed): Put an #ifdef around the use
3268 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3270 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3272 * src/maemo/modest-account-settings-dialog.h:
3273 * src/maemo/modest-account-settings-dialog.c:
3274 Added connect_for_modified() utility function to mark the new modified boolean.
3276 (create_page_account_details), (create_page_user_details),
3277 (create_page_incoming), (create_page_outgoing), (on_response),
3278 (modest_account_settings_dialog_init),
3279 (modest_account_settings_dialog_set_account_name):
3280 Only warn about unsaved changes when there are actually unsaved changes.
3282 * src/modest-account-mgr-helpers.c:
3283 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3284 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3285 to get the data from there in future.
3287 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3289 * src/modest-defs.h:
3291 * src/modest-account-mgr-helpers.h:
3292 * src/modest-account-mgr-helpers.c:
3293 Store the security account setting in a single conf key instead of using
3294 the options list, so that the list is left for just the to-be-removed camel hack,
3295 and because gconf_client_set_list() is failing for some reason.
3297 * src/modest-account-mgr.c:
3298 (modest_account_mgr_add_server_account):
3299 * src/maemo/modest-account-settings-dialog.c:
3300 (modest_account_settings_dialog_set_account_name),
3301 (save_configuration): Use the renamed functions.
3304 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3306 * src/widgets/Makefile.am:
3307 * src/widgets/modest-limit-retrieve-combo-box.c:
3308 * src/widgets/modest-limit-retrieve-combo-box.h:
3309 * src/widgets/modest-retrieve-combo-box.c:
3310 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3311 the account settings dialog.
3313 * src/modest-defs.h:
3314 * src/modest-account-mgr-helpers.h:
3315 * src/modest-account-mgr-helpers.c:
3316 (modest_server_account_get_option_secure_auth),
3317 (modest_server_account_set_option_secure_auth):
3318 * src/modest-account-mgr.c:
3319 (modest_account_mgr_add_server_account):
3320 Use the existing AUTH_MECH conf key for the secure-auth setting,
3321 instead of putting it in the list options, because this was actually used already.
3323 * src/maemo/modest-account-settings-dialog.c:
3324 (create_page_account_details),
3325 (modest_account_settings_dialog_set_account_name),
3326 (save_configuration):
3327 * src/maemo/modest-account-settings-dialog.h:
3328 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3329 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3331 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3333 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3334 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3335 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3337 * src/modest-defs.h:
3338 * src/maemo/modest-account-settings-dialog.c:
3339 (create_page_incoming), (on_combo_outgoing_security_changed),
3340 (on_combo_incoming_security_changed), (create_page_outgoing),
3341 (modest_account_settings_dialog_set_account_name),
3342 (save_configuration): Load/Save the port number, and change it when the
3343 security combo changes, to suitable defaults.
3345 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3347 * src/modest-account-mgr.c:
3348 (modest_account_mgr_add_server_account): Set the security and secure-auth
3349 options, and add a comment saying that the other camel-specific options should be
3352 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3354 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3356 * src/modest-tny-account-store.c: (account_list_free),
3357 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3358 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3361 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3363 * src/modest-protocol-info.c:
3364 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3365 is required by our UI spec. Maybe something in our implementation will use this eventually.
3366 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3367 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3368 instead of the previous 0 placeholder.
3370 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3371 secure-auth settings.
3372 * src/modest-account-mgr-helpers.h:
3373 * src/modest-account-mgr-helpers.c:
3374 (modest_server_account_data_get_option_secure_auth),
3375 (modest_server_account_set_option_secure_auth),
3376 (modest_server_account_data_get_option_security),
3377 (modest_server_account_set_option_security): Added this API for getting and setting the security
3378 and secure-auth settings.
3380 * src/maemo/modest-account-settings-dialog.h:
3381 * src/maemo/modest-account-settings-dialog.c:
3382 (modest_account_settings_dialog_finalize), (check_data),
3383 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3384 about changing titles.
3385 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3386 (save_configuration): Save the security and secure-auth settings.
3388 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3389 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3391 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3393 * src/modest-defs.h:
3394 * src/modest-account-mgr.c:
3395 (modest_account_mgr_add_server_account):
3396 Added and used defines for the options key and value pair strings,
3397 that are used so far, though they do not seem to correspond to anything in our
3398 UI specs or ModestProtocol enum.
3400 * src/modest-account-mgr-helpers.h:
3401 * src/modest-account-mgr-helpers.c:
3402 (compare_option_strings_for_name),
3403 (modest_server_account_data_get_option_value),
3404 (modest_server_account_data_get_option_bool),
3405 (modest_account_mgr_get_server_account_option):
3406 Added helper functions for parsing the options GSList.
3408 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3410 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3411 display name is based on the supplied account name.
3412 * src/modest-account-mgr.c:
3413 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3414 with an inefficient, but good-enough, implementation.
3416 * src/maemo/easysetup/modest-easysetup-wizard.c:
3417 (create_page_account_details), (on_before_next), (create_account):
3418 Check for existing display names rather than (non-user-visible) account names, and just
3419 create and set a unique account name at the end.
3421 * src/maemo/modest-account-settings-dialog.c:
3422 (modest_account_settings_dialog_init),
3423 (modest_account_settings_dialog_set_account_name),
3424 (create_page_incoming): Show the display name, instead of the account name.
3425 (on_response): Do some (not all) extra checks, as in the UI spec.
3426 (save_configuration): Save the display name if it was changed.
3428 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3430 * po/en_GB.po: Added needed logical ID and translation.
3431 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3432 (init_view): Made the is-default column clicking work.
3434 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3437 * src/maemo/easysetup/Makefile.am:
3438 * src/maemo/easysetup/modest-easysetup-wizard.c:
3439 (modest_easysetup_wizard_dialog_init):
3440 * src/maemo/easysetup/provider-data-test.keyfile:
3441 * src/maemo/easysetup/provider-data.keyfile:
3442 Moved the provider data file to the new modest-providers-data package and used it from there.
3444 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3446 * src/modest-local-folder-info.c:
3447 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3448 N_() was already used on the static strings, but this just marks it for translation without
3449 using the translation.
3451 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3453 * src/maemo/modest-account-settings-dialog.c:
3454 (create_page_incoming),
3455 (modest_account_settings_dialog_set_account_name):
3456 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3457 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3458 I will do this if nobody else gets there first.
3460 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3462 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3463 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3464 save the security stuff.
3466 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3468 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3469 Set the email address and user fullname, which I now see must be
3472 * src/maemo/modest-account-settings-dialog.h:
3473 * src/maemo/modest-account-settings-dialog.c:
3475 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3476 leave-on-server and authentication.
3477 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3480 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3483 * src/maemo/modest-account-settings-dialog.c:
3484 * src/maemo/modest-account-settings-dialog.h:
3485 Most (but not all) of the widgets are now present as specified by the UI spec.
3486 No changes are yet saved, and some details are not properly shown yet.
3488 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3490 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3492 * src/maemo/Makefile.am:
3493 * src/maemo/modest-account-settings-dialog.c:
3494 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3495 an existing account. Doesn't do much yet.
3497 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3498 Open the accounts settings dialog when Edit is clicked.
3500 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3502 * src/maemo/easysetup/Makefile.am:
3503 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3505 * src/maemo/easysetup/modest-easysetup-wizard.c:
3506 (modest_easysetup_wizard_dialog_init):
3507 Try to get the source directory from the build system,
3508 instead of hard-coding "./" into the source code, when opening our local
3509 copies of the configuration files.
3510 But this still fails when opening the wizard from the Accounts window,
3511 maybe because the working directory seems to change at runtime.
3512 So the wizard will fail the second time unless you copy the files into their
3513 proper locations - see the stdout warnings for the paths.
3515 (create_page_account_details),(on_before_next):
3516 Check for existing non-server accounts instead of server accounts,
3517 so the default account name is useful again, and to prevent trying to
3520 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3521 Show the wizard when New is clicked.
3523 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3524 (init_view): Show the column headers, and show the columns that are
3525 specified in the UI specs. However, something in Maemo's GTK+ prevents
3526 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3527 change the default account. This is despite unsetting the special properties.
3529 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3531 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3532 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3533 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3534 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3535 to make that clearer.
3536 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3538 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3540 * src/maemo/modest-account-view-window.c:
3541 (modest_account_view_window_init),
3542 (modest_account_view_window_new):
3543 Use the same buttons as specified in the
3544 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3545 the existing widgets, which never had a chance of working.
3546 Put the ModestAccountView treeview in a scrolled window.
3547 Do not repeat the initialization in both _init() and _new().
3549 * src/widgets/modest-account-view.c: (update_account_view):
3550 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3551 this widget and window shows no accounts.
3553 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3555 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3557 * src/maemo/easysetup/modest-easysetup-wizard.c:
3558 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3559 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3560 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3563 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3564 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3565 accounts exist yet, as in the UI spec.
3567 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3569 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3571 * src/maemo/Makefile.am:
3572 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3573 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3574 New window for editing connection-specific smtp details.
3575 Not fully implemented.
3577 * src/maemo/modest-connection-specific-smtp-window.c:
3578 (modest_connection_specific_smtp_window_finalize) :
3579 unref the tree model.
3580 (on_button_edit): Show the edit window.
3582 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3584 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3587 * src/maemo/Makefile.am:
3588 * src/maemo/modest-connection-specific-smtp-window.c:
3589 * src/maemo/modest-connection-specific-smtp-window.h:
3590 New window for showing the list of connections, for connection-specific
3591 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3592 * src/maemo/easysetup/modest-easysetup-wizard.c:
3593 (create_page_custom_outgoing): Show the new window when the button is clicked.
3595 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3597 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3598 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3599 * src/maemo/modest-msg-edit-window.c:
3600 (modest_msg_edit_window_insert_image):
3601 * src/modest-conf.c: (modest_conf_key_escape):
3602 * src/modest-mail-operation.c:
3603 (modest_mail_operation_send_new_mail):
3604 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3605 (modest_ui_actions_on_new_account):
3606 * src/widgets/modest-attachment-view.c: (update_filename_request):
3607 * src/widgets/modest-mail-header-view.c:
3608 Corrected warnings that were breaking the build, by commenting out unused variables,
3609 and a function, and by including a header.
3611 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3613 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3614 so we can #ifdef around platform-specific code when necessary.
3615 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3616 to allow this to build for the GNOME platform too.
3618 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3620 * src/maemo/easysetup/modest-easysetup-wizard.c:
3621 Added util_increment_name() and used it in create_page_account_details()
3622 to make sure that the default account name is always a new name.
3624 (modest_easysetup_wizard_dialog_init),
3625 (set_default_custom_servernames): Some minor memory management fixes.
3627 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3631 * src/modest-runtime.c: (init_i18n): Restored the translation
3632 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3633 are defined in config.h, and the translations are installed.
3635 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3636 is defined for translation.
3638 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3640 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3642 * src/maemo/easysetup/modest-easysetup-wizard.c:
3643 (modest_easysetup_wizard_dialog_init):
3644 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3645 Use realistic paths (though they should use $prefix generically) to the
3646 mcc_mapping and provider-data.keyfile files which might work when they
3647 are installed by the future version of the operator-wizard package,
3648 and then fallback to paths in our source code, with an explanatory
3651 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3655 * src/maemo/Makefile.am:
3656 * src/maemo/easysetup/: Added files from the previously-exernal
3657 osso-modest-easysetup.
3658 * src/maemo/modest-main-window-ui.h:
3659 * src/modest-ui-actions.c:
3660 * src/modest-ui-actions.h:
3661 Added modest_ui_actions_on_new_account() as a signal handler for the
3662 New Account menu item. It shows the easysetup wizard.
3663 * po/en_GB.po: Added additional needed logical IDs and translations.