1 2007-07-05 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
4 notification of HildonNumberEditor instead of remembering the port
5 number. Thanks to Johannes for pointing this out.
7 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
9 * src/maemo/easysetup/modest-easysetup-wizard.c:
10 Check if there are any user changes before showing a confirmation
11 dialog (projects.maemo.org NB#60946)
13 2007-07-05 Armin Burgmeier <armin@openismus.com>
15 * src/maemo/modest-account-settings-dialog.c: Remember custom port
16 number at the beginning of the dialog and set the modified flag at the
17 end if the port number has changed. This is necessary because
18 HildonNumberEditor does not support notification when the value has
21 2007-07-05 Murray Cumming <murrayc@murrayc.com>
23 * src/modest-ui-actions.c:
24 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
25 a connection before asking anything else. Correct the check for the destination
26 folder so that it succeeds when online.
27 This fixed projects.maemo.org bug NB#61645.
29 2007-07-05 Murray Cumming <murrayc@murrayc.com>
31 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
32 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
33 to fix projects.maemo.org bug NB#62439.
35 2007-07-05 Murray Cumming <murrayc@murrayc.com>
37 * src/modest-tny-account.c: (on_connection_status_changed):
38 Really do not use tny_device_force_offline() here. See the previous comment.
40 2007-07-04 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-tny-account.c: (on_connection_status_changed):
43 Do not use tny_device_force_offline() when tinymail says that something
44 went wrong with the connection. It seems to report this unnecessarily.
46 2007-07-04 Murray Cumming <murrayc@murrayc.com>
48 * src/maemo/modest-connection-specific-smtp-window.c:
49 (modest_connection_specific_smtp_window_init):
50 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
51 does not seem to have any effect in osso 1.1 (though it works in
52 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
54 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
56 * src/maemo/modest-connection-specific-smtp-window.c:
57 Fix UI specification problems with projects.meamo.org NB#60479
59 2007-07-04 Murray Cumming <murrayc@murrayc.com>
61 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
62 clue when this has failed, because the error dialog is not always shown
63 (at least in earlier version).
65 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
66 GError message, because the generic error dialog is not helpful.
68 'This message is not currently available (can't let a new connection go online)'
69 when trying to open an IMAP message.
71 (_modest_ui_actions_open): Offer a connection when some messages would
72 have to be downloaded and we are offline.
74 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
76 * src/widgets/modest-folder-view.c:
77 Don't check for MERGE type anymore as we use the correct type
79 NOTE: For the last two changes you need to update your tinymail copy
80 because of API changes!
82 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
84 * src/modest-tny-local-folders-account.c:
85 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
86 (see projects.maemo.org NB#61580)
88 2007-07-04 Murray Cumming <murrayc@murrayc.com>
90 * src/modest-tny-account.c: (on_connection_status_changed):
91 Commented out the call to modest_platform_connect_and_wait() because this
92 seems to always hang, and I would like to know if this is the only thing
93 that causes a hang when showing the connection dialog.
94 It is not very useful anyway.
96 2007-07-04 Murray Cumming <murrayc@murrayc.com>
98 * src/maemo/modest-msg-view-window.c:
99 (modest_msg_view_window_select_next_message):
101 * src/modest-platform.h:
102 * src/maemo/modest-platform.c:
103 Added modest_platform_connect_and_wait(), which calls
104 tny_maemo_conic_device_connect() always in the main thread, by calling it
105 in an idle handler and waiting for the idle handler to run. It should be
106 in the main thread because it uses GTK+ UI code. It just returns TRUE
107 if the device is already online.
109 There is some nasty code to ensure that subsequent calls to
110 modest_platform_connect_and_wait() just wait for the first one to finish,
111 by checking repeatedly in another idle handler. This is necessary,
112 because other threads (or even the main thread, via another idle handler)
113 can call modest_platform_connect_and_wait() while
114 modest_platform_connect_and_wait() is running.
116 (modest_platform_connect_and_wait_if_network_account),
117 (modest_platform_connect_and_wait_if_network_folderstore):
118 Convenience functions that calls modest_platform_connect_and_wait() if
119 the account or folder might want network access.
121 * src/modest-mail-operation.c:
122 (modest_mail_operation_update_account):
123 * src/modest-ui-actions.c: (download_uncached_messages),
124 (modest_ui_actions_on_rename_folder), (delete_folder),
125 (modest_ui_actions_on_main_window_move_to),
126 (modest_ui_actions_on_msg_view_window_move_to):
127 * src/widgets/modest-folder-view.c:
128 (drag_and_drop_from_folder_view):
129 Offer a connection if we are offline.
131 * src/modest-tny-account.c: (on_connection_status_changed):
132 Document this as only handling errors during network operations in progress,
133 and replace the idle code with a simple call to
134 modest_platform_connect_and_wait(), which does this instead.
136 2007-07-03 Murray Cumming <murrayc@murrayc.com>
138 * src/modest-tny-account.c:
139 (modest_tny_account_get_special_folder): (util_on_idle),
140 Handle the GError so we can see when tny_folder_store_get_folders()
141 fails, as it currently does while something else is connecting.
143 Added util_run_in_main_thread_and_wait()
144 which uses an idlen handler and mainloop to ensure that the function
145 is called in the main thread.
146 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
147 to make sure that we call attempt the connection in the mainloop only,
148 which might solve some hangs.
150 2007-07-03 Murray Cumming <murrayc@murrayc.com>
152 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
153 be found by their display name. This is never useful.
154 * src/modest-tny-account-store.c: (on_account_removed): Find the account
155 by its ID, instead of trying to use its ID as its display name.
157 * src/modest-tny-account-store.h:
158 * src/modest-tny-account.c:
159 (modest_tny_account_get_special_folder): Add a g_warning() when
160 tny_folder_store_get_folders() returns an empty list for the maildir.
162 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
163 Add a g_warning() when this returns NULL, because that it not allowed
166 2007-07-02 Armin Burgmeier <armin@openismus.com>
168 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
169 note when trying to cancel the wizard. This fixes projects.maemo.org
172 2007-07-02 Murray Cumming <murrayc@murrayc.com>
174 * src/modest-tny-account.h:
175 * src/modest-tny-account.c:
176 (modest_tny_account_new_from_server_account),
177 (modest_tny_account_new_from_server_account_name),
178 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
179 because this must now be set before setting the proto. This is usd in
180 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
181 warning in camel_session_get_service() caused by
182 tny_camel_transport_account_prepare().
184 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
187 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
189 * src/maemo/modest-connection-specific-smtp-edit-window.c:
191 (modest_connection_specific_smtp_edit_window_init):
193 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
196 2007-06-29 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-tny-account.c:
199 (modest_tny_account_new_from_server_account):
200 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
201 now uses to request a connection when it needs one, and which it uses
202 to tell us that something is wrong with the connection, so we can force
203 the accounts offline to prevent further problems.
206 * src/modest-init.c: (init_default_settings):
207 * src/modest-mail-operation.c:
208 (modest_mail_operation_update_account):
209 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
210 This should not be necessary anymore. Do not set the conf key that
211 determined this (it was always TRUE and not set anywhere else).
213 * src/modest-ui-actions.h: Remove unused and unimplemented
214 modest_ui_actions_on_online_toggle_toggled().
216 2007-06-29 Murray Cumming <murrayc@murrayc.com
218 * src/maemo/modest-main-window.c: (connect_signals):
219 Don't connect to delete_event twice. Maybe this was harmless.
221 2007-06-29 Murray Cumming <murrayc@murrayc.com
223 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
224 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
225 Debug output to give some more clue when a folder move is not allowed.
227 2007-06-28 Murray Cumming <murrayc@murrayc.com
229 * src/modest-tny-account.c: (on_modest_file_system_info),
230 (modest_tny_account_get_mmc_account_name):
231 Always call the callback, without checking whether the name has changed.
232 * src/widgets/modest-folder-view.c: (strings_are_equal),
233 (on_model_foreach_set_name), (on_get_mmc_account_name),
234 (text_cell_data): Compare the name here, and use the name from
235 the account rather than from the
236 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
237 if the name was changed after the account was added to the model.
238 That's a tinymail bug but not one that I want to fix now.
240 This finally fixes projects.maemo.org bug NB#59301.
242 2007-06-27 Armin Burgmeier <armin@openismus.com>
244 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
247 2007-06-27 Murray Cumming <murrayc@murrayc.com
249 * src/modest-tny-account.h:
250 * src/modest-tny-account.c:
251 Added modest_tny_account_get_mmc_account_name(), to set the memory
252 card name asynchronously for the given account and then notify.
253 (modest_tny_account_new_for_local_folders): Use this new function instead
254 of using hildon_file_system_info_async_new() directly.
256 * src/widgets/modest-folder-view.c: (text_cell_data):
257 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
258 gtk_tree_model_row_changed() when it is available.
260 This should fix projects.maemo.org bug NB#59301.
262 2007-06-27 Murray Cumming <murrayc@murrayc.com
264 * src/modest-mail-operation.c: (update_account_thread),
265 (get_msgs_full_thread): Fix typo failures in the revert
268 2007-06-27 Murray Cumming <murrayc@murrayc.com
270 * src/maemo/modest-maemo-global-settings-dialog.c:
271 (idle_select_default_focus):
272 * src/modest-mail-operation.c: (idle_notify_progress),
273 (idle_notify_progress_once), (set_last_updated_idle),
274 (update_account_thread), (get_msgs_full_thread):
275 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
276 * src/widgets/modest-header-view.c:
277 (idle_notify_headers_count_changed_destroy),
278 (idle_notify_headers_count_changed):
279 Reverted the additions of gdk_threads_enter/leave(), in case this
280 helps with a startup hang on the device.
282 2007-06-26 Armin Burgmeier <armin@openismus.com>
284 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
285 for supported secure authentication methods from server by
286 gtk_dialog_run(), saving CPU time and a potential race condition.
288 2007-06-26 Armin Burgmeier <armin@openismus.com>
290 * src/maemo/modest-maemo-utils.h:
291 * src/maemo/modest-maemo-utils.c: Added a
292 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
293 only error code to tell the calling code when the user canceled the
296 * src/maemo/modest-account-settings-dialog.h:
297 * src/maemo/modest-account-settings-dialog.c:
298 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
299 message if the retrieval of secure authentication methods was canceled
300 by the user. Perform the check before saving anything to configuration
301 to not end up with half-committed configuration changes, do not show
302 a "Saving to configuration failed" note when authentication methods
303 could not be retrieved.
305 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
308 2007-06-26 Murray Cumming <murrayc@murrayc.com>
310 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
311 Only return the first level of folders under accounts, because the
312 osso-global-search UI spec doesn't want the rest.
313 This fixed projects.maemo.org bug NB#61811.
315 2007-06-26 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-tny-account-store.c:
318 * src/modest-tny-account-store.h:
319 Added modest_tny_account_is_memory_card_account().
320 * src/maemo/modest-main-window.c: (create_details_widget):
321 Show the same information items for the memory card as we show for the
322 local-folders, to fix projects.maemo.org bug NB#59307.
324 2007-06-26 Murray Cumming <murrayc@murrayc.com>
326 * src/modest-tny-account-store.c: (get_password):
327 Added some checks for NULL to maybe prevent crashes, though I think
328 it was Philip's last commit that actually prevented the crash here
329 when creating a first new account.
330 But the new account is still not usable (no messages are shown)
331 until a restart of the application.
333 2007-06-26 Murray Cumming <murrayc@murrayc.com>
335 * src/maemo/modest-maemo-global-settings-dialog.c:
336 (idle_select_default_focus):
337 * src/modest-mail-operation.c: (idle_notify_progress),
338 (idle_notify_progress_once), (idle_notify_update_account_queue),
339 (set_last_updated_idle), (update_account_thread),
340 (notify_get_msgs_full), (get_msgs_full_destroyer),
341 (get_msgs_full_thread):
342 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
343 * src/widgets/modest-header-view.c:
344 (idle_notify_headers_count_changed_destroy),
345 (idle_notify_headers_count_changed):
346 Use gdk_threads_enter() and gdk_threads_enter_leave() in
347 all idle handlers, because some other thread could be blocking
348 the GDK lock, so that it can do GUI stuff.
350 2007-06-26 Murray Cumming <murrayc@murrayc.com>
352 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
353 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
354 (on_idle_send_receive), (on_idle_open_default_inbox):
355 * src/maemo/modest-msg-edit-window.c:
356 (modest_msg_edit_window_attach_file_noninteractive):
357 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
358 to prevent a hang. I don't quite understand why these are necessary,
359 beause we should already be in the main loop. I guess something outside
360 of the main loop is taking the lock.
362 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
363 we are really using URIs, and use files that are more likely to exist.
365 2007-06-26 Murray Cumming <murrayc@murrayc.com>
367 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
368 necessary because configure.ac now defines different variables.
370 2007-06-26 Murray Cumming <murrayc@murrayc.com>
372 * libmodest-dbus-client/libmodest-dbus-client.c:
373 * libmodest-dbus-client/libmodest-dbus-client.h:
374 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
375 libmodest_dbus_client_compose_mail() is what things actually use.
377 * src/dbus_api/modest-dbus-api.h:
378 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
379 * tests/dbus_api/Makefile.am:
380 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
383 2007-06-26 Murray Cumming <murrayc@murrayc.com>
385 * src/modest-init.c: (modest_init_local_folders):
386 For memory-card (or other non local-folders) maildir accounts,
387 always create an Archive folder, so that there is somewhere to put
388 messages. This should be less confusing, because the user does not need
389 to guess that the need to create a folder.
391 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
393 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
394 Fixed icon size by using (50, 50) which is the same as defined by
397 2007-06-25 Armin Burgmeier <armin@openismus.com>
399 * src/widgets/modest-window-mgr.c:
401 * configure.ac: Correctly recognize hildon-notify presence and fixed
402 the build without it being installed.
404 2007-06-25 Murray Cumming <murrayc@murrayc.com>
406 * libmodest-dbus-client/libmodest-dbus-client.c:
407 (libmodest_dbus_client_search): Fix the build. Sorry.
408 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
409 (reply_forward_cb): Initialize variables to fix the build.
411 * src/modest-tny-account-store.c:
412 (modest_tny_account_store_get_tny_account_by): Fix the account URI
413 comparison (a silly typo) so that email search results can be opened
414 when there are more than one account.
416 2007-06-25 Murray Cumming <murrayc@murrayc.com>
418 * libmodest-dbus-client/libmodest-dbus-client.c:
419 (libmodest_dbus_client_search),
420 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
421 instead of 1 second, because the search gets folders and messages from
422 the server, which can take a long time. When it times out,
423 osso-global-search will report no results.
425 We need to specify whether we should search only cached information
426 (maybe with a user preference), and the osso-email-search-plugin
427 API should really be improved to allow that option, and to allow results
428 to be delivered asynchronously in batches.
430 2007-06-25 Murray Cumming <murrayc@murrayc.com>
432 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
433 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
434 GTK_ICON_SIZE_DIALOG is probably the wrong size.
436 2007-06-25 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
439 that is an empty string. D-Bus seems to give us these instead of NULL.
441 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
443 * src/dbus_api/modest-dbus-callbacks.c:
444 * src/maemo/easysetup/modest-easysetup-wizard.h:
445 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
446 * src/maemo/modest-connection-specific-smtp-edit-window.c:
447 (modest_connection_specific_smtp_edit_window_init):
448 * src/maemo/modest-maemo-global-settings-dialog.c:
450 * src/maemo/modest-maemo-utils.c:
451 (modest_maemo_utils_setup_images_filechooser):
452 * src/maemo/modest-main-window.c: (create_details_widget):
453 * src/maemo/modest-msg-edit-window.c:
454 (modest_msg_edit_window_attach_file_noninteractive),
455 (modest_msg_edit_window_color_button_change),
456 (modest_msg_edit_window_set_zoom):
457 * src/modest-mail-operation.c: (update_account_thread):
458 * src/modest-tny-account-store.c:
459 * src/modest-tny-account.c:
460 * src/widgets/modest-global-settings-dialog.c:
461 * src/widgets/modest-window.h:
465 2007-06-25 Murray Cumming <murrayc@murrayc.com>
467 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
468 * src/modest-search.c: (modest_search_folder),
469 (modest_search_all_accounts): Actually search only in the specified folder,
470 doing a simple match on the folder ID.
471 * src/modest-search.h: Added a folder field to the ModestSearch struct,
472 and added some documentation.
474 2007-06-22 Armin Burgmeier <armin@openismus.com>
476 * src/maemo/modest-maemo-utils.h:
477 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
478 modest_maemo_utils_get_supported_secure_authentication_methods.
480 * src/maemo/easysetup/modest-easysetup-wizard.c:
481 * src/maemo/modest-account-settings-dialog.c: Show correct error if
482 one occured, not just "Server does not support secure authentication".
484 2007-06-22 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-tny-account-store.c: (get_password):
487 Restored the call to tny_account_set_user() because Philip seems to have
488 stopped this from crashing (by not using the freed string). It still does
489 not work, but now we can test it.
491 2007-06-22 Murray Cumming <murrayc@murrayc.com>
493 * src/maemo/modest-msg-edit-window.c: (init_window):
494 Comment out use of an uninitialzed GtkScrolledWindow variable,
495 to fix the build and stop a crash. Yet again.
497 2007-06-22 Murray Cumming <murrayc@murrayc.com>
499 * src/modest-tny-account-store.c: (get_password):
500 Remove the call to tny_account_set_user() because this actually crashes.
501 As mentioned in the last commit, it is known to not work anyway.
503 2007-06-22 Murray Cumming <murrayc@murrayc.com>
505 * src/modest-tny-account-store.c: (get_password):
506 Use tny_account_set_username() to tell tinymail that the username might
507 have changed too. But tinymail ignores this: see projects.maemo.org
509 * src/modest-ui-actions.c:
510 (modest_ui_actions_on_password_requested): Remove the useless attempt to
511 reset the connection when changing the username, and improve the comments.
512 Save the changed username to gconf at least, so it is used when Modest is
515 2007-06-21 Murray Cumming <murrayc@murrayc.com>
517 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
518 Do not use a query, so that we get all folders, including for POP and
519 local-folders. They work as search criteria too.
520 This fixes projects.maemo.org bug NB#57740.
522 2007-06-21 Murray Cumming <murrayc@murrayc.com>
524 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
525 Comment out the use of hildon_notification_set_sound() because it is
526 not declared, to fix the build. Warnings are serious, people.
528 2007-06-21 Armin Burgmeier <armin@openismus.com>
530 * src/maemo/modest-maemo-utils.h:
531 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
532 modest_maemo_utils_get_supported_secure_authentication_methods()
533 to query authentication methods for a specific user. This should fix
534 projects.maemo.org bug NB#61369.
536 * src/maemo/easysetup/modest-easysetup-wizard.c:
537 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
540 2007-06-21 Murray Cumming <murrayc@murrayc.com>
542 * libmodest-dbus-client/libmodest-dbus-client.h:
543 * libmodest-dbus-client/libmodest-dbus-client.c:
544 (modest_dbus_message_iter_get_search_hit),
545 (libmodest_dbus_client_search):
546 Reorganised and commented this.
547 Removed modest_search_hit_free() from the public API because it
550 Added libmodest_dbus_client_get_folders() and
551 modest_folder_result_list_free().
553 * src/dbus_api/modest-dbus-api.h:
554 * src/dbus_api/modest-dbus-callbacks.c:
555 (modest_dbus_req_filter): Commented. Moved most code to
556 on_dbus_method_search() and added on_dbus_method_get_folders().
558 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
559 of the extra D-Bus handler.
561 * tests/dbus_api/Makefile.am:
562 * tests/dbus_api/test_get_folders.c: New test for
563 libmodest_dbus_client_get_folders(). This seems to return an empty list
564 at the moment. That could be the same error that causes the message list
565 to be empty sometimes.
566 This should help with projects.maemo.org bug NB#57740.
568 2007-06-21 Armin Burgmeier <armin@openismus.com>
570 * src/modest-mail-operation.c: Do not call
571 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
572 notify the operation's end after having set the status to CANCELED for
573 the operation queue to listen on. This fixes a deadlock when there
574 were mail operations in the queue during its finalization.
576 * src/modest-singletons.c: Reordered uninitialization of the account
577 manager to happen after the mail operation queue was uninitialized
578 because the mail operation's in the queue might still try to access
579 the account manager (see modest_mail_operation_notify_end()). This
580 fixes a potential crash when terminating the application.
582 2007-06-21 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-search.c:
585 (search_mime_part_and_child_parts): Moved some code here so we
586 can search recursively in child folders.
587 (modest_search_folder): Search in the message as a mime part, instead
588 of just its child mime parts.
589 (read_chunk), (search_mime_part_ogs):
590 Check how many bytes were read, to prevent an endless loop.
591 Searching in message bodies now works. This finishes the fix for
592 projects.maemo.org bug NB#61007.
594 2007-06-20 Murray Cumming <murrayc@murrayc.com>
596 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
597 Add a g_warning when the item is not a folder.
599 * src/modest-ui-dimming-rules.c:
600 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
601 when selected item is not a folder (for instance, an account), because
602 the UI spec only talks about folders.
603 I am not sure what the UI spec wants, so this might not totally fix
604 projects.maemo.org bug NB#60794.
606 2007-06-20 Murray Cumming <murrayc@murrayc.com>
608 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
609 (load_from_file): Sort the list. The unsorted list would be more noticeable
610 in non-English locales.
612 * src/maemo/modest-msg-edit-window.c:
613 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
614 warning and fix the build.
616 * src/maemo/modest-progress-bar-widget.c:
617 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
618 avoid a g_warning, and probably to avoid a crash.
620 2007-06-20 Murray Cumming <murrayc@murrayc.com>
622 * src/modest-search.c: (modest_search_folder): Check for a GError
623 when calling tny_folder_get_headers(), to show that this is not the cause
626 2007-06-20 Murray Cumming <murrayc@murrayc.com>
628 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
629 Actually set the body query instead of the subject query.
631 * src/modest-search.c: (search_mime_part_ogs),
632 (search_mime_part_strcmp): Remove extra space from the text/* regex,
633 which would probably cause it to fail if we got this far.
635 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
636 to simplify the code.
637 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
638 be causing search-in-body to fail.
640 2007-06-20 Murray Cumming <murrayc@murrayc.com>
642 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
644 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
645 Better debug message when the folder cannot be found.
646 This should help with fixing projects.maemo.org bug #61287.
647 * src/modest-search.c: (add_hit): Do not leak the furl string.
649 2007-06-20 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-ui-actions.c:
652 (modest_ui_actions_on_folder_selection_changed):
653 Do not special-case TNY_MERGE_FOLDER here, because
654 modest_tny_folder_get_account() already does that. This fixes
655 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
656 shown when the Outbox was selected).
658 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
660 * libmodest-dbus-client/libmodest-dbus-client.c:
661 (_dbus_iter_get_string_or_null): Initialize the string variable in
662 case this helps with Dirk's crash.
664 2007-06-19 Murray Cumming <murrayc@murrayc.com>
666 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
667 though it is not implemented yet (this function is maybe not even used),
668 to avoid breaking ABI in future.
669 * libmodest-dbus-client/libmodest-dbus-client.c:
670 (get_attachments_string): Moved some code into this generic function.
671 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
672 sends email. It is maybe not used.
673 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
674 (on_send_mail): Use attachments.
676 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
677 * src/maemo/modest-msg-edit-window.c:
678 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
679 a filename before using it, to fix projects.maemo.org bug NB#58233.
681 2007-06-19 Murray Cumming <murrayc@murrayc.com>
683 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
684 Initialize the continue_download variable to fix the build, and probably
685 to fix randome behaviour.
687 2007-06-18 Armin Burgmeier <armin@openismus.com>
689 * src/modest-tny-send-queue.h:
690 * src/modest-tny-send-queue.c: Keep track of the status of messages in
691 the queue so we can later show it in the UI. Replaced
692 modest_tny_send_queue_msg_is_being_sent() by
693 modest_tny_send_queue_get_msg_status().
695 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
697 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
698 gpointer. This probably was not harmful, but just to be sure.
700 2007-06-18 Murray Cumming <murrayc@murrayc.com>
702 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
703 Fix the build, but leave the function broken on Bora, because
704 hildon_uri_action_get_service() does not exist.
705 osso_uri_action_get_service() does not exist either, it seems.
707 2007-06-18 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-tny-account.c:
710 (modest_tny_account_new_from_server_account):
711 Uncommented the url debug output again, because it is useful for
712 debugging, as I said in the comment.
714 2007-06-18 Murray Cumming <murrayc@murrayc.com>
716 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
718 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
719 for Mameo Bora, to fix the build.
721 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
724 Fixed build with hildon < 0.99
726 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
727 Check if the selected account is busy instead of checking all accounts
729 * src/modest-account-mgr-priv.h:
730 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
731 (modest_account_mgr_init), (compare_account_name),
732 (modest_account_mgr_set_account_busy),
733 (modest_account_mgr_account_is_busy):
734 * src/modest-account-mgr.h:
735 Added busy information to the account manager. It possible to
736 set an account to busy or not busy now.
738 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
739 (modest_mail_operation_update_account),
740 (modest_mail_operation_notify_end):
741 Set the account to busy/not busy depending on the operation state.
743 * src/widgets/modest-account-view.c:
744 (modest_account_view_finalize), (get_last_updated_string),
745 (update_account_view), (on_account_busy_changed), (init_view):
746 Show string "Refreshing..." if the account is currently busy.
748 All this fixes projects.maemo.org bug NB#59711
750 2007-06-14 Armin Burgmeier <armin@openismus.com>
752 * src/widgets/modest-attachments-view.h:
753 * src/widgets/modest-attachments-view.c: Added
754 modest_attachments_view_has_attachments() and fixed coordinate
755 transformation in get_att_view_at_coords(). This fixes attachment
758 * src/widgets/modest-msg-view.c: Make use of
759 modest_attachments_view_has_attachments() to decide whether to show
760 attachments in the header.
762 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
764 * src/maemo/modest-connection-specific-smtp-edit-window.c:
765 (on_change), (on_combo_security_changed),
766 (modest_connection_specific_smtp_edit_window_init),
767 (modest_connection_specific_smtp_edit_window_set_connection),
768 (modest_connection_specific_smtp_edit_window_is_dirty):
769 * src/maemo/modest-connection-specific-smtp-edit-window.h:
770 * src/maemo/modest-connection-specific-smtp-window.c:
773 Show an comfirmation dialog for the smpt-edit-window if there are
774 unsaved changes and the user hits cancel.
775 (projects.maemo.org bug NB#60479)
777 2007-06-14 Armin Burgmeier <armin@openismus.com>
779 * src/maemo/easysetup/modest-easysetup-wizard.c:
780 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
781 address" info in banner instead of node, and select all the text as
782 per UI spec. This fixes projects.maemo.org bug NB#60550.
784 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
786 reviewed by: <delete if not using a buddy>
788 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
789 * src/modest-ui-actions.c: (folder_refreshed_cb):
791 2007-06-14 Murray Cumming <murrayc@murrayc.com>
793 * src/widgets/modest-folder-view.c: (filter_row):
794 Explictly filter out the per-account outbox accounts. I don't know why
795 these only sometimes show up, but now they should never show up in the UI.
796 This should fix projects.maemo.org bug NB#60160.
798 2007-06-14 Murray Cumming <murrayc@murrayc.com>
800 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
801 when the toolbar does not exist yet.
802 * src/modest-widget-memory.c: (save_settings_header_view):
803 Added g_warnings() to help us to discover when we are trying to set
804 an empty columns list in gconf.
806 2007-06-14 Murray Cumming <murrayc@murrayc.com>
810 Added modest_init_get_default_header_view_column_ids().
812 * src/modest-widget-memory.c: (restore_settings_header_view):
813 Use the new function to get defaults, if the gconf key is empty,
814 instead of not creating any columns. This seems to fix the
815 empty right-hand pane problems.
817 * src/widgets/modest-header-view.h: Improved documentation.
819 2007-06-13 Murray Cumming <murrayc@murrayc.com>
821 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
822 Revert the use of the display name as the account name, because this
823 is generally wrong and would break the code that follows.
825 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
827 * src/maemo/easysetup/modest-easysetup-wizard.c:
828 (check_for_supported_auth_methods), (on_before_next),
831 More correct fix for projects.maemo.org bug NB# 58991
832 Do not longer accept AUTH_PASSWORD as secure method and choose
833 correct method when creating the account.
835 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
837 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
838 Fixed projects.maemo.org bug NB# 58991
840 2007-06-13 Murray Cumming <murrayc@murrayc.com>
842 * src/modest-init.c: (modest_init_init_core),
843 (modest_init_local_folders): Fixed compilation errors.
845 2007-06-13 Murray Cumming <murrayc@murrayc.com>
847 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
848 Remove unnecessary lib/include, though it is good in principle when needed.
850 * src/modest-init.c: (modest_init_one_local_folder),
851 (modest_init_local_folders):
852 * src/modest-init.h: Initialize the .modest library for memory cards,
853 instead of just doing nothing for them. This should allow us to create
854 folders there, fixing projects.maemo.org bug NB#59297.
856 2007-06-13 Murray Cumming <murrayc@murrayc.com>
858 * libmodest-dbus-client/libmodest-dbus-client.c:
859 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
860 (libmodest_dbus_client_compose_mail),
861 (libmodest_dbus_client_open_message),
862 (libmodest_dbus_client_send_and_receive),
863 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
865 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
866 (on_idle_open_message), (modest_dbus_req_handler),
867 (search_result_to_message), (modest_dbus_req_filter):
868 * src/modest-search.c: (add_hit), (modest_search_folder),
869 (modest_search_all_accounts): Improved debug messages.
871 * tests/dbus_api/test_open_message.c: (main): Improved comments.
873 * src/modest-tny-account-store.c:
874 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
877 2007-06-13 Murray Cumming <murrayc@murrayc.com>
880 2007-06-12 Murray Cumming <murrayc@murrayc.com>
882 * src/modest-tny-account-store.c: (get_server_accounts):
883 Call modest_tny_local_folders_account_add_merged_outbox_folders()
884 even when there are no accounts, so that the Outbox folder is always
885 visible. This fixes projects.maemo.org bug NB#60158.
887 2007-06-12 Murray Cumming <murrayc@murrayc.com>
889 * src/maemo/modest-main-window.c: (create_details_widget):
890 Use the mcen_va_never logical ID.
892 2007-06-12 Murray Cumming <murrayc@murrayc.com>
894 * src/dbus_api/modest-dbus-api.h:
895 * src/dbus_api/modest-dbus-callbacks.c:
896 (on_idle_open_default_inbox), (on_open_default_inbox),
897 (modest_dbus_req_handler):
898 Added a new OpenDefaultInbox method.
900 * libmodest-dbus-client/libmodest-dbus-client.h:
901 * libmodest-dbus-client/libmodest-dbus-client.c:
902 Added libmodest_dbus_client_open_default_inbox() to call the new
903 dbus method. This should be useful to projects.maemo.org bug NB#57214,
904 though it should maybe be used by a new osso-email-interface function.
906 * tests/dbus_api/Makefile.am:
907 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
910 2007-06-12 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
913 NULL, so that the signals get all the keys. This should not actually
914 change any behaviour because we currently update everything when anything
917 2007-06-12 Murray Cumming <murrayc@murrayc.com>
919 * src/widgets/modest-folder-view.c: (text_cell_data),
920 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
921 (find_inbox_iter): If tinymail tells us that the folder is
922 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
923 This causes the inbox to be selected at startup, fixing part of
924 projects.maemo.org bug NB#56305.
926 * src/modest-ui-dimming-rules.c:
927 (modest_ui_dimming_rules_on_tools_smtp_servers):
928 * src/modest-ui-dimming-rules.h: Added a callback function to dim
929 the SMTP servers menu item.
930 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
931 that the SMTP Servers menu item is dimmed when there are no accounts,
932 as a future version of the UI spec will require. This fixes
933 projects.maemo.org bug NB#56305.
935 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
937 * src/maemo/modest-maemo-utils.c:
938 (modest_maemo_utils_get_supported_secure_authentication_methods):
939 Added label to dialog instead of unreadable title
941 * src/maemo/modest-main-window.c: (sync_accounts_cb),
942 (modest_main_window_new):
943 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
946 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
947 * src/modest-account-mgr.h:
948 Added method to avoid code duplication
950 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
951 (modest_ui_actions_on_send_receive):
952 Use modest_account_mgr_has_accounts
954 2007-06-11 Murray Cumming <murrayc@murrayc.com>
956 * src/maemo/easysetup/modest-presets.c:
957 (modest_presets_get_info_server_security): Do not report secure auth
959 * src/modest-protocol-info.c: Use the defines for the gconf key names
960 for secure authentication. This was not working because we were writing
961 Password and reading password, and the check was case sensitive.
962 With this, gmail now works for receiving and sending when created via
965 2007-06-11 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/easysetup/modest-presets.c:
968 (modest_presets_get_info_server_security): Correct the key name for
969 SecureSmtp, because it seems to be case-sensitive.
970 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
971 Do not try to get the 0th notebook page if there are 0 pages, to
974 2007-06-11 Murray Cumming <murrayc@murrayc.com>
976 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
977 Prevent use of the new notification feature for now, because it currently
978 shows one dialog for each new email, which is annoying.
980 2007-06-11 Murray Cumming <murrayc@murrayc.com>
982 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
983 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
984 when no country was selected, so that we show the global ones.
985 * src/maemo/easysetup/modest-presets.c:
986 (modest_presets_get_providers): Return only the global providers, not
987 all providers when mmc=0 was requested.
989 2007-06-11 Murray Cumming <murrayc@murrayc.com>
991 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
992 (easysetup_provider_combo_box_fill): Remove debug code that showed the
993 provider ID in the combo.
995 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
996 Do not show the page numbers, because it would be confusing when we add
997 the 2 extra pages for the custom setup, when the user chooses the "Other"
998 provider. This fixes projects.maemo.org bug NB#59028
1000 * src/modest-init.c: (modest_init_init_core),
1001 (modest_init_local_folders):
1002 * src/modest-init.h:
1003 * src/modest-tny-account.c:
1004 (modest_tny_account_new_for_local_folders): Do not create default folders
1005 for the memory card. This should fix projects.maemo.org bug NB#59328.
1007 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1010 Free the changed_conf_keys string items. They are already freed in the
1011 idle handler if that runs first.
1013 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1015 * src/modest-ui-actions.c:
1016 (modest_ui_actions_on_password_requested): Check that the server name
1017 is not NULL, because I just saw a password dialog with (null) as the
1020 * src/modest-tny-folder.[h|c]: Added
1021 modest_tny_folder_is_memory_card_folder().
1022 * src/modest-ui-dimming-rules.c:
1023 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1024 menu item for memory cards, as per the UI spec (section 7.4). This should
1025 fix projects.maemo.org bug NB#59297.
1027 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1029 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1030 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1031 is another problem with the code, see Murray's comment at line 772)
1033 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1035 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1036 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1037 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1038 (load_from_file), (easysetup_country_combo_box_init),
1039 (easysetup_country_combo_box_get_active_country_ids),
1040 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1041 instead of just one ID, to avoid duplicate country names in the UI.
1043 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1044 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1045 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1046 a single ID, avoiding duplicate providers.
1047 * src/maemo/easysetup/modest-easysetup-wizard.c:
1048 (on_combo_account_country): Adapt to use a list.
1050 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1052 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1053 keys changed in the last X seconds.
1055 * src/modest-account-mgr.h:
1056 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1057 (on_key_change), (modest_account_mgr_class_init),
1058 (modest_account_mgr_init), (modest_account_mgr_finalize):
1059 As the keys are changed, save them in a GSList* and signal that GSList*
1060 further every X seconds, to batch changes, to allow us to do just one
1061 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1062 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1064 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1065 changed signal signature.
1067 * src/modest-conf.c: (modest_conf_set_list),
1068 (modest_conf_on_change): Reenable notification.
1070 (modest_conf_maemo_fake_on_change): Comment out the hack that
1071 notified immediately instead of asynchronously.
1073 * src/widgets/modest-account-view.h:
1074 * src/widgets/modest-account-view.c:
1075 (update_account_view): Select the previously-selected account ID,
1076 if possible. This fixes projects.maemo.org bug NB#56933.
1078 (on_account_changed), (on_account_removed),
1079 (modest_account_view_select_account):
1081 Remove the block/unblock functions
1082 because they were not useful.
1084 * src/maemo/modest-account-view-window.c:
1085 (on_delete_button_clicked), (on_edit_button_clicked),
1086 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1088 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1091 Improve the error dialog to show Incorrect Account Settings, which seems
1092 clearer, and say that the internal error message (to be removed from the
1093 dialog later) is often misleading.
1094 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1096 * src/modest-tny-account.c:
1097 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1098 URL because this is so useful for debugging on the device.
1100 * src/widgets/modest-serversecurity-combo-box.c:
1101 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1103 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1105 * src/modest-mail-operation.c:
1106 (modest_mail_operation_send_new_mail):
1107 Added a comment about a nasty but apparently harmless message. Details
1108 added to the wiki g_warnings() page.
1110 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1112 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1113 (modest_tny_send_queue_class_init):
1114 Do not use the priv struct because it is empty, to avoid g_warnings
1115 about a non-existant priv struct.
1117 * src/modest-tny-account-store.c:
1118 (modest_tny_account_store_get_server_account),
1119 (modest_tny_account_store_get_transport_account_for_open_connection
1120 ): Do not try to get transport server accounts for local folders,
1121 because they don't have any. This avoids a g_warning().
1123 * src/maemo/modest-main-window.c:
1124 (modest_main_window_notify_send_receive_initied),
1125 (on_configuration_key_changed):
1126 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1127 * src/modest-defs.h:
1128 * src/modest-mail-operation.c:
1129 (modest_mail_operation_update_account):
1130 * src/modest-tny-account-store.h:
1131 * src/modest-tny-account.c:
1132 (modest_tny_account_get_special_folder),
1133 (modest_tny_account_new_for_local_folders),
1134 (modest_tny_account_new_for_per_account_local_outbox_folder):
1135 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1136 * src/modest-tny-local-folders-account.c:
1137 (add_account_folders_to_merged_folder):
1138 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1139 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1140 (modest_ui_actions_on_send):
1141 * src/widgets/modest-folder-view.c: (update_model):
1142 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1143 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1144 modest_tny_account_store_get_tny_account_by_account() to
1145 modest_tny_account_store_get_server_account() to make the code clearer.
1147 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1149 * src/dbus_api/modest-dbus-api.h:
1150 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1151 * src/maemo/modest-msg-edit-window.c:
1152 (modest_msg_edit_window_attach_file_noninteractive):
1153 added g_warning in case the file to be attached does not exist
1154 * tests/dbus_api/test_compose_mail.c: (main):
1155 removed obsolete comment, added generic files as test case
1157 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1159 * src/modest-tny-account-store.c: (get_server_accounts):
1160 Create the local folders account only once, not once for each outbox, and
1161 not only when there are some outboxes.
1163 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1165 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1166 code that is causing a crash at startup. Sergio says that he is fixing this.
1168 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1170 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1171 * src/maemo/modest-account-settings-dialog.c:
1172 (create_page_outgoing),
1173 (modest_account_settings_dialog_set_account_name),
1174 (save_configuration):
1175 - Fixed handling of the "Use secure authentication" toggle to comply with
1176 the ui specification. See also projects.maemo.org bug NB#58400
1178 - Restore the Secure connection setting combo correctly when loading
1181 * src/maemo/modest-maemo-utils.c:
1182 (on_camel_account_get_supported_secure_authentication),
1183 (modest_maemo_utils_get_supported_secure_authentication_methods):
1184 Fixed a crasher if operation is canceled
1186 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1187 (modest_protocol_info_auth_is_secure):
1188 * src/modest-protocol-info.h:
1190 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1191 the sense of the "Use secure authentication" toggle.
1193 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-tny-account-store.h:
1196 * src/modest-tny-account-store.c:
1197 Added modest_tny_account_store_get_local_folders_account().
1199 * src/modest-tny-folder.h:
1200 * src/modest-tny-folder.c:
1201 (modest_tny_folder_get_account):
1202 Added this replacement for tny_folder_get_account() which returns
1203 the local-folders account for TnyMergeFolders, to avoid the
1204 warning about the unimplemented get_account_func() vfunc().
1206 (modest_tny_folder_get_rules),
1207 * src/modest-ui-actions.c:
1208 (modest_ui_actions_on_folder_selection_changed):
1209 * src/modest-mail-operation.c:
1210 (modest_mail_operation_remove_folder),
1211 (modest_mail_operation_xfer_folder),
1212 (modest_mail_operation_rename_folder),
1213 (modest_mail_operation_get_msg),
1214 (modest_mail_operation_get_msgs_full),
1215 (modest_mail_operation_remove_msg),
1216 (modest_mail_operation_xfer_msgs),
1217 (modest_mail_operation_refresh_folder):
1218 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1220 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1222 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1223 (modest_server_account_set_security):
1224 * src/modest-defs.h: Add comments explaining that our
1225 UI spec means TLS when it says Normal, so these do not look like errors.
1227 * src/modest-tny-account.c:
1228 (modest_tny_account_new_from_server_account): Use the new tinymail
1229 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1230 for TLS. This should fix projects.maemo.org bug NB#58460.
1232 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1234 * src/maemo/easysetup/modest-easysetup-wizard.c:
1235 (create_account): Correct the position of the gconf sanity check warning.
1236 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1237 of using the g_idle_add() hack, because this does not seem to be necessary
1238 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1239 caused by something other than maemo's gconf.
1240 This fixes projects.maemo.org bug #59022.
1242 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1244 * src/modest-account-mgr-helpers.c:
1245 (modest_account_mgr_get_default_account): Do not check that the account
1246 exists if there is no default account (NULL), to fix a runtime warning.
1248 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1250 * src/widgets/modest-folder-view.c: (update_model):
1251 Do not unref the treemodel before we have finished with it.
1252 This prevents a valgrind warning and an occasional crash at startup.
1254 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1256 * libmodest-dbus-client/libmodest-dbus-client.h:
1257 added libmodest_dbus_client_compose_mail()
1258 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1260 added functions needed for SendAsMail() functionality
1261 * src/maemo/modest-msg-edit-window.c:
1262 (modest_msg_edit_window_attach_file_noninteractive):
1263 non interactively attaching files to message edit window
1264 * src/widgets/modest-msg-edit-window.h:
1265 * tests/dbus_api/Makefile.am:
1266 added test_compose_mail.c
1267 * tests/dbus_api/test_compose_mail.c: (main):
1269 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1271 * src/modest-account-view.c:
1272 Fixed bug projects.maemo.org bug NB#59307
1274 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1276 * src/maemo/easysetup/modest-easysetup-wizard.c:
1277 (get_serverport_incoming), (on_before_next), (create_account):
1278 * src/maemo/modest-account-settings-dialog.c:
1279 (modest_account_settings_dialog_set_account_name):
1280 * src/maemo/modest-maemo-utils.c:
1281 (on_camel_account_get_supported_secure_authentication_status),
1282 (on_camel_account_get_supported_secure_authentication),
1283 (on_secure_auth_cancel),
1284 (modest_maemo_utils_get_supported_secure_authentication_methods):
1286 Implemented security authentication for settings and easysetup.
1288 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1290 * src/maemo/modest-main-window.c: (create_details_widget):
1291 Show the total size for memory card accounts too, instead of showing
1292 the name again. Fixes bug projects.maemo.org bug NB#59307.
1294 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1297 * src/modest-tny-simple-folder-store.c:
1298 * src/modest-tny-simple-folder-store.h: Removed.
1300 * src/modest-tny-local-folders-account.h
1301 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1302 for the local-folders maildir, with an extra TnyMergedFolder containing
1303 the folders of the per-account outbox store accounts.
1304 * src/modest-tny-account-store.c: (get_server_accounts):
1305 Add the outboxes to the special local folders account after creating it.
1307 * src/modest-tny-account.c:
1308 (modest_tny_account_new_for_local_folders): Create the derived
1309 account when creating the main local-folders account.
1311 * src/maemo/modest-main-window.c: (create_details_widget),
1312 (modest_main_window_set_contents_style):
1313 Adapted to the use of the derived account instead of the folder store.
1315 * src/modest-ui-actions.c:
1316 (modest_ui_actions_on_folder_selection_changed):
1317 * src/modest-ui-dimming-rules.c:
1318 (modest_ui_dimming_rules_on_new_folder):
1319 * src/widgets/modest-folder-view.c: (text_cell_data),
1320 (icon_cell_data), (filter_row), (update_model),
1321 (get_cmp_rows_type_pos):
1324 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1325 Do not get the priv struct, because no priv struct has been set,
1326 to avoid a runtime warning.
1328 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1329 #ifelse with #else, to fix a warning, to fix the build.
1332 2007-06-05 Christian Kellner <ckellner@openismus.com>
1334 * libmodest-dbus-client/libmodest-dbus-client.c:
1335 Fix small typo in doc (why do you always see them
1336 AFTER committing stuff?)
1339 2007-06-05 Christian Kellner <ckellner@openismus.com>
1341 * libmodest-dbus-client/libmodest-dbus-client.c:
1342 (libmodest_dbus_client_search):
1343 Initialize hit list with NULL. Also set folder list
1344 to "" if NULL was supplied.
1347 2007-06-03 Christian Kellner <ckellner@openismus.com>
1349 * libmodest-dbus-client/libmodest-dbus-client.c:
1350 (modest_search_hit_list_free):
1351 Make it save to call it with NULL.
1353 * src/dbus_api/modest-dbus-callbacks.c:
1354 * src/modest-search.c:
1355 Return full ModestSearchHits as the search result list not TnyHeader
1356 since can't be around withouth the correspoding TnyFolder.
1358 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1360 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1361 Added currently commented code to check for secure auth
1363 * src/maemo/modest-account-settings-dialog.c: (on_response),
1364 (save_configuration), (show_ok):
1365 Fixed projects.maemo.org bugs NB #59248 and #59251
1367 * src/maemo/modest-maemo-utils.c:
1368 (on_camel_account_get_supported_secure_authentication_status),
1369 (on_camel_account_get_supported_secure_authentication),
1370 (modest_maemo_utils_get_supported_secure_authentication_methods):
1371 * src/maemo/modest-maemo-utils.h:
1372 Moved get_supported_secure_authentication() method here to be able
1373 to use it from easysetup wizard.
1375 * src/modest-pair.c: (on_pair_compare_as_string):
1376 Should compare string with first part of pair and not
1377 strcmp pairs which will crash.
1379 * src/modest-protocol-info.c:
1380 (modest_protocol_info_protocol_is_store):
1381 * src/modest-protocol-info.h:
1382 Added modest_protocol_info_get_auth_protocol_name()
1384 2007-06-03 Armin Burgmeier <armin@openismus.com>
1386 * src/modest-mail-operation.c:
1387 (modest_mail_operation_get_msgs_full): Set priv->account also when
1388 only retrieving a single message. This avoids a crash when canceling
1391 (modest_mail_operation_notify_end): Do not explicitely remove the
1392 operation from the queue but only emit the progress_changed signal.
1393 The queue itself listens to that signal to remove the operation when
1394 it is finished. This reduces coupling and removes a potential deadlock
1395 when modest_mail_operation_notify_end() is called from the queue
1396 itself. If that is a problem performance-wise, I would suggest to
1397 implement a status-changed signal or something.
1399 * src/modest-mail-operation-queue.c: Make sure to never call a
1400 function from another file while the queue is locked. This (hopefully)
1401 fixes another deadlock when exiting the application while retrieving
1404 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1406 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1407 Fixed build if libogs is not available
1409 2007-06-03 Christian Kellner <ckellner@openismus.com>
1411 * libmodest-dbus-client/libmodest-dbus-client.h:
1412 * libmodest-dbus-client/libmodest-dbus-client.c:
1413 (libmodest_dbus_client_delete_message):
1414 Implement deletion of messages (Client side).
1416 (modest_search_hit_free),
1417 (modest_search_hit_list_free):
1418 Utility functions to free the result hits.
1420 * src/dbus_api/modest-dbus-api.h:
1421 * src/dbus_api/modest-dbus-callbacks.c:
1422 (on_delete_message),
1423 (modest_dbus_req_handler):
1424 Implement deletion of messages (Server side).
1426 * tests/dbus_api/test_search.c: (main):
1429 * tests/dbus_api/Makefile.am:
1430 * tests/dbus_api/test_delete_message:
1431 Add little test for the message deletion logic
1433 2007-06-03 Armin Burgmeier <armin@openismus.com>
1435 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1436 when the operation queue was not empty. projects.maemo.org bug
1439 2007-06-03 Armin Burgmeier <armin@openismus.com>
1441 * src/widgets/modest-account-view.c
1442 (on_account_default_toggled): Toggle default account column
1443 explicitely instead of waiting for gconf notification (which is
1444 currently ignored). This should fix projects.maemo.org bug NB#56910
1445 for now. It should probably be removed when gconf notifications are
1448 2007-06-03 Christian Kellner <ckellner@openismus.com>
1450 * libmodest-dbus-client/libmodest-dbus-client.c:
1451 Removed debugging spew.
1453 * src/dbus_api/modest-dbus-callbacks.c:
1454 Added debugging info.
1456 * src/modest-search.c:
1457 (modest_search_all_accounts):
1458 Use tny_account_store_get_accounts () on the account store
1459 to get all accounts which is the way to get all accounts.
1461 * tests/dbus_api/test_search.c: (main):
1462 Make it possible to supply the search term on the command line.
1464 2007-06-03 Christian Kellner <ckellner@openismus.com>
1466 * libmodest-dbus-client/libmodest-dbus-client.c:
1467 * libmodest-dbus-client/libmodest-dbus-client.h:
1468 Implement searching for mesages over raw dbus. (Client side)
1470 * src/dbus_api/Makefile.am:
1471 * src/dbus_api/modest-dbus-api.h:
1472 * src/dbus_api/modest-dbus-callbacks.c:
1473 * src/dbus_api/modest-dbus-callbacks.h:
1474 Search framework (Server side). Also implement on_idle_open_message().
1476 * src/maemo/modest-platform.c: (modest_platform_init):
1477 Prepare for raw dbus/osso rpc interaction.
1479 * src/modest-search.h:
1480 Changed minsize from unspecific guint to guint32.
1482 * src/modest-search.c:
1484 Added strange hack which magically made tnymail work.
1486 (modest_search_folder),
1487 (modest_search_account),
1488 (modest_search_all_accounts):
1489 Implement helper functions to search all accounts, specific account
1492 * tests/dbus_api/Makefile.am:
1493 * tests/dbus_api/test_open_message.c:
1494 Read url to open from commandline.
1496 * tests/dbus_api/test_search.c:
1497 Implement small test for dbus search stuff
1499 2007-06-02 Armin Burgmeier <armin@openismus.com>
1501 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1502 include account type and account title. This fixes projects.maemo.org
1505 * src/maemo/modest-account-view-window.c: Set a title for the window.
1507 2007-06-02 Armin Burgmeier <armin@openismus.com>
1509 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1510 incoming and outgoing server name based on email address and server
1511 types as long as the names have not been edited manually. This fixes
1512 projects.maemo.org bug NB#58671.
1514 2007-06-02 Armin Burgmeier <armin@openismus.com>
1516 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1517 server type cannot be changed in future to the incoming details page
1518 when creating an account. This fixes projects.maemo.org bug NB#59029.
1520 2007-06-02 Armin Burgmeier <armin@openismus.com>
1522 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1523 and assigned max width chars so that they wrap instead of being
1524 truncated. Fixes projects.maemo.org bug NB#56126.
1526 2007-06-02 Armin Burgmeier <armin@openismus.com>
1528 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1529 introductory note to the connection specific smtp servers dialog, as
1530 section 8.12 of the email UI specification requires. This fixes
1531 projects.maemo.org bug NB#59212.
1533 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1535 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1536 Check for running mail operations, and offer to cancel them, as per the UI
1537 spec. This fixes projects.maemo.org bug NB#59041 .
1538 However, I suspect that tinymail may still use the network connection
1539 in ways that we cannot detect or cancel. But it should at least adapt to
1540 changes fairly well.
1542 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-tny-account-store.c: (recreate_all_accounts),
1545 (get_cached_accounts), (get_server_accounts): Do more sensible
1546 ref-counting of the temporarily-cached outbox accounts list. This seems
1547 to fix a crash when entering the password when the password was wrong.
1549 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1551 * src/gnome/modest-main-window.c: (connect_signals):
1552 * src/modest-tny-account-store.c: (get_password),
1553 (modest_tny_account_store_alert): Added comments and clues and
1554 commented-out code about how we currently fail to deal with connection
1555 errors and wrong passwords, and how we should.
1557 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1559 * src/widgets/modest-retrieve-combo-box.c:
1560 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1561 This fixes projects.maemo.org bug NB#58472 .
1563 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1565 * src/maemo/easysetup/modest-easysetup-wizard.c:
1566 (create_page_complete_easysetup):
1567 (create_page_complete_custom): Correct the last commit,
1568 putting the correct sentences in the correct pages.
1570 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1572 * src/maemo/easysetup/modest-easysetup-wizard.c:
1573 (create_page_complete_custom): Show the second sentence of text
1574 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1577 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1579 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1580 Set the leave-on-server conf key by default. This fixes
1581 projects.maemo.org bug NB#59258 .
1583 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1585 * src/maemo/modest-account-view-window.c:
1586 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1587 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1590 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1592 * src/maemo/easysetup/modest-easysetup-wizard.c:
1593 (create_caption_new_with_asterisk):
1594 * src/maemo/modest-account-settings-dialog.c:
1595 (create_caption_new_with_asterisk):
1596 Uncomment the code to add the asterisk, because they are no longer in the
1597 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1598 (update_incoming_server_title): Add an asterisk here too.
1600 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1602 * src/maemo/modest-maemo-global-settings-dialog.c:
1603 (current_connection): Check that we are even connected before trying to
1604 get the current connection name, to prevent a warning.
1606 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1607 Change the comments because tny_maemo_conic_device_connect() is now meant to
1609 * src/modest-mail-operation.c:
1610 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1611 make sure we have a connection and fail if we can't connect.
1613 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1615 * src/maemo/modest-main-window.c:
1616 (on_account_store_connecting_finished): Do not try to get the
1617 connection ID if we are not really connected. I am surprised that
1618 this signal handler is called when we are not connected.
1620 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-error.h:
1623 * src/modest-ui-actions.c:
1624 (modest_ui_actions_get_msgs_full_error_handler):
1625 Renamed an enum, added comments, added an enum
1626 for retrieve-limit errors.
1628 * src/modest-mail-operation.c: (foreach_add_item),
1629 (internal_folder_observer_update), (update_account_thread),
1630 (modest_mail_operation_get_msgs_full):
1631 (modest_mail_operation_update_account),
1632 Added comments about how this works, and some code that should
1633 (but does not) check the retrieve-limit. See the TODO comment.
1635 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1637 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1638 Initialize help_id to fix the build. Warnings are good.
1640 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1642 * src/widgets/modest-hbox-cell-renderer.c:
1643 (modest_hbox_cell_renderer_append):
1644 * src/widgets/modest-vbox-cell-renderer.c:
1645 (modest_vbox_cell_renderer_append):
1646 Fix the last commit by doing an extra ref.
1648 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1650 * src/widgets/modest-hbox-cell-renderer.c:
1651 (modest_hbox_cell_renderer_append):
1652 * src/widgets/modest-vbox-cell-renderer.c:
1653 (modest_vbox_cell_renderer_append):
1654 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1655 to fix the build with Maemo Bora.
1656 However, there seems to be a remaining crash, probably due to reference
1659 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1661 * src/modest-tny-account.c:
1662 (modest_tny_account_new_for_local_folders):
1663 Use hildon_file_system_info_async_new() to get a better name for
1664 the memory card account, setting it as the account name.
1665 The timing seems to work, but this is probably
1666 not the best place to do this. See the TODO comment.
1667 * src/maemo/modest-main-window.c: (create_details_widget):
1668 * src/widgets/modest-folder-view.c: (text_cell_data):
1669 Use the tny account name instead of hardcoding a name.
1671 2007-05-30 Christian Kellner <ckellner@openismus.com>
1673 * src/modest-search.c: (modest_search):
1674 Correctly set part_search_func even if we have already parsed
1675 the query and thus a valid OgsTextSearcher object.
1677 2007-05-30 Christian Kellner <ckellner@openismus.com>
1680 Search and check for libogs.
1683 Incooparte the ogs build env.
1685 * src/modest-mime-part-search-stream.c:
1686 * src/modest-mime-part-search-stream.h:
1687 Removed since we do the real searching now in modest-search.c.
1689 * src/modest-search.c:
1690 * src/modest-search.h:
1691 Implement support for ogs. We use that if available and requested
1692 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1693 should now handle the corner case when the search term is spread
1694 across multiple reads.
1695 Also the logic in modest_search () was corrected to search all
1696 requested fields until one is found.
1698 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1700 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1702 * src/modest-init.h:
1703 * src/modest-init.c: Made modest_init_local_folders() take a
1704 path and be public so we can iniitialize maildir folders on
1707 * src/modest-local-folder-info.h:
1708 * src/modest-local-folder-info.c:
1709 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1711 * src/modest-tny-account.c:
1712 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1713 still means the standard local-folders path on the local volume.
1715 * src/modest-tny-account-store.c:
1716 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1717 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1718 all accounts when that happens.
1719 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1720 this too, so it shows up in the treeview.
1722 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1724 * src/maemo/modest-maemo-global-settings-dialog.c:
1725 (current_connection):
1726 * src/widgets/modest-global-settings-dialog.c:
1727 (current_connection_default):
1728 Use the enum values instead of 0, 1 and -1,
1729 to make the code clearer.
1731 * src/modest-account-mgr-helpers.c:
1732 (modest_account_mgr_get_connection_specific_smtp): Make this code
1735 * src/modest-runtime.h:
1736 * src/modest-runtime.c:
1737 Added modest_runtime_remove_all_send_queues().
1738 * src/maemo/modest-main-window.c:
1739 (on_account_store_connecting_finished): Recreate the send queues,
1740 using the appropriate transport accounts for this new connection.
1741 Some futher adapting might be needed if the old send queues are not
1742 automatically stopped at this point.
1744 * src/modest-tny-account-store.c: (get_server_accounts):
1745 Create the connection-specific transport accounts, so that they can
1746 be found later by their ID.
1748 * src/modest-tny-account.h:
1749 * src/modest-tny-account.c:
1750 Added modest_tny_account_new_from_server_account_name().
1751 modest_tny_account_new_from_server_account(): Do not create the
1752 send queues here, because they will be
1753 recreated anyway when the connection changes for the first time.
1755 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-local-folder-info.h:
1758 * src/modest-local-folder-info.c:
1759 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1760 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1761 tbox_folder): Take a modest account name instead of a server TnyAccount,
1762 so we can have per-modest-account rather than per-transport-account
1764 We must make sure that we change or recreate the exisitng send queues
1765 when the connection changes for connection-specific transport accounts.
1767 * src/modest-tny-account-store.c:
1768 (create_per_account_local_outbox_folders): Create outboxed per modest
1769 account, not per transport account.
1771 * src/modest-tny-account.h:
1772 * src/modest-tny-account.c:
1773 (modest_tny_account_get_special_folder): For outboxes, get the
1774 parent modest account name. The account is ignored for other folders.
1775 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1776 modest account name rather than a server TnyAccount.
1778 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1780 * src/modest-tny-account.c:
1781 (modest_tny_account_new_from_server_account):
1782 Call modest_runtime_get_send_queue() immediately after creating transport
1783 accounts, so that they start trying to send email from the outbox as soon
1784 as possible at startup. This is probably what we want.
1786 * src/modest-mail-operation.c: (update_account_thread):
1787 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1788 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1789 * src/modest-tny-send-queue.h:
1790 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1791 (modest_ui_actions_on_send):
1792 Added comments about how sending works, though it needs some more work.
1794 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1796 * src/modest-tny-account.c:
1797 (modest_tny_account_get_special_folder): Add TODO because this fails when
1798 the network is busy.
1799 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1800 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1801 Do not try to show this window when there is no active account. The UI
1802 specs does not tell us what to do in this case.
1804 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1808 * src/maemo/Makefile.am:
1809 * src/widgets/Makefile.am: Some dist fixes.
1811 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1813 * src/maemo/modest-connection-specific-smtp-window.c:
1814 (on_button_edit): Make the code clearer, to prevent a double free.
1816 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1818 * src/maemo/modest-account-settings-dialog.c:
1819 (modest_account_settings_dialog_set_account_name),
1820 Check the connection-specific smtp servers checkbox if there are any.
1822 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1823 (modest_connection_specific_smtp_edit_window_init):
1824 Start with a suitable port number.
1826 * src/modest-account-mgr-helpers.h:
1827 * src/modest-account-mgr-helpers.c: Added
1828 modest_account_mgr_get_has_connection_specific_smtp().
1830 (modest_account_mgr_set_connection_specific_smtp),
1831 (modest_account_mgr_remove_connection_specific_smtp),
1832 (modest_account_mgr_get_has_connection_specific_smtp),
1833 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1834 connection-specific smtp server accounts in the account, rather than
1835 the server account conf dir.
1837 This fixes bug projects.maemo.org bug NB#58263 .
1839 * src/modest-tny-account-store.c:
1840 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1841 if there are no server accounts yet, to prevent an infinite loop when there
1842 are no accounts. Document that one must be called before the other.
1844 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1846 * src/modest-account-mgr-helpers.c:
1847 (modest_account_mgr_get_default_account): Make sure that at least
1848 one account is always the default, if there are any enabled accounts.
1849 This is just a sanity check that shouldn't be necessary.
1851 * src/modest-account-mgr-priv.c:
1852 (_modest_account_mgr_account_from_key): Unescape the conf key to
1853 get the real account name. For instance, this is an issue if a space
1854 was in the account name, which can happen because the account name
1855 is generated from the display name.
1856 (_modest_account_mgr_get_account_keyname): Always escape the
1858 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1859 Unescape the conf keys to get the real account names.
1861 For instance, previously the is-default radio button in the accounts
1862 list was not checked for any accounts at first. This fixes that,
1863 and might fix several similar bugs.
1865 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1867 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1868 Removed some debug printfs.
1870 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1872 Modest on-disk outbox directories are now here, for instance:
1873 $HOME/.modest/outboxes/<account-id-1>/outbox
1874 $HOME/.modest/outboxes/<account-id-2>/outbox
1876 $HOME/.modest/local-folders/outbox
1877 so we can have a separate outbox for each account.
1878 But they are shown as one outbox in the GtkTreeView, by using a
1879 TnyMergeFolder in a ModestTnySimpleFolderStore.
1882 * src/modest-tny-simple-folder-store.c:
1883 * src/modest-tny-simple-folder-store.h:
1884 Added ModestTnySimpleFolderStore, used to contain folders from
1885 other folder stores, such as other accounts.
1887 * src/modest-tny-outbox-account.h:
1888 * src/modest-tny-outbox-account.c:
1889 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1890 used for the per-account local outbox folders.
1892 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1893 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1894 only use this (internally) now for the non-outbox local folders.
1896 * src/modest-init.h:
1897 * src/modest-init.c: Added modest_init_one_local_folder(), for
1898 setting up the directory structure for each local folder.
1900 * src/modest-local-folder-info.c:
1901 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1902 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1904 * src/modest-local-folder-info.h:
1905 * src/modest-tny-account-store.c: (on_account_removed),
1906 (on_account_changed), (create_per_account_local_outbox_folders),
1907 (get_server_accounts), (modest_tny_account_store_get_accounts),
1908 (modest_tny_account_store_get_tny_account_by_account),
1909 (modest_tny_folder_store_is_virtual_local_folders):
1911 * src/modest-tny-account.h:
1912 * src/modest-tny-account.c:
1913 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1914 to create an on-disk per-account local outbox folder for each
1916 (create_per_account_local_outbox_folders): Create a local outbox folder
1917 for each transport account.
1918 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1919 for all local folders.
1921 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1922 instead of using g_object_get/set() directly. It is clearer.
1924 (modest_tny_folder_store_get_message_count),
1925 (modest_tny_folder_store_get_local_size
1926 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1927 because we now use these with non-acount folder stores.
1929 (modest_tny_account_get_special_folder),
1930 (modest_tny_account_new_from_server_account),
1931 (modest_tny_account_new_from_account):
1932 (recurse_folders): Adjust to the new outbox system.
1934 * src/modest-tny-folder.h:
1935 * src/modest-tny-folder.c:
1936 (modest_tny_folder_is_local_folder),
1937 (modest_tny_folder_get_local_folder_type),
1938 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1940 * src/widgets/modest-main-window.h:
1941 * src/maemo/modest-main-window.c: (create_details_widget),
1942 (modest_main_window_set_contents_style): Show details for any folder store,
1945 (modest_tny_folder_get_rules):
1946 Remove the const. C does not support constness enough for this.
1948 * src/modest-ui-actions.c:
1949 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1950 make all outboxes appear as one, in the usual local-folders tree node.
1952 (set_active_account_from_tny_account),
1953 (modest_ui_actions_on_folder_selection_changed):
1954 * src/widgets/modest-folder-view.c: (text_cell_data),
1955 (icon_cell_data), (filter_row),
1956 (add_account_folders_to_merged_folder),
1957 (add_account_folders_to_simple_folder_store), (),
1958 (get_cmp_rows_type_pos), (cmp_rows),
1959 (modest_folder_view_set_account_id_of_visible_server_account):
1960 Adjust to the new outbox system, using generic folder stores and folders
1961 in the GtkTreeModel.
1963 2007-05-23 Christian Kellner <ckellner@openismus.com>
1965 * src/modest-mail-operation.c:
1966 (modest_mail_operation_update_account):
1967 Use info->max_size instead of unintialized local var [small
1968 build fix]. (Added TODO to review that change since I don't
1971 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1973 * libmodest-dbus-client/libmodest-dbus-client.c:
1974 (libmodest_dbus_client_compose_mail): function added
1975 * src/dbus_api/modest-dbus-api.h:
1976 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1977 (on_compose_mail): Implementation of the SendAsMail functionality
1979 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-account-mgr.c:
1982 (modest_account_mgr_add_server_account): Set the secure-connection
1983 conf key for transport accounts as well as store accounts. I don't know
1984 why the if was there. For instance, this makes sure that we use SSL
1985 for the gmail preset from the easysetup wizard.
1987 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1989 * src/gnome/modest-main-window.c:
1990 (on_account_store_connecting_finished), (connect_signals):
1991 * src/maemo/modest-main-window.c:
1992 (on_account_store_connecting_finished), (connect_signals),
1993 (modest_main_window_new):
1994 Handle TnyAccountStore::connecting-finished instead of
1995 TnyDevice::connection-changed, because we cannot actually perform
1996 operations on accounts until TnyAccountStore has itself responded to
1997 the TnyDevice::connection-changed signal. This prevents a GError from
1999 Do not try to update at startup, because we (at least on scratchbox)
2000 already do an update at startup when the device goes online.
2001 This prevents a GError from tinymail.
2002 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2003 Added TODO about stopping simultaneous operations.
2005 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2007 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2008 * src/modest-mail-operation-queue.c:
2009 (modest_mail_operation_queue_remove):
2010 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2011 about where they happened.
2013 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2015 * src/modest-ui-actions.c:
2016 (modest_ui_actions_on_password_requested): Make sure that the remember
2017 output parameter is always TRUE.
2019 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2022 Show a OK/Cancel dialog if the error is a question, though we still do not
2023 know anything more about what we are asking the user.
2024 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2025 Fix an uninitialized variable (helper). This is a logic error, however.
2027 2007-05-21 Christian Kellner <ckellner@openismus.com>
2029 * src/modest-search.h:
2030 Correct bit shifting in the ModestSearchFlags enum.
2032 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2034 * src/modest-tny-account.c:
2035 (modest_tny_account_new_from_server_account): Do not use the lsub and
2036 check-all hard-coded IMAP options when using POP.
2038 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2040 * src/modest-tny-account.c:
2041 (modest_tny_account_new_from_server_account):
2042 Use NULL for the secure-auth method for POP when Password auth has been
2043 specified by the user, as we already do for IMAP. "auth=Login" causes
2044 an error from camel or the server.
2046 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/modest-account-settings-dialog.c:
2049 (create_page_account_details),
2050 (modest_account_settings_dialog_set_account_name):
2051 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2052 for the leave-on-server checkbox, rathr than just the checkbox, when
2053 the protocol is not POP.
2055 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2057 * src/widgets/modest-account-view.c:
2058 * src/widgets/modest-account-view.h:
2059 Added modest_account_view_select_account() which will be useful later
2060 to asynchronously re-select the edited account.
2062 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2064 * src/maemo/modest-account-settings-dialog.c:
2065 (modest_account_settings_dialog_set_account_name):
2066 Automatically choose the port numbers based on the secure authentication
2067 methods, if they have not been chosen before.
2068 This fixes projects.maemo.org bug NB#56273 .
2070 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2072 * src/maemo/modest-main-window-ui.h:
2073 * src/modest-ui-actions.c:
2074 * src/modest-ui-actions.h:
2075 Connect the Tools/SMTP Servers menu item to
2076 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2077 SMTP servers dialog, as in the UI specification and saves changes when it
2078 is closed. This fixed projects.maemo.org bug NB#56305 .
2080 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2082 * src/maemo/modest-connection-specific-smtp-window.c:
2083 (modest_connection_specific_smtp_window_init):
2084 Use gtk_window_set_default_size() to make this window big enough, so
2085 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2087 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2089 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2090 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2091 (modest_connection_specific_smtp_edit_window_init),
2092 Do not try to connect to a combobox signal before the combobox exists.
2093 This fixes the cras in projects.maemo.org bug NB#56288 .
2094 (modest_connection_specific_smtp_edit_window_get_settings):
2095 Remove the server_account_name parameter which was being checked for NULL
2096 though it was not used.
2098 * src/maemo/modest-connection-specific-smtp-window.c:
2099 (modest_connection_specific_smtp_window_fill_with_connections),
2100 (on_button_edit), (modest_connection_specific_smtp_window_init):
2101 Correct the number of treemodel columns to prevent a warning.
2102 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2103 libconic does not work.
2105 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2107 * src/modest-tny-account.c:
2108 (modest_tny_account_new_from_server_account):
2109 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2110 SMTP when "None" was chosen by the user. However, with my SMTP server that
2111 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2114 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2117 to explain the memory management issue with the ID in the ModestPair.
2119 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2120 (add_sending_page), (modest_account_assistant_finalize):
2121 * src/gnome/modest-gnome-global-settings-dialog.c:
2122 (create_updating_page), (create_composing_page):
2123 * src/gnome/modest-msg-edit-window.c: (get_transports),
2124 (init_window), (modest_msg_edit_window_finalize),
2125 (modest_msg_edit_window_get_msg_data):
2126 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2127 * src/gnome/modest-transport-widget.c:
2128 (modest_transport_widget_finalize), (smtp_configuration):
2129 * src/maemo/modest-maemo-global-settings-dialog.c:
2130 (create_updating_page), (create_composing_page):
2131 * src/maemo/modest-msg-edit-window.c: (get_transports),
2132 (init_window), (modest_msg_edit_window_finalize),
2133 (modest_msg_edit_window_get_msg_data),
2134 (modest_msg_edit_window_free_msg_data):
2135 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2136 (modest_store_widget_finalize):
2137 * src/maemo/modest-transport-widget.c:
2138 (modest_transport_widget_finalize), (smtp_configuration):
2139 * src/modest-main.c: (send_mail):
2140 * src/widgets/modest-combo-box.h:
2141 * src/widgets/modest-global-settings-dialog-priv.h:
2142 * src/widgets/modest-global-settings-dialog.c:
2143 (modest_global_settings_dialog_finalize):
2144 * src/widgets/modest-msg-edit-window.h:
2145 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2146 as long as the combo box, to prevent use of freed memory for the ID.
2148 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2151 get_accounts(), to make this clearer. Do not check for the enabled gconf
2152 key, because we do not use this for server accounts (at least, not yet).
2153 This allows us to send email again.
2155 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/modest-platform.c:
2158 (on_modest_conf_update_interval_changed), (modest_platform_init):
2159 Only respond to this particular key change. All these strcmp()s cannot be
2162 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2164 * src/maemo/modest-maemo-global-settings-dialog.c:
2165 (current_connection): Prevent a crash in scratchbox when
2166 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2167 * src/maemo/modest-platform.c:
2168 (on_modest_conf_update_interval_changed), (modest_platform_init):
2169 Get the update interval from gconf and reset it when the gconf key changes.
2171 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2173 * src/modest-protocol-info.c:
2174 * src/modest-protocol-info.h: Adde enum-specific get functions,
2175 instead of using a ModestProtocolType enum parameter.
2177 * src/gnome/modest-account-assistant.c:
2178 * src/gnome/modest-store-widget.c:
2179 * src/gnome/modest-store-widget.h:
2180 * src/gnome/modest-transport-widget.c:
2181 * src/gnome/modest-transport-widget.h:
2182 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2183 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2184 * src/maemo/easysetup/modest-easysetup-wizard.c:
2185 * src/maemo/modest-account-settings-dialog.c:
2186 * src/maemo/modest-account-settings-dialog.h:
2187 * src/maemo/modest-store-widget.c:
2188 * src/maemo/modest-store-widget.h:
2189 * src/maemo/modest-transport-widget.c:
2190 * src/maemo/modest-transport-widget.h:
2191 * src/modest-account-mgr-helpers.c:
2192 * src/modest-account-mgr-helpers.h:
2193 * src/modest-account-mgr.c:
2194 * src/modest-account-mgr.h:
2195 * src/modest-tny-account.c:
2196 * src/modest-tny-folder.c:
2197 * src/widgets/modest-account-view.c:
2198 * src/widgets/modest-retrieve-combo-box.c:
2199 * src/widgets/modest-retrieve-combo-box.h:
2200 * src/widgets/modest-secureauth-combo-box.c:
2201 * src/widgets/modest-serversecurity-combo-box.c:
2202 * src/widgets/modest-serversecurity-combo-box.h:
2203 * tests/check_account-mgr.c:
2204 Use the specific functions, and use the re-renamed enum values for GNOME too.
2206 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2208 * src/modest-pair.h:
2209 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2210 so we can get the second based on the first.
2212 * src/maemo/modest-account-settings-dialog.h:
2213 * src/maemo/modest-account-settings-dialog.c:
2214 Added get_supported_secure_authentication_methods(), though it is mostly
2215 commented-out for now until the necessary API is committed to tinymail.
2216 (modest_account_settings_dialog_set_account_name),
2217 (save_configuration): Request the supported authentication methods from the
2218 server, so we can choose a working method.
2220 * src/modest-tny-account-store.h:
2221 * src/modest-tny-account-store.c:
2222 (modest_tny_account_store_get_session): Rename from
2223 tny_account_store_get_session().
2225 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2227 * src/modest-protocol-info.h: Split the ModestProtocol enum
2228 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2229 There was no need to have these unrelated values in one enum.
2231 * src/: many files: Adapted to changed enum. This makes the code a bit
2232 clearer, and the compiler could catch some errors.
2234 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2236 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2237 Show the detailed internal camel error message when an error happens
2238 during the configuration, so that our testers can give us more clues.
2239 For instance, in projects.maemo.org bug NB#56910 .
2241 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2243 * src/modest-tny-account.c:
2244 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2245 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2247 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2249 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2250 * src/maemo/modest-account-settings-dialog.c:
2251 (modest_account_settings_dialog_set_account_name),
2252 (save_configuration): For the incoming secure authentication checkbox,
2253 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2254 the UI specification. PLAIN does not seem to be supported for most IMAP
2255 servers anyway, and I am not sure what it would mean.
2256 However, we probably need to discover which of the secure-authentication
2257 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2258 * src/modest-account-mgr-helpers.c:
2259 (modest_account_mgr_get_server_account_data):
2261 * src/modest-tny-account.c:
2262 (modest_tny_account_new_from_server_account):
2263 Use tny_account_set_mech() to set secure-authentication methods,
2264 with some special-casing for IMAP, based on my observations of how
2267 * src/modest-account-mgr-helpers.h:
2268 * src/modest-account-mgr.c:
2269 * src/modest-defs.h: Comment that the URI is only used for local folders.
2271 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2273 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2274 parameter const, just to be neat.
2275 * src/modest-text-utils.c: (modest_text_utils_inline):
2276 End g_strconcat() with NULL, as its documentation says. This is almost
2277 certainly the cause of my crash at startup on the device. Interestingly,
2278 valgrind doesn't tell us about these errors.
2280 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2282 * scripts/build-packages: Added more precise comments about how to use
2283 this script, though I still get this error:
2284 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2285 error building tinymail
2287 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2289 * src/maemo/modest-main-window.c: (on_account_update):
2290 Very slight cleanup, hoping to make it simpler to discover what causes
2291 a crash here sometimes.
2293 * src/modest-tny-account.c:
2294 (modest_tny_account_new_from_server_account): Set the port. Added
2295 comments about the options and a TODO comment because I need to find out
2296 how to specify the secure authentication method.
2298 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2300 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2301 changed CFlags paths form modest to libmodest
2303 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2305 * src/modest-account-mgr-helpers.c:
2306 (modest_account_mgr_get_server_account_data),
2307 (modest_account_mgr_free_server_account_data):
2308 * src/modest-account-mgr-helpers.h:
2309 * src/modest-account-mgr.c:
2310 (modest_account_mgr_add_server_account):
2311 * src/modest-defs.h:
2312 * src/modest-tny-account.c:
2313 (modest_tny_account_new_from_server_account):
2314 Determine the options for tny_camel_account_add_option() here,
2315 based on the settings, rather than storing them directly in gconf.
2317 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2319 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2320 Show a more friendly error dialog now that we expect (from the tinymail
2321 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2323 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/modest-main-window.c: (on_account_update): Check that
2326 account_name is not NULL, to prevent a crash at startup that I am
2327 seeing on the N800. I do wonder why it is NULL.
2329 * src/maemo/easysetup/modest-easysetup-wizard.c:
2330 (create_page_user_details):
2331 * src/maemo/modest-account-settings-dialog.c:
2332 (create_page_user_details), (create_page_outgoing):
2333 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2334 (modest_connection_specific_smtp_edit_window_init):
2335 * src/modest-ui-actions.c:
2336 (modest_ui_actions_on_password_requested):
2337 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2338 might do something useful with the on-screen keyboard.
2340 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2342 * src/maemo/modest-main-window.c: (on_account_update):
2343 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2344 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2346 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2348 * src/modest-tny-account-store.c: (on_account_changed):
2349 Correct the signature of this signal handler.
2351 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2353 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2354 Show a HildonNote instead of a GtkDialog for Maemo.
2356 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2358 * src/widgets/modest-account-view.h:
2359 * src/widgets/modest-account-view.c: (on_account_changed),
2360 (on_account_removed). Added a boolean flag, set/unset by
2361 modest_account_view_block_conf_updates(),
2362 modest_account_view_unblock_conf_updates() to prevent unnecessary
2363 updates, but this is not very useful because the gconf notifications are
2364 so delays (maybe only on Maemo Bora).
2365 So auto-updating is turned off, and these functions do an explicit
2366 update when necessary.
2367 However, something else is still doing too much work when adding/removing
2368 accounts, probably in another part of the application.
2370 * src/maemo/modest-account-view-window.c:
2371 (on_delete_button_clicked), (on_edit_button_clicked),
2372 (on_new_button_clicked): Use the new functions.
2374 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2376 * src/modest-account-mgr-helpers.c:
2377 (modest_account_mgr_set_first_account_as_default):
2378 Sort the list of names alphabetically-by-title, so we choose the first one
2380 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2381 alphabetically by the title.
2383 This fixes projects.maemo.org bug NB#56418 .
2385 * src/modest-account-mgr-priv.c:
2386 (_modest_account_mgr_account_from_key):
2387 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2388 avoid a valgrind error, and possible random behaviour.
2390 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2392 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2393 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2394 tinymail documentation to say that this can be expected.
2395 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2396 pretty, and should not happen, but I would prefer to know when it does.
2398 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2400 * configure.ac: When using the older hildon version, probably on Bora,
2401 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2403 * src/widgets/modest-attachment-view.c:
2404 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2407 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2409 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2410 Implemented the prototype. Can be tested with
2411 tests/dbus_api/test_open_message:
2413 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2415 * src/modest-tny-account-store.c:
2416 (modest_tny_account_store_instance_init), (get_password):
2417 * src/modest-ui-actions.c:
2418 (modest_ui_actions_on_password_requested):
2419 Do not store the password in gconf, because this function is called
2420 for non-remembered passwords. Actually use the cached (in the hash map)
2421 password instead of releasing it.
2422 The password will now not be remembered if it is asked via the protected
2423 password dialog, as per the UI spec.
2425 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2427 * src/modest-defs.h:
2428 * src/modest-account-mgr-helpers.h:
2429 * src/modest-account-mgr-helpers.c:
2430 Added modest_server_account_get_username_has_succeeded(),
2431 modest_server_account_set_username_has_succeeded().
2432 (modest_server_account_set_username),
2433 Reset the has-succeeded flag if the username changes.
2435 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2436 * src/maemo/modest-connection-specific-smtp-window.c:
2437 (modest_connection_specific_smtp_window_save_server_accounts):
2438 Use modest_server_account_set_username() instead of using
2439 modest_conf_set_string() directly, so that the has-succeeded flag is always
2442 * src/modest-ui-actions.c:
2443 (modest_ui_actions_on_password_requested): Dim the username entry if
2444 the username has ever worked, as per the UI spec.
2446 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2448 * src/modest-tny-account-store.c: (get_password):
2449 * src/modest-ui-actions.c:
2450 (modest_ui_actions_on_password_requested):
2451 Allow the username to be changed too, though there is more work to
2452 be done on exactly how this behaves.
2454 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2456 * src/modest-account-mgr-helpers.h:
2457 * src/modest-account-mgr-helpers.c:
2458 Added modest_account_mgr_get_display_name(),
2459 modest_server_account_get_username(),
2460 modest_server_account_set_username(),
2461 modest_server_account_set_password(),
2462 modest_server_account_get_hostname() functions so we do not need to
2463 use the conf API directly.
2465 * src/maemo/modest-main-window.c: (connect_signals):
2466 Actually connect ot the ModestAccountStore::request-password signal,
2467 so that we show the dialog when the password is requested by Tinymail,
2468 for isntance if it is empty.
2470 * src/modest-marshal.list:
2471 * src/modest-tny-account-store.c:
2472 (modest_tny_account_store_class_init), (get_password),
2473 (modest_tny_account_store_alert):
2474 * src/modest-tny-account-store.h:
2475 * src/modest-ui-actions.h:
2476 * src/modest-ui-actions.c:
2477 (modest_ui_actions_on_password_requested):
2478 Change the signal parameters, so it is obvious that we are providing
2479 the non human-readable server name, and receiving both the username
2480 and password, though changing of the username is not yet implemented.
2481 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2482 for the GNOME version.
2484 This should fix the projects.maemo.org bug NB#56209, though it does not
2485 work on Bora, because the gconf_client_get() for the password fails
2486 immediately after we save it with gconf_client_set().
2488 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2491 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2492 caused an undefined symbol error:
2493 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2495 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2497 * src/modest-tny-account-store.c:
2498 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2499 using a GError instead of a string message, so we can translate it in
2502 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2504 * src/maemo/modest-address-book.c:
2505 (modest_address_book_check_names):
2506 * src/maemo/modest-msg-view-window.c:
2507 (modest_msg_view_window_clipboard_owner_change):
2508 * src/modest-init.c: (modest_init_init_ui):
2509 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2510 (update_folders_cb), (modest_mail_operation_update_account):
2511 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2512 (modest_ui_actions_on_msg_attachment_clicked),
2513 (modest_ui_actions_on_msg_recpt_activated):
2514 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2515 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2516 (modest_msg_view_search_next):
2517 * src/widgets/modest-recpt-editor.c:
2518 (modest_recpt_editor_on_button_release_event),
2519 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2520 g_message(). At this point we should only be seeing interesting errors on
2521 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2523 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2525 (modest_wizard_dialog_force_title_update):
2526 * src/maemo/easysetup/modest-wizard-dialog.h:
2527 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2528 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2529 can update the title when appropriate. Otherwise the title is wrong if the
2530 pages are added after adding the notebook to the dialog.
2531 This must be a problem in HildonWizardDialog too.
2532 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2534 * src/maemo/easysetup/modest-easysetup-wizard.c:
2535 (create_subsequent_customsetup_pages),
2536 (create_subsequent_easysetup_pages):
2537 Call modest_wizard_dialog_force_title_update() so that the title is
2538 correct even with GTK+ < 2.10.
2539 This fixes projects.maemo.org bug NB#56145 .
2541 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2543 * src/maemo/modest-platform.c:
2544 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2545 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2548 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2550 * src/widgets/modest-window.h:
2551 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2552 and modest_window_save_state(), which invokes it.
2554 * src/widgets/modest-window-mgr.h:
2555 * src/widgets/modest-window-mgr.c:
2556 Added modest_window_mgr_save_state_for_all_windows(), which calls
2557 the save_state vfunc on all registered windows, if implemented.
2559 * src/gnome/modest-msg-edit-window.c:
2560 * src/gnome/modest-msg-view-window.c:
2561 * src/maemo/modest-msg-edit-window.c:
2562 * src/maemo/modest-msg-view-window.c:
2563 * src/maemo/modest-main-window.c:
2564 Specify the existing save_settings functions as implementations of
2565 ModestWindow::save_state_func().
2567 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2568 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2569 enabling hibernation, for instance.
2571 We may need to do the same thing for restoring settings.
2574 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2576 * src/widgets/modest-window-mgr.c:
2577 * src/widgets/modest-window-mgr.h:
2578 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2579 modest_window_mgr_get_hibernation_is_prevented().
2581 * src/maemo/modest-main-window.c:
2582 (on_hildon_program_is_topmost_notify): Prevent hibernation
2583 (possible when the application goes to the background in the WM),
2584 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2586 * src/maemo/easysetup/modest-easysetup-wizard.c:
2587 (modest_easysetup_wizard_dialog_init):
2588 * src/maemo/modest-account-settings-dialog.c:
2589 (modest_account_settings_dialog_init):
2590 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2591 (modest_connection_specific_smtp_edit_window_init):
2592 * src/maemo/modest-connection-specific-smtp-window.c:
2593 (modest_connection_specific_smtp_window_init):
2594 * src/maemo/modest-signature-editor-dialog.c:
2595 (modest_signature_editor_dialog_init):
2596 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2597 prevent hibernation while any of these account settings dialogs are open.
2599 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2601 * src/maemo/Makefile.am:
2602 * src/maemo/modest-osso-state-saving.c:
2603 * src/maemo/modest-osso-state-saving.h: Added
2604 modest_osso_load_state() and modest_osso_save_state() though they do
2605 nothing now. They should iterate through all the open windows and load/save
2607 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2608 save state when closing.
2610 * src/maemo/modest-main-window.c:
2611 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2612 Add a notification handler for the HildonProgram::is-topmost property,
2613 so we can allow hibernation when the application goes into the background.
2614 But we still need to detect when the accounts setup windows are open so
2615 we can stop hibernation when they are open.
2616 To do this, I also added the main window the HildonProgram. This might have
2617 other side-effects/benefits, and should maybe be done for other windows.
2619 * src/maemo/modest-osso-autosave-callbacks.h:
2620 * src/maemo/modest-osso-autosave-callbacks.c:
2621 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2622 though it does not do anything yet, and we might never need this to do
2623 anything. For instance, we already save drafts.
2625 * src/maemo/modest-platform.c: (modest_platform_init):
2626 Specify the libosso auto-save callback.
2628 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2630 * src/maemo/modest-platform.c:
2631 (modest_platform_set_update_interval):
2632 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2633 aparently stays valid between application instances, so we can use this
2634 to remove and reset it later. According to a maemo-developers email from
2637 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2639 * configure.ac: Depend on libalarm for Maemo.
2641 * src/dbus_api/modest-dbus-api.h:
2642 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2643 (on_send_receive), (modest_dbus_req_handler):
2644 Handle a SEND_RECEIVE D-Bus method.
2646 * libmodest-dbus-client/libmodest-dbus-client.c:
2647 (libmodest_dbus_client_send_and_receive):
2648 * libmodest-dbus-client/libmodest-dbus-client.h:
2649 Add C convenience functions for calling the new D-Bus method.
2651 * src/modest-platform.h:
2652 * src/gnome/modest-platform.c:
2653 * src/maemo/modest-platform.c:
2654 Added modest_platform_set_update_interval(), which uses the
2655 alarmd API on Maemo.
2656 (modest_platform_init),
2657 Call modest_platform_set_update_interval(), using a hard-coded
2658 interval for now (until the global settings dialog is implemented),
2659 though I am not sure that this makes sense yet.
2661 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2663 * src/dbus_api/modest-dbus-callbacks.c:
2664 (modest_osso_cb_hw_state_handler):
2665 * src/dbus_api/modest-dbus-callbacks.h:
2666 * src/maemo/modest-platform.c: (modest_platform_init):
2667 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2668 in case this has some effect on the ability for Maemo to ping the
2671 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2673 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2674 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2675 warning. It is probably a logic error, but I need to fix the build.
2677 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2679 * src/modest-account-mgr.h:
2680 * src/modest-account-mgr.c:
2681 (modest_account_mgr_account_names): Add a gboolean enabled_only
2682 parameter, so we can get lists of onlt the enabled accounts.
2684 (modest_account_mgr_add_account),,
2685 (modest_account_mgr_account_with_display_name_exists):
2686 * src/maemo/modest-msg-edit-window.c: (get_transports):
2687 * src/modest-account-mgr-helpers.c:
2688 (modest_account_mgr_set_first_account_as_default):
2689 * src/modest-init.c: (init_default_account_maybe):
2690 * src/modest-tny-account-store.c: (get_accounts):
2691 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2692 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2693 * tests/check_account-mgr.c: (START_TEST):
2694 Provide the extra parameter, as appropriate.
2696 * src/widgets/modest-account-view.c: (update_account_view):
2697 Do not show disabled accounts (meaning that there is no way to
2698 enable/disable accounts in the UI (the feature is not in our UI
2699 specification), so we can use this internally only to mark unfinished
2700 or temporary account data.
2702 * src/maemo/easysetup/modest-easysetup-wizard.c:
2703 (create_account): Add boolean enable parameter, so we can specify FALSE
2704 to create the temporary account.
2705 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2706 (on_before_next): When finishing, when there is a temporary account, just
2708 Also, use a timeout to delay the showing of the dialog until gconf is likely
2709 to return correct information, due to a maemo gconf bug that is fixed in
2710 osso 1.1, but not yet in Bora.
2711 However, the dialog stays on screen after it is destroyed.
2713 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2714 for invalid data when cancelling. Use a hildon note instead of a dialog
2715 to complain about invalid data. Do not show the account-saved note if the
2716 account is disabled (a temporary account that will not really be saved for use
2719 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2721 * src/modest-account-mgr-helpers.h:
2722 * src/modest-account-mgr-helpers.c:
2723 Added modest_account_mgr_unset_default_account(),
2724 Added modest_account_mgr_set_first_account_as_default().
2726 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2727 If it was the default account, unset the default account name.
2729 * src/maemo/modest-account-view-window.c:
2730 (on_delete_button_clicked): If it was the default account,
2731 set the first remaining account as the default instead.
2733 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2734 a NULL account or a NULL default account, to prevent a crash. This should
2735 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2738 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2740 * src/widgets/modest-recpt-editor.c:
2741 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2742 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2743 TODO comment for this. This fixes the build.
2745 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2746 be the best place for it. This will in future update all auto-update accounts,
2747 rather than just the current/default account, when that gconf key exists.
2748 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2749 if there are no accounts, before calling do_send_receive().
2750 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2752 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2753 * src/maemo/modest-main-window-ui.h:
2754 * src/maemo/modest-main-window.c: (on_connection_changed),
2755 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2756 directly, becaue the signal handler does more.
2758 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2760 * src/modest-account-mgr-helpers.c:
2761 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2762 for the case that the account does not exist.
2764 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2765 (equivalent to the modest account name) rather than the tinymail account name
2766 (equivalent to the modest account title - human readable) to get the account data.
2767 Check for null account data to prevent the crash, and add a TODO comment saying that
2768 this needs fixing because it is using the server account name instead of the account name.
2770 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2772 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2773 * src/maemo/modest-account-settings-dialog.c: (show_error),
2775 Use hildon_note_new_information() for informative and error messages,
2776 which seems to be expected for Maemo applications (no documentation that I know of
2777 says this). I am surprised that there is no distinction between info and error
2780 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2782 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2783 it is easy to find where this is used.
2785 * src/maemo/easysetup/modest-easysetup-wizard.c:
2786 (create_page_welcome), (create_page_account_details),
2787 (create_page_user_details), (create_page_complete_easysetup),
2788 (create_page_custom_incoming), (create_page_custom_outgoing),
2789 (create_page_complete_custom):
2790 * src/maemo/modest-account-settings-dialog.c:
2791 (create_page_account_details), (create_page_user_details),
2792 (create_page_incoming), (create_page_outgoing):
2793 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2794 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2795 (modest_connection_specific_smtp_edit_window_init):
2796 * src/maemo/modest-connection-specific-smtp-window.c:
2797 (modest_connection_specific_smtp_window_init):
2798 * src/maemo/modest-signature-editor-dialog.c:
2799 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2800 and scrolling policy as per the Email Application Layout Guide, if I have
2803 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2805 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2806 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2807 which were empty, because these vfuncs have been removed from TnyAccountStore.
2808 This fixes the build.
2810 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2812 * src/maemo/modest-main-window.c:
2813 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2814 showing/hiding it. Added TODO because it probably should not be NULL.
2815 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2816 because unnecessary g_warnings() make degugging difficult.
2818 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/modest-msg-edit-window.c:
2821 (modest_msg_edit_window_select_color),
2822 (modest_msg_edit_window_select_background_color): 2 const corrections and
2823 moving 2 #endifs before closing brackets, to fix the build.
2825 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2827 * src/maemo/easysetup/modest-easysetup-wizard.h:
2828 * src/maemo/easysetup/modest-easysetup-wizard.c:
2829 (modest_easysetup_wizard_dialog_finalize),
2830 (on_button_edit_advanced_settings), (create_page_complete_custom),
2831 (on_response), (create_account):
2832 Implement the Advanced Settings edit button, by saving the account information,
2833 for the Advanded Settings dialog to use directly from gconf, and removing it
2834 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2835 Bug #5533 in the projects.maemo.org bugzilla.
2837 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2839 * src/maemo/modest-msg-view-window.c:
2840 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2841 when opening a message window.
2843 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2845 * src/maemo/easysetup/modest-easysetup-wizard.c:
2846 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2849 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2850 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2851 gconf settings. I probably added more checks than necessary, but that is safer.
2853 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2854 variable to fix the build, but this seems to be used when it is still NULL.
2856 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2858 * src/modest-platform.h:
2859 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2860 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2861 * src/modest-main.c: Implement this function so we can avoid using
2862 maemo-specific API from cross-platform code.
2864 * src/modest-tny-account-store.c:
2865 (get_smtp_specific_transport_account_for_open_connection):
2866 * src/modest-ui-actions.c: (check_for_connection),
2867 (modest_ui_actions_on_item_not_found):
2868 Use modest_platform_connect_and_wait() and put #idefs around other
2869 maemo-specific code, because only maemo currently has a way to
2870 identify connection names.
2872 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2874 * src/modest-tny-account-store.h:
2875 * src/modest-tny-account-store.c:
2876 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2877 the connection-specific SMTP server settings in the configuration.
2879 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2881 * src/maemo/modest-main-window.c: (on_connection_changed),
2883 * src/modest-main.c: (main), (start_ui), (send_mail):
2884 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2885 that is what is intended.
2887 * src/modest-ui-actions.c: (action_send), (action_receive),
2888 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2889 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2890 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2891 SMTP server is used when it is specified.
2893 (modest_ui_actions_on_send_receive):
2894 Check that a connection is open before proceeding.
2895 Receive and then send, instead of vice-versa, as per the specification.
2897 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2899 * src/modest-mail-operation.c:
2900 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2901 though I guess it should be something other than NULL.
2903 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2905 * src/maemo/easysetup/modest-easysetup-wizard.c:
2906 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2907 combo twice, to avoid an g_warning and to make it visible again.
2908 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2909 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2910 (already intended) dereference when detaching, because we then recreate the menu.
2911 But I am not sure why the warning was happening, and it is possible that this is a memory
2914 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2916 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2917 and uri_parse_mailto() utility functions.
2918 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2920 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2922 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2924 * src/dbus_api/modest-dbus-api.h:
2925 * src/dbus_api/modest-dbus-callbacks.c:
2926 Use an idle callback to execute the modest code in the application's own thread.
2927 Remove the helloworld example method.
2928 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2929 parsed, and the open-message method is not implemented because this is not yet implemented in
2931 * libmodest-dbus-client/libmodest-dbus-client.c:
2932 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2933 (libmodest_dbus_client_open_message):
2934 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2936 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2937 body without crashing.
2939 * tests/dbus_api/Makefile.am:
2940 * tests/dbus_api/test_mail_to.c:
2941 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2943 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2945 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2946 Added file to fix the build. Sorry.
2948 * src/dbus_api/Makefile.am:
2949 * src/dbus_api/modest-dbus-api.h:
2950 * src/dbus_api/modest-dbus-callbacks.h:
2951 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2952 (modest_dbus_req_handler):
2953 Put constants in a separate header so it can be reused by the
2954 client library, without duplication
2956 * libmodest-dbus-client/Makefile.am:
2957 * libmodest-dbus-client/libmodest-dbus-client.c:
2958 (libmodest_dbus_client_call_helloworld),
2959 (libmodfest_dbus_client_send_mail),
2960 (libmodfest_dbus_client_mailto),
2961 (libmodfest_dbus_client_open_message):
2962 * libmodest-dbus-client/libmodest-dbus-client.h:
2963 (Partly) Implement a send_mail D-Bus method.
2965 * tests/dbus_api/Makefile.am:
2966 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2967 the send_email D-Bus method.
2969 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2973 * libmodest-dbus-client/Makefile.am:
2974 * libmodest-dbus-client/libmodest-dbus-client.c:
2975 * libmodest-dbus-client/libmodest-dbus-client.h:
2976 * tests/dbus_api/Makefile.am:
2977 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2978 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2980 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/easysetup/modest-easysetup-wizard.c:
2983 (create_page_account_details):
2984 * src/maemo/modest-account-settings-dialog.c:
2985 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2986 widgets, because this might not be the default in future versions of the Maemo GTK+.
2987 However, I can not not get capitalization to work even in a simple test case.
2989 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2991 * src/maemo/easysetup/modest-easysetup-wizard.c:
2992 (create_page_custom_incoming), (create_page_custom_outgoing):
2993 * src/maemo/modest-account-settings-dialog.c:
2994 (create_page_account_details), (create_page_incoming),
2995 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2996 instead of using gtk_check_button_with_label(), so they are aligned like the other
2997 widgets, as per the UI spec.
2999 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3001 * src/maemo/easysetup/modest-easysetup-wizard.c:
3002 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3003 * src/widgets/modest-validating-entry.c:
3004 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3005 Modest prefix instead of an EasySetup prefix.
3007 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3009 * src/widgets/modest-validating-entry.h:
3010 * src/widgets/modest-validating-entry.c: (on_insert_text),
3011 Added easysetup_validating_entry_set_max_func(), used to set a callback
3012 to call when the max number of characters is reached. GtkEntry has a max-length
3013 already but is silent about it.
3015 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3016 (create_page_account_details), (create_page_user_details),
3018 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3019 (create_page_account_details), (create_page_user_details),
3020 (create_page_outgoing):
3021 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3022 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3023 the UI spec, when the user tries to enter more than the max number of characters.
3025 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3027 * src/maemo/easysetup/modest-easysetup-wizard.c:
3028 (create_page_user_details), (create_page_custom_incoming),
3029 (create_page_custom_outgoing):
3030 * src/maemo/modest-account-settings-dialog.c:
3031 (create_page_user_details), (create_page_incoming),
3032 (create_page_outgoing):
3033 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3034 (modest_connection_specific_smtp_edit_window_init):
3035 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3036 not appropriate. Bad Maemo-specific defaults!.
3038 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3040 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3041 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3042 (modest_signature_editor_dialog_set_settings):
3043 Disable the label and textview when the checkbox is disabled, and use the
3044 specified (UI spec) default signature text.
3046 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3048 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3049 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3051 * src/modest-defs.h:
3052 * src/modest-account-mgr-helpers.h:
3053 * src/modest-account-mgr-helpers.c:
3054 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3056 * src/maemo/Makefile.am:
3057 * src/maemo/modest-signature-editor-dialog.c:
3058 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3061 * src/maemo/modest-account-settings-dialog.h:
3062 * src/maemo/modest-account-settings-dialog.c:
3063 (modest_account_settings_dialog_finalize), (on_button_signature),
3064 (save_configuration): Use the new dialog when the Edit button is pressed, and
3065 save the changes if necessary, as per the UI spec.
3067 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3069 * src/maemo/Makefile.am:
3070 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3071 based on maemo-develoers email from Dirk.
3073 * src/maemo/easysetup/modest-easysetup-wizard.c:
3074 (create_page_welcome), (create_page_account_details),
3075 (create_page_user_details), (create_page_complete_easysetup),
3076 (create_page_custom_incoming), (create_page_custom_outgoing),
3077 (create_page_complete_custom),
3078 (modest_easysetup_wizard_dialog_init):
3079 * src/maemo/modest-account-settings-dialog.c:
3080 (create_page_account_details), (create_page_user_details),
3081 (create_page_incoming), (create_page_outgoing),
3082 (modest_account_settings_dialog_init):
3083 * src/maemo/modest-connection-specific-smtp-window.c:
3084 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3086 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3088 * src/maemo/easysetup/modest-easysetup-wizard.c:
3089 (create_page_account_details), (create_page_custom_outgoing),
3090 (create_page_complete_custom):
3091 * src/maemo/modest-account-settings-dialog.c:
3092 (create_page_user_details), (create_page_incoming),
3093 (create_page_outgoing):
3094 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3095 (modest_connection_specific_smtp_edit_window_init):
3096 Use the correct (UI spec) port min/max, and use horizontal separators,
3099 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3101 * src/maemo/easysetup/modest-easysetup-wizard.c:
3102 (set_default_custom_servernames):
3103 * src/maemo/modest-account-settings-dialog.c:
3104 (create_page_incoming), (on_combo_outgoing_security_changed),
3105 (on_combo_incoming_security_changed), (create_page_outgoing),
3106 (modest_account_settings_dialog_set_account_name),
3107 (save_configuration):
3108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3109 (on_combo_security_changed),
3110 (modest_connection_specific_smtp_edit_window_init),
3111 (modest_connection_specific_smtp_edit_window_set_connection),
3112 (modest_connection_specific_smtp_edit_window_get_settings):
3113 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3116 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3119 * src/maemo/easysetup/modest-easysetup-wizard.c:
3120 (create_page_custom_outgoing), (create_page_complete_custom):
3121 * src/maemo/modest-account-settings-dialog.c:
3122 (create_page_user_details), (create_page_outgoing):
3123 * src/maemo/modest-account-view-window.c: (button_box_new):
3124 Use changed logical IDs as per the most recent UI spec:
3125 mcen_bd_emailsetup_edit -> mcen_bd_edit
3126 mcen_bd_emailsetup_delete -> mcen_bd_delete
3127 mcen_bd_emailsetup_close -> mcen_bd_close
3129 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3133 * src/dbus_api/Makefile.am:
3134 * src/dbus_api/modest-dbus-callbacks.c:
3135 * src/dbus_api/modest-dbus-callbacks.h:
3136 * src/maemo/modest-platform.c: (modest_platform_init):
3137 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3139 * tests/Makefile.am:
3140 * tests/dbus_api/Makefile.am:
3141 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3143 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3145 * src/maemo/modest-account-settings-dialog.c:
3146 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3147 Removed unnecessary includes.
3149 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3151 * src/maemo/easysetup/modest-easysetup-wizard.c:
3152 * src/maemo/modest-account-settings-dialog.c:
3153 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3154 * src/widgets/Makefile.am:
3155 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3156 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3157 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3158 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3159 * src/widgets/modest-secureauth-combo-box.c:
3160 * src/widgets/modest-secureauth-combo-box.h:
3161 * src/widgets/modest-serversecurity-combo-box.c:
3162 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3163 made the GObject names more consistent with the rest of the Modest code.
3165 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3167 * src/maemo/easysetup/Makefile.am:
3168 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3169 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3170 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3171 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3172 * src/maemo/easysetup/modest-easysetup-wizard.c:
3173 * src/maemo/easysetup/modest-validating-entry.c:
3174 * src/maemo/easysetup/modest-validating-entry.h:
3175 * src/maemo/modest-account-settings-dialog.c:
3176 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3177 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3178 widgets/ because they are used outside of easysetup too. After checking in,
3179 svn will allow me to rename them too.
3181 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3183 * src/gnome/modest-msg-edit-window.c:
3184 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3185 linker error, to fix the build on the GNOME platform.
3186 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3187 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3188 ifdefed out to avoid a warning.
3190 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3192 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3193 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3194 some alternative for GTK+ 2.6.
3196 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3198 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3200 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3201 specified for EmailAccountsDialog in UI spec.
3203 * src/maemo/easysetup/modest-easysetup-wizard.c:
3204 * src/maemo/easysetup/modest-easysetup-wizard.h:
3205 * src/maemo/modest-account-settings-dialog.c:
3206 * src/maemo/modest-account-settings-dialog.h:
3207 Reuse a member window widget for the connection-specific SMTP server accounts,
3208 so we can tell it to create/save the accounts only if we actually save changes.
3210 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3211 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3212 (modest_connection_specific_smtp_edit_window_get_settings):
3213 Return a struct instance for temporarily remembering the entered data.
3215 * src/maemo/modest-connection-specific-smtp-window.h:
3216 * src/maemo/modest-connection-specific-smtp-window.c:
3217 (modest_connection_specific_smtp_window_finalize),
3218 (modest_connection_specific_smtp_window_fill_with_connections),
3220 (modest_connection_specific_smtp_window_save_server_accounts),
3221 (update_model_server_names): Do not actually save data until asked,
3222 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3224 (on_selection_changed),
3225 (modest_connection_specific_smtp_window_init): Disable the edit
3226 button when nothing is selected.
3228 * src/modest-account-mgr-helpers.c:
3229 * src/modest-account-mgr-helpers.h:
3230 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3233 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3235 * src/modest-account-mgr-helpers.h:
3236 * src/modest-account-mgr-helpers.c:
3237 (modest_account_mgr_get_unused_account_name),
3238 (modest_account_mgr_get_unused_account_display_name): Added these
3239 utility functions, to avoid code duplication.
3241 * src/maemo/easysetup/modest-easysetup-wizard.c:
3242 (create_page_account_details), (create_account):
3243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3244 (on_combo_security_changed),
3245 (modest_connection_specific_smtp_edit_window_init),
3246 (modest_connection_specific_smtp_edit_window_save_settings):
3247 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3248 * src/maemo/modest-connection-specific-smtp-window.c:
3249 (modest_connection_specific_smtp_window_finalize),
3250 (modest_connection_specific_smtp_window_fill_with_connections),
3251 (on_button_edit), (modest_connection_specific_smtp_window_init):
3252 * src/maemo/modest-connection-specific-smtp-window.h:
3253 Implementing saving of connection-specific server accounts.
3255 But I need to refactor this so we can save the data for each
3256 possible connection-specific account and only actually create the server accounts
3257 when the easysetup finished, or the OK button is pressed on the account settings
3260 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3262 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3263 (on_combo_security_changed):
3264 (modest_connection_specific_smtp_edit_window_init):
3265 Auto-fill the port number as in the account settings.
3267 (modest_connection_specific_smtp_edit_window_set_connection):
3268 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3269 * src/maemo/modest-connection-specific-smtp-window.c:
3270 (fill_with_connections), (on_button_edit),
3271 (modest_connection_specific_smtp_window_init):
3272 Turn the edit window into a dialog to simplify the code, and
3273 set a WM hint as in a GtkDialog, because only a popup can be on top of
3274 another window in Maemo, and popups usually have no WM decoration.
3276 * src/modest-defs.h:
3277 * src/modest-account-mgr-helpers.c:
3278 (modest_account_mgr_set_connection_specific_smtp),
3279 (modest_account_mgr_remove_connection_specific_smtp),
3280 (modest_account_mgr_get_connection_specific_smtp):
3281 * src/modest-account-mgr-helpers.h: Some functions to write the
3282 connection-specific SMTP server information. Not yet used.
3285 * src/widgets/modest-folder-view.c: (text_cell_data):
3286 Fix a warning about an uninitialized variable.
3287 (on_configuration_key_changed): Put an #ifdef around the use
3288 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3290 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3292 * src/maemo/modest-account-settings-dialog.h:
3293 * src/maemo/modest-account-settings-dialog.c:
3294 Added connect_for_modified() utility function to mark the new modified boolean.
3296 (create_page_account_details), (create_page_user_details),
3297 (create_page_incoming), (create_page_outgoing), (on_response),
3298 (modest_account_settings_dialog_init),
3299 (modest_account_settings_dialog_set_account_name):
3300 Only warn about unsaved changes when there are actually unsaved changes.
3302 * src/modest-account-mgr-helpers.c:
3303 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3304 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3305 to get the data from there in future.
3307 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3309 * src/modest-defs.h:
3311 * src/modest-account-mgr-helpers.h:
3312 * src/modest-account-mgr-helpers.c:
3313 Store the security account setting in a single conf key instead of using
3314 the options list, so that the list is left for just the to-be-removed camel hack,
3315 and because gconf_client_set_list() is failing for some reason.
3317 * src/modest-account-mgr.c:
3318 (modest_account_mgr_add_server_account):
3319 * src/maemo/modest-account-settings-dialog.c:
3320 (modest_account_settings_dialog_set_account_name),
3321 (save_configuration): Use the renamed functions.
3324 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3326 * src/widgets/Makefile.am:
3327 * src/widgets/modest-limit-retrieve-combo-box.c:
3328 * src/widgets/modest-limit-retrieve-combo-box.h:
3329 * src/widgets/modest-retrieve-combo-box.c:
3330 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3331 the account settings dialog.
3333 * src/modest-defs.h:
3334 * src/modest-account-mgr-helpers.h:
3335 * src/modest-account-mgr-helpers.c:
3336 (modest_server_account_get_option_secure_auth),
3337 (modest_server_account_set_option_secure_auth):
3338 * src/modest-account-mgr.c:
3339 (modest_account_mgr_add_server_account):
3340 Use the existing AUTH_MECH conf key for the secure-auth setting,
3341 instead of putting it in the list options, because this was actually used already.
3343 * src/maemo/modest-account-settings-dialog.c:
3344 (create_page_account_details),
3345 (modest_account_settings_dialog_set_account_name),
3346 (save_configuration):
3347 * src/maemo/modest-account-settings-dialog.h:
3348 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3349 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3351 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3353 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3354 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3355 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3357 * src/modest-defs.h:
3358 * src/maemo/modest-account-settings-dialog.c:
3359 (create_page_incoming), (on_combo_outgoing_security_changed),
3360 (on_combo_incoming_security_changed), (create_page_outgoing),
3361 (modest_account_settings_dialog_set_account_name),
3362 (save_configuration): Load/Save the port number, and change it when the
3363 security combo changes, to suitable defaults.
3365 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3367 * src/modest-account-mgr.c:
3368 (modest_account_mgr_add_server_account): Set the security and secure-auth
3369 options, and add a comment saying that the other camel-specific options should be
3372 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3374 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3376 * src/modest-tny-account-store.c: (account_list_free),
3377 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3378 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3381 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3383 * src/modest-protocol-info.c:
3384 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3385 is required by our UI spec. Maybe something in our implementation will use this eventually.
3386 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3387 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3388 instead of the previous 0 placeholder.
3390 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3391 secure-auth settings.
3392 * src/modest-account-mgr-helpers.h:
3393 * src/modest-account-mgr-helpers.c:
3394 (modest_server_account_data_get_option_secure_auth),
3395 (modest_server_account_set_option_secure_auth),
3396 (modest_server_account_data_get_option_security),
3397 (modest_server_account_set_option_security): Added this API for getting and setting the security
3398 and secure-auth settings.
3400 * src/maemo/modest-account-settings-dialog.h:
3401 * src/maemo/modest-account-settings-dialog.c:
3402 (modest_account_settings_dialog_finalize), (check_data),
3403 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3404 about changing titles.
3405 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3406 (save_configuration): Save the security and secure-auth settings.
3408 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3409 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3411 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3413 * src/modest-defs.h:
3414 * src/modest-account-mgr.c:
3415 (modest_account_mgr_add_server_account):
3416 Added and used defines for the options key and value pair strings,
3417 that are used so far, though they do not seem to correspond to anything in our
3418 UI specs or ModestProtocol enum.
3420 * src/modest-account-mgr-helpers.h:
3421 * src/modest-account-mgr-helpers.c:
3422 (compare_option_strings_for_name),
3423 (modest_server_account_data_get_option_value),
3424 (modest_server_account_data_get_option_bool),
3425 (modest_account_mgr_get_server_account_option):
3426 Added helper functions for parsing the options GSList.
3428 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3430 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3431 display name is based on the supplied account name.
3432 * src/modest-account-mgr.c:
3433 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3434 with an inefficient, but good-enough, implementation.
3436 * src/maemo/easysetup/modest-easysetup-wizard.c:
3437 (create_page_account_details), (on_before_next), (create_account):
3438 Check for existing display names rather than (non-user-visible) account names, and just
3439 create and set a unique account name at the end.
3441 * src/maemo/modest-account-settings-dialog.c:
3442 (modest_account_settings_dialog_init),
3443 (modest_account_settings_dialog_set_account_name),
3444 (create_page_incoming): Show the display name, instead of the account name.
3445 (on_response): Do some (not all) extra checks, as in the UI spec.
3446 (save_configuration): Save the display name if it was changed.
3448 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3450 * po/en_GB.po: Added needed logical ID and translation.
3451 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3452 (init_view): Made the is-default column clicking work.
3454 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3457 * src/maemo/easysetup/Makefile.am:
3458 * src/maemo/easysetup/modest-easysetup-wizard.c:
3459 (modest_easysetup_wizard_dialog_init):
3460 * src/maemo/easysetup/provider-data-test.keyfile:
3461 * src/maemo/easysetup/provider-data.keyfile:
3462 Moved the provider data file to the new modest-providers-data package and used it from there.
3464 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3466 * src/modest-local-folder-info.c:
3467 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3468 N_() was already used on the static strings, but this just marks it for translation without
3469 using the translation.
3471 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3473 * src/maemo/modest-account-settings-dialog.c:
3474 (create_page_incoming),
3475 (modest_account_settings_dialog_set_account_name):
3476 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3477 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3478 I will do this if nobody else gets there first.
3480 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3482 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3483 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3484 save the security stuff.
3486 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3488 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3489 Set the email address and user fullname, which I now see must be
3492 * src/maemo/modest-account-settings-dialog.h:
3493 * src/maemo/modest-account-settings-dialog.c:
3495 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3496 leave-on-server and authentication.
3497 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3500 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3503 * src/maemo/modest-account-settings-dialog.c:
3504 * src/maemo/modest-account-settings-dialog.h:
3505 Most (but not all) of the widgets are now present as specified by the UI spec.
3506 No changes are yet saved, and some details are not properly shown yet.
3508 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3510 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3512 * src/maemo/Makefile.am:
3513 * src/maemo/modest-account-settings-dialog.c:
3514 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3515 an existing account. Doesn't do much yet.
3517 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3518 Open the accounts settings dialog when Edit is clicked.
3520 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3522 * src/maemo/easysetup/Makefile.am:
3523 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3525 * src/maemo/easysetup/modest-easysetup-wizard.c:
3526 (modest_easysetup_wizard_dialog_init):
3527 Try to get the source directory from the build system,
3528 instead of hard-coding "./" into the source code, when opening our local
3529 copies of the configuration files.
3530 But this still fails when opening the wizard from the Accounts window,
3531 maybe because the working directory seems to change at runtime.
3532 So the wizard will fail the second time unless you copy the files into their
3533 proper locations - see the stdout warnings for the paths.
3535 (create_page_account_details),(on_before_next):
3536 Check for existing non-server accounts instead of server accounts,
3537 so the default account name is useful again, and to prevent trying to
3540 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3541 Show the wizard when New is clicked.
3543 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3544 (init_view): Show the column headers, and show the columns that are
3545 specified in the UI specs. However, something in Maemo's GTK+ prevents
3546 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3547 change the default account. This is despite unsetting the special properties.
3549 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3551 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3552 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3553 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3554 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3555 to make that clearer.
3556 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3558 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3560 * src/maemo/modest-account-view-window.c:
3561 (modest_account_view_window_init),
3562 (modest_account_view_window_new):
3563 Use the same buttons as specified in the
3564 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3565 the existing widgets, which never had a chance of working.
3566 Put the ModestAccountView treeview in a scrolled window.
3567 Do not repeat the initialization in both _init() and _new().
3569 * src/widgets/modest-account-view.c: (update_account_view):
3570 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3571 this widget and window shows no accounts.
3573 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3575 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3577 * src/maemo/easysetup/modest-easysetup-wizard.c:
3578 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3579 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3580 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3583 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3584 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3585 accounts exist yet, as in the UI spec.
3587 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3589 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3591 * src/maemo/Makefile.am:
3592 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3593 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3594 New window for editing connection-specific smtp details.
3595 Not fully implemented.
3597 * src/maemo/modest-connection-specific-smtp-window.c:
3598 (modest_connection_specific_smtp_window_finalize) :
3599 unref the tree model.
3600 (on_button_edit): Show the edit window.
3602 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3604 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3607 * src/maemo/Makefile.am:
3608 * src/maemo/modest-connection-specific-smtp-window.c:
3609 * src/maemo/modest-connection-specific-smtp-window.h:
3610 New window for showing the list of connections, for connection-specific
3611 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3612 * src/maemo/easysetup/modest-easysetup-wizard.c:
3613 (create_page_custom_outgoing): Show the new window when the button is clicked.
3615 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3617 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3618 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3619 * src/maemo/modest-msg-edit-window.c:
3620 (modest_msg_edit_window_insert_image):
3621 * src/modest-conf.c: (modest_conf_key_escape):
3622 * src/modest-mail-operation.c:
3623 (modest_mail_operation_send_new_mail):
3624 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3625 (modest_ui_actions_on_new_account):
3626 * src/widgets/modest-attachment-view.c: (update_filename_request):
3627 * src/widgets/modest-mail-header-view.c:
3628 Corrected warnings that were breaking the build, by commenting out unused variables,
3629 and a function, and by including a header.
3631 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3633 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3634 so we can #ifdef around platform-specific code when necessary.
3635 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3636 to allow this to build for the GNOME platform too.
3638 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3640 * src/maemo/easysetup/modest-easysetup-wizard.c:
3641 Added util_increment_name() and used it in create_page_account_details()
3642 to make sure that the default account name is always a new name.
3644 (modest_easysetup_wizard_dialog_init),
3645 (set_default_custom_servernames): Some minor memory management fixes.
3647 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3651 * src/modest-runtime.c: (init_i18n): Restored the translation
3652 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3653 are defined in config.h, and the translations are installed.
3655 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3656 is defined for translation.
3658 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3660 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3662 * src/maemo/easysetup/modest-easysetup-wizard.c:
3663 (modest_easysetup_wizard_dialog_init):
3664 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3665 Use realistic paths (though they should use $prefix generically) to the
3666 mcc_mapping and provider-data.keyfile files which might work when they
3667 are installed by the future version of the operator-wizard package,
3668 and then fallback to paths in our source code, with an explanatory
3671 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3675 * src/maemo/Makefile.am:
3676 * src/maemo/easysetup/: Added files from the previously-exernal
3677 osso-modest-easysetup.
3678 * src/maemo/modest-main-window-ui.h:
3679 * src/modest-ui-actions.c:
3680 * src/modest-ui-actions.h:
3681 Added modest_ui_actions_on_new_account() as a signal handler for the
3682 New Account menu item. It shows the easysetup wizard.
3683 * po/en_GB.po: Added additional needed logical IDs and translations.