1 2007-07-12 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
4 Pass the modest account name, not the TnyAccount display name to
5 modest_msg_view_window_new() so that the reply feature works,
6 fixing projects.maemo.org bug NB#62892.
8 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
9 (modest_msg_view_window_new_with_header_model):
10 * src/maemo/modest-msg-view-window.c:
11 (modest_msg_view_window_new_with_header_model),
12 (modest_msg_view_window_new):
13 * src/modest-ui-actions.c: (reply_forward):
14 * src/widgets/modest-msg-view-window.h:
15 * src/widgets/modest-window.c: (modest_window_set_active_account):
16 Rename an account parameter to modest_account_name to make this clearer.
18 2007-07-11 Murray Cumming <murrayc@murrayc.com>
20 * src/modest-ui-actions.h:
21 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
22 modest_do_message_delete().
23 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
24 Call modest_do_message_delete(), hoping that this would cause messages
25 to be really deleted from search instead of just marked with strike through.
26 Does not seem to help.
28 2007-07-11 Armin Burgmeier <armin@openismus.com>
30 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
31 priv->reselect to FALSE prior to calling
32 modest_folder_view_select_first_inbox_or_local() to prevent endless
33 recursion and thus a crash on startup.
35 2007-07-11 Armin Burgmeier <armin@openismus.com>
37 * src/maemo/modest-account-settings-dialog.h: Include
38 <gtk/gtknotebook.h> to fix the build (at least for me).
40 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
41 Use "New FolderN" as default suggested name if "New folder" already
42 exists, with N being the first free number, though never exceed "New
43 folder99" in which case we just fall back to "New Folder" even though
44 it already exists. This fixes projects.maemo.org bug NB#58663.
46 2007-07-11 Murray Cumming <murrayc@murrayc.com>
48 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
49 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
50 projects.maemo.org bug NB#62778.
52 2007-07-11 Murray Cumming <murrayc@murrayc.com>
54 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
55 Ignore the wrong (for now) secure-smtp setting in the presets -
56 just default to requiring secure authentication for SMTP, because
59 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
61 * src/widgets/modest-folder-view.c: (filter_row)
62 Do not show drafts folder (see UI specs)
64 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
66 * src/modest-ui-actions.c:
67 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
68 place and also not necessary.
70 * src/widgets/modest-folder-view.c: (filter_row)
71 Guess folder type and hide Sent & Outbox if necessary.
72 Fixed project.maemo.org NB#57328
74 2007-07-11 Murray Cumming <murrayc@murrayc.com>
76 * src/modest-ui-actions.h:
77 * src/modest-ui-actions.c:
78 (modest_ui_actions_on_delete_message):
79 Move some code into a new
80 modest_ui_actions_refresh_message_window_after_delete()
81 function so we can use it from elsewhere.
83 * src/dbus_api/modest-dbus-callbacks.c:
84 (on_idle_delete_message), (on_delete_message): Used an idle
85 handler, as we do for the other D-Bus method handlers.
86 Call modest_ui_actions_refresh_message_window_after_delete()
87 if the deleted message was open in a window. This fixed
88 projects.maemo.org bug NB#62862.
90 2007-07-11 Murray Cumming <murrayc@murrayc.com>
92 * src/modest-main.c: (main): Only show the UI at the start if
93 the showui command line option was given. For instance,
94 run-standalone src/modest showui
95 Otherwise, we wait for the top_application D-Bus method to
96 be sent by hildon-desktop when the application is selected
98 This allows us to run without a UI when osso-global-search
99 uses our D-Bus methods.
101 2007-07-11 Murray Cumming <murrayc@murrayc.com>
103 * src/dbus_api/modest-dbus-api.h: Added a define for a
104 top-application D-Bus method.
105 * src/dbus_api/modest-dbus-callbacks.c:
106 (on_top_application),
107 (modest_dbus_req_handler): Handle the top-application D-Bus
108 method, which might be an undocumented D-Bus signal sent by
109 hildon-desktop when it starts the application from the menu.
110 But I am not sure and I need to test it on the device, because
111 my scratchbox does not have the application in the menu now.
112 This method shows the main window, so that it can be invisible
113 when started, for instance, just for email searching from
116 * src/maemo/modest-main-window.c: (restore_settings),
117 (modest_main_window_new): Do not show the window immediately
118 upon creation. We show it later.
119 * src/modest-widget-memory.c: (save_settings_paned):
120 Try (unsuccessfully) to avoid saving the paned position when
121 it is not even visible.
122 (restore_settings_paned): Do not allow a silly paned position.
123 This seems necessary when not showing the window at first.
125 * tests/dbus_api/Makefile.am:
126 * tests/dbus_api/test_top_application.c: (main): Test for the
129 2007-07-10 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-ui-dimming-rules.c:
132 (modest_ui_dimming_rules_on_new_msg),
133 (modest_ui_dimming_rules_on_reply_msg),
134 (modest_ui_dimming_rules_on_delete_msg),
135 (modest_ui_dimming_rules_on_details),
136 (modest_ui_dimming_rules_on_view_window_move_to),
137 (modest_ui_dimming_rules_on_view_previous),
138 (modest_ui_dimming_rules_on_view_next),
139 (_invalid_folder_for_purge): Added checks before
140 casting the window. This looks like an actual
141 logic error in _invalid_folder_for_purge(), because it
142 tries to use a ModestMainWindow as a message window.
144 2007-07-10 Murray Cumming <murrayc@murrayc.com>
146 * src/maemo/modest-account-settings-dialog.c:
147 (show_error): Use the same implementation as in
148 modest-easysetup-wizard.c:
149 (on_entry_invalid_character): The logical ID contains a %s.
150 Guessed what it should be.
151 (on_entry_max), (check_data), (on_response): Adapt to
152 changed show_error().
153 (create_page_account_details): Really call
154 modest_validating_entry_set_func() on the correct widgets.
155 * src/maemo/easysetup/modest-easysetup-wizard.c:
156 (on_entry_invalid_character): Fix the logical ID here too.
157 (create_page_account_details),
158 (create_page_user_details):
160 modest_validating_entry_set_func() on the correct widgets.
162 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
163 Do not try to use the account if it is NULL.
165 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
167 * src/modest-ui-actions.c: (create_move_to_dialog),
168 (modest_ui_actions_on_main_window_move_to),
169 (modest_ui_actions_on_msg_view_window_move_to):
170 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
171 (filter_row), (modest_folder_view_show_non_move_folders):
172 * src/widgets/modest-folder-view.h:
174 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
175 the Sent folder yet as it does not report the correct folder type.
177 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
179 * src/maemo/modest-msg-edit-window.c: (init_window):
182 2007-07-10 Murray Cumming <murrayc@murrayc.com>
184 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
185 Take a parent widget instead of a parent window, and
186 implement this with hildon_banner_show_information() instead.
187 Non-Maemo builds can just ifdef that there.
188 This fixed projects.maemo.org bug NB#62766.
190 (on_entry_invalid_character): Use show_error() again instead
191 of using hildon directly, and use the _CS() macro to use the correct
193 (create_account), (check_for_supported_auth_methods), (on_entry_max):
194 Pass a widget instead od a window to show_error().
196 2007-07-10 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
199 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
200 This allows us to show the server name in the error message, fixing
201 projects.maemo.org bug NB#62904.
202 Also, use the appropriate logical ID message for the account protocol.
204 2007-07-10 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-tny-account-store.c: (on_idle_wrong_password):
207 A compilation fix, though the build wasn't broken for me.
209 2007-07-09 Murray Cumming <murrayc@murrayc.com>
211 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
212 Do not try to unref a NULL folder store, to avoid a runtime warning.
213 This seems to happen sometimes when changing accounts settings.
215 2007-07-09 Murray Cumming <murrayc@murrayc.com>
217 * src/modest-tny-account-store.c:
218 (modest_tny_account_store_instance_init),
219 (modest_tny_account_store_finalize),
220 (on_account_settings_hide), (on_idle_wrong_password):
221 Use a GHashTable to ensure that we only show one account settings
222 dialog per modest account. This avoids us having a dialog open for
223 both the store and transport accounts, or due to repeated get_password()
224 calls that shouldn't happen anyway.
226 2007-07-09 Murray Cumming <murrayc@murrayc.com>
228 * src/maemo/modest-maemo-utils.c: (on_hide),
229 (modest_maemo_show_dialog_and_forget): Handle the response, because
230 the window is not even hidden by default.
232 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
233 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
234 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
235 which seems to prevent some modality problems.
237 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
238 Ignore user cancellation errors.
240 * src/modest-account-mgr-helpers.h:
241 * src/modest-account-mgr-helpers.c:
242 Added modest_server_account_get_password() and
243 modest_server_account_get_has_password() to avoid direct use of
246 * src/maemo/modest-account-settings-dialog.h:
247 * src/maemo/modest-account-settings-dialog.c:
248 (modest_account_settings_dialog_init): Store the notebook so we can
250 Added modest_account_settings_dialog_switch_to_user_info().
252 * src/modest-tny-account-store.c:
253 (get_password): When the password in the account settings is wrong (we think),
254 show the relevant page of the account settings dialog, in the mainloop.
255 However, we currently get many of these at once because cancel does not
257 (forget_password): Do not forget the password
258 from the account settings, because this causes side-effects when
259 tinymail seems to call it at strange time, maybe because of how we
260 are cancelling get_password().
261 (modest_tny_account_store_alert): Ignore user cancellations.
263 2007-07-09 Murray Cumming <murrayc@murrayc.com>
265 * src/maemo/modest-maemo-utils.h:
266 * src/maemo/modest-maemo-utils.c:
267 Added modest_maemo_show_information_note_and_forget() for use instead of
268 gtk_dialog_run() when the response is not needed, to avoid an extra
269 mainloop which could cause a hang.
271 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
272 Use the logical IDs for the error message, though they are not
273 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
274 because gtk_dialog_run() caused a hang here (the window did not close).
275 This fixes projects.maemo.org bug NB#62646.
277 2007-07-09 Murray Cumming <murrayc@murrayc.com>
279 * src/modest-account-mgr-helpers.h:
280 * src/modest-account-mgr-helpers.c:
281 Added modest_account_mgr_get_store_protocol().
283 * src/maemo/modest-account-view-window.c:
284 (on_delete_button_clicked): Show different warning text depending on
285 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
286 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
289 2007-07-09 Murray Cumming <murrayc@murrayc.com>
291 * src/maemo/modest-msg-edit-window.c:
292 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
293 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
295 2007-07-07 Armin Burgmeier <armin@openismus.com>
297 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
298 ckdg_ib_maximum_characters_reached from correct package.
300 * src/modest-ui-actions.c: Show an error message when a folder could
301 not be created. Tinymail does not give us specific error codes about
302 what has gone wrong, so we assume that a folder with that name
303 already exists, though there might be other reasons.
305 2007-07-06 Murray Cumming <murrayc@murrayc.com>
307 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
308 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
309 give a more exact error message that can be partly translated.
311 2007-07-05 Murray Cumming <murrayc@murrayc.com>
313 * src/maemo/modest-address-book.c:
314 (select_email_addrs_for_contact): Specify a default window size for the
315 select-email-address dialog, so that it is probably big enough for the
316 title. This should fix projects.maemo.org bug NB#62277.
318 2007-07-05 Murray Cumming <murrayc@murrayc.com>
320 * src/maemo/easysetup/modest-easysetup-wizard.c:
321 (create_page_complete_easysetup): Use
322 gtk_widget_set_size() request to ensure that the text wraps
325 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
327 * src/maemo/easysetup/modest-easysetup-wizard.c:
328 (on_entry_invalid_character), (create_page_account_details),
329 (create_page_user_details):
330 Use new API of ModestValidatingEntry. But for some reason the banner is
331 not shown. I will have to investigate that further.
333 * src/widgets/modest-validating-entry.c: (on_insert_text),
334 (modest_validating_entry_set_func):
335 * src/widgets/modest-validating-entry.h:
336 Added a new callback function to be able to react to prevented
337 characters whitespaces to e.g show a banner.
339 2007-07-05 Armin Burgmeier <armin@openismus.com>
341 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
342 notification of HildonNumberEditor instead of remembering the port
343 number. Thanks to Johannes for pointing this out.
345 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
347 * src/maemo/easysetup/modest-easysetup-wizard.c:
348 Check if there are any user changes before showing a confirmation
349 dialog (projects.maemo.org NB#60946)
351 2007-07-05 Armin Burgmeier <armin@openismus.com>
353 * src/maemo/modest-account-settings-dialog.c: Remember custom port
354 number at the beginning of the dialog and set the modified flag at the
355 end if the port number has changed. This is necessary because
356 HildonNumberEditor does not support notification when the value has
359 2007-07-05 Murray Cumming <murrayc@murrayc.com>
361 * src/modest-ui-actions.c:
362 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
363 a connection before asking anything else. Correct the check for the destination
364 folder so that it succeeds when online.
365 This fixed projects.maemo.org bug NB#61645.
367 2007-07-05 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
370 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
371 to fix projects.maemo.org bug NB#62439.
373 2007-07-05 Murray Cumming <murrayc@murrayc.com>
375 * src/modest-tny-account.c: (on_connection_status_changed):
376 Really do not use tny_device_force_offline() here. See the previous comment.
378 2007-07-04 Murray Cumming <murrayc@murrayc.com>
380 * src/modest-tny-account.c: (on_connection_status_changed):
381 Do not use tny_device_force_offline() when tinymail says that something
382 went wrong with the connection. It seems to report this unnecessarily.
384 2007-07-04 Murray Cumming <murrayc@murrayc.com>
386 * src/maemo/modest-connection-specific-smtp-window.c:
387 (modest_connection_specific_smtp_window_init):
388 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
389 does not seem to have any effect in osso 1.1 (though it works in
390 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
392 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
394 * src/maemo/modest-connection-specific-smtp-window.c:
395 Fix UI specification problems with projects.meamo.org NB#60479
397 2007-07-04 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
400 clue when this has failed, because the error dialog is not always shown
401 (at least in earlier version).
403 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
404 GError message, because the generic error dialog is not helpful.
406 'This message is not currently available (can't let a new connection go online)'
407 when trying to open an IMAP message.
409 (_modest_ui_actions_open): Offer a connection when some messages would
410 have to be downloaded and we are offline.
412 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
414 * src/widgets/modest-folder-view.c:
415 Don't check for MERGE type anymore as we use the correct type
417 NOTE: For the last two changes you need to update your tinymail copy
418 because of API changes!
420 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
422 * src/modest-tny-local-folders-account.c:
423 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
424 (see projects.maemo.org NB#61580)
426 2007-07-04 Murray Cumming <murrayc@murrayc.com>
428 * src/modest-tny-account.c: (on_connection_status_changed):
429 Commented out the call to modest_platform_connect_and_wait() because this
430 seems to always hang, and I would like to know if this is the only thing
431 that causes a hang when showing the connection dialog.
432 It is not very useful anyway.
434 2007-07-04 Murray Cumming <murrayc@murrayc.com>
436 * src/maemo/modest-msg-view-window.c:
437 (modest_msg_view_window_select_next_message):
439 * src/modest-platform.h:
440 * src/maemo/modest-platform.c:
441 Added modest_platform_connect_and_wait(), which calls
442 tny_maemo_conic_device_connect() always in the main thread, by calling it
443 in an idle handler and waiting for the idle handler to run. It should be
444 in the main thread because it uses GTK+ UI code. It just returns TRUE
445 if the device is already online.
447 There is some nasty code to ensure that subsequent calls to
448 modest_platform_connect_and_wait() just wait for the first one to finish,
449 by checking repeatedly in another idle handler. This is necessary,
450 because other threads (or even the main thread, via another idle handler)
451 can call modest_platform_connect_and_wait() while
452 modest_platform_connect_and_wait() is running.
454 (modest_platform_connect_and_wait_if_network_account),
455 (modest_platform_connect_and_wait_if_network_folderstore):
456 Convenience functions that calls modest_platform_connect_and_wait() if
457 the account or folder might want network access.
459 * src/modest-mail-operation.c:
460 (modest_mail_operation_update_account):
461 * src/modest-ui-actions.c: (download_uncached_messages),
462 (modest_ui_actions_on_rename_folder), (delete_folder),
463 (modest_ui_actions_on_main_window_move_to),
464 (modest_ui_actions_on_msg_view_window_move_to):
465 * src/widgets/modest-folder-view.c:
466 (drag_and_drop_from_folder_view):
467 Offer a connection if we are offline.
469 * src/modest-tny-account.c: (on_connection_status_changed):
470 Document this as only handling errors during network operations in progress,
471 and replace the idle code with a simple call to
472 modest_platform_connect_and_wait(), which does this instead.
474 2007-07-03 Murray Cumming <murrayc@murrayc.com>
476 * src/modest-tny-account.c:
477 (modest_tny_account_get_special_folder): (util_on_idle),
478 Handle the GError so we can see when tny_folder_store_get_folders()
479 fails, as it currently does while something else is connecting.
481 Added util_run_in_main_thread_and_wait()
482 which uses an idlen handler and mainloop to ensure that the function
483 is called in the main thread.
484 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
485 to make sure that we call attempt the connection in the mainloop only,
486 which might solve some hangs.
488 2007-07-03 Murray Cumming <murrayc@murrayc.com>
490 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
491 be found by their display name. This is never useful.
492 * src/modest-tny-account-store.c: (on_account_removed): Find the account
493 by its ID, instead of trying to use its ID as its display name.
495 * src/modest-tny-account-store.h:
496 * src/modest-tny-account.c:
497 (modest_tny_account_get_special_folder): Add a g_warning() when
498 tny_folder_store_get_folders() returns an empty list for the maildir.
500 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
501 Add a g_warning() when this returns NULL, because that it not allowed
504 2007-07-02 Armin Burgmeier <armin@openismus.com>
506 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
507 note when trying to cancel the wizard. This fixes projects.maemo.org
510 2007-07-02 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-tny-account.h:
513 * src/modest-tny-account.c:
514 (modest_tny_account_new_from_server_account),
515 (modest_tny_account_new_from_server_account_name),
516 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
517 because this must now be set before setting the proto. This is usd in
518 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
519 warning in camel_session_get_service() caused by
520 tny_camel_transport_account_prepare().
522 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
525 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
527 * src/maemo/modest-connection-specific-smtp-edit-window.c:
529 (modest_connection_specific_smtp_edit_window_init):
531 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
534 2007-06-29 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-tny-account.c:
537 (modest_tny_account_new_from_server_account):
538 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
539 now uses to request a connection when it needs one, and which it uses
540 to tell us that something is wrong with the connection, so we can force
541 the accounts offline to prevent further problems.
544 * src/modest-init.c: (init_default_settings):
545 * src/modest-mail-operation.c:
546 (modest_mail_operation_update_account):
547 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
548 This should not be necessary anymore. Do not set the conf key that
549 determined this (it was always TRUE and not set anywhere else).
551 * src/modest-ui-actions.h: Remove unused and unimplemented
552 modest_ui_actions_on_online_toggle_toggled().
554 2007-06-29 Murray Cumming <murrayc@murrayc.com
556 * src/maemo/modest-main-window.c: (connect_signals):
557 Don't connect to delete_event twice. Maybe this was harmless.
559 2007-06-29 Murray Cumming <murrayc@murrayc.com
561 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
562 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
563 Debug output to give some more clue when a folder move is not allowed.
565 2007-06-28 Murray Cumming <murrayc@murrayc.com
567 * src/modest-tny-account.c: (on_modest_file_system_info),
568 (modest_tny_account_get_mmc_account_name):
569 Always call the callback, without checking whether the name has changed.
570 * src/widgets/modest-folder-view.c: (strings_are_equal),
571 (on_model_foreach_set_name), (on_get_mmc_account_name),
572 (text_cell_data): Compare the name here, and use the name from
573 the account rather than from the
574 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
575 if the name was changed after the account was added to the model.
576 That's a tinymail bug but not one that I want to fix now.
578 This finally fixes projects.maemo.org bug NB#59301.
580 2007-06-27 Armin Burgmeier <armin@openismus.com>
582 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
585 2007-06-27 Murray Cumming <murrayc@murrayc.com
587 * src/modest-tny-account.h:
588 * src/modest-tny-account.c:
589 Added modest_tny_account_get_mmc_account_name(), to set the memory
590 card name asynchronously for the given account and then notify.
591 (modest_tny_account_new_for_local_folders): Use this new function instead
592 of using hildon_file_system_info_async_new() directly.
594 * src/widgets/modest-folder-view.c: (text_cell_data):
595 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
596 gtk_tree_model_row_changed() when it is available.
598 This should fix projects.maemo.org bug NB#59301.
600 2007-06-27 Murray Cumming <murrayc@murrayc.com
602 * src/modest-mail-operation.c: (update_account_thread),
603 (get_msgs_full_thread): Fix typo failures in the revert
606 2007-06-27 Murray Cumming <murrayc@murrayc.com
608 * src/maemo/modest-maemo-global-settings-dialog.c:
609 (idle_select_default_focus):
610 * src/modest-mail-operation.c: (idle_notify_progress),
611 (idle_notify_progress_once), (set_last_updated_idle),
612 (update_account_thread), (get_msgs_full_thread):
613 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
614 * src/widgets/modest-header-view.c:
615 (idle_notify_headers_count_changed_destroy),
616 (idle_notify_headers_count_changed):
617 Reverted the additions of gdk_threads_enter/leave(), in case this
618 helps with a startup hang on the device.
620 2007-06-26 Armin Burgmeier <armin@openismus.com>
622 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
623 for supported secure authentication methods from server by
624 gtk_dialog_run(), saving CPU time and a potential race condition.
626 2007-06-26 Armin Burgmeier <armin@openismus.com>
628 * src/maemo/modest-maemo-utils.h:
629 * src/maemo/modest-maemo-utils.c: Added a
630 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
631 only error code to tell the calling code when the user canceled the
634 * src/maemo/modest-account-settings-dialog.h:
635 * src/maemo/modest-account-settings-dialog.c:
636 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
637 message if the retrieval of secure authentication methods was canceled
638 by the user. Perform the check before saving anything to configuration
639 to not end up with half-committed configuration changes, do not show
640 a "Saving to configuration failed" note when authentication methods
641 could not be retrieved.
643 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
646 2007-06-26 Murray Cumming <murrayc@murrayc.com>
648 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
649 Only return the first level of folders under accounts, because the
650 osso-global-search UI spec doesn't want the rest.
651 This fixed projects.maemo.org bug NB#61811.
653 2007-06-26 Murray Cumming <murrayc@murrayc.com>
655 * src/modest-tny-account-store.c:
656 * src/modest-tny-account-store.h:
657 Added modest_tny_account_is_memory_card_account().
658 * src/maemo/modest-main-window.c: (create_details_widget):
659 Show the same information items for the memory card as we show for the
660 local-folders, to fix projects.maemo.org bug NB#59307.
662 2007-06-26 Murray Cumming <murrayc@murrayc.com>
664 * src/modest-tny-account-store.c: (get_password):
665 Added some checks for NULL to maybe prevent crashes, though I think
666 it was Philip's last commit that actually prevented the crash here
667 when creating a first new account.
668 But the new account is still not usable (no messages are shown)
669 until a restart of the application.
671 2007-06-26 Murray Cumming <murrayc@murrayc.com>
673 * src/maemo/modest-maemo-global-settings-dialog.c:
674 (idle_select_default_focus):
675 * src/modest-mail-operation.c: (idle_notify_progress),
676 (idle_notify_progress_once), (idle_notify_update_account_queue),
677 (set_last_updated_idle), (update_account_thread),
678 (notify_get_msgs_full), (get_msgs_full_destroyer),
679 (get_msgs_full_thread):
680 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
681 * src/widgets/modest-header-view.c:
682 (idle_notify_headers_count_changed_destroy),
683 (idle_notify_headers_count_changed):
684 Use gdk_threads_enter() and gdk_threads_enter_leave() in
685 all idle handlers, because some other thread could be blocking
686 the GDK lock, so that it can do GUI stuff.
688 2007-06-26 Murray Cumming <murrayc@murrayc.com>
690 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
691 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
692 (on_idle_send_receive), (on_idle_open_default_inbox):
693 * src/maemo/modest-msg-edit-window.c:
694 (modest_msg_edit_window_attach_file_noninteractive):
695 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
696 to prevent a hang. I don't quite understand why these are necessary,
697 beause we should already be in the main loop. I guess something outside
698 of the main loop is taking the lock.
700 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
701 we are really using URIs, and use files that are more likely to exist.
703 2007-06-26 Murray Cumming <murrayc@murrayc.com>
705 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
706 necessary because configure.ac now defines different variables.
708 2007-06-26 Murray Cumming <murrayc@murrayc.com>
710 * libmodest-dbus-client/libmodest-dbus-client.c:
711 * libmodest-dbus-client/libmodest-dbus-client.h:
712 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
713 libmodest_dbus_client_compose_mail() is what things actually use.
715 * src/dbus_api/modest-dbus-api.h:
716 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
717 * tests/dbus_api/Makefile.am:
718 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
721 2007-06-26 Murray Cumming <murrayc@murrayc.com>
723 * src/modest-init.c: (modest_init_local_folders):
724 For memory-card (or other non local-folders) maildir accounts,
725 always create an Archive folder, so that there is somewhere to put
726 messages. This should be less confusing, because the user does not need
727 to guess that the need to create a folder.
729 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
731 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
732 Fixed icon size by using (50, 50) which is the same as defined by
735 2007-06-25 Armin Burgmeier <armin@openismus.com>
737 * src/widgets/modest-window-mgr.c:
739 * configure.ac: Correctly recognize hildon-notify presence and fixed
740 the build without it being installed.
742 2007-06-25 Murray Cumming <murrayc@murrayc.com>
744 * libmodest-dbus-client/libmodest-dbus-client.c:
745 (libmodest_dbus_client_search): Fix the build. Sorry.
746 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
747 (reply_forward_cb): Initialize variables to fix the build.
749 * src/modest-tny-account-store.c:
750 (modest_tny_account_store_get_tny_account_by): Fix the account URI
751 comparison (a silly typo) so that email search results can be opened
752 when there are more than one account.
754 2007-06-25 Murray Cumming <murrayc@murrayc.com>
756 * libmodest-dbus-client/libmodest-dbus-client.c:
757 (libmodest_dbus_client_search),
758 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
759 instead of 1 second, because the search gets folders and messages from
760 the server, which can take a long time. When it times out,
761 osso-global-search will report no results.
763 We need to specify whether we should search only cached information
764 (maybe with a user preference), and the osso-email-search-plugin
765 API should really be improved to allow that option, and to allow results
766 to be delivered asynchronously in batches.
768 2007-06-25 Murray Cumming <murrayc@murrayc.com>
770 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
771 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
772 GTK_ICON_SIZE_DIALOG is probably the wrong size.
774 2007-06-25 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
777 that is an empty string. D-Bus seems to give us these instead of NULL.
779 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
781 * src/dbus_api/modest-dbus-callbacks.c:
782 * src/maemo/easysetup/modest-easysetup-wizard.h:
783 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
784 * src/maemo/modest-connection-specific-smtp-edit-window.c:
785 (modest_connection_specific_smtp_edit_window_init):
786 * src/maemo/modest-maemo-global-settings-dialog.c:
788 * src/maemo/modest-maemo-utils.c:
789 (modest_maemo_utils_setup_images_filechooser):
790 * src/maemo/modest-main-window.c: (create_details_widget):
791 * src/maemo/modest-msg-edit-window.c:
792 (modest_msg_edit_window_attach_file_noninteractive),
793 (modest_msg_edit_window_color_button_change),
794 (modest_msg_edit_window_set_zoom):
795 * src/modest-mail-operation.c: (update_account_thread):
796 * src/modest-tny-account-store.c:
797 * src/modest-tny-account.c:
798 * src/widgets/modest-global-settings-dialog.c:
799 * src/widgets/modest-window.h:
803 2007-06-25 Murray Cumming <murrayc@murrayc.com>
805 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
806 * src/modest-search.c: (modest_search_folder),
807 (modest_search_all_accounts): Actually search only in the specified folder,
808 doing a simple match on the folder ID.
809 * src/modest-search.h: Added a folder field to the ModestSearch struct,
810 and added some documentation.
812 2007-06-22 Armin Burgmeier <armin@openismus.com>
814 * src/maemo/modest-maemo-utils.h:
815 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
816 modest_maemo_utils_get_supported_secure_authentication_methods.
818 * src/maemo/easysetup/modest-easysetup-wizard.c:
819 * src/maemo/modest-account-settings-dialog.c: Show correct error if
820 one occured, not just "Server does not support secure authentication".
822 2007-06-22 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-tny-account-store.c: (get_password):
825 Restored the call to tny_account_set_user() because Philip seems to have
826 stopped this from crashing (by not using the freed string). It still does
827 not work, but now we can test it.
829 2007-06-22 Murray Cumming <murrayc@murrayc.com>
831 * src/maemo/modest-msg-edit-window.c: (init_window):
832 Comment out use of an uninitialzed GtkScrolledWindow variable,
833 to fix the build and stop a crash. Yet again.
835 2007-06-22 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-tny-account-store.c: (get_password):
838 Remove the call to tny_account_set_user() because this actually crashes.
839 As mentioned in the last commit, it is known to not work anyway.
841 2007-06-22 Murray Cumming <murrayc@murrayc.com>
843 * src/modest-tny-account-store.c: (get_password):
844 Use tny_account_set_username() to tell tinymail that the username might
845 have changed too. But tinymail ignores this: see projects.maemo.org
847 * src/modest-ui-actions.c:
848 (modest_ui_actions_on_password_requested): Remove the useless attempt to
849 reset the connection when changing the username, and improve the comments.
850 Save the changed username to gconf at least, so it is used when Modest is
853 2007-06-21 Murray Cumming <murrayc@murrayc.com>
855 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
856 Do not use a query, so that we get all folders, including for POP and
857 local-folders. They work as search criteria too.
858 This fixes projects.maemo.org bug NB#57740.
860 2007-06-21 Murray Cumming <murrayc@murrayc.com>
862 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
863 Comment out the use of hildon_notification_set_sound() because it is
864 not declared, to fix the build. Warnings are serious, people.
866 2007-06-21 Armin Burgmeier <armin@openismus.com>
868 * src/maemo/modest-maemo-utils.h:
869 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
870 modest_maemo_utils_get_supported_secure_authentication_methods()
871 to query authentication methods for a specific user. This should fix
872 projects.maemo.org bug NB#61369.
874 * src/maemo/easysetup/modest-easysetup-wizard.c:
875 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
878 2007-06-21 Murray Cumming <murrayc@murrayc.com>
880 * libmodest-dbus-client/libmodest-dbus-client.h:
881 * libmodest-dbus-client/libmodest-dbus-client.c:
882 (modest_dbus_message_iter_get_search_hit),
883 (libmodest_dbus_client_search):
884 Reorganised and commented this.
885 Removed modest_search_hit_free() from the public API because it
888 Added libmodest_dbus_client_get_folders() and
889 modest_folder_result_list_free().
891 * src/dbus_api/modest-dbus-api.h:
892 * src/dbus_api/modest-dbus-callbacks.c:
893 (modest_dbus_req_filter): Commented. Moved most code to
894 on_dbus_method_search() and added on_dbus_method_get_folders().
896 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
897 of the extra D-Bus handler.
899 * tests/dbus_api/Makefile.am:
900 * tests/dbus_api/test_get_folders.c: New test for
901 libmodest_dbus_client_get_folders(). This seems to return an empty list
902 at the moment. That could be the same error that causes the message list
903 to be empty sometimes.
904 This should help with projects.maemo.org bug NB#57740.
906 2007-06-21 Armin Burgmeier <armin@openismus.com>
908 * src/modest-mail-operation.c: Do not call
909 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
910 notify the operation's end after having set the status to CANCELED for
911 the operation queue to listen on. This fixes a deadlock when there
912 were mail operations in the queue during its finalization.
914 * src/modest-singletons.c: Reordered uninitialization of the account
915 manager to happen after the mail operation queue was uninitialized
916 because the mail operation's in the queue might still try to access
917 the account manager (see modest_mail_operation_notify_end()). This
918 fixes a potential crash when terminating the application.
920 2007-06-21 Murray Cumming <murrayc@murrayc.com>
922 * src/modest-search.c:
923 (search_mime_part_and_child_parts): Moved some code here so we
924 can search recursively in child folders.
925 (modest_search_folder): Search in the message as a mime part, instead
926 of just its child mime parts.
927 (read_chunk), (search_mime_part_ogs):
928 Check how many bytes were read, to prevent an endless loop.
929 Searching in message bodies now works. This finishes the fix for
930 projects.maemo.org bug NB#61007.
932 2007-06-20 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
935 Add a g_warning when the item is not a folder.
937 * src/modest-ui-dimming-rules.c:
938 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
939 when selected item is not a folder (for instance, an account), because
940 the UI spec only talks about folders.
941 I am not sure what the UI spec wants, so this might not totally fix
942 projects.maemo.org bug NB#60794.
944 2007-06-20 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
947 (load_from_file): Sort the list. The unsorted list would be more noticeable
948 in non-English locales.
950 * src/maemo/modest-msg-edit-window.c:
951 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
952 warning and fix the build.
954 * src/maemo/modest-progress-bar-widget.c:
955 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
956 avoid a g_warning, and probably to avoid a crash.
958 2007-06-20 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-search.c: (modest_search_folder): Check for a GError
961 when calling tny_folder_get_headers(), to show that this is not the cause
964 2007-06-20 Murray Cumming <murrayc@murrayc.com>
966 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
967 Actually set the body query instead of the subject query.
969 * src/modest-search.c: (search_mime_part_ogs),
970 (search_mime_part_strcmp): Remove extra space from the text/* regex,
971 which would probably cause it to fail if we got this far.
973 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
974 to simplify the code.
975 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
976 be causing search-in-body to fail.
978 2007-06-20 Murray Cumming <murrayc@murrayc.com>
980 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
982 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
983 Better debug message when the folder cannot be found.
984 This should help with fixing projects.maemo.org bug #61287.
985 * src/modest-search.c: (add_hit): Do not leak the furl string.
987 2007-06-20 Murray Cumming <murrayc@murrayc.com>
989 * src/modest-ui-actions.c:
990 (modest_ui_actions_on_folder_selection_changed):
991 Do not special-case TNY_MERGE_FOLDER here, because
992 modest_tny_folder_get_account() already does that. This fixes
993 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
994 shown when the Outbox was selected).
996 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
998 * libmodest-dbus-client/libmodest-dbus-client.c:
999 (_dbus_iter_get_string_or_null): Initialize the string variable in
1000 case this helps with Dirk's crash.
1002 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1004 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1005 though it is not implemented yet (this function is maybe not even used),
1006 to avoid breaking ABI in future.
1007 * libmodest-dbus-client/libmodest-dbus-client.c:
1008 (get_attachments_string): Moved some code into this generic function.
1009 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1010 sends email. It is maybe not used.
1011 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1012 (on_send_mail): Use attachments.
1014 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1015 * src/maemo/modest-msg-edit-window.c:
1016 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1017 a filename before using it, to fix projects.maemo.org bug NB#58233.
1019 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1021 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1022 Initialize the continue_download variable to fix the build, and probably
1023 to fix randome behaviour.
1025 2007-06-18 Armin Burgmeier <armin@openismus.com>
1027 * src/modest-tny-send-queue.h:
1028 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1029 the queue so we can later show it in the UI. Replaced
1030 modest_tny_send_queue_msg_is_being_sent() by
1031 modest_tny_send_queue_get_msg_status().
1033 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1035 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1036 gpointer. This probably was not harmful, but just to be sure.
1038 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1040 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1041 Fix the build, but leave the function broken on Bora, because
1042 hildon_uri_action_get_service() does not exist.
1043 osso_uri_action_get_service() does not exist either, it seems.
1045 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1047 * src/modest-tny-account.c:
1048 (modest_tny_account_new_from_server_account):
1049 Uncommented the url debug output again, because it is useful for
1050 debugging, as I said in the comment.
1052 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1054 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1056 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1057 for Mameo Bora, to fix the build.
1059 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1062 Fixed build with hildon < 0.99
1064 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1065 Check if the selected account is busy instead of checking all accounts
1067 * src/modest-account-mgr-priv.h:
1068 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1069 (modest_account_mgr_init), (compare_account_name),
1070 (modest_account_mgr_set_account_busy),
1071 (modest_account_mgr_account_is_busy):
1072 * src/modest-account-mgr.h:
1073 Added busy information to the account manager. It possible to
1074 set an account to busy or not busy now.
1076 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1077 (modest_mail_operation_update_account),
1078 (modest_mail_operation_notify_end):
1079 Set the account to busy/not busy depending on the operation state.
1081 * src/widgets/modest-account-view.c:
1082 (modest_account_view_finalize), (get_last_updated_string),
1083 (update_account_view), (on_account_busy_changed), (init_view):
1084 Show string "Refreshing..." if the account is currently busy.
1086 All this fixes projects.maemo.org bug NB#59711
1088 2007-06-14 Armin Burgmeier <armin@openismus.com>
1090 * src/widgets/modest-attachments-view.h:
1091 * src/widgets/modest-attachments-view.c: Added
1092 modest_attachments_view_has_attachments() and fixed coordinate
1093 transformation in get_att_view_at_coords(). This fixes attachment
1096 * src/widgets/modest-msg-view.c: Make use of
1097 modest_attachments_view_has_attachments() to decide whether to show
1098 attachments in the header.
1100 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1102 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1103 (on_change), (on_combo_security_changed),
1104 (modest_connection_specific_smtp_edit_window_init),
1105 (modest_connection_specific_smtp_edit_window_set_connection),
1106 (modest_connection_specific_smtp_edit_window_is_dirty):
1107 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1108 * src/maemo/modest-connection-specific-smtp-window.c:
1111 Show an comfirmation dialog for the smpt-edit-window if there are
1112 unsaved changes and the user hits cancel.
1113 (projects.maemo.org bug NB#60479)
1115 2007-06-14 Armin Burgmeier <armin@openismus.com>
1117 * src/maemo/easysetup/modest-easysetup-wizard.c:
1118 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1119 address" info in banner instead of node, and select all the text as
1120 per UI spec. This fixes projects.maemo.org bug NB#60550.
1122 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1124 reviewed by: <delete if not using a buddy>
1126 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1127 * src/modest-ui-actions.c: (folder_refreshed_cb):
1129 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1131 * src/widgets/modest-folder-view.c: (filter_row):
1132 Explictly filter out the per-account outbox accounts. I don't know why
1133 these only sometimes show up, but now they should never show up in the UI.
1134 This should fix projects.maemo.org bug NB#60160.
1136 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1139 when the toolbar does not exist yet.
1140 * src/modest-widget-memory.c: (save_settings_header_view):
1141 Added g_warnings() to help us to discover when we are trying to set
1142 an empty columns list in gconf.
1144 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1146 * src/modest-init.h:
1147 * src/modest-init.c:
1148 Added modest_init_get_default_header_view_column_ids().
1150 * src/modest-widget-memory.c: (restore_settings_header_view):
1151 Use the new function to get defaults, if the gconf key is empty,
1152 instead of not creating any columns. This seems to fix the
1153 empty right-hand pane problems.
1155 * src/widgets/modest-header-view.h: Improved documentation.
1157 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1159 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1160 Revert the use of the display name as the account name, because this
1161 is generally wrong and would break the code that follows.
1163 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1165 * src/maemo/easysetup/modest-easysetup-wizard.c:
1166 (check_for_supported_auth_methods), (on_before_next),
1169 More correct fix for projects.maemo.org bug NB# 58991
1170 Do not longer accept AUTH_PASSWORD as secure method and choose
1171 correct method when creating the account.
1173 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1175 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1176 Fixed projects.maemo.org bug NB# 58991
1178 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1180 * src/modest-init.c: (modest_init_init_core),
1181 (modest_init_local_folders): Fixed compilation errors.
1183 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1185 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1186 Remove unnecessary lib/include, though it is good in principle when needed.
1188 * src/modest-init.c: (modest_init_one_local_folder),
1189 (modest_init_local_folders):
1190 * src/modest-init.h: Initialize the .modest library for memory cards,
1191 instead of just doing nothing for them. This should allow us to create
1192 folders there, fixing projects.maemo.org bug NB#59297.
1194 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1196 * libmodest-dbus-client/libmodest-dbus-client.c:
1197 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1198 (libmodest_dbus_client_compose_mail),
1199 (libmodest_dbus_client_open_message),
1200 (libmodest_dbus_client_send_and_receive),
1201 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1203 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1204 (on_idle_open_message), (modest_dbus_req_handler),
1205 (search_result_to_message), (modest_dbus_req_filter):
1206 * src/modest-search.c: (add_hit), (modest_search_folder),
1207 (modest_search_all_accounts): Improved debug messages.
1209 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1211 * src/modest-tny-account-store.c:
1212 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1215 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1218 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-tny-account-store.c: (get_server_accounts):
1221 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1222 even when there are no accounts, so that the Outbox folder is always
1223 visible. This fixes projects.maemo.org bug NB#60158.
1225 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1227 * src/maemo/modest-main-window.c: (create_details_widget):
1228 Use the mcen_va_never logical ID.
1230 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1232 * src/dbus_api/modest-dbus-api.h:
1233 * src/dbus_api/modest-dbus-callbacks.c:
1234 (on_idle_open_default_inbox), (on_open_default_inbox),
1235 (modest_dbus_req_handler):
1236 Added a new OpenDefaultInbox method.
1238 * libmodest-dbus-client/libmodest-dbus-client.h:
1239 * libmodest-dbus-client/libmodest-dbus-client.c:
1240 Added libmodest_dbus_client_open_default_inbox() to call the new
1241 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1242 though it should maybe be used by a new osso-email-interface function.
1244 * tests/dbus_api/Makefile.am:
1245 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1248 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1250 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1251 NULL, so that the signals get all the keys. This should not actually
1252 change any behaviour because we currently update everything when anything
1255 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1257 * src/widgets/modest-folder-view.c: (text_cell_data),
1258 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1259 (find_inbox_iter): If tinymail tells us that the folder is
1260 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1261 This causes the inbox to be selected at startup, fixing part of
1262 projects.maemo.org bug NB#56305.
1264 * src/modest-ui-dimming-rules.c:
1265 (modest_ui_dimming_rules_on_tools_smtp_servers):
1266 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1267 the SMTP servers menu item.
1268 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1269 that the SMTP Servers menu item is dimmed when there are no accounts,
1270 as a future version of the UI spec will require. This fixes
1271 projects.maemo.org bug NB#56305.
1273 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1275 * src/maemo/modest-maemo-utils.c:
1276 (modest_maemo_utils_get_supported_secure_authentication_methods):
1277 Added label to dialog instead of unreadable title
1279 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1280 (modest_main_window_new):
1281 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1284 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1285 * src/modest-account-mgr.h:
1286 Added method to avoid code duplication
1288 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1289 (modest_ui_actions_on_send_receive):
1290 Use modest_account_mgr_has_accounts
1292 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1294 * src/maemo/easysetup/modest-presets.c:
1295 (modest_presets_get_info_server_security): Do not report secure auth
1297 * src/modest-protocol-info.c: Use the defines for the gconf key names
1298 for secure authentication. This was not working because we were writing
1299 Password and reading password, and the check was case sensitive.
1300 With this, gmail now works for receiving and sending when created via
1303 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1305 * src/maemo/easysetup/modest-presets.c:
1306 (modest_presets_get_info_server_security): Correct the key name for
1307 SecureSmtp, because it seems to be case-sensitive.
1308 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1309 Do not try to get the 0th notebook page if there are 0 pages, to
1310 avoid a g_warning().
1312 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1314 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1315 Prevent use of the new notification feature for now, because it currently
1316 shows one dialog for each new email, which is annoying.
1318 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1321 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1322 when no country was selected, so that we show the global ones.
1323 * src/maemo/easysetup/modest-presets.c:
1324 (modest_presets_get_providers): Return only the global providers, not
1325 all providers when mmc=0 was requested.
1327 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1329 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1330 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1331 provider ID in the combo.
1333 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1334 Do not show the page numbers, because it would be confusing when we add
1335 the 2 extra pages for the custom setup, when the user chooses the "Other"
1336 provider. This fixes projects.maemo.org bug NB#59028
1338 * src/modest-init.c: (modest_init_init_core),
1339 (modest_init_local_folders):
1340 * src/modest-init.h:
1341 * src/modest-tny-account.c:
1342 (modest_tny_account_new_for_local_folders): Do not create default folders
1343 for the memory card. This should fix projects.maemo.org bug NB#59328.
1345 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1347 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1348 Free the changed_conf_keys string items. They are already freed in the
1349 idle handler if that runs first.
1351 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1353 * src/modest-ui-actions.c:
1354 (modest_ui_actions_on_password_requested): Check that the server name
1355 is not NULL, because I just saw a password dialog with (null) as the
1358 * src/modest-tny-folder.[h|c]: Added
1359 modest_tny_folder_is_memory_card_folder().
1360 * src/modest-ui-dimming-rules.c:
1361 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1362 menu item for memory cards, as per the UI spec (section 7.4). This should
1363 fix projects.maemo.org bug NB#59297.
1365 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1367 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1368 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1369 is another problem with the code, see Murray's comment at line 772)
1371 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1373 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1374 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1375 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1376 (load_from_file), (easysetup_country_combo_box_init),
1377 (easysetup_country_combo_box_get_active_country_ids),
1378 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1379 instead of just one ID, to avoid duplicate country names in the UI.
1381 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1382 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1383 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1384 a single ID, avoiding duplicate providers.
1385 * src/maemo/easysetup/modest-easysetup-wizard.c:
1386 (on_combo_account_country): Adapt to use a list.
1388 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1390 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1391 keys changed in the last X seconds.
1393 * src/modest-account-mgr.h:
1394 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1395 (on_key_change), (modest_account_mgr_class_init),
1396 (modest_account_mgr_init), (modest_account_mgr_finalize):
1397 As the keys are changed, save them in a GSList* and signal that GSList*
1398 further every X seconds, to batch changes, to allow us to do just one
1399 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1400 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1402 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1403 changed signal signature.
1405 * src/modest-conf.c: (modest_conf_set_list),
1406 (modest_conf_on_change): Reenable notification.
1408 (modest_conf_maemo_fake_on_change): Comment out the hack that
1409 notified immediately instead of asynchronously.
1411 * src/widgets/modest-account-view.h:
1412 * src/widgets/modest-account-view.c:
1413 (update_account_view): Select the previously-selected account ID,
1414 if possible. This fixes projects.maemo.org bug NB#56933.
1416 (on_account_changed), (on_account_removed),
1417 (modest_account_view_select_account):
1419 Remove the block/unblock functions
1420 because they were not useful.
1422 * src/maemo/modest-account-view-window.c:
1423 (on_delete_button_clicked), (on_edit_button_clicked),
1424 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1426 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1428 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1429 Improve the error dialog to show Incorrect Account Settings, which seems
1430 clearer, and say that the internal error message (to be removed from the
1431 dialog later) is often misleading.
1432 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1434 * src/modest-tny-account.c:
1435 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1436 URL because this is so useful for debugging on the device.
1438 * src/widgets/modest-serversecurity-combo-box.c:
1439 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1441 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1443 * src/modest-mail-operation.c:
1444 (modest_mail_operation_send_new_mail):
1445 Added a comment about a nasty but apparently harmless message. Details
1446 added to the wiki g_warnings() page.
1448 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1450 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1451 (modest_tny_send_queue_class_init):
1452 Do not use the priv struct because it is empty, to avoid g_warnings
1453 about a non-existant priv struct.
1455 * src/modest-tny-account-store.c:
1456 (modest_tny_account_store_get_server_account),
1457 (modest_tny_account_store_get_transport_account_for_open_connection
1458 ): Do not try to get transport server accounts for local folders,
1459 because they don't have any. This avoids a g_warning().
1461 * src/maemo/modest-main-window.c:
1462 (modest_main_window_notify_send_receive_initied),
1463 (on_configuration_key_changed):
1464 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1465 * src/modest-defs.h:
1466 * src/modest-mail-operation.c:
1467 (modest_mail_operation_update_account):
1468 * src/modest-tny-account-store.h:
1469 * src/modest-tny-account.c:
1470 (modest_tny_account_get_special_folder),
1471 (modest_tny_account_new_for_local_folders),
1472 (modest_tny_account_new_for_per_account_local_outbox_folder):
1473 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1474 * src/modest-tny-local-folders-account.c:
1475 (add_account_folders_to_merged_folder):
1476 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1477 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1478 (modest_ui_actions_on_send):
1479 * src/widgets/modest-folder-view.c: (update_model):
1480 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1481 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1482 modest_tny_account_store_get_tny_account_by_account() to
1483 modest_tny_account_store_get_server_account() to make the code clearer.
1485 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1487 * src/dbus_api/modest-dbus-api.h:
1488 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1489 * src/maemo/modest-msg-edit-window.c:
1490 (modest_msg_edit_window_attach_file_noninteractive):
1491 added g_warning in case the file to be attached does not exist
1492 * tests/dbus_api/test_compose_mail.c: (main):
1493 removed obsolete comment, added generic files as test case
1495 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1497 * src/modest-tny-account-store.c: (get_server_accounts):
1498 Create the local folders account only once, not once for each outbox, and
1499 not only when there are some outboxes.
1501 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1503 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1504 code that is causing a crash at startup. Sergio says that he is fixing this.
1506 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1508 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1509 * src/maemo/modest-account-settings-dialog.c:
1510 (create_page_outgoing),
1511 (modest_account_settings_dialog_set_account_name),
1512 (save_configuration):
1513 - Fixed handling of the "Use secure authentication" toggle to comply with
1514 the ui specification. See also projects.maemo.org bug NB#58400
1516 - Restore the Secure connection setting combo correctly when loading
1519 * src/maemo/modest-maemo-utils.c:
1520 (on_camel_account_get_supported_secure_authentication),
1521 (modest_maemo_utils_get_supported_secure_authentication_methods):
1522 Fixed a crasher if operation is canceled
1524 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1525 (modest_protocol_info_auth_is_secure):
1526 * src/modest-protocol-info.h:
1528 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1529 the sense of the "Use secure authentication" toggle.
1531 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1533 * src/modest-tny-account-store.h:
1534 * src/modest-tny-account-store.c:
1535 Added modest_tny_account_store_get_local_folders_account().
1537 * src/modest-tny-folder.h:
1538 * src/modest-tny-folder.c:
1539 (modest_tny_folder_get_account):
1540 Added this replacement for tny_folder_get_account() which returns
1541 the local-folders account for TnyMergeFolders, to avoid the
1542 warning about the unimplemented get_account_func() vfunc().
1544 (modest_tny_folder_get_rules),
1545 * src/modest-ui-actions.c:
1546 (modest_ui_actions_on_folder_selection_changed):
1547 * src/modest-mail-operation.c:
1548 (modest_mail_operation_remove_folder),
1549 (modest_mail_operation_xfer_folder),
1550 (modest_mail_operation_rename_folder),
1551 (modest_mail_operation_get_msg),
1552 (modest_mail_operation_get_msgs_full),
1553 (modest_mail_operation_remove_msg),
1554 (modest_mail_operation_xfer_msgs),
1555 (modest_mail_operation_refresh_folder):
1556 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1558 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1560 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1561 (modest_server_account_set_security):
1562 * src/modest-defs.h: Add comments explaining that our
1563 UI spec means TLS when it says Normal, so these do not look like errors.
1565 * src/modest-tny-account.c:
1566 (modest_tny_account_new_from_server_account): Use the new tinymail
1567 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1568 for TLS. This should fix projects.maemo.org bug NB#58460.
1570 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1572 * src/maemo/easysetup/modest-easysetup-wizard.c:
1573 (create_account): Correct the position of the gconf sanity check warning.
1574 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1575 of using the g_idle_add() hack, because this does not seem to be necessary
1576 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1577 caused by something other than maemo's gconf.
1578 This fixes projects.maemo.org bug #59022.
1580 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1582 * src/modest-account-mgr-helpers.c:
1583 (modest_account_mgr_get_default_account): Do not check that the account
1584 exists if there is no default account (NULL), to fix a runtime warning.
1586 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1588 * src/widgets/modest-folder-view.c: (update_model):
1589 Do not unref the treemodel before we have finished with it.
1590 This prevents a valgrind warning and an occasional crash at startup.
1592 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1594 * libmodest-dbus-client/libmodest-dbus-client.h:
1595 added libmodest_dbus_client_compose_mail()
1596 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1598 added functions needed for SendAsMail() functionality
1599 * src/maemo/modest-msg-edit-window.c:
1600 (modest_msg_edit_window_attach_file_noninteractive):
1601 non interactively attaching files to message edit window
1602 * src/widgets/modest-msg-edit-window.h:
1603 * tests/dbus_api/Makefile.am:
1604 added test_compose_mail.c
1605 * tests/dbus_api/test_compose_mail.c: (main):
1607 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1609 * src/modest-account-view.c:
1610 Fixed bug projects.maemo.org bug NB#59307
1612 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1614 * src/maemo/easysetup/modest-easysetup-wizard.c:
1615 (get_serverport_incoming), (on_before_next), (create_account):
1616 * src/maemo/modest-account-settings-dialog.c:
1617 (modest_account_settings_dialog_set_account_name):
1618 * src/maemo/modest-maemo-utils.c:
1619 (on_camel_account_get_supported_secure_authentication_status),
1620 (on_camel_account_get_supported_secure_authentication),
1621 (on_secure_auth_cancel),
1622 (modest_maemo_utils_get_supported_secure_authentication_methods):
1624 Implemented security authentication for settings and easysetup.
1626 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1628 * src/maemo/modest-main-window.c: (create_details_widget):
1629 Show the total size for memory card accounts too, instead of showing
1630 the name again. Fixes bug projects.maemo.org bug NB#59307.
1632 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1635 * src/modest-tny-simple-folder-store.c:
1636 * src/modest-tny-simple-folder-store.h: Removed.
1638 * src/modest-tny-local-folders-account.h
1639 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1640 for the local-folders maildir, with an extra TnyMergedFolder containing
1641 the folders of the per-account outbox store accounts.
1642 * src/modest-tny-account-store.c: (get_server_accounts):
1643 Add the outboxes to the special local folders account after creating it.
1645 * src/modest-tny-account.c:
1646 (modest_tny_account_new_for_local_folders): Create the derived
1647 account when creating the main local-folders account.
1649 * src/maemo/modest-main-window.c: (create_details_widget),
1650 (modest_main_window_set_contents_style):
1651 Adapted to the use of the derived account instead of the folder store.
1653 * src/modest-ui-actions.c:
1654 (modest_ui_actions_on_folder_selection_changed):
1655 * src/modest-ui-dimming-rules.c:
1656 (modest_ui_dimming_rules_on_new_folder):
1657 * src/widgets/modest-folder-view.c: (text_cell_data),
1658 (icon_cell_data), (filter_row), (update_model),
1659 (get_cmp_rows_type_pos):
1662 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1663 Do not get the priv struct, because no priv struct has been set,
1664 to avoid a runtime warning.
1666 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1667 #ifelse with #else, to fix a warning, to fix the build.
1670 2007-06-05 Christian Kellner <ckellner@openismus.com>
1672 * libmodest-dbus-client/libmodest-dbus-client.c:
1673 Fix small typo in doc (why do you always see them
1674 AFTER committing stuff?)
1677 2007-06-05 Christian Kellner <ckellner@openismus.com>
1679 * libmodest-dbus-client/libmodest-dbus-client.c:
1680 (libmodest_dbus_client_search):
1681 Initialize hit list with NULL. Also set folder list
1682 to "" if NULL was supplied.
1685 2007-06-03 Christian Kellner <ckellner@openismus.com>
1687 * libmodest-dbus-client/libmodest-dbus-client.c:
1688 (modest_search_hit_list_free):
1689 Make it save to call it with NULL.
1691 * src/dbus_api/modest-dbus-callbacks.c:
1692 * src/modest-search.c:
1693 Return full ModestSearchHits as the search result list not TnyHeader
1694 since can't be around withouth the correspoding TnyFolder.
1696 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1698 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1699 Added currently commented code to check for secure auth
1701 * src/maemo/modest-account-settings-dialog.c: (on_response),
1702 (save_configuration), (show_ok):
1703 Fixed projects.maemo.org bugs NB #59248 and #59251
1705 * src/maemo/modest-maemo-utils.c:
1706 (on_camel_account_get_supported_secure_authentication_status),
1707 (on_camel_account_get_supported_secure_authentication),
1708 (modest_maemo_utils_get_supported_secure_authentication_methods):
1709 * src/maemo/modest-maemo-utils.h:
1710 Moved get_supported_secure_authentication() method here to be able
1711 to use it from easysetup wizard.
1713 * src/modest-pair.c: (on_pair_compare_as_string):
1714 Should compare string with first part of pair and not
1715 strcmp pairs which will crash.
1717 * src/modest-protocol-info.c:
1718 (modest_protocol_info_protocol_is_store):
1719 * src/modest-protocol-info.h:
1720 Added modest_protocol_info_get_auth_protocol_name()
1722 2007-06-03 Armin Burgmeier <armin@openismus.com>
1724 * src/modest-mail-operation.c:
1725 (modest_mail_operation_get_msgs_full): Set priv->account also when
1726 only retrieving a single message. This avoids a crash when canceling
1729 (modest_mail_operation_notify_end): Do not explicitely remove the
1730 operation from the queue but only emit the progress_changed signal.
1731 The queue itself listens to that signal to remove the operation when
1732 it is finished. This reduces coupling and removes a potential deadlock
1733 when modest_mail_operation_notify_end() is called from the queue
1734 itself. If that is a problem performance-wise, I would suggest to
1735 implement a status-changed signal or something.
1737 * src/modest-mail-operation-queue.c: Make sure to never call a
1738 function from another file while the queue is locked. This (hopefully)
1739 fixes another deadlock when exiting the application while retrieving
1742 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1744 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1745 Fixed build if libogs is not available
1747 2007-06-03 Christian Kellner <ckellner@openismus.com>
1749 * libmodest-dbus-client/libmodest-dbus-client.h:
1750 * libmodest-dbus-client/libmodest-dbus-client.c:
1751 (libmodest_dbus_client_delete_message):
1752 Implement deletion of messages (Client side).
1754 (modest_search_hit_free),
1755 (modest_search_hit_list_free):
1756 Utility functions to free the result hits.
1758 * src/dbus_api/modest-dbus-api.h:
1759 * src/dbus_api/modest-dbus-callbacks.c:
1760 (on_delete_message),
1761 (modest_dbus_req_handler):
1762 Implement deletion of messages (Server side).
1764 * tests/dbus_api/test_search.c: (main):
1767 * tests/dbus_api/Makefile.am:
1768 * tests/dbus_api/test_delete_message:
1769 Add little test for the message deletion logic
1771 2007-06-03 Armin Burgmeier <armin@openismus.com>
1773 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1774 when the operation queue was not empty. projects.maemo.org bug
1777 2007-06-03 Armin Burgmeier <armin@openismus.com>
1779 * src/widgets/modest-account-view.c
1780 (on_account_default_toggled): Toggle default account column
1781 explicitely instead of waiting for gconf notification (which is
1782 currently ignored). This should fix projects.maemo.org bug NB#56910
1783 for now. It should probably be removed when gconf notifications are
1786 2007-06-03 Christian Kellner <ckellner@openismus.com>
1788 * libmodest-dbus-client/libmodest-dbus-client.c:
1789 Removed debugging spew.
1791 * src/dbus_api/modest-dbus-callbacks.c:
1792 Added debugging info.
1794 * src/modest-search.c:
1795 (modest_search_all_accounts):
1796 Use tny_account_store_get_accounts () on the account store
1797 to get all accounts which is the way to get all accounts.
1799 * tests/dbus_api/test_search.c: (main):
1800 Make it possible to supply the search term on the command line.
1802 2007-06-03 Christian Kellner <ckellner@openismus.com>
1804 * libmodest-dbus-client/libmodest-dbus-client.c:
1805 * libmodest-dbus-client/libmodest-dbus-client.h:
1806 Implement searching for mesages over raw dbus. (Client side)
1808 * src/dbus_api/Makefile.am:
1809 * src/dbus_api/modest-dbus-api.h:
1810 * src/dbus_api/modest-dbus-callbacks.c:
1811 * src/dbus_api/modest-dbus-callbacks.h:
1812 Search framework (Server side). Also implement on_idle_open_message().
1814 * src/maemo/modest-platform.c: (modest_platform_init):
1815 Prepare for raw dbus/osso rpc interaction.
1817 * src/modest-search.h:
1818 Changed minsize from unspecific guint to guint32.
1820 * src/modest-search.c:
1822 Added strange hack which magically made tnymail work.
1824 (modest_search_folder),
1825 (modest_search_account),
1826 (modest_search_all_accounts):
1827 Implement helper functions to search all accounts, specific account
1830 * tests/dbus_api/Makefile.am:
1831 * tests/dbus_api/test_open_message.c:
1832 Read url to open from commandline.
1834 * tests/dbus_api/test_search.c:
1835 Implement small test for dbus search stuff
1837 2007-06-02 Armin Burgmeier <armin@openismus.com>
1839 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1840 include account type and account title. This fixes projects.maemo.org
1843 * src/maemo/modest-account-view-window.c: Set a title for the window.
1845 2007-06-02 Armin Burgmeier <armin@openismus.com>
1847 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1848 incoming and outgoing server name based on email address and server
1849 types as long as the names have not been edited manually. This fixes
1850 projects.maemo.org bug NB#58671.
1852 2007-06-02 Armin Burgmeier <armin@openismus.com>
1854 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1855 server type cannot be changed in future to the incoming details page
1856 when creating an account. This fixes projects.maemo.org bug NB#59029.
1858 2007-06-02 Armin Burgmeier <armin@openismus.com>
1860 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1861 and assigned max width chars so that they wrap instead of being
1862 truncated. Fixes projects.maemo.org bug NB#56126.
1864 2007-06-02 Armin Burgmeier <armin@openismus.com>
1866 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1867 introductory note to the connection specific smtp servers dialog, as
1868 section 8.12 of the email UI specification requires. This fixes
1869 projects.maemo.org bug NB#59212.
1871 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1873 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1874 Check for running mail operations, and offer to cancel them, as per the UI
1875 spec. This fixes projects.maemo.org bug NB#59041 .
1876 However, I suspect that tinymail may still use the network connection
1877 in ways that we cannot detect or cancel. But it should at least adapt to
1878 changes fairly well.
1880 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1882 * src/modest-tny-account-store.c: (recreate_all_accounts),
1883 (get_cached_accounts), (get_server_accounts): Do more sensible
1884 ref-counting of the temporarily-cached outbox accounts list. This seems
1885 to fix a crash when entering the password when the password was wrong.
1887 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1889 * src/gnome/modest-main-window.c: (connect_signals):
1890 * src/modest-tny-account-store.c: (get_password),
1891 (modest_tny_account_store_alert): Added comments and clues and
1892 commented-out code about how we currently fail to deal with connection
1893 errors and wrong passwords, and how we should.
1895 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1897 * src/widgets/modest-retrieve-combo-box.c:
1898 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1899 This fixes projects.maemo.org bug NB#58472 .
1901 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1903 * src/maemo/easysetup/modest-easysetup-wizard.c:
1904 (create_page_complete_easysetup):
1905 (create_page_complete_custom): Correct the last commit,
1906 putting the correct sentences in the correct pages.
1908 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1910 * src/maemo/easysetup/modest-easysetup-wizard.c:
1911 (create_page_complete_custom): Show the second sentence of text
1912 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1915 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1917 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1918 Set the leave-on-server conf key by default. This fixes
1919 projects.maemo.org bug NB#59258 .
1921 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1923 * src/maemo/modest-account-view-window.c:
1924 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1925 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1928 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1930 * src/maemo/easysetup/modest-easysetup-wizard.c:
1931 (create_caption_new_with_asterisk):
1932 * src/maemo/modest-account-settings-dialog.c:
1933 (create_caption_new_with_asterisk):
1934 Uncomment the code to add the asterisk, because they are no longer in the
1935 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1936 (update_incoming_server_title): Add an asterisk here too.
1938 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1940 * src/maemo/modest-maemo-global-settings-dialog.c:
1941 (current_connection): Check that we are even connected before trying to
1942 get the current connection name, to prevent a warning.
1944 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1945 Change the comments because tny_maemo_conic_device_connect() is now meant to
1947 * src/modest-mail-operation.c:
1948 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1949 make sure we have a connection and fail if we can't connect.
1951 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/modest-main-window.c:
1954 (on_account_store_connecting_finished): Do not try to get the
1955 connection ID if we are not really connected. I am surprised that
1956 this signal handler is called when we are not connected.
1958 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1960 * src/modest-error.h:
1961 * src/modest-ui-actions.c:
1962 (modest_ui_actions_get_msgs_full_error_handler):
1963 Renamed an enum, added comments, added an enum
1964 for retrieve-limit errors.
1966 * src/modest-mail-operation.c: (foreach_add_item),
1967 (internal_folder_observer_update), (update_account_thread),
1968 (modest_mail_operation_get_msgs_full):
1969 (modest_mail_operation_update_account),
1970 Added comments about how this works, and some code that should
1971 (but does not) check the retrieve-limit. See the TODO comment.
1973 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1975 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1976 Initialize help_id to fix the build. Warnings are good.
1978 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1980 * src/widgets/modest-hbox-cell-renderer.c:
1981 (modest_hbox_cell_renderer_append):
1982 * src/widgets/modest-vbox-cell-renderer.c:
1983 (modest_vbox_cell_renderer_append):
1984 Fix the last commit by doing an extra ref.
1986 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1988 * src/widgets/modest-hbox-cell-renderer.c:
1989 (modest_hbox_cell_renderer_append):
1990 * src/widgets/modest-vbox-cell-renderer.c:
1991 (modest_vbox_cell_renderer_append):
1992 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1993 to fix the build with Maemo Bora.
1994 However, there seems to be a remaining crash, probably due to reference
1997 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1999 * src/modest-tny-account.c:
2000 (modest_tny_account_new_for_local_folders):
2001 Use hildon_file_system_info_async_new() to get a better name for
2002 the memory card account, setting it as the account name.
2003 The timing seems to work, but this is probably
2004 not the best place to do this. See the TODO comment.
2005 * src/maemo/modest-main-window.c: (create_details_widget):
2006 * src/widgets/modest-folder-view.c: (text_cell_data):
2007 Use the tny account name instead of hardcoding a name.
2009 2007-05-30 Christian Kellner <ckellner@openismus.com>
2011 * src/modest-search.c: (modest_search):
2012 Correctly set part_search_func even if we have already parsed
2013 the query and thus a valid OgsTextSearcher object.
2015 2007-05-30 Christian Kellner <ckellner@openismus.com>
2018 Search and check for libogs.
2021 Incooparte the ogs build env.
2023 * src/modest-mime-part-search-stream.c:
2024 * src/modest-mime-part-search-stream.h:
2025 Removed since we do the real searching now in modest-search.c.
2027 * src/modest-search.c:
2028 * src/modest-search.h:
2029 Implement support for ogs. We use that if available and requested
2030 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2031 should now handle the corner case when the search term is spread
2032 across multiple reads.
2033 Also the logic in modest_search () was corrected to search all
2034 requested fields until one is found.
2036 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2038 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2040 * src/modest-init.h:
2041 * src/modest-init.c: Made modest_init_local_folders() take a
2042 path and be public so we can iniitialize maildir folders on
2045 * src/modest-local-folder-info.h:
2046 * src/modest-local-folder-info.c:
2047 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2049 * src/modest-tny-account.c:
2050 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2051 still means the standard local-folders path on the local volume.
2053 * src/modest-tny-account-store.c:
2054 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2055 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2056 all accounts when that happens.
2057 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2058 this too, so it shows up in the treeview.
2060 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2062 * src/maemo/modest-maemo-global-settings-dialog.c:
2063 (current_connection):
2064 * src/widgets/modest-global-settings-dialog.c:
2065 (current_connection_default):
2066 Use the enum values instead of 0, 1 and -1,
2067 to make the code clearer.
2069 * src/modest-account-mgr-helpers.c:
2070 (modest_account_mgr_get_connection_specific_smtp): Make this code
2073 * src/modest-runtime.h:
2074 * src/modest-runtime.c:
2075 Added modest_runtime_remove_all_send_queues().
2076 * src/maemo/modest-main-window.c:
2077 (on_account_store_connecting_finished): Recreate the send queues,
2078 using the appropriate transport accounts for this new connection.
2079 Some futher adapting might be needed if the old send queues are not
2080 automatically stopped at this point.
2082 * src/modest-tny-account-store.c: (get_server_accounts):
2083 Create the connection-specific transport accounts, so that they can
2084 be found later by their ID.
2086 * src/modest-tny-account.h:
2087 * src/modest-tny-account.c:
2088 Added modest_tny_account_new_from_server_account_name().
2089 modest_tny_account_new_from_server_account(): Do not create the
2090 send queues here, because they will be
2091 recreated anyway when the connection changes for the first time.
2093 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2095 * src/modest-local-folder-info.h:
2096 * src/modest-local-folder-info.c:
2097 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2098 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2099 tbox_folder): Take a modest account name instead of a server TnyAccount,
2100 so we can have per-modest-account rather than per-transport-account
2102 We must make sure that we change or recreate the exisitng send queues
2103 when the connection changes for connection-specific transport accounts.
2105 * src/modest-tny-account-store.c:
2106 (create_per_account_local_outbox_folders): Create outboxed per modest
2107 account, not per transport account.
2109 * src/modest-tny-account.h:
2110 * src/modest-tny-account.c:
2111 (modest_tny_account_get_special_folder): For outboxes, get the
2112 parent modest account name. The account is ignored for other folders.
2113 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2114 modest account name rather than a server TnyAccount.
2116 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2118 * src/modest-tny-account.c:
2119 (modest_tny_account_new_from_server_account):
2120 Call modest_runtime_get_send_queue() immediately after creating transport
2121 accounts, so that they start trying to send email from the outbox as soon
2122 as possible at startup. This is probably what we want.
2124 * src/modest-mail-operation.c: (update_account_thread):
2125 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2126 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2127 * src/modest-tny-send-queue.h:
2128 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2129 (modest_ui_actions_on_send):
2130 Added comments about how sending works, though it needs some more work.
2132 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2134 * src/modest-tny-account.c:
2135 (modest_tny_account_get_special_folder): Add TODO because this fails when
2136 the network is busy.
2137 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2138 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2139 Do not try to show this window when there is no active account. The UI
2140 specs does not tell us what to do in this case.
2142 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2146 * src/maemo/Makefile.am:
2147 * src/widgets/Makefile.am: Some dist fixes.
2149 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2151 * src/maemo/modest-connection-specific-smtp-window.c:
2152 (on_button_edit): Make the code clearer, to prevent a double free.
2154 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2156 * src/maemo/modest-account-settings-dialog.c:
2157 (modest_account_settings_dialog_set_account_name),
2158 Check the connection-specific smtp servers checkbox if there are any.
2160 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2161 (modest_connection_specific_smtp_edit_window_init):
2162 Start with a suitable port number.
2164 * src/modest-account-mgr-helpers.h:
2165 * src/modest-account-mgr-helpers.c: Added
2166 modest_account_mgr_get_has_connection_specific_smtp().
2168 (modest_account_mgr_set_connection_specific_smtp),
2169 (modest_account_mgr_remove_connection_specific_smtp),
2170 (modest_account_mgr_get_has_connection_specific_smtp),
2171 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2172 connection-specific smtp server accounts in the account, rather than
2173 the server account conf dir.
2175 This fixes bug projects.maemo.org bug NB#58263 .
2177 * src/modest-tny-account-store.c:
2178 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2179 if there are no server accounts yet, to prevent an infinite loop when there
2180 are no accounts. Document that one must be called before the other.
2182 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2184 * src/modest-account-mgr-helpers.c:
2185 (modest_account_mgr_get_default_account): Make sure that at least
2186 one account is always the default, if there are any enabled accounts.
2187 This is just a sanity check that shouldn't be necessary.
2189 * src/modest-account-mgr-priv.c:
2190 (_modest_account_mgr_account_from_key): Unescape the conf key to
2191 get the real account name. For instance, this is an issue if a space
2192 was in the account name, which can happen because the account name
2193 is generated from the display name.
2194 (_modest_account_mgr_get_account_keyname): Always escape the
2196 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2197 Unescape the conf keys to get the real account names.
2199 For instance, previously the is-default radio button in the accounts
2200 list was not checked for any accounts at first. This fixes that,
2201 and might fix several similar bugs.
2203 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2205 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2206 Removed some debug printfs.
2208 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2210 Modest on-disk outbox directories are now here, for instance:
2211 $HOME/.modest/outboxes/<account-id-1>/outbox
2212 $HOME/.modest/outboxes/<account-id-2>/outbox
2214 $HOME/.modest/local-folders/outbox
2215 so we can have a separate outbox for each account.
2216 But they are shown as one outbox in the GtkTreeView, by using a
2217 TnyMergeFolder in a ModestTnySimpleFolderStore.
2220 * src/modest-tny-simple-folder-store.c:
2221 * src/modest-tny-simple-folder-store.h:
2222 Added ModestTnySimpleFolderStore, used to contain folders from
2223 other folder stores, such as other accounts.
2225 * src/modest-tny-outbox-account.h:
2226 * src/modest-tny-outbox-account.c:
2227 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2228 used for the per-account local outbox folders.
2230 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2231 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2232 only use this (internally) now for the non-outbox local folders.
2234 * src/modest-init.h:
2235 * src/modest-init.c: Added modest_init_one_local_folder(), for
2236 setting up the directory structure for each local folder.
2238 * src/modest-local-folder-info.c:
2239 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2240 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2242 * src/modest-local-folder-info.h:
2243 * src/modest-tny-account-store.c: (on_account_removed),
2244 (on_account_changed), (create_per_account_local_outbox_folders),
2245 (get_server_accounts), (modest_tny_account_store_get_accounts),
2246 (modest_tny_account_store_get_tny_account_by_account),
2247 (modest_tny_folder_store_is_virtual_local_folders):
2249 * src/modest-tny-account.h:
2250 * src/modest-tny-account.c:
2251 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2252 to create an on-disk per-account local outbox folder for each
2254 (create_per_account_local_outbox_folders): Create a local outbox folder
2255 for each transport account.
2256 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2257 for all local folders.
2259 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2260 instead of using g_object_get/set() directly. It is clearer.
2262 (modest_tny_folder_store_get_message_count),
2263 (modest_tny_folder_store_get_local_size
2264 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2265 because we now use these with non-acount folder stores.
2267 (modest_tny_account_get_special_folder),
2268 (modest_tny_account_new_from_server_account),
2269 (modest_tny_account_new_from_account):
2270 (recurse_folders): Adjust to the new outbox system.
2272 * src/modest-tny-folder.h:
2273 * src/modest-tny-folder.c:
2274 (modest_tny_folder_is_local_folder),
2275 (modest_tny_folder_get_local_folder_type),
2276 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2278 * src/widgets/modest-main-window.h:
2279 * src/maemo/modest-main-window.c: (create_details_widget),
2280 (modest_main_window_set_contents_style): Show details for any folder store,
2283 (modest_tny_folder_get_rules):
2284 Remove the const. C does not support constness enough for this.
2286 * src/modest-ui-actions.c:
2287 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2288 make all outboxes appear as one, in the usual local-folders tree node.
2290 (set_active_account_from_tny_account),
2291 (modest_ui_actions_on_folder_selection_changed):
2292 * src/widgets/modest-folder-view.c: (text_cell_data),
2293 (icon_cell_data), (filter_row),
2294 (add_account_folders_to_merged_folder),
2295 (add_account_folders_to_simple_folder_store), (),
2296 (get_cmp_rows_type_pos), (cmp_rows),
2297 (modest_folder_view_set_account_id_of_visible_server_account):
2298 Adjust to the new outbox system, using generic folder stores and folders
2299 in the GtkTreeModel.
2301 2007-05-23 Christian Kellner <ckellner@openismus.com>
2303 * src/modest-mail-operation.c:
2304 (modest_mail_operation_update_account):
2305 Use info->max_size instead of unintialized local var [small
2306 build fix]. (Added TODO to review that change since I don't
2309 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2311 * libmodest-dbus-client/libmodest-dbus-client.c:
2312 (libmodest_dbus_client_compose_mail): function added
2313 * src/dbus_api/modest-dbus-api.h:
2314 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2315 (on_compose_mail): Implementation of the SendAsMail functionality
2317 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2319 * src/modest-account-mgr.c:
2320 (modest_account_mgr_add_server_account): Set the secure-connection
2321 conf key for transport accounts as well as store accounts. I don't know
2322 why the if was there. For instance, this makes sure that we use SSL
2323 for the gmail preset from the easysetup wizard.
2325 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2327 * src/gnome/modest-main-window.c:
2328 (on_account_store_connecting_finished), (connect_signals):
2329 * src/maemo/modest-main-window.c:
2330 (on_account_store_connecting_finished), (connect_signals),
2331 (modest_main_window_new):
2332 Handle TnyAccountStore::connecting-finished instead of
2333 TnyDevice::connection-changed, because we cannot actually perform
2334 operations on accounts until TnyAccountStore has itself responded to
2335 the TnyDevice::connection-changed signal. This prevents a GError from
2337 Do not try to update at startup, because we (at least on scratchbox)
2338 already do an update at startup when the device goes online.
2339 This prevents a GError from tinymail.
2340 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2341 Added TODO about stopping simultaneous operations.
2343 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2345 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2346 * src/modest-mail-operation-queue.c:
2347 (modest_mail_operation_queue_remove):
2348 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2349 about where they happened.
2351 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2353 * src/modest-ui-actions.c:
2354 (modest_ui_actions_on_password_requested): Make sure that the remember
2355 output parameter is always TRUE.
2357 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2359 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2360 Show a OK/Cancel dialog if the error is a question, though we still do not
2361 know anything more about what we are asking the user.
2362 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2363 Fix an uninitialized variable (helper). This is a logic error, however.
2365 2007-05-21 Christian Kellner <ckellner@openismus.com>
2367 * src/modest-search.h:
2368 Correct bit shifting in the ModestSearchFlags enum.
2370 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2372 * src/modest-tny-account.c:
2373 (modest_tny_account_new_from_server_account): Do not use the lsub and
2374 check-all hard-coded IMAP options when using POP.
2376 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2378 * src/modest-tny-account.c:
2379 (modest_tny_account_new_from_server_account):
2380 Use NULL for the secure-auth method for POP when Password auth has been
2381 specified by the user, as we already do for IMAP. "auth=Login" causes
2382 an error from camel or the server.
2384 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2386 * src/maemo/modest-account-settings-dialog.c:
2387 (create_page_account_details),
2388 (modest_account_settings_dialog_set_account_name):
2389 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2390 for the leave-on-server checkbox, rathr than just the checkbox, when
2391 the protocol is not POP.
2393 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2395 * src/widgets/modest-account-view.c:
2396 * src/widgets/modest-account-view.h:
2397 Added modest_account_view_select_account() which will be useful later
2398 to asynchronously re-select the edited account.
2400 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2402 * src/maemo/modest-account-settings-dialog.c:
2403 (modest_account_settings_dialog_set_account_name):
2404 Automatically choose the port numbers based on the secure authentication
2405 methods, if they have not been chosen before.
2406 This fixes projects.maemo.org bug NB#56273 .
2408 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2410 * src/maemo/modest-main-window-ui.h:
2411 * src/modest-ui-actions.c:
2412 * src/modest-ui-actions.h:
2413 Connect the Tools/SMTP Servers menu item to
2414 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2415 SMTP servers dialog, as in the UI specification and saves changes when it
2416 is closed. This fixed projects.maemo.org bug NB#56305 .
2418 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2420 * src/maemo/modest-connection-specific-smtp-window.c:
2421 (modest_connection_specific_smtp_window_init):
2422 Use gtk_window_set_default_size() to make this window big enough, so
2423 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2425 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2427 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2428 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2429 (modest_connection_specific_smtp_edit_window_init),
2430 Do not try to connect to a combobox signal before the combobox exists.
2431 This fixes the cras in projects.maemo.org bug NB#56288 .
2432 (modest_connection_specific_smtp_edit_window_get_settings):
2433 Remove the server_account_name parameter which was being checked for NULL
2434 though it was not used.
2436 * src/maemo/modest-connection-specific-smtp-window.c:
2437 (modest_connection_specific_smtp_window_fill_with_connections),
2438 (on_button_edit), (modest_connection_specific_smtp_window_init):
2439 Correct the number of treemodel columns to prevent a warning.
2440 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2441 libconic does not work.
2443 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2445 * src/modest-tny-account.c:
2446 (modest_tny_account_new_from_server_account):
2447 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2448 SMTP when "None" was chosen by the user. However, with my SMTP server that
2449 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2452 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2454 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2455 to explain the memory management issue with the ID in the ModestPair.
2457 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2458 (add_sending_page), (modest_account_assistant_finalize):
2459 * src/gnome/modest-gnome-global-settings-dialog.c:
2460 (create_updating_page), (create_composing_page):
2461 * src/gnome/modest-msg-edit-window.c: (get_transports),
2462 (init_window), (modest_msg_edit_window_finalize),
2463 (modest_msg_edit_window_get_msg_data):
2464 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2465 * src/gnome/modest-transport-widget.c:
2466 (modest_transport_widget_finalize), (smtp_configuration):
2467 * src/maemo/modest-maemo-global-settings-dialog.c:
2468 (create_updating_page), (create_composing_page):
2469 * src/maemo/modest-msg-edit-window.c: (get_transports),
2470 (init_window), (modest_msg_edit_window_finalize),
2471 (modest_msg_edit_window_get_msg_data),
2472 (modest_msg_edit_window_free_msg_data):
2473 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2474 (modest_store_widget_finalize):
2475 * src/maemo/modest-transport-widget.c:
2476 (modest_transport_widget_finalize), (smtp_configuration):
2477 * src/modest-main.c: (send_mail):
2478 * src/widgets/modest-combo-box.h:
2479 * src/widgets/modest-global-settings-dialog-priv.h:
2480 * src/widgets/modest-global-settings-dialog.c:
2481 (modest_global_settings_dialog_finalize):
2482 * src/widgets/modest-msg-edit-window.h:
2483 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2484 as long as the combo box, to prevent use of freed memory for the ID.
2486 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2488 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2489 get_accounts(), to make this clearer. Do not check for the enabled gconf
2490 key, because we do not use this for server accounts (at least, not yet).
2491 This allows us to send email again.
2493 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/modest-platform.c:
2496 (on_modest_conf_update_interval_changed), (modest_platform_init):
2497 Only respond to this particular key change. All these strcmp()s cannot be
2500 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2502 * src/maemo/modest-maemo-global-settings-dialog.c:
2503 (current_connection): Prevent a crash in scratchbox when
2504 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2505 * src/maemo/modest-platform.c:
2506 (on_modest_conf_update_interval_changed), (modest_platform_init):
2507 Get the update interval from gconf and reset it when the gconf key changes.
2509 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2511 * src/modest-protocol-info.c:
2512 * src/modest-protocol-info.h: Adde enum-specific get functions,
2513 instead of using a ModestProtocolType enum parameter.
2515 * src/gnome/modest-account-assistant.c:
2516 * src/gnome/modest-store-widget.c:
2517 * src/gnome/modest-store-widget.h:
2518 * src/gnome/modest-transport-widget.c:
2519 * src/gnome/modest-transport-widget.h:
2520 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2521 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2522 * src/maemo/easysetup/modest-easysetup-wizard.c:
2523 * src/maemo/modest-account-settings-dialog.c:
2524 * src/maemo/modest-account-settings-dialog.h:
2525 * src/maemo/modest-store-widget.c:
2526 * src/maemo/modest-store-widget.h:
2527 * src/maemo/modest-transport-widget.c:
2528 * src/maemo/modest-transport-widget.h:
2529 * src/modest-account-mgr-helpers.c:
2530 * src/modest-account-mgr-helpers.h:
2531 * src/modest-account-mgr.c:
2532 * src/modest-account-mgr.h:
2533 * src/modest-tny-account.c:
2534 * src/modest-tny-folder.c:
2535 * src/widgets/modest-account-view.c:
2536 * src/widgets/modest-retrieve-combo-box.c:
2537 * src/widgets/modest-retrieve-combo-box.h:
2538 * src/widgets/modest-secureauth-combo-box.c:
2539 * src/widgets/modest-serversecurity-combo-box.c:
2540 * src/widgets/modest-serversecurity-combo-box.h:
2541 * tests/check_account-mgr.c:
2542 Use the specific functions, and use the re-renamed enum values for GNOME too.
2544 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2546 * src/modest-pair.h:
2547 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2548 so we can get the second based on the first.
2550 * src/maemo/modest-account-settings-dialog.h:
2551 * src/maemo/modest-account-settings-dialog.c:
2552 Added get_supported_secure_authentication_methods(), though it is mostly
2553 commented-out for now until the necessary API is committed to tinymail.
2554 (modest_account_settings_dialog_set_account_name),
2555 (save_configuration): Request the supported authentication methods from the
2556 server, so we can choose a working method.
2558 * src/modest-tny-account-store.h:
2559 * src/modest-tny-account-store.c:
2560 (modest_tny_account_store_get_session): Rename from
2561 tny_account_store_get_session().
2563 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2565 * src/modest-protocol-info.h: Split the ModestProtocol enum
2566 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2567 There was no need to have these unrelated values in one enum.
2569 * src/: many files: Adapted to changed enum. This makes the code a bit
2570 clearer, and the compiler could catch some errors.
2572 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2574 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2575 Show the detailed internal camel error message when an error happens
2576 during the configuration, so that our testers can give us more clues.
2577 For instance, in projects.maemo.org bug NB#56910 .
2579 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2581 * src/modest-tny-account.c:
2582 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2583 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2585 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2587 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2588 * src/maemo/modest-account-settings-dialog.c:
2589 (modest_account_settings_dialog_set_account_name),
2590 (save_configuration): For the incoming secure authentication checkbox,
2591 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2592 the UI specification. PLAIN does not seem to be supported for most IMAP
2593 servers anyway, and I am not sure what it would mean.
2594 However, we probably need to discover which of the secure-authentication
2595 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2596 * src/modest-account-mgr-helpers.c:
2597 (modest_account_mgr_get_server_account_data):
2599 * src/modest-tny-account.c:
2600 (modest_tny_account_new_from_server_account):
2601 Use tny_account_set_mech() to set secure-authentication methods,
2602 with some special-casing for IMAP, based on my observations of how
2605 * src/modest-account-mgr-helpers.h:
2606 * src/modest-account-mgr.c:
2607 * src/modest-defs.h: Comment that the URI is only used for local folders.
2609 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2611 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2612 parameter const, just to be neat.
2613 * src/modest-text-utils.c: (modest_text_utils_inline):
2614 End g_strconcat() with NULL, as its documentation says. This is almost
2615 certainly the cause of my crash at startup on the device. Interestingly,
2616 valgrind doesn't tell us about these errors.
2618 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2620 * scripts/build-packages: Added more precise comments about how to use
2621 this script, though I still get this error:
2622 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2623 error building tinymail
2625 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2627 * src/maemo/modest-main-window.c: (on_account_update):
2628 Very slight cleanup, hoping to make it simpler to discover what causes
2629 a crash here sometimes.
2631 * src/modest-tny-account.c:
2632 (modest_tny_account_new_from_server_account): Set the port. Added
2633 comments about the options and a TODO comment because I need to find out
2634 how to specify the secure authentication method.
2636 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2638 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2639 changed CFlags paths form modest to libmodest
2641 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2643 * src/modest-account-mgr-helpers.c:
2644 (modest_account_mgr_get_server_account_data),
2645 (modest_account_mgr_free_server_account_data):
2646 * src/modest-account-mgr-helpers.h:
2647 * src/modest-account-mgr.c:
2648 (modest_account_mgr_add_server_account):
2649 * src/modest-defs.h:
2650 * src/modest-tny-account.c:
2651 (modest_tny_account_new_from_server_account):
2652 Determine the options for tny_camel_account_add_option() here,
2653 based on the settings, rather than storing them directly in gconf.
2655 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2657 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2658 Show a more friendly error dialog now that we expect (from the tinymail
2659 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2661 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2663 * src/maemo/modest-main-window.c: (on_account_update): Check that
2664 account_name is not NULL, to prevent a crash at startup that I am
2665 seeing on the N800. I do wonder why it is NULL.
2667 * src/maemo/easysetup/modest-easysetup-wizard.c:
2668 (create_page_user_details):
2669 * src/maemo/modest-account-settings-dialog.c:
2670 (create_page_user_details), (create_page_outgoing):
2671 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2672 (modest_connection_specific_smtp_edit_window_init):
2673 * src/modest-ui-actions.c:
2674 (modest_ui_actions_on_password_requested):
2675 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2676 might do something useful with the on-screen keyboard.
2678 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2680 * src/maemo/modest-main-window.c: (on_account_update):
2681 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2682 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2684 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2686 * src/modest-tny-account-store.c: (on_account_changed):
2687 Correct the signature of this signal handler.
2689 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2691 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2692 Show a HildonNote instead of a GtkDialog for Maemo.
2694 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2696 * src/widgets/modest-account-view.h:
2697 * src/widgets/modest-account-view.c: (on_account_changed),
2698 (on_account_removed). Added a boolean flag, set/unset by
2699 modest_account_view_block_conf_updates(),
2700 modest_account_view_unblock_conf_updates() to prevent unnecessary
2701 updates, but this is not very useful because the gconf notifications are
2702 so delays (maybe only on Maemo Bora).
2703 So auto-updating is turned off, and these functions do an explicit
2704 update when necessary.
2705 However, something else is still doing too much work when adding/removing
2706 accounts, probably in another part of the application.
2708 * src/maemo/modest-account-view-window.c:
2709 (on_delete_button_clicked), (on_edit_button_clicked),
2710 (on_new_button_clicked): Use the new functions.
2712 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2714 * src/modest-account-mgr-helpers.c:
2715 (modest_account_mgr_set_first_account_as_default):
2716 Sort the list of names alphabetically-by-title, so we choose the first one
2718 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2719 alphabetically by the title.
2721 This fixes projects.maemo.org bug NB#56418 .
2723 * src/modest-account-mgr-priv.c:
2724 (_modest_account_mgr_account_from_key):
2725 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2726 avoid a valgrind error, and possible random behaviour.
2728 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2730 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2731 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2732 tinymail documentation to say that this can be expected.
2733 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2734 pretty, and should not happen, but I would prefer to know when it does.
2736 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2738 * configure.ac: When using the older hildon version, probably on Bora,
2739 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2741 * src/widgets/modest-attachment-view.c:
2742 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2745 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2747 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2748 Implemented the prototype. Can be tested with
2749 tests/dbus_api/test_open_message:
2751 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2753 * src/modest-tny-account-store.c:
2754 (modest_tny_account_store_instance_init), (get_password):
2755 * src/modest-ui-actions.c:
2756 (modest_ui_actions_on_password_requested):
2757 Do not store the password in gconf, because this function is called
2758 for non-remembered passwords. Actually use the cached (in the hash map)
2759 password instead of releasing it.
2760 The password will now not be remembered if it is asked via the protected
2761 password dialog, as per the UI spec.
2763 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2765 * src/modest-defs.h:
2766 * src/modest-account-mgr-helpers.h:
2767 * src/modest-account-mgr-helpers.c:
2768 Added modest_server_account_get_username_has_succeeded(),
2769 modest_server_account_set_username_has_succeeded().
2770 (modest_server_account_set_username),
2771 Reset the has-succeeded flag if the username changes.
2773 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2774 * src/maemo/modest-connection-specific-smtp-window.c:
2775 (modest_connection_specific_smtp_window_save_server_accounts):
2776 Use modest_server_account_set_username() instead of using
2777 modest_conf_set_string() directly, so that the has-succeeded flag is always
2780 * src/modest-ui-actions.c:
2781 (modest_ui_actions_on_password_requested): Dim the username entry if
2782 the username has ever worked, as per the UI spec.
2784 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2786 * src/modest-tny-account-store.c: (get_password):
2787 * src/modest-ui-actions.c:
2788 (modest_ui_actions_on_password_requested):
2789 Allow the username to be changed too, though there is more work to
2790 be done on exactly how this behaves.
2792 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2794 * src/modest-account-mgr-helpers.h:
2795 * src/modest-account-mgr-helpers.c:
2796 Added modest_account_mgr_get_display_name(),
2797 modest_server_account_get_username(),
2798 modest_server_account_set_username(),
2799 modest_server_account_set_password(),
2800 modest_server_account_get_hostname() functions so we do not need to
2801 use the conf API directly.
2803 * src/maemo/modest-main-window.c: (connect_signals):
2804 Actually connect ot the ModestAccountStore::request-password signal,
2805 so that we show the dialog when the password is requested by Tinymail,
2806 for isntance if it is empty.
2808 * src/modest-marshal.list:
2809 * src/modest-tny-account-store.c:
2810 (modest_tny_account_store_class_init), (get_password),
2811 (modest_tny_account_store_alert):
2812 * src/modest-tny-account-store.h:
2813 * src/modest-ui-actions.h:
2814 * src/modest-ui-actions.c:
2815 (modest_ui_actions_on_password_requested):
2816 Change the signal parameters, so it is obvious that we are providing
2817 the non human-readable server name, and receiving both the username
2818 and password, though changing of the username is not yet implemented.
2819 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2820 for the GNOME version.
2822 This should fix the projects.maemo.org bug NB#56209, though it does not
2823 work on Bora, because the gconf_client_get() for the password fails
2824 immediately after we save it with gconf_client_set().
2826 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2829 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2830 caused an undefined symbol error:
2831 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2833 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2835 * src/modest-tny-account-store.c:
2836 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2837 using a GError instead of a string message, so we can translate it in
2840 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2842 * src/maemo/modest-address-book.c:
2843 (modest_address_book_check_names):
2844 * src/maemo/modest-msg-view-window.c:
2845 (modest_msg_view_window_clipboard_owner_change):
2846 * src/modest-init.c: (modest_init_init_ui):
2847 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2848 (update_folders_cb), (modest_mail_operation_update_account):
2849 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2850 (modest_ui_actions_on_msg_attachment_clicked),
2851 (modest_ui_actions_on_msg_recpt_activated):
2852 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2853 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2854 (modest_msg_view_search_next):
2855 * src/widgets/modest-recpt-editor.c:
2856 (modest_recpt_editor_on_button_release_event),
2857 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2858 g_message(). At this point we should only be seeing interesting errors on
2859 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2861 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2863 (modest_wizard_dialog_force_title_update):
2864 * src/maemo/easysetup/modest-wizard-dialog.h:
2865 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2866 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2867 can update the title when appropriate. Otherwise the title is wrong if the
2868 pages are added after adding the notebook to the dialog.
2869 This must be a problem in HildonWizardDialog too.
2870 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2872 * src/maemo/easysetup/modest-easysetup-wizard.c:
2873 (create_subsequent_customsetup_pages),
2874 (create_subsequent_easysetup_pages):
2875 Call modest_wizard_dialog_force_title_update() so that the title is
2876 correct even with GTK+ < 2.10.
2877 This fixes projects.maemo.org bug NB#56145 .
2879 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2881 * src/maemo/modest-platform.c:
2882 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2883 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2886 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2888 * src/widgets/modest-window.h:
2889 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2890 and modest_window_save_state(), which invokes it.
2892 * src/widgets/modest-window-mgr.h:
2893 * src/widgets/modest-window-mgr.c:
2894 Added modest_window_mgr_save_state_for_all_windows(), which calls
2895 the save_state vfunc on all registered windows, if implemented.
2897 * src/gnome/modest-msg-edit-window.c:
2898 * src/gnome/modest-msg-view-window.c:
2899 * src/maemo/modest-msg-edit-window.c:
2900 * src/maemo/modest-msg-view-window.c:
2901 * src/maemo/modest-main-window.c:
2902 Specify the existing save_settings functions as implementations of
2903 ModestWindow::save_state_func().
2905 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2906 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2907 enabling hibernation, for instance.
2909 We may need to do the same thing for restoring settings.
2912 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2914 * src/widgets/modest-window-mgr.c:
2915 * src/widgets/modest-window-mgr.h:
2916 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2917 modest_window_mgr_get_hibernation_is_prevented().
2919 * src/maemo/modest-main-window.c:
2920 (on_hildon_program_is_topmost_notify): Prevent hibernation
2921 (possible when the application goes to the background in the WM),
2922 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2924 * src/maemo/easysetup/modest-easysetup-wizard.c:
2925 (modest_easysetup_wizard_dialog_init):
2926 * src/maemo/modest-account-settings-dialog.c:
2927 (modest_account_settings_dialog_init):
2928 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2929 (modest_connection_specific_smtp_edit_window_init):
2930 * src/maemo/modest-connection-specific-smtp-window.c:
2931 (modest_connection_specific_smtp_window_init):
2932 * src/maemo/modest-signature-editor-dialog.c:
2933 (modest_signature_editor_dialog_init):
2934 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2935 prevent hibernation while any of these account settings dialogs are open.
2937 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2939 * src/maemo/Makefile.am:
2940 * src/maemo/modest-osso-state-saving.c:
2941 * src/maemo/modest-osso-state-saving.h: Added
2942 modest_osso_load_state() and modest_osso_save_state() though they do
2943 nothing now. They should iterate through all the open windows and load/save
2945 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2946 save state when closing.
2948 * src/maemo/modest-main-window.c:
2949 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2950 Add a notification handler for the HildonProgram::is-topmost property,
2951 so we can allow hibernation when the application goes into the background.
2952 But we still need to detect when the accounts setup windows are open so
2953 we can stop hibernation when they are open.
2954 To do this, I also added the main window the HildonProgram. This might have
2955 other side-effects/benefits, and should maybe be done for other windows.
2957 * src/maemo/modest-osso-autosave-callbacks.h:
2958 * src/maemo/modest-osso-autosave-callbacks.c:
2959 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2960 though it does not do anything yet, and we might never need this to do
2961 anything. For instance, we already save drafts.
2963 * src/maemo/modest-platform.c: (modest_platform_init):
2964 Specify the libosso auto-save callback.
2966 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2968 * src/maemo/modest-platform.c:
2969 (modest_platform_set_update_interval):
2970 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2971 aparently stays valid between application instances, so we can use this
2972 to remove and reset it later. According to a maemo-developers email from
2975 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2977 * configure.ac: Depend on libalarm for Maemo.
2979 * src/dbus_api/modest-dbus-api.h:
2980 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2981 (on_send_receive), (modest_dbus_req_handler):
2982 Handle a SEND_RECEIVE D-Bus method.
2984 * libmodest-dbus-client/libmodest-dbus-client.c:
2985 (libmodest_dbus_client_send_and_receive):
2986 * libmodest-dbus-client/libmodest-dbus-client.h:
2987 Add C convenience functions for calling the new D-Bus method.
2989 * src/modest-platform.h:
2990 * src/gnome/modest-platform.c:
2991 * src/maemo/modest-platform.c:
2992 Added modest_platform_set_update_interval(), which uses the
2993 alarmd API on Maemo.
2994 (modest_platform_init),
2995 Call modest_platform_set_update_interval(), using a hard-coded
2996 interval for now (until the global settings dialog is implemented),
2997 though I am not sure that this makes sense yet.
2999 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3001 * src/dbus_api/modest-dbus-callbacks.c:
3002 (modest_osso_cb_hw_state_handler):
3003 * src/dbus_api/modest-dbus-callbacks.h:
3004 * src/maemo/modest-platform.c: (modest_platform_init):
3005 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3006 in case this has some effect on the ability for Maemo to ping the
3009 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3011 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3012 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3013 warning. It is probably a logic error, but I need to fix the build.
3015 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3017 * src/modest-account-mgr.h:
3018 * src/modest-account-mgr.c:
3019 (modest_account_mgr_account_names): Add a gboolean enabled_only
3020 parameter, so we can get lists of onlt the enabled accounts.
3022 (modest_account_mgr_add_account),,
3023 (modest_account_mgr_account_with_display_name_exists):
3024 * src/maemo/modest-msg-edit-window.c: (get_transports):
3025 * src/modest-account-mgr-helpers.c:
3026 (modest_account_mgr_set_first_account_as_default):
3027 * src/modest-init.c: (init_default_account_maybe):
3028 * src/modest-tny-account-store.c: (get_accounts):
3029 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3030 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3031 * tests/check_account-mgr.c: (START_TEST):
3032 Provide the extra parameter, as appropriate.
3034 * src/widgets/modest-account-view.c: (update_account_view):
3035 Do not show disabled accounts (meaning that there is no way to
3036 enable/disable accounts in the UI (the feature is not in our UI
3037 specification), so we can use this internally only to mark unfinished
3038 or temporary account data.
3040 * src/maemo/easysetup/modest-easysetup-wizard.c:
3041 (create_account): Add boolean enable parameter, so we can specify FALSE
3042 to create the temporary account.
3043 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3044 (on_before_next): When finishing, when there is a temporary account, just
3046 Also, use a timeout to delay the showing of the dialog until gconf is likely
3047 to return correct information, due to a maemo gconf bug that is fixed in
3048 osso 1.1, but not yet in Bora.
3049 However, the dialog stays on screen after it is destroyed.
3051 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3052 for invalid data when cancelling. Use a hildon note instead of a dialog
3053 to complain about invalid data. Do not show the account-saved note if the
3054 account is disabled (a temporary account that will not really be saved for use
3057 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3059 * src/modest-account-mgr-helpers.h:
3060 * src/modest-account-mgr-helpers.c:
3061 Added modest_account_mgr_unset_default_account(),
3062 Added modest_account_mgr_set_first_account_as_default().
3064 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3065 If it was the default account, unset the default account name.
3067 * src/maemo/modest-account-view-window.c:
3068 (on_delete_button_clicked): If it was the default account,
3069 set the first remaining account as the default instead.
3071 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3072 a NULL account or a NULL default account, to prevent a crash. This should
3073 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3076 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3078 * src/widgets/modest-recpt-editor.c:
3079 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3080 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3081 TODO comment for this. This fixes the build.
3083 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3084 be the best place for it. This will in future update all auto-update accounts,
3085 rather than just the current/default account, when that gconf key exists.
3086 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3087 if there are no accounts, before calling do_send_receive().
3088 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3090 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3091 * src/maemo/modest-main-window-ui.h:
3092 * src/maemo/modest-main-window.c: (on_connection_changed),
3093 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3094 directly, becaue the signal handler does more.
3096 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3098 * src/modest-account-mgr-helpers.c:
3099 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3100 for the case that the account does not exist.
3102 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3103 (equivalent to the modest account name) rather than the tinymail account name
3104 (equivalent to the modest account title - human readable) to get the account data.
3105 Check for null account data to prevent the crash, and add a TODO comment saying that
3106 this needs fixing because it is using the server account name instead of the account name.
3108 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3110 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3111 * src/maemo/modest-account-settings-dialog.c: (show_error),
3113 Use hildon_note_new_information() for informative and error messages,
3114 which seems to be expected for Maemo applications (no documentation that I know of
3115 says this). I am surprised that there is no distinction between info and error
3118 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3120 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3121 it is easy to find where this is used.
3123 * src/maemo/easysetup/modest-easysetup-wizard.c:
3124 (create_page_welcome), (create_page_account_details),
3125 (create_page_user_details), (create_page_complete_easysetup),
3126 (create_page_custom_incoming), (create_page_custom_outgoing),
3127 (create_page_complete_custom):
3128 * src/maemo/modest-account-settings-dialog.c:
3129 (create_page_account_details), (create_page_user_details),
3130 (create_page_incoming), (create_page_outgoing):
3131 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3132 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3133 (modest_connection_specific_smtp_edit_window_init):
3134 * src/maemo/modest-connection-specific-smtp-window.c:
3135 (modest_connection_specific_smtp_window_init):
3136 * src/maemo/modest-signature-editor-dialog.c:
3137 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3138 and scrolling policy as per the Email Application Layout Guide, if I have
3141 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3143 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3144 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3145 which were empty, because these vfuncs have been removed from TnyAccountStore.
3146 This fixes the build.
3148 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3150 * src/maemo/modest-main-window.c:
3151 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3152 showing/hiding it. Added TODO because it probably should not be NULL.
3153 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3154 because unnecessary g_warnings() make degugging difficult.
3156 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3158 * src/maemo/modest-msg-edit-window.c:
3159 (modest_msg_edit_window_select_color),
3160 (modest_msg_edit_window_select_background_color): 2 const corrections and
3161 moving 2 #endifs before closing brackets, to fix the build.
3163 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3165 * src/maemo/easysetup/modest-easysetup-wizard.h:
3166 * src/maemo/easysetup/modest-easysetup-wizard.c:
3167 (modest_easysetup_wizard_dialog_finalize),
3168 (on_button_edit_advanced_settings), (create_page_complete_custom),
3169 (on_response), (create_account):
3170 Implement the Advanced Settings edit button, by saving the account information,
3171 for the Advanded Settings dialog to use directly from gconf, and removing it
3172 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3173 Bug #5533 in the projects.maemo.org bugzilla.
3175 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3177 * src/maemo/modest-msg-view-window.c:
3178 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3179 when opening a message window.
3181 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3183 * src/maemo/easysetup/modest-easysetup-wizard.c:
3184 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3187 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3188 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3189 gconf settings. I probably added more checks than necessary, but that is safer.
3191 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3192 variable to fix the build, but this seems to be used when it is still NULL.
3194 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3196 * src/modest-platform.h:
3197 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3198 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3199 * src/modest-main.c: Implement this function so we can avoid using
3200 maemo-specific API from cross-platform code.
3202 * src/modest-tny-account-store.c:
3203 (get_smtp_specific_transport_account_for_open_connection):
3204 * src/modest-ui-actions.c: (check_for_connection),
3205 (modest_ui_actions_on_item_not_found):
3206 Use modest_platform_connect_and_wait() and put #idefs around other
3207 maemo-specific code, because only maemo currently has a way to
3208 identify connection names.
3210 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3212 * src/modest-tny-account-store.h:
3213 * src/modest-tny-account-store.c:
3214 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3215 the connection-specific SMTP server settings in the configuration.
3217 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3219 * src/maemo/modest-main-window.c: (on_connection_changed),
3221 * src/modest-main.c: (main), (start_ui), (send_mail):
3222 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3223 that is what is intended.
3225 * src/modest-ui-actions.c: (action_send), (action_receive),
3226 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3227 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3228 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3229 SMTP server is used when it is specified.
3231 (modest_ui_actions_on_send_receive):
3232 Check that a connection is open before proceeding.
3233 Receive and then send, instead of vice-versa, as per the specification.
3235 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3237 * src/modest-mail-operation.c:
3238 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3239 though I guess it should be something other than NULL.
3241 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3243 * src/maemo/easysetup/modest-easysetup-wizard.c:
3244 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3245 combo twice, to avoid an g_warning and to make it visible again.
3246 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3247 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3248 (already intended) dereference when detaching, because we then recreate the menu.
3249 But I am not sure why the warning was happening, and it is possible that this is a memory
3252 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3254 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3255 and uri_parse_mailto() utility functions.
3256 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3258 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3260 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3262 * src/dbus_api/modest-dbus-api.h:
3263 * src/dbus_api/modest-dbus-callbacks.c:
3264 Use an idle callback to execute the modest code in the application's own thread.
3265 Remove the helloworld example method.
3266 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3267 parsed, and the open-message method is not implemented because this is not yet implemented in
3269 * libmodest-dbus-client/libmodest-dbus-client.c:
3270 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3271 (libmodest_dbus_client_open_message):
3272 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3274 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3275 body without crashing.
3277 * tests/dbus_api/Makefile.am:
3278 * tests/dbus_api/test_mail_to.c:
3279 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3281 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3283 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3284 Added file to fix the build. Sorry.
3286 * src/dbus_api/Makefile.am:
3287 * src/dbus_api/modest-dbus-api.h:
3288 * src/dbus_api/modest-dbus-callbacks.h:
3289 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3290 (modest_dbus_req_handler):
3291 Put constants in a separate header so it can be reused by the
3292 client library, without duplication
3294 * libmodest-dbus-client/Makefile.am:
3295 * libmodest-dbus-client/libmodest-dbus-client.c:
3296 (libmodest_dbus_client_call_helloworld),
3297 (libmodfest_dbus_client_send_mail),
3298 (libmodfest_dbus_client_mailto),
3299 (libmodfest_dbus_client_open_message):
3300 * libmodest-dbus-client/libmodest-dbus-client.h:
3301 (Partly) Implement a send_mail D-Bus method.
3303 * tests/dbus_api/Makefile.am:
3304 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3305 the send_email D-Bus method.
3307 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3311 * libmodest-dbus-client/Makefile.am:
3312 * libmodest-dbus-client/libmodest-dbus-client.c:
3313 * libmodest-dbus-client/libmodest-dbus-client.h:
3314 * tests/dbus_api/Makefile.am:
3315 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3316 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3318 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3320 * src/maemo/easysetup/modest-easysetup-wizard.c:
3321 (create_page_account_details):
3322 * src/maemo/modest-account-settings-dialog.c:
3323 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3324 widgets, because this might not be the default in future versions of the Maemo GTK+.
3325 However, I can not not get capitalization to work even in a simple test case.
3327 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3329 * src/maemo/easysetup/modest-easysetup-wizard.c:
3330 (create_page_custom_incoming), (create_page_custom_outgoing):
3331 * src/maemo/modest-account-settings-dialog.c:
3332 (create_page_account_details), (create_page_incoming),
3333 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3334 instead of using gtk_check_button_with_label(), so they are aligned like the other
3335 widgets, as per the UI spec.
3337 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3339 * src/maemo/easysetup/modest-easysetup-wizard.c:
3340 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3341 * src/widgets/modest-validating-entry.c:
3342 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3343 Modest prefix instead of an EasySetup prefix.
3345 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3347 * src/widgets/modest-validating-entry.h:
3348 * src/widgets/modest-validating-entry.c: (on_insert_text),
3349 Added easysetup_validating_entry_set_max_func(), used to set a callback
3350 to call when the max number of characters is reached. GtkEntry has a max-length
3351 already but is silent about it.
3353 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3354 (create_page_account_details), (create_page_user_details),
3356 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3357 (create_page_account_details), (create_page_user_details),
3358 (create_page_outgoing):
3359 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3360 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3361 the UI spec, when the user tries to enter more than the max number of characters.
3363 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3365 * src/maemo/easysetup/modest-easysetup-wizard.c:
3366 (create_page_user_details), (create_page_custom_incoming),
3367 (create_page_custom_outgoing):
3368 * src/maemo/modest-account-settings-dialog.c:
3369 (create_page_user_details), (create_page_incoming),
3370 (create_page_outgoing):
3371 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3372 (modest_connection_specific_smtp_edit_window_init):
3373 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3374 not appropriate. Bad Maemo-specific defaults!.
3376 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3378 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3379 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3380 (modest_signature_editor_dialog_set_settings):
3381 Disable the label and textview when the checkbox is disabled, and use the
3382 specified (UI spec) default signature text.
3384 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3387 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3389 * src/modest-defs.h:
3390 * src/modest-account-mgr-helpers.h:
3391 * src/modest-account-mgr-helpers.c:
3392 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3394 * src/maemo/Makefile.am:
3395 * src/maemo/modest-signature-editor-dialog.c:
3396 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3399 * src/maemo/modest-account-settings-dialog.h:
3400 * src/maemo/modest-account-settings-dialog.c:
3401 (modest_account_settings_dialog_finalize), (on_button_signature),
3402 (save_configuration): Use the new dialog when the Edit button is pressed, and
3403 save the changes if necessary, as per the UI spec.
3405 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3407 * src/maemo/Makefile.am:
3408 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3409 based on maemo-develoers email from Dirk.
3411 * src/maemo/easysetup/modest-easysetup-wizard.c:
3412 (create_page_welcome), (create_page_account_details),
3413 (create_page_user_details), (create_page_complete_easysetup),
3414 (create_page_custom_incoming), (create_page_custom_outgoing),
3415 (create_page_complete_custom),
3416 (modest_easysetup_wizard_dialog_init):
3417 * src/maemo/modest-account-settings-dialog.c:
3418 (create_page_account_details), (create_page_user_details),
3419 (create_page_incoming), (create_page_outgoing),
3420 (modest_account_settings_dialog_init):
3421 * src/maemo/modest-connection-specific-smtp-window.c:
3422 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3424 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3426 * src/maemo/easysetup/modest-easysetup-wizard.c:
3427 (create_page_account_details), (create_page_custom_outgoing),
3428 (create_page_complete_custom):
3429 * src/maemo/modest-account-settings-dialog.c:
3430 (create_page_user_details), (create_page_incoming),
3431 (create_page_outgoing):
3432 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3433 (modest_connection_specific_smtp_edit_window_init):
3434 Use the correct (UI spec) port min/max, and use horizontal separators,
3437 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3439 * src/maemo/easysetup/modest-easysetup-wizard.c:
3440 (set_default_custom_servernames):
3441 * src/maemo/modest-account-settings-dialog.c:
3442 (create_page_incoming), (on_combo_outgoing_security_changed),
3443 (on_combo_incoming_security_changed), (create_page_outgoing),
3444 (modest_account_settings_dialog_set_account_name),
3445 (save_configuration):
3446 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3447 (on_combo_security_changed),
3448 (modest_connection_specific_smtp_edit_window_init),
3449 (modest_connection_specific_smtp_edit_window_set_connection),
3450 (modest_connection_specific_smtp_edit_window_get_settings):
3451 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3454 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3457 * src/maemo/easysetup/modest-easysetup-wizard.c:
3458 (create_page_custom_outgoing), (create_page_complete_custom):
3459 * src/maemo/modest-account-settings-dialog.c:
3460 (create_page_user_details), (create_page_outgoing):
3461 * src/maemo/modest-account-view-window.c: (button_box_new):
3462 Use changed logical IDs as per the most recent UI spec:
3463 mcen_bd_emailsetup_edit -> mcen_bd_edit
3464 mcen_bd_emailsetup_delete -> mcen_bd_delete
3465 mcen_bd_emailsetup_close -> mcen_bd_close
3467 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3471 * src/dbus_api/Makefile.am:
3472 * src/dbus_api/modest-dbus-callbacks.c:
3473 * src/dbus_api/modest-dbus-callbacks.h:
3474 * src/maemo/modest-platform.c: (modest_platform_init):
3475 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3477 * tests/Makefile.am:
3478 * tests/dbus_api/Makefile.am:
3479 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3481 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3483 * src/maemo/modest-account-settings-dialog.c:
3484 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3485 Removed unnecessary includes.
3487 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3489 * src/maemo/easysetup/modest-easysetup-wizard.c:
3490 * src/maemo/modest-account-settings-dialog.c:
3491 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3492 * src/widgets/Makefile.am:
3493 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3494 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3495 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3496 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3497 * src/widgets/modest-secureauth-combo-box.c:
3498 * src/widgets/modest-secureauth-combo-box.h:
3499 * src/widgets/modest-serversecurity-combo-box.c:
3500 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3501 made the GObject names more consistent with the rest of the Modest code.
3503 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3505 * src/maemo/easysetup/Makefile.am:
3506 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3507 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3508 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3509 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3510 * src/maemo/easysetup/modest-easysetup-wizard.c:
3511 * src/maemo/easysetup/modest-validating-entry.c:
3512 * src/maemo/easysetup/modest-validating-entry.h:
3513 * src/maemo/modest-account-settings-dialog.c:
3514 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3515 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3516 widgets/ because they are used outside of easysetup too. After checking in,
3517 svn will allow me to rename them too.
3519 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3521 * src/gnome/modest-msg-edit-window.c:
3522 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3523 linker error, to fix the build on the GNOME platform.
3524 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3525 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3526 ifdefed out to avoid a warning.
3528 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3530 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3531 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3532 some alternative for GTK+ 2.6.
3534 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3536 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3538 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3539 specified for EmailAccountsDialog in UI spec.
3541 * src/maemo/easysetup/modest-easysetup-wizard.c:
3542 * src/maemo/easysetup/modest-easysetup-wizard.h:
3543 * src/maemo/modest-account-settings-dialog.c:
3544 * src/maemo/modest-account-settings-dialog.h:
3545 Reuse a member window widget for the connection-specific SMTP server accounts,
3546 so we can tell it to create/save the accounts only if we actually save changes.
3548 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3549 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3550 (modest_connection_specific_smtp_edit_window_get_settings):
3551 Return a struct instance for temporarily remembering the entered data.
3553 * src/maemo/modest-connection-specific-smtp-window.h:
3554 * src/maemo/modest-connection-specific-smtp-window.c:
3555 (modest_connection_specific_smtp_window_finalize),
3556 (modest_connection_specific_smtp_window_fill_with_connections),
3558 (modest_connection_specific_smtp_window_save_server_accounts),
3559 (update_model_server_names): Do not actually save data until asked,
3560 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3562 (on_selection_changed),
3563 (modest_connection_specific_smtp_window_init): Disable the edit
3564 button when nothing is selected.
3566 * src/modest-account-mgr-helpers.c:
3567 * src/modest-account-mgr-helpers.h:
3568 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3571 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3573 * src/modest-account-mgr-helpers.h:
3574 * src/modest-account-mgr-helpers.c:
3575 (modest_account_mgr_get_unused_account_name),
3576 (modest_account_mgr_get_unused_account_display_name): Added these
3577 utility functions, to avoid code duplication.
3579 * src/maemo/easysetup/modest-easysetup-wizard.c:
3580 (create_page_account_details), (create_account):
3581 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3582 (on_combo_security_changed),
3583 (modest_connection_specific_smtp_edit_window_init),
3584 (modest_connection_specific_smtp_edit_window_save_settings):
3585 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3586 * src/maemo/modest-connection-specific-smtp-window.c:
3587 (modest_connection_specific_smtp_window_finalize),
3588 (modest_connection_specific_smtp_window_fill_with_connections),
3589 (on_button_edit), (modest_connection_specific_smtp_window_init):
3590 * src/maemo/modest-connection-specific-smtp-window.h:
3591 Implementing saving of connection-specific server accounts.
3593 But I need to refactor this so we can save the data for each
3594 possible connection-specific account and only actually create the server accounts
3595 when the easysetup finished, or the OK button is pressed on the account settings
3598 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3600 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3601 (on_combo_security_changed):
3602 (modest_connection_specific_smtp_edit_window_init):
3603 Auto-fill the port number as in the account settings.
3605 (modest_connection_specific_smtp_edit_window_set_connection):
3606 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3607 * src/maemo/modest-connection-specific-smtp-window.c:
3608 (fill_with_connections), (on_button_edit),
3609 (modest_connection_specific_smtp_window_init):
3610 Turn the edit window into a dialog to simplify the code, and
3611 set a WM hint as in a GtkDialog, because only a popup can be on top of
3612 another window in Maemo, and popups usually have no WM decoration.
3614 * src/modest-defs.h:
3615 * src/modest-account-mgr-helpers.c:
3616 (modest_account_mgr_set_connection_specific_smtp),
3617 (modest_account_mgr_remove_connection_specific_smtp),
3618 (modest_account_mgr_get_connection_specific_smtp):
3619 * src/modest-account-mgr-helpers.h: Some functions to write the
3620 connection-specific SMTP server information. Not yet used.
3623 * src/widgets/modest-folder-view.c: (text_cell_data):
3624 Fix a warning about an uninitialized variable.
3625 (on_configuration_key_changed): Put an #ifdef around the use
3626 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3628 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3630 * src/maemo/modest-account-settings-dialog.h:
3631 * src/maemo/modest-account-settings-dialog.c:
3632 Added connect_for_modified() utility function to mark the new modified boolean.
3634 (create_page_account_details), (create_page_user_details),
3635 (create_page_incoming), (create_page_outgoing), (on_response),
3636 (modest_account_settings_dialog_init),
3637 (modest_account_settings_dialog_set_account_name):
3638 Only warn about unsaved changes when there are actually unsaved changes.
3640 * src/modest-account-mgr-helpers.c:
3641 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3642 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3643 to get the data from there in future.
3645 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3647 * src/modest-defs.h:
3649 * src/modest-account-mgr-helpers.h:
3650 * src/modest-account-mgr-helpers.c:
3651 Store the security account setting in a single conf key instead of using
3652 the options list, so that the list is left for just the to-be-removed camel hack,
3653 and because gconf_client_set_list() is failing for some reason.
3655 * src/modest-account-mgr.c:
3656 (modest_account_mgr_add_server_account):
3657 * src/maemo/modest-account-settings-dialog.c:
3658 (modest_account_settings_dialog_set_account_name),
3659 (save_configuration): Use the renamed functions.
3662 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3664 * src/widgets/Makefile.am:
3665 * src/widgets/modest-limit-retrieve-combo-box.c:
3666 * src/widgets/modest-limit-retrieve-combo-box.h:
3667 * src/widgets/modest-retrieve-combo-box.c:
3668 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3669 the account settings dialog.
3671 * src/modest-defs.h:
3672 * src/modest-account-mgr-helpers.h:
3673 * src/modest-account-mgr-helpers.c:
3674 (modest_server_account_get_option_secure_auth),
3675 (modest_server_account_set_option_secure_auth):
3676 * src/modest-account-mgr.c:
3677 (modest_account_mgr_add_server_account):
3678 Use the existing AUTH_MECH conf key for the secure-auth setting,
3679 instead of putting it in the list options, because this was actually used already.
3681 * src/maemo/modest-account-settings-dialog.c:
3682 (create_page_account_details),
3683 (modest_account_settings_dialog_set_account_name),
3684 (save_configuration):
3685 * src/maemo/modest-account-settings-dialog.h:
3686 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3687 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3689 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3691 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3692 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3693 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3695 * src/modest-defs.h:
3696 * src/maemo/modest-account-settings-dialog.c:
3697 (create_page_incoming), (on_combo_outgoing_security_changed),
3698 (on_combo_incoming_security_changed), (create_page_outgoing),
3699 (modest_account_settings_dialog_set_account_name),
3700 (save_configuration): Load/Save the port number, and change it when the
3701 security combo changes, to suitable defaults.
3703 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3705 * src/modest-account-mgr.c:
3706 (modest_account_mgr_add_server_account): Set the security and secure-auth
3707 options, and add a comment saying that the other camel-specific options should be
3710 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3712 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3714 * src/modest-tny-account-store.c: (account_list_free),
3715 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3716 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3719 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3721 * src/modest-protocol-info.c:
3722 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3723 is required by our UI spec. Maybe something in our implementation will use this eventually.
3724 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3725 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3726 instead of the previous 0 placeholder.
3728 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3729 secure-auth settings.
3730 * src/modest-account-mgr-helpers.h:
3731 * src/modest-account-mgr-helpers.c:
3732 (modest_server_account_data_get_option_secure_auth),
3733 (modest_server_account_set_option_secure_auth),
3734 (modest_server_account_data_get_option_security),
3735 (modest_server_account_set_option_security): Added this API for getting and setting the security
3736 and secure-auth settings.
3738 * src/maemo/modest-account-settings-dialog.h:
3739 * src/maemo/modest-account-settings-dialog.c:
3740 (modest_account_settings_dialog_finalize), (check_data),
3741 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3742 about changing titles.
3743 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3744 (save_configuration): Save the security and secure-auth settings.
3746 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3747 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3749 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3751 * src/modest-defs.h:
3752 * src/modest-account-mgr.c:
3753 (modest_account_mgr_add_server_account):
3754 Added and used defines for the options key and value pair strings,
3755 that are used so far, though they do not seem to correspond to anything in our
3756 UI specs or ModestProtocol enum.
3758 * src/modest-account-mgr-helpers.h:
3759 * src/modest-account-mgr-helpers.c:
3760 (compare_option_strings_for_name),
3761 (modest_server_account_data_get_option_value),
3762 (modest_server_account_data_get_option_bool),
3763 (modest_account_mgr_get_server_account_option):
3764 Added helper functions for parsing the options GSList.
3766 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3768 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3769 display name is based on the supplied account name.
3770 * src/modest-account-mgr.c:
3771 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3772 with an inefficient, but good-enough, implementation.
3774 * src/maemo/easysetup/modest-easysetup-wizard.c:
3775 (create_page_account_details), (on_before_next), (create_account):
3776 Check for existing display names rather than (non-user-visible) account names, and just
3777 create and set a unique account name at the end.
3779 * src/maemo/modest-account-settings-dialog.c:
3780 (modest_account_settings_dialog_init),
3781 (modest_account_settings_dialog_set_account_name),
3782 (create_page_incoming): Show the display name, instead of the account name.
3783 (on_response): Do some (not all) extra checks, as in the UI spec.
3784 (save_configuration): Save the display name if it was changed.
3786 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3788 * po/en_GB.po: Added needed logical ID and translation.
3789 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3790 (init_view): Made the is-default column clicking work.
3792 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3795 * src/maemo/easysetup/Makefile.am:
3796 * src/maemo/easysetup/modest-easysetup-wizard.c:
3797 (modest_easysetup_wizard_dialog_init):
3798 * src/maemo/easysetup/provider-data-test.keyfile:
3799 * src/maemo/easysetup/provider-data.keyfile:
3800 Moved the provider data file to the new modest-providers-data package and used it from there.
3802 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3804 * src/modest-local-folder-info.c:
3805 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3806 N_() was already used on the static strings, but this just marks it for translation without
3807 using the translation.
3809 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3811 * src/maemo/modest-account-settings-dialog.c:
3812 (create_page_incoming),
3813 (modest_account_settings_dialog_set_account_name):
3814 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3815 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3816 I will do this if nobody else gets there first.
3818 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3820 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3821 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3822 save the security stuff.
3824 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3826 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3827 Set the email address and user fullname, which I now see must be
3830 * src/maemo/modest-account-settings-dialog.h:
3831 * src/maemo/modest-account-settings-dialog.c:
3833 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3834 leave-on-server and authentication.
3835 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3838 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3841 * src/maemo/modest-account-settings-dialog.c:
3842 * src/maemo/modest-account-settings-dialog.h:
3843 Most (but not all) of the widgets are now present as specified by the UI spec.
3844 No changes are yet saved, and some details are not properly shown yet.
3846 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3848 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3850 * src/maemo/Makefile.am:
3851 * src/maemo/modest-account-settings-dialog.c:
3852 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3853 an existing account. Doesn't do much yet.
3855 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3856 Open the accounts settings dialog when Edit is clicked.
3858 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3860 * src/maemo/easysetup/Makefile.am:
3861 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3863 * src/maemo/easysetup/modest-easysetup-wizard.c:
3864 (modest_easysetup_wizard_dialog_init):
3865 Try to get the source directory from the build system,
3866 instead of hard-coding "./" into the source code, when opening our local
3867 copies of the configuration files.
3868 But this still fails when opening the wizard from the Accounts window,
3869 maybe because the working directory seems to change at runtime.
3870 So the wizard will fail the second time unless you copy the files into their
3871 proper locations - see the stdout warnings for the paths.
3873 (create_page_account_details),(on_before_next):
3874 Check for existing non-server accounts instead of server accounts,
3875 so the default account name is useful again, and to prevent trying to
3878 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3879 Show the wizard when New is clicked.
3881 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3882 (init_view): Show the column headers, and show the columns that are
3883 specified in the UI specs. However, something in Maemo's GTK+ prevents
3884 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3885 change the default account. This is despite unsetting the special properties.
3887 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3889 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3890 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3891 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3892 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3893 to make that clearer.
3894 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3896 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3898 * src/maemo/modest-account-view-window.c:
3899 (modest_account_view_window_init),
3900 (modest_account_view_window_new):
3901 Use the same buttons as specified in the
3902 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3903 the existing widgets, which never had a chance of working.
3904 Put the ModestAccountView treeview in a scrolled window.
3905 Do not repeat the initialization in both _init() and _new().
3907 * src/widgets/modest-account-view.c: (update_account_view):
3908 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3909 this widget and window shows no accounts.
3911 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3913 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3915 * src/maemo/easysetup/modest-easysetup-wizard.c:
3916 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3917 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3918 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3921 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3922 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3923 accounts exist yet, as in the UI spec.
3925 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3927 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3929 * src/maemo/Makefile.am:
3930 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3931 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3932 New window for editing connection-specific smtp details.
3933 Not fully implemented.
3935 * src/maemo/modest-connection-specific-smtp-window.c:
3936 (modest_connection_specific_smtp_window_finalize) :
3937 unref the tree model.
3938 (on_button_edit): Show the edit window.
3940 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3942 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3945 * src/maemo/Makefile.am:
3946 * src/maemo/modest-connection-specific-smtp-window.c:
3947 * src/maemo/modest-connection-specific-smtp-window.h:
3948 New window for showing the list of connections, for connection-specific
3949 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3950 * src/maemo/easysetup/modest-easysetup-wizard.c:
3951 (create_page_custom_outgoing): Show the new window when the button is clicked.
3953 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3955 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3956 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3957 * src/maemo/modest-msg-edit-window.c:
3958 (modest_msg_edit_window_insert_image):
3959 * src/modest-conf.c: (modest_conf_key_escape):
3960 * src/modest-mail-operation.c:
3961 (modest_mail_operation_send_new_mail):
3962 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3963 (modest_ui_actions_on_new_account):
3964 * src/widgets/modest-attachment-view.c: (update_filename_request):
3965 * src/widgets/modest-mail-header-view.c:
3966 Corrected warnings that were breaking the build, by commenting out unused variables,
3967 and a function, and by including a header.
3969 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3971 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3972 so we can #ifdef around platform-specific code when necessary.
3973 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3974 to allow this to build for the GNOME platform too.
3976 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3978 * src/maemo/easysetup/modest-easysetup-wizard.c:
3979 Added util_increment_name() and used it in create_page_account_details()
3980 to make sure that the default account name is always a new name.
3982 (modest_easysetup_wizard_dialog_init),
3983 (set_default_custom_servernames): Some minor memory management fixes.
3985 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3989 * src/modest-runtime.c: (init_i18n): Restored the translation
3990 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3991 are defined in config.h, and the translations are installed.
3993 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3994 is defined for translation.
3996 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3998 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4000 * src/maemo/easysetup/modest-easysetup-wizard.c:
4001 (modest_easysetup_wizard_dialog_init):
4002 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4003 Use realistic paths (though they should use $prefix generically) to the
4004 mcc_mapping and provider-data.keyfile files which might work when they
4005 are installed by the future version of the operator-wizard package,
4006 and then fallback to paths in our source code, with an explanatory
4009 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4013 * src/maemo/Makefile.am:
4014 * src/maemo/easysetup/: Added files from the previously-exernal
4015 osso-modest-easysetup.
4016 * src/maemo/modest-main-window-ui.h:
4017 * src/modest-ui-actions.c:
4018 * src/modest-ui-actions.h:
4019 Added modest_ui_actions_on_new_account() as a signal handler for the
4020 New Account menu item. It shows the easysetup wizard.
4021 * po/en_GB.po: Added additional needed logical IDs and translations.