1 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3 * configure.ac: Depend on libalarm for Maemo.
5 * src/dbus_api/modest-dbus-api.h:
6 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
7 (on_send_receive), (modest_dbus_req_handler):
8 Handle a SEND_RECEIVE D-Bus method.
10 * libmodest-dbus-client/libmodest-dbus-client.c:
11 (libmodest_dbus_client_send_and_receive):
12 * libmodest-dbus-client/libmodest-dbus-client.h:
13 Add C convenience functions for calling the new D-Bus method.
15 * src/modest-platform.h:
16 * src/gnome/modest-platform.c:
17 * src/maemo/modest-platform.c:
18 Added modest_platform_set_update_interval(), which uses the
20 (modest_platform_init),
21 Call modest_platform_set_update_interval(), using a hard-coded
22 interval for now (until the global settings dialog is implemented),
23 though I am not sure that this makes sense yet.
25 2007-05-02 Murray Cumming <murrayc@murrayc.com>
27 * src/dbus_api/modest-dbus-callbacks.c:
28 (modest_osso_cb_hw_state_handler):
29 * src/dbus_api/modest-dbus-callbacks.h:
30 * src/maemo/modest-platform.c: (modest_platform_init):
31 Registered (empty) callbacks for the osso hardware state D-Bus signals,
32 in case this has some effect on the ability for Maemo to ping the
35 2007-05-02 Murray Cumming <murrayc@murrayc.com>
37 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
38 Comment out an if() that checks a gchar for < 0, causing a build-breaking
39 warning. It is probably a logic error, but I need to fix the build.
41 2007-05-02 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-account-mgr.h:
44 * src/modest-account-mgr.c:
45 (modest_account_mgr_account_names): Add a gboolean enabled_only
46 parameter, so we can get lists of onlt the enabled accounts.
48 (modest_account_mgr_add_account),,
49 (modest_account_mgr_account_with_display_name_exists):
50 * src/maemo/modest-msg-edit-window.c: (get_transports):
51 * src/modest-account-mgr-helpers.c:
52 (modest_account_mgr_set_first_account_as_default):
53 * src/modest-init.c: (init_default_account_maybe):
54 * src/modest-tny-account-store.c: (get_accounts):
55 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
56 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
57 * tests/check_account-mgr.c: (START_TEST):
58 Provide the extra parameter, as appropriate.
60 * src/widgets/modest-account-view.c: (update_account_view):
61 Do not show disabled accounts (meaning that there is no way to
62 enable/disable accounts in the UI (the feature is not in our UI
63 specification), so we can use this internally only to mark unfinished
64 or temporary account data.
66 * src/maemo/easysetup/modest-easysetup-wizard.c:
67 (create_account): Add boolean enable parameter, so we can specify FALSE
68 to create the temporary account.
69 (on_button_edit_advanced_settings): Create the temporary account as disabled.
70 (on_before_next): When finishing, when there is a temporary account, just
72 Also, use a timeout to delay the showing of the dialog until gconf is likely
73 to return correct information, due to a maemo gconf bug that is fixed in
74 osso 1.1, but not yet in Bora.
75 However, the dialog stays on screen after it is destroyed.
77 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
78 for invalid data when cancelling. Use a hildon note instead of a dialog
79 to complain about invalid data. Do not show the account-saved note if the
80 account is disabled (a temporary account that will not really be saved for use
83 2007-04-30 Murray Cumming <murrayc@murrayc.com>
85 * src/modest-account-mgr-helpers.h:
86 * src/modest-account-mgr-helpers.c:
87 Added modest_account_mgr_unset_default_account(),
88 Added modest_account_mgr_set_first_account_as_default().
90 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
91 If it was the default account, unset the default account name.
93 * src/maemo/modest-account-view-window.c:
94 (on_delete_button_clicked): If it was the default account,
95 set the first remaining account as the default instead.
97 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
98 a NULL account or a NULL default account, to prevent a crash. This should
99 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
102 2007-04-30 Murray Cumming <murrayc@murrayc.com>
104 * src/widgets/modest-recpt-editor.c:
105 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
106 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
107 TODO comment for this. This fixes the build.
109 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
110 be the best place for it. This will in future update all auto-update accounts,
111 rather than just the current/default account, when that gconf key exists.
112 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
113 if there are no accounts, before calling do_send_receive().
114 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
116 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
117 * src/maemo/modest-main-window-ui.h:
118 * src/maemo/modest-main-window.c: (on_connection_changed),
119 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
120 directly, becaue the signal handler does more.
122 2007-04-30 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-account-mgr-helpers.c:
125 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
126 for the case that the account does not exist.
128 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
129 (equivalent to the modest account name) rather than the tinymail account name
130 (equivalent to the modest account title - human readable) to get the account data.
131 Check for null account data to prevent the crash, and add a TODO comment saying that
132 this needs fixing because it is using the server account name instead of the account name.
134 2007-04-29 Murray Cumming <murrayc@murrayc.com>
136 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
137 * src/maemo/modest-account-settings-dialog.c: (show_error),
139 Use hildon_note_new_information() for informative and error messages,
140 which seems to be expected for Maemo applications (no documentation that I know of
141 says this). I am surprised that there is no distinction between info and error
144 2007-04-29 Murray Cumming <murrayc@murrayc.com>
146 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
147 it is easy to find where this is used.
149 * src/maemo/easysetup/modest-easysetup-wizard.c:
150 (create_page_welcome), (create_page_account_details),
151 (create_page_user_details), (create_page_complete_easysetup),
152 (create_page_custom_incoming), (create_page_custom_outgoing),
153 (create_page_complete_custom):
154 * src/maemo/modest-account-settings-dialog.c:
155 (create_page_account_details), (create_page_user_details),
156 (create_page_incoming), (create_page_outgoing):
157 * src/maemo/modest-account-view-window.c: (window_vbox_new):
158 * src/maemo/modest-connection-specific-smtp-edit-window.c:
159 (modest_connection_specific_smtp_edit_window_init):
160 * src/maemo/modest-connection-specific-smtp-window.c:
161 (modest_connection_specific_smtp_window_init):
162 * src/maemo/modest-signature-editor-dialog.c:
163 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
164 and scrolling policy as per the Email Application Layout Guide, if I have
167 2007-04-27 Murray Cumming <murrayc@murrayc.com>
169 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
170 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
171 which were empty, because these vfuncs have been removed from TnyAccountStore.
172 This fixes the build.
174 2007-04-27 Murray Cumming <murrayc@murrayc.com>
176 * src/maemo/modest-main-window.c:
177 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
178 showing/hiding it. Added TODO because it probably should not be NULL.
179 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
180 because unnecessary g_warnings() make degugging difficult.
182 2007-04-27 Murray Cumming <murrayc@murrayc.com>
184 * src/maemo/modest-msg-edit-window.c:
185 (modest_msg_edit_window_select_color),
186 (modest_msg_edit_window_select_background_color): 2 const corrections and
187 moving 2 #endifs before closing brackets, to fix the build.
189 2007-04-27 Murray Cumming <murrayc@murrayc.com>
191 * src/maemo/easysetup/modest-easysetup-wizard.h:
192 * src/maemo/easysetup/modest-easysetup-wizard.c:
193 (modest_easysetup_wizard_dialog_finalize),
194 (on_button_edit_advanced_settings), (create_page_complete_custom),
195 (on_response), (create_account):
196 Implement the Advanced Settings edit button, by saving the account information,
197 for the Advanded Settings dialog to use directly from gconf, and removing it
198 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
199 Bug #5533 in the projects.maemo.org bugzilla.
201 2007-04-27 Murray Cumming <murrayc@murrayc.com>
203 * src/maemo/modest-msg-view-window.c:
204 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
205 when opening a message window.
207 2007-04-27 Murray Cumming <murrayc@murrayc.com>
209 * src/maemo/easysetup/modest-easysetup-wizard.c:
210 (create_page_custom_outgoing): Correct the position of the horizontal separator to
213 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
214 before showing/hiding them, to avoid a crash when clicking on folders when there are no
215 gconf settings. I probably added more checks than necessary, but that is safer.
217 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
218 variable to fix the build, but this seems to be used when it is still NULL.
220 2007-04-27 Murray Cumming <murrayc@murrayc.com>
222 * src/modest-platform.h:
223 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
224 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
225 * src/modest-main.c: Implement this function so we can avoid using
226 maemo-specific API from cross-platform code.
228 * src/modest-tny-account-store.c:
229 (get_smtp_specific_transport_account_for_open_connection):
230 * src/modest-ui-actions.c: (check_for_connection),
231 (modest_ui_actions_on_item_not_found):
232 Use modest_platform_connect_and_wait() and put #idefs around other
233 maemo-specific code, because only maemo currently has a way to
234 identify connection names.
236 2007-04-27 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-tny-account-store.h:
239 * src/modest-tny-account-store.c:
240 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
241 the connection-specific SMTP server settings in the configuration.
243 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
245 * src/maemo/modest-main-window.c: (on_connection_changed),
247 * src/modest-main.c: (main), (start_ui), (send_mail):
248 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
249 that is what is intended.
251 * src/modest-ui-actions.c: (action_send), (action_receive),
252 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
253 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
254 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
255 SMTP server is used when it is specified.
257 (modest_ui_actions_on_send_receive):
258 Check that a connection is open before proceeding.
259 Receive and then send, instead of vice-versa, as per the specification.
261 2007-04-26 Murray Cumming <murrayc@murrayc.com>
263 * src/modest-mail-operation.c:
264 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
265 though I guess it should be something other than NULL.
267 2007-04-26 Murray Cumming <murrayc@murrayc.com>
269 * src/maemo/easysetup/modest-easysetup-wizard.c:
270 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
271 combo twice, to avoid an g_warning and to make it visible again.
272 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
273 attached before detaching it, to avoid a g_warning, and add comment about the implicit
274 (already intended) dereference when detaching, because we then recreate the menu.
275 But I am not sure why the warning was happening, and it is possible that this is a memory
278 2007-04-25 Murray Cumming <murrayc@murrayc.com>
280 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
281 and uri_parse_mailto() utility functions.
282 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
284 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
286 2007-04-24 Murray Cumming <murrayc@murrayc.com>
288 * src/dbus_api/modest-dbus-api.h:
289 * src/dbus_api/modest-dbus-callbacks.c:
290 Use an idle callback to execute the modest code in the application's own thread.
291 Remove the helloworld example method.
292 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
293 parsed, and the open-message method is not implemented because this is not yet implemented in
295 * libmodest-dbus-client/libmodest-dbus-client.c:
296 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
297 (libmodest_dbus_client_open_message):
298 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
300 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
301 body without crashing.
303 * tests/dbus_api/Makefile.am:
304 * tests/dbus_api/test_mail_to.c:
305 * tests/dbus_api/test_open_message.c: New tests for the new methods.
307 2007-04-24 Murray Cumming <murrayc@murrayc.com>
309 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
310 Added file to fix the build. Sorry.
312 * src/dbus_api/Makefile.am:
313 * src/dbus_api/modest-dbus-api.h:
314 * src/dbus_api/modest-dbus-callbacks.h:
315 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
316 (modest_dbus_req_handler):
317 Put constants in a separate header so it can be reused by the
318 client library, without duplication
320 * libmodest-dbus-client/Makefile.am:
321 * libmodest-dbus-client/libmodest-dbus-client.c:
322 (libmodest_dbus_client_call_helloworld),
323 (libmodfest_dbus_client_send_mail),
324 (libmodfest_dbus_client_mailto),
325 (libmodfest_dbus_client_open_message):
326 * libmodest-dbus-client/libmodest-dbus-client.h:
327 (Partly) Implement a send_mail D-Bus method.
329 * tests/dbus_api/Makefile.am:
330 * tests/dbus_api/test_send_mail.c: (main): Added a test for
331 the send_email D-Bus method.
333 2007-04-24 Murray Cumming <murrayc@murrayc.com>
337 * libmodest-dbus-client/Makefile.am:
338 * libmodest-dbus-client/libmodest-dbus-client.c:
339 * libmodest-dbus-client/libmodest-dbus-client.h:
340 * tests/dbus_api/Makefile.am:
341 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
342 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
344 2007-04-24 Murray Cumming <murrayc@murrayc.com>
346 * src/maemo/easysetup/modest-easysetup-wizard.c:
347 (create_page_account_details):
348 * src/maemo/modest-account-settings-dialog.c:
349 (create_page_account_details): Explicitly set auto-capitalization mode for the title
350 widgets, because this might not be the default in future versions of the Maemo GTK+.
351 However, I can not not get capitalization to work even in a simple test case.
353 2007-04-24 Murray Cumming <murrayc@murrayc.com>
355 * src/maemo/easysetup/modest-easysetup-wizard.c:
356 (create_page_custom_incoming), (create_page_custom_outgoing):
357 * src/maemo/modest-account-settings-dialog.c:
358 (create_page_account_details), (create_page_incoming),
359 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
360 instead of using gtk_check_button_with_label(), so they are aligned like the other
361 widgets, as per the UI spec.
363 2007-04-24 Murray Cumming <murrayc@murrayc.com>
365 * src/maemo/easysetup/modest-easysetup-wizard.c:
366 * src/maemo/modest-connection-specific-smtp-edit-window.c:
367 * src/widgets/modest-validating-entry.c:
368 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
369 Modest prefix instead of an EasySetup prefix.
371 2007-04-23 Murray Cumming <murrayc@murrayc.com>
373 * src/widgets/modest-validating-entry.h:
374 * src/widgets/modest-validating-entry.c: (on_insert_text),
375 Added easysetup_validating_entry_set_max_func(), used to set a callback
376 to call when the max number of characters is reached. GtkEntry has a max-length
377 already but is silent about it.
379 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
380 (create_page_account_details), (create_page_user_details),
382 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
383 (create_page_account_details), (create_page_user_details),
384 (create_page_outgoing):
385 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
386 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
387 the UI spec, when the user tries to enter more than the max number of characters.
389 2007-04-23 Murray Cumming <murrayc@murrayc.com>
391 * src/maemo/easysetup/modest-easysetup-wizard.c:
392 (create_page_user_details), (create_page_custom_incoming),
393 (create_page_custom_outgoing):
394 * src/maemo/modest-account-settings-dialog.c:
395 (create_page_user_details), (create_page_incoming),
396 (create_page_outgoing):
397 * src/maemo/modest-connection-specific-smtp-edit-window.c:
398 (modest_connection_specific_smtp_edit_window_init):
399 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
400 not appropriate. Bad Maemo-specific defaults!.
402 2007-04-23 Murray Cumming <murrayc@murrayc.com>
404 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
405 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
406 (modest_signature_editor_dialog_set_settings):
407 Disable the label and textview when the checkbox is disabled, and use the
408 specified (UI spec) default signature text.
410 2007-04-23 Murray Cumming <murrayc@murrayc.com>
412 * src/maemo/modest-connection-specific-smtp-edit-window.c:
413 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
416 * src/modest-account-mgr-helpers.h:
417 * src/modest-account-mgr-helpers.c:
418 Added modest_account_mgr_get/set_signature(), using new gconf keys.
420 * src/maemo/Makefile.am:
421 * src/maemo/modest-signature-editor-dialog.c:
422 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
425 * src/maemo/modest-account-settings-dialog.h:
426 * src/maemo/modest-account-settings-dialog.c:
427 (modest_account_settings_dialog_finalize), (on_button_signature),
428 (save_configuration): Use the new dialog when the Edit button is pressed, and
429 save the changes if necessary, as per the UI spec.
431 2007-04-23 Murray Cumming <murrayc@murrayc.com>
433 * src/maemo/Makefile.am:
434 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
435 based on maemo-develoers email from Dirk.
437 * src/maemo/easysetup/modest-easysetup-wizard.c:
438 (create_page_welcome), (create_page_account_details),
439 (create_page_user_details), (create_page_complete_easysetup),
440 (create_page_custom_incoming), (create_page_custom_outgoing),
441 (create_page_complete_custom),
442 (modest_easysetup_wizard_dialog_init):
443 * src/maemo/modest-account-settings-dialog.c:
444 (create_page_account_details), (create_page_user_details),
445 (create_page_incoming), (create_page_outgoing),
446 (modest_account_settings_dialog_init):
447 * src/maemo/modest-connection-specific-smtp-window.c:
448 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
450 2007-04-23 Murray Cumming <murrayc@murrayc.com>
452 * src/maemo/easysetup/modest-easysetup-wizard.c:
453 (create_page_account_details), (create_page_custom_outgoing),
454 (create_page_complete_custom):
455 * src/maemo/modest-account-settings-dialog.c:
456 (create_page_user_details), (create_page_incoming),
457 (create_page_outgoing):
458 * src/maemo/modest-connection-specific-smtp-edit-window.c:
459 (modest_connection_specific_smtp_edit_window_init):
460 Use the correct (UI spec) port min/max, and use horizontal separators,
463 2007-04-23 Murray Cumming <murrayc@murrayc.com>
465 * src/maemo/easysetup/modest-easysetup-wizard.c:
466 (set_default_custom_servernames):
467 * src/maemo/modest-account-settings-dialog.c:
468 (create_page_incoming), (on_combo_outgoing_security_changed),
469 (on_combo_incoming_security_changed), (create_page_outgoing),
470 (modest_account_settings_dialog_set_account_name),
471 (save_configuration):
472 * src/maemo/modest-connection-specific-smtp-edit-window.c:
473 (on_combo_security_changed),
474 (modest_connection_specific_smtp_edit_window_init),
475 (modest_connection_specific_smtp_edit_window_set_connection),
476 (modest_connection_specific_smtp_edit_window_get_settings):
477 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
480 2007-04-20 Murray Cumming <murrayc@murrayc.com>
483 * src/maemo/easysetup/modest-easysetup-wizard.c:
484 (create_page_custom_outgoing), (create_page_complete_custom):
485 * src/maemo/modest-account-settings-dialog.c:
486 (create_page_user_details), (create_page_outgoing):
487 * src/maemo/modest-account-view-window.c: (button_box_new):
488 Use changed logical IDs as per the most recent UI spec:
489 mcen_bd_emailsetup_edit -> mcen_bd_edit
490 mcen_bd_emailsetup_delete -> mcen_bd_delete
491 mcen_bd_emailsetup_close -> mcen_bd_close
493 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
497 * src/dbus_api/Makefile.am:
498 * src/dbus_api/modest-dbus-callbacks.c:
499 * src/dbus_api/modest-dbus-callbacks.h:
500 * src/maemo/modest-platform.c: (modest_platform_init):
501 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
504 * tests/dbus_api/Makefile.am:
505 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
507 2007-04-20 Murray Cumming <murrayc@murrayc.com>
509 * src/maemo/modest-account-settings-dialog.c:
510 * src/maemo/modest-connection-specific-smtp-edit-window.c:
511 Removed unnecessary includes.
513 2007-04-20 Murray Cumming <murrayc@murrayc.com>
515 * src/maemo/easysetup/modest-easysetup-wizard.c:
516 * src/maemo/modest-account-settings-dialog.c:
517 * src/maemo/modest-connection-specific-smtp-edit-window.c:
518 * src/widgets/Makefile.am:
519 * src/widgets/modest-easysetup-secureauth-combo-box.c:
520 * src/widgets/modest-easysetup-secureauth-combo-box.h:
521 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
522 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
523 * src/widgets/modest-secureauth-combo-box.c:
524 * src/widgets/modest-secureauth-combo-box.h:
525 * src/widgets/modest-serversecurity-combo-box.c:
526 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
527 made the GObject names more consistent with the rest of the Modest code.
529 2007-04-20 Murray Cumming <murrayc@murrayc.com>
531 * src/maemo/easysetup/Makefile.am:
532 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
533 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
534 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
535 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
536 * src/maemo/easysetup/modest-easysetup-wizard.c:
537 * src/maemo/easysetup/modest-validating-entry.c:
538 * src/maemo/easysetup/modest-validating-entry.h:
539 * src/maemo/modest-account-settings-dialog.c:
540 * src/maemo/modest-connection-specific-smtp-edit-window.c:
541 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
542 widgets/ because they are used outside of easysetup too. After checking in,
543 svn will allow me to rename them too.
545 2007-04-20 Murray Cumming <murrayc@murrayc.com>
547 * src/gnome/modest-msg-edit-window.c:
548 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
549 linker error, to fix the build on the GNOME platform.
550 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
551 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
552 ifdefed out to avoid a warning.
554 2007-04-20 Murray Cumming <murrayc@murrayc.com>
556 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
557 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
558 some alternative for GTK+ 2.6.
560 2007-04-19 Murray Cumming <murrayc@murrayc.com>
562 * src/maemo/modest-address-book.c: Added include to avoid a warning.
564 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
565 specified for EmailAccountsDialog in UI spec.
567 * src/maemo/easysetup/modest-easysetup-wizard.c:
568 * src/maemo/easysetup/modest-easysetup-wizard.h:
569 * src/maemo/modest-account-settings-dialog.c:
570 * src/maemo/modest-account-settings-dialog.h:
571 Reuse a member window widget for the connection-specific SMTP server accounts,
572 so we can tell it to create/save the accounts only if we actually save changes.
574 * src/maemo/modest-connection-specific-smtp-edit-window.h:
575 * src/maemo/modest-connection-specific-smtp-edit-window.c:
576 (modest_connection_specific_smtp_edit_window_get_settings):
577 Return a struct instance for temporarily remembering the entered data.
579 * src/maemo/modest-connection-specific-smtp-window.h:
580 * src/maemo/modest-connection-specific-smtp-window.c:
581 (modest_connection_specific_smtp_window_finalize),
582 (modest_connection_specific_smtp_window_fill_with_connections),
584 (modest_connection_specific_smtp_window_save_server_accounts),
585 (update_model_server_names): Do not actually save data until asked,
586 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
588 (on_selection_changed),
589 (modest_connection_specific_smtp_window_init): Disable the edit
590 button when nothing is selected.
592 * src/modest-account-mgr-helpers.c:
593 * src/modest-account-mgr-helpers.h:
594 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
597 2007-04-19 Murray Cumming <murrayc@murrayc.com>
599 * src/modest-account-mgr-helpers.h:
600 * src/modest-account-mgr-helpers.c:
601 (modest_account_mgr_get_unused_account_name),
602 (modest_account_mgr_get_unused_account_display_name): Added these
603 utility functions, to avoid code duplication.
605 * src/maemo/easysetup/modest-easysetup-wizard.c:
606 (create_page_account_details), (create_account):
607 * src/maemo/modest-connection-specific-smtp-edit-window.c:
608 (on_combo_security_changed),
609 (modest_connection_specific_smtp_edit_window_init),
610 (modest_connection_specific_smtp_edit_window_save_settings):
611 * src/maemo/modest-connection-specific-smtp-edit-window.h:
612 * src/maemo/modest-connection-specific-smtp-window.c:
613 (modest_connection_specific_smtp_window_finalize),
614 (modest_connection_specific_smtp_window_fill_with_connections),
615 (on_button_edit), (modest_connection_specific_smtp_window_init):
616 * src/maemo/modest-connection-specific-smtp-window.h:
617 Implementing saving of connection-specific server accounts.
619 But I need to refactor this so we can save the data for each
620 possible connection-specific account and only actually create the server accounts
621 when the easysetup finished, or the OK button is pressed on the account settings
624 2007-04-18 Murray Cumming <murrayc@murrayc.com>
626 * src/maemo/modest-connection-specific-smtp-edit-window.c:
627 (on_combo_security_changed):
628 (modest_connection_specific_smtp_edit_window_init):
629 Auto-fill the port number as in the account settings.
631 (modest_connection_specific_smtp_edit_window_set_connection):
632 * src/maemo/modest-connection-specific-smtp-edit-window.h:
633 * src/maemo/modest-connection-specific-smtp-window.c:
634 (fill_with_connections), (on_button_edit),
635 (modest_connection_specific_smtp_window_init):
636 Turn the edit window into a dialog to simplify the code, and
637 set a WM hint as in a GtkDialog, because only a popup can be on top of
638 another window in Maemo, and popups usually have no WM decoration.
641 * src/modest-account-mgr-helpers.c:
642 (modest_account_mgr_set_connection_specific_smtp),
643 (modest_account_mgr_remove_connection_specific_smtp),
644 (modest_account_mgr_get_connection_specific_smtp):
645 * src/modest-account-mgr-helpers.h: Some functions to write the
646 connection-specific SMTP server information. Not yet used.
649 * src/widgets/modest-folder-view.c: (text_cell_data):
650 Fix a warning about an uninitialized variable.
651 (on_configuration_key_changed): Put an #ifdef around the use
652 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
654 2007-04-18 Murray Cumming <murrayc@murrayc.com>
656 * src/maemo/modest-account-settings-dialog.h:
657 * src/maemo/modest-account-settings-dialog.c:
658 Added connect_for_modified() utility function to mark the new modified boolean.
660 (create_page_account_details), (create_page_user_details),
661 (create_page_incoming), (create_page_outgoing), (on_response),
662 (modest_account_settings_dialog_init),
663 (modest_account_settings_dialog_set_account_name):
664 Only warn about unsaved changes when there are actually unsaved changes.
666 * src/modest-account-mgr-helpers.c:
667 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
668 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
669 to get the data from there in future.
671 2007-04-18 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-account-mgr-helpers.h:
676 * src/modest-account-mgr-helpers.c:
677 Store the security account setting in a single conf key instead of using
678 the options list, so that the list is left for just the to-be-removed camel hack,
679 and because gconf_client_set_list() is failing for some reason.
681 * src/modest-account-mgr.c:
682 (modest_account_mgr_add_server_account):
683 * src/maemo/modest-account-settings-dialog.c:
684 (modest_account_settings_dialog_set_account_name),
685 (save_configuration): Use the renamed functions.
688 2007-04-18 Murray Cumming <murrayc@murrayc.com>
690 * src/widgets/Makefile.am:
691 * src/widgets/modest-limit-retrieve-combo-box.c:
692 * src/widgets/modest-limit-retrieve-combo-box.h:
693 * src/widgets/modest-retrieve-combo-box.c:
694 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
695 the account settings dialog.
698 * src/modest-account-mgr-helpers.h:
699 * src/modest-account-mgr-helpers.c:
700 (modest_server_account_get_option_secure_auth),
701 (modest_server_account_set_option_secure_auth):
702 * src/modest-account-mgr.c:
703 (modest_account_mgr_add_server_account):
704 Use the existing AUTH_MECH conf key for the secure-auth setting,
705 instead of putting it in the list options, because this was actually used already.
707 * src/maemo/modest-account-settings-dialog.c:
708 (create_page_account_details),
709 (modest_account_settings_dialog_set_account_name),
710 (save_configuration):
711 * src/maemo/modest-account-settings-dialog.h:
712 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
713 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
715 2007-04-18 Murray Cumming <murrayc@murrayc.com>
717 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
718 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
719 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
722 * src/maemo/modest-account-settings-dialog.c:
723 (create_page_incoming), (on_combo_outgoing_security_changed),
724 (on_combo_incoming_security_changed), (create_page_outgoing),
725 (modest_account_settings_dialog_set_account_name),
726 (save_configuration): Load/Save the port number, and change it when the
727 security combo changes, to suitable defaults.
729 2007-04-17 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-account-mgr.c:
732 (modest_account_mgr_add_server_account): Set the security and secure-auth
733 options, and add a comment saying that the other camel-specific options should be
736 2007-04-17 Murray Cumming <murrayc@murrayc.com>
738 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
740 * src/modest-tny-account-store.c: (account_list_free),
741 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
742 cursor->data after unreffing it. But there is some strange stuff there so it might not be
745 2007-04-17 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-protocol-info.c:
748 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
749 is required by our UI spec. Maybe something in our implementation will use this eventually.
750 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
751 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
752 instead of the previous 0 placeholder.
754 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
755 secure-auth settings.
756 * src/modest-account-mgr-helpers.h:
757 * src/modest-account-mgr-helpers.c:
758 (modest_server_account_data_get_option_secure_auth),
759 (modest_server_account_set_option_secure_auth),
760 (modest_server_account_data_get_option_security),
761 (modest_server_account_set_option_security): Added this API for getting and setting the security
762 and secure-auth settings.
764 * src/maemo/modest-account-settings-dialog.h:
765 * src/maemo/modest-account-settings-dialog.c:
766 (modest_account_settings_dialog_finalize), (check_data),
767 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
768 about changing titles.
769 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
770 (save_configuration): Save the security and secure-auth settings.
772 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
773 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
775 2007-04-17 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-account-mgr.c:
779 (modest_account_mgr_add_server_account):
780 Added and used defines for the options key and value pair strings,
781 that are used so far, though they do not seem to correspond to anything in our
782 UI specs or ModestProtocol enum.
784 * src/modest-account-mgr-helpers.h:
785 * src/modest-account-mgr-helpers.c:
786 (compare_option_strings_for_name),
787 (modest_server_account_data_get_option_value),
788 (modest_server_account_data_get_option_bool),
789 (modest_account_mgr_get_server_account_option):
790 Added helper functions for parsing the options GSList.
792 2007-04-16 Murray Cumming <murrayc@murrayc.com>
794 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
795 display name is based on the supplied account name.
796 * src/modest-account-mgr.c:
797 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
798 with an inefficient, but good-enough, implementation.
800 * src/maemo/easysetup/modest-easysetup-wizard.c:
801 (create_page_account_details), (on_before_next), (create_account):
802 Check for existing display names rather than (non-user-visible) account names, and just
803 create and set a unique account name at the end.
805 * src/maemo/modest-account-settings-dialog.c:
806 (modest_account_settings_dialog_init),
807 (modest_account_settings_dialog_set_account_name),
808 (create_page_incoming): Show the display name, instead of the account name.
809 (on_response): Do some (not all) extra checks, as in the UI spec.
810 (save_configuration): Save the display name if it was changed.
812 2007-04-16 Murray Cumming <murrayc@murrayc.com>
814 * po/en_GB.po: Added needed logical ID and translation.
815 * src/widgets/modest-account-view.c: (on_account_default_toggled),
816 (init_view): Made the is-default column clicking work.
818 2007-04-16 Murray Cumming <murrayc@murrayc.com>
821 * src/maemo/easysetup/Makefile.am:
822 * src/maemo/easysetup/modest-easysetup-wizard.c:
823 (modest_easysetup_wizard_dialog_init):
824 * src/maemo/easysetup/provider-data-test.keyfile:
825 * src/maemo/easysetup/provider-data.keyfile:
826 Moved the provider data file to the new modest-providers-data package and used it from there.
828 2007-04-16 Murray Cumming <murrayc@murrayc.com>
830 * src/modest-local-folder-info.c:
831 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
832 N_() was already used on the static strings, but this just marks it for translation without
833 using the translation.
835 2007-04-06 Murray Cumming <murrayc@murrayc.com>
837 * src/maemo/modest-account-settings-dialog.c:
838 (create_page_incoming),
839 (modest_account_settings_dialog_set_account_name):
840 Added comments about the need for new API in ModestAccountMgr to handle the authentication
841 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
842 I will do this if nobody else gets there first.
844 2007-04-06 Murray Cumming <murrayc@murrayc.com>
846 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
847 Saved much of the incoming and outgoing data too, though I cannot yet see how to
848 save the security stuff.
850 2007-04-06 Murray Cumming <murrayc@murrayc.com>
852 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
853 Set the email address and user fullname, which I now see must be
856 * src/maemo/modest-account-settings-dialog.h:
857 * src/maemo/modest-account-settings-dialog.c:
859 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
860 leave-on-server and authentication.
861 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
864 2007-04-06 Murray Cumming <murrayc@murrayc.com>
867 * src/maemo/modest-account-settings-dialog.c:
868 * src/maemo/modest-account-settings-dialog.h:
869 Most (but not all) of the widgets are now present as specified by the UI spec.
870 No changes are yet saved, and some details are not properly shown yet.
872 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
874 2007-04-06 Murray Cumming <murrayc@murrayc.com>
876 * src/maemo/Makefile.am:
877 * src/maemo/modest-account-settings-dialog.c:
878 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
879 an existing account. Doesn't do much yet.
881 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
882 Open the accounts settings dialog when Edit is clicked.
884 2007-04-05 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/easysetup/Makefile.am:
887 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
889 * src/maemo/easysetup/modest-easysetup-wizard.c:
890 (modest_easysetup_wizard_dialog_init):
891 Try to get the source directory from the build system,
892 instead of hard-coding "./" into the source code, when opening our local
893 copies of the configuration files.
894 But this still fails when opening the wizard from the Accounts window,
895 maybe because the working directory seems to change at runtime.
896 So the wizard will fail the second time unless you copy the files into their
897 proper locations - see the stdout warnings for the paths.
899 (create_page_account_details),(on_before_next):
900 Check for existing non-server accounts instead of server accounts,
901 so the default account name is useful again, and to prevent trying to
904 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
905 Show the wizard when New is clicked.
907 * src/widgets/modest-account-view.c: (on_account_default_toggled),
908 (init_view): Show the column headers, and show the columns that are
909 specified in the UI specs. However, something in Maemo's GTK+ prevents
910 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
911 change the default account. This is despite unsetting the special properties.
913 2007-04-05 Murray Cumming <murrayc@murrayc.com>
915 * docs/reference/modest-design.sgml: Corrected spelling mistake.
916 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
917 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
918 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
919 to make that clearer.
920 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
922 2007-04-05 Murray Cumming <murrayc@murrayc.com>
924 * src/maemo/modest-account-view-window.c:
925 (modest_account_view_window_init),
926 (modest_account_view_window_new):
927 Use the same buttons as specified in the
928 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
929 the existing widgets, which never had a chance of working.
930 Put the ModestAccountView treeview in a scrolled window.
931 Do not repeat the initialization in both _init() and _new().
933 * src/widgets/modest-account-view.c: (update_account_view):
934 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
935 this widget and window shows no accounts.
937 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
939 2007-04-05 Murray Cumming <murrayc@murrayc.com>
941 * src/maemo/easysetup/modest-easysetup-wizard.c:
942 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
943 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
944 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
947 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
948 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
949 accounts exist yet, as in the UI spec.
951 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
953 2007-04-05 Murray Cumming <murrayc@murrayc.com>
955 * src/maemo/Makefile.am:
956 * src/maemo/modest-connection-specific-smtp-edit-window.c:
957 * src/maemo/modest-connection-specific-smtp-edit-window.h:
958 New window for editing connection-specific smtp details.
959 Not fully implemented.
961 * src/maemo/modest-connection-specific-smtp-window.c:
962 (modest_connection_specific_smtp_window_finalize) :
963 unref the tree model.
964 (on_button_edit): Show the edit window.
966 2007-04-05 Murray Cumming <murrayc@murrayc.com>
968 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
971 * src/maemo/Makefile.am:
972 * src/maemo/modest-connection-specific-smtp-window.c:
973 * src/maemo/modest-connection-specific-smtp-window.h:
974 New window for showing the list of connections, for connection-specific
975 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
976 * src/maemo/easysetup/modest-easysetup-wizard.c:
977 (create_page_custom_outgoing): Show the new window when the button is clicked.
979 2007-04-04 Murray Cumming <murrayc@murrayc.com>
981 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
982 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
983 * src/maemo/modest-msg-edit-window.c:
984 (modest_msg_edit_window_insert_image):
985 * src/modest-conf.c: (modest_conf_key_escape):
986 * src/modest-mail-operation.c:
987 (modest_mail_operation_send_new_mail):
988 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
989 (modest_ui_actions_on_new_account):
990 * src/widgets/modest-attachment-view.c: (update_filename_request):
991 * src/widgets/modest-mail-header-view.c:
992 Corrected warnings that were breaking the build, by commenting out unused variables,
993 and a function, and by including a header.
995 2007-04-04 Murray Cumming <murrayc@murrayc.com>
997 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
998 so we can #ifdef around platform-specific code when necessary.
999 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1000 to allow this to build for the GNOME platform too.
1002 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1004 * src/maemo/easysetup/modest-easysetup-wizard.c:
1005 Added util_increment_name() and used it in create_page_account_details()
1006 to make sure that the default account name is always a new name.
1008 (modest_easysetup_wizard_dialog_init),
1009 (set_default_custom_servernames): Some minor memory management fixes.
1011 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1015 * src/modest-runtime.c: (init_i18n): Restored the translation
1016 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1017 are defined in config.h, and the translations are installed.
1019 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1020 is defined for translation.
1022 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1024 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1026 * src/maemo/easysetup/modest-easysetup-wizard.c:
1027 (modest_easysetup_wizard_dialog_init):
1028 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1029 Use realistic paths (though they should use $prefix generically) to the
1030 mcc_mapping and provider-data.keyfile files which might work when they
1031 are installed by the future version of the operator-wizard package,
1032 and then fallback to paths in our source code, with an explanatory
1035 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1039 * src/maemo/Makefile.am:
1040 * src/maemo/easysetup/: Added files from the previously-exernal
1041 osso-modest-easysetup.
1042 * src/maemo/modest-main-window-ui.h:
1043 * src/modest-ui-actions.c:
1044 * src/modest-ui-actions.h:
1045 Added modest_ui_actions_on_new_account() as a signal handler for the
1046 New Account menu item. It shows the easysetup wizard.
1047 * po/en_GB.po: Added additional needed logical IDs and translations.
1049 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1050 Apparently ChangeLog is not used for some vague Nokia legal reasons.