1 2007-07-30 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (on_account_removed),
4 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
5 account is removed from the View menu. We have TnyAccountStore
6 and ModestTnyAccountStore signals that seem very similar, but this
9 * src/maemo/modest-main-window.c:
10 (on_show_account_action_activated): Prevent dereference
11 of a NULL if the accoutn does not really exist, though that
12 should not happen anymore.
14 This fixes projects.maemo.org bug NB#64606.
16 2007-07-30 Murray Cumming <murrayc@murrayc.com>
18 * src/modest-ui-actions.c: (run_account_setup_wizard),
19 (modest_ui_actions_on_accounts): Revert a change that set these
20 to modal dialogs, freezing the UI when they show secondary dialogs.
21 This fixed projects.maemo.org bug NB#64519.
23 2007-07-27 Murray Cumming <murrayc@murrayc.com>
25 * src/widgets/modest-header-view-render.c:
26 (_modest_header_view_compact_header_cell_data):
27 Some checks and initialization to try to deal with a crash,
30 2007-07-27 Murray Cumming <murrayc@murrayc.com>
32 * src/maemo/modest-maemo-utils.c:
33 (modest_maemo_utils_get_supported_secure_authentication_methods):
34 Make sure that we have a connection, asking the user for one
36 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
37 Check for a connection before showing the wizard, because
38 the wizard needs a connection to check for server capabilities.
40 2007-07-27 Murray Cumming <murrayc@murrayc.com>
42 * src/maemo/modest-account-view-window.c:
43 (on_new_button_clicked): Remember the wizard dialog instance,
44 so we can just present it again if necessary. This prevents
45 multiple windows from appearing if you click again quickly on the
46 New button before the dialog appears, fixing projects.maemo.org
49 2007-07-27 Murray Cumming <murrayc@murrayc.com>
51 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
52 Offer a connection dialog if there is no connection when
53 starting modest. This should fix projects.maemo.org bug NB#61134.
55 2007-07-27 Murray Cumming <murrayc@murrayc.com>
57 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
58 Reverted my last commit. I was able to fix the build by doing
59 apt-get install wpeditor0 (replacing other wpeditor packages) and
60 an explicit apt-get install wpeditor-dev to upgrade the -dev
63 2007-07-27 Murray Cumming <murrayc@murrayc.com>
65 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
66 Commented out the use of wp_text_buffer_replace_image()
67 because it does not exist, to break the build. Added a TODO for it.
69 2007-07-26 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-tny-account-store.c: (recreate_all_accounts):
72 Recreate them even if they were NULL before. I guess something
73 else was already creating them before, or this would never
75 (modest_tny_account_store_get_server_account): Make sure that
76 the tny accounts have been created before trying to find one.
77 This allows libmodest_dbus_client_compose_mail() to work
78 when the UI is not yet visible.
79 This is probably useful in other cases too.
81 (get_password): When the password is wrong after it is entered
82 in the protected password dialog, show an info banner (in an
83 idle handler) before showing the protected password dialog
86 2007-07-26 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-ui-actions.h:
89 * src/modest-ui-actions.c: Added
90 modest_do_refresh_current_folder() containing some code from
91 modest_ui_actions_on_send_receive().
92 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
93 Call modest_do_refresh_current_folder() before refreshing the
94 requested account, as in modest_ui_actions_on_send_receive().
95 This is strange, but seems to be necessary to show new mails.
96 Now new emails are finally visible in the UI when downloaded
97 via the automatic update interval, fixing bug NB#57458.
98 This also works because bug NB#57458 has been fixed somehow.
100 2007-07-26 Murray Cumming <murrayc@murrayc.com>
102 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
103 printf more details when we get unhandled D-Bus methods, because
106 * src/modest-mail-operation.c: (update_account_thread):
107 Comment out the tny_camel_pop_store_account_reconnect(), because this
108 is apparently no longer needed, and it did not work before anyway.
109 See the comment in the code.
111 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
112 by checking the header flags. This fixes projects.maemo.org bug
115 2007-07-25 Murray Cumming <murrayc@murrayc.com>
117 * src/maemo/modest-maemo-utils.h:
118 * src/maemo/modest-maemo-utils.c: Added
119 modest_maemo_show_information_note_in_main_context_and_forget().
120 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
121 Use the new function to show simple error dialogs in the main
122 context, though question dialogs are still in the current context,
123 which is unfortunately usually not the main context. This should
126 2007-07-25 Murray Cumming <murrayc@murrayc.com>
128 * src/modest-tny-account-store.c: (get_password):
129 Never save the entered username and password in gconf,
130 because the UI spec says we should not. This helps
131 slightly with projects.maemo.org bug NB#63671.
133 2007-07-25 Murray Cumming <murrayc@murrayc.com>
135 * src/widgets/modest-msg-edit-window.h:
136 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
137 Moved some code here to make it simpler.
138 (modest_msg_edit_window_attach_file_one): Renamed from
139 modest_msg_edit_window_attach_file_interactive().
140 (modest_msg_edit_window_offer_attach_file): Renamed from
141 modest_msg_edit_window_attach_file() and used
142 modest_msg_edit_window_attach_file_one() instead of
143 copy/pasting the code. The old code for one was not using
144 GnomeVFS. This allows use of smb:// URLs when using send-as
145 from external applications, fixing bug NB#63741.
147 (modest_msg_edit_window_insert_image),
148 (modest_msg_edit_window_add_attachment_clicked):
149 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
150 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
151 Adapted to the new function names.
153 2007-07-25 Murray Cumming <murrayc@murrayc.com>
155 (modest_platform_set_update_interval): Set the alarm recurrence
156 fields so that auto-update does not just happen the first time.
157 This should have fixed projects.maemo.org bug NB#63938.
159 When this happens you can see a printf when the D-Bus method is
161 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
163 However, I do not actually seem to get new POP messages even when
164 clicking the refresh button manually. A restart gets them.
165 This might be a problem in today's tinymail only.
167 2007-07-24 Murray Cumming <murrayc@murrayc.com>
169 * src/maemo/modest-maemo-global-settings-dialog.c:
170 (current_connection):
171 Avoid a crash (probably only in scratchbox) when strcmp()ing a
172 NULL when closing the dialog.
174 2007-07-24 Murray Cumming <murrayc@murrayc.com>
176 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
177 Remove the hacky send/receive that didn't work, and instead
178 refilter the treemodel to make the deleted email really vanish from
179 the UI (though the delete-from-menu code does has commented out
180 the code that does that). This fixes projects.maemo.org bug
183 2007-07-24 Murray Cumming <murrayc@murrayc.com>
185 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
186 Try a couple of tricks to force the treeview to update (
187 poke the folder, and do a send/receive refresh), but the deleted
188 email still appears with a strike-through instead of really being
191 2007-07-23 Murray Cumming <murrayc@murrayc.com>
193 * src/dbus_api/modest-dbus-callbacks.c:
194 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
195 because their ID is not human-readable (see the comment about
196 improvements needed to the osso-email-interface API) and
197 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
199 2007-07-23 Murray Cumming <murrayc@murrayc.com>
201 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
202 (add_folders_to_list), (on_dbus_method_get_folders),
203 (modest_dbus_req_filter):
204 * src/maemo/modest-maemo-utils.c:
205 (on_camel_account_get_supported_secure_authentication):
206 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
207 (on_header_view_focus_in):
208 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
209 * src/modest-formatter.c: (modest_formatter_create_body_part):
210 * src/modest-mail-operation.c: (recurse_folders),
211 (update_account_thread), (get_msgs_full_thread),
212 (modest_mail_operation_get_msgs_full),
213 (modest_mail_operation_xfer_msgs):
214 * src/modest-search.c: (search_mime_part_and_child_parts),
215 (modest_search_account), (modest_search_all_accounts):
216 * src/modest-tny-account.c:
217 (modest_tny_account_get_special_folder), (recurse_folders):
218 * src/modest-tny-local-folders-account.c:
219 (modest_tny_local_folders_account_query_passes):
220 * src/modest-tny-msg.c: (copy_mime_part),
221 (modest_tny_msg_find_body_part_from_mime_part):
222 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
223 (modest_tny_send_queue_try_to_send):
224 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
225 (_modest_ui_actions_open), (download_uncached_messages),
226 (reply_forward), (modest_ui_actions_on_copy),
227 (modest_ui_actions_on_details), (has_retrieved_msgs),
228 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
230 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
231 (_selected_msg_marked_as), (_msg_download_completed),
232 (_selected_msg_sent_in_progress):
233 * src/widgets/modest-attachments-view.c:
234 (modest_attachments_view_set_message):
235 * src/widgets/modest-msg-view.c: (find_cid_image):
236 * tests/check_folder-transfer.c: (find_folders):
237 * tests/check_update-account.c: (func):
238 * tests/dbus_api/test_get_folders.c: (main):
239 Checked all uses of tny_iterator_get_current(), making sure
240 that the object is unreferenced (3 or 4 places did not),
241 and adding checks for NULL.
243 2007-07-23 Murray Cumming <murrayc@murrayc.com>
245 * src/dbus_api/modest-dbus-callbacks.c:
246 (on_idle_open_default_inbox): Make sure that the application UI is
248 * src/maemo/easysetup/modest-easysetup-wizard.c:
249 (on_entry_invalid_character): Show the word whitespace instead
250 of (null) in the banner when whitespace was entered.
251 (show_error): Add a comment that this does not work in
252 Maemo Bora, though we do not know why.
254 2007-07-23 Murray Cumming <murrayc@murrayc.com>
256 * src/modest-tny-account.c:
257 (modest_tny_account_get_special_folder): Use an if instead of
258 an assert for when the parent account name is NULL, because this
259 might be causing a crash in projects.maemo.org bug 63192.
260 * src/modest-mail-operation.c:
261 (modest_mail_operation_send_new_mail_cb),
262 (modest_mail_operation_remove_folder): unref the folder that is
263 returned from modest_tny_account_get_special_folder().
265 2007-07-23 Murray Cumming <murrayc@murrayc.com>
267 * src/modest-ui-actions.c:
268 (modest_ui_actions_on_password_requested):
269 Show mail_ib_login_cancelled info banner when the user cancels
270 the protected password dialog, to fix projects.maemo.org
273 2007-07-23 Murray Cumming <murrayc@murrayc.com>
275 * src/maemo/modest-account-settings-dialog.c:
276 (create_page_outgoing): Put this page in a GtkScrolledWindow,
277 matching the UI mock-up in the UI spec, and allowing access
278 to all widgets even when the on-screen keyboard is active.
280 2007-07-23 Murray Cumming <murrayc@murrayc.com>
282 Reverted this previous commit from Johannes,
283 because the scrollbars are always visible and because
284 I think we only need it on onepage of the account
285 settings, not the account wizard.
286 (I wrote the wrong instructions in the bug.)
288 * src/maemo/easysetup/modest-easysetup-wizard.c:
289 Added scrollbars to account wizard dialog.
290 Fixed projects.maemo.org NB #62744
292 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
294 * src/maemo/easysetup/modest-easysetup-wizard.c:
295 (create_page_user_details):
296 Use auto-cap for name (projects.maemo.org NB#63716)
297 * src/widgets/modest-account-view.c: (on_account_busy_changed):
299 2007-07-22 Armin Burgmeier <armin@openismus.com>
301 * src/maemo/modest-ui-actions.c: Use current account instead of
302 default account for creating viewer windows, so that the viewer
303 window knows to which account the viewed message belongs.
305 * src/maemo/modest-msg-view-window.c: Destroy the window when the
306 corresponding account is deleted. This fixes projects.maemo.org bug
309 2007-07-18 Armin Burgmeier <armin@openismus.com>
311 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
312 the dialog close after entering an invalid port number and clicking
313 OK. This fixes projects.maemo.org bug NB#63602.
315 2007-07-18 Armin Burgmeier <armin@openismus.com>
317 * src/modest-tny-account-store.c:
318 (get_server_accounts): Set parent modest account name for each
319 connection-specific transport account so that special folders of such
320 an account can be looked up. This fixes a crash when changing account
321 settings. This might also be related to projects.maemo.org bug
324 2007-07-16 Armin Burgmeier <armin@openismus.com>
326 * src/modest-ui-actions.c: Added a button to create a folder to the
327 move-to dialog. This fixes projects.maemo.org bug NB#.
329 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
331 * src/maemo/easysetup/modest-easysetup-wizard.c:
332 Added scrollbars to account wizard dialog.
333 Fixed projects.maemo.org NB #62744
335 2007-07-16 Murray Cumming <murrayc@murrayc.com>
337 * src/widgets/modest-msg-view.h:
338 * src/widgets/modest-msg-view.c:
339 Added modest_msg_view_get_message_is_empty() but this needs
341 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
342 Check if there is any text in the message yet.
343 But this needs to be implemented properly.
344 (modest_msg_edit_window_toggle_find_toolbar):
345 * src/maemo/modest-msg-view-window.c:
346 (modest_msg_view_window_toggle_find_toolbar):
347 Show a banner warning if there is no text to search, when
348 trying to start a search. This partially fixes
349 projects.maemo.org bug NB#62350.
351 2007-07-13 Murray Cumming <murrayc@murrayc.com>
353 * src/modest-mail-operation.c: (update_account_thread):
354 Initialized num_new_headers to fix the build.
356 2007-07-13 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
359 Ignore modest accounts whose server accounts don't exist in gconf.
360 This prevents us trying to create TnyAccount instances for those
361 server accounts when the server account has been removed from gconf,
362 but the parent modest account has not yet been removed from modest.
363 I don't know why this is only noticeable now. It was probably just
364 a harmeless g_warning() anyway.
366 2007-07-13 Murray Cumming <murrayc@murrayc.com>
368 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
369 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
371 2007-07-12 Armin Burgmeier <armin@openismus.com>
373 * src/maemo/modest-main-window.c: Make default account appear bold
374 in view, tools/send & receive and toolbar/send & receive SCM menus.
375 This fixes projects.maemo.org bug NB#59010.
377 2007-07-12 Murray Cumming <murrayc@murrayc.com>
379 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
380 Add a short-cut, by checking if the folder store is an account.
381 This ensures that the Sort menu item and toolbar is dimmed for
382 the local-folders account root item, fixing
383 projects.maemo.org bug NB#62545.
385 2007-07-12 Murray Cumming <murrayc@murrayc.com>
387 * src/modest-tny-account-store.c: (get_password):
388 Show the password dialog (via the signal) only in the mainloop, via
389 an idle handler that we wait for. This could theoretically prevent
390 hangs, though I worry that it could introduce some too.
392 2007-07-12 Murray Cumming <murrayc@murrayc.com>
394 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
395 * src/maemo/modest-platform.c:
396 (modest_platform_connect_and_wait):
397 Take a TnyAccount* parameter and try to set it to online
398 (a TnyCamel-only API), because tinymail sets accounts to offline
399 when the user cancels a password dialog, and doesn't ask again until
400 it has been set to online.
401 However, this is commented out because it causes a hang now.
403 (modest_platform_connect_and_wait_if_network_account):
404 * src/modest-mail-operation.c:
405 (modest_mail_operation_update_account):
406 * src/modest-platform.h:
407 * src/modest-ui-actions.c: (_modest_ui_actions_open),
408 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
410 2007-07-12 Armin Burgmeier <armin@openismus.com>
412 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
414 * src/modest-mail-operation.c:
415 * src/modest-ui-actions.c: Check for already existing folder before
416 querying the server, show error message from camel if the request
417 still fails. This fixes projects.maemo.org bug NB#58701.
419 2007-07-12 Murray Cumming <murrayc@murrayc.com>
421 * src/modest-tny-account-store.h:
422 * src/modest-tny-account-store.c:
423 Added modest_tny_account_store_forget_password_in_memory(),
424 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
425 when creating a new account, so that new passwords will be used, instead of
426 us thinking that it's a second request as a result of a failed password again.
428 2007-07-12 Murray Cumming <murrayc@murrayc.com>
430 * src/dbus_api/modest-dbus-callbacks.c:
431 (on_idle_open_message): If the message is in drafts then open it
432 in an edit window instead of a view window. This fixes
433 projects.maemo.org bug NB#63005.
435 2007-07-12 Murray Cumming <murrayc@murrayc.com>
437 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
438 Avoided a harmless g_warning().
440 2007-07-12 Murray Cumming <murrayc@murrayc.com>
442 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
443 Pass the modest account name, not the TnyAccount display name to
444 modest_msg_view_window_new() so that the reply feature works,
445 fixing projects.maemo.org bug NB#62892.
447 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
448 (modest_msg_view_window_new_with_header_model):
449 * src/maemo/modest-msg-view-window.c:
450 (modest_msg_view_window_new_with_header_model),
451 (modest_msg_view_window_new):
452 * src/modest-ui-actions.c: (reply_forward):
453 * src/widgets/modest-msg-view-window.h:
454 * src/widgets/modest-window.c: (modest_window_set_active_account):
455 Rename an account parameter to modest_account_name to make this clearer.
457 2007-07-11 Murray Cumming <murrayc@murrayc.com>
459 * src/modest-ui-actions.h:
460 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
461 modest_do_message_delete().
462 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
463 Call modest_do_message_delete(), hoping that this would cause messages
464 to be really deleted from search instead of just marked with strike through.
465 Does not seem to help.
467 2007-07-11 Armin Burgmeier <armin@openismus.com>
469 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
470 priv->reselect to FALSE prior to calling
471 modest_folder_view_select_first_inbox_or_local() to prevent endless
472 recursion and thus a crash on startup.
474 2007-07-11 Armin Burgmeier <armin@openismus.com>
476 * src/maemo/modest-account-settings-dialog.h: Include
477 <gtk/gtknotebook.h> to fix the build (at least for me).
479 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
480 Use "New FolderN" as default suggested name if "New folder" already
481 exists, with N being the first free number, though never exceed "New
482 folder99" in which case we just fall back to "New Folder" even though
483 it already exists. This fixes projects.maemo.org bug NB#58663.
485 2007-07-11 Murray Cumming <murrayc@murrayc.com>
487 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
488 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
489 projects.maemo.org bug NB#62778.
491 2007-07-11 Murray Cumming <murrayc@murrayc.com>
493 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
494 Ignore the wrong (for now) secure-smtp setting in the presets -
495 just default to requiring secure authentication for SMTP, because
498 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
500 * src/widgets/modest-folder-view.c: (filter_row)
501 Do not show drafts folder (see UI specs)
503 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
505 * src/modest-ui-actions.c:
506 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
507 place and also not necessary.
509 * src/widgets/modest-folder-view.c: (filter_row)
510 Guess folder type and hide Sent & Outbox if necessary.
511 Fixed project.maemo.org NB#57328
513 2007-07-11 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-ui-actions.h:
516 * src/modest-ui-actions.c:
517 (modest_ui_actions_on_delete_message):
518 Move some code into a new
519 modest_ui_actions_refresh_message_window_after_delete()
520 function so we can use it from elsewhere.
522 * src/dbus_api/modest-dbus-callbacks.c:
523 (on_idle_delete_message), (on_delete_message): Used an idle
524 handler, as we do for the other D-Bus method handlers.
525 Call modest_ui_actions_refresh_message_window_after_delete()
526 if the deleted message was open in a window. This fixed
527 projects.maemo.org bug NB#62862.
529 2007-07-11 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-main.c: (main): Only show the UI at the start if
532 the showui command line option was given. For instance,
533 run-standalone src/modest showui
534 Otherwise, we wait for the top_application D-Bus method to
535 be sent by hildon-desktop when the application is selected
537 This allows us to run without a UI when osso-global-search
538 uses our D-Bus methods.
540 2007-07-11 Murray Cumming <murrayc@murrayc.com>
542 * src/dbus_api/modest-dbus-api.h: Added a define for a
543 top-application D-Bus method.
544 * src/dbus_api/modest-dbus-callbacks.c:
545 (on_top_application),
546 (modest_dbus_req_handler): Handle the top-application D-Bus
547 method, which might be an undocumented D-Bus signal sent by
548 hildon-desktop when it starts the application from the menu.
549 But I am not sure and I need to test it on the device, because
550 my scratchbox does not have the application in the menu now.
551 This method shows the main window, so that it can be invisible
552 when started, for instance, just for email searching from
555 * src/maemo/modest-main-window.c: (restore_settings),
556 (modest_main_window_new): Do not show the window immediately
557 upon creation. We show it later.
558 * src/modest-widget-memory.c: (save_settings_paned):
559 Try (unsuccessfully) to avoid saving the paned position when
560 it is not even visible.
561 (restore_settings_paned): Do not allow a silly paned position.
562 This seems necessary when not showing the window at first.
564 * tests/dbus_api/Makefile.am:
565 * tests/dbus_api/test_top_application.c: (main): Test for the
568 2007-07-10 Murray Cumming <murrayc@murrayc.com>
570 * src/modest-ui-dimming-rules.c:
571 (modest_ui_dimming_rules_on_new_msg),
572 (modest_ui_dimming_rules_on_reply_msg),
573 (modest_ui_dimming_rules_on_delete_msg),
574 (modest_ui_dimming_rules_on_details),
575 (modest_ui_dimming_rules_on_view_window_move_to),
576 (modest_ui_dimming_rules_on_view_previous),
577 (modest_ui_dimming_rules_on_view_next),
578 (_invalid_folder_for_purge): Added checks before
579 casting the window. This looks like an actual
580 logic error in _invalid_folder_for_purge(), because it
581 tries to use a ModestMainWindow as a message window.
583 2007-07-10 Murray Cumming <murrayc@murrayc.com>
585 * src/maemo/modest-account-settings-dialog.c:
586 (show_error): Use the same implementation as in
587 modest-easysetup-wizard.c:
588 (on_entry_invalid_character): The logical ID contains a %s.
589 Guessed what it should be.
590 (on_entry_max), (check_data), (on_response): Adapt to
591 changed show_error().
592 (create_page_account_details): Really call
593 modest_validating_entry_set_func() on the correct widgets.
594 * src/maemo/easysetup/modest-easysetup-wizard.c:
595 (on_entry_invalid_character): Fix the logical ID here too.
596 (create_page_account_details),
597 (create_page_user_details):
599 modest_validating_entry_set_func() on the correct widgets.
601 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
602 Do not try to use the account if it is NULL.
604 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
606 * src/modest-ui-actions.c: (create_move_to_dialog),
607 (modest_ui_actions_on_main_window_move_to),
608 (modest_ui_actions_on_msg_view_window_move_to):
609 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
610 (filter_row), (modest_folder_view_show_non_move_folders):
611 * src/widgets/modest-folder-view.h:
613 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
614 the Sent folder yet as it does not report the correct folder type.
616 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
618 * src/maemo/modest-msg-edit-window.c: (init_window):
621 2007-07-10 Murray Cumming <murrayc@murrayc.com>
623 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
624 Take a parent widget instead of a parent window, and
625 implement this with hildon_banner_show_information() instead.
626 Non-Maemo builds can just ifdef that there.
627 This fixed projects.maemo.org bug NB#62766.
629 (on_entry_invalid_character): Use show_error() again instead
630 of using hildon directly, and use the _CS() macro to use the correct
632 (create_account), (check_for_supported_auth_methods), (on_entry_max):
633 Pass a widget instead od a window to show_error().
635 2007-07-10 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
638 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
639 This allows us to show the server name in the error message, fixing
640 projects.maemo.org bug NB#62904.
641 Also, use the appropriate logical ID message for the account protocol.
643 2007-07-10 Murray Cumming <murrayc@murrayc.com>
645 * src/modest-tny-account-store.c: (on_idle_wrong_password):
646 A compilation fix, though the build wasn't broken for me.
648 2007-07-09 Murray Cumming <murrayc@murrayc.com>
650 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
651 Do not try to unref a NULL folder store, to avoid a runtime warning.
652 This seems to happen sometimes when changing accounts settings.
654 2007-07-09 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-tny-account-store.c:
657 (modest_tny_account_store_instance_init),
658 (modest_tny_account_store_finalize),
659 (on_account_settings_hide), (on_idle_wrong_password):
660 Use a GHashTable to ensure that we only show one account settings
661 dialog per modest account. This avoids us having a dialog open for
662 both the store and transport accounts, or due to repeated get_password()
663 calls that shouldn't happen anyway.
665 2007-07-09 Murray Cumming <murrayc@murrayc.com>
667 * src/maemo/modest-maemo-utils.c: (on_hide),
668 (modest_maemo_show_dialog_and_forget): Handle the response, because
669 the window is not even hidden by default.
671 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
672 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
673 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
674 which seems to prevent some modality problems.
676 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
677 Ignore user cancellation errors.
679 * src/modest-account-mgr-helpers.h:
680 * src/modest-account-mgr-helpers.c:
681 Added modest_server_account_get_password() and
682 modest_server_account_get_has_password() to avoid direct use of
685 * src/maemo/modest-account-settings-dialog.h:
686 * src/maemo/modest-account-settings-dialog.c:
687 (modest_account_settings_dialog_init): Store the notebook so we can
689 Added modest_account_settings_dialog_switch_to_user_info().
691 * src/modest-tny-account-store.c:
692 (get_password): When the password in the account settings is wrong (we think),
693 show the relevant page of the account settings dialog, in the mainloop.
694 However, we currently get many of these at once because cancel does not
696 (forget_password): Do not forget the password
697 from the account settings, because this causes side-effects when
698 tinymail seems to call it at strange time, maybe because of how we
699 are cancelling get_password().
700 (modest_tny_account_store_alert): Ignore user cancellations.
702 2007-07-09 Murray Cumming <murrayc@murrayc.com>
704 * src/maemo/modest-maemo-utils.h:
705 * src/maemo/modest-maemo-utils.c:
706 Added modest_maemo_show_information_note_and_forget() for use instead of
707 gtk_dialog_run() when the response is not needed, to avoid an extra
708 mainloop which could cause a hang.
710 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
711 Use the logical IDs for the error message, though they are not
712 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
713 because gtk_dialog_run() caused a hang here (the window did not close).
714 This fixes projects.maemo.org bug NB#62646.
716 2007-07-09 Murray Cumming <murrayc@murrayc.com>
718 * src/modest-account-mgr-helpers.h:
719 * src/modest-account-mgr-helpers.c:
720 Added modest_account_mgr_get_store_protocol().
722 * src/maemo/modest-account-view-window.c:
723 (on_delete_button_clicked): Show different warning text depending on
724 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
725 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
728 2007-07-09 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/modest-msg-edit-window.c:
731 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
732 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
734 2007-07-07 Armin Burgmeier <armin@openismus.com>
736 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
737 ckdg_ib_maximum_characters_reached from correct package.
739 * src/modest-ui-actions.c: Show an error message when a folder could
740 not be created. Tinymail does not give us specific error codes about
741 what has gone wrong, so we assume that a folder with that name
742 already exists, though there might be other reasons.
744 2007-07-06 Murray Cumming <murrayc@murrayc.com>
746 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
747 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
748 give a more exact error message that can be partly translated.
750 2007-07-05 Murray Cumming <murrayc@murrayc.com>
752 * src/maemo/modest-address-book.c:
753 (select_email_addrs_for_contact): Specify a default window size for the
754 select-email-address dialog, so that it is probably big enough for the
755 title. This should fix projects.maemo.org bug NB#62277.
757 2007-07-05 Murray Cumming <murrayc@murrayc.com>
759 * src/maemo/easysetup/modest-easysetup-wizard.c:
760 (create_page_complete_easysetup): Use
761 gtk_widget_set_size() request to ensure that the text wraps
764 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
766 * src/maemo/easysetup/modest-easysetup-wizard.c:
767 (on_entry_invalid_character), (create_page_account_details),
768 (create_page_user_details):
769 Use new API of ModestValidatingEntry. But for some reason the banner is
770 not shown. I will have to investigate that further.
772 * src/widgets/modest-validating-entry.c: (on_insert_text),
773 (modest_validating_entry_set_func):
774 * src/widgets/modest-validating-entry.h:
775 Added a new callback function to be able to react to prevented
776 characters whitespaces to e.g show a banner.
778 2007-07-05 Armin Burgmeier <armin@openismus.com>
780 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
781 notification of HildonNumberEditor instead of remembering the port
782 number. Thanks to Johannes for pointing this out.
784 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
786 * src/maemo/easysetup/modest-easysetup-wizard.c:
787 Check if there are any user changes before showing a confirmation
788 dialog (projects.maemo.org NB#60946)
790 2007-07-05 Armin Burgmeier <armin@openismus.com>
792 * src/maemo/modest-account-settings-dialog.c: Remember custom port
793 number at the beginning of the dialog and set the modified flag at the
794 end if the port number has changed. This is necessary because
795 HildonNumberEditor does not support notification when the value has
798 2007-07-05 Murray Cumming <murrayc@murrayc.com>
800 * src/modest-ui-actions.c:
801 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
802 a connection before asking anything else. Correct the check for the destination
803 folder so that it succeeds when online.
804 This fixed projects.maemo.org bug NB#61645.
806 2007-07-05 Murray Cumming <murrayc@murrayc.com>
808 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
809 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
810 to fix projects.maemo.org bug NB#62439.
812 2007-07-05 Murray Cumming <murrayc@murrayc.com>
814 * src/modest-tny-account.c: (on_connection_status_changed):
815 Really do not use tny_device_force_offline() here. See the previous comment.
817 2007-07-04 Murray Cumming <murrayc@murrayc.com>
819 * src/modest-tny-account.c: (on_connection_status_changed):
820 Do not use tny_device_force_offline() when tinymail says that something
821 went wrong with the connection. It seems to report this unnecessarily.
823 2007-07-04 Murray Cumming <murrayc@murrayc.com>
825 * src/maemo/modest-connection-specific-smtp-window.c:
826 (modest_connection_specific_smtp_window_init):
827 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
828 does not seem to have any effect in osso 1.1 (though it works in
829 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
831 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
833 * src/maemo/modest-connection-specific-smtp-window.c:
834 Fix UI specification problems with projects.meamo.org NB#60479
836 2007-07-04 Murray Cumming <murrayc@murrayc.com>
838 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
839 clue when this has failed, because the error dialog is not always shown
840 (at least in earlier version).
842 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
843 GError message, because the generic error dialog is not helpful.
845 'This message is not currently available (can't let a new connection go online)'
846 when trying to open an IMAP message.
848 (_modest_ui_actions_open): Offer a connection when some messages would
849 have to be downloaded and we are offline.
851 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
853 * src/widgets/modest-folder-view.c:
854 Don't check for MERGE type anymore as we use the correct type
856 NOTE: For the last two changes you need to update your tinymail copy
857 because of API changes!
859 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
861 * src/modest-tny-local-folders-account.c:
862 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
863 (see projects.maemo.org NB#61580)
865 2007-07-04 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-tny-account.c: (on_connection_status_changed):
868 Commented out the call to modest_platform_connect_and_wait() because this
869 seems to always hang, and I would like to know if this is the only thing
870 that causes a hang when showing the connection dialog.
871 It is not very useful anyway.
873 2007-07-04 Murray Cumming <murrayc@murrayc.com>
875 * src/maemo/modest-msg-view-window.c:
876 (modest_msg_view_window_select_next_message):
878 * src/modest-platform.h:
879 * src/maemo/modest-platform.c:
880 Added modest_platform_connect_and_wait(), which calls
881 tny_maemo_conic_device_connect() always in the main thread, by calling it
882 in an idle handler and waiting for the idle handler to run. It should be
883 in the main thread because it uses GTK+ UI code. It just returns TRUE
884 if the device is already online.
886 There is some nasty code to ensure that subsequent calls to
887 modest_platform_connect_and_wait() just wait for the first one to finish,
888 by checking repeatedly in another idle handler. This is necessary,
889 because other threads (or even the main thread, via another idle handler)
890 can call modest_platform_connect_and_wait() while
891 modest_platform_connect_and_wait() is running.
893 (modest_platform_connect_and_wait_if_network_account),
894 (modest_platform_connect_and_wait_if_network_folderstore):
895 Convenience functions that calls modest_platform_connect_and_wait() if
896 the account or folder might want network access.
898 * src/modest-mail-operation.c:
899 (modest_mail_operation_update_account):
900 * src/modest-ui-actions.c: (download_uncached_messages),
901 (modest_ui_actions_on_rename_folder), (delete_folder),
902 (modest_ui_actions_on_main_window_move_to),
903 (modest_ui_actions_on_msg_view_window_move_to):
904 * src/widgets/modest-folder-view.c:
905 (drag_and_drop_from_folder_view):
906 Offer a connection if we are offline.
908 * src/modest-tny-account.c: (on_connection_status_changed):
909 Document this as only handling errors during network operations in progress,
910 and replace the idle code with a simple call to
911 modest_platform_connect_and_wait(), which does this instead.
913 2007-07-03 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-tny-account.c:
916 (modest_tny_account_get_special_folder): (util_on_idle),
917 Handle the GError so we can see when tny_folder_store_get_folders()
918 fails, as it currently does while something else is connecting.
920 Added util_run_in_main_thread_and_wait()
921 which uses an idlen handler and mainloop to ensure that the function
922 is called in the main thread.
923 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
924 to make sure that we call attempt the connection in the mainloop only,
925 which might solve some hangs.
927 2007-07-03 Murray Cumming <murrayc@murrayc.com>
929 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
930 be found by their display name. This is never useful.
931 * src/modest-tny-account-store.c: (on_account_removed): Find the account
932 by its ID, instead of trying to use its ID as its display name.
934 * src/modest-tny-account-store.h:
935 * src/modest-tny-account.c:
936 (modest_tny_account_get_special_folder): Add a g_warning() when
937 tny_folder_store_get_folders() returns an empty list for the maildir.
939 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
940 Add a g_warning() when this returns NULL, because that it not allowed
943 2007-07-02 Armin Burgmeier <armin@openismus.com>
945 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
946 note when trying to cancel the wizard. This fixes projects.maemo.org
949 2007-07-02 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-tny-account.h:
952 * src/modest-tny-account.c:
953 (modest_tny_account_new_from_server_account),
954 (modest_tny_account_new_from_server_account_name),
955 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
956 because this must now be set before setting the proto. This is usd in
957 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
958 warning in camel_session_get_service() caused by
959 tny_camel_transport_account_prepare().
961 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
964 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
966 * src/maemo/modest-connection-specific-smtp-edit-window.c:
968 (modest_connection_specific_smtp_edit_window_init):
970 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
973 2007-06-29 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-tny-account.c:
976 (modest_tny_account_new_from_server_account):
977 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
978 now uses to request a connection when it needs one, and which it uses
979 to tell us that something is wrong with the connection, so we can force
980 the accounts offline to prevent further problems.
983 * src/modest-init.c: (init_default_settings):
984 * src/modest-mail-operation.c:
985 (modest_mail_operation_update_account):
986 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
987 This should not be necessary anymore. Do not set the conf key that
988 determined this (it was always TRUE and not set anywhere else).
990 * src/modest-ui-actions.h: Remove unused and unimplemented
991 modest_ui_actions_on_online_toggle_toggled().
993 2007-06-29 Murray Cumming <murrayc@murrayc.com
995 * src/maemo/modest-main-window.c: (connect_signals):
996 Don't connect to delete_event twice. Maybe this was harmless.
998 2007-06-29 Murray Cumming <murrayc@murrayc.com
1000 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1001 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1002 Debug output to give some more clue when a folder move is not allowed.
1004 2007-06-28 Murray Cumming <murrayc@murrayc.com
1006 * src/modest-tny-account.c: (on_modest_file_system_info),
1007 (modest_tny_account_get_mmc_account_name):
1008 Always call the callback, without checking whether the name has changed.
1009 * src/widgets/modest-folder-view.c: (strings_are_equal),
1010 (on_model_foreach_set_name), (on_get_mmc_account_name),
1011 (text_cell_data): Compare the name here, and use the name from
1012 the account rather than from the
1013 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1014 if the name was changed after the account was added to the model.
1015 That's a tinymail bug but not one that I want to fix now.
1017 This finally fixes projects.maemo.org bug NB#59301.
1019 2007-06-27 Armin Burgmeier <armin@openismus.com>
1021 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1024 2007-06-27 Murray Cumming <murrayc@murrayc.com
1026 * src/modest-tny-account.h:
1027 * src/modest-tny-account.c:
1028 Added modest_tny_account_get_mmc_account_name(), to set the memory
1029 card name asynchronously for the given account and then notify.
1030 (modest_tny_account_new_for_local_folders): Use this new function instead
1031 of using hildon_file_system_info_async_new() directly.
1033 * src/widgets/modest-folder-view.c: (text_cell_data):
1034 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1035 gtk_tree_model_row_changed() when it is available.
1037 This should fix projects.maemo.org bug NB#59301.
1039 2007-06-27 Murray Cumming <murrayc@murrayc.com
1041 * src/modest-mail-operation.c: (update_account_thread),
1042 (get_msgs_full_thread): Fix typo failures in the revert
1045 2007-06-27 Murray Cumming <murrayc@murrayc.com
1047 * src/maemo/modest-maemo-global-settings-dialog.c:
1048 (idle_select_default_focus):
1049 * src/modest-mail-operation.c: (idle_notify_progress),
1050 (idle_notify_progress_once), (set_last_updated_idle),
1051 (update_account_thread), (get_msgs_full_thread):
1052 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1053 * src/widgets/modest-header-view.c:
1054 (idle_notify_headers_count_changed_destroy),
1055 (idle_notify_headers_count_changed):
1056 Reverted the additions of gdk_threads_enter/leave(), in case this
1057 helps with a startup hang on the device.
1059 2007-06-26 Armin Burgmeier <armin@openismus.com>
1061 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1062 for supported secure authentication methods from server by
1063 gtk_dialog_run(), saving CPU time and a potential race condition.
1065 2007-06-26 Armin Burgmeier <armin@openismus.com>
1067 * src/maemo/modest-maemo-utils.h:
1068 * src/maemo/modest-maemo-utils.c: Added a
1069 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1070 only error code to tell the calling code when the user canceled the
1073 * src/maemo/modest-account-settings-dialog.h:
1074 * src/maemo/modest-account-settings-dialog.c:
1075 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1076 message if the retrieval of secure authentication methods was canceled
1077 by the user. Perform the check before saving anything to configuration
1078 to not end up with half-committed configuration changes, do not show
1079 a "Saving to configuration failed" note when authentication methods
1080 could not be retrieved.
1082 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1085 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1087 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1088 Only return the first level of folders under accounts, because the
1089 osso-global-search UI spec doesn't want the rest.
1090 This fixed projects.maemo.org bug NB#61811.
1092 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1094 * src/modest-tny-account-store.c:
1095 * src/modest-tny-account-store.h:
1096 Added modest_tny_account_is_memory_card_account().
1097 * src/maemo/modest-main-window.c: (create_details_widget):
1098 Show the same information items for the memory card as we show for the
1099 local-folders, to fix projects.maemo.org bug NB#59307.
1101 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1103 * src/modest-tny-account-store.c: (get_password):
1104 Added some checks for NULL to maybe prevent crashes, though I think
1105 it was Philip's last commit that actually prevented the crash here
1106 when creating a first new account.
1107 But the new account is still not usable (no messages are shown)
1108 until a restart of the application.
1110 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1112 * src/maemo/modest-maemo-global-settings-dialog.c:
1113 (idle_select_default_focus):
1114 * src/modest-mail-operation.c: (idle_notify_progress),
1115 (idle_notify_progress_once), (idle_notify_update_account_queue),
1116 (set_last_updated_idle), (update_account_thread),
1117 (notify_get_msgs_full), (get_msgs_full_destroyer),
1118 (get_msgs_full_thread):
1119 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1120 * src/widgets/modest-header-view.c:
1121 (idle_notify_headers_count_changed_destroy),
1122 (idle_notify_headers_count_changed):
1123 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1124 all idle handlers, because some other thread could be blocking
1125 the GDK lock, so that it can do GUI stuff.
1127 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1129 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1130 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1131 (on_idle_send_receive), (on_idle_open_default_inbox):
1132 * src/maemo/modest-msg-edit-window.c:
1133 (modest_msg_edit_window_attach_file_noninteractive):
1134 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1135 to prevent a hang. I don't quite understand why these are necessary,
1136 beause we should already be in the main loop. I guess something outside
1137 of the main loop is taking the lock.
1139 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1140 we are really using URIs, and use files that are more likely to exist.
1142 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1144 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1145 necessary because configure.ac now defines different variables.
1147 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1149 * libmodest-dbus-client/libmodest-dbus-client.c:
1150 * libmodest-dbus-client/libmodest-dbus-client.h:
1151 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1152 libmodest_dbus_client_compose_mail() is what things actually use.
1154 * src/dbus_api/modest-dbus-api.h:
1155 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1156 * tests/dbus_api/Makefile.am:
1157 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1160 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1162 * src/modest-init.c: (modest_init_local_folders):
1163 For memory-card (or other non local-folders) maildir accounts,
1164 always create an Archive folder, so that there is somewhere to put
1165 messages. This should be less confusing, because the user does not need
1166 to guess that the need to create a folder.
1168 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1170 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1171 Fixed icon size by using (50, 50) which is the same as defined by
1174 2007-06-25 Armin Burgmeier <armin@openismus.com>
1176 * src/widgets/modest-window-mgr.c:
1177 * src/modest-init.c:
1178 * configure.ac: Correctly recognize hildon-notify presence and fixed
1179 the build without it being installed.
1181 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1183 * libmodest-dbus-client/libmodest-dbus-client.c:
1184 (libmodest_dbus_client_search): Fix the build. Sorry.
1185 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1186 (reply_forward_cb): Initialize variables to fix the build.
1188 * src/modest-tny-account-store.c:
1189 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1190 comparison (a silly typo) so that email search results can be opened
1191 when there are more than one account.
1193 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1195 * libmodest-dbus-client/libmodest-dbus-client.c:
1196 (libmodest_dbus_client_search),
1197 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1198 instead of 1 second, because the search gets folders and messages from
1199 the server, which can take a long time. When it times out,
1200 osso-global-search will report no results.
1202 We need to specify whether we should search only cached information
1203 (maybe with a user preference), and the osso-email-search-plugin
1204 API should really be improved to allow that option, and to allow results
1205 to be delivered asynchronously in batches.
1207 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1209 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1210 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1211 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1213 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1215 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1216 that is an empty string. D-Bus seems to give us these instead of NULL.
1218 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1220 * src/dbus_api/modest-dbus-callbacks.c:
1221 * src/maemo/easysetup/modest-easysetup-wizard.h:
1222 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1224 (modest_connection_specific_smtp_edit_window_init):
1225 * src/maemo/modest-maemo-global-settings-dialog.c:
1227 * src/maemo/modest-maemo-utils.c:
1228 (modest_maemo_utils_setup_images_filechooser):
1229 * src/maemo/modest-main-window.c: (create_details_widget):
1230 * src/maemo/modest-msg-edit-window.c:
1231 (modest_msg_edit_window_attach_file_noninteractive),
1232 (modest_msg_edit_window_color_button_change),
1233 (modest_msg_edit_window_set_zoom):
1234 * src/modest-mail-operation.c: (update_account_thread):
1235 * src/modest-tny-account-store.c:
1236 * src/modest-tny-account.c:
1237 * src/widgets/modest-global-settings-dialog.c:
1238 * src/widgets/modest-window.h:
1240 Fixed build on bora!
1242 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1244 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1245 * src/modest-search.c: (modest_search_folder),
1246 (modest_search_all_accounts): Actually search only in the specified folder,
1247 doing a simple match on the folder ID.
1248 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1249 and added some documentation.
1251 2007-06-22 Armin Burgmeier <armin@openismus.com>
1253 * src/maemo/modest-maemo-utils.h:
1254 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1255 modest_maemo_utils_get_supported_secure_authentication_methods.
1257 * src/maemo/easysetup/modest-easysetup-wizard.c:
1258 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1259 one occured, not just "Server does not support secure authentication".
1261 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1263 * src/modest-tny-account-store.c: (get_password):
1264 Restored the call to tny_account_set_user() because Philip seems to have
1265 stopped this from crashing (by not using the freed string). It still does
1266 not work, but now we can test it.
1268 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/modest-msg-edit-window.c: (init_window):
1271 Comment out use of an uninitialzed GtkScrolledWindow variable,
1272 to fix the build and stop a crash. Yet again.
1274 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1276 * src/modest-tny-account-store.c: (get_password):
1277 Remove the call to tny_account_set_user() because this actually crashes.
1278 As mentioned in the last commit, it is known to not work anyway.
1280 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1282 * src/modest-tny-account-store.c: (get_password):
1283 Use tny_account_set_username() to tell tinymail that the username might
1284 have changed too. But tinymail ignores this: see projects.maemo.org
1286 * src/modest-ui-actions.c:
1287 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1288 reset the connection when changing the username, and improve the comments.
1289 Save the changed username to gconf at least, so it is used when Modest is
1292 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1294 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1295 Do not use a query, so that we get all folders, including for POP and
1296 local-folders. They work as search criteria too.
1297 This fixes projects.maemo.org bug NB#57740.
1299 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1301 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1302 Comment out the use of hildon_notification_set_sound() because it is
1303 not declared, to fix the build. Warnings are serious, people.
1305 2007-06-21 Armin Burgmeier <armin@openismus.com>
1307 * src/maemo/modest-maemo-utils.h:
1308 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1309 modest_maemo_utils_get_supported_secure_authentication_methods()
1310 to query authentication methods for a specific user. This should fix
1311 projects.maemo.org bug NB#61369.
1313 * src/maemo/easysetup/modest-easysetup-wizard.c:
1314 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1317 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1319 * libmodest-dbus-client/libmodest-dbus-client.h:
1320 * libmodest-dbus-client/libmodest-dbus-client.c:
1321 (modest_dbus_message_iter_get_search_hit),
1322 (libmodest_dbus_client_search):
1323 Reorganised and commented this.
1324 Removed modest_search_hit_free() from the public API because it
1327 Added libmodest_dbus_client_get_folders() and
1328 modest_folder_result_list_free().
1330 * src/dbus_api/modest-dbus-api.h:
1331 * src/dbus_api/modest-dbus-callbacks.c:
1332 (modest_dbus_req_filter): Commented. Moved most code to
1333 on_dbus_method_search() and added on_dbus_method_get_folders().
1335 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1336 of the extra D-Bus handler.
1338 * tests/dbus_api/Makefile.am:
1339 * tests/dbus_api/test_get_folders.c: New test for
1340 libmodest_dbus_client_get_folders(). This seems to return an empty list
1341 at the moment. That could be the same error that causes the message list
1342 to be empty sometimes.
1343 This should help with projects.maemo.org bug NB#57740.
1345 2007-06-21 Armin Burgmeier <armin@openismus.com>
1347 * src/modest-mail-operation.c: Do not call
1348 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1349 notify the operation's end after having set the status to CANCELED for
1350 the operation queue to listen on. This fixes a deadlock when there
1351 were mail operations in the queue during its finalization.
1353 * src/modest-singletons.c: Reordered uninitialization of the account
1354 manager to happen after the mail operation queue was uninitialized
1355 because the mail operation's in the queue might still try to access
1356 the account manager (see modest_mail_operation_notify_end()). This
1357 fixes a potential crash when terminating the application.
1359 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-search.c:
1362 (search_mime_part_and_child_parts): Moved some code here so we
1363 can search recursively in child folders.
1364 (modest_search_folder): Search in the message as a mime part, instead
1365 of just its child mime parts.
1366 (read_chunk), (search_mime_part_ogs):
1367 Check how many bytes were read, to prevent an endless loop.
1368 Searching in message bodies now works. This finishes the fix for
1369 projects.maemo.org bug NB#61007.
1371 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1373 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1374 Add a g_warning when the item is not a folder.
1376 * src/modest-ui-dimming-rules.c:
1377 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1378 when selected item is not a folder (for instance, an account), because
1379 the UI spec only talks about folders.
1380 I am not sure what the UI spec wants, so this might not totally fix
1381 projects.maemo.org bug NB#60794.
1383 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1385 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1386 (load_from_file): Sort the list. The unsorted list would be more noticeable
1387 in non-English locales.
1389 * src/maemo/modest-msg-edit-window.c:
1390 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1391 warning and fix the build.
1393 * src/maemo/modest-progress-bar-widget.c:
1394 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1395 avoid a g_warning, and probably to avoid a crash.
1397 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1399 * src/modest-search.c: (modest_search_folder): Check for a GError
1400 when calling tny_folder_get_headers(), to show that this is not the cause
1403 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1405 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1406 Actually set the body query instead of the subject query.
1408 * src/modest-search.c: (search_mime_part_ogs),
1409 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1410 which would probably cause it to fail if we got this far.
1412 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1413 to simplify the code.
1414 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1415 be causing search-in-body to fail.
1417 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1419 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1421 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1422 Better debug message when the folder cannot be found.
1423 This should help with fixing projects.maemo.org bug #61287.
1424 * src/modest-search.c: (add_hit): Do not leak the furl string.
1426 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1428 * src/modest-ui-actions.c:
1429 (modest_ui_actions_on_folder_selection_changed):
1430 Do not special-case TNY_MERGE_FOLDER here, because
1431 modest_tny_folder_get_account() already does that. This fixes
1432 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1433 shown when the Outbox was selected).
1435 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1437 * libmodest-dbus-client/libmodest-dbus-client.c:
1438 (_dbus_iter_get_string_or_null): Initialize the string variable in
1439 case this helps with Dirk's crash.
1441 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1443 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1444 though it is not implemented yet (this function is maybe not even used),
1445 to avoid breaking ABI in future.
1446 * libmodest-dbus-client/libmodest-dbus-client.c:
1447 (get_attachments_string): Moved some code into this generic function.
1448 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1449 sends email. It is maybe not used.
1450 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1451 (on_send_mail): Use attachments.
1453 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1454 * src/maemo/modest-msg-edit-window.c:
1455 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1456 a filename before using it, to fix projects.maemo.org bug NB#58233.
1458 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1461 Initialize the continue_download variable to fix the build, and probably
1462 to fix randome behaviour.
1464 2007-06-18 Armin Burgmeier <armin@openismus.com>
1466 * src/modest-tny-send-queue.h:
1467 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1468 the queue so we can later show it in the UI. Replaced
1469 modest_tny_send_queue_msg_is_being_sent() by
1470 modest_tny_send_queue_get_msg_status().
1472 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1474 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1475 gpointer. This probably was not harmful, but just to be sure.
1477 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1479 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1480 Fix the build, but leave the function broken on Bora, because
1481 hildon_uri_action_get_service() does not exist.
1482 osso_uri_action_get_service() does not exist either, it seems.
1484 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1486 * src/modest-tny-account.c:
1487 (modest_tny_account_new_from_server_account):
1488 Uncommented the url debug output again, because it is useful for
1489 debugging, as I said in the comment.
1491 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1493 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1495 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1496 for Mameo Bora, to fix the build.
1498 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1501 Fixed build with hildon < 0.99
1503 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1504 Check if the selected account is busy instead of checking all accounts
1506 * src/modest-account-mgr-priv.h:
1507 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1508 (modest_account_mgr_init), (compare_account_name),
1509 (modest_account_mgr_set_account_busy),
1510 (modest_account_mgr_account_is_busy):
1511 * src/modest-account-mgr.h:
1512 Added busy information to the account manager. It possible to
1513 set an account to busy or not busy now.
1515 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1516 (modest_mail_operation_update_account),
1517 (modest_mail_operation_notify_end):
1518 Set the account to busy/not busy depending on the operation state.
1520 * src/widgets/modest-account-view.c:
1521 (modest_account_view_finalize), (get_last_updated_string),
1522 (update_account_view), (on_account_busy_changed), (init_view):
1523 Show string "Refreshing..." if the account is currently busy.
1525 All this fixes projects.maemo.org bug NB#59711
1527 2007-06-14 Armin Burgmeier <armin@openismus.com>
1529 * src/widgets/modest-attachments-view.h:
1530 * src/widgets/modest-attachments-view.c: Added
1531 modest_attachments_view_has_attachments() and fixed coordinate
1532 transformation in get_att_view_at_coords(). This fixes attachment
1535 * src/widgets/modest-msg-view.c: Make use of
1536 modest_attachments_view_has_attachments() to decide whether to show
1537 attachments in the header.
1539 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1541 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1542 (on_change), (on_combo_security_changed),
1543 (modest_connection_specific_smtp_edit_window_init),
1544 (modest_connection_specific_smtp_edit_window_set_connection),
1545 (modest_connection_specific_smtp_edit_window_is_dirty):
1546 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1547 * src/maemo/modest-connection-specific-smtp-window.c:
1550 Show an comfirmation dialog for the smpt-edit-window if there are
1551 unsaved changes and the user hits cancel.
1552 (projects.maemo.org bug NB#60479)
1554 2007-06-14 Armin Burgmeier <armin@openismus.com>
1556 * src/maemo/easysetup/modest-easysetup-wizard.c:
1557 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1558 address" info in banner instead of node, and select all the text as
1559 per UI spec. This fixes projects.maemo.org bug NB#60550.
1561 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1563 reviewed by: <delete if not using a buddy>
1565 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1566 * src/modest-ui-actions.c: (folder_refreshed_cb):
1568 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1570 * src/widgets/modest-folder-view.c: (filter_row):
1571 Explictly filter out the per-account outbox accounts. I don't know why
1572 these only sometimes show up, but now they should never show up in the UI.
1573 This should fix projects.maemo.org bug NB#60160.
1575 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1577 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1578 when the toolbar does not exist yet.
1579 * src/modest-widget-memory.c: (save_settings_header_view):
1580 Added g_warnings() to help us to discover when we are trying to set
1581 an empty columns list in gconf.
1583 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1585 * src/modest-init.h:
1586 * src/modest-init.c:
1587 Added modest_init_get_default_header_view_column_ids().
1589 * src/modest-widget-memory.c: (restore_settings_header_view):
1590 Use the new function to get defaults, if the gconf key is empty,
1591 instead of not creating any columns. This seems to fix the
1592 empty right-hand pane problems.
1594 * src/widgets/modest-header-view.h: Improved documentation.
1596 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1599 Revert the use of the display name as the account name, because this
1600 is generally wrong and would break the code that follows.
1602 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1604 * src/maemo/easysetup/modest-easysetup-wizard.c:
1605 (check_for_supported_auth_methods), (on_before_next),
1608 More correct fix for projects.maemo.org bug NB# 58991
1609 Do not longer accept AUTH_PASSWORD as secure method and choose
1610 correct method when creating the account.
1612 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1614 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1615 Fixed projects.maemo.org bug NB# 58991
1617 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-init.c: (modest_init_init_core),
1620 (modest_init_local_folders): Fixed compilation errors.
1622 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1624 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1625 Remove unnecessary lib/include, though it is good in principle when needed.
1627 * src/modest-init.c: (modest_init_one_local_folder),
1628 (modest_init_local_folders):
1629 * src/modest-init.h: Initialize the .modest library for memory cards,
1630 instead of just doing nothing for them. This should allow us to create
1631 folders there, fixing projects.maemo.org bug NB#59297.
1633 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1635 * libmodest-dbus-client/libmodest-dbus-client.c:
1636 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1637 (libmodest_dbus_client_compose_mail),
1638 (libmodest_dbus_client_open_message),
1639 (libmodest_dbus_client_send_and_receive),
1640 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1642 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1643 (on_idle_open_message), (modest_dbus_req_handler),
1644 (search_result_to_message), (modest_dbus_req_filter):
1645 * src/modest-search.c: (add_hit), (modest_search_folder),
1646 (modest_search_all_accounts): Improved debug messages.
1648 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1650 * src/modest-tny-account-store.c:
1651 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1654 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1657 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1659 * src/modest-tny-account-store.c: (get_server_accounts):
1660 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1661 even when there are no accounts, so that the Outbox folder is always
1662 visible. This fixes projects.maemo.org bug NB#60158.
1664 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1666 * src/maemo/modest-main-window.c: (create_details_widget):
1667 Use the mcen_va_never logical ID.
1669 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1671 * src/dbus_api/modest-dbus-api.h:
1672 * src/dbus_api/modest-dbus-callbacks.c:
1673 (on_idle_open_default_inbox), (on_open_default_inbox),
1674 (modest_dbus_req_handler):
1675 Added a new OpenDefaultInbox method.
1677 * libmodest-dbus-client/libmodest-dbus-client.h:
1678 * libmodest-dbus-client/libmodest-dbus-client.c:
1679 Added libmodest_dbus_client_open_default_inbox() to call the new
1680 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1681 though it should maybe be used by a new osso-email-interface function.
1683 * tests/dbus_api/Makefile.am:
1684 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1687 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1689 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1690 NULL, so that the signals get all the keys. This should not actually
1691 change any behaviour because we currently update everything when anything
1694 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1696 * src/widgets/modest-folder-view.c: (text_cell_data),
1697 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1698 (find_inbox_iter): If tinymail tells us that the folder is
1699 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1700 This causes the inbox to be selected at startup, fixing part of
1701 projects.maemo.org bug NB#56305.
1703 * src/modest-ui-dimming-rules.c:
1704 (modest_ui_dimming_rules_on_tools_smtp_servers):
1705 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1706 the SMTP servers menu item.
1707 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1708 that the SMTP Servers menu item is dimmed when there are no accounts,
1709 as a future version of the UI spec will require. This fixes
1710 projects.maemo.org bug NB#56305.
1712 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1714 * src/maemo/modest-maemo-utils.c:
1715 (modest_maemo_utils_get_supported_secure_authentication_methods):
1716 Added label to dialog instead of unreadable title
1718 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1719 (modest_main_window_new):
1720 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1723 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1724 * src/modest-account-mgr.h:
1725 Added method to avoid code duplication
1727 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1728 (modest_ui_actions_on_send_receive):
1729 Use modest_account_mgr_has_accounts
1731 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1733 * src/maemo/easysetup/modest-presets.c:
1734 (modest_presets_get_info_server_security): Do not report secure auth
1736 * src/modest-protocol-info.c: Use the defines for the gconf key names
1737 for secure authentication. This was not working because we were writing
1738 Password and reading password, and the check was case sensitive.
1739 With this, gmail now works for receiving and sending when created via
1742 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1744 * src/maemo/easysetup/modest-presets.c:
1745 (modest_presets_get_info_server_security): Correct the key name for
1746 SecureSmtp, because it seems to be case-sensitive.
1747 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1748 Do not try to get the 0th notebook page if there are 0 pages, to
1749 avoid a g_warning().
1751 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1753 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1754 Prevent use of the new notification feature for now, because it currently
1755 shows one dialog for each new email, which is annoying.
1757 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1759 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1760 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1761 when no country was selected, so that we show the global ones.
1762 * src/maemo/easysetup/modest-presets.c:
1763 (modest_presets_get_providers): Return only the global providers, not
1764 all providers when mmc=0 was requested.
1766 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1768 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1769 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1770 provider ID in the combo.
1772 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1773 Do not show the page numbers, because it would be confusing when we add
1774 the 2 extra pages for the custom setup, when the user chooses the "Other"
1775 provider. This fixes projects.maemo.org bug NB#59028
1777 * src/modest-init.c: (modest_init_init_core),
1778 (modest_init_local_folders):
1779 * src/modest-init.h:
1780 * src/modest-tny-account.c:
1781 (modest_tny_account_new_for_local_folders): Do not create default folders
1782 for the memory card. This should fix projects.maemo.org bug NB#59328.
1784 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1786 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1787 Free the changed_conf_keys string items. They are already freed in the
1788 idle handler if that runs first.
1790 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1792 * src/modest-ui-actions.c:
1793 (modest_ui_actions_on_password_requested): Check that the server name
1794 is not NULL, because I just saw a password dialog with (null) as the
1797 * src/modest-tny-folder.[h|c]: Added
1798 modest_tny_folder_is_memory_card_folder().
1799 * src/modest-ui-dimming-rules.c:
1800 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1801 menu item for memory cards, as per the UI spec (section 7.4). This should
1802 fix projects.maemo.org bug NB#59297.
1804 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1806 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1807 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1808 is another problem with the code, see Murray's comment at line 772)
1810 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1812 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1813 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1814 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1815 (load_from_file), (easysetup_country_combo_box_init),
1816 (easysetup_country_combo_box_get_active_country_ids),
1817 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1818 instead of just one ID, to avoid duplicate country names in the UI.
1820 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1821 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1822 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1823 a single ID, avoiding duplicate providers.
1824 * src/maemo/easysetup/modest-easysetup-wizard.c:
1825 (on_combo_account_country): Adapt to use a list.
1827 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1829 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1830 keys changed in the last X seconds.
1832 * src/modest-account-mgr.h:
1833 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1834 (on_key_change), (modest_account_mgr_class_init),
1835 (modest_account_mgr_init), (modest_account_mgr_finalize):
1836 As the keys are changed, save them in a GSList* and signal that GSList*
1837 further every X seconds, to batch changes, to allow us to do just one
1838 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1839 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1841 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1842 changed signal signature.
1844 * src/modest-conf.c: (modest_conf_set_list),
1845 (modest_conf_on_change): Reenable notification.
1847 (modest_conf_maemo_fake_on_change): Comment out the hack that
1848 notified immediately instead of asynchronously.
1850 * src/widgets/modest-account-view.h:
1851 * src/widgets/modest-account-view.c:
1852 (update_account_view): Select the previously-selected account ID,
1853 if possible. This fixes projects.maemo.org bug NB#56933.
1855 (on_account_changed), (on_account_removed),
1856 (modest_account_view_select_account):
1858 Remove the block/unblock functions
1859 because they were not useful.
1861 * src/maemo/modest-account-view-window.c:
1862 (on_delete_button_clicked), (on_edit_button_clicked),
1863 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1865 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1867 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1868 Improve the error dialog to show Incorrect Account Settings, which seems
1869 clearer, and say that the internal error message (to be removed from the
1870 dialog later) is often misleading.
1871 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1873 * src/modest-tny-account.c:
1874 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1875 URL because this is so useful for debugging on the device.
1877 * src/widgets/modest-serversecurity-combo-box.c:
1878 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1880 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1882 * src/modest-mail-operation.c:
1883 (modest_mail_operation_send_new_mail):
1884 Added a comment about a nasty but apparently harmless message. Details
1885 added to the wiki g_warnings() page.
1887 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1890 (modest_tny_send_queue_class_init):
1891 Do not use the priv struct because it is empty, to avoid g_warnings
1892 about a non-existant priv struct.
1894 * src/modest-tny-account-store.c:
1895 (modest_tny_account_store_get_server_account),
1896 (modest_tny_account_store_get_transport_account_for_open_connection
1897 ): Do not try to get transport server accounts for local folders,
1898 because they don't have any. This avoids a g_warning().
1900 * src/maemo/modest-main-window.c:
1901 (modest_main_window_notify_send_receive_initied),
1902 (on_configuration_key_changed):
1903 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1904 * src/modest-defs.h:
1905 * src/modest-mail-operation.c:
1906 (modest_mail_operation_update_account):
1907 * src/modest-tny-account-store.h:
1908 * src/modest-tny-account.c:
1909 (modest_tny_account_get_special_folder),
1910 (modest_tny_account_new_for_local_folders),
1911 (modest_tny_account_new_for_per_account_local_outbox_folder):
1912 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1913 * src/modest-tny-local-folders-account.c:
1914 (add_account_folders_to_merged_folder):
1915 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1916 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1917 (modest_ui_actions_on_send):
1918 * src/widgets/modest-folder-view.c: (update_model):
1919 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1920 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1921 modest_tny_account_store_get_tny_account_by_account() to
1922 modest_tny_account_store_get_server_account() to make the code clearer.
1924 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1926 * src/dbus_api/modest-dbus-api.h:
1927 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1928 * src/maemo/modest-msg-edit-window.c:
1929 (modest_msg_edit_window_attach_file_noninteractive):
1930 added g_warning in case the file to be attached does not exist
1931 * tests/dbus_api/test_compose_mail.c: (main):
1932 removed obsolete comment, added generic files as test case
1934 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-tny-account-store.c: (get_server_accounts):
1937 Create the local folders account only once, not once for each outbox, and
1938 not only when there are some outboxes.
1940 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1942 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1943 code that is causing a crash at startup. Sergio says that he is fixing this.
1945 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1947 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1948 * src/maemo/modest-account-settings-dialog.c:
1949 (create_page_outgoing),
1950 (modest_account_settings_dialog_set_account_name),
1951 (save_configuration):
1952 - Fixed handling of the "Use secure authentication" toggle to comply with
1953 the ui specification. See also projects.maemo.org bug NB#58400
1955 - Restore the Secure connection setting combo correctly when loading
1958 * src/maemo/modest-maemo-utils.c:
1959 (on_camel_account_get_supported_secure_authentication),
1960 (modest_maemo_utils_get_supported_secure_authentication_methods):
1961 Fixed a crasher if operation is canceled
1963 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1964 (modest_protocol_info_auth_is_secure):
1965 * src/modest-protocol-info.h:
1967 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1968 the sense of the "Use secure authentication" toggle.
1970 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1972 * src/modest-tny-account-store.h:
1973 * src/modest-tny-account-store.c:
1974 Added modest_tny_account_store_get_local_folders_account().
1976 * src/modest-tny-folder.h:
1977 * src/modest-tny-folder.c:
1978 (modest_tny_folder_get_account):
1979 Added this replacement for tny_folder_get_account() which returns
1980 the local-folders account for TnyMergeFolders, to avoid the
1981 warning about the unimplemented get_account_func() vfunc().
1983 (modest_tny_folder_get_rules),
1984 * src/modest-ui-actions.c:
1985 (modest_ui_actions_on_folder_selection_changed):
1986 * src/modest-mail-operation.c:
1987 (modest_mail_operation_remove_folder),
1988 (modest_mail_operation_xfer_folder),
1989 (modest_mail_operation_rename_folder),
1990 (modest_mail_operation_get_msg),
1991 (modest_mail_operation_get_msgs_full),
1992 (modest_mail_operation_remove_msg),
1993 (modest_mail_operation_xfer_msgs),
1994 (modest_mail_operation_refresh_folder):
1995 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1997 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1999 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2000 (modest_server_account_set_security):
2001 * src/modest-defs.h: Add comments explaining that our
2002 UI spec means TLS when it says Normal, so these do not look like errors.
2004 * src/modest-tny-account.c:
2005 (modest_tny_account_new_from_server_account): Use the new tinymail
2006 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2007 for TLS. This should fix projects.maemo.org bug NB#58460.
2009 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/easysetup/modest-easysetup-wizard.c:
2012 (create_account): Correct the position of the gconf sanity check warning.
2013 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2014 of using the g_idle_add() hack, because this does not seem to be necessary
2015 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2016 caused by something other than maemo's gconf.
2017 This fixes projects.maemo.org bug #59022.
2019 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-account-mgr-helpers.c:
2022 (modest_account_mgr_get_default_account): Do not check that the account
2023 exists if there is no default account (NULL), to fix a runtime warning.
2025 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2027 * src/widgets/modest-folder-view.c: (update_model):
2028 Do not unref the treemodel before we have finished with it.
2029 This prevents a valgrind warning and an occasional crash at startup.
2031 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2033 * libmodest-dbus-client/libmodest-dbus-client.h:
2034 added libmodest_dbus_client_compose_mail()
2035 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2037 added functions needed for SendAsMail() functionality
2038 * src/maemo/modest-msg-edit-window.c:
2039 (modest_msg_edit_window_attach_file_noninteractive):
2040 non interactively attaching files to message edit window
2041 * src/widgets/modest-msg-edit-window.h:
2042 * tests/dbus_api/Makefile.am:
2043 added test_compose_mail.c
2044 * tests/dbus_api/test_compose_mail.c: (main):
2046 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2048 * src/modest-account-view.c:
2049 Fixed bug projects.maemo.org bug NB#59307
2051 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2053 * src/maemo/easysetup/modest-easysetup-wizard.c:
2054 (get_serverport_incoming), (on_before_next), (create_account):
2055 * src/maemo/modest-account-settings-dialog.c:
2056 (modest_account_settings_dialog_set_account_name):
2057 * src/maemo/modest-maemo-utils.c:
2058 (on_camel_account_get_supported_secure_authentication_status),
2059 (on_camel_account_get_supported_secure_authentication),
2060 (on_secure_auth_cancel),
2061 (modest_maemo_utils_get_supported_secure_authentication_methods):
2063 Implemented security authentication for settings and easysetup.
2065 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2067 * src/maemo/modest-main-window.c: (create_details_widget):
2068 Show the total size for memory card accounts too, instead of showing
2069 the name again. Fixes bug projects.maemo.org bug NB#59307.
2071 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2074 * src/modest-tny-simple-folder-store.c:
2075 * src/modest-tny-simple-folder-store.h: Removed.
2077 * src/modest-tny-local-folders-account.h
2078 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2079 for the local-folders maildir, with an extra TnyMergedFolder containing
2080 the folders of the per-account outbox store accounts.
2081 * src/modest-tny-account-store.c: (get_server_accounts):
2082 Add the outboxes to the special local folders account after creating it.
2084 * src/modest-tny-account.c:
2085 (modest_tny_account_new_for_local_folders): Create the derived
2086 account when creating the main local-folders account.
2088 * src/maemo/modest-main-window.c: (create_details_widget),
2089 (modest_main_window_set_contents_style):
2090 Adapted to the use of the derived account instead of the folder store.
2092 * src/modest-ui-actions.c:
2093 (modest_ui_actions_on_folder_selection_changed):
2094 * src/modest-ui-dimming-rules.c:
2095 (modest_ui_dimming_rules_on_new_folder):
2096 * src/widgets/modest-folder-view.c: (text_cell_data),
2097 (icon_cell_data), (filter_row), (update_model),
2098 (get_cmp_rows_type_pos):
2101 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2102 Do not get the priv struct, because no priv struct has been set,
2103 to avoid a runtime warning.
2105 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2106 #ifelse with #else, to fix a warning, to fix the build.
2109 2007-06-05 Christian Kellner <ckellner@openismus.com>
2111 * libmodest-dbus-client/libmodest-dbus-client.c:
2112 Fix small typo in doc (why do you always see them
2113 AFTER committing stuff?)
2116 2007-06-05 Christian Kellner <ckellner@openismus.com>
2118 * libmodest-dbus-client/libmodest-dbus-client.c:
2119 (libmodest_dbus_client_search):
2120 Initialize hit list with NULL. Also set folder list
2121 to "" if NULL was supplied.
2124 2007-06-03 Christian Kellner <ckellner@openismus.com>
2126 * libmodest-dbus-client/libmodest-dbus-client.c:
2127 (modest_search_hit_list_free):
2128 Make it save to call it with NULL.
2130 * src/dbus_api/modest-dbus-callbacks.c:
2131 * src/modest-search.c:
2132 Return full ModestSearchHits as the search result list not TnyHeader
2133 since can't be around withouth the correspoding TnyFolder.
2135 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2137 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2138 Added currently commented code to check for secure auth
2140 * src/maemo/modest-account-settings-dialog.c: (on_response),
2141 (save_configuration), (show_ok):
2142 Fixed projects.maemo.org bugs NB #59248 and #59251
2144 * src/maemo/modest-maemo-utils.c:
2145 (on_camel_account_get_supported_secure_authentication_status),
2146 (on_camel_account_get_supported_secure_authentication),
2147 (modest_maemo_utils_get_supported_secure_authentication_methods):
2148 * src/maemo/modest-maemo-utils.h:
2149 Moved get_supported_secure_authentication() method here to be able
2150 to use it from easysetup wizard.
2152 * src/modest-pair.c: (on_pair_compare_as_string):
2153 Should compare string with first part of pair and not
2154 strcmp pairs which will crash.
2156 * src/modest-protocol-info.c:
2157 (modest_protocol_info_protocol_is_store):
2158 * src/modest-protocol-info.h:
2159 Added modest_protocol_info_get_auth_protocol_name()
2161 2007-06-03 Armin Burgmeier <armin@openismus.com>
2163 * src/modest-mail-operation.c:
2164 (modest_mail_operation_get_msgs_full): Set priv->account also when
2165 only retrieving a single message. This avoids a crash when canceling
2168 (modest_mail_operation_notify_end): Do not explicitely remove the
2169 operation from the queue but only emit the progress_changed signal.
2170 The queue itself listens to that signal to remove the operation when
2171 it is finished. This reduces coupling and removes a potential deadlock
2172 when modest_mail_operation_notify_end() is called from the queue
2173 itself. If that is a problem performance-wise, I would suggest to
2174 implement a status-changed signal or something.
2176 * src/modest-mail-operation-queue.c: Make sure to never call a
2177 function from another file while the queue is locked. This (hopefully)
2178 fixes another deadlock when exiting the application while retrieving
2181 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2183 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2184 Fixed build if libogs is not available
2186 2007-06-03 Christian Kellner <ckellner@openismus.com>
2188 * libmodest-dbus-client/libmodest-dbus-client.h:
2189 * libmodest-dbus-client/libmodest-dbus-client.c:
2190 (libmodest_dbus_client_delete_message):
2191 Implement deletion of messages (Client side).
2193 (modest_search_hit_free),
2194 (modest_search_hit_list_free):
2195 Utility functions to free the result hits.
2197 * src/dbus_api/modest-dbus-api.h:
2198 * src/dbus_api/modest-dbus-callbacks.c:
2199 (on_delete_message),
2200 (modest_dbus_req_handler):
2201 Implement deletion of messages (Server side).
2203 * tests/dbus_api/test_search.c: (main):
2206 * tests/dbus_api/Makefile.am:
2207 * tests/dbus_api/test_delete_message:
2208 Add little test for the message deletion logic
2210 2007-06-03 Armin Burgmeier <armin@openismus.com>
2212 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2213 when the operation queue was not empty. projects.maemo.org bug
2216 2007-06-03 Armin Burgmeier <armin@openismus.com>
2218 * src/widgets/modest-account-view.c
2219 (on_account_default_toggled): Toggle default account column
2220 explicitely instead of waiting for gconf notification (which is
2221 currently ignored). This should fix projects.maemo.org bug NB#56910
2222 for now. It should probably be removed when gconf notifications are
2225 2007-06-03 Christian Kellner <ckellner@openismus.com>
2227 * libmodest-dbus-client/libmodest-dbus-client.c:
2228 Removed debugging spew.
2230 * src/dbus_api/modest-dbus-callbacks.c:
2231 Added debugging info.
2233 * src/modest-search.c:
2234 (modest_search_all_accounts):
2235 Use tny_account_store_get_accounts () on the account store
2236 to get all accounts which is the way to get all accounts.
2238 * tests/dbus_api/test_search.c: (main):
2239 Make it possible to supply the search term on the command line.
2241 2007-06-03 Christian Kellner <ckellner@openismus.com>
2243 * libmodest-dbus-client/libmodest-dbus-client.c:
2244 * libmodest-dbus-client/libmodest-dbus-client.h:
2245 Implement searching for mesages over raw dbus. (Client side)
2247 * src/dbus_api/Makefile.am:
2248 * src/dbus_api/modest-dbus-api.h:
2249 * src/dbus_api/modest-dbus-callbacks.c:
2250 * src/dbus_api/modest-dbus-callbacks.h:
2251 Search framework (Server side). Also implement on_idle_open_message().
2253 * src/maemo/modest-platform.c: (modest_platform_init):
2254 Prepare for raw dbus/osso rpc interaction.
2256 * src/modest-search.h:
2257 Changed minsize from unspecific guint to guint32.
2259 * src/modest-search.c:
2261 Added strange hack which magically made tnymail work.
2263 (modest_search_folder),
2264 (modest_search_account),
2265 (modest_search_all_accounts):
2266 Implement helper functions to search all accounts, specific account
2269 * tests/dbus_api/Makefile.am:
2270 * tests/dbus_api/test_open_message.c:
2271 Read url to open from commandline.
2273 * tests/dbus_api/test_search.c:
2274 Implement small test for dbus search stuff
2276 2007-06-02 Armin Burgmeier <armin@openismus.com>
2278 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2279 include account type and account title. This fixes projects.maemo.org
2282 * src/maemo/modest-account-view-window.c: Set a title for the window.
2284 2007-06-02 Armin Burgmeier <armin@openismus.com>
2286 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2287 incoming and outgoing server name based on email address and server
2288 types as long as the names have not been edited manually. This fixes
2289 projects.maemo.org bug NB#58671.
2291 2007-06-02 Armin Burgmeier <armin@openismus.com>
2293 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2294 server type cannot be changed in future to the incoming details page
2295 when creating an account. This fixes projects.maemo.org bug NB#59029.
2297 2007-06-02 Armin Burgmeier <armin@openismus.com>
2299 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2300 and assigned max width chars so that they wrap instead of being
2301 truncated. Fixes projects.maemo.org bug NB#56126.
2303 2007-06-02 Armin Burgmeier <armin@openismus.com>
2305 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2306 introductory note to the connection specific smtp servers dialog, as
2307 section 8.12 of the email UI specification requires. This fixes
2308 projects.maemo.org bug NB#59212.
2310 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2312 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2313 Check for running mail operations, and offer to cancel them, as per the UI
2314 spec. This fixes projects.maemo.org bug NB#59041 .
2315 However, I suspect that tinymail may still use the network connection
2316 in ways that we cannot detect or cancel. But it should at least adapt to
2317 changes fairly well.
2319 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2321 * src/modest-tny-account-store.c: (recreate_all_accounts),
2322 (get_cached_accounts), (get_server_accounts): Do more sensible
2323 ref-counting of the temporarily-cached outbox accounts list. This seems
2324 to fix a crash when entering the password when the password was wrong.
2326 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2328 * src/gnome/modest-main-window.c: (connect_signals):
2329 * src/modest-tny-account-store.c: (get_password),
2330 (modest_tny_account_store_alert): Added comments and clues and
2331 commented-out code about how we currently fail to deal with connection
2332 errors and wrong passwords, and how we should.
2334 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2336 * src/widgets/modest-retrieve-combo-box.c:
2337 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2338 This fixes projects.maemo.org bug NB#58472 .
2340 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2342 * src/maemo/easysetup/modest-easysetup-wizard.c:
2343 (create_page_complete_easysetup):
2344 (create_page_complete_custom): Correct the last commit,
2345 putting the correct sentences in the correct pages.
2347 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/easysetup/modest-easysetup-wizard.c:
2350 (create_page_complete_custom): Show the second sentence of text
2351 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2354 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2356 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2357 Set the leave-on-server conf key by default. This fixes
2358 projects.maemo.org bug NB#59258 .
2360 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2362 * src/maemo/modest-account-view-window.c:
2363 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2364 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2367 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2369 * src/maemo/easysetup/modest-easysetup-wizard.c:
2370 (create_caption_new_with_asterisk):
2371 * src/maemo/modest-account-settings-dialog.c:
2372 (create_caption_new_with_asterisk):
2373 Uncomment the code to add the asterisk, because they are no longer in the
2374 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2375 (update_incoming_server_title): Add an asterisk here too.
2377 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2379 * src/maemo/modest-maemo-global-settings-dialog.c:
2380 (current_connection): Check that we are even connected before trying to
2381 get the current connection name, to prevent a warning.
2383 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2384 Change the comments because tny_maemo_conic_device_connect() is now meant to
2386 * src/modest-mail-operation.c:
2387 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2388 make sure we have a connection and fail if we can't connect.
2390 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2392 * src/maemo/modest-main-window.c:
2393 (on_account_store_connecting_finished): Do not try to get the
2394 connection ID if we are not really connected. I am surprised that
2395 this signal handler is called when we are not connected.
2397 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2399 * src/modest-error.h:
2400 * src/modest-ui-actions.c:
2401 (modest_ui_actions_get_msgs_full_error_handler):
2402 Renamed an enum, added comments, added an enum
2403 for retrieve-limit errors.
2405 * src/modest-mail-operation.c: (foreach_add_item),
2406 (internal_folder_observer_update), (update_account_thread),
2407 (modest_mail_operation_get_msgs_full):
2408 (modest_mail_operation_update_account),
2409 Added comments about how this works, and some code that should
2410 (but does not) check the retrieve-limit. See the TODO comment.
2412 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2414 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2415 Initialize help_id to fix the build. Warnings are good.
2417 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2419 * src/widgets/modest-hbox-cell-renderer.c:
2420 (modest_hbox_cell_renderer_append):
2421 * src/widgets/modest-vbox-cell-renderer.c:
2422 (modest_vbox_cell_renderer_append):
2423 Fix the last commit by doing an extra ref.
2425 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2427 * src/widgets/modest-hbox-cell-renderer.c:
2428 (modest_hbox_cell_renderer_append):
2429 * src/widgets/modest-vbox-cell-renderer.c:
2430 (modest_vbox_cell_renderer_append):
2431 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2432 to fix the build with Maemo Bora.
2433 However, there seems to be a remaining crash, probably due to reference
2436 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2438 * src/modest-tny-account.c:
2439 (modest_tny_account_new_for_local_folders):
2440 Use hildon_file_system_info_async_new() to get a better name for
2441 the memory card account, setting it as the account name.
2442 The timing seems to work, but this is probably
2443 not the best place to do this. See the TODO comment.
2444 * src/maemo/modest-main-window.c: (create_details_widget):
2445 * src/widgets/modest-folder-view.c: (text_cell_data):
2446 Use the tny account name instead of hardcoding a name.
2448 2007-05-30 Christian Kellner <ckellner@openismus.com>
2450 * src/modest-search.c: (modest_search):
2451 Correctly set part_search_func even if we have already parsed
2452 the query and thus a valid OgsTextSearcher object.
2454 2007-05-30 Christian Kellner <ckellner@openismus.com>
2457 Search and check for libogs.
2460 Incooparte the ogs build env.
2462 * src/modest-mime-part-search-stream.c:
2463 * src/modest-mime-part-search-stream.h:
2464 Removed since we do the real searching now in modest-search.c.
2466 * src/modest-search.c:
2467 * src/modest-search.h:
2468 Implement support for ogs. We use that if available and requested
2469 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2470 should now handle the corner case when the search term is spread
2471 across multiple reads.
2472 Also the logic in modest_search () was corrected to search all
2473 requested fields until one is found.
2475 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2477 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2479 * src/modest-init.h:
2480 * src/modest-init.c: Made modest_init_local_folders() take a
2481 path and be public so we can iniitialize maildir folders on
2484 * src/modest-local-folder-info.h:
2485 * src/modest-local-folder-info.c:
2486 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2488 * src/modest-tny-account.c:
2489 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2490 still means the standard local-folders path on the local volume.
2492 * src/modest-tny-account-store.c:
2493 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2494 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2495 all accounts when that happens.
2496 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2497 this too, so it shows up in the treeview.
2499 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2501 * src/maemo/modest-maemo-global-settings-dialog.c:
2502 (current_connection):
2503 * src/widgets/modest-global-settings-dialog.c:
2504 (current_connection_default):
2505 Use the enum values instead of 0, 1 and -1,
2506 to make the code clearer.
2508 * src/modest-account-mgr-helpers.c:
2509 (modest_account_mgr_get_connection_specific_smtp): Make this code
2512 * src/modest-runtime.h:
2513 * src/modest-runtime.c:
2514 Added modest_runtime_remove_all_send_queues().
2515 * src/maemo/modest-main-window.c:
2516 (on_account_store_connecting_finished): Recreate the send queues,
2517 using the appropriate transport accounts for this new connection.
2518 Some futher adapting might be needed if the old send queues are not
2519 automatically stopped at this point.
2521 * src/modest-tny-account-store.c: (get_server_accounts):
2522 Create the connection-specific transport accounts, so that they can
2523 be found later by their ID.
2525 * src/modest-tny-account.h:
2526 * src/modest-tny-account.c:
2527 Added modest_tny_account_new_from_server_account_name().
2528 modest_tny_account_new_from_server_account(): Do not create the
2529 send queues here, because they will be
2530 recreated anyway when the connection changes for the first time.
2532 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2534 * src/modest-local-folder-info.h:
2535 * src/modest-local-folder-info.c:
2536 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2537 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2538 tbox_folder): Take a modest account name instead of a server TnyAccount,
2539 so we can have per-modest-account rather than per-transport-account
2541 We must make sure that we change or recreate the exisitng send queues
2542 when the connection changes for connection-specific transport accounts.
2544 * src/modest-tny-account-store.c:
2545 (create_per_account_local_outbox_folders): Create outboxed per modest
2546 account, not per transport account.
2548 * src/modest-tny-account.h:
2549 * src/modest-tny-account.c:
2550 (modest_tny_account_get_special_folder): For outboxes, get the
2551 parent modest account name. The account is ignored for other folders.
2552 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2553 modest account name rather than a server TnyAccount.
2555 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2557 * src/modest-tny-account.c:
2558 (modest_tny_account_new_from_server_account):
2559 Call modest_runtime_get_send_queue() immediately after creating transport
2560 accounts, so that they start trying to send email from the outbox as soon
2561 as possible at startup. This is probably what we want.
2563 * src/modest-mail-operation.c: (update_account_thread):
2564 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2565 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2566 * src/modest-tny-send-queue.h:
2567 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2568 (modest_ui_actions_on_send):
2569 Added comments about how sending works, though it needs some more work.
2571 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2573 * src/modest-tny-account.c:
2574 (modest_tny_account_get_special_folder): Add TODO because this fails when
2575 the network is busy.
2576 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2577 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2578 Do not try to show this window when there is no active account. The UI
2579 specs does not tell us what to do in this case.
2581 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2585 * src/maemo/Makefile.am:
2586 * src/widgets/Makefile.am: Some dist fixes.
2588 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2590 * src/maemo/modest-connection-specific-smtp-window.c:
2591 (on_button_edit): Make the code clearer, to prevent a double free.
2593 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2595 * src/maemo/modest-account-settings-dialog.c:
2596 (modest_account_settings_dialog_set_account_name),
2597 Check the connection-specific smtp servers checkbox if there are any.
2599 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2600 (modest_connection_specific_smtp_edit_window_init):
2601 Start with a suitable port number.
2603 * src/modest-account-mgr-helpers.h:
2604 * src/modest-account-mgr-helpers.c: Added
2605 modest_account_mgr_get_has_connection_specific_smtp().
2607 (modest_account_mgr_set_connection_specific_smtp),
2608 (modest_account_mgr_remove_connection_specific_smtp),
2609 (modest_account_mgr_get_has_connection_specific_smtp),
2610 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2611 connection-specific smtp server accounts in the account, rather than
2612 the server account conf dir.
2614 This fixes bug projects.maemo.org bug NB#58263 .
2616 * src/modest-tny-account-store.c:
2617 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2618 if there are no server accounts yet, to prevent an infinite loop when there
2619 are no accounts. Document that one must be called before the other.
2621 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2623 * src/modest-account-mgr-helpers.c:
2624 (modest_account_mgr_get_default_account): Make sure that at least
2625 one account is always the default, if there are any enabled accounts.
2626 This is just a sanity check that shouldn't be necessary.
2628 * src/modest-account-mgr-priv.c:
2629 (_modest_account_mgr_account_from_key): Unescape the conf key to
2630 get the real account name. For instance, this is an issue if a space
2631 was in the account name, which can happen because the account name
2632 is generated from the display name.
2633 (_modest_account_mgr_get_account_keyname): Always escape the
2635 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2636 Unescape the conf keys to get the real account names.
2638 For instance, previously the is-default radio button in the accounts
2639 list was not checked for any accounts at first. This fixes that,
2640 and might fix several similar bugs.
2642 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2644 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2645 Removed some debug printfs.
2647 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2649 Modest on-disk outbox directories are now here, for instance:
2650 $HOME/.modest/outboxes/<account-id-1>/outbox
2651 $HOME/.modest/outboxes/<account-id-2>/outbox
2653 $HOME/.modest/local-folders/outbox
2654 so we can have a separate outbox for each account.
2655 But they are shown as one outbox in the GtkTreeView, by using a
2656 TnyMergeFolder in a ModestTnySimpleFolderStore.
2659 * src/modest-tny-simple-folder-store.c:
2660 * src/modest-tny-simple-folder-store.h:
2661 Added ModestTnySimpleFolderStore, used to contain folders from
2662 other folder stores, such as other accounts.
2664 * src/modest-tny-outbox-account.h:
2665 * src/modest-tny-outbox-account.c:
2666 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2667 used for the per-account local outbox folders.
2669 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2670 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2671 only use this (internally) now for the non-outbox local folders.
2673 * src/modest-init.h:
2674 * src/modest-init.c: Added modest_init_one_local_folder(), for
2675 setting up the directory structure for each local folder.
2677 * src/modest-local-folder-info.c:
2678 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2679 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2681 * src/modest-local-folder-info.h:
2682 * src/modest-tny-account-store.c: (on_account_removed),
2683 (on_account_changed), (create_per_account_local_outbox_folders),
2684 (get_server_accounts), (modest_tny_account_store_get_accounts),
2685 (modest_tny_account_store_get_tny_account_by_account),
2686 (modest_tny_folder_store_is_virtual_local_folders):
2688 * src/modest-tny-account.h:
2689 * src/modest-tny-account.c:
2690 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2691 to create an on-disk per-account local outbox folder for each
2693 (create_per_account_local_outbox_folders): Create a local outbox folder
2694 for each transport account.
2695 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2696 for all local folders.
2698 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2699 instead of using g_object_get/set() directly. It is clearer.
2701 (modest_tny_folder_store_get_message_count),
2702 (modest_tny_folder_store_get_local_size
2703 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2704 because we now use these with non-acount folder stores.
2706 (modest_tny_account_get_special_folder),
2707 (modest_tny_account_new_from_server_account),
2708 (modest_tny_account_new_from_account):
2709 (recurse_folders): Adjust to the new outbox system.
2711 * src/modest-tny-folder.h:
2712 * src/modest-tny-folder.c:
2713 (modest_tny_folder_is_local_folder),
2714 (modest_tny_folder_get_local_folder_type),
2715 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2717 * src/widgets/modest-main-window.h:
2718 * src/maemo/modest-main-window.c: (create_details_widget),
2719 (modest_main_window_set_contents_style): Show details for any folder store,
2722 (modest_tny_folder_get_rules):
2723 Remove the const. C does not support constness enough for this.
2725 * src/modest-ui-actions.c:
2726 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2727 make all outboxes appear as one, in the usual local-folders tree node.
2729 (set_active_account_from_tny_account),
2730 (modest_ui_actions_on_folder_selection_changed):
2731 * src/widgets/modest-folder-view.c: (text_cell_data),
2732 (icon_cell_data), (filter_row),
2733 (add_account_folders_to_merged_folder),
2734 (add_account_folders_to_simple_folder_store), (),
2735 (get_cmp_rows_type_pos), (cmp_rows),
2736 (modest_folder_view_set_account_id_of_visible_server_account):
2737 Adjust to the new outbox system, using generic folder stores and folders
2738 in the GtkTreeModel.
2740 2007-05-23 Christian Kellner <ckellner@openismus.com>
2742 * src/modest-mail-operation.c:
2743 (modest_mail_operation_update_account):
2744 Use info->max_size instead of unintialized local var [small
2745 build fix]. (Added TODO to review that change since I don't
2748 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2750 * libmodest-dbus-client/libmodest-dbus-client.c:
2751 (libmodest_dbus_client_compose_mail): function added
2752 * src/dbus_api/modest-dbus-api.h:
2753 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2754 (on_compose_mail): Implementation of the SendAsMail functionality
2756 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2758 * src/modest-account-mgr.c:
2759 (modest_account_mgr_add_server_account): Set the secure-connection
2760 conf key for transport accounts as well as store accounts. I don't know
2761 why the if was there. For instance, this makes sure that we use SSL
2762 for the gmail preset from the easysetup wizard.
2764 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2766 * src/gnome/modest-main-window.c:
2767 (on_account_store_connecting_finished), (connect_signals):
2768 * src/maemo/modest-main-window.c:
2769 (on_account_store_connecting_finished), (connect_signals),
2770 (modest_main_window_new):
2771 Handle TnyAccountStore::connecting-finished instead of
2772 TnyDevice::connection-changed, because we cannot actually perform
2773 operations on accounts until TnyAccountStore has itself responded to
2774 the TnyDevice::connection-changed signal. This prevents a GError from
2776 Do not try to update at startup, because we (at least on scratchbox)
2777 already do an update at startup when the device goes online.
2778 This prevents a GError from tinymail.
2779 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2780 Added TODO about stopping simultaneous operations.
2782 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2784 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2785 * src/modest-mail-operation-queue.c:
2786 (modest_mail_operation_queue_remove):
2787 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2788 about where they happened.
2790 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2792 * src/modest-ui-actions.c:
2793 (modest_ui_actions_on_password_requested): Make sure that the remember
2794 output parameter is always TRUE.
2796 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2798 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2799 Show a OK/Cancel dialog if the error is a question, though we still do not
2800 know anything more about what we are asking the user.
2801 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2802 Fix an uninitialized variable (helper). This is a logic error, however.
2804 2007-05-21 Christian Kellner <ckellner@openismus.com>
2806 * src/modest-search.h:
2807 Correct bit shifting in the ModestSearchFlags enum.
2809 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2811 * src/modest-tny-account.c:
2812 (modest_tny_account_new_from_server_account): Do not use the lsub and
2813 check-all hard-coded IMAP options when using POP.
2815 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2817 * src/modest-tny-account.c:
2818 (modest_tny_account_new_from_server_account):
2819 Use NULL for the secure-auth method for POP when Password auth has been
2820 specified by the user, as we already do for IMAP. "auth=Login" causes
2821 an error from camel or the server.
2823 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2825 * src/maemo/modest-account-settings-dialog.c:
2826 (create_page_account_details),
2827 (modest_account_settings_dialog_set_account_name):
2828 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2829 for the leave-on-server checkbox, rathr than just the checkbox, when
2830 the protocol is not POP.
2832 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2834 * src/widgets/modest-account-view.c:
2835 * src/widgets/modest-account-view.h:
2836 Added modest_account_view_select_account() which will be useful later
2837 to asynchronously re-select the edited account.
2839 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2841 * src/maemo/modest-account-settings-dialog.c:
2842 (modest_account_settings_dialog_set_account_name):
2843 Automatically choose the port numbers based on the secure authentication
2844 methods, if they have not been chosen before.
2845 This fixes projects.maemo.org bug NB#56273 .
2847 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2849 * src/maemo/modest-main-window-ui.h:
2850 * src/modest-ui-actions.c:
2851 * src/modest-ui-actions.h:
2852 Connect the Tools/SMTP Servers menu item to
2853 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2854 SMTP servers dialog, as in the UI specification and saves changes when it
2855 is closed. This fixed projects.maemo.org bug NB#56305 .
2857 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2859 * src/maemo/modest-connection-specific-smtp-window.c:
2860 (modest_connection_specific_smtp_window_init):
2861 Use gtk_window_set_default_size() to make this window big enough, so
2862 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2864 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2866 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2867 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2868 (modest_connection_specific_smtp_edit_window_init),
2869 Do not try to connect to a combobox signal before the combobox exists.
2870 This fixes the cras in projects.maemo.org bug NB#56288 .
2871 (modest_connection_specific_smtp_edit_window_get_settings):
2872 Remove the server_account_name parameter which was being checked for NULL
2873 though it was not used.
2875 * src/maemo/modest-connection-specific-smtp-window.c:
2876 (modest_connection_specific_smtp_window_fill_with_connections),
2877 (on_button_edit), (modest_connection_specific_smtp_window_init):
2878 Correct the number of treemodel columns to prevent a warning.
2879 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2880 libconic does not work.
2882 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2884 * src/modest-tny-account.c:
2885 (modest_tny_account_new_from_server_account):
2886 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2887 SMTP when "None" was chosen by the user. However, with my SMTP server that
2888 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2891 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2893 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2894 to explain the memory management issue with the ID in the ModestPair.
2896 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2897 (add_sending_page), (modest_account_assistant_finalize):
2898 * src/gnome/modest-gnome-global-settings-dialog.c:
2899 (create_updating_page), (create_composing_page):
2900 * src/gnome/modest-msg-edit-window.c: (get_transports),
2901 (init_window), (modest_msg_edit_window_finalize),
2902 (modest_msg_edit_window_get_msg_data):
2903 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2904 * src/gnome/modest-transport-widget.c:
2905 (modest_transport_widget_finalize), (smtp_configuration):
2906 * src/maemo/modest-maemo-global-settings-dialog.c:
2907 (create_updating_page), (create_composing_page):
2908 * src/maemo/modest-msg-edit-window.c: (get_transports),
2909 (init_window), (modest_msg_edit_window_finalize),
2910 (modest_msg_edit_window_get_msg_data),
2911 (modest_msg_edit_window_free_msg_data):
2912 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2913 (modest_store_widget_finalize):
2914 * src/maemo/modest-transport-widget.c:
2915 (modest_transport_widget_finalize), (smtp_configuration):
2916 * src/modest-main.c: (send_mail):
2917 * src/widgets/modest-combo-box.h:
2918 * src/widgets/modest-global-settings-dialog-priv.h:
2919 * src/widgets/modest-global-settings-dialog.c:
2920 (modest_global_settings_dialog_finalize):
2921 * src/widgets/modest-msg-edit-window.h:
2922 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2923 as long as the combo box, to prevent use of freed memory for the ID.
2925 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2927 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2928 get_accounts(), to make this clearer. Do not check for the enabled gconf
2929 key, because we do not use this for server accounts (at least, not yet).
2930 This allows us to send email again.
2932 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2934 * src/maemo/modest-platform.c:
2935 (on_modest_conf_update_interval_changed), (modest_platform_init):
2936 Only respond to this particular key change. All these strcmp()s cannot be
2939 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2941 * src/maemo/modest-maemo-global-settings-dialog.c:
2942 (current_connection): Prevent a crash in scratchbox when
2943 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2944 * src/maemo/modest-platform.c:
2945 (on_modest_conf_update_interval_changed), (modest_platform_init):
2946 Get the update interval from gconf and reset it when the gconf key changes.
2948 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2950 * src/modest-protocol-info.c:
2951 * src/modest-protocol-info.h: Adde enum-specific get functions,
2952 instead of using a ModestProtocolType enum parameter.
2954 * src/gnome/modest-account-assistant.c:
2955 * src/gnome/modest-store-widget.c:
2956 * src/gnome/modest-store-widget.h:
2957 * src/gnome/modest-transport-widget.c:
2958 * src/gnome/modest-transport-widget.h:
2959 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2960 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2961 * src/maemo/easysetup/modest-easysetup-wizard.c:
2962 * src/maemo/modest-account-settings-dialog.c:
2963 * src/maemo/modest-account-settings-dialog.h:
2964 * src/maemo/modest-store-widget.c:
2965 * src/maemo/modest-store-widget.h:
2966 * src/maemo/modest-transport-widget.c:
2967 * src/maemo/modest-transport-widget.h:
2968 * src/modest-account-mgr-helpers.c:
2969 * src/modest-account-mgr-helpers.h:
2970 * src/modest-account-mgr.c:
2971 * src/modest-account-mgr.h:
2972 * src/modest-tny-account.c:
2973 * src/modest-tny-folder.c:
2974 * src/widgets/modest-account-view.c:
2975 * src/widgets/modest-retrieve-combo-box.c:
2976 * src/widgets/modest-retrieve-combo-box.h:
2977 * src/widgets/modest-secureauth-combo-box.c:
2978 * src/widgets/modest-serversecurity-combo-box.c:
2979 * src/widgets/modest-serversecurity-combo-box.h:
2980 * tests/check_account-mgr.c:
2981 Use the specific functions, and use the re-renamed enum values for GNOME too.
2983 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2985 * src/modest-pair.h:
2986 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2987 so we can get the second based on the first.
2989 * src/maemo/modest-account-settings-dialog.h:
2990 * src/maemo/modest-account-settings-dialog.c:
2991 Added get_supported_secure_authentication_methods(), though it is mostly
2992 commented-out for now until the necessary API is committed to tinymail.
2993 (modest_account_settings_dialog_set_account_name),
2994 (save_configuration): Request the supported authentication methods from the
2995 server, so we can choose a working method.
2997 * src/modest-tny-account-store.h:
2998 * src/modest-tny-account-store.c:
2999 (modest_tny_account_store_get_session): Rename from
3000 tny_account_store_get_session().
3002 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3004 * src/modest-protocol-info.h: Split the ModestProtocol enum
3005 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3006 There was no need to have these unrelated values in one enum.
3008 * src/: many files: Adapted to changed enum. This makes the code a bit
3009 clearer, and the compiler could catch some errors.
3011 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3013 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3014 Show the detailed internal camel error message when an error happens
3015 during the configuration, so that our testers can give us more clues.
3016 For instance, in projects.maemo.org bug NB#56910 .
3018 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3020 * src/modest-tny-account.c:
3021 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3022 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3024 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3026 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3027 * src/maemo/modest-account-settings-dialog.c:
3028 (modest_account_settings_dialog_set_account_name),
3029 (save_configuration): For the incoming secure authentication checkbox,
3030 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3031 the UI specification. PLAIN does not seem to be supported for most IMAP
3032 servers anyway, and I am not sure what it would mean.
3033 However, we probably need to discover which of the secure-authentication
3034 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3035 * src/modest-account-mgr-helpers.c:
3036 (modest_account_mgr_get_server_account_data):
3038 * src/modest-tny-account.c:
3039 (modest_tny_account_new_from_server_account):
3040 Use tny_account_set_mech() to set secure-authentication methods,
3041 with some special-casing for IMAP, based on my observations of how
3044 * src/modest-account-mgr-helpers.h:
3045 * src/modest-account-mgr.c:
3046 * src/modest-defs.h: Comment that the URI is only used for local folders.
3048 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3050 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3051 parameter const, just to be neat.
3052 * src/modest-text-utils.c: (modest_text_utils_inline):
3053 End g_strconcat() with NULL, as its documentation says. This is almost
3054 certainly the cause of my crash at startup on the device. Interestingly,
3055 valgrind doesn't tell us about these errors.
3057 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3059 * scripts/build-packages: Added more precise comments about how to use
3060 this script, though I still get this error:
3061 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3062 error building tinymail
3064 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3066 * src/maemo/modest-main-window.c: (on_account_update):
3067 Very slight cleanup, hoping to make it simpler to discover what causes
3068 a crash here sometimes.
3070 * src/modest-tny-account.c:
3071 (modest_tny_account_new_from_server_account): Set the port. Added
3072 comments about the options and a TODO comment because I need to find out
3073 how to specify the secure authentication method.
3075 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3077 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3078 changed CFlags paths form modest to libmodest
3080 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3082 * src/modest-account-mgr-helpers.c:
3083 (modest_account_mgr_get_server_account_data),
3084 (modest_account_mgr_free_server_account_data):
3085 * src/modest-account-mgr-helpers.h:
3086 * src/modest-account-mgr.c:
3087 (modest_account_mgr_add_server_account):
3088 * src/modest-defs.h:
3089 * src/modest-tny-account.c:
3090 (modest_tny_account_new_from_server_account):
3091 Determine the options for tny_camel_account_add_option() here,
3092 based on the settings, rather than storing them directly in gconf.
3094 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3096 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3097 Show a more friendly error dialog now that we expect (from the tinymail
3098 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3100 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3102 * src/maemo/modest-main-window.c: (on_account_update): Check that
3103 account_name is not NULL, to prevent a crash at startup that I am
3104 seeing on the N800. I do wonder why it is NULL.
3106 * src/maemo/easysetup/modest-easysetup-wizard.c:
3107 (create_page_user_details):
3108 * src/maemo/modest-account-settings-dialog.c:
3109 (create_page_user_details), (create_page_outgoing):
3110 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3111 (modest_connection_specific_smtp_edit_window_init):
3112 * src/modest-ui-actions.c:
3113 (modest_ui_actions_on_password_requested):
3114 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3115 might do something useful with the on-screen keyboard.
3117 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3119 * src/maemo/modest-main-window.c: (on_account_update):
3120 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3121 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3123 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3125 * src/modest-tny-account-store.c: (on_account_changed):
3126 Correct the signature of this signal handler.
3128 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3130 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3131 Show a HildonNote instead of a GtkDialog for Maemo.
3133 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3135 * src/widgets/modest-account-view.h:
3136 * src/widgets/modest-account-view.c: (on_account_changed),
3137 (on_account_removed). Added a boolean flag, set/unset by
3138 modest_account_view_block_conf_updates(),
3139 modest_account_view_unblock_conf_updates() to prevent unnecessary
3140 updates, but this is not very useful because the gconf notifications are
3141 so delays (maybe only on Maemo Bora).
3142 So auto-updating is turned off, and these functions do an explicit
3143 update when necessary.
3144 However, something else is still doing too much work when adding/removing
3145 accounts, probably in another part of the application.
3147 * src/maemo/modest-account-view-window.c:
3148 (on_delete_button_clicked), (on_edit_button_clicked),
3149 (on_new_button_clicked): Use the new functions.
3151 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3153 * src/modest-account-mgr-helpers.c:
3154 (modest_account_mgr_set_first_account_as_default):
3155 Sort the list of names alphabetically-by-title, so we choose the first one
3157 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3158 alphabetically by the title.
3160 This fixes projects.maemo.org bug NB#56418 .
3162 * src/modest-account-mgr-priv.c:
3163 (_modest_account_mgr_account_from_key):
3164 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3165 avoid a valgrind error, and possible random behaviour.
3167 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3169 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3170 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3171 tinymail documentation to say that this can be expected.
3172 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3173 pretty, and should not happen, but I would prefer to know when it does.
3175 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3177 * configure.ac: When using the older hildon version, probably on Bora,
3178 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3180 * src/widgets/modest-attachment-view.c:
3181 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3184 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3186 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3187 Implemented the prototype. Can be tested with
3188 tests/dbus_api/test_open_message:
3190 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3192 * src/modest-tny-account-store.c:
3193 (modest_tny_account_store_instance_init), (get_password):
3194 * src/modest-ui-actions.c:
3195 (modest_ui_actions_on_password_requested):
3196 Do not store the password in gconf, because this function is called
3197 for non-remembered passwords. Actually use the cached (in the hash map)
3198 password instead of releasing it.
3199 The password will now not be remembered if it is asked via the protected
3200 password dialog, as per the UI spec.
3202 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3204 * src/modest-defs.h:
3205 * src/modest-account-mgr-helpers.h:
3206 * src/modest-account-mgr-helpers.c:
3207 Added modest_server_account_get_username_has_succeeded(),
3208 modest_server_account_set_username_has_succeeded().
3209 (modest_server_account_set_username),
3210 Reset the has-succeeded flag if the username changes.
3212 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3213 * src/maemo/modest-connection-specific-smtp-window.c:
3214 (modest_connection_specific_smtp_window_save_server_accounts):
3215 Use modest_server_account_set_username() instead of using
3216 modest_conf_set_string() directly, so that the has-succeeded flag is always
3219 * src/modest-ui-actions.c:
3220 (modest_ui_actions_on_password_requested): Dim the username entry if
3221 the username has ever worked, as per the UI spec.
3223 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3225 * src/modest-tny-account-store.c: (get_password):
3226 * src/modest-ui-actions.c:
3227 (modest_ui_actions_on_password_requested):
3228 Allow the username to be changed too, though there is more work to
3229 be done on exactly how this behaves.
3231 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3233 * src/modest-account-mgr-helpers.h:
3234 * src/modest-account-mgr-helpers.c:
3235 Added modest_account_mgr_get_display_name(),
3236 modest_server_account_get_username(),
3237 modest_server_account_set_username(),
3238 modest_server_account_set_password(),
3239 modest_server_account_get_hostname() functions so we do not need to
3240 use the conf API directly.
3242 * src/maemo/modest-main-window.c: (connect_signals):
3243 Actually connect ot the ModestAccountStore::request-password signal,
3244 so that we show the dialog when the password is requested by Tinymail,
3245 for isntance if it is empty.
3247 * src/modest-marshal.list:
3248 * src/modest-tny-account-store.c:
3249 (modest_tny_account_store_class_init), (get_password),
3250 (modest_tny_account_store_alert):
3251 * src/modest-tny-account-store.h:
3252 * src/modest-ui-actions.h:
3253 * src/modest-ui-actions.c:
3254 (modest_ui_actions_on_password_requested):
3255 Change the signal parameters, so it is obvious that we are providing
3256 the non human-readable server name, and receiving both the username
3257 and password, though changing of the username is not yet implemented.
3258 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3259 for the GNOME version.
3261 This should fix the projects.maemo.org bug NB#56209, though it does not
3262 work on Bora, because the gconf_client_get() for the password fails
3263 immediately after we save it with gconf_client_set().
3265 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3268 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3269 caused an undefined symbol error:
3270 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3272 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3274 * src/modest-tny-account-store.c:
3275 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3276 using a GError instead of a string message, so we can translate it in
3279 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3281 * src/maemo/modest-address-book.c:
3282 (modest_address_book_check_names):
3283 * src/maemo/modest-msg-view-window.c:
3284 (modest_msg_view_window_clipboard_owner_change):
3285 * src/modest-init.c: (modest_init_init_ui):
3286 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3287 (update_folders_cb), (modest_mail_operation_update_account):
3288 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3289 (modest_ui_actions_on_msg_attachment_clicked),
3290 (modest_ui_actions_on_msg_recpt_activated):
3291 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3292 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3293 (modest_msg_view_search_next):
3294 * src/widgets/modest-recpt-editor.c:
3295 (modest_recpt_editor_on_button_release_event),
3296 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3297 g_message(). At this point we should only be seeing interesting errors on
3298 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3300 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3302 (modest_wizard_dialog_force_title_update):
3303 * src/maemo/easysetup/modest-wizard-dialog.h:
3304 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3305 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3306 can update the title when appropriate. Otherwise the title is wrong if the
3307 pages are added after adding the notebook to the dialog.
3308 This must be a problem in HildonWizardDialog too.
3309 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3311 * src/maemo/easysetup/modest-easysetup-wizard.c:
3312 (create_subsequent_customsetup_pages),
3313 (create_subsequent_easysetup_pages):
3314 Call modest_wizard_dialog_force_title_update() so that the title is
3315 correct even with GTK+ < 2.10.
3316 This fixes projects.maemo.org bug NB#56145 .
3318 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3320 * src/maemo/modest-platform.c:
3321 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3322 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3325 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3327 * src/widgets/modest-window.h:
3328 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3329 and modest_window_save_state(), which invokes it.
3331 * src/widgets/modest-window-mgr.h:
3332 * src/widgets/modest-window-mgr.c:
3333 Added modest_window_mgr_save_state_for_all_windows(), which calls
3334 the save_state vfunc on all registered windows, if implemented.
3336 * src/gnome/modest-msg-edit-window.c:
3337 * src/gnome/modest-msg-view-window.c:
3338 * src/maemo/modest-msg-edit-window.c:
3339 * src/maemo/modest-msg-view-window.c:
3340 * src/maemo/modest-main-window.c:
3341 Specify the existing save_settings functions as implementations of
3342 ModestWindow::save_state_func().
3344 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3345 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3346 enabling hibernation, for instance.
3348 We may need to do the same thing for restoring settings.
3351 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3353 * src/widgets/modest-window-mgr.c:
3354 * src/widgets/modest-window-mgr.h:
3355 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3356 modest_window_mgr_get_hibernation_is_prevented().
3358 * src/maemo/modest-main-window.c:
3359 (on_hildon_program_is_topmost_notify): Prevent hibernation
3360 (possible when the application goes to the background in the WM),
3361 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3363 * src/maemo/easysetup/modest-easysetup-wizard.c:
3364 (modest_easysetup_wizard_dialog_init):
3365 * src/maemo/modest-account-settings-dialog.c:
3366 (modest_account_settings_dialog_init):
3367 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3368 (modest_connection_specific_smtp_edit_window_init):
3369 * src/maemo/modest-connection-specific-smtp-window.c:
3370 (modest_connection_specific_smtp_window_init):
3371 * src/maemo/modest-signature-editor-dialog.c:
3372 (modest_signature_editor_dialog_init):
3373 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3374 prevent hibernation while any of these account settings dialogs are open.
3376 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3378 * src/maemo/Makefile.am:
3379 * src/maemo/modest-osso-state-saving.c:
3380 * src/maemo/modest-osso-state-saving.h: Added
3381 modest_osso_load_state() and modest_osso_save_state() though they do
3382 nothing now. They should iterate through all the open windows and load/save
3384 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3385 save state when closing.
3387 * src/maemo/modest-main-window.c:
3388 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3389 Add a notification handler for the HildonProgram::is-topmost property,
3390 so we can allow hibernation when the application goes into the background.
3391 But we still need to detect when the accounts setup windows are open so
3392 we can stop hibernation when they are open.
3393 To do this, I also added the main window the HildonProgram. This might have
3394 other side-effects/benefits, and should maybe be done for other windows.
3396 * src/maemo/modest-osso-autosave-callbacks.h:
3397 * src/maemo/modest-osso-autosave-callbacks.c:
3398 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3399 though it does not do anything yet, and we might never need this to do
3400 anything. For instance, we already save drafts.
3402 * src/maemo/modest-platform.c: (modest_platform_init):
3403 Specify the libosso auto-save callback.
3405 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3407 * src/maemo/modest-platform.c:
3408 (modest_platform_set_update_interval):
3409 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3410 aparently stays valid between application instances, so we can use this
3411 to remove and reset it later. According to a maemo-developers email from
3414 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3416 * configure.ac: Depend on libalarm for Maemo.
3418 * src/dbus_api/modest-dbus-api.h:
3419 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3420 (on_send_receive), (modest_dbus_req_handler):
3421 Handle a SEND_RECEIVE D-Bus method.
3423 * libmodest-dbus-client/libmodest-dbus-client.c:
3424 (libmodest_dbus_client_send_and_receive):
3425 * libmodest-dbus-client/libmodest-dbus-client.h:
3426 Add C convenience functions for calling the new D-Bus method.
3428 * src/modest-platform.h:
3429 * src/gnome/modest-platform.c:
3430 * src/maemo/modest-platform.c:
3431 Added modest_platform_set_update_interval(), which uses the
3432 alarmd API on Maemo.
3433 (modest_platform_init),
3434 Call modest_platform_set_update_interval(), using a hard-coded
3435 interval for now (until the global settings dialog is implemented),
3436 though I am not sure that this makes sense yet.
3438 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3440 * src/dbus_api/modest-dbus-callbacks.c:
3441 (modest_osso_cb_hw_state_handler):
3442 * src/dbus_api/modest-dbus-callbacks.h:
3443 * src/maemo/modest-platform.c: (modest_platform_init):
3444 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3445 in case this has some effect on the ability for Maemo to ping the
3448 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3450 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3451 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3452 warning. It is probably a logic error, but I need to fix the build.
3454 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3456 * src/modest-account-mgr.h:
3457 * src/modest-account-mgr.c:
3458 (modest_account_mgr_account_names): Add a gboolean enabled_only
3459 parameter, so we can get lists of onlt the enabled accounts.
3461 (modest_account_mgr_add_account),,
3462 (modest_account_mgr_account_with_display_name_exists):
3463 * src/maemo/modest-msg-edit-window.c: (get_transports):
3464 * src/modest-account-mgr-helpers.c:
3465 (modest_account_mgr_set_first_account_as_default):
3466 * src/modest-init.c: (init_default_account_maybe):
3467 * src/modest-tny-account-store.c: (get_accounts):
3468 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3469 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3470 * tests/check_account-mgr.c: (START_TEST):
3471 Provide the extra parameter, as appropriate.
3473 * src/widgets/modest-account-view.c: (update_account_view):
3474 Do not show disabled accounts (meaning that there is no way to
3475 enable/disable accounts in the UI (the feature is not in our UI
3476 specification), so we can use this internally only to mark unfinished
3477 or temporary account data.
3479 * src/maemo/easysetup/modest-easysetup-wizard.c:
3480 (create_account): Add boolean enable parameter, so we can specify FALSE
3481 to create the temporary account.
3482 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3483 (on_before_next): When finishing, when there is a temporary account, just
3485 Also, use a timeout to delay the showing of the dialog until gconf is likely
3486 to return correct information, due to a maemo gconf bug that is fixed in
3487 osso 1.1, but not yet in Bora.
3488 However, the dialog stays on screen after it is destroyed.
3490 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3491 for invalid data when cancelling. Use a hildon note instead of a dialog
3492 to complain about invalid data. Do not show the account-saved note if the
3493 account is disabled (a temporary account that will not really be saved for use
3496 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3498 * src/modest-account-mgr-helpers.h:
3499 * src/modest-account-mgr-helpers.c:
3500 Added modest_account_mgr_unset_default_account(),
3501 Added modest_account_mgr_set_first_account_as_default().
3503 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3504 If it was the default account, unset the default account name.
3506 * src/maemo/modest-account-view-window.c:
3507 (on_delete_button_clicked): If it was the default account,
3508 set the first remaining account as the default instead.
3510 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3511 a NULL account or a NULL default account, to prevent a crash. This should
3512 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3515 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3517 * src/widgets/modest-recpt-editor.c:
3518 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3519 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3520 TODO comment for this. This fixes the build.
3522 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3523 be the best place for it. This will in future update all auto-update accounts,
3524 rather than just the current/default account, when that gconf key exists.
3525 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3526 if there are no accounts, before calling do_send_receive().
3527 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3529 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3530 * src/maemo/modest-main-window-ui.h:
3531 * src/maemo/modest-main-window.c: (on_connection_changed),
3532 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3533 directly, becaue the signal handler does more.
3535 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3537 * src/modest-account-mgr-helpers.c:
3538 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3539 for the case that the account does not exist.
3541 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3542 (equivalent to the modest account name) rather than the tinymail account name
3543 (equivalent to the modest account title - human readable) to get the account data.
3544 Check for null account data to prevent the crash, and add a TODO comment saying that
3545 this needs fixing because it is using the server account name instead of the account name.
3547 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3549 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3550 * src/maemo/modest-account-settings-dialog.c: (show_error),
3552 Use hildon_note_new_information() for informative and error messages,
3553 which seems to be expected for Maemo applications (no documentation that I know of
3554 says this). I am surprised that there is no distinction between info and error
3557 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3559 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3560 it is easy to find where this is used.
3562 * src/maemo/easysetup/modest-easysetup-wizard.c:
3563 (create_page_welcome), (create_page_account_details),
3564 (create_page_user_details), (create_page_complete_easysetup),
3565 (create_page_custom_incoming), (create_page_custom_outgoing),
3566 (create_page_complete_custom):
3567 * src/maemo/modest-account-settings-dialog.c:
3568 (create_page_account_details), (create_page_user_details),
3569 (create_page_incoming), (create_page_outgoing):
3570 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3571 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3572 (modest_connection_specific_smtp_edit_window_init):
3573 * src/maemo/modest-connection-specific-smtp-window.c:
3574 (modest_connection_specific_smtp_window_init):
3575 * src/maemo/modest-signature-editor-dialog.c:
3576 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3577 and scrolling policy as per the Email Application Layout Guide, if I have
3580 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3582 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3583 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3584 which were empty, because these vfuncs have been removed from TnyAccountStore.
3585 This fixes the build.
3587 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3589 * src/maemo/modest-main-window.c:
3590 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3591 showing/hiding it. Added TODO because it probably should not be NULL.
3592 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3593 because unnecessary g_warnings() make degugging difficult.
3595 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3597 * src/maemo/modest-msg-edit-window.c:
3598 (modest_msg_edit_window_select_color),
3599 (modest_msg_edit_window_select_background_color): 2 const corrections and
3600 moving 2 #endifs before closing brackets, to fix the build.
3602 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3604 * src/maemo/easysetup/modest-easysetup-wizard.h:
3605 * src/maemo/easysetup/modest-easysetup-wizard.c:
3606 (modest_easysetup_wizard_dialog_finalize),
3607 (on_button_edit_advanced_settings), (create_page_complete_custom),
3608 (on_response), (create_account):
3609 Implement the Advanced Settings edit button, by saving the account information,
3610 for the Advanded Settings dialog to use directly from gconf, and removing it
3611 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3612 Bug #5533 in the projects.maemo.org bugzilla.
3614 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3616 * src/maemo/modest-msg-view-window.c:
3617 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3618 when opening a message window.
3620 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3622 * src/maemo/easysetup/modest-easysetup-wizard.c:
3623 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3626 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3627 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3628 gconf settings. I probably added more checks than necessary, but that is safer.
3630 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3631 variable to fix the build, but this seems to be used when it is still NULL.
3633 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3635 * src/modest-platform.h:
3636 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3637 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3638 * src/modest-main.c: Implement this function so we can avoid using
3639 maemo-specific API from cross-platform code.
3641 * src/modest-tny-account-store.c:
3642 (get_smtp_specific_transport_account_for_open_connection):
3643 * src/modest-ui-actions.c: (check_for_connection),
3644 (modest_ui_actions_on_item_not_found):
3645 Use modest_platform_connect_and_wait() and put #idefs around other
3646 maemo-specific code, because only maemo currently has a way to
3647 identify connection names.
3649 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3651 * src/modest-tny-account-store.h:
3652 * src/modest-tny-account-store.c:
3653 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3654 the connection-specific SMTP server settings in the configuration.
3656 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3658 * src/maemo/modest-main-window.c: (on_connection_changed),
3660 * src/modest-main.c: (main), (start_ui), (send_mail):
3661 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3662 that is what is intended.
3664 * src/modest-ui-actions.c: (action_send), (action_receive),
3665 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3666 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3667 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3668 SMTP server is used when it is specified.
3670 (modest_ui_actions_on_send_receive):
3671 Check that a connection is open before proceeding.
3672 Receive and then send, instead of vice-versa, as per the specification.
3674 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3676 * src/modest-mail-operation.c:
3677 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3678 though I guess it should be something other than NULL.
3680 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3682 * src/maemo/easysetup/modest-easysetup-wizard.c:
3683 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3684 combo twice, to avoid an g_warning and to make it visible again.
3685 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3686 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3687 (already intended) dereference when detaching, because we then recreate the menu.
3688 But I am not sure why the warning was happening, and it is possible that this is a memory
3691 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3693 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3694 and uri_parse_mailto() utility functions.
3695 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3697 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3699 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3701 * src/dbus_api/modest-dbus-api.h:
3702 * src/dbus_api/modest-dbus-callbacks.c:
3703 Use an idle callback to execute the modest code in the application's own thread.
3704 Remove the helloworld example method.
3705 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3706 parsed, and the open-message method is not implemented because this is not yet implemented in
3708 * libmodest-dbus-client/libmodest-dbus-client.c:
3709 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3710 (libmodest_dbus_client_open_message):
3711 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3713 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3714 body without crashing.
3716 * tests/dbus_api/Makefile.am:
3717 * tests/dbus_api/test_mail_to.c:
3718 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3720 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3722 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3723 Added file to fix the build. Sorry.
3725 * src/dbus_api/Makefile.am:
3726 * src/dbus_api/modest-dbus-api.h:
3727 * src/dbus_api/modest-dbus-callbacks.h:
3728 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3729 (modest_dbus_req_handler):
3730 Put constants in a separate header so it can be reused by the
3731 client library, without duplication
3733 * libmodest-dbus-client/Makefile.am:
3734 * libmodest-dbus-client/libmodest-dbus-client.c:
3735 (libmodest_dbus_client_call_helloworld),
3736 (libmodfest_dbus_client_send_mail),
3737 (libmodfest_dbus_client_mailto),
3738 (libmodfest_dbus_client_open_message):
3739 * libmodest-dbus-client/libmodest-dbus-client.h:
3740 (Partly) Implement a send_mail D-Bus method.
3742 * tests/dbus_api/Makefile.am:
3743 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3744 the send_email D-Bus method.
3746 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3750 * libmodest-dbus-client/Makefile.am:
3751 * libmodest-dbus-client/libmodest-dbus-client.c:
3752 * libmodest-dbus-client/libmodest-dbus-client.h:
3753 * tests/dbus_api/Makefile.am:
3754 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3755 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3757 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3759 * src/maemo/easysetup/modest-easysetup-wizard.c:
3760 (create_page_account_details):
3761 * src/maemo/modest-account-settings-dialog.c:
3762 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3763 widgets, because this might not be the default in future versions of the Maemo GTK+.
3764 However, I can not not get capitalization to work even in a simple test case.
3766 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3768 * src/maemo/easysetup/modest-easysetup-wizard.c:
3769 (create_page_custom_incoming), (create_page_custom_outgoing):
3770 * src/maemo/modest-account-settings-dialog.c:
3771 (create_page_account_details), (create_page_incoming),
3772 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3773 instead of using gtk_check_button_with_label(), so they are aligned like the other
3774 widgets, as per the UI spec.
3776 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3778 * src/maemo/easysetup/modest-easysetup-wizard.c:
3779 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3780 * src/widgets/modest-validating-entry.c:
3781 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3782 Modest prefix instead of an EasySetup prefix.
3784 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3786 * src/widgets/modest-validating-entry.h:
3787 * src/widgets/modest-validating-entry.c: (on_insert_text),
3788 Added easysetup_validating_entry_set_max_func(), used to set a callback
3789 to call when the max number of characters is reached. GtkEntry has a max-length
3790 already but is silent about it.
3792 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3793 (create_page_account_details), (create_page_user_details),
3795 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3796 (create_page_account_details), (create_page_user_details),
3797 (create_page_outgoing):
3798 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3799 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3800 the UI spec, when the user tries to enter more than the max number of characters.
3802 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3804 * src/maemo/easysetup/modest-easysetup-wizard.c:
3805 (create_page_user_details), (create_page_custom_incoming),
3806 (create_page_custom_outgoing):
3807 * src/maemo/modest-account-settings-dialog.c:
3808 (create_page_user_details), (create_page_incoming),
3809 (create_page_outgoing):
3810 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3811 (modest_connection_specific_smtp_edit_window_init):
3812 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3813 not appropriate. Bad Maemo-specific defaults!.
3815 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3817 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3818 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3819 (modest_signature_editor_dialog_set_settings):
3820 Disable the label and textview when the checkbox is disabled, and use the
3821 specified (UI spec) default signature text.
3823 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3825 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3826 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3828 * src/modest-defs.h:
3829 * src/modest-account-mgr-helpers.h:
3830 * src/modest-account-mgr-helpers.c:
3831 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3833 * src/maemo/Makefile.am:
3834 * src/maemo/modest-signature-editor-dialog.c:
3835 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3838 * src/maemo/modest-account-settings-dialog.h:
3839 * src/maemo/modest-account-settings-dialog.c:
3840 (modest_account_settings_dialog_finalize), (on_button_signature),
3841 (save_configuration): Use the new dialog when the Edit button is pressed, and
3842 save the changes if necessary, as per the UI spec.
3844 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3846 * src/maemo/Makefile.am:
3847 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3848 based on maemo-develoers email from Dirk.
3850 * src/maemo/easysetup/modest-easysetup-wizard.c:
3851 (create_page_welcome), (create_page_account_details),
3852 (create_page_user_details), (create_page_complete_easysetup),
3853 (create_page_custom_incoming), (create_page_custom_outgoing),
3854 (create_page_complete_custom),
3855 (modest_easysetup_wizard_dialog_init):
3856 * src/maemo/modest-account-settings-dialog.c:
3857 (create_page_account_details), (create_page_user_details),
3858 (create_page_incoming), (create_page_outgoing),
3859 (modest_account_settings_dialog_init):
3860 * src/maemo/modest-connection-specific-smtp-window.c:
3861 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3863 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3865 * src/maemo/easysetup/modest-easysetup-wizard.c:
3866 (create_page_account_details), (create_page_custom_outgoing),
3867 (create_page_complete_custom):
3868 * src/maemo/modest-account-settings-dialog.c:
3869 (create_page_user_details), (create_page_incoming),
3870 (create_page_outgoing):
3871 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3872 (modest_connection_specific_smtp_edit_window_init):
3873 Use the correct (UI spec) port min/max, and use horizontal separators,
3876 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3878 * src/maemo/easysetup/modest-easysetup-wizard.c:
3879 (set_default_custom_servernames):
3880 * src/maemo/modest-account-settings-dialog.c:
3881 (create_page_incoming), (on_combo_outgoing_security_changed),
3882 (on_combo_incoming_security_changed), (create_page_outgoing),
3883 (modest_account_settings_dialog_set_account_name),
3884 (save_configuration):
3885 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3886 (on_combo_security_changed),
3887 (modest_connection_specific_smtp_edit_window_init),
3888 (modest_connection_specific_smtp_edit_window_set_connection),
3889 (modest_connection_specific_smtp_edit_window_get_settings):
3890 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3893 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3896 * src/maemo/easysetup/modest-easysetup-wizard.c:
3897 (create_page_custom_outgoing), (create_page_complete_custom):
3898 * src/maemo/modest-account-settings-dialog.c:
3899 (create_page_user_details), (create_page_outgoing):
3900 * src/maemo/modest-account-view-window.c: (button_box_new):
3901 Use changed logical IDs as per the most recent UI spec:
3902 mcen_bd_emailsetup_edit -> mcen_bd_edit
3903 mcen_bd_emailsetup_delete -> mcen_bd_delete
3904 mcen_bd_emailsetup_close -> mcen_bd_close
3906 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3910 * src/dbus_api/Makefile.am:
3911 * src/dbus_api/modest-dbus-callbacks.c:
3912 * src/dbus_api/modest-dbus-callbacks.h:
3913 * src/maemo/modest-platform.c: (modest_platform_init):
3914 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3916 * tests/Makefile.am:
3917 * tests/dbus_api/Makefile.am:
3918 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3920 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3922 * src/maemo/modest-account-settings-dialog.c:
3923 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3924 Removed unnecessary includes.
3926 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3928 * src/maemo/easysetup/modest-easysetup-wizard.c:
3929 * src/maemo/modest-account-settings-dialog.c:
3930 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3931 * src/widgets/Makefile.am:
3932 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3933 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3934 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3935 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3936 * src/widgets/modest-secureauth-combo-box.c:
3937 * src/widgets/modest-secureauth-combo-box.h:
3938 * src/widgets/modest-serversecurity-combo-box.c:
3939 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3940 made the GObject names more consistent with the rest of the Modest code.
3942 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3944 * src/maemo/easysetup/Makefile.am:
3945 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3946 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3947 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3948 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3949 * src/maemo/easysetup/modest-easysetup-wizard.c:
3950 * src/maemo/easysetup/modest-validating-entry.c:
3951 * src/maemo/easysetup/modest-validating-entry.h:
3952 * src/maemo/modest-account-settings-dialog.c:
3953 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3954 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3955 widgets/ because they are used outside of easysetup too. After checking in,
3956 svn will allow me to rename them too.
3958 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3960 * src/gnome/modest-msg-edit-window.c:
3961 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3962 linker error, to fix the build on the GNOME platform.
3963 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3964 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3965 ifdefed out to avoid a warning.
3967 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3969 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3970 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3971 some alternative for GTK+ 2.6.
3973 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3975 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3977 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3978 specified for EmailAccountsDialog in UI spec.
3980 * src/maemo/easysetup/modest-easysetup-wizard.c:
3981 * src/maemo/easysetup/modest-easysetup-wizard.h:
3982 * src/maemo/modest-account-settings-dialog.c:
3983 * src/maemo/modest-account-settings-dialog.h:
3984 Reuse a member window widget for the connection-specific SMTP server accounts,
3985 so we can tell it to create/save the accounts only if we actually save changes.
3987 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3988 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3989 (modest_connection_specific_smtp_edit_window_get_settings):
3990 Return a struct instance for temporarily remembering the entered data.
3992 * src/maemo/modest-connection-specific-smtp-window.h:
3993 * src/maemo/modest-connection-specific-smtp-window.c:
3994 (modest_connection_specific_smtp_window_finalize),
3995 (modest_connection_specific_smtp_window_fill_with_connections),
3997 (modest_connection_specific_smtp_window_save_server_accounts),
3998 (update_model_server_names): Do not actually save data until asked,
3999 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4001 (on_selection_changed),
4002 (modest_connection_specific_smtp_window_init): Disable the edit
4003 button when nothing is selected.
4005 * src/modest-account-mgr-helpers.c:
4006 * src/modest-account-mgr-helpers.h:
4007 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4010 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4012 * src/modest-account-mgr-helpers.h:
4013 * src/modest-account-mgr-helpers.c:
4014 (modest_account_mgr_get_unused_account_name),
4015 (modest_account_mgr_get_unused_account_display_name): Added these
4016 utility functions, to avoid code duplication.
4018 * src/maemo/easysetup/modest-easysetup-wizard.c:
4019 (create_page_account_details), (create_account):
4020 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4021 (on_combo_security_changed),
4022 (modest_connection_specific_smtp_edit_window_init),
4023 (modest_connection_specific_smtp_edit_window_save_settings):
4024 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4025 * src/maemo/modest-connection-specific-smtp-window.c:
4026 (modest_connection_specific_smtp_window_finalize),
4027 (modest_connection_specific_smtp_window_fill_with_connections),
4028 (on_button_edit), (modest_connection_specific_smtp_window_init):
4029 * src/maemo/modest-connection-specific-smtp-window.h:
4030 Implementing saving of connection-specific server accounts.
4032 But I need to refactor this so we can save the data for each
4033 possible connection-specific account and only actually create the server accounts
4034 when the easysetup finished, or the OK button is pressed on the account settings
4037 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4039 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4040 (on_combo_security_changed):
4041 (modest_connection_specific_smtp_edit_window_init):
4042 Auto-fill the port number as in the account settings.
4044 (modest_connection_specific_smtp_edit_window_set_connection):
4045 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4046 * src/maemo/modest-connection-specific-smtp-window.c:
4047 (fill_with_connections), (on_button_edit),
4048 (modest_connection_specific_smtp_window_init):
4049 Turn the edit window into a dialog to simplify the code, and
4050 set a WM hint as in a GtkDialog, because only a popup can be on top of
4051 another window in Maemo, and popups usually have no WM decoration.
4053 * src/modest-defs.h:
4054 * src/modest-account-mgr-helpers.c:
4055 (modest_account_mgr_set_connection_specific_smtp),
4056 (modest_account_mgr_remove_connection_specific_smtp),
4057 (modest_account_mgr_get_connection_specific_smtp):
4058 * src/modest-account-mgr-helpers.h: Some functions to write the
4059 connection-specific SMTP server information. Not yet used.
4062 * src/widgets/modest-folder-view.c: (text_cell_data):
4063 Fix a warning about an uninitialized variable.
4064 (on_configuration_key_changed): Put an #ifdef around the use
4065 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4067 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4069 * src/maemo/modest-account-settings-dialog.h:
4070 * src/maemo/modest-account-settings-dialog.c:
4071 Added connect_for_modified() utility function to mark the new modified boolean.
4073 (create_page_account_details), (create_page_user_details),
4074 (create_page_incoming), (create_page_outgoing), (on_response),
4075 (modest_account_settings_dialog_init),
4076 (modest_account_settings_dialog_set_account_name):
4077 Only warn about unsaved changes when there are actually unsaved changes.
4079 * src/modest-account-mgr-helpers.c:
4080 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4081 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4082 to get the data from there in future.
4084 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4086 * src/modest-defs.h:
4088 * src/modest-account-mgr-helpers.h:
4089 * src/modest-account-mgr-helpers.c:
4090 Store the security account setting in a single conf key instead of using
4091 the options list, so that the list is left for just the to-be-removed camel hack,
4092 and because gconf_client_set_list() is failing for some reason.
4094 * src/modest-account-mgr.c:
4095 (modest_account_mgr_add_server_account):
4096 * src/maemo/modest-account-settings-dialog.c:
4097 (modest_account_settings_dialog_set_account_name),
4098 (save_configuration): Use the renamed functions.
4101 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4103 * src/widgets/Makefile.am:
4104 * src/widgets/modest-limit-retrieve-combo-box.c:
4105 * src/widgets/modest-limit-retrieve-combo-box.h:
4106 * src/widgets/modest-retrieve-combo-box.c:
4107 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4108 the account settings dialog.
4110 * src/modest-defs.h:
4111 * src/modest-account-mgr-helpers.h:
4112 * src/modest-account-mgr-helpers.c:
4113 (modest_server_account_get_option_secure_auth),
4114 (modest_server_account_set_option_secure_auth):
4115 * src/modest-account-mgr.c:
4116 (modest_account_mgr_add_server_account):
4117 Use the existing AUTH_MECH conf key for the secure-auth setting,
4118 instead of putting it in the list options, because this was actually used already.
4120 * src/maemo/modest-account-settings-dialog.c:
4121 (create_page_account_details),
4122 (modest_account_settings_dialog_set_account_name),
4123 (save_configuration):
4124 * src/maemo/modest-account-settings-dialog.h:
4125 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4126 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4128 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4130 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4131 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4132 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4134 * src/modest-defs.h:
4135 * src/maemo/modest-account-settings-dialog.c:
4136 (create_page_incoming), (on_combo_outgoing_security_changed),
4137 (on_combo_incoming_security_changed), (create_page_outgoing),
4138 (modest_account_settings_dialog_set_account_name),
4139 (save_configuration): Load/Save the port number, and change it when the
4140 security combo changes, to suitable defaults.
4142 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4144 * src/modest-account-mgr.c:
4145 (modest_account_mgr_add_server_account): Set the security and secure-auth
4146 options, and add a comment saying that the other camel-specific options should be
4149 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4151 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4153 * src/modest-tny-account-store.c: (account_list_free),
4154 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4155 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4158 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4160 * src/modest-protocol-info.c:
4161 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4162 is required by our UI spec. Maybe something in our implementation will use this eventually.
4163 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4164 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4165 instead of the previous 0 placeholder.
4167 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4168 secure-auth settings.
4169 * src/modest-account-mgr-helpers.h:
4170 * src/modest-account-mgr-helpers.c:
4171 (modest_server_account_data_get_option_secure_auth),
4172 (modest_server_account_set_option_secure_auth),
4173 (modest_server_account_data_get_option_security),
4174 (modest_server_account_set_option_security): Added this API for getting and setting the security
4175 and secure-auth settings.
4177 * src/maemo/modest-account-settings-dialog.h:
4178 * src/maemo/modest-account-settings-dialog.c:
4179 (modest_account_settings_dialog_finalize), (check_data),
4180 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4181 about changing titles.
4182 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4183 (save_configuration): Save the security and secure-auth settings.
4185 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4186 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4188 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4190 * src/modest-defs.h:
4191 * src/modest-account-mgr.c:
4192 (modest_account_mgr_add_server_account):
4193 Added and used defines for the options key and value pair strings,
4194 that are used so far, though they do not seem to correspond to anything in our
4195 UI specs or ModestProtocol enum.
4197 * src/modest-account-mgr-helpers.h:
4198 * src/modest-account-mgr-helpers.c:
4199 (compare_option_strings_for_name),
4200 (modest_server_account_data_get_option_value),
4201 (modest_server_account_data_get_option_bool),
4202 (modest_account_mgr_get_server_account_option):
4203 Added helper functions for parsing the options GSList.
4205 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4207 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4208 display name is based on the supplied account name.
4209 * src/modest-account-mgr.c:
4210 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4211 with an inefficient, but good-enough, implementation.
4213 * src/maemo/easysetup/modest-easysetup-wizard.c:
4214 (create_page_account_details), (on_before_next), (create_account):
4215 Check for existing display names rather than (non-user-visible) account names, and just
4216 create and set a unique account name at the end.
4218 * src/maemo/modest-account-settings-dialog.c:
4219 (modest_account_settings_dialog_init),
4220 (modest_account_settings_dialog_set_account_name),
4221 (create_page_incoming): Show the display name, instead of the account name.
4222 (on_response): Do some (not all) extra checks, as in the UI spec.
4223 (save_configuration): Save the display name if it was changed.
4225 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4227 * po/en_GB.po: Added needed logical ID and translation.
4228 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4229 (init_view): Made the is-default column clicking work.
4231 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4234 * src/maemo/easysetup/Makefile.am:
4235 * src/maemo/easysetup/modest-easysetup-wizard.c:
4236 (modest_easysetup_wizard_dialog_init):
4237 * src/maemo/easysetup/provider-data-test.keyfile:
4238 * src/maemo/easysetup/provider-data.keyfile:
4239 Moved the provider data file to the new modest-providers-data package and used it from there.
4241 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4243 * src/modest-local-folder-info.c:
4244 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4245 N_() was already used on the static strings, but this just marks it for translation without
4246 using the translation.
4248 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4250 * src/maemo/modest-account-settings-dialog.c:
4251 (create_page_incoming),
4252 (modest_account_settings_dialog_set_account_name):
4253 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4254 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4255 I will do this if nobody else gets there first.
4257 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4259 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4260 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4261 save the security stuff.
4263 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4265 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4266 Set the email address and user fullname, which I now see must be
4269 * src/maemo/modest-account-settings-dialog.h:
4270 * src/maemo/modest-account-settings-dialog.c:
4272 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4273 leave-on-server and authentication.
4274 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4277 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4280 * src/maemo/modest-account-settings-dialog.c:
4281 * src/maemo/modest-account-settings-dialog.h:
4282 Most (but not all) of the widgets are now present as specified by the UI spec.
4283 No changes are yet saved, and some details are not properly shown yet.
4285 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4287 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4289 * src/maemo/Makefile.am:
4290 * src/maemo/modest-account-settings-dialog.c:
4291 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4292 an existing account. Doesn't do much yet.
4294 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4295 Open the accounts settings dialog when Edit is clicked.
4297 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4299 * src/maemo/easysetup/Makefile.am:
4300 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4302 * src/maemo/easysetup/modest-easysetup-wizard.c:
4303 (modest_easysetup_wizard_dialog_init):
4304 Try to get the source directory from the build system,
4305 instead of hard-coding "./" into the source code, when opening our local
4306 copies of the configuration files.
4307 But this still fails when opening the wizard from the Accounts window,
4308 maybe because the working directory seems to change at runtime.
4309 So the wizard will fail the second time unless you copy the files into their
4310 proper locations - see the stdout warnings for the paths.
4312 (create_page_account_details),(on_before_next):
4313 Check for existing non-server accounts instead of server accounts,
4314 so the default account name is useful again, and to prevent trying to
4317 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4318 Show the wizard when New is clicked.
4320 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4321 (init_view): Show the column headers, and show the columns that are
4322 specified in the UI specs. However, something in Maemo's GTK+ prevents
4323 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4324 change the default account. This is despite unsetting the special properties.
4326 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4328 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4329 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4330 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4331 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4332 to make that clearer.
4333 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4335 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4337 * src/maemo/modest-account-view-window.c:
4338 (modest_account_view_window_init),
4339 (modest_account_view_window_new):
4340 Use the same buttons as specified in the
4341 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4342 the existing widgets, which never had a chance of working.
4343 Put the ModestAccountView treeview in a scrolled window.
4344 Do not repeat the initialization in both _init() and _new().
4346 * src/widgets/modest-account-view.c: (update_account_view):
4347 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4348 this widget and window shows no accounts.
4350 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4352 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4354 * src/maemo/easysetup/modest-easysetup-wizard.c:
4355 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4356 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4357 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4360 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4361 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4362 accounts exist yet, as in the UI spec.
4364 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4366 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4368 * src/maemo/Makefile.am:
4369 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4370 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4371 New window for editing connection-specific smtp details.
4372 Not fully implemented.
4374 * src/maemo/modest-connection-specific-smtp-window.c:
4375 (modest_connection_specific_smtp_window_finalize) :
4376 unref the tree model.
4377 (on_button_edit): Show the edit window.
4379 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4381 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4384 * src/maemo/Makefile.am:
4385 * src/maemo/modest-connection-specific-smtp-window.c:
4386 * src/maemo/modest-connection-specific-smtp-window.h:
4387 New window for showing the list of connections, for connection-specific
4388 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4389 * src/maemo/easysetup/modest-easysetup-wizard.c:
4390 (create_page_custom_outgoing): Show the new window when the button is clicked.
4392 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4394 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4395 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4396 * src/maemo/modest-msg-edit-window.c:
4397 (modest_msg_edit_window_insert_image):
4398 * src/modest-conf.c: (modest_conf_key_escape):
4399 * src/modest-mail-operation.c:
4400 (modest_mail_operation_send_new_mail):
4401 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4402 (modest_ui_actions_on_new_account):
4403 * src/widgets/modest-attachment-view.c: (update_filename_request):
4404 * src/widgets/modest-mail-header-view.c:
4405 Corrected warnings that were breaking the build, by commenting out unused variables,
4406 and a function, and by including a header.
4408 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4410 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4411 so we can #ifdef around platform-specific code when necessary.
4412 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4413 to allow this to build for the GNOME platform too.
4415 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4417 * src/maemo/easysetup/modest-easysetup-wizard.c:
4418 Added util_increment_name() and used it in create_page_account_details()
4419 to make sure that the default account name is always a new name.
4421 (modest_easysetup_wizard_dialog_init),
4422 (set_default_custom_servernames): Some minor memory management fixes.
4424 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4428 * src/modest-runtime.c: (init_i18n): Restored the translation
4429 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4430 are defined in config.h, and the translations are installed.
4432 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4433 is defined for translation.
4435 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4437 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4439 * src/maemo/easysetup/modest-easysetup-wizard.c:
4440 (modest_easysetup_wizard_dialog_init):
4441 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4442 Use realistic paths (though they should use $prefix generically) to the
4443 mcc_mapping and provider-data.keyfile files which might work when they
4444 are installed by the future version of the operator-wizard package,
4445 and then fallback to paths in our source code, with an explanatory
4448 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4452 * src/maemo/Makefile.am:
4453 * src/maemo/easysetup/: Added files from the previously-exernal
4454 osso-modest-easysetup.
4455 * src/maemo/modest-main-window-ui.h:
4456 * src/modest-ui-actions.c:
4457 * src/modest-ui-actions.h:
4458 Added modest_ui_actions_on_new_account() as a signal handler for the
4459 New Account menu item. It shows the easysetup wizard.
4460 * po/en_GB.po: Added additional needed logical IDs and translations.