1 2007-07-10 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-dimming-rules.c:
4 (modest_ui_dimming_rules_on_new_msg),
5 (modest_ui_dimming_rules_on_reply_msg),
6 (modest_ui_dimming_rules_on_delete_msg),
7 (modest_ui_dimming_rules_on_details),
8 (modest_ui_dimming_rules_on_view_window_move_to),
9 (modest_ui_dimming_rules_on_view_previous),
10 (modest_ui_dimming_rules_on_view_next),
11 (_invalid_folder_for_purge): Added checks before
12 casting the window. This looks like an actual
13 logic error in _invalid_folder_for_purge(), because it
14 tries to use a ModestMainWindow as a message window.
16 2007-07-10 Murray Cumming <murrayc@murrayc.com>
18 * src/maemo/modest-account-settings-dialog.c:
19 (show_error): Use the same implementation as in
20 modest-easysetup-wizard.c:
21 (on_entry_invalid_character): The logical ID contains a %s.
22 Guessed what it should be.
23 (on_entry_max), (check_data), (on_response): Adapt to
25 (create_page_account_details): Really call
26 modest_validating_entry_set_func() on the correct widgets.
27 * src/maemo/easysetup/modest-easysetup-wizard.c:
28 (on_entry_invalid_character): Fix the logical ID here too.
29 (create_page_account_details),
30 (create_page_user_details):
32 modest_validating_entry_set_func() on the correct widgets.
34 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
35 Do not try to use the account if it is NULL.
37 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
39 * src/modest-ui-actions.c: (create_move_to_dialog),
40 (modest_ui_actions_on_main_window_move_to),
41 (modest_ui_actions_on_msg_view_window_move_to):
42 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
43 (filter_row), (modest_folder_view_show_non_move_folders):
44 * src/widgets/modest-folder-view.h:
46 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
47 the Sent folder yet as it does not report the correct folder type.
49 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
51 * src/maemo/modest-msg-edit-window.c: (init_window):
54 2007-07-10 Murray Cumming <murrayc@murrayc.com>
56 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
57 Take a parent widget instead of a parent window, and
58 implement this with hildon_banner_show_information() instead.
59 Non-Maemo builds can just ifdef that there.
60 This fixed projects.maemo.org bug NB#62766.
62 (on_entry_invalid_character): Use show_error() again instead
63 of using hildon directly, and use the _CS() macro to use the correct
65 (create_account), (check_for_supported_auth_methods), (on_entry_max):
66 Pass a widget instead od a window to show_error().
68 2007-07-10 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
71 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
72 This allows us to show the server name in the error message, fixing
73 projects.maemo.org bug NB#62904.
74 Also, use the appropriate logical ID message for the account protocol.
76 2007-07-10 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-tny-account-store.c: (on_idle_wrong_password):
79 A compilation fix, though the build wasn't broken for me.
81 2007-07-09 Murray Cumming <murrayc@murrayc.com>
83 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
84 Do not try to unref a NULL folder store, to avoid a runtime warning.
85 This seems to happen sometimes when changing accounts settings.
87 2007-07-09 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-tny-account-store.c:
90 (modest_tny_account_store_instance_init),
91 (modest_tny_account_store_finalize),
92 (on_account_settings_hide), (on_idle_wrong_password):
93 Use a GHashTable to ensure that we only show one account settings
94 dialog per modest account. This avoids us having a dialog open for
95 both the store and transport accounts, or due to repeated get_password()
96 calls that shouldn't happen anyway.
98 2007-07-09 Murray Cumming <murrayc@murrayc.com>
100 * src/maemo/modest-maemo-utils.c: (on_hide),
101 (modest_maemo_show_dialog_and_forget): Handle the response, because
102 the window is not even hidden by default.
104 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
105 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
106 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
107 which seems to prevent some modality problems.
109 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
110 Ignore user cancellation errors.
112 * src/modest-account-mgr-helpers.h:
113 * src/modest-account-mgr-helpers.c:
114 Added modest_server_account_get_password() and
115 modest_server_account_get_has_password() to avoid direct use of
118 * src/maemo/modest-account-settings-dialog.h:
119 * src/maemo/modest-account-settings-dialog.c:
120 (modest_account_settings_dialog_init): Store the notebook so we can
122 Added modest_account_settings_dialog_switch_to_user_info().
124 * src/modest-tny-account-store.c:
125 (get_password): When the password in the account settings is wrong (we think),
126 show the relevant page of the account settings dialog, in the mainloop.
127 However, we currently get many of these at once because cancel does not
129 (forget_password): Do not forget the password
130 from the account settings, because this causes side-effects when
131 tinymail seems to call it at strange time, maybe because of how we
132 are cancelling get_password().
133 (modest_tny_account_store_alert): Ignore user cancellations.
135 2007-07-09 Murray Cumming <murrayc@murrayc.com>
137 * src/maemo/modest-maemo-utils.h:
138 * src/maemo/modest-maemo-utils.c:
139 Added modest_maemo_show_information_note_and_forget() for use instead of
140 gtk_dialog_run() when the response is not needed, to avoid an extra
141 mainloop which could cause a hang.
143 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
144 Use the logical IDs for the error message, though they are not
145 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
146 because gtk_dialog_run() caused a hang here (the window did not close).
147 This fixes projects.maemo.org bug NB#62646.
149 2007-07-09 Murray Cumming <murrayc@murrayc.com>
151 * src/modest-account-mgr-helpers.h:
152 * src/modest-account-mgr-helpers.c:
153 Added modest_account_mgr_get_store_protocol().
155 * src/maemo/modest-account-view-window.c:
156 (on_delete_button_clicked): Show different warning text depending on
157 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
158 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
161 2007-07-09 Murray Cumming <murrayc@murrayc.com>
163 * src/maemo/modest-msg-edit-window.c:
164 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
165 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
167 2007-07-07 Armin Burgmeier <armin@openismus.com>
169 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
170 ckdg_ib_maximum_characters_reached from correct package.
172 * src/modest-ui-actions.c: Show an error message when a folder could
173 not be created. Tinymail does not give us specific error codes about
174 what has gone wrong, so we assume that a folder with that name
175 already exists, though there might be other reasons.
177 2007-07-06 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
180 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
181 give a more exact error message that can be partly translated.
183 2007-07-05 Murray Cumming <murrayc@murrayc.com>
185 * src/maemo/modest-address-book.c:
186 (select_email_addrs_for_contact): Specify a default window size for the
187 select-email-address dialog, so that it is probably big enough for the
188 title. This should fix projects.maemo.org bug NB#62277.
190 2007-07-05 Murray Cumming <murrayc@murrayc.com>
192 * src/maemo/easysetup/modest-easysetup-wizard.c:
193 (create_page_complete_easysetup): Use
194 gtk_widget_set_size() request to ensure that the text wraps
197 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
199 * src/maemo/easysetup/modest-easysetup-wizard.c:
200 (on_entry_invalid_character), (create_page_account_details),
201 (create_page_user_details):
202 Use new API of ModestValidatingEntry. But for some reason the banner is
203 not shown. I will have to investigate that further.
205 * src/widgets/modest-validating-entry.c: (on_insert_text),
206 (modest_validating_entry_set_func):
207 * src/widgets/modest-validating-entry.h:
208 Added a new callback function to be able to react to prevented
209 characters whitespaces to e.g show a banner.
211 2007-07-05 Armin Burgmeier <armin@openismus.com>
213 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
214 notification of HildonNumberEditor instead of remembering the port
215 number. Thanks to Johannes for pointing this out.
217 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
219 * src/maemo/easysetup/modest-easysetup-wizard.c:
220 Check if there are any user changes before showing a confirmation
221 dialog (projects.maemo.org NB#60946)
223 2007-07-05 Armin Burgmeier <armin@openismus.com>
225 * src/maemo/modest-account-settings-dialog.c: Remember custom port
226 number at the beginning of the dialog and set the modified flag at the
227 end if the port number has changed. This is necessary because
228 HildonNumberEditor does not support notification when the value has
231 2007-07-05 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-ui-actions.c:
234 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
235 a connection before asking anything else. Correct the check for the destination
236 folder so that it succeeds when online.
237 This fixed projects.maemo.org bug NB#61645.
239 2007-07-05 Murray Cumming <murrayc@murrayc.com>
241 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
242 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
243 to fix projects.maemo.org bug NB#62439.
245 2007-07-05 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-tny-account.c: (on_connection_status_changed):
248 Really do not use tny_device_force_offline() here. See the previous comment.
250 2007-07-04 Murray Cumming <murrayc@murrayc.com>
252 * src/modest-tny-account.c: (on_connection_status_changed):
253 Do not use tny_device_force_offline() when tinymail says that something
254 went wrong with the connection. It seems to report this unnecessarily.
256 2007-07-04 Murray Cumming <murrayc@murrayc.com>
258 * src/maemo/modest-connection-specific-smtp-window.c:
259 (modest_connection_specific_smtp_window_init):
260 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
261 does not seem to have any effect in osso 1.1 (though it works in
262 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
264 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
266 * src/maemo/modest-connection-specific-smtp-window.c:
267 Fix UI specification problems with projects.meamo.org NB#60479
269 2007-07-04 Murray Cumming <murrayc@murrayc.com>
271 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
272 clue when this has failed, because the error dialog is not always shown
273 (at least in earlier version).
275 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
276 GError message, because the generic error dialog is not helpful.
278 'This message is not currently available (can't let a new connection go online)'
279 when trying to open an IMAP message.
281 (_modest_ui_actions_open): Offer a connection when some messages would
282 have to be downloaded and we are offline.
284 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
286 * src/widgets/modest-folder-view.c:
287 Don't check for MERGE type anymore as we use the correct type
289 NOTE: For the last two changes you need to update your tinymail copy
290 because of API changes!
292 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
294 * src/modest-tny-local-folders-account.c:
295 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
296 (see projects.maemo.org NB#61580)
298 2007-07-04 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-tny-account.c: (on_connection_status_changed):
301 Commented out the call to modest_platform_connect_and_wait() because this
302 seems to always hang, and I would like to know if this is the only thing
303 that causes a hang when showing the connection dialog.
304 It is not very useful anyway.
306 2007-07-04 Murray Cumming <murrayc@murrayc.com>
308 * src/maemo/modest-msg-view-window.c:
309 (modest_msg_view_window_select_next_message):
311 * src/modest-platform.h:
312 * src/maemo/modest-platform.c:
313 Added modest_platform_connect_and_wait(), which calls
314 tny_maemo_conic_device_connect() always in the main thread, by calling it
315 in an idle handler and waiting for the idle handler to run. It should be
316 in the main thread because it uses GTK+ UI code. It just returns TRUE
317 if the device is already online.
319 There is some nasty code to ensure that subsequent calls to
320 modest_platform_connect_and_wait() just wait for the first one to finish,
321 by checking repeatedly in another idle handler. This is necessary,
322 because other threads (or even the main thread, via another idle handler)
323 can call modest_platform_connect_and_wait() while
324 modest_platform_connect_and_wait() is running.
326 (modest_platform_connect_and_wait_if_network_account),
327 (modest_platform_connect_and_wait_if_network_folderstore):
328 Convenience functions that calls modest_platform_connect_and_wait() if
329 the account or folder might want network access.
331 * src/modest-mail-operation.c:
332 (modest_mail_operation_update_account):
333 * src/modest-ui-actions.c: (download_uncached_messages),
334 (modest_ui_actions_on_rename_folder), (delete_folder),
335 (modest_ui_actions_on_main_window_move_to),
336 (modest_ui_actions_on_msg_view_window_move_to):
337 * src/widgets/modest-folder-view.c:
338 (drag_and_drop_from_folder_view):
339 Offer a connection if we are offline.
341 * src/modest-tny-account.c: (on_connection_status_changed):
342 Document this as only handling errors during network operations in progress,
343 and replace the idle code with a simple call to
344 modest_platform_connect_and_wait(), which does this instead.
346 2007-07-03 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-tny-account.c:
349 (modest_tny_account_get_special_folder): (util_on_idle),
350 Handle the GError so we can see when tny_folder_store_get_folders()
351 fails, as it currently does while something else is connecting.
353 Added util_run_in_main_thread_and_wait()
354 which uses an idlen handler and mainloop to ensure that the function
355 is called in the main thread.
356 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
357 to make sure that we call attempt the connection in the mainloop only,
358 which might solve some hangs.
360 2007-07-03 Murray Cumming <murrayc@murrayc.com>
362 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
363 be found by their display name. This is never useful.
364 * src/modest-tny-account-store.c: (on_account_removed): Find the account
365 by its ID, instead of trying to use its ID as its display name.
367 * src/modest-tny-account-store.h:
368 * src/modest-tny-account.c:
369 (modest_tny_account_get_special_folder): Add a g_warning() when
370 tny_folder_store_get_folders() returns an empty list for the maildir.
372 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
373 Add a g_warning() when this returns NULL, because that it not allowed
376 2007-07-02 Armin Burgmeier <armin@openismus.com>
378 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
379 note when trying to cancel the wizard. This fixes projects.maemo.org
382 2007-07-02 Murray Cumming <murrayc@murrayc.com>
384 * src/modest-tny-account.h:
385 * src/modest-tny-account.c:
386 (modest_tny_account_new_from_server_account),
387 (modest_tny_account_new_from_server_account_name),
388 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
389 because this must now be set before setting the proto. This is usd in
390 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
391 warning in camel_session_get_service() caused by
392 tny_camel_transport_account_prepare().
394 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
397 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
399 * src/maemo/modest-connection-specific-smtp-edit-window.c:
401 (modest_connection_specific_smtp_edit_window_init):
403 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
406 2007-06-29 Murray Cumming <murrayc@murrayc.com>
408 * src/modest-tny-account.c:
409 (modest_tny_account_new_from_server_account):
410 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
411 now uses to request a connection when it needs one, and which it uses
412 to tell us that something is wrong with the connection, so we can force
413 the accounts offline to prevent further problems.
416 * src/modest-init.c: (init_default_settings):
417 * src/modest-mail-operation.c:
418 (modest_mail_operation_update_account):
419 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
420 This should not be necessary anymore. Do not set the conf key that
421 determined this (it was always TRUE and not set anywhere else).
423 * src/modest-ui-actions.h: Remove unused and unimplemented
424 modest_ui_actions_on_online_toggle_toggled().
426 2007-06-29 Murray Cumming <murrayc@murrayc.com
428 * src/maemo/modest-main-window.c: (connect_signals):
429 Don't connect to delete_event twice. Maybe this was harmless.
431 2007-06-29 Murray Cumming <murrayc@murrayc.com
433 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
434 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
435 Debug output to give some more clue when a folder move is not allowed.
437 2007-06-28 Murray Cumming <murrayc@murrayc.com
439 * src/modest-tny-account.c: (on_modest_file_system_info),
440 (modest_tny_account_get_mmc_account_name):
441 Always call the callback, without checking whether the name has changed.
442 * src/widgets/modest-folder-view.c: (strings_are_equal),
443 (on_model_foreach_set_name), (on_get_mmc_account_name),
444 (text_cell_data): Compare the name here, and use the name from
445 the account rather than from the
446 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
447 if the name was changed after the account was added to the model.
448 That's a tinymail bug but not one that I want to fix now.
450 This finally fixes projects.maemo.org bug NB#59301.
452 2007-06-27 Armin Burgmeier <armin@openismus.com>
454 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
457 2007-06-27 Murray Cumming <murrayc@murrayc.com
459 * src/modest-tny-account.h:
460 * src/modest-tny-account.c:
461 Added modest_tny_account_get_mmc_account_name(), to set the memory
462 card name asynchronously for the given account and then notify.
463 (modest_tny_account_new_for_local_folders): Use this new function instead
464 of using hildon_file_system_info_async_new() directly.
466 * src/widgets/modest-folder-view.c: (text_cell_data):
467 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
468 gtk_tree_model_row_changed() when it is available.
470 This should fix projects.maemo.org bug NB#59301.
472 2007-06-27 Murray Cumming <murrayc@murrayc.com
474 * src/modest-mail-operation.c: (update_account_thread),
475 (get_msgs_full_thread): Fix typo failures in the revert
478 2007-06-27 Murray Cumming <murrayc@murrayc.com
480 * src/maemo/modest-maemo-global-settings-dialog.c:
481 (idle_select_default_focus):
482 * src/modest-mail-operation.c: (idle_notify_progress),
483 (idle_notify_progress_once), (set_last_updated_idle),
484 (update_account_thread), (get_msgs_full_thread):
485 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
486 * src/widgets/modest-header-view.c:
487 (idle_notify_headers_count_changed_destroy),
488 (idle_notify_headers_count_changed):
489 Reverted the additions of gdk_threads_enter/leave(), in case this
490 helps with a startup hang on the device.
492 2007-06-26 Armin Burgmeier <armin@openismus.com>
494 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
495 for supported secure authentication methods from server by
496 gtk_dialog_run(), saving CPU time and a potential race condition.
498 2007-06-26 Armin Burgmeier <armin@openismus.com>
500 * src/maemo/modest-maemo-utils.h:
501 * src/maemo/modest-maemo-utils.c: Added a
502 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
503 only error code to tell the calling code when the user canceled the
506 * src/maemo/modest-account-settings-dialog.h:
507 * src/maemo/modest-account-settings-dialog.c:
508 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
509 message if the retrieval of secure authentication methods was canceled
510 by the user. Perform the check before saving anything to configuration
511 to not end up with half-committed configuration changes, do not show
512 a "Saving to configuration failed" note when authentication methods
513 could not be retrieved.
515 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
518 2007-06-26 Murray Cumming <murrayc@murrayc.com>
520 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
521 Only return the first level of folders under accounts, because the
522 osso-global-search UI spec doesn't want the rest.
523 This fixed projects.maemo.org bug NB#61811.
525 2007-06-26 Murray Cumming <murrayc@murrayc.com>
527 * src/modest-tny-account-store.c:
528 * src/modest-tny-account-store.h:
529 Added modest_tny_account_is_memory_card_account().
530 * src/maemo/modest-main-window.c: (create_details_widget):
531 Show the same information items for the memory card as we show for the
532 local-folders, to fix projects.maemo.org bug NB#59307.
534 2007-06-26 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-tny-account-store.c: (get_password):
537 Added some checks for NULL to maybe prevent crashes, though I think
538 it was Philip's last commit that actually prevented the crash here
539 when creating a first new account.
540 But the new account is still not usable (no messages are shown)
541 until a restart of the application.
543 2007-06-26 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/modest-maemo-global-settings-dialog.c:
546 (idle_select_default_focus):
547 * src/modest-mail-operation.c: (idle_notify_progress),
548 (idle_notify_progress_once), (idle_notify_update_account_queue),
549 (set_last_updated_idle), (update_account_thread),
550 (notify_get_msgs_full), (get_msgs_full_destroyer),
551 (get_msgs_full_thread):
552 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
553 * src/widgets/modest-header-view.c:
554 (idle_notify_headers_count_changed_destroy),
555 (idle_notify_headers_count_changed):
556 Use gdk_threads_enter() and gdk_threads_enter_leave() in
557 all idle handlers, because some other thread could be blocking
558 the GDK lock, so that it can do GUI stuff.
560 2007-06-26 Murray Cumming <murrayc@murrayc.com>
562 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
563 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
564 (on_idle_send_receive), (on_idle_open_default_inbox):
565 * src/maemo/modest-msg-edit-window.c:
566 (modest_msg_edit_window_attach_file_noninteractive):
567 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
568 to prevent a hang. I don't quite understand why these are necessary,
569 beause we should already be in the main loop. I guess something outside
570 of the main loop is taking the lock.
572 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
573 we are really using URIs, and use files that are more likely to exist.
575 2007-06-26 Murray Cumming <murrayc@murrayc.com>
577 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
578 necessary because configure.ac now defines different variables.
580 2007-06-26 Murray Cumming <murrayc@murrayc.com>
582 * libmodest-dbus-client/libmodest-dbus-client.c:
583 * libmodest-dbus-client/libmodest-dbus-client.h:
584 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
585 libmodest_dbus_client_compose_mail() is what things actually use.
587 * src/dbus_api/modest-dbus-api.h:
588 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
589 * tests/dbus_api/Makefile.am:
590 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
593 2007-06-26 Murray Cumming <murrayc@murrayc.com>
595 * src/modest-init.c: (modest_init_local_folders):
596 For memory-card (or other non local-folders) maildir accounts,
597 always create an Archive folder, so that there is somewhere to put
598 messages. This should be less confusing, because the user does not need
599 to guess that the need to create a folder.
601 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
603 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
604 Fixed icon size by using (50, 50) which is the same as defined by
607 2007-06-25 Armin Burgmeier <armin@openismus.com>
609 * src/widgets/modest-window-mgr.c:
611 * configure.ac: Correctly recognize hildon-notify presence and fixed
612 the build without it being installed.
614 2007-06-25 Murray Cumming <murrayc@murrayc.com>
616 * libmodest-dbus-client/libmodest-dbus-client.c:
617 (libmodest_dbus_client_search): Fix the build. Sorry.
618 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
619 (reply_forward_cb): Initialize variables to fix the build.
621 * src/modest-tny-account-store.c:
622 (modest_tny_account_store_get_tny_account_by): Fix the account URI
623 comparison (a silly typo) so that email search results can be opened
624 when there are more than one account.
626 2007-06-25 Murray Cumming <murrayc@murrayc.com>
628 * libmodest-dbus-client/libmodest-dbus-client.c:
629 (libmodest_dbus_client_search),
630 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
631 instead of 1 second, because the search gets folders and messages from
632 the server, which can take a long time. When it times out,
633 osso-global-search will report no results.
635 We need to specify whether we should search only cached information
636 (maybe with a user preference), and the osso-email-search-plugin
637 API should really be improved to allow that option, and to allow results
638 to be delivered asynchronously in batches.
640 2007-06-25 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
643 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
644 GTK_ICON_SIZE_DIALOG is probably the wrong size.
646 2007-06-25 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
649 that is an empty string. D-Bus seems to give us these instead of NULL.
651 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
653 * src/dbus_api/modest-dbus-callbacks.c:
654 * src/maemo/easysetup/modest-easysetup-wizard.h:
655 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
656 * src/maemo/modest-connection-specific-smtp-edit-window.c:
657 (modest_connection_specific_smtp_edit_window_init):
658 * src/maemo/modest-maemo-global-settings-dialog.c:
660 * src/maemo/modest-maemo-utils.c:
661 (modest_maemo_utils_setup_images_filechooser):
662 * src/maemo/modest-main-window.c: (create_details_widget):
663 * src/maemo/modest-msg-edit-window.c:
664 (modest_msg_edit_window_attach_file_noninteractive),
665 (modest_msg_edit_window_color_button_change),
666 (modest_msg_edit_window_set_zoom):
667 * src/modest-mail-operation.c: (update_account_thread):
668 * src/modest-tny-account-store.c:
669 * src/modest-tny-account.c:
670 * src/widgets/modest-global-settings-dialog.c:
671 * src/widgets/modest-window.h:
675 2007-06-25 Murray Cumming <murrayc@murrayc.com>
677 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
678 * src/modest-search.c: (modest_search_folder),
679 (modest_search_all_accounts): Actually search only in the specified folder,
680 doing a simple match on the folder ID.
681 * src/modest-search.h: Added a folder field to the ModestSearch struct,
682 and added some documentation.
684 2007-06-22 Armin Burgmeier <armin@openismus.com>
686 * src/maemo/modest-maemo-utils.h:
687 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
688 modest_maemo_utils_get_supported_secure_authentication_methods.
690 * src/maemo/easysetup/modest-easysetup-wizard.c:
691 * src/maemo/modest-account-settings-dialog.c: Show correct error if
692 one occured, not just "Server does not support secure authentication".
694 2007-06-22 Murray Cumming <murrayc@murrayc.com>
696 * src/modest-tny-account-store.c: (get_password):
697 Restored the call to tny_account_set_user() because Philip seems to have
698 stopped this from crashing (by not using the freed string). It still does
699 not work, but now we can test it.
701 2007-06-22 Murray Cumming <murrayc@murrayc.com>
703 * src/maemo/modest-msg-edit-window.c: (init_window):
704 Comment out use of an uninitialzed GtkScrolledWindow variable,
705 to fix the build and stop a crash. Yet again.
707 2007-06-22 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-tny-account-store.c: (get_password):
710 Remove the call to tny_account_set_user() because this actually crashes.
711 As mentioned in the last commit, it is known to not work anyway.
713 2007-06-22 Murray Cumming <murrayc@murrayc.com>
715 * src/modest-tny-account-store.c: (get_password):
716 Use tny_account_set_username() to tell tinymail that the username might
717 have changed too. But tinymail ignores this: see projects.maemo.org
719 * src/modest-ui-actions.c:
720 (modest_ui_actions_on_password_requested): Remove the useless attempt to
721 reset the connection when changing the username, and improve the comments.
722 Save the changed username to gconf at least, so it is used when Modest is
725 2007-06-21 Murray Cumming <murrayc@murrayc.com>
727 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
728 Do not use a query, so that we get all folders, including for POP and
729 local-folders. They work as search criteria too.
730 This fixes projects.maemo.org bug NB#57740.
732 2007-06-21 Murray Cumming <murrayc@murrayc.com>
734 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
735 Comment out the use of hildon_notification_set_sound() because it is
736 not declared, to fix the build. Warnings are serious, people.
738 2007-06-21 Armin Burgmeier <armin@openismus.com>
740 * src/maemo/modest-maemo-utils.h:
741 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
742 modest_maemo_utils_get_supported_secure_authentication_methods()
743 to query authentication methods for a specific user. This should fix
744 projects.maemo.org bug NB#61369.
746 * src/maemo/easysetup/modest-easysetup-wizard.c:
747 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
750 2007-06-21 Murray Cumming <murrayc@murrayc.com>
752 * libmodest-dbus-client/libmodest-dbus-client.h:
753 * libmodest-dbus-client/libmodest-dbus-client.c:
754 (modest_dbus_message_iter_get_search_hit),
755 (libmodest_dbus_client_search):
756 Reorganised and commented this.
757 Removed modest_search_hit_free() from the public API because it
760 Added libmodest_dbus_client_get_folders() and
761 modest_folder_result_list_free().
763 * src/dbus_api/modest-dbus-api.h:
764 * src/dbus_api/modest-dbus-callbacks.c:
765 (modest_dbus_req_filter): Commented. Moved most code to
766 on_dbus_method_search() and added on_dbus_method_get_folders().
768 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
769 of the extra D-Bus handler.
771 * tests/dbus_api/Makefile.am:
772 * tests/dbus_api/test_get_folders.c: New test for
773 libmodest_dbus_client_get_folders(). This seems to return an empty list
774 at the moment. That could be the same error that causes the message list
775 to be empty sometimes.
776 This should help with projects.maemo.org bug NB#57740.
778 2007-06-21 Armin Burgmeier <armin@openismus.com>
780 * src/modest-mail-operation.c: Do not call
781 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
782 notify the operation's end after having set the status to CANCELED for
783 the operation queue to listen on. This fixes a deadlock when there
784 were mail operations in the queue during its finalization.
786 * src/modest-singletons.c: Reordered uninitialization of the account
787 manager to happen after the mail operation queue was uninitialized
788 because the mail operation's in the queue might still try to access
789 the account manager (see modest_mail_operation_notify_end()). This
790 fixes a potential crash when terminating the application.
792 2007-06-21 Murray Cumming <murrayc@murrayc.com>
794 * src/modest-search.c:
795 (search_mime_part_and_child_parts): Moved some code here so we
796 can search recursively in child folders.
797 (modest_search_folder): Search in the message as a mime part, instead
798 of just its child mime parts.
799 (read_chunk), (search_mime_part_ogs):
800 Check how many bytes were read, to prevent an endless loop.
801 Searching in message bodies now works. This finishes the fix for
802 projects.maemo.org bug NB#61007.
804 2007-06-20 Murray Cumming <murrayc@murrayc.com>
806 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
807 Add a g_warning when the item is not a folder.
809 * src/modest-ui-dimming-rules.c:
810 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
811 when selected item is not a folder (for instance, an account), because
812 the UI spec only talks about folders.
813 I am not sure what the UI spec wants, so this might not totally fix
814 projects.maemo.org bug NB#60794.
816 2007-06-20 Murray Cumming <murrayc@murrayc.com>
818 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
819 (load_from_file): Sort the list. The unsorted list would be more noticeable
820 in non-English locales.
822 * src/maemo/modest-msg-edit-window.c:
823 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
824 warning and fix the build.
826 * src/maemo/modest-progress-bar-widget.c:
827 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
828 avoid a g_warning, and probably to avoid a crash.
830 2007-06-20 Murray Cumming <murrayc@murrayc.com>
832 * src/modest-search.c: (modest_search_folder): Check for a GError
833 when calling tny_folder_get_headers(), to show that this is not the cause
836 2007-06-20 Murray Cumming <murrayc@murrayc.com>
838 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
839 Actually set the body query instead of the subject query.
841 * src/modest-search.c: (search_mime_part_ogs),
842 (search_mime_part_strcmp): Remove extra space from the text/* regex,
843 which would probably cause it to fail if we got this far.
845 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
846 to simplify the code.
847 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
848 be causing search-in-body to fail.
850 2007-06-20 Murray Cumming <murrayc@murrayc.com>
852 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
854 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
855 Better debug message when the folder cannot be found.
856 This should help with fixing projects.maemo.org bug #61287.
857 * src/modest-search.c: (add_hit): Do not leak the furl string.
859 2007-06-20 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-ui-actions.c:
862 (modest_ui_actions_on_folder_selection_changed):
863 Do not special-case TNY_MERGE_FOLDER here, because
864 modest_tny_folder_get_account() already does that. This fixes
865 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
866 shown when the Outbox was selected).
868 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
870 * libmodest-dbus-client/libmodest-dbus-client.c:
871 (_dbus_iter_get_string_or_null): Initialize the string variable in
872 case this helps with Dirk's crash.
874 2007-06-19 Murray Cumming <murrayc@murrayc.com>
876 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
877 though it is not implemented yet (this function is maybe not even used),
878 to avoid breaking ABI in future.
879 * libmodest-dbus-client/libmodest-dbus-client.c:
880 (get_attachments_string): Moved some code into this generic function.
881 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
882 sends email. It is maybe not used.
883 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
884 (on_send_mail): Use attachments.
886 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
887 * src/maemo/modest-msg-edit-window.c:
888 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
889 a filename before using it, to fix projects.maemo.org bug NB#58233.
891 2007-06-19 Murray Cumming <murrayc@murrayc.com>
893 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
894 Initialize the continue_download variable to fix the build, and probably
895 to fix randome behaviour.
897 2007-06-18 Armin Burgmeier <armin@openismus.com>
899 * src/modest-tny-send-queue.h:
900 * src/modest-tny-send-queue.c: Keep track of the status of messages in
901 the queue so we can later show it in the UI. Replaced
902 modest_tny_send_queue_msg_is_being_sent() by
903 modest_tny_send_queue_get_msg_status().
905 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
907 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
908 gpointer. This probably was not harmful, but just to be sure.
910 2007-06-18 Murray Cumming <murrayc@murrayc.com>
912 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
913 Fix the build, but leave the function broken on Bora, because
914 hildon_uri_action_get_service() does not exist.
915 osso_uri_action_get_service() does not exist either, it seems.
917 2007-06-18 Murray Cumming <murrayc@murrayc.com>
919 * src/modest-tny-account.c:
920 (modest_tny_account_new_from_server_account):
921 Uncommented the url debug output again, because it is useful for
922 debugging, as I said in the comment.
924 2007-06-18 Murray Cumming <murrayc@murrayc.com>
926 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
928 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
929 for Mameo Bora, to fix the build.
931 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
934 Fixed build with hildon < 0.99
936 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
937 Check if the selected account is busy instead of checking all accounts
939 * src/modest-account-mgr-priv.h:
940 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
941 (modest_account_mgr_init), (compare_account_name),
942 (modest_account_mgr_set_account_busy),
943 (modest_account_mgr_account_is_busy):
944 * src/modest-account-mgr.h:
945 Added busy information to the account manager. It possible to
946 set an account to busy or not busy now.
948 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
949 (modest_mail_operation_update_account),
950 (modest_mail_operation_notify_end):
951 Set the account to busy/not busy depending on the operation state.
953 * src/widgets/modest-account-view.c:
954 (modest_account_view_finalize), (get_last_updated_string),
955 (update_account_view), (on_account_busy_changed), (init_view):
956 Show string "Refreshing..." if the account is currently busy.
958 All this fixes projects.maemo.org bug NB#59711
960 2007-06-14 Armin Burgmeier <armin@openismus.com>
962 * src/widgets/modest-attachments-view.h:
963 * src/widgets/modest-attachments-view.c: Added
964 modest_attachments_view_has_attachments() and fixed coordinate
965 transformation in get_att_view_at_coords(). This fixes attachment
968 * src/widgets/modest-msg-view.c: Make use of
969 modest_attachments_view_has_attachments() to decide whether to show
970 attachments in the header.
972 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
974 * src/maemo/modest-connection-specific-smtp-edit-window.c:
975 (on_change), (on_combo_security_changed),
976 (modest_connection_specific_smtp_edit_window_init),
977 (modest_connection_specific_smtp_edit_window_set_connection),
978 (modest_connection_specific_smtp_edit_window_is_dirty):
979 * src/maemo/modest-connection-specific-smtp-edit-window.h:
980 * src/maemo/modest-connection-specific-smtp-window.c:
983 Show an comfirmation dialog for the smpt-edit-window if there are
984 unsaved changes and the user hits cancel.
985 (projects.maemo.org bug NB#60479)
987 2007-06-14 Armin Burgmeier <armin@openismus.com>
989 * src/maemo/easysetup/modest-easysetup-wizard.c:
990 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
991 address" info in banner instead of node, and select all the text as
992 per UI spec. This fixes projects.maemo.org bug NB#60550.
994 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
996 reviewed by: <delete if not using a buddy>
998 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
999 * src/modest-ui-actions.c: (folder_refreshed_cb):
1001 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1003 * src/widgets/modest-folder-view.c: (filter_row):
1004 Explictly filter out the per-account outbox accounts. I don't know why
1005 these only sometimes show up, but now they should never show up in the UI.
1006 This should fix projects.maemo.org bug NB#60160.
1008 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1010 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1011 when the toolbar does not exist yet.
1012 * src/modest-widget-memory.c: (save_settings_header_view):
1013 Added g_warnings() to help us to discover when we are trying to set
1014 an empty columns list in gconf.
1016 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-init.h:
1019 * src/modest-init.c:
1020 Added modest_init_get_default_header_view_column_ids().
1022 * src/modest-widget-memory.c: (restore_settings_header_view):
1023 Use the new function to get defaults, if the gconf key is empty,
1024 instead of not creating any columns. This seems to fix the
1025 empty right-hand pane problems.
1027 * src/widgets/modest-header-view.h: Improved documentation.
1029 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1031 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1032 Revert the use of the display name as the account name, because this
1033 is generally wrong and would break the code that follows.
1035 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1037 * src/maemo/easysetup/modest-easysetup-wizard.c:
1038 (check_for_supported_auth_methods), (on_before_next),
1041 More correct fix for projects.maemo.org bug NB# 58991
1042 Do not longer accept AUTH_PASSWORD as secure method and choose
1043 correct method when creating the account.
1045 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1047 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1048 Fixed projects.maemo.org bug NB# 58991
1050 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1052 * src/modest-init.c: (modest_init_init_core),
1053 (modest_init_local_folders): Fixed compilation errors.
1055 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1057 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1058 Remove unnecessary lib/include, though it is good in principle when needed.
1060 * src/modest-init.c: (modest_init_one_local_folder),
1061 (modest_init_local_folders):
1062 * src/modest-init.h: Initialize the .modest library for memory cards,
1063 instead of just doing nothing for them. This should allow us to create
1064 folders there, fixing projects.maemo.org bug NB#59297.
1066 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1068 * libmodest-dbus-client/libmodest-dbus-client.c:
1069 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1070 (libmodest_dbus_client_compose_mail),
1071 (libmodest_dbus_client_open_message),
1072 (libmodest_dbus_client_send_and_receive),
1073 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1075 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1076 (on_idle_open_message), (modest_dbus_req_handler),
1077 (search_result_to_message), (modest_dbus_req_filter):
1078 * src/modest-search.c: (add_hit), (modest_search_folder),
1079 (modest_search_all_accounts): Improved debug messages.
1081 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1083 * src/modest-tny-account-store.c:
1084 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1087 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1090 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1092 * src/modest-tny-account-store.c: (get_server_accounts):
1093 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1094 even when there are no accounts, so that the Outbox folder is always
1095 visible. This fixes projects.maemo.org bug NB#60158.
1097 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1099 * src/maemo/modest-main-window.c: (create_details_widget):
1100 Use the mcen_va_never logical ID.
1102 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1104 * src/dbus_api/modest-dbus-api.h:
1105 * src/dbus_api/modest-dbus-callbacks.c:
1106 (on_idle_open_default_inbox), (on_open_default_inbox),
1107 (modest_dbus_req_handler):
1108 Added a new OpenDefaultInbox method.
1110 * libmodest-dbus-client/libmodest-dbus-client.h:
1111 * libmodest-dbus-client/libmodest-dbus-client.c:
1112 Added libmodest_dbus_client_open_default_inbox() to call the new
1113 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1114 though it should maybe be used by a new osso-email-interface function.
1116 * tests/dbus_api/Makefile.am:
1117 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1120 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1122 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1123 NULL, so that the signals get all the keys. This should not actually
1124 change any behaviour because we currently update everything when anything
1127 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1129 * src/widgets/modest-folder-view.c: (text_cell_data),
1130 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1131 (find_inbox_iter): If tinymail tells us that the folder is
1132 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1133 This causes the inbox to be selected at startup, fixing part of
1134 projects.maemo.org bug NB#56305.
1136 * src/modest-ui-dimming-rules.c:
1137 (modest_ui_dimming_rules_on_tools_smtp_servers):
1138 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1139 the SMTP servers menu item.
1140 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1141 that the SMTP Servers menu item is dimmed when there are no accounts,
1142 as a future version of the UI spec will require. This fixes
1143 projects.maemo.org bug NB#56305.
1145 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1147 * src/maemo/modest-maemo-utils.c:
1148 (modest_maemo_utils_get_supported_secure_authentication_methods):
1149 Added label to dialog instead of unreadable title
1151 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1152 (modest_main_window_new):
1153 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1156 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1157 * src/modest-account-mgr.h:
1158 Added method to avoid code duplication
1160 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1161 (modest_ui_actions_on_send_receive):
1162 Use modest_account_mgr_has_accounts
1164 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1166 * src/maemo/easysetup/modest-presets.c:
1167 (modest_presets_get_info_server_security): Do not report secure auth
1169 * src/modest-protocol-info.c: Use the defines for the gconf key names
1170 for secure authentication. This was not working because we were writing
1171 Password and reading password, and the check was case sensitive.
1172 With this, gmail now works for receiving and sending when created via
1175 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1177 * src/maemo/easysetup/modest-presets.c:
1178 (modest_presets_get_info_server_security): Correct the key name for
1179 SecureSmtp, because it seems to be case-sensitive.
1180 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1181 Do not try to get the 0th notebook page if there are 0 pages, to
1182 avoid a g_warning().
1184 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1187 Prevent use of the new notification feature for now, because it currently
1188 shows one dialog for each new email, which is annoying.
1190 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1192 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1193 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1194 when no country was selected, so that we show the global ones.
1195 * src/maemo/easysetup/modest-presets.c:
1196 (modest_presets_get_providers): Return only the global providers, not
1197 all providers when mmc=0 was requested.
1199 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1201 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1202 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1203 provider ID in the combo.
1205 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1206 Do not show the page numbers, because it would be confusing when we add
1207 the 2 extra pages for the custom setup, when the user chooses the "Other"
1208 provider. This fixes projects.maemo.org bug NB#59028
1210 * src/modest-init.c: (modest_init_init_core),
1211 (modest_init_local_folders):
1212 * src/modest-init.h:
1213 * src/modest-tny-account.c:
1214 (modest_tny_account_new_for_local_folders): Do not create default folders
1215 for the memory card. This should fix projects.maemo.org bug NB#59328.
1217 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1219 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1220 Free the changed_conf_keys string items. They are already freed in the
1221 idle handler if that runs first.
1223 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1225 * src/modest-ui-actions.c:
1226 (modest_ui_actions_on_password_requested): Check that the server name
1227 is not NULL, because I just saw a password dialog with (null) as the
1230 * src/modest-tny-folder.[h|c]: Added
1231 modest_tny_folder_is_memory_card_folder().
1232 * src/modest-ui-dimming-rules.c:
1233 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1234 menu item for memory cards, as per the UI spec (section 7.4). This should
1235 fix projects.maemo.org bug NB#59297.
1237 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1239 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1240 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1241 is another problem with the code, see Murray's comment at line 772)
1243 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1245 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1246 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1247 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1248 (load_from_file), (easysetup_country_combo_box_init),
1249 (easysetup_country_combo_box_get_active_country_ids),
1250 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1251 instead of just one ID, to avoid duplicate country names in the UI.
1253 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1254 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1255 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1256 a single ID, avoiding duplicate providers.
1257 * src/maemo/easysetup/modest-easysetup-wizard.c:
1258 (on_combo_account_country): Adapt to use a list.
1260 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1263 keys changed in the last X seconds.
1265 * src/modest-account-mgr.h:
1266 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1267 (on_key_change), (modest_account_mgr_class_init),
1268 (modest_account_mgr_init), (modest_account_mgr_finalize):
1269 As the keys are changed, save them in a GSList* and signal that GSList*
1270 further every X seconds, to batch changes, to allow us to do just one
1271 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1272 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1274 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1275 changed signal signature.
1277 * src/modest-conf.c: (modest_conf_set_list),
1278 (modest_conf_on_change): Reenable notification.
1280 (modest_conf_maemo_fake_on_change): Comment out the hack that
1281 notified immediately instead of asynchronously.
1283 * src/widgets/modest-account-view.h:
1284 * src/widgets/modest-account-view.c:
1285 (update_account_view): Select the previously-selected account ID,
1286 if possible. This fixes projects.maemo.org bug NB#56933.
1288 (on_account_changed), (on_account_removed),
1289 (modest_account_view_select_account):
1291 Remove the block/unblock functions
1292 because they were not useful.
1294 * src/maemo/modest-account-view-window.c:
1295 (on_delete_button_clicked), (on_edit_button_clicked),
1296 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1298 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1300 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1301 Improve the error dialog to show Incorrect Account Settings, which seems
1302 clearer, and say that the internal error message (to be removed from the
1303 dialog later) is often misleading.
1304 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1306 * src/modest-tny-account.c:
1307 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1308 URL because this is so useful for debugging on the device.
1310 * src/widgets/modest-serversecurity-combo-box.c:
1311 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1313 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1315 * src/modest-mail-operation.c:
1316 (modest_mail_operation_send_new_mail):
1317 Added a comment about a nasty but apparently harmless message. Details
1318 added to the wiki g_warnings() page.
1320 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1323 (modest_tny_send_queue_class_init):
1324 Do not use the priv struct because it is empty, to avoid g_warnings
1325 about a non-existant priv struct.
1327 * src/modest-tny-account-store.c:
1328 (modest_tny_account_store_get_server_account),
1329 (modest_tny_account_store_get_transport_account_for_open_connection
1330 ): Do not try to get transport server accounts for local folders,
1331 because they don't have any. This avoids a g_warning().
1333 * src/maemo/modest-main-window.c:
1334 (modest_main_window_notify_send_receive_initied),
1335 (on_configuration_key_changed):
1336 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1337 * src/modest-defs.h:
1338 * src/modest-mail-operation.c:
1339 (modest_mail_operation_update_account):
1340 * src/modest-tny-account-store.h:
1341 * src/modest-tny-account.c:
1342 (modest_tny_account_get_special_folder),
1343 (modest_tny_account_new_for_local_folders),
1344 (modest_tny_account_new_for_per_account_local_outbox_folder):
1345 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1346 * src/modest-tny-local-folders-account.c:
1347 (add_account_folders_to_merged_folder):
1348 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1349 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1350 (modest_ui_actions_on_send):
1351 * src/widgets/modest-folder-view.c: (update_model):
1352 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1353 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1354 modest_tny_account_store_get_tny_account_by_account() to
1355 modest_tny_account_store_get_server_account() to make the code clearer.
1357 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1359 * src/dbus_api/modest-dbus-api.h:
1360 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1361 * src/maemo/modest-msg-edit-window.c:
1362 (modest_msg_edit_window_attach_file_noninteractive):
1363 added g_warning in case the file to be attached does not exist
1364 * tests/dbus_api/test_compose_mail.c: (main):
1365 removed obsolete comment, added generic files as test case
1367 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1369 * src/modest-tny-account-store.c: (get_server_accounts):
1370 Create the local folders account only once, not once for each outbox, and
1371 not only when there are some outboxes.
1373 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1375 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1376 code that is causing a crash at startup. Sergio says that he is fixing this.
1378 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1380 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1381 * src/maemo/modest-account-settings-dialog.c:
1382 (create_page_outgoing),
1383 (modest_account_settings_dialog_set_account_name),
1384 (save_configuration):
1385 - Fixed handling of the "Use secure authentication" toggle to comply with
1386 the ui specification. See also projects.maemo.org bug NB#58400
1388 - Restore the Secure connection setting combo correctly when loading
1391 * src/maemo/modest-maemo-utils.c:
1392 (on_camel_account_get_supported_secure_authentication),
1393 (modest_maemo_utils_get_supported_secure_authentication_methods):
1394 Fixed a crasher if operation is canceled
1396 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1397 (modest_protocol_info_auth_is_secure):
1398 * src/modest-protocol-info.h:
1400 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1401 the sense of the "Use secure authentication" toggle.
1403 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1405 * src/modest-tny-account-store.h:
1406 * src/modest-tny-account-store.c:
1407 Added modest_tny_account_store_get_local_folders_account().
1409 * src/modest-tny-folder.h:
1410 * src/modest-tny-folder.c:
1411 (modest_tny_folder_get_account):
1412 Added this replacement for tny_folder_get_account() which returns
1413 the local-folders account for TnyMergeFolders, to avoid the
1414 warning about the unimplemented get_account_func() vfunc().
1416 (modest_tny_folder_get_rules),
1417 * src/modest-ui-actions.c:
1418 (modest_ui_actions_on_folder_selection_changed):
1419 * src/modest-mail-operation.c:
1420 (modest_mail_operation_remove_folder),
1421 (modest_mail_operation_xfer_folder),
1422 (modest_mail_operation_rename_folder),
1423 (modest_mail_operation_get_msg),
1424 (modest_mail_operation_get_msgs_full),
1425 (modest_mail_operation_remove_msg),
1426 (modest_mail_operation_xfer_msgs),
1427 (modest_mail_operation_refresh_folder):
1428 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1430 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1432 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1433 (modest_server_account_set_security):
1434 * src/modest-defs.h: Add comments explaining that our
1435 UI spec means TLS when it says Normal, so these do not look like errors.
1437 * src/modest-tny-account.c:
1438 (modest_tny_account_new_from_server_account): Use the new tinymail
1439 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1440 for TLS. This should fix projects.maemo.org bug NB#58460.
1442 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/easysetup/modest-easysetup-wizard.c:
1445 (create_account): Correct the position of the gconf sanity check warning.
1446 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1447 of using the g_idle_add() hack, because this does not seem to be necessary
1448 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1449 caused by something other than maemo's gconf.
1450 This fixes projects.maemo.org bug #59022.
1452 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1454 * src/modest-account-mgr-helpers.c:
1455 (modest_account_mgr_get_default_account): Do not check that the account
1456 exists if there is no default account (NULL), to fix a runtime warning.
1458 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1460 * src/widgets/modest-folder-view.c: (update_model):
1461 Do not unref the treemodel before we have finished with it.
1462 This prevents a valgrind warning and an occasional crash at startup.
1464 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1466 * libmodest-dbus-client/libmodest-dbus-client.h:
1467 added libmodest_dbus_client_compose_mail()
1468 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1470 added functions needed for SendAsMail() functionality
1471 * src/maemo/modest-msg-edit-window.c:
1472 (modest_msg_edit_window_attach_file_noninteractive):
1473 non interactively attaching files to message edit window
1474 * src/widgets/modest-msg-edit-window.h:
1475 * tests/dbus_api/Makefile.am:
1476 added test_compose_mail.c
1477 * tests/dbus_api/test_compose_mail.c: (main):
1479 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1481 * src/modest-account-view.c:
1482 Fixed bug projects.maemo.org bug NB#59307
1484 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1486 * src/maemo/easysetup/modest-easysetup-wizard.c:
1487 (get_serverport_incoming), (on_before_next), (create_account):
1488 * src/maemo/modest-account-settings-dialog.c:
1489 (modest_account_settings_dialog_set_account_name):
1490 * src/maemo/modest-maemo-utils.c:
1491 (on_camel_account_get_supported_secure_authentication_status),
1492 (on_camel_account_get_supported_secure_authentication),
1493 (on_secure_auth_cancel),
1494 (modest_maemo_utils_get_supported_secure_authentication_methods):
1496 Implemented security authentication for settings and easysetup.
1498 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1500 * src/maemo/modest-main-window.c: (create_details_widget):
1501 Show the total size for memory card accounts too, instead of showing
1502 the name again. Fixes bug projects.maemo.org bug NB#59307.
1504 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1507 * src/modest-tny-simple-folder-store.c:
1508 * src/modest-tny-simple-folder-store.h: Removed.
1510 * src/modest-tny-local-folders-account.h
1511 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1512 for the local-folders maildir, with an extra TnyMergedFolder containing
1513 the folders of the per-account outbox store accounts.
1514 * src/modest-tny-account-store.c: (get_server_accounts):
1515 Add the outboxes to the special local folders account after creating it.
1517 * src/modest-tny-account.c:
1518 (modest_tny_account_new_for_local_folders): Create the derived
1519 account when creating the main local-folders account.
1521 * src/maemo/modest-main-window.c: (create_details_widget),
1522 (modest_main_window_set_contents_style):
1523 Adapted to the use of the derived account instead of the folder store.
1525 * src/modest-ui-actions.c:
1526 (modest_ui_actions_on_folder_selection_changed):
1527 * src/modest-ui-dimming-rules.c:
1528 (modest_ui_dimming_rules_on_new_folder):
1529 * src/widgets/modest-folder-view.c: (text_cell_data),
1530 (icon_cell_data), (filter_row), (update_model),
1531 (get_cmp_rows_type_pos):
1534 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1535 Do not get the priv struct, because no priv struct has been set,
1536 to avoid a runtime warning.
1538 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1539 #ifelse with #else, to fix a warning, to fix the build.
1542 2007-06-05 Christian Kellner <ckellner@openismus.com>
1544 * libmodest-dbus-client/libmodest-dbus-client.c:
1545 Fix small typo in doc (why do you always see them
1546 AFTER committing stuff?)
1549 2007-06-05 Christian Kellner <ckellner@openismus.com>
1551 * libmodest-dbus-client/libmodest-dbus-client.c:
1552 (libmodest_dbus_client_search):
1553 Initialize hit list with NULL. Also set folder list
1554 to "" if NULL was supplied.
1557 2007-06-03 Christian Kellner <ckellner@openismus.com>
1559 * libmodest-dbus-client/libmodest-dbus-client.c:
1560 (modest_search_hit_list_free):
1561 Make it save to call it with NULL.
1563 * src/dbus_api/modest-dbus-callbacks.c:
1564 * src/modest-search.c:
1565 Return full ModestSearchHits as the search result list not TnyHeader
1566 since can't be around withouth the correspoding TnyFolder.
1568 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1570 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1571 Added currently commented code to check for secure auth
1573 * src/maemo/modest-account-settings-dialog.c: (on_response),
1574 (save_configuration), (show_ok):
1575 Fixed projects.maemo.org bugs NB #59248 and #59251
1577 * src/maemo/modest-maemo-utils.c:
1578 (on_camel_account_get_supported_secure_authentication_status),
1579 (on_camel_account_get_supported_secure_authentication),
1580 (modest_maemo_utils_get_supported_secure_authentication_methods):
1581 * src/maemo/modest-maemo-utils.h:
1582 Moved get_supported_secure_authentication() method here to be able
1583 to use it from easysetup wizard.
1585 * src/modest-pair.c: (on_pair_compare_as_string):
1586 Should compare string with first part of pair and not
1587 strcmp pairs which will crash.
1589 * src/modest-protocol-info.c:
1590 (modest_protocol_info_protocol_is_store):
1591 * src/modest-protocol-info.h:
1592 Added modest_protocol_info_get_auth_protocol_name()
1594 2007-06-03 Armin Burgmeier <armin@openismus.com>
1596 * src/modest-mail-operation.c:
1597 (modest_mail_operation_get_msgs_full): Set priv->account also when
1598 only retrieving a single message. This avoids a crash when canceling
1601 (modest_mail_operation_notify_end): Do not explicitely remove the
1602 operation from the queue but only emit the progress_changed signal.
1603 The queue itself listens to that signal to remove the operation when
1604 it is finished. This reduces coupling and removes a potential deadlock
1605 when modest_mail_operation_notify_end() is called from the queue
1606 itself. If that is a problem performance-wise, I would suggest to
1607 implement a status-changed signal or something.
1609 * src/modest-mail-operation-queue.c: Make sure to never call a
1610 function from another file while the queue is locked. This (hopefully)
1611 fixes another deadlock when exiting the application while retrieving
1614 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1616 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1617 Fixed build if libogs is not available
1619 2007-06-03 Christian Kellner <ckellner@openismus.com>
1621 * libmodest-dbus-client/libmodest-dbus-client.h:
1622 * libmodest-dbus-client/libmodest-dbus-client.c:
1623 (libmodest_dbus_client_delete_message):
1624 Implement deletion of messages (Client side).
1626 (modest_search_hit_free),
1627 (modest_search_hit_list_free):
1628 Utility functions to free the result hits.
1630 * src/dbus_api/modest-dbus-api.h:
1631 * src/dbus_api/modest-dbus-callbacks.c:
1632 (on_delete_message),
1633 (modest_dbus_req_handler):
1634 Implement deletion of messages (Server side).
1636 * tests/dbus_api/test_search.c: (main):
1639 * tests/dbus_api/Makefile.am:
1640 * tests/dbus_api/test_delete_message:
1641 Add little test for the message deletion logic
1643 2007-06-03 Armin Burgmeier <armin@openismus.com>
1645 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1646 when the operation queue was not empty. projects.maemo.org bug
1649 2007-06-03 Armin Burgmeier <armin@openismus.com>
1651 * src/widgets/modest-account-view.c
1652 (on_account_default_toggled): Toggle default account column
1653 explicitely instead of waiting for gconf notification (which is
1654 currently ignored). This should fix projects.maemo.org bug NB#56910
1655 for now. It should probably be removed when gconf notifications are
1658 2007-06-03 Christian Kellner <ckellner@openismus.com>
1660 * libmodest-dbus-client/libmodest-dbus-client.c:
1661 Removed debugging spew.
1663 * src/dbus_api/modest-dbus-callbacks.c:
1664 Added debugging info.
1666 * src/modest-search.c:
1667 (modest_search_all_accounts):
1668 Use tny_account_store_get_accounts () on the account store
1669 to get all accounts which is the way to get all accounts.
1671 * tests/dbus_api/test_search.c: (main):
1672 Make it possible to supply the search term on the command line.
1674 2007-06-03 Christian Kellner <ckellner@openismus.com>
1676 * libmodest-dbus-client/libmodest-dbus-client.c:
1677 * libmodest-dbus-client/libmodest-dbus-client.h:
1678 Implement searching for mesages over raw dbus. (Client side)
1680 * src/dbus_api/Makefile.am:
1681 * src/dbus_api/modest-dbus-api.h:
1682 * src/dbus_api/modest-dbus-callbacks.c:
1683 * src/dbus_api/modest-dbus-callbacks.h:
1684 Search framework (Server side). Also implement on_idle_open_message().
1686 * src/maemo/modest-platform.c: (modest_platform_init):
1687 Prepare for raw dbus/osso rpc interaction.
1689 * src/modest-search.h:
1690 Changed minsize from unspecific guint to guint32.
1692 * src/modest-search.c:
1694 Added strange hack which magically made tnymail work.
1696 (modest_search_folder),
1697 (modest_search_account),
1698 (modest_search_all_accounts):
1699 Implement helper functions to search all accounts, specific account
1702 * tests/dbus_api/Makefile.am:
1703 * tests/dbus_api/test_open_message.c:
1704 Read url to open from commandline.
1706 * tests/dbus_api/test_search.c:
1707 Implement small test for dbus search stuff
1709 2007-06-02 Armin Burgmeier <armin@openismus.com>
1711 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1712 include account type and account title. This fixes projects.maemo.org
1715 * src/maemo/modest-account-view-window.c: Set a title for the window.
1717 2007-06-02 Armin Burgmeier <armin@openismus.com>
1719 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1720 incoming and outgoing server name based on email address and server
1721 types as long as the names have not been edited manually. This fixes
1722 projects.maemo.org bug NB#58671.
1724 2007-06-02 Armin Burgmeier <armin@openismus.com>
1726 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1727 server type cannot be changed in future to the incoming details page
1728 when creating an account. This fixes projects.maemo.org bug NB#59029.
1730 2007-06-02 Armin Burgmeier <armin@openismus.com>
1732 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1733 and assigned max width chars so that they wrap instead of being
1734 truncated. Fixes projects.maemo.org bug NB#56126.
1736 2007-06-02 Armin Burgmeier <armin@openismus.com>
1738 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1739 introductory note to the connection specific smtp servers dialog, as
1740 section 8.12 of the email UI specification requires. This fixes
1741 projects.maemo.org bug NB#59212.
1743 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1745 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1746 Check for running mail operations, and offer to cancel them, as per the UI
1747 spec. This fixes projects.maemo.org bug NB#59041 .
1748 However, I suspect that tinymail may still use the network connection
1749 in ways that we cannot detect or cancel. But it should at least adapt to
1750 changes fairly well.
1752 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1754 * src/modest-tny-account-store.c: (recreate_all_accounts),
1755 (get_cached_accounts), (get_server_accounts): Do more sensible
1756 ref-counting of the temporarily-cached outbox accounts list. This seems
1757 to fix a crash when entering the password when the password was wrong.
1759 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1761 * src/gnome/modest-main-window.c: (connect_signals):
1762 * src/modest-tny-account-store.c: (get_password),
1763 (modest_tny_account_store_alert): Added comments and clues and
1764 commented-out code about how we currently fail to deal with connection
1765 errors and wrong passwords, and how we should.
1767 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1769 * src/widgets/modest-retrieve-combo-box.c:
1770 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1771 This fixes projects.maemo.org bug NB#58472 .
1773 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/easysetup/modest-easysetup-wizard.c:
1776 (create_page_complete_easysetup):
1777 (create_page_complete_custom): Correct the last commit,
1778 putting the correct sentences in the correct pages.
1780 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1782 * src/maemo/easysetup/modest-easysetup-wizard.c:
1783 (create_page_complete_custom): Show the second sentence of text
1784 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1787 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1789 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1790 Set the leave-on-server conf key by default. This fixes
1791 projects.maemo.org bug NB#59258 .
1793 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1795 * src/maemo/modest-account-view-window.c:
1796 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1797 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1800 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1802 * src/maemo/easysetup/modest-easysetup-wizard.c:
1803 (create_caption_new_with_asterisk):
1804 * src/maemo/modest-account-settings-dialog.c:
1805 (create_caption_new_with_asterisk):
1806 Uncomment the code to add the asterisk, because they are no longer in the
1807 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1808 (update_incoming_server_title): Add an asterisk here too.
1810 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1812 * src/maemo/modest-maemo-global-settings-dialog.c:
1813 (current_connection): Check that we are even connected before trying to
1814 get the current connection name, to prevent a warning.
1816 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1817 Change the comments because tny_maemo_conic_device_connect() is now meant to
1819 * src/modest-mail-operation.c:
1820 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1821 make sure we have a connection and fail if we can't connect.
1823 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1825 * src/maemo/modest-main-window.c:
1826 (on_account_store_connecting_finished): Do not try to get the
1827 connection ID if we are not really connected. I am surprised that
1828 this signal handler is called when we are not connected.
1830 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-error.h:
1833 * src/modest-ui-actions.c:
1834 (modest_ui_actions_get_msgs_full_error_handler):
1835 Renamed an enum, added comments, added an enum
1836 for retrieve-limit errors.
1838 * src/modest-mail-operation.c: (foreach_add_item),
1839 (internal_folder_observer_update), (update_account_thread),
1840 (modest_mail_operation_get_msgs_full):
1841 (modest_mail_operation_update_account),
1842 Added comments about how this works, and some code that should
1843 (but does not) check the retrieve-limit. See the TODO comment.
1845 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1847 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1848 Initialize help_id to fix the build. Warnings are good.
1850 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1852 * src/widgets/modest-hbox-cell-renderer.c:
1853 (modest_hbox_cell_renderer_append):
1854 * src/widgets/modest-vbox-cell-renderer.c:
1855 (modest_vbox_cell_renderer_append):
1856 Fix the last commit by doing an extra ref.
1858 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1860 * src/widgets/modest-hbox-cell-renderer.c:
1861 (modest_hbox_cell_renderer_append):
1862 * src/widgets/modest-vbox-cell-renderer.c:
1863 (modest_vbox_cell_renderer_append):
1864 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1865 to fix the build with Maemo Bora.
1866 However, there seems to be a remaining crash, probably due to reference
1869 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1871 * src/modest-tny-account.c:
1872 (modest_tny_account_new_for_local_folders):
1873 Use hildon_file_system_info_async_new() to get a better name for
1874 the memory card account, setting it as the account name.
1875 The timing seems to work, but this is probably
1876 not the best place to do this. See the TODO comment.
1877 * src/maemo/modest-main-window.c: (create_details_widget):
1878 * src/widgets/modest-folder-view.c: (text_cell_data):
1879 Use the tny account name instead of hardcoding a name.
1881 2007-05-30 Christian Kellner <ckellner@openismus.com>
1883 * src/modest-search.c: (modest_search):
1884 Correctly set part_search_func even if we have already parsed
1885 the query and thus a valid OgsTextSearcher object.
1887 2007-05-30 Christian Kellner <ckellner@openismus.com>
1890 Search and check for libogs.
1893 Incooparte the ogs build env.
1895 * src/modest-mime-part-search-stream.c:
1896 * src/modest-mime-part-search-stream.h:
1897 Removed since we do the real searching now in modest-search.c.
1899 * src/modest-search.c:
1900 * src/modest-search.h:
1901 Implement support for ogs. We use that if available and requested
1902 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1903 should now handle the corner case when the search term is spread
1904 across multiple reads.
1905 Also the logic in modest_search () was corrected to search all
1906 requested fields until one is found.
1908 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1910 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1912 * src/modest-init.h:
1913 * src/modest-init.c: Made modest_init_local_folders() take a
1914 path and be public so we can iniitialize maildir folders on
1917 * src/modest-local-folder-info.h:
1918 * src/modest-local-folder-info.c:
1919 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1921 * src/modest-tny-account.c:
1922 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1923 still means the standard local-folders path on the local volume.
1925 * src/modest-tny-account-store.c:
1926 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1927 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1928 all accounts when that happens.
1929 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1930 this too, so it shows up in the treeview.
1932 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1934 * src/maemo/modest-maemo-global-settings-dialog.c:
1935 (current_connection):
1936 * src/widgets/modest-global-settings-dialog.c:
1937 (current_connection_default):
1938 Use the enum values instead of 0, 1 and -1,
1939 to make the code clearer.
1941 * src/modest-account-mgr-helpers.c:
1942 (modest_account_mgr_get_connection_specific_smtp): Make this code
1945 * src/modest-runtime.h:
1946 * src/modest-runtime.c:
1947 Added modest_runtime_remove_all_send_queues().
1948 * src/maemo/modest-main-window.c:
1949 (on_account_store_connecting_finished): Recreate the send queues,
1950 using the appropriate transport accounts for this new connection.
1951 Some futher adapting might be needed if the old send queues are not
1952 automatically stopped at this point.
1954 * src/modest-tny-account-store.c: (get_server_accounts):
1955 Create the connection-specific transport accounts, so that they can
1956 be found later by their ID.
1958 * src/modest-tny-account.h:
1959 * src/modest-tny-account.c:
1960 Added modest_tny_account_new_from_server_account_name().
1961 modest_tny_account_new_from_server_account(): Do not create the
1962 send queues here, because they will be
1963 recreated anyway when the connection changes for the first time.
1965 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-local-folder-info.h:
1968 * src/modest-local-folder-info.c:
1969 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1970 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1971 tbox_folder): Take a modest account name instead of a server TnyAccount,
1972 so we can have per-modest-account rather than per-transport-account
1974 We must make sure that we change or recreate the exisitng send queues
1975 when the connection changes for connection-specific transport accounts.
1977 * src/modest-tny-account-store.c:
1978 (create_per_account_local_outbox_folders): Create outboxed per modest
1979 account, not per transport account.
1981 * src/modest-tny-account.h:
1982 * src/modest-tny-account.c:
1983 (modest_tny_account_get_special_folder): For outboxes, get the
1984 parent modest account name. The account is ignored for other folders.
1985 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1986 modest account name rather than a server TnyAccount.
1988 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1990 * src/modest-tny-account.c:
1991 (modest_tny_account_new_from_server_account):
1992 Call modest_runtime_get_send_queue() immediately after creating transport
1993 accounts, so that they start trying to send email from the outbox as soon
1994 as possible at startup. This is probably what we want.
1996 * src/modest-mail-operation.c: (update_account_thread):
1997 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1998 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1999 * src/modest-tny-send-queue.h:
2000 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2001 (modest_ui_actions_on_send):
2002 Added comments about how sending works, though it needs some more work.
2004 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-tny-account.c:
2007 (modest_tny_account_get_special_folder): Add TODO because this fails when
2008 the network is busy.
2009 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2010 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2011 Do not try to show this window when there is no active account. The UI
2012 specs does not tell us what to do in this case.
2014 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2018 * src/maemo/Makefile.am:
2019 * src/widgets/Makefile.am: Some dist fixes.
2021 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2023 * src/maemo/modest-connection-specific-smtp-window.c:
2024 (on_button_edit): Make the code clearer, to prevent a double free.
2026 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/modest-account-settings-dialog.c:
2029 (modest_account_settings_dialog_set_account_name),
2030 Check the connection-specific smtp servers checkbox if there are any.
2032 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2033 (modest_connection_specific_smtp_edit_window_init):
2034 Start with a suitable port number.
2036 * src/modest-account-mgr-helpers.h:
2037 * src/modest-account-mgr-helpers.c: Added
2038 modest_account_mgr_get_has_connection_specific_smtp().
2040 (modest_account_mgr_set_connection_specific_smtp),
2041 (modest_account_mgr_remove_connection_specific_smtp),
2042 (modest_account_mgr_get_has_connection_specific_smtp),
2043 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2044 connection-specific smtp server accounts in the account, rather than
2045 the server account conf dir.
2047 This fixes bug projects.maemo.org bug NB#58263 .
2049 * src/modest-tny-account-store.c:
2050 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2051 if there are no server accounts yet, to prevent an infinite loop when there
2052 are no accounts. Document that one must be called before the other.
2054 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2056 * src/modest-account-mgr-helpers.c:
2057 (modest_account_mgr_get_default_account): Make sure that at least
2058 one account is always the default, if there are any enabled accounts.
2059 This is just a sanity check that shouldn't be necessary.
2061 * src/modest-account-mgr-priv.c:
2062 (_modest_account_mgr_account_from_key): Unescape the conf key to
2063 get the real account name. For instance, this is an issue if a space
2064 was in the account name, which can happen because the account name
2065 is generated from the display name.
2066 (_modest_account_mgr_get_account_keyname): Always escape the
2068 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2069 Unescape the conf keys to get the real account names.
2071 For instance, previously the is-default radio button in the accounts
2072 list was not checked for any accounts at first. This fixes that,
2073 and might fix several similar bugs.
2075 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2077 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2078 Removed some debug printfs.
2080 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2082 Modest on-disk outbox directories are now here, for instance:
2083 $HOME/.modest/outboxes/<account-id-1>/outbox
2084 $HOME/.modest/outboxes/<account-id-2>/outbox
2086 $HOME/.modest/local-folders/outbox
2087 so we can have a separate outbox for each account.
2088 But they are shown as one outbox in the GtkTreeView, by using a
2089 TnyMergeFolder in a ModestTnySimpleFolderStore.
2092 * src/modest-tny-simple-folder-store.c:
2093 * src/modest-tny-simple-folder-store.h:
2094 Added ModestTnySimpleFolderStore, used to contain folders from
2095 other folder stores, such as other accounts.
2097 * src/modest-tny-outbox-account.h:
2098 * src/modest-tny-outbox-account.c:
2099 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2100 used for the per-account local outbox folders.
2102 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2103 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2104 only use this (internally) now for the non-outbox local folders.
2106 * src/modest-init.h:
2107 * src/modest-init.c: Added modest_init_one_local_folder(), for
2108 setting up the directory structure for each local folder.
2110 * src/modest-local-folder-info.c:
2111 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2112 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2114 * src/modest-local-folder-info.h:
2115 * src/modest-tny-account-store.c: (on_account_removed),
2116 (on_account_changed), (create_per_account_local_outbox_folders),
2117 (get_server_accounts), (modest_tny_account_store_get_accounts),
2118 (modest_tny_account_store_get_tny_account_by_account),
2119 (modest_tny_folder_store_is_virtual_local_folders):
2121 * src/modest-tny-account.h:
2122 * src/modest-tny-account.c:
2123 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2124 to create an on-disk per-account local outbox folder for each
2126 (create_per_account_local_outbox_folders): Create a local outbox folder
2127 for each transport account.
2128 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2129 for all local folders.
2131 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2132 instead of using g_object_get/set() directly. It is clearer.
2134 (modest_tny_folder_store_get_message_count),
2135 (modest_tny_folder_store_get_local_size
2136 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2137 because we now use these with non-acount folder stores.
2139 (modest_tny_account_get_special_folder),
2140 (modest_tny_account_new_from_server_account),
2141 (modest_tny_account_new_from_account):
2142 (recurse_folders): Adjust to the new outbox system.
2144 * src/modest-tny-folder.h:
2145 * src/modest-tny-folder.c:
2146 (modest_tny_folder_is_local_folder),
2147 (modest_tny_folder_get_local_folder_type),
2148 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2150 * src/widgets/modest-main-window.h:
2151 * src/maemo/modest-main-window.c: (create_details_widget),
2152 (modest_main_window_set_contents_style): Show details for any folder store,
2155 (modest_tny_folder_get_rules):
2156 Remove the const. C does not support constness enough for this.
2158 * src/modest-ui-actions.c:
2159 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2160 make all outboxes appear as one, in the usual local-folders tree node.
2162 (set_active_account_from_tny_account),
2163 (modest_ui_actions_on_folder_selection_changed):
2164 * src/widgets/modest-folder-view.c: (text_cell_data),
2165 (icon_cell_data), (filter_row),
2166 (add_account_folders_to_merged_folder),
2167 (add_account_folders_to_simple_folder_store), (),
2168 (get_cmp_rows_type_pos), (cmp_rows),
2169 (modest_folder_view_set_account_id_of_visible_server_account):
2170 Adjust to the new outbox system, using generic folder stores and folders
2171 in the GtkTreeModel.
2173 2007-05-23 Christian Kellner <ckellner@openismus.com>
2175 * src/modest-mail-operation.c:
2176 (modest_mail_operation_update_account):
2177 Use info->max_size instead of unintialized local var [small
2178 build fix]. (Added TODO to review that change since I don't
2181 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2183 * libmodest-dbus-client/libmodest-dbus-client.c:
2184 (libmodest_dbus_client_compose_mail): function added
2185 * src/dbus_api/modest-dbus-api.h:
2186 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2187 (on_compose_mail): Implementation of the SendAsMail functionality
2189 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2191 * src/modest-account-mgr.c:
2192 (modest_account_mgr_add_server_account): Set the secure-connection
2193 conf key for transport accounts as well as store accounts. I don't know
2194 why the if was there. For instance, this makes sure that we use SSL
2195 for the gmail preset from the easysetup wizard.
2197 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2199 * src/gnome/modest-main-window.c:
2200 (on_account_store_connecting_finished), (connect_signals):
2201 * src/maemo/modest-main-window.c:
2202 (on_account_store_connecting_finished), (connect_signals),
2203 (modest_main_window_new):
2204 Handle TnyAccountStore::connecting-finished instead of
2205 TnyDevice::connection-changed, because we cannot actually perform
2206 operations on accounts until TnyAccountStore has itself responded to
2207 the TnyDevice::connection-changed signal. This prevents a GError from
2209 Do not try to update at startup, because we (at least on scratchbox)
2210 already do an update at startup when the device goes online.
2211 This prevents a GError from tinymail.
2212 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2213 Added TODO about stopping simultaneous operations.
2215 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2217 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2218 * src/modest-mail-operation-queue.c:
2219 (modest_mail_operation_queue_remove):
2220 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2221 about where they happened.
2223 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2225 * src/modest-ui-actions.c:
2226 (modest_ui_actions_on_password_requested): Make sure that the remember
2227 output parameter is always TRUE.
2229 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2231 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2232 Show a OK/Cancel dialog if the error is a question, though we still do not
2233 know anything more about what we are asking the user.
2234 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2235 Fix an uninitialized variable (helper). This is a logic error, however.
2237 2007-05-21 Christian Kellner <ckellner@openismus.com>
2239 * src/modest-search.h:
2240 Correct bit shifting in the ModestSearchFlags enum.
2242 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2244 * src/modest-tny-account.c:
2245 (modest_tny_account_new_from_server_account): Do not use the lsub and
2246 check-all hard-coded IMAP options when using POP.
2248 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2250 * src/modest-tny-account.c:
2251 (modest_tny_account_new_from_server_account):
2252 Use NULL for the secure-auth method for POP when Password auth has been
2253 specified by the user, as we already do for IMAP. "auth=Login" causes
2254 an error from camel or the server.
2256 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2258 * src/maemo/modest-account-settings-dialog.c:
2259 (create_page_account_details),
2260 (modest_account_settings_dialog_set_account_name):
2261 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2262 for the leave-on-server checkbox, rathr than just the checkbox, when
2263 the protocol is not POP.
2265 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2267 * src/widgets/modest-account-view.c:
2268 * src/widgets/modest-account-view.h:
2269 Added modest_account_view_select_account() which will be useful later
2270 to asynchronously re-select the edited account.
2272 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2274 * src/maemo/modest-account-settings-dialog.c:
2275 (modest_account_settings_dialog_set_account_name):
2276 Automatically choose the port numbers based on the secure authentication
2277 methods, if they have not been chosen before.
2278 This fixes projects.maemo.org bug NB#56273 .
2280 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2282 * src/maemo/modest-main-window-ui.h:
2283 * src/modest-ui-actions.c:
2284 * src/modest-ui-actions.h:
2285 Connect the Tools/SMTP Servers menu item to
2286 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2287 SMTP servers dialog, as in the UI specification and saves changes when it
2288 is closed. This fixed projects.maemo.org bug NB#56305 .
2290 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2292 * src/maemo/modest-connection-specific-smtp-window.c:
2293 (modest_connection_specific_smtp_window_init):
2294 Use gtk_window_set_default_size() to make this window big enough, so
2295 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2297 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2299 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2300 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2301 (modest_connection_specific_smtp_edit_window_init),
2302 Do not try to connect to a combobox signal before the combobox exists.
2303 This fixes the cras in projects.maemo.org bug NB#56288 .
2304 (modest_connection_specific_smtp_edit_window_get_settings):
2305 Remove the server_account_name parameter which was being checked for NULL
2306 though it was not used.
2308 * src/maemo/modest-connection-specific-smtp-window.c:
2309 (modest_connection_specific_smtp_window_fill_with_connections),
2310 (on_button_edit), (modest_connection_specific_smtp_window_init):
2311 Correct the number of treemodel columns to prevent a warning.
2312 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2313 libconic does not work.
2315 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2317 * src/modest-tny-account.c:
2318 (modest_tny_account_new_from_server_account):
2319 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2320 SMTP when "None" was chosen by the user. However, with my SMTP server that
2321 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2324 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2326 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2327 to explain the memory management issue with the ID in the ModestPair.
2329 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2330 (add_sending_page), (modest_account_assistant_finalize):
2331 * src/gnome/modest-gnome-global-settings-dialog.c:
2332 (create_updating_page), (create_composing_page):
2333 * src/gnome/modest-msg-edit-window.c: (get_transports),
2334 (init_window), (modest_msg_edit_window_finalize),
2335 (modest_msg_edit_window_get_msg_data):
2336 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2337 * src/gnome/modest-transport-widget.c:
2338 (modest_transport_widget_finalize), (smtp_configuration):
2339 * src/maemo/modest-maemo-global-settings-dialog.c:
2340 (create_updating_page), (create_composing_page):
2341 * src/maemo/modest-msg-edit-window.c: (get_transports),
2342 (init_window), (modest_msg_edit_window_finalize),
2343 (modest_msg_edit_window_get_msg_data),
2344 (modest_msg_edit_window_free_msg_data):
2345 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2346 (modest_store_widget_finalize):
2347 * src/maemo/modest-transport-widget.c:
2348 (modest_transport_widget_finalize), (smtp_configuration):
2349 * src/modest-main.c: (send_mail):
2350 * src/widgets/modest-combo-box.h:
2351 * src/widgets/modest-global-settings-dialog-priv.h:
2352 * src/widgets/modest-global-settings-dialog.c:
2353 (modest_global_settings_dialog_finalize):
2354 * src/widgets/modest-msg-edit-window.h:
2355 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2356 as long as the combo box, to prevent use of freed memory for the ID.
2358 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2360 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2361 get_accounts(), to make this clearer. Do not check for the enabled gconf
2362 key, because we do not use this for server accounts (at least, not yet).
2363 This allows us to send email again.
2365 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2367 * src/maemo/modest-platform.c:
2368 (on_modest_conf_update_interval_changed), (modest_platform_init):
2369 Only respond to this particular key change. All these strcmp()s cannot be
2372 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2374 * src/maemo/modest-maemo-global-settings-dialog.c:
2375 (current_connection): Prevent a crash in scratchbox when
2376 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2377 * src/maemo/modest-platform.c:
2378 (on_modest_conf_update_interval_changed), (modest_platform_init):
2379 Get the update interval from gconf and reset it when the gconf key changes.
2381 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2383 * src/modest-protocol-info.c:
2384 * src/modest-protocol-info.h: Adde enum-specific get functions,
2385 instead of using a ModestProtocolType enum parameter.
2387 * src/gnome/modest-account-assistant.c:
2388 * src/gnome/modest-store-widget.c:
2389 * src/gnome/modest-store-widget.h:
2390 * src/gnome/modest-transport-widget.c:
2391 * src/gnome/modest-transport-widget.h:
2392 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2393 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2394 * src/maemo/easysetup/modest-easysetup-wizard.c:
2395 * src/maemo/modest-account-settings-dialog.c:
2396 * src/maemo/modest-account-settings-dialog.h:
2397 * src/maemo/modest-store-widget.c:
2398 * src/maemo/modest-store-widget.h:
2399 * src/maemo/modest-transport-widget.c:
2400 * src/maemo/modest-transport-widget.h:
2401 * src/modest-account-mgr-helpers.c:
2402 * src/modest-account-mgr-helpers.h:
2403 * src/modest-account-mgr.c:
2404 * src/modest-account-mgr.h:
2405 * src/modest-tny-account.c:
2406 * src/modest-tny-folder.c:
2407 * src/widgets/modest-account-view.c:
2408 * src/widgets/modest-retrieve-combo-box.c:
2409 * src/widgets/modest-retrieve-combo-box.h:
2410 * src/widgets/modest-secureauth-combo-box.c:
2411 * src/widgets/modest-serversecurity-combo-box.c:
2412 * src/widgets/modest-serversecurity-combo-box.h:
2413 * tests/check_account-mgr.c:
2414 Use the specific functions, and use the re-renamed enum values for GNOME too.
2416 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2418 * src/modest-pair.h:
2419 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2420 so we can get the second based on the first.
2422 * src/maemo/modest-account-settings-dialog.h:
2423 * src/maemo/modest-account-settings-dialog.c:
2424 Added get_supported_secure_authentication_methods(), though it is mostly
2425 commented-out for now until the necessary API is committed to tinymail.
2426 (modest_account_settings_dialog_set_account_name),
2427 (save_configuration): Request the supported authentication methods from the
2428 server, so we can choose a working method.
2430 * src/modest-tny-account-store.h:
2431 * src/modest-tny-account-store.c:
2432 (modest_tny_account_store_get_session): Rename from
2433 tny_account_store_get_session().
2435 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2437 * src/modest-protocol-info.h: Split the ModestProtocol enum
2438 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2439 There was no need to have these unrelated values in one enum.
2441 * src/: many files: Adapted to changed enum. This makes the code a bit
2442 clearer, and the compiler could catch some errors.
2444 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2446 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2447 Show the detailed internal camel error message when an error happens
2448 during the configuration, so that our testers can give us more clues.
2449 For instance, in projects.maemo.org bug NB#56910 .
2451 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2453 * src/modest-tny-account.c:
2454 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2455 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2457 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2459 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2460 * src/maemo/modest-account-settings-dialog.c:
2461 (modest_account_settings_dialog_set_account_name),
2462 (save_configuration): For the incoming secure authentication checkbox,
2463 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2464 the UI specification. PLAIN does not seem to be supported for most IMAP
2465 servers anyway, and I am not sure what it would mean.
2466 However, we probably need to discover which of the secure-authentication
2467 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2468 * src/modest-account-mgr-helpers.c:
2469 (modest_account_mgr_get_server_account_data):
2471 * src/modest-tny-account.c:
2472 (modest_tny_account_new_from_server_account):
2473 Use tny_account_set_mech() to set secure-authentication methods,
2474 with some special-casing for IMAP, based on my observations of how
2477 * src/modest-account-mgr-helpers.h:
2478 * src/modest-account-mgr.c:
2479 * src/modest-defs.h: Comment that the URI is only used for local folders.
2481 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2483 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2484 parameter const, just to be neat.
2485 * src/modest-text-utils.c: (modest_text_utils_inline):
2486 End g_strconcat() with NULL, as its documentation says. This is almost
2487 certainly the cause of my crash at startup on the device. Interestingly,
2488 valgrind doesn't tell us about these errors.
2490 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2492 * scripts/build-packages: Added more precise comments about how to use
2493 this script, though I still get this error:
2494 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2495 error building tinymail
2497 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2499 * src/maemo/modest-main-window.c: (on_account_update):
2500 Very slight cleanup, hoping to make it simpler to discover what causes
2501 a crash here sometimes.
2503 * src/modest-tny-account.c:
2504 (modest_tny_account_new_from_server_account): Set the port. Added
2505 comments about the options and a TODO comment because I need to find out
2506 how to specify the secure authentication method.
2508 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2510 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2511 changed CFlags paths form modest to libmodest
2513 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2515 * src/modest-account-mgr-helpers.c:
2516 (modest_account_mgr_get_server_account_data),
2517 (modest_account_mgr_free_server_account_data):
2518 * src/modest-account-mgr-helpers.h:
2519 * src/modest-account-mgr.c:
2520 (modest_account_mgr_add_server_account):
2521 * src/modest-defs.h:
2522 * src/modest-tny-account.c:
2523 (modest_tny_account_new_from_server_account):
2524 Determine the options for tny_camel_account_add_option() here,
2525 based on the settings, rather than storing them directly in gconf.
2527 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2529 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2530 Show a more friendly error dialog now that we expect (from the tinymail
2531 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2533 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2535 * src/maemo/modest-main-window.c: (on_account_update): Check that
2536 account_name is not NULL, to prevent a crash at startup that I am
2537 seeing on the N800. I do wonder why it is NULL.
2539 * src/maemo/easysetup/modest-easysetup-wizard.c:
2540 (create_page_user_details):
2541 * src/maemo/modest-account-settings-dialog.c:
2542 (create_page_user_details), (create_page_outgoing):
2543 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2544 (modest_connection_specific_smtp_edit_window_init):
2545 * src/modest-ui-actions.c:
2546 (modest_ui_actions_on_password_requested):
2547 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2548 might do something useful with the on-screen keyboard.
2550 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2552 * src/maemo/modest-main-window.c: (on_account_update):
2553 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2554 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2556 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2558 * src/modest-tny-account-store.c: (on_account_changed):
2559 Correct the signature of this signal handler.
2561 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2563 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2564 Show a HildonNote instead of a GtkDialog for Maemo.
2566 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2568 * src/widgets/modest-account-view.h:
2569 * src/widgets/modest-account-view.c: (on_account_changed),
2570 (on_account_removed). Added a boolean flag, set/unset by
2571 modest_account_view_block_conf_updates(),
2572 modest_account_view_unblock_conf_updates() to prevent unnecessary
2573 updates, but this is not very useful because the gconf notifications are
2574 so delays (maybe only on Maemo Bora).
2575 So auto-updating is turned off, and these functions do an explicit
2576 update when necessary.
2577 However, something else is still doing too much work when adding/removing
2578 accounts, probably in another part of the application.
2580 * src/maemo/modest-account-view-window.c:
2581 (on_delete_button_clicked), (on_edit_button_clicked),
2582 (on_new_button_clicked): Use the new functions.
2584 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-account-mgr-helpers.c:
2587 (modest_account_mgr_set_first_account_as_default):
2588 Sort the list of names alphabetically-by-title, so we choose the first one
2590 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2591 alphabetically by the title.
2593 This fixes projects.maemo.org bug NB#56418 .
2595 * src/modest-account-mgr-priv.c:
2596 (_modest_account_mgr_account_from_key):
2597 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2598 avoid a valgrind error, and possible random behaviour.
2600 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2602 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2603 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2604 tinymail documentation to say that this can be expected.
2605 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2606 pretty, and should not happen, but I would prefer to know when it does.
2608 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2610 * configure.ac: When using the older hildon version, probably on Bora,
2611 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2613 * src/widgets/modest-attachment-view.c:
2614 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2617 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2619 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2620 Implemented the prototype. Can be tested with
2621 tests/dbus_api/test_open_message:
2623 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2625 * src/modest-tny-account-store.c:
2626 (modest_tny_account_store_instance_init), (get_password):
2627 * src/modest-ui-actions.c:
2628 (modest_ui_actions_on_password_requested):
2629 Do not store the password in gconf, because this function is called
2630 for non-remembered passwords. Actually use the cached (in the hash map)
2631 password instead of releasing it.
2632 The password will now not be remembered if it is asked via the protected
2633 password dialog, as per the UI spec.
2635 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2637 * src/modest-defs.h:
2638 * src/modest-account-mgr-helpers.h:
2639 * src/modest-account-mgr-helpers.c:
2640 Added modest_server_account_get_username_has_succeeded(),
2641 modest_server_account_set_username_has_succeeded().
2642 (modest_server_account_set_username),
2643 Reset the has-succeeded flag if the username changes.
2645 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2646 * src/maemo/modest-connection-specific-smtp-window.c:
2647 (modest_connection_specific_smtp_window_save_server_accounts):
2648 Use modest_server_account_set_username() instead of using
2649 modest_conf_set_string() directly, so that the has-succeeded flag is always
2652 * src/modest-ui-actions.c:
2653 (modest_ui_actions_on_password_requested): Dim the username entry if
2654 the username has ever worked, as per the UI spec.
2656 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2658 * src/modest-tny-account-store.c: (get_password):
2659 * src/modest-ui-actions.c:
2660 (modest_ui_actions_on_password_requested):
2661 Allow the username to be changed too, though there is more work to
2662 be done on exactly how this behaves.
2664 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2666 * src/modest-account-mgr-helpers.h:
2667 * src/modest-account-mgr-helpers.c:
2668 Added modest_account_mgr_get_display_name(),
2669 modest_server_account_get_username(),
2670 modest_server_account_set_username(),
2671 modest_server_account_set_password(),
2672 modest_server_account_get_hostname() functions so we do not need to
2673 use the conf API directly.
2675 * src/maemo/modest-main-window.c: (connect_signals):
2676 Actually connect ot the ModestAccountStore::request-password signal,
2677 so that we show the dialog when the password is requested by Tinymail,
2678 for isntance if it is empty.
2680 * src/modest-marshal.list:
2681 * src/modest-tny-account-store.c:
2682 (modest_tny_account_store_class_init), (get_password),
2683 (modest_tny_account_store_alert):
2684 * src/modest-tny-account-store.h:
2685 * src/modest-ui-actions.h:
2686 * src/modest-ui-actions.c:
2687 (modest_ui_actions_on_password_requested):
2688 Change the signal parameters, so it is obvious that we are providing
2689 the non human-readable server name, and receiving both the username
2690 and password, though changing of the username is not yet implemented.
2691 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2692 for the GNOME version.
2694 This should fix the projects.maemo.org bug NB#56209, though it does not
2695 work on Bora, because the gconf_client_get() for the password fails
2696 immediately after we save it with gconf_client_set().
2698 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2701 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2702 caused an undefined symbol error:
2703 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2705 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2707 * src/modest-tny-account-store.c:
2708 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2709 using a GError instead of a string message, so we can translate it in
2712 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2714 * src/maemo/modest-address-book.c:
2715 (modest_address_book_check_names):
2716 * src/maemo/modest-msg-view-window.c:
2717 (modest_msg_view_window_clipboard_owner_change):
2718 * src/modest-init.c: (modest_init_init_ui):
2719 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2720 (update_folders_cb), (modest_mail_operation_update_account):
2721 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2722 (modest_ui_actions_on_msg_attachment_clicked),
2723 (modest_ui_actions_on_msg_recpt_activated):
2724 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2725 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2726 (modest_msg_view_search_next):
2727 * src/widgets/modest-recpt-editor.c:
2728 (modest_recpt_editor_on_button_release_event),
2729 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2730 g_message(). At this point we should only be seeing interesting errors on
2731 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2733 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2735 (modest_wizard_dialog_force_title_update):
2736 * src/maemo/easysetup/modest-wizard-dialog.h:
2737 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2738 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2739 can update the title when appropriate. Otherwise the title is wrong if the
2740 pages are added after adding the notebook to the dialog.
2741 This must be a problem in HildonWizardDialog too.
2742 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2744 * src/maemo/easysetup/modest-easysetup-wizard.c:
2745 (create_subsequent_customsetup_pages),
2746 (create_subsequent_easysetup_pages):
2747 Call modest_wizard_dialog_force_title_update() so that the title is
2748 correct even with GTK+ < 2.10.
2749 This fixes projects.maemo.org bug NB#56145 .
2751 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2753 * src/maemo/modest-platform.c:
2754 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2755 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2758 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2760 * src/widgets/modest-window.h:
2761 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2762 and modest_window_save_state(), which invokes it.
2764 * src/widgets/modest-window-mgr.h:
2765 * src/widgets/modest-window-mgr.c:
2766 Added modest_window_mgr_save_state_for_all_windows(), which calls
2767 the save_state vfunc on all registered windows, if implemented.
2769 * src/gnome/modest-msg-edit-window.c:
2770 * src/gnome/modest-msg-view-window.c:
2771 * src/maemo/modest-msg-edit-window.c:
2772 * src/maemo/modest-msg-view-window.c:
2773 * src/maemo/modest-main-window.c:
2774 Specify the existing save_settings functions as implementations of
2775 ModestWindow::save_state_func().
2777 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2778 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2779 enabling hibernation, for instance.
2781 We may need to do the same thing for restoring settings.
2784 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2786 * src/widgets/modest-window-mgr.c:
2787 * src/widgets/modest-window-mgr.h:
2788 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2789 modest_window_mgr_get_hibernation_is_prevented().
2791 * src/maemo/modest-main-window.c:
2792 (on_hildon_program_is_topmost_notify): Prevent hibernation
2793 (possible when the application goes to the background in the WM),
2794 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2796 * src/maemo/easysetup/modest-easysetup-wizard.c:
2797 (modest_easysetup_wizard_dialog_init):
2798 * src/maemo/modest-account-settings-dialog.c:
2799 (modest_account_settings_dialog_init):
2800 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2801 (modest_connection_specific_smtp_edit_window_init):
2802 * src/maemo/modest-connection-specific-smtp-window.c:
2803 (modest_connection_specific_smtp_window_init):
2804 * src/maemo/modest-signature-editor-dialog.c:
2805 (modest_signature_editor_dialog_init):
2806 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2807 prevent hibernation while any of these account settings dialogs are open.
2809 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/Makefile.am:
2812 * src/maemo/modest-osso-state-saving.c:
2813 * src/maemo/modest-osso-state-saving.h: Added
2814 modest_osso_load_state() and modest_osso_save_state() though they do
2815 nothing now. They should iterate through all the open windows and load/save
2817 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2818 save state when closing.
2820 * src/maemo/modest-main-window.c:
2821 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2822 Add a notification handler for the HildonProgram::is-topmost property,
2823 so we can allow hibernation when the application goes into the background.
2824 But we still need to detect when the accounts setup windows are open so
2825 we can stop hibernation when they are open.
2826 To do this, I also added the main window the HildonProgram. This might have
2827 other side-effects/benefits, and should maybe be done for other windows.
2829 * src/maemo/modest-osso-autosave-callbacks.h:
2830 * src/maemo/modest-osso-autosave-callbacks.c:
2831 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2832 though it does not do anything yet, and we might never need this to do
2833 anything. For instance, we already save drafts.
2835 * src/maemo/modest-platform.c: (modest_platform_init):
2836 Specify the libosso auto-save callback.
2838 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2840 * src/maemo/modest-platform.c:
2841 (modest_platform_set_update_interval):
2842 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2843 aparently stays valid between application instances, so we can use this
2844 to remove and reset it later. According to a maemo-developers email from
2847 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2849 * configure.ac: Depend on libalarm for Maemo.
2851 * src/dbus_api/modest-dbus-api.h:
2852 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2853 (on_send_receive), (modest_dbus_req_handler):
2854 Handle a SEND_RECEIVE D-Bus method.
2856 * libmodest-dbus-client/libmodest-dbus-client.c:
2857 (libmodest_dbus_client_send_and_receive):
2858 * libmodest-dbus-client/libmodest-dbus-client.h:
2859 Add C convenience functions for calling the new D-Bus method.
2861 * src/modest-platform.h:
2862 * src/gnome/modest-platform.c:
2863 * src/maemo/modest-platform.c:
2864 Added modest_platform_set_update_interval(), which uses the
2865 alarmd API on Maemo.
2866 (modest_platform_init),
2867 Call modest_platform_set_update_interval(), using a hard-coded
2868 interval for now (until the global settings dialog is implemented),
2869 though I am not sure that this makes sense yet.
2871 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2873 * src/dbus_api/modest-dbus-callbacks.c:
2874 (modest_osso_cb_hw_state_handler):
2875 * src/dbus_api/modest-dbus-callbacks.h:
2876 * src/maemo/modest-platform.c: (modest_platform_init):
2877 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2878 in case this has some effect on the ability for Maemo to ping the
2881 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2883 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2884 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2885 warning. It is probably a logic error, but I need to fix the build.
2887 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2889 * src/modest-account-mgr.h:
2890 * src/modest-account-mgr.c:
2891 (modest_account_mgr_account_names): Add a gboolean enabled_only
2892 parameter, so we can get lists of onlt the enabled accounts.
2894 (modest_account_mgr_add_account),,
2895 (modest_account_mgr_account_with_display_name_exists):
2896 * src/maemo/modest-msg-edit-window.c: (get_transports):
2897 * src/modest-account-mgr-helpers.c:
2898 (modest_account_mgr_set_first_account_as_default):
2899 * src/modest-init.c: (init_default_account_maybe):
2900 * src/modest-tny-account-store.c: (get_accounts):
2901 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2902 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2903 * tests/check_account-mgr.c: (START_TEST):
2904 Provide the extra parameter, as appropriate.
2906 * src/widgets/modest-account-view.c: (update_account_view):
2907 Do not show disabled accounts (meaning that there is no way to
2908 enable/disable accounts in the UI (the feature is not in our UI
2909 specification), so we can use this internally only to mark unfinished
2910 or temporary account data.
2912 * src/maemo/easysetup/modest-easysetup-wizard.c:
2913 (create_account): Add boolean enable parameter, so we can specify FALSE
2914 to create the temporary account.
2915 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2916 (on_before_next): When finishing, when there is a temporary account, just
2918 Also, use a timeout to delay the showing of the dialog until gconf is likely
2919 to return correct information, due to a maemo gconf bug that is fixed in
2920 osso 1.1, but not yet in Bora.
2921 However, the dialog stays on screen after it is destroyed.
2923 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2924 for invalid data when cancelling. Use a hildon note instead of a dialog
2925 to complain about invalid data. Do not show the account-saved note if the
2926 account is disabled (a temporary account that will not really be saved for use
2929 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2931 * src/modest-account-mgr-helpers.h:
2932 * src/modest-account-mgr-helpers.c:
2933 Added modest_account_mgr_unset_default_account(),
2934 Added modest_account_mgr_set_first_account_as_default().
2936 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2937 If it was the default account, unset the default account name.
2939 * src/maemo/modest-account-view-window.c:
2940 (on_delete_button_clicked): If it was the default account,
2941 set the first remaining account as the default instead.
2943 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2944 a NULL account or a NULL default account, to prevent a crash. This should
2945 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2948 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2950 * src/widgets/modest-recpt-editor.c:
2951 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2952 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2953 TODO comment for this. This fixes the build.
2955 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2956 be the best place for it. This will in future update all auto-update accounts,
2957 rather than just the current/default account, when that gconf key exists.
2958 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2959 if there are no accounts, before calling do_send_receive().
2960 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2962 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2963 * src/maemo/modest-main-window-ui.h:
2964 * src/maemo/modest-main-window.c: (on_connection_changed),
2965 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2966 directly, becaue the signal handler does more.
2968 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2970 * src/modest-account-mgr-helpers.c:
2971 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2972 for the case that the account does not exist.
2974 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2975 (equivalent to the modest account name) rather than the tinymail account name
2976 (equivalent to the modest account title - human readable) to get the account data.
2977 Check for null account data to prevent the crash, and add a TODO comment saying that
2978 this needs fixing because it is using the server account name instead of the account name.
2980 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2983 * src/maemo/modest-account-settings-dialog.c: (show_error),
2985 Use hildon_note_new_information() for informative and error messages,
2986 which seems to be expected for Maemo applications (no documentation that I know of
2987 says this). I am surprised that there is no distinction between info and error
2990 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2992 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2993 it is easy to find where this is used.
2995 * src/maemo/easysetup/modest-easysetup-wizard.c:
2996 (create_page_welcome), (create_page_account_details),
2997 (create_page_user_details), (create_page_complete_easysetup),
2998 (create_page_custom_incoming), (create_page_custom_outgoing),
2999 (create_page_complete_custom):
3000 * src/maemo/modest-account-settings-dialog.c:
3001 (create_page_account_details), (create_page_user_details),
3002 (create_page_incoming), (create_page_outgoing):
3003 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3004 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3005 (modest_connection_specific_smtp_edit_window_init):
3006 * src/maemo/modest-connection-specific-smtp-window.c:
3007 (modest_connection_specific_smtp_window_init):
3008 * src/maemo/modest-signature-editor-dialog.c:
3009 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3010 and scrolling policy as per the Email Application Layout Guide, if I have
3013 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3015 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3016 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3017 which were empty, because these vfuncs have been removed from TnyAccountStore.
3018 This fixes the build.
3020 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3022 * src/maemo/modest-main-window.c:
3023 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3024 showing/hiding it. Added TODO because it probably should not be NULL.
3025 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3026 because unnecessary g_warnings() make degugging difficult.
3028 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3030 * src/maemo/modest-msg-edit-window.c:
3031 (modest_msg_edit_window_select_color),
3032 (modest_msg_edit_window_select_background_color): 2 const corrections and
3033 moving 2 #endifs before closing brackets, to fix the build.
3035 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3037 * src/maemo/easysetup/modest-easysetup-wizard.h:
3038 * src/maemo/easysetup/modest-easysetup-wizard.c:
3039 (modest_easysetup_wizard_dialog_finalize),
3040 (on_button_edit_advanced_settings), (create_page_complete_custom),
3041 (on_response), (create_account):
3042 Implement the Advanced Settings edit button, by saving the account information,
3043 for the Advanded Settings dialog to use directly from gconf, and removing it
3044 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3045 Bug #5533 in the projects.maemo.org bugzilla.
3047 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3049 * src/maemo/modest-msg-view-window.c:
3050 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3051 when opening a message window.
3053 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3055 * src/maemo/easysetup/modest-easysetup-wizard.c:
3056 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3059 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3060 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3061 gconf settings. I probably added more checks than necessary, but that is safer.
3063 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3064 variable to fix the build, but this seems to be used when it is still NULL.
3066 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3068 * src/modest-platform.h:
3069 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3070 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3071 * src/modest-main.c: Implement this function so we can avoid using
3072 maemo-specific API from cross-platform code.
3074 * src/modest-tny-account-store.c:
3075 (get_smtp_specific_transport_account_for_open_connection):
3076 * src/modest-ui-actions.c: (check_for_connection),
3077 (modest_ui_actions_on_item_not_found):
3078 Use modest_platform_connect_and_wait() and put #idefs around other
3079 maemo-specific code, because only maemo currently has a way to
3080 identify connection names.
3082 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3084 * src/modest-tny-account-store.h:
3085 * src/modest-tny-account-store.c:
3086 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3087 the connection-specific SMTP server settings in the configuration.
3089 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3091 * src/maemo/modest-main-window.c: (on_connection_changed),
3093 * src/modest-main.c: (main), (start_ui), (send_mail):
3094 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3095 that is what is intended.
3097 * src/modest-ui-actions.c: (action_send), (action_receive),
3098 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3099 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3100 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3101 SMTP server is used when it is specified.
3103 (modest_ui_actions_on_send_receive):
3104 Check that a connection is open before proceeding.
3105 Receive and then send, instead of vice-versa, as per the specification.
3107 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3109 * src/modest-mail-operation.c:
3110 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3111 though I guess it should be something other than NULL.
3113 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3115 * src/maemo/easysetup/modest-easysetup-wizard.c:
3116 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3117 combo twice, to avoid an g_warning and to make it visible again.
3118 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3119 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3120 (already intended) dereference when detaching, because we then recreate the menu.
3121 But I am not sure why the warning was happening, and it is possible that this is a memory
3124 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3126 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3127 and uri_parse_mailto() utility functions.
3128 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3130 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3132 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3134 * src/dbus_api/modest-dbus-api.h:
3135 * src/dbus_api/modest-dbus-callbacks.c:
3136 Use an idle callback to execute the modest code in the application's own thread.
3137 Remove the helloworld example method.
3138 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3139 parsed, and the open-message method is not implemented because this is not yet implemented in
3141 * libmodest-dbus-client/libmodest-dbus-client.c:
3142 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3143 (libmodest_dbus_client_open_message):
3144 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3146 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3147 body without crashing.
3149 * tests/dbus_api/Makefile.am:
3150 * tests/dbus_api/test_mail_to.c:
3151 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3153 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3155 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3156 Added file to fix the build. Sorry.
3158 * src/dbus_api/Makefile.am:
3159 * src/dbus_api/modest-dbus-api.h:
3160 * src/dbus_api/modest-dbus-callbacks.h:
3161 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3162 (modest_dbus_req_handler):
3163 Put constants in a separate header so it can be reused by the
3164 client library, without duplication
3166 * libmodest-dbus-client/Makefile.am:
3167 * libmodest-dbus-client/libmodest-dbus-client.c:
3168 (libmodest_dbus_client_call_helloworld),
3169 (libmodfest_dbus_client_send_mail),
3170 (libmodfest_dbus_client_mailto),
3171 (libmodfest_dbus_client_open_message):
3172 * libmodest-dbus-client/libmodest-dbus-client.h:
3173 (Partly) Implement a send_mail D-Bus method.
3175 * tests/dbus_api/Makefile.am:
3176 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3177 the send_email D-Bus method.
3179 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3183 * libmodest-dbus-client/Makefile.am:
3184 * libmodest-dbus-client/libmodest-dbus-client.c:
3185 * libmodest-dbus-client/libmodest-dbus-client.h:
3186 * tests/dbus_api/Makefile.am:
3187 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3188 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3190 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3192 * src/maemo/easysetup/modest-easysetup-wizard.c:
3193 (create_page_account_details):
3194 * src/maemo/modest-account-settings-dialog.c:
3195 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3196 widgets, because this might not be the default in future versions of the Maemo GTK+.
3197 However, I can not not get capitalization to work even in a simple test case.
3199 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3201 * src/maemo/easysetup/modest-easysetup-wizard.c:
3202 (create_page_custom_incoming), (create_page_custom_outgoing):
3203 * src/maemo/modest-account-settings-dialog.c:
3204 (create_page_account_details), (create_page_incoming),
3205 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3206 instead of using gtk_check_button_with_label(), so they are aligned like the other
3207 widgets, as per the UI spec.
3209 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3211 * src/maemo/easysetup/modest-easysetup-wizard.c:
3212 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3213 * src/widgets/modest-validating-entry.c:
3214 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3215 Modest prefix instead of an EasySetup prefix.
3217 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3219 * src/widgets/modest-validating-entry.h:
3220 * src/widgets/modest-validating-entry.c: (on_insert_text),
3221 Added easysetup_validating_entry_set_max_func(), used to set a callback
3222 to call when the max number of characters is reached. GtkEntry has a max-length
3223 already but is silent about it.
3225 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3226 (create_page_account_details), (create_page_user_details),
3228 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3229 (create_page_account_details), (create_page_user_details),
3230 (create_page_outgoing):
3231 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3232 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3233 the UI spec, when the user tries to enter more than the max number of characters.
3235 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3237 * src/maemo/easysetup/modest-easysetup-wizard.c:
3238 (create_page_user_details), (create_page_custom_incoming),
3239 (create_page_custom_outgoing):
3240 * src/maemo/modest-account-settings-dialog.c:
3241 (create_page_user_details), (create_page_incoming),
3242 (create_page_outgoing):
3243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3244 (modest_connection_specific_smtp_edit_window_init):
3245 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3246 not appropriate. Bad Maemo-specific defaults!.
3248 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3250 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3251 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3252 (modest_signature_editor_dialog_set_settings):
3253 Disable the label and textview when the checkbox is disabled, and use the
3254 specified (UI spec) default signature text.
3256 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3258 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3259 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3261 * src/modest-defs.h:
3262 * src/modest-account-mgr-helpers.h:
3263 * src/modest-account-mgr-helpers.c:
3264 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3266 * src/maemo/Makefile.am:
3267 * src/maemo/modest-signature-editor-dialog.c:
3268 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3271 * src/maemo/modest-account-settings-dialog.h:
3272 * src/maemo/modest-account-settings-dialog.c:
3273 (modest_account_settings_dialog_finalize), (on_button_signature),
3274 (save_configuration): Use the new dialog when the Edit button is pressed, and
3275 save the changes if necessary, as per the UI spec.
3277 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3279 * src/maemo/Makefile.am:
3280 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3281 based on maemo-develoers email from Dirk.
3283 * src/maemo/easysetup/modest-easysetup-wizard.c:
3284 (create_page_welcome), (create_page_account_details),
3285 (create_page_user_details), (create_page_complete_easysetup),
3286 (create_page_custom_incoming), (create_page_custom_outgoing),
3287 (create_page_complete_custom),
3288 (modest_easysetup_wizard_dialog_init):
3289 * src/maemo/modest-account-settings-dialog.c:
3290 (create_page_account_details), (create_page_user_details),
3291 (create_page_incoming), (create_page_outgoing),
3292 (modest_account_settings_dialog_init):
3293 * src/maemo/modest-connection-specific-smtp-window.c:
3294 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3296 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3298 * src/maemo/easysetup/modest-easysetup-wizard.c:
3299 (create_page_account_details), (create_page_custom_outgoing),
3300 (create_page_complete_custom):
3301 * src/maemo/modest-account-settings-dialog.c:
3302 (create_page_user_details), (create_page_incoming),
3303 (create_page_outgoing):
3304 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3305 (modest_connection_specific_smtp_edit_window_init):
3306 Use the correct (UI spec) port min/max, and use horizontal separators,
3309 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3311 * src/maemo/easysetup/modest-easysetup-wizard.c:
3312 (set_default_custom_servernames):
3313 * src/maemo/modest-account-settings-dialog.c:
3314 (create_page_incoming), (on_combo_outgoing_security_changed),
3315 (on_combo_incoming_security_changed), (create_page_outgoing),
3316 (modest_account_settings_dialog_set_account_name),
3317 (save_configuration):
3318 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3319 (on_combo_security_changed),
3320 (modest_connection_specific_smtp_edit_window_init),
3321 (modest_connection_specific_smtp_edit_window_set_connection),
3322 (modest_connection_specific_smtp_edit_window_get_settings):
3323 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3326 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3329 * src/maemo/easysetup/modest-easysetup-wizard.c:
3330 (create_page_custom_outgoing), (create_page_complete_custom):
3331 * src/maemo/modest-account-settings-dialog.c:
3332 (create_page_user_details), (create_page_outgoing):
3333 * src/maemo/modest-account-view-window.c: (button_box_new):
3334 Use changed logical IDs as per the most recent UI spec:
3335 mcen_bd_emailsetup_edit -> mcen_bd_edit
3336 mcen_bd_emailsetup_delete -> mcen_bd_delete
3337 mcen_bd_emailsetup_close -> mcen_bd_close
3339 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3343 * src/dbus_api/Makefile.am:
3344 * src/dbus_api/modest-dbus-callbacks.c:
3345 * src/dbus_api/modest-dbus-callbacks.h:
3346 * src/maemo/modest-platform.c: (modest_platform_init):
3347 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3349 * tests/Makefile.am:
3350 * tests/dbus_api/Makefile.am:
3351 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3353 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3355 * src/maemo/modest-account-settings-dialog.c:
3356 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3357 Removed unnecessary includes.
3359 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3361 * src/maemo/easysetup/modest-easysetup-wizard.c:
3362 * src/maemo/modest-account-settings-dialog.c:
3363 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3364 * src/widgets/Makefile.am:
3365 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3366 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3367 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3368 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3369 * src/widgets/modest-secureauth-combo-box.c:
3370 * src/widgets/modest-secureauth-combo-box.h:
3371 * src/widgets/modest-serversecurity-combo-box.c:
3372 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3373 made the GObject names more consistent with the rest of the Modest code.
3375 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3377 * src/maemo/easysetup/Makefile.am:
3378 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3379 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3380 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3381 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3382 * src/maemo/easysetup/modest-easysetup-wizard.c:
3383 * src/maemo/easysetup/modest-validating-entry.c:
3384 * src/maemo/easysetup/modest-validating-entry.h:
3385 * src/maemo/modest-account-settings-dialog.c:
3386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3387 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3388 widgets/ because they are used outside of easysetup too. After checking in,
3389 svn will allow me to rename them too.
3391 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3393 * src/gnome/modest-msg-edit-window.c:
3394 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3395 linker error, to fix the build on the GNOME platform.
3396 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3397 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3398 ifdefed out to avoid a warning.
3400 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3402 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3403 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3404 some alternative for GTK+ 2.6.
3406 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3408 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3410 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3411 specified for EmailAccountsDialog in UI spec.
3413 * src/maemo/easysetup/modest-easysetup-wizard.c:
3414 * src/maemo/easysetup/modest-easysetup-wizard.h:
3415 * src/maemo/modest-account-settings-dialog.c:
3416 * src/maemo/modest-account-settings-dialog.h:
3417 Reuse a member window widget for the connection-specific SMTP server accounts,
3418 so we can tell it to create/save the accounts only if we actually save changes.
3420 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3421 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3422 (modest_connection_specific_smtp_edit_window_get_settings):
3423 Return a struct instance for temporarily remembering the entered data.
3425 * src/maemo/modest-connection-specific-smtp-window.h:
3426 * src/maemo/modest-connection-specific-smtp-window.c:
3427 (modest_connection_specific_smtp_window_finalize),
3428 (modest_connection_specific_smtp_window_fill_with_connections),
3430 (modest_connection_specific_smtp_window_save_server_accounts),
3431 (update_model_server_names): Do not actually save data until asked,
3432 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3434 (on_selection_changed),
3435 (modest_connection_specific_smtp_window_init): Disable the edit
3436 button when nothing is selected.
3438 * src/modest-account-mgr-helpers.c:
3439 * src/modest-account-mgr-helpers.h:
3440 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3443 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3445 * src/modest-account-mgr-helpers.h:
3446 * src/modest-account-mgr-helpers.c:
3447 (modest_account_mgr_get_unused_account_name),
3448 (modest_account_mgr_get_unused_account_display_name): Added these
3449 utility functions, to avoid code duplication.
3451 * src/maemo/easysetup/modest-easysetup-wizard.c:
3452 (create_page_account_details), (create_account):
3453 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3454 (on_combo_security_changed),
3455 (modest_connection_specific_smtp_edit_window_init),
3456 (modest_connection_specific_smtp_edit_window_save_settings):
3457 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3458 * src/maemo/modest-connection-specific-smtp-window.c:
3459 (modest_connection_specific_smtp_window_finalize),
3460 (modest_connection_specific_smtp_window_fill_with_connections),
3461 (on_button_edit), (modest_connection_specific_smtp_window_init):
3462 * src/maemo/modest-connection-specific-smtp-window.h:
3463 Implementing saving of connection-specific server accounts.
3465 But I need to refactor this so we can save the data for each
3466 possible connection-specific account and only actually create the server accounts
3467 when the easysetup finished, or the OK button is pressed on the account settings
3470 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3472 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3473 (on_combo_security_changed):
3474 (modest_connection_specific_smtp_edit_window_init):
3475 Auto-fill the port number as in the account settings.
3477 (modest_connection_specific_smtp_edit_window_set_connection):
3478 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3479 * src/maemo/modest-connection-specific-smtp-window.c:
3480 (fill_with_connections), (on_button_edit),
3481 (modest_connection_specific_smtp_window_init):
3482 Turn the edit window into a dialog to simplify the code, and
3483 set a WM hint as in a GtkDialog, because only a popup can be on top of
3484 another window in Maemo, and popups usually have no WM decoration.
3486 * src/modest-defs.h:
3487 * src/modest-account-mgr-helpers.c:
3488 (modest_account_mgr_set_connection_specific_smtp),
3489 (modest_account_mgr_remove_connection_specific_smtp),
3490 (modest_account_mgr_get_connection_specific_smtp):
3491 * src/modest-account-mgr-helpers.h: Some functions to write the
3492 connection-specific SMTP server information. Not yet used.
3495 * src/widgets/modest-folder-view.c: (text_cell_data):
3496 Fix a warning about an uninitialized variable.
3497 (on_configuration_key_changed): Put an #ifdef around the use
3498 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3500 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3502 * src/maemo/modest-account-settings-dialog.h:
3503 * src/maemo/modest-account-settings-dialog.c:
3504 Added connect_for_modified() utility function to mark the new modified boolean.
3506 (create_page_account_details), (create_page_user_details),
3507 (create_page_incoming), (create_page_outgoing), (on_response),
3508 (modest_account_settings_dialog_init),
3509 (modest_account_settings_dialog_set_account_name):
3510 Only warn about unsaved changes when there are actually unsaved changes.
3512 * src/modest-account-mgr-helpers.c:
3513 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3514 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3515 to get the data from there in future.
3517 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3519 * src/modest-defs.h:
3521 * src/modest-account-mgr-helpers.h:
3522 * src/modest-account-mgr-helpers.c:
3523 Store the security account setting in a single conf key instead of using
3524 the options list, so that the list is left for just the to-be-removed camel hack,
3525 and because gconf_client_set_list() is failing for some reason.
3527 * src/modest-account-mgr.c:
3528 (modest_account_mgr_add_server_account):
3529 * src/maemo/modest-account-settings-dialog.c:
3530 (modest_account_settings_dialog_set_account_name),
3531 (save_configuration): Use the renamed functions.
3534 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3536 * src/widgets/Makefile.am:
3537 * src/widgets/modest-limit-retrieve-combo-box.c:
3538 * src/widgets/modest-limit-retrieve-combo-box.h:
3539 * src/widgets/modest-retrieve-combo-box.c:
3540 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3541 the account settings dialog.
3543 * src/modest-defs.h:
3544 * src/modest-account-mgr-helpers.h:
3545 * src/modest-account-mgr-helpers.c:
3546 (modest_server_account_get_option_secure_auth),
3547 (modest_server_account_set_option_secure_auth):
3548 * src/modest-account-mgr.c:
3549 (modest_account_mgr_add_server_account):
3550 Use the existing AUTH_MECH conf key for the secure-auth setting,
3551 instead of putting it in the list options, because this was actually used already.
3553 * src/maemo/modest-account-settings-dialog.c:
3554 (create_page_account_details),
3555 (modest_account_settings_dialog_set_account_name),
3556 (save_configuration):
3557 * src/maemo/modest-account-settings-dialog.h:
3558 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3559 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3561 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3563 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3564 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3565 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3567 * src/modest-defs.h:
3568 * src/maemo/modest-account-settings-dialog.c:
3569 (create_page_incoming), (on_combo_outgoing_security_changed),
3570 (on_combo_incoming_security_changed), (create_page_outgoing),
3571 (modest_account_settings_dialog_set_account_name),
3572 (save_configuration): Load/Save the port number, and change it when the
3573 security combo changes, to suitable defaults.
3575 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3577 * src/modest-account-mgr.c:
3578 (modest_account_mgr_add_server_account): Set the security and secure-auth
3579 options, and add a comment saying that the other camel-specific options should be
3582 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3584 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3586 * src/modest-tny-account-store.c: (account_list_free),
3587 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3588 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3591 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3593 * src/modest-protocol-info.c:
3594 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3595 is required by our UI spec. Maybe something in our implementation will use this eventually.
3596 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3597 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3598 instead of the previous 0 placeholder.
3600 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3601 secure-auth settings.
3602 * src/modest-account-mgr-helpers.h:
3603 * src/modest-account-mgr-helpers.c:
3604 (modest_server_account_data_get_option_secure_auth),
3605 (modest_server_account_set_option_secure_auth),
3606 (modest_server_account_data_get_option_security),
3607 (modest_server_account_set_option_security): Added this API for getting and setting the security
3608 and secure-auth settings.
3610 * src/maemo/modest-account-settings-dialog.h:
3611 * src/maemo/modest-account-settings-dialog.c:
3612 (modest_account_settings_dialog_finalize), (check_data),
3613 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3614 about changing titles.
3615 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3616 (save_configuration): Save the security and secure-auth settings.
3618 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3619 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3621 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3623 * src/modest-defs.h:
3624 * src/modest-account-mgr.c:
3625 (modest_account_mgr_add_server_account):
3626 Added and used defines for the options key and value pair strings,
3627 that are used so far, though they do not seem to correspond to anything in our
3628 UI specs or ModestProtocol enum.
3630 * src/modest-account-mgr-helpers.h:
3631 * src/modest-account-mgr-helpers.c:
3632 (compare_option_strings_for_name),
3633 (modest_server_account_data_get_option_value),
3634 (modest_server_account_data_get_option_bool),
3635 (modest_account_mgr_get_server_account_option):
3636 Added helper functions for parsing the options GSList.
3638 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3640 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3641 display name is based on the supplied account name.
3642 * src/modest-account-mgr.c:
3643 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3644 with an inefficient, but good-enough, implementation.
3646 * src/maemo/easysetup/modest-easysetup-wizard.c:
3647 (create_page_account_details), (on_before_next), (create_account):
3648 Check for existing display names rather than (non-user-visible) account names, and just
3649 create and set a unique account name at the end.
3651 * src/maemo/modest-account-settings-dialog.c:
3652 (modest_account_settings_dialog_init),
3653 (modest_account_settings_dialog_set_account_name),
3654 (create_page_incoming): Show the display name, instead of the account name.
3655 (on_response): Do some (not all) extra checks, as in the UI spec.
3656 (save_configuration): Save the display name if it was changed.
3658 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3660 * po/en_GB.po: Added needed logical ID and translation.
3661 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3662 (init_view): Made the is-default column clicking work.
3664 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3667 * src/maemo/easysetup/Makefile.am:
3668 * src/maemo/easysetup/modest-easysetup-wizard.c:
3669 (modest_easysetup_wizard_dialog_init):
3670 * src/maemo/easysetup/provider-data-test.keyfile:
3671 * src/maemo/easysetup/provider-data.keyfile:
3672 Moved the provider data file to the new modest-providers-data package and used it from there.
3674 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3676 * src/modest-local-folder-info.c:
3677 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3678 N_() was already used on the static strings, but this just marks it for translation without
3679 using the translation.
3681 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3683 * src/maemo/modest-account-settings-dialog.c:
3684 (create_page_incoming),
3685 (modest_account_settings_dialog_set_account_name):
3686 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3687 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3688 I will do this if nobody else gets there first.
3690 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3692 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3693 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3694 save the security stuff.
3696 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3698 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3699 Set the email address and user fullname, which I now see must be
3702 * src/maemo/modest-account-settings-dialog.h:
3703 * src/maemo/modest-account-settings-dialog.c:
3705 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3706 leave-on-server and authentication.
3707 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3710 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3713 * src/maemo/modest-account-settings-dialog.c:
3714 * src/maemo/modest-account-settings-dialog.h:
3715 Most (but not all) of the widgets are now present as specified by the UI spec.
3716 No changes are yet saved, and some details are not properly shown yet.
3718 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3720 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3722 * src/maemo/Makefile.am:
3723 * src/maemo/modest-account-settings-dialog.c:
3724 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3725 an existing account. Doesn't do much yet.
3727 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3728 Open the accounts settings dialog when Edit is clicked.
3730 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3732 * src/maemo/easysetup/Makefile.am:
3733 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3735 * src/maemo/easysetup/modest-easysetup-wizard.c:
3736 (modest_easysetup_wizard_dialog_init):
3737 Try to get the source directory from the build system,
3738 instead of hard-coding "./" into the source code, when opening our local
3739 copies of the configuration files.
3740 But this still fails when opening the wizard from the Accounts window,
3741 maybe because the working directory seems to change at runtime.
3742 So the wizard will fail the second time unless you copy the files into their
3743 proper locations - see the stdout warnings for the paths.
3745 (create_page_account_details),(on_before_next):
3746 Check for existing non-server accounts instead of server accounts,
3747 so the default account name is useful again, and to prevent trying to
3750 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3751 Show the wizard when New is clicked.
3753 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3754 (init_view): Show the column headers, and show the columns that are
3755 specified in the UI specs. However, something in Maemo's GTK+ prevents
3756 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3757 change the default account. This is despite unsetting the special properties.
3759 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3761 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3762 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3763 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3764 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3765 to make that clearer.
3766 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3768 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3770 * src/maemo/modest-account-view-window.c:
3771 (modest_account_view_window_init),
3772 (modest_account_view_window_new):
3773 Use the same buttons as specified in the
3774 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3775 the existing widgets, which never had a chance of working.
3776 Put the ModestAccountView treeview in a scrolled window.
3777 Do not repeat the initialization in both _init() and _new().
3779 * src/widgets/modest-account-view.c: (update_account_view):
3780 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3781 this widget and window shows no accounts.
3783 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3785 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3787 * src/maemo/easysetup/modest-easysetup-wizard.c:
3788 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3789 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3790 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3793 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3794 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3795 accounts exist yet, as in the UI spec.
3797 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3799 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3801 * src/maemo/Makefile.am:
3802 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3803 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3804 New window for editing connection-specific smtp details.
3805 Not fully implemented.
3807 * src/maemo/modest-connection-specific-smtp-window.c:
3808 (modest_connection_specific_smtp_window_finalize) :
3809 unref the tree model.
3810 (on_button_edit): Show the edit window.
3812 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3814 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3817 * src/maemo/Makefile.am:
3818 * src/maemo/modest-connection-specific-smtp-window.c:
3819 * src/maemo/modest-connection-specific-smtp-window.h:
3820 New window for showing the list of connections, for connection-specific
3821 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3822 * src/maemo/easysetup/modest-easysetup-wizard.c:
3823 (create_page_custom_outgoing): Show the new window when the button is clicked.
3825 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3827 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3828 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3829 * src/maemo/modest-msg-edit-window.c:
3830 (modest_msg_edit_window_insert_image):
3831 * src/modest-conf.c: (modest_conf_key_escape):
3832 * src/modest-mail-operation.c:
3833 (modest_mail_operation_send_new_mail):
3834 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3835 (modest_ui_actions_on_new_account):
3836 * src/widgets/modest-attachment-view.c: (update_filename_request):
3837 * src/widgets/modest-mail-header-view.c:
3838 Corrected warnings that were breaking the build, by commenting out unused variables,
3839 and a function, and by including a header.
3841 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3843 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3844 so we can #ifdef around platform-specific code when necessary.
3845 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3846 to allow this to build for the GNOME platform too.
3848 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3850 * src/maemo/easysetup/modest-easysetup-wizard.c:
3851 Added util_increment_name() and used it in create_page_account_details()
3852 to make sure that the default account name is always a new name.
3854 (modest_easysetup_wizard_dialog_init),
3855 (set_default_custom_servernames): Some minor memory management fixes.
3857 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3861 * src/modest-runtime.c: (init_i18n): Restored the translation
3862 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3863 are defined in config.h, and the translations are installed.
3865 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3866 is defined for translation.
3868 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3870 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3872 * src/maemo/easysetup/modest-easysetup-wizard.c:
3873 (modest_easysetup_wizard_dialog_init):
3874 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3875 Use realistic paths (though they should use $prefix generically) to the
3876 mcc_mapping and provider-data.keyfile files which might work when they
3877 are installed by the future version of the operator-wizard package,
3878 and then fallback to paths in our source code, with an explanatory
3881 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3885 * src/maemo/Makefile.am:
3886 * src/maemo/easysetup/: Added files from the previously-exernal
3887 osso-modest-easysetup.
3888 * src/maemo/modest-main-window-ui.h:
3889 * src/modest-ui-actions.c:
3890 * src/modest-ui-actions.h:
3891 Added modest_ui_actions_on_new_account() as a signal handler for the
3892 New Account menu item. It shows the easysetup wizard.
3893 * po/en_GB.po: Added additional needed logical IDs and translations.