1 2007-07-27 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-view-window.c:
4 (on_new_button_clicked): Remember the wizard dialog instance,
5 so we can just present it again if necessary. This prevents
6 multiple windows from appearing if you click again quickly on the
7 New button before the dialog appears, fixing projects.maemo.org
10 2007-07-27 Murray Cumming <murrayc@murrayc.com>
12 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
13 Offer a connection dialog if there is no connection when
14 starting modest. This should fix projects.maemo.org bug NB#61134.
16 2007-07-27 Murray Cumming <murrayc@murrayc.com>
18 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
19 Reverted my last commit. I was able to fix the build by doing
20 apt-get install wpeditor0 (replacing other wpeditor packages) and
21 an explicit apt-get install wpeditor-dev to upgrade the -dev
24 2007-07-27 Murray Cumming <murrayc@murrayc.com>
26 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
27 Commented out the use of wp_text_buffer_replace_image()
28 because it does not exist, to break the build. Added a TODO for it.
30 2007-07-26 Murray Cumming <murrayc@murrayc.com>
32 * src/modest-tny-account-store.c: (recreate_all_accounts):
33 Recreate them even if they were NULL before. I guess something
34 else was already creating them before, or this would never
36 (modest_tny_account_store_get_server_account): Make sure that
37 the tny accounts have been created before trying to find one.
38 This allows libmodest_dbus_client_compose_mail() to work
39 when the UI is not yet visible.
40 This is probably useful in other cases too.
42 (get_password): When the password is wrong after it is entered
43 in the protected password dialog, show an info banner (in an
44 idle handler) before showing the protected password dialog
47 2007-07-26 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-ui-actions.h:
50 * src/modest-ui-actions.c: Added
51 modest_do_refresh_current_folder() containing some code from
52 modest_ui_actions_on_send_receive().
53 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
54 Call modest_do_refresh_current_folder() before refreshing the
55 requested account, as in modest_ui_actions_on_send_receive().
56 This is strange, but seems to be necessary to show new mails.
57 Now new emails are finally visible in the UI when downloaded
58 via the automatic update interval, fixing bug NB#57458.
59 This also works because bug NB#57458 has been fixed somehow.
61 2007-07-26 Murray Cumming <murrayc@murrayc.com>
63 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
64 printf more details when we get unhandled D-Bus methods, because
67 * src/modest-mail-operation.c: (update_account_thread):
68 Comment out the tny_camel_pop_store_account_reconnect(), because this
69 is apparently no longer needed, and it did not work before anyway.
70 See the comment in the code.
72 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
73 by checking the header flags. This fixes projects.maemo.org bug
76 2007-07-25 Murray Cumming <murrayc@murrayc.com>
78 * src/maemo/modest-maemo-utils.h:
79 * src/maemo/modest-maemo-utils.c: Added
80 modest_maemo_show_information_note_in_main_context_and_forget().
81 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
82 Use the new function to show simple error dialogs in the main
83 context, though question dialogs are still in the current context,
84 which is unfortunately usually not the main context. This should
87 2007-07-25 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-tny-account-store.c: (get_password):
90 Never save the entered username and password in gconf,
91 because the UI spec says we should not. This helps
92 slightly with projects.maemo.org bug NB#63671.
94 2007-07-25 Murray Cumming <murrayc@murrayc.com>
96 * src/widgets/modest-msg-edit-window.h:
97 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
98 Moved some code here to make it simpler.
99 (modest_msg_edit_window_attach_file_one): Renamed from
100 modest_msg_edit_window_attach_file_interactive().
101 (modest_msg_edit_window_offer_attach_file): Renamed from
102 modest_msg_edit_window_attach_file() and used
103 modest_msg_edit_window_attach_file_one() instead of
104 copy/pasting the code. The old code for one was not using
105 GnomeVFS. This allows use of smb:// URLs when using send-as
106 from external applications, fixing bug NB#63741.
108 (modest_msg_edit_window_insert_image),
109 (modest_msg_edit_window_add_attachment_clicked):
110 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
111 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
112 Adapted to the new function names.
114 2007-07-25 Murray Cumming <murrayc@murrayc.com>
116 (modest_platform_set_update_interval): Set the alarm recurrence
117 fields so that auto-update does not just happen the first time.
118 This should have fixed projects.maemo.org bug NB#63938.
120 When this happens you can see a printf when the D-Bus method is
122 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
124 However, I do not actually seem to get new POP messages even when
125 clicking the refresh button manually. A restart gets them.
126 This might be a problem in today's tinymail only.
128 2007-07-24 Murray Cumming <murrayc@murrayc.com>
130 * src/maemo/modest-maemo-global-settings-dialog.c:
131 (current_connection):
132 Avoid a crash (probably only in scratchbox) when strcmp()ing a
133 NULL when closing the dialog.
135 2007-07-24 Murray Cumming <murrayc@murrayc.com>
137 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
138 Remove the hacky send/receive that didn't work, and instead
139 refilter the treemodel to make the deleted email really vanish from
140 the UI (though the delete-from-menu code does has commented out
141 the code that does that). This fixes projects.maemo.org bug
144 2007-07-24 Murray Cumming <murrayc@murrayc.com>
146 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
147 Try a couple of tricks to force the treeview to update (
148 poke the folder, and do a send/receive refresh), but the deleted
149 email still appears with a strike-through instead of really being
152 2007-07-23 Murray Cumming <murrayc@murrayc.com>
154 * src/dbus_api/modest-dbus-callbacks.c:
155 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
156 because their ID is not human-readable (see the comment about
157 improvements needed to the osso-email-interface API) and
158 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
160 2007-07-23 Murray Cumming <murrayc@murrayc.com>
162 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
163 (add_folders_to_list), (on_dbus_method_get_folders),
164 (modest_dbus_req_filter):
165 * src/maemo/modest-maemo-utils.c:
166 (on_camel_account_get_supported_secure_authentication):
167 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
168 (on_header_view_focus_in):
169 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
170 * src/modest-formatter.c: (modest_formatter_create_body_part):
171 * src/modest-mail-operation.c: (recurse_folders),
172 (update_account_thread), (get_msgs_full_thread),
173 (modest_mail_operation_get_msgs_full),
174 (modest_mail_operation_xfer_msgs):
175 * src/modest-search.c: (search_mime_part_and_child_parts),
176 (modest_search_account), (modest_search_all_accounts):
177 * src/modest-tny-account.c:
178 (modest_tny_account_get_special_folder), (recurse_folders):
179 * src/modest-tny-local-folders-account.c:
180 (modest_tny_local_folders_account_query_passes):
181 * src/modest-tny-msg.c: (copy_mime_part),
182 (modest_tny_msg_find_body_part_from_mime_part):
183 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
184 (modest_tny_send_queue_try_to_send):
185 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
186 (_modest_ui_actions_open), (download_uncached_messages),
187 (reply_forward), (modest_ui_actions_on_copy),
188 (modest_ui_actions_on_details), (has_retrieved_msgs),
189 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
191 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
192 (_selected_msg_marked_as), (_msg_download_completed),
193 (_selected_msg_sent_in_progress):
194 * src/widgets/modest-attachments-view.c:
195 (modest_attachments_view_set_message):
196 * src/widgets/modest-msg-view.c: (find_cid_image):
197 * tests/check_folder-transfer.c: (find_folders):
198 * tests/check_update-account.c: (func):
199 * tests/dbus_api/test_get_folders.c: (main):
200 Checked all uses of tny_iterator_get_current(), making sure
201 that the object is unreferenced (3 or 4 places did not),
202 and adding checks for NULL.
204 2007-07-23 Murray Cumming <murrayc@murrayc.com>
206 * src/dbus_api/modest-dbus-callbacks.c:
207 (on_idle_open_default_inbox): Make sure that the application UI is
209 * src/maemo/easysetup/modest-easysetup-wizard.c:
210 (on_entry_invalid_character): Show the word whitespace instead
211 of (null) in the banner when whitespace was entered.
212 (show_error): Add a comment that this does not work in
213 Maemo Bora, though we do not know why.
215 2007-07-23 Murray Cumming <murrayc@murrayc.com>
217 * src/modest-tny-account.c:
218 (modest_tny_account_get_special_folder): Use an if instead of
219 an assert for when the parent account name is NULL, because this
220 might be causing a crash in projects.maemo.org bug 63192.
221 * src/modest-mail-operation.c:
222 (modest_mail_operation_send_new_mail_cb),
223 (modest_mail_operation_remove_folder): unref the folder that is
224 returned from modest_tny_account_get_special_folder().
226 2007-07-23 Murray Cumming <murrayc@murrayc.com>
228 * src/modest-ui-actions.c:
229 (modest_ui_actions_on_password_requested):
230 Show mail_ib_login_cancelled info banner when the user cancels
231 the protected password dialog, to fix projects.maemo.org
234 2007-07-23 Murray Cumming <murrayc@murrayc.com>
236 * src/maemo/modest-account-settings-dialog.c:
237 (create_page_outgoing): Put this page in a GtkScrolledWindow,
238 matching the UI mock-up in the UI spec, and allowing access
239 to all widgets even when the on-screen keyboard is active.
241 2007-07-23 Murray Cumming <murrayc@murrayc.com>
243 Reverted this previous commit from Johannes,
244 because the scrollbars are always visible and because
245 I think we only need it on onepage of the account
246 settings, not the account wizard.
247 (I wrote the wrong instructions in the bug.)
249 * src/maemo/easysetup/modest-easysetup-wizard.c:
250 Added scrollbars to account wizard dialog.
251 Fixed projects.maemo.org NB #62744
253 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
255 * src/maemo/easysetup/modest-easysetup-wizard.c:
256 (create_page_user_details):
257 Use auto-cap for name (projects.maemo.org NB#63716)
258 * src/widgets/modest-account-view.c: (on_account_busy_changed):
260 2007-07-22 Armin Burgmeier <armin@openismus.com>
262 * src/maemo/modest-ui-actions.c: Use current account instead of
263 default account for creating viewer windows, so that the viewer
264 window knows to which account the viewed message belongs.
266 * src/maemo/modest-msg-view-window.c: Destroy the window when the
267 corresponding account is deleted. This fixes projects.maemo.org bug
270 2007-07-18 Armin Burgmeier <armin@openismus.com>
272 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
273 the dialog close after entering an invalid port number and clicking
274 OK. This fixes projects.maemo.org bug NB#63602.
276 2007-07-18 Armin Burgmeier <armin@openismus.com>
278 * src/modest-tny-account-store.c:
279 (get_server_accounts): Set parent modest account name for each
280 connection-specific transport account so that special folders of such
281 an account can be looked up. This fixes a crash when changing account
282 settings. This might also be related to projects.maemo.org bug
285 2007-07-16 Armin Burgmeier <armin@openismus.com>
287 * src/modest-ui-actions.c: Added a button to create a folder to the
288 move-to dialog. This fixes projects.maemo.org bug NB#.
290 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
292 * src/maemo/easysetup/modest-easysetup-wizard.c:
293 Added scrollbars to account wizard dialog.
294 Fixed projects.maemo.org NB #62744
296 2007-07-16 Murray Cumming <murrayc@murrayc.com>
298 * src/widgets/modest-msg-view.h:
299 * src/widgets/modest-msg-view.c:
300 Added modest_msg_view_get_message_is_empty() but this needs
302 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
303 Check if there is any text in the message yet.
304 But this needs to be implemented properly.
305 (modest_msg_edit_window_toggle_find_toolbar):
306 * src/maemo/modest-msg-view-window.c:
307 (modest_msg_view_window_toggle_find_toolbar):
308 Show a banner warning if there is no text to search, when
309 trying to start a search. This partially fixes
310 projects.maemo.org bug NB#62350.
312 2007-07-13 Murray Cumming <murrayc@murrayc.com>
314 * src/modest-mail-operation.c: (update_account_thread):
315 Initialized num_new_headers to fix the build.
317 2007-07-13 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
320 Ignore modest accounts whose server accounts don't exist in gconf.
321 This prevents us trying to create TnyAccount instances for those
322 server accounts when the server account has been removed from gconf,
323 but the parent modest account has not yet been removed from modest.
324 I don't know why this is only noticeable now. It was probably just
325 a harmeless g_warning() anyway.
327 2007-07-13 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
330 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
332 2007-07-12 Armin Burgmeier <armin@openismus.com>
334 * src/maemo/modest-main-window.c: Make default account appear bold
335 in view, tools/send & receive and toolbar/send & receive SCM menus.
336 This fixes projects.maemo.org bug NB#59010.
338 2007-07-12 Murray Cumming <murrayc@murrayc.com>
340 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
341 Add a short-cut, by checking if the folder store is an account.
342 This ensures that the Sort menu item and toolbar is dimmed for
343 the local-folders account root item, fixing
344 projects.maemo.org bug NB#62545.
346 2007-07-12 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-tny-account-store.c: (get_password):
349 Show the password dialog (via the signal) only in the mainloop, via
350 an idle handler that we wait for. This could theoretically prevent
351 hangs, though I worry that it could introduce some too.
353 2007-07-12 Murray Cumming <murrayc@murrayc.com>
355 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
356 * src/maemo/modest-platform.c:
357 (modest_platform_connect_and_wait):
358 Take a TnyAccount* parameter and try to set it to online
359 (a TnyCamel-only API), because tinymail sets accounts to offline
360 when the user cancels a password dialog, and doesn't ask again until
361 it has been set to online.
362 However, this is commented out because it causes a hang now.
364 (modest_platform_connect_and_wait_if_network_account):
365 * src/modest-mail-operation.c:
366 (modest_mail_operation_update_account):
367 * src/modest-platform.h:
368 * src/modest-ui-actions.c: (_modest_ui_actions_open),
369 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
371 2007-07-12 Armin Burgmeier <armin@openismus.com>
373 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
375 * src/modest-mail-operation.c:
376 * src/modest-ui-actions.c: Check for already existing folder before
377 querying the server, show error message from camel if the request
378 still fails. This fixes projects.maemo.org bug NB#58701.
380 2007-07-12 Murray Cumming <murrayc@murrayc.com>
382 * src/modest-tny-account-store.h:
383 * src/modest-tny-account-store.c:
384 Added modest_tny_account_store_forget_password_in_memory(),
385 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
386 when creating a new account, so that new passwords will be used, instead of
387 us thinking that it's a second request as a result of a failed password again.
389 2007-07-12 Murray Cumming <murrayc@murrayc.com>
391 * src/dbus_api/modest-dbus-callbacks.c:
392 (on_idle_open_message): If the message is in drafts then open it
393 in an edit window instead of a view window. This fixes
394 projects.maemo.org bug NB#63005.
396 2007-07-12 Murray Cumming <murrayc@murrayc.com>
398 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
399 Avoided a harmless g_warning().
401 2007-07-12 Murray Cumming <murrayc@murrayc.com>
403 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
404 Pass the modest account name, not the TnyAccount display name to
405 modest_msg_view_window_new() so that the reply feature works,
406 fixing projects.maemo.org bug NB#62892.
408 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
409 (modest_msg_view_window_new_with_header_model):
410 * src/maemo/modest-msg-view-window.c:
411 (modest_msg_view_window_new_with_header_model),
412 (modest_msg_view_window_new):
413 * src/modest-ui-actions.c: (reply_forward):
414 * src/widgets/modest-msg-view-window.h:
415 * src/widgets/modest-window.c: (modest_window_set_active_account):
416 Rename an account parameter to modest_account_name to make this clearer.
418 2007-07-11 Murray Cumming <murrayc@murrayc.com>
420 * src/modest-ui-actions.h:
421 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
422 modest_do_message_delete().
423 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
424 Call modest_do_message_delete(), hoping that this would cause messages
425 to be really deleted from search instead of just marked with strike through.
426 Does not seem to help.
428 2007-07-11 Armin Burgmeier <armin@openismus.com>
430 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
431 priv->reselect to FALSE prior to calling
432 modest_folder_view_select_first_inbox_or_local() to prevent endless
433 recursion and thus a crash on startup.
435 2007-07-11 Armin Burgmeier <armin@openismus.com>
437 * src/maemo/modest-account-settings-dialog.h: Include
438 <gtk/gtknotebook.h> to fix the build (at least for me).
440 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
441 Use "New FolderN" as default suggested name if "New folder" already
442 exists, with N being the first free number, though never exceed "New
443 folder99" in which case we just fall back to "New Folder" even though
444 it already exists. This fixes projects.maemo.org bug NB#58663.
446 2007-07-11 Murray Cumming <murrayc@murrayc.com>
448 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
449 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
450 projects.maemo.org bug NB#62778.
452 2007-07-11 Murray Cumming <murrayc@murrayc.com>
454 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
455 Ignore the wrong (for now) secure-smtp setting in the presets -
456 just default to requiring secure authentication for SMTP, because
459 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
461 * src/widgets/modest-folder-view.c: (filter_row)
462 Do not show drafts folder (see UI specs)
464 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
466 * src/modest-ui-actions.c:
467 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
468 place and also not necessary.
470 * src/widgets/modest-folder-view.c: (filter_row)
471 Guess folder type and hide Sent & Outbox if necessary.
472 Fixed project.maemo.org NB#57328
474 2007-07-11 Murray Cumming <murrayc@murrayc.com>
476 * src/modest-ui-actions.h:
477 * src/modest-ui-actions.c:
478 (modest_ui_actions_on_delete_message):
479 Move some code into a new
480 modest_ui_actions_refresh_message_window_after_delete()
481 function so we can use it from elsewhere.
483 * src/dbus_api/modest-dbus-callbacks.c:
484 (on_idle_delete_message), (on_delete_message): Used an idle
485 handler, as we do for the other D-Bus method handlers.
486 Call modest_ui_actions_refresh_message_window_after_delete()
487 if the deleted message was open in a window. This fixed
488 projects.maemo.org bug NB#62862.
490 2007-07-11 Murray Cumming <murrayc@murrayc.com>
492 * src/modest-main.c: (main): Only show the UI at the start if
493 the showui command line option was given. For instance,
494 run-standalone src/modest showui
495 Otherwise, we wait for the top_application D-Bus method to
496 be sent by hildon-desktop when the application is selected
498 This allows us to run without a UI when osso-global-search
499 uses our D-Bus methods.
501 2007-07-11 Murray Cumming <murrayc@murrayc.com>
503 * src/dbus_api/modest-dbus-api.h: Added a define for a
504 top-application D-Bus method.
505 * src/dbus_api/modest-dbus-callbacks.c:
506 (on_top_application),
507 (modest_dbus_req_handler): Handle the top-application D-Bus
508 method, which might be an undocumented D-Bus signal sent by
509 hildon-desktop when it starts the application from the menu.
510 But I am not sure and I need to test it on the device, because
511 my scratchbox does not have the application in the menu now.
512 This method shows the main window, so that it can be invisible
513 when started, for instance, just for email searching from
516 * src/maemo/modest-main-window.c: (restore_settings),
517 (modest_main_window_new): Do not show the window immediately
518 upon creation. We show it later.
519 * src/modest-widget-memory.c: (save_settings_paned):
520 Try (unsuccessfully) to avoid saving the paned position when
521 it is not even visible.
522 (restore_settings_paned): Do not allow a silly paned position.
523 This seems necessary when not showing the window at first.
525 * tests/dbus_api/Makefile.am:
526 * tests/dbus_api/test_top_application.c: (main): Test for the
529 2007-07-10 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-ui-dimming-rules.c:
532 (modest_ui_dimming_rules_on_new_msg),
533 (modest_ui_dimming_rules_on_reply_msg),
534 (modest_ui_dimming_rules_on_delete_msg),
535 (modest_ui_dimming_rules_on_details),
536 (modest_ui_dimming_rules_on_view_window_move_to),
537 (modest_ui_dimming_rules_on_view_previous),
538 (modest_ui_dimming_rules_on_view_next),
539 (_invalid_folder_for_purge): Added checks before
540 casting the window. This looks like an actual
541 logic error in _invalid_folder_for_purge(), because it
542 tries to use a ModestMainWindow as a message window.
544 2007-07-10 Murray Cumming <murrayc@murrayc.com>
546 * src/maemo/modest-account-settings-dialog.c:
547 (show_error): Use the same implementation as in
548 modest-easysetup-wizard.c:
549 (on_entry_invalid_character): The logical ID contains a %s.
550 Guessed what it should be.
551 (on_entry_max), (check_data), (on_response): Adapt to
552 changed show_error().
553 (create_page_account_details): Really call
554 modest_validating_entry_set_func() on the correct widgets.
555 * src/maemo/easysetup/modest-easysetup-wizard.c:
556 (on_entry_invalid_character): Fix the logical ID here too.
557 (create_page_account_details),
558 (create_page_user_details):
560 modest_validating_entry_set_func() on the correct widgets.
562 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
563 Do not try to use the account if it is NULL.
565 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
567 * src/modest-ui-actions.c: (create_move_to_dialog),
568 (modest_ui_actions_on_main_window_move_to),
569 (modest_ui_actions_on_msg_view_window_move_to):
570 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
571 (filter_row), (modest_folder_view_show_non_move_folders):
572 * src/widgets/modest-folder-view.h:
574 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
575 the Sent folder yet as it does not report the correct folder type.
577 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
579 * src/maemo/modest-msg-edit-window.c: (init_window):
582 2007-07-10 Murray Cumming <murrayc@murrayc.com>
584 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
585 Take a parent widget instead of a parent window, and
586 implement this with hildon_banner_show_information() instead.
587 Non-Maemo builds can just ifdef that there.
588 This fixed projects.maemo.org bug NB#62766.
590 (on_entry_invalid_character): Use show_error() again instead
591 of using hildon directly, and use the _CS() macro to use the correct
593 (create_account), (check_for_supported_auth_methods), (on_entry_max):
594 Pass a widget instead od a window to show_error().
596 2007-07-10 Murray Cumming <murrayc@murrayc.com>
598 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
599 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
600 This allows us to show the server name in the error message, fixing
601 projects.maemo.org bug NB#62904.
602 Also, use the appropriate logical ID message for the account protocol.
604 2007-07-10 Murray Cumming <murrayc@murrayc.com>
606 * src/modest-tny-account-store.c: (on_idle_wrong_password):
607 A compilation fix, though the build wasn't broken for me.
609 2007-07-09 Murray Cumming <murrayc@murrayc.com>
611 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
612 Do not try to unref a NULL folder store, to avoid a runtime warning.
613 This seems to happen sometimes when changing accounts settings.
615 2007-07-09 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-tny-account-store.c:
618 (modest_tny_account_store_instance_init),
619 (modest_tny_account_store_finalize),
620 (on_account_settings_hide), (on_idle_wrong_password):
621 Use a GHashTable to ensure that we only show one account settings
622 dialog per modest account. This avoids us having a dialog open for
623 both the store and transport accounts, or due to repeated get_password()
624 calls that shouldn't happen anyway.
626 2007-07-09 Murray Cumming <murrayc@murrayc.com>
628 * src/maemo/modest-maemo-utils.c: (on_hide),
629 (modest_maemo_show_dialog_and_forget): Handle the response, because
630 the window is not even hidden by default.
632 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
633 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
634 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
635 which seems to prevent some modality problems.
637 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
638 Ignore user cancellation errors.
640 * src/modest-account-mgr-helpers.h:
641 * src/modest-account-mgr-helpers.c:
642 Added modest_server_account_get_password() and
643 modest_server_account_get_has_password() to avoid direct use of
646 * src/maemo/modest-account-settings-dialog.h:
647 * src/maemo/modest-account-settings-dialog.c:
648 (modest_account_settings_dialog_init): Store the notebook so we can
650 Added modest_account_settings_dialog_switch_to_user_info().
652 * src/modest-tny-account-store.c:
653 (get_password): When the password in the account settings is wrong (we think),
654 show the relevant page of the account settings dialog, in the mainloop.
655 However, we currently get many of these at once because cancel does not
657 (forget_password): Do not forget the password
658 from the account settings, because this causes side-effects when
659 tinymail seems to call it at strange time, maybe because of how we
660 are cancelling get_password().
661 (modest_tny_account_store_alert): Ignore user cancellations.
663 2007-07-09 Murray Cumming <murrayc@murrayc.com>
665 * src/maemo/modest-maemo-utils.h:
666 * src/maemo/modest-maemo-utils.c:
667 Added modest_maemo_show_information_note_and_forget() for use instead of
668 gtk_dialog_run() when the response is not needed, to avoid an extra
669 mainloop which could cause a hang.
671 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
672 Use the logical IDs for the error message, though they are not
673 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
674 because gtk_dialog_run() caused a hang here (the window did not close).
675 This fixes projects.maemo.org bug NB#62646.
677 2007-07-09 Murray Cumming <murrayc@murrayc.com>
679 * src/modest-account-mgr-helpers.h:
680 * src/modest-account-mgr-helpers.c:
681 Added modest_account_mgr_get_store_protocol().
683 * src/maemo/modest-account-view-window.c:
684 (on_delete_button_clicked): Show different warning text depending on
685 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
686 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
689 2007-07-09 Murray Cumming <murrayc@murrayc.com>
691 * src/maemo/modest-msg-edit-window.c:
692 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
693 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
695 2007-07-07 Armin Burgmeier <armin@openismus.com>
697 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
698 ckdg_ib_maximum_characters_reached from correct package.
700 * src/modest-ui-actions.c: Show an error message when a folder could
701 not be created. Tinymail does not give us specific error codes about
702 what has gone wrong, so we assume that a folder with that name
703 already exists, though there might be other reasons.
705 2007-07-06 Murray Cumming <murrayc@murrayc.com>
707 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
708 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
709 give a more exact error message that can be partly translated.
711 2007-07-05 Murray Cumming <murrayc@murrayc.com>
713 * src/maemo/modest-address-book.c:
714 (select_email_addrs_for_contact): Specify a default window size for the
715 select-email-address dialog, so that it is probably big enough for the
716 title. This should fix projects.maemo.org bug NB#62277.
718 2007-07-05 Murray Cumming <murrayc@murrayc.com>
720 * src/maemo/easysetup/modest-easysetup-wizard.c:
721 (create_page_complete_easysetup): Use
722 gtk_widget_set_size() request to ensure that the text wraps
725 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
727 * src/maemo/easysetup/modest-easysetup-wizard.c:
728 (on_entry_invalid_character), (create_page_account_details),
729 (create_page_user_details):
730 Use new API of ModestValidatingEntry. But for some reason the banner is
731 not shown. I will have to investigate that further.
733 * src/widgets/modest-validating-entry.c: (on_insert_text),
734 (modest_validating_entry_set_func):
735 * src/widgets/modest-validating-entry.h:
736 Added a new callback function to be able to react to prevented
737 characters whitespaces to e.g show a banner.
739 2007-07-05 Armin Burgmeier <armin@openismus.com>
741 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
742 notification of HildonNumberEditor instead of remembering the port
743 number. Thanks to Johannes for pointing this out.
745 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
747 * src/maemo/easysetup/modest-easysetup-wizard.c:
748 Check if there are any user changes before showing a confirmation
749 dialog (projects.maemo.org NB#60946)
751 2007-07-05 Armin Burgmeier <armin@openismus.com>
753 * src/maemo/modest-account-settings-dialog.c: Remember custom port
754 number at the beginning of the dialog and set the modified flag at the
755 end if the port number has changed. This is necessary because
756 HildonNumberEditor does not support notification when the value has
759 2007-07-05 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-ui-actions.c:
762 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
763 a connection before asking anything else. Correct the check for the destination
764 folder so that it succeeds when online.
765 This fixed projects.maemo.org bug NB#61645.
767 2007-07-05 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
770 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
771 to fix projects.maemo.org bug NB#62439.
773 2007-07-05 Murray Cumming <murrayc@murrayc.com>
775 * src/modest-tny-account.c: (on_connection_status_changed):
776 Really do not use tny_device_force_offline() here. See the previous comment.
778 2007-07-04 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-tny-account.c: (on_connection_status_changed):
781 Do not use tny_device_force_offline() when tinymail says that something
782 went wrong with the connection. It seems to report this unnecessarily.
784 2007-07-04 Murray Cumming <murrayc@murrayc.com>
786 * src/maemo/modest-connection-specific-smtp-window.c:
787 (modest_connection_specific_smtp_window_init):
788 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
789 does not seem to have any effect in osso 1.1 (though it works in
790 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
792 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
794 * src/maemo/modest-connection-specific-smtp-window.c:
795 Fix UI specification problems with projects.meamo.org NB#60479
797 2007-07-04 Murray Cumming <murrayc@murrayc.com>
799 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
800 clue when this has failed, because the error dialog is not always shown
801 (at least in earlier version).
803 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
804 GError message, because the generic error dialog is not helpful.
806 'This message is not currently available (can't let a new connection go online)'
807 when trying to open an IMAP message.
809 (_modest_ui_actions_open): Offer a connection when some messages would
810 have to be downloaded and we are offline.
812 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
814 * src/widgets/modest-folder-view.c:
815 Don't check for MERGE type anymore as we use the correct type
817 NOTE: For the last two changes you need to update your tinymail copy
818 because of API changes!
820 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
822 * src/modest-tny-local-folders-account.c:
823 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
824 (see projects.maemo.org NB#61580)
826 2007-07-04 Murray Cumming <murrayc@murrayc.com>
828 * src/modest-tny-account.c: (on_connection_status_changed):
829 Commented out the call to modest_platform_connect_and_wait() because this
830 seems to always hang, and I would like to know if this is the only thing
831 that causes a hang when showing the connection dialog.
832 It is not very useful anyway.
834 2007-07-04 Murray Cumming <murrayc@murrayc.com>
836 * src/maemo/modest-msg-view-window.c:
837 (modest_msg_view_window_select_next_message):
839 * src/modest-platform.h:
840 * src/maemo/modest-platform.c:
841 Added modest_platform_connect_and_wait(), which calls
842 tny_maemo_conic_device_connect() always in the main thread, by calling it
843 in an idle handler and waiting for the idle handler to run. It should be
844 in the main thread because it uses GTK+ UI code. It just returns TRUE
845 if the device is already online.
847 There is some nasty code to ensure that subsequent calls to
848 modest_platform_connect_and_wait() just wait for the first one to finish,
849 by checking repeatedly in another idle handler. This is necessary,
850 because other threads (or even the main thread, via another idle handler)
851 can call modest_platform_connect_and_wait() while
852 modest_platform_connect_and_wait() is running.
854 (modest_platform_connect_and_wait_if_network_account),
855 (modest_platform_connect_and_wait_if_network_folderstore):
856 Convenience functions that calls modest_platform_connect_and_wait() if
857 the account or folder might want network access.
859 * src/modest-mail-operation.c:
860 (modest_mail_operation_update_account):
861 * src/modest-ui-actions.c: (download_uncached_messages),
862 (modest_ui_actions_on_rename_folder), (delete_folder),
863 (modest_ui_actions_on_main_window_move_to),
864 (modest_ui_actions_on_msg_view_window_move_to):
865 * src/widgets/modest-folder-view.c:
866 (drag_and_drop_from_folder_view):
867 Offer a connection if we are offline.
869 * src/modest-tny-account.c: (on_connection_status_changed):
870 Document this as only handling errors during network operations in progress,
871 and replace the idle code with a simple call to
872 modest_platform_connect_and_wait(), which does this instead.
874 2007-07-03 Murray Cumming <murrayc@murrayc.com>
876 * src/modest-tny-account.c:
877 (modest_tny_account_get_special_folder): (util_on_idle),
878 Handle the GError so we can see when tny_folder_store_get_folders()
879 fails, as it currently does while something else is connecting.
881 Added util_run_in_main_thread_and_wait()
882 which uses an idlen handler and mainloop to ensure that the function
883 is called in the main thread.
884 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
885 to make sure that we call attempt the connection in the mainloop only,
886 which might solve some hangs.
888 2007-07-03 Murray Cumming <murrayc@murrayc.com>
890 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
891 be found by their display name. This is never useful.
892 * src/modest-tny-account-store.c: (on_account_removed): Find the account
893 by its ID, instead of trying to use its ID as its display name.
895 * src/modest-tny-account-store.h:
896 * src/modest-tny-account.c:
897 (modest_tny_account_get_special_folder): Add a g_warning() when
898 tny_folder_store_get_folders() returns an empty list for the maildir.
900 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
901 Add a g_warning() when this returns NULL, because that it not allowed
904 2007-07-02 Armin Burgmeier <armin@openismus.com>
906 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
907 note when trying to cancel the wizard. This fixes projects.maemo.org
910 2007-07-02 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-tny-account.h:
913 * src/modest-tny-account.c:
914 (modest_tny_account_new_from_server_account),
915 (modest_tny_account_new_from_server_account_name),
916 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
917 because this must now be set before setting the proto. This is usd in
918 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
919 warning in camel_session_get_service() caused by
920 tny_camel_transport_account_prepare().
922 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
925 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
927 * src/maemo/modest-connection-specific-smtp-edit-window.c:
929 (modest_connection_specific_smtp_edit_window_init):
931 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
934 2007-06-29 Murray Cumming <murrayc@murrayc.com>
936 * src/modest-tny-account.c:
937 (modest_tny_account_new_from_server_account):
938 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
939 now uses to request a connection when it needs one, and which it uses
940 to tell us that something is wrong with the connection, so we can force
941 the accounts offline to prevent further problems.
944 * src/modest-init.c: (init_default_settings):
945 * src/modest-mail-operation.c:
946 (modest_mail_operation_update_account):
947 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
948 This should not be necessary anymore. Do not set the conf key that
949 determined this (it was always TRUE and not set anywhere else).
951 * src/modest-ui-actions.h: Remove unused and unimplemented
952 modest_ui_actions_on_online_toggle_toggled().
954 2007-06-29 Murray Cumming <murrayc@murrayc.com
956 * src/maemo/modest-main-window.c: (connect_signals):
957 Don't connect to delete_event twice. Maybe this was harmless.
959 2007-06-29 Murray Cumming <murrayc@murrayc.com
961 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
962 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
963 Debug output to give some more clue when a folder move is not allowed.
965 2007-06-28 Murray Cumming <murrayc@murrayc.com
967 * src/modest-tny-account.c: (on_modest_file_system_info),
968 (modest_tny_account_get_mmc_account_name):
969 Always call the callback, without checking whether the name has changed.
970 * src/widgets/modest-folder-view.c: (strings_are_equal),
971 (on_model_foreach_set_name), (on_get_mmc_account_name),
972 (text_cell_data): Compare the name here, and use the name from
973 the account rather than from the
974 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
975 if the name was changed after the account was added to the model.
976 That's a tinymail bug but not one that I want to fix now.
978 This finally fixes projects.maemo.org bug NB#59301.
980 2007-06-27 Armin Burgmeier <armin@openismus.com>
982 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
985 2007-06-27 Murray Cumming <murrayc@murrayc.com
987 * src/modest-tny-account.h:
988 * src/modest-tny-account.c:
989 Added modest_tny_account_get_mmc_account_name(), to set the memory
990 card name asynchronously for the given account and then notify.
991 (modest_tny_account_new_for_local_folders): Use this new function instead
992 of using hildon_file_system_info_async_new() directly.
994 * src/widgets/modest-folder-view.c: (text_cell_data):
995 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
996 gtk_tree_model_row_changed() when it is available.
998 This should fix projects.maemo.org bug NB#59301.
1000 2007-06-27 Murray Cumming <murrayc@murrayc.com
1002 * src/modest-mail-operation.c: (update_account_thread),
1003 (get_msgs_full_thread): Fix typo failures in the revert
1006 2007-06-27 Murray Cumming <murrayc@murrayc.com
1008 * src/maemo/modest-maemo-global-settings-dialog.c:
1009 (idle_select_default_focus):
1010 * src/modest-mail-operation.c: (idle_notify_progress),
1011 (idle_notify_progress_once), (set_last_updated_idle),
1012 (update_account_thread), (get_msgs_full_thread):
1013 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1014 * src/widgets/modest-header-view.c:
1015 (idle_notify_headers_count_changed_destroy),
1016 (idle_notify_headers_count_changed):
1017 Reverted the additions of gdk_threads_enter/leave(), in case this
1018 helps with a startup hang on the device.
1020 2007-06-26 Armin Burgmeier <armin@openismus.com>
1022 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1023 for supported secure authentication methods from server by
1024 gtk_dialog_run(), saving CPU time and a potential race condition.
1026 2007-06-26 Armin Burgmeier <armin@openismus.com>
1028 * src/maemo/modest-maemo-utils.h:
1029 * src/maemo/modest-maemo-utils.c: Added a
1030 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1031 only error code to tell the calling code when the user canceled the
1034 * src/maemo/modest-account-settings-dialog.h:
1035 * src/maemo/modest-account-settings-dialog.c:
1036 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1037 message if the retrieval of secure authentication methods was canceled
1038 by the user. Perform the check before saving anything to configuration
1039 to not end up with half-committed configuration changes, do not show
1040 a "Saving to configuration failed" note when authentication methods
1041 could not be retrieved.
1043 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1046 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1048 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1049 Only return the first level of folders under accounts, because the
1050 osso-global-search UI spec doesn't want the rest.
1051 This fixed projects.maemo.org bug NB#61811.
1053 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1055 * src/modest-tny-account-store.c:
1056 * src/modest-tny-account-store.h:
1057 Added modest_tny_account_is_memory_card_account().
1058 * src/maemo/modest-main-window.c: (create_details_widget):
1059 Show the same information items for the memory card as we show for the
1060 local-folders, to fix projects.maemo.org bug NB#59307.
1062 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1064 * src/modest-tny-account-store.c: (get_password):
1065 Added some checks for NULL to maybe prevent crashes, though I think
1066 it was Philip's last commit that actually prevented the crash here
1067 when creating a first new account.
1068 But the new account is still not usable (no messages are shown)
1069 until a restart of the application.
1071 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1073 * src/maemo/modest-maemo-global-settings-dialog.c:
1074 (idle_select_default_focus):
1075 * src/modest-mail-operation.c: (idle_notify_progress),
1076 (idle_notify_progress_once), (idle_notify_update_account_queue),
1077 (set_last_updated_idle), (update_account_thread),
1078 (notify_get_msgs_full), (get_msgs_full_destroyer),
1079 (get_msgs_full_thread):
1080 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1081 * src/widgets/modest-header-view.c:
1082 (idle_notify_headers_count_changed_destroy),
1083 (idle_notify_headers_count_changed):
1084 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1085 all idle handlers, because some other thread could be blocking
1086 the GDK lock, so that it can do GUI stuff.
1088 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1090 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1091 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1092 (on_idle_send_receive), (on_idle_open_default_inbox):
1093 * src/maemo/modest-msg-edit-window.c:
1094 (modest_msg_edit_window_attach_file_noninteractive):
1095 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1096 to prevent a hang. I don't quite understand why these are necessary,
1097 beause we should already be in the main loop. I guess something outside
1098 of the main loop is taking the lock.
1100 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1101 we are really using URIs, and use files that are more likely to exist.
1103 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1105 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1106 necessary because configure.ac now defines different variables.
1108 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1110 * libmodest-dbus-client/libmodest-dbus-client.c:
1111 * libmodest-dbus-client/libmodest-dbus-client.h:
1112 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1113 libmodest_dbus_client_compose_mail() is what things actually use.
1115 * src/dbus_api/modest-dbus-api.h:
1116 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1117 * tests/dbus_api/Makefile.am:
1118 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1121 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1123 * src/modest-init.c: (modest_init_local_folders):
1124 For memory-card (or other non local-folders) maildir accounts,
1125 always create an Archive folder, so that there is somewhere to put
1126 messages. This should be less confusing, because the user does not need
1127 to guess that the need to create a folder.
1129 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1131 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1132 Fixed icon size by using (50, 50) which is the same as defined by
1135 2007-06-25 Armin Burgmeier <armin@openismus.com>
1137 * src/widgets/modest-window-mgr.c:
1138 * src/modest-init.c:
1139 * configure.ac: Correctly recognize hildon-notify presence and fixed
1140 the build without it being installed.
1142 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1144 * libmodest-dbus-client/libmodest-dbus-client.c:
1145 (libmodest_dbus_client_search): Fix the build. Sorry.
1146 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1147 (reply_forward_cb): Initialize variables to fix the build.
1149 * src/modest-tny-account-store.c:
1150 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1151 comparison (a silly typo) so that email search results can be opened
1152 when there are more than one account.
1154 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1156 * libmodest-dbus-client/libmodest-dbus-client.c:
1157 (libmodest_dbus_client_search),
1158 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1159 instead of 1 second, because the search gets folders and messages from
1160 the server, which can take a long time. When it times out,
1161 osso-global-search will report no results.
1163 We need to specify whether we should search only cached information
1164 (maybe with a user preference), and the osso-email-search-plugin
1165 API should really be improved to allow that option, and to allow results
1166 to be delivered asynchronously in batches.
1168 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1170 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1171 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1172 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1174 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1176 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1177 that is an empty string. D-Bus seems to give us these instead of NULL.
1179 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1181 * src/dbus_api/modest-dbus-callbacks.c:
1182 * src/maemo/easysetup/modest-easysetup-wizard.h:
1183 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1184 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1185 (modest_connection_specific_smtp_edit_window_init):
1186 * src/maemo/modest-maemo-global-settings-dialog.c:
1188 * src/maemo/modest-maemo-utils.c:
1189 (modest_maemo_utils_setup_images_filechooser):
1190 * src/maemo/modest-main-window.c: (create_details_widget):
1191 * src/maemo/modest-msg-edit-window.c:
1192 (modest_msg_edit_window_attach_file_noninteractive),
1193 (modest_msg_edit_window_color_button_change),
1194 (modest_msg_edit_window_set_zoom):
1195 * src/modest-mail-operation.c: (update_account_thread):
1196 * src/modest-tny-account-store.c:
1197 * src/modest-tny-account.c:
1198 * src/widgets/modest-global-settings-dialog.c:
1199 * src/widgets/modest-window.h:
1201 Fixed build on bora!
1203 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1205 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1206 * src/modest-search.c: (modest_search_folder),
1207 (modest_search_all_accounts): Actually search only in the specified folder,
1208 doing a simple match on the folder ID.
1209 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1210 and added some documentation.
1212 2007-06-22 Armin Burgmeier <armin@openismus.com>
1214 * src/maemo/modest-maemo-utils.h:
1215 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1216 modest_maemo_utils_get_supported_secure_authentication_methods.
1218 * src/maemo/easysetup/modest-easysetup-wizard.c:
1219 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1220 one occured, not just "Server does not support secure authentication".
1222 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1224 * src/modest-tny-account-store.c: (get_password):
1225 Restored the call to tny_account_set_user() because Philip seems to have
1226 stopped this from crashing (by not using the freed string). It still does
1227 not work, but now we can test it.
1229 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1231 * src/maemo/modest-msg-edit-window.c: (init_window):
1232 Comment out use of an uninitialzed GtkScrolledWindow variable,
1233 to fix the build and stop a crash. Yet again.
1235 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1237 * src/modest-tny-account-store.c: (get_password):
1238 Remove the call to tny_account_set_user() because this actually crashes.
1239 As mentioned in the last commit, it is known to not work anyway.
1241 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1243 * src/modest-tny-account-store.c: (get_password):
1244 Use tny_account_set_username() to tell tinymail that the username might
1245 have changed too. But tinymail ignores this: see projects.maemo.org
1247 * src/modest-ui-actions.c:
1248 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1249 reset the connection when changing the username, and improve the comments.
1250 Save the changed username to gconf at least, so it is used when Modest is
1253 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1255 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1256 Do not use a query, so that we get all folders, including for POP and
1257 local-folders. They work as search criteria too.
1258 This fixes projects.maemo.org bug NB#57740.
1260 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1262 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1263 Comment out the use of hildon_notification_set_sound() because it is
1264 not declared, to fix the build. Warnings are serious, people.
1266 2007-06-21 Armin Burgmeier <armin@openismus.com>
1268 * src/maemo/modest-maemo-utils.h:
1269 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1270 modest_maemo_utils_get_supported_secure_authentication_methods()
1271 to query authentication methods for a specific user. This should fix
1272 projects.maemo.org bug NB#61369.
1274 * src/maemo/easysetup/modest-easysetup-wizard.c:
1275 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1278 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1280 * libmodest-dbus-client/libmodest-dbus-client.h:
1281 * libmodest-dbus-client/libmodest-dbus-client.c:
1282 (modest_dbus_message_iter_get_search_hit),
1283 (libmodest_dbus_client_search):
1284 Reorganised and commented this.
1285 Removed modest_search_hit_free() from the public API because it
1288 Added libmodest_dbus_client_get_folders() and
1289 modest_folder_result_list_free().
1291 * src/dbus_api/modest-dbus-api.h:
1292 * src/dbus_api/modest-dbus-callbacks.c:
1293 (modest_dbus_req_filter): Commented. Moved most code to
1294 on_dbus_method_search() and added on_dbus_method_get_folders().
1296 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1297 of the extra D-Bus handler.
1299 * tests/dbus_api/Makefile.am:
1300 * tests/dbus_api/test_get_folders.c: New test for
1301 libmodest_dbus_client_get_folders(). This seems to return an empty list
1302 at the moment. That could be the same error that causes the message list
1303 to be empty sometimes.
1304 This should help with projects.maemo.org bug NB#57740.
1306 2007-06-21 Armin Burgmeier <armin@openismus.com>
1308 * src/modest-mail-operation.c: Do not call
1309 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1310 notify the operation's end after having set the status to CANCELED for
1311 the operation queue to listen on. This fixes a deadlock when there
1312 were mail operations in the queue during its finalization.
1314 * src/modest-singletons.c: Reordered uninitialization of the account
1315 manager to happen after the mail operation queue was uninitialized
1316 because the mail operation's in the queue might still try to access
1317 the account manager (see modest_mail_operation_notify_end()). This
1318 fixes a potential crash when terminating the application.
1320 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-search.c:
1323 (search_mime_part_and_child_parts): Moved some code here so we
1324 can search recursively in child folders.
1325 (modest_search_folder): Search in the message as a mime part, instead
1326 of just its child mime parts.
1327 (read_chunk), (search_mime_part_ogs):
1328 Check how many bytes were read, to prevent an endless loop.
1329 Searching in message bodies now works. This finishes the fix for
1330 projects.maemo.org bug NB#61007.
1332 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1334 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1335 Add a g_warning when the item is not a folder.
1337 * src/modest-ui-dimming-rules.c:
1338 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1339 when selected item is not a folder (for instance, an account), because
1340 the UI spec only talks about folders.
1341 I am not sure what the UI spec wants, so this might not totally fix
1342 projects.maemo.org bug NB#60794.
1344 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1346 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1347 (load_from_file): Sort the list. The unsorted list would be more noticeable
1348 in non-English locales.
1350 * src/maemo/modest-msg-edit-window.c:
1351 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1352 warning and fix the build.
1354 * src/maemo/modest-progress-bar-widget.c:
1355 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1356 avoid a g_warning, and probably to avoid a crash.
1358 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1360 * src/modest-search.c: (modest_search_folder): Check for a GError
1361 when calling tny_folder_get_headers(), to show that this is not the cause
1364 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1366 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1367 Actually set the body query instead of the subject query.
1369 * src/modest-search.c: (search_mime_part_ogs),
1370 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1371 which would probably cause it to fail if we got this far.
1373 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1374 to simplify the code.
1375 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1376 be causing search-in-body to fail.
1378 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1380 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1382 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1383 Better debug message when the folder cannot be found.
1384 This should help with fixing projects.maemo.org bug #61287.
1385 * src/modest-search.c: (add_hit): Do not leak the furl string.
1387 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1389 * src/modest-ui-actions.c:
1390 (modest_ui_actions_on_folder_selection_changed):
1391 Do not special-case TNY_MERGE_FOLDER here, because
1392 modest_tny_folder_get_account() already does that. This fixes
1393 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1394 shown when the Outbox was selected).
1396 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1398 * libmodest-dbus-client/libmodest-dbus-client.c:
1399 (_dbus_iter_get_string_or_null): Initialize the string variable in
1400 case this helps with Dirk's crash.
1402 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1404 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1405 though it is not implemented yet (this function is maybe not even used),
1406 to avoid breaking ABI in future.
1407 * libmodest-dbus-client/libmodest-dbus-client.c:
1408 (get_attachments_string): Moved some code into this generic function.
1409 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1410 sends email. It is maybe not used.
1411 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1412 (on_send_mail): Use attachments.
1414 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1415 * src/maemo/modest-msg-edit-window.c:
1416 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1417 a filename before using it, to fix projects.maemo.org bug NB#58233.
1419 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1422 Initialize the continue_download variable to fix the build, and probably
1423 to fix randome behaviour.
1425 2007-06-18 Armin Burgmeier <armin@openismus.com>
1427 * src/modest-tny-send-queue.h:
1428 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1429 the queue so we can later show it in the UI. Replaced
1430 modest_tny_send_queue_msg_is_being_sent() by
1431 modest_tny_send_queue_get_msg_status().
1433 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1435 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1436 gpointer. This probably was not harmful, but just to be sure.
1438 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1440 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1441 Fix the build, but leave the function broken on Bora, because
1442 hildon_uri_action_get_service() does not exist.
1443 osso_uri_action_get_service() does not exist either, it seems.
1445 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1447 * src/modest-tny-account.c:
1448 (modest_tny_account_new_from_server_account):
1449 Uncommented the url debug output again, because it is useful for
1450 debugging, as I said in the comment.
1452 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1454 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1456 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1457 for Mameo Bora, to fix the build.
1459 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1462 Fixed build with hildon < 0.99
1464 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1465 Check if the selected account is busy instead of checking all accounts
1467 * src/modest-account-mgr-priv.h:
1468 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1469 (modest_account_mgr_init), (compare_account_name),
1470 (modest_account_mgr_set_account_busy),
1471 (modest_account_mgr_account_is_busy):
1472 * src/modest-account-mgr.h:
1473 Added busy information to the account manager. It possible to
1474 set an account to busy or not busy now.
1476 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1477 (modest_mail_operation_update_account),
1478 (modest_mail_operation_notify_end):
1479 Set the account to busy/not busy depending on the operation state.
1481 * src/widgets/modest-account-view.c:
1482 (modest_account_view_finalize), (get_last_updated_string),
1483 (update_account_view), (on_account_busy_changed), (init_view):
1484 Show string "Refreshing..." if the account is currently busy.
1486 All this fixes projects.maemo.org bug NB#59711
1488 2007-06-14 Armin Burgmeier <armin@openismus.com>
1490 * src/widgets/modest-attachments-view.h:
1491 * src/widgets/modest-attachments-view.c: Added
1492 modest_attachments_view_has_attachments() and fixed coordinate
1493 transformation in get_att_view_at_coords(). This fixes attachment
1496 * src/widgets/modest-msg-view.c: Make use of
1497 modest_attachments_view_has_attachments() to decide whether to show
1498 attachments in the header.
1500 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1502 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1503 (on_change), (on_combo_security_changed),
1504 (modest_connection_specific_smtp_edit_window_init),
1505 (modest_connection_specific_smtp_edit_window_set_connection),
1506 (modest_connection_specific_smtp_edit_window_is_dirty):
1507 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1508 * src/maemo/modest-connection-specific-smtp-window.c:
1511 Show an comfirmation dialog for the smpt-edit-window if there are
1512 unsaved changes and the user hits cancel.
1513 (projects.maemo.org bug NB#60479)
1515 2007-06-14 Armin Burgmeier <armin@openismus.com>
1517 * src/maemo/easysetup/modest-easysetup-wizard.c:
1518 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1519 address" info in banner instead of node, and select all the text as
1520 per UI spec. This fixes projects.maemo.org bug NB#60550.
1522 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1524 reviewed by: <delete if not using a buddy>
1526 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1527 * src/modest-ui-actions.c: (folder_refreshed_cb):
1529 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1531 * src/widgets/modest-folder-view.c: (filter_row):
1532 Explictly filter out the per-account outbox accounts. I don't know why
1533 these only sometimes show up, but now they should never show up in the UI.
1534 This should fix projects.maemo.org bug NB#60160.
1536 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1538 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1539 when the toolbar does not exist yet.
1540 * src/modest-widget-memory.c: (save_settings_header_view):
1541 Added g_warnings() to help us to discover when we are trying to set
1542 an empty columns list in gconf.
1544 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1546 * src/modest-init.h:
1547 * src/modest-init.c:
1548 Added modest_init_get_default_header_view_column_ids().
1550 * src/modest-widget-memory.c: (restore_settings_header_view):
1551 Use the new function to get defaults, if the gconf key is empty,
1552 instead of not creating any columns. This seems to fix the
1553 empty right-hand pane problems.
1555 * src/widgets/modest-header-view.h: Improved documentation.
1557 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1560 Revert the use of the display name as the account name, because this
1561 is generally wrong and would break the code that follows.
1563 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1565 * src/maemo/easysetup/modest-easysetup-wizard.c:
1566 (check_for_supported_auth_methods), (on_before_next),
1569 More correct fix for projects.maemo.org bug NB# 58991
1570 Do not longer accept AUTH_PASSWORD as secure method and choose
1571 correct method when creating the account.
1573 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1575 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1576 Fixed projects.maemo.org bug NB# 58991
1578 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1580 * src/modest-init.c: (modest_init_init_core),
1581 (modest_init_local_folders): Fixed compilation errors.
1583 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1585 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1586 Remove unnecessary lib/include, though it is good in principle when needed.
1588 * src/modest-init.c: (modest_init_one_local_folder),
1589 (modest_init_local_folders):
1590 * src/modest-init.h: Initialize the .modest library for memory cards,
1591 instead of just doing nothing for them. This should allow us to create
1592 folders there, fixing projects.maemo.org bug NB#59297.
1594 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1596 * libmodest-dbus-client/libmodest-dbus-client.c:
1597 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1598 (libmodest_dbus_client_compose_mail),
1599 (libmodest_dbus_client_open_message),
1600 (libmodest_dbus_client_send_and_receive),
1601 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1603 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1604 (on_idle_open_message), (modest_dbus_req_handler),
1605 (search_result_to_message), (modest_dbus_req_filter):
1606 * src/modest-search.c: (add_hit), (modest_search_folder),
1607 (modest_search_all_accounts): Improved debug messages.
1609 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1611 * src/modest-tny-account-store.c:
1612 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1615 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1618 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1620 * src/modest-tny-account-store.c: (get_server_accounts):
1621 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1622 even when there are no accounts, so that the Outbox folder is always
1623 visible. This fixes projects.maemo.org bug NB#60158.
1625 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1627 * src/maemo/modest-main-window.c: (create_details_widget):
1628 Use the mcen_va_never logical ID.
1630 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1632 * src/dbus_api/modest-dbus-api.h:
1633 * src/dbus_api/modest-dbus-callbacks.c:
1634 (on_idle_open_default_inbox), (on_open_default_inbox),
1635 (modest_dbus_req_handler):
1636 Added a new OpenDefaultInbox method.
1638 * libmodest-dbus-client/libmodest-dbus-client.h:
1639 * libmodest-dbus-client/libmodest-dbus-client.c:
1640 Added libmodest_dbus_client_open_default_inbox() to call the new
1641 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1642 though it should maybe be used by a new osso-email-interface function.
1644 * tests/dbus_api/Makefile.am:
1645 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1648 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1650 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1651 NULL, so that the signals get all the keys. This should not actually
1652 change any behaviour because we currently update everything when anything
1655 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1657 * src/widgets/modest-folder-view.c: (text_cell_data),
1658 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1659 (find_inbox_iter): If tinymail tells us that the folder is
1660 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1661 This causes the inbox to be selected at startup, fixing part of
1662 projects.maemo.org bug NB#56305.
1664 * src/modest-ui-dimming-rules.c:
1665 (modest_ui_dimming_rules_on_tools_smtp_servers):
1666 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1667 the SMTP servers menu item.
1668 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1669 that the SMTP Servers menu item is dimmed when there are no accounts,
1670 as a future version of the UI spec will require. This fixes
1671 projects.maemo.org bug NB#56305.
1673 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1675 * src/maemo/modest-maemo-utils.c:
1676 (modest_maemo_utils_get_supported_secure_authentication_methods):
1677 Added label to dialog instead of unreadable title
1679 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1680 (modest_main_window_new):
1681 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1684 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1685 * src/modest-account-mgr.h:
1686 Added method to avoid code duplication
1688 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1689 (modest_ui_actions_on_send_receive):
1690 Use modest_account_mgr_has_accounts
1692 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1694 * src/maemo/easysetup/modest-presets.c:
1695 (modest_presets_get_info_server_security): Do not report secure auth
1697 * src/modest-protocol-info.c: Use the defines for the gconf key names
1698 for secure authentication. This was not working because we were writing
1699 Password and reading password, and the check was case sensitive.
1700 With this, gmail now works for receiving and sending when created via
1703 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1705 * src/maemo/easysetup/modest-presets.c:
1706 (modest_presets_get_info_server_security): Correct the key name for
1707 SecureSmtp, because it seems to be case-sensitive.
1708 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1709 Do not try to get the 0th notebook page if there are 0 pages, to
1710 avoid a g_warning().
1712 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1714 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1715 Prevent use of the new notification feature for now, because it currently
1716 shows one dialog for each new email, which is annoying.
1718 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1720 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1721 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1722 when no country was selected, so that we show the global ones.
1723 * src/maemo/easysetup/modest-presets.c:
1724 (modest_presets_get_providers): Return only the global providers, not
1725 all providers when mmc=0 was requested.
1727 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1729 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1730 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1731 provider ID in the combo.
1733 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1734 Do not show the page numbers, because it would be confusing when we add
1735 the 2 extra pages for the custom setup, when the user chooses the "Other"
1736 provider. This fixes projects.maemo.org bug NB#59028
1738 * src/modest-init.c: (modest_init_init_core),
1739 (modest_init_local_folders):
1740 * src/modest-init.h:
1741 * src/modest-tny-account.c:
1742 (modest_tny_account_new_for_local_folders): Do not create default folders
1743 for the memory card. This should fix projects.maemo.org bug NB#59328.
1745 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1747 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1748 Free the changed_conf_keys string items. They are already freed in the
1749 idle handler if that runs first.
1751 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-ui-actions.c:
1754 (modest_ui_actions_on_password_requested): Check that the server name
1755 is not NULL, because I just saw a password dialog with (null) as the
1758 * src/modest-tny-folder.[h|c]: Added
1759 modest_tny_folder_is_memory_card_folder().
1760 * src/modest-ui-dimming-rules.c:
1761 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1762 menu item for memory cards, as per the UI spec (section 7.4). This should
1763 fix projects.maemo.org bug NB#59297.
1765 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1767 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1768 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1769 is another problem with the code, see Murray's comment at line 772)
1771 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1773 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1774 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1775 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1776 (load_from_file), (easysetup_country_combo_box_init),
1777 (easysetup_country_combo_box_get_active_country_ids),
1778 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1779 instead of just one ID, to avoid duplicate country names in the UI.
1781 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1782 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1783 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1784 a single ID, avoiding duplicate providers.
1785 * src/maemo/easysetup/modest-easysetup-wizard.c:
1786 (on_combo_account_country): Adapt to use a list.
1788 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1790 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1791 keys changed in the last X seconds.
1793 * src/modest-account-mgr.h:
1794 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1795 (on_key_change), (modest_account_mgr_class_init),
1796 (modest_account_mgr_init), (modest_account_mgr_finalize):
1797 As the keys are changed, save them in a GSList* and signal that GSList*
1798 further every X seconds, to batch changes, to allow us to do just one
1799 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1800 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1802 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1803 changed signal signature.
1805 * src/modest-conf.c: (modest_conf_set_list),
1806 (modest_conf_on_change): Reenable notification.
1808 (modest_conf_maemo_fake_on_change): Comment out the hack that
1809 notified immediately instead of asynchronously.
1811 * src/widgets/modest-account-view.h:
1812 * src/widgets/modest-account-view.c:
1813 (update_account_view): Select the previously-selected account ID,
1814 if possible. This fixes projects.maemo.org bug NB#56933.
1816 (on_account_changed), (on_account_removed),
1817 (modest_account_view_select_account):
1819 Remove the block/unblock functions
1820 because they were not useful.
1822 * src/maemo/modest-account-view-window.c:
1823 (on_delete_button_clicked), (on_edit_button_clicked),
1824 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1826 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1828 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1829 Improve the error dialog to show Incorrect Account Settings, which seems
1830 clearer, and say that the internal error message (to be removed from the
1831 dialog later) is often misleading.
1832 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1834 * src/modest-tny-account.c:
1835 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1836 URL because this is so useful for debugging on the device.
1838 * src/widgets/modest-serversecurity-combo-box.c:
1839 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1841 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1843 * src/modest-mail-operation.c:
1844 (modest_mail_operation_send_new_mail):
1845 Added a comment about a nasty but apparently harmless message. Details
1846 added to the wiki g_warnings() page.
1848 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1850 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1851 (modest_tny_send_queue_class_init):
1852 Do not use the priv struct because it is empty, to avoid g_warnings
1853 about a non-existant priv struct.
1855 * src/modest-tny-account-store.c:
1856 (modest_tny_account_store_get_server_account),
1857 (modest_tny_account_store_get_transport_account_for_open_connection
1858 ): Do not try to get transport server accounts for local folders,
1859 because they don't have any. This avoids a g_warning().
1861 * src/maemo/modest-main-window.c:
1862 (modest_main_window_notify_send_receive_initied),
1863 (on_configuration_key_changed):
1864 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1865 * src/modest-defs.h:
1866 * src/modest-mail-operation.c:
1867 (modest_mail_operation_update_account):
1868 * src/modest-tny-account-store.h:
1869 * src/modest-tny-account.c:
1870 (modest_tny_account_get_special_folder),
1871 (modest_tny_account_new_for_local_folders),
1872 (modest_tny_account_new_for_per_account_local_outbox_folder):
1873 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1874 * src/modest-tny-local-folders-account.c:
1875 (add_account_folders_to_merged_folder):
1876 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1877 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1878 (modest_ui_actions_on_send):
1879 * src/widgets/modest-folder-view.c: (update_model):
1880 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1881 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1882 modest_tny_account_store_get_tny_account_by_account() to
1883 modest_tny_account_store_get_server_account() to make the code clearer.
1885 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1887 * src/dbus_api/modest-dbus-api.h:
1888 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1889 * src/maemo/modest-msg-edit-window.c:
1890 (modest_msg_edit_window_attach_file_noninteractive):
1891 added g_warning in case the file to be attached does not exist
1892 * tests/dbus_api/test_compose_mail.c: (main):
1893 removed obsolete comment, added generic files as test case
1895 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1897 * src/modest-tny-account-store.c: (get_server_accounts):
1898 Create the local folders account only once, not once for each outbox, and
1899 not only when there are some outboxes.
1901 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1903 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1904 code that is causing a crash at startup. Sergio says that he is fixing this.
1906 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1908 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1909 * src/maemo/modest-account-settings-dialog.c:
1910 (create_page_outgoing),
1911 (modest_account_settings_dialog_set_account_name),
1912 (save_configuration):
1913 - Fixed handling of the "Use secure authentication" toggle to comply with
1914 the ui specification. See also projects.maemo.org bug NB#58400
1916 - Restore the Secure connection setting combo correctly when loading
1919 * src/maemo/modest-maemo-utils.c:
1920 (on_camel_account_get_supported_secure_authentication),
1921 (modest_maemo_utils_get_supported_secure_authentication_methods):
1922 Fixed a crasher if operation is canceled
1924 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1925 (modest_protocol_info_auth_is_secure):
1926 * src/modest-protocol-info.h:
1928 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1929 the sense of the "Use secure authentication" toggle.
1931 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1933 * src/modest-tny-account-store.h:
1934 * src/modest-tny-account-store.c:
1935 Added modest_tny_account_store_get_local_folders_account().
1937 * src/modest-tny-folder.h:
1938 * src/modest-tny-folder.c:
1939 (modest_tny_folder_get_account):
1940 Added this replacement for tny_folder_get_account() which returns
1941 the local-folders account for TnyMergeFolders, to avoid the
1942 warning about the unimplemented get_account_func() vfunc().
1944 (modest_tny_folder_get_rules),
1945 * src/modest-ui-actions.c:
1946 (modest_ui_actions_on_folder_selection_changed):
1947 * src/modest-mail-operation.c:
1948 (modest_mail_operation_remove_folder),
1949 (modest_mail_operation_xfer_folder),
1950 (modest_mail_operation_rename_folder),
1951 (modest_mail_operation_get_msg),
1952 (modest_mail_operation_get_msgs_full),
1953 (modest_mail_operation_remove_msg),
1954 (modest_mail_operation_xfer_msgs),
1955 (modest_mail_operation_refresh_folder):
1956 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1958 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1960 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1961 (modest_server_account_set_security):
1962 * src/modest-defs.h: Add comments explaining that our
1963 UI spec means TLS when it says Normal, so these do not look like errors.
1965 * src/modest-tny-account.c:
1966 (modest_tny_account_new_from_server_account): Use the new tinymail
1967 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1968 for TLS. This should fix projects.maemo.org bug NB#58460.
1970 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1972 * src/maemo/easysetup/modest-easysetup-wizard.c:
1973 (create_account): Correct the position of the gconf sanity check warning.
1974 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1975 of using the g_idle_add() hack, because this does not seem to be necessary
1976 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1977 caused by something other than maemo's gconf.
1978 This fixes projects.maemo.org bug #59022.
1980 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1982 * src/modest-account-mgr-helpers.c:
1983 (modest_account_mgr_get_default_account): Do not check that the account
1984 exists if there is no default account (NULL), to fix a runtime warning.
1986 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1988 * src/widgets/modest-folder-view.c: (update_model):
1989 Do not unref the treemodel before we have finished with it.
1990 This prevents a valgrind warning and an occasional crash at startup.
1992 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1994 * libmodest-dbus-client/libmodest-dbus-client.h:
1995 added libmodest_dbus_client_compose_mail()
1996 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1998 added functions needed for SendAsMail() functionality
1999 * src/maemo/modest-msg-edit-window.c:
2000 (modest_msg_edit_window_attach_file_noninteractive):
2001 non interactively attaching files to message edit window
2002 * src/widgets/modest-msg-edit-window.h:
2003 * tests/dbus_api/Makefile.am:
2004 added test_compose_mail.c
2005 * tests/dbus_api/test_compose_mail.c: (main):
2007 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2009 * src/modest-account-view.c:
2010 Fixed bug projects.maemo.org bug NB#59307
2012 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2014 * src/maemo/easysetup/modest-easysetup-wizard.c:
2015 (get_serverport_incoming), (on_before_next), (create_account):
2016 * src/maemo/modest-account-settings-dialog.c:
2017 (modest_account_settings_dialog_set_account_name):
2018 * src/maemo/modest-maemo-utils.c:
2019 (on_camel_account_get_supported_secure_authentication_status),
2020 (on_camel_account_get_supported_secure_authentication),
2021 (on_secure_auth_cancel),
2022 (modest_maemo_utils_get_supported_secure_authentication_methods):
2024 Implemented security authentication for settings and easysetup.
2026 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/modest-main-window.c: (create_details_widget):
2029 Show the total size for memory card accounts too, instead of showing
2030 the name again. Fixes bug projects.maemo.org bug NB#59307.
2032 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2035 * src/modest-tny-simple-folder-store.c:
2036 * src/modest-tny-simple-folder-store.h: Removed.
2038 * src/modest-tny-local-folders-account.h
2039 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2040 for the local-folders maildir, with an extra TnyMergedFolder containing
2041 the folders of the per-account outbox store accounts.
2042 * src/modest-tny-account-store.c: (get_server_accounts):
2043 Add the outboxes to the special local folders account after creating it.
2045 * src/modest-tny-account.c:
2046 (modest_tny_account_new_for_local_folders): Create the derived
2047 account when creating the main local-folders account.
2049 * src/maemo/modest-main-window.c: (create_details_widget),
2050 (modest_main_window_set_contents_style):
2051 Adapted to the use of the derived account instead of the folder store.
2053 * src/modest-ui-actions.c:
2054 (modest_ui_actions_on_folder_selection_changed):
2055 * src/modest-ui-dimming-rules.c:
2056 (modest_ui_dimming_rules_on_new_folder):
2057 * src/widgets/modest-folder-view.c: (text_cell_data),
2058 (icon_cell_data), (filter_row), (update_model),
2059 (get_cmp_rows_type_pos):
2062 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2063 Do not get the priv struct, because no priv struct has been set,
2064 to avoid a runtime warning.
2066 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2067 #ifelse with #else, to fix a warning, to fix the build.
2070 2007-06-05 Christian Kellner <ckellner@openismus.com>
2072 * libmodest-dbus-client/libmodest-dbus-client.c:
2073 Fix small typo in doc (why do you always see them
2074 AFTER committing stuff?)
2077 2007-06-05 Christian Kellner <ckellner@openismus.com>
2079 * libmodest-dbus-client/libmodest-dbus-client.c:
2080 (libmodest_dbus_client_search):
2081 Initialize hit list with NULL. Also set folder list
2082 to "" if NULL was supplied.
2085 2007-06-03 Christian Kellner <ckellner@openismus.com>
2087 * libmodest-dbus-client/libmodest-dbus-client.c:
2088 (modest_search_hit_list_free):
2089 Make it save to call it with NULL.
2091 * src/dbus_api/modest-dbus-callbacks.c:
2092 * src/modest-search.c:
2093 Return full ModestSearchHits as the search result list not TnyHeader
2094 since can't be around withouth the correspoding TnyFolder.
2096 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2098 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2099 Added currently commented code to check for secure auth
2101 * src/maemo/modest-account-settings-dialog.c: (on_response),
2102 (save_configuration), (show_ok):
2103 Fixed projects.maemo.org bugs NB #59248 and #59251
2105 * src/maemo/modest-maemo-utils.c:
2106 (on_camel_account_get_supported_secure_authentication_status),
2107 (on_camel_account_get_supported_secure_authentication),
2108 (modest_maemo_utils_get_supported_secure_authentication_methods):
2109 * src/maemo/modest-maemo-utils.h:
2110 Moved get_supported_secure_authentication() method here to be able
2111 to use it from easysetup wizard.
2113 * src/modest-pair.c: (on_pair_compare_as_string):
2114 Should compare string with first part of pair and not
2115 strcmp pairs which will crash.
2117 * src/modest-protocol-info.c:
2118 (modest_protocol_info_protocol_is_store):
2119 * src/modest-protocol-info.h:
2120 Added modest_protocol_info_get_auth_protocol_name()
2122 2007-06-03 Armin Burgmeier <armin@openismus.com>
2124 * src/modest-mail-operation.c:
2125 (modest_mail_operation_get_msgs_full): Set priv->account also when
2126 only retrieving a single message. This avoids a crash when canceling
2129 (modest_mail_operation_notify_end): Do not explicitely remove the
2130 operation from the queue but only emit the progress_changed signal.
2131 The queue itself listens to that signal to remove the operation when
2132 it is finished. This reduces coupling and removes a potential deadlock
2133 when modest_mail_operation_notify_end() is called from the queue
2134 itself. If that is a problem performance-wise, I would suggest to
2135 implement a status-changed signal or something.
2137 * src/modest-mail-operation-queue.c: Make sure to never call a
2138 function from another file while the queue is locked. This (hopefully)
2139 fixes another deadlock when exiting the application while retrieving
2142 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2144 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2145 Fixed build if libogs is not available
2147 2007-06-03 Christian Kellner <ckellner@openismus.com>
2149 * libmodest-dbus-client/libmodest-dbus-client.h:
2150 * libmodest-dbus-client/libmodest-dbus-client.c:
2151 (libmodest_dbus_client_delete_message):
2152 Implement deletion of messages (Client side).
2154 (modest_search_hit_free),
2155 (modest_search_hit_list_free):
2156 Utility functions to free the result hits.
2158 * src/dbus_api/modest-dbus-api.h:
2159 * src/dbus_api/modest-dbus-callbacks.c:
2160 (on_delete_message),
2161 (modest_dbus_req_handler):
2162 Implement deletion of messages (Server side).
2164 * tests/dbus_api/test_search.c: (main):
2167 * tests/dbus_api/Makefile.am:
2168 * tests/dbus_api/test_delete_message:
2169 Add little test for the message deletion logic
2171 2007-06-03 Armin Burgmeier <armin@openismus.com>
2173 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2174 when the operation queue was not empty. projects.maemo.org bug
2177 2007-06-03 Armin Burgmeier <armin@openismus.com>
2179 * src/widgets/modest-account-view.c
2180 (on_account_default_toggled): Toggle default account column
2181 explicitely instead of waiting for gconf notification (which is
2182 currently ignored). This should fix projects.maemo.org bug NB#56910
2183 for now. It should probably be removed when gconf notifications are
2186 2007-06-03 Christian Kellner <ckellner@openismus.com>
2188 * libmodest-dbus-client/libmodest-dbus-client.c:
2189 Removed debugging spew.
2191 * src/dbus_api/modest-dbus-callbacks.c:
2192 Added debugging info.
2194 * src/modest-search.c:
2195 (modest_search_all_accounts):
2196 Use tny_account_store_get_accounts () on the account store
2197 to get all accounts which is the way to get all accounts.
2199 * tests/dbus_api/test_search.c: (main):
2200 Make it possible to supply the search term on the command line.
2202 2007-06-03 Christian Kellner <ckellner@openismus.com>
2204 * libmodest-dbus-client/libmodest-dbus-client.c:
2205 * libmodest-dbus-client/libmodest-dbus-client.h:
2206 Implement searching for mesages over raw dbus. (Client side)
2208 * src/dbus_api/Makefile.am:
2209 * src/dbus_api/modest-dbus-api.h:
2210 * src/dbus_api/modest-dbus-callbacks.c:
2211 * src/dbus_api/modest-dbus-callbacks.h:
2212 Search framework (Server side). Also implement on_idle_open_message().
2214 * src/maemo/modest-platform.c: (modest_platform_init):
2215 Prepare for raw dbus/osso rpc interaction.
2217 * src/modest-search.h:
2218 Changed minsize from unspecific guint to guint32.
2220 * src/modest-search.c:
2222 Added strange hack which magically made tnymail work.
2224 (modest_search_folder),
2225 (modest_search_account),
2226 (modest_search_all_accounts):
2227 Implement helper functions to search all accounts, specific account
2230 * tests/dbus_api/Makefile.am:
2231 * tests/dbus_api/test_open_message.c:
2232 Read url to open from commandline.
2234 * tests/dbus_api/test_search.c:
2235 Implement small test for dbus search stuff
2237 2007-06-02 Armin Burgmeier <armin@openismus.com>
2239 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2240 include account type and account title. This fixes projects.maemo.org
2243 * src/maemo/modest-account-view-window.c: Set a title for the window.
2245 2007-06-02 Armin Burgmeier <armin@openismus.com>
2247 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2248 incoming and outgoing server name based on email address and server
2249 types as long as the names have not been edited manually. This fixes
2250 projects.maemo.org bug NB#58671.
2252 2007-06-02 Armin Burgmeier <armin@openismus.com>
2254 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2255 server type cannot be changed in future to the incoming details page
2256 when creating an account. This fixes projects.maemo.org bug NB#59029.
2258 2007-06-02 Armin Burgmeier <armin@openismus.com>
2260 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2261 and assigned max width chars so that they wrap instead of being
2262 truncated. Fixes projects.maemo.org bug NB#56126.
2264 2007-06-02 Armin Burgmeier <armin@openismus.com>
2266 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2267 introductory note to the connection specific smtp servers dialog, as
2268 section 8.12 of the email UI specification requires. This fixes
2269 projects.maemo.org bug NB#59212.
2271 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2273 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2274 Check for running mail operations, and offer to cancel them, as per the UI
2275 spec. This fixes projects.maemo.org bug NB#59041 .
2276 However, I suspect that tinymail may still use the network connection
2277 in ways that we cannot detect or cancel. But it should at least adapt to
2278 changes fairly well.
2280 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2282 * src/modest-tny-account-store.c: (recreate_all_accounts),
2283 (get_cached_accounts), (get_server_accounts): Do more sensible
2284 ref-counting of the temporarily-cached outbox accounts list. This seems
2285 to fix a crash when entering the password when the password was wrong.
2287 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2289 * src/gnome/modest-main-window.c: (connect_signals):
2290 * src/modest-tny-account-store.c: (get_password),
2291 (modest_tny_account_store_alert): Added comments and clues and
2292 commented-out code about how we currently fail to deal with connection
2293 errors and wrong passwords, and how we should.
2295 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2297 * src/widgets/modest-retrieve-combo-box.c:
2298 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2299 This fixes projects.maemo.org bug NB#58472 .
2301 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2303 * src/maemo/easysetup/modest-easysetup-wizard.c:
2304 (create_page_complete_easysetup):
2305 (create_page_complete_custom): Correct the last commit,
2306 putting the correct sentences in the correct pages.
2308 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2310 * src/maemo/easysetup/modest-easysetup-wizard.c:
2311 (create_page_complete_custom): Show the second sentence of text
2312 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2315 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2317 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2318 Set the leave-on-server conf key by default. This fixes
2319 projects.maemo.org bug NB#59258 .
2321 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2323 * src/maemo/modest-account-view-window.c:
2324 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2325 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2328 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2330 * src/maemo/easysetup/modest-easysetup-wizard.c:
2331 (create_caption_new_with_asterisk):
2332 * src/maemo/modest-account-settings-dialog.c:
2333 (create_caption_new_with_asterisk):
2334 Uncomment the code to add the asterisk, because they are no longer in the
2335 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2336 (update_incoming_server_title): Add an asterisk here too.
2338 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2340 * src/maemo/modest-maemo-global-settings-dialog.c:
2341 (current_connection): Check that we are even connected before trying to
2342 get the current connection name, to prevent a warning.
2344 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2345 Change the comments because tny_maemo_conic_device_connect() is now meant to
2347 * src/modest-mail-operation.c:
2348 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2349 make sure we have a connection and fail if we can't connect.
2351 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2353 * src/maemo/modest-main-window.c:
2354 (on_account_store_connecting_finished): Do not try to get the
2355 connection ID if we are not really connected. I am surprised that
2356 this signal handler is called when we are not connected.
2358 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2360 * src/modest-error.h:
2361 * src/modest-ui-actions.c:
2362 (modest_ui_actions_get_msgs_full_error_handler):
2363 Renamed an enum, added comments, added an enum
2364 for retrieve-limit errors.
2366 * src/modest-mail-operation.c: (foreach_add_item),
2367 (internal_folder_observer_update), (update_account_thread),
2368 (modest_mail_operation_get_msgs_full):
2369 (modest_mail_operation_update_account),
2370 Added comments about how this works, and some code that should
2371 (but does not) check the retrieve-limit. See the TODO comment.
2373 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2375 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2376 Initialize help_id to fix the build. Warnings are good.
2378 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2380 * src/widgets/modest-hbox-cell-renderer.c:
2381 (modest_hbox_cell_renderer_append):
2382 * src/widgets/modest-vbox-cell-renderer.c:
2383 (modest_vbox_cell_renderer_append):
2384 Fix the last commit by doing an extra ref.
2386 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2388 * src/widgets/modest-hbox-cell-renderer.c:
2389 (modest_hbox_cell_renderer_append):
2390 * src/widgets/modest-vbox-cell-renderer.c:
2391 (modest_vbox_cell_renderer_append):
2392 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2393 to fix the build with Maemo Bora.
2394 However, there seems to be a remaining crash, probably due to reference
2397 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2399 * src/modest-tny-account.c:
2400 (modest_tny_account_new_for_local_folders):
2401 Use hildon_file_system_info_async_new() to get a better name for
2402 the memory card account, setting it as the account name.
2403 The timing seems to work, but this is probably
2404 not the best place to do this. See the TODO comment.
2405 * src/maemo/modest-main-window.c: (create_details_widget):
2406 * src/widgets/modest-folder-view.c: (text_cell_data):
2407 Use the tny account name instead of hardcoding a name.
2409 2007-05-30 Christian Kellner <ckellner@openismus.com>
2411 * src/modest-search.c: (modest_search):
2412 Correctly set part_search_func even if we have already parsed
2413 the query and thus a valid OgsTextSearcher object.
2415 2007-05-30 Christian Kellner <ckellner@openismus.com>
2418 Search and check for libogs.
2421 Incooparte the ogs build env.
2423 * src/modest-mime-part-search-stream.c:
2424 * src/modest-mime-part-search-stream.h:
2425 Removed since we do the real searching now in modest-search.c.
2427 * src/modest-search.c:
2428 * src/modest-search.h:
2429 Implement support for ogs. We use that if available and requested
2430 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2431 should now handle the corner case when the search term is spread
2432 across multiple reads.
2433 Also the logic in modest_search () was corrected to search all
2434 requested fields until one is found.
2436 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2438 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2440 * src/modest-init.h:
2441 * src/modest-init.c: Made modest_init_local_folders() take a
2442 path and be public so we can iniitialize maildir folders on
2445 * src/modest-local-folder-info.h:
2446 * src/modest-local-folder-info.c:
2447 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2449 * src/modest-tny-account.c:
2450 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2451 still means the standard local-folders path on the local volume.
2453 * src/modest-tny-account-store.c:
2454 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2455 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2456 all accounts when that happens.
2457 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2458 this too, so it shows up in the treeview.
2460 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2462 * src/maemo/modest-maemo-global-settings-dialog.c:
2463 (current_connection):
2464 * src/widgets/modest-global-settings-dialog.c:
2465 (current_connection_default):
2466 Use the enum values instead of 0, 1 and -1,
2467 to make the code clearer.
2469 * src/modest-account-mgr-helpers.c:
2470 (modest_account_mgr_get_connection_specific_smtp): Make this code
2473 * src/modest-runtime.h:
2474 * src/modest-runtime.c:
2475 Added modest_runtime_remove_all_send_queues().
2476 * src/maemo/modest-main-window.c:
2477 (on_account_store_connecting_finished): Recreate the send queues,
2478 using the appropriate transport accounts for this new connection.
2479 Some futher adapting might be needed if the old send queues are not
2480 automatically stopped at this point.
2482 * src/modest-tny-account-store.c: (get_server_accounts):
2483 Create the connection-specific transport accounts, so that they can
2484 be found later by their ID.
2486 * src/modest-tny-account.h:
2487 * src/modest-tny-account.c:
2488 Added modest_tny_account_new_from_server_account_name().
2489 modest_tny_account_new_from_server_account(): Do not create the
2490 send queues here, because they will be
2491 recreated anyway when the connection changes for the first time.
2493 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2495 * src/modest-local-folder-info.h:
2496 * src/modest-local-folder-info.c:
2497 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2498 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2499 tbox_folder): Take a modest account name instead of a server TnyAccount,
2500 so we can have per-modest-account rather than per-transport-account
2502 We must make sure that we change or recreate the exisitng send queues
2503 when the connection changes for connection-specific transport accounts.
2505 * src/modest-tny-account-store.c:
2506 (create_per_account_local_outbox_folders): Create outboxed per modest
2507 account, not per transport account.
2509 * src/modest-tny-account.h:
2510 * src/modest-tny-account.c:
2511 (modest_tny_account_get_special_folder): For outboxes, get the
2512 parent modest account name. The account is ignored for other folders.
2513 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2514 modest account name rather than a server TnyAccount.
2516 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2518 * src/modest-tny-account.c:
2519 (modest_tny_account_new_from_server_account):
2520 Call modest_runtime_get_send_queue() immediately after creating transport
2521 accounts, so that they start trying to send email from the outbox as soon
2522 as possible at startup. This is probably what we want.
2524 * src/modest-mail-operation.c: (update_account_thread):
2525 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2526 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2527 * src/modest-tny-send-queue.h:
2528 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2529 (modest_ui_actions_on_send):
2530 Added comments about how sending works, though it needs some more work.
2532 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2534 * src/modest-tny-account.c:
2535 (modest_tny_account_get_special_folder): Add TODO because this fails when
2536 the network is busy.
2537 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2538 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2539 Do not try to show this window when there is no active account. The UI
2540 specs does not tell us what to do in this case.
2542 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2546 * src/maemo/Makefile.am:
2547 * src/widgets/Makefile.am: Some dist fixes.
2549 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2551 * src/maemo/modest-connection-specific-smtp-window.c:
2552 (on_button_edit): Make the code clearer, to prevent a double free.
2554 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2556 * src/maemo/modest-account-settings-dialog.c:
2557 (modest_account_settings_dialog_set_account_name),
2558 Check the connection-specific smtp servers checkbox if there are any.
2560 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2561 (modest_connection_specific_smtp_edit_window_init):
2562 Start with a suitable port number.
2564 * src/modest-account-mgr-helpers.h:
2565 * src/modest-account-mgr-helpers.c: Added
2566 modest_account_mgr_get_has_connection_specific_smtp().
2568 (modest_account_mgr_set_connection_specific_smtp),
2569 (modest_account_mgr_remove_connection_specific_smtp),
2570 (modest_account_mgr_get_has_connection_specific_smtp),
2571 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2572 connection-specific smtp server accounts in the account, rather than
2573 the server account conf dir.
2575 This fixes bug projects.maemo.org bug NB#58263 .
2577 * src/modest-tny-account-store.c:
2578 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2579 if there are no server accounts yet, to prevent an infinite loop when there
2580 are no accounts. Document that one must be called before the other.
2582 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2584 * src/modest-account-mgr-helpers.c:
2585 (modest_account_mgr_get_default_account): Make sure that at least
2586 one account is always the default, if there are any enabled accounts.
2587 This is just a sanity check that shouldn't be necessary.
2589 * src/modest-account-mgr-priv.c:
2590 (_modest_account_mgr_account_from_key): Unescape the conf key to
2591 get the real account name. For instance, this is an issue if a space
2592 was in the account name, which can happen because the account name
2593 is generated from the display name.
2594 (_modest_account_mgr_get_account_keyname): Always escape the
2596 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2597 Unescape the conf keys to get the real account names.
2599 For instance, previously the is-default radio button in the accounts
2600 list was not checked for any accounts at first. This fixes that,
2601 and might fix several similar bugs.
2603 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2605 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2606 Removed some debug printfs.
2608 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2610 Modest on-disk outbox directories are now here, for instance:
2611 $HOME/.modest/outboxes/<account-id-1>/outbox
2612 $HOME/.modest/outboxes/<account-id-2>/outbox
2614 $HOME/.modest/local-folders/outbox
2615 so we can have a separate outbox for each account.
2616 But they are shown as one outbox in the GtkTreeView, by using a
2617 TnyMergeFolder in a ModestTnySimpleFolderStore.
2620 * src/modest-tny-simple-folder-store.c:
2621 * src/modest-tny-simple-folder-store.h:
2622 Added ModestTnySimpleFolderStore, used to contain folders from
2623 other folder stores, such as other accounts.
2625 * src/modest-tny-outbox-account.h:
2626 * src/modest-tny-outbox-account.c:
2627 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2628 used for the per-account local outbox folders.
2630 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2631 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2632 only use this (internally) now for the non-outbox local folders.
2634 * src/modest-init.h:
2635 * src/modest-init.c: Added modest_init_one_local_folder(), for
2636 setting up the directory structure for each local folder.
2638 * src/modest-local-folder-info.c:
2639 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2640 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2642 * src/modest-local-folder-info.h:
2643 * src/modest-tny-account-store.c: (on_account_removed),
2644 (on_account_changed), (create_per_account_local_outbox_folders),
2645 (get_server_accounts), (modest_tny_account_store_get_accounts),
2646 (modest_tny_account_store_get_tny_account_by_account),
2647 (modest_tny_folder_store_is_virtual_local_folders):
2649 * src/modest-tny-account.h:
2650 * src/modest-tny-account.c:
2651 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2652 to create an on-disk per-account local outbox folder for each
2654 (create_per_account_local_outbox_folders): Create a local outbox folder
2655 for each transport account.
2656 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2657 for all local folders.
2659 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2660 instead of using g_object_get/set() directly. It is clearer.
2662 (modest_tny_folder_store_get_message_count),
2663 (modest_tny_folder_store_get_local_size
2664 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2665 because we now use these with non-acount folder stores.
2667 (modest_tny_account_get_special_folder),
2668 (modest_tny_account_new_from_server_account),
2669 (modest_tny_account_new_from_account):
2670 (recurse_folders): Adjust to the new outbox system.
2672 * src/modest-tny-folder.h:
2673 * src/modest-tny-folder.c:
2674 (modest_tny_folder_is_local_folder),
2675 (modest_tny_folder_get_local_folder_type),
2676 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2678 * src/widgets/modest-main-window.h:
2679 * src/maemo/modest-main-window.c: (create_details_widget),
2680 (modest_main_window_set_contents_style): Show details for any folder store,
2683 (modest_tny_folder_get_rules):
2684 Remove the const. C does not support constness enough for this.
2686 * src/modest-ui-actions.c:
2687 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2688 make all outboxes appear as one, in the usual local-folders tree node.
2690 (set_active_account_from_tny_account),
2691 (modest_ui_actions_on_folder_selection_changed):
2692 * src/widgets/modest-folder-view.c: (text_cell_data),
2693 (icon_cell_data), (filter_row),
2694 (add_account_folders_to_merged_folder),
2695 (add_account_folders_to_simple_folder_store), (),
2696 (get_cmp_rows_type_pos), (cmp_rows),
2697 (modest_folder_view_set_account_id_of_visible_server_account):
2698 Adjust to the new outbox system, using generic folder stores and folders
2699 in the GtkTreeModel.
2701 2007-05-23 Christian Kellner <ckellner@openismus.com>
2703 * src/modest-mail-operation.c:
2704 (modest_mail_operation_update_account):
2705 Use info->max_size instead of unintialized local var [small
2706 build fix]. (Added TODO to review that change since I don't
2709 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2711 * libmodest-dbus-client/libmodest-dbus-client.c:
2712 (libmodest_dbus_client_compose_mail): function added
2713 * src/dbus_api/modest-dbus-api.h:
2714 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2715 (on_compose_mail): Implementation of the SendAsMail functionality
2717 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2719 * src/modest-account-mgr.c:
2720 (modest_account_mgr_add_server_account): Set the secure-connection
2721 conf key for transport accounts as well as store accounts. I don't know
2722 why the if was there. For instance, this makes sure that we use SSL
2723 for the gmail preset from the easysetup wizard.
2725 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2727 * src/gnome/modest-main-window.c:
2728 (on_account_store_connecting_finished), (connect_signals):
2729 * src/maemo/modest-main-window.c:
2730 (on_account_store_connecting_finished), (connect_signals),
2731 (modest_main_window_new):
2732 Handle TnyAccountStore::connecting-finished instead of
2733 TnyDevice::connection-changed, because we cannot actually perform
2734 operations on accounts until TnyAccountStore has itself responded to
2735 the TnyDevice::connection-changed signal. This prevents a GError from
2737 Do not try to update at startup, because we (at least on scratchbox)
2738 already do an update at startup when the device goes online.
2739 This prevents a GError from tinymail.
2740 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2741 Added TODO about stopping simultaneous operations.
2743 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2745 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2746 * src/modest-mail-operation-queue.c:
2747 (modest_mail_operation_queue_remove):
2748 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2749 about where they happened.
2751 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2753 * src/modest-ui-actions.c:
2754 (modest_ui_actions_on_password_requested): Make sure that the remember
2755 output parameter is always TRUE.
2757 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2759 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2760 Show a OK/Cancel dialog if the error is a question, though we still do not
2761 know anything more about what we are asking the user.
2762 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2763 Fix an uninitialized variable (helper). This is a logic error, however.
2765 2007-05-21 Christian Kellner <ckellner@openismus.com>
2767 * src/modest-search.h:
2768 Correct bit shifting in the ModestSearchFlags enum.
2770 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2772 * src/modest-tny-account.c:
2773 (modest_tny_account_new_from_server_account): Do not use the lsub and
2774 check-all hard-coded IMAP options when using POP.
2776 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2778 * src/modest-tny-account.c:
2779 (modest_tny_account_new_from_server_account):
2780 Use NULL for the secure-auth method for POP when Password auth has been
2781 specified by the user, as we already do for IMAP. "auth=Login" causes
2782 an error from camel or the server.
2784 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2786 * src/maemo/modest-account-settings-dialog.c:
2787 (create_page_account_details),
2788 (modest_account_settings_dialog_set_account_name):
2789 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2790 for the leave-on-server checkbox, rathr than just the checkbox, when
2791 the protocol is not POP.
2793 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2795 * src/widgets/modest-account-view.c:
2796 * src/widgets/modest-account-view.h:
2797 Added modest_account_view_select_account() which will be useful later
2798 to asynchronously re-select the edited account.
2800 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/modest-account-settings-dialog.c:
2803 (modest_account_settings_dialog_set_account_name):
2804 Automatically choose the port numbers based on the secure authentication
2805 methods, if they have not been chosen before.
2806 This fixes projects.maemo.org bug NB#56273 .
2808 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2810 * src/maemo/modest-main-window-ui.h:
2811 * src/modest-ui-actions.c:
2812 * src/modest-ui-actions.h:
2813 Connect the Tools/SMTP Servers menu item to
2814 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2815 SMTP servers dialog, as in the UI specification and saves changes when it
2816 is closed. This fixed projects.maemo.org bug NB#56305 .
2818 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/modest-connection-specific-smtp-window.c:
2821 (modest_connection_specific_smtp_window_init):
2822 Use gtk_window_set_default_size() to make this window big enough, so
2823 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2825 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2827 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2828 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2829 (modest_connection_specific_smtp_edit_window_init),
2830 Do not try to connect to a combobox signal before the combobox exists.
2831 This fixes the cras in projects.maemo.org bug NB#56288 .
2832 (modest_connection_specific_smtp_edit_window_get_settings):
2833 Remove the server_account_name parameter which was being checked for NULL
2834 though it was not used.
2836 * src/maemo/modest-connection-specific-smtp-window.c:
2837 (modest_connection_specific_smtp_window_fill_with_connections),
2838 (on_button_edit), (modest_connection_specific_smtp_window_init):
2839 Correct the number of treemodel columns to prevent a warning.
2840 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2841 libconic does not work.
2843 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2845 * src/modest-tny-account.c:
2846 (modest_tny_account_new_from_server_account):
2847 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2848 SMTP when "None" was chosen by the user. However, with my SMTP server that
2849 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2852 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2854 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2855 to explain the memory management issue with the ID in the ModestPair.
2857 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2858 (add_sending_page), (modest_account_assistant_finalize):
2859 * src/gnome/modest-gnome-global-settings-dialog.c:
2860 (create_updating_page), (create_composing_page):
2861 * src/gnome/modest-msg-edit-window.c: (get_transports),
2862 (init_window), (modest_msg_edit_window_finalize),
2863 (modest_msg_edit_window_get_msg_data):
2864 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2865 * src/gnome/modest-transport-widget.c:
2866 (modest_transport_widget_finalize), (smtp_configuration):
2867 * src/maemo/modest-maemo-global-settings-dialog.c:
2868 (create_updating_page), (create_composing_page):
2869 * src/maemo/modest-msg-edit-window.c: (get_transports),
2870 (init_window), (modest_msg_edit_window_finalize),
2871 (modest_msg_edit_window_get_msg_data),
2872 (modest_msg_edit_window_free_msg_data):
2873 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2874 (modest_store_widget_finalize):
2875 * src/maemo/modest-transport-widget.c:
2876 (modest_transport_widget_finalize), (smtp_configuration):
2877 * src/modest-main.c: (send_mail):
2878 * src/widgets/modest-combo-box.h:
2879 * src/widgets/modest-global-settings-dialog-priv.h:
2880 * src/widgets/modest-global-settings-dialog.c:
2881 (modest_global_settings_dialog_finalize):
2882 * src/widgets/modest-msg-edit-window.h:
2883 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2884 as long as the combo box, to prevent use of freed memory for the ID.
2886 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2888 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2889 get_accounts(), to make this clearer. Do not check for the enabled gconf
2890 key, because we do not use this for server accounts (at least, not yet).
2891 This allows us to send email again.
2893 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2895 * src/maemo/modest-platform.c:
2896 (on_modest_conf_update_interval_changed), (modest_platform_init):
2897 Only respond to this particular key change. All these strcmp()s cannot be
2900 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2902 * src/maemo/modest-maemo-global-settings-dialog.c:
2903 (current_connection): Prevent a crash in scratchbox when
2904 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2905 * src/maemo/modest-platform.c:
2906 (on_modest_conf_update_interval_changed), (modest_platform_init):
2907 Get the update interval from gconf and reset it when the gconf key changes.
2909 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2911 * src/modest-protocol-info.c:
2912 * src/modest-protocol-info.h: Adde enum-specific get functions,
2913 instead of using a ModestProtocolType enum parameter.
2915 * src/gnome/modest-account-assistant.c:
2916 * src/gnome/modest-store-widget.c:
2917 * src/gnome/modest-store-widget.h:
2918 * src/gnome/modest-transport-widget.c:
2919 * src/gnome/modest-transport-widget.h:
2920 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2921 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2922 * src/maemo/easysetup/modest-easysetup-wizard.c:
2923 * src/maemo/modest-account-settings-dialog.c:
2924 * src/maemo/modest-account-settings-dialog.h:
2925 * src/maemo/modest-store-widget.c:
2926 * src/maemo/modest-store-widget.h:
2927 * src/maemo/modest-transport-widget.c:
2928 * src/maemo/modest-transport-widget.h:
2929 * src/modest-account-mgr-helpers.c:
2930 * src/modest-account-mgr-helpers.h:
2931 * src/modest-account-mgr.c:
2932 * src/modest-account-mgr.h:
2933 * src/modest-tny-account.c:
2934 * src/modest-tny-folder.c:
2935 * src/widgets/modest-account-view.c:
2936 * src/widgets/modest-retrieve-combo-box.c:
2937 * src/widgets/modest-retrieve-combo-box.h:
2938 * src/widgets/modest-secureauth-combo-box.c:
2939 * src/widgets/modest-serversecurity-combo-box.c:
2940 * src/widgets/modest-serversecurity-combo-box.h:
2941 * tests/check_account-mgr.c:
2942 Use the specific functions, and use the re-renamed enum values for GNOME too.
2944 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2946 * src/modest-pair.h:
2947 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2948 so we can get the second based on the first.
2950 * src/maemo/modest-account-settings-dialog.h:
2951 * src/maemo/modest-account-settings-dialog.c:
2952 Added get_supported_secure_authentication_methods(), though it is mostly
2953 commented-out for now until the necessary API is committed to tinymail.
2954 (modest_account_settings_dialog_set_account_name),
2955 (save_configuration): Request the supported authentication methods from the
2956 server, so we can choose a working method.
2958 * src/modest-tny-account-store.h:
2959 * src/modest-tny-account-store.c:
2960 (modest_tny_account_store_get_session): Rename from
2961 tny_account_store_get_session().
2963 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2965 * src/modest-protocol-info.h: Split the ModestProtocol enum
2966 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2967 There was no need to have these unrelated values in one enum.
2969 * src/: many files: Adapted to changed enum. This makes the code a bit
2970 clearer, and the compiler could catch some errors.
2972 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2974 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2975 Show the detailed internal camel error message when an error happens
2976 during the configuration, so that our testers can give us more clues.
2977 For instance, in projects.maemo.org bug NB#56910 .
2979 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2981 * src/modest-tny-account.c:
2982 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2983 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2985 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2987 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2988 * src/maemo/modest-account-settings-dialog.c:
2989 (modest_account_settings_dialog_set_account_name),
2990 (save_configuration): For the incoming secure authentication checkbox,
2991 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2992 the UI specification. PLAIN does not seem to be supported for most IMAP
2993 servers anyway, and I am not sure what it would mean.
2994 However, we probably need to discover which of the secure-authentication
2995 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2996 * src/modest-account-mgr-helpers.c:
2997 (modest_account_mgr_get_server_account_data):
2999 * src/modest-tny-account.c:
3000 (modest_tny_account_new_from_server_account):
3001 Use tny_account_set_mech() to set secure-authentication methods,
3002 with some special-casing for IMAP, based on my observations of how
3005 * src/modest-account-mgr-helpers.h:
3006 * src/modest-account-mgr.c:
3007 * src/modest-defs.h: Comment that the URI is only used for local folders.
3009 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3011 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3012 parameter const, just to be neat.
3013 * src/modest-text-utils.c: (modest_text_utils_inline):
3014 End g_strconcat() with NULL, as its documentation says. This is almost
3015 certainly the cause of my crash at startup on the device. Interestingly,
3016 valgrind doesn't tell us about these errors.
3018 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3020 * scripts/build-packages: Added more precise comments about how to use
3021 this script, though I still get this error:
3022 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3023 error building tinymail
3025 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3027 * src/maemo/modest-main-window.c: (on_account_update):
3028 Very slight cleanup, hoping to make it simpler to discover what causes
3029 a crash here sometimes.
3031 * src/modest-tny-account.c:
3032 (modest_tny_account_new_from_server_account): Set the port. Added
3033 comments about the options and a TODO comment because I need to find out
3034 how to specify the secure authentication method.
3036 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3038 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3039 changed CFlags paths form modest to libmodest
3041 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3043 * src/modest-account-mgr-helpers.c:
3044 (modest_account_mgr_get_server_account_data),
3045 (modest_account_mgr_free_server_account_data):
3046 * src/modest-account-mgr-helpers.h:
3047 * src/modest-account-mgr.c:
3048 (modest_account_mgr_add_server_account):
3049 * src/modest-defs.h:
3050 * src/modest-tny-account.c:
3051 (modest_tny_account_new_from_server_account):
3052 Determine the options for tny_camel_account_add_option() here,
3053 based on the settings, rather than storing them directly in gconf.
3055 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3057 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3058 Show a more friendly error dialog now that we expect (from the tinymail
3059 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3061 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3063 * src/maemo/modest-main-window.c: (on_account_update): Check that
3064 account_name is not NULL, to prevent a crash at startup that I am
3065 seeing on the N800. I do wonder why it is NULL.
3067 * src/maemo/easysetup/modest-easysetup-wizard.c:
3068 (create_page_user_details):
3069 * src/maemo/modest-account-settings-dialog.c:
3070 (create_page_user_details), (create_page_outgoing):
3071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3072 (modest_connection_specific_smtp_edit_window_init):
3073 * src/modest-ui-actions.c:
3074 (modest_ui_actions_on_password_requested):
3075 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3076 might do something useful with the on-screen keyboard.
3078 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3080 * src/maemo/modest-main-window.c: (on_account_update):
3081 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3082 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3084 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3086 * src/modest-tny-account-store.c: (on_account_changed):
3087 Correct the signature of this signal handler.
3089 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3091 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3092 Show a HildonNote instead of a GtkDialog for Maemo.
3094 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3096 * src/widgets/modest-account-view.h:
3097 * src/widgets/modest-account-view.c: (on_account_changed),
3098 (on_account_removed). Added a boolean flag, set/unset by
3099 modest_account_view_block_conf_updates(),
3100 modest_account_view_unblock_conf_updates() to prevent unnecessary
3101 updates, but this is not very useful because the gconf notifications are
3102 so delays (maybe only on Maemo Bora).
3103 So auto-updating is turned off, and these functions do an explicit
3104 update when necessary.
3105 However, something else is still doing too much work when adding/removing
3106 accounts, probably in another part of the application.
3108 * src/maemo/modest-account-view-window.c:
3109 (on_delete_button_clicked), (on_edit_button_clicked),
3110 (on_new_button_clicked): Use the new functions.
3112 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3114 * src/modest-account-mgr-helpers.c:
3115 (modest_account_mgr_set_first_account_as_default):
3116 Sort the list of names alphabetically-by-title, so we choose the first one
3118 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3119 alphabetically by the title.
3121 This fixes projects.maemo.org bug NB#56418 .
3123 * src/modest-account-mgr-priv.c:
3124 (_modest_account_mgr_account_from_key):
3125 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3126 avoid a valgrind error, and possible random behaviour.
3128 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3130 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3131 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3132 tinymail documentation to say that this can be expected.
3133 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3134 pretty, and should not happen, but I would prefer to know when it does.
3136 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3138 * configure.ac: When using the older hildon version, probably on Bora,
3139 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3141 * src/widgets/modest-attachment-view.c:
3142 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3145 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3147 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3148 Implemented the prototype. Can be tested with
3149 tests/dbus_api/test_open_message:
3151 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3153 * src/modest-tny-account-store.c:
3154 (modest_tny_account_store_instance_init), (get_password):
3155 * src/modest-ui-actions.c:
3156 (modest_ui_actions_on_password_requested):
3157 Do not store the password in gconf, because this function is called
3158 for non-remembered passwords. Actually use the cached (in the hash map)
3159 password instead of releasing it.
3160 The password will now not be remembered if it is asked via the protected
3161 password dialog, as per the UI spec.
3163 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3165 * src/modest-defs.h:
3166 * src/modest-account-mgr-helpers.h:
3167 * src/modest-account-mgr-helpers.c:
3168 Added modest_server_account_get_username_has_succeeded(),
3169 modest_server_account_set_username_has_succeeded().
3170 (modest_server_account_set_username),
3171 Reset the has-succeeded flag if the username changes.
3173 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3174 * src/maemo/modest-connection-specific-smtp-window.c:
3175 (modest_connection_specific_smtp_window_save_server_accounts):
3176 Use modest_server_account_set_username() instead of using
3177 modest_conf_set_string() directly, so that the has-succeeded flag is always
3180 * src/modest-ui-actions.c:
3181 (modest_ui_actions_on_password_requested): Dim the username entry if
3182 the username has ever worked, as per the UI spec.
3184 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3186 * src/modest-tny-account-store.c: (get_password):
3187 * src/modest-ui-actions.c:
3188 (modest_ui_actions_on_password_requested):
3189 Allow the username to be changed too, though there is more work to
3190 be done on exactly how this behaves.
3192 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3194 * src/modest-account-mgr-helpers.h:
3195 * src/modest-account-mgr-helpers.c:
3196 Added modest_account_mgr_get_display_name(),
3197 modest_server_account_get_username(),
3198 modest_server_account_set_username(),
3199 modest_server_account_set_password(),
3200 modest_server_account_get_hostname() functions so we do not need to
3201 use the conf API directly.
3203 * src/maemo/modest-main-window.c: (connect_signals):
3204 Actually connect ot the ModestAccountStore::request-password signal,
3205 so that we show the dialog when the password is requested by Tinymail,
3206 for isntance if it is empty.
3208 * src/modest-marshal.list:
3209 * src/modest-tny-account-store.c:
3210 (modest_tny_account_store_class_init), (get_password),
3211 (modest_tny_account_store_alert):
3212 * src/modest-tny-account-store.h:
3213 * src/modest-ui-actions.h:
3214 * src/modest-ui-actions.c:
3215 (modest_ui_actions_on_password_requested):
3216 Change the signal parameters, so it is obvious that we are providing
3217 the non human-readable server name, and receiving both the username
3218 and password, though changing of the username is not yet implemented.
3219 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3220 for the GNOME version.
3222 This should fix the projects.maemo.org bug NB#56209, though it does not
3223 work on Bora, because the gconf_client_get() for the password fails
3224 immediately after we save it with gconf_client_set().
3226 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3229 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3230 caused an undefined symbol error:
3231 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3233 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3235 * src/modest-tny-account-store.c:
3236 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3237 using a GError instead of a string message, so we can translate it in
3240 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/modest-address-book.c:
3243 (modest_address_book_check_names):
3244 * src/maemo/modest-msg-view-window.c:
3245 (modest_msg_view_window_clipboard_owner_change):
3246 * src/modest-init.c: (modest_init_init_ui):
3247 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3248 (update_folders_cb), (modest_mail_operation_update_account):
3249 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3250 (modest_ui_actions_on_msg_attachment_clicked),
3251 (modest_ui_actions_on_msg_recpt_activated):
3252 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3253 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3254 (modest_msg_view_search_next):
3255 * src/widgets/modest-recpt-editor.c:
3256 (modest_recpt_editor_on_button_release_event),
3257 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3258 g_message(). At this point we should only be seeing interesting errors on
3259 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3261 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3263 (modest_wizard_dialog_force_title_update):
3264 * src/maemo/easysetup/modest-wizard-dialog.h:
3265 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3266 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3267 can update the title when appropriate. Otherwise the title is wrong if the
3268 pages are added after adding the notebook to the dialog.
3269 This must be a problem in HildonWizardDialog too.
3270 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3272 * src/maemo/easysetup/modest-easysetup-wizard.c:
3273 (create_subsequent_customsetup_pages),
3274 (create_subsequent_easysetup_pages):
3275 Call modest_wizard_dialog_force_title_update() so that the title is
3276 correct even with GTK+ < 2.10.
3277 This fixes projects.maemo.org bug NB#56145 .
3279 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3281 * src/maemo/modest-platform.c:
3282 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3283 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3286 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3288 * src/widgets/modest-window.h:
3289 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3290 and modest_window_save_state(), which invokes it.
3292 * src/widgets/modest-window-mgr.h:
3293 * src/widgets/modest-window-mgr.c:
3294 Added modest_window_mgr_save_state_for_all_windows(), which calls
3295 the save_state vfunc on all registered windows, if implemented.
3297 * src/gnome/modest-msg-edit-window.c:
3298 * src/gnome/modest-msg-view-window.c:
3299 * src/maemo/modest-msg-edit-window.c:
3300 * src/maemo/modest-msg-view-window.c:
3301 * src/maemo/modest-main-window.c:
3302 Specify the existing save_settings functions as implementations of
3303 ModestWindow::save_state_func().
3305 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3306 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3307 enabling hibernation, for instance.
3309 We may need to do the same thing for restoring settings.
3312 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3314 * src/widgets/modest-window-mgr.c:
3315 * src/widgets/modest-window-mgr.h:
3316 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3317 modest_window_mgr_get_hibernation_is_prevented().
3319 * src/maemo/modest-main-window.c:
3320 (on_hildon_program_is_topmost_notify): Prevent hibernation
3321 (possible when the application goes to the background in the WM),
3322 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3324 * src/maemo/easysetup/modest-easysetup-wizard.c:
3325 (modest_easysetup_wizard_dialog_init):
3326 * src/maemo/modest-account-settings-dialog.c:
3327 (modest_account_settings_dialog_init):
3328 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3329 (modest_connection_specific_smtp_edit_window_init):
3330 * src/maemo/modest-connection-specific-smtp-window.c:
3331 (modest_connection_specific_smtp_window_init):
3332 * src/maemo/modest-signature-editor-dialog.c:
3333 (modest_signature_editor_dialog_init):
3334 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3335 prevent hibernation while any of these account settings dialogs are open.
3337 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3339 * src/maemo/Makefile.am:
3340 * src/maemo/modest-osso-state-saving.c:
3341 * src/maemo/modest-osso-state-saving.h: Added
3342 modest_osso_load_state() and modest_osso_save_state() though they do
3343 nothing now. They should iterate through all the open windows and load/save
3345 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3346 save state when closing.
3348 * src/maemo/modest-main-window.c:
3349 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3350 Add a notification handler for the HildonProgram::is-topmost property,
3351 so we can allow hibernation when the application goes into the background.
3352 But we still need to detect when the accounts setup windows are open so
3353 we can stop hibernation when they are open.
3354 To do this, I also added the main window the HildonProgram. This might have
3355 other side-effects/benefits, and should maybe be done for other windows.
3357 * src/maemo/modest-osso-autosave-callbacks.h:
3358 * src/maemo/modest-osso-autosave-callbacks.c:
3359 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3360 though it does not do anything yet, and we might never need this to do
3361 anything. For instance, we already save drafts.
3363 * src/maemo/modest-platform.c: (modest_platform_init):
3364 Specify the libosso auto-save callback.
3366 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/modest-platform.c:
3369 (modest_platform_set_update_interval):
3370 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3371 aparently stays valid between application instances, so we can use this
3372 to remove and reset it later. According to a maemo-developers email from
3375 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3377 * configure.ac: Depend on libalarm for Maemo.
3379 * src/dbus_api/modest-dbus-api.h:
3380 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3381 (on_send_receive), (modest_dbus_req_handler):
3382 Handle a SEND_RECEIVE D-Bus method.
3384 * libmodest-dbus-client/libmodest-dbus-client.c:
3385 (libmodest_dbus_client_send_and_receive):
3386 * libmodest-dbus-client/libmodest-dbus-client.h:
3387 Add C convenience functions for calling the new D-Bus method.
3389 * src/modest-platform.h:
3390 * src/gnome/modest-platform.c:
3391 * src/maemo/modest-platform.c:
3392 Added modest_platform_set_update_interval(), which uses the
3393 alarmd API on Maemo.
3394 (modest_platform_init),
3395 Call modest_platform_set_update_interval(), using a hard-coded
3396 interval for now (until the global settings dialog is implemented),
3397 though I am not sure that this makes sense yet.
3399 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3401 * src/dbus_api/modest-dbus-callbacks.c:
3402 (modest_osso_cb_hw_state_handler):
3403 * src/dbus_api/modest-dbus-callbacks.h:
3404 * src/maemo/modest-platform.c: (modest_platform_init):
3405 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3406 in case this has some effect on the ability for Maemo to ping the
3409 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3411 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3412 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3413 warning. It is probably a logic error, but I need to fix the build.
3415 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3417 * src/modest-account-mgr.h:
3418 * src/modest-account-mgr.c:
3419 (modest_account_mgr_account_names): Add a gboolean enabled_only
3420 parameter, so we can get lists of onlt the enabled accounts.
3422 (modest_account_mgr_add_account),,
3423 (modest_account_mgr_account_with_display_name_exists):
3424 * src/maemo/modest-msg-edit-window.c: (get_transports):
3425 * src/modest-account-mgr-helpers.c:
3426 (modest_account_mgr_set_first_account_as_default):
3427 * src/modest-init.c: (init_default_account_maybe):
3428 * src/modest-tny-account-store.c: (get_accounts):
3429 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3430 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3431 * tests/check_account-mgr.c: (START_TEST):
3432 Provide the extra parameter, as appropriate.
3434 * src/widgets/modest-account-view.c: (update_account_view):
3435 Do not show disabled accounts (meaning that there is no way to
3436 enable/disable accounts in the UI (the feature is not in our UI
3437 specification), so we can use this internally only to mark unfinished
3438 or temporary account data.
3440 * src/maemo/easysetup/modest-easysetup-wizard.c:
3441 (create_account): Add boolean enable parameter, so we can specify FALSE
3442 to create the temporary account.
3443 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3444 (on_before_next): When finishing, when there is a temporary account, just
3446 Also, use a timeout to delay the showing of the dialog until gconf is likely
3447 to return correct information, due to a maemo gconf bug that is fixed in
3448 osso 1.1, but not yet in Bora.
3449 However, the dialog stays on screen after it is destroyed.
3451 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3452 for invalid data when cancelling. Use a hildon note instead of a dialog
3453 to complain about invalid data. Do not show the account-saved note if the
3454 account is disabled (a temporary account that will not really be saved for use
3457 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3459 * src/modest-account-mgr-helpers.h:
3460 * src/modest-account-mgr-helpers.c:
3461 Added modest_account_mgr_unset_default_account(),
3462 Added modest_account_mgr_set_first_account_as_default().
3464 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3465 If it was the default account, unset the default account name.
3467 * src/maemo/modest-account-view-window.c:
3468 (on_delete_button_clicked): If it was the default account,
3469 set the first remaining account as the default instead.
3471 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3472 a NULL account or a NULL default account, to prevent a crash. This should
3473 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3476 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3478 * src/widgets/modest-recpt-editor.c:
3479 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3480 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3481 TODO comment for this. This fixes the build.
3483 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3484 be the best place for it. This will in future update all auto-update accounts,
3485 rather than just the current/default account, when that gconf key exists.
3486 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3487 if there are no accounts, before calling do_send_receive().
3488 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3490 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3491 * src/maemo/modest-main-window-ui.h:
3492 * src/maemo/modest-main-window.c: (on_connection_changed),
3493 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3494 directly, becaue the signal handler does more.
3496 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3498 * src/modest-account-mgr-helpers.c:
3499 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3500 for the case that the account does not exist.
3502 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3503 (equivalent to the modest account name) rather than the tinymail account name
3504 (equivalent to the modest account title - human readable) to get the account data.
3505 Check for null account data to prevent the crash, and add a TODO comment saying that
3506 this needs fixing because it is using the server account name instead of the account name.
3508 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3510 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3511 * src/maemo/modest-account-settings-dialog.c: (show_error),
3513 Use hildon_note_new_information() for informative and error messages,
3514 which seems to be expected for Maemo applications (no documentation that I know of
3515 says this). I am surprised that there is no distinction between info and error
3518 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3520 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3521 it is easy to find where this is used.
3523 * src/maemo/easysetup/modest-easysetup-wizard.c:
3524 (create_page_welcome), (create_page_account_details),
3525 (create_page_user_details), (create_page_complete_easysetup),
3526 (create_page_custom_incoming), (create_page_custom_outgoing),
3527 (create_page_complete_custom):
3528 * src/maemo/modest-account-settings-dialog.c:
3529 (create_page_account_details), (create_page_user_details),
3530 (create_page_incoming), (create_page_outgoing):
3531 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3532 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3533 (modest_connection_specific_smtp_edit_window_init):
3534 * src/maemo/modest-connection-specific-smtp-window.c:
3535 (modest_connection_specific_smtp_window_init):
3536 * src/maemo/modest-signature-editor-dialog.c:
3537 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3538 and scrolling policy as per the Email Application Layout Guide, if I have
3541 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3543 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3544 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3545 which were empty, because these vfuncs have been removed from TnyAccountStore.
3546 This fixes the build.
3548 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3550 * src/maemo/modest-main-window.c:
3551 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3552 showing/hiding it. Added TODO because it probably should not be NULL.
3553 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3554 because unnecessary g_warnings() make degugging difficult.
3556 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3558 * src/maemo/modest-msg-edit-window.c:
3559 (modest_msg_edit_window_select_color),
3560 (modest_msg_edit_window_select_background_color): 2 const corrections and
3561 moving 2 #endifs before closing brackets, to fix the build.
3563 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3565 * src/maemo/easysetup/modest-easysetup-wizard.h:
3566 * src/maemo/easysetup/modest-easysetup-wizard.c:
3567 (modest_easysetup_wizard_dialog_finalize),
3568 (on_button_edit_advanced_settings), (create_page_complete_custom),
3569 (on_response), (create_account):
3570 Implement the Advanced Settings edit button, by saving the account information,
3571 for the Advanded Settings dialog to use directly from gconf, and removing it
3572 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3573 Bug #5533 in the projects.maemo.org bugzilla.
3575 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3577 * src/maemo/modest-msg-view-window.c:
3578 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3579 when opening a message window.
3581 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3583 * src/maemo/easysetup/modest-easysetup-wizard.c:
3584 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3587 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3588 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3589 gconf settings. I probably added more checks than necessary, but that is safer.
3591 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3592 variable to fix the build, but this seems to be used when it is still NULL.
3594 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3596 * src/modest-platform.h:
3597 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3598 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3599 * src/modest-main.c: Implement this function so we can avoid using
3600 maemo-specific API from cross-platform code.
3602 * src/modest-tny-account-store.c:
3603 (get_smtp_specific_transport_account_for_open_connection):
3604 * src/modest-ui-actions.c: (check_for_connection),
3605 (modest_ui_actions_on_item_not_found):
3606 Use modest_platform_connect_and_wait() and put #idefs around other
3607 maemo-specific code, because only maemo currently has a way to
3608 identify connection names.
3610 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3612 * src/modest-tny-account-store.h:
3613 * src/modest-tny-account-store.c:
3614 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3615 the connection-specific SMTP server settings in the configuration.
3617 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3619 * src/maemo/modest-main-window.c: (on_connection_changed),
3621 * src/modest-main.c: (main), (start_ui), (send_mail):
3622 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3623 that is what is intended.
3625 * src/modest-ui-actions.c: (action_send), (action_receive),
3626 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3627 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3628 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3629 SMTP server is used when it is specified.
3631 (modest_ui_actions_on_send_receive):
3632 Check that a connection is open before proceeding.
3633 Receive and then send, instead of vice-versa, as per the specification.
3635 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3637 * src/modest-mail-operation.c:
3638 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3639 though I guess it should be something other than NULL.
3641 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3643 * src/maemo/easysetup/modest-easysetup-wizard.c:
3644 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3645 combo twice, to avoid an g_warning and to make it visible again.
3646 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3647 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3648 (already intended) dereference when detaching, because we then recreate the menu.
3649 But I am not sure why the warning was happening, and it is possible that this is a memory
3652 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3654 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3655 and uri_parse_mailto() utility functions.
3656 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3658 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3660 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3662 * src/dbus_api/modest-dbus-api.h:
3663 * src/dbus_api/modest-dbus-callbacks.c:
3664 Use an idle callback to execute the modest code in the application's own thread.
3665 Remove the helloworld example method.
3666 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3667 parsed, and the open-message method is not implemented because this is not yet implemented in
3669 * libmodest-dbus-client/libmodest-dbus-client.c:
3670 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3671 (libmodest_dbus_client_open_message):
3672 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3674 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3675 body without crashing.
3677 * tests/dbus_api/Makefile.am:
3678 * tests/dbus_api/test_mail_to.c:
3679 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3681 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3683 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3684 Added file to fix the build. Sorry.
3686 * src/dbus_api/Makefile.am:
3687 * src/dbus_api/modest-dbus-api.h:
3688 * src/dbus_api/modest-dbus-callbacks.h:
3689 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3690 (modest_dbus_req_handler):
3691 Put constants in a separate header so it can be reused by the
3692 client library, without duplication
3694 * libmodest-dbus-client/Makefile.am:
3695 * libmodest-dbus-client/libmodest-dbus-client.c:
3696 (libmodest_dbus_client_call_helloworld),
3697 (libmodfest_dbus_client_send_mail),
3698 (libmodfest_dbus_client_mailto),
3699 (libmodfest_dbus_client_open_message):
3700 * libmodest-dbus-client/libmodest-dbus-client.h:
3701 (Partly) Implement a send_mail D-Bus method.
3703 * tests/dbus_api/Makefile.am:
3704 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3705 the send_email D-Bus method.
3707 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3711 * libmodest-dbus-client/Makefile.am:
3712 * libmodest-dbus-client/libmodest-dbus-client.c:
3713 * libmodest-dbus-client/libmodest-dbus-client.h:
3714 * tests/dbus_api/Makefile.am:
3715 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3716 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3718 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3720 * src/maemo/easysetup/modest-easysetup-wizard.c:
3721 (create_page_account_details):
3722 * src/maemo/modest-account-settings-dialog.c:
3723 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3724 widgets, because this might not be the default in future versions of the Maemo GTK+.
3725 However, I can not not get capitalization to work even in a simple test case.
3727 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3729 * src/maemo/easysetup/modest-easysetup-wizard.c:
3730 (create_page_custom_incoming), (create_page_custom_outgoing):
3731 * src/maemo/modest-account-settings-dialog.c:
3732 (create_page_account_details), (create_page_incoming),
3733 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3734 instead of using gtk_check_button_with_label(), so they are aligned like the other
3735 widgets, as per the UI spec.
3737 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3739 * src/maemo/easysetup/modest-easysetup-wizard.c:
3740 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3741 * src/widgets/modest-validating-entry.c:
3742 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3743 Modest prefix instead of an EasySetup prefix.
3745 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3747 * src/widgets/modest-validating-entry.h:
3748 * src/widgets/modest-validating-entry.c: (on_insert_text),
3749 Added easysetup_validating_entry_set_max_func(), used to set a callback
3750 to call when the max number of characters is reached. GtkEntry has a max-length
3751 already but is silent about it.
3753 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3754 (create_page_account_details), (create_page_user_details),
3756 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3757 (create_page_account_details), (create_page_user_details),
3758 (create_page_outgoing):
3759 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3760 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3761 the UI spec, when the user tries to enter more than the max number of characters.
3763 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3765 * src/maemo/easysetup/modest-easysetup-wizard.c:
3766 (create_page_user_details), (create_page_custom_incoming),
3767 (create_page_custom_outgoing):
3768 * src/maemo/modest-account-settings-dialog.c:
3769 (create_page_user_details), (create_page_incoming),
3770 (create_page_outgoing):
3771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3772 (modest_connection_specific_smtp_edit_window_init):
3773 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3774 not appropriate. Bad Maemo-specific defaults!.
3776 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3778 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3779 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3780 (modest_signature_editor_dialog_set_settings):
3781 Disable the label and textview when the checkbox is disabled, and use the
3782 specified (UI spec) default signature text.
3784 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3786 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3787 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3789 * src/modest-defs.h:
3790 * src/modest-account-mgr-helpers.h:
3791 * src/modest-account-mgr-helpers.c:
3792 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3794 * src/maemo/Makefile.am:
3795 * src/maemo/modest-signature-editor-dialog.c:
3796 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3799 * src/maemo/modest-account-settings-dialog.h:
3800 * src/maemo/modest-account-settings-dialog.c:
3801 (modest_account_settings_dialog_finalize), (on_button_signature),
3802 (save_configuration): Use the new dialog when the Edit button is pressed, and
3803 save the changes if necessary, as per the UI spec.
3805 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3807 * src/maemo/Makefile.am:
3808 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3809 based on maemo-develoers email from Dirk.
3811 * src/maemo/easysetup/modest-easysetup-wizard.c:
3812 (create_page_welcome), (create_page_account_details),
3813 (create_page_user_details), (create_page_complete_easysetup),
3814 (create_page_custom_incoming), (create_page_custom_outgoing),
3815 (create_page_complete_custom),
3816 (modest_easysetup_wizard_dialog_init):
3817 * src/maemo/modest-account-settings-dialog.c:
3818 (create_page_account_details), (create_page_user_details),
3819 (create_page_incoming), (create_page_outgoing),
3820 (modest_account_settings_dialog_init):
3821 * src/maemo/modest-connection-specific-smtp-window.c:
3822 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3824 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3826 * src/maemo/easysetup/modest-easysetup-wizard.c:
3827 (create_page_account_details), (create_page_custom_outgoing),
3828 (create_page_complete_custom):
3829 * src/maemo/modest-account-settings-dialog.c:
3830 (create_page_user_details), (create_page_incoming),
3831 (create_page_outgoing):
3832 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3833 (modest_connection_specific_smtp_edit_window_init):
3834 Use the correct (UI spec) port min/max, and use horizontal separators,
3837 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3839 * src/maemo/easysetup/modest-easysetup-wizard.c:
3840 (set_default_custom_servernames):
3841 * src/maemo/modest-account-settings-dialog.c:
3842 (create_page_incoming), (on_combo_outgoing_security_changed),
3843 (on_combo_incoming_security_changed), (create_page_outgoing),
3844 (modest_account_settings_dialog_set_account_name),
3845 (save_configuration):
3846 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3847 (on_combo_security_changed),
3848 (modest_connection_specific_smtp_edit_window_init),
3849 (modest_connection_specific_smtp_edit_window_set_connection),
3850 (modest_connection_specific_smtp_edit_window_get_settings):
3851 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3854 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3857 * src/maemo/easysetup/modest-easysetup-wizard.c:
3858 (create_page_custom_outgoing), (create_page_complete_custom):
3859 * src/maemo/modest-account-settings-dialog.c:
3860 (create_page_user_details), (create_page_outgoing):
3861 * src/maemo/modest-account-view-window.c: (button_box_new):
3862 Use changed logical IDs as per the most recent UI spec:
3863 mcen_bd_emailsetup_edit -> mcen_bd_edit
3864 mcen_bd_emailsetup_delete -> mcen_bd_delete
3865 mcen_bd_emailsetup_close -> mcen_bd_close
3867 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3871 * src/dbus_api/Makefile.am:
3872 * src/dbus_api/modest-dbus-callbacks.c:
3873 * src/dbus_api/modest-dbus-callbacks.h:
3874 * src/maemo/modest-platform.c: (modest_platform_init):
3875 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3877 * tests/Makefile.am:
3878 * tests/dbus_api/Makefile.am:
3879 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3881 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3883 * src/maemo/modest-account-settings-dialog.c:
3884 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3885 Removed unnecessary includes.
3887 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3889 * src/maemo/easysetup/modest-easysetup-wizard.c:
3890 * src/maemo/modest-account-settings-dialog.c:
3891 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3892 * src/widgets/Makefile.am:
3893 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3894 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3895 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3896 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3897 * src/widgets/modest-secureauth-combo-box.c:
3898 * src/widgets/modest-secureauth-combo-box.h:
3899 * src/widgets/modest-serversecurity-combo-box.c:
3900 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3901 made the GObject names more consistent with the rest of the Modest code.
3903 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3905 * src/maemo/easysetup/Makefile.am:
3906 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3907 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3908 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3909 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3910 * src/maemo/easysetup/modest-easysetup-wizard.c:
3911 * src/maemo/easysetup/modest-validating-entry.c:
3912 * src/maemo/easysetup/modest-validating-entry.h:
3913 * src/maemo/modest-account-settings-dialog.c:
3914 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3915 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3916 widgets/ because they are used outside of easysetup too. After checking in,
3917 svn will allow me to rename them too.
3919 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3921 * src/gnome/modest-msg-edit-window.c:
3922 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3923 linker error, to fix the build on the GNOME platform.
3924 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3925 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3926 ifdefed out to avoid a warning.
3928 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3930 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3931 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3932 some alternative for GTK+ 2.6.
3934 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3938 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3939 specified for EmailAccountsDialog in UI spec.
3941 * src/maemo/easysetup/modest-easysetup-wizard.c:
3942 * src/maemo/easysetup/modest-easysetup-wizard.h:
3943 * src/maemo/modest-account-settings-dialog.c:
3944 * src/maemo/modest-account-settings-dialog.h:
3945 Reuse a member window widget for the connection-specific SMTP server accounts,
3946 so we can tell it to create/save the accounts only if we actually save changes.
3948 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3949 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3950 (modest_connection_specific_smtp_edit_window_get_settings):
3951 Return a struct instance for temporarily remembering the entered data.
3953 * src/maemo/modest-connection-specific-smtp-window.h:
3954 * src/maemo/modest-connection-specific-smtp-window.c:
3955 (modest_connection_specific_smtp_window_finalize),
3956 (modest_connection_specific_smtp_window_fill_with_connections),
3958 (modest_connection_specific_smtp_window_save_server_accounts),
3959 (update_model_server_names): Do not actually save data until asked,
3960 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3962 (on_selection_changed),
3963 (modest_connection_specific_smtp_window_init): Disable the edit
3964 button when nothing is selected.
3966 * src/modest-account-mgr-helpers.c:
3967 * src/modest-account-mgr-helpers.h:
3968 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3971 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3973 * src/modest-account-mgr-helpers.h:
3974 * src/modest-account-mgr-helpers.c:
3975 (modest_account_mgr_get_unused_account_name),
3976 (modest_account_mgr_get_unused_account_display_name): Added these
3977 utility functions, to avoid code duplication.
3979 * src/maemo/easysetup/modest-easysetup-wizard.c:
3980 (create_page_account_details), (create_account):
3981 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3982 (on_combo_security_changed),
3983 (modest_connection_specific_smtp_edit_window_init),
3984 (modest_connection_specific_smtp_edit_window_save_settings):
3985 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3986 * src/maemo/modest-connection-specific-smtp-window.c:
3987 (modest_connection_specific_smtp_window_finalize),
3988 (modest_connection_specific_smtp_window_fill_with_connections),
3989 (on_button_edit), (modest_connection_specific_smtp_window_init):
3990 * src/maemo/modest-connection-specific-smtp-window.h:
3991 Implementing saving of connection-specific server accounts.
3993 But I need to refactor this so we can save the data for each
3994 possible connection-specific account and only actually create the server accounts
3995 when the easysetup finished, or the OK button is pressed on the account settings
3998 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4000 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4001 (on_combo_security_changed):
4002 (modest_connection_specific_smtp_edit_window_init):
4003 Auto-fill the port number as in the account settings.
4005 (modest_connection_specific_smtp_edit_window_set_connection):
4006 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4007 * src/maemo/modest-connection-specific-smtp-window.c:
4008 (fill_with_connections), (on_button_edit),
4009 (modest_connection_specific_smtp_window_init):
4010 Turn the edit window into a dialog to simplify the code, and
4011 set a WM hint as in a GtkDialog, because only a popup can be on top of
4012 another window in Maemo, and popups usually have no WM decoration.
4014 * src/modest-defs.h:
4015 * src/modest-account-mgr-helpers.c:
4016 (modest_account_mgr_set_connection_specific_smtp),
4017 (modest_account_mgr_remove_connection_specific_smtp),
4018 (modest_account_mgr_get_connection_specific_smtp):
4019 * src/modest-account-mgr-helpers.h: Some functions to write the
4020 connection-specific SMTP server information. Not yet used.
4023 * src/widgets/modest-folder-view.c: (text_cell_data):
4024 Fix a warning about an uninitialized variable.
4025 (on_configuration_key_changed): Put an #ifdef around the use
4026 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4028 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4030 * src/maemo/modest-account-settings-dialog.h:
4031 * src/maemo/modest-account-settings-dialog.c:
4032 Added connect_for_modified() utility function to mark the new modified boolean.
4034 (create_page_account_details), (create_page_user_details),
4035 (create_page_incoming), (create_page_outgoing), (on_response),
4036 (modest_account_settings_dialog_init),
4037 (modest_account_settings_dialog_set_account_name):
4038 Only warn about unsaved changes when there are actually unsaved changes.
4040 * src/modest-account-mgr-helpers.c:
4041 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4042 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4043 to get the data from there in future.
4045 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4047 * src/modest-defs.h:
4049 * src/modest-account-mgr-helpers.h:
4050 * src/modest-account-mgr-helpers.c:
4051 Store the security account setting in a single conf key instead of using
4052 the options list, so that the list is left for just the to-be-removed camel hack,
4053 and because gconf_client_set_list() is failing for some reason.
4055 * src/modest-account-mgr.c:
4056 (modest_account_mgr_add_server_account):
4057 * src/maemo/modest-account-settings-dialog.c:
4058 (modest_account_settings_dialog_set_account_name),
4059 (save_configuration): Use the renamed functions.
4062 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4064 * src/widgets/Makefile.am:
4065 * src/widgets/modest-limit-retrieve-combo-box.c:
4066 * src/widgets/modest-limit-retrieve-combo-box.h:
4067 * src/widgets/modest-retrieve-combo-box.c:
4068 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4069 the account settings dialog.
4071 * src/modest-defs.h:
4072 * src/modest-account-mgr-helpers.h:
4073 * src/modest-account-mgr-helpers.c:
4074 (modest_server_account_get_option_secure_auth),
4075 (modest_server_account_set_option_secure_auth):
4076 * src/modest-account-mgr.c:
4077 (modest_account_mgr_add_server_account):
4078 Use the existing AUTH_MECH conf key for the secure-auth setting,
4079 instead of putting it in the list options, because this was actually used already.
4081 * src/maemo/modest-account-settings-dialog.c:
4082 (create_page_account_details),
4083 (modest_account_settings_dialog_set_account_name),
4084 (save_configuration):
4085 * src/maemo/modest-account-settings-dialog.h:
4086 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4087 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4089 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4091 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4092 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4093 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4095 * src/modest-defs.h:
4096 * src/maemo/modest-account-settings-dialog.c:
4097 (create_page_incoming), (on_combo_outgoing_security_changed),
4098 (on_combo_incoming_security_changed), (create_page_outgoing),
4099 (modest_account_settings_dialog_set_account_name),
4100 (save_configuration): Load/Save the port number, and change it when the
4101 security combo changes, to suitable defaults.
4103 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4105 * src/modest-account-mgr.c:
4106 (modest_account_mgr_add_server_account): Set the security and secure-auth
4107 options, and add a comment saying that the other camel-specific options should be
4110 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4112 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4114 * src/modest-tny-account-store.c: (account_list_free),
4115 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4116 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4119 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4121 * src/modest-protocol-info.c:
4122 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4123 is required by our UI spec. Maybe something in our implementation will use this eventually.
4124 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4125 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4126 instead of the previous 0 placeholder.
4128 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4129 secure-auth settings.
4130 * src/modest-account-mgr-helpers.h:
4131 * src/modest-account-mgr-helpers.c:
4132 (modest_server_account_data_get_option_secure_auth),
4133 (modest_server_account_set_option_secure_auth),
4134 (modest_server_account_data_get_option_security),
4135 (modest_server_account_set_option_security): Added this API for getting and setting the security
4136 and secure-auth settings.
4138 * src/maemo/modest-account-settings-dialog.h:
4139 * src/maemo/modest-account-settings-dialog.c:
4140 (modest_account_settings_dialog_finalize), (check_data),
4141 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4142 about changing titles.
4143 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4144 (save_configuration): Save the security and secure-auth settings.
4146 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4147 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4149 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4151 * src/modest-defs.h:
4152 * src/modest-account-mgr.c:
4153 (modest_account_mgr_add_server_account):
4154 Added and used defines for the options key and value pair strings,
4155 that are used so far, though they do not seem to correspond to anything in our
4156 UI specs or ModestProtocol enum.
4158 * src/modest-account-mgr-helpers.h:
4159 * src/modest-account-mgr-helpers.c:
4160 (compare_option_strings_for_name),
4161 (modest_server_account_data_get_option_value),
4162 (modest_server_account_data_get_option_bool),
4163 (modest_account_mgr_get_server_account_option):
4164 Added helper functions for parsing the options GSList.
4166 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4168 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4169 display name is based on the supplied account name.
4170 * src/modest-account-mgr.c:
4171 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4172 with an inefficient, but good-enough, implementation.
4174 * src/maemo/easysetup/modest-easysetup-wizard.c:
4175 (create_page_account_details), (on_before_next), (create_account):
4176 Check for existing display names rather than (non-user-visible) account names, and just
4177 create and set a unique account name at the end.
4179 * src/maemo/modest-account-settings-dialog.c:
4180 (modest_account_settings_dialog_init),
4181 (modest_account_settings_dialog_set_account_name),
4182 (create_page_incoming): Show the display name, instead of the account name.
4183 (on_response): Do some (not all) extra checks, as in the UI spec.
4184 (save_configuration): Save the display name if it was changed.
4186 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4188 * po/en_GB.po: Added needed logical ID and translation.
4189 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4190 (init_view): Made the is-default column clicking work.
4192 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4195 * src/maemo/easysetup/Makefile.am:
4196 * src/maemo/easysetup/modest-easysetup-wizard.c:
4197 (modest_easysetup_wizard_dialog_init):
4198 * src/maemo/easysetup/provider-data-test.keyfile:
4199 * src/maemo/easysetup/provider-data.keyfile:
4200 Moved the provider data file to the new modest-providers-data package and used it from there.
4202 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4204 * src/modest-local-folder-info.c:
4205 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4206 N_() was already used on the static strings, but this just marks it for translation without
4207 using the translation.
4209 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4211 * src/maemo/modest-account-settings-dialog.c:
4212 (create_page_incoming),
4213 (modest_account_settings_dialog_set_account_name):
4214 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4215 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4216 I will do this if nobody else gets there first.
4218 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4220 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4221 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4222 save the security stuff.
4224 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4226 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4227 Set the email address and user fullname, which I now see must be
4230 * src/maemo/modest-account-settings-dialog.h:
4231 * src/maemo/modest-account-settings-dialog.c:
4233 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4234 leave-on-server and authentication.
4235 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4238 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4241 * src/maemo/modest-account-settings-dialog.c:
4242 * src/maemo/modest-account-settings-dialog.h:
4243 Most (but not all) of the widgets are now present as specified by the UI spec.
4244 No changes are yet saved, and some details are not properly shown yet.
4246 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4248 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4250 * src/maemo/Makefile.am:
4251 * src/maemo/modest-account-settings-dialog.c:
4252 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4253 an existing account. Doesn't do much yet.
4255 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4256 Open the accounts settings dialog when Edit is clicked.
4258 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4260 * src/maemo/easysetup/Makefile.am:
4261 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4263 * src/maemo/easysetup/modest-easysetup-wizard.c:
4264 (modest_easysetup_wizard_dialog_init):
4265 Try to get the source directory from the build system,
4266 instead of hard-coding "./" into the source code, when opening our local
4267 copies of the configuration files.
4268 But this still fails when opening the wizard from the Accounts window,
4269 maybe because the working directory seems to change at runtime.
4270 So the wizard will fail the second time unless you copy the files into their
4271 proper locations - see the stdout warnings for the paths.
4273 (create_page_account_details),(on_before_next):
4274 Check for existing non-server accounts instead of server accounts,
4275 so the default account name is useful again, and to prevent trying to
4278 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4279 Show the wizard when New is clicked.
4281 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4282 (init_view): Show the column headers, and show the columns that are
4283 specified in the UI specs. However, something in Maemo's GTK+ prevents
4284 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4285 change the default account. This is despite unsetting the special properties.
4287 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4289 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4290 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4291 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4292 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4293 to make that clearer.
4294 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4296 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4298 * src/maemo/modest-account-view-window.c:
4299 (modest_account_view_window_init),
4300 (modest_account_view_window_new):
4301 Use the same buttons as specified in the
4302 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4303 the existing widgets, which never had a chance of working.
4304 Put the ModestAccountView treeview in a scrolled window.
4305 Do not repeat the initialization in both _init() and _new().
4307 * src/widgets/modest-account-view.c: (update_account_view):
4308 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4309 this widget and window shows no accounts.
4311 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4313 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4315 * src/maemo/easysetup/modest-easysetup-wizard.c:
4316 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4317 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4318 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4321 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4322 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4323 accounts exist yet, as in the UI spec.
4325 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4327 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4329 * src/maemo/Makefile.am:
4330 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4331 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4332 New window for editing connection-specific smtp details.
4333 Not fully implemented.
4335 * src/maemo/modest-connection-specific-smtp-window.c:
4336 (modest_connection_specific_smtp_window_finalize) :
4337 unref the tree model.
4338 (on_button_edit): Show the edit window.
4340 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4342 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4345 * src/maemo/Makefile.am:
4346 * src/maemo/modest-connection-specific-smtp-window.c:
4347 * src/maemo/modest-connection-specific-smtp-window.h:
4348 New window for showing the list of connections, for connection-specific
4349 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4350 * src/maemo/easysetup/modest-easysetup-wizard.c:
4351 (create_page_custom_outgoing): Show the new window when the button is clicked.
4353 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4355 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4356 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4357 * src/maemo/modest-msg-edit-window.c:
4358 (modest_msg_edit_window_insert_image):
4359 * src/modest-conf.c: (modest_conf_key_escape):
4360 * src/modest-mail-operation.c:
4361 (modest_mail_operation_send_new_mail):
4362 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4363 (modest_ui_actions_on_new_account):
4364 * src/widgets/modest-attachment-view.c: (update_filename_request):
4365 * src/widgets/modest-mail-header-view.c:
4366 Corrected warnings that were breaking the build, by commenting out unused variables,
4367 and a function, and by including a header.
4369 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4371 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4372 so we can #ifdef around platform-specific code when necessary.
4373 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4374 to allow this to build for the GNOME platform too.
4376 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4378 * src/maemo/easysetup/modest-easysetup-wizard.c:
4379 Added util_increment_name() and used it in create_page_account_details()
4380 to make sure that the default account name is always a new name.
4382 (modest_easysetup_wizard_dialog_init),
4383 (set_default_custom_servernames): Some minor memory management fixes.
4385 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4389 * src/modest-runtime.c: (init_i18n): Restored the translation
4390 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4391 are defined in config.h, and the translations are installed.
4393 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4394 is defined for translation.
4396 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4398 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4400 * src/maemo/easysetup/modest-easysetup-wizard.c:
4401 (modest_easysetup_wizard_dialog_init):
4402 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4403 Use realistic paths (though they should use $prefix generically) to the
4404 mcc_mapping and provider-data.keyfile files which might work when they
4405 are installed by the future version of the operator-wizard package,
4406 and then fallback to paths in our source code, with an explanatory
4409 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4413 * src/maemo/Makefile.am:
4414 * src/maemo/easysetup/: Added files from the previously-exernal
4415 osso-modest-easysetup.
4416 * src/maemo/modest-main-window-ui.h:
4417 * src/modest-ui-actions.c:
4418 * src/modest-ui-actions.h:
4419 Added modest_ui_actions_on_new_account() as a signal handler for the
4420 New Account menu item. It shows the easysetup wizard.
4421 * po/en_GB.po: Added additional needed logical IDs and translations.