1 2007-08-31 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
4 MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
5 for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
6 boolean, because this is the specified behaviour in the UI spec.
7 * src/modest-account-mgr-helpers.h:
8 * src/modest-account-mgr-helpers.c:
9 (modest_account_mgr_set_connection_specific_smtp),
10 (modest_account_mgr_remove_connection_specific_smtp),
11 (modest_account_mgr_get_connection_specific_smtp): Remove the account_name
13 * src/maemo/modest-connection-specific-smtp-window.h:
14 * src/maemo/modest-connection-specific-smtp-window.c:
15 (modest_connection_specific_smtp_window_finalize),
16 (modest_connection_specific_smtp_window_fill_with_connections),
17 (modest_connection_specific_smtp_window_save_server_accounts):
18 Remove the account_name parameters and member variable.
19 * src/maemo/easysetup/modest-easysetup-wizard.c:
20 (on_button_outgoing_smtp_servers), (create_account):
21 * src/maemo/modest-account-settings-dialog.c:
22 (on_button_outgoing_smtp_servers), (check_data),
23 (modest_account_settings_dialog_set_account_name),
25 * src/maemo/modest-maemo-utils.c: (on_account_online),
26 (modest_maemo_utils_get_supported_secure_authentication_methods):
27 * src/modest-tny-account-store.c:
28 (get_smtp_specific_transport_account_for_open_connection),
29 (insert_account), (add_connection_specific_transport_accounts):
30 * src/modest-ui-actions.c: (on_smtp_servers_window_hide),
31 (modest_ui_actions_on_smtp_servers):
32 Adapt to the changed API.
34 2007-08-29 Armin Burgmeier <armin@openismus.com>
36 * src/modest-protocol-info.h:
37 * src/modest-protocol-info.c: Added
38 modest_protocol_info_get_auth_protocol() to translate an
39 authentication protocol name to the corresponding enum value.
41 * src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
42 generation using the newly added function.
44 * src/maemo/modest-account-settings-dialog.c: Use the current element
45 when traversing through the list of supported authentication methods,
48 2007-08-29 Murray Cumming <murrayc@murrayc.com>
50 * src/maemo/easysetup/modest-easysetup-wizard.c:
51 (check_first_supported_auth_method), (on_before_next),
53 * src/maemo/modest-account-settings-dialog.c: (check_data):
54 Some cleanup, to make the code clearer.
56 2007-08-29 Murray Cumming <murrayc@murrayc.com>
58 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
59 Use the mail_ni_ssl_certificate_error ("Secure connection failed")
60 logical ID when the secure authentication method is not supported by
61 the server, as requested by Mox on the wiki, though I hate not
62 giving the user the clue.
64 2007-08-29 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-search.c: (modest_search_all_accounts):
67 * src/modest-platform.h:
68 * src/maemo/modest-platform.c: Moved and renamed
69 check_and_wait_for_account_is_online() to
70 modest_platform_check_and_wait_for_account_is_online() so it
71 can be used in more places.
73 2007-08-29 Murray Cumming <murrayc@murrayc.com>
75 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
76 Removed the sleep(1) experiment because it does not seem to help,
77 and I should not have checked the experiment in anyway.
78 The problem is maybe in the TnyAccount connected state - I will
79 investigate that instead.
81 2007-08-28 Murray Cumming <murrayc@murrayc.com>
83 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
84 Added a sleep(1) in case it helps with bug #66769.
86 2007-08-28 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-search.c: (on_timeout_check_account_is_online),
89 (check_and_wait_for_account_is_online):
90 It is OK for local-folder and mmc accounts to be used when they
91 are in the _INIT folder, instead of waiting for them to change
93 For POP and IMAP, wait from them to stop being _INIT, rather than
94 waiting from them to be _CONNECTED, because that seems to be
95 the status that causes the problems.
97 2007-08-28 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-search.c: (check_and_wait_for_account_is_online):
100 Actually pass the account to the timeout callback.
102 2007-08-28 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-search.c: (on_timeout_check_account_is_online):
105 Added some debug output to help me debug a problem on the N800.
106 (check_and_wait_for_account_is_online): Fail immediately if the
108 modest_search_all_accounts(): Try the search even if the account does
109 not seem to be online, because this can work sometimes, and should work
110 with the cache if there is no active libconic connection.
112 2007-08-27 Armin Burgmeier <armin@openismus.com>
114 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
115 observe outbox for added messages to assign them a status. Previously,
116 this was done in modest_tny_send_queue_add(), but the message id might
117 not yet be known at that point. This reduces warnings when sending
118 mail, though I am not sure how this even worked before.
120 2007-08-27 Murray Cumming <murrayc@murrayc.com>
122 * src/maemo/modest-account-settings-dialog.c:
123 (modest_account_settings_dialog_init):
124 * src/maemo/modest-connection-specific-smtp-edit-window.c:
125 (modest_connection_specific_smtp_edit_window_init):
126 * src/maemo/modest-connection-specific-smtp-window.c:
127 (modest_connection_specific_smtp_window_init):
128 * src/maemo/modest-maemo-utils.c:
129 (modest_maemo_utils_get_supported_secure_authentication_methods):
130 * src/maemo/modest-platform.c:
131 (modest_platform_run_folder_name_dialog):
132 * src/maemo/modest-signature-editor-dialog.c:
133 (modest_signature_editor_dialog_init):
134 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
135 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
136 * src/widgets/modest-global-settings-dialog.c:
137 (modest_global_settings_dialog_init):
138 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
140 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
141 GTK_STOCK_EDIT with mcen_bd_edit, and
142 GTK_STOCK_CLOSE with mcen_bd_close,
143 to fix projects.maemo.org bug NB#64995.
144 I strongly believe that Maemo's GTK+ should have the wanted translations
145 instead of duplicating this in each application and complicating the code.
147 2007-08-27 Armin Burgmeier <armin@openismus.com>
149 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
150 recursion when entering text in the subject field.
152 2007-08-27 Murray Cumming <murrayc@murrayc.com>
154 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
155 which checks every second, 10 times, to wait until the account is online
156 so that we can use it, if the account is in the process of going online.
157 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
158 so that searching works even when the application was not yet started before.
159 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
161 2007-08-24 Armin Burgmeier <armin@openismus.com>
163 * src/modest-widget-memory.c: Always show the default account when the
164 application is started, as stated in the UI spec. This fixes
165 projects.maemo.org bug NB#66630.
167 2007-08-24 Armin Burgmeier <armin@openismus.com>
169 * src/maemo/modest-platform.c:
170 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
171 english text for strings in the rename folder dialog, fixing
172 projects.maemo.org bug NB#66338.
174 2007-08-22 Armin Burgmeier <armin@openismus.com>
176 * src/widgets/modest-account-view.c: Fix for bora by using
177 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
178 latter seems not be used anymore.
180 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
183 * src/maemo/modest-main-window.c: Update menu items when the default
184 account changes so that the current default account is always bolded.
185 This fixes maemo.projects.org bug NB#66173.
187 2007-08-17 Murray Cumming <murrayc@murrayc.com>
189 * src/dbus_api/modest-dbus-callbacks.c:
190 (on_dbus_method_get_folders): Avoid trying to get the account name
191 when there are no accounts, to avoid critical g_warnings, fixing
192 projects.maemo.org bug NB#65574.
194 2007-08-17 Murray Cumming <murrayc@murrayc.com>
196 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
197 Use modest_account_mgr_get_signature() instead of accessing gconf
198 directly, to slightly simplify the code.
199 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
200 Append the signature also when opening via other applications,
201 fixing projects.maemo.org bug NB#65828.
203 2007-08-17 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
206 Check for NULLs to prevent a crash when opening an email that is
207 an attachment in another email, fixing projects.maemo.org bug
210 2007-08-17 Murray Cumming <murrayc@murrayc.com>
212 * src/modest-ui-dimming-rules.c:
213 (modest_ui_dimming_rules_on_view_window_move_to):
214 Enable the Move To toolbar button for search results, fixing the
215 last part of projects.maemo.org bug NB#63807.
217 2007-08-17 Murray Cumming <murrayc@murrayc.com>
219 * src/dbus_api/modest-dbus-callbacks.c:
220 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
221 because this is called from idle handlers, to fix hangs afte the
223 (find_message_by_url): Added a TODO comment about a crash that
224 happens when tinymail was built with DBC checks.
226 2007-08-16 Murray Cumming <murrayc@murrayc.com>
228 * src/modest-search.c: (modest_search_folder):
229 * src/modest-search.h: Rename ModestSearch::before to start_date
230 and after to end_date, using the same names as the libogs struct
232 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
233 The start_date and end_date were swapped in the check. This
234 fixes date range searches, fixing projects.maemo.org bug NB#63407.
236 2007-08-16 Murray Cumming <murrayc@murrayc.com>
238 * src/maemo/modest-account-view-window.c:
239 Added (check_for_active_acount).
240 (on_delete_button_clicked), (on_edit_button_clicked):
241 When an account is doing something (such as refreshing),
242 show the same warning for account deletion as for account
243 editing, to fix projects.maemo.org bug NB#64588.
245 2007-08-16 Murray Cumming <murrayc@murrayc.com>
247 * src/widgets/modest-msg-view-window.h:
248 * src/gnome/modest-msg-view-window.c:
249 * src/maemo/modest-msg-view-window.c:
250 Added modest_msg_view_window_construct().
251 (modest_msg_view_window_new_with_header_model),
252 Added modest_msg_view_window_new_for_search_result),
253 Renamed modest_msg_view_window_new() to
254 modest_msg_view_window_new_for_attachment(),
255 and modest_msg_view_window_is_search_result(),
256 so we can explicitly know that the window is for an
257 attachment or a search result or a message from the list.
259 (modest_msg_view_window_view_attachment):
260 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
261 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
262 Use modest_msg_view_window_new_for_search_result().
264 * src/modest-ui-dimming-rules.c:
265 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
266 for search results, fixing projects.maemo.org bug NB#63811.
268 2007-08-16 Armin Burgmeier <armin@openismus.com>
270 * src/modest-ui-actions.c: Show a banner instead of a dialog when
271 renaming a folder fails, to stay consistent with what happens when
272 creating a folder fails.
274 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
275 slightly country loading from the mmc_mappings file, fixed a memory
278 2007-08-16 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-tny-account-store.c: (volume_path_is_mounted):
281 Check the GnomeVFSVolume activation path instead of the device path,
282 so that the memory card is really really shown in the UI.
284 2007-08-16 Murray Cumming <murrayc@murrayc.com>
286 * src/maemo/easysetup/modest-easysetup-wizard.c:
287 (get_entered_account_title), (on_before_next), (entry_is_empty),
289 * src/maemo/modest-account-settings-dialog.c:
290 (get_entered_account_title), (on_button_signature), (check_data),
291 (save_configuration), (entry_is_empty):
292 Strip the account title of whitespace at the start and end before
293 using it or checking it. This means that an all-whitespace title
294 is not allowed, fixing projects.maemo.org bug NB#64977.
296 2007-08-15 Murray Cumming <murrayc@murrayc.com>
298 * src/modest-ui-actions.h:
299 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
300 to modest_run_account_setup_wizard() and made it public.
301 * src/dbus_api/modest-dbus-callbacks.c:
302 (check_and_offer_account_creation), (on_idle_mail_to),
303 (on_idle_compose_mail), (on_idle_open_default_inbox):
304 Offer account creation if necessary, fixing projects.maemo.org
307 2007-08-15 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-ui-actions.c: (run_account_setup_wizard):
310 Return a gboolean to indicate success.
311 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
312 (modest_ui_actions_on_send): When offering account creation, only
313 give up (return) if account creation failed. Otherwise continue
314 with the original request. This fixed projects.maemo.org bug
317 2007-08-15 Murray Cumming <murrayc@murrayc.com>
319 * src/widgets/modest-recpt-editor.c:
320 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
321 to fix projects.maemo.org bug NB#63789.
323 2007-08-15 Murray Cumming <murrayc@murrayc.com>
325 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
326 (modest_tny_account_store_new): Properly detect the memory card at
327 startup, and add an account for it.
329 2007-08-14 Murray Cumming <murrayc@murrayc.com>
331 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
332 Commented out the MMC code again because it mistakenly detects
333 the card even when it isn't inserted.
335 2007-08-14 Murray Cumming <murrayc@murrayc.com>
337 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
338 Renabled the call to add_mmc_account() because I do not believe
339 it could be the cause of the mentioned hang (in scratchbox, where
340 there is no memory card), and because I have tested that it works
343 2007-08-14 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
346 Comment out part of the last commit because it apparently causes
349 2007-08-14 Murray Cumming <murrayc@murrayc.com>
351 * src/modest-tny-account-store.c: Added the add_mmc_account()
352 function to save some copy/pasting.
353 (modest_tny_account_store_new): If the memory card is mounted,
354 create an account for it at the start, instead of waiting for the
355 user to unmount it and mount it.
357 2007-08-13 Murray Cumming <murrayc@murrayc.com>
359 * src/widgets/modest-account-view.c: (on_account_changed):
360 Do not try to use the human-readable TnyAccount name instead of the
361 ID of the modest account to get the transport account. And unref
362 the transport account. This prevents a g_warning(), and a possible
365 2007-08-13 Murray Cumming <murrayc@murrayc.com>
367 * src/maemo/modest-platform.c:
368 (modest_platform_set_update_interval): Handle the new
369 alarmd error to warn when alarmd is not running, as is the case in
370 scratchbox for me now because
371 "Module /usr/lib/alarmd/libretu.so initialization failed"
373 2007-08-13 Murray Cumming <murrayc@murrayc.com>
375 * src/widgets/modest-header-view-render.c:
376 (_modest_header_view_compact_header_cell_data):
377 NULL some strings after freeing them, trying to deal with
378 the double deletion found in projects.maemo.org bug 64183,
379 probably having no effect.
381 2007-08-13 Murray Cumming <murrayc@murrayc.com>
383 * src/maemo/modest-account-settings-dialog.c:
384 (create_page_incoming), (create_page_outgoing): Use a define
385 for the min and max port numbers.
387 (check_hildon_number_editor_and_warn_value_not_in_range),
388 (check_data): Do an extra check for an invalid port number, as needed
389 in projects.maemo.org bug #64275, when the number is cleared, but this
390 does not work due to bugs.maemo.org bug #1806.
392 2007-08-13 Murray Cumming <murrayc@murrayc.com>
394 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
395 Comment out the debug warning about the unexpected D-Bus methods.
396 They are just annoying now.
397 * src/maemo/modest-platform.c:
398 (modest_platform_set_update_interval): Correct the D-Bus path, instead
399 of using a file path, though it did not seem to break things before.
400 It might be needed now:
401 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
402 modest is not already running. This is the behaviour of the old client, and
403 Mox says it is what we should do for modest.
404 This closes projects.maemo.org bug NB#64327.
406 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
408 * src/modest-text-utils.c:
409 Fixed invalid jump due to incorrect string/pointer
411 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
414 2007-08-01 Murray Cumming <murrayc@murrayc.com>
416 * src/modest-account-mgr-helpers.h:
417 * src/modest-account-mgr-helpers.c:
418 Added modest_account_mgr_get_first_account_name(),
419 using code from modest_account_mgr_set_first_account_as_default().
421 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
422 (account_number_changed): Call set_at_least_one_account_visible() so that
423 the first account is visible when first added, without the user having to
425 I do wonder how this worked before.
427 2007-08-01 Murray Cumming <murrayc@murrayc.com>
429 * src/modest-tny-account-store.c: (show_password_warning_only),
430 (show_wrong_password), (request_password_and_wait), (get_password),
431 (modest_tny_account_store_alert): Remove the (incomplete anyway)
432 attempts to show UI only in the main context, which used g_idle_add()
433 and mainloops, because tinymail now guarantees that it only calls these
434 callbacks in the mainloop with the gdk lock. This makes everything much
437 2007-08-01 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
440 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
441 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
442 error dialog, instead of ignoring it.
444 2007-08-01 Murray Cumming <murrayc@murrayc.com>
446 * src/maemo/modest-msg-view-window.c:
447 (modest_msg_view_window_get_header),
448 (modest_msg_view_window_last_message_selected):
449 Added comments to explain the use of priv->header_model.
450 * src/modest-ui-dimming-rules.c:
451 (modest_ui_dimming_rules_on_open_msg),
452 (modest_ui_dimming_rules_on_mark_as_read_msg),
453 (modest_ui_dimming_rules_on_mark_as_unread_msg),
454 (modest_ui_dimming_rules_on_remove_attachments),
455 (_invalid_attach_selected), (_selected_msg_marked_as):
456 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
457 and changed the parameter to a ModestMainWindow to make it clearer that
458 it never uses any other kind of window.
459 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
460 instead of the selected message.
461 I notice that much of the dimming code and the ModestMsgViewWindow code
462 hard-codes the assumption that the viewed message is always selected in
463 the header view. This does not seem wise or simple.
465 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
466 examine the actual message instead of whatever might be selected
467 in the header view. This stops the delete toolbar button and menu item
468 from being dimmed when opening a message view the search UI,
469 partially fixing projects.maemo.org bug NB#63811.
471 However, when actually deleting, I now get this warning:
472 "tny_header_set_flags: This is a header instance for a new message.
473 Only priority and attachment flags are supported"
475 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
477 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
479 Show account wizard if no accounts are defined while sending
480 (automatic sending after the account wizard finished does not
481 work because it takes some time until the account manager
482 synchronizes everything. (projects.maemo.org NB#62792)
484 2007-07-30 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-tny-account-store.c: (on_account_removed),
487 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
488 account is removed from the View menu. We have TnyAccountStore
489 and ModestTnyAccountStore signals that seem very similar, but this
490 seems to work for now.
492 * src/maemo/modest-main-window.c:
493 (on_show_account_action_activated): Prevent dereference
494 of a NULL if the accoutn does not really exist, though that
495 should not happen anymore.
497 This fixes projects.maemo.org bug NB#64606.
499 2007-07-30 Murray Cumming <murrayc@murrayc.com>
501 * src/modest-ui-actions.c: (run_account_setup_wizard),
502 (modest_ui_actions_on_accounts): Revert a change that set these
503 to modal dialogs, freezing the UI when they show secondary dialogs.
504 This fixed projects.maemo.org bug NB#64519.
506 2007-07-27 Murray Cumming <murrayc@murrayc.com>
508 * src/widgets/modest-header-view-render.c:
509 (_modest_header_view_compact_header_cell_data):
510 Some checks and initialization to try to deal with a crash,
511 probably ineffective.
513 2007-07-27 Murray Cumming <murrayc@murrayc.com>
515 * src/maemo/modest-maemo-utils.c:
516 (modest_maemo_utils_get_supported_secure_authentication_methods):
517 Make sure that we have a connection, asking the user for one
519 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
520 Check for a connection before showing the wizard, because
521 the wizard needs a connection to check for server capabilities.
523 2007-07-27 Murray Cumming <murrayc@murrayc.com>
525 * src/maemo/modest-account-view-window.c:
526 (on_new_button_clicked): Remember the wizard dialog instance,
527 so we can just present it again if necessary. This prevents
528 multiple windows from appearing if you click again quickly on the
529 New button before the dialog appears, fixing projects.maemo.org
532 2007-07-27 Murray Cumming <murrayc@murrayc.com>
534 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
535 Offer a connection dialog if there is no connection when
536 starting modest. This should fix projects.maemo.org bug NB#61134.
538 2007-07-27 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
541 Reverted my last commit. I was able to fix the build by doing
542 apt-get install wpeditor0 (replacing other wpeditor packages) and
543 an explicit apt-get install wpeditor-dev to upgrade the -dev
546 2007-07-27 Murray Cumming <murrayc@murrayc.com>
548 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
549 Commented out the use of wp_text_buffer_replace_image()
550 because it does not exist, to break the build. Added a TODO for it.
552 2007-07-26 Murray Cumming <murrayc@murrayc.com>
554 * src/modest-tny-account-store.c: (recreate_all_accounts):
555 Recreate them even if they were NULL before. I guess something
556 else was already creating them before, or this would never
558 (modest_tny_account_store_get_server_account): Make sure that
559 the tny accounts have been created before trying to find one.
560 This allows libmodest_dbus_client_compose_mail() to work
561 when the UI is not yet visible.
562 This is probably useful in other cases too.
564 (get_password): When the password is wrong after it is entered
565 in the protected password dialog, show an info banner (in an
566 idle handler) before showing the protected password dialog
569 2007-07-26 Murray Cumming <murrayc@murrayc.com>
571 * src/modest-ui-actions.h:
572 * src/modest-ui-actions.c: Added
573 modest_do_refresh_current_folder() containing some code from
574 modest_ui_actions_on_send_receive().
575 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
576 Call modest_do_refresh_current_folder() before refreshing the
577 requested account, as in modest_ui_actions_on_send_receive().
578 This is strange, but seems to be necessary to show new mails.
579 Now new emails are finally visible in the UI when downloaded
580 via the automatic update interval, fixing bug NB#57458.
581 This also works because bug NB#57458 has been fixed somehow.
583 2007-07-26 Murray Cumming <murrayc@murrayc.com>
585 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
586 printf more details when we get unhandled D-Bus methods, because
589 * src/modest-mail-operation.c: (update_account_thread):
590 Comment out the tny_camel_pop_store_account_reconnect(), because this
591 is apparently no longer needed, and it did not work before anyway.
592 See the comment in the code.
594 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
595 by checking the header flags. This fixes projects.maemo.org bug
598 2007-07-25 Murray Cumming <murrayc@murrayc.com>
600 * src/maemo/modest-maemo-utils.h:
601 * src/maemo/modest-maemo-utils.c: Added
602 modest_maemo_show_information_note_in_main_context_and_forget().
603 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
604 Use the new function to show simple error dialogs in the main
605 context, though question dialogs are still in the current context,
606 which is unfortunately usually not the main context. This should
609 2007-07-25 Murray Cumming <murrayc@murrayc.com>
611 * src/modest-tny-account-store.c: (get_password):
612 Never save the entered username and password in gconf,
613 because the UI spec says we should not. This helps
614 slightly with projects.maemo.org bug NB#63671.
616 2007-07-25 Murray Cumming <murrayc@murrayc.com>
618 * src/widgets/modest-msg-edit-window.h:
619 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
620 Moved some code here to make it simpler.
621 (modest_msg_edit_window_attach_file_one): Renamed from
622 modest_msg_edit_window_attach_file_interactive().
623 (modest_msg_edit_window_offer_attach_file): Renamed from
624 modest_msg_edit_window_attach_file() and used
625 modest_msg_edit_window_attach_file_one() instead of
626 copy/pasting the code. The old code for one was not using
627 GnomeVFS. This allows use of smb:// URLs when using send-as
628 from external applications, fixing bug NB#63741.
630 (modest_msg_edit_window_insert_image),
631 (modest_msg_edit_window_add_attachment_clicked):
632 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
633 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
634 Adapted to the new function names.
636 2007-07-25 Murray Cumming <murrayc@murrayc.com>
638 (modest_platform_set_update_interval): Set the alarm recurrence
639 fields so that auto-update does not just happen the first time.
640 This should have fixed projects.maemo.org bug NB#63938.
642 When this happens you can see a printf when the D-Bus method is
644 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
646 However, I do not actually seem to get new POP messages even when
647 clicking the refresh button manually. A restart gets them.
648 This might be a problem in today's tinymail only.
650 2007-07-24 Murray Cumming <murrayc@murrayc.com>
652 * src/maemo/modest-maemo-global-settings-dialog.c:
653 (current_connection):
654 Avoid a crash (probably only in scratchbox) when strcmp()ing a
655 NULL when closing the dialog.
657 2007-07-24 Murray Cumming <murrayc@murrayc.com>
659 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
660 Remove the hacky send/receive that didn't work, and instead
661 refilter the treemodel to make the deleted email really vanish from
662 the UI (though the delete-from-menu code does has commented out
663 the code that does that). This fixes projects.maemo.org bug
666 2007-07-24 Murray Cumming <murrayc@murrayc.com>
668 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
669 Try a couple of tricks to force the treeview to update (
670 poke the folder, and do a send/receive refresh), but the deleted
671 email still appears with a strike-through instead of really being
674 2007-07-23 Murray Cumming <murrayc@murrayc.com>
676 * src/dbus_api/modest-dbus-callbacks.c:
677 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
678 because their ID is not human-readable (see the comment about
679 improvements needed to the osso-email-interface API) and
680 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
682 2007-07-23 Murray Cumming <murrayc@murrayc.com>
684 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
685 (add_folders_to_list), (on_dbus_method_get_folders),
686 (modest_dbus_req_filter):
687 * src/maemo/modest-maemo-utils.c:
688 (on_camel_account_get_supported_secure_authentication):
689 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
690 (on_header_view_focus_in):
691 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
692 * src/modest-formatter.c: (modest_formatter_create_body_part):
693 * src/modest-mail-operation.c: (recurse_folders),
694 (update_account_thread), (get_msgs_full_thread),
695 (modest_mail_operation_get_msgs_full),
696 (modest_mail_operation_xfer_msgs):
697 * src/modest-search.c: (search_mime_part_and_child_parts),
698 (modest_search_account), (modest_search_all_accounts):
699 * src/modest-tny-account.c:
700 (modest_tny_account_get_special_folder), (recurse_folders):
701 * src/modest-tny-local-folders-account.c:
702 (modest_tny_local_folders_account_query_passes):
703 * src/modest-tny-msg.c: (copy_mime_part),
704 (modest_tny_msg_find_body_part_from_mime_part):
705 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
706 (modest_tny_send_queue_try_to_send):
707 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
708 (_modest_ui_actions_open), (download_uncached_messages),
709 (reply_forward), (modest_ui_actions_on_copy),
710 (modest_ui_actions_on_details), (has_retrieved_msgs),
711 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
713 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
714 (_selected_msg_marked_as), (_msg_download_completed),
715 (_selected_msg_sent_in_progress):
716 * src/widgets/modest-attachments-view.c:
717 (modest_attachments_view_set_message):
718 * src/widgets/modest-msg-view.c: (find_cid_image):
719 * tests/check_folder-transfer.c: (find_folders):
720 * tests/check_update-account.c: (func):
721 * tests/dbus_api/test_get_folders.c: (main):
722 Checked all uses of tny_iterator_get_current(), making sure
723 that the object is unreferenced (3 or 4 places did not),
724 and adding checks for NULL.
726 2007-07-23 Murray Cumming <murrayc@murrayc.com>
728 * src/dbus_api/modest-dbus-callbacks.c:
729 (on_idle_open_default_inbox): Make sure that the application UI is
731 * src/maemo/easysetup/modest-easysetup-wizard.c:
732 (on_entry_invalid_character): Show the word whitespace instead
733 of (null) in the banner when whitespace was entered.
734 (show_error): Add a comment that this does not work in
735 Maemo Bora, though we do not know why.
737 2007-07-23 Murray Cumming <murrayc@murrayc.com>
739 * src/modest-tny-account.c:
740 (modest_tny_account_get_special_folder): Use an if instead of
741 an assert for when the parent account name is NULL, because this
742 might be causing a crash in projects.maemo.org bug 63192.
743 * src/modest-mail-operation.c:
744 (modest_mail_operation_send_new_mail_cb),
745 (modest_mail_operation_remove_folder): unref the folder that is
746 returned from modest_tny_account_get_special_folder().
748 2007-07-23 Murray Cumming <murrayc@murrayc.com>
750 * src/modest-ui-actions.c:
751 (modest_ui_actions_on_password_requested):
752 Show mail_ib_login_cancelled info banner when the user cancels
753 the protected password dialog, to fix projects.maemo.org
756 2007-07-23 Murray Cumming <murrayc@murrayc.com>
758 * src/maemo/modest-account-settings-dialog.c:
759 (create_page_outgoing): Put this page in a GtkScrolledWindow,
760 matching the UI mock-up in the UI spec, and allowing access
761 to all widgets even when the on-screen keyboard is active.
763 2007-07-23 Murray Cumming <murrayc@murrayc.com>
765 Reverted this previous commit from Johannes,
766 because the scrollbars are always visible and because
767 I think we only need it on onepage of the account
768 settings, not the account wizard.
769 (I wrote the wrong instructions in the bug.)
771 * src/maemo/easysetup/modest-easysetup-wizard.c:
772 Added scrollbars to account wizard dialog.
773 Fixed projects.maemo.org NB #62744
775 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
777 * src/maemo/easysetup/modest-easysetup-wizard.c:
778 (create_page_user_details):
779 Use auto-cap for name (projects.maemo.org NB#63716)
780 * src/widgets/modest-account-view.c: (on_account_busy_changed):
782 2007-07-22 Armin Burgmeier <armin@openismus.com>
784 * src/maemo/modest-ui-actions.c: Use current account instead of
785 default account for creating viewer windows, so that the viewer
786 window knows to which account the viewed message belongs.
788 * src/maemo/modest-msg-view-window.c: Destroy the window when the
789 corresponding account is deleted. This fixes projects.maemo.org bug
792 2007-07-18 Armin Burgmeier <armin@openismus.com>
794 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
795 the dialog close after entering an invalid port number and clicking
796 OK. This fixes projects.maemo.org bug NB#63602.
798 2007-07-18 Armin Burgmeier <armin@openismus.com>
800 * src/modest-tny-account-store.c:
801 (get_server_accounts): Set parent modest account name for each
802 connection-specific transport account so that special folders of such
803 an account can be looked up. This fixes a crash when changing account
804 settings. This might also be related to projects.maemo.org bug
807 2007-07-16 Armin Burgmeier <armin@openismus.com>
809 * src/modest-ui-actions.c: Added a button to create a folder to the
810 move-to dialog. This fixes projects.maemo.org bug NB#59863.
812 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
814 * src/maemo/easysetup/modest-easysetup-wizard.c:
815 Added scrollbars to account wizard dialog.
816 Fixed projects.maemo.org NB #62744
818 2007-07-16 Murray Cumming <murrayc@murrayc.com>
820 * src/widgets/modest-msg-view.h:
821 * src/widgets/modest-msg-view.c:
822 Added modest_msg_view_get_message_is_empty() but this needs
824 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
825 Check if there is any text in the message yet.
826 But this needs to be implemented properly.
827 (modest_msg_edit_window_toggle_find_toolbar):
828 * src/maemo/modest-msg-view-window.c:
829 (modest_msg_view_window_toggle_find_toolbar):
830 Show a banner warning if there is no text to search, when
831 trying to start a search. This partially fixes
832 projects.maemo.org bug NB#62350.
834 2007-07-13 Murray Cumming <murrayc@murrayc.com>
836 * src/modest-mail-operation.c: (update_account_thread):
837 Initialized num_new_headers to fix the build.
839 2007-07-13 Murray Cumming <murrayc@murrayc.com>
841 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
842 Ignore modest accounts whose server accounts don't exist in gconf.
843 This prevents us trying to create TnyAccount instances for those
844 server accounts when the server account has been removed from gconf,
845 but the parent modest account has not yet been removed from modest.
846 I don't know why this is only noticeable now. It was probably just
847 a harmeless g_warning() anyway.
849 2007-07-13 Murray Cumming <murrayc@murrayc.com>
851 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
852 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
854 2007-07-12 Armin Burgmeier <armin@openismus.com>
856 * src/maemo/modest-main-window.c: Make default account appear bold
857 in view, tools/send & receive and toolbar/send & receive SCM menus.
858 This fixes projects.maemo.org bug NB#59010.
860 2007-07-12 Murray Cumming <murrayc@murrayc.com>
862 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
863 Add a short-cut, by checking if the folder store is an account.
864 This ensures that the Sort menu item and toolbar is dimmed for
865 the local-folders account root item, fixing
866 projects.maemo.org bug NB#62545.
868 2007-07-12 Murray Cumming <murrayc@murrayc.com>
870 * src/modest-tny-account-store.c: (get_password):
871 Show the password dialog (via the signal) only in the mainloop, via
872 an idle handler that we wait for. This could theoretically prevent
873 hangs, though I worry that it could introduce some too.
875 2007-07-12 Murray Cumming <murrayc@murrayc.com>
877 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
878 * src/maemo/modest-platform.c:
879 (modest_platform_connect_and_wait):
880 Take a TnyAccount* parameter and try to set it to online
881 (a TnyCamel-only API), because tinymail sets accounts to offline
882 when the user cancels a password dialog, and doesn't ask again until
883 it has been set to online.
884 However, this is commented out because it causes a hang now.
886 (modest_platform_connect_and_wait_if_network_account):
887 * src/modest-mail-operation.c:
888 (modest_mail_operation_update_account):
889 * src/modest-platform.h:
890 * src/modest-ui-actions.c: (_modest_ui_actions_open),
891 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
893 2007-07-12 Armin Burgmeier <armin@openismus.com>
895 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
897 * src/modest-mail-operation.c:
898 * src/modest-ui-actions.c: Check for already existing folder before
899 querying the server, show error message from camel if the request
900 still fails. This fixes projects.maemo.org bug NB#58701.
902 2007-07-12 Murray Cumming <murrayc@murrayc.com>
904 * src/modest-tny-account-store.h:
905 * src/modest-tny-account-store.c:
906 Added modest_tny_account_store_forget_password_in_memory(),
907 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
908 when creating a new account, so that new passwords will be used, instead of
909 us thinking that it's a second request as a result of a failed password again.
911 2007-07-12 Murray Cumming <murrayc@murrayc.com>
913 * src/dbus_api/modest-dbus-callbacks.c:
914 (on_idle_open_message): If the message is in drafts then open it
915 in an edit window instead of a view window. This fixes
916 projects.maemo.org bug NB#63005.
918 2007-07-12 Murray Cumming <murrayc@murrayc.com>
920 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
921 Avoided a harmless g_warning().
923 2007-07-12 Murray Cumming <murrayc@murrayc.com>
925 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
926 Pass the modest account name, not the TnyAccount display name to
927 modest_msg_view_window_new() so that the reply feature works,
928 fixing projects.maemo.org bug NB#62892.
930 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
931 (modest_msg_view_window_new_with_header_model):
932 * src/maemo/modest-msg-view-window.c:
933 (modest_msg_view_window_new_with_header_model),
934 (modest_msg_view_window_new):
935 * src/modest-ui-actions.c: (reply_forward):
936 * src/widgets/modest-msg-view-window.h:
937 * src/widgets/modest-window.c: (modest_window_set_active_account):
938 Rename an account parameter to modest_account_name to make this clearer.
940 2007-07-11 Murray Cumming <murrayc@murrayc.com>
942 * src/modest-ui-actions.h:
943 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
944 modest_do_message_delete().
945 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
946 Call modest_do_message_delete(), hoping that this would cause messages
947 to be really deleted from search instead of just marked with strike through.
948 Does not seem to help.
950 2007-07-11 Armin Burgmeier <armin@openismus.com>
952 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
953 priv->reselect to FALSE prior to calling
954 modest_folder_view_select_first_inbox_or_local() to prevent endless
955 recursion and thus a crash on startup.
957 2007-07-11 Armin Burgmeier <armin@openismus.com>
959 * src/maemo/modest-account-settings-dialog.h: Include
960 <gtk/gtknotebook.h> to fix the build (at least for me).
962 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
963 Use "New FolderN" as default suggested name if "New folder" already
964 exists, with N being the first free number, though never exceed "New
965 folder99" in which case we just fall back to "New Folder" even though
966 it already exists. This fixes projects.maemo.org bug NB#58663.
968 2007-07-11 Murray Cumming <murrayc@murrayc.com>
970 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
971 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
972 projects.maemo.org bug NB#62778.
974 2007-07-11 Murray Cumming <murrayc@murrayc.com>
976 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
977 Ignore the wrong (for now) secure-smtp setting in the presets -
978 just default to requiring secure authentication for SMTP, because
981 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
983 * src/widgets/modest-folder-view.c: (filter_row)
984 Do not show drafts folder (see UI specs)
986 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
988 * src/modest-ui-actions.c:
989 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
990 place and also not necessary.
992 * src/widgets/modest-folder-view.c: (filter_row)
993 Guess folder type and hide Sent & Outbox if necessary.
994 Fixed project.maemo.org NB#57328
996 2007-07-11 Murray Cumming <murrayc@murrayc.com>
998 * src/modest-ui-actions.h:
999 * src/modest-ui-actions.c:
1000 (modest_ui_actions_on_delete_message):
1001 Move some code into a new
1002 modest_ui_actions_refresh_message_window_after_delete()
1003 function so we can use it from elsewhere.
1005 * src/dbus_api/modest-dbus-callbacks.c:
1006 (on_idle_delete_message), (on_delete_message): Used an idle
1007 handler, as we do for the other D-Bus method handlers.
1008 Call modest_ui_actions_refresh_message_window_after_delete()
1009 if the deleted message was open in a window. This fixed
1010 projects.maemo.org bug NB#62862.
1012 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1014 * src/modest-main.c: (main): Only show the UI at the start if
1015 the showui command line option was given. For instance,
1016 run-standalone src/modest showui
1017 Otherwise, we wait for the top_application D-Bus method to
1018 be sent by hildon-desktop when the application is selected
1020 This allows us to run without a UI when osso-global-search
1021 uses our D-Bus methods.
1023 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1025 * src/dbus_api/modest-dbus-api.h: Added a define for a
1026 top-application D-Bus method.
1027 * src/dbus_api/modest-dbus-callbacks.c:
1028 (on_top_application),
1029 (modest_dbus_req_handler): Handle the top-application D-Bus
1030 method, which might be an undocumented D-Bus signal sent by
1031 hildon-desktop when it starts the application from the menu.
1032 But I am not sure and I need to test it on the device, because
1033 my scratchbox does not have the application in the menu now.
1034 This method shows the main window, so that it can be invisible
1035 when started, for instance, just for email searching from
1038 * src/maemo/modest-main-window.c: (restore_settings),
1039 (modest_main_window_new): Do not show the window immediately
1040 upon creation. We show it later.
1041 * src/modest-widget-memory.c: (save_settings_paned):
1042 Try (unsuccessfully) to avoid saving the paned position when
1043 it is not even visible.
1044 (restore_settings_paned): Do not allow a silly paned position.
1045 This seems necessary when not showing the window at first.
1047 * tests/dbus_api/Makefile.am:
1048 * tests/dbus_api/test_top_application.c: (main): Test for the
1051 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1053 * src/modest-ui-dimming-rules.c:
1054 (modest_ui_dimming_rules_on_new_msg),
1055 (modest_ui_dimming_rules_on_reply_msg),
1056 (modest_ui_dimming_rules_on_delete_msg),
1057 (modest_ui_dimming_rules_on_details),
1058 (modest_ui_dimming_rules_on_view_window_move_to),
1059 (modest_ui_dimming_rules_on_view_previous),
1060 (modest_ui_dimming_rules_on_view_next),
1061 (_invalid_folder_for_purge): Added checks before
1062 casting the window. This looks like an actual
1063 logic error in _invalid_folder_for_purge(), because it
1064 tries to use a ModestMainWindow as a message window.
1066 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1068 * src/maemo/modest-account-settings-dialog.c:
1069 (show_error): Use the same implementation as in
1070 modest-easysetup-wizard.c:
1071 (on_entry_invalid_character): The logical ID contains a %s.
1072 Guessed what it should be.
1073 (on_entry_max), (check_data), (on_response): Adapt to
1074 changed show_error().
1075 (create_page_account_details): Really call
1076 modest_validating_entry_set_func() on the correct widgets.
1077 * src/maemo/easysetup/modest-easysetup-wizard.c:
1078 (on_entry_invalid_character): Fix the logical ID here too.
1079 (create_page_account_details),
1080 (create_page_user_details):
1082 modest_validating_entry_set_func() on the correct widgets.
1084 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1085 Do not try to use the account if it is NULL.
1087 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1089 * src/modest-ui-actions.c: (create_move_to_dialog),
1090 (modest_ui_actions_on_main_window_move_to),
1091 (modest_ui_actions_on_msg_view_window_move_to):
1092 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1093 (filter_row), (modest_folder_view_show_non_move_folders):
1094 * src/widgets/modest-folder-view.h:
1096 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1097 the Sent folder yet as it does not report the correct folder type.
1099 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1101 * src/maemo/modest-msg-edit-window.c: (init_window):
1104 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1107 Take a parent widget instead of a parent window, and
1108 implement this with hildon_banner_show_information() instead.
1109 Non-Maemo builds can just ifdef that there.
1110 This fixed projects.maemo.org bug NB#62766.
1112 (on_entry_invalid_character): Use show_error() again instead
1113 of using hildon directly, and use the _CS() macro to use the correct
1115 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1116 Pass a widget instead od a window to show_error().
1118 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1120 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1121 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1122 This allows us to show the server name in the error message, fixing
1123 projects.maemo.org bug NB#62904.
1124 Also, use the appropriate logical ID message for the account protocol.
1126 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1128 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1129 A compilation fix, though the build wasn't broken for me.
1131 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1133 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1134 Do not try to unref a NULL folder store, to avoid a runtime warning.
1135 This seems to happen sometimes when changing accounts settings.
1137 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-tny-account-store.c:
1140 (modest_tny_account_store_instance_init),
1141 (modest_tny_account_store_finalize),
1142 (on_account_settings_hide), (on_idle_wrong_password):
1143 Use a GHashTable to ensure that we only show one account settings
1144 dialog per modest account. This avoids us having a dialog open for
1145 both the store and transport accounts, or due to repeated get_password()
1146 calls that shouldn't happen anyway.
1148 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1150 * src/maemo/modest-maemo-utils.c: (on_hide),
1151 (modest_maemo_show_dialog_and_forget): Handle the response, because
1152 the window is not even hidden by default.
1154 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1155 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1156 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1157 which seems to prevent some modality problems.
1159 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1160 Ignore user cancellation errors.
1162 * src/modest-account-mgr-helpers.h:
1163 * src/modest-account-mgr-helpers.c:
1164 Added modest_server_account_get_password() and
1165 modest_server_account_get_has_password() to avoid direct use of
1168 * src/maemo/modest-account-settings-dialog.h:
1169 * src/maemo/modest-account-settings-dialog.c:
1170 (modest_account_settings_dialog_init): Store the notebook so we can
1172 Added modest_account_settings_dialog_switch_to_user_info().
1174 * src/modest-tny-account-store.c:
1175 (get_password): When the password in the account settings is wrong (we think),
1176 show the relevant page of the account settings dialog, in the mainloop.
1177 However, we currently get many of these at once because cancel does not
1179 (forget_password): Do not forget the password
1180 from the account settings, because this causes side-effects when
1181 tinymail seems to call it at strange time, maybe because of how we
1182 are cancelling get_password().
1183 (modest_tny_account_store_alert): Ignore user cancellations.
1185 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1187 * src/maemo/modest-maemo-utils.h:
1188 * src/maemo/modest-maemo-utils.c:
1189 Added modest_maemo_show_information_note_and_forget() for use instead of
1190 gtk_dialog_run() when the response is not needed, to avoid an extra
1191 mainloop which could cause a hang.
1193 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1194 Use the logical IDs for the error message, though they are not
1195 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1196 because gtk_dialog_run() caused a hang here (the window did not close).
1197 This fixes projects.maemo.org bug NB#62646.
1199 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1201 * src/modest-account-mgr-helpers.h:
1202 * src/modest-account-mgr-helpers.c:
1203 Added modest_account_mgr_get_store_protocol().
1205 * src/maemo/modest-account-view-window.c:
1206 (on_delete_button_clicked): Show different warning text depending on
1207 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1208 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1211 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1213 * src/maemo/modest-msg-edit-window.c:
1214 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1215 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1217 2007-07-07 Armin Burgmeier <armin@openismus.com>
1219 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1220 ckdg_ib_maximum_characters_reached from correct package.
1222 * src/modest-ui-actions.c: Show an error message when a folder could
1223 not be created. Tinymail does not give us specific error codes about
1224 what has gone wrong, so we assume that a folder with that name
1225 already exists, though there might be other reasons.
1227 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1230 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1231 give a more exact error message that can be partly translated.
1233 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1235 * src/maemo/modest-address-book.c:
1236 (select_email_addrs_for_contact): Specify a default window size for the
1237 select-email-address dialog, so that it is probably big enough for the
1238 title. This should fix projects.maemo.org bug NB#62277.
1240 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1242 * src/maemo/easysetup/modest-easysetup-wizard.c:
1243 (create_page_complete_easysetup): Use
1244 gtk_widget_set_size() request to ensure that the text wraps
1247 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1249 * src/maemo/easysetup/modest-easysetup-wizard.c:
1250 (on_entry_invalid_character), (create_page_account_details),
1251 (create_page_user_details):
1252 Use new API of ModestValidatingEntry. But for some reason the banner is
1253 not shown. I will have to investigate that further.
1255 * src/widgets/modest-validating-entry.c: (on_insert_text),
1256 (modest_validating_entry_set_func):
1257 * src/widgets/modest-validating-entry.h:
1258 Added a new callback function to be able to react to prevented
1259 characters whitespaces to e.g show a banner.
1261 2007-07-05 Armin Burgmeier <armin@openismus.com>
1263 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1264 notification of HildonNumberEditor instead of remembering the port
1265 number. Thanks to Johannes for pointing this out.
1267 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1269 * src/maemo/easysetup/modest-easysetup-wizard.c:
1270 Check if there are any user changes before showing a confirmation
1271 dialog (projects.maemo.org NB#60946)
1273 2007-07-05 Armin Burgmeier <armin@openismus.com>
1275 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1276 number at the beginning of the dialog and set the modified flag at the
1277 end if the port number has changed. This is necessary because
1278 HildonNumberEditor does not support notification when the value has
1281 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1283 * src/modest-ui-actions.c:
1284 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1285 a connection before asking anything else. Correct the check for the destination
1286 folder so that it succeeds when online.
1287 This fixed projects.maemo.org bug NB#61645.
1289 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1291 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1292 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1293 to fix projects.maemo.org bug NB#62439.
1295 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1297 * src/modest-tny-account.c: (on_connection_status_changed):
1298 Really do not use tny_device_force_offline() here. See the previous comment.
1300 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-tny-account.c: (on_connection_status_changed):
1303 Do not use tny_device_force_offline() when tinymail says that something
1304 went wrong with the connection. It seems to report this unnecessarily.
1306 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1308 * src/maemo/modest-connection-specific-smtp-window.c:
1309 (modest_connection_specific_smtp_window_init):
1310 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1311 does not seem to have any effect in osso 1.1 (though it works in
1312 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1314 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1316 * src/maemo/modest-connection-specific-smtp-window.c:
1317 Fix UI specification problems with projects.meamo.org NB#60479
1319 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1321 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1322 clue when this has failed, because the error dialog is not always shown
1323 (at least in earlier version).
1325 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1326 GError message, because the generic error dialog is not helpful.
1328 'This message is not currently available (can't let a new connection go online)'
1329 when trying to open an IMAP message.
1331 (_modest_ui_actions_open): Offer a connection when some messages would
1332 have to be downloaded and we are offline.
1334 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1336 * src/widgets/modest-folder-view.c:
1337 Don't check for MERGE type anymore as we use the correct type
1339 NOTE: For the last two changes you need to update your tinymail copy
1340 because of API changes!
1342 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1344 * src/modest-tny-local-folders-account.c:
1345 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1346 (see projects.maemo.org NB#61580)
1348 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1350 * src/modest-tny-account.c: (on_connection_status_changed):
1351 Commented out the call to modest_platform_connect_and_wait() because this
1352 seems to always hang, and I would like to know if this is the only thing
1353 that causes a hang when showing the connection dialog.
1354 It is not very useful anyway.
1356 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1358 * src/maemo/modest-msg-view-window.c:
1359 (modest_msg_view_window_select_next_message):
1361 * src/modest-platform.h:
1362 * src/maemo/modest-platform.c:
1363 Added modest_platform_connect_and_wait(), which calls
1364 tny_maemo_conic_device_connect() always in the main thread, by calling it
1365 in an idle handler and waiting for the idle handler to run. It should be
1366 in the main thread because it uses GTK+ UI code. It just returns TRUE
1367 if the device is already online.
1369 There is some nasty code to ensure that subsequent calls to
1370 modest_platform_connect_and_wait() just wait for the first one to finish,
1371 by checking repeatedly in another idle handler. This is necessary,
1372 because other threads (or even the main thread, via another idle handler)
1373 can call modest_platform_connect_and_wait() while
1374 modest_platform_connect_and_wait() is running.
1376 (modest_platform_connect_and_wait_if_network_account),
1377 (modest_platform_connect_and_wait_if_network_folderstore):
1378 Convenience functions that calls modest_platform_connect_and_wait() if
1379 the account or folder might want network access.
1381 * src/modest-mail-operation.c:
1382 (modest_mail_operation_update_account):
1383 * src/modest-ui-actions.c: (download_uncached_messages),
1384 (modest_ui_actions_on_rename_folder), (delete_folder),
1385 (modest_ui_actions_on_main_window_move_to),
1386 (modest_ui_actions_on_msg_view_window_move_to):
1387 * src/widgets/modest-folder-view.c:
1388 (drag_and_drop_from_folder_view):
1389 Offer a connection if we are offline.
1391 * src/modest-tny-account.c: (on_connection_status_changed):
1392 Document this as only handling errors during network operations in progress,
1393 and replace the idle code with a simple call to
1394 modest_platform_connect_and_wait(), which does this instead.
1396 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1398 * src/modest-tny-account.c:
1399 (modest_tny_account_get_special_folder): (util_on_idle),
1400 Handle the GError so we can see when tny_folder_store_get_folders()
1401 fails, as it currently does while something else is connecting.
1403 Added util_run_in_main_thread_and_wait()
1404 which uses an idlen handler and mainloop to ensure that the function
1405 is called in the main thread.
1406 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1407 to make sure that we call attempt the connection in the mainloop only,
1408 which might solve some hangs.
1410 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1412 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1413 be found by their display name. This is never useful.
1414 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1415 by its ID, instead of trying to use its ID as its display name.
1417 * src/modest-tny-account-store.h:
1418 * src/modest-tny-account.c:
1419 (modest_tny_account_get_special_folder): Add a g_warning() when
1420 tny_folder_store_get_folders() returns an empty list for the maildir.
1422 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1423 Add a g_warning() when this returns NULL, because that it not allowed
1426 2007-07-02 Armin Burgmeier <armin@openismus.com>
1428 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1429 note when trying to cancel the wizard. This fixes projects.maemo.org
1432 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1434 * src/modest-tny-account.h:
1435 * src/modest-tny-account.c:
1436 (modest_tny_account_new_from_server_account),
1437 (modest_tny_account_new_from_server_account_name),
1438 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1439 because this must now be set before setting the proto. This is usd in
1440 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1441 warning in camel_session_get_service() caused by
1442 tny_camel_transport_account_prepare().
1444 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1447 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1449 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1451 (modest_connection_specific_smtp_edit_window_init):
1453 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1454 of "changed" for now
1456 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1458 * src/modest-tny-account.c:
1459 (modest_tny_account_new_from_server_account):
1460 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1461 now uses to request a connection when it needs one, and which it uses
1462 to tell us that something is wrong with the connection, so we can force
1463 the accounts offline to prevent further problems.
1465 * src/modest-defs.h:
1466 * src/modest-init.c: (init_default_settings):
1467 * src/modest-mail-operation.c:
1468 (modest_mail_operation_update_account):
1469 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1470 This should not be necessary anymore. Do not set the conf key that
1471 determined this (it was always TRUE and not set anywhere else).
1473 * src/modest-ui-actions.h: Remove unused and unimplemented
1474 modest_ui_actions_on_online_toggle_toggled().
1476 2007-06-29 Murray Cumming <murrayc@murrayc.com
1478 * src/maemo/modest-main-window.c: (connect_signals):
1479 Don't connect to delete_event twice. Maybe this was harmless.
1481 2007-06-29 Murray Cumming <murrayc@murrayc.com
1483 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1484 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1485 Debug output to give some more clue when a folder move is not allowed.
1487 2007-06-28 Murray Cumming <murrayc@murrayc.com
1489 * src/modest-tny-account.c: (on_modest_file_system_info),
1490 (modest_tny_account_get_mmc_account_name):
1491 Always call the callback, without checking whether the name has changed.
1492 * src/widgets/modest-folder-view.c: (strings_are_equal),
1493 (on_model_foreach_set_name), (on_get_mmc_account_name),
1494 (text_cell_data): Compare the name here, and use the name from
1495 the account rather than from the
1496 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1497 if the name was changed after the account was added to the model.
1498 That's a tinymail bug but not one that I want to fix now.
1500 This finally fixes projects.maemo.org bug NB#59301.
1502 2007-06-27 Armin Burgmeier <armin@openismus.com>
1504 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1507 2007-06-27 Murray Cumming <murrayc@murrayc.com
1509 * src/modest-tny-account.h:
1510 * src/modest-tny-account.c:
1511 Added modest_tny_account_get_mmc_account_name(), to set the memory
1512 card name asynchronously for the given account and then notify.
1513 (modest_tny_account_new_for_local_folders): Use this new function instead
1514 of using hildon_file_system_info_async_new() directly.
1516 * src/widgets/modest-folder-view.c: (text_cell_data):
1517 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1518 gtk_tree_model_row_changed() when it is available.
1520 This should fix projects.maemo.org bug NB#59301.
1522 2007-06-27 Murray Cumming <murrayc@murrayc.com
1524 * src/modest-mail-operation.c: (update_account_thread),
1525 (get_msgs_full_thread): Fix typo failures in the revert
1528 2007-06-27 Murray Cumming <murrayc@murrayc.com
1530 * src/maemo/modest-maemo-global-settings-dialog.c:
1531 (idle_select_default_focus):
1532 * src/modest-mail-operation.c: (idle_notify_progress),
1533 (idle_notify_progress_once), (set_last_updated_idle),
1534 (update_account_thread), (get_msgs_full_thread):
1535 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1536 * src/widgets/modest-header-view.c:
1537 (idle_notify_headers_count_changed_destroy),
1538 (idle_notify_headers_count_changed):
1539 Reverted the additions of gdk_threads_enter/leave(), in case this
1540 helps with a startup hang on the device.
1542 2007-06-26 Armin Burgmeier <armin@openismus.com>
1544 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1545 for supported secure authentication methods from server by
1546 gtk_dialog_run(), saving CPU time and a potential race condition.
1548 2007-06-26 Armin Burgmeier <armin@openismus.com>
1550 * src/maemo/modest-maemo-utils.h:
1551 * src/maemo/modest-maemo-utils.c: Added a
1552 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1553 only error code to tell the calling code when the user canceled the
1556 * src/maemo/modest-account-settings-dialog.h:
1557 * src/maemo/modest-account-settings-dialog.c:
1558 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1559 message if the retrieval of secure authentication methods was canceled
1560 by the user. Perform the check before saving anything to configuration
1561 to not end up with half-committed configuration changes, do not show
1562 a "Saving to configuration failed" note when authentication methods
1563 could not be retrieved.
1565 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1568 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1570 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1571 Only return the first level of folders under accounts, because the
1572 osso-global-search UI spec doesn't want the rest.
1573 This fixed projects.maemo.org bug NB#61811.
1575 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-tny-account-store.c:
1578 * src/modest-tny-account-store.h:
1579 Added modest_tny_account_is_memory_card_account().
1580 * src/maemo/modest-main-window.c: (create_details_widget):
1581 Show the same information items for the memory card as we show for the
1582 local-folders, to fix projects.maemo.org bug NB#59307.
1584 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-tny-account-store.c: (get_password):
1587 Added some checks for NULL to maybe prevent crashes, though I think
1588 it was Philip's last commit that actually prevented the crash here
1589 when creating a first new account.
1590 But the new account is still not usable (no messages are shown)
1591 until a restart of the application.
1593 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1595 * src/maemo/modest-maemo-global-settings-dialog.c:
1596 (idle_select_default_focus):
1597 * src/modest-mail-operation.c: (idle_notify_progress),
1598 (idle_notify_progress_once), (idle_notify_update_account_queue),
1599 (set_last_updated_idle), (update_account_thread),
1600 (notify_get_msgs_full), (get_msgs_full_destroyer),
1601 (get_msgs_full_thread):
1602 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1603 * src/widgets/modest-header-view.c:
1604 (idle_notify_headers_count_changed_destroy),
1605 (idle_notify_headers_count_changed):
1606 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1607 all idle handlers, because some other thread could be blocking
1608 the GDK lock, so that it can do GUI stuff.
1610 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1612 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1613 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1614 (on_idle_send_receive), (on_idle_open_default_inbox):
1615 * src/maemo/modest-msg-edit-window.c:
1616 (modest_msg_edit_window_attach_file_noninteractive):
1617 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1618 to prevent a hang. I don't quite understand why these are necessary,
1619 beause we should already be in the main loop. I guess something outside
1620 of the main loop is taking the lock.
1622 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1623 we are really using URIs, and use files that are more likely to exist.
1625 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1627 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1628 necessary because configure.ac now defines different variables.
1630 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1632 * libmodest-dbus-client/libmodest-dbus-client.c:
1633 * libmodest-dbus-client/libmodest-dbus-client.h:
1634 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1635 libmodest_dbus_client_compose_mail() is what things actually use.
1637 * src/dbus_api/modest-dbus-api.h:
1638 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1639 * tests/dbus_api/Makefile.am:
1640 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1643 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1645 * src/modest-init.c: (modest_init_local_folders):
1646 For memory-card (or other non local-folders) maildir accounts,
1647 always create an Archive folder, so that there is somewhere to put
1648 messages. This should be less confusing, because the user does not need
1649 to guess that the need to create a folder.
1651 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1653 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1654 Fixed icon size by using (50, 50) which is the same as defined by
1657 2007-06-25 Armin Burgmeier <armin@openismus.com>
1659 * src/widgets/modest-window-mgr.c:
1660 * src/modest-init.c:
1661 * configure.ac: Correctly recognize hildon-notify presence and fixed
1662 the build without it being installed.
1664 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1666 * libmodest-dbus-client/libmodest-dbus-client.c:
1667 (libmodest_dbus_client_search): Fix the build. Sorry.
1668 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1669 (reply_forward_cb): Initialize variables to fix the build.
1671 * src/modest-tny-account-store.c:
1672 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1673 comparison (a silly typo) so that email search results can be opened
1674 when there are more than one account.
1676 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1678 * libmodest-dbus-client/libmodest-dbus-client.c:
1679 (libmodest_dbus_client_search),
1680 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1681 instead of 1 second, because the search gets folders and messages from
1682 the server, which can take a long time. When it times out,
1683 osso-global-search will report no results.
1685 We need to specify whether we should search only cached information
1686 (maybe with a user preference), and the osso-email-search-plugin
1687 API should really be improved to allow that option, and to allow results
1688 to be delivered asynchronously in batches.
1690 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1692 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1693 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1694 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1696 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1698 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1699 that is an empty string. D-Bus seems to give us these instead of NULL.
1701 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1703 * src/dbus_api/modest-dbus-callbacks.c:
1704 * src/maemo/easysetup/modest-easysetup-wizard.h:
1705 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1706 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1707 (modest_connection_specific_smtp_edit_window_init):
1708 * src/maemo/modest-maemo-global-settings-dialog.c:
1710 * src/maemo/modest-maemo-utils.c:
1711 (modest_maemo_utils_setup_images_filechooser):
1712 * src/maemo/modest-main-window.c: (create_details_widget):
1713 * src/maemo/modest-msg-edit-window.c:
1714 (modest_msg_edit_window_attach_file_noninteractive),
1715 (modest_msg_edit_window_color_button_change),
1716 (modest_msg_edit_window_set_zoom):
1717 * src/modest-mail-operation.c: (update_account_thread):
1718 * src/modest-tny-account-store.c:
1719 * src/modest-tny-account.c:
1720 * src/widgets/modest-global-settings-dialog.c:
1721 * src/widgets/modest-window.h:
1723 Fixed build on bora!
1725 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1727 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1728 * src/modest-search.c: (modest_search_folder),
1729 (modest_search_all_accounts): Actually search only in the specified folder,
1730 doing a simple match on the folder ID.
1731 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1732 and added some documentation.
1734 2007-06-22 Armin Burgmeier <armin@openismus.com>
1736 * src/maemo/modest-maemo-utils.h:
1737 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1738 modest_maemo_utils_get_supported_secure_authentication_methods.
1740 * src/maemo/easysetup/modest-easysetup-wizard.c:
1741 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1742 one occured, not just "Server does not support secure authentication".
1744 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1746 * src/modest-tny-account-store.c: (get_password):
1747 Restored the call to tny_account_set_user() because Philip seems to have
1748 stopped this from crashing (by not using the freed string). It still does
1749 not work, but now we can test it.
1751 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1753 * src/maemo/modest-msg-edit-window.c: (init_window):
1754 Comment out use of an uninitialzed GtkScrolledWindow variable,
1755 to fix the build and stop a crash. Yet again.
1757 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1759 * src/modest-tny-account-store.c: (get_password):
1760 Remove the call to tny_account_set_user() because this actually crashes.
1761 As mentioned in the last commit, it is known to not work anyway.
1763 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1765 * src/modest-tny-account-store.c: (get_password):
1766 Use tny_account_set_username() to tell tinymail that the username might
1767 have changed too. But tinymail ignores this: see projects.maemo.org
1769 * src/modest-ui-actions.c:
1770 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1771 reset the connection when changing the username, and improve the comments.
1772 Save the changed username to gconf at least, so it is used when Modest is
1775 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1777 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1778 Do not use a query, so that we get all folders, including for POP and
1779 local-folders. They work as search criteria too.
1780 This fixes projects.maemo.org bug NB#57740.
1782 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1784 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1785 Comment out the use of hildon_notification_set_sound() because it is
1786 not declared, to fix the build. Warnings are serious, people.
1788 2007-06-21 Armin Burgmeier <armin@openismus.com>
1790 * src/maemo/modest-maemo-utils.h:
1791 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1792 modest_maemo_utils_get_supported_secure_authentication_methods()
1793 to query authentication methods for a specific user. This should fix
1794 projects.maemo.org bug NB#61369.
1796 * src/maemo/easysetup/modest-easysetup-wizard.c:
1797 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1800 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1802 * libmodest-dbus-client/libmodest-dbus-client.h:
1803 * libmodest-dbus-client/libmodest-dbus-client.c:
1804 (modest_dbus_message_iter_get_search_hit),
1805 (libmodest_dbus_client_search):
1806 Reorganised and commented this.
1807 Removed modest_search_hit_free() from the public API because it
1810 Added libmodest_dbus_client_get_folders() and
1811 modest_folder_result_list_free().
1813 * src/dbus_api/modest-dbus-api.h:
1814 * src/dbus_api/modest-dbus-callbacks.c:
1815 (modest_dbus_req_filter): Commented. Moved most code to
1816 on_dbus_method_search() and added on_dbus_method_get_folders().
1818 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1819 of the extra D-Bus handler.
1821 * tests/dbus_api/Makefile.am:
1822 * tests/dbus_api/test_get_folders.c: New test for
1823 libmodest_dbus_client_get_folders(). This seems to return an empty list
1824 at the moment. That could be the same error that causes the message list
1825 to be empty sometimes.
1826 This should help with projects.maemo.org bug NB#57740.
1828 2007-06-21 Armin Burgmeier <armin@openismus.com>
1830 * src/modest-mail-operation.c: Do not call
1831 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1832 notify the operation's end after having set the status to CANCELED for
1833 the operation queue to listen on. This fixes a deadlock when there
1834 were mail operations in the queue during its finalization.
1836 * src/modest-singletons.c: Reordered uninitialization of the account
1837 manager to happen after the mail operation queue was uninitialized
1838 because the mail operation's in the queue might still try to access
1839 the account manager (see modest_mail_operation_notify_end()). This
1840 fixes a potential crash when terminating the application.
1842 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1844 * src/modest-search.c:
1845 (search_mime_part_and_child_parts): Moved some code here so we
1846 can search recursively in child folders.
1847 (modest_search_folder): Search in the message as a mime part, instead
1848 of just its child mime parts.
1849 (read_chunk), (search_mime_part_ogs):
1850 Check how many bytes were read, to prevent an endless loop.
1851 Searching in message bodies now works. This finishes the fix for
1852 projects.maemo.org bug NB#61007.
1854 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1856 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1857 Add a g_warning when the item is not a folder.
1859 * src/modest-ui-dimming-rules.c:
1860 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1861 when selected item is not a folder (for instance, an account), because
1862 the UI spec only talks about folders.
1863 I am not sure what the UI spec wants, so this might not totally fix
1864 projects.maemo.org bug NB#60794.
1866 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1868 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1869 (load_from_file): Sort the list. The unsorted list would be more noticeable
1870 in non-English locales.
1872 * src/maemo/modest-msg-edit-window.c:
1873 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1874 warning and fix the build.
1876 * src/maemo/modest-progress-bar-widget.c:
1877 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1878 avoid a g_warning, and probably to avoid a crash.
1880 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1882 * src/modest-search.c: (modest_search_folder): Check for a GError
1883 when calling tny_folder_get_headers(), to show that this is not the cause
1886 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1888 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1889 Actually set the body query instead of the subject query.
1891 * src/modest-search.c: (search_mime_part_ogs),
1892 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1893 which would probably cause it to fail if we got this far.
1895 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1896 to simplify the code.
1897 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1898 be causing search-in-body to fail.
1900 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1902 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1904 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1905 Better debug message when the folder cannot be found.
1906 This should help with fixing projects.maemo.org bug #61287.
1907 * src/modest-search.c: (add_hit): Do not leak the furl string.
1909 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1911 * src/modest-ui-actions.c:
1912 (modest_ui_actions_on_folder_selection_changed):
1913 Do not special-case TNY_MERGE_FOLDER here, because
1914 modest_tny_folder_get_account() already does that. This fixes
1915 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1916 shown when the Outbox was selected).
1918 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1920 * libmodest-dbus-client/libmodest-dbus-client.c:
1921 (_dbus_iter_get_string_or_null): Initialize the string variable in
1922 case this helps with Dirk's crash.
1924 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1926 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1927 though it is not implemented yet (this function is maybe not even used),
1928 to avoid breaking ABI in future.
1929 * libmodest-dbus-client/libmodest-dbus-client.c:
1930 (get_attachments_string): Moved some code into this generic function.
1931 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1932 sends email. It is maybe not used.
1933 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1934 (on_send_mail): Use attachments.
1936 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1937 * src/maemo/modest-msg-edit-window.c:
1938 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1939 a filename before using it, to fix projects.maemo.org bug NB#58233.
1941 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1943 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1944 Initialize the continue_download variable to fix the build, and probably
1945 to fix randome behaviour.
1947 2007-06-18 Armin Burgmeier <armin@openismus.com>
1949 * src/modest-tny-send-queue.h:
1950 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1951 the queue so we can later show it in the UI. Replaced
1952 modest_tny_send_queue_msg_is_being_sent() by
1953 modest_tny_send_queue_get_msg_status().
1955 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1957 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1958 gpointer. This probably was not harmful, but just to be sure.
1960 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1962 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1963 Fix the build, but leave the function broken on Bora, because
1964 hildon_uri_action_get_service() does not exist.
1965 osso_uri_action_get_service() does not exist either, it seems.
1967 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1969 * src/modest-tny-account.c:
1970 (modest_tny_account_new_from_server_account):
1971 Uncommented the url debug output again, because it is useful for
1972 debugging, as I said in the comment.
1974 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1976 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1978 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1979 for Mameo Bora, to fix the build.
1981 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1984 Fixed build with hildon < 0.99
1986 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1987 Check if the selected account is busy instead of checking all accounts
1989 * src/modest-account-mgr-priv.h:
1990 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1991 (modest_account_mgr_init), (compare_account_name),
1992 (modest_account_mgr_set_account_busy),
1993 (modest_account_mgr_account_is_busy):
1994 * src/modest-account-mgr.h:
1995 Added busy information to the account manager. It possible to
1996 set an account to busy or not busy now.
1998 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1999 (modest_mail_operation_update_account),
2000 (modest_mail_operation_notify_end):
2001 Set the account to busy/not busy depending on the operation state.
2003 * src/widgets/modest-account-view.c:
2004 (modest_account_view_finalize), (get_last_updated_string),
2005 (update_account_view), (on_account_busy_changed), (init_view):
2006 Show string "Refreshing..." if the account is currently busy.
2008 All this fixes projects.maemo.org bug NB#59711
2010 2007-06-14 Armin Burgmeier <armin@openismus.com>
2012 * src/widgets/modest-attachments-view.h:
2013 * src/widgets/modest-attachments-view.c: Added
2014 modest_attachments_view_has_attachments() and fixed coordinate
2015 transformation in get_att_view_at_coords(). This fixes attachment
2018 * src/widgets/modest-msg-view.c: Make use of
2019 modest_attachments_view_has_attachments() to decide whether to show
2020 attachments in the header.
2022 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
2024 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2025 (on_change), (on_combo_security_changed),
2026 (modest_connection_specific_smtp_edit_window_init),
2027 (modest_connection_specific_smtp_edit_window_set_connection),
2028 (modest_connection_specific_smtp_edit_window_is_dirty):
2029 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2030 * src/maemo/modest-connection-specific-smtp-window.c:
2033 Show an comfirmation dialog for the smpt-edit-window if there are
2034 unsaved changes and the user hits cancel.
2035 (projects.maemo.org bug NB#60479)
2037 2007-06-14 Armin Burgmeier <armin@openismus.com>
2039 * src/maemo/easysetup/modest-easysetup-wizard.c:
2040 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
2041 address" info in banner instead of node, and select all the text as
2042 per UI spec. This fixes projects.maemo.org bug NB#60550.
2044 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
2046 reviewed by: <delete if not using a buddy>
2048 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
2049 * src/modest-ui-actions.c: (folder_refreshed_cb):
2051 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2053 * src/widgets/modest-folder-view.c: (filter_row):
2054 Explictly filter out the per-account outbox accounts. I don't know why
2055 these only sometimes show up, but now they should never show up in the UI.
2056 This should fix projects.maemo.org bug NB#60160.
2058 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2060 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
2061 when the toolbar does not exist yet.
2062 * src/modest-widget-memory.c: (save_settings_header_view):
2063 Added g_warnings() to help us to discover when we are trying to set
2064 an empty columns list in gconf.
2066 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-init.h:
2069 * src/modest-init.c:
2070 Added modest_init_get_default_header_view_column_ids().
2072 * src/modest-widget-memory.c: (restore_settings_header_view):
2073 Use the new function to get defaults, if the gconf key is empty,
2074 instead of not creating any columns. This seems to fix the
2075 empty right-hand pane problems.
2077 * src/widgets/modest-header-view.h: Improved documentation.
2079 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2081 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2082 Revert the use of the display name as the account name, because this
2083 is generally wrong and would break the code that follows.
2085 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2087 * src/maemo/easysetup/modest-easysetup-wizard.c:
2088 (check_for_supported_auth_methods), (on_before_next),
2091 More correct fix for projects.maemo.org bug NB# 58991
2092 Do not longer accept AUTH_PASSWORD as secure method and choose
2093 correct method when creating the account.
2095 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2097 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2098 Fixed projects.maemo.org bug NB# 58991
2100 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2102 * src/modest-init.c: (modest_init_init_core),
2103 (modest_init_local_folders): Fixed compilation errors.
2105 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2107 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2108 Remove unnecessary lib/include, though it is good in principle when needed.
2110 * src/modest-init.c: (modest_init_one_local_folder),
2111 (modest_init_local_folders):
2112 * src/modest-init.h: Initialize the .modest library for memory cards,
2113 instead of just doing nothing for them. This should allow us to create
2114 folders there, fixing projects.maemo.org bug NB#59297.
2116 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2118 * libmodest-dbus-client/libmodest-dbus-client.c:
2119 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2120 (libmodest_dbus_client_compose_mail),
2121 (libmodest_dbus_client_open_message),
2122 (libmodest_dbus_client_send_and_receive),
2123 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2125 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2126 (on_idle_open_message), (modest_dbus_req_handler),
2127 (search_result_to_message), (modest_dbus_req_filter):
2128 * src/modest-search.c: (add_hit), (modest_search_folder),
2129 (modest_search_all_accounts): Improved debug messages.
2131 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2133 * src/modest-tny-account-store.c:
2134 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2137 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2140 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2142 * src/modest-tny-account-store.c: (get_server_accounts):
2143 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2144 even when there are no accounts, so that the Outbox folder is always
2145 visible. This fixes projects.maemo.org bug NB#60158.
2147 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2149 * src/maemo/modest-main-window.c: (create_details_widget):
2150 Use the mcen_va_never logical ID.
2152 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2154 * src/dbus_api/modest-dbus-api.h:
2155 * src/dbus_api/modest-dbus-callbacks.c:
2156 (on_idle_open_default_inbox), (on_open_default_inbox),
2157 (modest_dbus_req_handler):
2158 Added a new OpenDefaultInbox method.
2160 * libmodest-dbus-client/libmodest-dbus-client.h:
2161 * libmodest-dbus-client/libmodest-dbus-client.c:
2162 Added libmodest_dbus_client_open_default_inbox() to call the new
2163 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2164 though it should maybe be used by a new osso-email-interface function.
2166 * tests/dbus_api/Makefile.am:
2167 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2170 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2172 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2173 NULL, so that the signals get all the keys. This should not actually
2174 change any behaviour because we currently update everything when anything
2177 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2179 * src/widgets/modest-folder-view.c: (text_cell_data),
2180 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2181 (find_inbox_iter): If tinymail tells us that the folder is
2182 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2183 This causes the inbox to be selected at startup, fixing part of
2184 projects.maemo.org bug NB#56305.
2186 * src/modest-ui-dimming-rules.c:
2187 (modest_ui_dimming_rules_on_tools_smtp_servers):
2188 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2189 the SMTP servers menu item.
2190 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2191 that the SMTP Servers menu item is dimmed when there are no accounts,
2192 as a future version of the UI spec will require. This fixes
2193 projects.maemo.org bug NB#56305.
2195 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2197 * src/maemo/modest-maemo-utils.c:
2198 (modest_maemo_utils_get_supported_secure_authentication_methods):
2199 Added label to dialog instead of unreadable title
2201 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2202 (modest_main_window_new):
2203 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2206 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2207 * src/modest-account-mgr.h:
2208 Added method to avoid code duplication
2210 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2211 (modest_ui_actions_on_send_receive):
2212 Use modest_account_mgr_has_accounts
2214 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2216 * src/maemo/easysetup/modest-presets.c:
2217 (modest_presets_get_info_server_security): Do not report secure auth
2219 * src/modest-protocol-info.c: Use the defines for the gconf key names
2220 for secure authentication. This was not working because we were writing
2221 Password and reading password, and the check was case sensitive.
2222 With this, gmail now works for receiving and sending when created via
2225 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2227 * src/maemo/easysetup/modest-presets.c:
2228 (modest_presets_get_info_server_security): Correct the key name for
2229 SecureSmtp, because it seems to be case-sensitive.
2230 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2231 Do not try to get the 0th notebook page if there are 0 pages, to
2232 avoid a g_warning().
2234 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2236 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2237 Prevent use of the new notification feature for now, because it currently
2238 shows one dialog for each new email, which is annoying.
2240 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2242 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2243 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2244 when no country was selected, so that we show the global ones.
2245 * src/maemo/easysetup/modest-presets.c:
2246 (modest_presets_get_providers): Return only the global providers, not
2247 all providers when mmc=0 was requested.
2249 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2251 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2252 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2253 provider ID in the combo.
2255 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2256 Do not show the page numbers, because it would be confusing when we add
2257 the 2 extra pages for the custom setup, when the user chooses the "Other"
2258 provider. This fixes projects.maemo.org bug NB#59028
2260 * src/modest-init.c: (modest_init_init_core),
2261 (modest_init_local_folders):
2262 * src/modest-init.h:
2263 * src/modest-tny-account.c:
2264 (modest_tny_account_new_for_local_folders): Do not create default folders
2265 for the memory card. This should fix projects.maemo.org bug NB#59328.
2267 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2269 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2270 Free the changed_conf_keys string items. They are already freed in the
2271 idle handler if that runs first.
2273 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2275 * src/modest-ui-actions.c:
2276 (modest_ui_actions_on_password_requested): Check that the server name
2277 is not NULL, because I just saw a password dialog with (null) as the
2280 * src/modest-tny-folder.[h|c]: Added
2281 modest_tny_folder_is_memory_card_folder().
2282 * src/modest-ui-dimming-rules.c:
2283 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2284 menu item for memory cards, as per the UI spec (section 7.4). This should
2285 fix projects.maemo.org bug NB#59297.
2287 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2289 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2290 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2291 is another problem with the code, see Murray's comment at line 772)
2293 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2295 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2296 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2297 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2298 (load_from_file), (easysetup_country_combo_box_init),
2299 (easysetup_country_combo_box_get_active_country_ids),
2300 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2301 instead of just one ID, to avoid duplicate country names in the UI.
2303 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2304 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2305 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2306 a single ID, avoiding duplicate providers.
2307 * src/maemo/easysetup/modest-easysetup-wizard.c:
2308 (on_combo_account_country): Adapt to use a list.
2310 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2312 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2313 keys changed in the last X seconds.
2315 * src/modest-account-mgr.h:
2316 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2317 (on_key_change), (modest_account_mgr_class_init),
2318 (modest_account_mgr_init), (modest_account_mgr_finalize):
2319 As the keys are changed, save them in a GSList* and signal that GSList*
2320 further every X seconds, to batch changes, to allow us to do just one
2321 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2322 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2324 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2325 changed signal signature.
2327 * src/modest-conf.c: (modest_conf_set_list),
2328 (modest_conf_on_change): Reenable notification.
2330 (modest_conf_maemo_fake_on_change): Comment out the hack that
2331 notified immediately instead of asynchronously.
2333 * src/widgets/modest-account-view.h:
2334 * src/widgets/modest-account-view.c:
2335 (update_account_view): Select the previously-selected account ID,
2336 if possible. This fixes projects.maemo.org bug NB#56933.
2338 (on_account_changed), (on_account_removed),
2339 (modest_account_view_select_account):
2341 Remove the block/unblock functions
2342 because they were not useful.
2344 * src/maemo/modest-account-view-window.c:
2345 (on_delete_button_clicked), (on_edit_button_clicked),
2346 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2348 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2350 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2351 Improve the error dialog to show Incorrect Account Settings, which seems
2352 clearer, and say that the internal error message (to be removed from the
2353 dialog later) is often misleading.
2354 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2356 * src/modest-tny-account.c:
2357 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2358 URL because this is so useful for debugging on the device.
2360 * src/widgets/modest-serversecurity-combo-box.c:
2361 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2363 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2365 * src/modest-mail-operation.c:
2366 (modest_mail_operation_send_new_mail):
2367 Added a comment about a nasty but apparently harmless message. Details
2368 added to the wiki g_warnings() page.
2370 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2372 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2373 (modest_tny_send_queue_class_init):
2374 Do not use the priv struct because it is empty, to avoid g_warnings
2375 about a non-existant priv struct.
2377 * src/modest-tny-account-store.c:
2378 (modest_tny_account_store_get_server_account),
2379 (modest_tny_account_store_get_transport_account_for_open_connection
2380 ): Do not try to get transport server accounts for local folders,
2381 because they don't have any. This avoids a g_warning().
2383 * src/maemo/modest-main-window.c:
2384 (modest_main_window_notify_send_receive_initied),
2385 (on_configuration_key_changed):
2386 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2387 * src/modest-defs.h:
2388 * src/modest-mail-operation.c:
2389 (modest_mail_operation_update_account):
2390 * src/modest-tny-account-store.h:
2391 * src/modest-tny-account.c:
2392 (modest_tny_account_get_special_folder),
2393 (modest_tny_account_new_for_local_folders),
2394 (modest_tny_account_new_for_per_account_local_outbox_folder):
2395 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2396 * src/modest-tny-local-folders-account.c:
2397 (add_account_folders_to_merged_folder):
2398 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2399 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2400 (modest_ui_actions_on_send):
2401 * src/widgets/modest-folder-view.c: (update_model):
2402 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2403 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2404 modest_tny_account_store_get_tny_account_by_account() to
2405 modest_tny_account_store_get_server_account() to make the code clearer.
2407 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2409 * src/dbus_api/modest-dbus-api.h:
2410 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2411 * src/maemo/modest-msg-edit-window.c:
2412 (modest_msg_edit_window_attach_file_noninteractive):
2413 added g_warning in case the file to be attached does not exist
2414 * tests/dbus_api/test_compose_mail.c: (main):
2415 removed obsolete comment, added generic files as test case
2417 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2419 * src/modest-tny-account-store.c: (get_server_accounts):
2420 Create the local folders account only once, not once for each outbox, and
2421 not only when there are some outboxes.
2423 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2425 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2426 code that is causing a crash at startup. Sergio says that he is fixing this.
2428 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2430 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2431 * src/maemo/modest-account-settings-dialog.c:
2432 (create_page_outgoing),
2433 (modest_account_settings_dialog_set_account_name),
2434 (save_configuration):
2435 - Fixed handling of the "Use secure authentication" toggle to comply with
2436 the ui specification. See also projects.maemo.org bug NB#58400
2438 - Restore the Secure connection setting combo correctly when loading
2441 * src/maemo/modest-maemo-utils.c:
2442 (on_camel_account_get_supported_secure_authentication),
2443 (modest_maemo_utils_get_supported_secure_authentication_methods):
2444 Fixed a crasher if operation is canceled
2446 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2447 (modest_protocol_info_auth_is_secure):
2448 * src/modest-protocol-info.h:
2450 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2451 the sense of the "Use secure authentication" toggle.
2453 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2455 * src/modest-tny-account-store.h:
2456 * src/modest-tny-account-store.c:
2457 Added modest_tny_account_store_get_local_folders_account().
2459 * src/modest-tny-folder.h:
2460 * src/modest-tny-folder.c:
2461 (modest_tny_folder_get_account):
2462 Added this replacement for tny_folder_get_account() which returns
2463 the local-folders account for TnyMergeFolders, to avoid the
2464 warning about the unimplemented get_account_func() vfunc().
2466 (modest_tny_folder_get_rules),
2467 * src/modest-ui-actions.c:
2468 (modest_ui_actions_on_folder_selection_changed):
2469 * src/modest-mail-operation.c:
2470 (modest_mail_operation_remove_folder),
2471 (modest_mail_operation_xfer_folder),
2472 (modest_mail_operation_rename_folder),
2473 (modest_mail_operation_get_msg),
2474 (modest_mail_operation_get_msgs_full),
2475 (modest_mail_operation_remove_msg),
2476 (modest_mail_operation_xfer_msgs),
2477 (modest_mail_operation_refresh_folder):
2478 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2480 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2482 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2483 (modest_server_account_set_security):
2484 * src/modest-defs.h: Add comments explaining that our
2485 UI spec means TLS when it says Normal, so these do not look like errors.
2487 * src/modest-tny-account.c:
2488 (modest_tny_account_new_from_server_account): Use the new tinymail
2489 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2490 for TLS. This should fix projects.maemo.org bug NB#58460.
2492 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2494 * src/maemo/easysetup/modest-easysetup-wizard.c:
2495 (create_account): Correct the position of the gconf sanity check warning.
2496 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2497 of using the g_idle_add() hack, because this does not seem to be necessary
2498 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2499 caused by something other than maemo's gconf.
2500 This fixes projects.maemo.org bug #59022.
2502 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2504 * src/modest-account-mgr-helpers.c:
2505 (modest_account_mgr_get_default_account): Do not check that the account
2506 exists if there is no default account (NULL), to fix a runtime warning.
2508 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2510 * src/widgets/modest-folder-view.c: (update_model):
2511 Do not unref the treemodel before we have finished with it.
2512 This prevents a valgrind warning and an occasional crash at startup.
2514 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2516 * libmodest-dbus-client/libmodest-dbus-client.h:
2517 added libmodest_dbus_client_compose_mail()
2518 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2520 added functions needed for SendAsMail() functionality
2521 * src/maemo/modest-msg-edit-window.c:
2522 (modest_msg_edit_window_attach_file_noninteractive):
2523 non interactively attaching files to message edit window
2524 * src/widgets/modest-msg-edit-window.h:
2525 * tests/dbus_api/Makefile.am:
2526 added test_compose_mail.c
2527 * tests/dbus_api/test_compose_mail.c: (main):
2529 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2531 * src/modest-account-view.c:
2532 Fixed bug projects.maemo.org bug NB#59307
2534 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2536 * src/maemo/easysetup/modest-easysetup-wizard.c:
2537 (get_serverport_incoming), (on_before_next), (create_account):
2538 * src/maemo/modest-account-settings-dialog.c:
2539 (modest_account_settings_dialog_set_account_name):
2540 * src/maemo/modest-maemo-utils.c:
2541 (on_camel_account_get_supported_secure_authentication_status),
2542 (on_camel_account_get_supported_secure_authentication),
2543 (on_secure_auth_cancel),
2544 (modest_maemo_utils_get_supported_secure_authentication_methods):
2546 Implemented security authentication for settings and easysetup.
2548 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2550 * src/maemo/modest-main-window.c: (create_details_widget):
2551 Show the total size for memory card accounts too, instead of showing
2552 the name again. Fixes bug projects.maemo.org bug NB#59307.
2554 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2557 * src/modest-tny-simple-folder-store.c:
2558 * src/modest-tny-simple-folder-store.h: Removed.
2560 * src/modest-tny-local-folders-account.h
2561 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2562 for the local-folders maildir, with an extra TnyMergedFolder containing
2563 the folders of the per-account outbox store accounts.
2564 * src/modest-tny-account-store.c: (get_server_accounts):
2565 Add the outboxes to the special local folders account after creating it.
2567 * src/modest-tny-account.c:
2568 (modest_tny_account_new_for_local_folders): Create the derived
2569 account when creating the main local-folders account.
2571 * src/maemo/modest-main-window.c: (create_details_widget),
2572 (modest_main_window_set_contents_style):
2573 Adapted to the use of the derived account instead of the folder store.
2575 * src/modest-ui-actions.c:
2576 (modest_ui_actions_on_folder_selection_changed):
2577 * src/modest-ui-dimming-rules.c:
2578 (modest_ui_dimming_rules_on_new_folder):
2579 * src/widgets/modest-folder-view.c: (text_cell_data),
2580 (icon_cell_data), (filter_row), (update_model),
2581 (get_cmp_rows_type_pos):
2584 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2585 Do not get the priv struct, because no priv struct has been set,
2586 to avoid a runtime warning.
2588 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2589 #ifelse with #else, to fix a warning, to fix the build.
2592 2007-06-05 Christian Kellner <ckellner@openismus.com>
2594 * libmodest-dbus-client/libmodest-dbus-client.c:
2595 Fix small typo in doc (why do you always see them
2596 AFTER committing stuff?)
2599 2007-06-05 Christian Kellner <ckellner@openismus.com>
2601 * libmodest-dbus-client/libmodest-dbus-client.c:
2602 (libmodest_dbus_client_search):
2603 Initialize hit list with NULL. Also set folder list
2604 to "" if NULL was supplied.
2607 2007-06-03 Christian Kellner <ckellner@openismus.com>
2609 * libmodest-dbus-client/libmodest-dbus-client.c:
2610 (modest_search_hit_list_free):
2611 Make it save to call it with NULL.
2613 * src/dbus_api/modest-dbus-callbacks.c:
2614 * src/modest-search.c:
2615 Return full ModestSearchHits as the search result list not TnyHeader
2616 since can't be around withouth the correspoding TnyFolder.
2618 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2620 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2621 Added currently commented code to check for secure auth
2623 * src/maemo/modest-account-settings-dialog.c: (on_response),
2624 (save_configuration), (show_ok):
2625 Fixed projects.maemo.org bugs NB #59248 and #59251
2627 * src/maemo/modest-maemo-utils.c:
2628 (on_camel_account_get_supported_secure_authentication_status),
2629 (on_camel_account_get_supported_secure_authentication),
2630 (modest_maemo_utils_get_supported_secure_authentication_methods):
2631 * src/maemo/modest-maemo-utils.h:
2632 Moved get_supported_secure_authentication() method here to be able
2633 to use it from easysetup wizard.
2635 * src/modest-pair.c: (on_pair_compare_as_string):
2636 Should compare string with first part of pair and not
2637 strcmp pairs which will crash.
2639 * src/modest-protocol-info.c:
2640 (modest_protocol_info_protocol_is_store):
2641 * src/modest-protocol-info.h:
2642 Added modest_protocol_info_get_auth_protocol_name()
2644 2007-06-03 Armin Burgmeier <armin@openismus.com>
2646 * src/modest-mail-operation.c:
2647 (modest_mail_operation_get_msgs_full): Set priv->account also when
2648 only retrieving a single message. This avoids a crash when canceling
2651 (modest_mail_operation_notify_end): Do not explicitely remove the
2652 operation from the queue but only emit the progress_changed signal.
2653 The queue itself listens to that signal to remove the operation when
2654 it is finished. This reduces coupling and removes a potential deadlock
2655 when modest_mail_operation_notify_end() is called from the queue
2656 itself. If that is a problem performance-wise, I would suggest to
2657 implement a status-changed signal or something.
2659 * src/modest-mail-operation-queue.c: Make sure to never call a
2660 function from another file while the queue is locked. This (hopefully)
2661 fixes another deadlock when exiting the application while retrieving
2664 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2666 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2667 Fixed build if libogs is not available
2669 2007-06-03 Christian Kellner <ckellner@openismus.com>
2671 * libmodest-dbus-client/libmodest-dbus-client.h:
2672 * libmodest-dbus-client/libmodest-dbus-client.c:
2673 (libmodest_dbus_client_delete_message):
2674 Implement deletion of messages (Client side).
2676 (modest_search_hit_free),
2677 (modest_search_hit_list_free):
2678 Utility functions to free the result hits.
2680 * src/dbus_api/modest-dbus-api.h:
2681 * src/dbus_api/modest-dbus-callbacks.c:
2682 (on_delete_message),
2683 (modest_dbus_req_handler):
2684 Implement deletion of messages (Server side).
2686 * tests/dbus_api/test_search.c: (main):
2689 * tests/dbus_api/Makefile.am:
2690 * tests/dbus_api/test_delete_message:
2691 Add little test for the message deletion logic
2693 2007-06-03 Armin Burgmeier <armin@openismus.com>
2695 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2696 when the operation queue was not empty. projects.maemo.org bug
2699 2007-06-03 Armin Burgmeier <armin@openismus.com>
2701 * src/widgets/modest-account-view.c
2702 (on_account_default_toggled): Toggle default account column
2703 explicitely instead of waiting for gconf notification (which is
2704 currently ignored). This should fix projects.maemo.org bug NB#56910
2705 for now. It should probably be removed when gconf notifications are
2708 2007-06-03 Christian Kellner <ckellner@openismus.com>
2710 * libmodest-dbus-client/libmodest-dbus-client.c:
2711 Removed debugging spew.
2713 * src/dbus_api/modest-dbus-callbacks.c:
2714 Added debugging info.
2716 * src/modest-search.c:
2717 (modest_search_all_accounts):
2718 Use tny_account_store_get_accounts () on the account store
2719 to get all accounts which is the way to get all accounts.
2721 * tests/dbus_api/test_search.c: (main):
2722 Make it possible to supply the search term on the command line.
2724 2007-06-03 Christian Kellner <ckellner@openismus.com>
2726 * libmodest-dbus-client/libmodest-dbus-client.c:
2727 * libmodest-dbus-client/libmodest-dbus-client.h:
2728 Implement searching for mesages over raw dbus. (Client side)
2730 * src/dbus_api/Makefile.am:
2731 * src/dbus_api/modest-dbus-api.h:
2732 * src/dbus_api/modest-dbus-callbacks.c:
2733 * src/dbus_api/modest-dbus-callbacks.h:
2734 Search framework (Server side). Also implement on_idle_open_message().
2736 * src/maemo/modest-platform.c: (modest_platform_init):
2737 Prepare for raw dbus/osso rpc interaction.
2739 * src/modest-search.h:
2740 Changed minsize from unspecific guint to guint32.
2742 * src/modest-search.c:
2744 Added strange hack which magically made tnymail work.
2746 (modest_search_folder),
2747 (modest_search_account),
2748 (modest_search_all_accounts):
2749 Implement helper functions to search all accounts, specific account
2752 * tests/dbus_api/Makefile.am:
2753 * tests/dbus_api/test_open_message.c:
2754 Read url to open from commandline.
2756 * tests/dbus_api/test_search.c:
2757 Implement small test for dbus search stuff
2759 2007-06-02 Armin Burgmeier <armin@openismus.com>
2761 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2762 include account type and account title. This fixes projects.maemo.org
2765 * src/maemo/modest-account-view-window.c: Set a title for the window.
2767 2007-06-02 Armin Burgmeier <armin@openismus.com>
2769 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2770 incoming and outgoing server name based on email address and server
2771 types as long as the names have not been edited manually. This fixes
2772 projects.maemo.org bug NB#58671.
2774 2007-06-02 Armin Burgmeier <armin@openismus.com>
2776 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2777 server type cannot be changed in future to the incoming details page
2778 when creating an account. This fixes projects.maemo.org bug NB#59029.
2780 2007-06-02 Armin Burgmeier <armin@openismus.com>
2782 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2783 and assigned max width chars so that they wrap instead of being
2784 truncated. Fixes projects.maemo.org bug NB#56126.
2786 2007-06-02 Armin Burgmeier <armin@openismus.com>
2788 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2789 introductory note to the connection specific smtp servers dialog, as
2790 section 8.12 of the email UI specification requires. This fixes
2791 projects.maemo.org bug NB#59212.
2793 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2795 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2796 Check for running mail operations, and offer to cancel them, as per the UI
2797 spec. This fixes projects.maemo.org bug NB#59041 .
2798 However, I suspect that tinymail may still use the network connection
2799 in ways that we cannot detect or cancel. But it should at least adapt to
2800 changes fairly well.
2802 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2804 * src/modest-tny-account-store.c: (recreate_all_accounts),
2805 (get_cached_accounts), (get_server_accounts): Do more sensible
2806 ref-counting of the temporarily-cached outbox accounts list. This seems
2807 to fix a crash when entering the password when the password was wrong.
2809 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2811 * src/gnome/modest-main-window.c: (connect_signals):
2812 * src/modest-tny-account-store.c: (get_password),
2813 (modest_tny_account_store_alert): Added comments and clues and
2814 commented-out code about how we currently fail to deal with connection
2815 errors and wrong passwords, and how we should.
2817 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2819 * src/widgets/modest-retrieve-combo-box.c:
2820 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2821 This fixes projects.maemo.org bug NB#58472 .
2823 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2825 * src/maemo/easysetup/modest-easysetup-wizard.c:
2826 (create_page_complete_easysetup):
2827 (create_page_complete_custom): Correct the last commit,
2828 putting the correct sentences in the correct pages.
2830 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2832 * src/maemo/easysetup/modest-easysetup-wizard.c:
2833 (create_page_complete_custom): Show the second sentence of text
2834 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2837 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2839 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2840 Set the leave-on-server conf key by default. This fixes
2841 projects.maemo.org bug NB#59258 .
2843 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2845 * src/maemo/modest-account-view-window.c:
2846 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2847 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2850 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2852 * src/maemo/easysetup/modest-easysetup-wizard.c:
2853 (create_caption_new_with_asterisk):
2854 * src/maemo/modest-account-settings-dialog.c:
2855 (create_caption_new_with_asterisk):
2856 Uncomment the code to add the asterisk, because they are no longer in the
2857 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2858 (update_incoming_server_title): Add an asterisk here too.
2860 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2862 * src/maemo/modest-maemo-global-settings-dialog.c:
2863 (current_connection): Check that we are even connected before trying to
2864 get the current connection name, to prevent a warning.
2866 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2867 Change the comments because tny_maemo_conic_device_connect() is now meant to
2869 * src/modest-mail-operation.c:
2870 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2871 make sure we have a connection and fail if we can't connect.
2873 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2875 * src/maemo/modest-main-window.c:
2876 (on_account_store_connecting_finished): Do not try to get the
2877 connection ID if we are not really connected. I am surprised that
2878 this signal handler is called when we are not connected.
2880 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2882 * src/modest-error.h:
2883 * src/modest-ui-actions.c:
2884 (modest_ui_actions_get_msgs_full_error_handler):
2885 Renamed an enum, added comments, added an enum
2886 for retrieve-limit errors.
2888 * src/modest-mail-operation.c: (foreach_add_item),
2889 (internal_folder_observer_update), (update_account_thread),
2890 (modest_mail_operation_get_msgs_full):
2891 (modest_mail_operation_update_account),
2892 Added comments about how this works, and some code that should
2893 (but does not) check the retrieve-limit. See the TODO comment.
2895 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2897 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2898 Initialize help_id to fix the build. Warnings are good.
2900 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2902 * src/widgets/modest-hbox-cell-renderer.c:
2903 (modest_hbox_cell_renderer_append):
2904 * src/widgets/modest-vbox-cell-renderer.c:
2905 (modest_vbox_cell_renderer_append):
2906 Fix the last commit by doing an extra ref.
2908 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2910 * src/widgets/modest-hbox-cell-renderer.c:
2911 (modest_hbox_cell_renderer_append):
2912 * src/widgets/modest-vbox-cell-renderer.c:
2913 (modest_vbox_cell_renderer_append):
2914 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2915 to fix the build with Maemo Bora.
2916 However, there seems to be a remaining crash, probably due to reference
2919 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2921 * src/modest-tny-account.c:
2922 (modest_tny_account_new_for_local_folders):
2923 Use hildon_file_system_info_async_new() to get a better name for
2924 the memory card account, setting it as the account name.
2925 The timing seems to work, but this is probably
2926 not the best place to do this. See the TODO comment.
2927 * src/maemo/modest-main-window.c: (create_details_widget):
2928 * src/widgets/modest-folder-view.c: (text_cell_data):
2929 Use the tny account name instead of hardcoding a name.
2931 2007-05-30 Christian Kellner <ckellner@openismus.com>
2933 * src/modest-search.c: (modest_search):
2934 Correctly set part_search_func even if we have already parsed
2935 the query and thus a valid OgsTextSearcher object.
2937 2007-05-30 Christian Kellner <ckellner@openismus.com>
2940 Search and check for libogs.
2943 Incooparte the ogs build env.
2945 * src/modest-mime-part-search-stream.c:
2946 * src/modest-mime-part-search-stream.h:
2947 Removed since we do the real searching now in modest-search.c.
2949 * src/modest-search.c:
2950 * src/modest-search.h:
2951 Implement support for ogs. We use that if available and requested
2952 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2953 should now handle the corner case when the search term is spread
2954 across multiple reads.
2955 Also the logic in modest_search () was corrected to search all
2956 requested fields until one is found.
2958 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2960 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2962 * src/modest-init.h:
2963 * src/modest-init.c: Made modest_init_local_folders() take a
2964 path and be public so we can iniitialize maildir folders on
2967 * src/modest-local-folder-info.h:
2968 * src/modest-local-folder-info.c:
2969 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2971 * src/modest-tny-account.c:
2972 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2973 still means the standard local-folders path on the local volume.
2975 * src/modest-tny-account-store.c:
2976 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2977 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2978 all accounts when that happens.
2979 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2980 this too, so it shows up in the treeview.
2982 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2984 * src/maemo/modest-maemo-global-settings-dialog.c:
2985 (current_connection):
2986 * src/widgets/modest-global-settings-dialog.c:
2987 (current_connection_default):
2988 Use the enum values instead of 0, 1 and -1,
2989 to make the code clearer.
2991 * src/modest-account-mgr-helpers.c:
2992 (modest_account_mgr_get_connection_specific_smtp): Make this code
2995 * src/modest-runtime.h:
2996 * src/modest-runtime.c:
2997 Added modest_runtime_remove_all_send_queues().
2998 * src/maemo/modest-main-window.c:
2999 (on_account_store_connecting_finished): Recreate the send queues,
3000 using the appropriate transport accounts for this new connection.
3001 Some futher adapting might be needed if the old send queues are not
3002 automatically stopped at this point.
3004 * src/modest-tny-account-store.c: (get_server_accounts):
3005 Create the connection-specific transport accounts, so that they can
3006 be found later by their ID.
3008 * src/modest-tny-account.h:
3009 * src/modest-tny-account.c:
3010 Added modest_tny_account_new_from_server_account_name().
3011 modest_tny_account_new_from_server_account(): Do not create the
3012 send queues here, because they will be
3013 recreated anyway when the connection changes for the first time.
3015 2007-05-28 Murray Cumming <murrayc@murrayc.com>
3017 * src/modest-local-folder-info.h:
3018 * src/modest-local-folder-info.c:
3019 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3020 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3021 tbox_folder): Take a modest account name instead of a server TnyAccount,
3022 so we can have per-modest-account rather than per-transport-account
3024 We must make sure that we change or recreate the exisitng send queues
3025 when the connection changes for connection-specific transport accounts.
3027 * src/modest-tny-account-store.c:
3028 (create_per_account_local_outbox_folders): Create outboxed per modest
3029 account, not per transport account.
3031 * src/modest-tny-account.h:
3032 * src/modest-tny-account.c:
3033 (modest_tny_account_get_special_folder): For outboxes, get the
3034 parent modest account name. The account is ignored for other folders.
3035 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
3036 modest account name rather than a server TnyAccount.
3038 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3040 * src/modest-tny-account.c:
3041 (modest_tny_account_new_from_server_account):
3042 Call modest_runtime_get_send_queue() immediately after creating transport
3043 accounts, so that they start trying to send email from the outbox as soon
3044 as possible at startup. This is probably what we want.
3046 * src/modest-mail-operation.c: (update_account_thread):
3047 * src/modest-runtime.c: (modest_runtime_get_send_queue):
3048 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
3049 * src/modest-tny-send-queue.h:
3050 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
3051 (modest_ui_actions_on_send):
3052 Added comments about how sending works, though it needs some more work.
3054 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3056 * src/modest-tny-account.c:
3057 (modest_tny_account_get_special_folder): Add TODO because this fails when
3058 the network is busy.
3059 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
3060 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
3061 Do not try to show this window when there is no active account. The UI
3062 specs does not tell us what to do in this case.
3064 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3068 * src/maemo/Makefile.am:
3069 * src/widgets/Makefile.am: Some dist fixes.
3071 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3073 * src/maemo/modest-connection-specific-smtp-window.c:
3074 (on_button_edit): Make the code clearer, to prevent a double free.
3076 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3078 * src/maemo/modest-account-settings-dialog.c:
3079 (modest_account_settings_dialog_set_account_name),
3080 Check the connection-specific smtp servers checkbox if there are any.
3082 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3083 (modest_connection_specific_smtp_edit_window_init):
3084 Start with a suitable port number.
3086 * src/modest-account-mgr-helpers.h:
3087 * src/modest-account-mgr-helpers.c: Added
3088 modest_account_mgr_get_has_connection_specific_smtp().
3090 (modest_account_mgr_set_connection_specific_smtp),
3091 (modest_account_mgr_remove_connection_specific_smtp),
3092 (modest_account_mgr_get_has_connection_specific_smtp),
3093 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3094 connection-specific smtp server accounts in the account, rather than
3095 the server account conf dir.
3097 This fixes bug projects.maemo.org bug NB#58263 .
3099 * src/modest-tny-account-store.c:
3100 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3101 if there are no server accounts yet, to prevent an infinite loop when there
3102 are no accounts. Document that one must be called before the other.
3104 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3106 * src/modest-account-mgr-helpers.c:
3107 (modest_account_mgr_get_default_account): Make sure that at least
3108 one account is always the default, if there are any enabled accounts.
3109 This is just a sanity check that shouldn't be necessary.
3111 * src/modest-account-mgr-priv.c:
3112 (_modest_account_mgr_account_from_key): Unescape the conf key to
3113 get the real account name. For instance, this is an issue if a space
3114 was in the account name, which can happen because the account name
3115 is generated from the display name.
3116 (_modest_account_mgr_get_account_keyname): Always escape the
3118 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3119 Unescape the conf keys to get the real account names.
3121 For instance, previously the is-default radio button in the accounts
3122 list was not checked for any accounts at first. This fixes that,
3123 and might fix several similar bugs.
3125 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3127 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3128 Removed some debug printfs.
3130 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3132 Modest on-disk outbox directories are now here, for instance:
3133 $HOME/.modest/outboxes/<account-id-1>/outbox
3134 $HOME/.modest/outboxes/<account-id-2>/outbox
3136 $HOME/.modest/local-folders/outbox
3137 so we can have a separate outbox for each account.
3138 But they are shown as one outbox in the GtkTreeView, by using a
3139 TnyMergeFolder in a ModestTnySimpleFolderStore.
3142 * src/modest-tny-simple-folder-store.c:
3143 * src/modest-tny-simple-folder-store.h:
3144 Added ModestTnySimpleFolderStore, used to contain folders from
3145 other folder stores, such as other accounts.
3147 * src/modest-tny-outbox-account.h:
3148 * src/modest-tny-outbox-account.c:
3149 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3150 used for the per-account local outbox folders.
3152 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3153 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3154 only use this (internally) now for the non-outbox local folders.
3156 * src/modest-init.h:
3157 * src/modest-init.c: Added modest_init_one_local_folder(), for
3158 setting up the directory structure for each local folder.
3160 * src/modest-local-folder-info.c:
3161 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3162 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3164 * src/modest-local-folder-info.h:
3165 * src/modest-tny-account-store.c: (on_account_removed),
3166 (on_account_changed), (create_per_account_local_outbox_folders),
3167 (get_server_accounts), (modest_tny_account_store_get_accounts),
3168 (modest_tny_account_store_get_tny_account_by_account),
3169 (modest_tny_folder_store_is_virtual_local_folders):
3171 * src/modest-tny-account.h:
3172 * src/modest-tny-account.c:
3173 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3174 to create an on-disk per-account local outbox folder for each
3176 (create_per_account_local_outbox_folders): Create a local outbox folder
3177 for each transport account.
3178 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3179 for all local folders.
3181 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3182 instead of using g_object_get/set() directly. It is clearer.
3184 (modest_tny_folder_store_get_message_count),
3185 (modest_tny_folder_store_get_local_size
3186 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3187 because we now use these with non-acount folder stores.
3189 (modest_tny_account_get_special_folder),
3190 (modest_tny_account_new_from_server_account),
3191 (modest_tny_account_new_from_account):
3192 (recurse_folders): Adjust to the new outbox system.
3194 * src/modest-tny-folder.h:
3195 * src/modest-tny-folder.c:
3196 (modest_tny_folder_is_local_folder),
3197 (modest_tny_folder_get_local_folder_type),
3198 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3200 * src/widgets/modest-main-window.h:
3201 * src/maemo/modest-main-window.c: (create_details_widget),
3202 (modest_main_window_set_contents_style): Show details for any folder store,
3205 (modest_tny_folder_get_rules):
3206 Remove the const. C does not support constness enough for this.
3208 * src/modest-ui-actions.c:
3209 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3210 make all outboxes appear as one, in the usual local-folders tree node.
3212 (set_active_account_from_tny_account),
3213 (modest_ui_actions_on_folder_selection_changed):
3214 * src/widgets/modest-folder-view.c: (text_cell_data),
3215 (icon_cell_data), (filter_row),
3216 (add_account_folders_to_merged_folder),
3217 (add_account_folders_to_simple_folder_store), (),
3218 (get_cmp_rows_type_pos), (cmp_rows),
3219 (modest_folder_view_set_account_id_of_visible_server_account):
3220 Adjust to the new outbox system, using generic folder stores and folders
3221 in the GtkTreeModel.
3223 2007-05-23 Christian Kellner <ckellner@openismus.com>
3225 * src/modest-mail-operation.c:
3226 (modest_mail_operation_update_account):
3227 Use info->max_size instead of unintialized local var [small
3228 build fix]. (Added TODO to review that change since I don't
3231 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3233 * libmodest-dbus-client/libmodest-dbus-client.c:
3234 (libmodest_dbus_client_compose_mail): function added
3235 * src/dbus_api/modest-dbus-api.h:
3236 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3237 (on_compose_mail): Implementation of the SendAsMail functionality
3239 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3241 * src/modest-account-mgr.c:
3242 (modest_account_mgr_add_server_account): Set the secure-connection
3243 conf key for transport accounts as well as store accounts. I don't know
3244 why the if was there. For instance, this makes sure that we use SSL
3245 for the gmail preset from the easysetup wizard.
3247 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3249 * src/gnome/modest-main-window.c:
3250 (on_account_store_connecting_finished), (connect_signals):
3251 * src/maemo/modest-main-window.c:
3252 (on_account_store_connecting_finished), (connect_signals),
3253 (modest_main_window_new):
3254 Handle TnyAccountStore::connecting-finished instead of
3255 TnyDevice::connection-changed, because we cannot actually perform
3256 operations on accounts until TnyAccountStore has itself responded to
3257 the TnyDevice::connection-changed signal. This prevents a GError from
3259 Do not try to update at startup, because we (at least on scratchbox)
3260 already do an update at startup when the device goes online.
3261 This prevents a GError from tinymail.
3262 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3263 Added TODO about stopping simultaneous operations.
3265 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3267 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3268 * src/modest-mail-operation-queue.c:
3269 (modest_mail_operation_queue_remove):
3270 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3271 about where they happened.
3273 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3275 * src/modest-ui-actions.c:
3276 (modest_ui_actions_on_password_requested): Make sure that the remember
3277 output parameter is always TRUE.
3279 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3281 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3282 Show a OK/Cancel dialog if the error is a question, though we still do not
3283 know anything more about what we are asking the user.
3284 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3285 Fix an uninitialized variable (helper). This is a logic error, however.
3287 2007-05-21 Christian Kellner <ckellner@openismus.com>
3289 * src/modest-search.h:
3290 Correct bit shifting in the ModestSearchFlags enum.
3292 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3294 * src/modest-tny-account.c:
3295 (modest_tny_account_new_from_server_account): Do not use the lsub and
3296 check-all hard-coded IMAP options when using POP.
3298 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3300 * src/modest-tny-account.c:
3301 (modest_tny_account_new_from_server_account):
3302 Use NULL for the secure-auth method for POP when Password auth has been
3303 specified by the user, as we already do for IMAP. "auth=Login" causes
3304 an error from camel or the server.
3306 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/modest-account-settings-dialog.c:
3309 (create_page_account_details),
3310 (modest_account_settings_dialog_set_account_name):
3311 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3312 for the leave-on-server checkbox, rathr than just the checkbox, when
3313 the protocol is not POP.
3315 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3317 * src/widgets/modest-account-view.c:
3318 * src/widgets/modest-account-view.h:
3319 Added modest_account_view_select_account() which will be useful later
3320 to asynchronously re-select the edited account.
3322 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3324 * src/maemo/modest-account-settings-dialog.c:
3325 (modest_account_settings_dialog_set_account_name):
3326 Automatically choose the port numbers based on the secure authentication
3327 methods, if they have not been chosen before.
3328 This fixes projects.maemo.org bug NB#56273 .
3330 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3332 * src/maemo/modest-main-window-ui.h:
3333 * src/modest-ui-actions.c:
3334 * src/modest-ui-actions.h:
3335 Connect the Tools/SMTP Servers menu item to
3336 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3337 SMTP servers dialog, as in the UI specification and saves changes when it
3338 is closed. This fixed projects.maemo.org bug NB#56305 .
3340 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3342 * src/maemo/modest-connection-specific-smtp-window.c:
3343 (modest_connection_specific_smtp_window_init):
3344 Use gtk_window_set_default_size() to make this window big enough, so
3345 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3347 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3349 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3350 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3351 (modest_connection_specific_smtp_edit_window_init),
3352 Do not try to connect to a combobox signal before the combobox exists.
3353 This fixes the cras in projects.maemo.org bug NB#56288 .
3354 (modest_connection_specific_smtp_edit_window_get_settings):
3355 Remove the server_account_name parameter which was being checked for NULL
3356 though it was not used.
3358 * src/maemo/modest-connection-specific-smtp-window.c:
3359 (modest_connection_specific_smtp_window_fill_with_connections),
3360 (on_button_edit), (modest_connection_specific_smtp_window_init):
3361 Correct the number of treemodel columns to prevent a warning.
3362 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3363 libconic does not work.
3365 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3367 * src/modest-tny-account.c:
3368 (modest_tny_account_new_from_server_account):
3369 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3370 SMTP when "None" was chosen by the user. However, with my SMTP server that
3371 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3374 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3376 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3377 to explain the memory management issue with the ID in the ModestPair.
3379 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3380 (add_sending_page), (modest_account_assistant_finalize):
3381 * src/gnome/modest-gnome-global-settings-dialog.c:
3382 (create_updating_page), (create_composing_page):
3383 * src/gnome/modest-msg-edit-window.c: (get_transports),
3384 (init_window), (modest_msg_edit_window_finalize),
3385 (modest_msg_edit_window_get_msg_data):
3386 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3387 * src/gnome/modest-transport-widget.c:
3388 (modest_transport_widget_finalize), (smtp_configuration):
3389 * src/maemo/modest-maemo-global-settings-dialog.c:
3390 (create_updating_page), (create_composing_page):
3391 * src/maemo/modest-msg-edit-window.c: (get_transports),
3392 (init_window), (modest_msg_edit_window_finalize),
3393 (modest_msg_edit_window_get_msg_data),
3394 (modest_msg_edit_window_free_msg_data):
3395 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3396 (modest_store_widget_finalize):
3397 * src/maemo/modest-transport-widget.c:
3398 (modest_transport_widget_finalize), (smtp_configuration):
3399 * src/modest-main.c: (send_mail):
3400 * src/widgets/modest-combo-box.h:
3401 * src/widgets/modest-global-settings-dialog-priv.h:
3402 * src/widgets/modest-global-settings-dialog.c:
3403 (modest_global_settings_dialog_finalize):
3404 * src/widgets/modest-msg-edit-window.h:
3405 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3406 as long as the combo box, to prevent use of freed memory for the ID.
3408 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3410 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3411 get_accounts(), to make this clearer. Do not check for the enabled gconf
3412 key, because we do not use this for server accounts (at least, not yet).
3413 This allows us to send email again.
3415 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3417 * src/maemo/modest-platform.c:
3418 (on_modest_conf_update_interval_changed), (modest_platform_init):
3419 Only respond to this particular key change. All these strcmp()s cannot be
3422 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3424 * src/maemo/modest-maemo-global-settings-dialog.c:
3425 (current_connection): Prevent a crash in scratchbox when
3426 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3427 * src/maemo/modest-platform.c:
3428 (on_modest_conf_update_interval_changed), (modest_platform_init):
3429 Get the update interval from gconf and reset it when the gconf key changes.
3431 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3433 * src/modest-protocol-info.c:
3434 * src/modest-protocol-info.h: Adde enum-specific get functions,
3435 instead of using a ModestProtocolType enum parameter.
3437 * src/gnome/modest-account-assistant.c:
3438 * src/gnome/modest-store-widget.c:
3439 * src/gnome/modest-store-widget.h:
3440 * src/gnome/modest-transport-widget.c:
3441 * src/gnome/modest-transport-widget.h:
3442 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3443 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3444 * src/maemo/easysetup/modest-easysetup-wizard.c:
3445 * src/maemo/modest-account-settings-dialog.c:
3446 * src/maemo/modest-account-settings-dialog.h:
3447 * src/maemo/modest-store-widget.c:
3448 * src/maemo/modest-store-widget.h:
3449 * src/maemo/modest-transport-widget.c:
3450 * src/maemo/modest-transport-widget.h:
3451 * src/modest-account-mgr-helpers.c:
3452 * src/modest-account-mgr-helpers.h:
3453 * src/modest-account-mgr.c:
3454 * src/modest-account-mgr.h:
3455 * src/modest-tny-account.c:
3456 * src/modest-tny-folder.c:
3457 * src/widgets/modest-account-view.c:
3458 * src/widgets/modest-retrieve-combo-box.c:
3459 * src/widgets/modest-retrieve-combo-box.h:
3460 * src/widgets/modest-secureauth-combo-box.c:
3461 * src/widgets/modest-serversecurity-combo-box.c:
3462 * src/widgets/modest-serversecurity-combo-box.h:
3463 * tests/check_account-mgr.c:
3464 Use the specific functions, and use the re-renamed enum values for GNOME too.
3466 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3468 * src/modest-pair.h:
3469 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3470 so we can get the second based on the first.
3472 * src/maemo/modest-account-settings-dialog.h:
3473 * src/maemo/modest-account-settings-dialog.c:
3474 Added get_supported_secure_authentication_methods(), though it is mostly
3475 commented-out for now until the necessary API is committed to tinymail.
3476 (modest_account_settings_dialog_set_account_name),
3477 (save_configuration): Request the supported authentication methods from the
3478 server, so we can choose a working method.
3480 * src/modest-tny-account-store.h:
3481 * src/modest-tny-account-store.c:
3482 (modest_tny_account_store_get_session): Rename from
3483 tny_account_store_get_session().
3485 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3487 * src/modest-protocol-info.h: Split the ModestProtocol enum
3488 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3489 There was no need to have these unrelated values in one enum.
3491 * src/: many files: Adapted to changed enum. This makes the code a bit
3492 clearer, and the compiler could catch some errors.
3494 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3496 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3497 Show the detailed internal camel error message when an error happens
3498 during the configuration, so that our testers can give us more clues.
3499 For instance, in projects.maemo.org bug NB#56910 .
3501 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3503 * src/modest-tny-account.c:
3504 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3505 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3507 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3509 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3510 * src/maemo/modest-account-settings-dialog.c:
3511 (modest_account_settings_dialog_set_account_name),
3512 (save_configuration): For the incoming secure authentication checkbox,
3513 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3514 the UI specification. PLAIN does not seem to be supported for most IMAP
3515 servers anyway, and I am not sure what it would mean.
3516 However, we probably need to discover which of the secure-authentication
3517 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3518 * src/modest-account-mgr-helpers.c:
3519 (modest_account_mgr_get_server_account_data):
3521 * src/modest-tny-account.c:
3522 (modest_tny_account_new_from_server_account):
3523 Use tny_account_set_mech() to set secure-authentication methods,
3524 with some special-casing for IMAP, based on my observations of how
3527 * src/modest-account-mgr-helpers.h:
3528 * src/modest-account-mgr.c:
3529 * src/modest-defs.h: Comment that the URI is only used for local folders.
3531 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3533 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3534 parameter const, just to be neat.
3535 * src/modest-text-utils.c: (modest_text_utils_inline):
3536 End g_strconcat() with NULL, as its documentation says. This is almost
3537 certainly the cause of my crash at startup on the device. Interestingly,
3538 valgrind doesn't tell us about these errors.
3540 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3542 * scripts/build-packages: Added more precise comments about how to use
3543 this script, though I still get this error:
3544 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3545 error building tinymail
3547 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3549 * src/maemo/modest-main-window.c: (on_account_update):
3550 Very slight cleanup, hoping to make it simpler to discover what causes
3551 a crash here sometimes.
3553 * src/modest-tny-account.c:
3554 (modest_tny_account_new_from_server_account): Set the port. Added
3555 comments about the options and a TODO comment because I need to find out
3556 how to specify the secure authentication method.
3558 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3560 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3561 changed CFlags paths form modest to libmodest
3563 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3565 * src/modest-account-mgr-helpers.c:
3566 (modest_account_mgr_get_server_account_data),
3567 (modest_account_mgr_free_server_account_data):
3568 * src/modest-account-mgr-helpers.h:
3569 * src/modest-account-mgr.c:
3570 (modest_account_mgr_add_server_account):
3571 * src/modest-defs.h:
3572 * src/modest-tny-account.c:
3573 (modest_tny_account_new_from_server_account):
3574 Determine the options for tny_camel_account_add_option() here,
3575 based on the settings, rather than storing them directly in gconf.
3577 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3579 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3580 Show a more friendly error dialog now that we expect (from the tinymail
3581 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3583 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3585 * src/maemo/modest-main-window.c: (on_account_update): Check that
3586 account_name is not NULL, to prevent a crash at startup that I am
3587 seeing on the N800. I do wonder why it is NULL.
3589 * src/maemo/easysetup/modest-easysetup-wizard.c:
3590 (create_page_user_details):
3591 * src/maemo/modest-account-settings-dialog.c:
3592 (create_page_user_details), (create_page_outgoing):
3593 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3594 (modest_connection_specific_smtp_edit_window_init):
3595 * src/modest-ui-actions.c:
3596 (modest_ui_actions_on_password_requested):
3597 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3598 might do something useful with the on-screen keyboard.
3600 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3602 * src/maemo/modest-main-window.c: (on_account_update):
3603 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3604 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3606 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3608 * src/modest-tny-account-store.c: (on_account_changed):
3609 Correct the signature of this signal handler.
3611 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3613 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3614 Show a HildonNote instead of a GtkDialog for Maemo.
3616 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3618 * src/widgets/modest-account-view.h:
3619 * src/widgets/modest-account-view.c: (on_account_changed),
3620 (on_account_removed). Added a boolean flag, set/unset by
3621 modest_account_view_block_conf_updates(),
3622 modest_account_view_unblock_conf_updates() to prevent unnecessary
3623 updates, but this is not very useful because the gconf notifications are
3624 so delays (maybe only on Maemo Bora).
3625 So auto-updating is turned off, and these functions do an explicit
3626 update when necessary.
3627 However, something else is still doing too much work when adding/removing
3628 accounts, probably in another part of the application.
3630 * src/maemo/modest-account-view-window.c:
3631 (on_delete_button_clicked), (on_edit_button_clicked),
3632 (on_new_button_clicked): Use the new functions.
3634 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3636 * src/modest-account-mgr-helpers.c:
3637 (modest_account_mgr_set_first_account_as_default):
3638 Sort the list of names alphabetically-by-title, so we choose the first one
3640 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3641 alphabetically by the title.
3643 This fixes projects.maemo.org bug NB#56418 .
3645 * src/modest-account-mgr-priv.c:
3646 (_modest_account_mgr_account_from_key):
3647 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3648 avoid a valgrind error, and possible random behaviour.
3650 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3652 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3653 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3654 tinymail documentation to say that this can be expected.
3655 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3656 pretty, and should not happen, but I would prefer to know when it does.
3658 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3660 * configure.ac: When using the older hildon version, probably on Bora,
3661 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3663 * src/widgets/modest-attachment-view.c:
3664 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3667 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3669 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3670 Implemented the prototype. Can be tested with
3671 tests/dbus_api/test_open_message:
3673 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3675 * src/modest-tny-account-store.c:
3676 (modest_tny_account_store_instance_init), (get_password):
3677 * src/modest-ui-actions.c:
3678 (modest_ui_actions_on_password_requested):
3679 Do not store the password in gconf, because this function is called
3680 for non-remembered passwords. Actually use the cached (in the hash map)
3681 password instead of releasing it.
3682 The password will now not be remembered if it is asked via the protected
3683 password dialog, as per the UI spec.
3685 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3687 * src/modest-defs.h:
3688 * src/modest-account-mgr-helpers.h:
3689 * src/modest-account-mgr-helpers.c:
3690 Added modest_server_account_get_username_has_succeeded(),
3691 modest_server_account_set_username_has_succeeded().
3692 (modest_server_account_set_username),
3693 Reset the has-succeeded flag if the username changes.
3695 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3696 * src/maemo/modest-connection-specific-smtp-window.c:
3697 (modest_connection_specific_smtp_window_save_server_accounts):
3698 Use modest_server_account_set_username() instead of using
3699 modest_conf_set_string() directly, so that the has-succeeded flag is always
3702 * src/modest-ui-actions.c:
3703 (modest_ui_actions_on_password_requested): Dim the username entry if
3704 the username has ever worked, as per the UI spec.
3706 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3708 * src/modest-tny-account-store.c: (get_password):
3709 * src/modest-ui-actions.c:
3710 (modest_ui_actions_on_password_requested):
3711 Allow the username to be changed too, though there is more work to
3712 be done on exactly how this behaves.
3714 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3716 * src/modest-account-mgr-helpers.h:
3717 * src/modest-account-mgr-helpers.c:
3718 Added modest_account_mgr_get_display_name(),
3719 modest_server_account_get_username(),
3720 modest_server_account_set_username(),
3721 modest_server_account_set_password(),
3722 modest_server_account_get_hostname() functions so we do not need to
3723 use the conf API directly.
3725 * src/maemo/modest-main-window.c: (connect_signals):
3726 Actually connect ot the ModestAccountStore::request-password signal,
3727 so that we show the dialog when the password is requested by Tinymail,
3728 for isntance if it is empty.
3730 * src/modest-marshal.list:
3731 * src/modest-tny-account-store.c:
3732 (modest_tny_account_store_class_init), (get_password),
3733 (modest_tny_account_store_alert):
3734 * src/modest-tny-account-store.h:
3735 * src/modest-ui-actions.h:
3736 * src/modest-ui-actions.c:
3737 (modest_ui_actions_on_password_requested):
3738 Change the signal parameters, so it is obvious that we are providing
3739 the non human-readable server name, and receiving both the username
3740 and password, though changing of the username is not yet implemented.
3741 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3742 for the GNOME version.
3744 This should fix the projects.maemo.org bug NB#56209, though it does not
3745 work on Bora, because the gconf_client_get() for the password fails
3746 immediately after we save it with gconf_client_set().
3748 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3751 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3752 caused an undefined symbol error:
3753 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3755 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3757 * src/modest-tny-account-store.c:
3758 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3759 using a GError instead of a string message, so we can translate it in
3762 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3764 * src/maemo/modest-address-book.c:
3765 (modest_address_book_check_names):
3766 * src/maemo/modest-msg-view-window.c:
3767 (modest_msg_view_window_clipboard_owner_change):
3768 * src/modest-init.c: (modest_init_init_ui):
3769 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3770 (update_folders_cb), (modest_mail_operation_update_account):
3771 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3772 (modest_ui_actions_on_msg_attachment_clicked),
3773 (modest_ui_actions_on_msg_recpt_activated):
3774 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3775 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3776 (modest_msg_view_search_next):
3777 * src/widgets/modest-recpt-editor.c:
3778 (modest_recpt_editor_on_button_release_event),
3779 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3780 g_message(). At this point we should only be seeing interesting errors on
3781 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3783 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3785 (modest_wizard_dialog_force_title_update):
3786 * src/maemo/easysetup/modest-wizard-dialog.h:
3787 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3788 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3789 can update the title when appropriate. Otherwise the title is wrong if the
3790 pages are added after adding the notebook to the dialog.
3791 This must be a problem in HildonWizardDialog too.
3792 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3794 * src/maemo/easysetup/modest-easysetup-wizard.c:
3795 (create_subsequent_customsetup_pages),
3796 (create_subsequent_easysetup_pages):
3797 Call modest_wizard_dialog_force_title_update() so that the title is
3798 correct even with GTK+ < 2.10.
3799 This fixes projects.maemo.org bug NB#56145 .
3801 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3803 * src/maemo/modest-platform.c:
3804 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3805 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3808 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3810 * src/widgets/modest-window.h:
3811 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3812 and modest_window_save_state(), which invokes it.
3814 * src/widgets/modest-window-mgr.h:
3815 * src/widgets/modest-window-mgr.c:
3816 Added modest_window_mgr_save_state_for_all_windows(), which calls
3817 the save_state vfunc on all registered windows, if implemented.
3819 * src/gnome/modest-msg-edit-window.c:
3820 * src/gnome/modest-msg-view-window.c:
3821 * src/maemo/modest-msg-edit-window.c:
3822 * src/maemo/modest-msg-view-window.c:
3823 * src/maemo/modest-main-window.c:
3824 Specify the existing save_settings functions as implementations of
3825 ModestWindow::save_state_func().
3827 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3828 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3829 enabling hibernation, for instance.
3831 We may need to do the same thing for restoring settings.
3834 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3836 * src/widgets/modest-window-mgr.c:
3837 * src/widgets/modest-window-mgr.h:
3838 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3839 modest_window_mgr_get_hibernation_is_prevented().
3841 * src/maemo/modest-main-window.c:
3842 (on_hildon_program_is_topmost_notify): Prevent hibernation
3843 (possible when the application goes to the background in the WM),
3844 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3846 * src/maemo/easysetup/modest-easysetup-wizard.c:
3847 (modest_easysetup_wizard_dialog_init):
3848 * src/maemo/modest-account-settings-dialog.c:
3849 (modest_account_settings_dialog_init):
3850 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3851 (modest_connection_specific_smtp_edit_window_init):
3852 * src/maemo/modest-connection-specific-smtp-window.c:
3853 (modest_connection_specific_smtp_window_init):
3854 * src/maemo/modest-signature-editor-dialog.c:
3855 (modest_signature_editor_dialog_init):
3856 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3857 prevent hibernation while any of these account settings dialogs are open.
3859 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3861 * src/maemo/Makefile.am:
3862 * src/maemo/modest-osso-state-saving.c:
3863 * src/maemo/modest-osso-state-saving.h: Added
3864 modest_osso_load_state() and modest_osso_save_state() though they do
3865 nothing now. They should iterate through all the open windows and load/save
3867 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3868 save state when closing.
3870 * src/maemo/modest-main-window.c:
3871 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3872 Add a notification handler for the HildonProgram::is-topmost property,
3873 so we can allow hibernation when the application goes into the background.
3874 But we still need to detect when the accounts setup windows are open so
3875 we can stop hibernation when they are open.
3876 To do this, I also added the main window the HildonProgram. This might have
3877 other side-effects/benefits, and should maybe be done for other windows.
3879 * src/maemo/modest-osso-autosave-callbacks.h:
3880 * src/maemo/modest-osso-autosave-callbacks.c:
3881 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3882 though it does not do anything yet, and we might never need this to do
3883 anything. For instance, we already save drafts.
3885 * src/maemo/modest-platform.c: (modest_platform_init):
3886 Specify the libosso auto-save callback.
3888 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3890 * src/maemo/modest-platform.c:
3891 (modest_platform_set_update_interval):
3892 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3893 aparently stays valid between application instances, so we can use this
3894 to remove and reset it later. According to a maemo-developers email from
3897 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3899 * configure.ac: Depend on libalarm for Maemo.
3901 * src/dbus_api/modest-dbus-api.h:
3902 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3903 (on_send_receive), (modest_dbus_req_handler):
3904 Handle a SEND_RECEIVE D-Bus method.
3906 * libmodest-dbus-client/libmodest-dbus-client.c:
3907 (libmodest_dbus_client_send_and_receive):
3908 * libmodest-dbus-client/libmodest-dbus-client.h:
3909 Add C convenience functions for calling the new D-Bus method.
3911 * src/modest-platform.h:
3912 * src/gnome/modest-platform.c:
3913 * src/maemo/modest-platform.c:
3914 Added modest_platform_set_update_interval(), which uses the
3915 alarmd API on Maemo.
3916 (modest_platform_init),
3917 Call modest_platform_set_update_interval(), using a hard-coded
3918 interval for now (until the global settings dialog is implemented),
3919 though I am not sure that this makes sense yet.
3921 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3923 * src/dbus_api/modest-dbus-callbacks.c:
3924 (modest_osso_cb_hw_state_handler):
3925 * src/dbus_api/modest-dbus-callbacks.h:
3926 * src/maemo/modest-platform.c: (modest_platform_init):
3927 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3928 in case this has some effect on the ability for Maemo to ping the
3931 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3933 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3934 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3935 warning. It is probably a logic error, but I need to fix the build.
3937 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3939 * src/modest-account-mgr.h:
3940 * src/modest-account-mgr.c:
3941 (modest_account_mgr_account_names): Add a gboolean enabled_only
3942 parameter, so we can get lists of onlt the enabled accounts.
3944 (modest_account_mgr_add_account),,
3945 (modest_account_mgr_account_with_display_name_exists):
3946 * src/maemo/modest-msg-edit-window.c: (get_transports):
3947 * src/modest-account-mgr-helpers.c:
3948 (modest_account_mgr_set_first_account_as_default):
3949 * src/modest-init.c: (init_default_account_maybe):
3950 * src/modest-tny-account-store.c: (get_accounts):
3951 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3952 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3953 * tests/check_account-mgr.c: (START_TEST):
3954 Provide the extra parameter, as appropriate.
3956 * src/widgets/modest-account-view.c: (update_account_view):
3957 Do not show disabled accounts (meaning that there is no way to
3958 enable/disable accounts in the UI (the feature is not in our UI
3959 specification), so we can use this internally only to mark unfinished
3960 or temporary account data.
3962 * src/maemo/easysetup/modest-easysetup-wizard.c:
3963 (create_account): Add boolean enable parameter, so we can specify FALSE
3964 to create the temporary account.
3965 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3966 (on_before_next): When finishing, when there is a temporary account, just
3968 Also, use a timeout to delay the showing of the dialog until gconf is likely
3969 to return correct information, due to a maemo gconf bug that is fixed in
3970 osso 1.1, but not yet in Bora.
3971 However, the dialog stays on screen after it is destroyed.
3973 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3974 for invalid data when cancelling. Use a hildon note instead of a dialog
3975 to complain about invalid data. Do not show the account-saved note if the
3976 account is disabled (a temporary account that will not really be saved for use
3979 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3981 * src/modest-account-mgr-helpers.h:
3982 * src/modest-account-mgr-helpers.c:
3983 Added modest_account_mgr_unset_default_account(),
3984 Added modest_account_mgr_set_first_account_as_default().
3986 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3987 If it was the default account, unset the default account name.
3989 * src/maemo/modest-account-view-window.c:
3990 (on_delete_button_clicked): If it was the default account,
3991 set the first remaining account as the default instead.
3993 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3994 a NULL account or a NULL default account, to prevent a crash. This should
3995 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3998 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4000 * src/widgets/modest-recpt-editor.c:
4001 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
4002 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
4003 TODO comment for this. This fixes the build.
4005 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
4006 be the best place for it. This will in future update all auto-update accounts,
4007 rather than just the current/default account, when that gconf key exists.
4008 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
4009 if there are no accounts, before calling do_send_receive().
4010 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
4012 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
4013 * src/maemo/modest-main-window-ui.h:
4014 * src/maemo/modest-main-window.c: (on_connection_changed),
4015 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
4016 directly, becaue the signal handler does more.
4018 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4020 * src/modest-account-mgr-helpers.c:
4021 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
4022 for the case that the account does not exist.
4024 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
4025 (equivalent to the modest account name) rather than the tinymail account name
4026 (equivalent to the modest account title - human readable) to get the account data.
4027 Check for null account data to prevent the crash, and add a TODO comment saying that
4028 this needs fixing because it is using the server account name instead of the account name.
4030 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4032 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
4033 * src/maemo/modest-account-settings-dialog.c: (show_error),
4035 Use hildon_note_new_information() for informative and error messages,
4036 which seems to be expected for Maemo applications (no documentation that I know of
4037 says this). I am surprised that there is no distinction between info and error
4040 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4042 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
4043 it is easy to find where this is used.
4045 * src/maemo/easysetup/modest-easysetup-wizard.c:
4046 (create_page_welcome), (create_page_account_details),
4047 (create_page_user_details), (create_page_complete_easysetup),
4048 (create_page_custom_incoming), (create_page_custom_outgoing),
4049 (create_page_complete_custom):
4050 * src/maemo/modest-account-settings-dialog.c:
4051 (create_page_account_details), (create_page_user_details),
4052 (create_page_incoming), (create_page_outgoing):
4053 * src/maemo/modest-account-view-window.c: (window_vbox_new):
4054 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4055 (modest_connection_specific_smtp_edit_window_init):
4056 * src/maemo/modest-connection-specific-smtp-window.c:
4057 (modest_connection_specific_smtp_window_init):
4058 * src/maemo/modest-signature-editor-dialog.c:
4059 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
4060 and scrolling policy as per the Email Application Layout Guide, if I have
4063 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4065 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
4066 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
4067 which were empty, because these vfuncs have been removed from TnyAccountStore.
4068 This fixes the build.
4070 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4072 * src/maemo/modest-main-window.c:
4073 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
4074 showing/hiding it. Added TODO because it probably should not be NULL.
4075 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
4076 because unnecessary g_warnings() make degugging difficult.
4078 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4080 * src/maemo/modest-msg-edit-window.c:
4081 (modest_msg_edit_window_select_color),
4082 (modest_msg_edit_window_select_background_color): 2 const corrections and
4083 moving 2 #endifs before closing brackets, to fix the build.
4085 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4087 * src/maemo/easysetup/modest-easysetup-wizard.h:
4088 * src/maemo/easysetup/modest-easysetup-wizard.c:
4089 (modest_easysetup_wizard_dialog_finalize),
4090 (on_button_edit_advanced_settings), (create_page_complete_custom),
4091 (on_response), (create_account):
4092 Implement the Advanced Settings edit button, by saving the account information,
4093 for the Advanded Settings dialog to use directly from gconf, and removing it
4094 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4095 Bug #5533 in the projects.maemo.org bugzilla.
4097 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4099 * src/maemo/modest-msg-view-window.c:
4100 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4101 when opening a message window.
4103 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4105 * src/maemo/easysetup/modest-easysetup-wizard.c:
4106 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4109 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4110 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4111 gconf settings. I probably added more checks than necessary, but that is safer.
4113 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4114 variable to fix the build, but this seems to be used when it is still NULL.
4116 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4118 * src/modest-platform.h:
4119 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4120 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4121 * src/modest-main.c: Implement this function so we can avoid using
4122 maemo-specific API from cross-platform code.
4124 * src/modest-tny-account-store.c:
4125 (get_smtp_specific_transport_account_for_open_connection):
4126 * src/modest-ui-actions.c: (check_for_connection),
4127 (modest_ui_actions_on_item_not_found):
4128 Use modest_platform_connect_and_wait() and put #idefs around other
4129 maemo-specific code, because only maemo currently has a way to
4130 identify connection names.
4132 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4134 * src/modest-tny-account-store.h:
4135 * src/modest-tny-account-store.c:
4136 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4137 the connection-specific SMTP server settings in the configuration.
4139 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4141 * src/maemo/modest-main-window.c: (on_connection_changed),
4143 * src/modest-main.c: (main), (start_ui), (send_mail):
4144 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4145 that is what is intended.
4147 * src/modest-ui-actions.c: (action_send), (action_receive),
4148 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4149 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4150 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4151 SMTP server is used when it is specified.
4153 (modest_ui_actions_on_send_receive):
4154 Check that a connection is open before proceeding.
4155 Receive and then send, instead of vice-versa, as per the specification.
4157 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4159 * src/modest-mail-operation.c:
4160 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4161 though I guess it should be something other than NULL.
4163 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4165 * src/maemo/easysetup/modest-easysetup-wizard.c:
4166 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4167 combo twice, to avoid an g_warning and to make it visible again.
4168 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4169 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4170 (already intended) dereference when detaching, because we then recreate the menu.
4171 But I am not sure why the warning was happening, and it is possible that this is a memory
4174 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4176 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4177 and uri_parse_mailto() utility functions.
4178 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4180 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4182 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4184 * src/dbus_api/modest-dbus-api.h:
4185 * src/dbus_api/modest-dbus-callbacks.c:
4186 Use an idle callback to execute the modest code in the application's own thread.
4187 Remove the helloworld example method.
4188 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4189 parsed, and the open-message method is not implemented because this is not yet implemented in
4191 * libmodest-dbus-client/libmodest-dbus-client.c:
4192 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4193 (libmodest_dbus_client_open_message):
4194 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4196 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4197 body without crashing.
4199 * tests/dbus_api/Makefile.am:
4200 * tests/dbus_api/test_mail_to.c:
4201 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4203 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4205 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4206 Added file to fix the build. Sorry.
4208 * src/dbus_api/Makefile.am:
4209 * src/dbus_api/modest-dbus-api.h:
4210 * src/dbus_api/modest-dbus-callbacks.h:
4211 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4212 (modest_dbus_req_handler):
4213 Put constants in a separate header so it can be reused by the
4214 client library, without duplication
4216 * libmodest-dbus-client/Makefile.am:
4217 * libmodest-dbus-client/libmodest-dbus-client.c:
4218 (libmodest_dbus_client_call_helloworld),
4219 (libmodfest_dbus_client_send_mail),
4220 (libmodfest_dbus_client_mailto),
4221 (libmodfest_dbus_client_open_message):
4222 * libmodest-dbus-client/libmodest-dbus-client.h:
4223 (Partly) Implement a send_mail D-Bus method.
4225 * tests/dbus_api/Makefile.am:
4226 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4227 the send_email D-Bus method.
4229 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4233 * libmodest-dbus-client/Makefile.am:
4234 * libmodest-dbus-client/libmodest-dbus-client.c:
4235 * libmodest-dbus-client/libmodest-dbus-client.h:
4236 * tests/dbus_api/Makefile.am:
4237 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4238 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4240 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4242 * src/maemo/easysetup/modest-easysetup-wizard.c:
4243 (create_page_account_details):
4244 * src/maemo/modest-account-settings-dialog.c:
4245 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4246 widgets, because this might not be the default in future versions of the Maemo GTK+.
4247 However, I can not not get capitalization to work even in a simple test case.
4249 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4251 * src/maemo/easysetup/modest-easysetup-wizard.c:
4252 (create_page_custom_incoming), (create_page_custom_outgoing):
4253 * src/maemo/modest-account-settings-dialog.c:
4254 (create_page_account_details), (create_page_incoming),
4255 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4256 instead of using gtk_check_button_with_label(), so they are aligned like the other
4257 widgets, as per the UI spec.
4259 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4261 * src/maemo/easysetup/modest-easysetup-wizard.c:
4262 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4263 * src/widgets/modest-validating-entry.c:
4264 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4265 Modest prefix instead of an EasySetup prefix.
4267 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4269 * src/widgets/modest-validating-entry.h:
4270 * src/widgets/modest-validating-entry.c: (on_insert_text),
4271 Added easysetup_validating_entry_set_max_func(), used to set a callback
4272 to call when the max number of characters is reached. GtkEntry has a max-length
4273 already but is silent about it.
4275 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4276 (create_page_account_details), (create_page_user_details),
4278 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4279 (create_page_account_details), (create_page_user_details),
4280 (create_page_outgoing):
4281 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4282 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4283 the UI spec, when the user tries to enter more than the max number of characters.
4285 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4287 * src/maemo/easysetup/modest-easysetup-wizard.c:
4288 (create_page_user_details), (create_page_custom_incoming),
4289 (create_page_custom_outgoing):
4290 * src/maemo/modest-account-settings-dialog.c:
4291 (create_page_user_details), (create_page_incoming),
4292 (create_page_outgoing):
4293 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4294 (modest_connection_specific_smtp_edit_window_init):
4295 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4296 not appropriate. Bad Maemo-specific defaults!.
4298 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4300 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4301 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4302 (modest_signature_editor_dialog_set_settings):
4303 Disable the label and textview when the checkbox is disabled, and use the
4304 specified (UI spec) default signature text.
4306 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4308 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4309 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4311 * src/modest-defs.h:
4312 * src/modest-account-mgr-helpers.h:
4313 * src/modest-account-mgr-helpers.c:
4314 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4316 * src/maemo/Makefile.am:
4317 * src/maemo/modest-signature-editor-dialog.c:
4318 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4321 * src/maemo/modest-account-settings-dialog.h:
4322 * src/maemo/modest-account-settings-dialog.c:
4323 (modest_account_settings_dialog_finalize), (on_button_signature),
4324 (save_configuration): Use the new dialog when the Edit button is pressed, and
4325 save the changes if necessary, as per the UI spec.
4327 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4329 * src/maemo/Makefile.am:
4330 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4331 based on maemo-develoers email from Dirk.
4333 * src/maemo/easysetup/modest-easysetup-wizard.c:
4334 (create_page_welcome), (create_page_account_details),
4335 (create_page_user_details), (create_page_complete_easysetup),
4336 (create_page_custom_incoming), (create_page_custom_outgoing),
4337 (create_page_complete_custom),
4338 (modest_easysetup_wizard_dialog_init):
4339 * src/maemo/modest-account-settings-dialog.c:
4340 (create_page_account_details), (create_page_user_details),
4341 (create_page_incoming), (create_page_outgoing),
4342 (modest_account_settings_dialog_init):
4343 * src/maemo/modest-connection-specific-smtp-window.c:
4344 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4346 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4348 * src/maemo/easysetup/modest-easysetup-wizard.c:
4349 (create_page_account_details), (create_page_custom_outgoing),
4350 (create_page_complete_custom):
4351 * src/maemo/modest-account-settings-dialog.c:
4352 (create_page_user_details), (create_page_incoming),
4353 (create_page_outgoing):
4354 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4355 (modest_connection_specific_smtp_edit_window_init):
4356 Use the correct (UI spec) port min/max, and use horizontal separators,
4359 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4361 * src/maemo/easysetup/modest-easysetup-wizard.c:
4362 (set_default_custom_servernames):
4363 * src/maemo/modest-account-settings-dialog.c:
4364 (create_page_incoming), (on_combo_outgoing_security_changed),
4365 (on_combo_incoming_security_changed), (create_page_outgoing),
4366 (modest_account_settings_dialog_set_account_name),
4367 (save_configuration):
4368 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4369 (on_combo_security_changed),
4370 (modest_connection_specific_smtp_edit_window_init),
4371 (modest_connection_specific_smtp_edit_window_set_connection),
4372 (modest_connection_specific_smtp_edit_window_get_settings):
4373 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4376 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4379 * src/maemo/easysetup/modest-easysetup-wizard.c:
4380 (create_page_custom_outgoing), (create_page_complete_custom):
4381 * src/maemo/modest-account-settings-dialog.c:
4382 (create_page_user_details), (create_page_outgoing):
4383 * src/maemo/modest-account-view-window.c: (button_box_new):
4384 Use changed logical IDs as per the most recent UI spec:
4385 mcen_bd_emailsetup_edit -> mcen_bd_edit
4386 mcen_bd_emailsetup_delete -> mcen_bd_delete
4387 mcen_bd_emailsetup_close -> mcen_bd_close
4389 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4393 * src/dbus_api/Makefile.am:
4394 * src/dbus_api/modest-dbus-callbacks.c:
4395 * src/dbus_api/modest-dbus-callbacks.h:
4396 * src/maemo/modest-platform.c: (modest_platform_init):
4397 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4399 * tests/Makefile.am:
4400 * tests/dbus_api/Makefile.am:
4401 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4403 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4405 * src/maemo/modest-account-settings-dialog.c:
4406 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4407 Removed unnecessary includes.
4409 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4411 * src/maemo/easysetup/modest-easysetup-wizard.c:
4412 * src/maemo/modest-account-settings-dialog.c:
4413 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4414 * src/widgets/Makefile.am:
4415 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4416 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4417 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4418 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4419 * src/widgets/modest-secureauth-combo-box.c:
4420 * src/widgets/modest-secureauth-combo-box.h:
4421 * src/widgets/modest-serversecurity-combo-box.c:
4422 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4423 made the GObject names more consistent with the rest of the Modest code.
4425 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4427 * src/maemo/easysetup/Makefile.am:
4428 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4429 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4430 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4431 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4432 * src/maemo/easysetup/modest-easysetup-wizard.c:
4433 * src/maemo/easysetup/modest-validating-entry.c:
4434 * src/maemo/easysetup/modest-validating-entry.h:
4435 * src/maemo/modest-account-settings-dialog.c:
4436 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4437 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4438 widgets/ because they are used outside of easysetup too. After checking in,
4439 svn will allow me to rename them too.
4441 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4443 * src/gnome/modest-msg-edit-window.c:
4444 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4445 linker error, to fix the build on the GNOME platform.
4446 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4447 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4448 ifdefed out to avoid a warning.
4450 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4452 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4453 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4454 some alternative for GTK+ 2.6.
4456 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4458 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4460 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4461 specified for EmailAccountsDialog in UI spec.
4463 * src/maemo/easysetup/modest-easysetup-wizard.c:
4464 * src/maemo/easysetup/modest-easysetup-wizard.h:
4465 * src/maemo/modest-account-settings-dialog.c:
4466 * src/maemo/modest-account-settings-dialog.h:
4467 Reuse a member window widget for the connection-specific SMTP server accounts,
4468 so we can tell it to create/save the accounts only if we actually save changes.
4470 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4471 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4472 (modest_connection_specific_smtp_edit_window_get_settings):
4473 Return a struct instance for temporarily remembering the entered data.
4475 * src/maemo/modest-connection-specific-smtp-window.h:
4476 * src/maemo/modest-connection-specific-smtp-window.c:
4477 (modest_connection_specific_smtp_window_finalize),
4478 (modest_connection_specific_smtp_window_fill_with_connections),
4480 (modest_connection_specific_smtp_window_save_server_accounts),
4481 (update_model_server_names): Do not actually save data until asked,
4482 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4484 (on_selection_changed),
4485 (modest_connection_specific_smtp_window_init): Disable the edit
4486 button when nothing is selected.
4488 * src/modest-account-mgr-helpers.c:
4489 * src/modest-account-mgr-helpers.h:
4490 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4493 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4495 * src/modest-account-mgr-helpers.h:
4496 * src/modest-account-mgr-helpers.c:
4497 (modest_account_mgr_get_unused_account_name),
4498 (modest_account_mgr_get_unused_account_display_name): Added these
4499 utility functions, to avoid code duplication.
4501 * src/maemo/easysetup/modest-easysetup-wizard.c:
4502 (create_page_account_details), (create_account):
4503 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4504 (on_combo_security_changed),
4505 (modest_connection_specific_smtp_edit_window_init),
4506 (modest_connection_specific_smtp_edit_window_save_settings):
4507 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4508 * src/maemo/modest-connection-specific-smtp-window.c:
4509 (modest_connection_specific_smtp_window_finalize),
4510 (modest_connection_specific_smtp_window_fill_with_connections),
4511 (on_button_edit), (modest_connection_specific_smtp_window_init):
4512 * src/maemo/modest-connection-specific-smtp-window.h:
4513 Implementing saving of connection-specific server accounts.
4515 But I need to refactor this so we can save the data for each
4516 possible connection-specific account and only actually create the server accounts
4517 when the easysetup finished, or the OK button is pressed on the account settings
4520 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4522 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4523 (on_combo_security_changed):
4524 (modest_connection_specific_smtp_edit_window_init):
4525 Auto-fill the port number as in the account settings.
4527 (modest_connection_specific_smtp_edit_window_set_connection):
4528 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4529 * src/maemo/modest-connection-specific-smtp-window.c:
4530 (fill_with_connections), (on_button_edit),
4531 (modest_connection_specific_smtp_window_init):
4532 Turn the edit window into a dialog to simplify the code, and
4533 set a WM hint as in a GtkDialog, because only a popup can be on top of
4534 another window in Maemo, and popups usually have no WM decoration.
4536 * src/modest-defs.h:
4537 * src/modest-account-mgr-helpers.c:
4538 (modest_account_mgr_set_connection_specific_smtp),
4539 (modest_account_mgr_remove_connection_specific_smtp),
4540 (modest_account_mgr_get_connection_specific_smtp):
4541 * src/modest-account-mgr-helpers.h: Some functions to write the
4542 connection-specific SMTP server information. Not yet used.
4545 * src/widgets/modest-folder-view.c: (text_cell_data):
4546 Fix a warning about an uninitialized variable.
4547 (on_configuration_key_changed): Put an #ifdef around the use
4548 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4550 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4552 * src/maemo/modest-account-settings-dialog.h:
4553 * src/maemo/modest-account-settings-dialog.c:
4554 Added connect_for_modified() utility function to mark the new modified boolean.
4556 (create_page_account_details), (create_page_user_details),
4557 (create_page_incoming), (create_page_outgoing), (on_response),
4558 (modest_account_settings_dialog_init),
4559 (modest_account_settings_dialog_set_account_name):
4560 Only warn about unsaved changes when there are actually unsaved changes.
4562 * src/modest-account-mgr-helpers.c:
4563 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4564 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4565 to get the data from there in future.
4567 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4569 * src/modest-defs.h:
4571 * src/modest-account-mgr-helpers.h:
4572 * src/modest-account-mgr-helpers.c:
4573 Store the security account setting in a single conf key instead of using
4574 the options list, so that the list is left for just the to-be-removed camel hack,
4575 and because gconf_client_set_list() is failing for some reason.
4577 * src/modest-account-mgr.c:
4578 (modest_account_mgr_add_server_account):
4579 * src/maemo/modest-account-settings-dialog.c:
4580 (modest_account_settings_dialog_set_account_name),
4581 (save_configuration): Use the renamed functions.
4584 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4586 * src/widgets/Makefile.am:
4587 * src/widgets/modest-limit-retrieve-combo-box.c:
4588 * src/widgets/modest-limit-retrieve-combo-box.h:
4589 * src/widgets/modest-retrieve-combo-box.c:
4590 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4591 the account settings dialog.
4593 * src/modest-defs.h:
4594 * src/modest-account-mgr-helpers.h:
4595 * src/modest-account-mgr-helpers.c:
4596 (modest_server_account_get_option_secure_auth),
4597 (modest_server_account_set_option_secure_auth):
4598 * src/modest-account-mgr.c:
4599 (modest_account_mgr_add_server_account):
4600 Use the existing AUTH_MECH conf key for the secure-auth setting,
4601 instead of putting it in the list options, because this was actually used already.
4603 * src/maemo/modest-account-settings-dialog.c:
4604 (create_page_account_details),
4605 (modest_account_settings_dialog_set_account_name),
4606 (save_configuration):
4607 * src/maemo/modest-account-settings-dialog.h:
4608 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4609 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4611 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4613 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4614 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4615 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4617 * src/modest-defs.h:
4618 * src/maemo/modest-account-settings-dialog.c:
4619 (create_page_incoming), (on_combo_outgoing_security_changed),
4620 (on_combo_incoming_security_changed), (create_page_outgoing),
4621 (modest_account_settings_dialog_set_account_name),
4622 (save_configuration): Load/Save the port number, and change it when the
4623 security combo changes, to suitable defaults.
4625 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4627 * src/modest-account-mgr.c:
4628 (modest_account_mgr_add_server_account): Set the security and secure-auth
4629 options, and add a comment saying that the other camel-specific options should be
4632 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4634 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4636 * src/modest-tny-account-store.c: (account_list_free),
4637 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4638 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4641 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4643 * src/modest-protocol-info.c:
4644 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4645 is required by our UI spec. Maybe something in our implementation will use this eventually.
4646 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4647 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4648 instead of the previous 0 placeholder.
4650 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4651 secure-auth settings.
4652 * src/modest-account-mgr-helpers.h:
4653 * src/modest-account-mgr-helpers.c:
4654 (modest_server_account_data_get_option_secure_auth),
4655 (modest_server_account_set_option_secure_auth),
4656 (modest_server_account_data_get_option_security),
4657 (modest_server_account_set_option_security): Added this API for getting and setting the security
4658 and secure-auth settings.
4660 * src/maemo/modest-account-settings-dialog.h:
4661 * src/maemo/modest-account-settings-dialog.c:
4662 (modest_account_settings_dialog_finalize), (check_data),
4663 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4664 about changing titles.
4665 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4666 (save_configuration): Save the security and secure-auth settings.
4668 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4669 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4671 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4673 * src/modest-defs.h:
4674 * src/modest-account-mgr.c:
4675 (modest_account_mgr_add_server_account):
4676 Added and used defines for the options key and value pair strings,
4677 that are used so far, though they do not seem to correspond to anything in our
4678 UI specs or ModestProtocol enum.
4680 * src/modest-account-mgr-helpers.h:
4681 * src/modest-account-mgr-helpers.c:
4682 (compare_option_strings_for_name),
4683 (modest_server_account_data_get_option_value),
4684 (modest_server_account_data_get_option_bool),
4685 (modest_account_mgr_get_server_account_option):
4686 Added helper functions for parsing the options GSList.
4688 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4690 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4691 display name is based on the supplied account name.
4692 * src/modest-account-mgr.c:
4693 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4694 with an inefficient, but good-enough, implementation.
4696 * src/maemo/easysetup/modest-easysetup-wizard.c:
4697 (create_page_account_details), (on_before_next), (create_account):
4698 Check for existing display names rather than (non-user-visible) account names, and just
4699 create and set a unique account name at the end.
4701 * src/maemo/modest-account-settings-dialog.c:
4702 (modest_account_settings_dialog_init),
4703 (modest_account_settings_dialog_set_account_name),
4704 (create_page_incoming): Show the display name, instead of the account name.
4705 (on_response): Do some (not all) extra checks, as in the UI spec.
4706 (save_configuration): Save the display name if it was changed.
4708 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4710 * po/en_GB.po: Added needed logical ID and translation.
4711 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4712 (init_view): Made the is-default column clicking work.
4714 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4717 * src/maemo/easysetup/Makefile.am:
4718 * src/maemo/easysetup/modest-easysetup-wizard.c:
4719 (modest_easysetup_wizard_dialog_init):
4720 * src/maemo/easysetup/provider-data-test.keyfile:
4721 * src/maemo/easysetup/provider-data.keyfile:
4722 Moved the provider data file to the new modest-providers-data package and used it from there.
4724 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4726 * src/modest-local-folder-info.c:
4727 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4728 N_() was already used on the static strings, but this just marks it for translation without
4729 using the translation.
4731 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4733 * src/maemo/modest-account-settings-dialog.c:
4734 (create_page_incoming),
4735 (modest_account_settings_dialog_set_account_name):
4736 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4737 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4738 I will do this if nobody else gets there first.
4740 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4742 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4743 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4744 save the security stuff.
4746 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4748 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4749 Set the email address and user fullname, which I now see must be
4752 * src/maemo/modest-account-settings-dialog.h:
4753 * src/maemo/modest-account-settings-dialog.c:
4755 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4756 leave-on-server and authentication.
4757 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4760 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4763 * src/maemo/modest-account-settings-dialog.c:
4764 * src/maemo/modest-account-settings-dialog.h:
4765 Most (but not all) of the widgets are now present as specified by the UI spec.
4766 No changes are yet saved, and some details are not properly shown yet.
4768 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4770 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4772 * src/maemo/Makefile.am:
4773 * src/maemo/modest-account-settings-dialog.c:
4774 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4775 an existing account. Doesn't do much yet.
4777 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4778 Open the accounts settings dialog when Edit is clicked.
4780 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4782 * src/maemo/easysetup/Makefile.am:
4783 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4785 * src/maemo/easysetup/modest-easysetup-wizard.c:
4786 (modest_easysetup_wizard_dialog_init):
4787 Try to get the source directory from the build system,
4788 instead of hard-coding "./" into the source code, when opening our local
4789 copies of the configuration files.
4790 But this still fails when opening the wizard from the Accounts window,
4791 maybe because the working directory seems to change at runtime.
4792 So the wizard will fail the second time unless you copy the files into their
4793 proper locations - see the stdout warnings for the paths.
4795 (create_page_account_details),(on_before_next):
4796 Check for existing non-server accounts instead of server accounts,
4797 so the default account name is useful again, and to prevent trying to
4800 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4801 Show the wizard when New is clicked.
4803 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4804 (init_view): Show the column headers, and show the columns that are
4805 specified in the UI specs. However, something in Maemo's GTK+ prevents
4806 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4807 change the default account. This is despite unsetting the special properties.
4809 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4811 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4812 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4813 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4814 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4815 to make that clearer.
4816 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4818 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4820 * src/maemo/modest-account-view-window.c:
4821 (modest_account_view_window_init),
4822 (modest_account_view_window_new):
4823 Use the same buttons as specified in the
4824 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4825 the existing widgets, which never had a chance of working.
4826 Put the ModestAccountView treeview in a scrolled window.
4827 Do not repeat the initialization in both _init() and _new().
4829 * src/widgets/modest-account-view.c: (update_account_view):
4830 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4831 this widget and window shows no accounts.
4833 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4835 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4837 * src/maemo/easysetup/modest-easysetup-wizard.c:
4838 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4839 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4840 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4843 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4844 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4845 accounts exist yet, as in the UI spec.
4847 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4849 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4851 * src/maemo/Makefile.am:
4852 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4853 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4854 New window for editing connection-specific smtp details.
4855 Not fully implemented.
4857 * src/maemo/modest-connection-specific-smtp-window.c:
4858 (modest_connection_specific_smtp_window_finalize) :
4859 unref the tree model.
4860 (on_button_edit): Show the edit window.
4862 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4864 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4867 * src/maemo/Makefile.am:
4868 * src/maemo/modest-connection-specific-smtp-window.c:
4869 * src/maemo/modest-connection-specific-smtp-window.h:
4870 New window for showing the list of connections, for connection-specific
4871 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4872 * src/maemo/easysetup/modest-easysetup-wizard.c:
4873 (create_page_custom_outgoing): Show the new window when the button is clicked.
4875 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4877 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4878 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4879 * src/maemo/modest-msg-edit-window.c:
4880 (modest_msg_edit_window_insert_image):
4881 * src/modest-conf.c: (modest_conf_key_escape):
4882 * src/modest-mail-operation.c:
4883 (modest_mail_operation_send_new_mail):
4884 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4885 (modest_ui_actions_on_new_account):
4886 * src/widgets/modest-attachment-view.c: (update_filename_request):
4887 * src/widgets/modest-mail-header-view.c:
4888 Corrected warnings that were breaking the build, by commenting out unused variables,
4889 and a function, and by including a header.
4891 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4893 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4894 so we can #ifdef around platform-specific code when necessary.
4895 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4896 to allow this to build for the GNOME platform too.
4898 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4900 * src/maemo/easysetup/modest-easysetup-wizard.c:
4901 Added util_increment_name() and used it in create_page_account_details()
4902 to make sure that the default account name is always a new name.
4904 (modest_easysetup_wizard_dialog_init),
4905 (set_default_custom_servernames): Some minor memory management fixes.
4907 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4911 * src/modest-runtime.c: (init_i18n): Restored the translation
4912 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4913 are defined in config.h, and the translations are installed.
4915 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4916 is defined for translation.
4918 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4920 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4922 * src/maemo/easysetup/modest-easysetup-wizard.c:
4923 (modest_easysetup_wizard_dialog_init):
4924 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4925 Use realistic paths (though they should use $prefix generically) to the
4926 mcc_mapping and provider-data.keyfile files which might work when they
4927 are installed by the future version of the operator-wizard package,
4928 and then fallback to paths in our source code, with an explanatory
4931 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4935 * src/maemo/Makefile.am:
4936 * src/maemo/easysetup/: Added files from the previously-exernal
4937 osso-modest-easysetup.
4938 * src/maemo/modest-main-window-ui.h:
4939 * src/modest-ui-actions.c:
4940 * src/modest-ui-actions.h:
4941 Added modest_ui_actions_on_new_account() as a signal handler for the
4942 New Account menu item. It shows the easysetup wizard.
4943 * po/en_GB.po: Added additional needed logical IDs and translations.