1 2007-07-11 Armin Burgmeier <armin@openismus.com>
3 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
4 priv->reselect to FALSE prior to calling
5 modest_folder_view_select_first_inbox_or_local() to prevent endless
6 recursion and thus a crash on startup.
8 2007-07-11 Armin Burgmeier <armin@openismus.com>
10 * src/maemo/modest-account-settings-dialog.h: Include
11 <gtk/gtknotebook.h> to fix the build (at least for me).
13 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
14 Use "New FolderN" as default suggested name if "New folder" already
15 exists, with N being the first free number, though never exceed "New
16 folder99" in which case we just fall back to "New Folder" even though
17 it already exists. This fixes projects.maemo.org bug NB#58663.
19 2007-07-11 Murray Cumming <murrayc@murrayc.com>
21 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
22 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
23 projects.maemo.org bug NB#62778.
25 2007-07-11 Murray Cumming <murrayc@murrayc.com>
27 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
28 Ignore the wrong (for now) secure-smtp setting in the presets -
29 just default to requiring secure authentication for SMTP, because
32 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
34 * src/widgets/modest-folder-view.c: (filter_row)
35 Do not show drafts folder (see UI specs)
37 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
39 * src/modest-ui-actions.c:
40 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
41 place and also not necessary.
43 * src/widgets/modest-folder-view.c: (filter_row)
44 Guess folder type and hide Sent & Outbox if necessary.
45 Fixed project.maemo.org NB#57328
47 2007-07-11 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-ui-actions.h:
50 * src/modest-ui-actions.c:
51 (modest_ui_actions_on_delete_message):
52 Move some code into a new
53 modest_ui_actions_refresh_message_window_after_delete()
54 function so we can use it from elsewhere.
56 * src/dbus_api/modest-dbus-callbacks.c:
57 (on_idle_delete_message), (on_delete_message): Used an idle
58 handler, as we do for the other D-Bus method handlers.
59 Call modest_ui_actions_refresh_message_window_after_delete()
60 if the deleted message was open in a window. This fixed
61 projects.maemo.org bug NB#62862.
63 2007-07-11 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-main.c: (main): Only show the UI at the start if
66 the showui command line option was given. For instance,
67 run-standalone src/modest showui
68 Otherwise, we wait for the top_application D-Bus method to
69 be sent by hildon-desktop when the application is selected
71 This allows us to run without a UI when osso-global-search
72 uses our D-Bus methods.
74 2007-07-11 Murray Cumming <murrayc@murrayc.com>
76 * src/dbus_api/modest-dbus-api.h: Added a define for a
77 top-application D-Bus method.
78 * src/dbus_api/modest-dbus-callbacks.c:
80 (modest_dbus_req_handler): Handle the top-application D-Bus
81 method, which might be an undocumented D-Bus signal sent by
82 hildon-desktop when it starts the application from the menu.
83 But I am not sure and I need to test it on the device, because
84 my scratchbox does not have the application in the menu now.
85 This method shows the main window, so that it can be invisible
86 when started, for instance, just for email searching from
89 * src/maemo/modest-main-window.c: (restore_settings),
90 (modest_main_window_new): Do not show the window immediately
91 upon creation. We show it later.
92 * src/modest-widget-memory.c: (save_settings_paned):
93 Try (unsuccessfully) to avoid saving the paned position when
94 it is not even visible.
95 (restore_settings_paned): Do not allow a silly paned position.
96 This seems necessary when not showing the window at first.
98 * tests/dbus_api/Makefile.am:
99 * tests/dbus_api/test_top_application.c: (main): Test for the
102 2007-07-10 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-ui-dimming-rules.c:
105 (modest_ui_dimming_rules_on_new_msg),
106 (modest_ui_dimming_rules_on_reply_msg),
107 (modest_ui_dimming_rules_on_delete_msg),
108 (modest_ui_dimming_rules_on_details),
109 (modest_ui_dimming_rules_on_view_window_move_to),
110 (modest_ui_dimming_rules_on_view_previous),
111 (modest_ui_dimming_rules_on_view_next),
112 (_invalid_folder_for_purge): Added checks before
113 casting the window. This looks like an actual
114 logic error in _invalid_folder_for_purge(), because it
115 tries to use a ModestMainWindow as a message window.
117 2007-07-10 Murray Cumming <murrayc@murrayc.com>
119 * src/maemo/modest-account-settings-dialog.c:
120 (show_error): Use the same implementation as in
121 modest-easysetup-wizard.c:
122 (on_entry_invalid_character): The logical ID contains a %s.
123 Guessed what it should be.
124 (on_entry_max), (check_data), (on_response): Adapt to
125 changed show_error().
126 (create_page_account_details): Really call
127 modest_validating_entry_set_func() on the correct widgets.
128 * src/maemo/easysetup/modest-easysetup-wizard.c:
129 (on_entry_invalid_character): Fix the logical ID here too.
130 (create_page_account_details),
131 (create_page_user_details):
133 modest_validating_entry_set_func() on the correct widgets.
135 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
136 Do not try to use the account if it is NULL.
138 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
140 * src/modest-ui-actions.c: (create_move_to_dialog),
141 (modest_ui_actions_on_main_window_move_to),
142 (modest_ui_actions_on_msg_view_window_move_to):
143 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
144 (filter_row), (modest_folder_view_show_non_move_folders):
145 * src/widgets/modest-folder-view.h:
147 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
148 the Sent folder yet as it does not report the correct folder type.
150 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
152 * src/maemo/modest-msg-edit-window.c: (init_window):
155 2007-07-10 Murray Cumming <murrayc@murrayc.com>
157 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
158 Take a parent widget instead of a parent window, and
159 implement this with hildon_banner_show_information() instead.
160 Non-Maemo builds can just ifdef that there.
161 This fixed projects.maemo.org bug NB#62766.
163 (on_entry_invalid_character): Use show_error() again instead
164 of using hildon directly, and use the _CS() macro to use the correct
166 (create_account), (check_for_supported_auth_methods), (on_entry_max):
167 Pass a widget instead od a window to show_error().
169 2007-07-10 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
172 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
173 This allows us to show the server name in the error message, fixing
174 projects.maemo.org bug NB#62904.
175 Also, use the appropriate logical ID message for the account protocol.
177 2007-07-10 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-tny-account-store.c: (on_idle_wrong_password):
180 A compilation fix, though the build wasn't broken for me.
182 2007-07-09 Murray Cumming <murrayc@murrayc.com>
184 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
185 Do not try to unref a NULL folder store, to avoid a runtime warning.
186 This seems to happen sometimes when changing accounts settings.
188 2007-07-09 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-tny-account-store.c:
191 (modest_tny_account_store_instance_init),
192 (modest_tny_account_store_finalize),
193 (on_account_settings_hide), (on_idle_wrong_password):
194 Use a GHashTable to ensure that we only show one account settings
195 dialog per modest account. This avoids us having a dialog open for
196 both the store and transport accounts, or due to repeated get_password()
197 calls that shouldn't happen anyway.
199 2007-07-09 Murray Cumming <murrayc@murrayc.com>
201 * src/maemo/modest-maemo-utils.c: (on_hide),
202 (modest_maemo_show_dialog_and_forget): Handle the response, because
203 the window is not even hidden by default.
205 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
206 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
207 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
208 which seems to prevent some modality problems.
210 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
211 Ignore user cancellation errors.
213 * src/modest-account-mgr-helpers.h:
214 * src/modest-account-mgr-helpers.c:
215 Added modest_server_account_get_password() and
216 modest_server_account_get_has_password() to avoid direct use of
219 * src/maemo/modest-account-settings-dialog.h:
220 * src/maemo/modest-account-settings-dialog.c:
221 (modest_account_settings_dialog_init): Store the notebook so we can
223 Added modest_account_settings_dialog_switch_to_user_info().
225 * src/modest-tny-account-store.c:
226 (get_password): When the password in the account settings is wrong (we think),
227 show the relevant page of the account settings dialog, in the mainloop.
228 However, we currently get many of these at once because cancel does not
230 (forget_password): Do not forget the password
231 from the account settings, because this causes side-effects when
232 tinymail seems to call it at strange time, maybe because of how we
233 are cancelling get_password().
234 (modest_tny_account_store_alert): Ignore user cancellations.
236 2007-07-09 Murray Cumming <murrayc@murrayc.com>
238 * src/maemo/modest-maemo-utils.h:
239 * src/maemo/modest-maemo-utils.c:
240 Added modest_maemo_show_information_note_and_forget() for use instead of
241 gtk_dialog_run() when the response is not needed, to avoid an extra
242 mainloop which could cause a hang.
244 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
245 Use the logical IDs for the error message, though they are not
246 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
247 because gtk_dialog_run() caused a hang here (the window did not close).
248 This fixes projects.maemo.org bug NB#62646.
250 2007-07-09 Murray Cumming <murrayc@murrayc.com>
252 * src/modest-account-mgr-helpers.h:
253 * src/modest-account-mgr-helpers.c:
254 Added modest_account_mgr_get_store_protocol().
256 * src/maemo/modest-account-view-window.c:
257 (on_delete_button_clicked): Show different warning text depending on
258 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
259 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
262 2007-07-09 Murray Cumming <murrayc@murrayc.com>
264 * src/maemo/modest-msg-edit-window.c:
265 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
266 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
268 2007-07-07 Armin Burgmeier <armin@openismus.com>
270 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
271 ckdg_ib_maximum_characters_reached from correct package.
273 * src/modest-ui-actions.c: Show an error message when a folder could
274 not be created. Tinymail does not give us specific error codes about
275 what has gone wrong, so we assume that a folder with that name
276 already exists, though there might be other reasons.
278 2007-07-06 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
281 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
282 give a more exact error message that can be partly translated.
284 2007-07-05 Murray Cumming <murrayc@murrayc.com>
286 * src/maemo/modest-address-book.c:
287 (select_email_addrs_for_contact): Specify a default window size for the
288 select-email-address dialog, so that it is probably big enough for the
289 title. This should fix projects.maemo.org bug NB#62277.
291 2007-07-05 Murray Cumming <murrayc@murrayc.com>
293 * src/maemo/easysetup/modest-easysetup-wizard.c:
294 (create_page_complete_easysetup): Use
295 gtk_widget_set_size() request to ensure that the text wraps
298 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
300 * src/maemo/easysetup/modest-easysetup-wizard.c:
301 (on_entry_invalid_character), (create_page_account_details),
302 (create_page_user_details):
303 Use new API of ModestValidatingEntry. But for some reason the banner is
304 not shown. I will have to investigate that further.
306 * src/widgets/modest-validating-entry.c: (on_insert_text),
307 (modest_validating_entry_set_func):
308 * src/widgets/modest-validating-entry.h:
309 Added a new callback function to be able to react to prevented
310 characters whitespaces to e.g show a banner.
312 2007-07-05 Armin Burgmeier <armin@openismus.com>
314 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
315 notification of HildonNumberEditor instead of remembering the port
316 number. Thanks to Johannes for pointing this out.
318 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
320 * src/maemo/easysetup/modest-easysetup-wizard.c:
321 Check if there are any user changes before showing a confirmation
322 dialog (projects.maemo.org NB#60946)
324 2007-07-05 Armin Burgmeier <armin@openismus.com>
326 * src/maemo/modest-account-settings-dialog.c: Remember custom port
327 number at the beginning of the dialog and set the modified flag at the
328 end if the port number has changed. This is necessary because
329 HildonNumberEditor does not support notification when the value has
332 2007-07-05 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-ui-actions.c:
335 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
336 a connection before asking anything else. Correct the check for the destination
337 folder so that it succeeds when online.
338 This fixed projects.maemo.org bug NB#61645.
340 2007-07-05 Murray Cumming <murrayc@murrayc.com>
342 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
343 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
344 to fix projects.maemo.org bug NB#62439.
346 2007-07-05 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-tny-account.c: (on_connection_status_changed):
349 Really do not use tny_device_force_offline() here. See the previous comment.
351 2007-07-04 Murray Cumming <murrayc@murrayc.com>
353 * src/modest-tny-account.c: (on_connection_status_changed):
354 Do not use tny_device_force_offline() when tinymail says that something
355 went wrong with the connection. It seems to report this unnecessarily.
357 2007-07-04 Murray Cumming <murrayc@murrayc.com>
359 * src/maemo/modest-connection-specific-smtp-window.c:
360 (modest_connection_specific_smtp_window_init):
361 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
362 does not seem to have any effect in osso 1.1 (though it works in
363 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
365 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
367 * src/maemo/modest-connection-specific-smtp-window.c:
368 Fix UI specification problems with projects.meamo.org NB#60479
370 2007-07-04 Murray Cumming <murrayc@murrayc.com>
372 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
373 clue when this has failed, because the error dialog is not always shown
374 (at least in earlier version).
376 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
377 GError message, because the generic error dialog is not helpful.
379 'This message is not currently available (can't let a new connection go online)'
380 when trying to open an IMAP message.
382 (_modest_ui_actions_open): Offer a connection when some messages would
383 have to be downloaded and we are offline.
385 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
387 * src/widgets/modest-folder-view.c:
388 Don't check for MERGE type anymore as we use the correct type
390 NOTE: For the last two changes you need to update your tinymail copy
391 because of API changes!
393 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
395 * src/modest-tny-local-folders-account.c:
396 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
397 (see projects.maemo.org NB#61580)
399 2007-07-04 Murray Cumming <murrayc@murrayc.com>
401 * src/modest-tny-account.c: (on_connection_status_changed):
402 Commented out the call to modest_platform_connect_and_wait() because this
403 seems to always hang, and I would like to know if this is the only thing
404 that causes a hang when showing the connection dialog.
405 It is not very useful anyway.
407 2007-07-04 Murray Cumming <murrayc@murrayc.com>
409 * src/maemo/modest-msg-view-window.c:
410 (modest_msg_view_window_select_next_message):
412 * src/modest-platform.h:
413 * src/maemo/modest-platform.c:
414 Added modest_platform_connect_and_wait(), which calls
415 tny_maemo_conic_device_connect() always in the main thread, by calling it
416 in an idle handler and waiting for the idle handler to run. It should be
417 in the main thread because it uses GTK+ UI code. It just returns TRUE
418 if the device is already online.
420 There is some nasty code to ensure that subsequent calls to
421 modest_platform_connect_and_wait() just wait for the first one to finish,
422 by checking repeatedly in another idle handler. This is necessary,
423 because other threads (or even the main thread, via another idle handler)
424 can call modest_platform_connect_and_wait() while
425 modest_platform_connect_and_wait() is running.
427 (modest_platform_connect_and_wait_if_network_account),
428 (modest_platform_connect_and_wait_if_network_folderstore):
429 Convenience functions that calls modest_platform_connect_and_wait() if
430 the account or folder might want network access.
432 * src/modest-mail-operation.c:
433 (modest_mail_operation_update_account):
434 * src/modest-ui-actions.c: (download_uncached_messages),
435 (modest_ui_actions_on_rename_folder), (delete_folder),
436 (modest_ui_actions_on_main_window_move_to),
437 (modest_ui_actions_on_msg_view_window_move_to):
438 * src/widgets/modest-folder-view.c:
439 (drag_and_drop_from_folder_view):
440 Offer a connection if we are offline.
442 * src/modest-tny-account.c: (on_connection_status_changed):
443 Document this as only handling errors during network operations in progress,
444 and replace the idle code with a simple call to
445 modest_platform_connect_and_wait(), which does this instead.
447 2007-07-03 Murray Cumming <murrayc@murrayc.com>
449 * src/modest-tny-account.c:
450 (modest_tny_account_get_special_folder): (util_on_idle),
451 Handle the GError so we can see when tny_folder_store_get_folders()
452 fails, as it currently does while something else is connecting.
454 Added util_run_in_main_thread_and_wait()
455 which uses an idlen handler and mainloop to ensure that the function
456 is called in the main thread.
457 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
458 to make sure that we call attempt the connection in the mainloop only,
459 which might solve some hangs.
461 2007-07-03 Murray Cumming <murrayc@murrayc.com>
463 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
464 be found by their display name. This is never useful.
465 * src/modest-tny-account-store.c: (on_account_removed): Find the account
466 by its ID, instead of trying to use its ID as its display name.
468 * src/modest-tny-account-store.h:
469 * src/modest-tny-account.c:
470 (modest_tny_account_get_special_folder): Add a g_warning() when
471 tny_folder_store_get_folders() returns an empty list for the maildir.
473 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
474 Add a g_warning() when this returns NULL, because that it not allowed
477 2007-07-02 Armin Burgmeier <armin@openismus.com>
479 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
480 note when trying to cancel the wizard. This fixes projects.maemo.org
483 2007-07-02 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-tny-account.h:
486 * src/modest-tny-account.c:
487 (modest_tny_account_new_from_server_account),
488 (modest_tny_account_new_from_server_account_name),
489 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
490 because this must now be set before setting the proto. This is usd in
491 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
492 warning in camel_session_get_service() caused by
493 tny_camel_transport_account_prepare().
495 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
498 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
500 * src/maemo/modest-connection-specific-smtp-edit-window.c:
502 (modest_connection_specific_smtp_edit_window_init):
504 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
507 2007-06-29 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-tny-account.c:
510 (modest_tny_account_new_from_server_account):
511 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
512 now uses to request a connection when it needs one, and which it uses
513 to tell us that something is wrong with the connection, so we can force
514 the accounts offline to prevent further problems.
517 * src/modest-init.c: (init_default_settings):
518 * src/modest-mail-operation.c:
519 (modest_mail_operation_update_account):
520 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
521 This should not be necessary anymore. Do not set the conf key that
522 determined this (it was always TRUE and not set anywhere else).
524 * src/modest-ui-actions.h: Remove unused and unimplemented
525 modest_ui_actions_on_online_toggle_toggled().
527 2007-06-29 Murray Cumming <murrayc@murrayc.com
529 * src/maemo/modest-main-window.c: (connect_signals):
530 Don't connect to delete_event twice. Maybe this was harmless.
532 2007-06-29 Murray Cumming <murrayc@murrayc.com
534 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
535 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
536 Debug output to give some more clue when a folder move is not allowed.
538 2007-06-28 Murray Cumming <murrayc@murrayc.com
540 * src/modest-tny-account.c: (on_modest_file_system_info),
541 (modest_tny_account_get_mmc_account_name):
542 Always call the callback, without checking whether the name has changed.
543 * src/widgets/modest-folder-view.c: (strings_are_equal),
544 (on_model_foreach_set_name), (on_get_mmc_account_name),
545 (text_cell_data): Compare the name here, and use the name from
546 the account rather than from the
547 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
548 if the name was changed after the account was added to the model.
549 That's a tinymail bug but not one that I want to fix now.
551 This finally fixes projects.maemo.org bug NB#59301.
553 2007-06-27 Armin Burgmeier <armin@openismus.com>
555 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
558 2007-06-27 Murray Cumming <murrayc@murrayc.com
560 * src/modest-tny-account.h:
561 * src/modest-tny-account.c:
562 Added modest_tny_account_get_mmc_account_name(), to set the memory
563 card name asynchronously for the given account and then notify.
564 (modest_tny_account_new_for_local_folders): Use this new function instead
565 of using hildon_file_system_info_async_new() directly.
567 * src/widgets/modest-folder-view.c: (text_cell_data):
568 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
569 gtk_tree_model_row_changed() when it is available.
571 This should fix projects.maemo.org bug NB#59301.
573 2007-06-27 Murray Cumming <murrayc@murrayc.com
575 * src/modest-mail-operation.c: (update_account_thread),
576 (get_msgs_full_thread): Fix typo failures in the revert
579 2007-06-27 Murray Cumming <murrayc@murrayc.com
581 * src/maemo/modest-maemo-global-settings-dialog.c:
582 (idle_select_default_focus):
583 * src/modest-mail-operation.c: (idle_notify_progress),
584 (idle_notify_progress_once), (set_last_updated_idle),
585 (update_account_thread), (get_msgs_full_thread):
586 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
587 * src/widgets/modest-header-view.c:
588 (idle_notify_headers_count_changed_destroy),
589 (idle_notify_headers_count_changed):
590 Reverted the additions of gdk_threads_enter/leave(), in case this
591 helps with a startup hang on the device.
593 2007-06-26 Armin Burgmeier <armin@openismus.com>
595 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
596 for supported secure authentication methods from server by
597 gtk_dialog_run(), saving CPU time and a potential race condition.
599 2007-06-26 Armin Burgmeier <armin@openismus.com>
601 * src/maemo/modest-maemo-utils.h:
602 * src/maemo/modest-maemo-utils.c: Added a
603 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
604 only error code to tell the calling code when the user canceled the
607 * src/maemo/modest-account-settings-dialog.h:
608 * src/maemo/modest-account-settings-dialog.c:
609 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
610 message if the retrieval of secure authentication methods was canceled
611 by the user. Perform the check before saving anything to configuration
612 to not end up with half-committed configuration changes, do not show
613 a "Saving to configuration failed" note when authentication methods
614 could not be retrieved.
616 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
619 2007-06-26 Murray Cumming <murrayc@murrayc.com>
621 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
622 Only return the first level of folders under accounts, because the
623 osso-global-search UI spec doesn't want the rest.
624 This fixed projects.maemo.org bug NB#61811.
626 2007-06-26 Murray Cumming <murrayc@murrayc.com>
628 * src/modest-tny-account-store.c:
629 * src/modest-tny-account-store.h:
630 Added modest_tny_account_is_memory_card_account().
631 * src/maemo/modest-main-window.c: (create_details_widget):
632 Show the same information items for the memory card as we show for the
633 local-folders, to fix projects.maemo.org bug NB#59307.
635 2007-06-26 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-tny-account-store.c: (get_password):
638 Added some checks for NULL to maybe prevent crashes, though I think
639 it was Philip's last commit that actually prevented the crash here
640 when creating a first new account.
641 But the new account is still not usable (no messages are shown)
642 until a restart of the application.
644 2007-06-26 Murray Cumming <murrayc@murrayc.com>
646 * src/maemo/modest-maemo-global-settings-dialog.c:
647 (idle_select_default_focus):
648 * src/modest-mail-operation.c: (idle_notify_progress),
649 (idle_notify_progress_once), (idle_notify_update_account_queue),
650 (set_last_updated_idle), (update_account_thread),
651 (notify_get_msgs_full), (get_msgs_full_destroyer),
652 (get_msgs_full_thread):
653 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
654 * src/widgets/modest-header-view.c:
655 (idle_notify_headers_count_changed_destroy),
656 (idle_notify_headers_count_changed):
657 Use gdk_threads_enter() and gdk_threads_enter_leave() in
658 all idle handlers, because some other thread could be blocking
659 the GDK lock, so that it can do GUI stuff.
661 2007-06-26 Murray Cumming <murrayc@murrayc.com>
663 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
664 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
665 (on_idle_send_receive), (on_idle_open_default_inbox):
666 * src/maemo/modest-msg-edit-window.c:
667 (modest_msg_edit_window_attach_file_noninteractive):
668 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
669 to prevent a hang. I don't quite understand why these are necessary,
670 beause we should already be in the main loop. I guess something outside
671 of the main loop is taking the lock.
673 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
674 we are really using URIs, and use files that are more likely to exist.
676 2007-06-26 Murray Cumming <murrayc@murrayc.com>
678 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
679 necessary because configure.ac now defines different variables.
681 2007-06-26 Murray Cumming <murrayc@murrayc.com>
683 * libmodest-dbus-client/libmodest-dbus-client.c:
684 * libmodest-dbus-client/libmodest-dbus-client.h:
685 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
686 libmodest_dbus_client_compose_mail() is what things actually use.
688 * src/dbus_api/modest-dbus-api.h:
689 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
690 * tests/dbus_api/Makefile.am:
691 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
694 2007-06-26 Murray Cumming <murrayc@murrayc.com>
696 * src/modest-init.c: (modest_init_local_folders):
697 For memory-card (or other non local-folders) maildir accounts,
698 always create an Archive folder, so that there is somewhere to put
699 messages. This should be less confusing, because the user does not need
700 to guess that the need to create a folder.
702 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
704 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
705 Fixed icon size by using (50, 50) which is the same as defined by
708 2007-06-25 Armin Burgmeier <armin@openismus.com>
710 * src/widgets/modest-window-mgr.c:
712 * configure.ac: Correctly recognize hildon-notify presence and fixed
713 the build without it being installed.
715 2007-06-25 Murray Cumming <murrayc@murrayc.com>
717 * libmodest-dbus-client/libmodest-dbus-client.c:
718 (libmodest_dbus_client_search): Fix the build. Sorry.
719 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
720 (reply_forward_cb): Initialize variables to fix the build.
722 * src/modest-tny-account-store.c:
723 (modest_tny_account_store_get_tny_account_by): Fix the account URI
724 comparison (a silly typo) so that email search results can be opened
725 when there are more than one account.
727 2007-06-25 Murray Cumming <murrayc@murrayc.com>
729 * libmodest-dbus-client/libmodest-dbus-client.c:
730 (libmodest_dbus_client_search),
731 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
732 instead of 1 second, because the search gets folders and messages from
733 the server, which can take a long time. When it times out,
734 osso-global-search will report no results.
736 We need to specify whether we should search only cached information
737 (maybe with a user preference), and the osso-email-search-plugin
738 API should really be improved to allow that option, and to allow results
739 to be delivered asynchronously in batches.
741 2007-06-25 Murray Cumming <murrayc@murrayc.com>
743 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
744 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
745 GTK_ICON_SIZE_DIALOG is probably the wrong size.
747 2007-06-25 Murray Cumming <murrayc@murrayc.com>
749 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
750 that is an empty string. D-Bus seems to give us these instead of NULL.
752 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
754 * src/dbus_api/modest-dbus-callbacks.c:
755 * src/maemo/easysetup/modest-easysetup-wizard.h:
756 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
758 (modest_connection_specific_smtp_edit_window_init):
759 * src/maemo/modest-maemo-global-settings-dialog.c:
761 * src/maemo/modest-maemo-utils.c:
762 (modest_maemo_utils_setup_images_filechooser):
763 * src/maemo/modest-main-window.c: (create_details_widget):
764 * src/maemo/modest-msg-edit-window.c:
765 (modest_msg_edit_window_attach_file_noninteractive),
766 (modest_msg_edit_window_color_button_change),
767 (modest_msg_edit_window_set_zoom):
768 * src/modest-mail-operation.c: (update_account_thread):
769 * src/modest-tny-account-store.c:
770 * src/modest-tny-account.c:
771 * src/widgets/modest-global-settings-dialog.c:
772 * src/widgets/modest-window.h:
776 2007-06-25 Murray Cumming <murrayc@murrayc.com>
778 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
779 * src/modest-search.c: (modest_search_folder),
780 (modest_search_all_accounts): Actually search only in the specified folder,
781 doing a simple match on the folder ID.
782 * src/modest-search.h: Added a folder field to the ModestSearch struct,
783 and added some documentation.
785 2007-06-22 Armin Burgmeier <armin@openismus.com>
787 * src/maemo/modest-maemo-utils.h:
788 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
789 modest_maemo_utils_get_supported_secure_authentication_methods.
791 * src/maemo/easysetup/modest-easysetup-wizard.c:
792 * src/maemo/modest-account-settings-dialog.c: Show correct error if
793 one occured, not just "Server does not support secure authentication".
795 2007-06-22 Murray Cumming <murrayc@murrayc.com>
797 * src/modest-tny-account-store.c: (get_password):
798 Restored the call to tny_account_set_user() because Philip seems to have
799 stopped this from crashing (by not using the freed string). It still does
800 not work, but now we can test it.
802 2007-06-22 Murray Cumming <murrayc@murrayc.com>
804 * src/maemo/modest-msg-edit-window.c: (init_window):
805 Comment out use of an uninitialzed GtkScrolledWindow variable,
806 to fix the build and stop a crash. Yet again.
808 2007-06-22 Murray Cumming <murrayc@murrayc.com>
810 * src/modest-tny-account-store.c: (get_password):
811 Remove the call to tny_account_set_user() because this actually crashes.
812 As mentioned in the last commit, it is known to not work anyway.
814 2007-06-22 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-tny-account-store.c: (get_password):
817 Use tny_account_set_username() to tell tinymail that the username might
818 have changed too. But tinymail ignores this: see projects.maemo.org
820 * src/modest-ui-actions.c:
821 (modest_ui_actions_on_password_requested): Remove the useless attempt to
822 reset the connection when changing the username, and improve the comments.
823 Save the changed username to gconf at least, so it is used when Modest is
826 2007-06-21 Murray Cumming <murrayc@murrayc.com>
828 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
829 Do not use a query, so that we get all folders, including for POP and
830 local-folders. They work as search criteria too.
831 This fixes projects.maemo.org bug NB#57740.
833 2007-06-21 Murray Cumming <murrayc@murrayc.com>
835 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
836 Comment out the use of hildon_notification_set_sound() because it is
837 not declared, to fix the build. Warnings are serious, people.
839 2007-06-21 Armin Burgmeier <armin@openismus.com>
841 * src/maemo/modest-maemo-utils.h:
842 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
843 modest_maemo_utils_get_supported_secure_authentication_methods()
844 to query authentication methods for a specific user. This should fix
845 projects.maemo.org bug NB#61369.
847 * src/maemo/easysetup/modest-easysetup-wizard.c:
848 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
851 2007-06-21 Murray Cumming <murrayc@murrayc.com>
853 * libmodest-dbus-client/libmodest-dbus-client.h:
854 * libmodest-dbus-client/libmodest-dbus-client.c:
855 (modest_dbus_message_iter_get_search_hit),
856 (libmodest_dbus_client_search):
857 Reorganised and commented this.
858 Removed modest_search_hit_free() from the public API because it
861 Added libmodest_dbus_client_get_folders() and
862 modest_folder_result_list_free().
864 * src/dbus_api/modest-dbus-api.h:
865 * src/dbus_api/modest-dbus-callbacks.c:
866 (modest_dbus_req_filter): Commented. Moved most code to
867 on_dbus_method_search() and added on_dbus_method_get_folders().
869 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
870 of the extra D-Bus handler.
872 * tests/dbus_api/Makefile.am:
873 * tests/dbus_api/test_get_folders.c: New test for
874 libmodest_dbus_client_get_folders(). This seems to return an empty list
875 at the moment. That could be the same error that causes the message list
876 to be empty sometimes.
877 This should help with projects.maemo.org bug NB#57740.
879 2007-06-21 Armin Burgmeier <armin@openismus.com>
881 * src/modest-mail-operation.c: Do not call
882 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
883 notify the operation's end after having set the status to CANCELED for
884 the operation queue to listen on. This fixes a deadlock when there
885 were mail operations in the queue during its finalization.
887 * src/modest-singletons.c: Reordered uninitialization of the account
888 manager to happen after the mail operation queue was uninitialized
889 because the mail operation's in the queue might still try to access
890 the account manager (see modest_mail_operation_notify_end()). This
891 fixes a potential crash when terminating the application.
893 2007-06-21 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-search.c:
896 (search_mime_part_and_child_parts): Moved some code here so we
897 can search recursively in child folders.
898 (modest_search_folder): Search in the message as a mime part, instead
899 of just its child mime parts.
900 (read_chunk), (search_mime_part_ogs):
901 Check how many bytes were read, to prevent an endless loop.
902 Searching in message bodies now works. This finishes the fix for
903 projects.maemo.org bug NB#61007.
905 2007-06-20 Murray Cumming <murrayc@murrayc.com>
907 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
908 Add a g_warning when the item is not a folder.
910 * src/modest-ui-dimming-rules.c:
911 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
912 when selected item is not a folder (for instance, an account), because
913 the UI spec only talks about folders.
914 I am not sure what the UI spec wants, so this might not totally fix
915 projects.maemo.org bug NB#60794.
917 2007-06-20 Murray Cumming <murrayc@murrayc.com>
919 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
920 (load_from_file): Sort the list. The unsorted list would be more noticeable
921 in non-English locales.
923 * src/maemo/modest-msg-edit-window.c:
924 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
925 warning and fix the build.
927 * src/maemo/modest-progress-bar-widget.c:
928 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
929 avoid a g_warning, and probably to avoid a crash.
931 2007-06-20 Murray Cumming <murrayc@murrayc.com>
933 * src/modest-search.c: (modest_search_folder): Check for a GError
934 when calling tny_folder_get_headers(), to show that this is not the cause
937 2007-06-20 Murray Cumming <murrayc@murrayc.com>
939 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
940 Actually set the body query instead of the subject query.
942 * src/modest-search.c: (search_mime_part_ogs),
943 (search_mime_part_strcmp): Remove extra space from the text/* regex,
944 which would probably cause it to fail if we got this far.
946 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
947 to simplify the code.
948 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
949 be causing search-in-body to fail.
951 2007-06-20 Murray Cumming <murrayc@murrayc.com>
953 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
955 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
956 Better debug message when the folder cannot be found.
957 This should help with fixing projects.maemo.org bug #61287.
958 * src/modest-search.c: (add_hit): Do not leak the furl string.
960 2007-06-20 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-ui-actions.c:
963 (modest_ui_actions_on_folder_selection_changed):
964 Do not special-case TNY_MERGE_FOLDER here, because
965 modest_tny_folder_get_account() already does that. This fixes
966 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
967 shown when the Outbox was selected).
969 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
971 * libmodest-dbus-client/libmodest-dbus-client.c:
972 (_dbus_iter_get_string_or_null): Initialize the string variable in
973 case this helps with Dirk's crash.
975 2007-06-19 Murray Cumming <murrayc@murrayc.com>
977 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
978 though it is not implemented yet (this function is maybe not even used),
979 to avoid breaking ABI in future.
980 * libmodest-dbus-client/libmodest-dbus-client.c:
981 (get_attachments_string): Moved some code into this generic function.
982 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
983 sends email. It is maybe not used.
984 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
985 (on_send_mail): Use attachments.
987 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
988 * src/maemo/modest-msg-edit-window.c:
989 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
990 a filename before using it, to fix projects.maemo.org bug NB#58233.
992 2007-06-19 Murray Cumming <murrayc@murrayc.com>
994 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
995 Initialize the continue_download variable to fix the build, and probably
996 to fix randome behaviour.
998 2007-06-18 Armin Burgmeier <armin@openismus.com>
1000 * src/modest-tny-send-queue.h:
1001 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1002 the queue so we can later show it in the UI. Replaced
1003 modest_tny_send_queue_msg_is_being_sent() by
1004 modest_tny_send_queue_get_msg_status().
1006 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1008 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1009 gpointer. This probably was not harmful, but just to be sure.
1011 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1013 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1014 Fix the build, but leave the function broken on Bora, because
1015 hildon_uri_action_get_service() does not exist.
1016 osso_uri_action_get_service() does not exist either, it seems.
1018 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1020 * src/modest-tny-account.c:
1021 (modest_tny_account_new_from_server_account):
1022 Uncommented the url debug output again, because it is useful for
1023 debugging, as I said in the comment.
1025 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1027 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1029 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1030 for Mameo Bora, to fix the build.
1032 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1035 Fixed build with hildon < 0.99
1037 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1038 Check if the selected account is busy instead of checking all accounts
1040 * src/modest-account-mgr-priv.h:
1041 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1042 (modest_account_mgr_init), (compare_account_name),
1043 (modest_account_mgr_set_account_busy),
1044 (modest_account_mgr_account_is_busy):
1045 * src/modest-account-mgr.h:
1046 Added busy information to the account manager. It possible to
1047 set an account to busy or not busy now.
1049 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1050 (modest_mail_operation_update_account),
1051 (modest_mail_operation_notify_end):
1052 Set the account to busy/not busy depending on the operation state.
1054 * src/widgets/modest-account-view.c:
1055 (modest_account_view_finalize), (get_last_updated_string),
1056 (update_account_view), (on_account_busy_changed), (init_view):
1057 Show string "Refreshing..." if the account is currently busy.
1059 All this fixes projects.maemo.org bug NB#59711
1061 2007-06-14 Armin Burgmeier <armin@openismus.com>
1063 * src/widgets/modest-attachments-view.h:
1064 * src/widgets/modest-attachments-view.c: Added
1065 modest_attachments_view_has_attachments() and fixed coordinate
1066 transformation in get_att_view_at_coords(). This fixes attachment
1069 * src/widgets/modest-msg-view.c: Make use of
1070 modest_attachments_view_has_attachments() to decide whether to show
1071 attachments in the header.
1073 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1075 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1076 (on_change), (on_combo_security_changed),
1077 (modest_connection_specific_smtp_edit_window_init),
1078 (modest_connection_specific_smtp_edit_window_set_connection),
1079 (modest_connection_specific_smtp_edit_window_is_dirty):
1080 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1081 * src/maemo/modest-connection-specific-smtp-window.c:
1084 Show an comfirmation dialog for the smpt-edit-window if there are
1085 unsaved changes and the user hits cancel.
1086 (projects.maemo.org bug NB#60479)
1088 2007-06-14 Armin Burgmeier <armin@openismus.com>
1090 * src/maemo/easysetup/modest-easysetup-wizard.c:
1091 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1092 address" info in banner instead of node, and select all the text as
1093 per UI spec. This fixes projects.maemo.org bug NB#60550.
1095 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1097 reviewed by: <delete if not using a buddy>
1099 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1100 * src/modest-ui-actions.c: (folder_refreshed_cb):
1102 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1104 * src/widgets/modest-folder-view.c: (filter_row):
1105 Explictly filter out the per-account outbox accounts. I don't know why
1106 these only sometimes show up, but now they should never show up in the UI.
1107 This should fix projects.maemo.org bug NB#60160.
1109 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1111 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1112 when the toolbar does not exist yet.
1113 * src/modest-widget-memory.c: (save_settings_header_view):
1114 Added g_warnings() to help us to discover when we are trying to set
1115 an empty columns list in gconf.
1117 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1119 * src/modest-init.h:
1120 * src/modest-init.c:
1121 Added modest_init_get_default_header_view_column_ids().
1123 * src/modest-widget-memory.c: (restore_settings_header_view):
1124 Use the new function to get defaults, if the gconf key is empty,
1125 instead of not creating any columns. This seems to fix the
1126 empty right-hand pane problems.
1128 * src/widgets/modest-header-view.h: Improved documentation.
1130 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1133 Revert the use of the display name as the account name, because this
1134 is generally wrong and would break the code that follows.
1136 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1138 * src/maemo/easysetup/modest-easysetup-wizard.c:
1139 (check_for_supported_auth_methods), (on_before_next),
1142 More correct fix for projects.maemo.org bug NB# 58991
1143 Do not longer accept AUTH_PASSWORD as secure method and choose
1144 correct method when creating the account.
1146 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1148 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1149 Fixed projects.maemo.org bug NB# 58991
1151 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1153 * src/modest-init.c: (modest_init_init_core),
1154 (modest_init_local_folders): Fixed compilation errors.
1156 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1158 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1159 Remove unnecessary lib/include, though it is good in principle when needed.
1161 * src/modest-init.c: (modest_init_one_local_folder),
1162 (modest_init_local_folders):
1163 * src/modest-init.h: Initialize the .modest library for memory cards,
1164 instead of just doing nothing for them. This should allow us to create
1165 folders there, fixing projects.maemo.org bug NB#59297.
1167 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1169 * libmodest-dbus-client/libmodest-dbus-client.c:
1170 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1171 (libmodest_dbus_client_compose_mail),
1172 (libmodest_dbus_client_open_message),
1173 (libmodest_dbus_client_send_and_receive),
1174 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1176 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1177 (on_idle_open_message), (modest_dbus_req_handler),
1178 (search_result_to_message), (modest_dbus_req_filter):
1179 * src/modest-search.c: (add_hit), (modest_search_folder),
1180 (modest_search_all_accounts): Improved debug messages.
1182 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1184 * src/modest-tny-account-store.c:
1185 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1188 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1191 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1193 * src/modest-tny-account-store.c: (get_server_accounts):
1194 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1195 even when there are no accounts, so that the Outbox folder is always
1196 visible. This fixes projects.maemo.org bug NB#60158.
1198 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1200 * src/maemo/modest-main-window.c: (create_details_widget):
1201 Use the mcen_va_never logical ID.
1203 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1205 * src/dbus_api/modest-dbus-api.h:
1206 * src/dbus_api/modest-dbus-callbacks.c:
1207 (on_idle_open_default_inbox), (on_open_default_inbox),
1208 (modest_dbus_req_handler):
1209 Added a new OpenDefaultInbox method.
1211 * libmodest-dbus-client/libmodest-dbus-client.h:
1212 * libmodest-dbus-client/libmodest-dbus-client.c:
1213 Added libmodest_dbus_client_open_default_inbox() to call the new
1214 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1215 though it should maybe be used by a new osso-email-interface function.
1217 * tests/dbus_api/Makefile.am:
1218 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1221 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1223 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1224 NULL, so that the signals get all the keys. This should not actually
1225 change any behaviour because we currently update everything when anything
1228 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1230 * src/widgets/modest-folder-view.c: (text_cell_data),
1231 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1232 (find_inbox_iter): If tinymail tells us that the folder is
1233 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1234 This causes the inbox to be selected at startup, fixing part of
1235 projects.maemo.org bug NB#56305.
1237 * src/modest-ui-dimming-rules.c:
1238 (modest_ui_dimming_rules_on_tools_smtp_servers):
1239 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1240 the SMTP servers menu item.
1241 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1242 that the SMTP Servers menu item is dimmed when there are no accounts,
1243 as a future version of the UI spec will require. This fixes
1244 projects.maemo.org bug NB#56305.
1246 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1248 * src/maemo/modest-maemo-utils.c:
1249 (modest_maemo_utils_get_supported_secure_authentication_methods):
1250 Added label to dialog instead of unreadable title
1252 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1253 (modest_main_window_new):
1254 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1257 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1258 * src/modest-account-mgr.h:
1259 Added method to avoid code duplication
1261 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1262 (modest_ui_actions_on_send_receive):
1263 Use modest_account_mgr_has_accounts
1265 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1267 * src/maemo/easysetup/modest-presets.c:
1268 (modest_presets_get_info_server_security): Do not report secure auth
1270 * src/modest-protocol-info.c: Use the defines for the gconf key names
1271 for secure authentication. This was not working because we were writing
1272 Password and reading password, and the check was case sensitive.
1273 With this, gmail now works for receiving and sending when created via
1276 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/easysetup/modest-presets.c:
1279 (modest_presets_get_info_server_security): Correct the key name for
1280 SecureSmtp, because it seems to be case-sensitive.
1281 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1282 Do not try to get the 0th notebook page if there are 0 pages, to
1283 avoid a g_warning().
1285 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1287 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1288 Prevent use of the new notification feature for now, because it currently
1289 shows one dialog for each new email, which is annoying.
1291 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1293 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1294 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1295 when no country was selected, so that we show the global ones.
1296 * src/maemo/easysetup/modest-presets.c:
1297 (modest_presets_get_providers): Return only the global providers, not
1298 all providers when mmc=0 was requested.
1300 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1302 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1303 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1304 provider ID in the combo.
1306 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1307 Do not show the page numbers, because it would be confusing when we add
1308 the 2 extra pages for the custom setup, when the user chooses the "Other"
1309 provider. This fixes projects.maemo.org bug NB#59028
1311 * src/modest-init.c: (modest_init_init_core),
1312 (modest_init_local_folders):
1313 * src/modest-init.h:
1314 * src/modest-tny-account.c:
1315 (modest_tny_account_new_for_local_folders): Do not create default folders
1316 for the memory card. This should fix projects.maemo.org bug NB#59328.
1318 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1320 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1321 Free the changed_conf_keys string items. They are already freed in the
1322 idle handler if that runs first.
1324 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1326 * src/modest-ui-actions.c:
1327 (modest_ui_actions_on_password_requested): Check that the server name
1328 is not NULL, because I just saw a password dialog with (null) as the
1331 * src/modest-tny-folder.[h|c]: Added
1332 modest_tny_folder_is_memory_card_folder().
1333 * src/modest-ui-dimming-rules.c:
1334 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1335 menu item for memory cards, as per the UI spec (section 7.4). This should
1336 fix projects.maemo.org bug NB#59297.
1338 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1340 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1341 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1342 is another problem with the code, see Murray's comment at line 772)
1344 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1346 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1347 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1348 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1349 (load_from_file), (easysetup_country_combo_box_init),
1350 (easysetup_country_combo_box_get_active_country_ids),
1351 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1352 instead of just one ID, to avoid duplicate country names in the UI.
1354 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1355 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1356 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1357 a single ID, avoiding duplicate providers.
1358 * src/maemo/easysetup/modest-easysetup-wizard.c:
1359 (on_combo_account_country): Adapt to use a list.
1361 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1363 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1364 keys changed in the last X seconds.
1366 * src/modest-account-mgr.h:
1367 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1368 (on_key_change), (modest_account_mgr_class_init),
1369 (modest_account_mgr_init), (modest_account_mgr_finalize):
1370 As the keys are changed, save them in a GSList* and signal that GSList*
1371 further every X seconds, to batch changes, to allow us to do just one
1372 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1373 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1375 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1376 changed signal signature.
1378 * src/modest-conf.c: (modest_conf_set_list),
1379 (modest_conf_on_change): Reenable notification.
1381 (modest_conf_maemo_fake_on_change): Comment out the hack that
1382 notified immediately instead of asynchronously.
1384 * src/widgets/modest-account-view.h:
1385 * src/widgets/modest-account-view.c:
1386 (update_account_view): Select the previously-selected account ID,
1387 if possible. This fixes projects.maemo.org bug NB#56933.
1389 (on_account_changed), (on_account_removed),
1390 (modest_account_view_select_account):
1392 Remove the block/unblock functions
1393 because they were not useful.
1395 * src/maemo/modest-account-view-window.c:
1396 (on_delete_button_clicked), (on_edit_button_clicked),
1397 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1399 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1402 Improve the error dialog to show Incorrect Account Settings, which seems
1403 clearer, and say that the internal error message (to be removed from the
1404 dialog later) is often misleading.
1405 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1407 * src/modest-tny-account.c:
1408 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1409 URL because this is so useful for debugging on the device.
1411 * src/widgets/modest-serversecurity-combo-box.c:
1412 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1414 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1416 * src/modest-mail-operation.c:
1417 (modest_mail_operation_send_new_mail):
1418 Added a comment about a nasty but apparently harmless message. Details
1419 added to the wiki g_warnings() page.
1421 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1423 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1424 (modest_tny_send_queue_class_init):
1425 Do not use the priv struct because it is empty, to avoid g_warnings
1426 about a non-existant priv struct.
1428 * src/modest-tny-account-store.c:
1429 (modest_tny_account_store_get_server_account),
1430 (modest_tny_account_store_get_transport_account_for_open_connection
1431 ): Do not try to get transport server accounts for local folders,
1432 because they don't have any. This avoids a g_warning().
1434 * src/maemo/modest-main-window.c:
1435 (modest_main_window_notify_send_receive_initied),
1436 (on_configuration_key_changed):
1437 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1438 * src/modest-defs.h:
1439 * src/modest-mail-operation.c:
1440 (modest_mail_operation_update_account):
1441 * src/modest-tny-account-store.h:
1442 * src/modest-tny-account.c:
1443 (modest_tny_account_get_special_folder),
1444 (modest_tny_account_new_for_local_folders),
1445 (modest_tny_account_new_for_per_account_local_outbox_folder):
1446 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1447 * src/modest-tny-local-folders-account.c:
1448 (add_account_folders_to_merged_folder):
1449 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1450 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1451 (modest_ui_actions_on_send):
1452 * src/widgets/modest-folder-view.c: (update_model):
1453 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1454 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1455 modest_tny_account_store_get_tny_account_by_account() to
1456 modest_tny_account_store_get_server_account() to make the code clearer.
1458 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1460 * src/dbus_api/modest-dbus-api.h:
1461 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1462 * src/maemo/modest-msg-edit-window.c:
1463 (modest_msg_edit_window_attach_file_noninteractive):
1464 added g_warning in case the file to be attached does not exist
1465 * tests/dbus_api/test_compose_mail.c: (main):
1466 removed obsolete comment, added generic files as test case
1468 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1470 * src/modest-tny-account-store.c: (get_server_accounts):
1471 Create the local folders account only once, not once for each outbox, and
1472 not only when there are some outboxes.
1474 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1476 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1477 code that is causing a crash at startup. Sergio says that he is fixing this.
1479 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1481 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1482 * src/maemo/modest-account-settings-dialog.c:
1483 (create_page_outgoing),
1484 (modest_account_settings_dialog_set_account_name),
1485 (save_configuration):
1486 - Fixed handling of the "Use secure authentication" toggle to comply with
1487 the ui specification. See also projects.maemo.org bug NB#58400
1489 - Restore the Secure connection setting combo correctly when loading
1492 * src/maemo/modest-maemo-utils.c:
1493 (on_camel_account_get_supported_secure_authentication),
1494 (modest_maemo_utils_get_supported_secure_authentication_methods):
1495 Fixed a crasher if operation is canceled
1497 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1498 (modest_protocol_info_auth_is_secure):
1499 * src/modest-protocol-info.h:
1501 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1502 the sense of the "Use secure authentication" toggle.
1504 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1506 * src/modest-tny-account-store.h:
1507 * src/modest-tny-account-store.c:
1508 Added modest_tny_account_store_get_local_folders_account().
1510 * src/modest-tny-folder.h:
1511 * src/modest-tny-folder.c:
1512 (modest_tny_folder_get_account):
1513 Added this replacement for tny_folder_get_account() which returns
1514 the local-folders account for TnyMergeFolders, to avoid the
1515 warning about the unimplemented get_account_func() vfunc().
1517 (modest_tny_folder_get_rules),
1518 * src/modest-ui-actions.c:
1519 (modest_ui_actions_on_folder_selection_changed):
1520 * src/modest-mail-operation.c:
1521 (modest_mail_operation_remove_folder),
1522 (modest_mail_operation_xfer_folder),
1523 (modest_mail_operation_rename_folder),
1524 (modest_mail_operation_get_msg),
1525 (modest_mail_operation_get_msgs_full),
1526 (modest_mail_operation_remove_msg),
1527 (modest_mail_operation_xfer_msgs),
1528 (modest_mail_operation_refresh_folder):
1529 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1531 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1533 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1534 (modest_server_account_set_security):
1535 * src/modest-defs.h: Add comments explaining that our
1536 UI spec means TLS when it says Normal, so these do not look like errors.
1538 * src/modest-tny-account.c:
1539 (modest_tny_account_new_from_server_account): Use the new tinymail
1540 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1541 for TLS. This should fix projects.maemo.org bug NB#58460.
1543 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1545 * src/maemo/easysetup/modest-easysetup-wizard.c:
1546 (create_account): Correct the position of the gconf sanity check warning.
1547 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1548 of using the g_idle_add() hack, because this does not seem to be necessary
1549 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1550 caused by something other than maemo's gconf.
1551 This fixes projects.maemo.org bug #59022.
1553 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1555 * src/modest-account-mgr-helpers.c:
1556 (modest_account_mgr_get_default_account): Do not check that the account
1557 exists if there is no default account (NULL), to fix a runtime warning.
1559 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1561 * src/widgets/modest-folder-view.c: (update_model):
1562 Do not unref the treemodel before we have finished with it.
1563 This prevents a valgrind warning and an occasional crash at startup.
1565 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1567 * libmodest-dbus-client/libmodest-dbus-client.h:
1568 added libmodest_dbus_client_compose_mail()
1569 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1571 added functions needed for SendAsMail() functionality
1572 * src/maemo/modest-msg-edit-window.c:
1573 (modest_msg_edit_window_attach_file_noninteractive):
1574 non interactively attaching files to message edit window
1575 * src/widgets/modest-msg-edit-window.h:
1576 * tests/dbus_api/Makefile.am:
1577 added test_compose_mail.c
1578 * tests/dbus_api/test_compose_mail.c: (main):
1580 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1582 * src/modest-account-view.c:
1583 Fixed bug projects.maemo.org bug NB#59307
1585 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1587 * src/maemo/easysetup/modest-easysetup-wizard.c:
1588 (get_serverport_incoming), (on_before_next), (create_account):
1589 * src/maemo/modest-account-settings-dialog.c:
1590 (modest_account_settings_dialog_set_account_name):
1591 * src/maemo/modest-maemo-utils.c:
1592 (on_camel_account_get_supported_secure_authentication_status),
1593 (on_camel_account_get_supported_secure_authentication),
1594 (on_secure_auth_cancel),
1595 (modest_maemo_utils_get_supported_secure_authentication_methods):
1597 Implemented security authentication for settings and easysetup.
1599 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1601 * src/maemo/modest-main-window.c: (create_details_widget):
1602 Show the total size for memory card accounts too, instead of showing
1603 the name again. Fixes bug projects.maemo.org bug NB#59307.
1605 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1608 * src/modest-tny-simple-folder-store.c:
1609 * src/modest-tny-simple-folder-store.h: Removed.
1611 * src/modest-tny-local-folders-account.h
1612 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1613 for the local-folders maildir, with an extra TnyMergedFolder containing
1614 the folders of the per-account outbox store accounts.
1615 * src/modest-tny-account-store.c: (get_server_accounts):
1616 Add the outboxes to the special local folders account after creating it.
1618 * src/modest-tny-account.c:
1619 (modest_tny_account_new_for_local_folders): Create the derived
1620 account when creating the main local-folders account.
1622 * src/maemo/modest-main-window.c: (create_details_widget),
1623 (modest_main_window_set_contents_style):
1624 Adapted to the use of the derived account instead of the folder store.
1626 * src/modest-ui-actions.c:
1627 (modest_ui_actions_on_folder_selection_changed):
1628 * src/modest-ui-dimming-rules.c:
1629 (modest_ui_dimming_rules_on_new_folder):
1630 * src/widgets/modest-folder-view.c: (text_cell_data),
1631 (icon_cell_data), (filter_row), (update_model),
1632 (get_cmp_rows_type_pos):
1635 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1636 Do not get the priv struct, because no priv struct has been set,
1637 to avoid a runtime warning.
1639 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1640 #ifelse with #else, to fix a warning, to fix the build.
1643 2007-06-05 Christian Kellner <ckellner@openismus.com>
1645 * libmodest-dbus-client/libmodest-dbus-client.c:
1646 Fix small typo in doc (why do you always see them
1647 AFTER committing stuff?)
1650 2007-06-05 Christian Kellner <ckellner@openismus.com>
1652 * libmodest-dbus-client/libmodest-dbus-client.c:
1653 (libmodest_dbus_client_search):
1654 Initialize hit list with NULL. Also set folder list
1655 to "" if NULL was supplied.
1658 2007-06-03 Christian Kellner <ckellner@openismus.com>
1660 * libmodest-dbus-client/libmodest-dbus-client.c:
1661 (modest_search_hit_list_free):
1662 Make it save to call it with NULL.
1664 * src/dbus_api/modest-dbus-callbacks.c:
1665 * src/modest-search.c:
1666 Return full ModestSearchHits as the search result list not TnyHeader
1667 since can't be around withouth the correspoding TnyFolder.
1669 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1671 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1672 Added currently commented code to check for secure auth
1674 * src/maemo/modest-account-settings-dialog.c: (on_response),
1675 (save_configuration), (show_ok):
1676 Fixed projects.maemo.org bugs NB #59248 and #59251
1678 * src/maemo/modest-maemo-utils.c:
1679 (on_camel_account_get_supported_secure_authentication_status),
1680 (on_camel_account_get_supported_secure_authentication),
1681 (modest_maemo_utils_get_supported_secure_authentication_methods):
1682 * src/maemo/modest-maemo-utils.h:
1683 Moved get_supported_secure_authentication() method here to be able
1684 to use it from easysetup wizard.
1686 * src/modest-pair.c: (on_pair_compare_as_string):
1687 Should compare string with first part of pair and not
1688 strcmp pairs which will crash.
1690 * src/modest-protocol-info.c:
1691 (modest_protocol_info_protocol_is_store):
1692 * src/modest-protocol-info.h:
1693 Added modest_protocol_info_get_auth_protocol_name()
1695 2007-06-03 Armin Burgmeier <armin@openismus.com>
1697 * src/modest-mail-operation.c:
1698 (modest_mail_operation_get_msgs_full): Set priv->account also when
1699 only retrieving a single message. This avoids a crash when canceling
1702 (modest_mail_operation_notify_end): Do not explicitely remove the
1703 operation from the queue but only emit the progress_changed signal.
1704 The queue itself listens to that signal to remove the operation when
1705 it is finished. This reduces coupling and removes a potential deadlock
1706 when modest_mail_operation_notify_end() is called from the queue
1707 itself. If that is a problem performance-wise, I would suggest to
1708 implement a status-changed signal or something.
1710 * src/modest-mail-operation-queue.c: Make sure to never call a
1711 function from another file while the queue is locked. This (hopefully)
1712 fixes another deadlock when exiting the application while retrieving
1715 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1717 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1718 Fixed build if libogs is not available
1720 2007-06-03 Christian Kellner <ckellner@openismus.com>
1722 * libmodest-dbus-client/libmodest-dbus-client.h:
1723 * libmodest-dbus-client/libmodest-dbus-client.c:
1724 (libmodest_dbus_client_delete_message):
1725 Implement deletion of messages (Client side).
1727 (modest_search_hit_free),
1728 (modest_search_hit_list_free):
1729 Utility functions to free the result hits.
1731 * src/dbus_api/modest-dbus-api.h:
1732 * src/dbus_api/modest-dbus-callbacks.c:
1733 (on_delete_message),
1734 (modest_dbus_req_handler):
1735 Implement deletion of messages (Server side).
1737 * tests/dbus_api/test_search.c: (main):
1740 * tests/dbus_api/Makefile.am:
1741 * tests/dbus_api/test_delete_message:
1742 Add little test for the message deletion logic
1744 2007-06-03 Armin Burgmeier <armin@openismus.com>
1746 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1747 when the operation queue was not empty. projects.maemo.org bug
1750 2007-06-03 Armin Burgmeier <armin@openismus.com>
1752 * src/widgets/modest-account-view.c
1753 (on_account_default_toggled): Toggle default account column
1754 explicitely instead of waiting for gconf notification (which is
1755 currently ignored). This should fix projects.maemo.org bug NB#56910
1756 for now. It should probably be removed when gconf notifications are
1759 2007-06-03 Christian Kellner <ckellner@openismus.com>
1761 * libmodest-dbus-client/libmodest-dbus-client.c:
1762 Removed debugging spew.
1764 * src/dbus_api/modest-dbus-callbacks.c:
1765 Added debugging info.
1767 * src/modest-search.c:
1768 (modest_search_all_accounts):
1769 Use tny_account_store_get_accounts () on the account store
1770 to get all accounts which is the way to get all accounts.
1772 * tests/dbus_api/test_search.c: (main):
1773 Make it possible to supply the search term on the command line.
1775 2007-06-03 Christian Kellner <ckellner@openismus.com>
1777 * libmodest-dbus-client/libmodest-dbus-client.c:
1778 * libmodest-dbus-client/libmodest-dbus-client.h:
1779 Implement searching for mesages over raw dbus. (Client side)
1781 * src/dbus_api/Makefile.am:
1782 * src/dbus_api/modest-dbus-api.h:
1783 * src/dbus_api/modest-dbus-callbacks.c:
1784 * src/dbus_api/modest-dbus-callbacks.h:
1785 Search framework (Server side). Also implement on_idle_open_message().
1787 * src/maemo/modest-platform.c: (modest_platform_init):
1788 Prepare for raw dbus/osso rpc interaction.
1790 * src/modest-search.h:
1791 Changed minsize from unspecific guint to guint32.
1793 * src/modest-search.c:
1795 Added strange hack which magically made tnymail work.
1797 (modest_search_folder),
1798 (modest_search_account),
1799 (modest_search_all_accounts):
1800 Implement helper functions to search all accounts, specific account
1803 * tests/dbus_api/Makefile.am:
1804 * tests/dbus_api/test_open_message.c:
1805 Read url to open from commandline.
1807 * tests/dbus_api/test_search.c:
1808 Implement small test for dbus search stuff
1810 2007-06-02 Armin Burgmeier <armin@openismus.com>
1812 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1813 include account type and account title. This fixes projects.maemo.org
1816 * src/maemo/modest-account-view-window.c: Set a title for the window.
1818 2007-06-02 Armin Burgmeier <armin@openismus.com>
1820 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1821 incoming and outgoing server name based on email address and server
1822 types as long as the names have not been edited manually. This fixes
1823 projects.maemo.org bug NB#58671.
1825 2007-06-02 Armin Burgmeier <armin@openismus.com>
1827 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1828 server type cannot be changed in future to the incoming details page
1829 when creating an account. This fixes projects.maemo.org bug NB#59029.
1831 2007-06-02 Armin Burgmeier <armin@openismus.com>
1833 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1834 and assigned max width chars so that they wrap instead of being
1835 truncated. Fixes projects.maemo.org bug NB#56126.
1837 2007-06-02 Armin Burgmeier <armin@openismus.com>
1839 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1840 introductory note to the connection specific smtp servers dialog, as
1841 section 8.12 of the email UI specification requires. This fixes
1842 projects.maemo.org bug NB#59212.
1844 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1846 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1847 Check for running mail operations, and offer to cancel them, as per the UI
1848 spec. This fixes projects.maemo.org bug NB#59041 .
1849 However, I suspect that tinymail may still use the network connection
1850 in ways that we cannot detect or cancel. But it should at least adapt to
1851 changes fairly well.
1853 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-tny-account-store.c: (recreate_all_accounts),
1856 (get_cached_accounts), (get_server_accounts): Do more sensible
1857 ref-counting of the temporarily-cached outbox accounts list. This seems
1858 to fix a crash when entering the password when the password was wrong.
1860 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1862 * src/gnome/modest-main-window.c: (connect_signals):
1863 * src/modest-tny-account-store.c: (get_password),
1864 (modest_tny_account_store_alert): Added comments and clues and
1865 commented-out code about how we currently fail to deal with connection
1866 errors and wrong passwords, and how we should.
1868 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1870 * src/widgets/modest-retrieve-combo-box.c:
1871 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1872 This fixes projects.maemo.org bug NB#58472 .
1874 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1876 * src/maemo/easysetup/modest-easysetup-wizard.c:
1877 (create_page_complete_easysetup):
1878 (create_page_complete_custom): Correct the last commit,
1879 putting the correct sentences in the correct pages.
1881 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1883 * src/maemo/easysetup/modest-easysetup-wizard.c:
1884 (create_page_complete_custom): Show the second sentence of text
1885 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1888 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1890 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1891 Set the leave-on-server conf key by default. This fixes
1892 projects.maemo.org bug NB#59258 .
1894 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1896 * src/maemo/modest-account-view-window.c:
1897 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1898 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1901 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1903 * src/maemo/easysetup/modest-easysetup-wizard.c:
1904 (create_caption_new_with_asterisk):
1905 * src/maemo/modest-account-settings-dialog.c:
1906 (create_caption_new_with_asterisk):
1907 Uncomment the code to add the asterisk, because they are no longer in the
1908 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1909 (update_incoming_server_title): Add an asterisk here too.
1911 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1913 * src/maemo/modest-maemo-global-settings-dialog.c:
1914 (current_connection): Check that we are even connected before trying to
1915 get the current connection name, to prevent a warning.
1917 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1918 Change the comments because tny_maemo_conic_device_connect() is now meant to
1920 * src/modest-mail-operation.c:
1921 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1922 make sure we have a connection and fail if we can't connect.
1924 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/modest-main-window.c:
1927 (on_account_store_connecting_finished): Do not try to get the
1928 connection ID if we are not really connected. I am surprised that
1929 this signal handler is called when we are not connected.
1931 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1933 * src/modest-error.h:
1934 * src/modest-ui-actions.c:
1935 (modest_ui_actions_get_msgs_full_error_handler):
1936 Renamed an enum, added comments, added an enum
1937 for retrieve-limit errors.
1939 * src/modest-mail-operation.c: (foreach_add_item),
1940 (internal_folder_observer_update), (update_account_thread),
1941 (modest_mail_operation_get_msgs_full):
1942 (modest_mail_operation_update_account),
1943 Added comments about how this works, and some code that should
1944 (but does not) check the retrieve-limit. See the TODO comment.
1946 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1948 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1949 Initialize help_id to fix the build. Warnings are good.
1951 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1953 * src/widgets/modest-hbox-cell-renderer.c:
1954 (modest_hbox_cell_renderer_append):
1955 * src/widgets/modest-vbox-cell-renderer.c:
1956 (modest_vbox_cell_renderer_append):
1957 Fix the last commit by doing an extra ref.
1959 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1961 * src/widgets/modest-hbox-cell-renderer.c:
1962 (modest_hbox_cell_renderer_append):
1963 * src/widgets/modest-vbox-cell-renderer.c:
1964 (modest_vbox_cell_renderer_append):
1965 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1966 to fix the build with Maemo Bora.
1967 However, there seems to be a remaining crash, probably due to reference
1970 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1972 * src/modest-tny-account.c:
1973 (modest_tny_account_new_for_local_folders):
1974 Use hildon_file_system_info_async_new() to get a better name for
1975 the memory card account, setting it as the account name.
1976 The timing seems to work, but this is probably
1977 not the best place to do this. See the TODO comment.
1978 * src/maemo/modest-main-window.c: (create_details_widget):
1979 * src/widgets/modest-folder-view.c: (text_cell_data):
1980 Use the tny account name instead of hardcoding a name.
1982 2007-05-30 Christian Kellner <ckellner@openismus.com>
1984 * src/modest-search.c: (modest_search):
1985 Correctly set part_search_func even if we have already parsed
1986 the query and thus a valid OgsTextSearcher object.
1988 2007-05-30 Christian Kellner <ckellner@openismus.com>
1991 Search and check for libogs.
1994 Incooparte the ogs build env.
1996 * src/modest-mime-part-search-stream.c:
1997 * src/modest-mime-part-search-stream.h:
1998 Removed since we do the real searching now in modest-search.c.
2000 * src/modest-search.c:
2001 * src/modest-search.h:
2002 Implement support for ogs. We use that if available and requested
2003 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2004 should now handle the corner case when the search term is spread
2005 across multiple reads.
2006 Also the logic in modest_search () was corrected to search all
2007 requested fields until one is found.
2009 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2011 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2013 * src/modest-init.h:
2014 * src/modest-init.c: Made modest_init_local_folders() take a
2015 path and be public so we can iniitialize maildir folders on
2018 * src/modest-local-folder-info.h:
2019 * src/modest-local-folder-info.c:
2020 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2022 * src/modest-tny-account.c:
2023 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2024 still means the standard local-folders path on the local volume.
2026 * src/modest-tny-account-store.c:
2027 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2028 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2029 all accounts when that happens.
2030 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2031 this too, so it shows up in the treeview.
2033 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/modest-maemo-global-settings-dialog.c:
2036 (current_connection):
2037 * src/widgets/modest-global-settings-dialog.c:
2038 (current_connection_default):
2039 Use the enum values instead of 0, 1 and -1,
2040 to make the code clearer.
2042 * src/modest-account-mgr-helpers.c:
2043 (modest_account_mgr_get_connection_specific_smtp): Make this code
2046 * src/modest-runtime.h:
2047 * src/modest-runtime.c:
2048 Added modest_runtime_remove_all_send_queues().
2049 * src/maemo/modest-main-window.c:
2050 (on_account_store_connecting_finished): Recreate the send queues,
2051 using the appropriate transport accounts for this new connection.
2052 Some futher adapting might be needed if the old send queues are not
2053 automatically stopped at this point.
2055 * src/modest-tny-account-store.c: (get_server_accounts):
2056 Create the connection-specific transport accounts, so that they can
2057 be found later by their ID.
2059 * src/modest-tny-account.h:
2060 * src/modest-tny-account.c:
2061 Added modest_tny_account_new_from_server_account_name().
2062 modest_tny_account_new_from_server_account(): Do not create the
2063 send queues here, because they will be
2064 recreated anyway when the connection changes for the first time.
2066 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-local-folder-info.h:
2069 * src/modest-local-folder-info.c:
2070 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2071 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2072 tbox_folder): Take a modest account name instead of a server TnyAccount,
2073 so we can have per-modest-account rather than per-transport-account
2075 We must make sure that we change or recreate the exisitng send queues
2076 when the connection changes for connection-specific transport accounts.
2078 * src/modest-tny-account-store.c:
2079 (create_per_account_local_outbox_folders): Create outboxed per modest
2080 account, not per transport account.
2082 * src/modest-tny-account.h:
2083 * src/modest-tny-account.c:
2084 (modest_tny_account_get_special_folder): For outboxes, get the
2085 parent modest account name. The account is ignored for other folders.
2086 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2087 modest account name rather than a server TnyAccount.
2089 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2091 * src/modest-tny-account.c:
2092 (modest_tny_account_new_from_server_account):
2093 Call modest_runtime_get_send_queue() immediately after creating transport
2094 accounts, so that they start trying to send email from the outbox as soon
2095 as possible at startup. This is probably what we want.
2097 * src/modest-mail-operation.c: (update_account_thread):
2098 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2099 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2100 * src/modest-tny-send-queue.h:
2101 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2102 (modest_ui_actions_on_send):
2103 Added comments about how sending works, though it needs some more work.
2105 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2107 * src/modest-tny-account.c:
2108 (modest_tny_account_get_special_folder): Add TODO because this fails when
2109 the network is busy.
2110 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2111 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2112 Do not try to show this window when there is no active account. The UI
2113 specs does not tell us what to do in this case.
2115 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/Makefile.am:
2120 * src/widgets/Makefile.am: Some dist fixes.
2122 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2124 * src/maemo/modest-connection-specific-smtp-window.c:
2125 (on_button_edit): Make the code clearer, to prevent a double free.
2127 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2129 * src/maemo/modest-account-settings-dialog.c:
2130 (modest_account_settings_dialog_set_account_name),
2131 Check the connection-specific smtp servers checkbox if there are any.
2133 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2134 (modest_connection_specific_smtp_edit_window_init):
2135 Start with a suitable port number.
2137 * src/modest-account-mgr-helpers.h:
2138 * src/modest-account-mgr-helpers.c: Added
2139 modest_account_mgr_get_has_connection_specific_smtp().
2141 (modest_account_mgr_set_connection_specific_smtp),
2142 (modest_account_mgr_remove_connection_specific_smtp),
2143 (modest_account_mgr_get_has_connection_specific_smtp),
2144 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2145 connection-specific smtp server accounts in the account, rather than
2146 the server account conf dir.
2148 This fixes bug projects.maemo.org bug NB#58263 .
2150 * src/modest-tny-account-store.c:
2151 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2152 if there are no server accounts yet, to prevent an infinite loop when there
2153 are no accounts. Document that one must be called before the other.
2155 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2157 * src/modest-account-mgr-helpers.c:
2158 (modest_account_mgr_get_default_account): Make sure that at least
2159 one account is always the default, if there are any enabled accounts.
2160 This is just a sanity check that shouldn't be necessary.
2162 * src/modest-account-mgr-priv.c:
2163 (_modest_account_mgr_account_from_key): Unescape the conf key to
2164 get the real account name. For instance, this is an issue if a space
2165 was in the account name, which can happen because the account name
2166 is generated from the display name.
2167 (_modest_account_mgr_get_account_keyname): Always escape the
2169 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2170 Unescape the conf keys to get the real account names.
2172 For instance, previously the is-default radio button in the accounts
2173 list was not checked for any accounts at first. This fixes that,
2174 and might fix several similar bugs.
2176 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2178 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2179 Removed some debug printfs.
2181 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2183 Modest on-disk outbox directories are now here, for instance:
2184 $HOME/.modest/outboxes/<account-id-1>/outbox
2185 $HOME/.modest/outboxes/<account-id-2>/outbox
2187 $HOME/.modest/local-folders/outbox
2188 so we can have a separate outbox for each account.
2189 But they are shown as one outbox in the GtkTreeView, by using a
2190 TnyMergeFolder in a ModestTnySimpleFolderStore.
2193 * src/modest-tny-simple-folder-store.c:
2194 * src/modest-tny-simple-folder-store.h:
2195 Added ModestTnySimpleFolderStore, used to contain folders from
2196 other folder stores, such as other accounts.
2198 * src/modest-tny-outbox-account.h:
2199 * src/modest-tny-outbox-account.c:
2200 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2201 used for the per-account local outbox folders.
2203 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2204 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2205 only use this (internally) now for the non-outbox local folders.
2207 * src/modest-init.h:
2208 * src/modest-init.c: Added modest_init_one_local_folder(), for
2209 setting up the directory structure for each local folder.
2211 * src/modest-local-folder-info.c:
2212 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2213 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2215 * src/modest-local-folder-info.h:
2216 * src/modest-tny-account-store.c: (on_account_removed),
2217 (on_account_changed), (create_per_account_local_outbox_folders),
2218 (get_server_accounts), (modest_tny_account_store_get_accounts),
2219 (modest_tny_account_store_get_tny_account_by_account),
2220 (modest_tny_folder_store_is_virtual_local_folders):
2222 * src/modest-tny-account.h:
2223 * src/modest-tny-account.c:
2224 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2225 to create an on-disk per-account local outbox folder for each
2227 (create_per_account_local_outbox_folders): Create a local outbox folder
2228 for each transport account.
2229 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2230 for all local folders.
2232 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2233 instead of using g_object_get/set() directly. It is clearer.
2235 (modest_tny_folder_store_get_message_count),
2236 (modest_tny_folder_store_get_local_size
2237 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2238 because we now use these with non-acount folder stores.
2240 (modest_tny_account_get_special_folder),
2241 (modest_tny_account_new_from_server_account),
2242 (modest_tny_account_new_from_account):
2243 (recurse_folders): Adjust to the new outbox system.
2245 * src/modest-tny-folder.h:
2246 * src/modest-tny-folder.c:
2247 (modest_tny_folder_is_local_folder),
2248 (modest_tny_folder_get_local_folder_type),
2249 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2251 * src/widgets/modest-main-window.h:
2252 * src/maemo/modest-main-window.c: (create_details_widget),
2253 (modest_main_window_set_contents_style): Show details for any folder store,
2256 (modest_tny_folder_get_rules):
2257 Remove the const. C does not support constness enough for this.
2259 * src/modest-ui-actions.c:
2260 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2261 make all outboxes appear as one, in the usual local-folders tree node.
2263 (set_active_account_from_tny_account),
2264 (modest_ui_actions_on_folder_selection_changed):
2265 * src/widgets/modest-folder-view.c: (text_cell_data),
2266 (icon_cell_data), (filter_row),
2267 (add_account_folders_to_merged_folder),
2268 (add_account_folders_to_simple_folder_store), (),
2269 (get_cmp_rows_type_pos), (cmp_rows),
2270 (modest_folder_view_set_account_id_of_visible_server_account):
2271 Adjust to the new outbox system, using generic folder stores and folders
2272 in the GtkTreeModel.
2274 2007-05-23 Christian Kellner <ckellner@openismus.com>
2276 * src/modest-mail-operation.c:
2277 (modest_mail_operation_update_account):
2278 Use info->max_size instead of unintialized local var [small
2279 build fix]. (Added TODO to review that change since I don't
2282 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2284 * libmodest-dbus-client/libmodest-dbus-client.c:
2285 (libmodest_dbus_client_compose_mail): function added
2286 * src/dbus_api/modest-dbus-api.h:
2287 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2288 (on_compose_mail): Implementation of the SendAsMail functionality
2290 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2292 * src/modest-account-mgr.c:
2293 (modest_account_mgr_add_server_account): Set the secure-connection
2294 conf key for transport accounts as well as store accounts. I don't know
2295 why the if was there. For instance, this makes sure that we use SSL
2296 for the gmail preset from the easysetup wizard.
2298 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2300 * src/gnome/modest-main-window.c:
2301 (on_account_store_connecting_finished), (connect_signals):
2302 * src/maemo/modest-main-window.c:
2303 (on_account_store_connecting_finished), (connect_signals),
2304 (modest_main_window_new):
2305 Handle TnyAccountStore::connecting-finished instead of
2306 TnyDevice::connection-changed, because we cannot actually perform
2307 operations on accounts until TnyAccountStore has itself responded to
2308 the TnyDevice::connection-changed signal. This prevents a GError from
2310 Do not try to update at startup, because we (at least on scratchbox)
2311 already do an update at startup when the device goes online.
2312 This prevents a GError from tinymail.
2313 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2314 Added TODO about stopping simultaneous operations.
2316 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2318 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2319 * src/modest-mail-operation-queue.c:
2320 (modest_mail_operation_queue_remove):
2321 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2322 about where they happened.
2324 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2326 * src/modest-ui-actions.c:
2327 (modest_ui_actions_on_password_requested): Make sure that the remember
2328 output parameter is always TRUE.
2330 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2332 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2333 Show a OK/Cancel dialog if the error is a question, though we still do not
2334 know anything more about what we are asking the user.
2335 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2336 Fix an uninitialized variable (helper). This is a logic error, however.
2338 2007-05-21 Christian Kellner <ckellner@openismus.com>
2340 * src/modest-search.h:
2341 Correct bit shifting in the ModestSearchFlags enum.
2343 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2345 * src/modest-tny-account.c:
2346 (modest_tny_account_new_from_server_account): Do not use the lsub and
2347 check-all hard-coded IMAP options when using POP.
2349 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2351 * src/modest-tny-account.c:
2352 (modest_tny_account_new_from_server_account):
2353 Use NULL for the secure-auth method for POP when Password auth has been
2354 specified by the user, as we already do for IMAP. "auth=Login" causes
2355 an error from camel or the server.
2357 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2359 * src/maemo/modest-account-settings-dialog.c:
2360 (create_page_account_details),
2361 (modest_account_settings_dialog_set_account_name):
2362 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2363 for the leave-on-server checkbox, rathr than just the checkbox, when
2364 the protocol is not POP.
2366 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2368 * src/widgets/modest-account-view.c:
2369 * src/widgets/modest-account-view.h:
2370 Added modest_account_view_select_account() which will be useful later
2371 to asynchronously re-select the edited account.
2373 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2375 * src/maemo/modest-account-settings-dialog.c:
2376 (modest_account_settings_dialog_set_account_name):
2377 Automatically choose the port numbers based on the secure authentication
2378 methods, if they have not been chosen before.
2379 This fixes projects.maemo.org bug NB#56273 .
2381 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2383 * src/maemo/modest-main-window-ui.h:
2384 * src/modest-ui-actions.c:
2385 * src/modest-ui-actions.h:
2386 Connect the Tools/SMTP Servers menu item to
2387 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2388 SMTP servers dialog, as in the UI specification and saves changes when it
2389 is closed. This fixed projects.maemo.org bug NB#56305 .
2391 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2393 * src/maemo/modest-connection-specific-smtp-window.c:
2394 (modest_connection_specific_smtp_window_init):
2395 Use gtk_window_set_default_size() to make this window big enough, so
2396 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2398 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2400 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2401 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2402 (modest_connection_specific_smtp_edit_window_init),
2403 Do not try to connect to a combobox signal before the combobox exists.
2404 This fixes the cras in projects.maemo.org bug NB#56288 .
2405 (modest_connection_specific_smtp_edit_window_get_settings):
2406 Remove the server_account_name parameter which was being checked for NULL
2407 though it was not used.
2409 * src/maemo/modest-connection-specific-smtp-window.c:
2410 (modest_connection_specific_smtp_window_fill_with_connections),
2411 (on_button_edit), (modest_connection_specific_smtp_window_init):
2412 Correct the number of treemodel columns to prevent a warning.
2413 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2414 libconic does not work.
2416 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2418 * src/modest-tny-account.c:
2419 (modest_tny_account_new_from_server_account):
2420 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2421 SMTP when "None" was chosen by the user. However, with my SMTP server that
2422 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2425 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2427 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2428 to explain the memory management issue with the ID in the ModestPair.
2430 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2431 (add_sending_page), (modest_account_assistant_finalize):
2432 * src/gnome/modest-gnome-global-settings-dialog.c:
2433 (create_updating_page), (create_composing_page):
2434 * src/gnome/modest-msg-edit-window.c: (get_transports),
2435 (init_window), (modest_msg_edit_window_finalize),
2436 (modest_msg_edit_window_get_msg_data):
2437 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2438 * src/gnome/modest-transport-widget.c:
2439 (modest_transport_widget_finalize), (smtp_configuration):
2440 * src/maemo/modest-maemo-global-settings-dialog.c:
2441 (create_updating_page), (create_composing_page):
2442 * src/maemo/modest-msg-edit-window.c: (get_transports),
2443 (init_window), (modest_msg_edit_window_finalize),
2444 (modest_msg_edit_window_get_msg_data),
2445 (modest_msg_edit_window_free_msg_data):
2446 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2447 (modest_store_widget_finalize):
2448 * src/maemo/modest-transport-widget.c:
2449 (modest_transport_widget_finalize), (smtp_configuration):
2450 * src/modest-main.c: (send_mail):
2451 * src/widgets/modest-combo-box.h:
2452 * src/widgets/modest-global-settings-dialog-priv.h:
2453 * src/widgets/modest-global-settings-dialog.c:
2454 (modest_global_settings_dialog_finalize):
2455 * src/widgets/modest-msg-edit-window.h:
2456 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2457 as long as the combo box, to prevent use of freed memory for the ID.
2459 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2461 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2462 get_accounts(), to make this clearer. Do not check for the enabled gconf
2463 key, because we do not use this for server accounts (at least, not yet).
2464 This allows us to send email again.
2466 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/modest-platform.c:
2469 (on_modest_conf_update_interval_changed), (modest_platform_init):
2470 Only respond to this particular key change. All these strcmp()s cannot be
2473 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2475 * src/maemo/modest-maemo-global-settings-dialog.c:
2476 (current_connection): Prevent a crash in scratchbox when
2477 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2478 * src/maemo/modest-platform.c:
2479 (on_modest_conf_update_interval_changed), (modest_platform_init):
2480 Get the update interval from gconf and reset it when the gconf key changes.
2482 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-protocol-info.c:
2485 * src/modest-protocol-info.h: Adde enum-specific get functions,
2486 instead of using a ModestProtocolType enum parameter.
2488 * src/gnome/modest-account-assistant.c:
2489 * src/gnome/modest-store-widget.c:
2490 * src/gnome/modest-store-widget.h:
2491 * src/gnome/modest-transport-widget.c:
2492 * src/gnome/modest-transport-widget.h:
2493 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2494 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2495 * src/maemo/easysetup/modest-easysetup-wizard.c:
2496 * src/maemo/modest-account-settings-dialog.c:
2497 * src/maemo/modest-account-settings-dialog.h:
2498 * src/maemo/modest-store-widget.c:
2499 * src/maemo/modest-store-widget.h:
2500 * src/maemo/modest-transport-widget.c:
2501 * src/maemo/modest-transport-widget.h:
2502 * src/modest-account-mgr-helpers.c:
2503 * src/modest-account-mgr-helpers.h:
2504 * src/modest-account-mgr.c:
2505 * src/modest-account-mgr.h:
2506 * src/modest-tny-account.c:
2507 * src/modest-tny-folder.c:
2508 * src/widgets/modest-account-view.c:
2509 * src/widgets/modest-retrieve-combo-box.c:
2510 * src/widgets/modest-retrieve-combo-box.h:
2511 * src/widgets/modest-secureauth-combo-box.c:
2512 * src/widgets/modest-serversecurity-combo-box.c:
2513 * src/widgets/modest-serversecurity-combo-box.h:
2514 * tests/check_account-mgr.c:
2515 Use the specific functions, and use the re-renamed enum values for GNOME too.
2517 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-pair.h:
2520 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2521 so we can get the second based on the first.
2523 * src/maemo/modest-account-settings-dialog.h:
2524 * src/maemo/modest-account-settings-dialog.c:
2525 Added get_supported_secure_authentication_methods(), though it is mostly
2526 commented-out for now until the necessary API is committed to tinymail.
2527 (modest_account_settings_dialog_set_account_name),
2528 (save_configuration): Request the supported authentication methods from the
2529 server, so we can choose a working method.
2531 * src/modest-tny-account-store.h:
2532 * src/modest-tny-account-store.c:
2533 (modest_tny_account_store_get_session): Rename from
2534 tny_account_store_get_session().
2536 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2538 * src/modest-protocol-info.h: Split the ModestProtocol enum
2539 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2540 There was no need to have these unrelated values in one enum.
2542 * src/: many files: Adapted to changed enum. This makes the code a bit
2543 clearer, and the compiler could catch some errors.
2545 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2547 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2548 Show the detailed internal camel error message when an error happens
2549 during the configuration, so that our testers can give us more clues.
2550 For instance, in projects.maemo.org bug NB#56910 .
2552 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2554 * src/modest-tny-account.c:
2555 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2556 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2558 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2560 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2561 * src/maemo/modest-account-settings-dialog.c:
2562 (modest_account_settings_dialog_set_account_name),
2563 (save_configuration): For the incoming secure authentication checkbox,
2564 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2565 the UI specification. PLAIN does not seem to be supported for most IMAP
2566 servers anyway, and I am not sure what it would mean.
2567 However, we probably need to discover which of the secure-authentication
2568 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2569 * src/modest-account-mgr-helpers.c:
2570 (modest_account_mgr_get_server_account_data):
2572 * src/modest-tny-account.c:
2573 (modest_tny_account_new_from_server_account):
2574 Use tny_account_set_mech() to set secure-authentication methods,
2575 with some special-casing for IMAP, based on my observations of how
2578 * src/modest-account-mgr-helpers.h:
2579 * src/modest-account-mgr.c:
2580 * src/modest-defs.h: Comment that the URI is only used for local folders.
2582 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2584 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2585 parameter const, just to be neat.
2586 * src/modest-text-utils.c: (modest_text_utils_inline):
2587 End g_strconcat() with NULL, as its documentation says. This is almost
2588 certainly the cause of my crash at startup on the device. Interestingly,
2589 valgrind doesn't tell us about these errors.
2591 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2593 * scripts/build-packages: Added more precise comments about how to use
2594 this script, though I still get this error:
2595 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2596 error building tinymail
2598 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2600 * src/maemo/modest-main-window.c: (on_account_update):
2601 Very slight cleanup, hoping to make it simpler to discover what causes
2602 a crash here sometimes.
2604 * src/modest-tny-account.c:
2605 (modest_tny_account_new_from_server_account): Set the port. Added
2606 comments about the options and a TODO comment because I need to find out
2607 how to specify the secure authentication method.
2609 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2611 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2612 changed CFlags paths form modest to libmodest
2614 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2616 * src/modest-account-mgr-helpers.c:
2617 (modest_account_mgr_get_server_account_data),
2618 (modest_account_mgr_free_server_account_data):
2619 * src/modest-account-mgr-helpers.h:
2620 * src/modest-account-mgr.c:
2621 (modest_account_mgr_add_server_account):
2622 * src/modest-defs.h:
2623 * src/modest-tny-account.c:
2624 (modest_tny_account_new_from_server_account):
2625 Determine the options for tny_camel_account_add_option() here,
2626 based on the settings, rather than storing them directly in gconf.
2628 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2630 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2631 Show a more friendly error dialog now that we expect (from the tinymail
2632 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2634 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2636 * src/maemo/modest-main-window.c: (on_account_update): Check that
2637 account_name is not NULL, to prevent a crash at startup that I am
2638 seeing on the N800. I do wonder why it is NULL.
2640 * src/maemo/easysetup/modest-easysetup-wizard.c:
2641 (create_page_user_details):
2642 * src/maemo/modest-account-settings-dialog.c:
2643 (create_page_user_details), (create_page_outgoing):
2644 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2645 (modest_connection_specific_smtp_edit_window_init):
2646 * src/modest-ui-actions.c:
2647 (modest_ui_actions_on_password_requested):
2648 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2649 might do something useful with the on-screen keyboard.
2651 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2653 * src/maemo/modest-main-window.c: (on_account_update):
2654 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2655 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2657 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2659 * src/modest-tny-account-store.c: (on_account_changed):
2660 Correct the signature of this signal handler.
2662 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2664 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2665 Show a HildonNote instead of a GtkDialog for Maemo.
2667 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2669 * src/widgets/modest-account-view.h:
2670 * src/widgets/modest-account-view.c: (on_account_changed),
2671 (on_account_removed). Added a boolean flag, set/unset by
2672 modest_account_view_block_conf_updates(),
2673 modest_account_view_unblock_conf_updates() to prevent unnecessary
2674 updates, but this is not very useful because the gconf notifications are
2675 so delays (maybe only on Maemo Bora).
2676 So auto-updating is turned off, and these functions do an explicit
2677 update when necessary.
2678 However, something else is still doing too much work when adding/removing
2679 accounts, probably in another part of the application.
2681 * src/maemo/modest-account-view-window.c:
2682 (on_delete_button_clicked), (on_edit_button_clicked),
2683 (on_new_button_clicked): Use the new functions.
2685 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2687 * src/modest-account-mgr-helpers.c:
2688 (modest_account_mgr_set_first_account_as_default):
2689 Sort the list of names alphabetically-by-title, so we choose the first one
2691 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2692 alphabetically by the title.
2694 This fixes projects.maemo.org bug NB#56418 .
2696 * src/modest-account-mgr-priv.c:
2697 (_modest_account_mgr_account_from_key):
2698 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2699 avoid a valgrind error, and possible random behaviour.
2701 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2703 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2704 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2705 tinymail documentation to say that this can be expected.
2706 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2707 pretty, and should not happen, but I would prefer to know when it does.
2709 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2711 * configure.ac: When using the older hildon version, probably on Bora,
2712 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2714 * src/widgets/modest-attachment-view.c:
2715 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2718 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2720 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2721 Implemented the prototype. Can be tested with
2722 tests/dbus_api/test_open_message:
2724 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2726 * src/modest-tny-account-store.c:
2727 (modest_tny_account_store_instance_init), (get_password):
2728 * src/modest-ui-actions.c:
2729 (modest_ui_actions_on_password_requested):
2730 Do not store the password in gconf, because this function is called
2731 for non-remembered passwords. Actually use the cached (in the hash map)
2732 password instead of releasing it.
2733 The password will now not be remembered if it is asked via the protected
2734 password dialog, as per the UI spec.
2736 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2738 * src/modest-defs.h:
2739 * src/modest-account-mgr-helpers.h:
2740 * src/modest-account-mgr-helpers.c:
2741 Added modest_server_account_get_username_has_succeeded(),
2742 modest_server_account_set_username_has_succeeded().
2743 (modest_server_account_set_username),
2744 Reset the has-succeeded flag if the username changes.
2746 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2747 * src/maemo/modest-connection-specific-smtp-window.c:
2748 (modest_connection_specific_smtp_window_save_server_accounts):
2749 Use modest_server_account_set_username() instead of using
2750 modest_conf_set_string() directly, so that the has-succeeded flag is always
2753 * src/modest-ui-actions.c:
2754 (modest_ui_actions_on_password_requested): Dim the username entry if
2755 the username has ever worked, as per the UI spec.
2757 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2759 * src/modest-tny-account-store.c: (get_password):
2760 * src/modest-ui-actions.c:
2761 (modest_ui_actions_on_password_requested):
2762 Allow the username to be changed too, though there is more work to
2763 be done on exactly how this behaves.
2765 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2767 * src/modest-account-mgr-helpers.h:
2768 * src/modest-account-mgr-helpers.c:
2769 Added modest_account_mgr_get_display_name(),
2770 modest_server_account_get_username(),
2771 modest_server_account_set_username(),
2772 modest_server_account_set_password(),
2773 modest_server_account_get_hostname() functions so we do not need to
2774 use the conf API directly.
2776 * src/maemo/modest-main-window.c: (connect_signals):
2777 Actually connect ot the ModestAccountStore::request-password signal,
2778 so that we show the dialog when the password is requested by Tinymail,
2779 for isntance if it is empty.
2781 * src/modest-marshal.list:
2782 * src/modest-tny-account-store.c:
2783 (modest_tny_account_store_class_init), (get_password),
2784 (modest_tny_account_store_alert):
2785 * src/modest-tny-account-store.h:
2786 * src/modest-ui-actions.h:
2787 * src/modest-ui-actions.c:
2788 (modest_ui_actions_on_password_requested):
2789 Change the signal parameters, so it is obvious that we are providing
2790 the non human-readable server name, and receiving both the username
2791 and password, though changing of the username is not yet implemented.
2792 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2793 for the GNOME version.
2795 This should fix the projects.maemo.org bug NB#56209, though it does not
2796 work on Bora, because the gconf_client_get() for the password fails
2797 immediately after we save it with gconf_client_set().
2799 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2802 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2803 caused an undefined symbol error:
2804 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2806 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2808 * src/modest-tny-account-store.c:
2809 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2810 using a GError instead of a string message, so we can translate it in
2813 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2815 * src/maemo/modest-address-book.c:
2816 (modest_address_book_check_names):
2817 * src/maemo/modest-msg-view-window.c:
2818 (modest_msg_view_window_clipboard_owner_change):
2819 * src/modest-init.c: (modest_init_init_ui):
2820 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2821 (update_folders_cb), (modest_mail_operation_update_account):
2822 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2823 (modest_ui_actions_on_msg_attachment_clicked),
2824 (modest_ui_actions_on_msg_recpt_activated):
2825 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2826 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2827 (modest_msg_view_search_next):
2828 * src/widgets/modest-recpt-editor.c:
2829 (modest_recpt_editor_on_button_release_event),
2830 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2831 g_message(). At this point we should only be seeing interesting errors on
2832 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2834 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2836 (modest_wizard_dialog_force_title_update):
2837 * src/maemo/easysetup/modest-wizard-dialog.h:
2838 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2839 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2840 can update the title when appropriate. Otherwise the title is wrong if the
2841 pages are added after adding the notebook to the dialog.
2842 This must be a problem in HildonWizardDialog too.
2843 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2845 * src/maemo/easysetup/modest-easysetup-wizard.c:
2846 (create_subsequent_customsetup_pages),
2847 (create_subsequent_easysetup_pages):
2848 Call modest_wizard_dialog_force_title_update() so that the title is
2849 correct even with GTK+ < 2.10.
2850 This fixes projects.maemo.org bug NB#56145 .
2852 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2854 * src/maemo/modest-platform.c:
2855 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2856 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2859 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2861 * src/widgets/modest-window.h:
2862 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2863 and modest_window_save_state(), which invokes it.
2865 * src/widgets/modest-window-mgr.h:
2866 * src/widgets/modest-window-mgr.c:
2867 Added modest_window_mgr_save_state_for_all_windows(), which calls
2868 the save_state vfunc on all registered windows, if implemented.
2870 * src/gnome/modest-msg-edit-window.c:
2871 * src/gnome/modest-msg-view-window.c:
2872 * src/maemo/modest-msg-edit-window.c:
2873 * src/maemo/modest-msg-view-window.c:
2874 * src/maemo/modest-main-window.c:
2875 Specify the existing save_settings functions as implementations of
2876 ModestWindow::save_state_func().
2878 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2879 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2880 enabling hibernation, for instance.
2882 We may need to do the same thing for restoring settings.
2885 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2887 * src/widgets/modest-window-mgr.c:
2888 * src/widgets/modest-window-mgr.h:
2889 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2890 modest_window_mgr_get_hibernation_is_prevented().
2892 * src/maemo/modest-main-window.c:
2893 (on_hildon_program_is_topmost_notify): Prevent hibernation
2894 (possible when the application goes to the background in the WM),
2895 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2897 * src/maemo/easysetup/modest-easysetup-wizard.c:
2898 (modest_easysetup_wizard_dialog_init):
2899 * src/maemo/modest-account-settings-dialog.c:
2900 (modest_account_settings_dialog_init):
2901 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2902 (modest_connection_specific_smtp_edit_window_init):
2903 * src/maemo/modest-connection-specific-smtp-window.c:
2904 (modest_connection_specific_smtp_window_init):
2905 * src/maemo/modest-signature-editor-dialog.c:
2906 (modest_signature_editor_dialog_init):
2907 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2908 prevent hibernation while any of these account settings dialogs are open.
2910 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2912 * src/maemo/Makefile.am:
2913 * src/maemo/modest-osso-state-saving.c:
2914 * src/maemo/modest-osso-state-saving.h: Added
2915 modest_osso_load_state() and modest_osso_save_state() though they do
2916 nothing now. They should iterate through all the open windows and load/save
2918 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2919 save state when closing.
2921 * src/maemo/modest-main-window.c:
2922 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2923 Add a notification handler for the HildonProgram::is-topmost property,
2924 so we can allow hibernation when the application goes into the background.
2925 But we still need to detect when the accounts setup windows are open so
2926 we can stop hibernation when they are open.
2927 To do this, I also added the main window the HildonProgram. This might have
2928 other side-effects/benefits, and should maybe be done for other windows.
2930 * src/maemo/modest-osso-autosave-callbacks.h:
2931 * src/maemo/modest-osso-autosave-callbacks.c:
2932 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2933 though it does not do anything yet, and we might never need this to do
2934 anything. For instance, we already save drafts.
2936 * src/maemo/modest-platform.c: (modest_platform_init):
2937 Specify the libosso auto-save callback.
2939 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2941 * src/maemo/modest-platform.c:
2942 (modest_platform_set_update_interval):
2943 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2944 aparently stays valid between application instances, so we can use this
2945 to remove and reset it later. According to a maemo-developers email from
2948 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2950 * configure.ac: Depend on libalarm for Maemo.
2952 * src/dbus_api/modest-dbus-api.h:
2953 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2954 (on_send_receive), (modest_dbus_req_handler):
2955 Handle a SEND_RECEIVE D-Bus method.
2957 * libmodest-dbus-client/libmodest-dbus-client.c:
2958 (libmodest_dbus_client_send_and_receive):
2959 * libmodest-dbus-client/libmodest-dbus-client.h:
2960 Add C convenience functions for calling the new D-Bus method.
2962 * src/modest-platform.h:
2963 * src/gnome/modest-platform.c:
2964 * src/maemo/modest-platform.c:
2965 Added modest_platform_set_update_interval(), which uses the
2966 alarmd API on Maemo.
2967 (modest_platform_init),
2968 Call modest_platform_set_update_interval(), using a hard-coded
2969 interval for now (until the global settings dialog is implemented),
2970 though I am not sure that this makes sense yet.
2972 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2974 * src/dbus_api/modest-dbus-callbacks.c:
2975 (modest_osso_cb_hw_state_handler):
2976 * src/dbus_api/modest-dbus-callbacks.h:
2977 * src/maemo/modest-platform.c: (modest_platform_init):
2978 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2979 in case this has some effect on the ability for Maemo to ping the
2982 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2984 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2985 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2986 warning. It is probably a logic error, but I need to fix the build.
2988 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2990 * src/modest-account-mgr.h:
2991 * src/modest-account-mgr.c:
2992 (modest_account_mgr_account_names): Add a gboolean enabled_only
2993 parameter, so we can get lists of onlt the enabled accounts.
2995 (modest_account_mgr_add_account),,
2996 (modest_account_mgr_account_with_display_name_exists):
2997 * src/maemo/modest-msg-edit-window.c: (get_transports):
2998 * src/modest-account-mgr-helpers.c:
2999 (modest_account_mgr_set_first_account_as_default):
3000 * src/modest-init.c: (init_default_account_maybe):
3001 * src/modest-tny-account-store.c: (get_accounts):
3002 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3003 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3004 * tests/check_account-mgr.c: (START_TEST):
3005 Provide the extra parameter, as appropriate.
3007 * src/widgets/modest-account-view.c: (update_account_view):
3008 Do not show disabled accounts (meaning that there is no way to
3009 enable/disable accounts in the UI (the feature is not in our UI
3010 specification), so we can use this internally only to mark unfinished
3011 or temporary account data.
3013 * src/maemo/easysetup/modest-easysetup-wizard.c:
3014 (create_account): Add boolean enable parameter, so we can specify FALSE
3015 to create the temporary account.
3016 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3017 (on_before_next): When finishing, when there is a temporary account, just
3019 Also, use a timeout to delay the showing of the dialog until gconf is likely
3020 to return correct information, due to a maemo gconf bug that is fixed in
3021 osso 1.1, but not yet in Bora.
3022 However, the dialog stays on screen after it is destroyed.
3024 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3025 for invalid data when cancelling. Use a hildon note instead of a dialog
3026 to complain about invalid data. Do not show the account-saved note if the
3027 account is disabled (a temporary account that will not really be saved for use
3030 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3032 * src/modest-account-mgr-helpers.h:
3033 * src/modest-account-mgr-helpers.c:
3034 Added modest_account_mgr_unset_default_account(),
3035 Added modest_account_mgr_set_first_account_as_default().
3037 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3038 If it was the default account, unset the default account name.
3040 * src/maemo/modest-account-view-window.c:
3041 (on_delete_button_clicked): If it was the default account,
3042 set the first remaining account as the default instead.
3044 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3045 a NULL account or a NULL default account, to prevent a crash. This should
3046 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3049 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3051 * src/widgets/modest-recpt-editor.c:
3052 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3053 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3054 TODO comment for this. This fixes the build.
3056 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3057 be the best place for it. This will in future update all auto-update accounts,
3058 rather than just the current/default account, when that gconf key exists.
3059 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3060 if there are no accounts, before calling do_send_receive().
3061 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3063 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3064 * src/maemo/modest-main-window-ui.h:
3065 * src/maemo/modest-main-window.c: (on_connection_changed),
3066 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3067 directly, becaue the signal handler does more.
3069 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3071 * src/modest-account-mgr-helpers.c:
3072 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3073 for the case that the account does not exist.
3075 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3076 (equivalent to the modest account name) rather than the tinymail account name
3077 (equivalent to the modest account title - human readable) to get the account data.
3078 Check for null account data to prevent the crash, and add a TODO comment saying that
3079 this needs fixing because it is using the server account name instead of the account name.
3081 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3083 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3084 * src/maemo/modest-account-settings-dialog.c: (show_error),
3086 Use hildon_note_new_information() for informative and error messages,
3087 which seems to be expected for Maemo applications (no documentation that I know of
3088 says this). I am surprised that there is no distinction between info and error
3091 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3093 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3094 it is easy to find where this is used.
3096 * src/maemo/easysetup/modest-easysetup-wizard.c:
3097 (create_page_welcome), (create_page_account_details),
3098 (create_page_user_details), (create_page_complete_easysetup),
3099 (create_page_custom_incoming), (create_page_custom_outgoing),
3100 (create_page_complete_custom):
3101 * src/maemo/modest-account-settings-dialog.c:
3102 (create_page_account_details), (create_page_user_details),
3103 (create_page_incoming), (create_page_outgoing):
3104 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3105 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3106 (modest_connection_specific_smtp_edit_window_init):
3107 * src/maemo/modest-connection-specific-smtp-window.c:
3108 (modest_connection_specific_smtp_window_init):
3109 * src/maemo/modest-signature-editor-dialog.c:
3110 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3111 and scrolling policy as per the Email Application Layout Guide, if I have
3114 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3116 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3117 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3118 which were empty, because these vfuncs have been removed from TnyAccountStore.
3119 This fixes the build.
3121 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3123 * src/maemo/modest-main-window.c:
3124 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3125 showing/hiding it. Added TODO because it probably should not be NULL.
3126 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3127 because unnecessary g_warnings() make degugging difficult.
3129 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3131 * src/maemo/modest-msg-edit-window.c:
3132 (modest_msg_edit_window_select_color),
3133 (modest_msg_edit_window_select_background_color): 2 const corrections and
3134 moving 2 #endifs before closing brackets, to fix the build.
3136 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3138 * src/maemo/easysetup/modest-easysetup-wizard.h:
3139 * src/maemo/easysetup/modest-easysetup-wizard.c:
3140 (modest_easysetup_wizard_dialog_finalize),
3141 (on_button_edit_advanced_settings), (create_page_complete_custom),
3142 (on_response), (create_account):
3143 Implement the Advanced Settings edit button, by saving the account information,
3144 for the Advanded Settings dialog to use directly from gconf, and removing it
3145 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3146 Bug #5533 in the projects.maemo.org bugzilla.
3148 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3150 * src/maemo/modest-msg-view-window.c:
3151 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3152 when opening a message window.
3154 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3156 * src/maemo/easysetup/modest-easysetup-wizard.c:
3157 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3160 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3161 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3162 gconf settings. I probably added more checks than necessary, but that is safer.
3164 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3165 variable to fix the build, but this seems to be used when it is still NULL.
3167 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3169 * src/modest-platform.h:
3170 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3171 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3172 * src/modest-main.c: Implement this function so we can avoid using
3173 maemo-specific API from cross-platform code.
3175 * src/modest-tny-account-store.c:
3176 (get_smtp_specific_transport_account_for_open_connection):
3177 * src/modest-ui-actions.c: (check_for_connection),
3178 (modest_ui_actions_on_item_not_found):
3179 Use modest_platform_connect_and_wait() and put #idefs around other
3180 maemo-specific code, because only maemo currently has a way to
3181 identify connection names.
3183 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3185 * src/modest-tny-account-store.h:
3186 * src/modest-tny-account-store.c:
3187 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3188 the connection-specific SMTP server settings in the configuration.
3190 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3192 * src/maemo/modest-main-window.c: (on_connection_changed),
3194 * src/modest-main.c: (main), (start_ui), (send_mail):
3195 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3196 that is what is intended.
3198 * src/modest-ui-actions.c: (action_send), (action_receive),
3199 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3200 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3201 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3202 SMTP server is used when it is specified.
3204 (modest_ui_actions_on_send_receive):
3205 Check that a connection is open before proceeding.
3206 Receive and then send, instead of vice-versa, as per the specification.
3208 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3210 * src/modest-mail-operation.c:
3211 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3212 though I guess it should be something other than NULL.
3214 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3216 * src/maemo/easysetup/modest-easysetup-wizard.c:
3217 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3218 combo twice, to avoid an g_warning and to make it visible again.
3219 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3220 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3221 (already intended) dereference when detaching, because we then recreate the menu.
3222 But I am not sure why the warning was happening, and it is possible that this is a memory
3225 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3227 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3228 and uri_parse_mailto() utility functions.
3229 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3231 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3233 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3235 * src/dbus_api/modest-dbus-api.h:
3236 * src/dbus_api/modest-dbus-callbacks.c:
3237 Use an idle callback to execute the modest code in the application's own thread.
3238 Remove the helloworld example method.
3239 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3240 parsed, and the open-message method is not implemented because this is not yet implemented in
3242 * libmodest-dbus-client/libmodest-dbus-client.c:
3243 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3244 (libmodest_dbus_client_open_message):
3245 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3247 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3248 body without crashing.
3250 * tests/dbus_api/Makefile.am:
3251 * tests/dbus_api/test_mail_to.c:
3252 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3254 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3256 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3257 Added file to fix the build. Sorry.
3259 * src/dbus_api/Makefile.am:
3260 * src/dbus_api/modest-dbus-api.h:
3261 * src/dbus_api/modest-dbus-callbacks.h:
3262 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3263 (modest_dbus_req_handler):
3264 Put constants in a separate header so it can be reused by the
3265 client library, without duplication
3267 * libmodest-dbus-client/Makefile.am:
3268 * libmodest-dbus-client/libmodest-dbus-client.c:
3269 (libmodest_dbus_client_call_helloworld),
3270 (libmodfest_dbus_client_send_mail),
3271 (libmodfest_dbus_client_mailto),
3272 (libmodfest_dbus_client_open_message):
3273 * libmodest-dbus-client/libmodest-dbus-client.h:
3274 (Partly) Implement a send_mail D-Bus method.
3276 * tests/dbus_api/Makefile.am:
3277 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3278 the send_email D-Bus method.
3280 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3284 * libmodest-dbus-client/Makefile.am:
3285 * libmodest-dbus-client/libmodest-dbus-client.c:
3286 * libmodest-dbus-client/libmodest-dbus-client.h:
3287 * tests/dbus_api/Makefile.am:
3288 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3289 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3291 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/easysetup/modest-easysetup-wizard.c:
3294 (create_page_account_details):
3295 * src/maemo/modest-account-settings-dialog.c:
3296 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3297 widgets, because this might not be the default in future versions of the Maemo GTK+.
3298 However, I can not not get capitalization to work even in a simple test case.
3300 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3302 * src/maemo/easysetup/modest-easysetup-wizard.c:
3303 (create_page_custom_incoming), (create_page_custom_outgoing):
3304 * src/maemo/modest-account-settings-dialog.c:
3305 (create_page_account_details), (create_page_incoming),
3306 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3307 instead of using gtk_check_button_with_label(), so they are aligned like the other
3308 widgets, as per the UI spec.
3310 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3312 * src/maemo/easysetup/modest-easysetup-wizard.c:
3313 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3314 * src/widgets/modest-validating-entry.c:
3315 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3316 Modest prefix instead of an EasySetup prefix.
3318 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3320 * src/widgets/modest-validating-entry.h:
3321 * src/widgets/modest-validating-entry.c: (on_insert_text),
3322 Added easysetup_validating_entry_set_max_func(), used to set a callback
3323 to call when the max number of characters is reached. GtkEntry has a max-length
3324 already but is silent about it.
3326 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3327 (create_page_account_details), (create_page_user_details),
3329 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3330 (create_page_account_details), (create_page_user_details),
3331 (create_page_outgoing):
3332 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3333 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3334 the UI spec, when the user tries to enter more than the max number of characters.
3336 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3338 * src/maemo/easysetup/modest-easysetup-wizard.c:
3339 (create_page_user_details), (create_page_custom_incoming),
3340 (create_page_custom_outgoing):
3341 * src/maemo/modest-account-settings-dialog.c:
3342 (create_page_user_details), (create_page_incoming),
3343 (create_page_outgoing):
3344 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3345 (modest_connection_specific_smtp_edit_window_init):
3346 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3347 not appropriate. Bad Maemo-specific defaults!.
3349 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3351 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3352 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3353 (modest_signature_editor_dialog_set_settings):
3354 Disable the label and textview when the checkbox is disabled, and use the
3355 specified (UI spec) default signature text.
3357 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3359 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3360 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3362 * src/modest-defs.h:
3363 * src/modest-account-mgr-helpers.h:
3364 * src/modest-account-mgr-helpers.c:
3365 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3367 * src/maemo/Makefile.am:
3368 * src/maemo/modest-signature-editor-dialog.c:
3369 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3372 * src/maemo/modest-account-settings-dialog.h:
3373 * src/maemo/modest-account-settings-dialog.c:
3374 (modest_account_settings_dialog_finalize), (on_button_signature),
3375 (save_configuration): Use the new dialog when the Edit button is pressed, and
3376 save the changes if necessary, as per the UI spec.
3378 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3380 * src/maemo/Makefile.am:
3381 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3382 based on maemo-develoers email from Dirk.
3384 * src/maemo/easysetup/modest-easysetup-wizard.c:
3385 (create_page_welcome), (create_page_account_details),
3386 (create_page_user_details), (create_page_complete_easysetup),
3387 (create_page_custom_incoming), (create_page_custom_outgoing),
3388 (create_page_complete_custom),
3389 (modest_easysetup_wizard_dialog_init):
3390 * src/maemo/modest-account-settings-dialog.c:
3391 (create_page_account_details), (create_page_user_details),
3392 (create_page_incoming), (create_page_outgoing),
3393 (modest_account_settings_dialog_init):
3394 * src/maemo/modest-connection-specific-smtp-window.c:
3395 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3397 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3399 * src/maemo/easysetup/modest-easysetup-wizard.c:
3400 (create_page_account_details), (create_page_custom_outgoing),
3401 (create_page_complete_custom):
3402 * src/maemo/modest-account-settings-dialog.c:
3403 (create_page_user_details), (create_page_incoming),
3404 (create_page_outgoing):
3405 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3406 (modest_connection_specific_smtp_edit_window_init):
3407 Use the correct (UI spec) port min/max, and use horizontal separators,
3410 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3412 * src/maemo/easysetup/modest-easysetup-wizard.c:
3413 (set_default_custom_servernames):
3414 * src/maemo/modest-account-settings-dialog.c:
3415 (create_page_incoming), (on_combo_outgoing_security_changed),
3416 (on_combo_incoming_security_changed), (create_page_outgoing),
3417 (modest_account_settings_dialog_set_account_name),
3418 (save_configuration):
3419 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3420 (on_combo_security_changed),
3421 (modest_connection_specific_smtp_edit_window_init),
3422 (modest_connection_specific_smtp_edit_window_set_connection),
3423 (modest_connection_specific_smtp_edit_window_get_settings):
3424 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3427 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3430 * src/maemo/easysetup/modest-easysetup-wizard.c:
3431 (create_page_custom_outgoing), (create_page_complete_custom):
3432 * src/maemo/modest-account-settings-dialog.c:
3433 (create_page_user_details), (create_page_outgoing):
3434 * src/maemo/modest-account-view-window.c: (button_box_new):
3435 Use changed logical IDs as per the most recent UI spec:
3436 mcen_bd_emailsetup_edit -> mcen_bd_edit
3437 mcen_bd_emailsetup_delete -> mcen_bd_delete
3438 mcen_bd_emailsetup_close -> mcen_bd_close
3440 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3444 * src/dbus_api/Makefile.am:
3445 * src/dbus_api/modest-dbus-callbacks.c:
3446 * src/dbus_api/modest-dbus-callbacks.h:
3447 * src/maemo/modest-platform.c: (modest_platform_init):
3448 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3450 * tests/Makefile.am:
3451 * tests/dbus_api/Makefile.am:
3452 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3454 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3456 * src/maemo/modest-account-settings-dialog.c:
3457 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3458 Removed unnecessary includes.
3460 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3462 * src/maemo/easysetup/modest-easysetup-wizard.c:
3463 * src/maemo/modest-account-settings-dialog.c:
3464 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3465 * src/widgets/Makefile.am:
3466 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3467 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3468 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3469 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3470 * src/widgets/modest-secureauth-combo-box.c:
3471 * src/widgets/modest-secureauth-combo-box.h:
3472 * src/widgets/modest-serversecurity-combo-box.c:
3473 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3474 made the GObject names more consistent with the rest of the Modest code.
3476 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3478 * src/maemo/easysetup/Makefile.am:
3479 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3480 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3481 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3482 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3483 * src/maemo/easysetup/modest-easysetup-wizard.c:
3484 * src/maemo/easysetup/modest-validating-entry.c:
3485 * src/maemo/easysetup/modest-validating-entry.h:
3486 * src/maemo/modest-account-settings-dialog.c:
3487 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3488 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3489 widgets/ because they are used outside of easysetup too. After checking in,
3490 svn will allow me to rename them too.
3492 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3494 * src/gnome/modest-msg-edit-window.c:
3495 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3496 linker error, to fix the build on the GNOME platform.
3497 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3498 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3499 ifdefed out to avoid a warning.
3501 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3503 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3504 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3505 some alternative for GTK+ 2.6.
3507 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3509 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3511 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3512 specified for EmailAccountsDialog in UI spec.
3514 * src/maemo/easysetup/modest-easysetup-wizard.c:
3515 * src/maemo/easysetup/modest-easysetup-wizard.h:
3516 * src/maemo/modest-account-settings-dialog.c:
3517 * src/maemo/modest-account-settings-dialog.h:
3518 Reuse a member window widget for the connection-specific SMTP server accounts,
3519 so we can tell it to create/save the accounts only if we actually save changes.
3521 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3522 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3523 (modest_connection_specific_smtp_edit_window_get_settings):
3524 Return a struct instance for temporarily remembering the entered data.
3526 * src/maemo/modest-connection-specific-smtp-window.h:
3527 * src/maemo/modest-connection-specific-smtp-window.c:
3528 (modest_connection_specific_smtp_window_finalize),
3529 (modest_connection_specific_smtp_window_fill_with_connections),
3531 (modest_connection_specific_smtp_window_save_server_accounts),
3532 (update_model_server_names): Do not actually save data until asked,
3533 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3535 (on_selection_changed),
3536 (modest_connection_specific_smtp_window_init): Disable the edit
3537 button when nothing is selected.
3539 * src/modest-account-mgr-helpers.c:
3540 * src/modest-account-mgr-helpers.h:
3541 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3544 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3546 * src/modest-account-mgr-helpers.h:
3547 * src/modest-account-mgr-helpers.c:
3548 (modest_account_mgr_get_unused_account_name),
3549 (modest_account_mgr_get_unused_account_display_name): Added these
3550 utility functions, to avoid code duplication.
3552 * src/maemo/easysetup/modest-easysetup-wizard.c:
3553 (create_page_account_details), (create_account):
3554 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3555 (on_combo_security_changed),
3556 (modest_connection_specific_smtp_edit_window_init),
3557 (modest_connection_specific_smtp_edit_window_save_settings):
3558 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3559 * src/maemo/modest-connection-specific-smtp-window.c:
3560 (modest_connection_specific_smtp_window_finalize),
3561 (modest_connection_specific_smtp_window_fill_with_connections),
3562 (on_button_edit), (modest_connection_specific_smtp_window_init):
3563 * src/maemo/modest-connection-specific-smtp-window.h:
3564 Implementing saving of connection-specific server accounts.
3566 But I need to refactor this so we can save the data for each
3567 possible connection-specific account and only actually create the server accounts
3568 when the easysetup finished, or the OK button is pressed on the account settings
3571 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3573 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3574 (on_combo_security_changed):
3575 (modest_connection_specific_smtp_edit_window_init):
3576 Auto-fill the port number as in the account settings.
3578 (modest_connection_specific_smtp_edit_window_set_connection):
3579 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3580 * src/maemo/modest-connection-specific-smtp-window.c:
3581 (fill_with_connections), (on_button_edit),
3582 (modest_connection_specific_smtp_window_init):
3583 Turn the edit window into a dialog to simplify the code, and
3584 set a WM hint as in a GtkDialog, because only a popup can be on top of
3585 another window in Maemo, and popups usually have no WM decoration.
3587 * src/modest-defs.h:
3588 * src/modest-account-mgr-helpers.c:
3589 (modest_account_mgr_set_connection_specific_smtp),
3590 (modest_account_mgr_remove_connection_specific_smtp),
3591 (modest_account_mgr_get_connection_specific_smtp):
3592 * src/modest-account-mgr-helpers.h: Some functions to write the
3593 connection-specific SMTP server information. Not yet used.
3596 * src/widgets/modest-folder-view.c: (text_cell_data):
3597 Fix a warning about an uninitialized variable.
3598 (on_configuration_key_changed): Put an #ifdef around the use
3599 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3601 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3603 * src/maemo/modest-account-settings-dialog.h:
3604 * src/maemo/modest-account-settings-dialog.c:
3605 Added connect_for_modified() utility function to mark the new modified boolean.
3607 (create_page_account_details), (create_page_user_details),
3608 (create_page_incoming), (create_page_outgoing), (on_response),
3609 (modest_account_settings_dialog_init),
3610 (modest_account_settings_dialog_set_account_name):
3611 Only warn about unsaved changes when there are actually unsaved changes.
3613 * src/modest-account-mgr-helpers.c:
3614 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3615 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3616 to get the data from there in future.
3618 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3620 * src/modest-defs.h:
3622 * src/modest-account-mgr-helpers.h:
3623 * src/modest-account-mgr-helpers.c:
3624 Store the security account setting in a single conf key instead of using
3625 the options list, so that the list is left for just the to-be-removed camel hack,
3626 and because gconf_client_set_list() is failing for some reason.
3628 * src/modest-account-mgr.c:
3629 (modest_account_mgr_add_server_account):
3630 * src/maemo/modest-account-settings-dialog.c:
3631 (modest_account_settings_dialog_set_account_name),
3632 (save_configuration): Use the renamed functions.
3635 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3637 * src/widgets/Makefile.am:
3638 * src/widgets/modest-limit-retrieve-combo-box.c:
3639 * src/widgets/modest-limit-retrieve-combo-box.h:
3640 * src/widgets/modest-retrieve-combo-box.c:
3641 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3642 the account settings dialog.
3644 * src/modest-defs.h:
3645 * src/modest-account-mgr-helpers.h:
3646 * src/modest-account-mgr-helpers.c:
3647 (modest_server_account_get_option_secure_auth),
3648 (modest_server_account_set_option_secure_auth):
3649 * src/modest-account-mgr.c:
3650 (modest_account_mgr_add_server_account):
3651 Use the existing AUTH_MECH conf key for the secure-auth setting,
3652 instead of putting it in the list options, because this was actually used already.
3654 * src/maemo/modest-account-settings-dialog.c:
3655 (create_page_account_details),
3656 (modest_account_settings_dialog_set_account_name),
3657 (save_configuration):
3658 * src/maemo/modest-account-settings-dialog.h:
3659 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3660 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3662 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3664 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3665 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3666 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3668 * src/modest-defs.h:
3669 * src/maemo/modest-account-settings-dialog.c:
3670 (create_page_incoming), (on_combo_outgoing_security_changed),
3671 (on_combo_incoming_security_changed), (create_page_outgoing),
3672 (modest_account_settings_dialog_set_account_name),
3673 (save_configuration): Load/Save the port number, and change it when the
3674 security combo changes, to suitable defaults.
3676 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3678 * src/modest-account-mgr.c:
3679 (modest_account_mgr_add_server_account): Set the security and secure-auth
3680 options, and add a comment saying that the other camel-specific options should be
3683 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3685 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3687 * src/modest-tny-account-store.c: (account_list_free),
3688 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3689 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3692 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3694 * src/modest-protocol-info.c:
3695 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3696 is required by our UI spec. Maybe something in our implementation will use this eventually.
3697 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3698 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3699 instead of the previous 0 placeholder.
3701 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3702 secure-auth settings.
3703 * src/modest-account-mgr-helpers.h:
3704 * src/modest-account-mgr-helpers.c:
3705 (modest_server_account_data_get_option_secure_auth),
3706 (modest_server_account_set_option_secure_auth),
3707 (modest_server_account_data_get_option_security),
3708 (modest_server_account_set_option_security): Added this API for getting and setting the security
3709 and secure-auth settings.
3711 * src/maemo/modest-account-settings-dialog.h:
3712 * src/maemo/modest-account-settings-dialog.c:
3713 (modest_account_settings_dialog_finalize), (check_data),
3714 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3715 about changing titles.
3716 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3717 (save_configuration): Save the security and secure-auth settings.
3719 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3720 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3722 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3724 * src/modest-defs.h:
3725 * src/modest-account-mgr.c:
3726 (modest_account_mgr_add_server_account):
3727 Added and used defines for the options key and value pair strings,
3728 that are used so far, though they do not seem to correspond to anything in our
3729 UI specs or ModestProtocol enum.
3731 * src/modest-account-mgr-helpers.h:
3732 * src/modest-account-mgr-helpers.c:
3733 (compare_option_strings_for_name),
3734 (modest_server_account_data_get_option_value),
3735 (modest_server_account_data_get_option_bool),
3736 (modest_account_mgr_get_server_account_option):
3737 Added helper functions for parsing the options GSList.
3739 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3741 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3742 display name is based on the supplied account name.
3743 * src/modest-account-mgr.c:
3744 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3745 with an inefficient, but good-enough, implementation.
3747 * src/maemo/easysetup/modest-easysetup-wizard.c:
3748 (create_page_account_details), (on_before_next), (create_account):
3749 Check for existing display names rather than (non-user-visible) account names, and just
3750 create and set a unique account name at the end.
3752 * src/maemo/modest-account-settings-dialog.c:
3753 (modest_account_settings_dialog_init),
3754 (modest_account_settings_dialog_set_account_name),
3755 (create_page_incoming): Show the display name, instead of the account name.
3756 (on_response): Do some (not all) extra checks, as in the UI spec.
3757 (save_configuration): Save the display name if it was changed.
3759 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3761 * po/en_GB.po: Added needed logical ID and translation.
3762 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3763 (init_view): Made the is-default column clicking work.
3765 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3768 * src/maemo/easysetup/Makefile.am:
3769 * src/maemo/easysetup/modest-easysetup-wizard.c:
3770 (modest_easysetup_wizard_dialog_init):
3771 * src/maemo/easysetup/provider-data-test.keyfile:
3772 * src/maemo/easysetup/provider-data.keyfile:
3773 Moved the provider data file to the new modest-providers-data package and used it from there.
3775 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3777 * src/modest-local-folder-info.c:
3778 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3779 N_() was already used on the static strings, but this just marks it for translation without
3780 using the translation.
3782 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3784 * src/maemo/modest-account-settings-dialog.c:
3785 (create_page_incoming),
3786 (modest_account_settings_dialog_set_account_name):
3787 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3788 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3789 I will do this if nobody else gets there first.
3791 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3793 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3794 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3795 save the security stuff.
3797 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3799 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3800 Set the email address and user fullname, which I now see must be
3803 * src/maemo/modest-account-settings-dialog.h:
3804 * src/maemo/modest-account-settings-dialog.c:
3806 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3807 leave-on-server and authentication.
3808 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3811 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3814 * src/maemo/modest-account-settings-dialog.c:
3815 * src/maemo/modest-account-settings-dialog.h:
3816 Most (but not all) of the widgets are now present as specified by the UI spec.
3817 No changes are yet saved, and some details are not properly shown yet.
3819 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3821 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3823 * src/maemo/Makefile.am:
3824 * src/maemo/modest-account-settings-dialog.c:
3825 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3826 an existing account. Doesn't do much yet.
3828 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3829 Open the accounts settings dialog when Edit is clicked.
3831 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3833 * src/maemo/easysetup/Makefile.am:
3834 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3836 * src/maemo/easysetup/modest-easysetup-wizard.c:
3837 (modest_easysetup_wizard_dialog_init):
3838 Try to get the source directory from the build system,
3839 instead of hard-coding "./" into the source code, when opening our local
3840 copies of the configuration files.
3841 But this still fails when opening the wizard from the Accounts window,
3842 maybe because the working directory seems to change at runtime.
3843 So the wizard will fail the second time unless you copy the files into their
3844 proper locations - see the stdout warnings for the paths.
3846 (create_page_account_details),(on_before_next):
3847 Check for existing non-server accounts instead of server accounts,
3848 so the default account name is useful again, and to prevent trying to
3851 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3852 Show the wizard when New is clicked.
3854 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3855 (init_view): Show the column headers, and show the columns that are
3856 specified in the UI specs. However, something in Maemo's GTK+ prevents
3857 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3858 change the default account. This is despite unsetting the special properties.
3860 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3862 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3863 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3864 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3865 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3866 to make that clearer.
3867 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3869 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3871 * src/maemo/modest-account-view-window.c:
3872 (modest_account_view_window_init),
3873 (modest_account_view_window_new):
3874 Use the same buttons as specified in the
3875 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3876 the existing widgets, which never had a chance of working.
3877 Put the ModestAccountView treeview in a scrolled window.
3878 Do not repeat the initialization in both _init() and _new().
3880 * src/widgets/modest-account-view.c: (update_account_view):
3881 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3882 this widget and window shows no accounts.
3884 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3886 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3888 * src/maemo/easysetup/modest-easysetup-wizard.c:
3889 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3890 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3891 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3894 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3895 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3896 accounts exist yet, as in the UI spec.
3898 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3900 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3902 * src/maemo/Makefile.am:
3903 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3904 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3905 New window for editing connection-specific smtp details.
3906 Not fully implemented.
3908 * src/maemo/modest-connection-specific-smtp-window.c:
3909 (modest_connection_specific_smtp_window_finalize) :
3910 unref the tree model.
3911 (on_button_edit): Show the edit window.
3913 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3915 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3918 * src/maemo/Makefile.am:
3919 * src/maemo/modest-connection-specific-smtp-window.c:
3920 * src/maemo/modest-connection-specific-smtp-window.h:
3921 New window for showing the list of connections, for connection-specific
3922 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3923 * src/maemo/easysetup/modest-easysetup-wizard.c:
3924 (create_page_custom_outgoing): Show the new window when the button is clicked.
3926 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3928 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3929 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3930 * src/maemo/modest-msg-edit-window.c:
3931 (modest_msg_edit_window_insert_image):
3932 * src/modest-conf.c: (modest_conf_key_escape):
3933 * src/modest-mail-operation.c:
3934 (modest_mail_operation_send_new_mail):
3935 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3936 (modest_ui_actions_on_new_account):
3937 * src/widgets/modest-attachment-view.c: (update_filename_request):
3938 * src/widgets/modest-mail-header-view.c:
3939 Corrected warnings that were breaking the build, by commenting out unused variables,
3940 and a function, and by including a header.
3942 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3944 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3945 so we can #ifdef around platform-specific code when necessary.
3946 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3947 to allow this to build for the GNOME platform too.
3949 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3951 * src/maemo/easysetup/modest-easysetup-wizard.c:
3952 Added util_increment_name() and used it in create_page_account_details()
3953 to make sure that the default account name is always a new name.
3955 (modest_easysetup_wizard_dialog_init),
3956 (set_default_custom_servernames): Some minor memory management fixes.
3958 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3962 * src/modest-runtime.c: (init_i18n): Restored the translation
3963 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3964 are defined in config.h, and the translations are installed.
3966 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3967 is defined for translation.
3969 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3971 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3973 * src/maemo/easysetup/modest-easysetup-wizard.c:
3974 (modest_easysetup_wizard_dialog_init):
3975 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3976 Use realistic paths (though they should use $prefix generically) to the
3977 mcc_mapping and provider-data.keyfile files which might work when they
3978 are installed by the future version of the operator-wizard package,
3979 and then fallback to paths in our source code, with an explanatory
3982 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3986 * src/maemo/Makefile.am:
3987 * src/maemo/easysetup/: Added files from the previously-exernal
3988 osso-modest-easysetup.
3989 * src/maemo/modest-main-window-ui.h:
3990 * src/modest-ui-actions.c:
3991 * src/modest-ui-actions.h:
3992 Added modest_ui_actions_on_new_account() as a signal handler for the
3993 New Account menu item. It shows the easysetup wizard.
3994 * po/en_GB.po: Added additional needed logical IDs and translations.