1 2007-07-02 Murray Cumming <murrayc@murrayc.com
3 * src/modest-tny-account.c: Added util_run_in_main_thread_and_wait()
4 which uses an idlen handler and mainloop to ensure that the function
5 is called in the main thread.
6 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
7 to make sure that we call attempt the connection in the mainloop only,
8 which might solve some hangs.
10 2007-07-02 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-tny-account.h:
13 * src/modest-tny-account.c:
14 (modest_tny_account_new_from_server_account),
15 (modest_tny_account_new_from_server_account_name),
16 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
17 because this must now be set before setting the proto. This is usd in
18 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
19 warning in camel_session_get_service() caused by
20 tny_camel_transport_account_prepare().
22 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
25 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
27 * src/maemo/modest-connection-specific-smtp-edit-window.c:
29 (modest_connection_specific_smtp_edit_window_init):
31 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
34 2007-06-29 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-tny-account.c:
37 (modest_tny_account_new_from_server_account):
38 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
39 now uses to request a connection when it needs one, and which it uses
40 to tell us that something is wrong with the connection, so we can force
41 the accounts offline to prevent further problems.
44 * src/modest-init.c: (init_default_settings):
45 * src/modest-mail-operation.c:
46 (modest_mail_operation_update_account):
47 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
48 This should not be necessary anymore. Do not set the conf key that
49 determined this (it was always TRUE and not set anywhere else).
51 * src/modest-ui-actions.h: Remove unused and unimplemented
52 modest_ui_actions_on_online_toggle_toggled().
54 2007-06-29 Murray Cumming <murrayc@murrayc.com
56 * src/maemo/modest-main-window.c: (connect_signals):
57 Don't connect to delete_event twice. Maybe this was harmless.
59 2007-06-29 Murray Cumming <murrayc@murrayc.com
61 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
62 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
63 Debug output to give some more clue when a folder move is not allowed.
65 2007-06-28 Murray Cumming <murrayc@murrayc.com
67 * src/modest-tny-account.c: (on_modest_file_system_info),
68 (modest_tny_account_get_mmc_account_name):
69 Always call the callback, without checking whether the name has changed.
70 * src/widgets/modest-folder-view.c: (strings_are_equal),
71 (on_model_foreach_set_name), (on_get_mmc_account_name),
72 (text_cell_data): Compare the name here, and use the name from
73 the account rather than from the
74 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
75 if the name was changed after the account was added to the model.
76 That's a tinymail bug but not one that I want to fix now.
78 This finally fixes projects.maemo.org bug NB#59301.
80 2007-06-27 Armin Burgmeier <armin@openismus.com>
82 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
85 2007-06-27 Murray Cumming <murrayc@murrayc.com
87 * src/modest-tny-account.h:
88 * src/modest-tny-account.c:
89 Added modest_tny_account_get_mmc_account_name(), to set the memory
90 card name asynchronously for the given account and then notify.
91 (modest_tny_account_new_for_local_folders): Use this new function instead
92 of using hildon_file_system_info_async_new() directly.
94 * src/widgets/modest-folder-view.c: (text_cell_data):
95 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
96 gtk_tree_model_row_changed() when it is available.
98 This should fix projects.maemo.org bug NB#59301.
100 2007-06-27 Murray Cumming <murrayc@murrayc.com
102 * src/modest-mail-operation.c: (update_account_thread),
103 (get_msgs_full_thread): Fix typo failures in the revert
106 2007-06-27 Murray Cumming <murrayc@murrayc.com
108 * src/maemo/modest-maemo-global-settings-dialog.c:
109 (idle_select_default_focus):
110 * src/modest-mail-operation.c: (idle_notify_progress),
111 (idle_notify_progress_once), (set_last_updated_idle),
112 (update_account_thread), (get_msgs_full_thread):
113 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
114 * src/widgets/modest-header-view.c:
115 (idle_notify_headers_count_changed_destroy),
116 (idle_notify_headers_count_changed):
117 Reverted the additions of gdk_threads_enter/leave(), in case this
118 helps with a startup hang on the device.
120 2007-06-26 Armin Burgmeier <armin@openismus.com>
122 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
123 for supported secure authentication methods from server by
124 gtk_dialog_run(), saving CPU time and a potential race condition.
126 2007-06-26 Armin Burgmeier <armin@openismus.com>
128 * src/maemo/modest-maemo-utils.h:
129 * src/maemo/modest-maemo-utils.c: Added a
130 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
131 only error code to tell the calling code when the user canceled the
134 * src/maemo/modest-account-settings-dialog.h:
135 * src/maemo/modest-account-settings-dialog.c:
136 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
137 message if the retrieval of secure authentication methods was canceled
138 by the user. Perform the check before saving anything to configuration
139 to not end up with half-committed configuration changes, do not show
140 a "Saving to configuration failed" note when authentication methods
141 could not be retrieved.
143 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
146 2007-06-26 Murray Cumming <murrayc@murrayc.com>
148 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
149 Only return the first level of folders under accounts, because the
150 osso-global-search UI spec doesn't want the rest.
151 This fixed projects.maemo.org bug NB#61811.
153 2007-06-26 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-tny-account-store.c:
156 * src/modest-tny-account-store.h:
157 Added modest_tny_account_is_memory_card_account().
158 * src/maemo/modest-main-window.c: (create_details_widget):
159 Show the same information items for the memory card as we show for the
160 local-folders, to fix projects.maemo.org bug NB#59307.
162 2007-06-26 Murray Cumming <murrayc@murrayc.com>
164 * src/modest-tny-account-store.c: (get_password):
165 Added some checks for NULL to maybe prevent crashes, though I think
166 it was Philip's last commit that actually prevented the crash here
167 when creating a first new account.
168 But the new account is still not usable (no messages are shown)
169 until a restart of the application.
171 2007-06-26 Murray Cumming <murrayc@murrayc.com>
173 * src/maemo/modest-maemo-global-settings-dialog.c:
174 (idle_select_default_focus):
175 * src/modest-mail-operation.c: (idle_notify_progress),
176 (idle_notify_progress_once), (idle_notify_update_account_queue),
177 (set_last_updated_idle), (update_account_thread),
178 (notify_get_msgs_full), (get_msgs_full_destroyer),
179 (get_msgs_full_thread):
180 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
181 * src/widgets/modest-header-view.c:
182 (idle_notify_headers_count_changed_destroy),
183 (idle_notify_headers_count_changed):
184 Use gdk_threads_enter() and gdk_threads_enter_leave() in
185 all idle handlers, because some other thread could be blocking
186 the GDK lock, so that it can do GUI stuff.
188 2007-06-26 Murray Cumming <murrayc@murrayc.com>
190 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
191 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
192 (on_idle_send_receive), (on_idle_open_default_inbox):
193 * src/maemo/modest-msg-edit-window.c:
194 (modest_msg_edit_window_attach_file_noninteractive):
195 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
196 to prevent a hang. I don't quite understand why these are necessary,
197 beause we should already be in the main loop. I guess something outside
198 of the main loop is taking the lock.
200 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
201 we are really using URIs, and use files that are more likely to exist.
203 2007-06-26 Murray Cumming <murrayc@murrayc.com>
205 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
206 necessary because configure.ac now defines different variables.
208 2007-06-26 Murray Cumming <murrayc@murrayc.com>
210 * libmodest-dbus-client/libmodest-dbus-client.c:
211 * libmodest-dbus-client/libmodest-dbus-client.h:
212 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
213 libmodest_dbus_client_compose_mail() is what things actually use.
215 * src/dbus_api/modest-dbus-api.h:
216 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
217 * tests/dbus_api/Makefile.am:
218 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
221 2007-06-26 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-init.c: (modest_init_local_folders):
224 For memory-card (or other non local-folders) maildir accounts,
225 always create an Archive folder, so that there is somewhere to put
226 messages. This should be less confusing, because the user does not need
227 to guess that the need to create a folder.
229 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
231 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
232 Fixed icon size by using (50, 50) which is the same as defined by
235 2007-06-25 Armin Burgmeier <armin@openismus.com>
237 * src/widgets/modest-window-mgr.c:
239 * configure.ac: Correctly recognize hildon-notify presence and fixed
240 the build without it being installed.
242 2007-06-25 Murray Cumming <murrayc@murrayc.com>
244 * libmodest-dbus-client/libmodest-dbus-client.c:
245 (libmodest_dbus_client_search): Fix the build. Sorry.
246 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
247 (reply_forward_cb): Initialize variables to fix the build.
249 * src/modest-tny-account-store.c:
250 (modest_tny_account_store_get_tny_account_by): Fix the account URI
251 comparison (a silly typo) so that email search results can be opened
252 when there are more than one account.
254 2007-06-25 Murray Cumming <murrayc@murrayc.com>
256 * libmodest-dbus-client/libmodest-dbus-client.c:
257 (libmodest_dbus_client_search),
258 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
259 instead of 1 second, because the search gets folders and messages from
260 the server, which can take a long time. When it times out,
261 osso-global-search will report no results.
263 We need to specify whether we should search only cached information
264 (maybe with a user preference), and the osso-email-search-plugin
265 API should really be improved to allow that option, and to allow results
266 to be delivered asynchronously in batches.
268 2007-06-25 Murray Cumming <murrayc@murrayc.com>
270 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
271 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
272 GTK_ICON_SIZE_DIALOG is probably the wrong size.
274 2007-06-25 Murray Cumming <murrayc@murrayc.com>
276 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
277 that is an empty string. D-Bus seems to give us these instead of NULL.
279 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
281 * src/dbus_api/modest-dbus-callbacks.c:
282 * src/maemo/easysetup/modest-easysetup-wizard.h:
283 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
284 * src/maemo/modest-connection-specific-smtp-edit-window.c:
285 (modest_connection_specific_smtp_edit_window_init):
286 * src/maemo/modest-maemo-global-settings-dialog.c:
288 * src/maemo/modest-maemo-utils.c:
289 (modest_maemo_utils_setup_images_filechooser):
290 * src/maemo/modest-main-window.c: (create_details_widget):
291 * src/maemo/modest-msg-edit-window.c:
292 (modest_msg_edit_window_attach_file_noninteractive),
293 (modest_msg_edit_window_color_button_change),
294 (modest_msg_edit_window_set_zoom):
295 * src/modest-mail-operation.c: (update_account_thread):
296 * src/modest-tny-account-store.c:
297 * src/modest-tny-account.c:
298 * src/widgets/modest-global-settings-dialog.c:
299 * src/widgets/modest-window.h:
303 2007-06-25 Murray Cumming <murrayc@murrayc.com>
305 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
306 * src/modest-search.c: (modest_search_folder),
307 (modest_search_all_accounts): Actually search only in the specified folder,
308 doing a simple match on the folder ID.
309 * src/modest-search.h: Added a folder field to the ModestSearch struct,
310 and added some documentation.
312 2007-06-22 Armin Burgmeier <armin@openismus.com>
314 * src/maemo/modest-maemo-utils.h:
315 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
316 modest_maemo_utils_get_supported_secure_authentication_methods.
318 * src/maemo/easysetup/modest-easysetup-wizard.c:
319 * src/maemo/modest-account-settings-dialog.c: Show correct error if
320 one occured, not just "Server does not support secure authentication".
322 2007-06-22 Murray Cumming <murrayc@murrayc.com>
324 * src/modest-tny-account-store.c: (get_password):
325 Restored the call to tny_account_set_user() because Philip seems to have
326 stopped this from crashing (by not using the freed string). It still does
327 not work, but now we can test it.
329 2007-06-22 Murray Cumming <murrayc@murrayc.com>
331 * src/maemo/modest-msg-edit-window.c: (init_window):
332 Comment out use of an uninitialzed GtkScrolledWindow variable,
333 to fix the build and stop a crash. Yet again.
335 2007-06-22 Murray Cumming <murrayc@murrayc.com>
337 * src/modest-tny-account-store.c: (get_password):
338 Remove the call to tny_account_set_user() because this actually crashes.
339 As mentioned in the last commit, it is known to not work anyway.
341 2007-06-22 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-tny-account-store.c: (get_password):
344 Use tny_account_set_username() to tell tinymail that the username might
345 have changed too. But tinymail ignores this: see projects.maemo.org
347 * src/modest-ui-actions.c:
348 (modest_ui_actions_on_password_requested): Remove the useless attempt to
349 reset the connection when changing the username, and improve the comments.
350 Save the changed username to gconf at least, so it is used when Modest is
353 2007-06-21 Murray Cumming <murrayc@murrayc.com>
355 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
356 Do not use a query, so that we get all folders, including for POP and
357 local-folders. They work as search criteria too.
358 This fixes projects.maemo.org bug NB#57740.
360 2007-06-21 Murray Cumming <murrayc@murrayc.com>
362 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
363 Comment out the use of hildon_notification_set_sound() because it is
364 not declared, to fix the build. Warnings are serious, people.
366 2007-06-21 Armin Burgmeier <armin@openismus.com>
368 * src/maemo/modest-maemo-utils.h:
369 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
370 modest_maemo_utils_get_supported_secure_authentication_methods()
371 to query authentication methods for a specific user. This should fix
372 projects.maemo.org bug NB#61369.
374 * src/maemo/easysetup/modest-easysetup-wizard.c:
375 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
378 2007-06-21 Murray Cumming <murrayc@murrayc.com>
380 * libmodest-dbus-client/libmodest-dbus-client.h:
381 * libmodest-dbus-client/libmodest-dbus-client.c:
382 (modest_dbus_message_iter_get_search_hit),
383 (libmodest_dbus_client_search):
384 Reorganised and commented this.
385 Removed modest_search_hit_free() from the public API because it
388 Added libmodest_dbus_client_get_folders() and
389 modest_folder_result_list_free().
391 * src/dbus_api/modest-dbus-api.h:
392 * src/dbus_api/modest-dbus-callbacks.c:
393 (modest_dbus_req_filter): Commented. Moved most code to
394 on_dbus_method_search() and added on_dbus_method_get_folders().
396 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
397 of the extra D-Bus handler.
399 * tests/dbus_api/Makefile.am:
400 * tests/dbus_api/test_get_folders.c: New test for
401 libmodest_dbus_client_get_folders(). This seems to return an empty list
402 at the moment. That could be the same error that causes the message list
403 to be empty sometimes.
404 This should help with projects.maemo.org bug NB#57740.
406 2007-06-21 Armin Burgmeier <armin@openismus.com>
408 * src/modest-mail-operation.c: Do not call
409 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
410 notify the operation's end after having set the status to CANCELED for
411 the operation queue to listen on. This fixes a deadlock when there
412 were mail operations in the queue during its finalization.
414 * src/modest-singletons.c: Reordered uninitialization of the account
415 manager to happen after the mail operation queue was uninitialized
416 because the mail operation's in the queue might still try to access
417 the account manager (see modest_mail_operation_notify_end()). This
418 fixes a potential crash when terminating the application.
420 2007-06-21 Murray Cumming <murrayc@murrayc.com>
422 * src/modest-search.c:
423 (search_mime_part_and_child_parts): Moved some code here so we
424 can search recursively in child folders.
425 (modest_search_folder): Search in the message as a mime part, instead
426 of just its child mime parts.
427 (read_chunk), (search_mime_part_ogs):
428 Check how many bytes were read, to prevent an endless loop.
429 Searching in message bodies now works. This finishes the fix for
430 projects.maemo.org bug NB#61007.
432 2007-06-20 Murray Cumming <murrayc@murrayc.com>
434 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
435 Add a g_warning when the item is not a folder.
437 * src/modest-ui-dimming-rules.c:
438 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
439 when selected item is not a folder (for instance, an account), because
440 the UI spec only talks about folders.
441 I am not sure what the UI spec wants, so this might not totally fix
442 projects.maemo.org bug NB#60794.
444 2007-06-20 Murray Cumming <murrayc@murrayc.com>
446 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
447 (load_from_file): Sort the list. The unsorted list would be more noticeable
448 in non-English locales.
450 * src/maemo/modest-msg-edit-window.c:
451 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
452 warning and fix the build.
454 * src/maemo/modest-progress-bar-widget.c:
455 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
456 avoid a g_warning, and probably to avoid a crash.
458 2007-06-20 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-search.c: (modest_search_folder): Check for a GError
461 when calling tny_folder_get_headers(), to show that this is not the cause
464 2007-06-20 Murray Cumming <murrayc@murrayc.com>
466 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
467 Actually set the body query instead of the subject query.
469 * src/modest-search.c: (search_mime_part_ogs),
470 (search_mime_part_strcmp): Remove extra space from the text/* regex,
471 which would probably cause it to fail if we got this far.
473 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
474 to simplify the code.
475 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
476 be causing search-in-body to fail.
478 2007-06-20 Murray Cumming <murrayc@murrayc.com>
480 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
482 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
483 Better debug message when the folder cannot be found.
484 This should help with fixing projects.maemo.org bug #61287.
485 * src/modest-search.c: (add_hit): Do not leak the furl string.
487 2007-06-20 Murray Cumming <murrayc@murrayc.com>
489 * src/modest-ui-actions.c:
490 (modest_ui_actions_on_folder_selection_changed):
491 Do not special-case TNY_MERGE_FOLDER here, because
492 modest_tny_folder_get_account() already does that. This fixes
493 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
494 shown when the Outbox was selected).
496 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
498 * libmodest-dbus-client/libmodest-dbus-client.c:
499 (_dbus_iter_get_string_or_null): Initialize the string variable in
500 case this helps with Dirk's crash.
502 2007-06-19 Murray Cumming <murrayc@murrayc.com>
504 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
505 though it is not implemented yet (this function is maybe not even used),
506 to avoid breaking ABI in future.
507 * libmodest-dbus-client/libmodest-dbus-client.c:
508 (get_attachments_string): Moved some code into this generic function.
509 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
510 sends email. It is maybe not used.
511 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
512 (on_send_mail): Use attachments.
514 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
515 * src/maemo/modest-msg-edit-window.c:
516 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
517 a filename before using it, to fix projects.maemo.org bug NB#58233.
519 2007-06-19 Murray Cumming <murrayc@murrayc.com>
521 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
522 Initialize the continue_download variable to fix the build, and probably
523 to fix randome behaviour.
525 2007-06-18 Armin Burgmeier <armin@openismus.com>
527 * src/modest-tny-send-queue.h:
528 * src/modest-tny-send-queue.c: Keep track of the status of messages in
529 the queue so we can later show it in the UI. Replaced
530 modest_tny_send_queue_msg_is_being_sent() by
531 modest_tny_send_queue_get_msg_status().
533 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
535 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
536 gpointer. This probably was not harmful, but just to be sure.
538 2007-06-18 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
541 Fix the build, but leave the function broken on Bora, because
542 hildon_uri_action_get_service() does not exist.
543 osso_uri_action_get_service() does not exist either, it seems.
545 2007-06-18 Murray Cumming <murrayc@murrayc.com>
547 * src/modest-tny-account.c:
548 (modest_tny_account_new_from_server_account):
549 Uncommented the url debug output again, because it is useful for
550 debugging, as I said in the comment.
552 2007-06-18 Murray Cumming <murrayc@murrayc.com>
554 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
556 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
557 for Mameo Bora, to fix the build.
559 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
562 Fixed build with hildon < 0.99
564 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
565 Check if the selected account is busy instead of checking all accounts
567 * src/modest-account-mgr-priv.h:
568 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
569 (modest_account_mgr_init), (compare_account_name),
570 (modest_account_mgr_set_account_busy),
571 (modest_account_mgr_account_is_busy):
572 * src/modest-account-mgr.h:
573 Added busy information to the account manager. It possible to
574 set an account to busy or not busy now.
576 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
577 (modest_mail_operation_update_account),
578 (modest_mail_operation_notify_end):
579 Set the account to busy/not busy depending on the operation state.
581 * src/widgets/modest-account-view.c:
582 (modest_account_view_finalize), (get_last_updated_string),
583 (update_account_view), (on_account_busy_changed), (init_view):
584 Show string "Refreshing..." if the account is currently busy.
586 All this fixes projects.maemo.org bug NB#59711
588 2007-06-14 Armin Burgmeier <armin@openismus.com>
590 * src/widgets/modest-attachments-view.h:
591 * src/widgets/modest-attachments-view.c: Added
592 modest_attachments_view_has_attachments() and fixed coordinate
593 transformation in get_att_view_at_coords(). This fixes attachment
596 * src/widgets/modest-msg-view.c: Make use of
597 modest_attachments_view_has_attachments() to decide whether to show
598 attachments in the header.
600 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
602 * src/maemo/modest-connection-specific-smtp-edit-window.c:
603 (on_change), (on_combo_security_changed),
604 (modest_connection_specific_smtp_edit_window_init),
605 (modest_connection_specific_smtp_edit_window_set_connection),
606 (modest_connection_specific_smtp_edit_window_is_dirty):
607 * src/maemo/modest-connection-specific-smtp-edit-window.h:
608 * src/maemo/modest-connection-specific-smtp-window.c:
611 Show an comfirmation dialog for the smpt-edit-window if there are
612 unsaved changes and the user hits cancel.
613 (projects.maemo.org bug NB#60479)
615 2007-06-14 Armin Burgmeier <armin@openismus.com>
617 * src/maemo/easysetup/modest-easysetup-wizard.c:
618 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
619 address" info in banner instead of node, and select all the text as
620 per UI spec. This fixes projects.maemo.org bug NB#60550.
622 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
624 reviewed by: <delete if not using a buddy>
626 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
627 * src/modest-ui-actions.c: (folder_refreshed_cb):
629 2007-06-14 Murray Cumming <murrayc@murrayc.com>
631 * src/widgets/modest-folder-view.c: (filter_row):
632 Explictly filter out the per-account outbox accounts. I don't know why
633 these only sometimes show up, but now they should never show up in the UI.
634 This should fix projects.maemo.org bug NB#60160.
636 2007-06-14 Murray Cumming <murrayc@murrayc.com>
638 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
639 when the toolbar does not exist yet.
640 * src/modest-widget-memory.c: (save_settings_header_view):
641 Added g_warnings() to help us to discover when we are trying to set
642 an empty columns list in gconf.
644 2007-06-14 Murray Cumming <murrayc@murrayc.com>
648 Added modest_init_get_default_header_view_column_ids().
650 * src/modest-widget-memory.c: (restore_settings_header_view):
651 Use the new function to get defaults, if the gconf key is empty,
652 instead of not creating any columns. This seems to fix the
653 empty right-hand pane problems.
655 * src/widgets/modest-header-view.h: Improved documentation.
657 2007-06-13 Murray Cumming <murrayc@murrayc.com>
659 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
660 Revert the use of the display name as the account name, because this
661 is generally wrong and would break the code that follows.
663 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
665 * src/maemo/easysetup/modest-easysetup-wizard.c:
666 (check_for_supported_auth_methods), (on_before_next),
669 More correct fix for projects.maemo.org bug NB# 58991
670 Do not longer accept AUTH_PASSWORD as secure method and choose
671 correct method when creating the account.
673 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
675 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
676 Fixed projects.maemo.org bug NB# 58991
678 2007-06-13 Murray Cumming <murrayc@murrayc.com>
680 * src/modest-init.c: (modest_init_init_core),
681 (modest_init_local_folders): Fixed compilation errors.
683 2007-06-13 Murray Cumming <murrayc@murrayc.com>
685 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
686 Remove unnecessary lib/include, though it is good in principle when needed.
688 * src/modest-init.c: (modest_init_one_local_folder),
689 (modest_init_local_folders):
690 * src/modest-init.h: Initialize the .modest library for memory cards,
691 instead of just doing nothing for them. This should allow us to create
692 folders there, fixing projects.maemo.org bug NB#59297.
694 2007-06-13 Murray Cumming <murrayc@murrayc.com>
696 * libmodest-dbus-client/libmodest-dbus-client.c:
697 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
698 (libmodest_dbus_client_compose_mail),
699 (libmodest_dbus_client_open_message),
700 (libmodest_dbus_client_send_and_receive),
701 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
703 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
704 (on_idle_open_message), (modest_dbus_req_handler),
705 (search_result_to_message), (modest_dbus_req_filter):
706 * src/modest-search.c: (add_hit), (modest_search_folder),
707 (modest_search_all_accounts): Improved debug messages.
709 * tests/dbus_api/test_open_message.c: (main): Improved comments.
711 * src/modest-tny-account-store.c:
712 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
715 2007-06-13 Murray Cumming <murrayc@murrayc.com>
718 2007-06-12 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-tny-account-store.c: (get_server_accounts):
721 Call modest_tny_local_folders_account_add_merged_outbox_folders()
722 even when there are no accounts, so that the Outbox folder is always
723 visible. This fixes projects.maemo.org bug NB#60158.
725 2007-06-12 Murray Cumming <murrayc@murrayc.com>
727 * src/maemo/modest-main-window.c: (create_details_widget):
728 Use the mcen_va_never logical ID.
730 2007-06-12 Murray Cumming <murrayc@murrayc.com>
732 * src/dbus_api/modest-dbus-api.h:
733 * src/dbus_api/modest-dbus-callbacks.c:
734 (on_idle_open_default_inbox), (on_open_default_inbox),
735 (modest_dbus_req_handler):
736 Added a new OpenDefaultInbox method.
738 * libmodest-dbus-client/libmodest-dbus-client.h:
739 * libmodest-dbus-client/libmodest-dbus-client.c:
740 Added libmodest_dbus_client_open_default_inbox() to call the new
741 dbus method. This should be useful to projects.maemo.org bug NB#57214,
742 though it should maybe be used by a new osso-email-interface function.
744 * tests/dbus_api/Makefile.am:
745 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
748 2007-06-12 Murray Cumming <murrayc@murrayc.com>
750 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
751 NULL, so that the signals get all the keys. This should not actually
752 change any behaviour because we currently update everything when anything
755 2007-06-12 Murray Cumming <murrayc@murrayc.com>
757 * src/widgets/modest-folder-view.c: (text_cell_data),
758 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
759 (find_inbox_iter): If tinymail tells us that the folder is
760 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
761 This causes the inbox to be selected at startup, fixing part of
762 projects.maemo.org bug NB#56305.
764 * src/modest-ui-dimming-rules.c:
765 (modest_ui_dimming_rules_on_tools_smtp_servers):
766 * src/modest-ui-dimming-rules.h: Added a callback function to dim
767 the SMTP servers menu item.
768 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
769 that the SMTP Servers menu item is dimmed when there are no accounts,
770 as a future version of the UI spec will require. This fixes
771 projects.maemo.org bug NB#56305.
773 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
775 * src/maemo/modest-maemo-utils.c:
776 (modest_maemo_utils_get_supported_secure_authentication_methods):
777 Added label to dialog instead of unreadable title
779 * src/maemo/modest-main-window.c: (sync_accounts_cb),
780 (modest_main_window_new):
781 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
784 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
785 * src/modest-account-mgr.h:
786 Added method to avoid code duplication
788 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
789 (modest_ui_actions_on_send_receive):
790 Use modest_account_mgr_has_accounts
792 2007-06-11 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/easysetup/modest-presets.c:
795 (modest_presets_get_info_server_security): Do not report secure auth
797 * src/modest-protocol-info.c: Use the defines for the gconf key names
798 for secure authentication. This was not working because we were writing
799 Password and reading password, and the check was case sensitive.
800 With this, gmail now works for receiving and sending when created via
803 2007-06-11 Murray Cumming <murrayc@murrayc.com>
805 * src/maemo/easysetup/modest-presets.c:
806 (modest_presets_get_info_server_security): Correct the key name for
807 SecureSmtp, because it seems to be case-sensitive.
808 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
809 Do not try to get the 0th notebook page if there are 0 pages, to
812 2007-06-11 Murray Cumming <murrayc@murrayc.com>
814 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
815 Prevent use of the new notification feature for now, because it currently
816 shows one dialog for each new email, which is annoying.
818 2007-06-11 Murray Cumming <murrayc@murrayc.com>
820 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
821 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
822 when no country was selected, so that we show the global ones.
823 * src/maemo/easysetup/modest-presets.c:
824 (modest_presets_get_providers): Return only the global providers, not
825 all providers when mmc=0 was requested.
827 2007-06-11 Murray Cumming <murrayc@murrayc.com>
829 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
830 (easysetup_provider_combo_box_fill): Remove debug code that showed the
831 provider ID in the combo.
833 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
834 Do not show the page numbers, because it would be confusing when we add
835 the 2 extra pages for the custom setup, when the user chooses the "Other"
836 provider. This fixes projects.maemo.org bug NB#59028
838 * src/modest-init.c: (modest_init_init_core),
839 (modest_init_local_folders):
841 * src/modest-tny-account.c:
842 (modest_tny_account_new_for_local_folders): Do not create default folders
843 for the memory card. This should fix projects.maemo.org bug NB#59328.
845 2007-06-11 Murray Cumming <murrayc@murrayc.com>
847 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
848 Free the changed_conf_keys string items. They are already freed in the
849 idle handler if that runs first.
851 2007-06-11 Murray Cumming <murrayc@murrayc.com>
853 * src/modest-ui-actions.c:
854 (modest_ui_actions_on_password_requested): Check that the server name
855 is not NULL, because I just saw a password dialog with (null) as the
858 * src/modest-tny-folder.[h|c]: Added
859 modest_tny_folder_is_memory_card_folder().
860 * src/modest-ui-dimming-rules.c:
861 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
862 menu item for memory cards, as per the UI spec (section 7.4). This should
863 fix projects.maemo.org bug NB#59297.
865 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
867 * src/maemo/modest-main-window.c: (sync_accounts_cb):
868 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
869 is another problem with the code, see Murray's comment at line 772)
871 2007-06-08 Murray Cumming <murrayc@murrayc.com>
873 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
874 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
875 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
876 (load_from_file), (easysetup_country_combo_box_init),
877 (easysetup_country_combo_box_get_active_country_ids),
878 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
879 instead of just one ID, to avoid duplicate country names in the UI.
881 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
882 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
883 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
884 a single ID, avoiding duplicate providers.
885 * src/maemo/easysetup/modest-easysetup-wizard.c:
886 (on_combo_account_country): Adapt to use a list.
888 2007-06-08 Murray Cumming <murrayc@murrayc.com>
890 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
891 keys changed in the last X seconds.
893 * src/modest-account-mgr.h:
894 * src/modest-account-mgr.c: (on_timeout_notify_changes),
895 (on_key_change), (modest_account_mgr_class_init),
896 (modest_account_mgr_init), (modest_account_mgr_finalize):
897 As the keys are changed, save them in a GSList* and signal that GSList*
898 further every X seconds, to batch changes, to allow us to do just one
899 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
900 bug NB#56941 and other (UI-blocking) delays when changing account settings.
902 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
903 changed signal signature.
905 * src/modest-conf.c: (modest_conf_set_list),
906 (modest_conf_on_change): Reenable notification.
908 (modest_conf_maemo_fake_on_change): Comment out the hack that
909 notified immediately instead of asynchronously.
911 * src/widgets/modest-account-view.h:
912 * src/widgets/modest-account-view.c:
913 (update_account_view): Select the previously-selected account ID,
914 if possible. This fixes projects.maemo.org bug NB#56933.
916 (on_account_changed), (on_account_removed),
917 (modest_account_view_select_account):
919 Remove the block/unblock functions
920 because they were not useful.
922 * src/maemo/modest-account-view-window.c:
923 (on_delete_button_clicked), (on_edit_button_clicked),
924 (on_new_button_clicked): Remove the use of the non-working block/unblock.
926 2007-06-08 Murray Cumming <murrayc@murrayc.com>
928 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
929 Improve the error dialog to show Incorrect Account Settings, which seems
930 clearer, and say that the internal error message (to be removed from the
931 dialog later) is often misleading.
932 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
934 * src/modest-tny-account.c:
935 (modest_tny_account_new_from_server_account): Uncomment the printf of the
936 URL because this is so useful for debugging on the device.
938 * src/widgets/modest-serversecurity-combo-box.c:
939 (modest_serversecurity_combo_box_fill): Correct a logical ID.
941 2007-06-08 Murray Cumming <murrayc@murrayc.com>
943 * src/modest-mail-operation.c:
944 (modest_mail_operation_send_new_mail):
945 Added a comment about a nasty but apparently harmless message. Details
946 added to the wiki g_warnings() page.
948 2007-06-08 Murray Cumming <murrayc@murrayc.com>
950 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
951 (modest_tny_send_queue_class_init):
952 Do not use the priv struct because it is empty, to avoid g_warnings
953 about a non-existant priv struct.
955 * src/modest-tny-account-store.c:
956 (modest_tny_account_store_get_server_account),
957 (modest_tny_account_store_get_transport_account_for_open_connection
958 ): Do not try to get transport server accounts for local folders,
959 because they don't have any. This avoids a g_warning().
961 * src/maemo/modest-main-window.c:
962 (modest_main_window_notify_send_receive_initied),
963 (on_configuration_key_changed):
964 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
966 * src/modest-mail-operation.c:
967 (modest_mail_operation_update_account):
968 * src/modest-tny-account-store.h:
969 * src/modest-tny-account.c:
970 (modest_tny_account_get_special_folder),
971 (modest_tny_account_new_for_local_folders),
972 (modest_tny_account_new_for_per_account_local_outbox_folder):
973 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
974 * src/modest-tny-local-folders-account.c:
975 (add_account_folders_to_merged_folder):
976 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
977 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
978 (modest_ui_actions_on_send):
979 * src/widgets/modest-folder-view.c: (update_model):
980 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
981 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
982 modest_tny_account_store_get_tny_account_by_account() to
983 modest_tny_account_store_get_server_account() to make the code clearer.
985 2007-06-07 Marcus Bauer <marcusb@openismus.com>
987 * src/dbus_api/modest-dbus-api.h:
988 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
989 * src/maemo/modest-msg-edit-window.c:
990 (modest_msg_edit_window_attach_file_noninteractive):
991 added g_warning in case the file to be attached does not exist
992 * tests/dbus_api/test_compose_mail.c: (main):
993 removed obsolete comment, added generic files as test case
995 2007-06-07 Murray Cumming <murrayc@murrayc.com>
997 * src/modest-tny-account-store.c: (get_server_accounts):
998 Create the local folders account only once, not once for each outbox, and
999 not only when there are some outboxes.
1001 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1003 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1004 code that is causing a crash at startup. Sergio says that he is fixing this.
1006 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1008 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1009 * src/maemo/modest-account-settings-dialog.c:
1010 (create_page_outgoing),
1011 (modest_account_settings_dialog_set_account_name),
1012 (save_configuration):
1013 - Fixed handling of the "Use secure authentication" toggle to comply with
1014 the ui specification. See also projects.maemo.org bug NB#58400
1016 - Restore the Secure connection setting combo correctly when loading
1019 * src/maemo/modest-maemo-utils.c:
1020 (on_camel_account_get_supported_secure_authentication),
1021 (modest_maemo_utils_get_supported_secure_authentication_methods):
1022 Fixed a crasher if operation is canceled
1024 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1025 (modest_protocol_info_auth_is_secure):
1026 * src/modest-protocol-info.h:
1028 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1029 the sense of the "Use secure authentication" toggle.
1031 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1033 * src/modest-tny-account-store.h:
1034 * src/modest-tny-account-store.c:
1035 Added modest_tny_account_store_get_local_folders_account().
1037 * src/modest-tny-folder.h:
1038 * src/modest-tny-folder.c:
1039 (modest_tny_folder_get_account):
1040 Added this replacement for tny_folder_get_account() which returns
1041 the local-folders account for TnyMergeFolders, to avoid the
1042 warning about the unimplemented get_account_func() vfunc().
1044 (modest_tny_folder_get_rules),
1045 * src/modest-ui-actions.c:
1046 (modest_ui_actions_on_folder_selection_changed):
1047 * src/modest-mail-operation.c:
1048 (modest_mail_operation_remove_folder),
1049 (modest_mail_operation_xfer_folder),
1050 (modest_mail_operation_rename_folder),
1051 (modest_mail_operation_get_msg),
1052 (modest_mail_operation_get_msgs_full),
1053 (modest_mail_operation_remove_msg),
1054 (modest_mail_operation_xfer_msgs),
1055 (modest_mail_operation_refresh_folder):
1056 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1058 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1060 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1061 (modest_server_account_set_security):
1062 * src/modest-defs.h: Add comments explaining that our
1063 UI spec means TLS when it says Normal, so these do not look like errors.
1065 * src/modest-tny-account.c:
1066 (modest_tny_account_new_from_server_account): Use the new tinymail
1067 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1068 for TLS. This should fix projects.maemo.org bug NB#58460.
1070 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1072 * src/maemo/easysetup/modest-easysetup-wizard.c:
1073 (create_account): Correct the position of the gconf sanity check warning.
1074 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1075 of using the g_idle_add() hack, because this does not seem to be necessary
1076 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1077 caused by something other than maemo's gconf.
1078 This fixes projects.maemo.org bug #59022.
1080 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1082 * src/modest-account-mgr-helpers.c:
1083 (modest_account_mgr_get_default_account): Do not check that the account
1084 exists if there is no default account (NULL), to fix a runtime warning.
1086 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1088 * src/widgets/modest-folder-view.c: (update_model):
1089 Do not unref the treemodel before we have finished with it.
1090 This prevents a valgrind warning and an occasional crash at startup.
1092 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1094 * libmodest-dbus-client/libmodest-dbus-client.h:
1095 added libmodest_dbus_client_compose_mail()
1096 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1098 added functions needed for SendAsMail() functionality
1099 * src/maemo/modest-msg-edit-window.c:
1100 (modest_msg_edit_window_attach_file_noninteractive):
1101 non interactively attaching files to message edit window
1102 * src/widgets/modest-msg-edit-window.h:
1103 * tests/dbus_api/Makefile.am:
1104 added test_compose_mail.c
1105 * tests/dbus_api/test_compose_mail.c: (main):
1107 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1109 * src/modest-account-view.c:
1110 Fixed bug projects.maemo.org bug NB#59307
1112 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1114 * src/maemo/easysetup/modest-easysetup-wizard.c:
1115 (get_serverport_incoming), (on_before_next), (create_account):
1116 * src/maemo/modest-account-settings-dialog.c:
1117 (modest_account_settings_dialog_set_account_name):
1118 * src/maemo/modest-maemo-utils.c:
1119 (on_camel_account_get_supported_secure_authentication_status),
1120 (on_camel_account_get_supported_secure_authentication),
1121 (on_secure_auth_cancel),
1122 (modest_maemo_utils_get_supported_secure_authentication_methods):
1124 Implemented security authentication for settings and easysetup.
1126 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1128 * src/maemo/modest-main-window.c: (create_details_widget):
1129 Show the total size for memory card accounts too, instead of showing
1130 the name again. Fixes bug projects.maemo.org bug NB#59307.
1132 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1135 * src/modest-tny-simple-folder-store.c:
1136 * src/modest-tny-simple-folder-store.h: Removed.
1138 * src/modest-tny-local-folders-account.h
1139 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1140 for the local-folders maildir, with an extra TnyMergedFolder containing
1141 the folders of the per-account outbox store accounts.
1142 * src/modest-tny-account-store.c: (get_server_accounts):
1143 Add the outboxes to the special local folders account after creating it.
1145 * src/modest-tny-account.c:
1146 (modest_tny_account_new_for_local_folders): Create the derived
1147 account when creating the main local-folders account.
1149 * src/maemo/modest-main-window.c: (create_details_widget),
1150 (modest_main_window_set_contents_style):
1151 Adapted to the use of the derived account instead of the folder store.
1153 * src/modest-ui-actions.c:
1154 (modest_ui_actions_on_folder_selection_changed):
1155 * src/modest-ui-dimming-rules.c:
1156 (modest_ui_dimming_rules_on_new_folder):
1157 * src/widgets/modest-folder-view.c: (text_cell_data),
1158 (icon_cell_data), (filter_row), (update_model),
1159 (get_cmp_rows_type_pos):
1162 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1163 Do not get the priv struct, because no priv struct has been set,
1164 to avoid a runtime warning.
1166 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1167 #ifelse with #else, to fix a warning, to fix the build.
1170 2007-06-05 Christian Kellner <ckellner@openismus.com>
1172 * libmodest-dbus-client/libmodest-dbus-client.c:
1173 Fix small typo in doc (why do you always see them
1174 AFTER committing stuff?)
1177 2007-06-05 Christian Kellner <ckellner@openismus.com>
1179 * libmodest-dbus-client/libmodest-dbus-client.c:
1180 (libmodest_dbus_client_search):
1181 Initialize hit list with NULL. Also set folder list
1182 to "" if NULL was supplied.
1185 2007-06-03 Christian Kellner <ckellner@openismus.com>
1187 * libmodest-dbus-client/libmodest-dbus-client.c:
1188 (modest_search_hit_list_free):
1189 Make it save to call it with NULL.
1191 * src/dbus_api/modest-dbus-callbacks.c:
1192 * src/modest-search.c:
1193 Return full ModestSearchHits as the search result list not TnyHeader
1194 since can't be around withouth the correspoding TnyFolder.
1196 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1198 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1199 Added currently commented code to check for secure auth
1201 * src/maemo/modest-account-settings-dialog.c: (on_response),
1202 (save_configuration), (show_ok):
1203 Fixed projects.maemo.org bugs NB #59248 and #59251
1205 * src/maemo/modest-maemo-utils.c:
1206 (on_camel_account_get_supported_secure_authentication_status),
1207 (on_camel_account_get_supported_secure_authentication),
1208 (modest_maemo_utils_get_supported_secure_authentication_methods):
1209 * src/maemo/modest-maemo-utils.h:
1210 Moved get_supported_secure_authentication() method here to be able
1211 to use it from easysetup wizard.
1213 * src/modest-pair.c: (on_pair_compare_as_string):
1214 Should compare string with first part of pair and not
1215 strcmp pairs which will crash.
1217 * src/modest-protocol-info.c:
1218 (modest_protocol_info_protocol_is_store):
1219 * src/modest-protocol-info.h:
1220 Added modest_protocol_info_get_auth_protocol_name()
1222 2007-06-03 Armin Burgmeier <armin@openismus.com>
1224 * src/modest-mail-operation.c:
1225 (modest_mail_operation_get_msgs_full): Set priv->account also when
1226 only retrieving a single message. This avoids a crash when canceling
1229 (modest_mail_operation_notify_end): Do not explicitely remove the
1230 operation from the queue but only emit the progress_changed signal.
1231 The queue itself listens to that signal to remove the operation when
1232 it is finished. This reduces coupling and removes a potential deadlock
1233 when modest_mail_operation_notify_end() is called from the queue
1234 itself. If that is a problem performance-wise, I would suggest to
1235 implement a status-changed signal or something.
1237 * src/modest-mail-operation-queue.c: Make sure to never call a
1238 function from another file while the queue is locked. This (hopefully)
1239 fixes another deadlock when exiting the application while retrieving
1242 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1244 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1245 Fixed build if libogs is not available
1247 2007-06-03 Christian Kellner <ckellner@openismus.com>
1249 * libmodest-dbus-client/libmodest-dbus-client.h:
1250 * libmodest-dbus-client/libmodest-dbus-client.c:
1251 (libmodest_dbus_client_delete_message):
1252 Implement deletion of messages (Client side).
1254 (modest_search_hit_free),
1255 (modest_search_hit_list_free):
1256 Utility functions to free the result hits.
1258 * src/dbus_api/modest-dbus-api.h:
1259 * src/dbus_api/modest-dbus-callbacks.c:
1260 (on_delete_message),
1261 (modest_dbus_req_handler):
1262 Implement deletion of messages (Server side).
1264 * tests/dbus_api/test_search.c: (main):
1267 * tests/dbus_api/Makefile.am:
1268 * tests/dbus_api/test_delete_message:
1269 Add little test for the message deletion logic
1271 2007-06-03 Armin Burgmeier <armin@openismus.com>
1273 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1274 when the operation queue was not empty. projects.maemo.org bug
1277 2007-06-03 Armin Burgmeier <armin@openismus.com>
1279 * src/widgets/modest-account-view.c
1280 (on_account_default_toggled): Toggle default account column
1281 explicitely instead of waiting for gconf notification (which is
1282 currently ignored). This should fix projects.maemo.org bug NB#56910
1283 for now. It should probably be removed when gconf notifications are
1286 2007-06-03 Christian Kellner <ckellner@openismus.com>
1288 * libmodest-dbus-client/libmodest-dbus-client.c:
1289 Removed debugging spew.
1291 * src/dbus_api/modest-dbus-callbacks.c:
1292 Added debugging info.
1294 * src/modest-search.c:
1295 (modest_search_all_accounts):
1296 Use tny_account_store_get_accounts () on the account store
1297 to get all accounts which is the way to get all accounts.
1299 * tests/dbus_api/test_search.c: (main):
1300 Make it possible to supply the search term on the command line.
1302 2007-06-03 Christian Kellner <ckellner@openismus.com>
1304 * libmodest-dbus-client/libmodest-dbus-client.c:
1305 * libmodest-dbus-client/libmodest-dbus-client.h:
1306 Implement searching for mesages over raw dbus. (Client side)
1308 * src/dbus_api/Makefile.am:
1309 * src/dbus_api/modest-dbus-api.h:
1310 * src/dbus_api/modest-dbus-callbacks.c:
1311 * src/dbus_api/modest-dbus-callbacks.h:
1312 Search framework (Server side). Also implement on_idle_open_message().
1314 * src/maemo/modest-platform.c: (modest_platform_init):
1315 Prepare for raw dbus/osso rpc interaction.
1317 * src/modest-search.h:
1318 Changed minsize from unspecific guint to guint32.
1320 * src/modest-search.c:
1322 Added strange hack which magically made tnymail work.
1324 (modest_search_folder),
1325 (modest_search_account),
1326 (modest_search_all_accounts):
1327 Implement helper functions to search all accounts, specific account
1330 * tests/dbus_api/Makefile.am:
1331 * tests/dbus_api/test_open_message.c:
1332 Read url to open from commandline.
1334 * tests/dbus_api/test_search.c:
1335 Implement small test for dbus search stuff
1337 2007-06-02 Armin Burgmeier <armin@openismus.com>
1339 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1340 include account type and account title. This fixes projects.maemo.org
1343 * src/maemo/modest-account-view-window.c: Set a title for the window.
1345 2007-06-02 Armin Burgmeier <armin@openismus.com>
1347 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1348 incoming and outgoing server name based on email address and server
1349 types as long as the names have not been edited manually. This fixes
1350 projects.maemo.org bug NB#58671.
1352 2007-06-02 Armin Burgmeier <armin@openismus.com>
1354 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1355 server type cannot be changed in future to the incoming details page
1356 when creating an account. This fixes projects.maemo.org bug NB#59029.
1358 2007-06-02 Armin Burgmeier <armin@openismus.com>
1360 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1361 and assigned max width chars so that they wrap instead of being
1362 truncated. Fixes projects.maemo.org bug NB#56126.
1364 2007-06-02 Armin Burgmeier <armin@openismus.com>
1366 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1367 introductory note to the connection specific smtp servers dialog, as
1368 section 8.12 of the email UI specification requires. This fixes
1369 projects.maemo.org bug NB#59212.
1371 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1373 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1374 Check for running mail operations, and offer to cancel them, as per the UI
1375 spec. This fixes projects.maemo.org bug NB#59041 .
1376 However, I suspect that tinymail may still use the network connection
1377 in ways that we cannot detect or cancel. But it should at least adapt to
1378 changes fairly well.
1380 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1382 * src/modest-tny-account-store.c: (recreate_all_accounts),
1383 (get_cached_accounts), (get_server_accounts): Do more sensible
1384 ref-counting of the temporarily-cached outbox accounts list. This seems
1385 to fix a crash when entering the password when the password was wrong.
1387 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1389 * src/gnome/modest-main-window.c: (connect_signals):
1390 * src/modest-tny-account-store.c: (get_password),
1391 (modest_tny_account_store_alert): Added comments and clues and
1392 commented-out code about how we currently fail to deal with connection
1393 errors and wrong passwords, and how we should.
1395 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1397 * src/widgets/modest-retrieve-combo-box.c:
1398 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1399 This fixes projects.maemo.org bug NB#58472 .
1401 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/easysetup/modest-easysetup-wizard.c:
1404 (create_page_complete_easysetup):
1405 (create_page_complete_custom): Correct the last commit,
1406 putting the correct sentences in the correct pages.
1408 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1410 * src/maemo/easysetup/modest-easysetup-wizard.c:
1411 (create_page_complete_custom): Show the second sentence of text
1412 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1415 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1417 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1418 Set the leave-on-server conf key by default. This fixes
1419 projects.maemo.org bug NB#59258 .
1421 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1423 * src/maemo/modest-account-view-window.c:
1424 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1425 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1428 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/easysetup/modest-easysetup-wizard.c:
1431 (create_caption_new_with_asterisk):
1432 * src/maemo/modest-account-settings-dialog.c:
1433 (create_caption_new_with_asterisk):
1434 Uncomment the code to add the asterisk, because they are no longer in the
1435 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1436 (update_incoming_server_title): Add an asterisk here too.
1438 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1440 * src/maemo/modest-maemo-global-settings-dialog.c:
1441 (current_connection): Check that we are even connected before trying to
1442 get the current connection name, to prevent a warning.
1444 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1445 Change the comments because tny_maemo_conic_device_connect() is now meant to
1447 * src/modest-mail-operation.c:
1448 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1449 make sure we have a connection and fail if we can't connect.
1451 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1453 * src/maemo/modest-main-window.c:
1454 (on_account_store_connecting_finished): Do not try to get the
1455 connection ID if we are not really connected. I am surprised that
1456 this signal handler is called when we are not connected.
1458 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-error.h:
1461 * src/modest-ui-actions.c:
1462 (modest_ui_actions_get_msgs_full_error_handler):
1463 Renamed an enum, added comments, added an enum
1464 for retrieve-limit errors.
1466 * src/modest-mail-operation.c: (foreach_add_item),
1467 (internal_folder_observer_update), (update_account_thread),
1468 (modest_mail_operation_get_msgs_full):
1469 (modest_mail_operation_update_account),
1470 Added comments about how this works, and some code that should
1471 (but does not) check the retrieve-limit. See the TODO comment.
1473 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1475 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1476 Initialize help_id to fix the build. Warnings are good.
1478 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1480 * src/widgets/modest-hbox-cell-renderer.c:
1481 (modest_hbox_cell_renderer_append):
1482 * src/widgets/modest-vbox-cell-renderer.c:
1483 (modest_vbox_cell_renderer_append):
1484 Fix the last commit by doing an extra ref.
1486 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1488 * src/widgets/modest-hbox-cell-renderer.c:
1489 (modest_hbox_cell_renderer_append):
1490 * src/widgets/modest-vbox-cell-renderer.c:
1491 (modest_vbox_cell_renderer_append):
1492 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1493 to fix the build with Maemo Bora.
1494 However, there seems to be a remaining crash, probably due to reference
1497 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1499 * src/modest-tny-account.c:
1500 (modest_tny_account_new_for_local_folders):
1501 Use hildon_file_system_info_async_new() to get a better name for
1502 the memory card account, setting it as the account name.
1503 The timing seems to work, but this is probably
1504 not the best place to do this. See the TODO comment.
1505 * src/maemo/modest-main-window.c: (create_details_widget):
1506 * src/widgets/modest-folder-view.c: (text_cell_data):
1507 Use the tny account name instead of hardcoding a name.
1509 2007-05-30 Christian Kellner <ckellner@openismus.com>
1511 * src/modest-search.c: (modest_search):
1512 Correctly set part_search_func even if we have already parsed
1513 the query and thus a valid OgsTextSearcher object.
1515 2007-05-30 Christian Kellner <ckellner@openismus.com>
1518 Search and check for libogs.
1521 Incooparte the ogs build env.
1523 * src/modest-mime-part-search-stream.c:
1524 * src/modest-mime-part-search-stream.h:
1525 Removed since we do the real searching now in modest-search.c.
1527 * src/modest-search.c:
1528 * src/modest-search.h:
1529 Implement support for ogs. We use that if available and requested
1530 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1531 should now handle the corner case when the search term is spread
1532 across multiple reads.
1533 Also the logic in modest_search () was corrected to search all
1534 requested fields until one is found.
1536 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1538 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1540 * src/modest-init.h:
1541 * src/modest-init.c: Made modest_init_local_folders() take a
1542 path and be public so we can iniitialize maildir folders on
1545 * src/modest-local-folder-info.h:
1546 * src/modest-local-folder-info.c:
1547 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1549 * src/modest-tny-account.c:
1550 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1551 still means the standard local-folders path on the local volume.
1553 * src/modest-tny-account-store.c:
1554 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1555 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1556 all accounts when that happens.
1557 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1558 this too, so it shows up in the treeview.
1560 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1562 * src/maemo/modest-maemo-global-settings-dialog.c:
1563 (current_connection):
1564 * src/widgets/modest-global-settings-dialog.c:
1565 (current_connection_default):
1566 Use the enum values instead of 0, 1 and -1,
1567 to make the code clearer.
1569 * src/modest-account-mgr-helpers.c:
1570 (modest_account_mgr_get_connection_specific_smtp): Make this code
1573 * src/modest-runtime.h:
1574 * src/modest-runtime.c:
1575 Added modest_runtime_remove_all_send_queues().
1576 * src/maemo/modest-main-window.c:
1577 (on_account_store_connecting_finished): Recreate the send queues,
1578 using the appropriate transport accounts for this new connection.
1579 Some futher adapting might be needed if the old send queues are not
1580 automatically stopped at this point.
1582 * src/modest-tny-account-store.c: (get_server_accounts):
1583 Create the connection-specific transport accounts, so that they can
1584 be found later by their ID.
1586 * src/modest-tny-account.h:
1587 * src/modest-tny-account.c:
1588 Added modest_tny_account_new_from_server_account_name().
1589 modest_tny_account_new_from_server_account(): Do not create the
1590 send queues here, because they will be
1591 recreated anyway when the connection changes for the first time.
1593 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1595 * src/modest-local-folder-info.h:
1596 * src/modest-local-folder-info.c:
1597 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1598 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1599 tbox_folder): Take a modest account name instead of a server TnyAccount,
1600 so we can have per-modest-account rather than per-transport-account
1602 We must make sure that we change or recreate the exisitng send queues
1603 when the connection changes for connection-specific transport accounts.
1605 * src/modest-tny-account-store.c:
1606 (create_per_account_local_outbox_folders): Create outboxed per modest
1607 account, not per transport account.
1609 * src/modest-tny-account.h:
1610 * src/modest-tny-account.c:
1611 (modest_tny_account_get_special_folder): For outboxes, get the
1612 parent modest account name. The account is ignored for other folders.
1613 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1614 modest account name rather than a server TnyAccount.
1616 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1618 * src/modest-tny-account.c:
1619 (modest_tny_account_new_from_server_account):
1620 Call modest_runtime_get_send_queue() immediately after creating transport
1621 accounts, so that they start trying to send email from the outbox as soon
1622 as possible at startup. This is probably what we want.
1624 * src/modest-mail-operation.c: (update_account_thread):
1625 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1626 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1627 * src/modest-tny-send-queue.h:
1628 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1629 (modest_ui_actions_on_send):
1630 Added comments about how sending works, though it needs some more work.
1632 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1634 * src/modest-tny-account.c:
1635 (modest_tny_account_get_special_folder): Add TODO because this fails when
1636 the network is busy.
1637 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1638 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1639 Do not try to show this window when there is no active account. The UI
1640 specs does not tell us what to do in this case.
1642 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1646 * src/maemo/Makefile.am:
1647 * src/widgets/Makefile.am: Some dist fixes.
1649 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1651 * src/maemo/modest-connection-specific-smtp-window.c:
1652 (on_button_edit): Make the code clearer, to prevent a double free.
1654 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1656 * src/maemo/modest-account-settings-dialog.c:
1657 (modest_account_settings_dialog_set_account_name),
1658 Check the connection-specific smtp servers checkbox if there are any.
1660 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1661 (modest_connection_specific_smtp_edit_window_init):
1662 Start with a suitable port number.
1664 * src/modest-account-mgr-helpers.h:
1665 * src/modest-account-mgr-helpers.c: Added
1666 modest_account_mgr_get_has_connection_specific_smtp().
1668 (modest_account_mgr_set_connection_specific_smtp),
1669 (modest_account_mgr_remove_connection_specific_smtp),
1670 (modest_account_mgr_get_has_connection_specific_smtp),
1671 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1672 connection-specific smtp server accounts in the account, rather than
1673 the server account conf dir.
1675 This fixes bug projects.maemo.org bug NB#58263 .
1677 * src/modest-tny-account-store.c:
1678 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1679 if there are no server accounts yet, to prevent an infinite loop when there
1680 are no accounts. Document that one must be called before the other.
1682 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1684 * src/modest-account-mgr-helpers.c:
1685 (modest_account_mgr_get_default_account): Make sure that at least
1686 one account is always the default, if there are any enabled accounts.
1687 This is just a sanity check that shouldn't be necessary.
1689 * src/modest-account-mgr-priv.c:
1690 (_modest_account_mgr_account_from_key): Unescape the conf key to
1691 get the real account name. For instance, this is an issue if a space
1692 was in the account name, which can happen because the account name
1693 is generated from the display name.
1694 (_modest_account_mgr_get_account_keyname): Always escape the
1696 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1697 Unescape the conf keys to get the real account names.
1699 For instance, previously the is-default radio button in the accounts
1700 list was not checked for any accounts at first. This fixes that,
1701 and might fix several similar bugs.
1703 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1705 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1706 Removed some debug printfs.
1708 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1710 Modest on-disk outbox directories are now here, for instance:
1711 $HOME/.modest/outboxes/<account-id-1>/outbox
1712 $HOME/.modest/outboxes/<account-id-2>/outbox
1714 $HOME/.modest/local-folders/outbox
1715 so we can have a separate outbox for each account.
1716 But they are shown as one outbox in the GtkTreeView, by using a
1717 TnyMergeFolder in a ModestTnySimpleFolderStore.
1720 * src/modest-tny-simple-folder-store.c:
1721 * src/modest-tny-simple-folder-store.h:
1722 Added ModestTnySimpleFolderStore, used to contain folders from
1723 other folder stores, such as other accounts.
1725 * src/modest-tny-outbox-account.h:
1726 * src/modest-tny-outbox-account.c:
1727 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1728 used for the per-account local outbox folders.
1730 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1731 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1732 only use this (internally) now for the non-outbox local folders.
1734 * src/modest-init.h:
1735 * src/modest-init.c: Added modest_init_one_local_folder(), for
1736 setting up the directory structure for each local folder.
1738 * src/modest-local-folder-info.c:
1739 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1740 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1742 * src/modest-local-folder-info.h:
1743 * src/modest-tny-account-store.c: (on_account_removed),
1744 (on_account_changed), (create_per_account_local_outbox_folders),
1745 (get_server_accounts), (modest_tny_account_store_get_accounts),
1746 (modest_tny_account_store_get_tny_account_by_account),
1747 (modest_tny_folder_store_is_virtual_local_folders):
1749 * src/modest-tny-account.h:
1750 * src/modest-tny-account.c:
1751 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1752 to create an on-disk per-account local outbox folder for each
1754 (create_per_account_local_outbox_folders): Create a local outbox folder
1755 for each transport account.
1756 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1757 for all local folders.
1759 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1760 instead of using g_object_get/set() directly. It is clearer.
1762 (modest_tny_folder_store_get_message_count),
1763 (modest_tny_folder_store_get_local_size
1764 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1765 because we now use these with non-acount folder stores.
1767 (modest_tny_account_get_special_folder),
1768 (modest_tny_account_new_from_server_account),
1769 (modest_tny_account_new_from_account):
1770 (recurse_folders): Adjust to the new outbox system.
1772 * src/modest-tny-folder.h:
1773 * src/modest-tny-folder.c:
1774 (modest_tny_folder_is_local_folder),
1775 (modest_tny_folder_get_local_folder_type),
1776 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1778 * src/widgets/modest-main-window.h:
1779 * src/maemo/modest-main-window.c: (create_details_widget),
1780 (modest_main_window_set_contents_style): Show details for any folder store,
1783 (modest_tny_folder_get_rules):
1784 Remove the const. C does not support constness enough for this.
1786 * src/modest-ui-actions.c:
1787 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1788 make all outboxes appear as one, in the usual local-folders tree node.
1790 (set_active_account_from_tny_account),
1791 (modest_ui_actions_on_folder_selection_changed):
1792 * src/widgets/modest-folder-view.c: (text_cell_data),
1793 (icon_cell_data), (filter_row),
1794 (add_account_folders_to_merged_folder),
1795 (add_account_folders_to_simple_folder_store), (),
1796 (get_cmp_rows_type_pos), (cmp_rows),
1797 (modest_folder_view_set_account_id_of_visible_server_account):
1798 Adjust to the new outbox system, using generic folder stores and folders
1799 in the GtkTreeModel.
1801 2007-05-23 Christian Kellner <ckellner@openismus.com>
1803 * src/modest-mail-operation.c:
1804 (modest_mail_operation_update_account):
1805 Use info->max_size instead of unintialized local var [small
1806 build fix]. (Added TODO to review that change since I don't
1809 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1811 * libmodest-dbus-client/libmodest-dbus-client.c:
1812 (libmodest_dbus_client_compose_mail): function added
1813 * src/dbus_api/modest-dbus-api.h:
1814 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1815 (on_compose_mail): Implementation of the SendAsMail functionality
1817 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1819 * src/modest-account-mgr.c:
1820 (modest_account_mgr_add_server_account): Set the secure-connection
1821 conf key for transport accounts as well as store accounts. I don't know
1822 why the if was there. For instance, this makes sure that we use SSL
1823 for the gmail preset from the easysetup wizard.
1825 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1827 * src/gnome/modest-main-window.c:
1828 (on_account_store_connecting_finished), (connect_signals):
1829 * src/maemo/modest-main-window.c:
1830 (on_account_store_connecting_finished), (connect_signals),
1831 (modest_main_window_new):
1832 Handle TnyAccountStore::connecting-finished instead of
1833 TnyDevice::connection-changed, because we cannot actually perform
1834 operations on accounts until TnyAccountStore has itself responded to
1835 the TnyDevice::connection-changed signal. This prevents a GError from
1837 Do not try to update at startup, because we (at least on scratchbox)
1838 already do an update at startup when the device goes online.
1839 This prevents a GError from tinymail.
1840 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1841 Added TODO about stopping simultaneous operations.
1843 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1845 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1846 * src/modest-mail-operation-queue.c:
1847 (modest_mail_operation_queue_remove):
1848 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1849 about where they happened.
1851 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1853 * src/modest-ui-actions.c:
1854 (modest_ui_actions_on_password_requested): Make sure that the remember
1855 output parameter is always TRUE.
1857 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1859 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1860 Show a OK/Cancel dialog if the error is a question, though we still do not
1861 know anything more about what we are asking the user.
1862 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1863 Fix an uninitialized variable (helper). This is a logic error, however.
1865 2007-05-21 Christian Kellner <ckellner@openismus.com>
1867 * src/modest-search.h:
1868 Correct bit shifting in the ModestSearchFlags enum.
1870 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1872 * src/modest-tny-account.c:
1873 (modest_tny_account_new_from_server_account): Do not use the lsub and
1874 check-all hard-coded IMAP options when using POP.
1876 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1878 * src/modest-tny-account.c:
1879 (modest_tny_account_new_from_server_account):
1880 Use NULL for the secure-auth method for POP when Password auth has been
1881 specified by the user, as we already do for IMAP. "auth=Login" causes
1882 an error from camel or the server.
1884 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/modest-account-settings-dialog.c:
1887 (create_page_account_details),
1888 (modest_account_settings_dialog_set_account_name):
1889 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1890 for the leave-on-server checkbox, rathr than just the checkbox, when
1891 the protocol is not POP.
1893 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1895 * src/widgets/modest-account-view.c:
1896 * src/widgets/modest-account-view.h:
1897 Added modest_account_view_select_account() which will be useful later
1898 to asynchronously re-select the edited account.
1900 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1902 * src/maemo/modest-account-settings-dialog.c:
1903 (modest_account_settings_dialog_set_account_name):
1904 Automatically choose the port numbers based on the secure authentication
1905 methods, if they have not been chosen before.
1906 This fixes projects.maemo.org bug NB#56273 .
1908 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1910 * src/maemo/modest-main-window-ui.h:
1911 * src/modest-ui-actions.c:
1912 * src/modest-ui-actions.h:
1913 Connect the Tools/SMTP Servers menu item to
1914 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1915 SMTP servers dialog, as in the UI specification and saves changes when it
1916 is closed. This fixed projects.maemo.org bug NB#56305 .
1918 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1920 * src/maemo/modest-connection-specific-smtp-window.c:
1921 (modest_connection_specific_smtp_window_init):
1922 Use gtk_window_set_default_size() to make this window big enough, so
1923 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1925 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1927 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1928 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1929 (modest_connection_specific_smtp_edit_window_init),
1930 Do not try to connect to a combobox signal before the combobox exists.
1931 This fixes the cras in projects.maemo.org bug NB#56288 .
1932 (modest_connection_specific_smtp_edit_window_get_settings):
1933 Remove the server_account_name parameter which was being checked for NULL
1934 though it was not used.
1936 * src/maemo/modest-connection-specific-smtp-window.c:
1937 (modest_connection_specific_smtp_window_fill_with_connections),
1938 (on_button_edit), (modest_connection_specific_smtp_window_init):
1939 Correct the number of treemodel columns to prevent a warning.
1940 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1941 libconic does not work.
1943 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1945 * src/modest-tny-account.c:
1946 (modest_tny_account_new_from_server_account):
1947 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1948 SMTP when "None" was chosen by the user. However, with my SMTP server that
1949 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1952 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1954 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1955 to explain the memory management issue with the ID in the ModestPair.
1957 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1958 (add_sending_page), (modest_account_assistant_finalize):
1959 * src/gnome/modest-gnome-global-settings-dialog.c:
1960 (create_updating_page), (create_composing_page):
1961 * src/gnome/modest-msg-edit-window.c: (get_transports),
1962 (init_window), (modest_msg_edit_window_finalize),
1963 (modest_msg_edit_window_get_msg_data):
1964 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1965 * src/gnome/modest-transport-widget.c:
1966 (modest_transport_widget_finalize), (smtp_configuration):
1967 * src/maemo/modest-maemo-global-settings-dialog.c:
1968 (create_updating_page), (create_composing_page):
1969 * src/maemo/modest-msg-edit-window.c: (get_transports),
1970 (init_window), (modest_msg_edit_window_finalize),
1971 (modest_msg_edit_window_get_msg_data),
1972 (modest_msg_edit_window_free_msg_data):
1973 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1974 (modest_store_widget_finalize):
1975 * src/maemo/modest-transport-widget.c:
1976 (modest_transport_widget_finalize), (smtp_configuration):
1977 * src/modest-main.c: (send_mail):
1978 * src/widgets/modest-combo-box.h:
1979 * src/widgets/modest-global-settings-dialog-priv.h:
1980 * src/widgets/modest-global-settings-dialog.c:
1981 (modest_global_settings_dialog_finalize):
1982 * src/widgets/modest-msg-edit-window.h:
1983 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1984 as long as the combo box, to prevent use of freed memory for the ID.
1986 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1988 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1989 get_accounts(), to make this clearer. Do not check for the enabled gconf
1990 key, because we do not use this for server accounts (at least, not yet).
1991 This allows us to send email again.
1993 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1995 * src/maemo/modest-platform.c:
1996 (on_modest_conf_update_interval_changed), (modest_platform_init):
1997 Only respond to this particular key change. All these strcmp()s cannot be
2000 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2002 * src/maemo/modest-maemo-global-settings-dialog.c:
2003 (current_connection): Prevent a crash in scratchbox when
2004 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2005 * src/maemo/modest-platform.c:
2006 (on_modest_conf_update_interval_changed), (modest_platform_init):
2007 Get the update interval from gconf and reset it when the gconf key changes.
2009 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2011 * src/modest-protocol-info.c:
2012 * src/modest-protocol-info.h: Adde enum-specific get functions,
2013 instead of using a ModestProtocolType enum parameter.
2015 * src/gnome/modest-account-assistant.c:
2016 * src/gnome/modest-store-widget.c:
2017 * src/gnome/modest-store-widget.h:
2018 * src/gnome/modest-transport-widget.c:
2019 * src/gnome/modest-transport-widget.h:
2020 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2021 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2022 * src/maemo/easysetup/modest-easysetup-wizard.c:
2023 * src/maemo/modest-account-settings-dialog.c:
2024 * src/maemo/modest-account-settings-dialog.h:
2025 * src/maemo/modest-store-widget.c:
2026 * src/maemo/modest-store-widget.h:
2027 * src/maemo/modest-transport-widget.c:
2028 * src/maemo/modest-transport-widget.h:
2029 * src/modest-account-mgr-helpers.c:
2030 * src/modest-account-mgr-helpers.h:
2031 * src/modest-account-mgr.c:
2032 * src/modest-account-mgr.h:
2033 * src/modest-tny-account.c:
2034 * src/modest-tny-folder.c:
2035 * src/widgets/modest-account-view.c:
2036 * src/widgets/modest-retrieve-combo-box.c:
2037 * src/widgets/modest-retrieve-combo-box.h:
2038 * src/widgets/modest-secureauth-combo-box.c:
2039 * src/widgets/modest-serversecurity-combo-box.c:
2040 * src/widgets/modest-serversecurity-combo-box.h:
2041 * tests/check_account-mgr.c:
2042 Use the specific functions, and use the re-renamed enum values for GNOME too.
2044 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2046 * src/modest-pair.h:
2047 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2048 so we can get the second based on the first.
2050 * src/maemo/modest-account-settings-dialog.h:
2051 * src/maemo/modest-account-settings-dialog.c:
2052 Added get_supported_secure_authentication_methods(), though it is mostly
2053 commented-out for now until the necessary API is committed to tinymail.
2054 (modest_account_settings_dialog_set_account_name),
2055 (save_configuration): Request the supported authentication methods from the
2056 server, so we can choose a working method.
2058 * src/modest-tny-account-store.h:
2059 * src/modest-tny-account-store.c:
2060 (modest_tny_account_store_get_session): Rename from
2061 tny_account_store_get_session().
2063 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2065 * src/modest-protocol-info.h: Split the ModestProtocol enum
2066 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2067 There was no need to have these unrelated values in one enum.
2069 * src/: many files: Adapted to changed enum. This makes the code a bit
2070 clearer, and the compiler could catch some errors.
2072 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2074 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2075 Show the detailed internal camel error message when an error happens
2076 during the configuration, so that our testers can give us more clues.
2077 For instance, in projects.maemo.org bug NB#56910 .
2079 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2081 * src/modest-tny-account.c:
2082 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2083 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2085 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2087 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2088 * src/maemo/modest-account-settings-dialog.c:
2089 (modest_account_settings_dialog_set_account_name),
2090 (save_configuration): For the incoming secure authentication checkbox,
2091 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2092 the UI specification. PLAIN does not seem to be supported for most IMAP
2093 servers anyway, and I am not sure what it would mean.
2094 However, we probably need to discover which of the secure-authentication
2095 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2096 * src/modest-account-mgr-helpers.c:
2097 (modest_account_mgr_get_server_account_data):
2099 * src/modest-tny-account.c:
2100 (modest_tny_account_new_from_server_account):
2101 Use tny_account_set_mech() to set secure-authentication methods,
2102 with some special-casing for IMAP, based on my observations of how
2105 * src/modest-account-mgr-helpers.h:
2106 * src/modest-account-mgr.c:
2107 * src/modest-defs.h: Comment that the URI is only used for local folders.
2109 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2111 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2112 parameter const, just to be neat.
2113 * src/modest-text-utils.c: (modest_text_utils_inline):
2114 End g_strconcat() with NULL, as its documentation says. This is almost
2115 certainly the cause of my crash at startup on the device. Interestingly,
2116 valgrind doesn't tell us about these errors.
2118 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2120 * scripts/build-packages: Added more precise comments about how to use
2121 this script, though I still get this error:
2122 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2123 error building tinymail
2125 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2127 * src/maemo/modest-main-window.c: (on_account_update):
2128 Very slight cleanup, hoping to make it simpler to discover what causes
2129 a crash here sometimes.
2131 * src/modest-tny-account.c:
2132 (modest_tny_account_new_from_server_account): Set the port. Added
2133 comments about the options and a TODO comment because I need to find out
2134 how to specify the secure authentication method.
2136 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2138 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2139 changed CFlags paths form modest to libmodest
2141 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2143 * src/modest-account-mgr-helpers.c:
2144 (modest_account_mgr_get_server_account_data),
2145 (modest_account_mgr_free_server_account_data):
2146 * src/modest-account-mgr-helpers.h:
2147 * src/modest-account-mgr.c:
2148 (modest_account_mgr_add_server_account):
2149 * src/modest-defs.h:
2150 * src/modest-tny-account.c:
2151 (modest_tny_account_new_from_server_account):
2152 Determine the options for tny_camel_account_add_option() here,
2153 based on the settings, rather than storing them directly in gconf.
2155 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2157 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2158 Show a more friendly error dialog now that we expect (from the tinymail
2159 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2161 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2163 * src/maemo/modest-main-window.c: (on_account_update): Check that
2164 account_name is not NULL, to prevent a crash at startup that I am
2165 seeing on the N800. I do wonder why it is NULL.
2167 * src/maemo/easysetup/modest-easysetup-wizard.c:
2168 (create_page_user_details):
2169 * src/maemo/modest-account-settings-dialog.c:
2170 (create_page_user_details), (create_page_outgoing):
2171 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2172 (modest_connection_specific_smtp_edit_window_init):
2173 * src/modest-ui-actions.c:
2174 (modest_ui_actions_on_password_requested):
2175 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2176 might do something useful with the on-screen keyboard.
2178 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2180 * src/maemo/modest-main-window.c: (on_account_update):
2181 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2182 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2184 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2186 * src/modest-tny-account-store.c: (on_account_changed):
2187 Correct the signature of this signal handler.
2189 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2191 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2192 Show a HildonNote instead of a GtkDialog for Maemo.
2194 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2196 * src/widgets/modest-account-view.h:
2197 * src/widgets/modest-account-view.c: (on_account_changed),
2198 (on_account_removed). Added a boolean flag, set/unset by
2199 modest_account_view_block_conf_updates(),
2200 modest_account_view_unblock_conf_updates() to prevent unnecessary
2201 updates, but this is not very useful because the gconf notifications are
2202 so delays (maybe only on Maemo Bora).
2203 So auto-updating is turned off, and these functions do an explicit
2204 update when necessary.
2205 However, something else is still doing too much work when adding/removing
2206 accounts, probably in another part of the application.
2208 * src/maemo/modest-account-view-window.c:
2209 (on_delete_button_clicked), (on_edit_button_clicked),
2210 (on_new_button_clicked): Use the new functions.
2212 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2214 * src/modest-account-mgr-helpers.c:
2215 (modest_account_mgr_set_first_account_as_default):
2216 Sort the list of names alphabetically-by-title, so we choose the first one
2218 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2219 alphabetically by the title.
2221 This fixes projects.maemo.org bug NB#56418 .
2223 * src/modest-account-mgr-priv.c:
2224 (_modest_account_mgr_account_from_key):
2225 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2226 avoid a valgrind error, and possible random behaviour.
2228 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2230 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2231 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2232 tinymail documentation to say that this can be expected.
2233 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2234 pretty, and should not happen, but I would prefer to know when it does.
2236 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2238 * configure.ac: When using the older hildon version, probably on Bora,
2239 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2241 * src/widgets/modest-attachment-view.c:
2242 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2245 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2247 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2248 Implemented the prototype. Can be tested with
2249 tests/dbus_api/test_open_message:
2251 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-tny-account-store.c:
2254 (modest_tny_account_store_instance_init), (get_password):
2255 * src/modest-ui-actions.c:
2256 (modest_ui_actions_on_password_requested):
2257 Do not store the password in gconf, because this function is called
2258 for non-remembered passwords. Actually use the cached (in the hash map)
2259 password instead of releasing it.
2260 The password will now not be remembered if it is asked via the protected
2261 password dialog, as per the UI spec.
2263 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2265 * src/modest-defs.h:
2266 * src/modest-account-mgr-helpers.h:
2267 * src/modest-account-mgr-helpers.c:
2268 Added modest_server_account_get_username_has_succeeded(),
2269 modest_server_account_set_username_has_succeeded().
2270 (modest_server_account_set_username),
2271 Reset the has-succeeded flag if the username changes.
2273 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2274 * src/maemo/modest-connection-specific-smtp-window.c:
2275 (modest_connection_specific_smtp_window_save_server_accounts):
2276 Use modest_server_account_set_username() instead of using
2277 modest_conf_set_string() directly, so that the has-succeeded flag is always
2280 * src/modest-ui-actions.c:
2281 (modest_ui_actions_on_password_requested): Dim the username entry if
2282 the username has ever worked, as per the UI spec.
2284 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2286 * src/modest-tny-account-store.c: (get_password):
2287 * src/modest-ui-actions.c:
2288 (modest_ui_actions_on_password_requested):
2289 Allow the username to be changed too, though there is more work to
2290 be done on exactly how this behaves.
2292 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2294 * src/modest-account-mgr-helpers.h:
2295 * src/modest-account-mgr-helpers.c:
2296 Added modest_account_mgr_get_display_name(),
2297 modest_server_account_get_username(),
2298 modest_server_account_set_username(),
2299 modest_server_account_set_password(),
2300 modest_server_account_get_hostname() functions so we do not need to
2301 use the conf API directly.
2303 * src/maemo/modest-main-window.c: (connect_signals):
2304 Actually connect ot the ModestAccountStore::request-password signal,
2305 so that we show the dialog when the password is requested by Tinymail,
2306 for isntance if it is empty.
2308 * src/modest-marshal.list:
2309 * src/modest-tny-account-store.c:
2310 (modest_tny_account_store_class_init), (get_password),
2311 (modest_tny_account_store_alert):
2312 * src/modest-tny-account-store.h:
2313 * src/modest-ui-actions.h:
2314 * src/modest-ui-actions.c:
2315 (modest_ui_actions_on_password_requested):
2316 Change the signal parameters, so it is obvious that we are providing
2317 the non human-readable server name, and receiving both the username
2318 and password, though changing of the username is not yet implemented.
2319 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2320 for the GNOME version.
2322 This should fix the projects.maemo.org bug NB#56209, though it does not
2323 work on Bora, because the gconf_client_get() for the password fails
2324 immediately after we save it with gconf_client_set().
2326 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2329 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2330 caused an undefined symbol error:
2331 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2333 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2335 * src/modest-tny-account-store.c:
2336 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2337 using a GError instead of a string message, so we can translate it in
2340 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2342 * src/maemo/modest-address-book.c:
2343 (modest_address_book_check_names):
2344 * src/maemo/modest-msg-view-window.c:
2345 (modest_msg_view_window_clipboard_owner_change):
2346 * src/modest-init.c: (modest_init_init_ui):
2347 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2348 (update_folders_cb), (modest_mail_operation_update_account):
2349 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2350 (modest_ui_actions_on_msg_attachment_clicked),
2351 (modest_ui_actions_on_msg_recpt_activated):
2352 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2353 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2354 (modest_msg_view_search_next):
2355 * src/widgets/modest-recpt-editor.c:
2356 (modest_recpt_editor_on_button_release_event),
2357 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2358 g_message(). At this point we should only be seeing interesting errors on
2359 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2361 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2363 (modest_wizard_dialog_force_title_update):
2364 * src/maemo/easysetup/modest-wizard-dialog.h:
2365 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2366 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2367 can update the title when appropriate. Otherwise the title is wrong if the
2368 pages are added after adding the notebook to the dialog.
2369 This must be a problem in HildonWizardDialog too.
2370 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2372 * src/maemo/easysetup/modest-easysetup-wizard.c:
2373 (create_subsequent_customsetup_pages),
2374 (create_subsequent_easysetup_pages):
2375 Call modest_wizard_dialog_force_title_update() so that the title is
2376 correct even with GTK+ < 2.10.
2377 This fixes projects.maemo.org bug NB#56145 .
2379 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2381 * src/maemo/modest-platform.c:
2382 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2383 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2386 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2388 * src/widgets/modest-window.h:
2389 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2390 and modest_window_save_state(), which invokes it.
2392 * src/widgets/modest-window-mgr.h:
2393 * src/widgets/modest-window-mgr.c:
2394 Added modest_window_mgr_save_state_for_all_windows(), which calls
2395 the save_state vfunc on all registered windows, if implemented.
2397 * src/gnome/modest-msg-edit-window.c:
2398 * src/gnome/modest-msg-view-window.c:
2399 * src/maemo/modest-msg-edit-window.c:
2400 * src/maemo/modest-msg-view-window.c:
2401 * src/maemo/modest-main-window.c:
2402 Specify the existing save_settings functions as implementations of
2403 ModestWindow::save_state_func().
2405 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2406 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2407 enabling hibernation, for instance.
2409 We may need to do the same thing for restoring settings.
2412 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2414 * src/widgets/modest-window-mgr.c:
2415 * src/widgets/modest-window-mgr.h:
2416 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2417 modest_window_mgr_get_hibernation_is_prevented().
2419 * src/maemo/modest-main-window.c:
2420 (on_hildon_program_is_topmost_notify): Prevent hibernation
2421 (possible when the application goes to the background in the WM),
2422 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2424 * src/maemo/easysetup/modest-easysetup-wizard.c:
2425 (modest_easysetup_wizard_dialog_init):
2426 * src/maemo/modest-account-settings-dialog.c:
2427 (modest_account_settings_dialog_init):
2428 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2429 (modest_connection_specific_smtp_edit_window_init):
2430 * src/maemo/modest-connection-specific-smtp-window.c:
2431 (modest_connection_specific_smtp_window_init):
2432 * src/maemo/modest-signature-editor-dialog.c:
2433 (modest_signature_editor_dialog_init):
2434 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2435 prevent hibernation while any of these account settings dialogs are open.
2437 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/Makefile.am:
2440 * src/maemo/modest-osso-state-saving.c:
2441 * src/maemo/modest-osso-state-saving.h: Added
2442 modest_osso_load_state() and modest_osso_save_state() though they do
2443 nothing now. They should iterate through all the open windows and load/save
2445 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2446 save state when closing.
2448 * src/maemo/modest-main-window.c:
2449 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2450 Add a notification handler for the HildonProgram::is-topmost property,
2451 so we can allow hibernation when the application goes into the background.
2452 But we still need to detect when the accounts setup windows are open so
2453 we can stop hibernation when they are open.
2454 To do this, I also added the main window the HildonProgram. This might have
2455 other side-effects/benefits, and should maybe be done for other windows.
2457 * src/maemo/modest-osso-autosave-callbacks.h:
2458 * src/maemo/modest-osso-autosave-callbacks.c:
2459 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2460 though it does not do anything yet, and we might never need this to do
2461 anything. For instance, we already save drafts.
2463 * src/maemo/modest-platform.c: (modest_platform_init):
2464 Specify the libosso auto-save callback.
2466 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/modest-platform.c:
2469 (modest_platform_set_update_interval):
2470 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2471 aparently stays valid between application instances, so we can use this
2472 to remove and reset it later. According to a maemo-developers email from
2475 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2477 * configure.ac: Depend on libalarm for Maemo.
2479 * src/dbus_api/modest-dbus-api.h:
2480 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2481 (on_send_receive), (modest_dbus_req_handler):
2482 Handle a SEND_RECEIVE D-Bus method.
2484 * libmodest-dbus-client/libmodest-dbus-client.c:
2485 (libmodest_dbus_client_send_and_receive):
2486 * libmodest-dbus-client/libmodest-dbus-client.h:
2487 Add C convenience functions for calling the new D-Bus method.
2489 * src/modest-platform.h:
2490 * src/gnome/modest-platform.c:
2491 * src/maemo/modest-platform.c:
2492 Added modest_platform_set_update_interval(), which uses the
2493 alarmd API on Maemo.
2494 (modest_platform_init),
2495 Call modest_platform_set_update_interval(), using a hard-coded
2496 interval for now (until the global settings dialog is implemented),
2497 though I am not sure that this makes sense yet.
2499 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2501 * src/dbus_api/modest-dbus-callbacks.c:
2502 (modest_osso_cb_hw_state_handler):
2503 * src/dbus_api/modest-dbus-callbacks.h:
2504 * src/maemo/modest-platform.c: (modest_platform_init):
2505 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2506 in case this has some effect on the ability for Maemo to ping the
2509 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2511 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2512 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2513 warning. It is probably a logic error, but I need to fix the build.
2515 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2517 * src/modest-account-mgr.h:
2518 * src/modest-account-mgr.c:
2519 (modest_account_mgr_account_names): Add a gboolean enabled_only
2520 parameter, so we can get lists of onlt the enabled accounts.
2522 (modest_account_mgr_add_account),,
2523 (modest_account_mgr_account_with_display_name_exists):
2524 * src/maemo/modest-msg-edit-window.c: (get_transports):
2525 * src/modest-account-mgr-helpers.c:
2526 (modest_account_mgr_set_first_account_as_default):
2527 * src/modest-init.c: (init_default_account_maybe):
2528 * src/modest-tny-account-store.c: (get_accounts):
2529 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2530 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2531 * tests/check_account-mgr.c: (START_TEST):
2532 Provide the extra parameter, as appropriate.
2534 * src/widgets/modest-account-view.c: (update_account_view):
2535 Do not show disabled accounts (meaning that there is no way to
2536 enable/disable accounts in the UI (the feature is not in our UI
2537 specification), so we can use this internally only to mark unfinished
2538 or temporary account data.
2540 * src/maemo/easysetup/modest-easysetup-wizard.c:
2541 (create_account): Add boolean enable parameter, so we can specify FALSE
2542 to create the temporary account.
2543 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2544 (on_before_next): When finishing, when there is a temporary account, just
2546 Also, use a timeout to delay the showing of the dialog until gconf is likely
2547 to return correct information, due to a maemo gconf bug that is fixed in
2548 osso 1.1, but not yet in Bora.
2549 However, the dialog stays on screen after it is destroyed.
2551 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2552 for invalid data when cancelling. Use a hildon note instead of a dialog
2553 to complain about invalid data. Do not show the account-saved note if the
2554 account is disabled (a temporary account that will not really be saved for use
2557 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2559 * src/modest-account-mgr-helpers.h:
2560 * src/modest-account-mgr-helpers.c:
2561 Added modest_account_mgr_unset_default_account(),
2562 Added modest_account_mgr_set_first_account_as_default().
2564 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2565 If it was the default account, unset the default account name.
2567 * src/maemo/modest-account-view-window.c:
2568 (on_delete_button_clicked): If it was the default account,
2569 set the first remaining account as the default instead.
2571 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2572 a NULL account or a NULL default account, to prevent a crash. This should
2573 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2576 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2578 * src/widgets/modest-recpt-editor.c:
2579 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2580 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2581 TODO comment for this. This fixes the build.
2583 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2584 be the best place for it. This will in future update all auto-update accounts,
2585 rather than just the current/default account, when that gconf key exists.
2586 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2587 if there are no accounts, before calling do_send_receive().
2588 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2590 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2591 * src/maemo/modest-main-window-ui.h:
2592 * src/maemo/modest-main-window.c: (on_connection_changed),
2593 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2594 directly, becaue the signal handler does more.
2596 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2598 * src/modest-account-mgr-helpers.c:
2599 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2600 for the case that the account does not exist.
2602 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2603 (equivalent to the modest account name) rather than the tinymail account name
2604 (equivalent to the modest account title - human readable) to get the account data.
2605 Check for null account data to prevent the crash, and add a TODO comment saying that
2606 this needs fixing because it is using the server account name instead of the account name.
2608 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2610 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2611 * src/maemo/modest-account-settings-dialog.c: (show_error),
2613 Use hildon_note_new_information() for informative and error messages,
2614 which seems to be expected for Maemo applications (no documentation that I know of
2615 says this). I am surprised that there is no distinction between info and error
2618 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2620 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2621 it is easy to find where this is used.
2623 * src/maemo/easysetup/modest-easysetup-wizard.c:
2624 (create_page_welcome), (create_page_account_details),
2625 (create_page_user_details), (create_page_complete_easysetup),
2626 (create_page_custom_incoming), (create_page_custom_outgoing),
2627 (create_page_complete_custom):
2628 * src/maemo/modest-account-settings-dialog.c:
2629 (create_page_account_details), (create_page_user_details),
2630 (create_page_incoming), (create_page_outgoing):
2631 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2632 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2633 (modest_connection_specific_smtp_edit_window_init):
2634 * src/maemo/modest-connection-specific-smtp-window.c:
2635 (modest_connection_specific_smtp_window_init):
2636 * src/maemo/modest-signature-editor-dialog.c:
2637 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2638 and scrolling policy as per the Email Application Layout Guide, if I have
2641 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2643 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2644 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2645 which were empty, because these vfuncs have been removed from TnyAccountStore.
2646 This fixes the build.
2648 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2650 * src/maemo/modest-main-window.c:
2651 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2652 showing/hiding it. Added TODO because it probably should not be NULL.
2653 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2654 because unnecessary g_warnings() make degugging difficult.
2656 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2658 * src/maemo/modest-msg-edit-window.c:
2659 (modest_msg_edit_window_select_color),
2660 (modest_msg_edit_window_select_background_color): 2 const corrections and
2661 moving 2 #endifs before closing brackets, to fix the build.
2663 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2665 * src/maemo/easysetup/modest-easysetup-wizard.h:
2666 * src/maemo/easysetup/modest-easysetup-wizard.c:
2667 (modest_easysetup_wizard_dialog_finalize),
2668 (on_button_edit_advanced_settings), (create_page_complete_custom),
2669 (on_response), (create_account):
2670 Implement the Advanced Settings edit button, by saving the account information,
2671 for the Advanded Settings dialog to use directly from gconf, and removing it
2672 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2673 Bug #5533 in the projects.maemo.org bugzilla.
2675 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/modest-msg-view-window.c:
2678 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2679 when opening a message window.
2681 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2683 * src/maemo/easysetup/modest-easysetup-wizard.c:
2684 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2687 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2688 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2689 gconf settings. I probably added more checks than necessary, but that is safer.
2691 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2692 variable to fix the build, but this seems to be used when it is still NULL.
2694 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2696 * src/modest-platform.h:
2697 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2698 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2699 * src/modest-main.c: Implement this function so we can avoid using
2700 maemo-specific API from cross-platform code.
2702 * src/modest-tny-account-store.c:
2703 (get_smtp_specific_transport_account_for_open_connection):
2704 * src/modest-ui-actions.c: (check_for_connection),
2705 (modest_ui_actions_on_item_not_found):
2706 Use modest_platform_connect_and_wait() and put #idefs around other
2707 maemo-specific code, because only maemo currently has a way to
2708 identify connection names.
2710 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2712 * src/modest-tny-account-store.h:
2713 * src/modest-tny-account-store.c:
2714 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2715 the connection-specific SMTP server settings in the configuration.
2717 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2719 * src/maemo/modest-main-window.c: (on_connection_changed),
2721 * src/modest-main.c: (main), (start_ui), (send_mail):
2722 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2723 that is what is intended.
2725 * src/modest-ui-actions.c: (action_send), (action_receive),
2726 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2727 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2728 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2729 SMTP server is used when it is specified.
2731 (modest_ui_actions_on_send_receive):
2732 Check that a connection is open before proceeding.
2733 Receive and then send, instead of vice-versa, as per the specification.
2735 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2737 * src/modest-mail-operation.c:
2738 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2739 though I guess it should be something other than NULL.
2741 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2743 * src/maemo/easysetup/modest-easysetup-wizard.c:
2744 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2745 combo twice, to avoid an g_warning and to make it visible again.
2746 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2747 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2748 (already intended) dereference when detaching, because we then recreate the menu.
2749 But I am not sure why the warning was happening, and it is possible that this is a memory
2752 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2754 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2755 and uri_parse_mailto() utility functions.
2756 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2758 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2760 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2762 * src/dbus_api/modest-dbus-api.h:
2763 * src/dbus_api/modest-dbus-callbacks.c:
2764 Use an idle callback to execute the modest code in the application's own thread.
2765 Remove the helloworld example method.
2766 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2767 parsed, and the open-message method is not implemented because this is not yet implemented in
2769 * libmodest-dbus-client/libmodest-dbus-client.c:
2770 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2771 (libmodest_dbus_client_open_message):
2772 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2774 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2775 body without crashing.
2777 * tests/dbus_api/Makefile.am:
2778 * tests/dbus_api/test_mail_to.c:
2779 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2781 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2783 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2784 Added file to fix the build. Sorry.
2786 * src/dbus_api/Makefile.am:
2787 * src/dbus_api/modest-dbus-api.h:
2788 * src/dbus_api/modest-dbus-callbacks.h:
2789 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2790 (modest_dbus_req_handler):
2791 Put constants in a separate header so it can be reused by the
2792 client library, without duplication
2794 * libmodest-dbus-client/Makefile.am:
2795 * libmodest-dbus-client/libmodest-dbus-client.c:
2796 (libmodest_dbus_client_call_helloworld),
2797 (libmodfest_dbus_client_send_mail),
2798 (libmodfest_dbus_client_mailto),
2799 (libmodfest_dbus_client_open_message):
2800 * libmodest-dbus-client/libmodest-dbus-client.h:
2801 (Partly) Implement a send_mail D-Bus method.
2803 * tests/dbus_api/Makefile.am:
2804 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2805 the send_email D-Bus method.
2807 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2811 * libmodest-dbus-client/Makefile.am:
2812 * libmodest-dbus-client/libmodest-dbus-client.c:
2813 * libmodest-dbus-client/libmodest-dbus-client.h:
2814 * tests/dbus_api/Makefile.am:
2815 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2816 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2818 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/easysetup/modest-easysetup-wizard.c:
2821 (create_page_account_details):
2822 * src/maemo/modest-account-settings-dialog.c:
2823 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2824 widgets, because this might not be the default in future versions of the Maemo GTK+.
2825 However, I can not not get capitalization to work even in a simple test case.
2827 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2829 * src/maemo/easysetup/modest-easysetup-wizard.c:
2830 (create_page_custom_incoming), (create_page_custom_outgoing):
2831 * src/maemo/modest-account-settings-dialog.c:
2832 (create_page_account_details), (create_page_incoming),
2833 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2834 instead of using gtk_check_button_with_label(), so they are aligned like the other
2835 widgets, as per the UI spec.
2837 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2839 * src/maemo/easysetup/modest-easysetup-wizard.c:
2840 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2841 * src/widgets/modest-validating-entry.c:
2842 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2843 Modest prefix instead of an EasySetup prefix.
2845 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2847 * src/widgets/modest-validating-entry.h:
2848 * src/widgets/modest-validating-entry.c: (on_insert_text),
2849 Added easysetup_validating_entry_set_max_func(), used to set a callback
2850 to call when the max number of characters is reached. GtkEntry has a max-length
2851 already but is silent about it.
2853 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2854 (create_page_account_details), (create_page_user_details),
2856 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2857 (create_page_account_details), (create_page_user_details),
2858 (create_page_outgoing):
2859 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2860 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2861 the UI spec, when the user tries to enter more than the max number of characters.
2863 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2865 * src/maemo/easysetup/modest-easysetup-wizard.c:
2866 (create_page_user_details), (create_page_custom_incoming),
2867 (create_page_custom_outgoing):
2868 * src/maemo/modest-account-settings-dialog.c:
2869 (create_page_user_details), (create_page_incoming),
2870 (create_page_outgoing):
2871 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2872 (modest_connection_specific_smtp_edit_window_init):
2873 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2874 not appropriate. Bad Maemo-specific defaults!.
2876 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2878 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2879 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2880 (modest_signature_editor_dialog_set_settings):
2881 Disable the label and textview when the checkbox is disabled, and use the
2882 specified (UI spec) default signature text.
2884 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2886 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2887 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2889 * src/modest-defs.h:
2890 * src/modest-account-mgr-helpers.h:
2891 * src/modest-account-mgr-helpers.c:
2892 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2894 * src/maemo/Makefile.am:
2895 * src/maemo/modest-signature-editor-dialog.c:
2896 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2899 * src/maemo/modest-account-settings-dialog.h:
2900 * src/maemo/modest-account-settings-dialog.c:
2901 (modest_account_settings_dialog_finalize), (on_button_signature),
2902 (save_configuration): Use the new dialog when the Edit button is pressed, and
2903 save the changes if necessary, as per the UI spec.
2905 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2907 * src/maemo/Makefile.am:
2908 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2909 based on maemo-develoers email from Dirk.
2911 * src/maemo/easysetup/modest-easysetup-wizard.c:
2912 (create_page_welcome), (create_page_account_details),
2913 (create_page_user_details), (create_page_complete_easysetup),
2914 (create_page_custom_incoming), (create_page_custom_outgoing),
2915 (create_page_complete_custom),
2916 (modest_easysetup_wizard_dialog_init):
2917 * src/maemo/modest-account-settings-dialog.c:
2918 (create_page_account_details), (create_page_user_details),
2919 (create_page_incoming), (create_page_outgoing),
2920 (modest_account_settings_dialog_init):
2921 * src/maemo/modest-connection-specific-smtp-window.c:
2922 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2924 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2926 * src/maemo/easysetup/modest-easysetup-wizard.c:
2927 (create_page_account_details), (create_page_custom_outgoing),
2928 (create_page_complete_custom):
2929 * src/maemo/modest-account-settings-dialog.c:
2930 (create_page_user_details), (create_page_incoming),
2931 (create_page_outgoing):
2932 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2933 (modest_connection_specific_smtp_edit_window_init):
2934 Use the correct (UI spec) port min/max, and use horizontal separators,
2937 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2939 * src/maemo/easysetup/modest-easysetup-wizard.c:
2940 (set_default_custom_servernames):
2941 * src/maemo/modest-account-settings-dialog.c:
2942 (create_page_incoming), (on_combo_outgoing_security_changed),
2943 (on_combo_incoming_security_changed), (create_page_outgoing),
2944 (modest_account_settings_dialog_set_account_name),
2945 (save_configuration):
2946 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2947 (on_combo_security_changed),
2948 (modest_connection_specific_smtp_edit_window_init),
2949 (modest_connection_specific_smtp_edit_window_set_connection),
2950 (modest_connection_specific_smtp_edit_window_get_settings):
2951 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2954 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2957 * src/maemo/easysetup/modest-easysetup-wizard.c:
2958 (create_page_custom_outgoing), (create_page_complete_custom):
2959 * src/maemo/modest-account-settings-dialog.c:
2960 (create_page_user_details), (create_page_outgoing):
2961 * src/maemo/modest-account-view-window.c: (button_box_new):
2962 Use changed logical IDs as per the most recent UI spec:
2963 mcen_bd_emailsetup_edit -> mcen_bd_edit
2964 mcen_bd_emailsetup_delete -> mcen_bd_delete
2965 mcen_bd_emailsetup_close -> mcen_bd_close
2967 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2971 * src/dbus_api/Makefile.am:
2972 * src/dbus_api/modest-dbus-callbacks.c:
2973 * src/dbus_api/modest-dbus-callbacks.h:
2974 * src/maemo/modest-platform.c: (modest_platform_init):
2975 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2977 * tests/Makefile.am:
2978 * tests/dbus_api/Makefile.am:
2979 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2981 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2983 * src/maemo/modest-account-settings-dialog.c:
2984 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2985 Removed unnecessary includes.
2987 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2989 * src/maemo/easysetup/modest-easysetup-wizard.c:
2990 * src/maemo/modest-account-settings-dialog.c:
2991 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2992 * src/widgets/Makefile.am:
2993 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2994 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2995 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2996 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2997 * src/widgets/modest-secureauth-combo-box.c:
2998 * src/widgets/modest-secureauth-combo-box.h:
2999 * src/widgets/modest-serversecurity-combo-box.c:
3000 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3001 made the GObject names more consistent with the rest of the Modest code.
3003 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3005 * src/maemo/easysetup/Makefile.am:
3006 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3007 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3008 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3009 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3010 * src/maemo/easysetup/modest-easysetup-wizard.c:
3011 * src/maemo/easysetup/modest-validating-entry.c:
3012 * src/maemo/easysetup/modest-validating-entry.h:
3013 * src/maemo/modest-account-settings-dialog.c:
3014 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3015 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3016 widgets/ because they are used outside of easysetup too. After checking in,
3017 svn will allow me to rename them too.
3019 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3021 * src/gnome/modest-msg-edit-window.c:
3022 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3023 linker error, to fix the build on the GNOME platform.
3024 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3025 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3026 ifdefed out to avoid a warning.
3028 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3030 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3031 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3032 some alternative for GTK+ 2.6.
3034 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3036 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3038 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3039 specified for EmailAccountsDialog in UI spec.
3041 * src/maemo/easysetup/modest-easysetup-wizard.c:
3042 * src/maemo/easysetup/modest-easysetup-wizard.h:
3043 * src/maemo/modest-account-settings-dialog.c:
3044 * src/maemo/modest-account-settings-dialog.h:
3045 Reuse a member window widget for the connection-specific SMTP server accounts,
3046 so we can tell it to create/save the accounts only if we actually save changes.
3048 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3049 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3050 (modest_connection_specific_smtp_edit_window_get_settings):
3051 Return a struct instance for temporarily remembering the entered data.
3053 * src/maemo/modest-connection-specific-smtp-window.h:
3054 * src/maemo/modest-connection-specific-smtp-window.c:
3055 (modest_connection_specific_smtp_window_finalize),
3056 (modest_connection_specific_smtp_window_fill_with_connections),
3058 (modest_connection_specific_smtp_window_save_server_accounts),
3059 (update_model_server_names): Do not actually save data until asked,
3060 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3062 (on_selection_changed),
3063 (modest_connection_specific_smtp_window_init): Disable the edit
3064 button when nothing is selected.
3066 * src/modest-account-mgr-helpers.c:
3067 * src/modest-account-mgr-helpers.h:
3068 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3071 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3073 * src/modest-account-mgr-helpers.h:
3074 * src/modest-account-mgr-helpers.c:
3075 (modest_account_mgr_get_unused_account_name),
3076 (modest_account_mgr_get_unused_account_display_name): Added these
3077 utility functions, to avoid code duplication.
3079 * src/maemo/easysetup/modest-easysetup-wizard.c:
3080 (create_page_account_details), (create_account):
3081 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3082 (on_combo_security_changed),
3083 (modest_connection_specific_smtp_edit_window_init),
3084 (modest_connection_specific_smtp_edit_window_save_settings):
3085 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3086 * src/maemo/modest-connection-specific-smtp-window.c:
3087 (modest_connection_specific_smtp_window_finalize),
3088 (modest_connection_specific_smtp_window_fill_with_connections),
3089 (on_button_edit), (modest_connection_specific_smtp_window_init):
3090 * src/maemo/modest-connection-specific-smtp-window.h:
3091 Implementing saving of connection-specific server accounts.
3093 But I need to refactor this so we can save the data for each
3094 possible connection-specific account and only actually create the server accounts
3095 when the easysetup finished, or the OK button is pressed on the account settings
3098 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3100 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3101 (on_combo_security_changed):
3102 (modest_connection_specific_smtp_edit_window_init):
3103 Auto-fill the port number as in the account settings.
3105 (modest_connection_specific_smtp_edit_window_set_connection):
3106 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3107 * src/maemo/modest-connection-specific-smtp-window.c:
3108 (fill_with_connections), (on_button_edit),
3109 (modest_connection_specific_smtp_window_init):
3110 Turn the edit window into a dialog to simplify the code, and
3111 set a WM hint as in a GtkDialog, because only a popup can be on top of
3112 another window in Maemo, and popups usually have no WM decoration.
3114 * src/modest-defs.h:
3115 * src/modest-account-mgr-helpers.c:
3116 (modest_account_mgr_set_connection_specific_smtp),
3117 (modest_account_mgr_remove_connection_specific_smtp),
3118 (modest_account_mgr_get_connection_specific_smtp):
3119 * src/modest-account-mgr-helpers.h: Some functions to write the
3120 connection-specific SMTP server information. Not yet used.
3123 * src/widgets/modest-folder-view.c: (text_cell_data):
3124 Fix a warning about an uninitialized variable.
3125 (on_configuration_key_changed): Put an #ifdef around the use
3126 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3128 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3130 * src/maemo/modest-account-settings-dialog.h:
3131 * src/maemo/modest-account-settings-dialog.c:
3132 Added connect_for_modified() utility function to mark the new modified boolean.
3134 (create_page_account_details), (create_page_user_details),
3135 (create_page_incoming), (create_page_outgoing), (on_response),
3136 (modest_account_settings_dialog_init),
3137 (modest_account_settings_dialog_set_account_name):
3138 Only warn about unsaved changes when there are actually unsaved changes.
3140 * src/modest-account-mgr-helpers.c:
3141 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3142 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3143 to get the data from there in future.
3145 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3147 * src/modest-defs.h:
3149 * src/modest-account-mgr-helpers.h:
3150 * src/modest-account-mgr-helpers.c:
3151 Store the security account setting in a single conf key instead of using
3152 the options list, so that the list is left for just the to-be-removed camel hack,
3153 and because gconf_client_set_list() is failing for some reason.
3155 * src/modest-account-mgr.c:
3156 (modest_account_mgr_add_server_account):
3157 * src/maemo/modest-account-settings-dialog.c:
3158 (modest_account_settings_dialog_set_account_name),
3159 (save_configuration): Use the renamed functions.
3162 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3164 * src/widgets/Makefile.am:
3165 * src/widgets/modest-limit-retrieve-combo-box.c:
3166 * src/widgets/modest-limit-retrieve-combo-box.h:
3167 * src/widgets/modest-retrieve-combo-box.c:
3168 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3169 the account settings dialog.
3171 * src/modest-defs.h:
3172 * src/modest-account-mgr-helpers.h:
3173 * src/modest-account-mgr-helpers.c:
3174 (modest_server_account_get_option_secure_auth),
3175 (modest_server_account_set_option_secure_auth):
3176 * src/modest-account-mgr.c:
3177 (modest_account_mgr_add_server_account):
3178 Use the existing AUTH_MECH conf key for the secure-auth setting,
3179 instead of putting it in the list options, because this was actually used already.
3181 * src/maemo/modest-account-settings-dialog.c:
3182 (create_page_account_details),
3183 (modest_account_settings_dialog_set_account_name),
3184 (save_configuration):
3185 * src/maemo/modest-account-settings-dialog.h:
3186 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3187 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3189 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3191 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3192 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3193 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3195 * src/modest-defs.h:
3196 * src/maemo/modest-account-settings-dialog.c:
3197 (create_page_incoming), (on_combo_outgoing_security_changed),
3198 (on_combo_incoming_security_changed), (create_page_outgoing),
3199 (modest_account_settings_dialog_set_account_name),
3200 (save_configuration): Load/Save the port number, and change it when the
3201 security combo changes, to suitable defaults.
3203 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3205 * src/modest-account-mgr.c:
3206 (modest_account_mgr_add_server_account): Set the security and secure-auth
3207 options, and add a comment saying that the other camel-specific options should be
3210 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3212 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3214 * src/modest-tny-account-store.c: (account_list_free),
3215 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3216 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3219 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3221 * src/modest-protocol-info.c:
3222 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3223 is required by our UI spec. Maybe something in our implementation will use this eventually.
3224 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3225 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3226 instead of the previous 0 placeholder.
3228 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3229 secure-auth settings.
3230 * src/modest-account-mgr-helpers.h:
3231 * src/modest-account-mgr-helpers.c:
3232 (modest_server_account_data_get_option_secure_auth),
3233 (modest_server_account_set_option_secure_auth),
3234 (modest_server_account_data_get_option_security),
3235 (modest_server_account_set_option_security): Added this API for getting and setting the security
3236 and secure-auth settings.
3238 * src/maemo/modest-account-settings-dialog.h:
3239 * src/maemo/modest-account-settings-dialog.c:
3240 (modest_account_settings_dialog_finalize), (check_data),
3241 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3242 about changing titles.
3243 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3244 (save_configuration): Save the security and secure-auth settings.
3246 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3247 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3249 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3251 * src/modest-defs.h:
3252 * src/modest-account-mgr.c:
3253 (modest_account_mgr_add_server_account):
3254 Added and used defines for the options key and value pair strings,
3255 that are used so far, though they do not seem to correspond to anything in our
3256 UI specs or ModestProtocol enum.
3258 * src/modest-account-mgr-helpers.h:
3259 * src/modest-account-mgr-helpers.c:
3260 (compare_option_strings_for_name),
3261 (modest_server_account_data_get_option_value),
3262 (modest_server_account_data_get_option_bool),
3263 (modest_account_mgr_get_server_account_option):
3264 Added helper functions for parsing the options GSList.
3266 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3268 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3269 display name is based on the supplied account name.
3270 * src/modest-account-mgr.c:
3271 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3272 with an inefficient, but good-enough, implementation.
3274 * src/maemo/easysetup/modest-easysetup-wizard.c:
3275 (create_page_account_details), (on_before_next), (create_account):
3276 Check for existing display names rather than (non-user-visible) account names, and just
3277 create and set a unique account name at the end.
3279 * src/maemo/modest-account-settings-dialog.c:
3280 (modest_account_settings_dialog_init),
3281 (modest_account_settings_dialog_set_account_name),
3282 (create_page_incoming): Show the display name, instead of the account name.
3283 (on_response): Do some (not all) extra checks, as in the UI spec.
3284 (save_configuration): Save the display name if it was changed.
3286 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3288 * po/en_GB.po: Added needed logical ID and translation.
3289 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3290 (init_view): Made the is-default column clicking work.
3292 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3295 * src/maemo/easysetup/Makefile.am:
3296 * src/maemo/easysetup/modest-easysetup-wizard.c:
3297 (modest_easysetup_wizard_dialog_init):
3298 * src/maemo/easysetup/provider-data-test.keyfile:
3299 * src/maemo/easysetup/provider-data.keyfile:
3300 Moved the provider data file to the new modest-providers-data package and used it from there.
3302 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3304 * src/modest-local-folder-info.c:
3305 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3306 N_() was already used on the static strings, but this just marks it for translation without
3307 using the translation.
3309 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3311 * src/maemo/modest-account-settings-dialog.c:
3312 (create_page_incoming),
3313 (modest_account_settings_dialog_set_account_name):
3314 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3315 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3316 I will do this if nobody else gets there first.
3318 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3320 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3321 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3322 save the security stuff.
3324 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3326 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3327 Set the email address and user fullname, which I now see must be
3330 * src/maemo/modest-account-settings-dialog.h:
3331 * src/maemo/modest-account-settings-dialog.c:
3333 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3334 leave-on-server and authentication.
3335 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3338 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3341 * src/maemo/modest-account-settings-dialog.c:
3342 * src/maemo/modest-account-settings-dialog.h:
3343 Most (but not all) of the widgets are now present as specified by the UI spec.
3344 No changes are yet saved, and some details are not properly shown yet.
3346 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3348 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3350 * src/maemo/Makefile.am:
3351 * src/maemo/modest-account-settings-dialog.c:
3352 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3353 an existing account. Doesn't do much yet.
3355 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3356 Open the accounts settings dialog when Edit is clicked.
3358 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3360 * src/maemo/easysetup/Makefile.am:
3361 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3363 * src/maemo/easysetup/modest-easysetup-wizard.c:
3364 (modest_easysetup_wizard_dialog_init):
3365 Try to get the source directory from the build system,
3366 instead of hard-coding "./" into the source code, when opening our local
3367 copies of the configuration files.
3368 But this still fails when opening the wizard from the Accounts window,
3369 maybe because the working directory seems to change at runtime.
3370 So the wizard will fail the second time unless you copy the files into their
3371 proper locations - see the stdout warnings for the paths.
3373 (create_page_account_details),(on_before_next):
3374 Check for existing non-server accounts instead of server accounts,
3375 so the default account name is useful again, and to prevent trying to
3378 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3379 Show the wizard when New is clicked.
3381 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3382 (init_view): Show the column headers, and show the columns that are
3383 specified in the UI specs. However, something in Maemo's GTK+ prevents
3384 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3385 change the default account. This is despite unsetting the special properties.
3387 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3389 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3390 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3391 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3392 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3393 to make that clearer.
3394 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3396 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3398 * src/maemo/modest-account-view-window.c:
3399 (modest_account_view_window_init),
3400 (modest_account_view_window_new):
3401 Use the same buttons as specified in the
3402 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3403 the existing widgets, which never had a chance of working.
3404 Put the ModestAccountView treeview in a scrolled window.
3405 Do not repeat the initialization in both _init() and _new().
3407 * src/widgets/modest-account-view.c: (update_account_view):
3408 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3409 this widget and window shows no accounts.
3411 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3413 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3415 * src/maemo/easysetup/modest-easysetup-wizard.c:
3416 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3417 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3418 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3421 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3422 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3423 accounts exist yet, as in the UI spec.
3425 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3427 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3429 * src/maemo/Makefile.am:
3430 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3431 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3432 New window for editing connection-specific smtp details.
3433 Not fully implemented.
3435 * src/maemo/modest-connection-specific-smtp-window.c:
3436 (modest_connection_specific_smtp_window_finalize) :
3437 unref the tree model.
3438 (on_button_edit): Show the edit window.
3440 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3442 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3445 * src/maemo/Makefile.am:
3446 * src/maemo/modest-connection-specific-smtp-window.c:
3447 * src/maemo/modest-connection-specific-smtp-window.h:
3448 New window for showing the list of connections, for connection-specific
3449 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3450 * src/maemo/easysetup/modest-easysetup-wizard.c:
3451 (create_page_custom_outgoing): Show the new window when the button is clicked.
3453 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3455 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3456 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3457 * src/maemo/modest-msg-edit-window.c:
3458 (modest_msg_edit_window_insert_image):
3459 * src/modest-conf.c: (modest_conf_key_escape):
3460 * src/modest-mail-operation.c:
3461 (modest_mail_operation_send_new_mail):
3462 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3463 (modest_ui_actions_on_new_account):
3464 * src/widgets/modest-attachment-view.c: (update_filename_request):
3465 * src/widgets/modest-mail-header-view.c:
3466 Corrected warnings that were breaking the build, by commenting out unused variables,
3467 and a function, and by including a header.
3469 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3471 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3472 so we can #ifdef around platform-specific code when necessary.
3473 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3474 to allow this to build for the GNOME platform too.
3476 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3478 * src/maemo/easysetup/modest-easysetup-wizard.c:
3479 Added util_increment_name() and used it in create_page_account_details()
3480 to make sure that the default account name is always a new name.
3482 (modest_easysetup_wizard_dialog_init),
3483 (set_default_custom_servernames): Some minor memory management fixes.
3485 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3489 * src/modest-runtime.c: (init_i18n): Restored the translation
3490 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3491 are defined in config.h, and the translations are installed.
3493 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3494 is defined for translation.
3496 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3498 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3500 * src/maemo/easysetup/modest-easysetup-wizard.c:
3501 (modest_easysetup_wizard_dialog_init):
3502 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3503 Use realistic paths (though they should use $prefix generically) to the
3504 mcc_mapping and provider-data.keyfile files which might work when they
3505 are installed by the future version of the operator-wizard package,
3506 and then fallback to paths in our source code, with an explanatory
3509 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3513 * src/maemo/Makefile.am:
3514 * src/maemo/easysetup/: Added files from the previously-exernal
3515 osso-modest-easysetup.
3516 * src/maemo/modest-main-window-ui.h:
3517 * src/modest-ui-actions.c:
3518 * src/modest-ui-actions.h:
3519 Added modest_ui_actions_on_new_account() as a signal handler for the
3520 New Account menu item. It shows the easysetup wizard.
3521 * po/en_GB.po: Added additional needed logical IDs and translations.