1 2007-06-01 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 (create_caption_new_with_asterisk):
5 * src/maemo/modest-account-settings-dialog.c:
6 (create_caption_new_with_asterisk):
7 Uncomment the code to add the asterisk, because they are no longer in the
8 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
9 (update_incoming_server_title): Add an asterisk here too.
11 2007-06-01 Murray Cumming <murrayc@murrayc.com>
13 * src/maemo/modest-maemo-global-settings-dialog.c:
14 (current_connection): Check that we are even connected before trying to
15 get the current connection name, to prevent a warning.
17 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
18 Change the comments because tny_maemo_conic_device_connect() is now meant to
20 * src/modest-mail-operation.c:
21 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
22 make sure we have a connection and fail if we can't connect.
24 2007-05-31 Murray Cumming <murrayc@murrayc.com>
26 * src/maemo/modest-main-window.c:
27 (on_account_store_connecting_finished): Do not try to get the
28 connection ID if we are not really connected. I am surprised that
29 this signal handler is called when we are not connected.
31 2007-05-31 Murray Cumming <murrayc@murrayc.com>
34 * src/modest-ui-actions.c:
35 (modest_ui_actions_get_msgs_full_error_handler):
36 Renamed an enum, added comments, added an enum
37 for retrieve-limit errors.
39 * src/modest-mail-operation.c: (foreach_add_item),
40 (internal_folder_observer_update), (update_account_thread),
41 (modest_mail_operation_get_msgs_full):
42 (modest_mail_operation_update_account),
43 Added comments about how this works, and some code that should
44 (but does not) check the retrieve-limit. See the TODO comment.
46 2007-05-31 Murray Cumming <murrayc@murrayc.com>
48 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
49 Initialize help_id to fix the build. Warnings are good.
51 2007-05-31 Murray Cumming <murrayc@murrayc.com>
53 * src/widgets/modest-hbox-cell-renderer.c:
54 (modest_hbox_cell_renderer_append):
55 * src/widgets/modest-vbox-cell-renderer.c:
56 (modest_vbox_cell_renderer_append):
57 Fix the last commit by doing an extra ref.
59 2007-05-31 Murray Cumming <murrayc@murrayc.com>
61 * src/widgets/modest-hbox-cell-renderer.c:
62 (modest_hbox_cell_renderer_append):
63 * src/widgets/modest-vbox-cell-renderer.c:
64 (modest_vbox_cell_renderer_append):
65 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
66 to fix the build with Maemo Bora.
67 However, there seems to be a remaining crash, probably due to reference
70 2007-05-30 Murray Cumming <murrayc@murrayc.com>
72 * src/modest-tny-account.c:
73 (modest_tny_account_new_for_local_folders):
74 Use hildon_file_system_info_async_new() to get a better name for
75 the memory card account, setting it as the account name.
76 The timing seems to work, but this is probably
77 not the best place to do this. See the TODO comment.
78 * src/maemo/modest-main-window.c: (create_details_widget):
79 * src/widgets/modest-folder-view.c: (text_cell_data):
80 Use the tny account name instead of hardcoding a name.
82 2007-05-30 Christian Kellner <ckellner@openismus.com>
84 * src/modest-search.c: (modest_search):
85 Correctly set part_search_func even if we have already parsed
86 the query and thus a valid OgsTextSearcher object.
88 2007-05-30 Christian Kellner <ckellner@openismus.com>
91 Search and check for libogs.
94 Incooparte the ogs build env.
96 * src/modest-mime-part-search-stream.c:
97 * src/modest-mime-part-search-stream.h:
98 Removed since we do the real searching now in modest-search.c.
100 * src/modest-search.c:
101 * src/modest-search.h:
102 Implement support for ogs. We use that if available and requested
103 and fall back to modest_text_utils_utf8_strcmp (). The search logic
104 should now handle the corner case when the search term is spread
105 across multiple reads.
106 Also the logic in modest_search () was corrected to search all
107 requested fields until one is found.
109 2007-05-30 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
114 * src/modest-init.c: Made modest_init_local_folders() take a
115 path and be public so we can iniitialize maildir folders on
118 * src/modest-local-folder-info.h:
119 * src/modest-local-folder-info.c:
120 (modest_local_folder_info_get_maildir_path): Add a path parameter.
122 * src/modest-tny-account.c:
123 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
124 still means the standard local-folders path on the local volume.
126 * src/modest-tny-account-store.c:
127 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
128 signal so we can detect mount/unmount of the MMC1 card, and do an update of
129 all accounts when that happens.
130 (get_server_accounts): If the MMC1 card is mounted, create a store account for
131 this too, so it shows up in the treeview.
133 2007-05-28 Murray Cumming <murrayc@murrayc.com>
135 * src/maemo/modest-maemo-global-settings-dialog.c:
136 (current_connection):
137 * src/widgets/modest-global-settings-dialog.c:
138 (current_connection_default):
139 Use the enum values instead of 0, 1 and -1,
140 to make the code clearer.
142 * src/modest-account-mgr-helpers.c:
143 (modest_account_mgr_get_connection_specific_smtp): Make this code
146 * src/modest-runtime.h:
147 * src/modest-runtime.c:
148 Added modest_runtime_remove_all_send_queues().
149 * src/maemo/modest-main-window.c:
150 (on_account_store_connecting_finished): Recreate the send queues,
151 using the appropriate transport accounts for this new connection.
152 Some futher adapting might be needed if the old send queues are not
153 automatically stopped at this point.
155 * src/modest-tny-account-store.c: (get_server_accounts):
156 Create the connection-specific transport accounts, so that they can
157 be found later by their ID.
159 * src/modest-tny-account.h:
160 * src/modest-tny-account.c:
161 Added modest_tny_account_new_from_server_account_name().
162 modest_tny_account_new_from_server_account(): Do not create the
163 send queues here, because they will be
164 recreated anyway when the connection changes for the first time.
166 2007-05-28 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-local-folder-info.h:
169 * src/modest-local-folder-info.c:
170 (modest_per_account_local_outbox_folder_info_get_maildir_path),
171 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
172 tbox_folder): Take a modest account name instead of a server TnyAccount,
173 so we can have per-modest-account rather than per-transport-account
175 We must make sure that we change or recreate the exisitng send queues
176 when the connection changes for connection-specific transport accounts.
178 * src/modest-tny-account-store.c:
179 (create_per_account_local_outbox_folders): Create outboxed per modest
180 account, not per transport account.
182 * src/modest-tny-account.h:
183 * src/modest-tny-account.c:
184 (modest_tny_account_get_special_folder): For outboxes, get the
185 parent modest account name. The account is ignored for other folders.
186 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
187 modest account name rather than a server TnyAccount.
189 2007-05-25 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-tny-account.c:
192 (modest_tny_account_new_from_server_account):
193 Call modest_runtime_get_send_queue() immediately after creating transport
194 accounts, so that they start trying to send email from the outbox as soon
195 as possible at startup. This is probably what we want.
197 * src/modest-mail-operation.c: (update_account_thread):
198 * src/modest-runtime.c: (modest_runtime_get_send_queue):
199 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
200 * src/modest-tny-send-queue.h:
201 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
202 (modest_ui_actions_on_send):
203 Added comments about how sending works, though it needs some more work.
205 2007-05-25 Murray Cumming <murrayc@murrayc.com>
207 * src/modest-tny-account.c:
208 (modest_tny_account_get_special_folder): Add TODO because this fails when
210 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
211 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
212 Do not try to show this window when there is no active account. The UI
213 specs does not tell us what to do in this case.
215 2007-05-24 Murray Cumming <murrayc@murrayc.com>
219 * src/maemo/Makefile.am:
220 * src/widgets/Makefile.am: Some dist fixes.
222 2007-05-24 Murray Cumming <murrayc@murrayc.com>
224 * src/maemo/modest-connection-specific-smtp-window.c:
225 (on_button_edit): Make the code clearer, to prevent a double free.
227 2007-05-24 Murray Cumming <murrayc@murrayc.com>
229 * src/maemo/modest-account-settings-dialog.c:
230 (modest_account_settings_dialog_set_account_name),
231 Check the connection-specific smtp servers checkbox if there are any.
233 * src/maemo/modest-connection-specific-smtp-edit-window.c:
234 (modest_connection_specific_smtp_edit_window_init):
235 Start with a suitable port number.
237 * src/modest-account-mgr-helpers.h:
238 * src/modest-account-mgr-helpers.c: Added
239 modest_account_mgr_get_has_connection_specific_smtp().
241 (modest_account_mgr_set_connection_specific_smtp),
242 (modest_account_mgr_remove_connection_specific_smtp),
243 (modest_account_mgr_get_has_connection_specific_smtp),
244 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
245 connection-specific smtp server accounts in the account, rather than
246 the server account conf dir.
248 This fixes bug projects.maemo.org bug NB#58263 .
250 * src/modest-tny-account-store.c:
251 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
252 if there are no server accounts yet, to prevent an infinite loop when there
253 are no accounts. Document that one must be called before the other.
255 2007-05-24 Murray Cumming <murrayc@murrayc.com>
257 * src/modest-account-mgr-helpers.c:
258 (modest_account_mgr_get_default_account): Make sure that at least
259 one account is always the default, if there are any enabled accounts.
260 This is just a sanity check that shouldn't be necessary.
262 * src/modest-account-mgr-priv.c:
263 (_modest_account_mgr_account_from_key): Unescape the conf key to
264 get the real account name. For instance, this is an issue if a space
265 was in the account name, which can happen because the account name
266 is generated from the display name.
267 (_modest_account_mgr_get_account_keyname): Always escape the
269 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
270 Unescape the conf keys to get the real account names.
272 For instance, previously the is-default radio button in the accounts
273 list was not checked for any accounts at first. This fixes that,
274 and might fix several similar bugs.
276 2007-05-23 Murray Cumming <murrayc@murrayc.com>
278 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
279 Removed some debug printfs.
281 2007-05-23 Murray Cumming <murrayc@murrayc.com>
283 Modest on-disk outbox directories are now here, for instance:
284 $HOME/.modest/outboxes/<account-id-1>/outbox
285 $HOME/.modest/outboxes/<account-id-2>/outbox
287 $HOME/.modest/local-folders/outbox
288 so we can have a separate outbox for each account.
289 But they are shown as one outbox in the GtkTreeView, by using a
290 TnyMergeFolder in a ModestTnySimpleFolderStore.
293 * src/modest-tny-simple-folder-store.c:
294 * src/modest-tny-simple-folder-store.h:
295 Added ModestTnySimpleFolderStore, used to contain folders from
296 other folder stores, such as other accounts.
298 * src/modest-tny-outbox-account.h:
299 * src/modest-tny-outbox-account.c:
300 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
301 used for the per-account local outbox folders.
303 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
304 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
305 only use this (internally) now for the non-outbox local folders.
308 * src/modest-init.c: Added modest_init_one_local_folder(), for
309 setting up the directory structure for each local folder.
311 * src/modest-local-folder-info.c:
312 (modest_per_account_local_outbox_folder_info_get_maildir_path),
313 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
315 * src/modest-local-folder-info.h:
316 * src/modest-tny-account-store.c: (on_account_removed),
317 (on_account_changed), (create_per_account_local_outbox_folders),
318 (get_server_accounts), (modest_tny_account_store_get_accounts),
319 (modest_tny_account_store_get_tny_account_by_account),
320 (modest_tny_folder_store_is_virtual_local_folders):
322 * src/modest-tny-account.h:
323 * src/modest-tny-account.c:
324 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
325 to create an on-disk per-account local outbox folder for each
327 (create_per_account_local_outbox_folders): Create a local outbox folder
328 for each transport account.
329 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
330 for all local folders.
332 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
333 instead of using g_object_get/set() directly. It is clearer.
335 (modest_tny_folder_store_get_message_count),
336 (modest_tny_folder_store_get_local_size
337 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
338 because we now use these with non-acount folder stores.
340 (modest_tny_account_get_special_folder),
341 (modest_tny_account_new_from_server_account),
342 (modest_tny_account_new_from_account):
343 (recurse_folders): Adjust to the new outbox system.
345 * src/modest-tny-folder.h:
346 * src/modest-tny-folder.c:
347 (modest_tny_folder_is_local_folder),
348 (modest_tny_folder_get_local_folder_type),
349 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
351 * src/widgets/modest-main-window.h:
352 * src/maemo/modest-main-window.c: (create_details_widget),
353 (modest_main_window_set_contents_style): Show details for any folder store,
356 (modest_tny_folder_get_rules):
357 Remove the const. C does not support constness enough for this.
359 * src/modest-ui-actions.c:
360 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
361 make all outboxes appear as one, in the usual local-folders tree node.
363 (set_active_account_from_tny_account),
364 (modest_ui_actions_on_folder_selection_changed):
365 * src/widgets/modest-folder-view.c: (text_cell_data),
366 (icon_cell_data), (filter_row),
367 (add_account_folders_to_merged_folder),
368 (add_account_folders_to_simple_folder_store), (),
369 (get_cmp_rows_type_pos), (cmp_rows),
370 (modest_folder_view_set_account_id_of_visible_server_account):
371 Adjust to the new outbox system, using generic folder stores and folders
374 2007-05-23 Christian Kellner <ckellner@openismus.com>
376 * src/modest-mail-operation.c:
377 (modest_mail_operation_update_account):
378 Use info->max_size instead of unintialized local var [small
379 build fix]. (Added TODO to review that change since I don't
382 2007-05-23 Marcus Bauer <marcusb@openismus.com>
384 * libmodest-dbus-client/libmodest-dbus-client.c:
385 (libmodest_dbus_client_compose_mail): function added
386 * src/dbus_api/modest-dbus-api.h:
387 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
388 (on_compose_mail): Implementation of the SendAsMail functionality
390 2007-05-22 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-account-mgr.c:
393 (modest_account_mgr_add_server_account): Set the secure-connection
394 conf key for transport accounts as well as store accounts. I don't know
395 why the if was there. For instance, this makes sure that we use SSL
396 for the gmail preset from the easysetup wizard.
398 2007-05-22 Murray Cumming <murrayc@murrayc.com>
400 * src/gnome/modest-main-window.c:
401 (on_account_store_connecting_finished), (connect_signals):
402 * src/maemo/modest-main-window.c:
403 (on_account_store_connecting_finished), (connect_signals),
404 (modest_main_window_new):
405 Handle TnyAccountStore::connecting-finished instead of
406 TnyDevice::connection-changed, because we cannot actually perform
407 operations on accounts until TnyAccountStore has itself responded to
408 the TnyDevice::connection-changed signal. This prevents a GError from
410 Do not try to update at startup, because we (at least on scratchbox)
411 already do an update at startup when the device goes online.
412 This prevents a GError from tinymail.
413 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
414 Added TODO about stopping simultaneous operations.
416 2007-05-21 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
419 * src/modest-mail-operation-queue.c:
420 (modest_mail_operation_queue_remove):
421 * src/modest-tny-account-store.c: When GErrors happen, give more clues
422 about where they happened.
424 2007-05-21 Murray Cumming <murrayc@murrayc.com>
426 * src/modest-ui-actions.c:
427 (modest_ui_actions_on_password_requested): Make sure that the remember
428 output parameter is always TRUE.
430 2007-05-21 Murray Cumming <murrayc@murrayc.com>
432 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
433 Show a OK/Cancel dialog if the error is a question, though we still do not
434 know anything more about what we are asking the user.
435 * src/widgets/modest-folder-view.c: (on_drag_data_received):
436 Fix an uninitialized variable (helper). This is a logic error, however.
438 2007-05-21 Christian Kellner <ckellner@openismus.com>
440 * src/modest-search.h:
441 Correct bit shifting in the ModestSearchFlags enum.
443 2007-05-21 Murray Cumming <murrayc@murrayc.com>
445 * src/modest-tny-account.c:
446 (modest_tny_account_new_from_server_account): Do not use the lsub and
447 check-all hard-coded IMAP options when using POP.
449 2007-05-21 Murray Cumming <murrayc@murrayc.com>
451 * src/modest-tny-account.c:
452 (modest_tny_account_new_from_server_account):
453 Use NULL for the secure-auth method for POP when Password auth has been
454 specified by the user, as we already do for IMAP. "auth=Login" causes
455 an error from camel or the server.
457 2007-05-17 Murray Cumming <murrayc@murrayc.com>
459 * src/maemo/modest-account-settings-dialog.c:
460 (create_page_account_details),
461 (modest_account_settings_dialog_set_account_name):
462 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
463 for the leave-on-server checkbox, rathr than just the checkbox, when
464 the protocol is not POP.
466 2007-05-17 Murray Cumming <murrayc@murrayc.com>
468 * src/widgets/modest-account-view.c:
469 * src/widgets/modest-account-view.h:
470 Added modest_account_view_select_account() which will be useful later
471 to asynchronously re-select the edited account.
473 2007-05-17 Murray Cumming <murrayc@murrayc.com>
475 * src/maemo/modest-account-settings-dialog.c:
476 (modest_account_settings_dialog_set_account_name):
477 Automatically choose the port numbers based on the secure authentication
478 methods, if they have not been chosen before.
479 This fixes projects.maemo.org bug NB#56273 .
481 2007-05-17 Murray Cumming <murrayc@murrayc.com>
483 * src/maemo/modest-main-window-ui.h:
484 * src/modest-ui-actions.c:
485 * src/modest-ui-actions.h:
486 Connect the Tools/SMTP Servers menu item to
487 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
488 SMTP servers dialog, as in the UI specification and saves changes when it
489 is closed. This fixed projects.maemo.org bug NB#56305 .
491 2007-05-17 Murray Cumming <murrayc@murrayc.com>
493 * src/maemo/modest-connection-specific-smtp-window.c:
494 (modest_connection_specific_smtp_window_init):
495 Use gtk_window_set_default_size() to make this window big enough, so
496 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
498 2007-05-17 Murray Cumming <murrayc@murrayc.com>
500 * src/maemo/modest-connection-specific-smtp-edit-window.h:
501 * src/maemo/modest-connection-specific-smtp-edit-window.c:
502 (modest_connection_specific_smtp_edit_window_init),
503 Do not try to connect to a combobox signal before the combobox exists.
504 This fixes the cras in projects.maemo.org bug NB#56288 .
505 (modest_connection_specific_smtp_edit_window_get_settings):
506 Remove the server_account_name parameter which was being checked for NULL
507 though it was not used.
509 * src/maemo/modest-connection-specific-smtp-window.c:
510 (modest_connection_specific_smtp_window_fill_with_connections),
511 (on_button_edit), (modest_connection_specific_smtp_window_init):
512 Correct the number of treemodel columns to prevent a warning.
513 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
514 libconic does not work.
516 2007-05-16 Murray Cumming <murrayc@murrayc.com>
518 * src/modest-tny-account.c:
519 (modest_tny_account_new_from_server_account):
520 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
521 SMTP when "None" was chosen by the user. However, with my SMTP server that
522 does not support ANONYMOUS, the emails do not leave the Outbox and I see
525 2007-05-16 Murray Cumming <murrayc@murrayc.com>
527 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
528 to explain the memory management issue with the ID in the ModestPair.
530 * src/gnome/modest-account-assistant.c: (add_receiving_page),
531 (add_sending_page), (modest_account_assistant_finalize):
532 * src/gnome/modest-gnome-global-settings-dialog.c:
533 (create_updating_page), (create_composing_page):
534 * src/gnome/modest-msg-edit-window.c: (get_transports),
535 (init_window), (modest_msg_edit_window_finalize),
536 (modest_msg_edit_window_get_msg_data):
537 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
538 * src/gnome/modest-transport-widget.c:
539 (modest_transport_widget_finalize), (smtp_configuration):
540 * src/maemo/modest-maemo-global-settings-dialog.c:
541 (create_updating_page), (create_composing_page):
542 * src/maemo/modest-msg-edit-window.c: (get_transports),
543 (init_window), (modest_msg_edit_window_finalize),
544 (modest_msg_edit_window_get_msg_data),
545 (modest_msg_edit_window_free_msg_data):
546 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
547 (modest_store_widget_finalize):
548 * src/maemo/modest-transport-widget.c:
549 (modest_transport_widget_finalize), (smtp_configuration):
550 * src/modest-main.c: (send_mail):
551 * src/widgets/modest-combo-box.h:
552 * src/widgets/modest-global-settings-dialog-priv.h:
553 * src/widgets/modest-global-settings-dialog.c:
554 (modest_global_settings_dialog_finalize):
555 * src/widgets/modest-msg-edit-window.h:
556 Whenever using modest_combo_box_new(), keep the ModestPairList alive
557 as long as the combo box, to prevent use of freed memory for the ID.
559 2007-05-15 Murray Cumming <murrayc@murrayc.com>
561 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
562 get_accounts(), to make this clearer. Do not check for the enabled gconf
563 key, because we do not use this for server accounts (at least, not yet).
564 This allows us to send email again.
566 2007-05-15 Murray Cumming <murrayc@murrayc.com>
568 * src/maemo/modest-platform.c:
569 (on_modest_conf_update_interval_changed), (modest_platform_init):
570 Only respond to this particular key change. All these strcmp()s cannot be
573 2007-05-15 Murray Cumming <murrayc@murrayc.com>
575 * src/maemo/modest-maemo-global-settings-dialog.c:
576 (current_connection): Prevent a crash in scratchbox when
577 ny_maemo_conic_device_get_current_iap_id() returns NULL.
578 * src/maemo/modest-platform.c:
579 (on_modest_conf_update_interval_changed), (modest_platform_init):
580 Get the update interval from gconf and reset it when the gconf key changes.
582 2007-05-15 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-protocol-info.c:
585 * src/modest-protocol-info.h: Adde enum-specific get functions,
586 instead of using a ModestProtocolType enum parameter.
588 * src/gnome/modest-account-assistant.c:
589 * src/gnome/modest-store-widget.c:
590 * src/gnome/modest-store-widget.h:
591 * src/gnome/modest-transport-widget.c:
592 * src/gnome/modest-transport-widget.h:
593 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
594 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
595 * src/maemo/easysetup/modest-easysetup-wizard.c:
596 * src/maemo/modest-account-settings-dialog.c:
597 * src/maemo/modest-account-settings-dialog.h:
598 * src/maemo/modest-store-widget.c:
599 * src/maemo/modest-store-widget.h:
600 * src/maemo/modest-transport-widget.c:
601 * src/maemo/modest-transport-widget.h:
602 * src/modest-account-mgr-helpers.c:
603 * src/modest-account-mgr-helpers.h:
604 * src/modest-account-mgr.c:
605 * src/modest-account-mgr.h:
606 * src/modest-tny-account.c:
607 * src/modest-tny-folder.c:
608 * src/widgets/modest-account-view.c:
609 * src/widgets/modest-retrieve-combo-box.c:
610 * src/widgets/modest-retrieve-combo-box.h:
611 * src/widgets/modest-secureauth-combo-box.c:
612 * src/widgets/modest-serversecurity-combo-box.c:
613 * src/widgets/modest-serversecurity-combo-box.h:
614 * tests/check_account-mgr.c:
615 Use the specific functions, and use the re-renamed enum values for GNOME too.
617 2007-05-15 Murray Cumming <murrayc@murrayc.com>
620 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
621 so we can get the second based on the first.
623 * src/maemo/modest-account-settings-dialog.h:
624 * src/maemo/modest-account-settings-dialog.c:
625 Added get_supported_secure_authentication_methods(), though it is mostly
626 commented-out for now until the necessary API is committed to tinymail.
627 (modest_account_settings_dialog_set_account_name),
628 (save_configuration): Request the supported authentication methods from the
629 server, so we can choose a working method.
631 * src/modest-tny-account-store.h:
632 * src/modest-tny-account-store.c:
633 (modest_tny_account_store_get_session): Rename from
634 tny_account_store_get_session().
636 2007-05-14 Murray Cumming <murrayc@murrayc.com>
638 * src/modest-protocol-info.h: Split the ModestProtocol enum
639 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
640 There was no need to have these unrelated values in one enum.
642 * src/: many files: Adapted to changed enum. This makes the code a bit
643 clearer, and the compiler could catch some errors.
645 2007-05-14 Murray Cumming <murrayc@murrayc.com>
647 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
648 Show the detailed internal camel error message when an error happens
649 during the configuration, so that our testers can give us more clues.
650 For instance, in projects.maemo.org bug NB#56910 .
652 2007-05-14 Murray Cumming <murrayc@murrayc.com>
654 * src/modest-tny-account.c:
655 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
656 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
658 2007-05-14 Murray Cumming <murrayc@murrayc.com>
660 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
661 * src/maemo/modest-account-settings-dialog.c:
662 (modest_account_settings_dialog_set_account_name),
663 (save_configuration): For the incoming secure authentication checkbox,
664 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
665 the UI specification. PLAIN does not seem to be supported for most IMAP
666 servers anyway, and I am not sure what it would mean.
667 However, we probably need to discover which of the secure-authentication
668 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
669 * src/modest-account-mgr-helpers.c:
670 (modest_account_mgr_get_server_account_data):
672 * src/modest-tny-account.c:
673 (modest_tny_account_new_from_server_account):
674 Use tny_account_set_mech() to set secure-authentication methods,
675 with some special-casing for IMAP, based on my observations of how
678 * src/modest-account-mgr-helpers.h:
679 * src/modest-account-mgr.c:
680 * src/modest-defs.h: Comment that the URI is only used for local folders.
682 2007-05-11 Murray Cumming <murrayc@murrayc.com>
684 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
685 parameter const, just to be neat.
686 * src/modest-text-utils.c: (modest_text_utils_inline):
687 End g_strconcat() with NULL, as its documentation says. This is almost
688 certainly the cause of my crash at startup on the device. Interestingly,
689 valgrind doesn't tell us about these errors.
691 2007-05-11 Murray Cumming <murrayc@murrayc.com>
693 * scripts/build-packages: Added more precise comments about how to use
694 this script, though I still get this error:
695 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
696 error building tinymail
698 2007-05-11 Murray Cumming <murrayc@murrayc.com>
700 * src/maemo/modest-main-window.c: (on_account_update):
701 Very slight cleanup, hoping to make it simpler to discover what causes
702 a crash here sometimes.
704 * src/modest-tny-account.c:
705 (modest_tny_account_new_from_server_account): Set the port. Added
706 comments about the options and a TODO comment because I need to find out
707 how to specify the secure authentication method.
709 2007-05-11 Marcus Bauer <marcusb@openismus.com>
711 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
712 changed CFlags paths form modest to libmodest
714 2007-05-10 Murray Cumming <murrayc@murrayc.com>
716 * src/modest-account-mgr-helpers.c:
717 (modest_account_mgr_get_server_account_data),
718 (modest_account_mgr_free_server_account_data):
719 * src/modest-account-mgr-helpers.h:
720 * src/modest-account-mgr.c:
721 (modest_account_mgr_add_server_account):
723 * src/modest-tny-account.c:
724 (modest_tny_account_new_from_server_account):
725 Determine the options for tny_camel_account_add_option() here,
726 based on the settings, rather than storing them directly in gconf.
728 2007-05-10 Murray Cumming <murrayc@murrayc.com>
730 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
731 Show a more friendly error dialog now that we expect (from the tinymail
732 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
734 2007-05-10 Murray Cumming <murrayc@murrayc.com>
736 * src/maemo/modest-main-window.c: (on_account_update): Check that
737 account_name is not NULL, to prevent a crash at startup that I am
738 seeing on the N800. I do wonder why it is NULL.
740 * src/maemo/easysetup/modest-easysetup-wizard.c:
741 (create_page_user_details):
742 * src/maemo/modest-account-settings-dialog.c:
743 (create_page_user_details), (create_page_outgoing):
744 * src/maemo/modest-connection-specific-smtp-edit-window.c:
745 (modest_connection_specific_smtp_edit_window_init):
746 * src/modest-ui-actions.c:
747 (modest_ui_actions_on_password_requested):
748 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
749 might do something useful with the on-screen keyboard.
751 2007-05-10 Murray Cumming <murrayc@murrayc.com>
753 * src/maemo/modest-main-window.c: (on_account_update):
754 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
755 NULL, to avoid lots of warnings. However, it probably should not be NULL.
757 2007-05-09 Murray Cumming <murrayc@murrayc.com>
759 * src/modest-tny-account-store.c: (on_account_changed):
760 Correct the signature of this signal handler.
762 2007-05-09 Murray Cumming <murrayc@murrayc.com>
764 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
765 Show a HildonNote instead of a GtkDialog for Maemo.
767 2007-05-09 Murray Cumming <murrayc@murrayc.com>
769 * src/widgets/modest-account-view.h:
770 * src/widgets/modest-account-view.c: (on_account_changed),
771 (on_account_removed). Added a boolean flag, set/unset by
772 modest_account_view_block_conf_updates(),
773 modest_account_view_unblock_conf_updates() to prevent unnecessary
774 updates, but this is not very useful because the gconf notifications are
775 so delays (maybe only on Maemo Bora).
776 So auto-updating is turned off, and these functions do an explicit
777 update when necessary.
778 However, something else is still doing too much work when adding/removing
779 accounts, probably in another part of the application.
781 * src/maemo/modest-account-view-window.c:
782 (on_delete_button_clicked), (on_edit_button_clicked),
783 (on_new_button_clicked): Use the new functions.
785 2007-05-09 Murray Cumming <murrayc@murrayc.com>
787 * src/modest-account-mgr-helpers.c:
788 (modest_account_mgr_set_first_account_as_default):
789 Sort the list of names alphabetically-by-title, so we choose the first one
791 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
792 alphabetically by the title.
794 This fixes projects.maemo.org bug NB#56418 .
796 * src/modest-account-mgr-priv.c:
797 (_modest_account_mgr_account_from_key):
798 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
799 avoid a valgrind error, and possible random behaviour.
801 2007-05-09 Murray Cumming <murrayc@murrayc.com>
803 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
804 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
805 tinymail documentation to say that this can be expected.
806 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
807 pretty, and should not happen, but I would prefer to know when it does.
809 2007-05-09 Murray Cumming <murrayc@murrayc.com>
811 * configure.ac: When using the older hildon version, probably on Bora,
812 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
814 * src/widgets/modest-attachment-view.c:
815 (modest_attachment_view_set_part_default): Initialize variables, to fix the
818 2007-05-09 Marcus Bauer <marcusb@openismus.com>
820 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
821 Implemented the prototype. Can be tested with
822 tests/dbus_api/test_open_message:
824 2007-05-08 Murray Cumming <murrayc@murrayc.com>
826 * src/modest-tny-account-store.c:
827 (modest_tny_account_store_instance_init), (get_password):
828 * src/modest-ui-actions.c:
829 (modest_ui_actions_on_password_requested):
830 Do not store the password in gconf, because this function is called
831 for non-remembered passwords. Actually use the cached (in the hash map)
832 password instead of releasing it.
833 The password will now not be remembered if it is asked via the protected
834 password dialog, as per the UI spec.
836 2007-05-08 Murray Cumming <murrayc@murrayc.com>
839 * src/modest-account-mgr-helpers.h:
840 * src/modest-account-mgr-helpers.c:
841 Added modest_server_account_get_username_has_succeeded(),
842 modest_server_account_set_username_has_succeeded().
843 (modest_server_account_set_username),
844 Reset the has-succeeded flag if the username changes.
846 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
847 * src/maemo/modest-connection-specific-smtp-window.c:
848 (modest_connection_specific_smtp_window_save_server_accounts):
849 Use modest_server_account_set_username() instead of using
850 modest_conf_set_string() directly, so that the has-succeeded flag is always
853 * src/modest-ui-actions.c:
854 (modest_ui_actions_on_password_requested): Dim the username entry if
855 the username has ever worked, as per the UI spec.
857 2007-05-08 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-tny-account-store.c: (get_password):
860 * src/modest-ui-actions.c:
861 (modest_ui_actions_on_password_requested):
862 Allow the username to be changed too, though there is more work to
863 be done on exactly how this behaves.
865 2007-05-08 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-account-mgr-helpers.h:
868 * src/modest-account-mgr-helpers.c:
869 Added modest_account_mgr_get_display_name(),
870 modest_server_account_get_username(),
871 modest_server_account_set_username(),
872 modest_server_account_set_password(),
873 modest_server_account_get_hostname() functions so we do not need to
874 use the conf API directly.
876 * src/maemo/modest-main-window.c: (connect_signals):
877 Actually connect ot the ModestAccountStore::request-password signal,
878 so that we show the dialog when the password is requested by Tinymail,
879 for isntance if it is empty.
881 * src/modest-marshal.list:
882 * src/modest-tny-account-store.c:
883 (modest_tny_account_store_class_init), (get_password),
884 (modest_tny_account_store_alert):
885 * src/modest-tny-account-store.h:
886 * src/modest-ui-actions.h:
887 * src/modest-ui-actions.c:
888 (modest_ui_actions_on_password_requested):
889 Change the signal parameters, so it is obvious that we are providing
890 the non human-readable server name, and receiving both the username
891 and password, though changing of the username is not yet implemented.
892 Change the dialog UI to match the Maemo UI specifications, with #idfefing
893 for the GNOME version.
895 This should fix the projects.maemo.org bug NB#56209, though it does not
896 work on Bora, because the gconf_client_get() for the password fails
897 immediately after we save it with gconf_client_set().
899 2007-05-08 Murray Cumming <murrayc@murrayc.com>
902 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
903 caused an undefined symbol error:
904 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
906 2007-05-08 Murray Cumming <murrayc@murrayc.com>
908 * src/modest-tny-account-store.c:
909 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
910 using a GError instead of a string message, so we can translate it in
913 2007-05-08 Murray Cumming <murrayc@murrayc.com>
915 * src/maemo/modest-address-book.c:
916 (modest_address_book_check_names):
917 * src/maemo/modest-msg-view-window.c:
918 (modest_msg_view_window_clipboard_owner_change):
919 * src/modest-init.c: (modest_init_init_ui):
920 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
921 (update_folders_cb), (modest_mail_operation_update_account):
922 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
923 (modest_ui_actions_on_msg_attachment_clicked),
924 (modest_ui_actions_on_msg_recpt_activated):
925 * src/widgets/modest-header-view.c: (drag_data_get_cb):
926 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
927 (modest_msg_view_search_next):
928 * src/widgets/modest-recpt-editor.c:
929 (modest_recpt_editor_on_button_release_event),
930 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
931 g_message(). At this point we should only be seeing interesting errors on
932 stdout. Debugging messages could be #ifdefed-out if they are still useful.
934 2007-05-07 Murray Cumming <murrayc@murrayc.com>
936 (modest_wizard_dialog_force_title_update):
937 * src/maemo/easysetup/modest-wizard-dialog.h:
938 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
939 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
940 can update the title when appropriate. Otherwise the title is wrong if the
941 pages are added after adding the notebook to the dialog.
942 This must be a problem in HildonWizardDialog too.
943 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
945 * src/maemo/easysetup/modest-easysetup-wizard.c:
946 (create_subsequent_customsetup_pages),
947 (create_subsequent_easysetup_pages):
948 Call modest_wizard_dialog_force_title_update() so that the title is
949 correct even with GTK+ < 2.10.
950 This fixes projects.maemo.org bug NB#56145 .
952 2007-05-07 Murray Cumming <murrayc@murrayc.com>
954 * src/maemo/modest-platform.c:
955 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
956 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
959 2007-05-07 Murray Cumming <murrayc@murrayc.com>
961 * src/widgets/modest-window.h:
962 * src/widgets/modest-window.c: Added a save_state_func vfunc,
963 and modest_window_save_state(), which invokes it.
965 * src/widgets/modest-window-mgr.h:
966 * src/widgets/modest-window-mgr.c:
967 Added modest_window_mgr_save_state_for_all_windows(), which calls
968 the save_state vfunc on all registered windows, if implemented.
970 * src/gnome/modest-msg-edit-window.c:
971 * src/gnome/modest-msg-view-window.c:
972 * src/maemo/modest-msg-edit-window.c:
973 * src/maemo/modest-msg-view-window.c:
974 * src/maemo/modest-main-window.c:
975 Specify the existing save_settings functions as implementations of
976 ModestWindow::save_state_func().
978 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
979 Call modest_window_mgr_save_state_for_all_windows(). This happens before
980 enabling hibernation, for instance.
982 We may need to do the same thing for restoring settings.
985 2007-05-07 Murray Cumming <murrayc@murrayc.com>
987 * src/widgets/modest-window-mgr.c:
988 * src/widgets/modest-window-mgr.h:
989 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
990 modest_window_mgr_get_hibernation_is_prevented().
992 * src/maemo/modest-main-window.c:
993 (on_hildon_program_is_topmost_notify): Prevent hibernation
994 (possible when the application goes to the background in the WM),
995 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
997 * src/maemo/easysetup/modest-easysetup-wizard.c:
998 (modest_easysetup_wizard_dialog_init):
999 * src/maemo/modest-account-settings-dialog.c:
1000 (modest_account_settings_dialog_init):
1001 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1002 (modest_connection_specific_smtp_edit_window_init):
1003 * src/maemo/modest-connection-specific-smtp-window.c:
1004 (modest_connection_specific_smtp_window_init):
1005 * src/maemo/modest-signature-editor-dialog.c:
1006 (modest_signature_editor_dialog_init):
1007 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1008 prevent hibernation while any of these account settings dialogs are open.
1010 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1012 * src/maemo/Makefile.am:
1013 * src/maemo/modest-osso-state-saving.c:
1014 * src/maemo/modest-osso-state-saving.h: Added
1015 modest_osso_load_state() and modest_osso_save_state() though they do
1016 nothing now. They should iterate through all the open windows and load/save
1018 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1019 save state when closing.
1021 * src/maemo/modest-main-window.c:
1022 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1023 Add a notification handler for the HildonProgram::is-topmost property,
1024 so we can allow hibernation when the application goes into the background.
1025 But we still need to detect when the accounts setup windows are open so
1026 we can stop hibernation when they are open.
1027 To do this, I also added the main window the HildonProgram. This might have
1028 other side-effects/benefits, and should maybe be done for other windows.
1030 * src/maemo/modest-osso-autosave-callbacks.h:
1031 * src/maemo/modest-osso-autosave-callbacks.c:
1032 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1033 though it does not do anything yet, and we might never need this to do
1034 anything. For instance, we already save drafts.
1036 * src/maemo/modest-platform.c: (modest_platform_init):
1037 Specify the libosso auto-save callback.
1039 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1041 * src/maemo/modest-platform.c:
1042 (modest_platform_set_update_interval):
1043 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1044 aparently stays valid between application instances, so we can use this
1045 to remove and reset it later. According to a maemo-developers email from
1048 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1050 * configure.ac: Depend on libalarm for Maemo.
1052 * src/dbus_api/modest-dbus-api.h:
1053 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1054 (on_send_receive), (modest_dbus_req_handler):
1055 Handle a SEND_RECEIVE D-Bus method.
1057 * libmodest-dbus-client/libmodest-dbus-client.c:
1058 (libmodest_dbus_client_send_and_receive):
1059 * libmodest-dbus-client/libmodest-dbus-client.h:
1060 Add C convenience functions for calling the new D-Bus method.
1062 * src/modest-platform.h:
1063 * src/gnome/modest-platform.c:
1064 * src/maemo/modest-platform.c:
1065 Added modest_platform_set_update_interval(), which uses the
1066 alarmd API on Maemo.
1067 (modest_platform_init),
1068 Call modest_platform_set_update_interval(), using a hard-coded
1069 interval for now (until the global settings dialog is implemented),
1070 though I am not sure that this makes sense yet.
1072 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1074 * src/dbus_api/modest-dbus-callbacks.c:
1075 (modest_osso_cb_hw_state_handler):
1076 * src/dbus_api/modest-dbus-callbacks.h:
1077 * src/maemo/modest-platform.c: (modest_platform_init):
1078 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1079 in case this has some effect on the ability for Maemo to ping the
1082 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1085 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1086 warning. It is probably a logic error, but I need to fix the build.
1088 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-account-mgr.h:
1091 * src/modest-account-mgr.c:
1092 (modest_account_mgr_account_names): Add a gboolean enabled_only
1093 parameter, so we can get lists of onlt the enabled accounts.
1095 (modest_account_mgr_add_account),,
1096 (modest_account_mgr_account_with_display_name_exists):
1097 * src/maemo/modest-msg-edit-window.c: (get_transports):
1098 * src/modest-account-mgr-helpers.c:
1099 (modest_account_mgr_set_first_account_as_default):
1100 * src/modest-init.c: (init_default_account_maybe):
1101 * src/modest-tny-account-store.c: (get_accounts):
1102 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1103 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1104 * tests/check_account-mgr.c: (START_TEST):
1105 Provide the extra parameter, as appropriate.
1107 * src/widgets/modest-account-view.c: (update_account_view):
1108 Do not show disabled accounts (meaning that there is no way to
1109 enable/disable accounts in the UI (the feature is not in our UI
1110 specification), so we can use this internally only to mark unfinished
1111 or temporary account data.
1113 * src/maemo/easysetup/modest-easysetup-wizard.c:
1114 (create_account): Add boolean enable parameter, so we can specify FALSE
1115 to create the temporary account.
1116 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1117 (on_before_next): When finishing, when there is a temporary account, just
1119 Also, use a timeout to delay the showing of the dialog until gconf is likely
1120 to return correct information, due to a maemo gconf bug that is fixed in
1121 osso 1.1, but not yet in Bora.
1122 However, the dialog stays on screen after it is destroyed.
1124 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1125 for invalid data when cancelling. Use a hildon note instead of a dialog
1126 to complain about invalid data. Do not show the account-saved note if the
1127 account is disabled (a temporary account that will not really be saved for use
1130 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1132 * src/modest-account-mgr-helpers.h:
1133 * src/modest-account-mgr-helpers.c:
1134 Added modest_account_mgr_unset_default_account(),
1135 Added modest_account_mgr_set_first_account_as_default().
1137 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1138 If it was the default account, unset the default account name.
1140 * src/maemo/modest-account-view-window.c:
1141 (on_delete_button_clicked): If it was the default account,
1142 set the first remaining account as the default instead.
1144 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1145 a NULL account or a NULL default account, to prevent a crash. This should
1146 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1149 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1151 * src/widgets/modest-recpt-editor.c:
1152 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1153 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1154 TODO comment for this. This fixes the build.
1156 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1157 be the best place for it. This will in future update all auto-update accounts,
1158 rather than just the current/default account, when that gconf key exists.
1159 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1160 if there are no accounts, before calling do_send_receive().
1161 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1163 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1164 * src/maemo/modest-main-window-ui.h:
1165 * src/maemo/modest-main-window.c: (on_connection_changed),
1166 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1167 directly, becaue the signal handler does more.
1169 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-account-mgr-helpers.c:
1172 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1173 for the case that the account does not exist.
1175 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1176 (equivalent to the modest account name) rather than the tinymail account name
1177 (equivalent to the modest account title - human readable) to get the account data.
1178 Check for null account data to prevent the crash, and add a TODO comment saying that
1179 this needs fixing because it is using the server account name instead of the account name.
1181 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1183 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1184 * src/maemo/modest-account-settings-dialog.c: (show_error),
1186 Use hildon_note_new_information() for informative and error messages,
1187 which seems to be expected for Maemo applications (no documentation that I know of
1188 says this). I am surprised that there is no distinction between info and error
1191 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1193 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1194 it is easy to find where this is used.
1196 * src/maemo/easysetup/modest-easysetup-wizard.c:
1197 (create_page_welcome), (create_page_account_details),
1198 (create_page_user_details), (create_page_complete_easysetup),
1199 (create_page_custom_incoming), (create_page_custom_outgoing),
1200 (create_page_complete_custom):
1201 * src/maemo/modest-account-settings-dialog.c:
1202 (create_page_account_details), (create_page_user_details),
1203 (create_page_incoming), (create_page_outgoing):
1204 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1205 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1206 (modest_connection_specific_smtp_edit_window_init):
1207 * src/maemo/modest-connection-specific-smtp-window.c:
1208 (modest_connection_specific_smtp_window_init):
1209 * src/maemo/modest-signature-editor-dialog.c:
1210 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1211 and scrolling policy as per the Email Application Layout Guide, if I have
1214 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1217 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1218 which were empty, because these vfuncs have been removed from TnyAccountStore.
1219 This fixes the build.
1221 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1223 * src/maemo/modest-main-window.c:
1224 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1225 showing/hiding it. Added TODO because it probably should not be NULL.
1226 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1227 because unnecessary g_warnings() make degugging difficult.
1229 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1231 * src/maemo/modest-msg-edit-window.c:
1232 (modest_msg_edit_window_select_color),
1233 (modest_msg_edit_window_select_background_color): 2 const corrections and
1234 moving 2 #endifs before closing brackets, to fix the build.
1236 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1238 * src/maemo/easysetup/modest-easysetup-wizard.h:
1239 * src/maemo/easysetup/modest-easysetup-wizard.c:
1240 (modest_easysetup_wizard_dialog_finalize),
1241 (on_button_edit_advanced_settings), (create_page_complete_custom),
1242 (on_response), (create_account):
1243 Implement the Advanced Settings edit button, by saving the account information,
1244 for the Advanded Settings dialog to use directly from gconf, and removing it
1245 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1246 Bug #5533 in the projects.maemo.org bugzilla.
1248 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1250 * src/maemo/modest-msg-view-window.c:
1251 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1252 when opening a message window.
1254 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1256 * src/maemo/easysetup/modest-easysetup-wizard.c:
1257 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1260 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1261 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1262 gconf settings. I probably added more checks than necessary, but that is safer.
1264 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1265 variable to fix the build, but this seems to be used when it is still NULL.
1267 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1269 * src/modest-platform.h:
1270 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1271 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1272 * src/modest-main.c: Implement this function so we can avoid using
1273 maemo-specific API from cross-platform code.
1275 * src/modest-tny-account-store.c:
1276 (get_smtp_specific_transport_account_for_open_connection):
1277 * src/modest-ui-actions.c: (check_for_connection),
1278 (modest_ui_actions_on_item_not_found):
1279 Use modest_platform_connect_and_wait() and put #idefs around other
1280 maemo-specific code, because only maemo currently has a way to
1281 identify connection names.
1283 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-tny-account-store.h:
1286 * src/modest-tny-account-store.c:
1287 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1288 the connection-specific SMTP server settings in the configuration.
1290 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1292 * src/maemo/modest-main-window.c: (on_connection_changed),
1294 * src/modest-main.c: (main), (start_ui), (send_mail):
1295 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1296 that is what is intended.
1298 * src/modest-ui-actions.c: (action_send), (action_receive),
1299 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1300 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1301 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1302 SMTP server is used when it is specified.
1304 (modest_ui_actions_on_send_receive):
1305 Check that a connection is open before proceeding.
1306 Receive and then send, instead of vice-versa, as per the specification.
1308 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1310 * src/modest-mail-operation.c:
1311 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1312 though I guess it should be something other than NULL.
1314 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1316 * src/maemo/easysetup/modest-easysetup-wizard.c:
1317 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1318 combo twice, to avoid an g_warning and to make it visible again.
1319 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1320 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1321 (already intended) dereference when detaching, because we then recreate the menu.
1322 But I am not sure why the warning was happening, and it is possible that this is a memory
1325 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1327 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1328 and uri_parse_mailto() utility functions.
1329 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1331 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1333 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1335 * src/dbus_api/modest-dbus-api.h:
1336 * src/dbus_api/modest-dbus-callbacks.c:
1337 Use an idle callback to execute the modest code in the application's own thread.
1338 Remove the helloworld example method.
1339 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1340 parsed, and the open-message method is not implemented because this is not yet implemented in
1342 * libmodest-dbus-client/libmodest-dbus-client.c:
1343 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1344 (libmodest_dbus_client_open_message):
1345 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1347 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1348 body without crashing.
1350 * tests/dbus_api/Makefile.am:
1351 * tests/dbus_api/test_mail_to.c:
1352 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1354 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1356 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1357 Added file to fix the build. Sorry.
1359 * src/dbus_api/Makefile.am:
1360 * src/dbus_api/modest-dbus-api.h:
1361 * src/dbus_api/modest-dbus-callbacks.h:
1362 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1363 (modest_dbus_req_handler):
1364 Put constants in a separate header so it can be reused by the
1365 client library, without duplication
1367 * libmodest-dbus-client/Makefile.am:
1368 * libmodest-dbus-client/libmodest-dbus-client.c:
1369 (libmodest_dbus_client_call_helloworld),
1370 (libmodfest_dbus_client_send_mail),
1371 (libmodfest_dbus_client_mailto),
1372 (libmodfest_dbus_client_open_message):
1373 * libmodest-dbus-client/libmodest-dbus-client.h:
1374 (Partly) Implement a send_mail D-Bus method.
1376 * tests/dbus_api/Makefile.am:
1377 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1378 the send_email D-Bus method.
1380 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1384 * libmodest-dbus-client/Makefile.am:
1385 * libmodest-dbus-client/libmodest-dbus-client.c:
1386 * libmodest-dbus-client/libmodest-dbus-client.h:
1387 * tests/dbus_api/Makefile.am:
1388 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1389 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1391 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1393 * src/maemo/easysetup/modest-easysetup-wizard.c:
1394 (create_page_account_details):
1395 * src/maemo/modest-account-settings-dialog.c:
1396 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1397 widgets, because this might not be the default in future versions of the Maemo GTK+.
1398 However, I can not not get capitalization to work even in a simple test case.
1400 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1402 * src/maemo/easysetup/modest-easysetup-wizard.c:
1403 (create_page_custom_incoming), (create_page_custom_outgoing):
1404 * src/maemo/modest-account-settings-dialog.c:
1405 (create_page_account_details), (create_page_incoming),
1406 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1407 instead of using gtk_check_button_with_label(), so they are aligned like the other
1408 widgets, as per the UI spec.
1410 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1412 * src/maemo/easysetup/modest-easysetup-wizard.c:
1413 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1414 * src/widgets/modest-validating-entry.c:
1415 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1416 Modest prefix instead of an EasySetup prefix.
1418 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1420 * src/widgets/modest-validating-entry.h:
1421 * src/widgets/modest-validating-entry.c: (on_insert_text),
1422 Added easysetup_validating_entry_set_max_func(), used to set a callback
1423 to call when the max number of characters is reached. GtkEntry has a max-length
1424 already but is silent about it.
1426 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1427 (create_page_account_details), (create_page_user_details),
1429 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1430 (create_page_account_details), (create_page_user_details),
1431 (create_page_outgoing):
1432 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1433 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1434 the UI spec, when the user tries to enter more than the max number of characters.
1436 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1438 * src/maemo/easysetup/modest-easysetup-wizard.c:
1439 (create_page_user_details), (create_page_custom_incoming),
1440 (create_page_custom_outgoing):
1441 * src/maemo/modest-account-settings-dialog.c:
1442 (create_page_user_details), (create_page_incoming),
1443 (create_page_outgoing):
1444 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1445 (modest_connection_specific_smtp_edit_window_init):
1446 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1447 not appropriate. Bad Maemo-specific defaults!.
1449 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1451 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1452 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1453 (modest_signature_editor_dialog_set_settings):
1454 Disable the label and textview when the checkbox is disabled, and use the
1455 specified (UI spec) default signature text.
1457 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1459 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1460 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1462 * src/modest-defs.h:
1463 * src/modest-account-mgr-helpers.h:
1464 * src/modest-account-mgr-helpers.c:
1465 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1467 * src/maemo/Makefile.am:
1468 * src/maemo/modest-signature-editor-dialog.c:
1469 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1472 * src/maemo/modest-account-settings-dialog.h:
1473 * src/maemo/modest-account-settings-dialog.c:
1474 (modest_account_settings_dialog_finalize), (on_button_signature),
1475 (save_configuration): Use the new dialog when the Edit button is pressed, and
1476 save the changes if necessary, as per the UI spec.
1478 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1480 * src/maemo/Makefile.am:
1481 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1482 based on maemo-develoers email from Dirk.
1484 * src/maemo/easysetup/modest-easysetup-wizard.c:
1485 (create_page_welcome), (create_page_account_details),
1486 (create_page_user_details), (create_page_complete_easysetup),
1487 (create_page_custom_incoming), (create_page_custom_outgoing),
1488 (create_page_complete_custom),
1489 (modest_easysetup_wizard_dialog_init):
1490 * src/maemo/modest-account-settings-dialog.c:
1491 (create_page_account_details), (create_page_user_details),
1492 (create_page_incoming), (create_page_outgoing),
1493 (modest_account_settings_dialog_init):
1494 * src/maemo/modest-connection-specific-smtp-window.c:
1495 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1497 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/easysetup/modest-easysetup-wizard.c:
1500 (create_page_account_details), (create_page_custom_outgoing),
1501 (create_page_complete_custom):
1502 * src/maemo/modest-account-settings-dialog.c:
1503 (create_page_user_details), (create_page_incoming),
1504 (create_page_outgoing):
1505 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1506 (modest_connection_specific_smtp_edit_window_init):
1507 Use the correct (UI spec) port min/max, and use horizontal separators,
1510 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1512 * src/maemo/easysetup/modest-easysetup-wizard.c:
1513 (set_default_custom_servernames):
1514 * src/maemo/modest-account-settings-dialog.c:
1515 (create_page_incoming), (on_combo_outgoing_security_changed),
1516 (on_combo_incoming_security_changed), (create_page_outgoing),
1517 (modest_account_settings_dialog_set_account_name),
1518 (save_configuration):
1519 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1520 (on_combo_security_changed),
1521 (modest_connection_specific_smtp_edit_window_init),
1522 (modest_connection_specific_smtp_edit_window_set_connection),
1523 (modest_connection_specific_smtp_edit_window_get_settings):
1524 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1527 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1530 * src/maemo/easysetup/modest-easysetup-wizard.c:
1531 (create_page_custom_outgoing), (create_page_complete_custom):
1532 * src/maemo/modest-account-settings-dialog.c:
1533 (create_page_user_details), (create_page_outgoing):
1534 * src/maemo/modest-account-view-window.c: (button_box_new):
1535 Use changed logical IDs as per the most recent UI spec:
1536 mcen_bd_emailsetup_edit -> mcen_bd_edit
1537 mcen_bd_emailsetup_delete -> mcen_bd_delete
1538 mcen_bd_emailsetup_close -> mcen_bd_close
1540 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1544 * src/dbus_api/Makefile.am:
1545 * src/dbus_api/modest-dbus-callbacks.c:
1546 * src/dbus_api/modest-dbus-callbacks.h:
1547 * src/maemo/modest-platform.c: (modest_platform_init):
1548 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1550 * tests/Makefile.am:
1551 * tests/dbus_api/Makefile.am:
1552 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1554 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1556 * src/maemo/modest-account-settings-dialog.c:
1557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1558 Removed unnecessary includes.
1560 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1562 * src/maemo/easysetup/modest-easysetup-wizard.c:
1563 * src/maemo/modest-account-settings-dialog.c:
1564 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1565 * src/widgets/Makefile.am:
1566 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1567 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1568 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1569 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1570 * src/widgets/modest-secureauth-combo-box.c:
1571 * src/widgets/modest-secureauth-combo-box.h:
1572 * src/widgets/modest-serversecurity-combo-box.c:
1573 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1574 made the GObject names more consistent with the rest of the Modest code.
1576 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1578 * src/maemo/easysetup/Makefile.am:
1579 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1580 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1581 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1582 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1583 * src/maemo/easysetup/modest-easysetup-wizard.c:
1584 * src/maemo/easysetup/modest-validating-entry.c:
1585 * src/maemo/easysetup/modest-validating-entry.h:
1586 * src/maemo/modest-account-settings-dialog.c:
1587 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1588 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1589 widgets/ because they are used outside of easysetup too. After checking in,
1590 svn will allow me to rename them too.
1592 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1594 * src/gnome/modest-msg-edit-window.c:
1595 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1596 linker error, to fix the build on the GNOME platform.
1597 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1598 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1599 ifdefed out to avoid a warning.
1601 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1603 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1604 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1605 some alternative for GTK+ 2.6.
1607 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1609 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1611 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1612 specified for EmailAccountsDialog in UI spec.
1614 * src/maemo/easysetup/modest-easysetup-wizard.c:
1615 * src/maemo/easysetup/modest-easysetup-wizard.h:
1616 * src/maemo/modest-account-settings-dialog.c:
1617 * src/maemo/modest-account-settings-dialog.h:
1618 Reuse a member window widget for the connection-specific SMTP server accounts,
1619 so we can tell it to create/save the accounts only if we actually save changes.
1621 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1622 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1623 (modest_connection_specific_smtp_edit_window_get_settings):
1624 Return a struct instance for temporarily remembering the entered data.
1626 * src/maemo/modest-connection-specific-smtp-window.h:
1627 * src/maemo/modest-connection-specific-smtp-window.c:
1628 (modest_connection_specific_smtp_window_finalize),
1629 (modest_connection_specific_smtp_window_fill_with_connections),
1631 (modest_connection_specific_smtp_window_save_server_accounts),
1632 (update_model_server_names): Do not actually save data until asked,
1633 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1635 (on_selection_changed),
1636 (modest_connection_specific_smtp_window_init): Disable the edit
1637 button when nothing is selected.
1639 * src/modest-account-mgr-helpers.c:
1640 * src/modest-account-mgr-helpers.h:
1641 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1644 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1646 * src/modest-account-mgr-helpers.h:
1647 * src/modest-account-mgr-helpers.c:
1648 (modest_account_mgr_get_unused_account_name),
1649 (modest_account_mgr_get_unused_account_display_name): Added these
1650 utility functions, to avoid code duplication.
1652 * src/maemo/easysetup/modest-easysetup-wizard.c:
1653 (create_page_account_details), (create_account):
1654 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1655 (on_combo_security_changed),
1656 (modest_connection_specific_smtp_edit_window_init),
1657 (modest_connection_specific_smtp_edit_window_save_settings):
1658 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1659 * src/maemo/modest-connection-specific-smtp-window.c:
1660 (modest_connection_specific_smtp_window_finalize),
1661 (modest_connection_specific_smtp_window_fill_with_connections),
1662 (on_button_edit), (modest_connection_specific_smtp_window_init):
1663 * src/maemo/modest-connection-specific-smtp-window.h:
1664 Implementing saving of connection-specific server accounts.
1666 But I need to refactor this so we can save the data for each
1667 possible connection-specific account and only actually create the server accounts
1668 when the easysetup finished, or the OK button is pressed on the account settings
1671 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1673 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1674 (on_combo_security_changed):
1675 (modest_connection_specific_smtp_edit_window_init):
1676 Auto-fill the port number as in the account settings.
1678 (modest_connection_specific_smtp_edit_window_set_connection):
1679 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1680 * src/maemo/modest-connection-specific-smtp-window.c:
1681 (fill_with_connections), (on_button_edit),
1682 (modest_connection_specific_smtp_window_init):
1683 Turn the edit window into a dialog to simplify the code, and
1684 set a WM hint as in a GtkDialog, because only a popup can be on top of
1685 another window in Maemo, and popups usually have no WM decoration.
1687 * src/modest-defs.h:
1688 * src/modest-account-mgr-helpers.c:
1689 (modest_account_mgr_set_connection_specific_smtp),
1690 (modest_account_mgr_remove_connection_specific_smtp),
1691 (modest_account_mgr_get_connection_specific_smtp):
1692 * src/modest-account-mgr-helpers.h: Some functions to write the
1693 connection-specific SMTP server information. Not yet used.
1696 * src/widgets/modest-folder-view.c: (text_cell_data):
1697 Fix a warning about an uninitialized variable.
1698 (on_configuration_key_changed): Put an #ifdef around the use
1699 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1701 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1703 * src/maemo/modest-account-settings-dialog.h:
1704 * src/maemo/modest-account-settings-dialog.c:
1705 Added connect_for_modified() utility function to mark the new modified boolean.
1707 (create_page_account_details), (create_page_user_details),
1708 (create_page_incoming), (create_page_outgoing), (on_response),
1709 (modest_account_settings_dialog_init),
1710 (modest_account_settings_dialog_set_account_name):
1711 Only warn about unsaved changes when there are actually unsaved changes.
1713 * src/modest-account-mgr-helpers.c:
1714 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1715 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1716 to get the data from there in future.
1718 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1720 * src/modest-defs.h:
1722 * src/modest-account-mgr-helpers.h:
1723 * src/modest-account-mgr-helpers.c:
1724 Store the security account setting in a single conf key instead of using
1725 the options list, so that the list is left for just the to-be-removed camel hack,
1726 and because gconf_client_set_list() is failing for some reason.
1728 * src/modest-account-mgr.c:
1729 (modest_account_mgr_add_server_account):
1730 * src/maemo/modest-account-settings-dialog.c:
1731 (modest_account_settings_dialog_set_account_name),
1732 (save_configuration): Use the renamed functions.
1735 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1737 * src/widgets/Makefile.am:
1738 * src/widgets/modest-limit-retrieve-combo-box.c:
1739 * src/widgets/modest-limit-retrieve-combo-box.h:
1740 * src/widgets/modest-retrieve-combo-box.c:
1741 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1742 the account settings dialog.
1744 * src/modest-defs.h:
1745 * src/modest-account-mgr-helpers.h:
1746 * src/modest-account-mgr-helpers.c:
1747 (modest_server_account_get_option_secure_auth),
1748 (modest_server_account_set_option_secure_auth):
1749 * src/modest-account-mgr.c:
1750 (modest_account_mgr_add_server_account):
1751 Use the existing AUTH_MECH conf key for the secure-auth setting,
1752 instead of putting it in the list options, because this was actually used already.
1754 * src/maemo/modest-account-settings-dialog.c:
1755 (create_page_account_details),
1756 (modest_account_settings_dialog_set_account_name),
1757 (save_configuration):
1758 * src/maemo/modest-account-settings-dialog.h:
1759 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1760 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1762 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1764 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1765 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1766 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1768 * src/modest-defs.h:
1769 * src/maemo/modest-account-settings-dialog.c:
1770 (create_page_incoming), (on_combo_outgoing_security_changed),
1771 (on_combo_incoming_security_changed), (create_page_outgoing),
1772 (modest_account_settings_dialog_set_account_name),
1773 (save_configuration): Load/Save the port number, and change it when the
1774 security combo changes, to suitable defaults.
1776 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1778 * src/modest-account-mgr.c:
1779 (modest_account_mgr_add_server_account): Set the security and secure-auth
1780 options, and add a comment saying that the other camel-specific options should be
1783 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1785 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1787 * src/modest-tny-account-store.c: (account_list_free),
1788 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1789 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1792 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1794 * src/modest-protocol-info.c:
1795 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1796 is required by our UI spec. Maybe something in our implementation will use this eventually.
1797 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1798 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1799 instead of the previous 0 placeholder.
1801 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1802 secure-auth settings.
1803 * src/modest-account-mgr-helpers.h:
1804 * src/modest-account-mgr-helpers.c:
1805 (modest_server_account_data_get_option_secure_auth),
1806 (modest_server_account_set_option_secure_auth),
1807 (modest_server_account_data_get_option_security),
1808 (modest_server_account_set_option_security): Added this API for getting and setting the security
1809 and secure-auth settings.
1811 * src/maemo/modest-account-settings-dialog.h:
1812 * src/maemo/modest-account-settings-dialog.c:
1813 (modest_account_settings_dialog_finalize), (check_data),
1814 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1815 about changing titles.
1816 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1817 (save_configuration): Save the security and secure-auth settings.
1819 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1820 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1822 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-defs.h:
1825 * src/modest-account-mgr.c:
1826 (modest_account_mgr_add_server_account):
1827 Added and used defines for the options key and value pair strings,
1828 that are used so far, though they do not seem to correspond to anything in our
1829 UI specs or ModestProtocol enum.
1831 * src/modest-account-mgr-helpers.h:
1832 * src/modest-account-mgr-helpers.c:
1833 (compare_option_strings_for_name),
1834 (modest_server_account_data_get_option_value),
1835 (modest_server_account_data_get_option_bool),
1836 (modest_account_mgr_get_server_account_option):
1837 Added helper functions for parsing the options GSList.
1839 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1841 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1842 display name is based on the supplied account name.
1843 * src/modest-account-mgr.c:
1844 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1845 with an inefficient, but good-enough, implementation.
1847 * src/maemo/easysetup/modest-easysetup-wizard.c:
1848 (create_page_account_details), (on_before_next), (create_account):
1849 Check for existing display names rather than (non-user-visible) account names, and just
1850 create and set a unique account name at the end.
1852 * src/maemo/modest-account-settings-dialog.c:
1853 (modest_account_settings_dialog_init),
1854 (modest_account_settings_dialog_set_account_name),
1855 (create_page_incoming): Show the display name, instead of the account name.
1856 (on_response): Do some (not all) extra checks, as in the UI spec.
1857 (save_configuration): Save the display name if it was changed.
1859 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1861 * po/en_GB.po: Added needed logical ID and translation.
1862 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1863 (init_view): Made the is-default column clicking work.
1865 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1868 * src/maemo/easysetup/Makefile.am:
1869 * src/maemo/easysetup/modest-easysetup-wizard.c:
1870 (modest_easysetup_wizard_dialog_init):
1871 * src/maemo/easysetup/provider-data-test.keyfile:
1872 * src/maemo/easysetup/provider-data.keyfile:
1873 Moved the provider data file to the new modest-providers-data package and used it from there.
1875 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1877 * src/modest-local-folder-info.c:
1878 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1879 N_() was already used on the static strings, but this just marks it for translation without
1880 using the translation.
1882 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1884 * src/maemo/modest-account-settings-dialog.c:
1885 (create_page_incoming),
1886 (modest_account_settings_dialog_set_account_name):
1887 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1888 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1889 I will do this if nobody else gets there first.
1891 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1894 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1895 save the security stuff.
1897 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1900 Set the email address and user fullname, which I now see must be
1903 * src/maemo/modest-account-settings-dialog.h:
1904 * src/maemo/modest-account-settings-dialog.c:
1906 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1907 leave-on-server and authentication.
1908 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1911 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1914 * src/maemo/modest-account-settings-dialog.c:
1915 * src/maemo/modest-account-settings-dialog.h:
1916 Most (but not all) of the widgets are now present as specified by the UI spec.
1917 No changes are yet saved, and some details are not properly shown yet.
1919 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1921 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1923 * src/maemo/Makefile.am:
1924 * src/maemo/modest-account-settings-dialog.c:
1925 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1926 an existing account. Doesn't do much yet.
1928 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1929 Open the accounts settings dialog when Edit is clicked.
1931 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1933 * src/maemo/easysetup/Makefile.am:
1934 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1936 * src/maemo/easysetup/modest-easysetup-wizard.c:
1937 (modest_easysetup_wizard_dialog_init):
1938 Try to get the source directory from the build system,
1939 instead of hard-coding "./" into the source code, when opening our local
1940 copies of the configuration files.
1941 But this still fails when opening the wizard from the Accounts window,
1942 maybe because the working directory seems to change at runtime.
1943 So the wizard will fail the second time unless you copy the files into their
1944 proper locations - see the stdout warnings for the paths.
1946 (create_page_account_details),(on_before_next):
1947 Check for existing non-server accounts instead of server accounts,
1948 so the default account name is useful again, and to prevent trying to
1951 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1952 Show the wizard when New is clicked.
1954 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1955 (init_view): Show the column headers, and show the columns that are
1956 specified in the UI specs. However, something in Maemo's GTK+ prevents
1957 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1958 change the default account. This is despite unsetting the special properties.
1960 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1962 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1963 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1964 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1965 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1966 to make that clearer.
1967 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1969 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1971 * src/maemo/modest-account-view-window.c:
1972 (modest_account_view_window_init),
1973 (modest_account_view_window_new):
1974 Use the same buttons as specified in the
1975 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1976 the existing widgets, which never had a chance of working.
1977 Put the ModestAccountView treeview in a scrolled window.
1978 Do not repeat the initialization in both _init() and _new().
1980 * src/widgets/modest-account-view.c: (update_account_view):
1981 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1982 this widget and window shows no accounts.
1984 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1986 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1988 * src/maemo/easysetup/modest-easysetup-wizard.c:
1989 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1990 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1991 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1994 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1995 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1996 accounts exist yet, as in the UI spec.
1998 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2000 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2002 * src/maemo/Makefile.am:
2003 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2004 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2005 New window for editing connection-specific smtp details.
2006 Not fully implemented.
2008 * src/maemo/modest-connection-specific-smtp-window.c:
2009 (modest_connection_specific_smtp_window_finalize) :
2010 unref the tree model.
2011 (on_button_edit): Show the edit window.
2013 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2015 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2018 * src/maemo/Makefile.am:
2019 * src/maemo/modest-connection-specific-smtp-window.c:
2020 * src/maemo/modest-connection-specific-smtp-window.h:
2021 New window for showing the list of connections, for connection-specific
2022 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2023 * src/maemo/easysetup/modest-easysetup-wizard.c:
2024 (create_page_custom_outgoing): Show the new window when the button is clicked.
2026 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2029 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2030 * src/maemo/modest-msg-edit-window.c:
2031 (modest_msg_edit_window_insert_image):
2032 * src/modest-conf.c: (modest_conf_key_escape):
2033 * src/modest-mail-operation.c:
2034 (modest_mail_operation_send_new_mail):
2035 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2036 (modest_ui_actions_on_new_account):
2037 * src/widgets/modest-attachment-view.c: (update_filename_request):
2038 * src/widgets/modest-mail-header-view.c:
2039 Corrected warnings that were breaking the build, by commenting out unused variables,
2040 and a function, and by including a header.
2042 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2044 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2045 so we can #ifdef around platform-specific code when necessary.
2046 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2047 to allow this to build for the GNOME platform too.
2049 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2051 * src/maemo/easysetup/modest-easysetup-wizard.c:
2052 Added util_increment_name() and used it in create_page_account_details()
2053 to make sure that the default account name is always a new name.
2055 (modest_easysetup_wizard_dialog_init),
2056 (set_default_custom_servernames): Some minor memory management fixes.
2058 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2062 * src/modest-runtime.c: (init_i18n): Restored the translation
2063 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2064 are defined in config.h, and the translations are installed.
2066 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2067 is defined for translation.
2069 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2071 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2073 * src/maemo/easysetup/modest-easysetup-wizard.c:
2074 (modest_easysetup_wizard_dialog_init):
2075 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2076 Use realistic paths (though they should use $prefix generically) to the
2077 mcc_mapping and provider-data.keyfile files which might work when they
2078 are installed by the future version of the operator-wizard package,
2079 and then fallback to paths in our source code, with an explanatory
2082 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2086 * src/maemo/Makefile.am:
2087 * src/maemo/easysetup/: Added files from the previously-exernal
2088 osso-modest-easysetup.
2089 * src/maemo/modest-main-window-ui.h:
2090 * src/modest-ui-actions.c:
2091 * src/modest-ui-actions.h:
2092 Added modest_ui_actions_on_new_account() as a signal handler for the
2093 New Account menu item. It shows the easysetup wizard.
2094 * po/en_GB.po: Added additional needed logical IDs and translations.
2096 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2097 Apparently ChangeLog is not used for some vague Nokia legal reasons.