1 2007-07-26 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.h:
4 * src/modest-ui-actions.c: Added
5 modest_do_refresh_current_folder() containing some code from
6 modest_ui_actions_on_send_receive().
7 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
8 Call modest_do_refresh_current_folder() before refreshing the
9 requested account, as in modest_ui_actions_on_send_receive().
10 This is strange, but seems to be necessary to show new mails.
11 Now new emails are finally visible in the UI when downloaded
12 via the automatic update interval, fixing bug NB#57458.
13 This also works because bug NB#57458 has been fixed somehow.
15 2007-07-26 Murray Cumming <murrayc@murrayc.com>
17 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
18 printf more details when we get unhandled D-Bus methods, because
21 * src/modest-mail-operation.c: (update_account_thread):
22 Comment out the tny_camel_pop_store_account_reconnect(), because this
23 is apparently no longer needed, and it did not work before anyway.
24 See the comment in the code.
26 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
27 by checking the header flags. This fixes projects.maemo.org bug
30 2007-07-25 Murray Cumming <murrayc@murrayc.com>
32 * src/maemo/modest-maemo-utils.h:
33 * src/maemo/modest-maemo-utils.c: Added
34 modest_maemo_show_information_note_in_main_context_and_forget().
35 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
36 Use the new function to show simple error dialogs in the main
37 context, though question dialogs are still in the current context,
38 which is unfortunately usually not the main context. This should
41 2007-07-25 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-tny-account-store.c: (get_password):
44 Never save the entered username and password in gconf,
45 because the UI spec says we should not. This helps
46 slightly with projects.maemo.org bug NB#63671.
48 2007-07-25 Murray Cumming <murrayc@murrayc.com>
50 * src/widgets/modest-msg-edit-window.h:
51 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
52 Moved some code here to make it simpler.
53 (modest_msg_edit_window_attach_file_one): Renamed from
54 modest_msg_edit_window_attach_file_interactive().
55 (modest_msg_edit_window_offer_attach_file): Renamed from
56 modest_msg_edit_window_attach_file() and used
57 modest_msg_edit_window_attach_file_one() instead of
58 copy/pasting the code. The old code for one was not using
59 GnomeVFS. This allows use of smb:// URLs when using send-as
60 from external applications, fixing bug NB#63741.
62 (modest_msg_edit_window_insert_image),
63 (modest_msg_edit_window_add_attachment_clicked):
64 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
65 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
66 Adapted to the new function names.
68 2007-07-25 Murray Cumming <murrayc@murrayc.com>
70 (modest_platform_set_update_interval): Set the alarm recurrence
71 fields so that auto-update does not just happen the first time.
72 This should have fixed projects.maemo.org bug NB#63938.
74 When this happens you can see a printf when the D-Bus method is
76 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
78 However, I do not actually seem to get new POP messages even when
79 clicking the refresh button manually. A restart gets them.
80 This might be a problem in today's tinymail only.
82 2007-07-24 Murray Cumming <murrayc@murrayc.com>
84 * src/maemo/modest-maemo-global-settings-dialog.c:
86 Avoid a crash (probably only in scratchbox) when strcmp()ing a
87 NULL when closing the dialog.
89 2007-07-24 Murray Cumming <murrayc@murrayc.com>
91 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
92 Remove the hacky send/receive that didn't work, and instead
93 refilter the treemodel to make the deleted email really vanish from
94 the UI (though the delete-from-menu code does has commented out
95 the code that does that). This fixes projects.maemo.org bug
98 2007-07-24 Murray Cumming <murrayc@murrayc.com>
100 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
101 Try a couple of tricks to force the treeview to update (
102 poke the folder, and do a send/receive refresh), but the deleted
103 email still appears with a strike-through instead of really being
106 2007-07-23 Murray Cumming <murrayc@murrayc.com>
108 * src/dbus_api/modest-dbus-callbacks.c:
109 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
110 because their ID is not human-readable (see the comment about
111 improvements needed to the osso-email-interface API) and
112 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
114 2007-07-23 Murray Cumming <murrayc@murrayc.com>
116 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
117 (add_folders_to_list), (on_dbus_method_get_folders),
118 (modest_dbus_req_filter):
119 * src/maemo/modest-maemo-utils.c:
120 (on_camel_account_get_supported_secure_authentication):
121 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
122 (on_header_view_focus_in):
123 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
124 * src/modest-formatter.c: (modest_formatter_create_body_part):
125 * src/modest-mail-operation.c: (recurse_folders),
126 (update_account_thread), (get_msgs_full_thread),
127 (modest_mail_operation_get_msgs_full),
128 (modest_mail_operation_xfer_msgs):
129 * src/modest-search.c: (search_mime_part_and_child_parts),
130 (modest_search_account), (modest_search_all_accounts):
131 * src/modest-tny-account.c:
132 (modest_tny_account_get_special_folder), (recurse_folders):
133 * src/modest-tny-local-folders-account.c:
134 (modest_tny_local_folders_account_query_passes):
135 * src/modest-tny-msg.c: (copy_mime_part),
136 (modest_tny_msg_find_body_part_from_mime_part):
137 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
138 (modest_tny_send_queue_try_to_send):
139 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
140 (_modest_ui_actions_open), (download_uncached_messages),
141 (reply_forward), (modest_ui_actions_on_copy),
142 (modest_ui_actions_on_details), (has_retrieved_msgs),
143 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
145 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
146 (_selected_msg_marked_as), (_msg_download_completed),
147 (_selected_msg_sent_in_progress):
148 * src/widgets/modest-attachments-view.c:
149 (modest_attachments_view_set_message):
150 * src/widgets/modest-msg-view.c: (find_cid_image):
151 * tests/check_folder-transfer.c: (find_folders):
152 * tests/check_update-account.c: (func):
153 * tests/dbus_api/test_get_folders.c: (main):
154 Checked all uses of tny_iterator_get_current(), making sure
155 that the object is unreferenced (3 or 4 places did not),
156 and adding checks for NULL.
158 2007-07-23 Murray Cumming <murrayc@murrayc.com>
160 * src/dbus_api/modest-dbus-callbacks.c:
161 (on_idle_open_default_inbox): Make sure that the application UI is
163 * src/maemo/easysetup/modest-easysetup-wizard.c:
164 (on_entry_invalid_character): Show the word whitespace instead
165 of (null) in the banner when whitespace was entered.
166 (show_error): Add a comment that this does not work in
167 Maemo Bora, though we do not know why.
169 2007-07-23 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-tny-account.c:
172 (modest_tny_account_get_special_folder): Use an if instead of
173 an assert for when the parent account name is NULL, because this
174 might be causing a crash in projects.maemo.org bug 63192.
175 * src/modest-mail-operation.c:
176 (modest_mail_operation_send_new_mail_cb),
177 (modest_mail_operation_remove_folder): unref the folder that is
178 returned from modest_tny_account_get_special_folder().
180 2007-07-23 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-ui-actions.c:
183 (modest_ui_actions_on_password_requested):
184 Show mail_ib_login_cancelled info banner when the user cancels
185 the protected password dialog, to fix projects.maemo.org
188 2007-07-23 Murray Cumming <murrayc@murrayc.com>
190 * src/maemo/modest-account-settings-dialog.c:
191 (create_page_outgoing): Put this page in a GtkScrolledWindow,
192 matching the UI mock-up in the UI spec, and allowing access
193 to all widgets even when the on-screen keyboard is active.
195 2007-07-23 Murray Cumming <murrayc@murrayc.com>
197 Reverted this previous commit from Johannes,
198 because the scrollbars are always visible and because
199 I think we only need it on onepage of the account
200 settings, not the account wizard.
201 (I wrote the wrong instructions in the bug.)
203 * src/maemo/easysetup/modest-easysetup-wizard.c:
204 Added scrollbars to account wizard dialog.
205 Fixed projects.maemo.org NB #62744
207 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
209 * src/maemo/easysetup/modest-easysetup-wizard.c:
210 (create_page_user_details):
211 Use auto-cap for name (projects.maemo.org NB#63716)
212 * src/widgets/modest-account-view.c: (on_account_busy_changed):
214 2007-07-22 Armin Burgmeier <armin@openismus.com>
216 * src/maemo/modest-ui-actions.c: Use current account instead of
217 default account for creating viewer windows, so that the viewer
218 window knows to which account the viewed message belongs.
220 * src/maemo/modest-msg-view-window.c: Destroy the window when the
221 corresponding account is deleted. This fixes projects.maemo.org bug
224 2007-07-18 Armin Burgmeier <armin@openismus.com>
226 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
227 the dialog close after entering an invalid port number and clicking
228 OK. This fixes projects.maemo.org bug NB#63602.
230 2007-07-18 Armin Burgmeier <armin@openismus.com>
232 * src/modest-tny-account-store.c:
233 (get_server_accounts): Set parent modest account name for each
234 connection-specific transport account so that special folders of such
235 an account can be looked up. This fixes a crash when changing account
236 settings. This might also be related to projects.maemo.org bug
239 2007-07-16 Armin Burgmeier <armin@openismus.com>
241 * src/modest-ui-actions.c: Added a button to create a folder to the
242 move-to dialog. This fixes projects.maemo.org bug NB#.
244 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
246 * src/maemo/easysetup/modest-easysetup-wizard.c:
247 Added scrollbars to account wizard dialog.
248 Fixed projects.maemo.org NB #62744
250 2007-07-16 Murray Cumming <murrayc@murrayc.com>
252 * src/widgets/modest-msg-view.h:
253 * src/widgets/modest-msg-view.c:
254 Added modest_msg_view_get_message_is_empty() but this needs
256 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
257 Check if there is any text in the message yet.
258 But this needs to be implemented properly.
259 (modest_msg_edit_window_toggle_find_toolbar):
260 * src/maemo/modest-msg-view-window.c:
261 (modest_msg_view_window_toggle_find_toolbar):
262 Show a banner warning if there is no text to search, when
263 trying to start a search. This partially fixes
264 projects.maemo.org bug NB#62350.
266 2007-07-13 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-mail-operation.c: (update_account_thread):
269 Initialized num_new_headers to fix the build.
271 2007-07-13 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
274 Ignore modest accounts whose server accounts don't exist in gconf.
275 This prevents us trying to create TnyAccount instances for those
276 server accounts when the server account has been removed from gconf,
277 but the parent modest account has not yet been removed from modest.
278 I don't know why this is only noticeable now. It was probably just
279 a harmeless g_warning() anyway.
281 2007-07-13 Murray Cumming <murrayc@murrayc.com>
283 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
284 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
286 2007-07-12 Armin Burgmeier <armin@openismus.com>
288 * src/maemo/modest-main-window.c: Make default account appear bold
289 in view, tools/send & receive and toolbar/send & receive SCM menus.
290 This fixes projects.maemo.org bug NB#59010.
292 2007-07-12 Murray Cumming <murrayc@murrayc.com>
294 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
295 Add a short-cut, by checking if the folder store is an account.
296 This ensures that the Sort menu item and toolbar is dimmed for
297 the local-folders account root item, fixing
298 projects.maemo.org bug NB#62545.
300 2007-07-12 Murray Cumming <murrayc@murrayc.com>
302 * src/modest-tny-account-store.c: (get_password):
303 Show the password dialog (via the signal) only in the mainloop, via
304 an idle handler that we wait for. This could theoretically prevent
305 hangs, though I worry that it could introduce some too.
307 2007-07-12 Murray Cumming <murrayc@murrayc.com>
309 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
310 * src/maemo/modest-platform.c:
311 (modest_platform_connect_and_wait):
312 Take a TnyAccount* parameter and try to set it to online
313 (a TnyCamel-only API), because tinymail sets accounts to offline
314 when the user cancels a password dialog, and doesn't ask again until
315 it has been set to online.
316 However, this is commented out because it causes a hang now.
318 (modest_platform_connect_and_wait_if_network_account):
319 * src/modest-mail-operation.c:
320 (modest_mail_operation_update_account):
321 * src/modest-platform.h:
322 * src/modest-ui-actions.c: (_modest_ui_actions_open),
323 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
325 2007-07-12 Armin Burgmeier <armin@openismus.com>
327 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
329 * src/modest-mail-operation.c:
330 * src/modest-ui-actions.c: Check for already existing folder before
331 querying the server, show error message from camel if the request
332 still fails. This fixes projects.maemo.org bug NB#58701.
334 2007-07-12 Murray Cumming <murrayc@murrayc.com>
336 * src/modest-tny-account-store.h:
337 * src/modest-tny-account-store.c:
338 Added modest_tny_account_store_forget_password_in_memory(),
339 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
340 when creating a new account, so that new passwords will be used, instead of
341 us thinking that it's a second request as a result of a failed password again.
343 2007-07-12 Murray Cumming <murrayc@murrayc.com>
345 * src/dbus_api/modest-dbus-callbacks.c:
346 (on_idle_open_message): If the message is in drafts then open it
347 in an edit window instead of a view window. This fixes
348 projects.maemo.org bug NB#63005.
350 2007-07-12 Murray Cumming <murrayc@murrayc.com>
352 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
353 Avoided a harmless g_warning().
355 2007-07-12 Murray Cumming <murrayc@murrayc.com>
357 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
358 Pass the modest account name, not the TnyAccount display name to
359 modest_msg_view_window_new() so that the reply feature works,
360 fixing projects.maemo.org bug NB#62892.
362 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
363 (modest_msg_view_window_new_with_header_model):
364 * src/maemo/modest-msg-view-window.c:
365 (modest_msg_view_window_new_with_header_model),
366 (modest_msg_view_window_new):
367 * src/modest-ui-actions.c: (reply_forward):
368 * src/widgets/modest-msg-view-window.h:
369 * src/widgets/modest-window.c: (modest_window_set_active_account):
370 Rename an account parameter to modest_account_name to make this clearer.
372 2007-07-11 Murray Cumming <murrayc@murrayc.com>
374 * src/modest-ui-actions.h:
375 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
376 modest_do_message_delete().
377 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
378 Call modest_do_message_delete(), hoping that this would cause messages
379 to be really deleted from search instead of just marked with strike through.
380 Does not seem to help.
382 2007-07-11 Armin Burgmeier <armin@openismus.com>
384 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
385 priv->reselect to FALSE prior to calling
386 modest_folder_view_select_first_inbox_or_local() to prevent endless
387 recursion and thus a crash on startup.
389 2007-07-11 Armin Burgmeier <armin@openismus.com>
391 * src/maemo/modest-account-settings-dialog.h: Include
392 <gtk/gtknotebook.h> to fix the build (at least for me).
394 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
395 Use "New FolderN" as default suggested name if "New folder" already
396 exists, with N being the first free number, though never exceed "New
397 folder99" in which case we just fall back to "New Folder" even though
398 it already exists. This fixes projects.maemo.org bug NB#58663.
400 2007-07-11 Murray Cumming <murrayc@murrayc.com>
402 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
403 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
404 projects.maemo.org bug NB#62778.
406 2007-07-11 Murray Cumming <murrayc@murrayc.com>
408 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
409 Ignore the wrong (for now) secure-smtp setting in the presets -
410 just default to requiring secure authentication for SMTP, because
413 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
415 * src/widgets/modest-folder-view.c: (filter_row)
416 Do not show drafts folder (see UI specs)
418 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
420 * src/modest-ui-actions.c:
421 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
422 place and also not necessary.
424 * src/widgets/modest-folder-view.c: (filter_row)
425 Guess folder type and hide Sent & Outbox if necessary.
426 Fixed project.maemo.org NB#57328
428 2007-07-11 Murray Cumming <murrayc@murrayc.com>
430 * src/modest-ui-actions.h:
431 * src/modest-ui-actions.c:
432 (modest_ui_actions_on_delete_message):
433 Move some code into a new
434 modest_ui_actions_refresh_message_window_after_delete()
435 function so we can use it from elsewhere.
437 * src/dbus_api/modest-dbus-callbacks.c:
438 (on_idle_delete_message), (on_delete_message): Used an idle
439 handler, as we do for the other D-Bus method handlers.
440 Call modest_ui_actions_refresh_message_window_after_delete()
441 if the deleted message was open in a window. This fixed
442 projects.maemo.org bug NB#62862.
444 2007-07-11 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-main.c: (main): Only show the UI at the start if
447 the showui command line option was given. For instance,
448 run-standalone src/modest showui
449 Otherwise, we wait for the top_application D-Bus method to
450 be sent by hildon-desktop when the application is selected
452 This allows us to run without a UI when osso-global-search
453 uses our D-Bus methods.
455 2007-07-11 Murray Cumming <murrayc@murrayc.com>
457 * src/dbus_api/modest-dbus-api.h: Added a define for a
458 top-application D-Bus method.
459 * src/dbus_api/modest-dbus-callbacks.c:
460 (on_top_application),
461 (modest_dbus_req_handler): Handle the top-application D-Bus
462 method, which might be an undocumented D-Bus signal sent by
463 hildon-desktop when it starts the application from the menu.
464 But I am not sure and I need to test it on the device, because
465 my scratchbox does not have the application in the menu now.
466 This method shows the main window, so that it can be invisible
467 when started, for instance, just for email searching from
470 * src/maemo/modest-main-window.c: (restore_settings),
471 (modest_main_window_new): Do not show the window immediately
472 upon creation. We show it later.
473 * src/modest-widget-memory.c: (save_settings_paned):
474 Try (unsuccessfully) to avoid saving the paned position when
475 it is not even visible.
476 (restore_settings_paned): Do not allow a silly paned position.
477 This seems necessary when not showing the window at first.
479 * tests/dbus_api/Makefile.am:
480 * tests/dbus_api/test_top_application.c: (main): Test for the
483 2007-07-10 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-ui-dimming-rules.c:
486 (modest_ui_dimming_rules_on_new_msg),
487 (modest_ui_dimming_rules_on_reply_msg),
488 (modest_ui_dimming_rules_on_delete_msg),
489 (modest_ui_dimming_rules_on_details),
490 (modest_ui_dimming_rules_on_view_window_move_to),
491 (modest_ui_dimming_rules_on_view_previous),
492 (modest_ui_dimming_rules_on_view_next),
493 (_invalid_folder_for_purge): Added checks before
494 casting the window. This looks like an actual
495 logic error in _invalid_folder_for_purge(), because it
496 tries to use a ModestMainWindow as a message window.
498 2007-07-10 Murray Cumming <murrayc@murrayc.com>
500 * src/maemo/modest-account-settings-dialog.c:
501 (show_error): Use the same implementation as in
502 modest-easysetup-wizard.c:
503 (on_entry_invalid_character): The logical ID contains a %s.
504 Guessed what it should be.
505 (on_entry_max), (check_data), (on_response): Adapt to
506 changed show_error().
507 (create_page_account_details): Really call
508 modest_validating_entry_set_func() on the correct widgets.
509 * src/maemo/easysetup/modest-easysetup-wizard.c:
510 (on_entry_invalid_character): Fix the logical ID here too.
511 (create_page_account_details),
512 (create_page_user_details):
514 modest_validating_entry_set_func() on the correct widgets.
516 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
517 Do not try to use the account if it is NULL.
519 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
521 * src/modest-ui-actions.c: (create_move_to_dialog),
522 (modest_ui_actions_on_main_window_move_to),
523 (modest_ui_actions_on_msg_view_window_move_to):
524 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
525 (filter_row), (modest_folder_view_show_non_move_folders):
526 * src/widgets/modest-folder-view.h:
528 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
529 the Sent folder yet as it does not report the correct folder type.
531 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
533 * src/maemo/modest-msg-edit-window.c: (init_window):
536 2007-07-10 Murray Cumming <murrayc@murrayc.com>
538 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
539 Take a parent widget instead of a parent window, and
540 implement this with hildon_banner_show_information() instead.
541 Non-Maemo builds can just ifdef that there.
542 This fixed projects.maemo.org bug NB#62766.
544 (on_entry_invalid_character): Use show_error() again instead
545 of using hildon directly, and use the _CS() macro to use the correct
547 (create_account), (check_for_supported_auth_methods), (on_entry_max):
548 Pass a widget instead od a window to show_error().
550 2007-07-10 Murray Cumming <murrayc@murrayc.com>
552 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
553 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
554 This allows us to show the server name in the error message, fixing
555 projects.maemo.org bug NB#62904.
556 Also, use the appropriate logical ID message for the account protocol.
558 2007-07-10 Murray Cumming <murrayc@murrayc.com>
560 * src/modest-tny-account-store.c: (on_idle_wrong_password):
561 A compilation fix, though the build wasn't broken for me.
563 2007-07-09 Murray Cumming <murrayc@murrayc.com>
565 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
566 Do not try to unref a NULL folder store, to avoid a runtime warning.
567 This seems to happen sometimes when changing accounts settings.
569 2007-07-09 Murray Cumming <murrayc@murrayc.com>
571 * src/modest-tny-account-store.c:
572 (modest_tny_account_store_instance_init),
573 (modest_tny_account_store_finalize),
574 (on_account_settings_hide), (on_idle_wrong_password):
575 Use a GHashTable to ensure that we only show one account settings
576 dialog per modest account. This avoids us having a dialog open for
577 both the store and transport accounts, or due to repeated get_password()
578 calls that shouldn't happen anyway.
580 2007-07-09 Murray Cumming <murrayc@murrayc.com>
582 * src/maemo/modest-maemo-utils.c: (on_hide),
583 (modest_maemo_show_dialog_and_forget): Handle the response, because
584 the window is not even hidden by default.
586 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
587 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
588 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
589 which seems to prevent some modality problems.
591 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
592 Ignore user cancellation errors.
594 * src/modest-account-mgr-helpers.h:
595 * src/modest-account-mgr-helpers.c:
596 Added modest_server_account_get_password() and
597 modest_server_account_get_has_password() to avoid direct use of
600 * src/maemo/modest-account-settings-dialog.h:
601 * src/maemo/modest-account-settings-dialog.c:
602 (modest_account_settings_dialog_init): Store the notebook so we can
604 Added modest_account_settings_dialog_switch_to_user_info().
606 * src/modest-tny-account-store.c:
607 (get_password): When the password in the account settings is wrong (we think),
608 show the relevant page of the account settings dialog, in the mainloop.
609 However, we currently get many of these at once because cancel does not
611 (forget_password): Do not forget the password
612 from the account settings, because this causes side-effects when
613 tinymail seems to call it at strange time, maybe because of how we
614 are cancelling get_password().
615 (modest_tny_account_store_alert): Ignore user cancellations.
617 2007-07-09 Murray Cumming <murrayc@murrayc.com>
619 * src/maemo/modest-maemo-utils.h:
620 * src/maemo/modest-maemo-utils.c:
621 Added modest_maemo_show_information_note_and_forget() for use instead of
622 gtk_dialog_run() when the response is not needed, to avoid an extra
623 mainloop which could cause a hang.
625 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
626 Use the logical IDs for the error message, though they are not
627 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
628 because gtk_dialog_run() caused a hang here (the window did not close).
629 This fixes projects.maemo.org bug NB#62646.
631 2007-07-09 Murray Cumming <murrayc@murrayc.com>
633 * src/modest-account-mgr-helpers.h:
634 * src/modest-account-mgr-helpers.c:
635 Added modest_account_mgr_get_store_protocol().
637 * src/maemo/modest-account-view-window.c:
638 (on_delete_button_clicked): Show different warning text depending on
639 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
640 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
643 2007-07-09 Murray Cumming <murrayc@murrayc.com>
645 * src/maemo/modest-msg-edit-window.c:
646 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
647 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
649 2007-07-07 Armin Burgmeier <armin@openismus.com>
651 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
652 ckdg_ib_maximum_characters_reached from correct package.
654 * src/modest-ui-actions.c: Show an error message when a folder could
655 not be created. Tinymail does not give us specific error codes about
656 what has gone wrong, so we assume that a folder with that name
657 already exists, though there might be other reasons.
659 2007-07-06 Murray Cumming <murrayc@murrayc.com>
661 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
662 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
663 give a more exact error message that can be partly translated.
665 2007-07-05 Murray Cumming <murrayc@murrayc.com>
667 * src/maemo/modest-address-book.c:
668 (select_email_addrs_for_contact): Specify a default window size for the
669 select-email-address dialog, so that it is probably big enough for the
670 title. This should fix projects.maemo.org bug NB#62277.
672 2007-07-05 Murray Cumming <murrayc@murrayc.com>
674 * src/maemo/easysetup/modest-easysetup-wizard.c:
675 (create_page_complete_easysetup): Use
676 gtk_widget_set_size() request to ensure that the text wraps
679 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
681 * src/maemo/easysetup/modest-easysetup-wizard.c:
682 (on_entry_invalid_character), (create_page_account_details),
683 (create_page_user_details):
684 Use new API of ModestValidatingEntry. But for some reason the banner is
685 not shown. I will have to investigate that further.
687 * src/widgets/modest-validating-entry.c: (on_insert_text),
688 (modest_validating_entry_set_func):
689 * src/widgets/modest-validating-entry.h:
690 Added a new callback function to be able to react to prevented
691 characters whitespaces to e.g show a banner.
693 2007-07-05 Armin Burgmeier <armin@openismus.com>
695 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
696 notification of HildonNumberEditor instead of remembering the port
697 number. Thanks to Johannes for pointing this out.
699 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
701 * src/maemo/easysetup/modest-easysetup-wizard.c:
702 Check if there are any user changes before showing a confirmation
703 dialog (projects.maemo.org NB#60946)
705 2007-07-05 Armin Burgmeier <armin@openismus.com>
707 * src/maemo/modest-account-settings-dialog.c: Remember custom port
708 number at the beginning of the dialog and set the modified flag at the
709 end if the port number has changed. This is necessary because
710 HildonNumberEditor does not support notification when the value has
713 2007-07-05 Murray Cumming <murrayc@murrayc.com>
715 * src/modest-ui-actions.c:
716 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
717 a connection before asking anything else. Correct the check for the destination
718 folder so that it succeeds when online.
719 This fixed projects.maemo.org bug NB#61645.
721 2007-07-05 Murray Cumming <murrayc@murrayc.com>
723 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
724 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
725 to fix projects.maemo.org bug NB#62439.
727 2007-07-05 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-tny-account.c: (on_connection_status_changed):
730 Really do not use tny_device_force_offline() here. See the previous comment.
732 2007-07-04 Murray Cumming <murrayc@murrayc.com>
734 * src/modest-tny-account.c: (on_connection_status_changed):
735 Do not use tny_device_force_offline() when tinymail says that something
736 went wrong with the connection. It seems to report this unnecessarily.
738 2007-07-04 Murray Cumming <murrayc@murrayc.com>
740 * src/maemo/modest-connection-specific-smtp-window.c:
741 (modest_connection_specific_smtp_window_init):
742 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
743 does not seem to have any effect in osso 1.1 (though it works in
744 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
746 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
748 * src/maemo/modest-connection-specific-smtp-window.c:
749 Fix UI specification problems with projects.meamo.org NB#60479
751 2007-07-04 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
754 clue when this has failed, because the error dialog is not always shown
755 (at least in earlier version).
757 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
758 GError message, because the generic error dialog is not helpful.
760 'This message is not currently available (can't let a new connection go online)'
761 when trying to open an IMAP message.
763 (_modest_ui_actions_open): Offer a connection when some messages would
764 have to be downloaded and we are offline.
766 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
768 * src/widgets/modest-folder-view.c:
769 Don't check for MERGE type anymore as we use the correct type
771 NOTE: For the last two changes you need to update your tinymail copy
772 because of API changes!
774 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
776 * src/modest-tny-local-folders-account.c:
777 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
778 (see projects.maemo.org NB#61580)
780 2007-07-04 Murray Cumming <murrayc@murrayc.com>
782 * src/modest-tny-account.c: (on_connection_status_changed):
783 Commented out the call to modest_platform_connect_and_wait() because this
784 seems to always hang, and I would like to know if this is the only thing
785 that causes a hang when showing the connection dialog.
786 It is not very useful anyway.
788 2007-07-04 Murray Cumming <murrayc@murrayc.com>
790 * src/maemo/modest-msg-view-window.c:
791 (modest_msg_view_window_select_next_message):
793 * src/modest-platform.h:
794 * src/maemo/modest-platform.c:
795 Added modest_platform_connect_and_wait(), which calls
796 tny_maemo_conic_device_connect() always in the main thread, by calling it
797 in an idle handler and waiting for the idle handler to run. It should be
798 in the main thread because it uses GTK+ UI code. It just returns TRUE
799 if the device is already online.
801 There is some nasty code to ensure that subsequent calls to
802 modest_platform_connect_and_wait() just wait for the first one to finish,
803 by checking repeatedly in another idle handler. This is necessary,
804 because other threads (or even the main thread, via another idle handler)
805 can call modest_platform_connect_and_wait() while
806 modest_platform_connect_and_wait() is running.
808 (modest_platform_connect_and_wait_if_network_account),
809 (modest_platform_connect_and_wait_if_network_folderstore):
810 Convenience functions that calls modest_platform_connect_and_wait() if
811 the account or folder might want network access.
813 * src/modest-mail-operation.c:
814 (modest_mail_operation_update_account):
815 * src/modest-ui-actions.c: (download_uncached_messages),
816 (modest_ui_actions_on_rename_folder), (delete_folder),
817 (modest_ui_actions_on_main_window_move_to),
818 (modest_ui_actions_on_msg_view_window_move_to):
819 * src/widgets/modest-folder-view.c:
820 (drag_and_drop_from_folder_view):
821 Offer a connection if we are offline.
823 * src/modest-tny-account.c: (on_connection_status_changed):
824 Document this as only handling errors during network operations in progress,
825 and replace the idle code with a simple call to
826 modest_platform_connect_and_wait(), which does this instead.
828 2007-07-03 Murray Cumming <murrayc@murrayc.com>
830 * src/modest-tny-account.c:
831 (modest_tny_account_get_special_folder): (util_on_idle),
832 Handle the GError so we can see when tny_folder_store_get_folders()
833 fails, as it currently does while something else is connecting.
835 Added util_run_in_main_thread_and_wait()
836 which uses an idlen handler and mainloop to ensure that the function
837 is called in the main thread.
838 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
839 to make sure that we call attempt the connection in the mainloop only,
840 which might solve some hangs.
842 2007-07-03 Murray Cumming <murrayc@murrayc.com>
844 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
845 be found by their display name. This is never useful.
846 * src/modest-tny-account-store.c: (on_account_removed): Find the account
847 by its ID, instead of trying to use its ID as its display name.
849 * src/modest-tny-account-store.h:
850 * src/modest-tny-account.c:
851 (modest_tny_account_get_special_folder): Add a g_warning() when
852 tny_folder_store_get_folders() returns an empty list for the maildir.
854 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
855 Add a g_warning() when this returns NULL, because that it not allowed
858 2007-07-02 Armin Burgmeier <armin@openismus.com>
860 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
861 note when trying to cancel the wizard. This fixes projects.maemo.org
864 2007-07-02 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-tny-account.h:
867 * src/modest-tny-account.c:
868 (modest_tny_account_new_from_server_account),
869 (modest_tny_account_new_from_server_account_name),
870 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
871 because this must now be set before setting the proto. This is usd in
872 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
873 warning in camel_session_get_service() caused by
874 tny_camel_transport_account_prepare().
876 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
879 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
881 * src/maemo/modest-connection-specific-smtp-edit-window.c:
883 (modest_connection_specific_smtp_edit_window_init):
885 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
888 2007-06-29 Murray Cumming <murrayc@murrayc.com>
890 * src/modest-tny-account.c:
891 (modest_tny_account_new_from_server_account):
892 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
893 now uses to request a connection when it needs one, and which it uses
894 to tell us that something is wrong with the connection, so we can force
895 the accounts offline to prevent further problems.
898 * src/modest-init.c: (init_default_settings):
899 * src/modest-mail-operation.c:
900 (modest_mail_operation_update_account):
901 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
902 This should not be necessary anymore. Do not set the conf key that
903 determined this (it was always TRUE and not set anywhere else).
905 * src/modest-ui-actions.h: Remove unused and unimplemented
906 modest_ui_actions_on_online_toggle_toggled().
908 2007-06-29 Murray Cumming <murrayc@murrayc.com
910 * src/maemo/modest-main-window.c: (connect_signals):
911 Don't connect to delete_event twice. Maybe this was harmless.
913 2007-06-29 Murray Cumming <murrayc@murrayc.com
915 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
916 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
917 Debug output to give some more clue when a folder move is not allowed.
919 2007-06-28 Murray Cumming <murrayc@murrayc.com
921 * src/modest-tny-account.c: (on_modest_file_system_info),
922 (modest_tny_account_get_mmc_account_name):
923 Always call the callback, without checking whether the name has changed.
924 * src/widgets/modest-folder-view.c: (strings_are_equal),
925 (on_model_foreach_set_name), (on_get_mmc_account_name),
926 (text_cell_data): Compare the name here, and use the name from
927 the account rather than from the
928 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
929 if the name was changed after the account was added to the model.
930 That's a tinymail bug but not one that I want to fix now.
932 This finally fixes projects.maemo.org bug NB#59301.
934 2007-06-27 Armin Burgmeier <armin@openismus.com>
936 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
939 2007-06-27 Murray Cumming <murrayc@murrayc.com
941 * src/modest-tny-account.h:
942 * src/modest-tny-account.c:
943 Added modest_tny_account_get_mmc_account_name(), to set the memory
944 card name asynchronously for the given account and then notify.
945 (modest_tny_account_new_for_local_folders): Use this new function instead
946 of using hildon_file_system_info_async_new() directly.
948 * src/widgets/modest-folder-view.c: (text_cell_data):
949 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
950 gtk_tree_model_row_changed() when it is available.
952 This should fix projects.maemo.org bug NB#59301.
954 2007-06-27 Murray Cumming <murrayc@murrayc.com
956 * src/modest-mail-operation.c: (update_account_thread),
957 (get_msgs_full_thread): Fix typo failures in the revert
960 2007-06-27 Murray Cumming <murrayc@murrayc.com
962 * src/maemo/modest-maemo-global-settings-dialog.c:
963 (idle_select_default_focus):
964 * src/modest-mail-operation.c: (idle_notify_progress),
965 (idle_notify_progress_once), (set_last_updated_idle),
966 (update_account_thread), (get_msgs_full_thread):
967 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
968 * src/widgets/modest-header-view.c:
969 (idle_notify_headers_count_changed_destroy),
970 (idle_notify_headers_count_changed):
971 Reverted the additions of gdk_threads_enter/leave(), in case this
972 helps with a startup hang on the device.
974 2007-06-26 Armin Burgmeier <armin@openismus.com>
976 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
977 for supported secure authentication methods from server by
978 gtk_dialog_run(), saving CPU time and a potential race condition.
980 2007-06-26 Armin Burgmeier <armin@openismus.com>
982 * src/maemo/modest-maemo-utils.h:
983 * src/maemo/modest-maemo-utils.c: Added a
984 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
985 only error code to tell the calling code when the user canceled the
988 * src/maemo/modest-account-settings-dialog.h:
989 * src/maemo/modest-account-settings-dialog.c:
990 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
991 message if the retrieval of secure authentication methods was canceled
992 by the user. Perform the check before saving anything to configuration
993 to not end up with half-committed configuration changes, do not show
994 a "Saving to configuration failed" note when authentication methods
995 could not be retrieved.
997 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1000 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1002 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1003 Only return the first level of folders under accounts, because the
1004 osso-global-search UI spec doesn't want the rest.
1005 This fixed projects.maemo.org bug NB#61811.
1007 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-tny-account-store.c:
1010 * src/modest-tny-account-store.h:
1011 Added modest_tny_account_is_memory_card_account().
1012 * src/maemo/modest-main-window.c: (create_details_widget):
1013 Show the same information items for the memory card as we show for the
1014 local-folders, to fix projects.maemo.org bug NB#59307.
1016 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-tny-account-store.c: (get_password):
1019 Added some checks for NULL to maybe prevent crashes, though I think
1020 it was Philip's last commit that actually prevented the crash here
1021 when creating a first new account.
1022 But the new account is still not usable (no messages are shown)
1023 until a restart of the application.
1025 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1027 * src/maemo/modest-maemo-global-settings-dialog.c:
1028 (idle_select_default_focus):
1029 * src/modest-mail-operation.c: (idle_notify_progress),
1030 (idle_notify_progress_once), (idle_notify_update_account_queue),
1031 (set_last_updated_idle), (update_account_thread),
1032 (notify_get_msgs_full), (get_msgs_full_destroyer),
1033 (get_msgs_full_thread):
1034 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1035 * src/widgets/modest-header-view.c:
1036 (idle_notify_headers_count_changed_destroy),
1037 (idle_notify_headers_count_changed):
1038 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1039 all idle handlers, because some other thread could be blocking
1040 the GDK lock, so that it can do GUI stuff.
1042 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1044 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1045 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1046 (on_idle_send_receive), (on_idle_open_default_inbox):
1047 * src/maemo/modest-msg-edit-window.c:
1048 (modest_msg_edit_window_attach_file_noninteractive):
1049 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1050 to prevent a hang. I don't quite understand why these are necessary,
1051 beause we should already be in the main loop. I guess something outside
1052 of the main loop is taking the lock.
1054 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1055 we are really using URIs, and use files that are more likely to exist.
1057 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1059 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1060 necessary because configure.ac now defines different variables.
1062 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1064 * libmodest-dbus-client/libmodest-dbus-client.c:
1065 * libmodest-dbus-client/libmodest-dbus-client.h:
1066 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1067 libmodest_dbus_client_compose_mail() is what things actually use.
1069 * src/dbus_api/modest-dbus-api.h:
1070 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1071 * tests/dbus_api/Makefile.am:
1072 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1075 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-init.c: (modest_init_local_folders):
1078 For memory-card (or other non local-folders) maildir accounts,
1079 always create an Archive folder, so that there is somewhere to put
1080 messages. This should be less confusing, because the user does not need
1081 to guess that the need to create a folder.
1083 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1085 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1086 Fixed icon size by using (50, 50) which is the same as defined by
1089 2007-06-25 Armin Burgmeier <armin@openismus.com>
1091 * src/widgets/modest-window-mgr.c:
1092 * src/modest-init.c:
1093 * configure.ac: Correctly recognize hildon-notify presence and fixed
1094 the build without it being installed.
1096 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1098 * libmodest-dbus-client/libmodest-dbus-client.c:
1099 (libmodest_dbus_client_search): Fix the build. Sorry.
1100 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1101 (reply_forward_cb): Initialize variables to fix the build.
1103 * src/modest-tny-account-store.c:
1104 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1105 comparison (a silly typo) so that email search results can be opened
1106 when there are more than one account.
1108 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1110 * libmodest-dbus-client/libmodest-dbus-client.c:
1111 (libmodest_dbus_client_search),
1112 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1113 instead of 1 second, because the search gets folders and messages from
1114 the server, which can take a long time. When it times out,
1115 osso-global-search will report no results.
1117 We need to specify whether we should search only cached information
1118 (maybe with a user preference), and the osso-email-search-plugin
1119 API should really be improved to allow that option, and to allow results
1120 to be delivered asynchronously in batches.
1122 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1124 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1125 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1126 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1128 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1130 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1131 that is an empty string. D-Bus seems to give us these instead of NULL.
1133 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1135 * src/dbus_api/modest-dbus-callbacks.c:
1136 * src/maemo/easysetup/modest-easysetup-wizard.h:
1137 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1138 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1139 (modest_connection_specific_smtp_edit_window_init):
1140 * src/maemo/modest-maemo-global-settings-dialog.c:
1142 * src/maemo/modest-maemo-utils.c:
1143 (modest_maemo_utils_setup_images_filechooser):
1144 * src/maemo/modest-main-window.c: (create_details_widget):
1145 * src/maemo/modest-msg-edit-window.c:
1146 (modest_msg_edit_window_attach_file_noninteractive),
1147 (modest_msg_edit_window_color_button_change),
1148 (modest_msg_edit_window_set_zoom):
1149 * src/modest-mail-operation.c: (update_account_thread):
1150 * src/modest-tny-account-store.c:
1151 * src/modest-tny-account.c:
1152 * src/widgets/modest-global-settings-dialog.c:
1153 * src/widgets/modest-window.h:
1155 Fixed build on bora!
1157 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1159 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1160 * src/modest-search.c: (modest_search_folder),
1161 (modest_search_all_accounts): Actually search only in the specified folder,
1162 doing a simple match on the folder ID.
1163 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1164 and added some documentation.
1166 2007-06-22 Armin Burgmeier <armin@openismus.com>
1168 * src/maemo/modest-maemo-utils.h:
1169 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1170 modest_maemo_utils_get_supported_secure_authentication_methods.
1172 * src/maemo/easysetup/modest-easysetup-wizard.c:
1173 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1174 one occured, not just "Server does not support secure authentication".
1176 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1178 * src/modest-tny-account-store.c: (get_password):
1179 Restored the call to tny_account_set_user() because Philip seems to have
1180 stopped this from crashing (by not using the freed string). It still does
1181 not work, but now we can test it.
1183 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1185 * src/maemo/modest-msg-edit-window.c: (init_window):
1186 Comment out use of an uninitialzed GtkScrolledWindow variable,
1187 to fix the build and stop a crash. Yet again.
1189 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1191 * src/modest-tny-account-store.c: (get_password):
1192 Remove the call to tny_account_set_user() because this actually crashes.
1193 As mentioned in the last commit, it is known to not work anyway.
1195 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-tny-account-store.c: (get_password):
1198 Use tny_account_set_username() to tell tinymail that the username might
1199 have changed too. But tinymail ignores this: see projects.maemo.org
1201 * src/modest-ui-actions.c:
1202 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1203 reset the connection when changing the username, and improve the comments.
1204 Save the changed username to gconf at least, so it is used when Modest is
1207 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1209 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1210 Do not use a query, so that we get all folders, including for POP and
1211 local-folders. They work as search criteria too.
1212 This fixes projects.maemo.org bug NB#57740.
1214 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1216 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1217 Comment out the use of hildon_notification_set_sound() because it is
1218 not declared, to fix the build. Warnings are serious, people.
1220 2007-06-21 Armin Burgmeier <armin@openismus.com>
1222 * src/maemo/modest-maemo-utils.h:
1223 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1224 modest_maemo_utils_get_supported_secure_authentication_methods()
1225 to query authentication methods for a specific user. This should fix
1226 projects.maemo.org bug NB#61369.
1228 * src/maemo/easysetup/modest-easysetup-wizard.c:
1229 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1232 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1234 * libmodest-dbus-client/libmodest-dbus-client.h:
1235 * libmodest-dbus-client/libmodest-dbus-client.c:
1236 (modest_dbus_message_iter_get_search_hit),
1237 (libmodest_dbus_client_search):
1238 Reorganised and commented this.
1239 Removed modest_search_hit_free() from the public API because it
1242 Added libmodest_dbus_client_get_folders() and
1243 modest_folder_result_list_free().
1245 * src/dbus_api/modest-dbus-api.h:
1246 * src/dbus_api/modest-dbus-callbacks.c:
1247 (modest_dbus_req_filter): Commented. Moved most code to
1248 on_dbus_method_search() and added on_dbus_method_get_folders().
1250 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1251 of the extra D-Bus handler.
1253 * tests/dbus_api/Makefile.am:
1254 * tests/dbus_api/test_get_folders.c: New test for
1255 libmodest_dbus_client_get_folders(). This seems to return an empty list
1256 at the moment. That could be the same error that causes the message list
1257 to be empty sometimes.
1258 This should help with projects.maemo.org bug NB#57740.
1260 2007-06-21 Armin Burgmeier <armin@openismus.com>
1262 * src/modest-mail-operation.c: Do not call
1263 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1264 notify the operation's end after having set the status to CANCELED for
1265 the operation queue to listen on. This fixes a deadlock when there
1266 were mail operations in the queue during its finalization.
1268 * src/modest-singletons.c: Reordered uninitialization of the account
1269 manager to happen after the mail operation queue was uninitialized
1270 because the mail operation's in the queue might still try to access
1271 the account manager (see modest_mail_operation_notify_end()). This
1272 fixes a potential crash when terminating the application.
1274 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1276 * src/modest-search.c:
1277 (search_mime_part_and_child_parts): Moved some code here so we
1278 can search recursively in child folders.
1279 (modest_search_folder): Search in the message as a mime part, instead
1280 of just its child mime parts.
1281 (read_chunk), (search_mime_part_ogs):
1282 Check how many bytes were read, to prevent an endless loop.
1283 Searching in message bodies now works. This finishes the fix for
1284 projects.maemo.org bug NB#61007.
1286 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1288 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1289 Add a g_warning when the item is not a folder.
1291 * src/modest-ui-dimming-rules.c:
1292 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1293 when selected item is not a folder (for instance, an account), because
1294 the UI spec only talks about folders.
1295 I am not sure what the UI spec wants, so this might not totally fix
1296 projects.maemo.org bug NB#60794.
1298 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1300 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1301 (load_from_file): Sort the list. The unsorted list would be more noticeable
1302 in non-English locales.
1304 * src/maemo/modest-msg-edit-window.c:
1305 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1306 warning and fix the build.
1308 * src/maemo/modest-progress-bar-widget.c:
1309 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1310 avoid a g_warning, and probably to avoid a crash.
1312 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1314 * src/modest-search.c: (modest_search_folder): Check for a GError
1315 when calling tny_folder_get_headers(), to show that this is not the cause
1318 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1320 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1321 Actually set the body query instead of the subject query.
1323 * src/modest-search.c: (search_mime_part_ogs),
1324 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1325 which would probably cause it to fail if we got this far.
1327 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1328 to simplify the code.
1329 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1330 be causing search-in-body to fail.
1332 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1334 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1336 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1337 Better debug message when the folder cannot be found.
1338 This should help with fixing projects.maemo.org bug #61287.
1339 * src/modest-search.c: (add_hit): Do not leak the furl string.
1341 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1343 * src/modest-ui-actions.c:
1344 (modest_ui_actions_on_folder_selection_changed):
1345 Do not special-case TNY_MERGE_FOLDER here, because
1346 modest_tny_folder_get_account() already does that. This fixes
1347 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1348 shown when the Outbox was selected).
1350 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1352 * libmodest-dbus-client/libmodest-dbus-client.c:
1353 (_dbus_iter_get_string_or_null): Initialize the string variable in
1354 case this helps with Dirk's crash.
1356 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1358 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1359 though it is not implemented yet (this function is maybe not even used),
1360 to avoid breaking ABI in future.
1361 * libmodest-dbus-client/libmodest-dbus-client.c:
1362 (get_attachments_string): Moved some code into this generic function.
1363 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1364 sends email. It is maybe not used.
1365 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1366 (on_send_mail): Use attachments.
1368 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1369 * src/maemo/modest-msg-edit-window.c:
1370 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1371 a filename before using it, to fix projects.maemo.org bug NB#58233.
1373 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1375 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1376 Initialize the continue_download variable to fix the build, and probably
1377 to fix randome behaviour.
1379 2007-06-18 Armin Burgmeier <armin@openismus.com>
1381 * src/modest-tny-send-queue.h:
1382 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1383 the queue so we can later show it in the UI. Replaced
1384 modest_tny_send_queue_msg_is_being_sent() by
1385 modest_tny_send_queue_get_msg_status().
1387 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1389 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1390 gpointer. This probably was not harmful, but just to be sure.
1392 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1394 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1395 Fix the build, but leave the function broken on Bora, because
1396 hildon_uri_action_get_service() does not exist.
1397 osso_uri_action_get_service() does not exist either, it seems.
1399 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-tny-account.c:
1402 (modest_tny_account_new_from_server_account):
1403 Uncommented the url debug output again, because it is useful for
1404 debugging, as I said in the comment.
1406 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1408 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1410 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1411 for Mameo Bora, to fix the build.
1413 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1416 Fixed build with hildon < 0.99
1418 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1419 Check if the selected account is busy instead of checking all accounts
1421 * src/modest-account-mgr-priv.h:
1422 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1423 (modest_account_mgr_init), (compare_account_name),
1424 (modest_account_mgr_set_account_busy),
1425 (modest_account_mgr_account_is_busy):
1426 * src/modest-account-mgr.h:
1427 Added busy information to the account manager. It possible to
1428 set an account to busy or not busy now.
1430 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1431 (modest_mail_operation_update_account),
1432 (modest_mail_operation_notify_end):
1433 Set the account to busy/not busy depending on the operation state.
1435 * src/widgets/modest-account-view.c:
1436 (modest_account_view_finalize), (get_last_updated_string),
1437 (update_account_view), (on_account_busy_changed), (init_view):
1438 Show string "Refreshing..." if the account is currently busy.
1440 All this fixes projects.maemo.org bug NB#59711
1442 2007-06-14 Armin Burgmeier <armin@openismus.com>
1444 * src/widgets/modest-attachments-view.h:
1445 * src/widgets/modest-attachments-view.c: Added
1446 modest_attachments_view_has_attachments() and fixed coordinate
1447 transformation in get_att_view_at_coords(). This fixes attachment
1450 * src/widgets/modest-msg-view.c: Make use of
1451 modest_attachments_view_has_attachments() to decide whether to show
1452 attachments in the header.
1454 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1456 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1457 (on_change), (on_combo_security_changed),
1458 (modest_connection_specific_smtp_edit_window_init),
1459 (modest_connection_specific_smtp_edit_window_set_connection),
1460 (modest_connection_specific_smtp_edit_window_is_dirty):
1461 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1462 * src/maemo/modest-connection-specific-smtp-window.c:
1465 Show an comfirmation dialog for the smpt-edit-window if there are
1466 unsaved changes and the user hits cancel.
1467 (projects.maemo.org bug NB#60479)
1469 2007-06-14 Armin Burgmeier <armin@openismus.com>
1471 * src/maemo/easysetup/modest-easysetup-wizard.c:
1472 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1473 address" info in banner instead of node, and select all the text as
1474 per UI spec. This fixes projects.maemo.org bug NB#60550.
1476 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1478 reviewed by: <delete if not using a buddy>
1480 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1481 * src/modest-ui-actions.c: (folder_refreshed_cb):
1483 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1485 * src/widgets/modest-folder-view.c: (filter_row):
1486 Explictly filter out the per-account outbox accounts. I don't know why
1487 these only sometimes show up, but now they should never show up in the UI.
1488 This should fix projects.maemo.org bug NB#60160.
1490 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1492 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1493 when the toolbar does not exist yet.
1494 * src/modest-widget-memory.c: (save_settings_header_view):
1495 Added g_warnings() to help us to discover when we are trying to set
1496 an empty columns list in gconf.
1498 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1500 * src/modest-init.h:
1501 * src/modest-init.c:
1502 Added modest_init_get_default_header_view_column_ids().
1504 * src/modest-widget-memory.c: (restore_settings_header_view):
1505 Use the new function to get defaults, if the gconf key is empty,
1506 instead of not creating any columns. This seems to fix the
1507 empty right-hand pane problems.
1509 * src/widgets/modest-header-view.h: Improved documentation.
1511 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1513 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1514 Revert the use of the display name as the account name, because this
1515 is generally wrong and would break the code that follows.
1517 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1519 * src/maemo/easysetup/modest-easysetup-wizard.c:
1520 (check_for_supported_auth_methods), (on_before_next),
1523 More correct fix for projects.maemo.org bug NB# 58991
1524 Do not longer accept AUTH_PASSWORD as secure method and choose
1525 correct method when creating the account.
1527 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1529 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1530 Fixed projects.maemo.org bug NB# 58991
1532 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1534 * src/modest-init.c: (modest_init_init_core),
1535 (modest_init_local_folders): Fixed compilation errors.
1537 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1539 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1540 Remove unnecessary lib/include, though it is good in principle when needed.
1542 * src/modest-init.c: (modest_init_one_local_folder),
1543 (modest_init_local_folders):
1544 * src/modest-init.h: Initialize the .modest library for memory cards,
1545 instead of just doing nothing for them. This should allow us to create
1546 folders there, fixing projects.maemo.org bug NB#59297.
1548 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1550 * libmodest-dbus-client/libmodest-dbus-client.c:
1551 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1552 (libmodest_dbus_client_compose_mail),
1553 (libmodest_dbus_client_open_message),
1554 (libmodest_dbus_client_send_and_receive),
1555 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1557 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1558 (on_idle_open_message), (modest_dbus_req_handler),
1559 (search_result_to_message), (modest_dbus_req_filter):
1560 * src/modest-search.c: (add_hit), (modest_search_folder),
1561 (modest_search_all_accounts): Improved debug messages.
1563 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1565 * src/modest-tny-account-store.c:
1566 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1569 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1572 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1574 * src/modest-tny-account-store.c: (get_server_accounts):
1575 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1576 even when there are no accounts, so that the Outbox folder is always
1577 visible. This fixes projects.maemo.org bug NB#60158.
1579 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1581 * src/maemo/modest-main-window.c: (create_details_widget):
1582 Use the mcen_va_never logical ID.
1584 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1586 * src/dbus_api/modest-dbus-api.h:
1587 * src/dbus_api/modest-dbus-callbacks.c:
1588 (on_idle_open_default_inbox), (on_open_default_inbox),
1589 (modest_dbus_req_handler):
1590 Added a new OpenDefaultInbox method.
1592 * libmodest-dbus-client/libmodest-dbus-client.h:
1593 * libmodest-dbus-client/libmodest-dbus-client.c:
1594 Added libmodest_dbus_client_open_default_inbox() to call the new
1595 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1596 though it should maybe be used by a new osso-email-interface function.
1598 * tests/dbus_api/Makefile.am:
1599 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1602 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1604 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1605 NULL, so that the signals get all the keys. This should not actually
1606 change any behaviour because we currently update everything when anything
1609 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1611 * src/widgets/modest-folder-view.c: (text_cell_data),
1612 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1613 (find_inbox_iter): If tinymail tells us that the folder is
1614 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1615 This causes the inbox to be selected at startup, fixing part of
1616 projects.maemo.org bug NB#56305.
1618 * src/modest-ui-dimming-rules.c:
1619 (modest_ui_dimming_rules_on_tools_smtp_servers):
1620 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1621 the SMTP servers menu item.
1622 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1623 that the SMTP Servers menu item is dimmed when there are no accounts,
1624 as a future version of the UI spec will require. This fixes
1625 projects.maemo.org bug NB#56305.
1627 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1629 * src/maemo/modest-maemo-utils.c:
1630 (modest_maemo_utils_get_supported_secure_authentication_methods):
1631 Added label to dialog instead of unreadable title
1633 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1634 (modest_main_window_new):
1635 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1638 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1639 * src/modest-account-mgr.h:
1640 Added method to avoid code duplication
1642 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1643 (modest_ui_actions_on_send_receive):
1644 Use modest_account_mgr_has_accounts
1646 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1648 * src/maemo/easysetup/modest-presets.c:
1649 (modest_presets_get_info_server_security): Do not report secure auth
1651 * src/modest-protocol-info.c: Use the defines for the gconf key names
1652 for secure authentication. This was not working because we were writing
1653 Password and reading password, and the check was case sensitive.
1654 With this, gmail now works for receiving and sending when created via
1657 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1659 * src/maemo/easysetup/modest-presets.c:
1660 (modest_presets_get_info_server_security): Correct the key name for
1661 SecureSmtp, because it seems to be case-sensitive.
1662 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1663 Do not try to get the 0th notebook page if there are 0 pages, to
1664 avoid a g_warning().
1666 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1668 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1669 Prevent use of the new notification feature for now, because it currently
1670 shows one dialog for each new email, which is annoying.
1672 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1674 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1675 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1676 when no country was selected, so that we show the global ones.
1677 * src/maemo/easysetup/modest-presets.c:
1678 (modest_presets_get_providers): Return only the global providers, not
1679 all providers when mmc=0 was requested.
1681 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1683 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1684 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1685 provider ID in the combo.
1687 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1688 Do not show the page numbers, because it would be confusing when we add
1689 the 2 extra pages for the custom setup, when the user chooses the "Other"
1690 provider. This fixes projects.maemo.org bug NB#59028
1692 * src/modest-init.c: (modest_init_init_core),
1693 (modest_init_local_folders):
1694 * src/modest-init.h:
1695 * src/modest-tny-account.c:
1696 (modest_tny_account_new_for_local_folders): Do not create default folders
1697 for the memory card. This should fix projects.maemo.org bug NB#59328.
1699 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1701 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1702 Free the changed_conf_keys string items. They are already freed in the
1703 idle handler if that runs first.
1705 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-ui-actions.c:
1708 (modest_ui_actions_on_password_requested): Check that the server name
1709 is not NULL, because I just saw a password dialog with (null) as the
1712 * src/modest-tny-folder.[h|c]: Added
1713 modest_tny_folder_is_memory_card_folder().
1714 * src/modest-ui-dimming-rules.c:
1715 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1716 menu item for memory cards, as per the UI spec (section 7.4). This should
1717 fix projects.maemo.org bug NB#59297.
1719 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1721 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1722 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1723 is another problem with the code, see Murray's comment at line 772)
1725 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1727 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1728 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1729 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1730 (load_from_file), (easysetup_country_combo_box_init),
1731 (easysetup_country_combo_box_get_active_country_ids),
1732 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1733 instead of just one ID, to avoid duplicate country names in the UI.
1735 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1736 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1737 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1738 a single ID, avoiding duplicate providers.
1739 * src/maemo/easysetup/modest-easysetup-wizard.c:
1740 (on_combo_account_country): Adapt to use a list.
1742 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1744 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1745 keys changed in the last X seconds.
1747 * src/modest-account-mgr.h:
1748 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1749 (on_key_change), (modest_account_mgr_class_init),
1750 (modest_account_mgr_init), (modest_account_mgr_finalize):
1751 As the keys are changed, save them in a GSList* and signal that GSList*
1752 further every X seconds, to batch changes, to allow us to do just one
1753 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1754 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1756 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1757 changed signal signature.
1759 * src/modest-conf.c: (modest_conf_set_list),
1760 (modest_conf_on_change): Reenable notification.
1762 (modest_conf_maemo_fake_on_change): Comment out the hack that
1763 notified immediately instead of asynchronously.
1765 * src/widgets/modest-account-view.h:
1766 * src/widgets/modest-account-view.c:
1767 (update_account_view): Select the previously-selected account ID,
1768 if possible. This fixes projects.maemo.org bug NB#56933.
1770 (on_account_changed), (on_account_removed),
1771 (modest_account_view_select_account):
1773 Remove the block/unblock functions
1774 because they were not useful.
1776 * src/maemo/modest-account-view-window.c:
1777 (on_delete_button_clicked), (on_edit_button_clicked),
1778 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1780 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1782 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1783 Improve the error dialog to show Incorrect Account Settings, which seems
1784 clearer, and say that the internal error message (to be removed from the
1785 dialog later) is often misleading.
1786 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1788 * src/modest-tny-account.c:
1789 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1790 URL because this is so useful for debugging on the device.
1792 * src/widgets/modest-serversecurity-combo-box.c:
1793 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1795 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1797 * src/modest-mail-operation.c:
1798 (modest_mail_operation_send_new_mail):
1799 Added a comment about a nasty but apparently harmless message. Details
1800 added to the wiki g_warnings() page.
1802 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1804 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1805 (modest_tny_send_queue_class_init):
1806 Do not use the priv struct because it is empty, to avoid g_warnings
1807 about a non-existant priv struct.
1809 * src/modest-tny-account-store.c:
1810 (modest_tny_account_store_get_server_account),
1811 (modest_tny_account_store_get_transport_account_for_open_connection
1812 ): Do not try to get transport server accounts for local folders,
1813 because they don't have any. This avoids a g_warning().
1815 * src/maemo/modest-main-window.c:
1816 (modest_main_window_notify_send_receive_initied),
1817 (on_configuration_key_changed):
1818 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1819 * src/modest-defs.h:
1820 * src/modest-mail-operation.c:
1821 (modest_mail_operation_update_account):
1822 * src/modest-tny-account-store.h:
1823 * src/modest-tny-account.c:
1824 (modest_tny_account_get_special_folder),
1825 (modest_tny_account_new_for_local_folders),
1826 (modest_tny_account_new_for_per_account_local_outbox_folder):
1827 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1828 * src/modest-tny-local-folders-account.c:
1829 (add_account_folders_to_merged_folder):
1830 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1831 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1832 (modest_ui_actions_on_send):
1833 * src/widgets/modest-folder-view.c: (update_model):
1834 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1835 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1836 modest_tny_account_store_get_tny_account_by_account() to
1837 modest_tny_account_store_get_server_account() to make the code clearer.
1839 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1841 * src/dbus_api/modest-dbus-api.h:
1842 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1843 * src/maemo/modest-msg-edit-window.c:
1844 (modest_msg_edit_window_attach_file_noninteractive):
1845 added g_warning in case the file to be attached does not exist
1846 * tests/dbus_api/test_compose_mail.c: (main):
1847 removed obsolete comment, added generic files as test case
1849 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1851 * src/modest-tny-account-store.c: (get_server_accounts):
1852 Create the local folders account only once, not once for each outbox, and
1853 not only when there are some outboxes.
1855 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1857 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1858 code that is causing a crash at startup. Sergio says that he is fixing this.
1860 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1862 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1863 * src/maemo/modest-account-settings-dialog.c:
1864 (create_page_outgoing),
1865 (modest_account_settings_dialog_set_account_name),
1866 (save_configuration):
1867 - Fixed handling of the "Use secure authentication" toggle to comply with
1868 the ui specification. See also projects.maemo.org bug NB#58400
1870 - Restore the Secure connection setting combo correctly when loading
1873 * src/maemo/modest-maemo-utils.c:
1874 (on_camel_account_get_supported_secure_authentication),
1875 (modest_maemo_utils_get_supported_secure_authentication_methods):
1876 Fixed a crasher if operation is canceled
1878 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1879 (modest_protocol_info_auth_is_secure):
1880 * src/modest-protocol-info.h:
1882 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1883 the sense of the "Use secure authentication" toggle.
1885 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1887 * src/modest-tny-account-store.h:
1888 * src/modest-tny-account-store.c:
1889 Added modest_tny_account_store_get_local_folders_account().
1891 * src/modest-tny-folder.h:
1892 * src/modest-tny-folder.c:
1893 (modest_tny_folder_get_account):
1894 Added this replacement for tny_folder_get_account() which returns
1895 the local-folders account for TnyMergeFolders, to avoid the
1896 warning about the unimplemented get_account_func() vfunc().
1898 (modest_tny_folder_get_rules),
1899 * src/modest-ui-actions.c:
1900 (modest_ui_actions_on_folder_selection_changed):
1901 * src/modest-mail-operation.c:
1902 (modest_mail_operation_remove_folder),
1903 (modest_mail_operation_xfer_folder),
1904 (modest_mail_operation_rename_folder),
1905 (modest_mail_operation_get_msg),
1906 (modest_mail_operation_get_msgs_full),
1907 (modest_mail_operation_remove_msg),
1908 (modest_mail_operation_xfer_msgs),
1909 (modest_mail_operation_refresh_folder):
1910 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1912 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1914 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1915 (modest_server_account_set_security):
1916 * src/modest-defs.h: Add comments explaining that our
1917 UI spec means TLS when it says Normal, so these do not look like errors.
1919 * src/modest-tny-account.c:
1920 (modest_tny_account_new_from_server_account): Use the new tinymail
1921 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1922 for TLS. This should fix projects.maemo.org bug NB#58460.
1924 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/easysetup/modest-easysetup-wizard.c:
1927 (create_account): Correct the position of the gconf sanity check warning.
1928 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1929 of using the g_idle_add() hack, because this does not seem to be necessary
1930 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1931 caused by something other than maemo's gconf.
1932 This fixes projects.maemo.org bug #59022.
1934 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-account-mgr-helpers.c:
1937 (modest_account_mgr_get_default_account): Do not check that the account
1938 exists if there is no default account (NULL), to fix a runtime warning.
1940 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1942 * src/widgets/modest-folder-view.c: (update_model):
1943 Do not unref the treemodel before we have finished with it.
1944 This prevents a valgrind warning and an occasional crash at startup.
1946 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1948 * libmodest-dbus-client/libmodest-dbus-client.h:
1949 added libmodest_dbus_client_compose_mail()
1950 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1952 added functions needed for SendAsMail() functionality
1953 * src/maemo/modest-msg-edit-window.c:
1954 (modest_msg_edit_window_attach_file_noninteractive):
1955 non interactively attaching files to message edit window
1956 * src/widgets/modest-msg-edit-window.h:
1957 * tests/dbus_api/Makefile.am:
1958 added test_compose_mail.c
1959 * tests/dbus_api/test_compose_mail.c: (main):
1961 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1963 * src/modest-account-view.c:
1964 Fixed bug projects.maemo.org bug NB#59307
1966 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1968 * src/maemo/easysetup/modest-easysetup-wizard.c:
1969 (get_serverport_incoming), (on_before_next), (create_account):
1970 * src/maemo/modest-account-settings-dialog.c:
1971 (modest_account_settings_dialog_set_account_name):
1972 * src/maemo/modest-maemo-utils.c:
1973 (on_camel_account_get_supported_secure_authentication_status),
1974 (on_camel_account_get_supported_secure_authentication),
1975 (on_secure_auth_cancel),
1976 (modest_maemo_utils_get_supported_secure_authentication_methods):
1978 Implemented security authentication for settings and easysetup.
1980 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/modest-main-window.c: (create_details_widget):
1983 Show the total size for memory card accounts too, instead of showing
1984 the name again. Fixes bug projects.maemo.org bug NB#59307.
1986 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1989 * src/modest-tny-simple-folder-store.c:
1990 * src/modest-tny-simple-folder-store.h: Removed.
1992 * src/modest-tny-local-folders-account.h
1993 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1994 for the local-folders maildir, with an extra TnyMergedFolder containing
1995 the folders of the per-account outbox store accounts.
1996 * src/modest-tny-account-store.c: (get_server_accounts):
1997 Add the outboxes to the special local folders account after creating it.
1999 * src/modest-tny-account.c:
2000 (modest_tny_account_new_for_local_folders): Create the derived
2001 account when creating the main local-folders account.
2003 * src/maemo/modest-main-window.c: (create_details_widget),
2004 (modest_main_window_set_contents_style):
2005 Adapted to the use of the derived account instead of the folder store.
2007 * src/modest-ui-actions.c:
2008 (modest_ui_actions_on_folder_selection_changed):
2009 * src/modest-ui-dimming-rules.c:
2010 (modest_ui_dimming_rules_on_new_folder):
2011 * src/widgets/modest-folder-view.c: (text_cell_data),
2012 (icon_cell_data), (filter_row), (update_model),
2013 (get_cmp_rows_type_pos):
2016 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2017 Do not get the priv struct, because no priv struct has been set,
2018 to avoid a runtime warning.
2020 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2021 #ifelse with #else, to fix a warning, to fix the build.
2024 2007-06-05 Christian Kellner <ckellner@openismus.com>
2026 * libmodest-dbus-client/libmodest-dbus-client.c:
2027 Fix small typo in doc (why do you always see them
2028 AFTER committing stuff?)
2031 2007-06-05 Christian Kellner <ckellner@openismus.com>
2033 * libmodest-dbus-client/libmodest-dbus-client.c:
2034 (libmodest_dbus_client_search):
2035 Initialize hit list with NULL. Also set folder list
2036 to "" if NULL was supplied.
2039 2007-06-03 Christian Kellner <ckellner@openismus.com>
2041 * libmodest-dbus-client/libmodest-dbus-client.c:
2042 (modest_search_hit_list_free):
2043 Make it save to call it with NULL.
2045 * src/dbus_api/modest-dbus-callbacks.c:
2046 * src/modest-search.c:
2047 Return full ModestSearchHits as the search result list not TnyHeader
2048 since can't be around withouth the correspoding TnyFolder.
2050 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2052 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2053 Added currently commented code to check for secure auth
2055 * src/maemo/modest-account-settings-dialog.c: (on_response),
2056 (save_configuration), (show_ok):
2057 Fixed projects.maemo.org bugs NB #59248 and #59251
2059 * src/maemo/modest-maemo-utils.c:
2060 (on_camel_account_get_supported_secure_authentication_status),
2061 (on_camel_account_get_supported_secure_authentication),
2062 (modest_maemo_utils_get_supported_secure_authentication_methods):
2063 * src/maemo/modest-maemo-utils.h:
2064 Moved get_supported_secure_authentication() method here to be able
2065 to use it from easysetup wizard.
2067 * src/modest-pair.c: (on_pair_compare_as_string):
2068 Should compare string with first part of pair and not
2069 strcmp pairs which will crash.
2071 * src/modest-protocol-info.c:
2072 (modest_protocol_info_protocol_is_store):
2073 * src/modest-protocol-info.h:
2074 Added modest_protocol_info_get_auth_protocol_name()
2076 2007-06-03 Armin Burgmeier <armin@openismus.com>
2078 * src/modest-mail-operation.c:
2079 (modest_mail_operation_get_msgs_full): Set priv->account also when
2080 only retrieving a single message. This avoids a crash when canceling
2083 (modest_mail_operation_notify_end): Do not explicitely remove the
2084 operation from the queue but only emit the progress_changed signal.
2085 The queue itself listens to that signal to remove the operation when
2086 it is finished. This reduces coupling and removes a potential deadlock
2087 when modest_mail_operation_notify_end() is called from the queue
2088 itself. If that is a problem performance-wise, I would suggest to
2089 implement a status-changed signal or something.
2091 * src/modest-mail-operation-queue.c: Make sure to never call a
2092 function from another file while the queue is locked. This (hopefully)
2093 fixes another deadlock when exiting the application while retrieving
2096 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2098 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2099 Fixed build if libogs is not available
2101 2007-06-03 Christian Kellner <ckellner@openismus.com>
2103 * libmodest-dbus-client/libmodest-dbus-client.h:
2104 * libmodest-dbus-client/libmodest-dbus-client.c:
2105 (libmodest_dbus_client_delete_message):
2106 Implement deletion of messages (Client side).
2108 (modest_search_hit_free),
2109 (modest_search_hit_list_free):
2110 Utility functions to free the result hits.
2112 * src/dbus_api/modest-dbus-api.h:
2113 * src/dbus_api/modest-dbus-callbacks.c:
2114 (on_delete_message),
2115 (modest_dbus_req_handler):
2116 Implement deletion of messages (Server side).
2118 * tests/dbus_api/test_search.c: (main):
2121 * tests/dbus_api/Makefile.am:
2122 * tests/dbus_api/test_delete_message:
2123 Add little test for the message deletion logic
2125 2007-06-03 Armin Burgmeier <armin@openismus.com>
2127 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2128 when the operation queue was not empty. projects.maemo.org bug
2131 2007-06-03 Armin Burgmeier <armin@openismus.com>
2133 * src/widgets/modest-account-view.c
2134 (on_account_default_toggled): Toggle default account column
2135 explicitely instead of waiting for gconf notification (which is
2136 currently ignored). This should fix projects.maemo.org bug NB#56910
2137 for now. It should probably be removed when gconf notifications are
2140 2007-06-03 Christian Kellner <ckellner@openismus.com>
2142 * libmodest-dbus-client/libmodest-dbus-client.c:
2143 Removed debugging spew.
2145 * src/dbus_api/modest-dbus-callbacks.c:
2146 Added debugging info.
2148 * src/modest-search.c:
2149 (modest_search_all_accounts):
2150 Use tny_account_store_get_accounts () on the account store
2151 to get all accounts which is the way to get all accounts.
2153 * tests/dbus_api/test_search.c: (main):
2154 Make it possible to supply the search term on the command line.
2156 2007-06-03 Christian Kellner <ckellner@openismus.com>
2158 * libmodest-dbus-client/libmodest-dbus-client.c:
2159 * libmodest-dbus-client/libmodest-dbus-client.h:
2160 Implement searching for mesages over raw dbus. (Client side)
2162 * src/dbus_api/Makefile.am:
2163 * src/dbus_api/modest-dbus-api.h:
2164 * src/dbus_api/modest-dbus-callbacks.c:
2165 * src/dbus_api/modest-dbus-callbacks.h:
2166 Search framework (Server side). Also implement on_idle_open_message().
2168 * src/maemo/modest-platform.c: (modest_platform_init):
2169 Prepare for raw dbus/osso rpc interaction.
2171 * src/modest-search.h:
2172 Changed minsize from unspecific guint to guint32.
2174 * src/modest-search.c:
2176 Added strange hack which magically made tnymail work.
2178 (modest_search_folder),
2179 (modest_search_account),
2180 (modest_search_all_accounts):
2181 Implement helper functions to search all accounts, specific account
2184 * tests/dbus_api/Makefile.am:
2185 * tests/dbus_api/test_open_message.c:
2186 Read url to open from commandline.
2188 * tests/dbus_api/test_search.c:
2189 Implement small test for dbus search stuff
2191 2007-06-02 Armin Burgmeier <armin@openismus.com>
2193 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2194 include account type and account title. This fixes projects.maemo.org
2197 * src/maemo/modest-account-view-window.c: Set a title for the window.
2199 2007-06-02 Armin Burgmeier <armin@openismus.com>
2201 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2202 incoming and outgoing server name based on email address and server
2203 types as long as the names have not been edited manually. This fixes
2204 projects.maemo.org bug NB#58671.
2206 2007-06-02 Armin Burgmeier <armin@openismus.com>
2208 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2209 server type cannot be changed in future to the incoming details page
2210 when creating an account. This fixes projects.maemo.org bug NB#59029.
2212 2007-06-02 Armin Burgmeier <armin@openismus.com>
2214 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2215 and assigned max width chars so that they wrap instead of being
2216 truncated. Fixes projects.maemo.org bug NB#56126.
2218 2007-06-02 Armin Burgmeier <armin@openismus.com>
2220 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2221 introductory note to the connection specific smtp servers dialog, as
2222 section 8.12 of the email UI specification requires. This fixes
2223 projects.maemo.org bug NB#59212.
2225 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2227 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2228 Check for running mail operations, and offer to cancel them, as per the UI
2229 spec. This fixes projects.maemo.org bug NB#59041 .
2230 However, I suspect that tinymail may still use the network connection
2231 in ways that we cannot detect or cancel. But it should at least adapt to
2232 changes fairly well.
2234 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2236 * src/modest-tny-account-store.c: (recreate_all_accounts),
2237 (get_cached_accounts), (get_server_accounts): Do more sensible
2238 ref-counting of the temporarily-cached outbox accounts list. This seems
2239 to fix a crash when entering the password when the password was wrong.
2241 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2243 * src/gnome/modest-main-window.c: (connect_signals):
2244 * src/modest-tny-account-store.c: (get_password),
2245 (modest_tny_account_store_alert): Added comments and clues and
2246 commented-out code about how we currently fail to deal with connection
2247 errors and wrong passwords, and how we should.
2249 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2251 * src/widgets/modest-retrieve-combo-box.c:
2252 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2253 This fixes projects.maemo.org bug NB#58472 .
2255 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2257 * src/maemo/easysetup/modest-easysetup-wizard.c:
2258 (create_page_complete_easysetup):
2259 (create_page_complete_custom): Correct the last commit,
2260 putting the correct sentences in the correct pages.
2262 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2264 * src/maemo/easysetup/modest-easysetup-wizard.c:
2265 (create_page_complete_custom): Show the second sentence of text
2266 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2269 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2271 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2272 Set the leave-on-server conf key by default. This fixes
2273 projects.maemo.org bug NB#59258 .
2275 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2277 * src/maemo/modest-account-view-window.c:
2278 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2279 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2282 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2284 * src/maemo/easysetup/modest-easysetup-wizard.c:
2285 (create_caption_new_with_asterisk):
2286 * src/maemo/modest-account-settings-dialog.c:
2287 (create_caption_new_with_asterisk):
2288 Uncomment the code to add the asterisk, because they are no longer in the
2289 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2290 (update_incoming_server_title): Add an asterisk here too.
2292 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2294 * src/maemo/modest-maemo-global-settings-dialog.c:
2295 (current_connection): Check that we are even connected before trying to
2296 get the current connection name, to prevent a warning.
2298 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2299 Change the comments because tny_maemo_conic_device_connect() is now meant to
2301 * src/modest-mail-operation.c:
2302 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2303 make sure we have a connection and fail if we can't connect.
2305 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/modest-main-window.c:
2308 (on_account_store_connecting_finished): Do not try to get the
2309 connection ID if we are not really connected. I am surprised that
2310 this signal handler is called when we are not connected.
2312 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2314 * src/modest-error.h:
2315 * src/modest-ui-actions.c:
2316 (modest_ui_actions_get_msgs_full_error_handler):
2317 Renamed an enum, added comments, added an enum
2318 for retrieve-limit errors.
2320 * src/modest-mail-operation.c: (foreach_add_item),
2321 (internal_folder_observer_update), (update_account_thread),
2322 (modest_mail_operation_get_msgs_full):
2323 (modest_mail_operation_update_account),
2324 Added comments about how this works, and some code that should
2325 (but does not) check the retrieve-limit. See the TODO comment.
2327 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2329 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2330 Initialize help_id to fix the build. Warnings are good.
2332 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2334 * src/widgets/modest-hbox-cell-renderer.c:
2335 (modest_hbox_cell_renderer_append):
2336 * src/widgets/modest-vbox-cell-renderer.c:
2337 (modest_vbox_cell_renderer_append):
2338 Fix the last commit by doing an extra ref.
2340 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2342 * src/widgets/modest-hbox-cell-renderer.c:
2343 (modest_hbox_cell_renderer_append):
2344 * src/widgets/modest-vbox-cell-renderer.c:
2345 (modest_vbox_cell_renderer_append):
2346 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2347 to fix the build with Maemo Bora.
2348 However, there seems to be a remaining crash, probably due to reference
2351 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2353 * src/modest-tny-account.c:
2354 (modest_tny_account_new_for_local_folders):
2355 Use hildon_file_system_info_async_new() to get a better name for
2356 the memory card account, setting it as the account name.
2357 The timing seems to work, but this is probably
2358 not the best place to do this. See the TODO comment.
2359 * src/maemo/modest-main-window.c: (create_details_widget):
2360 * src/widgets/modest-folder-view.c: (text_cell_data):
2361 Use the tny account name instead of hardcoding a name.
2363 2007-05-30 Christian Kellner <ckellner@openismus.com>
2365 * src/modest-search.c: (modest_search):
2366 Correctly set part_search_func even if we have already parsed
2367 the query and thus a valid OgsTextSearcher object.
2369 2007-05-30 Christian Kellner <ckellner@openismus.com>
2372 Search and check for libogs.
2375 Incooparte the ogs build env.
2377 * src/modest-mime-part-search-stream.c:
2378 * src/modest-mime-part-search-stream.h:
2379 Removed since we do the real searching now in modest-search.c.
2381 * src/modest-search.c:
2382 * src/modest-search.h:
2383 Implement support for ogs. We use that if available and requested
2384 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2385 should now handle the corner case when the search term is spread
2386 across multiple reads.
2387 Also the logic in modest_search () was corrected to search all
2388 requested fields until one is found.
2390 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2392 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2394 * src/modest-init.h:
2395 * src/modest-init.c: Made modest_init_local_folders() take a
2396 path and be public so we can iniitialize maildir folders on
2399 * src/modest-local-folder-info.h:
2400 * src/modest-local-folder-info.c:
2401 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2403 * src/modest-tny-account.c:
2404 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2405 still means the standard local-folders path on the local volume.
2407 * src/modest-tny-account-store.c:
2408 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2409 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2410 all accounts when that happens.
2411 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2412 this too, so it shows up in the treeview.
2414 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2416 * src/maemo/modest-maemo-global-settings-dialog.c:
2417 (current_connection):
2418 * src/widgets/modest-global-settings-dialog.c:
2419 (current_connection_default):
2420 Use the enum values instead of 0, 1 and -1,
2421 to make the code clearer.
2423 * src/modest-account-mgr-helpers.c:
2424 (modest_account_mgr_get_connection_specific_smtp): Make this code
2427 * src/modest-runtime.h:
2428 * src/modest-runtime.c:
2429 Added modest_runtime_remove_all_send_queues().
2430 * src/maemo/modest-main-window.c:
2431 (on_account_store_connecting_finished): Recreate the send queues,
2432 using the appropriate transport accounts for this new connection.
2433 Some futher adapting might be needed if the old send queues are not
2434 automatically stopped at this point.
2436 * src/modest-tny-account-store.c: (get_server_accounts):
2437 Create the connection-specific transport accounts, so that they can
2438 be found later by their ID.
2440 * src/modest-tny-account.h:
2441 * src/modest-tny-account.c:
2442 Added modest_tny_account_new_from_server_account_name().
2443 modest_tny_account_new_from_server_account(): Do not create the
2444 send queues here, because they will be
2445 recreated anyway when the connection changes for the first time.
2447 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2449 * src/modest-local-folder-info.h:
2450 * src/modest-local-folder-info.c:
2451 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2452 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2453 tbox_folder): Take a modest account name instead of a server TnyAccount,
2454 so we can have per-modest-account rather than per-transport-account
2456 We must make sure that we change or recreate the exisitng send queues
2457 when the connection changes for connection-specific transport accounts.
2459 * src/modest-tny-account-store.c:
2460 (create_per_account_local_outbox_folders): Create outboxed per modest
2461 account, not per transport account.
2463 * src/modest-tny-account.h:
2464 * src/modest-tny-account.c:
2465 (modest_tny_account_get_special_folder): For outboxes, get the
2466 parent modest account name. The account is ignored for other folders.
2467 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2468 modest account name rather than a server TnyAccount.
2470 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2472 * src/modest-tny-account.c:
2473 (modest_tny_account_new_from_server_account):
2474 Call modest_runtime_get_send_queue() immediately after creating transport
2475 accounts, so that they start trying to send email from the outbox as soon
2476 as possible at startup. This is probably what we want.
2478 * src/modest-mail-operation.c: (update_account_thread):
2479 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2480 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2481 * src/modest-tny-send-queue.h:
2482 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2483 (modest_ui_actions_on_send):
2484 Added comments about how sending works, though it needs some more work.
2486 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2488 * src/modest-tny-account.c:
2489 (modest_tny_account_get_special_folder): Add TODO because this fails when
2490 the network is busy.
2491 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2492 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2493 Do not try to show this window when there is no active account. The UI
2494 specs does not tell us what to do in this case.
2496 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2500 * src/maemo/Makefile.am:
2501 * src/widgets/Makefile.am: Some dist fixes.
2503 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2505 * src/maemo/modest-connection-specific-smtp-window.c:
2506 (on_button_edit): Make the code clearer, to prevent a double free.
2508 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2510 * src/maemo/modest-account-settings-dialog.c:
2511 (modest_account_settings_dialog_set_account_name),
2512 Check the connection-specific smtp servers checkbox if there are any.
2514 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2515 (modest_connection_specific_smtp_edit_window_init):
2516 Start with a suitable port number.
2518 * src/modest-account-mgr-helpers.h:
2519 * src/modest-account-mgr-helpers.c: Added
2520 modest_account_mgr_get_has_connection_specific_smtp().
2522 (modest_account_mgr_set_connection_specific_smtp),
2523 (modest_account_mgr_remove_connection_specific_smtp),
2524 (modest_account_mgr_get_has_connection_specific_smtp),
2525 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2526 connection-specific smtp server accounts in the account, rather than
2527 the server account conf dir.
2529 This fixes bug projects.maemo.org bug NB#58263 .
2531 * src/modest-tny-account-store.c:
2532 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2533 if there are no server accounts yet, to prevent an infinite loop when there
2534 are no accounts. Document that one must be called before the other.
2536 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2538 * src/modest-account-mgr-helpers.c:
2539 (modest_account_mgr_get_default_account): Make sure that at least
2540 one account is always the default, if there are any enabled accounts.
2541 This is just a sanity check that shouldn't be necessary.
2543 * src/modest-account-mgr-priv.c:
2544 (_modest_account_mgr_account_from_key): Unescape the conf key to
2545 get the real account name. For instance, this is an issue if a space
2546 was in the account name, which can happen because the account name
2547 is generated from the display name.
2548 (_modest_account_mgr_get_account_keyname): Always escape the
2550 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2551 Unescape the conf keys to get the real account names.
2553 For instance, previously the is-default radio button in the accounts
2554 list was not checked for any accounts at first. This fixes that,
2555 and might fix several similar bugs.
2557 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2559 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2560 Removed some debug printfs.
2562 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2564 Modest on-disk outbox directories are now here, for instance:
2565 $HOME/.modest/outboxes/<account-id-1>/outbox
2566 $HOME/.modest/outboxes/<account-id-2>/outbox
2568 $HOME/.modest/local-folders/outbox
2569 so we can have a separate outbox for each account.
2570 But they are shown as one outbox in the GtkTreeView, by using a
2571 TnyMergeFolder in a ModestTnySimpleFolderStore.
2574 * src/modest-tny-simple-folder-store.c:
2575 * src/modest-tny-simple-folder-store.h:
2576 Added ModestTnySimpleFolderStore, used to contain folders from
2577 other folder stores, such as other accounts.
2579 * src/modest-tny-outbox-account.h:
2580 * src/modest-tny-outbox-account.c:
2581 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2582 used for the per-account local outbox folders.
2584 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2585 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2586 only use this (internally) now for the non-outbox local folders.
2588 * src/modest-init.h:
2589 * src/modest-init.c: Added modest_init_one_local_folder(), for
2590 setting up the directory structure for each local folder.
2592 * src/modest-local-folder-info.c:
2593 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2594 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2596 * src/modest-local-folder-info.h:
2597 * src/modest-tny-account-store.c: (on_account_removed),
2598 (on_account_changed), (create_per_account_local_outbox_folders),
2599 (get_server_accounts), (modest_tny_account_store_get_accounts),
2600 (modest_tny_account_store_get_tny_account_by_account),
2601 (modest_tny_folder_store_is_virtual_local_folders):
2603 * src/modest-tny-account.h:
2604 * src/modest-tny-account.c:
2605 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2606 to create an on-disk per-account local outbox folder for each
2608 (create_per_account_local_outbox_folders): Create a local outbox folder
2609 for each transport account.
2610 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2611 for all local folders.
2613 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2614 instead of using g_object_get/set() directly. It is clearer.
2616 (modest_tny_folder_store_get_message_count),
2617 (modest_tny_folder_store_get_local_size
2618 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2619 because we now use these with non-acount folder stores.
2621 (modest_tny_account_get_special_folder),
2622 (modest_tny_account_new_from_server_account),
2623 (modest_tny_account_new_from_account):
2624 (recurse_folders): Adjust to the new outbox system.
2626 * src/modest-tny-folder.h:
2627 * src/modest-tny-folder.c:
2628 (modest_tny_folder_is_local_folder),
2629 (modest_tny_folder_get_local_folder_type),
2630 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2632 * src/widgets/modest-main-window.h:
2633 * src/maemo/modest-main-window.c: (create_details_widget),
2634 (modest_main_window_set_contents_style): Show details for any folder store,
2637 (modest_tny_folder_get_rules):
2638 Remove the const. C does not support constness enough for this.
2640 * src/modest-ui-actions.c:
2641 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2642 make all outboxes appear as one, in the usual local-folders tree node.
2644 (set_active_account_from_tny_account),
2645 (modest_ui_actions_on_folder_selection_changed):
2646 * src/widgets/modest-folder-view.c: (text_cell_data),
2647 (icon_cell_data), (filter_row),
2648 (add_account_folders_to_merged_folder),
2649 (add_account_folders_to_simple_folder_store), (),
2650 (get_cmp_rows_type_pos), (cmp_rows),
2651 (modest_folder_view_set_account_id_of_visible_server_account):
2652 Adjust to the new outbox system, using generic folder stores and folders
2653 in the GtkTreeModel.
2655 2007-05-23 Christian Kellner <ckellner@openismus.com>
2657 * src/modest-mail-operation.c:
2658 (modest_mail_operation_update_account):
2659 Use info->max_size instead of unintialized local var [small
2660 build fix]. (Added TODO to review that change since I don't
2663 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2665 * libmodest-dbus-client/libmodest-dbus-client.c:
2666 (libmodest_dbus_client_compose_mail): function added
2667 * src/dbus_api/modest-dbus-api.h:
2668 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2669 (on_compose_mail): Implementation of the SendAsMail functionality
2671 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2673 * src/modest-account-mgr.c:
2674 (modest_account_mgr_add_server_account): Set the secure-connection
2675 conf key for transport accounts as well as store accounts. I don't know
2676 why the if was there. For instance, this makes sure that we use SSL
2677 for the gmail preset from the easysetup wizard.
2679 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2681 * src/gnome/modest-main-window.c:
2682 (on_account_store_connecting_finished), (connect_signals):
2683 * src/maemo/modest-main-window.c:
2684 (on_account_store_connecting_finished), (connect_signals),
2685 (modest_main_window_new):
2686 Handle TnyAccountStore::connecting-finished instead of
2687 TnyDevice::connection-changed, because we cannot actually perform
2688 operations on accounts until TnyAccountStore has itself responded to
2689 the TnyDevice::connection-changed signal. This prevents a GError from
2691 Do not try to update at startup, because we (at least on scratchbox)
2692 already do an update at startup when the device goes online.
2693 This prevents a GError from tinymail.
2694 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2695 Added TODO about stopping simultaneous operations.
2697 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2699 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2700 * src/modest-mail-operation-queue.c:
2701 (modest_mail_operation_queue_remove):
2702 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2703 about where they happened.
2705 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2707 * src/modest-ui-actions.c:
2708 (modest_ui_actions_on_password_requested): Make sure that the remember
2709 output parameter is always TRUE.
2711 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2713 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2714 Show a OK/Cancel dialog if the error is a question, though we still do not
2715 know anything more about what we are asking the user.
2716 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2717 Fix an uninitialized variable (helper). This is a logic error, however.
2719 2007-05-21 Christian Kellner <ckellner@openismus.com>
2721 * src/modest-search.h:
2722 Correct bit shifting in the ModestSearchFlags enum.
2724 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2726 * src/modest-tny-account.c:
2727 (modest_tny_account_new_from_server_account): Do not use the lsub and
2728 check-all hard-coded IMAP options when using POP.
2730 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2732 * src/modest-tny-account.c:
2733 (modest_tny_account_new_from_server_account):
2734 Use NULL for the secure-auth method for POP when Password auth has been
2735 specified by the user, as we already do for IMAP. "auth=Login" causes
2736 an error from camel or the server.
2738 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2740 * src/maemo/modest-account-settings-dialog.c:
2741 (create_page_account_details),
2742 (modest_account_settings_dialog_set_account_name):
2743 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2744 for the leave-on-server checkbox, rathr than just the checkbox, when
2745 the protocol is not POP.
2747 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2749 * src/widgets/modest-account-view.c:
2750 * src/widgets/modest-account-view.h:
2751 Added modest_account_view_select_account() which will be useful later
2752 to asynchronously re-select the edited account.
2754 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2756 * src/maemo/modest-account-settings-dialog.c:
2757 (modest_account_settings_dialog_set_account_name):
2758 Automatically choose the port numbers based on the secure authentication
2759 methods, if they have not been chosen before.
2760 This fixes projects.maemo.org bug NB#56273 .
2762 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2764 * src/maemo/modest-main-window-ui.h:
2765 * src/modest-ui-actions.c:
2766 * src/modest-ui-actions.h:
2767 Connect the Tools/SMTP Servers menu item to
2768 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2769 SMTP servers dialog, as in the UI specification and saves changes when it
2770 is closed. This fixed projects.maemo.org bug NB#56305 .
2772 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2774 * src/maemo/modest-connection-specific-smtp-window.c:
2775 (modest_connection_specific_smtp_window_init):
2776 Use gtk_window_set_default_size() to make this window big enough, so
2777 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2779 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2782 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2783 (modest_connection_specific_smtp_edit_window_init),
2784 Do not try to connect to a combobox signal before the combobox exists.
2785 This fixes the cras in projects.maemo.org bug NB#56288 .
2786 (modest_connection_specific_smtp_edit_window_get_settings):
2787 Remove the server_account_name parameter which was being checked for NULL
2788 though it was not used.
2790 * src/maemo/modest-connection-specific-smtp-window.c:
2791 (modest_connection_specific_smtp_window_fill_with_connections),
2792 (on_button_edit), (modest_connection_specific_smtp_window_init):
2793 Correct the number of treemodel columns to prevent a warning.
2794 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2795 libconic does not work.
2797 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2799 * src/modest-tny-account.c:
2800 (modest_tny_account_new_from_server_account):
2801 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2802 SMTP when "None" was chosen by the user. However, with my SMTP server that
2803 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2806 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2808 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2809 to explain the memory management issue with the ID in the ModestPair.
2811 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2812 (add_sending_page), (modest_account_assistant_finalize):
2813 * src/gnome/modest-gnome-global-settings-dialog.c:
2814 (create_updating_page), (create_composing_page):
2815 * src/gnome/modest-msg-edit-window.c: (get_transports),
2816 (init_window), (modest_msg_edit_window_finalize),
2817 (modest_msg_edit_window_get_msg_data):
2818 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2819 * src/gnome/modest-transport-widget.c:
2820 (modest_transport_widget_finalize), (smtp_configuration):
2821 * src/maemo/modest-maemo-global-settings-dialog.c:
2822 (create_updating_page), (create_composing_page):
2823 * src/maemo/modest-msg-edit-window.c: (get_transports),
2824 (init_window), (modest_msg_edit_window_finalize),
2825 (modest_msg_edit_window_get_msg_data),
2826 (modest_msg_edit_window_free_msg_data):
2827 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2828 (modest_store_widget_finalize):
2829 * src/maemo/modest-transport-widget.c:
2830 (modest_transport_widget_finalize), (smtp_configuration):
2831 * src/modest-main.c: (send_mail):
2832 * src/widgets/modest-combo-box.h:
2833 * src/widgets/modest-global-settings-dialog-priv.h:
2834 * src/widgets/modest-global-settings-dialog.c:
2835 (modest_global_settings_dialog_finalize):
2836 * src/widgets/modest-msg-edit-window.h:
2837 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2838 as long as the combo box, to prevent use of freed memory for the ID.
2840 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2842 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2843 get_accounts(), to make this clearer. Do not check for the enabled gconf
2844 key, because we do not use this for server accounts (at least, not yet).
2845 This allows us to send email again.
2847 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2849 * src/maemo/modest-platform.c:
2850 (on_modest_conf_update_interval_changed), (modest_platform_init):
2851 Only respond to this particular key change. All these strcmp()s cannot be
2854 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2856 * src/maemo/modest-maemo-global-settings-dialog.c:
2857 (current_connection): Prevent a crash in scratchbox when
2858 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2859 * src/maemo/modest-platform.c:
2860 (on_modest_conf_update_interval_changed), (modest_platform_init):
2861 Get the update interval from gconf and reset it when the gconf key changes.
2863 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2865 * src/modest-protocol-info.c:
2866 * src/modest-protocol-info.h: Adde enum-specific get functions,
2867 instead of using a ModestProtocolType enum parameter.
2869 * src/gnome/modest-account-assistant.c:
2870 * src/gnome/modest-store-widget.c:
2871 * src/gnome/modest-store-widget.h:
2872 * src/gnome/modest-transport-widget.c:
2873 * src/gnome/modest-transport-widget.h:
2874 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2875 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2876 * src/maemo/easysetup/modest-easysetup-wizard.c:
2877 * src/maemo/modest-account-settings-dialog.c:
2878 * src/maemo/modest-account-settings-dialog.h:
2879 * src/maemo/modest-store-widget.c:
2880 * src/maemo/modest-store-widget.h:
2881 * src/maemo/modest-transport-widget.c:
2882 * src/maemo/modest-transport-widget.h:
2883 * src/modest-account-mgr-helpers.c:
2884 * src/modest-account-mgr-helpers.h:
2885 * src/modest-account-mgr.c:
2886 * src/modest-account-mgr.h:
2887 * src/modest-tny-account.c:
2888 * src/modest-tny-folder.c:
2889 * src/widgets/modest-account-view.c:
2890 * src/widgets/modest-retrieve-combo-box.c:
2891 * src/widgets/modest-retrieve-combo-box.h:
2892 * src/widgets/modest-secureauth-combo-box.c:
2893 * src/widgets/modest-serversecurity-combo-box.c:
2894 * src/widgets/modest-serversecurity-combo-box.h:
2895 * tests/check_account-mgr.c:
2896 Use the specific functions, and use the re-renamed enum values for GNOME too.
2898 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2900 * src/modest-pair.h:
2901 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2902 so we can get the second based on the first.
2904 * src/maemo/modest-account-settings-dialog.h:
2905 * src/maemo/modest-account-settings-dialog.c:
2906 Added get_supported_secure_authentication_methods(), though it is mostly
2907 commented-out for now until the necessary API is committed to tinymail.
2908 (modest_account_settings_dialog_set_account_name),
2909 (save_configuration): Request the supported authentication methods from the
2910 server, so we can choose a working method.
2912 * src/modest-tny-account-store.h:
2913 * src/modest-tny-account-store.c:
2914 (modest_tny_account_store_get_session): Rename from
2915 tny_account_store_get_session().
2917 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2919 * src/modest-protocol-info.h: Split the ModestProtocol enum
2920 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2921 There was no need to have these unrelated values in one enum.
2923 * src/: many files: Adapted to changed enum. This makes the code a bit
2924 clearer, and the compiler could catch some errors.
2926 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2928 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2929 Show the detailed internal camel error message when an error happens
2930 during the configuration, so that our testers can give us more clues.
2931 For instance, in projects.maemo.org bug NB#56910 .
2933 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2935 * src/modest-tny-account.c:
2936 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2937 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2939 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2941 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2942 * src/maemo/modest-account-settings-dialog.c:
2943 (modest_account_settings_dialog_set_account_name),
2944 (save_configuration): For the incoming secure authentication checkbox,
2945 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2946 the UI specification. PLAIN does not seem to be supported for most IMAP
2947 servers anyway, and I am not sure what it would mean.
2948 However, we probably need to discover which of the secure-authentication
2949 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2950 * src/modest-account-mgr-helpers.c:
2951 (modest_account_mgr_get_server_account_data):
2953 * src/modest-tny-account.c:
2954 (modest_tny_account_new_from_server_account):
2955 Use tny_account_set_mech() to set secure-authentication methods,
2956 with some special-casing for IMAP, based on my observations of how
2959 * src/modest-account-mgr-helpers.h:
2960 * src/modest-account-mgr.c:
2961 * src/modest-defs.h: Comment that the URI is only used for local folders.
2963 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2965 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2966 parameter const, just to be neat.
2967 * src/modest-text-utils.c: (modest_text_utils_inline):
2968 End g_strconcat() with NULL, as its documentation says. This is almost
2969 certainly the cause of my crash at startup on the device. Interestingly,
2970 valgrind doesn't tell us about these errors.
2972 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2974 * scripts/build-packages: Added more precise comments about how to use
2975 this script, though I still get this error:
2976 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2977 error building tinymail
2979 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2981 * src/maemo/modest-main-window.c: (on_account_update):
2982 Very slight cleanup, hoping to make it simpler to discover what causes
2983 a crash here sometimes.
2985 * src/modest-tny-account.c:
2986 (modest_tny_account_new_from_server_account): Set the port. Added
2987 comments about the options and a TODO comment because I need to find out
2988 how to specify the secure authentication method.
2990 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2992 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2993 changed CFlags paths form modest to libmodest
2995 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2997 * src/modest-account-mgr-helpers.c:
2998 (modest_account_mgr_get_server_account_data),
2999 (modest_account_mgr_free_server_account_data):
3000 * src/modest-account-mgr-helpers.h:
3001 * src/modest-account-mgr.c:
3002 (modest_account_mgr_add_server_account):
3003 * src/modest-defs.h:
3004 * src/modest-tny-account.c:
3005 (modest_tny_account_new_from_server_account):
3006 Determine the options for tny_camel_account_add_option() here,
3007 based on the settings, rather than storing them directly in gconf.
3009 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3011 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3012 Show a more friendly error dialog now that we expect (from the tinymail
3013 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3015 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3017 * src/maemo/modest-main-window.c: (on_account_update): Check that
3018 account_name is not NULL, to prevent a crash at startup that I am
3019 seeing on the N800. I do wonder why it is NULL.
3021 * src/maemo/easysetup/modest-easysetup-wizard.c:
3022 (create_page_user_details):
3023 * src/maemo/modest-account-settings-dialog.c:
3024 (create_page_user_details), (create_page_outgoing):
3025 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3026 (modest_connection_specific_smtp_edit_window_init):
3027 * src/modest-ui-actions.c:
3028 (modest_ui_actions_on_password_requested):
3029 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3030 might do something useful with the on-screen keyboard.
3032 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3034 * src/maemo/modest-main-window.c: (on_account_update):
3035 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3036 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3038 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3040 * src/modest-tny-account-store.c: (on_account_changed):
3041 Correct the signature of this signal handler.
3043 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3045 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3046 Show a HildonNote instead of a GtkDialog for Maemo.
3048 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3050 * src/widgets/modest-account-view.h:
3051 * src/widgets/modest-account-view.c: (on_account_changed),
3052 (on_account_removed). Added a boolean flag, set/unset by
3053 modest_account_view_block_conf_updates(),
3054 modest_account_view_unblock_conf_updates() to prevent unnecessary
3055 updates, but this is not very useful because the gconf notifications are
3056 so delays (maybe only on Maemo Bora).
3057 So auto-updating is turned off, and these functions do an explicit
3058 update when necessary.
3059 However, something else is still doing too much work when adding/removing
3060 accounts, probably in another part of the application.
3062 * src/maemo/modest-account-view-window.c:
3063 (on_delete_button_clicked), (on_edit_button_clicked),
3064 (on_new_button_clicked): Use the new functions.
3066 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3068 * src/modest-account-mgr-helpers.c:
3069 (modest_account_mgr_set_first_account_as_default):
3070 Sort the list of names alphabetically-by-title, so we choose the first one
3072 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3073 alphabetically by the title.
3075 This fixes projects.maemo.org bug NB#56418 .
3077 * src/modest-account-mgr-priv.c:
3078 (_modest_account_mgr_account_from_key):
3079 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3080 avoid a valgrind error, and possible random behaviour.
3082 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3084 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3085 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3086 tinymail documentation to say that this can be expected.
3087 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3088 pretty, and should not happen, but I would prefer to know when it does.
3090 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3092 * configure.ac: When using the older hildon version, probably on Bora,
3093 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3095 * src/widgets/modest-attachment-view.c:
3096 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3099 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3101 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3102 Implemented the prototype. Can be tested with
3103 tests/dbus_api/test_open_message:
3105 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3107 * src/modest-tny-account-store.c:
3108 (modest_tny_account_store_instance_init), (get_password):
3109 * src/modest-ui-actions.c:
3110 (modest_ui_actions_on_password_requested):
3111 Do not store the password in gconf, because this function is called
3112 for non-remembered passwords. Actually use the cached (in the hash map)
3113 password instead of releasing it.
3114 The password will now not be remembered if it is asked via the protected
3115 password dialog, as per the UI spec.
3117 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3119 * src/modest-defs.h:
3120 * src/modest-account-mgr-helpers.h:
3121 * src/modest-account-mgr-helpers.c:
3122 Added modest_server_account_get_username_has_succeeded(),
3123 modest_server_account_set_username_has_succeeded().
3124 (modest_server_account_set_username),
3125 Reset the has-succeeded flag if the username changes.
3127 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3128 * src/maemo/modest-connection-specific-smtp-window.c:
3129 (modest_connection_specific_smtp_window_save_server_accounts):
3130 Use modest_server_account_set_username() instead of using
3131 modest_conf_set_string() directly, so that the has-succeeded flag is always
3134 * src/modest-ui-actions.c:
3135 (modest_ui_actions_on_password_requested): Dim the username entry if
3136 the username has ever worked, as per the UI spec.
3138 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3140 * src/modest-tny-account-store.c: (get_password):
3141 * src/modest-ui-actions.c:
3142 (modest_ui_actions_on_password_requested):
3143 Allow the username to be changed too, though there is more work to
3144 be done on exactly how this behaves.
3146 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3148 * src/modest-account-mgr-helpers.h:
3149 * src/modest-account-mgr-helpers.c:
3150 Added modest_account_mgr_get_display_name(),
3151 modest_server_account_get_username(),
3152 modest_server_account_set_username(),
3153 modest_server_account_set_password(),
3154 modest_server_account_get_hostname() functions so we do not need to
3155 use the conf API directly.
3157 * src/maemo/modest-main-window.c: (connect_signals):
3158 Actually connect ot the ModestAccountStore::request-password signal,
3159 so that we show the dialog when the password is requested by Tinymail,
3160 for isntance if it is empty.
3162 * src/modest-marshal.list:
3163 * src/modest-tny-account-store.c:
3164 (modest_tny_account_store_class_init), (get_password),
3165 (modest_tny_account_store_alert):
3166 * src/modest-tny-account-store.h:
3167 * src/modest-ui-actions.h:
3168 * src/modest-ui-actions.c:
3169 (modest_ui_actions_on_password_requested):
3170 Change the signal parameters, so it is obvious that we are providing
3171 the non human-readable server name, and receiving both the username
3172 and password, though changing of the username is not yet implemented.
3173 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3174 for the GNOME version.
3176 This should fix the projects.maemo.org bug NB#56209, though it does not
3177 work on Bora, because the gconf_client_get() for the password fails
3178 immediately after we save it with gconf_client_set().
3180 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3183 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3184 caused an undefined symbol error:
3185 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3187 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3189 * src/modest-tny-account-store.c:
3190 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3191 using a GError instead of a string message, so we can translate it in
3194 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3196 * src/maemo/modest-address-book.c:
3197 (modest_address_book_check_names):
3198 * src/maemo/modest-msg-view-window.c:
3199 (modest_msg_view_window_clipboard_owner_change):
3200 * src/modest-init.c: (modest_init_init_ui):
3201 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3202 (update_folders_cb), (modest_mail_operation_update_account):
3203 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3204 (modest_ui_actions_on_msg_attachment_clicked),
3205 (modest_ui_actions_on_msg_recpt_activated):
3206 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3207 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3208 (modest_msg_view_search_next):
3209 * src/widgets/modest-recpt-editor.c:
3210 (modest_recpt_editor_on_button_release_event),
3211 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3212 g_message(). At this point we should only be seeing interesting errors on
3213 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3215 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3217 (modest_wizard_dialog_force_title_update):
3218 * src/maemo/easysetup/modest-wizard-dialog.h:
3219 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3220 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3221 can update the title when appropriate. Otherwise the title is wrong if the
3222 pages are added after adding the notebook to the dialog.
3223 This must be a problem in HildonWizardDialog too.
3224 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3226 * src/maemo/easysetup/modest-easysetup-wizard.c:
3227 (create_subsequent_customsetup_pages),
3228 (create_subsequent_easysetup_pages):
3229 Call modest_wizard_dialog_force_title_update() so that the title is
3230 correct even with GTK+ < 2.10.
3231 This fixes projects.maemo.org bug NB#56145 .
3233 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3235 * src/maemo/modest-platform.c:
3236 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3237 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3240 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3242 * src/widgets/modest-window.h:
3243 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3244 and modest_window_save_state(), which invokes it.
3246 * src/widgets/modest-window-mgr.h:
3247 * src/widgets/modest-window-mgr.c:
3248 Added modest_window_mgr_save_state_for_all_windows(), which calls
3249 the save_state vfunc on all registered windows, if implemented.
3251 * src/gnome/modest-msg-edit-window.c:
3252 * src/gnome/modest-msg-view-window.c:
3253 * src/maemo/modest-msg-edit-window.c:
3254 * src/maemo/modest-msg-view-window.c:
3255 * src/maemo/modest-main-window.c:
3256 Specify the existing save_settings functions as implementations of
3257 ModestWindow::save_state_func().
3259 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3260 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3261 enabling hibernation, for instance.
3263 We may need to do the same thing for restoring settings.
3266 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3268 * src/widgets/modest-window-mgr.c:
3269 * src/widgets/modest-window-mgr.h:
3270 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3271 modest_window_mgr_get_hibernation_is_prevented().
3273 * src/maemo/modest-main-window.c:
3274 (on_hildon_program_is_topmost_notify): Prevent hibernation
3275 (possible when the application goes to the background in the WM),
3276 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3278 * src/maemo/easysetup/modest-easysetup-wizard.c:
3279 (modest_easysetup_wizard_dialog_init):
3280 * src/maemo/modest-account-settings-dialog.c:
3281 (modest_account_settings_dialog_init):
3282 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3283 (modest_connection_specific_smtp_edit_window_init):
3284 * src/maemo/modest-connection-specific-smtp-window.c:
3285 (modest_connection_specific_smtp_window_init):
3286 * src/maemo/modest-signature-editor-dialog.c:
3287 (modest_signature_editor_dialog_init):
3288 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3289 prevent hibernation while any of these account settings dialogs are open.
3291 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/Makefile.am:
3294 * src/maemo/modest-osso-state-saving.c:
3295 * src/maemo/modest-osso-state-saving.h: Added
3296 modest_osso_load_state() and modest_osso_save_state() though they do
3297 nothing now. They should iterate through all the open windows and load/save
3299 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3300 save state when closing.
3302 * src/maemo/modest-main-window.c:
3303 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3304 Add a notification handler for the HildonProgram::is-topmost property,
3305 so we can allow hibernation when the application goes into the background.
3306 But we still need to detect when the accounts setup windows are open so
3307 we can stop hibernation when they are open.
3308 To do this, I also added the main window the HildonProgram. This might have
3309 other side-effects/benefits, and should maybe be done for other windows.
3311 * src/maemo/modest-osso-autosave-callbacks.h:
3312 * src/maemo/modest-osso-autosave-callbacks.c:
3313 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3314 though it does not do anything yet, and we might never need this to do
3315 anything. For instance, we already save drafts.
3317 * src/maemo/modest-platform.c: (modest_platform_init):
3318 Specify the libosso auto-save callback.
3320 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3322 * src/maemo/modest-platform.c:
3323 (modest_platform_set_update_interval):
3324 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3325 aparently stays valid between application instances, so we can use this
3326 to remove and reset it later. According to a maemo-developers email from
3329 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3331 * configure.ac: Depend on libalarm for Maemo.
3333 * src/dbus_api/modest-dbus-api.h:
3334 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3335 (on_send_receive), (modest_dbus_req_handler):
3336 Handle a SEND_RECEIVE D-Bus method.
3338 * libmodest-dbus-client/libmodest-dbus-client.c:
3339 (libmodest_dbus_client_send_and_receive):
3340 * libmodest-dbus-client/libmodest-dbus-client.h:
3341 Add C convenience functions for calling the new D-Bus method.
3343 * src/modest-platform.h:
3344 * src/gnome/modest-platform.c:
3345 * src/maemo/modest-platform.c:
3346 Added modest_platform_set_update_interval(), which uses the
3347 alarmd API on Maemo.
3348 (modest_platform_init),
3349 Call modest_platform_set_update_interval(), using a hard-coded
3350 interval for now (until the global settings dialog is implemented),
3351 though I am not sure that this makes sense yet.
3353 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3355 * src/dbus_api/modest-dbus-callbacks.c:
3356 (modest_osso_cb_hw_state_handler):
3357 * src/dbus_api/modest-dbus-callbacks.h:
3358 * src/maemo/modest-platform.c: (modest_platform_init):
3359 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3360 in case this has some effect on the ability for Maemo to ping the
3363 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3365 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3366 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3367 warning. It is probably a logic error, but I need to fix the build.
3369 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3371 * src/modest-account-mgr.h:
3372 * src/modest-account-mgr.c:
3373 (modest_account_mgr_account_names): Add a gboolean enabled_only
3374 parameter, so we can get lists of onlt the enabled accounts.
3376 (modest_account_mgr_add_account),,
3377 (modest_account_mgr_account_with_display_name_exists):
3378 * src/maemo/modest-msg-edit-window.c: (get_transports):
3379 * src/modest-account-mgr-helpers.c:
3380 (modest_account_mgr_set_first_account_as_default):
3381 * src/modest-init.c: (init_default_account_maybe):
3382 * src/modest-tny-account-store.c: (get_accounts):
3383 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3384 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3385 * tests/check_account-mgr.c: (START_TEST):
3386 Provide the extra parameter, as appropriate.
3388 * src/widgets/modest-account-view.c: (update_account_view):
3389 Do not show disabled accounts (meaning that there is no way to
3390 enable/disable accounts in the UI (the feature is not in our UI
3391 specification), so we can use this internally only to mark unfinished
3392 or temporary account data.
3394 * src/maemo/easysetup/modest-easysetup-wizard.c:
3395 (create_account): Add boolean enable parameter, so we can specify FALSE
3396 to create the temporary account.
3397 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3398 (on_before_next): When finishing, when there is a temporary account, just
3400 Also, use a timeout to delay the showing of the dialog until gconf is likely
3401 to return correct information, due to a maemo gconf bug that is fixed in
3402 osso 1.1, but not yet in Bora.
3403 However, the dialog stays on screen after it is destroyed.
3405 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3406 for invalid data when cancelling. Use a hildon note instead of a dialog
3407 to complain about invalid data. Do not show the account-saved note if the
3408 account is disabled (a temporary account that will not really be saved for use
3411 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3413 * src/modest-account-mgr-helpers.h:
3414 * src/modest-account-mgr-helpers.c:
3415 Added modest_account_mgr_unset_default_account(),
3416 Added modest_account_mgr_set_first_account_as_default().
3418 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3419 If it was the default account, unset the default account name.
3421 * src/maemo/modest-account-view-window.c:
3422 (on_delete_button_clicked): If it was the default account,
3423 set the first remaining account as the default instead.
3425 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3426 a NULL account or a NULL default account, to prevent a crash. This should
3427 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3430 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3432 * src/widgets/modest-recpt-editor.c:
3433 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3434 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3435 TODO comment for this. This fixes the build.
3437 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3438 be the best place for it. This will in future update all auto-update accounts,
3439 rather than just the current/default account, when that gconf key exists.
3440 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3441 if there are no accounts, before calling do_send_receive().
3442 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3444 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3445 * src/maemo/modest-main-window-ui.h:
3446 * src/maemo/modest-main-window.c: (on_connection_changed),
3447 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3448 directly, becaue the signal handler does more.
3450 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3452 * src/modest-account-mgr-helpers.c:
3453 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3454 for the case that the account does not exist.
3456 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3457 (equivalent to the modest account name) rather than the tinymail account name
3458 (equivalent to the modest account title - human readable) to get the account data.
3459 Check for null account data to prevent the crash, and add a TODO comment saying that
3460 this needs fixing because it is using the server account name instead of the account name.
3462 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3464 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3465 * src/maemo/modest-account-settings-dialog.c: (show_error),
3467 Use hildon_note_new_information() for informative and error messages,
3468 which seems to be expected for Maemo applications (no documentation that I know of
3469 says this). I am surprised that there is no distinction between info and error
3472 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3474 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3475 it is easy to find where this is used.
3477 * src/maemo/easysetup/modest-easysetup-wizard.c:
3478 (create_page_welcome), (create_page_account_details),
3479 (create_page_user_details), (create_page_complete_easysetup),
3480 (create_page_custom_incoming), (create_page_custom_outgoing),
3481 (create_page_complete_custom):
3482 * src/maemo/modest-account-settings-dialog.c:
3483 (create_page_account_details), (create_page_user_details),
3484 (create_page_incoming), (create_page_outgoing):
3485 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3486 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3487 (modest_connection_specific_smtp_edit_window_init):
3488 * src/maemo/modest-connection-specific-smtp-window.c:
3489 (modest_connection_specific_smtp_window_init):
3490 * src/maemo/modest-signature-editor-dialog.c:
3491 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3492 and scrolling policy as per the Email Application Layout Guide, if I have
3495 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3497 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3498 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3499 which were empty, because these vfuncs have been removed from TnyAccountStore.
3500 This fixes the build.
3502 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3504 * src/maemo/modest-main-window.c:
3505 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3506 showing/hiding it. Added TODO because it probably should not be NULL.
3507 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3508 because unnecessary g_warnings() make degugging difficult.
3510 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3512 * src/maemo/modest-msg-edit-window.c:
3513 (modest_msg_edit_window_select_color),
3514 (modest_msg_edit_window_select_background_color): 2 const corrections and
3515 moving 2 #endifs before closing brackets, to fix the build.
3517 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3519 * src/maemo/easysetup/modest-easysetup-wizard.h:
3520 * src/maemo/easysetup/modest-easysetup-wizard.c:
3521 (modest_easysetup_wizard_dialog_finalize),
3522 (on_button_edit_advanced_settings), (create_page_complete_custom),
3523 (on_response), (create_account):
3524 Implement the Advanced Settings edit button, by saving the account information,
3525 for the Advanded Settings dialog to use directly from gconf, and removing it
3526 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3527 Bug #5533 in the projects.maemo.org bugzilla.
3529 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3531 * src/maemo/modest-msg-view-window.c:
3532 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3533 when opening a message window.
3535 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3537 * src/maemo/easysetup/modest-easysetup-wizard.c:
3538 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3541 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3542 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3543 gconf settings. I probably added more checks than necessary, but that is safer.
3545 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3546 variable to fix the build, but this seems to be used when it is still NULL.
3548 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3550 * src/modest-platform.h:
3551 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3552 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3553 * src/modest-main.c: Implement this function so we can avoid using
3554 maemo-specific API from cross-platform code.
3556 * src/modest-tny-account-store.c:
3557 (get_smtp_specific_transport_account_for_open_connection):
3558 * src/modest-ui-actions.c: (check_for_connection),
3559 (modest_ui_actions_on_item_not_found):
3560 Use modest_platform_connect_and_wait() and put #idefs around other
3561 maemo-specific code, because only maemo currently has a way to
3562 identify connection names.
3564 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3566 * src/modest-tny-account-store.h:
3567 * src/modest-tny-account-store.c:
3568 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3569 the connection-specific SMTP server settings in the configuration.
3571 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3573 * src/maemo/modest-main-window.c: (on_connection_changed),
3575 * src/modest-main.c: (main), (start_ui), (send_mail):
3576 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3577 that is what is intended.
3579 * src/modest-ui-actions.c: (action_send), (action_receive),
3580 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3581 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3582 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3583 SMTP server is used when it is specified.
3585 (modest_ui_actions_on_send_receive):
3586 Check that a connection is open before proceeding.
3587 Receive and then send, instead of vice-versa, as per the specification.
3589 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3591 * src/modest-mail-operation.c:
3592 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3593 though I guess it should be something other than NULL.
3595 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3597 * src/maemo/easysetup/modest-easysetup-wizard.c:
3598 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3599 combo twice, to avoid an g_warning and to make it visible again.
3600 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3601 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3602 (already intended) dereference when detaching, because we then recreate the menu.
3603 But I am not sure why the warning was happening, and it is possible that this is a memory
3606 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3608 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3609 and uri_parse_mailto() utility functions.
3610 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3612 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3614 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3616 * src/dbus_api/modest-dbus-api.h:
3617 * src/dbus_api/modest-dbus-callbacks.c:
3618 Use an idle callback to execute the modest code in the application's own thread.
3619 Remove the helloworld example method.
3620 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3621 parsed, and the open-message method is not implemented because this is not yet implemented in
3623 * libmodest-dbus-client/libmodest-dbus-client.c:
3624 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3625 (libmodest_dbus_client_open_message):
3626 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3628 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3629 body without crashing.
3631 * tests/dbus_api/Makefile.am:
3632 * tests/dbus_api/test_mail_to.c:
3633 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3635 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3637 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3638 Added file to fix the build. Sorry.
3640 * src/dbus_api/Makefile.am:
3641 * src/dbus_api/modest-dbus-api.h:
3642 * src/dbus_api/modest-dbus-callbacks.h:
3643 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3644 (modest_dbus_req_handler):
3645 Put constants in a separate header so it can be reused by the
3646 client library, without duplication
3648 * libmodest-dbus-client/Makefile.am:
3649 * libmodest-dbus-client/libmodest-dbus-client.c:
3650 (libmodest_dbus_client_call_helloworld),
3651 (libmodfest_dbus_client_send_mail),
3652 (libmodfest_dbus_client_mailto),
3653 (libmodfest_dbus_client_open_message):
3654 * libmodest-dbus-client/libmodest-dbus-client.h:
3655 (Partly) Implement a send_mail D-Bus method.
3657 * tests/dbus_api/Makefile.am:
3658 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3659 the send_email D-Bus method.
3661 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3665 * libmodest-dbus-client/Makefile.am:
3666 * libmodest-dbus-client/libmodest-dbus-client.c:
3667 * libmodest-dbus-client/libmodest-dbus-client.h:
3668 * tests/dbus_api/Makefile.am:
3669 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3670 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3672 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3674 * src/maemo/easysetup/modest-easysetup-wizard.c:
3675 (create_page_account_details):
3676 * src/maemo/modest-account-settings-dialog.c:
3677 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3678 widgets, because this might not be the default in future versions of the Maemo GTK+.
3679 However, I can not not get capitalization to work even in a simple test case.
3681 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3683 * src/maemo/easysetup/modest-easysetup-wizard.c:
3684 (create_page_custom_incoming), (create_page_custom_outgoing):
3685 * src/maemo/modest-account-settings-dialog.c:
3686 (create_page_account_details), (create_page_incoming),
3687 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3688 instead of using gtk_check_button_with_label(), so they are aligned like the other
3689 widgets, as per the UI spec.
3691 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3693 * src/maemo/easysetup/modest-easysetup-wizard.c:
3694 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3695 * src/widgets/modest-validating-entry.c:
3696 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3697 Modest prefix instead of an EasySetup prefix.
3699 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3701 * src/widgets/modest-validating-entry.h:
3702 * src/widgets/modest-validating-entry.c: (on_insert_text),
3703 Added easysetup_validating_entry_set_max_func(), used to set a callback
3704 to call when the max number of characters is reached. GtkEntry has a max-length
3705 already but is silent about it.
3707 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3708 (create_page_account_details), (create_page_user_details),
3710 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3711 (create_page_account_details), (create_page_user_details),
3712 (create_page_outgoing):
3713 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3714 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3715 the UI spec, when the user tries to enter more than the max number of characters.
3717 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3719 * src/maemo/easysetup/modest-easysetup-wizard.c:
3720 (create_page_user_details), (create_page_custom_incoming),
3721 (create_page_custom_outgoing):
3722 * src/maemo/modest-account-settings-dialog.c:
3723 (create_page_user_details), (create_page_incoming),
3724 (create_page_outgoing):
3725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3726 (modest_connection_specific_smtp_edit_window_init):
3727 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3728 not appropriate. Bad Maemo-specific defaults!.
3730 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3732 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3733 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3734 (modest_signature_editor_dialog_set_settings):
3735 Disable the label and textview when the checkbox is disabled, and use the
3736 specified (UI spec) default signature text.
3738 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3740 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3741 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3743 * src/modest-defs.h:
3744 * src/modest-account-mgr-helpers.h:
3745 * src/modest-account-mgr-helpers.c:
3746 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3748 * src/maemo/Makefile.am:
3749 * src/maemo/modest-signature-editor-dialog.c:
3750 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3753 * src/maemo/modest-account-settings-dialog.h:
3754 * src/maemo/modest-account-settings-dialog.c:
3755 (modest_account_settings_dialog_finalize), (on_button_signature),
3756 (save_configuration): Use the new dialog when the Edit button is pressed, and
3757 save the changes if necessary, as per the UI spec.
3759 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3761 * src/maemo/Makefile.am:
3762 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3763 based on maemo-develoers email from Dirk.
3765 * src/maemo/easysetup/modest-easysetup-wizard.c:
3766 (create_page_welcome), (create_page_account_details),
3767 (create_page_user_details), (create_page_complete_easysetup),
3768 (create_page_custom_incoming), (create_page_custom_outgoing),
3769 (create_page_complete_custom),
3770 (modest_easysetup_wizard_dialog_init):
3771 * src/maemo/modest-account-settings-dialog.c:
3772 (create_page_account_details), (create_page_user_details),
3773 (create_page_incoming), (create_page_outgoing),
3774 (modest_account_settings_dialog_init):
3775 * src/maemo/modest-connection-specific-smtp-window.c:
3776 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3778 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3780 * src/maemo/easysetup/modest-easysetup-wizard.c:
3781 (create_page_account_details), (create_page_custom_outgoing),
3782 (create_page_complete_custom):
3783 * src/maemo/modest-account-settings-dialog.c:
3784 (create_page_user_details), (create_page_incoming),
3785 (create_page_outgoing):
3786 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3787 (modest_connection_specific_smtp_edit_window_init):
3788 Use the correct (UI spec) port min/max, and use horizontal separators,
3791 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3793 * src/maemo/easysetup/modest-easysetup-wizard.c:
3794 (set_default_custom_servernames):
3795 * src/maemo/modest-account-settings-dialog.c:
3796 (create_page_incoming), (on_combo_outgoing_security_changed),
3797 (on_combo_incoming_security_changed), (create_page_outgoing),
3798 (modest_account_settings_dialog_set_account_name),
3799 (save_configuration):
3800 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3801 (on_combo_security_changed),
3802 (modest_connection_specific_smtp_edit_window_init),
3803 (modest_connection_specific_smtp_edit_window_set_connection),
3804 (modest_connection_specific_smtp_edit_window_get_settings):
3805 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3808 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3811 * src/maemo/easysetup/modest-easysetup-wizard.c:
3812 (create_page_custom_outgoing), (create_page_complete_custom):
3813 * src/maemo/modest-account-settings-dialog.c:
3814 (create_page_user_details), (create_page_outgoing):
3815 * src/maemo/modest-account-view-window.c: (button_box_new):
3816 Use changed logical IDs as per the most recent UI spec:
3817 mcen_bd_emailsetup_edit -> mcen_bd_edit
3818 mcen_bd_emailsetup_delete -> mcen_bd_delete
3819 mcen_bd_emailsetup_close -> mcen_bd_close
3821 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3825 * src/dbus_api/Makefile.am:
3826 * src/dbus_api/modest-dbus-callbacks.c:
3827 * src/dbus_api/modest-dbus-callbacks.h:
3828 * src/maemo/modest-platform.c: (modest_platform_init):
3829 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3831 * tests/Makefile.am:
3832 * tests/dbus_api/Makefile.am:
3833 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3835 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3837 * src/maemo/modest-account-settings-dialog.c:
3838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3839 Removed unnecessary includes.
3841 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3843 * src/maemo/easysetup/modest-easysetup-wizard.c:
3844 * src/maemo/modest-account-settings-dialog.c:
3845 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3846 * src/widgets/Makefile.am:
3847 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3848 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3849 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3850 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3851 * src/widgets/modest-secureauth-combo-box.c:
3852 * src/widgets/modest-secureauth-combo-box.h:
3853 * src/widgets/modest-serversecurity-combo-box.c:
3854 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3855 made the GObject names more consistent with the rest of the Modest code.
3857 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3859 * src/maemo/easysetup/Makefile.am:
3860 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3861 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3862 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3863 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3864 * src/maemo/easysetup/modest-easysetup-wizard.c:
3865 * src/maemo/easysetup/modest-validating-entry.c:
3866 * src/maemo/easysetup/modest-validating-entry.h:
3867 * src/maemo/modest-account-settings-dialog.c:
3868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3869 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3870 widgets/ because they are used outside of easysetup too. After checking in,
3871 svn will allow me to rename them too.
3873 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3875 * src/gnome/modest-msg-edit-window.c:
3876 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3877 linker error, to fix the build on the GNOME platform.
3878 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3879 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3880 ifdefed out to avoid a warning.
3882 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3884 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3885 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3886 some alternative for GTK+ 2.6.
3888 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3890 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3892 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3893 specified for EmailAccountsDialog in UI spec.
3895 * src/maemo/easysetup/modest-easysetup-wizard.c:
3896 * src/maemo/easysetup/modest-easysetup-wizard.h:
3897 * src/maemo/modest-account-settings-dialog.c:
3898 * src/maemo/modest-account-settings-dialog.h:
3899 Reuse a member window widget for the connection-specific SMTP server accounts,
3900 so we can tell it to create/save the accounts only if we actually save changes.
3902 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3903 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3904 (modest_connection_specific_smtp_edit_window_get_settings):
3905 Return a struct instance for temporarily remembering the entered data.
3907 * src/maemo/modest-connection-specific-smtp-window.h:
3908 * src/maemo/modest-connection-specific-smtp-window.c:
3909 (modest_connection_specific_smtp_window_finalize),
3910 (modest_connection_specific_smtp_window_fill_with_connections),
3912 (modest_connection_specific_smtp_window_save_server_accounts),
3913 (update_model_server_names): Do not actually save data until asked,
3914 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3916 (on_selection_changed),
3917 (modest_connection_specific_smtp_window_init): Disable the edit
3918 button when nothing is selected.
3920 * src/modest-account-mgr-helpers.c:
3921 * src/modest-account-mgr-helpers.h:
3922 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3925 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3927 * src/modest-account-mgr-helpers.h:
3928 * src/modest-account-mgr-helpers.c:
3929 (modest_account_mgr_get_unused_account_name),
3930 (modest_account_mgr_get_unused_account_display_name): Added these
3931 utility functions, to avoid code duplication.
3933 * src/maemo/easysetup/modest-easysetup-wizard.c:
3934 (create_page_account_details), (create_account):
3935 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3936 (on_combo_security_changed),
3937 (modest_connection_specific_smtp_edit_window_init),
3938 (modest_connection_specific_smtp_edit_window_save_settings):
3939 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3940 * src/maemo/modest-connection-specific-smtp-window.c:
3941 (modest_connection_specific_smtp_window_finalize),
3942 (modest_connection_specific_smtp_window_fill_with_connections),
3943 (on_button_edit), (modest_connection_specific_smtp_window_init):
3944 * src/maemo/modest-connection-specific-smtp-window.h:
3945 Implementing saving of connection-specific server accounts.
3947 But I need to refactor this so we can save the data for each
3948 possible connection-specific account and only actually create the server accounts
3949 when the easysetup finished, or the OK button is pressed on the account settings
3952 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3954 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3955 (on_combo_security_changed):
3956 (modest_connection_specific_smtp_edit_window_init):
3957 Auto-fill the port number as in the account settings.
3959 (modest_connection_specific_smtp_edit_window_set_connection):
3960 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3961 * src/maemo/modest-connection-specific-smtp-window.c:
3962 (fill_with_connections), (on_button_edit),
3963 (modest_connection_specific_smtp_window_init):
3964 Turn the edit window into a dialog to simplify the code, and
3965 set a WM hint as in a GtkDialog, because only a popup can be on top of
3966 another window in Maemo, and popups usually have no WM decoration.
3968 * src/modest-defs.h:
3969 * src/modest-account-mgr-helpers.c:
3970 (modest_account_mgr_set_connection_specific_smtp),
3971 (modest_account_mgr_remove_connection_specific_smtp),
3972 (modest_account_mgr_get_connection_specific_smtp):
3973 * src/modest-account-mgr-helpers.h: Some functions to write the
3974 connection-specific SMTP server information. Not yet used.
3977 * src/widgets/modest-folder-view.c: (text_cell_data):
3978 Fix a warning about an uninitialized variable.
3979 (on_configuration_key_changed): Put an #ifdef around the use
3980 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3982 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/modest-account-settings-dialog.h:
3985 * src/maemo/modest-account-settings-dialog.c:
3986 Added connect_for_modified() utility function to mark the new modified boolean.
3988 (create_page_account_details), (create_page_user_details),
3989 (create_page_incoming), (create_page_outgoing), (on_response),
3990 (modest_account_settings_dialog_init),
3991 (modest_account_settings_dialog_set_account_name):
3992 Only warn about unsaved changes when there are actually unsaved changes.
3994 * src/modest-account-mgr-helpers.c:
3995 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3996 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3997 to get the data from there in future.
3999 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4001 * src/modest-defs.h:
4003 * src/modest-account-mgr-helpers.h:
4004 * src/modest-account-mgr-helpers.c:
4005 Store the security account setting in a single conf key instead of using
4006 the options list, so that the list is left for just the to-be-removed camel hack,
4007 and because gconf_client_set_list() is failing for some reason.
4009 * src/modest-account-mgr.c:
4010 (modest_account_mgr_add_server_account):
4011 * src/maemo/modest-account-settings-dialog.c:
4012 (modest_account_settings_dialog_set_account_name),
4013 (save_configuration): Use the renamed functions.
4016 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4018 * src/widgets/Makefile.am:
4019 * src/widgets/modest-limit-retrieve-combo-box.c:
4020 * src/widgets/modest-limit-retrieve-combo-box.h:
4021 * src/widgets/modest-retrieve-combo-box.c:
4022 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4023 the account settings dialog.
4025 * src/modest-defs.h:
4026 * src/modest-account-mgr-helpers.h:
4027 * src/modest-account-mgr-helpers.c:
4028 (modest_server_account_get_option_secure_auth),
4029 (modest_server_account_set_option_secure_auth):
4030 * src/modest-account-mgr.c:
4031 (modest_account_mgr_add_server_account):
4032 Use the existing AUTH_MECH conf key for the secure-auth setting,
4033 instead of putting it in the list options, because this was actually used already.
4035 * src/maemo/modest-account-settings-dialog.c:
4036 (create_page_account_details),
4037 (modest_account_settings_dialog_set_account_name),
4038 (save_configuration):
4039 * src/maemo/modest-account-settings-dialog.h:
4040 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4041 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4043 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4045 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4046 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4047 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4049 * src/modest-defs.h:
4050 * src/maemo/modest-account-settings-dialog.c:
4051 (create_page_incoming), (on_combo_outgoing_security_changed),
4052 (on_combo_incoming_security_changed), (create_page_outgoing),
4053 (modest_account_settings_dialog_set_account_name),
4054 (save_configuration): Load/Save the port number, and change it when the
4055 security combo changes, to suitable defaults.
4057 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4059 * src/modest-account-mgr.c:
4060 (modest_account_mgr_add_server_account): Set the security and secure-auth
4061 options, and add a comment saying that the other camel-specific options should be
4064 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4066 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4068 * src/modest-tny-account-store.c: (account_list_free),
4069 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4070 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4073 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4075 * src/modest-protocol-info.c:
4076 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4077 is required by our UI spec. Maybe something in our implementation will use this eventually.
4078 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4079 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4080 instead of the previous 0 placeholder.
4082 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4083 secure-auth settings.
4084 * src/modest-account-mgr-helpers.h:
4085 * src/modest-account-mgr-helpers.c:
4086 (modest_server_account_data_get_option_secure_auth),
4087 (modest_server_account_set_option_secure_auth),
4088 (modest_server_account_data_get_option_security),
4089 (modest_server_account_set_option_security): Added this API for getting and setting the security
4090 and secure-auth settings.
4092 * src/maemo/modest-account-settings-dialog.h:
4093 * src/maemo/modest-account-settings-dialog.c:
4094 (modest_account_settings_dialog_finalize), (check_data),
4095 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4096 about changing titles.
4097 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4098 (save_configuration): Save the security and secure-auth settings.
4100 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4101 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4103 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4105 * src/modest-defs.h:
4106 * src/modest-account-mgr.c:
4107 (modest_account_mgr_add_server_account):
4108 Added and used defines for the options key and value pair strings,
4109 that are used so far, though they do not seem to correspond to anything in our
4110 UI specs or ModestProtocol enum.
4112 * src/modest-account-mgr-helpers.h:
4113 * src/modest-account-mgr-helpers.c:
4114 (compare_option_strings_for_name),
4115 (modest_server_account_data_get_option_value),
4116 (modest_server_account_data_get_option_bool),
4117 (modest_account_mgr_get_server_account_option):
4118 Added helper functions for parsing the options GSList.
4120 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4122 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4123 display name is based on the supplied account name.
4124 * src/modest-account-mgr.c:
4125 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4126 with an inefficient, but good-enough, implementation.
4128 * src/maemo/easysetup/modest-easysetup-wizard.c:
4129 (create_page_account_details), (on_before_next), (create_account):
4130 Check for existing display names rather than (non-user-visible) account names, and just
4131 create and set a unique account name at the end.
4133 * src/maemo/modest-account-settings-dialog.c:
4134 (modest_account_settings_dialog_init),
4135 (modest_account_settings_dialog_set_account_name),
4136 (create_page_incoming): Show the display name, instead of the account name.
4137 (on_response): Do some (not all) extra checks, as in the UI spec.
4138 (save_configuration): Save the display name if it was changed.
4140 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4142 * po/en_GB.po: Added needed logical ID and translation.
4143 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4144 (init_view): Made the is-default column clicking work.
4146 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4149 * src/maemo/easysetup/Makefile.am:
4150 * src/maemo/easysetup/modest-easysetup-wizard.c:
4151 (modest_easysetup_wizard_dialog_init):
4152 * src/maemo/easysetup/provider-data-test.keyfile:
4153 * src/maemo/easysetup/provider-data.keyfile:
4154 Moved the provider data file to the new modest-providers-data package and used it from there.
4156 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4158 * src/modest-local-folder-info.c:
4159 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4160 N_() was already used on the static strings, but this just marks it for translation without
4161 using the translation.
4163 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4165 * src/maemo/modest-account-settings-dialog.c:
4166 (create_page_incoming),
4167 (modest_account_settings_dialog_set_account_name):
4168 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4169 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4170 I will do this if nobody else gets there first.
4172 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4174 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4175 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4176 save the security stuff.
4178 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4180 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4181 Set the email address and user fullname, which I now see must be
4184 * src/maemo/modest-account-settings-dialog.h:
4185 * src/maemo/modest-account-settings-dialog.c:
4187 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4188 leave-on-server and authentication.
4189 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4192 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4195 * src/maemo/modest-account-settings-dialog.c:
4196 * src/maemo/modest-account-settings-dialog.h:
4197 Most (but not all) of the widgets are now present as specified by the UI spec.
4198 No changes are yet saved, and some details are not properly shown yet.
4200 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4202 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4204 * src/maemo/Makefile.am:
4205 * src/maemo/modest-account-settings-dialog.c:
4206 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4207 an existing account. Doesn't do much yet.
4209 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4210 Open the accounts settings dialog when Edit is clicked.
4212 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4214 * src/maemo/easysetup/Makefile.am:
4215 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4217 * src/maemo/easysetup/modest-easysetup-wizard.c:
4218 (modest_easysetup_wizard_dialog_init):
4219 Try to get the source directory from the build system,
4220 instead of hard-coding "./" into the source code, when opening our local
4221 copies of the configuration files.
4222 But this still fails when opening the wizard from the Accounts window,
4223 maybe because the working directory seems to change at runtime.
4224 So the wizard will fail the second time unless you copy the files into their
4225 proper locations - see the stdout warnings for the paths.
4227 (create_page_account_details),(on_before_next):
4228 Check for existing non-server accounts instead of server accounts,
4229 so the default account name is useful again, and to prevent trying to
4232 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4233 Show the wizard when New is clicked.
4235 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4236 (init_view): Show the column headers, and show the columns that are
4237 specified in the UI specs. However, something in Maemo's GTK+ prevents
4238 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4239 change the default account. This is despite unsetting the special properties.
4241 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4243 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4244 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4245 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4246 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4247 to make that clearer.
4248 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4250 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4252 * src/maemo/modest-account-view-window.c:
4253 (modest_account_view_window_init),
4254 (modest_account_view_window_new):
4255 Use the same buttons as specified in the
4256 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4257 the existing widgets, which never had a chance of working.
4258 Put the ModestAccountView treeview in a scrolled window.
4259 Do not repeat the initialization in both _init() and _new().
4261 * src/widgets/modest-account-view.c: (update_account_view):
4262 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4263 this widget and window shows no accounts.
4265 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4267 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4269 * src/maemo/easysetup/modest-easysetup-wizard.c:
4270 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4271 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4272 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4275 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4276 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4277 accounts exist yet, as in the UI spec.
4279 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4281 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4283 * src/maemo/Makefile.am:
4284 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4285 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4286 New window for editing connection-specific smtp details.
4287 Not fully implemented.
4289 * src/maemo/modest-connection-specific-smtp-window.c:
4290 (modest_connection_specific_smtp_window_finalize) :
4291 unref the tree model.
4292 (on_button_edit): Show the edit window.
4294 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4296 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4299 * src/maemo/Makefile.am:
4300 * src/maemo/modest-connection-specific-smtp-window.c:
4301 * src/maemo/modest-connection-specific-smtp-window.h:
4302 New window for showing the list of connections, for connection-specific
4303 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4304 * src/maemo/easysetup/modest-easysetup-wizard.c:
4305 (create_page_custom_outgoing): Show the new window when the button is clicked.
4307 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4309 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4310 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4311 * src/maemo/modest-msg-edit-window.c:
4312 (modest_msg_edit_window_insert_image):
4313 * src/modest-conf.c: (modest_conf_key_escape):
4314 * src/modest-mail-operation.c:
4315 (modest_mail_operation_send_new_mail):
4316 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4317 (modest_ui_actions_on_new_account):
4318 * src/widgets/modest-attachment-view.c: (update_filename_request):
4319 * src/widgets/modest-mail-header-view.c:
4320 Corrected warnings that were breaking the build, by commenting out unused variables,
4321 and a function, and by including a header.
4323 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4325 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4326 so we can #ifdef around platform-specific code when necessary.
4327 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4328 to allow this to build for the GNOME platform too.
4330 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4332 * src/maemo/easysetup/modest-easysetup-wizard.c:
4333 Added util_increment_name() and used it in create_page_account_details()
4334 to make sure that the default account name is always a new name.
4336 (modest_easysetup_wizard_dialog_init),
4337 (set_default_custom_servernames): Some minor memory management fixes.
4339 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4343 * src/modest-runtime.c: (init_i18n): Restored the translation
4344 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4345 are defined in config.h, and the translations are installed.
4347 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4348 is defined for translation.
4350 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4352 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4354 * src/maemo/easysetup/modest-easysetup-wizard.c:
4355 (modest_easysetup_wizard_dialog_init):
4356 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4357 Use realistic paths (though they should use $prefix generically) to the
4358 mcc_mapping and provider-data.keyfile files which might work when they
4359 are installed by the future version of the operator-wizard package,
4360 and then fallback to paths in our source code, with an explanatory
4363 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4367 * src/maemo/Makefile.am:
4368 * src/maemo/easysetup/: Added files from the previously-exernal
4369 osso-modest-easysetup.
4370 * src/maemo/modest-main-window-ui.h:
4371 * src/modest-ui-actions.c:
4372 * src/modest-ui-actions.h:
4373 Added modest_ui_actions_on_new_account() as a signal handler for the
4374 New Account menu item. It shows the easysetup wizard.
4375 * po/en_GB.po: Added additional needed logical IDs and translations.