1 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/modest-ui-actions.c: (create_move_to_dialog),
4 (modest_ui_actions_on_main_window_move_to),
5 (modest_ui_actions_on_msg_view_window_move_to):
6 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
7 (filter_row), (modest_folder_view_show_non_move_folders):
8 * src/widgets/modest-folder-view.h:
10 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
11 the Sent folder yet as it does not report the correct folder type.
13 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
15 * src/maemo/modest-msg-edit-window.c: (init_window):
18 2007-07-10 Murray Cumming <murrayc@murrayc.com>
20 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
21 Take a parent widget instead of a parent window, and
22 implement this with hildon_banner_show_information() instead.
23 Non-Maemo builds can just ifdef that there.
24 This fixed projects.maemo.org bug NB#62766.
26 (on_entry_invalid_character): Use show_error() again instead
27 of using hildon directly, and use the _CS() macro to use the correct
29 (create_account), (check_for_supported_auth_methods), (on_entry_max):
30 Pass a widget instead od a window to show_error().
32 2007-07-10 Murray Cumming <murrayc@murrayc.com>
34 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
35 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
36 This allows us to show the server name in the error message, fixing
37 projects.maemo.org bug NB#62904.
38 Also, use the appropriate logical ID message for the account protocol.
40 2007-07-10 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-tny-account-store.c: (on_idle_wrong_password):
43 A compilation fix, though the build wasn't broken for me.
45 2007-07-09 Murray Cumming <murrayc@murrayc.com>
47 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
48 Do not try to unref a NULL folder store, to avoid a runtime warning.
49 This seems to happen sometimes when changing accounts settings.
51 2007-07-09 Murray Cumming <murrayc@murrayc.com>
53 * src/modest-tny-account-store.c:
54 (modest_tny_account_store_instance_init),
55 (modest_tny_account_store_finalize),
56 (on_account_settings_hide), (on_idle_wrong_password):
57 Use a GHashTable to ensure that we only show one account settings
58 dialog per modest account. This avoids us having a dialog open for
59 both the store and transport accounts, or due to repeated get_password()
60 calls that shouldn't happen anyway.
62 2007-07-09 Murray Cumming <murrayc@murrayc.com>
64 * src/maemo/modest-maemo-utils.c: (on_hide),
65 (modest_maemo_show_dialog_and_forget): Handle the response, because
66 the window is not even hidden by default.
68 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
69 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
70 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
71 which seems to prevent some modality problems.
73 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
74 Ignore user cancellation errors.
76 * src/modest-account-mgr-helpers.h:
77 * src/modest-account-mgr-helpers.c:
78 Added modest_server_account_get_password() and
79 modest_server_account_get_has_password() to avoid direct use of
82 * src/maemo/modest-account-settings-dialog.h:
83 * src/maemo/modest-account-settings-dialog.c:
84 (modest_account_settings_dialog_init): Store the notebook so we can
86 Added modest_account_settings_dialog_switch_to_user_info().
88 * src/modest-tny-account-store.c:
89 (get_password): When the password in the account settings is wrong (we think),
90 show the relevant page of the account settings dialog, in the mainloop.
91 However, we currently get many of these at once because cancel does not
93 (forget_password): Do not forget the password
94 from the account settings, because this causes side-effects when
95 tinymail seems to call it at strange time, maybe because of how we
96 are cancelling get_password().
97 (modest_tny_account_store_alert): Ignore user cancellations.
99 2007-07-09 Murray Cumming <murrayc@murrayc.com>
101 * src/maemo/modest-maemo-utils.h:
102 * src/maemo/modest-maemo-utils.c:
103 Added modest_maemo_show_information_note_and_forget() for use instead of
104 gtk_dialog_run() when the response is not needed, to avoid an extra
105 mainloop which could cause a hang.
107 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
108 Use the logical IDs for the error message, though they are not
109 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
110 because gtk_dialog_run() caused a hang here (the window did not close).
111 This fixes projects.maemo.org bug NB#62646.
113 2007-07-09 Murray Cumming <murrayc@murrayc.com>
115 * src/modest-account-mgr-helpers.h:
116 * src/modest-account-mgr-helpers.c:
117 Added modest_account_mgr_get_store_protocol().
119 * src/maemo/modest-account-view-window.c:
120 (on_delete_button_clicked): Show different warning text depending on
121 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
122 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
125 2007-07-09 Murray Cumming <murrayc@murrayc.com>
127 * src/maemo/modest-msg-edit-window.c:
128 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
129 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
131 2007-07-07 Armin Burgmeier <armin@openismus.com>
133 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
134 ckdg_ib_maximum_characters_reached from correct package.
136 * src/modest-ui-actions.c: Show an error message when a folder could
137 not be created. Tinymail does not give us specific error codes about
138 what has gone wrong, so we assume that a folder with that name
139 already exists, though there might be other reasons.
141 2007-07-06 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
144 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
145 give a more exact error message that can be partly translated.
147 2007-07-05 Murray Cumming <murrayc@murrayc.com>
149 * src/maemo/modest-address-book.c:
150 (select_email_addrs_for_contact): Specify a default window size for the
151 select-email-address dialog, so that it is probably big enough for the
152 title. This should fix projects.maemo.org bug NB#62277.
154 2007-07-05 Murray Cumming <murrayc@murrayc.com>
156 * src/maemo/easysetup/modest-easysetup-wizard.c:
157 (create_page_complete_easysetup): Use
158 gtk_widget_set_size() request to ensure that the text wraps
161 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
163 * src/maemo/easysetup/modest-easysetup-wizard.c:
164 (on_entry_invalid_character), (create_page_account_details),
165 (create_page_user_details):
166 Use new API of ModestValidatingEntry. But for some reason the banner is
167 not shown. I will have to investigate that further.
169 * src/widgets/modest-validating-entry.c: (on_insert_text),
170 (modest_validating_entry_set_func):
171 * src/widgets/modest-validating-entry.h:
172 Added a new callback function to be able to react to prevented
173 characters whitespaces to e.g show a banner.
175 2007-07-05 Armin Burgmeier <armin@openismus.com>
177 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
178 notification of HildonNumberEditor instead of remembering the port
179 number. Thanks to Johannes for pointing this out.
181 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
183 * src/maemo/easysetup/modest-easysetup-wizard.c:
184 Check if there are any user changes before showing a confirmation
185 dialog (projects.maemo.org NB#60946)
187 2007-07-05 Armin Burgmeier <armin@openismus.com>
189 * src/maemo/modest-account-settings-dialog.c: Remember custom port
190 number at the beginning of the dialog and set the modified flag at the
191 end if the port number has changed. This is necessary because
192 HildonNumberEditor does not support notification when the value has
195 2007-07-05 Murray Cumming <murrayc@murrayc.com>
197 * src/modest-ui-actions.c:
198 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
199 a connection before asking anything else. Correct the check for the destination
200 folder so that it succeeds when online.
201 This fixed projects.maemo.org bug NB#61645.
203 2007-07-05 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
206 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
207 to fix projects.maemo.org bug NB#62439.
209 2007-07-05 Murray Cumming <murrayc@murrayc.com>
211 * src/modest-tny-account.c: (on_connection_status_changed):
212 Really do not use tny_device_force_offline() here. See the previous comment.
214 2007-07-04 Murray Cumming <murrayc@murrayc.com>
216 * src/modest-tny-account.c: (on_connection_status_changed):
217 Do not use tny_device_force_offline() when tinymail says that something
218 went wrong with the connection. It seems to report this unnecessarily.
220 2007-07-04 Murray Cumming <murrayc@murrayc.com>
222 * src/maemo/modest-connection-specific-smtp-window.c:
223 (modest_connection_specific_smtp_window_init):
224 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
225 does not seem to have any effect in osso 1.1 (though it works in
226 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
228 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
230 * src/maemo/modest-connection-specific-smtp-window.c:
231 Fix UI specification problems with projects.meamo.org NB#60479
233 2007-07-04 Murray Cumming <murrayc@murrayc.com>
235 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
236 clue when this has failed, because the error dialog is not always shown
237 (at least in earlier version).
239 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
240 GError message, because the generic error dialog is not helpful.
242 'This message is not currently available (can't let a new connection go online)'
243 when trying to open an IMAP message.
245 (_modest_ui_actions_open): Offer a connection when some messages would
246 have to be downloaded and we are offline.
248 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
250 * src/widgets/modest-folder-view.c:
251 Don't check for MERGE type anymore as we use the correct type
253 NOTE: For the last two changes you need to update your tinymail copy
254 because of API changes!
256 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
258 * src/modest-tny-local-folders-account.c:
259 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
260 (see projects.maemo.org NB#61580)
262 2007-07-04 Murray Cumming <murrayc@murrayc.com>
264 * src/modest-tny-account.c: (on_connection_status_changed):
265 Commented out the call to modest_platform_connect_and_wait() because this
266 seems to always hang, and I would like to know if this is the only thing
267 that causes a hang when showing the connection dialog.
268 It is not very useful anyway.
270 2007-07-04 Murray Cumming <murrayc@murrayc.com>
272 * src/maemo/modest-msg-view-window.c:
273 (modest_msg_view_window_select_next_message):
275 * src/modest-platform.h:
276 * src/maemo/modest-platform.c:
277 Added modest_platform_connect_and_wait(), which calls
278 tny_maemo_conic_device_connect() always in the main thread, by calling it
279 in an idle handler and waiting for the idle handler to run. It should be
280 in the main thread because it uses GTK+ UI code. It just returns TRUE
281 if the device is already online.
283 There is some nasty code to ensure that subsequent calls to
284 modest_platform_connect_and_wait() just wait for the first one to finish,
285 by checking repeatedly in another idle handler. This is necessary,
286 because other threads (or even the main thread, via another idle handler)
287 can call modest_platform_connect_and_wait() while
288 modest_platform_connect_and_wait() is running.
290 (modest_platform_connect_and_wait_if_network_account),
291 (modest_platform_connect_and_wait_if_network_folderstore):
292 Convenience functions that calls modest_platform_connect_and_wait() if
293 the account or folder might want network access.
295 * src/modest-mail-operation.c:
296 (modest_mail_operation_update_account):
297 * src/modest-ui-actions.c: (download_uncached_messages),
298 (modest_ui_actions_on_rename_folder), (delete_folder),
299 (modest_ui_actions_on_main_window_move_to),
300 (modest_ui_actions_on_msg_view_window_move_to):
301 * src/widgets/modest-folder-view.c:
302 (drag_and_drop_from_folder_view):
303 Offer a connection if we are offline.
305 * src/modest-tny-account.c: (on_connection_status_changed):
306 Document this as only handling errors during network operations in progress,
307 and replace the idle code with a simple call to
308 modest_platform_connect_and_wait(), which does this instead.
310 2007-07-03 Murray Cumming <murrayc@murrayc.com>
312 * src/modest-tny-account.c:
313 (modest_tny_account_get_special_folder): (util_on_idle),
314 Handle the GError so we can see when tny_folder_store_get_folders()
315 fails, as it currently does while something else is connecting.
317 Added util_run_in_main_thread_and_wait()
318 which uses an idlen handler and mainloop to ensure that the function
319 is called in the main thread.
320 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
321 to make sure that we call attempt the connection in the mainloop only,
322 which might solve some hangs.
324 2007-07-03 Murray Cumming <murrayc@murrayc.com>
326 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
327 be found by their display name. This is never useful.
328 * src/modest-tny-account-store.c: (on_account_removed): Find the account
329 by its ID, instead of trying to use its ID as its display name.
331 * src/modest-tny-account-store.h:
332 * src/modest-tny-account.c:
333 (modest_tny_account_get_special_folder): Add a g_warning() when
334 tny_folder_store_get_folders() returns an empty list for the maildir.
336 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
337 Add a g_warning() when this returns NULL, because that it not allowed
340 2007-07-02 Armin Burgmeier <armin@openismus.com>
342 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
343 note when trying to cancel the wizard. This fixes projects.maemo.org
346 2007-07-02 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-tny-account.h:
349 * src/modest-tny-account.c:
350 (modest_tny_account_new_from_server_account),
351 (modest_tny_account_new_from_server_account_name),
352 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
353 because this must now be set before setting the proto. This is usd in
354 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
355 warning in camel_session_get_service() caused by
356 tny_camel_transport_account_prepare().
358 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
361 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
363 * src/maemo/modest-connection-specific-smtp-edit-window.c:
365 (modest_connection_specific_smtp_edit_window_init):
367 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
370 2007-06-29 Murray Cumming <murrayc@murrayc.com>
372 * src/modest-tny-account.c:
373 (modest_tny_account_new_from_server_account):
374 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
375 now uses to request a connection when it needs one, and which it uses
376 to tell us that something is wrong with the connection, so we can force
377 the accounts offline to prevent further problems.
380 * src/modest-init.c: (init_default_settings):
381 * src/modest-mail-operation.c:
382 (modest_mail_operation_update_account):
383 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
384 This should not be necessary anymore. Do not set the conf key that
385 determined this (it was always TRUE and not set anywhere else).
387 * src/modest-ui-actions.h: Remove unused and unimplemented
388 modest_ui_actions_on_online_toggle_toggled().
390 2007-06-29 Murray Cumming <murrayc@murrayc.com
392 * src/maemo/modest-main-window.c: (connect_signals):
393 Don't connect to delete_event twice. Maybe this was harmless.
395 2007-06-29 Murray Cumming <murrayc@murrayc.com
397 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
398 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
399 Debug output to give some more clue when a folder move is not allowed.
401 2007-06-28 Murray Cumming <murrayc@murrayc.com
403 * src/modest-tny-account.c: (on_modest_file_system_info),
404 (modest_tny_account_get_mmc_account_name):
405 Always call the callback, without checking whether the name has changed.
406 * src/widgets/modest-folder-view.c: (strings_are_equal),
407 (on_model_foreach_set_name), (on_get_mmc_account_name),
408 (text_cell_data): Compare the name here, and use the name from
409 the account rather than from the
410 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
411 if the name was changed after the account was added to the model.
412 That's a tinymail bug but not one that I want to fix now.
414 This finally fixes projects.maemo.org bug NB#59301.
416 2007-06-27 Armin Burgmeier <armin@openismus.com>
418 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
421 2007-06-27 Murray Cumming <murrayc@murrayc.com
423 * src/modest-tny-account.h:
424 * src/modest-tny-account.c:
425 Added modest_tny_account_get_mmc_account_name(), to set the memory
426 card name asynchronously for the given account and then notify.
427 (modest_tny_account_new_for_local_folders): Use this new function instead
428 of using hildon_file_system_info_async_new() directly.
430 * src/widgets/modest-folder-view.c: (text_cell_data):
431 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
432 gtk_tree_model_row_changed() when it is available.
434 This should fix projects.maemo.org bug NB#59301.
436 2007-06-27 Murray Cumming <murrayc@murrayc.com
438 * src/modest-mail-operation.c: (update_account_thread),
439 (get_msgs_full_thread): Fix typo failures in the revert
442 2007-06-27 Murray Cumming <murrayc@murrayc.com
444 * src/maemo/modest-maemo-global-settings-dialog.c:
445 (idle_select_default_focus):
446 * src/modest-mail-operation.c: (idle_notify_progress),
447 (idle_notify_progress_once), (set_last_updated_idle),
448 (update_account_thread), (get_msgs_full_thread):
449 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
450 * src/widgets/modest-header-view.c:
451 (idle_notify_headers_count_changed_destroy),
452 (idle_notify_headers_count_changed):
453 Reverted the additions of gdk_threads_enter/leave(), in case this
454 helps with a startup hang on the device.
456 2007-06-26 Armin Burgmeier <armin@openismus.com>
458 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
459 for supported secure authentication methods from server by
460 gtk_dialog_run(), saving CPU time and a potential race condition.
462 2007-06-26 Armin Burgmeier <armin@openismus.com>
464 * src/maemo/modest-maemo-utils.h:
465 * src/maemo/modest-maemo-utils.c: Added a
466 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
467 only error code to tell the calling code when the user canceled the
470 * src/maemo/modest-account-settings-dialog.h:
471 * src/maemo/modest-account-settings-dialog.c:
472 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
473 message if the retrieval of secure authentication methods was canceled
474 by the user. Perform the check before saving anything to configuration
475 to not end up with half-committed configuration changes, do not show
476 a "Saving to configuration failed" note when authentication methods
477 could not be retrieved.
479 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
482 2007-06-26 Murray Cumming <murrayc@murrayc.com>
484 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
485 Only return the first level of folders under accounts, because the
486 osso-global-search UI spec doesn't want the rest.
487 This fixed projects.maemo.org bug NB#61811.
489 2007-06-26 Murray Cumming <murrayc@murrayc.com>
491 * src/modest-tny-account-store.c:
492 * src/modest-tny-account-store.h:
493 Added modest_tny_account_is_memory_card_account().
494 * src/maemo/modest-main-window.c: (create_details_widget):
495 Show the same information items for the memory card as we show for the
496 local-folders, to fix projects.maemo.org bug NB#59307.
498 2007-06-26 Murray Cumming <murrayc@murrayc.com>
500 * src/modest-tny-account-store.c: (get_password):
501 Added some checks for NULL to maybe prevent crashes, though I think
502 it was Philip's last commit that actually prevented the crash here
503 when creating a first new account.
504 But the new account is still not usable (no messages are shown)
505 until a restart of the application.
507 2007-06-26 Murray Cumming <murrayc@murrayc.com>
509 * src/maemo/modest-maemo-global-settings-dialog.c:
510 (idle_select_default_focus):
511 * src/modest-mail-operation.c: (idle_notify_progress),
512 (idle_notify_progress_once), (idle_notify_update_account_queue),
513 (set_last_updated_idle), (update_account_thread),
514 (notify_get_msgs_full), (get_msgs_full_destroyer),
515 (get_msgs_full_thread):
516 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
517 * src/widgets/modest-header-view.c:
518 (idle_notify_headers_count_changed_destroy),
519 (idle_notify_headers_count_changed):
520 Use gdk_threads_enter() and gdk_threads_enter_leave() in
521 all idle handlers, because some other thread could be blocking
522 the GDK lock, so that it can do GUI stuff.
524 2007-06-26 Murray Cumming <murrayc@murrayc.com>
526 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
527 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
528 (on_idle_send_receive), (on_idle_open_default_inbox):
529 * src/maemo/modest-msg-edit-window.c:
530 (modest_msg_edit_window_attach_file_noninteractive):
531 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
532 to prevent a hang. I don't quite understand why these are necessary,
533 beause we should already be in the main loop. I guess something outside
534 of the main loop is taking the lock.
536 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
537 we are really using URIs, and use files that are more likely to exist.
539 2007-06-26 Murray Cumming <murrayc@murrayc.com>
541 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
542 necessary because configure.ac now defines different variables.
544 2007-06-26 Murray Cumming <murrayc@murrayc.com>
546 * libmodest-dbus-client/libmodest-dbus-client.c:
547 * libmodest-dbus-client/libmodest-dbus-client.h:
548 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
549 libmodest_dbus_client_compose_mail() is what things actually use.
551 * src/dbus_api/modest-dbus-api.h:
552 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
553 * tests/dbus_api/Makefile.am:
554 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
557 2007-06-26 Murray Cumming <murrayc@murrayc.com>
559 * src/modest-init.c: (modest_init_local_folders):
560 For memory-card (or other non local-folders) maildir accounts,
561 always create an Archive folder, so that there is somewhere to put
562 messages. This should be less confusing, because the user does not need
563 to guess that the need to create a folder.
565 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
567 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
568 Fixed icon size by using (50, 50) which is the same as defined by
571 2007-06-25 Armin Burgmeier <armin@openismus.com>
573 * src/widgets/modest-window-mgr.c:
575 * configure.ac: Correctly recognize hildon-notify presence and fixed
576 the build without it being installed.
578 2007-06-25 Murray Cumming <murrayc@murrayc.com>
580 * libmodest-dbus-client/libmodest-dbus-client.c:
581 (libmodest_dbus_client_search): Fix the build. Sorry.
582 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
583 (reply_forward_cb): Initialize variables to fix the build.
585 * src/modest-tny-account-store.c:
586 (modest_tny_account_store_get_tny_account_by): Fix the account URI
587 comparison (a silly typo) so that email search results can be opened
588 when there are more than one account.
590 2007-06-25 Murray Cumming <murrayc@murrayc.com>
592 * libmodest-dbus-client/libmodest-dbus-client.c:
593 (libmodest_dbus_client_search),
594 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
595 instead of 1 second, because the search gets folders and messages from
596 the server, which can take a long time. When it times out,
597 osso-global-search will report no results.
599 We need to specify whether we should search only cached information
600 (maybe with a user preference), and the osso-email-search-plugin
601 API should really be improved to allow that option, and to allow results
602 to be delivered asynchronously in batches.
604 2007-06-25 Murray Cumming <murrayc@murrayc.com>
606 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
607 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
608 GTK_ICON_SIZE_DIALOG is probably the wrong size.
610 2007-06-25 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
613 that is an empty string. D-Bus seems to give us these instead of NULL.
615 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
617 * src/dbus_api/modest-dbus-callbacks.c:
618 * src/maemo/easysetup/modest-easysetup-wizard.h:
619 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
620 * src/maemo/modest-connection-specific-smtp-edit-window.c:
621 (modest_connection_specific_smtp_edit_window_init):
622 * src/maemo/modest-maemo-global-settings-dialog.c:
624 * src/maemo/modest-maemo-utils.c:
625 (modest_maemo_utils_setup_images_filechooser):
626 * src/maemo/modest-main-window.c: (create_details_widget):
627 * src/maemo/modest-msg-edit-window.c:
628 (modest_msg_edit_window_attach_file_noninteractive),
629 (modest_msg_edit_window_color_button_change),
630 (modest_msg_edit_window_set_zoom):
631 * src/modest-mail-operation.c: (update_account_thread):
632 * src/modest-tny-account-store.c:
633 * src/modest-tny-account.c:
634 * src/widgets/modest-global-settings-dialog.c:
635 * src/widgets/modest-window.h:
639 2007-06-25 Murray Cumming <murrayc@murrayc.com>
641 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
642 * src/modest-search.c: (modest_search_folder),
643 (modest_search_all_accounts): Actually search only in the specified folder,
644 doing a simple match on the folder ID.
645 * src/modest-search.h: Added a folder field to the ModestSearch struct,
646 and added some documentation.
648 2007-06-22 Armin Burgmeier <armin@openismus.com>
650 * src/maemo/modest-maemo-utils.h:
651 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
652 modest_maemo_utils_get_supported_secure_authentication_methods.
654 * src/maemo/easysetup/modest-easysetup-wizard.c:
655 * src/maemo/modest-account-settings-dialog.c: Show correct error if
656 one occured, not just "Server does not support secure authentication".
658 2007-06-22 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-tny-account-store.c: (get_password):
661 Restored the call to tny_account_set_user() because Philip seems to have
662 stopped this from crashing (by not using the freed string). It still does
663 not work, but now we can test it.
665 2007-06-22 Murray Cumming <murrayc@murrayc.com>
667 * src/maemo/modest-msg-edit-window.c: (init_window):
668 Comment out use of an uninitialzed GtkScrolledWindow variable,
669 to fix the build and stop a crash. Yet again.
671 2007-06-22 Murray Cumming <murrayc@murrayc.com>
673 * src/modest-tny-account-store.c: (get_password):
674 Remove the call to tny_account_set_user() because this actually crashes.
675 As mentioned in the last commit, it is known to not work anyway.
677 2007-06-22 Murray Cumming <murrayc@murrayc.com>
679 * src/modest-tny-account-store.c: (get_password):
680 Use tny_account_set_username() to tell tinymail that the username might
681 have changed too. But tinymail ignores this: see projects.maemo.org
683 * src/modest-ui-actions.c:
684 (modest_ui_actions_on_password_requested): Remove the useless attempt to
685 reset the connection when changing the username, and improve the comments.
686 Save the changed username to gconf at least, so it is used when Modest is
689 2007-06-21 Murray Cumming <murrayc@murrayc.com>
691 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
692 Do not use a query, so that we get all folders, including for POP and
693 local-folders. They work as search criteria too.
694 This fixes projects.maemo.org bug NB#57740.
696 2007-06-21 Murray Cumming <murrayc@murrayc.com>
698 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
699 Comment out the use of hildon_notification_set_sound() because it is
700 not declared, to fix the build. Warnings are serious, people.
702 2007-06-21 Armin Burgmeier <armin@openismus.com>
704 * src/maemo/modest-maemo-utils.h:
705 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
706 modest_maemo_utils_get_supported_secure_authentication_methods()
707 to query authentication methods for a specific user. This should fix
708 projects.maemo.org bug NB#61369.
710 * src/maemo/easysetup/modest-easysetup-wizard.c:
711 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
714 2007-06-21 Murray Cumming <murrayc@murrayc.com>
716 * libmodest-dbus-client/libmodest-dbus-client.h:
717 * libmodest-dbus-client/libmodest-dbus-client.c:
718 (modest_dbus_message_iter_get_search_hit),
719 (libmodest_dbus_client_search):
720 Reorganised and commented this.
721 Removed modest_search_hit_free() from the public API because it
724 Added libmodest_dbus_client_get_folders() and
725 modest_folder_result_list_free().
727 * src/dbus_api/modest-dbus-api.h:
728 * src/dbus_api/modest-dbus-callbacks.c:
729 (modest_dbus_req_filter): Commented. Moved most code to
730 on_dbus_method_search() and added on_dbus_method_get_folders().
732 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
733 of the extra D-Bus handler.
735 * tests/dbus_api/Makefile.am:
736 * tests/dbus_api/test_get_folders.c: New test for
737 libmodest_dbus_client_get_folders(). This seems to return an empty list
738 at the moment. That could be the same error that causes the message list
739 to be empty sometimes.
740 This should help with projects.maemo.org bug NB#57740.
742 2007-06-21 Armin Burgmeier <armin@openismus.com>
744 * src/modest-mail-operation.c: Do not call
745 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
746 notify the operation's end after having set the status to CANCELED for
747 the operation queue to listen on. This fixes a deadlock when there
748 were mail operations in the queue during its finalization.
750 * src/modest-singletons.c: Reordered uninitialization of the account
751 manager to happen after the mail operation queue was uninitialized
752 because the mail operation's in the queue might still try to access
753 the account manager (see modest_mail_operation_notify_end()). This
754 fixes a potential crash when terminating the application.
756 2007-06-21 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-search.c:
759 (search_mime_part_and_child_parts): Moved some code here so we
760 can search recursively in child folders.
761 (modest_search_folder): Search in the message as a mime part, instead
762 of just its child mime parts.
763 (read_chunk), (search_mime_part_ogs):
764 Check how many bytes were read, to prevent an endless loop.
765 Searching in message bodies now works. This finishes the fix for
766 projects.maemo.org bug NB#61007.
768 2007-06-20 Murray Cumming <murrayc@murrayc.com>
770 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
771 Add a g_warning when the item is not a folder.
773 * src/modest-ui-dimming-rules.c:
774 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
775 when selected item is not a folder (for instance, an account), because
776 the UI spec only talks about folders.
777 I am not sure what the UI spec wants, so this might not totally fix
778 projects.maemo.org bug NB#60794.
780 2007-06-20 Murray Cumming <murrayc@murrayc.com>
782 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
783 (load_from_file): Sort the list. The unsorted list would be more noticeable
784 in non-English locales.
786 * src/maemo/modest-msg-edit-window.c:
787 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
788 warning and fix the build.
790 * src/maemo/modest-progress-bar-widget.c:
791 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
792 avoid a g_warning, and probably to avoid a crash.
794 2007-06-20 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-search.c: (modest_search_folder): Check for a GError
797 when calling tny_folder_get_headers(), to show that this is not the cause
800 2007-06-20 Murray Cumming <murrayc@murrayc.com>
802 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
803 Actually set the body query instead of the subject query.
805 * src/modest-search.c: (search_mime_part_ogs),
806 (search_mime_part_strcmp): Remove extra space from the text/* regex,
807 which would probably cause it to fail if we got this far.
809 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
810 to simplify the code.
811 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
812 be causing search-in-body to fail.
814 2007-06-20 Murray Cumming <murrayc@murrayc.com>
816 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
818 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
819 Better debug message when the folder cannot be found.
820 This should help with fixing projects.maemo.org bug #61287.
821 * src/modest-search.c: (add_hit): Do not leak the furl string.
823 2007-06-20 Murray Cumming <murrayc@murrayc.com>
825 * src/modest-ui-actions.c:
826 (modest_ui_actions_on_folder_selection_changed):
827 Do not special-case TNY_MERGE_FOLDER here, because
828 modest_tny_folder_get_account() already does that. This fixes
829 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
830 shown when the Outbox was selected).
832 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
834 * libmodest-dbus-client/libmodest-dbus-client.c:
835 (_dbus_iter_get_string_or_null): Initialize the string variable in
836 case this helps with Dirk's crash.
838 2007-06-19 Murray Cumming <murrayc@murrayc.com>
840 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
841 though it is not implemented yet (this function is maybe not even used),
842 to avoid breaking ABI in future.
843 * libmodest-dbus-client/libmodest-dbus-client.c:
844 (get_attachments_string): Moved some code into this generic function.
845 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
846 sends email. It is maybe not used.
847 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
848 (on_send_mail): Use attachments.
850 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
851 * src/maemo/modest-msg-edit-window.c:
852 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
853 a filename before using it, to fix projects.maemo.org bug NB#58233.
855 2007-06-19 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
858 Initialize the continue_download variable to fix the build, and probably
859 to fix randome behaviour.
861 2007-06-18 Armin Burgmeier <armin@openismus.com>
863 * src/modest-tny-send-queue.h:
864 * src/modest-tny-send-queue.c: Keep track of the status of messages in
865 the queue so we can later show it in the UI. Replaced
866 modest_tny_send_queue_msg_is_being_sent() by
867 modest_tny_send_queue_get_msg_status().
869 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
871 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
872 gpointer. This probably was not harmful, but just to be sure.
874 2007-06-18 Murray Cumming <murrayc@murrayc.com>
876 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
877 Fix the build, but leave the function broken on Bora, because
878 hildon_uri_action_get_service() does not exist.
879 osso_uri_action_get_service() does not exist either, it seems.
881 2007-06-18 Murray Cumming <murrayc@murrayc.com>
883 * src/modest-tny-account.c:
884 (modest_tny_account_new_from_server_account):
885 Uncommented the url debug output again, because it is useful for
886 debugging, as I said in the comment.
888 2007-06-18 Murray Cumming <murrayc@murrayc.com>
890 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
892 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
893 for Mameo Bora, to fix the build.
895 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
898 Fixed build with hildon < 0.99
900 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
901 Check if the selected account is busy instead of checking all accounts
903 * src/modest-account-mgr-priv.h:
904 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
905 (modest_account_mgr_init), (compare_account_name),
906 (modest_account_mgr_set_account_busy),
907 (modest_account_mgr_account_is_busy):
908 * src/modest-account-mgr.h:
909 Added busy information to the account manager. It possible to
910 set an account to busy or not busy now.
912 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
913 (modest_mail_operation_update_account),
914 (modest_mail_operation_notify_end):
915 Set the account to busy/not busy depending on the operation state.
917 * src/widgets/modest-account-view.c:
918 (modest_account_view_finalize), (get_last_updated_string),
919 (update_account_view), (on_account_busy_changed), (init_view):
920 Show string "Refreshing..." if the account is currently busy.
922 All this fixes projects.maemo.org bug NB#59711
924 2007-06-14 Armin Burgmeier <armin@openismus.com>
926 * src/widgets/modest-attachments-view.h:
927 * src/widgets/modest-attachments-view.c: Added
928 modest_attachments_view_has_attachments() and fixed coordinate
929 transformation in get_att_view_at_coords(). This fixes attachment
932 * src/widgets/modest-msg-view.c: Make use of
933 modest_attachments_view_has_attachments() to decide whether to show
934 attachments in the header.
936 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
938 * src/maemo/modest-connection-specific-smtp-edit-window.c:
939 (on_change), (on_combo_security_changed),
940 (modest_connection_specific_smtp_edit_window_init),
941 (modest_connection_specific_smtp_edit_window_set_connection),
942 (modest_connection_specific_smtp_edit_window_is_dirty):
943 * src/maemo/modest-connection-specific-smtp-edit-window.h:
944 * src/maemo/modest-connection-specific-smtp-window.c:
947 Show an comfirmation dialog for the smpt-edit-window if there are
948 unsaved changes and the user hits cancel.
949 (projects.maemo.org bug NB#60479)
951 2007-06-14 Armin Burgmeier <armin@openismus.com>
953 * src/maemo/easysetup/modest-easysetup-wizard.c:
954 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
955 address" info in banner instead of node, and select all the text as
956 per UI spec. This fixes projects.maemo.org bug NB#60550.
958 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
960 reviewed by: <delete if not using a buddy>
962 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
963 * src/modest-ui-actions.c: (folder_refreshed_cb):
965 2007-06-14 Murray Cumming <murrayc@murrayc.com>
967 * src/widgets/modest-folder-view.c: (filter_row):
968 Explictly filter out the per-account outbox accounts. I don't know why
969 these only sometimes show up, but now they should never show up in the UI.
970 This should fix projects.maemo.org bug NB#60160.
972 2007-06-14 Murray Cumming <murrayc@murrayc.com>
974 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
975 when the toolbar does not exist yet.
976 * src/modest-widget-memory.c: (save_settings_header_view):
977 Added g_warnings() to help us to discover when we are trying to set
978 an empty columns list in gconf.
980 2007-06-14 Murray Cumming <murrayc@murrayc.com>
984 Added modest_init_get_default_header_view_column_ids().
986 * src/modest-widget-memory.c: (restore_settings_header_view):
987 Use the new function to get defaults, if the gconf key is empty,
988 instead of not creating any columns. This seems to fix the
989 empty right-hand pane problems.
991 * src/widgets/modest-header-view.h: Improved documentation.
993 2007-06-13 Murray Cumming <murrayc@murrayc.com>
995 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
996 Revert the use of the display name as the account name, because this
997 is generally wrong and would break the code that follows.
999 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1001 * src/maemo/easysetup/modest-easysetup-wizard.c:
1002 (check_for_supported_auth_methods), (on_before_next),
1005 More correct fix for projects.maemo.org bug NB# 58991
1006 Do not longer accept AUTH_PASSWORD as secure method and choose
1007 correct method when creating the account.
1009 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1011 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1012 Fixed projects.maemo.org bug NB# 58991
1014 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1016 * src/modest-init.c: (modest_init_init_core),
1017 (modest_init_local_folders): Fixed compilation errors.
1019 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1021 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1022 Remove unnecessary lib/include, though it is good in principle when needed.
1024 * src/modest-init.c: (modest_init_one_local_folder),
1025 (modest_init_local_folders):
1026 * src/modest-init.h: Initialize the .modest library for memory cards,
1027 instead of just doing nothing for them. This should allow us to create
1028 folders there, fixing projects.maemo.org bug NB#59297.
1030 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1032 * libmodest-dbus-client/libmodest-dbus-client.c:
1033 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1034 (libmodest_dbus_client_compose_mail),
1035 (libmodest_dbus_client_open_message),
1036 (libmodest_dbus_client_send_and_receive),
1037 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1039 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1040 (on_idle_open_message), (modest_dbus_req_handler),
1041 (search_result_to_message), (modest_dbus_req_filter):
1042 * src/modest-search.c: (add_hit), (modest_search_folder),
1043 (modest_search_all_accounts): Improved debug messages.
1045 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1047 * src/modest-tny-account-store.c:
1048 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1051 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1054 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1056 * src/modest-tny-account-store.c: (get_server_accounts):
1057 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1058 even when there are no accounts, so that the Outbox folder is always
1059 visible. This fixes projects.maemo.org bug NB#60158.
1061 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1063 * src/maemo/modest-main-window.c: (create_details_widget):
1064 Use the mcen_va_never logical ID.
1066 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1068 * src/dbus_api/modest-dbus-api.h:
1069 * src/dbus_api/modest-dbus-callbacks.c:
1070 (on_idle_open_default_inbox), (on_open_default_inbox),
1071 (modest_dbus_req_handler):
1072 Added a new OpenDefaultInbox method.
1074 * libmodest-dbus-client/libmodest-dbus-client.h:
1075 * libmodest-dbus-client/libmodest-dbus-client.c:
1076 Added libmodest_dbus_client_open_default_inbox() to call the new
1077 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1078 though it should maybe be used by a new osso-email-interface function.
1080 * tests/dbus_api/Makefile.am:
1081 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1084 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1086 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1087 NULL, so that the signals get all the keys. This should not actually
1088 change any behaviour because we currently update everything when anything
1091 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1093 * src/widgets/modest-folder-view.c: (text_cell_data),
1094 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1095 (find_inbox_iter): If tinymail tells us that the folder is
1096 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1097 This causes the inbox to be selected at startup, fixing part of
1098 projects.maemo.org bug NB#56305.
1100 * src/modest-ui-dimming-rules.c:
1101 (modest_ui_dimming_rules_on_tools_smtp_servers):
1102 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1103 the SMTP servers menu item.
1104 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1105 that the SMTP Servers menu item is dimmed when there are no accounts,
1106 as a future version of the UI spec will require. This fixes
1107 projects.maemo.org bug NB#56305.
1109 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1111 * src/maemo/modest-maemo-utils.c:
1112 (modest_maemo_utils_get_supported_secure_authentication_methods):
1113 Added label to dialog instead of unreadable title
1115 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1116 (modest_main_window_new):
1117 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1120 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1121 * src/modest-account-mgr.h:
1122 Added method to avoid code duplication
1124 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1125 (modest_ui_actions_on_send_receive):
1126 Use modest_account_mgr_has_accounts
1128 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1130 * src/maemo/easysetup/modest-presets.c:
1131 (modest_presets_get_info_server_security): Do not report secure auth
1133 * src/modest-protocol-info.c: Use the defines for the gconf key names
1134 for secure authentication. This was not working because we were writing
1135 Password and reading password, and the check was case sensitive.
1136 With this, gmail now works for receiving and sending when created via
1139 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1141 * src/maemo/easysetup/modest-presets.c:
1142 (modest_presets_get_info_server_security): Correct the key name for
1143 SecureSmtp, because it seems to be case-sensitive.
1144 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1145 Do not try to get the 0th notebook page if there are 0 pages, to
1146 avoid a g_warning().
1148 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1150 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1151 Prevent use of the new notification feature for now, because it currently
1152 shows one dialog for each new email, which is annoying.
1154 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1156 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1157 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1158 when no country was selected, so that we show the global ones.
1159 * src/maemo/easysetup/modest-presets.c:
1160 (modest_presets_get_providers): Return only the global providers, not
1161 all providers when mmc=0 was requested.
1163 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1165 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1166 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1167 provider ID in the combo.
1169 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1170 Do not show the page numbers, because it would be confusing when we add
1171 the 2 extra pages for the custom setup, when the user chooses the "Other"
1172 provider. This fixes projects.maemo.org bug NB#59028
1174 * src/modest-init.c: (modest_init_init_core),
1175 (modest_init_local_folders):
1176 * src/modest-init.h:
1177 * src/modest-tny-account.c:
1178 (modest_tny_account_new_for_local_folders): Do not create default folders
1179 for the memory card. This should fix projects.maemo.org bug NB#59328.
1181 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1183 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1184 Free the changed_conf_keys string items. They are already freed in the
1185 idle handler if that runs first.
1187 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1189 * src/modest-ui-actions.c:
1190 (modest_ui_actions_on_password_requested): Check that the server name
1191 is not NULL, because I just saw a password dialog with (null) as the
1194 * src/modest-tny-folder.[h|c]: Added
1195 modest_tny_folder_is_memory_card_folder().
1196 * src/modest-ui-dimming-rules.c:
1197 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1198 menu item for memory cards, as per the UI spec (section 7.4). This should
1199 fix projects.maemo.org bug NB#59297.
1201 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1203 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1204 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1205 is another problem with the code, see Murray's comment at line 772)
1207 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1209 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1210 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1211 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1212 (load_from_file), (easysetup_country_combo_box_init),
1213 (easysetup_country_combo_box_get_active_country_ids),
1214 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1215 instead of just one ID, to avoid duplicate country names in the UI.
1217 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1218 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1219 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1220 a single ID, avoiding duplicate providers.
1221 * src/maemo/easysetup/modest-easysetup-wizard.c:
1222 (on_combo_account_country): Adapt to use a list.
1224 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1226 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1227 keys changed in the last X seconds.
1229 * src/modest-account-mgr.h:
1230 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1231 (on_key_change), (modest_account_mgr_class_init),
1232 (modest_account_mgr_init), (modest_account_mgr_finalize):
1233 As the keys are changed, save them in a GSList* and signal that GSList*
1234 further every X seconds, to batch changes, to allow us to do just one
1235 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1236 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1238 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1239 changed signal signature.
1241 * src/modest-conf.c: (modest_conf_set_list),
1242 (modest_conf_on_change): Reenable notification.
1244 (modest_conf_maemo_fake_on_change): Comment out the hack that
1245 notified immediately instead of asynchronously.
1247 * src/widgets/modest-account-view.h:
1248 * src/widgets/modest-account-view.c:
1249 (update_account_view): Select the previously-selected account ID,
1250 if possible. This fixes projects.maemo.org bug NB#56933.
1252 (on_account_changed), (on_account_removed),
1253 (modest_account_view_select_account):
1255 Remove the block/unblock functions
1256 because they were not useful.
1258 * src/maemo/modest-account-view-window.c:
1259 (on_delete_button_clicked), (on_edit_button_clicked),
1260 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1262 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1265 Improve the error dialog to show Incorrect Account Settings, which seems
1266 clearer, and say that the internal error message (to be removed from the
1267 dialog later) is often misleading.
1268 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1270 * src/modest-tny-account.c:
1271 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1272 URL because this is so useful for debugging on the device.
1274 * src/widgets/modest-serversecurity-combo-box.c:
1275 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1277 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1279 * src/modest-mail-operation.c:
1280 (modest_mail_operation_send_new_mail):
1281 Added a comment about a nasty but apparently harmless message. Details
1282 added to the wiki g_warnings() page.
1284 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1286 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1287 (modest_tny_send_queue_class_init):
1288 Do not use the priv struct because it is empty, to avoid g_warnings
1289 about a non-existant priv struct.
1291 * src/modest-tny-account-store.c:
1292 (modest_tny_account_store_get_server_account),
1293 (modest_tny_account_store_get_transport_account_for_open_connection
1294 ): Do not try to get transport server accounts for local folders,
1295 because they don't have any. This avoids a g_warning().
1297 * src/maemo/modest-main-window.c:
1298 (modest_main_window_notify_send_receive_initied),
1299 (on_configuration_key_changed):
1300 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1301 * src/modest-defs.h:
1302 * src/modest-mail-operation.c:
1303 (modest_mail_operation_update_account):
1304 * src/modest-tny-account-store.h:
1305 * src/modest-tny-account.c:
1306 (modest_tny_account_get_special_folder),
1307 (modest_tny_account_new_for_local_folders),
1308 (modest_tny_account_new_for_per_account_local_outbox_folder):
1309 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1310 * src/modest-tny-local-folders-account.c:
1311 (add_account_folders_to_merged_folder):
1312 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1313 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1314 (modest_ui_actions_on_send):
1315 * src/widgets/modest-folder-view.c: (update_model):
1316 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1317 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1318 modest_tny_account_store_get_tny_account_by_account() to
1319 modest_tny_account_store_get_server_account() to make the code clearer.
1321 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1323 * src/dbus_api/modest-dbus-api.h:
1324 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1325 * src/maemo/modest-msg-edit-window.c:
1326 (modest_msg_edit_window_attach_file_noninteractive):
1327 added g_warning in case the file to be attached does not exist
1328 * tests/dbus_api/test_compose_mail.c: (main):
1329 removed obsolete comment, added generic files as test case
1331 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-tny-account-store.c: (get_server_accounts):
1334 Create the local folders account only once, not once for each outbox, and
1335 not only when there are some outboxes.
1337 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1339 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1340 code that is causing a crash at startup. Sergio says that he is fixing this.
1342 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1344 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1345 * src/maemo/modest-account-settings-dialog.c:
1346 (create_page_outgoing),
1347 (modest_account_settings_dialog_set_account_name),
1348 (save_configuration):
1349 - Fixed handling of the "Use secure authentication" toggle to comply with
1350 the ui specification. See also projects.maemo.org bug NB#58400
1352 - Restore the Secure connection setting combo correctly when loading
1355 * src/maemo/modest-maemo-utils.c:
1356 (on_camel_account_get_supported_secure_authentication),
1357 (modest_maemo_utils_get_supported_secure_authentication_methods):
1358 Fixed a crasher if operation is canceled
1360 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1361 (modest_protocol_info_auth_is_secure):
1362 * src/modest-protocol-info.h:
1364 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1365 the sense of the "Use secure authentication" toggle.
1367 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1369 * src/modest-tny-account-store.h:
1370 * src/modest-tny-account-store.c:
1371 Added modest_tny_account_store_get_local_folders_account().
1373 * src/modest-tny-folder.h:
1374 * src/modest-tny-folder.c:
1375 (modest_tny_folder_get_account):
1376 Added this replacement for tny_folder_get_account() which returns
1377 the local-folders account for TnyMergeFolders, to avoid the
1378 warning about the unimplemented get_account_func() vfunc().
1380 (modest_tny_folder_get_rules),
1381 * src/modest-ui-actions.c:
1382 (modest_ui_actions_on_folder_selection_changed):
1383 * src/modest-mail-operation.c:
1384 (modest_mail_operation_remove_folder),
1385 (modest_mail_operation_xfer_folder),
1386 (modest_mail_operation_rename_folder),
1387 (modest_mail_operation_get_msg),
1388 (modest_mail_operation_get_msgs_full),
1389 (modest_mail_operation_remove_msg),
1390 (modest_mail_operation_xfer_msgs),
1391 (modest_mail_operation_refresh_folder):
1392 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1394 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1396 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1397 (modest_server_account_set_security):
1398 * src/modest-defs.h: Add comments explaining that our
1399 UI spec means TLS when it says Normal, so these do not look like errors.
1401 * src/modest-tny-account.c:
1402 (modest_tny_account_new_from_server_account): Use the new tinymail
1403 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1404 for TLS. This should fix projects.maemo.org bug NB#58460.
1406 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1408 * src/maemo/easysetup/modest-easysetup-wizard.c:
1409 (create_account): Correct the position of the gconf sanity check warning.
1410 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1411 of using the g_idle_add() hack, because this does not seem to be necessary
1412 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1413 caused by something other than maemo's gconf.
1414 This fixes projects.maemo.org bug #59022.
1416 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1418 * src/modest-account-mgr-helpers.c:
1419 (modest_account_mgr_get_default_account): Do not check that the account
1420 exists if there is no default account (NULL), to fix a runtime warning.
1422 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1424 * src/widgets/modest-folder-view.c: (update_model):
1425 Do not unref the treemodel before we have finished with it.
1426 This prevents a valgrind warning and an occasional crash at startup.
1428 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1430 * libmodest-dbus-client/libmodest-dbus-client.h:
1431 added libmodest_dbus_client_compose_mail()
1432 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1434 added functions needed for SendAsMail() functionality
1435 * src/maemo/modest-msg-edit-window.c:
1436 (modest_msg_edit_window_attach_file_noninteractive):
1437 non interactively attaching files to message edit window
1438 * src/widgets/modest-msg-edit-window.h:
1439 * tests/dbus_api/Makefile.am:
1440 added test_compose_mail.c
1441 * tests/dbus_api/test_compose_mail.c: (main):
1443 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1445 * src/modest-account-view.c:
1446 Fixed bug projects.maemo.org bug NB#59307
1448 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1450 * src/maemo/easysetup/modest-easysetup-wizard.c:
1451 (get_serverport_incoming), (on_before_next), (create_account):
1452 * src/maemo/modest-account-settings-dialog.c:
1453 (modest_account_settings_dialog_set_account_name):
1454 * src/maemo/modest-maemo-utils.c:
1455 (on_camel_account_get_supported_secure_authentication_status),
1456 (on_camel_account_get_supported_secure_authentication),
1457 (on_secure_auth_cancel),
1458 (modest_maemo_utils_get_supported_secure_authentication_methods):
1460 Implemented security authentication for settings and easysetup.
1462 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1464 * src/maemo/modest-main-window.c: (create_details_widget):
1465 Show the total size for memory card accounts too, instead of showing
1466 the name again. Fixes bug projects.maemo.org bug NB#59307.
1468 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-tny-simple-folder-store.c:
1472 * src/modest-tny-simple-folder-store.h: Removed.
1474 * src/modest-tny-local-folders-account.h
1475 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1476 for the local-folders maildir, with an extra TnyMergedFolder containing
1477 the folders of the per-account outbox store accounts.
1478 * src/modest-tny-account-store.c: (get_server_accounts):
1479 Add the outboxes to the special local folders account after creating it.
1481 * src/modest-tny-account.c:
1482 (modest_tny_account_new_for_local_folders): Create the derived
1483 account when creating the main local-folders account.
1485 * src/maemo/modest-main-window.c: (create_details_widget),
1486 (modest_main_window_set_contents_style):
1487 Adapted to the use of the derived account instead of the folder store.
1489 * src/modest-ui-actions.c:
1490 (modest_ui_actions_on_folder_selection_changed):
1491 * src/modest-ui-dimming-rules.c:
1492 (modest_ui_dimming_rules_on_new_folder):
1493 * src/widgets/modest-folder-view.c: (text_cell_data),
1494 (icon_cell_data), (filter_row), (update_model),
1495 (get_cmp_rows_type_pos):
1498 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1499 Do not get the priv struct, because no priv struct has been set,
1500 to avoid a runtime warning.
1502 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1503 #ifelse with #else, to fix a warning, to fix the build.
1506 2007-06-05 Christian Kellner <ckellner@openismus.com>
1508 * libmodest-dbus-client/libmodest-dbus-client.c:
1509 Fix small typo in doc (why do you always see them
1510 AFTER committing stuff?)
1513 2007-06-05 Christian Kellner <ckellner@openismus.com>
1515 * libmodest-dbus-client/libmodest-dbus-client.c:
1516 (libmodest_dbus_client_search):
1517 Initialize hit list with NULL. Also set folder list
1518 to "" if NULL was supplied.
1521 2007-06-03 Christian Kellner <ckellner@openismus.com>
1523 * libmodest-dbus-client/libmodest-dbus-client.c:
1524 (modest_search_hit_list_free):
1525 Make it save to call it with NULL.
1527 * src/dbus_api/modest-dbus-callbacks.c:
1528 * src/modest-search.c:
1529 Return full ModestSearchHits as the search result list not TnyHeader
1530 since can't be around withouth the correspoding TnyFolder.
1532 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1534 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1535 Added currently commented code to check for secure auth
1537 * src/maemo/modest-account-settings-dialog.c: (on_response),
1538 (save_configuration), (show_ok):
1539 Fixed projects.maemo.org bugs NB #59248 and #59251
1541 * src/maemo/modest-maemo-utils.c:
1542 (on_camel_account_get_supported_secure_authentication_status),
1543 (on_camel_account_get_supported_secure_authentication),
1544 (modest_maemo_utils_get_supported_secure_authentication_methods):
1545 * src/maemo/modest-maemo-utils.h:
1546 Moved get_supported_secure_authentication() method here to be able
1547 to use it from easysetup wizard.
1549 * src/modest-pair.c: (on_pair_compare_as_string):
1550 Should compare string with first part of pair and not
1551 strcmp pairs which will crash.
1553 * src/modest-protocol-info.c:
1554 (modest_protocol_info_protocol_is_store):
1555 * src/modest-protocol-info.h:
1556 Added modest_protocol_info_get_auth_protocol_name()
1558 2007-06-03 Armin Burgmeier <armin@openismus.com>
1560 * src/modest-mail-operation.c:
1561 (modest_mail_operation_get_msgs_full): Set priv->account also when
1562 only retrieving a single message. This avoids a crash when canceling
1565 (modest_mail_operation_notify_end): Do not explicitely remove the
1566 operation from the queue but only emit the progress_changed signal.
1567 The queue itself listens to that signal to remove the operation when
1568 it is finished. This reduces coupling and removes a potential deadlock
1569 when modest_mail_operation_notify_end() is called from the queue
1570 itself. If that is a problem performance-wise, I would suggest to
1571 implement a status-changed signal or something.
1573 * src/modest-mail-operation-queue.c: Make sure to never call a
1574 function from another file while the queue is locked. This (hopefully)
1575 fixes another deadlock when exiting the application while retrieving
1578 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1580 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1581 Fixed build if libogs is not available
1583 2007-06-03 Christian Kellner <ckellner@openismus.com>
1585 * libmodest-dbus-client/libmodest-dbus-client.h:
1586 * libmodest-dbus-client/libmodest-dbus-client.c:
1587 (libmodest_dbus_client_delete_message):
1588 Implement deletion of messages (Client side).
1590 (modest_search_hit_free),
1591 (modest_search_hit_list_free):
1592 Utility functions to free the result hits.
1594 * src/dbus_api/modest-dbus-api.h:
1595 * src/dbus_api/modest-dbus-callbacks.c:
1596 (on_delete_message),
1597 (modest_dbus_req_handler):
1598 Implement deletion of messages (Server side).
1600 * tests/dbus_api/test_search.c: (main):
1603 * tests/dbus_api/Makefile.am:
1604 * tests/dbus_api/test_delete_message:
1605 Add little test for the message deletion logic
1607 2007-06-03 Armin Burgmeier <armin@openismus.com>
1609 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1610 when the operation queue was not empty. projects.maemo.org bug
1613 2007-06-03 Armin Burgmeier <armin@openismus.com>
1615 * src/widgets/modest-account-view.c
1616 (on_account_default_toggled): Toggle default account column
1617 explicitely instead of waiting for gconf notification (which is
1618 currently ignored). This should fix projects.maemo.org bug NB#56910
1619 for now. It should probably be removed when gconf notifications are
1622 2007-06-03 Christian Kellner <ckellner@openismus.com>
1624 * libmodest-dbus-client/libmodest-dbus-client.c:
1625 Removed debugging spew.
1627 * src/dbus_api/modest-dbus-callbacks.c:
1628 Added debugging info.
1630 * src/modest-search.c:
1631 (modest_search_all_accounts):
1632 Use tny_account_store_get_accounts () on the account store
1633 to get all accounts which is the way to get all accounts.
1635 * tests/dbus_api/test_search.c: (main):
1636 Make it possible to supply the search term on the command line.
1638 2007-06-03 Christian Kellner <ckellner@openismus.com>
1640 * libmodest-dbus-client/libmodest-dbus-client.c:
1641 * libmodest-dbus-client/libmodest-dbus-client.h:
1642 Implement searching for mesages over raw dbus. (Client side)
1644 * src/dbus_api/Makefile.am:
1645 * src/dbus_api/modest-dbus-api.h:
1646 * src/dbus_api/modest-dbus-callbacks.c:
1647 * src/dbus_api/modest-dbus-callbacks.h:
1648 Search framework (Server side). Also implement on_idle_open_message().
1650 * src/maemo/modest-platform.c: (modest_platform_init):
1651 Prepare for raw dbus/osso rpc interaction.
1653 * src/modest-search.h:
1654 Changed minsize from unspecific guint to guint32.
1656 * src/modest-search.c:
1658 Added strange hack which magically made tnymail work.
1660 (modest_search_folder),
1661 (modest_search_account),
1662 (modest_search_all_accounts):
1663 Implement helper functions to search all accounts, specific account
1666 * tests/dbus_api/Makefile.am:
1667 * tests/dbus_api/test_open_message.c:
1668 Read url to open from commandline.
1670 * tests/dbus_api/test_search.c:
1671 Implement small test for dbus search stuff
1673 2007-06-02 Armin Burgmeier <armin@openismus.com>
1675 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1676 include account type and account title. This fixes projects.maemo.org
1679 * src/maemo/modest-account-view-window.c: Set a title for the window.
1681 2007-06-02 Armin Burgmeier <armin@openismus.com>
1683 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1684 incoming and outgoing server name based on email address and server
1685 types as long as the names have not been edited manually. This fixes
1686 projects.maemo.org bug NB#58671.
1688 2007-06-02 Armin Burgmeier <armin@openismus.com>
1690 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1691 server type cannot be changed in future to the incoming details page
1692 when creating an account. This fixes projects.maemo.org bug NB#59029.
1694 2007-06-02 Armin Burgmeier <armin@openismus.com>
1696 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1697 and assigned max width chars so that they wrap instead of being
1698 truncated. Fixes projects.maemo.org bug NB#56126.
1700 2007-06-02 Armin Burgmeier <armin@openismus.com>
1702 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1703 introductory note to the connection specific smtp servers dialog, as
1704 section 8.12 of the email UI specification requires. This fixes
1705 projects.maemo.org bug NB#59212.
1707 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1709 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1710 Check for running mail operations, and offer to cancel them, as per the UI
1711 spec. This fixes projects.maemo.org bug NB#59041 .
1712 However, I suspect that tinymail may still use the network connection
1713 in ways that we cannot detect or cancel. But it should at least adapt to
1714 changes fairly well.
1716 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1718 * src/modest-tny-account-store.c: (recreate_all_accounts),
1719 (get_cached_accounts), (get_server_accounts): Do more sensible
1720 ref-counting of the temporarily-cached outbox accounts list. This seems
1721 to fix a crash when entering the password when the password was wrong.
1723 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1725 * src/gnome/modest-main-window.c: (connect_signals):
1726 * src/modest-tny-account-store.c: (get_password),
1727 (modest_tny_account_store_alert): Added comments and clues and
1728 commented-out code about how we currently fail to deal with connection
1729 errors and wrong passwords, and how we should.
1731 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1733 * src/widgets/modest-retrieve-combo-box.c:
1734 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1735 This fixes projects.maemo.org bug NB#58472 .
1737 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1739 * src/maemo/easysetup/modest-easysetup-wizard.c:
1740 (create_page_complete_easysetup):
1741 (create_page_complete_custom): Correct the last commit,
1742 putting the correct sentences in the correct pages.
1744 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1746 * src/maemo/easysetup/modest-easysetup-wizard.c:
1747 (create_page_complete_custom): Show the second sentence of text
1748 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1751 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1754 Set the leave-on-server conf key by default. This fixes
1755 projects.maemo.org bug NB#59258 .
1757 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1759 * src/maemo/modest-account-view-window.c:
1760 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1761 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1764 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1766 * src/maemo/easysetup/modest-easysetup-wizard.c:
1767 (create_caption_new_with_asterisk):
1768 * src/maemo/modest-account-settings-dialog.c:
1769 (create_caption_new_with_asterisk):
1770 Uncomment the code to add the asterisk, because they are no longer in the
1771 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1772 (update_incoming_server_title): Add an asterisk here too.
1774 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1776 * src/maemo/modest-maemo-global-settings-dialog.c:
1777 (current_connection): Check that we are even connected before trying to
1778 get the current connection name, to prevent a warning.
1780 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1781 Change the comments because tny_maemo_conic_device_connect() is now meant to
1783 * src/modest-mail-operation.c:
1784 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1785 make sure we have a connection and fail if we can't connect.
1787 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1789 * src/maemo/modest-main-window.c:
1790 (on_account_store_connecting_finished): Do not try to get the
1791 connection ID if we are not really connected. I am surprised that
1792 this signal handler is called when we are not connected.
1794 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1796 * src/modest-error.h:
1797 * src/modest-ui-actions.c:
1798 (modest_ui_actions_get_msgs_full_error_handler):
1799 Renamed an enum, added comments, added an enum
1800 for retrieve-limit errors.
1802 * src/modest-mail-operation.c: (foreach_add_item),
1803 (internal_folder_observer_update), (update_account_thread),
1804 (modest_mail_operation_get_msgs_full):
1805 (modest_mail_operation_update_account),
1806 Added comments about how this works, and some code that should
1807 (but does not) check the retrieve-limit. See the TODO comment.
1809 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1811 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1812 Initialize help_id to fix the build. Warnings are good.
1814 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1816 * src/widgets/modest-hbox-cell-renderer.c:
1817 (modest_hbox_cell_renderer_append):
1818 * src/widgets/modest-vbox-cell-renderer.c:
1819 (modest_vbox_cell_renderer_append):
1820 Fix the last commit by doing an extra ref.
1822 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1824 * src/widgets/modest-hbox-cell-renderer.c:
1825 (modest_hbox_cell_renderer_append):
1826 * src/widgets/modest-vbox-cell-renderer.c:
1827 (modest_vbox_cell_renderer_append):
1828 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1829 to fix the build with Maemo Bora.
1830 However, there seems to be a remaining crash, probably due to reference
1833 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-tny-account.c:
1836 (modest_tny_account_new_for_local_folders):
1837 Use hildon_file_system_info_async_new() to get a better name for
1838 the memory card account, setting it as the account name.
1839 The timing seems to work, but this is probably
1840 not the best place to do this. See the TODO comment.
1841 * src/maemo/modest-main-window.c: (create_details_widget):
1842 * src/widgets/modest-folder-view.c: (text_cell_data):
1843 Use the tny account name instead of hardcoding a name.
1845 2007-05-30 Christian Kellner <ckellner@openismus.com>
1847 * src/modest-search.c: (modest_search):
1848 Correctly set part_search_func even if we have already parsed
1849 the query and thus a valid OgsTextSearcher object.
1851 2007-05-30 Christian Kellner <ckellner@openismus.com>
1854 Search and check for libogs.
1857 Incooparte the ogs build env.
1859 * src/modest-mime-part-search-stream.c:
1860 * src/modest-mime-part-search-stream.h:
1861 Removed since we do the real searching now in modest-search.c.
1863 * src/modest-search.c:
1864 * src/modest-search.h:
1865 Implement support for ogs. We use that if available and requested
1866 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1867 should now handle the corner case when the search term is spread
1868 across multiple reads.
1869 Also the logic in modest_search () was corrected to search all
1870 requested fields until one is found.
1872 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1876 * src/modest-init.h:
1877 * src/modest-init.c: Made modest_init_local_folders() take a
1878 path and be public so we can iniitialize maildir folders on
1881 * src/modest-local-folder-info.h:
1882 * src/modest-local-folder-info.c:
1883 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1885 * src/modest-tny-account.c:
1886 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1887 still means the standard local-folders path on the local volume.
1889 * src/modest-tny-account-store.c:
1890 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1891 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1892 all accounts when that happens.
1893 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1894 this too, so it shows up in the treeview.
1896 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1898 * src/maemo/modest-maemo-global-settings-dialog.c:
1899 (current_connection):
1900 * src/widgets/modest-global-settings-dialog.c:
1901 (current_connection_default):
1902 Use the enum values instead of 0, 1 and -1,
1903 to make the code clearer.
1905 * src/modest-account-mgr-helpers.c:
1906 (modest_account_mgr_get_connection_specific_smtp): Make this code
1909 * src/modest-runtime.h:
1910 * src/modest-runtime.c:
1911 Added modest_runtime_remove_all_send_queues().
1912 * src/maemo/modest-main-window.c:
1913 (on_account_store_connecting_finished): Recreate the send queues,
1914 using the appropriate transport accounts for this new connection.
1915 Some futher adapting might be needed if the old send queues are not
1916 automatically stopped at this point.
1918 * src/modest-tny-account-store.c: (get_server_accounts):
1919 Create the connection-specific transport accounts, so that they can
1920 be found later by their ID.
1922 * src/modest-tny-account.h:
1923 * src/modest-tny-account.c:
1924 Added modest_tny_account_new_from_server_account_name().
1925 modest_tny_account_new_from_server_account(): Do not create the
1926 send queues here, because they will be
1927 recreated anyway when the connection changes for the first time.
1929 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1931 * src/modest-local-folder-info.h:
1932 * src/modest-local-folder-info.c:
1933 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1934 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1935 tbox_folder): Take a modest account name instead of a server TnyAccount,
1936 so we can have per-modest-account rather than per-transport-account
1938 We must make sure that we change or recreate the exisitng send queues
1939 when the connection changes for connection-specific transport accounts.
1941 * src/modest-tny-account-store.c:
1942 (create_per_account_local_outbox_folders): Create outboxed per modest
1943 account, not per transport account.
1945 * src/modest-tny-account.h:
1946 * src/modest-tny-account.c:
1947 (modest_tny_account_get_special_folder): For outboxes, get the
1948 parent modest account name. The account is ignored for other folders.
1949 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1950 modest account name rather than a server TnyAccount.
1952 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1954 * src/modest-tny-account.c:
1955 (modest_tny_account_new_from_server_account):
1956 Call modest_runtime_get_send_queue() immediately after creating transport
1957 accounts, so that they start trying to send email from the outbox as soon
1958 as possible at startup. This is probably what we want.
1960 * src/modest-mail-operation.c: (update_account_thread):
1961 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1962 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1963 * src/modest-tny-send-queue.h:
1964 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1965 (modest_ui_actions_on_send):
1966 Added comments about how sending works, though it needs some more work.
1968 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1970 * src/modest-tny-account.c:
1971 (modest_tny_account_get_special_folder): Add TODO because this fails when
1972 the network is busy.
1973 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1974 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1975 Do not try to show this window when there is no active account. The UI
1976 specs does not tell us what to do in this case.
1978 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/Makefile.am:
1983 * src/widgets/Makefile.am: Some dist fixes.
1985 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1987 * src/maemo/modest-connection-specific-smtp-window.c:
1988 (on_button_edit): Make the code clearer, to prevent a double free.
1990 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1992 * src/maemo/modest-account-settings-dialog.c:
1993 (modest_account_settings_dialog_set_account_name),
1994 Check the connection-specific smtp servers checkbox if there are any.
1996 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1997 (modest_connection_specific_smtp_edit_window_init):
1998 Start with a suitable port number.
2000 * src/modest-account-mgr-helpers.h:
2001 * src/modest-account-mgr-helpers.c: Added
2002 modest_account_mgr_get_has_connection_specific_smtp().
2004 (modest_account_mgr_set_connection_specific_smtp),
2005 (modest_account_mgr_remove_connection_specific_smtp),
2006 (modest_account_mgr_get_has_connection_specific_smtp),
2007 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2008 connection-specific smtp server accounts in the account, rather than
2009 the server account conf dir.
2011 This fixes bug projects.maemo.org bug NB#58263 .
2013 * src/modest-tny-account-store.c:
2014 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2015 if there are no server accounts yet, to prevent an infinite loop when there
2016 are no accounts. Document that one must be called before the other.
2018 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2020 * src/modest-account-mgr-helpers.c:
2021 (modest_account_mgr_get_default_account): Make sure that at least
2022 one account is always the default, if there are any enabled accounts.
2023 This is just a sanity check that shouldn't be necessary.
2025 * src/modest-account-mgr-priv.c:
2026 (_modest_account_mgr_account_from_key): Unescape the conf key to
2027 get the real account name. For instance, this is an issue if a space
2028 was in the account name, which can happen because the account name
2029 is generated from the display name.
2030 (_modest_account_mgr_get_account_keyname): Always escape the
2032 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2033 Unescape the conf keys to get the real account names.
2035 For instance, previously the is-default radio button in the accounts
2036 list was not checked for any accounts at first. This fixes that,
2037 and might fix several similar bugs.
2039 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2042 Removed some debug printfs.
2044 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2046 Modest on-disk outbox directories are now here, for instance:
2047 $HOME/.modest/outboxes/<account-id-1>/outbox
2048 $HOME/.modest/outboxes/<account-id-2>/outbox
2050 $HOME/.modest/local-folders/outbox
2051 so we can have a separate outbox for each account.
2052 But they are shown as one outbox in the GtkTreeView, by using a
2053 TnyMergeFolder in a ModestTnySimpleFolderStore.
2056 * src/modest-tny-simple-folder-store.c:
2057 * src/modest-tny-simple-folder-store.h:
2058 Added ModestTnySimpleFolderStore, used to contain folders from
2059 other folder stores, such as other accounts.
2061 * src/modest-tny-outbox-account.h:
2062 * src/modest-tny-outbox-account.c:
2063 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2064 used for the per-account local outbox folders.
2066 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2067 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2068 only use this (internally) now for the non-outbox local folders.
2070 * src/modest-init.h:
2071 * src/modest-init.c: Added modest_init_one_local_folder(), for
2072 setting up the directory structure for each local folder.
2074 * src/modest-local-folder-info.c:
2075 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2076 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2078 * src/modest-local-folder-info.h:
2079 * src/modest-tny-account-store.c: (on_account_removed),
2080 (on_account_changed), (create_per_account_local_outbox_folders),
2081 (get_server_accounts), (modest_tny_account_store_get_accounts),
2082 (modest_tny_account_store_get_tny_account_by_account),
2083 (modest_tny_folder_store_is_virtual_local_folders):
2085 * src/modest-tny-account.h:
2086 * src/modest-tny-account.c:
2087 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2088 to create an on-disk per-account local outbox folder for each
2090 (create_per_account_local_outbox_folders): Create a local outbox folder
2091 for each transport account.
2092 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2093 for all local folders.
2095 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2096 instead of using g_object_get/set() directly. It is clearer.
2098 (modest_tny_folder_store_get_message_count),
2099 (modest_tny_folder_store_get_local_size
2100 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2101 because we now use these with non-acount folder stores.
2103 (modest_tny_account_get_special_folder),
2104 (modest_tny_account_new_from_server_account),
2105 (modest_tny_account_new_from_account):
2106 (recurse_folders): Adjust to the new outbox system.
2108 * src/modest-tny-folder.h:
2109 * src/modest-tny-folder.c:
2110 (modest_tny_folder_is_local_folder),
2111 (modest_tny_folder_get_local_folder_type),
2112 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2114 * src/widgets/modest-main-window.h:
2115 * src/maemo/modest-main-window.c: (create_details_widget),
2116 (modest_main_window_set_contents_style): Show details for any folder store,
2119 (modest_tny_folder_get_rules):
2120 Remove the const. C does not support constness enough for this.
2122 * src/modest-ui-actions.c:
2123 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2124 make all outboxes appear as one, in the usual local-folders tree node.
2126 (set_active_account_from_tny_account),
2127 (modest_ui_actions_on_folder_selection_changed):
2128 * src/widgets/modest-folder-view.c: (text_cell_data),
2129 (icon_cell_data), (filter_row),
2130 (add_account_folders_to_merged_folder),
2131 (add_account_folders_to_simple_folder_store), (),
2132 (get_cmp_rows_type_pos), (cmp_rows),
2133 (modest_folder_view_set_account_id_of_visible_server_account):
2134 Adjust to the new outbox system, using generic folder stores and folders
2135 in the GtkTreeModel.
2137 2007-05-23 Christian Kellner <ckellner@openismus.com>
2139 * src/modest-mail-operation.c:
2140 (modest_mail_operation_update_account):
2141 Use info->max_size instead of unintialized local var [small
2142 build fix]. (Added TODO to review that change since I don't
2145 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2147 * libmodest-dbus-client/libmodest-dbus-client.c:
2148 (libmodest_dbus_client_compose_mail): function added
2149 * src/dbus_api/modest-dbus-api.h:
2150 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2151 (on_compose_mail): Implementation of the SendAsMail functionality
2153 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2155 * src/modest-account-mgr.c:
2156 (modest_account_mgr_add_server_account): Set the secure-connection
2157 conf key for transport accounts as well as store accounts. I don't know
2158 why the if was there. For instance, this makes sure that we use SSL
2159 for the gmail preset from the easysetup wizard.
2161 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2163 * src/gnome/modest-main-window.c:
2164 (on_account_store_connecting_finished), (connect_signals):
2165 * src/maemo/modest-main-window.c:
2166 (on_account_store_connecting_finished), (connect_signals),
2167 (modest_main_window_new):
2168 Handle TnyAccountStore::connecting-finished instead of
2169 TnyDevice::connection-changed, because we cannot actually perform
2170 operations on accounts until TnyAccountStore has itself responded to
2171 the TnyDevice::connection-changed signal. This prevents a GError from
2173 Do not try to update at startup, because we (at least on scratchbox)
2174 already do an update at startup when the device goes online.
2175 This prevents a GError from tinymail.
2176 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2177 Added TODO about stopping simultaneous operations.
2179 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2181 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2182 * src/modest-mail-operation-queue.c:
2183 (modest_mail_operation_queue_remove):
2184 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2185 about where they happened.
2187 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2189 * src/modest-ui-actions.c:
2190 (modest_ui_actions_on_password_requested): Make sure that the remember
2191 output parameter is always TRUE.
2193 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2195 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2196 Show a OK/Cancel dialog if the error is a question, though we still do not
2197 know anything more about what we are asking the user.
2198 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2199 Fix an uninitialized variable (helper). This is a logic error, however.
2201 2007-05-21 Christian Kellner <ckellner@openismus.com>
2203 * src/modest-search.h:
2204 Correct bit shifting in the ModestSearchFlags enum.
2206 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2208 * src/modest-tny-account.c:
2209 (modest_tny_account_new_from_server_account): Do not use the lsub and
2210 check-all hard-coded IMAP options when using POP.
2212 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2214 * src/modest-tny-account.c:
2215 (modest_tny_account_new_from_server_account):
2216 Use NULL for the secure-auth method for POP when Password auth has been
2217 specified by the user, as we already do for IMAP. "auth=Login" causes
2218 an error from camel or the server.
2220 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2222 * src/maemo/modest-account-settings-dialog.c:
2223 (create_page_account_details),
2224 (modest_account_settings_dialog_set_account_name):
2225 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2226 for the leave-on-server checkbox, rathr than just the checkbox, when
2227 the protocol is not POP.
2229 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2231 * src/widgets/modest-account-view.c:
2232 * src/widgets/modest-account-view.h:
2233 Added modest_account_view_select_account() which will be useful later
2234 to asynchronously re-select the edited account.
2236 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2238 * src/maemo/modest-account-settings-dialog.c:
2239 (modest_account_settings_dialog_set_account_name):
2240 Automatically choose the port numbers based on the secure authentication
2241 methods, if they have not been chosen before.
2242 This fixes projects.maemo.org bug NB#56273 .
2244 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2246 * src/maemo/modest-main-window-ui.h:
2247 * src/modest-ui-actions.c:
2248 * src/modest-ui-actions.h:
2249 Connect the Tools/SMTP Servers menu item to
2250 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2251 SMTP servers dialog, as in the UI specification and saves changes when it
2252 is closed. This fixed projects.maemo.org bug NB#56305 .
2254 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2256 * src/maemo/modest-connection-specific-smtp-window.c:
2257 (modest_connection_specific_smtp_window_init):
2258 Use gtk_window_set_default_size() to make this window big enough, so
2259 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2261 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2263 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2264 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2265 (modest_connection_specific_smtp_edit_window_init),
2266 Do not try to connect to a combobox signal before the combobox exists.
2267 This fixes the cras in projects.maemo.org bug NB#56288 .
2268 (modest_connection_specific_smtp_edit_window_get_settings):
2269 Remove the server_account_name parameter which was being checked for NULL
2270 though it was not used.
2272 * src/maemo/modest-connection-specific-smtp-window.c:
2273 (modest_connection_specific_smtp_window_fill_with_connections),
2274 (on_button_edit), (modest_connection_specific_smtp_window_init):
2275 Correct the number of treemodel columns to prevent a warning.
2276 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2277 libconic does not work.
2279 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2281 * src/modest-tny-account.c:
2282 (modest_tny_account_new_from_server_account):
2283 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2284 SMTP when "None" was chosen by the user. However, with my SMTP server that
2285 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2288 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2290 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2291 to explain the memory management issue with the ID in the ModestPair.
2293 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2294 (add_sending_page), (modest_account_assistant_finalize):
2295 * src/gnome/modest-gnome-global-settings-dialog.c:
2296 (create_updating_page), (create_composing_page):
2297 * src/gnome/modest-msg-edit-window.c: (get_transports),
2298 (init_window), (modest_msg_edit_window_finalize),
2299 (modest_msg_edit_window_get_msg_data):
2300 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2301 * src/gnome/modest-transport-widget.c:
2302 (modest_transport_widget_finalize), (smtp_configuration):
2303 * src/maemo/modest-maemo-global-settings-dialog.c:
2304 (create_updating_page), (create_composing_page):
2305 * src/maemo/modest-msg-edit-window.c: (get_transports),
2306 (init_window), (modest_msg_edit_window_finalize),
2307 (modest_msg_edit_window_get_msg_data),
2308 (modest_msg_edit_window_free_msg_data):
2309 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2310 (modest_store_widget_finalize):
2311 * src/maemo/modest-transport-widget.c:
2312 (modest_transport_widget_finalize), (smtp_configuration):
2313 * src/modest-main.c: (send_mail):
2314 * src/widgets/modest-combo-box.h:
2315 * src/widgets/modest-global-settings-dialog-priv.h:
2316 * src/widgets/modest-global-settings-dialog.c:
2317 (modest_global_settings_dialog_finalize):
2318 * src/widgets/modest-msg-edit-window.h:
2319 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2320 as long as the combo box, to prevent use of freed memory for the ID.
2322 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2324 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2325 get_accounts(), to make this clearer. Do not check for the enabled gconf
2326 key, because we do not use this for server accounts (at least, not yet).
2327 This allows us to send email again.
2329 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2331 * src/maemo/modest-platform.c:
2332 (on_modest_conf_update_interval_changed), (modest_platform_init):
2333 Only respond to this particular key change. All these strcmp()s cannot be
2336 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2338 * src/maemo/modest-maemo-global-settings-dialog.c:
2339 (current_connection): Prevent a crash in scratchbox when
2340 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2341 * src/maemo/modest-platform.c:
2342 (on_modest_conf_update_interval_changed), (modest_platform_init):
2343 Get the update interval from gconf and reset it when the gconf key changes.
2345 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2347 * src/modest-protocol-info.c:
2348 * src/modest-protocol-info.h: Adde enum-specific get functions,
2349 instead of using a ModestProtocolType enum parameter.
2351 * src/gnome/modest-account-assistant.c:
2352 * src/gnome/modest-store-widget.c:
2353 * src/gnome/modest-store-widget.h:
2354 * src/gnome/modest-transport-widget.c:
2355 * src/gnome/modest-transport-widget.h:
2356 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2357 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2358 * src/maemo/easysetup/modest-easysetup-wizard.c:
2359 * src/maemo/modest-account-settings-dialog.c:
2360 * src/maemo/modest-account-settings-dialog.h:
2361 * src/maemo/modest-store-widget.c:
2362 * src/maemo/modest-store-widget.h:
2363 * src/maemo/modest-transport-widget.c:
2364 * src/maemo/modest-transport-widget.h:
2365 * src/modest-account-mgr-helpers.c:
2366 * src/modest-account-mgr-helpers.h:
2367 * src/modest-account-mgr.c:
2368 * src/modest-account-mgr.h:
2369 * src/modest-tny-account.c:
2370 * src/modest-tny-folder.c:
2371 * src/widgets/modest-account-view.c:
2372 * src/widgets/modest-retrieve-combo-box.c:
2373 * src/widgets/modest-retrieve-combo-box.h:
2374 * src/widgets/modest-secureauth-combo-box.c:
2375 * src/widgets/modest-serversecurity-combo-box.c:
2376 * src/widgets/modest-serversecurity-combo-box.h:
2377 * tests/check_account-mgr.c:
2378 Use the specific functions, and use the re-renamed enum values for GNOME too.
2380 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2382 * src/modest-pair.h:
2383 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2384 so we can get the second based on the first.
2386 * src/maemo/modest-account-settings-dialog.h:
2387 * src/maemo/modest-account-settings-dialog.c:
2388 Added get_supported_secure_authentication_methods(), though it is mostly
2389 commented-out for now until the necessary API is committed to tinymail.
2390 (modest_account_settings_dialog_set_account_name),
2391 (save_configuration): Request the supported authentication methods from the
2392 server, so we can choose a working method.
2394 * src/modest-tny-account-store.h:
2395 * src/modest-tny-account-store.c:
2396 (modest_tny_account_store_get_session): Rename from
2397 tny_account_store_get_session().
2399 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2401 * src/modest-protocol-info.h: Split the ModestProtocol enum
2402 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2403 There was no need to have these unrelated values in one enum.
2405 * src/: many files: Adapted to changed enum. This makes the code a bit
2406 clearer, and the compiler could catch some errors.
2408 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2410 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2411 Show the detailed internal camel error message when an error happens
2412 during the configuration, so that our testers can give us more clues.
2413 For instance, in projects.maemo.org bug NB#56910 .
2415 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2417 * src/modest-tny-account.c:
2418 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2419 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2421 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2423 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2424 * src/maemo/modest-account-settings-dialog.c:
2425 (modest_account_settings_dialog_set_account_name),
2426 (save_configuration): For the incoming secure authentication checkbox,
2427 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2428 the UI specification. PLAIN does not seem to be supported for most IMAP
2429 servers anyway, and I am not sure what it would mean.
2430 However, we probably need to discover which of the secure-authentication
2431 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2432 * src/modest-account-mgr-helpers.c:
2433 (modest_account_mgr_get_server_account_data):
2435 * src/modest-tny-account.c:
2436 (modest_tny_account_new_from_server_account):
2437 Use tny_account_set_mech() to set secure-authentication methods,
2438 with some special-casing for IMAP, based on my observations of how
2441 * src/modest-account-mgr-helpers.h:
2442 * src/modest-account-mgr.c:
2443 * src/modest-defs.h: Comment that the URI is only used for local folders.
2445 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2447 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2448 parameter const, just to be neat.
2449 * src/modest-text-utils.c: (modest_text_utils_inline):
2450 End g_strconcat() with NULL, as its documentation says. This is almost
2451 certainly the cause of my crash at startup on the device. Interestingly,
2452 valgrind doesn't tell us about these errors.
2454 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2456 * scripts/build-packages: Added more precise comments about how to use
2457 this script, though I still get this error:
2458 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2459 error building tinymail
2461 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2463 * src/maemo/modest-main-window.c: (on_account_update):
2464 Very slight cleanup, hoping to make it simpler to discover what causes
2465 a crash here sometimes.
2467 * src/modest-tny-account.c:
2468 (modest_tny_account_new_from_server_account): Set the port. Added
2469 comments about the options and a TODO comment because I need to find out
2470 how to specify the secure authentication method.
2472 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2474 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2475 changed CFlags paths form modest to libmodest
2477 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2479 * src/modest-account-mgr-helpers.c:
2480 (modest_account_mgr_get_server_account_data),
2481 (modest_account_mgr_free_server_account_data):
2482 * src/modest-account-mgr-helpers.h:
2483 * src/modest-account-mgr.c:
2484 (modest_account_mgr_add_server_account):
2485 * src/modest-defs.h:
2486 * src/modest-tny-account.c:
2487 (modest_tny_account_new_from_server_account):
2488 Determine the options for tny_camel_account_add_option() here,
2489 based on the settings, rather than storing them directly in gconf.
2491 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2493 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2494 Show a more friendly error dialog now that we expect (from the tinymail
2495 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2497 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2499 * src/maemo/modest-main-window.c: (on_account_update): Check that
2500 account_name is not NULL, to prevent a crash at startup that I am
2501 seeing on the N800. I do wonder why it is NULL.
2503 * src/maemo/easysetup/modest-easysetup-wizard.c:
2504 (create_page_user_details):
2505 * src/maemo/modest-account-settings-dialog.c:
2506 (create_page_user_details), (create_page_outgoing):
2507 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2508 (modest_connection_specific_smtp_edit_window_init):
2509 * src/modest-ui-actions.c:
2510 (modest_ui_actions_on_password_requested):
2511 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2512 might do something useful with the on-screen keyboard.
2514 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2516 * src/maemo/modest-main-window.c: (on_account_update):
2517 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2518 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2520 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2522 * src/modest-tny-account-store.c: (on_account_changed):
2523 Correct the signature of this signal handler.
2525 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2527 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2528 Show a HildonNote instead of a GtkDialog for Maemo.
2530 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2532 * src/widgets/modest-account-view.h:
2533 * src/widgets/modest-account-view.c: (on_account_changed),
2534 (on_account_removed). Added a boolean flag, set/unset by
2535 modest_account_view_block_conf_updates(),
2536 modest_account_view_unblock_conf_updates() to prevent unnecessary
2537 updates, but this is not very useful because the gconf notifications are
2538 so delays (maybe only on Maemo Bora).
2539 So auto-updating is turned off, and these functions do an explicit
2540 update when necessary.
2541 However, something else is still doing too much work when adding/removing
2542 accounts, probably in another part of the application.
2544 * src/maemo/modest-account-view-window.c:
2545 (on_delete_button_clicked), (on_edit_button_clicked),
2546 (on_new_button_clicked): Use the new functions.
2548 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2550 * src/modest-account-mgr-helpers.c:
2551 (modest_account_mgr_set_first_account_as_default):
2552 Sort the list of names alphabetically-by-title, so we choose the first one
2554 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2555 alphabetically by the title.
2557 This fixes projects.maemo.org bug NB#56418 .
2559 * src/modest-account-mgr-priv.c:
2560 (_modest_account_mgr_account_from_key):
2561 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2562 avoid a valgrind error, and possible random behaviour.
2564 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2566 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2567 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2568 tinymail documentation to say that this can be expected.
2569 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2570 pretty, and should not happen, but I would prefer to know when it does.
2572 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2574 * configure.ac: When using the older hildon version, probably on Bora,
2575 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2577 * src/widgets/modest-attachment-view.c:
2578 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2581 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2583 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2584 Implemented the prototype. Can be tested with
2585 tests/dbus_api/test_open_message:
2587 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2589 * src/modest-tny-account-store.c:
2590 (modest_tny_account_store_instance_init), (get_password):
2591 * src/modest-ui-actions.c:
2592 (modest_ui_actions_on_password_requested):
2593 Do not store the password in gconf, because this function is called
2594 for non-remembered passwords. Actually use the cached (in the hash map)
2595 password instead of releasing it.
2596 The password will now not be remembered if it is asked via the protected
2597 password dialog, as per the UI spec.
2599 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2601 * src/modest-defs.h:
2602 * src/modest-account-mgr-helpers.h:
2603 * src/modest-account-mgr-helpers.c:
2604 Added modest_server_account_get_username_has_succeeded(),
2605 modest_server_account_set_username_has_succeeded().
2606 (modest_server_account_set_username),
2607 Reset the has-succeeded flag if the username changes.
2609 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2610 * src/maemo/modest-connection-specific-smtp-window.c:
2611 (modest_connection_specific_smtp_window_save_server_accounts):
2612 Use modest_server_account_set_username() instead of using
2613 modest_conf_set_string() directly, so that the has-succeeded flag is always
2616 * src/modest-ui-actions.c:
2617 (modest_ui_actions_on_password_requested): Dim the username entry if
2618 the username has ever worked, as per the UI spec.
2620 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2622 * src/modest-tny-account-store.c: (get_password):
2623 * src/modest-ui-actions.c:
2624 (modest_ui_actions_on_password_requested):
2625 Allow the username to be changed too, though there is more work to
2626 be done on exactly how this behaves.
2628 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2630 * src/modest-account-mgr-helpers.h:
2631 * src/modest-account-mgr-helpers.c:
2632 Added modest_account_mgr_get_display_name(),
2633 modest_server_account_get_username(),
2634 modest_server_account_set_username(),
2635 modest_server_account_set_password(),
2636 modest_server_account_get_hostname() functions so we do not need to
2637 use the conf API directly.
2639 * src/maemo/modest-main-window.c: (connect_signals):
2640 Actually connect ot the ModestAccountStore::request-password signal,
2641 so that we show the dialog when the password is requested by Tinymail,
2642 for isntance if it is empty.
2644 * src/modest-marshal.list:
2645 * src/modest-tny-account-store.c:
2646 (modest_tny_account_store_class_init), (get_password),
2647 (modest_tny_account_store_alert):
2648 * src/modest-tny-account-store.h:
2649 * src/modest-ui-actions.h:
2650 * src/modest-ui-actions.c:
2651 (modest_ui_actions_on_password_requested):
2652 Change the signal parameters, so it is obvious that we are providing
2653 the non human-readable server name, and receiving both the username
2654 and password, though changing of the username is not yet implemented.
2655 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2656 for the GNOME version.
2658 This should fix the projects.maemo.org bug NB#56209, though it does not
2659 work on Bora, because the gconf_client_get() for the password fails
2660 immediately after we save it with gconf_client_set().
2662 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2665 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2666 caused an undefined symbol error:
2667 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2669 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2671 * src/modest-tny-account-store.c:
2672 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2673 using a GError instead of a string message, so we can translate it in
2676 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2678 * src/maemo/modest-address-book.c:
2679 (modest_address_book_check_names):
2680 * src/maemo/modest-msg-view-window.c:
2681 (modest_msg_view_window_clipboard_owner_change):
2682 * src/modest-init.c: (modest_init_init_ui):
2683 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2684 (update_folders_cb), (modest_mail_operation_update_account):
2685 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2686 (modest_ui_actions_on_msg_attachment_clicked),
2687 (modest_ui_actions_on_msg_recpt_activated):
2688 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2689 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2690 (modest_msg_view_search_next):
2691 * src/widgets/modest-recpt-editor.c:
2692 (modest_recpt_editor_on_button_release_event),
2693 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2694 g_message(). At this point we should only be seeing interesting errors on
2695 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2697 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2699 (modest_wizard_dialog_force_title_update):
2700 * src/maemo/easysetup/modest-wizard-dialog.h:
2701 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2702 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2703 can update the title when appropriate. Otherwise the title is wrong if the
2704 pages are added after adding the notebook to the dialog.
2705 This must be a problem in HildonWizardDialog too.
2706 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2708 * src/maemo/easysetup/modest-easysetup-wizard.c:
2709 (create_subsequent_customsetup_pages),
2710 (create_subsequent_easysetup_pages):
2711 Call modest_wizard_dialog_force_title_update() so that the title is
2712 correct even with GTK+ < 2.10.
2713 This fixes projects.maemo.org bug NB#56145 .
2715 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2717 * src/maemo/modest-platform.c:
2718 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2719 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2722 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2724 * src/widgets/modest-window.h:
2725 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2726 and modest_window_save_state(), which invokes it.
2728 * src/widgets/modest-window-mgr.h:
2729 * src/widgets/modest-window-mgr.c:
2730 Added modest_window_mgr_save_state_for_all_windows(), which calls
2731 the save_state vfunc on all registered windows, if implemented.
2733 * src/gnome/modest-msg-edit-window.c:
2734 * src/gnome/modest-msg-view-window.c:
2735 * src/maemo/modest-msg-edit-window.c:
2736 * src/maemo/modest-msg-view-window.c:
2737 * src/maemo/modest-main-window.c:
2738 Specify the existing save_settings functions as implementations of
2739 ModestWindow::save_state_func().
2741 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2742 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2743 enabling hibernation, for instance.
2745 We may need to do the same thing for restoring settings.
2748 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2750 * src/widgets/modest-window-mgr.c:
2751 * src/widgets/modest-window-mgr.h:
2752 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2753 modest_window_mgr_get_hibernation_is_prevented().
2755 * src/maemo/modest-main-window.c:
2756 (on_hildon_program_is_topmost_notify): Prevent hibernation
2757 (possible when the application goes to the background in the WM),
2758 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2760 * src/maemo/easysetup/modest-easysetup-wizard.c:
2761 (modest_easysetup_wizard_dialog_init):
2762 * src/maemo/modest-account-settings-dialog.c:
2763 (modest_account_settings_dialog_init):
2764 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2765 (modest_connection_specific_smtp_edit_window_init):
2766 * src/maemo/modest-connection-specific-smtp-window.c:
2767 (modest_connection_specific_smtp_window_init):
2768 * src/maemo/modest-signature-editor-dialog.c:
2769 (modest_signature_editor_dialog_init):
2770 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2771 prevent hibernation while any of these account settings dialogs are open.
2773 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2775 * src/maemo/Makefile.am:
2776 * src/maemo/modest-osso-state-saving.c:
2777 * src/maemo/modest-osso-state-saving.h: Added
2778 modest_osso_load_state() and modest_osso_save_state() though they do
2779 nothing now. They should iterate through all the open windows and load/save
2781 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2782 save state when closing.
2784 * src/maemo/modest-main-window.c:
2785 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2786 Add a notification handler for the HildonProgram::is-topmost property,
2787 so we can allow hibernation when the application goes into the background.
2788 But we still need to detect when the accounts setup windows are open so
2789 we can stop hibernation when they are open.
2790 To do this, I also added the main window the HildonProgram. This might have
2791 other side-effects/benefits, and should maybe be done for other windows.
2793 * src/maemo/modest-osso-autosave-callbacks.h:
2794 * src/maemo/modest-osso-autosave-callbacks.c:
2795 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2796 though it does not do anything yet, and we might never need this to do
2797 anything. For instance, we already save drafts.
2799 * src/maemo/modest-platform.c: (modest_platform_init):
2800 Specify the libosso auto-save callback.
2802 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2804 * src/maemo/modest-platform.c:
2805 (modest_platform_set_update_interval):
2806 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2807 aparently stays valid between application instances, so we can use this
2808 to remove and reset it later. According to a maemo-developers email from
2811 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2813 * configure.ac: Depend on libalarm for Maemo.
2815 * src/dbus_api/modest-dbus-api.h:
2816 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2817 (on_send_receive), (modest_dbus_req_handler):
2818 Handle a SEND_RECEIVE D-Bus method.
2820 * libmodest-dbus-client/libmodest-dbus-client.c:
2821 (libmodest_dbus_client_send_and_receive):
2822 * libmodest-dbus-client/libmodest-dbus-client.h:
2823 Add C convenience functions for calling the new D-Bus method.
2825 * src/modest-platform.h:
2826 * src/gnome/modest-platform.c:
2827 * src/maemo/modest-platform.c:
2828 Added modest_platform_set_update_interval(), which uses the
2829 alarmd API on Maemo.
2830 (modest_platform_init),
2831 Call modest_platform_set_update_interval(), using a hard-coded
2832 interval for now (until the global settings dialog is implemented),
2833 though I am not sure that this makes sense yet.
2835 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2837 * src/dbus_api/modest-dbus-callbacks.c:
2838 (modest_osso_cb_hw_state_handler):
2839 * src/dbus_api/modest-dbus-callbacks.h:
2840 * src/maemo/modest-platform.c: (modest_platform_init):
2841 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2842 in case this has some effect on the ability for Maemo to ping the
2845 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2847 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2848 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2849 warning. It is probably a logic error, but I need to fix the build.
2851 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2853 * src/modest-account-mgr.h:
2854 * src/modest-account-mgr.c:
2855 (modest_account_mgr_account_names): Add a gboolean enabled_only
2856 parameter, so we can get lists of onlt the enabled accounts.
2858 (modest_account_mgr_add_account),,
2859 (modest_account_mgr_account_with_display_name_exists):
2860 * src/maemo/modest-msg-edit-window.c: (get_transports):
2861 * src/modest-account-mgr-helpers.c:
2862 (modest_account_mgr_set_first_account_as_default):
2863 * src/modest-init.c: (init_default_account_maybe):
2864 * src/modest-tny-account-store.c: (get_accounts):
2865 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2866 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2867 * tests/check_account-mgr.c: (START_TEST):
2868 Provide the extra parameter, as appropriate.
2870 * src/widgets/modest-account-view.c: (update_account_view):
2871 Do not show disabled accounts (meaning that there is no way to
2872 enable/disable accounts in the UI (the feature is not in our UI
2873 specification), so we can use this internally only to mark unfinished
2874 or temporary account data.
2876 * src/maemo/easysetup/modest-easysetup-wizard.c:
2877 (create_account): Add boolean enable parameter, so we can specify FALSE
2878 to create the temporary account.
2879 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2880 (on_before_next): When finishing, when there is a temporary account, just
2882 Also, use a timeout to delay the showing of the dialog until gconf is likely
2883 to return correct information, due to a maemo gconf bug that is fixed in
2884 osso 1.1, but not yet in Bora.
2885 However, the dialog stays on screen after it is destroyed.
2887 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2888 for invalid data when cancelling. Use a hildon note instead of a dialog
2889 to complain about invalid data. Do not show the account-saved note if the
2890 account is disabled (a temporary account that will not really be saved for use
2893 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2895 * src/modest-account-mgr-helpers.h:
2896 * src/modest-account-mgr-helpers.c:
2897 Added modest_account_mgr_unset_default_account(),
2898 Added modest_account_mgr_set_first_account_as_default().
2900 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2901 If it was the default account, unset the default account name.
2903 * src/maemo/modest-account-view-window.c:
2904 (on_delete_button_clicked): If it was the default account,
2905 set the first remaining account as the default instead.
2907 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2908 a NULL account or a NULL default account, to prevent a crash. This should
2909 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2912 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2914 * src/widgets/modest-recpt-editor.c:
2915 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2916 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2917 TODO comment for this. This fixes the build.
2919 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2920 be the best place for it. This will in future update all auto-update accounts,
2921 rather than just the current/default account, when that gconf key exists.
2922 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2923 if there are no accounts, before calling do_send_receive().
2924 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2926 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2927 * src/maemo/modest-main-window-ui.h:
2928 * src/maemo/modest-main-window.c: (on_connection_changed),
2929 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2930 directly, becaue the signal handler does more.
2932 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2934 * src/modest-account-mgr-helpers.c:
2935 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2936 for the case that the account does not exist.
2938 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2939 (equivalent to the modest account name) rather than the tinymail account name
2940 (equivalent to the modest account title - human readable) to get the account data.
2941 Check for null account data to prevent the crash, and add a TODO comment saying that
2942 this needs fixing because it is using the server account name instead of the account name.
2944 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2946 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2947 * src/maemo/modest-account-settings-dialog.c: (show_error),
2949 Use hildon_note_new_information() for informative and error messages,
2950 which seems to be expected for Maemo applications (no documentation that I know of
2951 says this). I am surprised that there is no distinction between info and error
2954 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2956 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2957 it is easy to find where this is used.
2959 * src/maemo/easysetup/modest-easysetup-wizard.c:
2960 (create_page_welcome), (create_page_account_details),
2961 (create_page_user_details), (create_page_complete_easysetup),
2962 (create_page_custom_incoming), (create_page_custom_outgoing),
2963 (create_page_complete_custom):
2964 * src/maemo/modest-account-settings-dialog.c:
2965 (create_page_account_details), (create_page_user_details),
2966 (create_page_incoming), (create_page_outgoing):
2967 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2968 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2969 (modest_connection_specific_smtp_edit_window_init):
2970 * src/maemo/modest-connection-specific-smtp-window.c:
2971 (modest_connection_specific_smtp_window_init):
2972 * src/maemo/modest-signature-editor-dialog.c:
2973 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2974 and scrolling policy as per the Email Application Layout Guide, if I have
2977 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2979 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2980 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2981 which were empty, because these vfuncs have been removed from TnyAccountStore.
2982 This fixes the build.
2984 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2986 * src/maemo/modest-main-window.c:
2987 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2988 showing/hiding it. Added TODO because it probably should not be NULL.
2989 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2990 because unnecessary g_warnings() make degugging difficult.
2992 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2994 * src/maemo/modest-msg-edit-window.c:
2995 (modest_msg_edit_window_select_color),
2996 (modest_msg_edit_window_select_background_color): 2 const corrections and
2997 moving 2 #endifs before closing brackets, to fix the build.
2999 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3001 * src/maemo/easysetup/modest-easysetup-wizard.h:
3002 * src/maemo/easysetup/modest-easysetup-wizard.c:
3003 (modest_easysetup_wizard_dialog_finalize),
3004 (on_button_edit_advanced_settings), (create_page_complete_custom),
3005 (on_response), (create_account):
3006 Implement the Advanced Settings edit button, by saving the account information,
3007 for the Advanded Settings dialog to use directly from gconf, and removing it
3008 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3009 Bug #5533 in the projects.maemo.org bugzilla.
3011 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3013 * src/maemo/modest-msg-view-window.c:
3014 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3015 when opening a message window.
3017 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3019 * src/maemo/easysetup/modest-easysetup-wizard.c:
3020 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3023 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3024 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3025 gconf settings. I probably added more checks than necessary, but that is safer.
3027 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3028 variable to fix the build, but this seems to be used when it is still NULL.
3030 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3032 * src/modest-platform.h:
3033 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3034 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3035 * src/modest-main.c: Implement this function so we can avoid using
3036 maemo-specific API from cross-platform code.
3038 * src/modest-tny-account-store.c:
3039 (get_smtp_specific_transport_account_for_open_connection):
3040 * src/modest-ui-actions.c: (check_for_connection),
3041 (modest_ui_actions_on_item_not_found):
3042 Use modest_platform_connect_and_wait() and put #idefs around other
3043 maemo-specific code, because only maemo currently has a way to
3044 identify connection names.
3046 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3048 * src/modest-tny-account-store.h:
3049 * src/modest-tny-account-store.c:
3050 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3051 the connection-specific SMTP server settings in the configuration.
3053 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3055 * src/maemo/modest-main-window.c: (on_connection_changed),
3057 * src/modest-main.c: (main), (start_ui), (send_mail):
3058 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3059 that is what is intended.
3061 * src/modest-ui-actions.c: (action_send), (action_receive),
3062 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3063 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3064 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3065 SMTP server is used when it is specified.
3067 (modest_ui_actions_on_send_receive):
3068 Check that a connection is open before proceeding.
3069 Receive and then send, instead of vice-versa, as per the specification.
3071 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3073 * src/modest-mail-operation.c:
3074 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3075 though I guess it should be something other than NULL.
3077 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3079 * src/maemo/easysetup/modest-easysetup-wizard.c:
3080 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3081 combo twice, to avoid an g_warning and to make it visible again.
3082 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3083 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3084 (already intended) dereference when detaching, because we then recreate the menu.
3085 But I am not sure why the warning was happening, and it is possible that this is a memory
3088 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3090 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3091 and uri_parse_mailto() utility functions.
3092 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3094 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3096 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3098 * src/dbus_api/modest-dbus-api.h:
3099 * src/dbus_api/modest-dbus-callbacks.c:
3100 Use an idle callback to execute the modest code in the application's own thread.
3101 Remove the helloworld example method.
3102 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3103 parsed, and the open-message method is not implemented because this is not yet implemented in
3105 * libmodest-dbus-client/libmodest-dbus-client.c:
3106 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3107 (libmodest_dbus_client_open_message):
3108 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3110 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3111 body without crashing.
3113 * tests/dbus_api/Makefile.am:
3114 * tests/dbus_api/test_mail_to.c:
3115 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3117 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3119 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3120 Added file to fix the build. Sorry.
3122 * src/dbus_api/Makefile.am:
3123 * src/dbus_api/modest-dbus-api.h:
3124 * src/dbus_api/modest-dbus-callbacks.h:
3125 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3126 (modest_dbus_req_handler):
3127 Put constants in a separate header so it can be reused by the
3128 client library, without duplication
3130 * libmodest-dbus-client/Makefile.am:
3131 * libmodest-dbus-client/libmodest-dbus-client.c:
3132 (libmodest_dbus_client_call_helloworld),
3133 (libmodfest_dbus_client_send_mail),
3134 (libmodfest_dbus_client_mailto),
3135 (libmodfest_dbus_client_open_message):
3136 * libmodest-dbus-client/libmodest-dbus-client.h:
3137 (Partly) Implement a send_mail D-Bus method.
3139 * tests/dbus_api/Makefile.am:
3140 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3141 the send_email D-Bus method.
3143 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3147 * libmodest-dbus-client/Makefile.am:
3148 * libmodest-dbus-client/libmodest-dbus-client.c:
3149 * libmodest-dbus-client/libmodest-dbus-client.h:
3150 * tests/dbus_api/Makefile.am:
3151 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3152 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3154 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3156 * src/maemo/easysetup/modest-easysetup-wizard.c:
3157 (create_page_account_details):
3158 * src/maemo/modest-account-settings-dialog.c:
3159 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3160 widgets, because this might not be the default in future versions of the Maemo GTK+.
3161 However, I can not not get capitalization to work even in a simple test case.
3163 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3165 * src/maemo/easysetup/modest-easysetup-wizard.c:
3166 (create_page_custom_incoming), (create_page_custom_outgoing):
3167 * src/maemo/modest-account-settings-dialog.c:
3168 (create_page_account_details), (create_page_incoming),
3169 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3170 instead of using gtk_check_button_with_label(), so they are aligned like the other
3171 widgets, as per the UI spec.
3173 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3175 * src/maemo/easysetup/modest-easysetup-wizard.c:
3176 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3177 * src/widgets/modest-validating-entry.c:
3178 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3179 Modest prefix instead of an EasySetup prefix.
3181 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3183 * src/widgets/modest-validating-entry.h:
3184 * src/widgets/modest-validating-entry.c: (on_insert_text),
3185 Added easysetup_validating_entry_set_max_func(), used to set a callback
3186 to call when the max number of characters is reached. GtkEntry has a max-length
3187 already but is silent about it.
3189 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3190 (create_page_account_details), (create_page_user_details),
3192 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3193 (create_page_account_details), (create_page_user_details),
3194 (create_page_outgoing):
3195 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3196 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3197 the UI spec, when the user tries to enter more than the max number of characters.
3199 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3201 * src/maemo/easysetup/modest-easysetup-wizard.c:
3202 (create_page_user_details), (create_page_custom_incoming),
3203 (create_page_custom_outgoing):
3204 * src/maemo/modest-account-settings-dialog.c:
3205 (create_page_user_details), (create_page_incoming),
3206 (create_page_outgoing):
3207 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3208 (modest_connection_specific_smtp_edit_window_init):
3209 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3210 not appropriate. Bad Maemo-specific defaults!.
3212 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3214 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3215 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3216 (modest_signature_editor_dialog_set_settings):
3217 Disable the label and textview when the checkbox is disabled, and use the
3218 specified (UI spec) default signature text.
3220 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3222 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3223 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3225 * src/modest-defs.h:
3226 * src/modest-account-mgr-helpers.h:
3227 * src/modest-account-mgr-helpers.c:
3228 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3230 * src/maemo/Makefile.am:
3231 * src/maemo/modest-signature-editor-dialog.c:
3232 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3235 * src/maemo/modest-account-settings-dialog.h:
3236 * src/maemo/modest-account-settings-dialog.c:
3237 (modest_account_settings_dialog_finalize), (on_button_signature),
3238 (save_configuration): Use the new dialog when the Edit button is pressed, and
3239 save the changes if necessary, as per the UI spec.
3241 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3243 * src/maemo/Makefile.am:
3244 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3245 based on maemo-develoers email from Dirk.
3247 * src/maemo/easysetup/modest-easysetup-wizard.c:
3248 (create_page_welcome), (create_page_account_details),
3249 (create_page_user_details), (create_page_complete_easysetup),
3250 (create_page_custom_incoming), (create_page_custom_outgoing),
3251 (create_page_complete_custom),
3252 (modest_easysetup_wizard_dialog_init):
3253 * src/maemo/modest-account-settings-dialog.c:
3254 (create_page_account_details), (create_page_user_details),
3255 (create_page_incoming), (create_page_outgoing),
3256 (modest_account_settings_dialog_init):
3257 * src/maemo/modest-connection-specific-smtp-window.c:
3258 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3260 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3262 * src/maemo/easysetup/modest-easysetup-wizard.c:
3263 (create_page_account_details), (create_page_custom_outgoing),
3264 (create_page_complete_custom):
3265 * src/maemo/modest-account-settings-dialog.c:
3266 (create_page_user_details), (create_page_incoming),
3267 (create_page_outgoing):
3268 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3269 (modest_connection_specific_smtp_edit_window_init):
3270 Use the correct (UI spec) port min/max, and use horizontal separators,
3273 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3275 * src/maemo/easysetup/modest-easysetup-wizard.c:
3276 (set_default_custom_servernames):
3277 * src/maemo/modest-account-settings-dialog.c:
3278 (create_page_incoming), (on_combo_outgoing_security_changed),
3279 (on_combo_incoming_security_changed), (create_page_outgoing),
3280 (modest_account_settings_dialog_set_account_name),
3281 (save_configuration):
3282 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3283 (on_combo_security_changed),
3284 (modest_connection_specific_smtp_edit_window_init),
3285 (modest_connection_specific_smtp_edit_window_set_connection),
3286 (modest_connection_specific_smtp_edit_window_get_settings):
3287 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3290 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/easysetup/modest-easysetup-wizard.c:
3294 (create_page_custom_outgoing), (create_page_complete_custom):
3295 * src/maemo/modest-account-settings-dialog.c:
3296 (create_page_user_details), (create_page_outgoing):
3297 * src/maemo/modest-account-view-window.c: (button_box_new):
3298 Use changed logical IDs as per the most recent UI spec:
3299 mcen_bd_emailsetup_edit -> mcen_bd_edit
3300 mcen_bd_emailsetup_delete -> mcen_bd_delete
3301 mcen_bd_emailsetup_close -> mcen_bd_close
3303 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3307 * src/dbus_api/Makefile.am:
3308 * src/dbus_api/modest-dbus-callbacks.c:
3309 * src/dbus_api/modest-dbus-callbacks.h:
3310 * src/maemo/modest-platform.c: (modest_platform_init):
3311 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3313 * tests/Makefile.am:
3314 * tests/dbus_api/Makefile.am:
3315 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3317 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3319 * src/maemo/modest-account-settings-dialog.c:
3320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3321 Removed unnecessary includes.
3323 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3325 * src/maemo/easysetup/modest-easysetup-wizard.c:
3326 * src/maemo/modest-account-settings-dialog.c:
3327 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3328 * src/widgets/Makefile.am:
3329 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3330 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3331 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3332 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3333 * src/widgets/modest-secureauth-combo-box.c:
3334 * src/widgets/modest-secureauth-combo-box.h:
3335 * src/widgets/modest-serversecurity-combo-box.c:
3336 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3337 made the GObject names more consistent with the rest of the Modest code.
3339 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3341 * src/maemo/easysetup/Makefile.am:
3342 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3343 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3344 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3345 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3346 * src/maemo/easysetup/modest-easysetup-wizard.c:
3347 * src/maemo/easysetup/modest-validating-entry.c:
3348 * src/maemo/easysetup/modest-validating-entry.h:
3349 * src/maemo/modest-account-settings-dialog.c:
3350 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3351 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3352 widgets/ because they are used outside of easysetup too. After checking in,
3353 svn will allow me to rename them too.
3355 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3357 * src/gnome/modest-msg-edit-window.c:
3358 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3359 linker error, to fix the build on the GNOME platform.
3360 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3361 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3362 ifdefed out to avoid a warning.
3364 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3366 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3367 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3368 some alternative for GTK+ 2.6.
3370 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3372 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3374 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3375 specified for EmailAccountsDialog in UI spec.
3377 * src/maemo/easysetup/modest-easysetup-wizard.c:
3378 * src/maemo/easysetup/modest-easysetup-wizard.h:
3379 * src/maemo/modest-account-settings-dialog.c:
3380 * src/maemo/modest-account-settings-dialog.h:
3381 Reuse a member window widget for the connection-specific SMTP server accounts,
3382 so we can tell it to create/save the accounts only if we actually save changes.
3384 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3385 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3386 (modest_connection_specific_smtp_edit_window_get_settings):
3387 Return a struct instance for temporarily remembering the entered data.
3389 * src/maemo/modest-connection-specific-smtp-window.h:
3390 * src/maemo/modest-connection-specific-smtp-window.c:
3391 (modest_connection_specific_smtp_window_finalize),
3392 (modest_connection_specific_smtp_window_fill_with_connections),
3394 (modest_connection_specific_smtp_window_save_server_accounts),
3395 (update_model_server_names): Do not actually save data until asked,
3396 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3398 (on_selection_changed),
3399 (modest_connection_specific_smtp_window_init): Disable the edit
3400 button when nothing is selected.
3402 * src/modest-account-mgr-helpers.c:
3403 * src/modest-account-mgr-helpers.h:
3404 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3407 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3409 * src/modest-account-mgr-helpers.h:
3410 * src/modest-account-mgr-helpers.c:
3411 (modest_account_mgr_get_unused_account_name),
3412 (modest_account_mgr_get_unused_account_display_name): Added these
3413 utility functions, to avoid code duplication.
3415 * src/maemo/easysetup/modest-easysetup-wizard.c:
3416 (create_page_account_details), (create_account):
3417 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3418 (on_combo_security_changed),
3419 (modest_connection_specific_smtp_edit_window_init),
3420 (modest_connection_specific_smtp_edit_window_save_settings):
3421 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3422 * src/maemo/modest-connection-specific-smtp-window.c:
3423 (modest_connection_specific_smtp_window_finalize),
3424 (modest_connection_specific_smtp_window_fill_with_connections),
3425 (on_button_edit), (modest_connection_specific_smtp_window_init):
3426 * src/maemo/modest-connection-specific-smtp-window.h:
3427 Implementing saving of connection-specific server accounts.
3429 But I need to refactor this so we can save the data for each
3430 possible connection-specific account and only actually create the server accounts
3431 when the easysetup finished, or the OK button is pressed on the account settings
3434 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3436 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3437 (on_combo_security_changed):
3438 (modest_connection_specific_smtp_edit_window_init):
3439 Auto-fill the port number as in the account settings.
3441 (modest_connection_specific_smtp_edit_window_set_connection):
3442 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3443 * src/maemo/modest-connection-specific-smtp-window.c:
3444 (fill_with_connections), (on_button_edit),
3445 (modest_connection_specific_smtp_window_init):
3446 Turn the edit window into a dialog to simplify the code, and
3447 set a WM hint as in a GtkDialog, because only a popup can be on top of
3448 another window in Maemo, and popups usually have no WM decoration.
3450 * src/modest-defs.h:
3451 * src/modest-account-mgr-helpers.c:
3452 (modest_account_mgr_set_connection_specific_smtp),
3453 (modest_account_mgr_remove_connection_specific_smtp),
3454 (modest_account_mgr_get_connection_specific_smtp):
3455 * src/modest-account-mgr-helpers.h: Some functions to write the
3456 connection-specific SMTP server information. Not yet used.
3459 * src/widgets/modest-folder-view.c: (text_cell_data):
3460 Fix a warning about an uninitialized variable.
3461 (on_configuration_key_changed): Put an #ifdef around the use
3462 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3464 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3466 * src/maemo/modest-account-settings-dialog.h:
3467 * src/maemo/modest-account-settings-dialog.c:
3468 Added connect_for_modified() utility function to mark the new modified boolean.
3470 (create_page_account_details), (create_page_user_details),
3471 (create_page_incoming), (create_page_outgoing), (on_response),
3472 (modest_account_settings_dialog_init),
3473 (modest_account_settings_dialog_set_account_name):
3474 Only warn about unsaved changes when there are actually unsaved changes.
3476 * src/modest-account-mgr-helpers.c:
3477 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3478 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3479 to get the data from there in future.
3481 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3483 * src/modest-defs.h:
3485 * src/modest-account-mgr-helpers.h:
3486 * src/modest-account-mgr-helpers.c:
3487 Store the security account setting in a single conf key instead of using
3488 the options list, so that the list is left for just the to-be-removed camel hack,
3489 and because gconf_client_set_list() is failing for some reason.
3491 * src/modest-account-mgr.c:
3492 (modest_account_mgr_add_server_account):
3493 * src/maemo/modest-account-settings-dialog.c:
3494 (modest_account_settings_dialog_set_account_name),
3495 (save_configuration): Use the renamed functions.
3498 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3500 * src/widgets/Makefile.am:
3501 * src/widgets/modest-limit-retrieve-combo-box.c:
3502 * src/widgets/modest-limit-retrieve-combo-box.h:
3503 * src/widgets/modest-retrieve-combo-box.c:
3504 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3505 the account settings dialog.
3507 * src/modest-defs.h:
3508 * src/modest-account-mgr-helpers.h:
3509 * src/modest-account-mgr-helpers.c:
3510 (modest_server_account_get_option_secure_auth),
3511 (modest_server_account_set_option_secure_auth):
3512 * src/modest-account-mgr.c:
3513 (modest_account_mgr_add_server_account):
3514 Use the existing AUTH_MECH conf key for the secure-auth setting,
3515 instead of putting it in the list options, because this was actually used already.
3517 * src/maemo/modest-account-settings-dialog.c:
3518 (create_page_account_details),
3519 (modest_account_settings_dialog_set_account_name),
3520 (save_configuration):
3521 * src/maemo/modest-account-settings-dialog.h:
3522 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3523 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3525 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3527 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3528 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3529 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3531 * src/modest-defs.h:
3532 * src/maemo/modest-account-settings-dialog.c:
3533 (create_page_incoming), (on_combo_outgoing_security_changed),
3534 (on_combo_incoming_security_changed), (create_page_outgoing),
3535 (modest_account_settings_dialog_set_account_name),
3536 (save_configuration): Load/Save the port number, and change it when the
3537 security combo changes, to suitable defaults.
3539 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3541 * src/modest-account-mgr.c:
3542 (modest_account_mgr_add_server_account): Set the security and secure-auth
3543 options, and add a comment saying that the other camel-specific options should be
3546 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3548 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3550 * src/modest-tny-account-store.c: (account_list_free),
3551 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3552 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3555 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3557 * src/modest-protocol-info.c:
3558 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3559 is required by our UI spec. Maybe something in our implementation will use this eventually.
3560 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3561 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3562 instead of the previous 0 placeholder.
3564 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3565 secure-auth settings.
3566 * src/modest-account-mgr-helpers.h:
3567 * src/modest-account-mgr-helpers.c:
3568 (modest_server_account_data_get_option_secure_auth),
3569 (modest_server_account_set_option_secure_auth),
3570 (modest_server_account_data_get_option_security),
3571 (modest_server_account_set_option_security): Added this API for getting and setting the security
3572 and secure-auth settings.
3574 * src/maemo/modest-account-settings-dialog.h:
3575 * src/maemo/modest-account-settings-dialog.c:
3576 (modest_account_settings_dialog_finalize), (check_data),
3577 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3578 about changing titles.
3579 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3580 (save_configuration): Save the security and secure-auth settings.
3582 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3583 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3585 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3587 * src/modest-defs.h:
3588 * src/modest-account-mgr.c:
3589 (modest_account_mgr_add_server_account):
3590 Added and used defines for the options key and value pair strings,
3591 that are used so far, though they do not seem to correspond to anything in our
3592 UI specs or ModestProtocol enum.
3594 * src/modest-account-mgr-helpers.h:
3595 * src/modest-account-mgr-helpers.c:
3596 (compare_option_strings_for_name),
3597 (modest_server_account_data_get_option_value),
3598 (modest_server_account_data_get_option_bool),
3599 (modest_account_mgr_get_server_account_option):
3600 Added helper functions for parsing the options GSList.
3602 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3604 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3605 display name is based on the supplied account name.
3606 * src/modest-account-mgr.c:
3607 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3608 with an inefficient, but good-enough, implementation.
3610 * src/maemo/easysetup/modest-easysetup-wizard.c:
3611 (create_page_account_details), (on_before_next), (create_account):
3612 Check for existing display names rather than (non-user-visible) account names, and just
3613 create and set a unique account name at the end.
3615 * src/maemo/modest-account-settings-dialog.c:
3616 (modest_account_settings_dialog_init),
3617 (modest_account_settings_dialog_set_account_name),
3618 (create_page_incoming): Show the display name, instead of the account name.
3619 (on_response): Do some (not all) extra checks, as in the UI spec.
3620 (save_configuration): Save the display name if it was changed.
3622 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3624 * po/en_GB.po: Added needed logical ID and translation.
3625 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3626 (init_view): Made the is-default column clicking work.
3628 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3631 * src/maemo/easysetup/Makefile.am:
3632 * src/maemo/easysetup/modest-easysetup-wizard.c:
3633 (modest_easysetup_wizard_dialog_init):
3634 * src/maemo/easysetup/provider-data-test.keyfile:
3635 * src/maemo/easysetup/provider-data.keyfile:
3636 Moved the provider data file to the new modest-providers-data package and used it from there.
3638 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3640 * src/modest-local-folder-info.c:
3641 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3642 N_() was already used on the static strings, but this just marks it for translation without
3643 using the translation.
3645 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3647 * src/maemo/modest-account-settings-dialog.c:
3648 (create_page_incoming),
3649 (modest_account_settings_dialog_set_account_name):
3650 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3651 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3652 I will do this if nobody else gets there first.
3654 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3656 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3657 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3658 save the security stuff.
3660 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3662 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3663 Set the email address and user fullname, which I now see must be
3666 * src/maemo/modest-account-settings-dialog.h:
3667 * src/maemo/modest-account-settings-dialog.c:
3669 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3670 leave-on-server and authentication.
3671 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3674 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3677 * src/maemo/modest-account-settings-dialog.c:
3678 * src/maemo/modest-account-settings-dialog.h:
3679 Most (but not all) of the widgets are now present as specified by the UI spec.
3680 No changes are yet saved, and some details are not properly shown yet.
3682 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3684 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3686 * src/maemo/Makefile.am:
3687 * src/maemo/modest-account-settings-dialog.c:
3688 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3689 an existing account. Doesn't do much yet.
3691 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3692 Open the accounts settings dialog when Edit is clicked.
3694 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3696 * src/maemo/easysetup/Makefile.am:
3697 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3699 * src/maemo/easysetup/modest-easysetup-wizard.c:
3700 (modest_easysetup_wizard_dialog_init):
3701 Try to get the source directory from the build system,
3702 instead of hard-coding "./" into the source code, when opening our local
3703 copies of the configuration files.
3704 But this still fails when opening the wizard from the Accounts window,
3705 maybe because the working directory seems to change at runtime.
3706 So the wizard will fail the second time unless you copy the files into their
3707 proper locations - see the stdout warnings for the paths.
3709 (create_page_account_details),(on_before_next):
3710 Check for existing non-server accounts instead of server accounts,
3711 so the default account name is useful again, and to prevent trying to
3714 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3715 Show the wizard when New is clicked.
3717 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3718 (init_view): Show the column headers, and show the columns that are
3719 specified in the UI specs. However, something in Maemo's GTK+ prevents
3720 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3721 change the default account. This is despite unsetting the special properties.
3723 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3725 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3726 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3727 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3728 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3729 to make that clearer.
3730 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3732 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3734 * src/maemo/modest-account-view-window.c:
3735 (modest_account_view_window_init),
3736 (modest_account_view_window_new):
3737 Use the same buttons as specified in the
3738 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3739 the existing widgets, which never had a chance of working.
3740 Put the ModestAccountView treeview in a scrolled window.
3741 Do not repeat the initialization in both _init() and _new().
3743 * src/widgets/modest-account-view.c: (update_account_view):
3744 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3745 this widget and window shows no accounts.
3747 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3749 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3751 * src/maemo/easysetup/modest-easysetup-wizard.c:
3752 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3753 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3754 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3757 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3758 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3759 accounts exist yet, as in the UI spec.
3761 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3763 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3765 * src/maemo/Makefile.am:
3766 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3767 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3768 New window for editing connection-specific smtp details.
3769 Not fully implemented.
3771 * src/maemo/modest-connection-specific-smtp-window.c:
3772 (modest_connection_specific_smtp_window_finalize) :
3773 unref the tree model.
3774 (on_button_edit): Show the edit window.
3776 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3778 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3781 * src/maemo/Makefile.am:
3782 * src/maemo/modest-connection-specific-smtp-window.c:
3783 * src/maemo/modest-connection-specific-smtp-window.h:
3784 New window for showing the list of connections, for connection-specific
3785 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3786 * src/maemo/easysetup/modest-easysetup-wizard.c:
3787 (create_page_custom_outgoing): Show the new window when the button is clicked.
3789 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3791 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3792 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3793 * src/maemo/modest-msg-edit-window.c:
3794 (modest_msg_edit_window_insert_image):
3795 * src/modest-conf.c: (modest_conf_key_escape):
3796 * src/modest-mail-operation.c:
3797 (modest_mail_operation_send_new_mail):
3798 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3799 (modest_ui_actions_on_new_account):
3800 * src/widgets/modest-attachment-view.c: (update_filename_request):
3801 * src/widgets/modest-mail-header-view.c:
3802 Corrected warnings that were breaking the build, by commenting out unused variables,
3803 and a function, and by including a header.
3805 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3807 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3808 so we can #ifdef around platform-specific code when necessary.
3809 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3810 to allow this to build for the GNOME platform too.
3812 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3814 * src/maemo/easysetup/modest-easysetup-wizard.c:
3815 Added util_increment_name() and used it in create_page_account_details()
3816 to make sure that the default account name is always a new name.
3818 (modest_easysetup_wizard_dialog_init),
3819 (set_default_custom_servernames): Some minor memory management fixes.
3821 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3825 * src/modest-runtime.c: (init_i18n): Restored the translation
3826 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3827 are defined in config.h, and the translations are installed.
3829 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3830 is defined for translation.
3832 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3834 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3836 * src/maemo/easysetup/modest-easysetup-wizard.c:
3837 (modest_easysetup_wizard_dialog_init):
3838 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3839 Use realistic paths (though they should use $prefix generically) to the
3840 mcc_mapping and provider-data.keyfile files which might work when they
3841 are installed by the future version of the operator-wizard package,
3842 and then fallback to paths in our source code, with an explanatory
3845 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3849 * src/maemo/Makefile.am:
3850 * src/maemo/easysetup/: Added files from the previously-exernal
3851 osso-modest-easysetup.
3852 * src/maemo/modest-main-window-ui.h:
3853 * src/modest-ui-actions.c:
3854 * src/modest-ui-actions.h:
3855 Added modest_ui_actions_on_new_account() as a signal handler for the
3856 New Account menu item. It shows the easysetup wizard.
3857 * po/en_GB.po: Added additional needed logical IDs and translations.