1 2007-09-11 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-settings-dialog.c:
4 (modest_account_settings_dialog_set_account_name): Set the incoming
5 secure-auth checkbox only when a secure auth method is really specified
6 in gconf. For some reason, it was set also if a secure connection was
7 chosen, but that does not make sense to me, and was not commented.
8 For instance, this stops the user from seeing an error about unsupported
9 secure authentication when editing a gmail account.
11 2007-09-05 Murray Cumming <murrayc@murrayc.com>
13 * src/maemo/modest-maemo-utils.c:
14 (on_camel_account_get_supported_secure_authentication),
15 (modest_maemo_utils_get_supported_secure_authentication_methods):
16 Adapted to the changed tinymail signature of the callback, and
17 printf a warning when there is an exception, as a clue.
19 2007-09-03 Armin Burgmeier <armin@openismus.com>
21 * src/maemo/modest-maemo-utils.c: Don't set the temporary account
22 online that checks for supported authentication methods. This fixes
23 projects.maemo.org bug NB#61369.
25 2007-09-03 Murray Cumming <murrayc@murrayc.com>
27 * src/widgets/modest-folder-view.c: (strings_are_equal),
28 (on_model_foreach_set_name), (on_get_mmc_account_name),
29 (text_cell_data): Restored this code that was removed in
30 svn revision 3165 by jfernandez, because this late name-discovery
31 really is necessary sometimes. This is the correct fix to the endless
32 calling of this function:
33 * src/modest-tny-account.c: (on_modest_file_system_info):
34 Don't call tny_account_set_name() when the name is already correct,
35 to avoid unnecessary (endless) updates to the tree model.
37 2007-08-31 Murray Cumming <murrayc@murrayc.com>
39 * src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
40 MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
41 for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
42 boolean, because this is the specified behaviour in the UI spec.
43 * src/modest-account-mgr-helpers.h:
44 * src/modest-account-mgr-helpers.c:
45 (modest_account_mgr_set_connection_specific_smtp),
46 (modest_account_mgr_remove_connection_specific_smtp),
47 (modest_account_mgr_get_connection_specific_smtp): Remove the account_name
49 * src/maemo/modest-connection-specific-smtp-window.h:
50 * src/maemo/modest-connection-specific-smtp-window.c:
51 (modest_connection_specific_smtp_window_finalize),
52 (modest_connection_specific_smtp_window_fill_with_connections),
53 (modest_connection_specific_smtp_window_save_server_accounts):
54 Remove the account_name parameters and member variable.
55 * src/maemo/easysetup/modest-easysetup-wizard.c:
56 (on_button_outgoing_smtp_servers), (create_account):
57 * src/maemo/modest-account-settings-dialog.c:
58 (on_button_outgoing_smtp_servers), (check_data),
59 (modest_account_settings_dialog_set_account_name),
61 * src/maemo/modest-maemo-utils.c: (on_account_online),
62 (modest_maemo_utils_get_supported_secure_authentication_methods):
63 * src/modest-tny-account-store.c:
64 (get_smtp_specific_transport_account_for_open_connection),
65 (insert_account), (add_connection_specific_transport_accounts):
66 * src/modest-ui-actions.c: (on_smtp_servers_window_hide),
67 (modest_ui_actions_on_smtp_servers):
68 Adapt to the changed API.
70 2007-08-29 Armin Burgmeier <armin@openismus.com>
72 * src/modest-protocol-info.h:
73 * src/modest-protocol-info.c: Added
74 modest_protocol_info_get_auth_protocol() to translate an
75 authentication protocol name to the corresponding enum value.
77 * src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
78 generation using the newly added function.
80 * src/maemo/modest-account-settings-dialog.c: Use the current element
81 when traversing through the list of supported authentication methods,
84 2007-08-29 Murray Cumming <murrayc@murrayc.com>
86 * src/maemo/easysetup/modest-easysetup-wizard.c:
87 (check_first_supported_auth_method), (on_before_next),
89 * src/maemo/modest-account-settings-dialog.c: (check_data):
90 Some cleanup, to make the code clearer.
92 2007-08-29 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
95 Use the mail_ni_ssl_certificate_error ("Secure connection failed")
96 logical ID when the secure authentication method is not supported by
97 the server, as requested by Mox on the wiki, though I hate not
98 giving the user the clue.
100 2007-08-29 Murray Cumming <murrayc@murrayc.com>
102 * src/modest-search.c: (modest_search_all_accounts):
103 * src/modest-platform.h:
104 * src/maemo/modest-platform.c: Moved and renamed
105 check_and_wait_for_account_is_online() to
106 modest_platform_check_and_wait_for_account_is_online() so it
107 can be used in more places.
109 2007-08-29 Murray Cumming <murrayc@murrayc.com>
111 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
112 Removed the sleep(1) experiment because it does not seem to help,
113 and I should not have checked the experiment in anyway.
114 The problem is maybe in the TnyAccount connected state - I will
115 investigate that instead.
117 2007-08-28 Murray Cumming <murrayc@murrayc.com>
119 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
120 Added a sleep(1) in case it helps with bug #66769.
122 2007-08-28 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-search.c: (on_timeout_check_account_is_online),
125 (check_and_wait_for_account_is_online):
126 It is OK for local-folder and mmc accounts to be used when they
127 are in the _INIT folder, instead of waiting for them to change
129 For POP and IMAP, wait from them to stop being _INIT, rather than
130 waiting from them to be _CONNECTED, because that seems to be
131 the status that causes the problems.
133 2007-08-28 Murray Cumming <murrayc@murrayc.com>
135 * src/modest-search.c: (check_and_wait_for_account_is_online):
136 Actually pass the account to the timeout callback.
138 2007-08-28 Murray Cumming <murrayc@murrayc.com>
140 * src/modest-search.c: (on_timeout_check_account_is_online):
141 Added some debug output to help me debug a problem on the N800.
142 (check_and_wait_for_account_is_online): Fail immediately if the
144 modest_search_all_accounts(): Try the search even if the account does
145 not seem to be online, because this can work sometimes, and should work
146 with the cache if there is no active libconic connection.
148 2007-08-27 Armin Burgmeier <armin@openismus.com>
150 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
151 observe outbox for added messages to assign them a status. Previously,
152 this was done in modest_tny_send_queue_add(), but the message id might
153 not yet be known at that point. This reduces warnings when sending
154 mail, though I am not sure how this even worked before.
156 2007-08-27 Murray Cumming <murrayc@murrayc.com>
158 * src/maemo/modest-account-settings-dialog.c:
159 (modest_account_settings_dialog_init):
160 * src/maemo/modest-connection-specific-smtp-edit-window.c:
161 (modest_connection_specific_smtp_edit_window_init):
162 * src/maemo/modest-connection-specific-smtp-window.c:
163 (modest_connection_specific_smtp_window_init):
164 * src/maemo/modest-maemo-utils.c:
165 (modest_maemo_utils_get_supported_secure_authentication_methods):
166 * src/maemo/modest-platform.c:
167 (modest_platform_run_folder_name_dialog):
168 * src/maemo/modest-signature-editor-dialog.c:
169 (modest_signature_editor_dialog_init):
170 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
171 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
172 * src/widgets/modest-global-settings-dialog.c:
173 (modest_global_settings_dialog_init):
174 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
176 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
177 GTK_STOCK_EDIT with mcen_bd_edit, and
178 GTK_STOCK_CLOSE with mcen_bd_close,
179 to fix projects.maemo.org bug NB#64995.
180 I strongly believe that Maemo's GTK+ should have the wanted translations
181 instead of duplicating this in each application and complicating the code.
183 2007-08-27 Armin Burgmeier <armin@openismus.com>
185 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
186 recursion when entering text in the subject field.
188 2007-08-27 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
191 which checks every second, 10 times, to wait until the account is online
192 so that we can use it, if the account is in the process of going online.
193 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
194 so that searching works even when the application was not yet started before.
195 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
197 2007-08-24 Armin Burgmeier <armin@openismus.com>
199 * src/modest-widget-memory.c: Always show the default account when the
200 application is started, as stated in the UI spec. This fixes
201 projects.maemo.org bug NB#66630.
203 2007-08-24 Armin Burgmeier <armin@openismus.com>
205 * src/maemo/modest-platform.c:
206 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
207 english text for strings in the rename folder dialog, fixing
208 projects.maemo.org bug NB#66338.
210 2007-08-22 Armin Burgmeier <armin@openismus.com>
212 * src/widgets/modest-account-view.c: Fix for bora by using
213 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
214 latter seems not be used anymore.
216 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
219 * src/maemo/modest-main-window.c: Update menu items when the default
220 account changes so that the current default account is always bolded.
221 This fixes maemo.projects.org bug NB#66173.
223 2007-08-17 Murray Cumming <murrayc@murrayc.com>
225 * src/dbus_api/modest-dbus-callbacks.c:
226 (on_dbus_method_get_folders): Avoid trying to get the account name
227 when there are no accounts, to avoid critical g_warnings, fixing
228 projects.maemo.org bug NB#65574.
230 2007-08-17 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
233 Use modest_account_mgr_get_signature() instead of accessing gconf
234 directly, to slightly simplify the code.
235 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
236 Append the signature also when opening via other applications,
237 fixing projects.maemo.org bug NB#65828.
239 2007-08-17 Murray Cumming <murrayc@murrayc.com>
241 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
242 Check for NULLs to prevent a crash when opening an email that is
243 an attachment in another email, fixing projects.maemo.org bug
246 2007-08-17 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-ui-dimming-rules.c:
249 (modest_ui_dimming_rules_on_view_window_move_to):
250 Enable the Move To toolbar button for search results, fixing the
251 last part of projects.maemo.org bug NB#63807.
253 2007-08-17 Murray Cumming <murrayc@murrayc.com>
255 * src/dbus_api/modest-dbus-callbacks.c:
256 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
257 because this is called from idle handlers, to fix hangs afte the
259 (find_message_by_url): Added a TODO comment about a crash that
260 happens when tinymail was built with DBC checks.
262 2007-08-16 Murray Cumming <murrayc@murrayc.com>
264 * src/modest-search.c: (modest_search_folder):
265 * src/modest-search.h: Rename ModestSearch::before to start_date
266 and after to end_date, using the same names as the libogs struct
268 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
269 The start_date and end_date were swapped in the check. This
270 fixes date range searches, fixing projects.maemo.org bug NB#63407.
272 2007-08-16 Murray Cumming <murrayc@murrayc.com>
274 * src/maemo/modest-account-view-window.c:
275 Added (check_for_active_acount).
276 (on_delete_button_clicked), (on_edit_button_clicked):
277 When an account is doing something (such as refreshing),
278 show the same warning for account deletion as for account
279 editing, to fix projects.maemo.org bug NB#64588.
281 2007-08-16 Murray Cumming <murrayc@murrayc.com>
283 * src/widgets/modest-msg-view-window.h:
284 * src/gnome/modest-msg-view-window.c:
285 * src/maemo/modest-msg-view-window.c:
286 Added modest_msg_view_window_construct().
287 (modest_msg_view_window_new_with_header_model),
288 Added modest_msg_view_window_new_for_search_result),
289 Renamed modest_msg_view_window_new() to
290 modest_msg_view_window_new_for_attachment(),
291 and modest_msg_view_window_is_search_result(),
292 so we can explicitly know that the window is for an
293 attachment or a search result or a message from the list.
295 (modest_msg_view_window_view_attachment):
296 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
297 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
298 Use modest_msg_view_window_new_for_search_result().
300 * src/modest-ui-dimming-rules.c:
301 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
302 for search results, fixing projects.maemo.org bug NB#63811.
304 2007-08-16 Armin Burgmeier <armin@openismus.com>
306 * src/modest-ui-actions.c: Show a banner instead of a dialog when
307 renaming a folder fails, to stay consistent with what happens when
308 creating a folder fails.
310 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
311 slightly country loading from the mmc_mappings file, fixed a memory
314 2007-08-16 Murray Cumming <murrayc@murrayc.com>
316 * src/modest-tny-account-store.c: (volume_path_is_mounted):
317 Check the GnomeVFSVolume activation path instead of the device path,
318 so that the memory card is really really shown in the UI.
320 2007-08-16 Murray Cumming <murrayc@murrayc.com>
322 * src/maemo/easysetup/modest-easysetup-wizard.c:
323 (get_entered_account_title), (on_before_next), (entry_is_empty),
325 * src/maemo/modest-account-settings-dialog.c:
326 (get_entered_account_title), (on_button_signature), (check_data),
327 (save_configuration), (entry_is_empty):
328 Strip the account title of whitespace at the start and end before
329 using it or checking it. This means that an all-whitespace title
330 is not allowed, fixing projects.maemo.org bug NB#64977.
332 2007-08-15 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-ui-actions.h:
335 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
336 to modest_run_account_setup_wizard() and made it public.
337 * src/dbus_api/modest-dbus-callbacks.c:
338 (check_and_offer_account_creation), (on_idle_mail_to),
339 (on_idle_compose_mail), (on_idle_open_default_inbox):
340 Offer account creation if necessary, fixing projects.maemo.org
343 2007-08-15 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-ui-actions.c: (run_account_setup_wizard):
346 Return a gboolean to indicate success.
347 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
348 (modest_ui_actions_on_send): When offering account creation, only
349 give up (return) if account creation failed. Otherwise continue
350 with the original request. This fixed projects.maemo.org bug
353 2007-08-15 Murray Cumming <murrayc@murrayc.com>
355 * src/widgets/modest-recpt-editor.c:
356 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
357 to fix projects.maemo.org bug NB#63789.
359 2007-08-15 Murray Cumming <murrayc@murrayc.com>
361 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
362 (modest_tny_account_store_new): Properly detect the memory card at
363 startup, and add an account for it.
365 2007-08-14 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
368 Commented out the MMC code again because it mistakenly detects
369 the card even when it isn't inserted.
371 2007-08-14 Murray Cumming <murrayc@murrayc.com>
373 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
374 Renabled the call to add_mmc_account() because I do not believe
375 it could be the cause of the mentioned hang (in scratchbox, where
376 there is no memory card), and because I have tested that it works
379 2007-08-14 Murray Cumming <murrayc@murrayc.com>
381 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
382 Comment out part of the last commit because it apparently causes
385 2007-08-14 Murray Cumming <murrayc@murrayc.com>
387 * src/modest-tny-account-store.c: Added the add_mmc_account()
388 function to save some copy/pasting.
389 (modest_tny_account_store_new): If the memory card is mounted,
390 create an account for it at the start, instead of waiting for the
391 user to unmount it and mount it.
393 2007-08-13 Murray Cumming <murrayc@murrayc.com>
395 * src/widgets/modest-account-view.c: (on_account_changed):
396 Do not try to use the human-readable TnyAccount name instead of the
397 ID of the modest account to get the transport account. And unref
398 the transport account. This prevents a g_warning(), and a possible
401 2007-08-13 Murray Cumming <murrayc@murrayc.com>
403 * src/maemo/modest-platform.c:
404 (modest_platform_set_update_interval): Handle the new
405 alarmd error to warn when alarmd is not running, as is the case in
406 scratchbox for me now because
407 "Module /usr/lib/alarmd/libretu.so initialization failed"
409 2007-08-13 Murray Cumming <murrayc@murrayc.com>
411 * src/widgets/modest-header-view-render.c:
412 (_modest_header_view_compact_header_cell_data):
413 NULL some strings after freeing them, trying to deal with
414 the double deletion found in projects.maemo.org bug 64183,
415 probably having no effect.
417 2007-08-13 Murray Cumming <murrayc@murrayc.com>
419 * src/maemo/modest-account-settings-dialog.c:
420 (create_page_incoming), (create_page_outgoing): Use a define
421 for the min and max port numbers.
423 (check_hildon_number_editor_and_warn_value_not_in_range),
424 (check_data): Do an extra check for an invalid port number, as needed
425 in projects.maemo.org bug #64275, when the number is cleared, but this
426 does not work due to bugs.maemo.org bug #1806.
428 2007-08-13 Murray Cumming <murrayc@murrayc.com>
430 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
431 Comment out the debug warning about the unexpected D-Bus methods.
432 They are just annoying now.
433 * src/maemo/modest-platform.c:
434 (modest_platform_set_update_interval): Correct the D-Bus path, instead
435 of using a file path, though it did not seem to break things before.
436 It might be needed now:
437 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
438 modest is not already running. This is the behaviour of the old client, and
439 Mox says it is what we should do for modest.
440 This closes projects.maemo.org bug NB#64327.
442 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
444 * src/modest-text-utils.c:
445 Fixed invalid jump due to incorrect string/pointer
447 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
450 2007-08-01 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-account-mgr-helpers.h:
453 * src/modest-account-mgr-helpers.c:
454 Added modest_account_mgr_get_first_account_name(),
455 using code from modest_account_mgr_set_first_account_as_default().
457 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
458 (account_number_changed): Call set_at_least_one_account_visible() so that
459 the first account is visible when first added, without the user having to
461 I do wonder how this worked before.
463 2007-08-01 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-tny-account-store.c: (show_password_warning_only),
466 (show_wrong_password), (request_password_and_wait), (get_password),
467 (modest_tny_account_store_alert): Remove the (incomplete anyway)
468 attempts to show UI only in the main context, which used g_idle_add()
469 and mainloops, because tinymail now guarantees that it only calls these
470 callbacks in the mainloop with the gdk lock. This makes everything much
473 2007-08-01 Murray Cumming <murrayc@murrayc.com>
475 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
476 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
477 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
478 error dialog, instead of ignoring it.
480 2007-08-01 Murray Cumming <murrayc@murrayc.com>
482 * src/maemo/modest-msg-view-window.c:
483 (modest_msg_view_window_get_header),
484 (modest_msg_view_window_last_message_selected):
485 Added comments to explain the use of priv->header_model.
486 * src/modest-ui-dimming-rules.c:
487 (modest_ui_dimming_rules_on_open_msg),
488 (modest_ui_dimming_rules_on_mark_as_read_msg),
489 (modest_ui_dimming_rules_on_mark_as_unread_msg),
490 (modest_ui_dimming_rules_on_remove_attachments),
491 (_invalid_attach_selected), (_selected_msg_marked_as):
492 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
493 and changed the parameter to a ModestMainWindow to make it clearer that
494 it never uses any other kind of window.
495 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
496 instead of the selected message.
497 I notice that much of the dimming code and the ModestMsgViewWindow code
498 hard-codes the assumption that the viewed message is always selected in
499 the header view. This does not seem wise or simple.
501 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
502 examine the actual message instead of whatever might be selected
503 in the header view. This stops the delete toolbar button and menu item
504 from being dimmed when opening a message view the search UI,
505 partially fixing projects.maemo.org bug NB#63811.
507 However, when actually deleting, I now get this warning:
508 "tny_header_set_flags: This is a header instance for a new message.
509 Only priority and attachment flags are supported"
511 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
513 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
515 Show account wizard if no accounts are defined while sending
516 (automatic sending after the account wizard finished does not
517 work because it takes some time until the account manager
518 synchronizes everything. (projects.maemo.org NB#62792)
520 2007-07-30 Murray Cumming <murrayc@murrayc.com>
522 * src/modest-tny-account-store.c: (on_account_removed),
523 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
524 account is removed from the View menu. We have TnyAccountStore
525 and ModestTnyAccountStore signals that seem very similar, but this
526 seems to work for now.
528 * src/maemo/modest-main-window.c:
529 (on_show_account_action_activated): Prevent dereference
530 of a NULL if the accoutn does not really exist, though that
531 should not happen anymore.
533 This fixes projects.maemo.org bug NB#64606.
535 2007-07-30 Murray Cumming <murrayc@murrayc.com>
537 * src/modest-ui-actions.c: (run_account_setup_wizard),
538 (modest_ui_actions_on_accounts): Revert a change that set these
539 to modal dialogs, freezing the UI when they show secondary dialogs.
540 This fixed projects.maemo.org bug NB#64519.
542 2007-07-27 Murray Cumming <murrayc@murrayc.com>
544 * src/widgets/modest-header-view-render.c:
545 (_modest_header_view_compact_header_cell_data):
546 Some checks and initialization to try to deal with a crash,
547 probably ineffective.
549 2007-07-27 Murray Cumming <murrayc@murrayc.com>
551 * src/maemo/modest-maemo-utils.c:
552 (modest_maemo_utils_get_supported_secure_authentication_methods):
553 Make sure that we have a connection, asking the user for one
555 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
556 Check for a connection before showing the wizard, because
557 the wizard needs a connection to check for server capabilities.
559 2007-07-27 Murray Cumming <murrayc@murrayc.com>
561 * src/maemo/modest-account-view-window.c:
562 (on_new_button_clicked): Remember the wizard dialog instance,
563 so we can just present it again if necessary. This prevents
564 multiple windows from appearing if you click again quickly on the
565 New button before the dialog appears, fixing projects.maemo.org
568 2007-07-27 Murray Cumming <murrayc@murrayc.com>
570 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
571 Offer a connection dialog if there is no connection when
572 starting modest. This should fix projects.maemo.org bug NB#61134.
574 2007-07-27 Murray Cumming <murrayc@murrayc.com>
576 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
577 Reverted my last commit. I was able to fix the build by doing
578 apt-get install wpeditor0 (replacing other wpeditor packages) and
579 an explicit apt-get install wpeditor-dev to upgrade the -dev
582 2007-07-27 Murray Cumming <murrayc@murrayc.com>
584 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
585 Commented out the use of wp_text_buffer_replace_image()
586 because it does not exist, to break the build. Added a TODO for it.
588 2007-07-26 Murray Cumming <murrayc@murrayc.com>
590 * src/modest-tny-account-store.c: (recreate_all_accounts):
591 Recreate them even if they were NULL before. I guess something
592 else was already creating them before, or this would never
594 (modest_tny_account_store_get_server_account): Make sure that
595 the tny accounts have been created before trying to find one.
596 This allows libmodest_dbus_client_compose_mail() to work
597 when the UI is not yet visible.
598 This is probably useful in other cases too.
600 (get_password): When the password is wrong after it is entered
601 in the protected password dialog, show an info banner (in an
602 idle handler) before showing the protected password dialog
605 2007-07-26 Murray Cumming <murrayc@murrayc.com>
607 * src/modest-ui-actions.h:
608 * src/modest-ui-actions.c: Added
609 modest_do_refresh_current_folder() containing some code from
610 modest_ui_actions_on_send_receive().
611 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
612 Call modest_do_refresh_current_folder() before refreshing the
613 requested account, as in modest_ui_actions_on_send_receive().
614 This is strange, but seems to be necessary to show new mails.
615 Now new emails are finally visible in the UI when downloaded
616 via the automatic update interval, fixing bug NB#57458.
617 This also works because bug NB#57458 has been fixed somehow.
619 2007-07-26 Murray Cumming <murrayc@murrayc.com>
621 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
622 printf more details when we get unhandled D-Bus methods, because
625 * src/modest-mail-operation.c: (update_account_thread):
626 Comment out the tny_camel_pop_store_account_reconnect(), because this
627 is apparently no longer needed, and it did not work before anyway.
628 See the comment in the code.
630 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
631 by checking the header flags. This fixes projects.maemo.org bug
634 2007-07-25 Murray Cumming <murrayc@murrayc.com>
636 * src/maemo/modest-maemo-utils.h:
637 * src/maemo/modest-maemo-utils.c: Added
638 modest_maemo_show_information_note_in_main_context_and_forget().
639 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
640 Use the new function to show simple error dialogs in the main
641 context, though question dialogs are still in the current context,
642 which is unfortunately usually not the main context. This should
645 2007-07-25 Murray Cumming <murrayc@murrayc.com>
647 * src/modest-tny-account-store.c: (get_password):
648 Never save the entered username and password in gconf,
649 because the UI spec says we should not. This helps
650 slightly with projects.maemo.org bug NB#63671.
652 2007-07-25 Murray Cumming <murrayc@murrayc.com>
654 * src/widgets/modest-msg-edit-window.h:
655 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
656 Moved some code here to make it simpler.
657 (modest_msg_edit_window_attach_file_one): Renamed from
658 modest_msg_edit_window_attach_file_interactive().
659 (modest_msg_edit_window_offer_attach_file): Renamed from
660 modest_msg_edit_window_attach_file() and used
661 modest_msg_edit_window_attach_file_one() instead of
662 copy/pasting the code. The old code for one was not using
663 GnomeVFS. This allows use of smb:// URLs when using send-as
664 from external applications, fixing bug NB#63741.
666 (modest_msg_edit_window_insert_image),
667 (modest_msg_edit_window_add_attachment_clicked):
668 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
669 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
670 Adapted to the new function names.
672 2007-07-25 Murray Cumming <murrayc@murrayc.com>
674 (modest_platform_set_update_interval): Set the alarm recurrence
675 fields so that auto-update does not just happen the first time.
676 This should have fixed projects.maemo.org bug NB#63938.
678 When this happens you can see a printf when the D-Bus method is
680 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
682 However, I do not actually seem to get new POP messages even when
683 clicking the refresh button manually. A restart gets them.
684 This might be a problem in today's tinymail only.
686 2007-07-24 Murray Cumming <murrayc@murrayc.com>
688 * src/maemo/modest-maemo-global-settings-dialog.c:
689 (current_connection):
690 Avoid a crash (probably only in scratchbox) when strcmp()ing a
691 NULL when closing the dialog.
693 2007-07-24 Murray Cumming <murrayc@murrayc.com>
695 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
696 Remove the hacky send/receive that didn't work, and instead
697 refilter the treemodel to make the deleted email really vanish from
698 the UI (though the delete-from-menu code does has commented out
699 the code that does that). This fixes projects.maemo.org bug
702 2007-07-24 Murray Cumming <murrayc@murrayc.com>
704 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
705 Try a couple of tricks to force the treeview to update (
706 poke the folder, and do a send/receive refresh), but the deleted
707 email still appears with a strike-through instead of really being
710 2007-07-23 Murray Cumming <murrayc@murrayc.com>
712 * src/dbus_api/modest-dbus-callbacks.c:
713 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
714 because their ID is not human-readable (see the comment about
715 improvements needed to the osso-email-interface API) and
716 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
718 2007-07-23 Murray Cumming <murrayc@murrayc.com>
720 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
721 (add_folders_to_list), (on_dbus_method_get_folders),
722 (modest_dbus_req_filter):
723 * src/maemo/modest-maemo-utils.c:
724 (on_camel_account_get_supported_secure_authentication):
725 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
726 (on_header_view_focus_in):
727 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
728 * src/modest-formatter.c: (modest_formatter_create_body_part):
729 * src/modest-mail-operation.c: (recurse_folders),
730 (update_account_thread), (get_msgs_full_thread),
731 (modest_mail_operation_get_msgs_full),
732 (modest_mail_operation_xfer_msgs):
733 * src/modest-search.c: (search_mime_part_and_child_parts),
734 (modest_search_account), (modest_search_all_accounts):
735 * src/modest-tny-account.c:
736 (modest_tny_account_get_special_folder), (recurse_folders):
737 * src/modest-tny-local-folders-account.c:
738 (modest_tny_local_folders_account_query_passes):
739 * src/modest-tny-msg.c: (copy_mime_part),
740 (modest_tny_msg_find_body_part_from_mime_part):
741 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
742 (modest_tny_send_queue_try_to_send):
743 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
744 (_modest_ui_actions_open), (download_uncached_messages),
745 (reply_forward), (modest_ui_actions_on_copy),
746 (modest_ui_actions_on_details), (has_retrieved_msgs),
747 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
749 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
750 (_selected_msg_marked_as), (_msg_download_completed),
751 (_selected_msg_sent_in_progress):
752 * src/widgets/modest-attachments-view.c:
753 (modest_attachments_view_set_message):
754 * src/widgets/modest-msg-view.c: (find_cid_image):
755 * tests/check_folder-transfer.c: (find_folders):
756 * tests/check_update-account.c: (func):
757 * tests/dbus_api/test_get_folders.c: (main):
758 Checked all uses of tny_iterator_get_current(), making sure
759 that the object is unreferenced (3 or 4 places did not),
760 and adding checks for NULL.
762 2007-07-23 Murray Cumming <murrayc@murrayc.com>
764 * src/dbus_api/modest-dbus-callbacks.c:
765 (on_idle_open_default_inbox): Make sure that the application UI is
767 * src/maemo/easysetup/modest-easysetup-wizard.c:
768 (on_entry_invalid_character): Show the word whitespace instead
769 of (null) in the banner when whitespace was entered.
770 (show_error): Add a comment that this does not work in
771 Maemo Bora, though we do not know why.
773 2007-07-23 Murray Cumming <murrayc@murrayc.com>
775 * src/modest-tny-account.c:
776 (modest_tny_account_get_special_folder): Use an if instead of
777 an assert for when the parent account name is NULL, because this
778 might be causing a crash in projects.maemo.org bug 63192.
779 * src/modest-mail-operation.c:
780 (modest_mail_operation_send_new_mail_cb),
781 (modest_mail_operation_remove_folder): unref the folder that is
782 returned from modest_tny_account_get_special_folder().
784 2007-07-23 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-ui-actions.c:
787 (modest_ui_actions_on_password_requested):
788 Show mail_ib_login_cancelled info banner when the user cancels
789 the protected password dialog, to fix projects.maemo.org
792 2007-07-23 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/modest-account-settings-dialog.c:
795 (create_page_outgoing): Put this page in a GtkScrolledWindow,
796 matching the UI mock-up in the UI spec, and allowing access
797 to all widgets even when the on-screen keyboard is active.
799 2007-07-23 Murray Cumming <murrayc@murrayc.com>
801 Reverted this previous commit from Johannes,
802 because the scrollbars are always visible and because
803 I think we only need it on onepage of the account
804 settings, not the account wizard.
805 (I wrote the wrong instructions in the bug.)
807 * src/maemo/easysetup/modest-easysetup-wizard.c:
808 Added scrollbars to account wizard dialog.
809 Fixed projects.maemo.org NB #62744
811 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
813 * src/maemo/easysetup/modest-easysetup-wizard.c:
814 (create_page_user_details):
815 Use auto-cap for name (projects.maemo.org NB#63716)
816 * src/widgets/modest-account-view.c: (on_account_busy_changed):
818 2007-07-22 Armin Burgmeier <armin@openismus.com>
820 * src/maemo/modest-ui-actions.c: Use current account instead of
821 default account for creating viewer windows, so that the viewer
822 window knows to which account the viewed message belongs.
824 * src/maemo/modest-msg-view-window.c: Destroy the window when the
825 corresponding account is deleted. This fixes projects.maemo.org bug
828 2007-07-18 Armin Burgmeier <armin@openismus.com>
830 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
831 the dialog close after entering an invalid port number and clicking
832 OK. This fixes projects.maemo.org bug NB#63602.
834 2007-07-18 Armin Burgmeier <armin@openismus.com>
836 * src/modest-tny-account-store.c:
837 (get_server_accounts): Set parent modest account name for each
838 connection-specific transport account so that special folders of such
839 an account can be looked up. This fixes a crash when changing account
840 settings. This might also be related to projects.maemo.org bug
843 2007-07-16 Armin Burgmeier <armin@openismus.com>
845 * src/modest-ui-actions.c: Added a button to create a folder to the
846 move-to dialog. This fixes projects.maemo.org bug NB#59863.
848 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
850 * src/maemo/easysetup/modest-easysetup-wizard.c:
851 Added scrollbars to account wizard dialog.
852 Fixed projects.maemo.org NB #62744
854 2007-07-16 Murray Cumming <murrayc@murrayc.com>
856 * src/widgets/modest-msg-view.h:
857 * src/widgets/modest-msg-view.c:
858 Added modest_msg_view_get_message_is_empty() but this needs
860 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
861 Check if there is any text in the message yet.
862 But this needs to be implemented properly.
863 (modest_msg_edit_window_toggle_find_toolbar):
864 * src/maemo/modest-msg-view-window.c:
865 (modest_msg_view_window_toggle_find_toolbar):
866 Show a banner warning if there is no text to search, when
867 trying to start a search. This partially fixes
868 projects.maemo.org bug NB#62350.
870 2007-07-13 Murray Cumming <murrayc@murrayc.com>
872 * src/modest-mail-operation.c: (update_account_thread):
873 Initialized num_new_headers to fix the build.
875 2007-07-13 Murray Cumming <murrayc@murrayc.com>
877 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
878 Ignore modest accounts whose server accounts don't exist in gconf.
879 This prevents us trying to create TnyAccount instances for those
880 server accounts when the server account has been removed from gconf,
881 but the parent modest account has not yet been removed from modest.
882 I don't know why this is only noticeable now. It was probably just
883 a harmeless g_warning() anyway.
885 2007-07-13 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
888 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
890 2007-07-12 Armin Burgmeier <armin@openismus.com>
892 * src/maemo/modest-main-window.c: Make default account appear bold
893 in view, tools/send & receive and toolbar/send & receive SCM menus.
894 This fixes projects.maemo.org bug NB#59010.
896 2007-07-12 Murray Cumming <murrayc@murrayc.com>
898 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
899 Add a short-cut, by checking if the folder store is an account.
900 This ensures that the Sort menu item and toolbar is dimmed for
901 the local-folders account root item, fixing
902 projects.maemo.org bug NB#62545.
904 2007-07-12 Murray Cumming <murrayc@murrayc.com>
906 * src/modest-tny-account-store.c: (get_password):
907 Show the password dialog (via the signal) only in the mainloop, via
908 an idle handler that we wait for. This could theoretically prevent
909 hangs, though I worry that it could introduce some too.
911 2007-07-12 Murray Cumming <murrayc@murrayc.com>
913 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
914 * src/maemo/modest-platform.c:
915 (modest_platform_connect_and_wait):
916 Take a TnyAccount* parameter and try to set it to online
917 (a TnyCamel-only API), because tinymail sets accounts to offline
918 when the user cancels a password dialog, and doesn't ask again until
919 it has been set to online.
920 However, this is commented out because it causes a hang now.
922 (modest_platform_connect_and_wait_if_network_account):
923 * src/modest-mail-operation.c:
924 (modest_mail_operation_update_account):
925 * src/modest-platform.h:
926 * src/modest-ui-actions.c: (_modest_ui_actions_open),
927 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
929 2007-07-12 Armin Burgmeier <armin@openismus.com>
931 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
933 * src/modest-mail-operation.c:
934 * src/modest-ui-actions.c: Check for already existing folder before
935 querying the server, show error message from camel if the request
936 still fails. This fixes projects.maemo.org bug NB#58701.
938 2007-07-12 Murray Cumming <murrayc@murrayc.com>
940 * src/modest-tny-account-store.h:
941 * src/modest-tny-account-store.c:
942 Added modest_tny_account_store_forget_password_in_memory(),
943 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
944 when creating a new account, so that new passwords will be used, instead of
945 us thinking that it's a second request as a result of a failed password again.
947 2007-07-12 Murray Cumming <murrayc@murrayc.com>
949 * src/dbus_api/modest-dbus-callbacks.c:
950 (on_idle_open_message): If the message is in drafts then open it
951 in an edit window instead of a view window. This fixes
952 projects.maemo.org bug NB#63005.
954 2007-07-12 Murray Cumming <murrayc@murrayc.com>
956 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
957 Avoided a harmless g_warning().
959 2007-07-12 Murray Cumming <murrayc@murrayc.com>
961 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
962 Pass the modest account name, not the TnyAccount display name to
963 modest_msg_view_window_new() so that the reply feature works,
964 fixing projects.maemo.org bug NB#62892.
966 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
967 (modest_msg_view_window_new_with_header_model):
968 * src/maemo/modest-msg-view-window.c:
969 (modest_msg_view_window_new_with_header_model),
970 (modest_msg_view_window_new):
971 * src/modest-ui-actions.c: (reply_forward):
972 * src/widgets/modest-msg-view-window.h:
973 * src/widgets/modest-window.c: (modest_window_set_active_account):
974 Rename an account parameter to modest_account_name to make this clearer.
976 2007-07-11 Murray Cumming <murrayc@murrayc.com>
978 * src/modest-ui-actions.h:
979 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
980 modest_do_message_delete().
981 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
982 Call modest_do_message_delete(), hoping that this would cause messages
983 to be really deleted from search instead of just marked with strike through.
984 Does not seem to help.
986 2007-07-11 Armin Burgmeier <armin@openismus.com>
988 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
989 priv->reselect to FALSE prior to calling
990 modest_folder_view_select_first_inbox_or_local() to prevent endless
991 recursion and thus a crash on startup.
993 2007-07-11 Armin Burgmeier <armin@openismus.com>
995 * src/maemo/modest-account-settings-dialog.h: Include
996 <gtk/gtknotebook.h> to fix the build (at least for me).
998 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
999 Use "New FolderN" as default suggested name if "New folder" already
1000 exists, with N being the first free number, though never exceed "New
1001 folder99" in which case we just fall back to "New Folder" even though
1002 it already exists. This fixes projects.maemo.org bug NB#58663.
1004 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1006 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1007 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
1008 projects.maemo.org bug NB#62778.
1010 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1012 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1013 Ignore the wrong (for now) secure-smtp setting in the presets -
1014 just default to requiring secure authentication for SMTP, because
1015 that is most common.
1017 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
1019 * src/widgets/modest-folder-view.c: (filter_row)
1020 Do not show drafts folder (see UI specs)
1022 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
1024 * src/modest-ui-actions.c:
1025 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
1026 place and also not necessary.
1028 * src/widgets/modest-folder-view.c: (filter_row)
1029 Guess folder type and hide Sent & Outbox if necessary.
1030 Fixed project.maemo.org NB#57328
1032 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1034 * src/modest-ui-actions.h:
1035 * src/modest-ui-actions.c:
1036 (modest_ui_actions_on_delete_message):
1037 Move some code into a new
1038 modest_ui_actions_refresh_message_window_after_delete()
1039 function so we can use it from elsewhere.
1041 * src/dbus_api/modest-dbus-callbacks.c:
1042 (on_idle_delete_message), (on_delete_message): Used an idle
1043 handler, as we do for the other D-Bus method handlers.
1044 Call modest_ui_actions_refresh_message_window_after_delete()
1045 if the deleted message was open in a window. This fixed
1046 projects.maemo.org bug NB#62862.
1048 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1050 * src/modest-main.c: (main): Only show the UI at the start if
1051 the showui command line option was given. For instance,
1052 run-standalone src/modest showui
1053 Otherwise, we wait for the top_application D-Bus method to
1054 be sent by hildon-desktop when the application is selected
1056 This allows us to run without a UI when osso-global-search
1057 uses our D-Bus methods.
1059 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1061 * src/dbus_api/modest-dbus-api.h: Added a define for a
1062 top-application D-Bus method.
1063 * src/dbus_api/modest-dbus-callbacks.c:
1064 (on_top_application),
1065 (modest_dbus_req_handler): Handle the top-application D-Bus
1066 method, which might be an undocumented D-Bus signal sent by
1067 hildon-desktop when it starts the application from the menu.
1068 But I am not sure and I need to test it on the device, because
1069 my scratchbox does not have the application in the menu now.
1070 This method shows the main window, so that it can be invisible
1071 when started, for instance, just for email searching from
1074 * src/maemo/modest-main-window.c: (restore_settings),
1075 (modest_main_window_new): Do not show the window immediately
1076 upon creation. We show it later.
1077 * src/modest-widget-memory.c: (save_settings_paned):
1078 Try (unsuccessfully) to avoid saving the paned position when
1079 it is not even visible.
1080 (restore_settings_paned): Do not allow a silly paned position.
1081 This seems necessary when not showing the window at first.
1083 * tests/dbus_api/Makefile.am:
1084 * tests/dbus_api/test_top_application.c: (main): Test for the
1087 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1089 * src/modest-ui-dimming-rules.c:
1090 (modest_ui_dimming_rules_on_new_msg),
1091 (modest_ui_dimming_rules_on_reply_msg),
1092 (modest_ui_dimming_rules_on_delete_msg),
1093 (modest_ui_dimming_rules_on_details),
1094 (modest_ui_dimming_rules_on_view_window_move_to),
1095 (modest_ui_dimming_rules_on_view_previous),
1096 (modest_ui_dimming_rules_on_view_next),
1097 (_invalid_folder_for_purge): Added checks before
1098 casting the window. This looks like an actual
1099 logic error in _invalid_folder_for_purge(), because it
1100 tries to use a ModestMainWindow as a message window.
1102 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1104 * src/maemo/modest-account-settings-dialog.c:
1105 (show_error): Use the same implementation as in
1106 modest-easysetup-wizard.c:
1107 (on_entry_invalid_character): The logical ID contains a %s.
1108 Guessed what it should be.
1109 (on_entry_max), (check_data), (on_response): Adapt to
1110 changed show_error().
1111 (create_page_account_details): Really call
1112 modest_validating_entry_set_func() on the correct widgets.
1113 * src/maemo/easysetup/modest-easysetup-wizard.c:
1114 (on_entry_invalid_character): Fix the logical ID here too.
1115 (create_page_account_details),
1116 (create_page_user_details):
1118 modest_validating_entry_set_func() on the correct widgets.
1120 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1121 Do not try to use the account if it is NULL.
1123 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1125 * src/modest-ui-actions.c: (create_move_to_dialog),
1126 (modest_ui_actions_on_main_window_move_to),
1127 (modest_ui_actions_on_msg_view_window_move_to):
1128 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1129 (filter_row), (modest_folder_view_show_non_move_folders):
1130 * src/widgets/modest-folder-view.h:
1132 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1133 the Sent folder yet as it does not report the correct folder type.
1135 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1137 * src/maemo/modest-msg-edit-window.c: (init_window):
1140 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1142 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1143 Take a parent widget instead of a parent window, and
1144 implement this with hildon_banner_show_information() instead.
1145 Non-Maemo builds can just ifdef that there.
1146 This fixed projects.maemo.org bug NB#62766.
1148 (on_entry_invalid_character): Use show_error() again instead
1149 of using hildon directly, and use the _CS() macro to use the correct
1151 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1152 Pass a widget instead od a window to show_error().
1154 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1156 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1157 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1158 This allows us to show the server name in the error message, fixing
1159 projects.maemo.org bug NB#62904.
1160 Also, use the appropriate logical ID message for the account protocol.
1162 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1165 A compilation fix, though the build wasn't broken for me.
1167 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1169 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1170 Do not try to unref a NULL folder store, to avoid a runtime warning.
1171 This seems to happen sometimes when changing accounts settings.
1173 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-tny-account-store.c:
1176 (modest_tny_account_store_instance_init),
1177 (modest_tny_account_store_finalize),
1178 (on_account_settings_hide), (on_idle_wrong_password):
1179 Use a GHashTable to ensure that we only show one account settings
1180 dialog per modest account. This avoids us having a dialog open for
1181 both the store and transport accounts, or due to repeated get_password()
1182 calls that shouldn't happen anyway.
1184 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-maemo-utils.c: (on_hide),
1187 (modest_maemo_show_dialog_and_forget): Handle the response, because
1188 the window is not even hidden by default.
1190 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1191 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1192 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1193 which seems to prevent some modality problems.
1195 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1196 Ignore user cancellation errors.
1198 * src/modest-account-mgr-helpers.h:
1199 * src/modest-account-mgr-helpers.c:
1200 Added modest_server_account_get_password() and
1201 modest_server_account_get_has_password() to avoid direct use of
1204 * src/maemo/modest-account-settings-dialog.h:
1205 * src/maemo/modest-account-settings-dialog.c:
1206 (modest_account_settings_dialog_init): Store the notebook so we can
1208 Added modest_account_settings_dialog_switch_to_user_info().
1210 * src/modest-tny-account-store.c:
1211 (get_password): When the password in the account settings is wrong (we think),
1212 show the relevant page of the account settings dialog, in the mainloop.
1213 However, we currently get many of these at once because cancel does not
1215 (forget_password): Do not forget the password
1216 from the account settings, because this causes side-effects when
1217 tinymail seems to call it at strange time, maybe because of how we
1218 are cancelling get_password().
1219 (modest_tny_account_store_alert): Ignore user cancellations.
1221 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1223 * src/maemo/modest-maemo-utils.h:
1224 * src/maemo/modest-maemo-utils.c:
1225 Added modest_maemo_show_information_note_and_forget() for use instead of
1226 gtk_dialog_run() when the response is not needed, to avoid an extra
1227 mainloop which could cause a hang.
1229 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1230 Use the logical IDs for the error message, though they are not
1231 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1232 because gtk_dialog_run() caused a hang here (the window did not close).
1233 This fixes projects.maemo.org bug NB#62646.
1235 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1237 * src/modest-account-mgr-helpers.h:
1238 * src/modest-account-mgr-helpers.c:
1239 Added modest_account_mgr_get_store_protocol().
1241 * src/maemo/modest-account-view-window.c:
1242 (on_delete_button_clicked): Show different warning text depending on
1243 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1244 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1247 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1249 * src/maemo/modest-msg-edit-window.c:
1250 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1251 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1253 2007-07-07 Armin Burgmeier <armin@openismus.com>
1255 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1256 ckdg_ib_maximum_characters_reached from correct package.
1258 * src/modest-ui-actions.c: Show an error message when a folder could
1259 not be created. Tinymail does not give us specific error codes about
1260 what has gone wrong, so we assume that a folder with that name
1261 already exists, though there might be other reasons.
1263 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1266 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1267 give a more exact error message that can be partly translated.
1269 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1271 * src/maemo/modest-address-book.c:
1272 (select_email_addrs_for_contact): Specify a default window size for the
1273 select-email-address dialog, so that it is probably big enough for the
1274 title. This should fix projects.maemo.org bug NB#62277.
1276 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/easysetup/modest-easysetup-wizard.c:
1279 (create_page_complete_easysetup): Use
1280 gtk_widget_set_size() request to ensure that the text wraps
1283 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1285 * src/maemo/easysetup/modest-easysetup-wizard.c:
1286 (on_entry_invalid_character), (create_page_account_details),
1287 (create_page_user_details):
1288 Use new API of ModestValidatingEntry. But for some reason the banner is
1289 not shown. I will have to investigate that further.
1291 * src/widgets/modest-validating-entry.c: (on_insert_text),
1292 (modest_validating_entry_set_func):
1293 * src/widgets/modest-validating-entry.h:
1294 Added a new callback function to be able to react to prevented
1295 characters whitespaces to e.g show a banner.
1297 2007-07-05 Armin Burgmeier <armin@openismus.com>
1299 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1300 notification of HildonNumberEditor instead of remembering the port
1301 number. Thanks to Johannes for pointing this out.
1303 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1305 * src/maemo/easysetup/modest-easysetup-wizard.c:
1306 Check if there are any user changes before showing a confirmation
1307 dialog (projects.maemo.org NB#60946)
1309 2007-07-05 Armin Burgmeier <armin@openismus.com>
1311 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1312 number at the beginning of the dialog and set the modified flag at the
1313 end if the port number has changed. This is necessary because
1314 HildonNumberEditor does not support notification when the value has
1317 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1319 * src/modest-ui-actions.c:
1320 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1321 a connection before asking anything else. Correct the check for the destination
1322 folder so that it succeeds when online.
1323 This fixed projects.maemo.org bug NB#61645.
1325 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1327 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1328 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1329 to fix projects.maemo.org bug NB#62439.
1331 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-tny-account.c: (on_connection_status_changed):
1334 Really do not use tny_device_force_offline() here. See the previous comment.
1336 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1338 * src/modest-tny-account.c: (on_connection_status_changed):
1339 Do not use tny_device_force_offline() when tinymail says that something
1340 went wrong with the connection. It seems to report this unnecessarily.
1342 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1344 * src/maemo/modest-connection-specific-smtp-window.c:
1345 (modest_connection_specific_smtp_window_init):
1346 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1347 does not seem to have any effect in osso 1.1 (though it works in
1348 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1350 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1352 * src/maemo/modest-connection-specific-smtp-window.c:
1353 Fix UI specification problems with projects.meamo.org NB#60479
1355 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1357 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1358 clue when this has failed, because the error dialog is not always shown
1359 (at least in earlier version).
1361 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1362 GError message, because the generic error dialog is not helpful.
1364 'This message is not currently available (can't let a new connection go online)'
1365 when trying to open an IMAP message.
1367 (_modest_ui_actions_open): Offer a connection when some messages would
1368 have to be downloaded and we are offline.
1370 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1372 * src/widgets/modest-folder-view.c:
1373 Don't check for MERGE type anymore as we use the correct type
1375 NOTE: For the last two changes you need to update your tinymail copy
1376 because of API changes!
1378 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1380 * src/modest-tny-local-folders-account.c:
1381 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1382 (see projects.maemo.org NB#61580)
1384 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1386 * src/modest-tny-account.c: (on_connection_status_changed):
1387 Commented out the call to modest_platform_connect_and_wait() because this
1388 seems to always hang, and I would like to know if this is the only thing
1389 that causes a hang when showing the connection dialog.
1390 It is not very useful anyway.
1392 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1394 * src/maemo/modest-msg-view-window.c:
1395 (modest_msg_view_window_select_next_message):
1397 * src/modest-platform.h:
1398 * src/maemo/modest-platform.c:
1399 Added modest_platform_connect_and_wait(), which calls
1400 tny_maemo_conic_device_connect() always in the main thread, by calling it
1401 in an idle handler and waiting for the idle handler to run. It should be
1402 in the main thread because it uses GTK+ UI code. It just returns TRUE
1403 if the device is already online.
1405 There is some nasty code to ensure that subsequent calls to
1406 modest_platform_connect_and_wait() just wait for the first one to finish,
1407 by checking repeatedly in another idle handler. This is necessary,
1408 because other threads (or even the main thread, via another idle handler)
1409 can call modest_platform_connect_and_wait() while
1410 modest_platform_connect_and_wait() is running.
1412 (modest_platform_connect_and_wait_if_network_account),
1413 (modest_platform_connect_and_wait_if_network_folderstore):
1414 Convenience functions that calls modest_platform_connect_and_wait() if
1415 the account or folder might want network access.
1417 * src/modest-mail-operation.c:
1418 (modest_mail_operation_update_account):
1419 * src/modest-ui-actions.c: (download_uncached_messages),
1420 (modest_ui_actions_on_rename_folder), (delete_folder),
1421 (modest_ui_actions_on_main_window_move_to),
1422 (modest_ui_actions_on_msg_view_window_move_to):
1423 * src/widgets/modest-folder-view.c:
1424 (drag_and_drop_from_folder_view):
1425 Offer a connection if we are offline.
1427 * src/modest-tny-account.c: (on_connection_status_changed):
1428 Document this as only handling errors during network operations in progress,
1429 and replace the idle code with a simple call to
1430 modest_platform_connect_and_wait(), which does this instead.
1432 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1434 * src/modest-tny-account.c:
1435 (modest_tny_account_get_special_folder): (util_on_idle),
1436 Handle the GError so we can see when tny_folder_store_get_folders()
1437 fails, as it currently does while something else is connecting.
1439 Added util_run_in_main_thread_and_wait()
1440 which uses an idlen handler and mainloop to ensure that the function
1441 is called in the main thread.
1442 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1443 to make sure that we call attempt the connection in the mainloop only,
1444 which might solve some hangs.
1446 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1448 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1449 be found by their display name. This is never useful.
1450 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1451 by its ID, instead of trying to use its ID as its display name.
1453 * src/modest-tny-account-store.h:
1454 * src/modest-tny-account.c:
1455 (modest_tny_account_get_special_folder): Add a g_warning() when
1456 tny_folder_store_get_folders() returns an empty list for the maildir.
1458 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1459 Add a g_warning() when this returns NULL, because that it not allowed
1462 2007-07-02 Armin Burgmeier <armin@openismus.com>
1464 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1465 note when trying to cancel the wizard. This fixes projects.maemo.org
1468 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1470 * src/modest-tny-account.h:
1471 * src/modest-tny-account.c:
1472 (modest_tny_account_new_from_server_account),
1473 (modest_tny_account_new_from_server_account_name),
1474 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1475 because this must now be set before setting the proto. This is usd in
1476 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1477 warning in camel_session_get_service() caused by
1478 tny_camel_transport_account_prepare().
1480 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1483 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1485 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1487 (modest_connection_specific_smtp_edit_window_init):
1489 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1490 of "changed" for now
1492 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1494 * src/modest-tny-account.c:
1495 (modest_tny_account_new_from_server_account):
1496 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1497 now uses to request a connection when it needs one, and which it uses
1498 to tell us that something is wrong with the connection, so we can force
1499 the accounts offline to prevent further problems.
1501 * src/modest-defs.h:
1502 * src/modest-init.c: (init_default_settings):
1503 * src/modest-mail-operation.c:
1504 (modest_mail_operation_update_account):
1505 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1506 This should not be necessary anymore. Do not set the conf key that
1507 determined this (it was always TRUE and not set anywhere else).
1509 * src/modest-ui-actions.h: Remove unused and unimplemented
1510 modest_ui_actions_on_online_toggle_toggled().
1512 2007-06-29 Murray Cumming <murrayc@murrayc.com
1514 * src/maemo/modest-main-window.c: (connect_signals):
1515 Don't connect to delete_event twice. Maybe this was harmless.
1517 2007-06-29 Murray Cumming <murrayc@murrayc.com
1519 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1520 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1521 Debug output to give some more clue when a folder move is not allowed.
1523 2007-06-28 Murray Cumming <murrayc@murrayc.com
1525 * src/modest-tny-account.c: (on_modest_file_system_info),
1526 (modest_tny_account_get_mmc_account_name):
1527 Always call the callback, without checking whether the name has changed.
1528 * src/widgets/modest-folder-view.c: (strings_are_equal),
1529 (on_model_foreach_set_name), (on_get_mmc_account_name),
1530 (text_cell_data): Compare the name here, and use the name from
1531 the account rather than from the
1532 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1533 if the name was changed after the account was added to the model.
1534 That's a tinymail bug but not one that I want to fix now.
1536 This finally fixes projects.maemo.org bug NB#59301.
1538 2007-06-27 Armin Burgmeier <armin@openismus.com>
1540 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1543 2007-06-27 Murray Cumming <murrayc@murrayc.com
1545 * src/modest-tny-account.h:
1546 * src/modest-tny-account.c:
1547 Added modest_tny_account_get_mmc_account_name(), to set the memory
1548 card name asynchronously for the given account and then notify.
1549 (modest_tny_account_new_for_local_folders): Use this new function instead
1550 of using hildon_file_system_info_async_new() directly.
1552 * src/widgets/modest-folder-view.c: (text_cell_data):
1553 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1554 gtk_tree_model_row_changed() when it is available.
1556 This should fix projects.maemo.org bug NB#59301.
1558 2007-06-27 Murray Cumming <murrayc@murrayc.com
1560 * src/modest-mail-operation.c: (update_account_thread),
1561 (get_msgs_full_thread): Fix typo failures in the revert
1564 2007-06-27 Murray Cumming <murrayc@murrayc.com
1566 * src/maemo/modest-maemo-global-settings-dialog.c:
1567 (idle_select_default_focus):
1568 * src/modest-mail-operation.c: (idle_notify_progress),
1569 (idle_notify_progress_once), (set_last_updated_idle),
1570 (update_account_thread), (get_msgs_full_thread):
1571 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1572 * src/widgets/modest-header-view.c:
1573 (idle_notify_headers_count_changed_destroy),
1574 (idle_notify_headers_count_changed):
1575 Reverted the additions of gdk_threads_enter/leave(), in case this
1576 helps with a startup hang on the device.
1578 2007-06-26 Armin Burgmeier <armin@openismus.com>
1580 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1581 for supported secure authentication methods from server by
1582 gtk_dialog_run(), saving CPU time and a potential race condition.
1584 2007-06-26 Armin Burgmeier <armin@openismus.com>
1586 * src/maemo/modest-maemo-utils.h:
1587 * src/maemo/modest-maemo-utils.c: Added a
1588 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1589 only error code to tell the calling code when the user canceled the
1592 * src/maemo/modest-account-settings-dialog.h:
1593 * src/maemo/modest-account-settings-dialog.c:
1594 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1595 message if the retrieval of secure authentication methods was canceled
1596 by the user. Perform the check before saving anything to configuration
1597 to not end up with half-committed configuration changes, do not show
1598 a "Saving to configuration failed" note when authentication methods
1599 could not be retrieved.
1601 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1604 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1606 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1607 Only return the first level of folders under accounts, because the
1608 osso-global-search UI spec doesn't want the rest.
1609 This fixed projects.maemo.org bug NB#61811.
1611 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-tny-account-store.c:
1614 * src/modest-tny-account-store.h:
1615 Added modest_tny_account_is_memory_card_account().
1616 * src/maemo/modest-main-window.c: (create_details_widget):
1617 Show the same information items for the memory card as we show for the
1618 local-folders, to fix projects.maemo.org bug NB#59307.
1620 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-tny-account-store.c: (get_password):
1623 Added some checks for NULL to maybe prevent crashes, though I think
1624 it was Philip's last commit that actually prevented the crash here
1625 when creating a first new account.
1626 But the new account is still not usable (no messages are shown)
1627 until a restart of the application.
1629 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1631 * src/maemo/modest-maemo-global-settings-dialog.c:
1632 (idle_select_default_focus):
1633 * src/modest-mail-operation.c: (idle_notify_progress),
1634 (idle_notify_progress_once), (idle_notify_update_account_queue),
1635 (set_last_updated_idle), (update_account_thread),
1636 (notify_get_msgs_full), (get_msgs_full_destroyer),
1637 (get_msgs_full_thread):
1638 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1639 * src/widgets/modest-header-view.c:
1640 (idle_notify_headers_count_changed_destroy),
1641 (idle_notify_headers_count_changed):
1642 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1643 all idle handlers, because some other thread could be blocking
1644 the GDK lock, so that it can do GUI stuff.
1646 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1648 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1649 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1650 (on_idle_send_receive), (on_idle_open_default_inbox):
1651 * src/maemo/modest-msg-edit-window.c:
1652 (modest_msg_edit_window_attach_file_noninteractive):
1653 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1654 to prevent a hang. I don't quite understand why these are necessary,
1655 beause we should already be in the main loop. I guess something outside
1656 of the main loop is taking the lock.
1658 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1659 we are really using URIs, and use files that are more likely to exist.
1661 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1663 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1664 necessary because configure.ac now defines different variables.
1666 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1668 * libmodest-dbus-client/libmodest-dbus-client.c:
1669 * libmodest-dbus-client/libmodest-dbus-client.h:
1670 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1671 libmodest_dbus_client_compose_mail() is what things actually use.
1673 * src/dbus_api/modest-dbus-api.h:
1674 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1675 * tests/dbus_api/Makefile.am:
1676 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1679 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1681 * src/modest-init.c: (modest_init_local_folders):
1682 For memory-card (or other non local-folders) maildir accounts,
1683 always create an Archive folder, so that there is somewhere to put
1684 messages. This should be less confusing, because the user does not need
1685 to guess that the need to create a folder.
1687 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1689 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1690 Fixed icon size by using (50, 50) which is the same as defined by
1693 2007-06-25 Armin Burgmeier <armin@openismus.com>
1695 * src/widgets/modest-window-mgr.c:
1696 * src/modest-init.c:
1697 * configure.ac: Correctly recognize hildon-notify presence and fixed
1698 the build without it being installed.
1700 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1702 * libmodest-dbus-client/libmodest-dbus-client.c:
1703 (libmodest_dbus_client_search): Fix the build. Sorry.
1704 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1705 (reply_forward_cb): Initialize variables to fix the build.
1707 * src/modest-tny-account-store.c:
1708 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1709 comparison (a silly typo) so that email search results can be opened
1710 when there are more than one account.
1712 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1714 * libmodest-dbus-client/libmodest-dbus-client.c:
1715 (libmodest_dbus_client_search),
1716 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1717 instead of 1 second, because the search gets folders and messages from
1718 the server, which can take a long time. When it times out,
1719 osso-global-search will report no results.
1721 We need to specify whether we should search only cached information
1722 (maybe with a user preference), and the osso-email-search-plugin
1723 API should really be improved to allow that option, and to allow results
1724 to be delivered asynchronously in batches.
1726 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1728 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1729 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1730 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1732 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1734 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1735 that is an empty string. D-Bus seems to give us these instead of NULL.
1737 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1739 * src/dbus_api/modest-dbus-callbacks.c:
1740 * src/maemo/easysetup/modest-easysetup-wizard.h:
1741 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1742 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1743 (modest_connection_specific_smtp_edit_window_init):
1744 * src/maemo/modest-maemo-global-settings-dialog.c:
1746 * src/maemo/modest-maemo-utils.c:
1747 (modest_maemo_utils_setup_images_filechooser):
1748 * src/maemo/modest-main-window.c: (create_details_widget):
1749 * src/maemo/modest-msg-edit-window.c:
1750 (modest_msg_edit_window_attach_file_noninteractive),
1751 (modest_msg_edit_window_color_button_change),
1752 (modest_msg_edit_window_set_zoom):
1753 * src/modest-mail-operation.c: (update_account_thread):
1754 * src/modest-tny-account-store.c:
1755 * src/modest-tny-account.c:
1756 * src/widgets/modest-global-settings-dialog.c:
1757 * src/widgets/modest-window.h:
1759 Fixed build on bora!
1761 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1763 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1764 * src/modest-search.c: (modest_search_folder),
1765 (modest_search_all_accounts): Actually search only in the specified folder,
1766 doing a simple match on the folder ID.
1767 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1768 and added some documentation.
1770 2007-06-22 Armin Burgmeier <armin@openismus.com>
1772 * src/maemo/modest-maemo-utils.h:
1773 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1774 modest_maemo_utils_get_supported_secure_authentication_methods.
1776 * src/maemo/easysetup/modest-easysetup-wizard.c:
1777 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1778 one occured, not just "Server does not support secure authentication".
1780 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1782 * src/modest-tny-account-store.c: (get_password):
1783 Restored the call to tny_account_set_user() because Philip seems to have
1784 stopped this from crashing (by not using the freed string). It still does
1785 not work, but now we can test it.
1787 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1789 * src/maemo/modest-msg-edit-window.c: (init_window):
1790 Comment out use of an uninitialzed GtkScrolledWindow variable,
1791 to fix the build and stop a crash. Yet again.
1793 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1795 * src/modest-tny-account-store.c: (get_password):
1796 Remove the call to tny_account_set_user() because this actually crashes.
1797 As mentioned in the last commit, it is known to not work anyway.
1799 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-tny-account-store.c: (get_password):
1802 Use tny_account_set_username() to tell tinymail that the username might
1803 have changed too. But tinymail ignores this: see projects.maemo.org
1805 * src/modest-ui-actions.c:
1806 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1807 reset the connection when changing the username, and improve the comments.
1808 Save the changed username to gconf at least, so it is used when Modest is
1811 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1813 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1814 Do not use a query, so that we get all folders, including for POP and
1815 local-folders. They work as search criteria too.
1816 This fixes projects.maemo.org bug NB#57740.
1818 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1820 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1821 Comment out the use of hildon_notification_set_sound() because it is
1822 not declared, to fix the build. Warnings are serious, people.
1824 2007-06-21 Armin Burgmeier <armin@openismus.com>
1826 * src/maemo/modest-maemo-utils.h:
1827 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1828 modest_maemo_utils_get_supported_secure_authentication_methods()
1829 to query authentication methods for a specific user. This should fix
1830 projects.maemo.org bug NB#61369.
1832 * src/maemo/easysetup/modest-easysetup-wizard.c:
1833 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1836 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1838 * libmodest-dbus-client/libmodest-dbus-client.h:
1839 * libmodest-dbus-client/libmodest-dbus-client.c:
1840 (modest_dbus_message_iter_get_search_hit),
1841 (libmodest_dbus_client_search):
1842 Reorganised and commented this.
1843 Removed modest_search_hit_free() from the public API because it
1846 Added libmodest_dbus_client_get_folders() and
1847 modest_folder_result_list_free().
1849 * src/dbus_api/modest-dbus-api.h:
1850 * src/dbus_api/modest-dbus-callbacks.c:
1851 (modest_dbus_req_filter): Commented. Moved most code to
1852 on_dbus_method_search() and added on_dbus_method_get_folders().
1854 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1855 of the extra D-Bus handler.
1857 * tests/dbus_api/Makefile.am:
1858 * tests/dbus_api/test_get_folders.c: New test for
1859 libmodest_dbus_client_get_folders(). This seems to return an empty list
1860 at the moment. That could be the same error that causes the message list
1861 to be empty sometimes.
1862 This should help with projects.maemo.org bug NB#57740.
1864 2007-06-21 Armin Burgmeier <armin@openismus.com>
1866 * src/modest-mail-operation.c: Do not call
1867 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1868 notify the operation's end after having set the status to CANCELED for
1869 the operation queue to listen on. This fixes a deadlock when there
1870 were mail operations in the queue during its finalization.
1872 * src/modest-singletons.c: Reordered uninitialization of the account
1873 manager to happen after the mail operation queue was uninitialized
1874 because the mail operation's in the queue might still try to access
1875 the account manager (see modest_mail_operation_notify_end()). This
1876 fixes a potential crash when terminating the application.
1878 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1880 * src/modest-search.c:
1881 (search_mime_part_and_child_parts): Moved some code here so we
1882 can search recursively in child folders.
1883 (modest_search_folder): Search in the message as a mime part, instead
1884 of just its child mime parts.
1885 (read_chunk), (search_mime_part_ogs):
1886 Check how many bytes were read, to prevent an endless loop.
1887 Searching in message bodies now works. This finishes the fix for
1888 projects.maemo.org bug NB#61007.
1890 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1892 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1893 Add a g_warning when the item is not a folder.
1895 * src/modest-ui-dimming-rules.c:
1896 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1897 when selected item is not a folder (for instance, an account), because
1898 the UI spec only talks about folders.
1899 I am not sure what the UI spec wants, so this might not totally fix
1900 projects.maemo.org bug NB#60794.
1902 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1904 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1905 (load_from_file): Sort the list. The unsorted list would be more noticeable
1906 in non-English locales.
1908 * src/maemo/modest-msg-edit-window.c:
1909 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1910 warning and fix the build.
1912 * src/maemo/modest-progress-bar-widget.c:
1913 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1914 avoid a g_warning, and probably to avoid a crash.
1916 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1918 * src/modest-search.c: (modest_search_folder): Check for a GError
1919 when calling tny_folder_get_headers(), to show that this is not the cause
1922 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1924 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1925 Actually set the body query instead of the subject query.
1927 * src/modest-search.c: (search_mime_part_ogs),
1928 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1929 which would probably cause it to fail if we got this far.
1931 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1932 to simplify the code.
1933 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1934 be causing search-in-body to fail.
1936 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1938 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1940 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1941 Better debug message when the folder cannot be found.
1942 This should help with fixing projects.maemo.org bug #61287.
1943 * src/modest-search.c: (add_hit): Do not leak the furl string.
1945 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1947 * src/modest-ui-actions.c:
1948 (modest_ui_actions_on_folder_selection_changed):
1949 Do not special-case TNY_MERGE_FOLDER here, because
1950 modest_tny_folder_get_account() already does that. This fixes
1951 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1952 shown when the Outbox was selected).
1954 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1956 * libmodest-dbus-client/libmodest-dbus-client.c:
1957 (_dbus_iter_get_string_or_null): Initialize the string variable in
1958 case this helps with Dirk's crash.
1960 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1962 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1963 though it is not implemented yet (this function is maybe not even used),
1964 to avoid breaking ABI in future.
1965 * libmodest-dbus-client/libmodest-dbus-client.c:
1966 (get_attachments_string): Moved some code into this generic function.
1967 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1968 sends email. It is maybe not used.
1969 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1970 (on_send_mail): Use attachments.
1972 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1973 * src/maemo/modest-msg-edit-window.c:
1974 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1975 a filename before using it, to fix projects.maemo.org bug NB#58233.
1977 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1979 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1980 Initialize the continue_download variable to fix the build, and probably
1981 to fix randome behaviour.
1983 2007-06-18 Armin Burgmeier <armin@openismus.com>
1985 * src/modest-tny-send-queue.h:
1986 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1987 the queue so we can later show it in the UI. Replaced
1988 modest_tny_send_queue_msg_is_being_sent() by
1989 modest_tny_send_queue_get_msg_status().
1991 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1993 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1994 gpointer. This probably was not harmful, but just to be sure.
1996 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1998 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1999 Fix the build, but leave the function broken on Bora, because
2000 hildon_uri_action_get_service() does not exist.
2001 osso_uri_action_get_service() does not exist either, it seems.
2003 2007-06-18 Murray Cumming <murrayc@murrayc.com>
2005 * src/modest-tny-account.c:
2006 (modest_tny_account_new_from_server_account):
2007 Uncommented the url debug output again, because it is useful for
2008 debugging, as I said in the comment.
2010 2007-06-18 Murray Cumming <murrayc@murrayc.com>
2012 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
2014 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
2015 for Mameo Bora, to fix the build.
2017 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
2020 Fixed build with hildon < 0.99
2022 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2023 Check if the selected account is busy instead of checking all accounts
2025 * src/modest-account-mgr-priv.h:
2026 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
2027 (modest_account_mgr_init), (compare_account_name),
2028 (modest_account_mgr_set_account_busy),
2029 (modest_account_mgr_account_is_busy):
2030 * src/modest-account-mgr.h:
2031 Added busy information to the account manager. It possible to
2032 set an account to busy or not busy now.
2034 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
2035 (modest_mail_operation_update_account),
2036 (modest_mail_operation_notify_end):
2037 Set the account to busy/not busy depending on the operation state.
2039 * src/widgets/modest-account-view.c:
2040 (modest_account_view_finalize), (get_last_updated_string),
2041 (update_account_view), (on_account_busy_changed), (init_view):
2042 Show string "Refreshing..." if the account is currently busy.
2044 All this fixes projects.maemo.org bug NB#59711
2046 2007-06-14 Armin Burgmeier <armin@openismus.com>
2048 * src/widgets/modest-attachments-view.h:
2049 * src/widgets/modest-attachments-view.c: Added
2050 modest_attachments_view_has_attachments() and fixed coordinate
2051 transformation in get_att_view_at_coords(). This fixes attachment
2054 * src/widgets/modest-msg-view.c: Make use of
2055 modest_attachments_view_has_attachments() to decide whether to show
2056 attachments in the header.
2058 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
2060 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2061 (on_change), (on_combo_security_changed),
2062 (modest_connection_specific_smtp_edit_window_init),
2063 (modest_connection_specific_smtp_edit_window_set_connection),
2064 (modest_connection_specific_smtp_edit_window_is_dirty):
2065 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2066 * src/maemo/modest-connection-specific-smtp-window.c:
2069 Show an comfirmation dialog for the smpt-edit-window if there are
2070 unsaved changes and the user hits cancel.
2071 (projects.maemo.org bug NB#60479)
2073 2007-06-14 Armin Burgmeier <armin@openismus.com>
2075 * src/maemo/easysetup/modest-easysetup-wizard.c:
2076 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
2077 address" info in banner instead of node, and select all the text as
2078 per UI spec. This fixes projects.maemo.org bug NB#60550.
2080 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
2082 reviewed by: <delete if not using a buddy>
2084 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
2085 * src/modest-ui-actions.c: (folder_refreshed_cb):
2087 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2089 * src/widgets/modest-folder-view.c: (filter_row):
2090 Explictly filter out the per-account outbox accounts. I don't know why
2091 these only sometimes show up, but now they should never show up in the UI.
2092 This should fix projects.maemo.org bug NB#60160.
2094 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
2097 when the toolbar does not exist yet.
2098 * src/modest-widget-memory.c: (save_settings_header_view):
2099 Added g_warnings() to help us to discover when we are trying to set
2100 an empty columns list in gconf.
2102 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2104 * src/modest-init.h:
2105 * src/modest-init.c:
2106 Added modest_init_get_default_header_view_column_ids().
2108 * src/modest-widget-memory.c: (restore_settings_header_view):
2109 Use the new function to get defaults, if the gconf key is empty,
2110 instead of not creating any columns. This seems to fix the
2111 empty right-hand pane problems.
2113 * src/widgets/modest-header-view.h: Improved documentation.
2115 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2117 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2118 Revert the use of the display name as the account name, because this
2119 is generally wrong and would break the code that follows.
2121 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2123 * src/maemo/easysetup/modest-easysetup-wizard.c:
2124 (check_for_supported_auth_methods), (on_before_next),
2127 More correct fix for projects.maemo.org bug NB# 58991
2128 Do not longer accept AUTH_PASSWORD as secure method and choose
2129 correct method when creating the account.
2131 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2133 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2134 Fixed projects.maemo.org bug NB# 58991
2136 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2138 * src/modest-init.c: (modest_init_init_core),
2139 (modest_init_local_folders): Fixed compilation errors.
2141 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2143 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2144 Remove unnecessary lib/include, though it is good in principle when needed.
2146 * src/modest-init.c: (modest_init_one_local_folder),
2147 (modest_init_local_folders):
2148 * src/modest-init.h: Initialize the .modest library for memory cards,
2149 instead of just doing nothing for them. This should allow us to create
2150 folders there, fixing projects.maemo.org bug NB#59297.
2152 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2154 * libmodest-dbus-client/libmodest-dbus-client.c:
2155 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2156 (libmodest_dbus_client_compose_mail),
2157 (libmodest_dbus_client_open_message),
2158 (libmodest_dbus_client_send_and_receive),
2159 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2161 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2162 (on_idle_open_message), (modest_dbus_req_handler),
2163 (search_result_to_message), (modest_dbus_req_filter):
2164 * src/modest-search.c: (add_hit), (modest_search_folder),
2165 (modest_search_all_accounts): Improved debug messages.
2167 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2169 * src/modest-tny-account-store.c:
2170 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2173 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2176 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2178 * src/modest-tny-account-store.c: (get_server_accounts):
2179 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2180 even when there are no accounts, so that the Outbox folder is always
2181 visible. This fixes projects.maemo.org bug NB#60158.
2183 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2185 * src/maemo/modest-main-window.c: (create_details_widget):
2186 Use the mcen_va_never logical ID.
2188 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2190 * src/dbus_api/modest-dbus-api.h:
2191 * src/dbus_api/modest-dbus-callbacks.c:
2192 (on_idle_open_default_inbox), (on_open_default_inbox),
2193 (modest_dbus_req_handler):
2194 Added a new OpenDefaultInbox method.
2196 * libmodest-dbus-client/libmodest-dbus-client.h:
2197 * libmodest-dbus-client/libmodest-dbus-client.c:
2198 Added libmodest_dbus_client_open_default_inbox() to call the new
2199 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2200 though it should maybe be used by a new osso-email-interface function.
2202 * tests/dbus_api/Makefile.am:
2203 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2206 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2208 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2209 NULL, so that the signals get all the keys. This should not actually
2210 change any behaviour because we currently update everything when anything
2213 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2215 * src/widgets/modest-folder-view.c: (text_cell_data),
2216 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2217 (find_inbox_iter): If tinymail tells us that the folder is
2218 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2219 This causes the inbox to be selected at startup, fixing part of
2220 projects.maemo.org bug NB#56305.
2222 * src/modest-ui-dimming-rules.c:
2223 (modest_ui_dimming_rules_on_tools_smtp_servers):
2224 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2225 the SMTP servers menu item.
2226 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2227 that the SMTP Servers menu item is dimmed when there are no accounts,
2228 as a future version of the UI spec will require. This fixes
2229 projects.maemo.org bug NB#56305.
2231 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2233 * src/maemo/modest-maemo-utils.c:
2234 (modest_maemo_utils_get_supported_secure_authentication_methods):
2235 Added label to dialog instead of unreadable title
2237 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2238 (modest_main_window_new):
2239 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2242 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2243 * src/modest-account-mgr.h:
2244 Added method to avoid code duplication
2246 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2247 (modest_ui_actions_on_send_receive):
2248 Use modest_account_mgr_has_accounts
2250 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2252 * src/maemo/easysetup/modest-presets.c:
2253 (modest_presets_get_info_server_security): Do not report secure auth
2255 * src/modest-protocol-info.c: Use the defines for the gconf key names
2256 for secure authentication. This was not working because we were writing
2257 Password and reading password, and the check was case sensitive.
2258 With this, gmail now works for receiving and sending when created via
2261 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2263 * src/maemo/easysetup/modest-presets.c:
2264 (modest_presets_get_info_server_security): Correct the key name for
2265 SecureSmtp, because it seems to be case-sensitive.
2266 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2267 Do not try to get the 0th notebook page if there are 0 pages, to
2268 avoid a g_warning().
2270 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2272 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2273 Prevent use of the new notification feature for now, because it currently
2274 shows one dialog for each new email, which is annoying.
2276 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2278 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2279 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2280 when no country was selected, so that we show the global ones.
2281 * src/maemo/easysetup/modest-presets.c:
2282 (modest_presets_get_providers): Return only the global providers, not
2283 all providers when mmc=0 was requested.
2285 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2287 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2288 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2289 provider ID in the combo.
2291 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2292 Do not show the page numbers, because it would be confusing when we add
2293 the 2 extra pages for the custom setup, when the user chooses the "Other"
2294 provider. This fixes projects.maemo.org bug NB#59028
2296 * src/modest-init.c: (modest_init_init_core),
2297 (modest_init_local_folders):
2298 * src/modest-init.h:
2299 * src/modest-tny-account.c:
2300 (modest_tny_account_new_for_local_folders): Do not create default folders
2301 for the memory card. This should fix projects.maemo.org bug NB#59328.
2303 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2305 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2306 Free the changed_conf_keys string items. They are already freed in the
2307 idle handler if that runs first.
2309 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2311 * src/modest-ui-actions.c:
2312 (modest_ui_actions_on_password_requested): Check that the server name
2313 is not NULL, because I just saw a password dialog with (null) as the
2316 * src/modest-tny-folder.[h|c]: Added
2317 modest_tny_folder_is_memory_card_folder().
2318 * src/modest-ui-dimming-rules.c:
2319 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2320 menu item for memory cards, as per the UI spec (section 7.4). This should
2321 fix projects.maemo.org bug NB#59297.
2323 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2325 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2326 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2327 is another problem with the code, see Murray's comment at line 772)
2329 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2331 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2332 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2333 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2334 (load_from_file), (easysetup_country_combo_box_init),
2335 (easysetup_country_combo_box_get_active_country_ids),
2336 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2337 instead of just one ID, to avoid duplicate country names in the UI.
2339 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2340 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2341 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2342 a single ID, avoiding duplicate providers.
2343 * src/maemo/easysetup/modest-easysetup-wizard.c:
2344 (on_combo_account_country): Adapt to use a list.
2346 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2348 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2349 keys changed in the last X seconds.
2351 * src/modest-account-mgr.h:
2352 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2353 (on_key_change), (modest_account_mgr_class_init),
2354 (modest_account_mgr_init), (modest_account_mgr_finalize):
2355 As the keys are changed, save them in a GSList* and signal that GSList*
2356 further every X seconds, to batch changes, to allow us to do just one
2357 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2358 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2360 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2361 changed signal signature.
2363 * src/modest-conf.c: (modest_conf_set_list),
2364 (modest_conf_on_change): Reenable notification.
2366 (modest_conf_maemo_fake_on_change): Comment out the hack that
2367 notified immediately instead of asynchronously.
2369 * src/widgets/modest-account-view.h:
2370 * src/widgets/modest-account-view.c:
2371 (update_account_view): Select the previously-selected account ID,
2372 if possible. This fixes projects.maemo.org bug NB#56933.
2374 (on_account_changed), (on_account_removed),
2375 (modest_account_view_select_account):
2377 Remove the block/unblock functions
2378 because they were not useful.
2380 * src/maemo/modest-account-view-window.c:
2381 (on_delete_button_clicked), (on_edit_button_clicked),
2382 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2384 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2386 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2387 Improve the error dialog to show Incorrect Account Settings, which seems
2388 clearer, and say that the internal error message (to be removed from the
2389 dialog later) is often misleading.
2390 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2392 * src/modest-tny-account.c:
2393 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2394 URL because this is so useful for debugging on the device.
2396 * src/widgets/modest-serversecurity-combo-box.c:
2397 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2399 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2401 * src/modest-mail-operation.c:
2402 (modest_mail_operation_send_new_mail):
2403 Added a comment about a nasty but apparently harmless message. Details
2404 added to the wiki g_warnings() page.
2406 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2408 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2409 (modest_tny_send_queue_class_init):
2410 Do not use the priv struct because it is empty, to avoid g_warnings
2411 about a non-existant priv struct.
2413 * src/modest-tny-account-store.c:
2414 (modest_tny_account_store_get_server_account),
2415 (modest_tny_account_store_get_transport_account_for_open_connection
2416 ): Do not try to get transport server accounts for local folders,
2417 because they don't have any. This avoids a g_warning().
2419 * src/maemo/modest-main-window.c:
2420 (modest_main_window_notify_send_receive_initied),
2421 (on_configuration_key_changed):
2422 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2423 * src/modest-defs.h:
2424 * src/modest-mail-operation.c:
2425 (modest_mail_operation_update_account):
2426 * src/modest-tny-account-store.h:
2427 * src/modest-tny-account.c:
2428 (modest_tny_account_get_special_folder),
2429 (modest_tny_account_new_for_local_folders),
2430 (modest_tny_account_new_for_per_account_local_outbox_folder):
2431 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2432 * src/modest-tny-local-folders-account.c:
2433 (add_account_folders_to_merged_folder):
2434 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2435 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2436 (modest_ui_actions_on_send):
2437 * src/widgets/modest-folder-view.c: (update_model):
2438 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2439 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2440 modest_tny_account_store_get_tny_account_by_account() to
2441 modest_tny_account_store_get_server_account() to make the code clearer.
2443 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2445 * src/dbus_api/modest-dbus-api.h:
2446 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2447 * src/maemo/modest-msg-edit-window.c:
2448 (modest_msg_edit_window_attach_file_noninteractive):
2449 added g_warning in case the file to be attached does not exist
2450 * tests/dbus_api/test_compose_mail.c: (main):
2451 removed obsolete comment, added generic files as test case
2453 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2455 * src/modest-tny-account-store.c: (get_server_accounts):
2456 Create the local folders account only once, not once for each outbox, and
2457 not only when there are some outboxes.
2459 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2461 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2462 code that is causing a crash at startup. Sergio says that he is fixing this.
2464 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2466 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2467 * src/maemo/modest-account-settings-dialog.c:
2468 (create_page_outgoing),
2469 (modest_account_settings_dialog_set_account_name),
2470 (save_configuration):
2471 - Fixed handling of the "Use secure authentication" toggle to comply with
2472 the ui specification. See also projects.maemo.org bug NB#58400
2474 - Restore the Secure connection setting combo correctly when loading
2477 * src/maemo/modest-maemo-utils.c:
2478 (on_camel_account_get_supported_secure_authentication),
2479 (modest_maemo_utils_get_supported_secure_authentication_methods):
2480 Fixed a crasher if operation is canceled
2482 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2483 (modest_protocol_info_auth_is_secure):
2484 * src/modest-protocol-info.h:
2486 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2487 the sense of the "Use secure authentication" toggle.
2489 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2491 * src/modest-tny-account-store.h:
2492 * src/modest-tny-account-store.c:
2493 Added modest_tny_account_store_get_local_folders_account().
2495 * src/modest-tny-folder.h:
2496 * src/modest-tny-folder.c:
2497 (modest_tny_folder_get_account):
2498 Added this replacement for tny_folder_get_account() which returns
2499 the local-folders account for TnyMergeFolders, to avoid the
2500 warning about the unimplemented get_account_func() vfunc().
2502 (modest_tny_folder_get_rules),
2503 * src/modest-ui-actions.c:
2504 (modest_ui_actions_on_folder_selection_changed):
2505 * src/modest-mail-operation.c:
2506 (modest_mail_operation_remove_folder),
2507 (modest_mail_operation_xfer_folder),
2508 (modest_mail_operation_rename_folder),
2509 (modest_mail_operation_get_msg),
2510 (modest_mail_operation_get_msgs_full),
2511 (modest_mail_operation_remove_msg),
2512 (modest_mail_operation_xfer_msgs),
2513 (modest_mail_operation_refresh_folder):
2514 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2516 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2518 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2519 (modest_server_account_set_security):
2520 * src/modest-defs.h: Add comments explaining that our
2521 UI spec means TLS when it says Normal, so these do not look like errors.
2523 * src/modest-tny-account.c:
2524 (modest_tny_account_new_from_server_account): Use the new tinymail
2525 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2526 for TLS. This should fix projects.maemo.org bug NB#58460.
2528 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2530 * src/maemo/easysetup/modest-easysetup-wizard.c:
2531 (create_account): Correct the position of the gconf sanity check warning.
2532 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2533 of using the g_idle_add() hack, because this does not seem to be necessary
2534 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2535 caused by something other than maemo's gconf.
2536 This fixes projects.maemo.org bug #59022.
2538 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2540 * src/modest-account-mgr-helpers.c:
2541 (modest_account_mgr_get_default_account): Do not check that the account
2542 exists if there is no default account (NULL), to fix a runtime warning.
2544 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2546 * src/widgets/modest-folder-view.c: (update_model):
2547 Do not unref the treemodel before we have finished with it.
2548 This prevents a valgrind warning and an occasional crash at startup.
2550 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2552 * libmodest-dbus-client/libmodest-dbus-client.h:
2553 added libmodest_dbus_client_compose_mail()
2554 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2556 added functions needed for SendAsMail() functionality
2557 * src/maemo/modest-msg-edit-window.c:
2558 (modest_msg_edit_window_attach_file_noninteractive):
2559 non interactively attaching files to message edit window
2560 * src/widgets/modest-msg-edit-window.h:
2561 * tests/dbus_api/Makefile.am:
2562 added test_compose_mail.c
2563 * tests/dbus_api/test_compose_mail.c: (main):
2565 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2567 * src/modest-account-view.c:
2568 Fixed bug projects.maemo.org bug NB#59307
2570 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2572 * src/maemo/easysetup/modest-easysetup-wizard.c:
2573 (get_serverport_incoming), (on_before_next), (create_account):
2574 * src/maemo/modest-account-settings-dialog.c:
2575 (modest_account_settings_dialog_set_account_name):
2576 * src/maemo/modest-maemo-utils.c:
2577 (on_camel_account_get_supported_secure_authentication_status),
2578 (on_camel_account_get_supported_secure_authentication),
2579 (on_secure_auth_cancel),
2580 (modest_maemo_utils_get_supported_secure_authentication_methods):
2582 Implemented security authentication for settings and easysetup.
2584 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/modest-main-window.c: (create_details_widget):
2587 Show the total size for memory card accounts too, instead of showing
2588 the name again. Fixes bug projects.maemo.org bug NB#59307.
2590 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2593 * src/modest-tny-simple-folder-store.c:
2594 * src/modest-tny-simple-folder-store.h: Removed.
2596 * src/modest-tny-local-folders-account.h
2597 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2598 for the local-folders maildir, with an extra TnyMergedFolder containing
2599 the folders of the per-account outbox store accounts.
2600 * src/modest-tny-account-store.c: (get_server_accounts):
2601 Add the outboxes to the special local folders account after creating it.
2603 * src/modest-tny-account.c:
2604 (modest_tny_account_new_for_local_folders): Create the derived
2605 account when creating the main local-folders account.
2607 * src/maemo/modest-main-window.c: (create_details_widget),
2608 (modest_main_window_set_contents_style):
2609 Adapted to the use of the derived account instead of the folder store.
2611 * src/modest-ui-actions.c:
2612 (modest_ui_actions_on_folder_selection_changed):
2613 * src/modest-ui-dimming-rules.c:
2614 (modest_ui_dimming_rules_on_new_folder):
2615 * src/widgets/modest-folder-view.c: (text_cell_data),
2616 (icon_cell_data), (filter_row), (update_model),
2617 (get_cmp_rows_type_pos):
2620 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2621 Do not get the priv struct, because no priv struct has been set,
2622 to avoid a runtime warning.
2624 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2625 #ifelse with #else, to fix a warning, to fix the build.
2628 2007-06-05 Christian Kellner <ckellner@openismus.com>
2630 * libmodest-dbus-client/libmodest-dbus-client.c:
2631 Fix small typo in doc (why do you always see them
2632 AFTER committing stuff?)
2635 2007-06-05 Christian Kellner <ckellner@openismus.com>
2637 * libmodest-dbus-client/libmodest-dbus-client.c:
2638 (libmodest_dbus_client_search):
2639 Initialize hit list with NULL. Also set folder list
2640 to "" if NULL was supplied.
2643 2007-06-03 Christian Kellner <ckellner@openismus.com>
2645 * libmodest-dbus-client/libmodest-dbus-client.c:
2646 (modest_search_hit_list_free):
2647 Make it save to call it with NULL.
2649 * src/dbus_api/modest-dbus-callbacks.c:
2650 * src/modest-search.c:
2651 Return full ModestSearchHits as the search result list not TnyHeader
2652 since can't be around withouth the correspoding TnyFolder.
2654 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2656 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2657 Added currently commented code to check for secure auth
2659 * src/maemo/modest-account-settings-dialog.c: (on_response),
2660 (save_configuration), (show_ok):
2661 Fixed projects.maemo.org bugs NB #59248 and #59251
2663 * src/maemo/modest-maemo-utils.c:
2664 (on_camel_account_get_supported_secure_authentication_status),
2665 (on_camel_account_get_supported_secure_authentication),
2666 (modest_maemo_utils_get_supported_secure_authentication_methods):
2667 * src/maemo/modest-maemo-utils.h:
2668 Moved get_supported_secure_authentication() method here to be able
2669 to use it from easysetup wizard.
2671 * src/modest-pair.c: (on_pair_compare_as_string):
2672 Should compare string with first part of pair and not
2673 strcmp pairs which will crash.
2675 * src/modest-protocol-info.c:
2676 (modest_protocol_info_protocol_is_store):
2677 * src/modest-protocol-info.h:
2678 Added modest_protocol_info_get_auth_protocol_name()
2680 2007-06-03 Armin Burgmeier <armin@openismus.com>
2682 * src/modest-mail-operation.c:
2683 (modest_mail_operation_get_msgs_full): Set priv->account also when
2684 only retrieving a single message. This avoids a crash when canceling
2687 (modest_mail_operation_notify_end): Do not explicitely remove the
2688 operation from the queue but only emit the progress_changed signal.
2689 The queue itself listens to that signal to remove the operation when
2690 it is finished. This reduces coupling and removes a potential deadlock
2691 when modest_mail_operation_notify_end() is called from the queue
2692 itself. If that is a problem performance-wise, I would suggest to
2693 implement a status-changed signal or something.
2695 * src/modest-mail-operation-queue.c: Make sure to never call a
2696 function from another file while the queue is locked. This (hopefully)
2697 fixes another deadlock when exiting the application while retrieving
2700 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2702 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2703 Fixed build if libogs is not available
2705 2007-06-03 Christian Kellner <ckellner@openismus.com>
2707 * libmodest-dbus-client/libmodest-dbus-client.h:
2708 * libmodest-dbus-client/libmodest-dbus-client.c:
2709 (libmodest_dbus_client_delete_message):
2710 Implement deletion of messages (Client side).
2712 (modest_search_hit_free),
2713 (modest_search_hit_list_free):
2714 Utility functions to free the result hits.
2716 * src/dbus_api/modest-dbus-api.h:
2717 * src/dbus_api/modest-dbus-callbacks.c:
2718 (on_delete_message),
2719 (modest_dbus_req_handler):
2720 Implement deletion of messages (Server side).
2722 * tests/dbus_api/test_search.c: (main):
2725 * tests/dbus_api/Makefile.am:
2726 * tests/dbus_api/test_delete_message:
2727 Add little test for the message deletion logic
2729 2007-06-03 Armin Burgmeier <armin@openismus.com>
2731 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2732 when the operation queue was not empty. projects.maemo.org bug
2735 2007-06-03 Armin Burgmeier <armin@openismus.com>
2737 * src/widgets/modest-account-view.c
2738 (on_account_default_toggled): Toggle default account column
2739 explicitely instead of waiting for gconf notification (which is
2740 currently ignored). This should fix projects.maemo.org bug NB#56910
2741 for now. It should probably be removed when gconf notifications are
2744 2007-06-03 Christian Kellner <ckellner@openismus.com>
2746 * libmodest-dbus-client/libmodest-dbus-client.c:
2747 Removed debugging spew.
2749 * src/dbus_api/modest-dbus-callbacks.c:
2750 Added debugging info.
2752 * src/modest-search.c:
2753 (modest_search_all_accounts):
2754 Use tny_account_store_get_accounts () on the account store
2755 to get all accounts which is the way to get all accounts.
2757 * tests/dbus_api/test_search.c: (main):
2758 Make it possible to supply the search term on the command line.
2760 2007-06-03 Christian Kellner <ckellner@openismus.com>
2762 * libmodest-dbus-client/libmodest-dbus-client.c:
2763 * libmodest-dbus-client/libmodest-dbus-client.h:
2764 Implement searching for mesages over raw dbus. (Client side)
2766 * src/dbus_api/Makefile.am:
2767 * src/dbus_api/modest-dbus-api.h:
2768 * src/dbus_api/modest-dbus-callbacks.c:
2769 * src/dbus_api/modest-dbus-callbacks.h:
2770 Search framework (Server side). Also implement on_idle_open_message().
2772 * src/maemo/modest-platform.c: (modest_platform_init):
2773 Prepare for raw dbus/osso rpc interaction.
2775 * src/modest-search.h:
2776 Changed minsize from unspecific guint to guint32.
2778 * src/modest-search.c:
2780 Added strange hack which magically made tnymail work.
2782 (modest_search_folder),
2783 (modest_search_account),
2784 (modest_search_all_accounts):
2785 Implement helper functions to search all accounts, specific account
2788 * tests/dbus_api/Makefile.am:
2789 * tests/dbus_api/test_open_message.c:
2790 Read url to open from commandline.
2792 * tests/dbus_api/test_search.c:
2793 Implement small test for dbus search stuff
2795 2007-06-02 Armin Burgmeier <armin@openismus.com>
2797 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2798 include account type and account title. This fixes projects.maemo.org
2801 * src/maemo/modest-account-view-window.c: Set a title for the window.
2803 2007-06-02 Armin Burgmeier <armin@openismus.com>
2805 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2806 incoming and outgoing server name based on email address and server
2807 types as long as the names have not been edited manually. This fixes
2808 projects.maemo.org bug NB#58671.
2810 2007-06-02 Armin Burgmeier <armin@openismus.com>
2812 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2813 server type cannot be changed in future to the incoming details page
2814 when creating an account. This fixes projects.maemo.org bug NB#59029.
2816 2007-06-02 Armin Burgmeier <armin@openismus.com>
2818 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2819 and assigned max width chars so that they wrap instead of being
2820 truncated. Fixes projects.maemo.org bug NB#56126.
2822 2007-06-02 Armin Burgmeier <armin@openismus.com>
2824 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2825 introductory note to the connection specific smtp servers dialog, as
2826 section 8.12 of the email UI specification requires. This fixes
2827 projects.maemo.org bug NB#59212.
2829 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2831 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2832 Check for running mail operations, and offer to cancel them, as per the UI
2833 spec. This fixes projects.maemo.org bug NB#59041 .
2834 However, I suspect that tinymail may still use the network connection
2835 in ways that we cannot detect or cancel. But it should at least adapt to
2836 changes fairly well.
2838 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2840 * src/modest-tny-account-store.c: (recreate_all_accounts),
2841 (get_cached_accounts), (get_server_accounts): Do more sensible
2842 ref-counting of the temporarily-cached outbox accounts list. This seems
2843 to fix a crash when entering the password when the password was wrong.
2845 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2847 * src/gnome/modest-main-window.c: (connect_signals):
2848 * src/modest-tny-account-store.c: (get_password),
2849 (modest_tny_account_store_alert): Added comments and clues and
2850 commented-out code about how we currently fail to deal with connection
2851 errors and wrong passwords, and how we should.
2853 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2855 * src/widgets/modest-retrieve-combo-box.c:
2856 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2857 This fixes projects.maemo.org bug NB#58472 .
2859 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2861 * src/maemo/easysetup/modest-easysetup-wizard.c:
2862 (create_page_complete_easysetup):
2863 (create_page_complete_custom): Correct the last commit,
2864 putting the correct sentences in the correct pages.
2866 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2868 * src/maemo/easysetup/modest-easysetup-wizard.c:
2869 (create_page_complete_custom): Show the second sentence of text
2870 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2873 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2875 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2876 Set the leave-on-server conf key by default. This fixes
2877 projects.maemo.org bug NB#59258 .
2879 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2881 * src/maemo/modest-account-view-window.c:
2882 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2883 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2886 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2888 * src/maemo/easysetup/modest-easysetup-wizard.c:
2889 (create_caption_new_with_asterisk):
2890 * src/maemo/modest-account-settings-dialog.c:
2891 (create_caption_new_with_asterisk):
2892 Uncomment the code to add the asterisk, because they are no longer in the
2893 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2894 (update_incoming_server_title): Add an asterisk here too.
2896 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2898 * src/maemo/modest-maemo-global-settings-dialog.c:
2899 (current_connection): Check that we are even connected before trying to
2900 get the current connection name, to prevent a warning.
2902 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2903 Change the comments because tny_maemo_conic_device_connect() is now meant to
2905 * src/modest-mail-operation.c:
2906 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2907 make sure we have a connection and fail if we can't connect.
2909 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2911 * src/maemo/modest-main-window.c:
2912 (on_account_store_connecting_finished): Do not try to get the
2913 connection ID if we are not really connected. I am surprised that
2914 this signal handler is called when we are not connected.
2916 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2918 * src/modest-error.h:
2919 * src/modest-ui-actions.c:
2920 (modest_ui_actions_get_msgs_full_error_handler):
2921 Renamed an enum, added comments, added an enum
2922 for retrieve-limit errors.
2924 * src/modest-mail-operation.c: (foreach_add_item),
2925 (internal_folder_observer_update), (update_account_thread),
2926 (modest_mail_operation_get_msgs_full):
2927 (modest_mail_operation_update_account),
2928 Added comments about how this works, and some code that should
2929 (but does not) check the retrieve-limit. See the TODO comment.
2931 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2933 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2934 Initialize help_id to fix the build. Warnings are good.
2936 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2938 * src/widgets/modest-hbox-cell-renderer.c:
2939 (modest_hbox_cell_renderer_append):
2940 * src/widgets/modest-vbox-cell-renderer.c:
2941 (modest_vbox_cell_renderer_append):
2942 Fix the last commit by doing an extra ref.
2944 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2946 * src/widgets/modest-hbox-cell-renderer.c:
2947 (modest_hbox_cell_renderer_append):
2948 * src/widgets/modest-vbox-cell-renderer.c:
2949 (modest_vbox_cell_renderer_append):
2950 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2951 to fix the build with Maemo Bora.
2952 However, there seems to be a remaining crash, probably due to reference
2955 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2957 * src/modest-tny-account.c:
2958 (modest_tny_account_new_for_local_folders):
2959 Use hildon_file_system_info_async_new() to get a better name for
2960 the memory card account, setting it as the account name.
2961 The timing seems to work, but this is probably
2962 not the best place to do this. See the TODO comment.
2963 * src/maemo/modest-main-window.c: (create_details_widget):
2964 * src/widgets/modest-folder-view.c: (text_cell_data):
2965 Use the tny account name instead of hardcoding a name.
2967 2007-05-30 Christian Kellner <ckellner@openismus.com>
2969 * src/modest-search.c: (modest_search):
2970 Correctly set part_search_func even if we have already parsed
2971 the query and thus a valid OgsTextSearcher object.
2973 2007-05-30 Christian Kellner <ckellner@openismus.com>
2976 Search and check for libogs.
2979 Incooparte the ogs build env.
2981 * src/modest-mime-part-search-stream.c:
2982 * src/modest-mime-part-search-stream.h:
2983 Removed since we do the real searching now in modest-search.c.
2985 * src/modest-search.c:
2986 * src/modest-search.h:
2987 Implement support for ogs. We use that if available and requested
2988 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2989 should now handle the corner case when the search term is spread
2990 across multiple reads.
2991 Also the logic in modest_search () was corrected to search all
2992 requested fields until one is found.
2994 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2996 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2998 * src/modest-init.h:
2999 * src/modest-init.c: Made modest_init_local_folders() take a
3000 path and be public so we can iniitialize maildir folders on
3003 * src/modest-local-folder-info.h:
3004 * src/modest-local-folder-info.c:
3005 (modest_local_folder_info_get_maildir_path): Add a path parameter.
3007 * src/modest-tny-account.c:
3008 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
3009 still means the standard local-folders path on the local volume.
3011 * src/modest-tny-account-store.c:
3012 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
3013 signal so we can detect mount/unmount of the MMC1 card, and do an update of
3014 all accounts when that happens.
3015 (get_server_accounts): If the MMC1 card is mounted, create a store account for
3016 this too, so it shows up in the treeview.
3018 2007-05-28 Murray Cumming <murrayc@murrayc.com>
3020 * src/maemo/modest-maemo-global-settings-dialog.c:
3021 (current_connection):
3022 * src/widgets/modest-global-settings-dialog.c:
3023 (current_connection_default):
3024 Use the enum values instead of 0, 1 and -1,
3025 to make the code clearer.
3027 * src/modest-account-mgr-helpers.c:
3028 (modest_account_mgr_get_connection_specific_smtp): Make this code
3031 * src/modest-runtime.h:
3032 * src/modest-runtime.c:
3033 Added modest_runtime_remove_all_send_queues().
3034 * src/maemo/modest-main-window.c:
3035 (on_account_store_connecting_finished): Recreate the send queues,
3036 using the appropriate transport accounts for this new connection.
3037 Some futher adapting might be needed if the old send queues are not
3038 automatically stopped at this point.
3040 * src/modest-tny-account-store.c: (get_server_accounts):
3041 Create the connection-specific transport accounts, so that they can
3042 be found later by their ID.
3044 * src/modest-tny-account.h:
3045 * src/modest-tny-account.c:
3046 Added modest_tny_account_new_from_server_account_name().
3047 modest_tny_account_new_from_server_account(): Do not create the
3048 send queues here, because they will be
3049 recreated anyway when the connection changes for the first time.
3051 2007-05-28 Murray Cumming <murrayc@murrayc.com>
3053 * src/modest-local-folder-info.h:
3054 * src/modest-local-folder-info.c:
3055 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3056 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3057 tbox_folder): Take a modest account name instead of a server TnyAccount,
3058 so we can have per-modest-account rather than per-transport-account
3060 We must make sure that we change or recreate the exisitng send queues
3061 when the connection changes for connection-specific transport accounts.
3063 * src/modest-tny-account-store.c:
3064 (create_per_account_local_outbox_folders): Create outboxed per modest
3065 account, not per transport account.
3067 * src/modest-tny-account.h:
3068 * src/modest-tny-account.c:
3069 (modest_tny_account_get_special_folder): For outboxes, get the
3070 parent modest account name. The account is ignored for other folders.
3071 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
3072 modest account name rather than a server TnyAccount.
3074 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3076 * src/modest-tny-account.c:
3077 (modest_tny_account_new_from_server_account):
3078 Call modest_runtime_get_send_queue() immediately after creating transport
3079 accounts, so that they start trying to send email from the outbox as soon
3080 as possible at startup. This is probably what we want.
3082 * src/modest-mail-operation.c: (update_account_thread):
3083 * src/modest-runtime.c: (modest_runtime_get_send_queue):
3084 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
3085 * src/modest-tny-send-queue.h:
3086 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
3087 (modest_ui_actions_on_send):
3088 Added comments about how sending works, though it needs some more work.
3090 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3092 * src/modest-tny-account.c:
3093 (modest_tny_account_get_special_folder): Add TODO because this fails when
3094 the network is busy.
3095 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
3096 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
3097 Do not try to show this window when there is no active account. The UI
3098 specs does not tell us what to do in this case.
3100 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3104 * src/maemo/Makefile.am:
3105 * src/widgets/Makefile.am: Some dist fixes.
3107 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3109 * src/maemo/modest-connection-specific-smtp-window.c:
3110 (on_button_edit): Make the code clearer, to prevent a double free.
3112 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3114 * src/maemo/modest-account-settings-dialog.c:
3115 (modest_account_settings_dialog_set_account_name),
3116 Check the connection-specific smtp servers checkbox if there are any.
3118 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3119 (modest_connection_specific_smtp_edit_window_init):
3120 Start with a suitable port number.
3122 * src/modest-account-mgr-helpers.h:
3123 * src/modest-account-mgr-helpers.c: Added
3124 modest_account_mgr_get_has_connection_specific_smtp().
3126 (modest_account_mgr_set_connection_specific_smtp),
3127 (modest_account_mgr_remove_connection_specific_smtp),
3128 (modest_account_mgr_get_has_connection_specific_smtp),
3129 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3130 connection-specific smtp server accounts in the account, rather than
3131 the server account conf dir.
3133 This fixes bug projects.maemo.org bug NB#58263 .
3135 * src/modest-tny-account-store.c:
3136 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3137 if there are no server accounts yet, to prevent an infinite loop when there
3138 are no accounts. Document that one must be called before the other.
3140 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3142 * src/modest-account-mgr-helpers.c:
3143 (modest_account_mgr_get_default_account): Make sure that at least
3144 one account is always the default, if there are any enabled accounts.
3145 This is just a sanity check that shouldn't be necessary.
3147 * src/modest-account-mgr-priv.c:
3148 (_modest_account_mgr_account_from_key): Unescape the conf key to
3149 get the real account name. For instance, this is an issue if a space
3150 was in the account name, which can happen because the account name
3151 is generated from the display name.
3152 (_modest_account_mgr_get_account_keyname): Always escape the
3154 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3155 Unescape the conf keys to get the real account names.
3157 For instance, previously the is-default radio button in the accounts
3158 list was not checked for any accounts at first. This fixes that,
3159 and might fix several similar bugs.
3161 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3163 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3164 Removed some debug printfs.
3166 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3168 Modest on-disk outbox directories are now here, for instance:
3169 $HOME/.modest/outboxes/<account-id-1>/outbox
3170 $HOME/.modest/outboxes/<account-id-2>/outbox
3172 $HOME/.modest/local-folders/outbox
3173 so we can have a separate outbox for each account.
3174 But they are shown as one outbox in the GtkTreeView, by using a
3175 TnyMergeFolder in a ModestTnySimpleFolderStore.
3178 * src/modest-tny-simple-folder-store.c:
3179 * src/modest-tny-simple-folder-store.h:
3180 Added ModestTnySimpleFolderStore, used to contain folders from
3181 other folder stores, such as other accounts.
3183 * src/modest-tny-outbox-account.h:
3184 * src/modest-tny-outbox-account.c:
3185 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3186 used for the per-account local outbox folders.
3188 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3189 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3190 only use this (internally) now for the non-outbox local folders.
3192 * src/modest-init.h:
3193 * src/modest-init.c: Added modest_init_one_local_folder(), for
3194 setting up the directory structure for each local folder.
3196 * src/modest-local-folder-info.c:
3197 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3198 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3200 * src/modest-local-folder-info.h:
3201 * src/modest-tny-account-store.c: (on_account_removed),
3202 (on_account_changed), (create_per_account_local_outbox_folders),
3203 (get_server_accounts), (modest_tny_account_store_get_accounts),
3204 (modest_tny_account_store_get_tny_account_by_account),
3205 (modest_tny_folder_store_is_virtual_local_folders):
3207 * src/modest-tny-account.h:
3208 * src/modest-tny-account.c:
3209 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3210 to create an on-disk per-account local outbox folder for each
3212 (create_per_account_local_outbox_folders): Create a local outbox folder
3213 for each transport account.
3214 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3215 for all local folders.
3217 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3218 instead of using g_object_get/set() directly. It is clearer.
3220 (modest_tny_folder_store_get_message_count),
3221 (modest_tny_folder_store_get_local_size
3222 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3223 because we now use these with non-acount folder stores.
3225 (modest_tny_account_get_special_folder),
3226 (modest_tny_account_new_from_server_account),
3227 (modest_tny_account_new_from_account):
3228 (recurse_folders): Adjust to the new outbox system.
3230 * src/modest-tny-folder.h:
3231 * src/modest-tny-folder.c:
3232 (modest_tny_folder_is_local_folder),
3233 (modest_tny_folder_get_local_folder_type),
3234 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3236 * src/widgets/modest-main-window.h:
3237 * src/maemo/modest-main-window.c: (create_details_widget),
3238 (modest_main_window_set_contents_style): Show details for any folder store,
3241 (modest_tny_folder_get_rules):
3242 Remove the const. C does not support constness enough for this.
3244 * src/modest-ui-actions.c:
3245 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3246 make all outboxes appear as one, in the usual local-folders tree node.
3248 (set_active_account_from_tny_account),
3249 (modest_ui_actions_on_folder_selection_changed):
3250 * src/widgets/modest-folder-view.c: (text_cell_data),
3251 (icon_cell_data), (filter_row),
3252 (add_account_folders_to_merged_folder),
3253 (add_account_folders_to_simple_folder_store), (),
3254 (get_cmp_rows_type_pos), (cmp_rows),
3255 (modest_folder_view_set_account_id_of_visible_server_account):
3256 Adjust to the new outbox system, using generic folder stores and folders
3257 in the GtkTreeModel.
3259 2007-05-23 Christian Kellner <ckellner@openismus.com>
3261 * src/modest-mail-operation.c:
3262 (modest_mail_operation_update_account):
3263 Use info->max_size instead of unintialized local var [small
3264 build fix]. (Added TODO to review that change since I don't
3267 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3269 * libmodest-dbus-client/libmodest-dbus-client.c:
3270 (libmodest_dbus_client_compose_mail): function added
3271 * src/dbus_api/modest-dbus-api.h:
3272 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3273 (on_compose_mail): Implementation of the SendAsMail functionality
3275 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3277 * src/modest-account-mgr.c:
3278 (modest_account_mgr_add_server_account): Set the secure-connection
3279 conf key for transport accounts as well as store accounts. I don't know
3280 why the if was there. For instance, this makes sure that we use SSL
3281 for the gmail preset from the easysetup wizard.
3283 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3285 * src/gnome/modest-main-window.c:
3286 (on_account_store_connecting_finished), (connect_signals):
3287 * src/maemo/modest-main-window.c:
3288 (on_account_store_connecting_finished), (connect_signals),
3289 (modest_main_window_new):
3290 Handle TnyAccountStore::connecting-finished instead of
3291 TnyDevice::connection-changed, because we cannot actually perform
3292 operations on accounts until TnyAccountStore has itself responded to
3293 the TnyDevice::connection-changed signal. This prevents a GError from
3295 Do not try to update at startup, because we (at least on scratchbox)
3296 already do an update at startup when the device goes online.
3297 This prevents a GError from tinymail.
3298 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3299 Added TODO about stopping simultaneous operations.
3301 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3303 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3304 * src/modest-mail-operation-queue.c:
3305 (modest_mail_operation_queue_remove):
3306 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3307 about where they happened.
3309 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3311 * src/modest-ui-actions.c:
3312 (modest_ui_actions_on_password_requested): Make sure that the remember
3313 output parameter is always TRUE.
3315 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3317 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3318 Show a OK/Cancel dialog if the error is a question, though we still do not
3319 know anything more about what we are asking the user.
3320 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3321 Fix an uninitialized variable (helper). This is a logic error, however.
3323 2007-05-21 Christian Kellner <ckellner@openismus.com>
3325 * src/modest-search.h:
3326 Correct bit shifting in the ModestSearchFlags enum.
3328 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3330 * src/modest-tny-account.c:
3331 (modest_tny_account_new_from_server_account): Do not use the lsub and
3332 check-all hard-coded IMAP options when using POP.
3334 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3336 * src/modest-tny-account.c:
3337 (modest_tny_account_new_from_server_account):
3338 Use NULL for the secure-auth method for POP when Password auth has been
3339 specified by the user, as we already do for IMAP. "auth=Login" causes
3340 an error from camel or the server.
3342 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3344 * src/maemo/modest-account-settings-dialog.c:
3345 (create_page_account_details),
3346 (modest_account_settings_dialog_set_account_name):
3347 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3348 for the leave-on-server checkbox, rathr than just the checkbox, when
3349 the protocol is not POP.
3351 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3353 * src/widgets/modest-account-view.c:
3354 * src/widgets/modest-account-view.h:
3355 Added modest_account_view_select_account() which will be useful later
3356 to asynchronously re-select the edited account.
3358 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3360 * src/maemo/modest-account-settings-dialog.c:
3361 (modest_account_settings_dialog_set_account_name):
3362 Automatically choose the port numbers based on the secure authentication
3363 methods, if they have not been chosen before.
3364 This fixes projects.maemo.org bug NB#56273 .
3366 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/modest-main-window-ui.h:
3369 * src/modest-ui-actions.c:
3370 * src/modest-ui-actions.h:
3371 Connect the Tools/SMTP Servers menu item to
3372 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3373 SMTP servers dialog, as in the UI specification and saves changes when it
3374 is closed. This fixed projects.maemo.org bug NB#56305 .
3376 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3378 * src/maemo/modest-connection-specific-smtp-window.c:
3379 (modest_connection_specific_smtp_window_init):
3380 Use gtk_window_set_default_size() to make this window big enough, so
3381 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3383 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3385 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3387 (modest_connection_specific_smtp_edit_window_init),
3388 Do not try to connect to a combobox signal before the combobox exists.
3389 This fixes the cras in projects.maemo.org bug NB#56288 .
3390 (modest_connection_specific_smtp_edit_window_get_settings):
3391 Remove the server_account_name parameter which was being checked for NULL
3392 though it was not used.
3394 * src/maemo/modest-connection-specific-smtp-window.c:
3395 (modest_connection_specific_smtp_window_fill_with_connections),
3396 (on_button_edit), (modest_connection_specific_smtp_window_init):
3397 Correct the number of treemodel columns to prevent a warning.
3398 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3399 libconic does not work.
3401 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3403 * src/modest-tny-account.c:
3404 (modest_tny_account_new_from_server_account):
3405 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3406 SMTP when "None" was chosen by the user. However, with my SMTP server that
3407 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3410 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3412 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3413 to explain the memory management issue with the ID in the ModestPair.
3415 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3416 (add_sending_page), (modest_account_assistant_finalize):
3417 * src/gnome/modest-gnome-global-settings-dialog.c:
3418 (create_updating_page), (create_composing_page):
3419 * src/gnome/modest-msg-edit-window.c: (get_transports),
3420 (init_window), (modest_msg_edit_window_finalize),
3421 (modest_msg_edit_window_get_msg_data):
3422 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3423 * src/gnome/modest-transport-widget.c:
3424 (modest_transport_widget_finalize), (smtp_configuration):
3425 * src/maemo/modest-maemo-global-settings-dialog.c:
3426 (create_updating_page), (create_composing_page):
3427 * src/maemo/modest-msg-edit-window.c: (get_transports),
3428 (init_window), (modest_msg_edit_window_finalize),
3429 (modest_msg_edit_window_get_msg_data),
3430 (modest_msg_edit_window_free_msg_data):
3431 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3432 (modest_store_widget_finalize):
3433 * src/maemo/modest-transport-widget.c:
3434 (modest_transport_widget_finalize), (smtp_configuration):
3435 * src/modest-main.c: (send_mail):
3436 * src/widgets/modest-combo-box.h:
3437 * src/widgets/modest-global-settings-dialog-priv.h:
3438 * src/widgets/modest-global-settings-dialog.c:
3439 (modest_global_settings_dialog_finalize):
3440 * src/widgets/modest-msg-edit-window.h:
3441 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3442 as long as the combo box, to prevent use of freed memory for the ID.
3444 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3446 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3447 get_accounts(), to make this clearer. Do not check for the enabled gconf
3448 key, because we do not use this for server accounts (at least, not yet).
3449 This allows us to send email again.
3451 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3453 * src/maemo/modest-platform.c:
3454 (on_modest_conf_update_interval_changed), (modest_platform_init):
3455 Only respond to this particular key change. All these strcmp()s cannot be
3458 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3460 * src/maemo/modest-maemo-global-settings-dialog.c:
3461 (current_connection): Prevent a crash in scratchbox when
3462 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3463 * src/maemo/modest-platform.c:
3464 (on_modest_conf_update_interval_changed), (modest_platform_init):
3465 Get the update interval from gconf and reset it when the gconf key changes.
3467 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3469 * src/modest-protocol-info.c:
3470 * src/modest-protocol-info.h: Adde enum-specific get functions,
3471 instead of using a ModestProtocolType enum parameter.
3473 * src/gnome/modest-account-assistant.c:
3474 * src/gnome/modest-store-widget.c:
3475 * src/gnome/modest-store-widget.h:
3476 * src/gnome/modest-transport-widget.c:
3477 * src/gnome/modest-transport-widget.h:
3478 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3479 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3480 * src/maemo/easysetup/modest-easysetup-wizard.c:
3481 * src/maemo/modest-account-settings-dialog.c:
3482 * src/maemo/modest-account-settings-dialog.h:
3483 * src/maemo/modest-store-widget.c:
3484 * src/maemo/modest-store-widget.h:
3485 * src/maemo/modest-transport-widget.c:
3486 * src/maemo/modest-transport-widget.h:
3487 * src/modest-account-mgr-helpers.c:
3488 * src/modest-account-mgr-helpers.h:
3489 * src/modest-account-mgr.c:
3490 * src/modest-account-mgr.h:
3491 * src/modest-tny-account.c:
3492 * src/modest-tny-folder.c:
3493 * src/widgets/modest-account-view.c:
3494 * src/widgets/modest-retrieve-combo-box.c:
3495 * src/widgets/modest-retrieve-combo-box.h:
3496 * src/widgets/modest-secureauth-combo-box.c:
3497 * src/widgets/modest-serversecurity-combo-box.c:
3498 * src/widgets/modest-serversecurity-combo-box.h:
3499 * tests/check_account-mgr.c:
3500 Use the specific functions, and use the re-renamed enum values for GNOME too.
3502 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3504 * src/modest-pair.h:
3505 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3506 so we can get the second based on the first.
3508 * src/maemo/modest-account-settings-dialog.h:
3509 * src/maemo/modest-account-settings-dialog.c:
3510 Added get_supported_secure_authentication_methods(), though it is mostly
3511 commented-out for now until the necessary API is committed to tinymail.
3512 (modest_account_settings_dialog_set_account_name),
3513 (save_configuration): Request the supported authentication methods from the
3514 server, so we can choose a working method.
3516 * src/modest-tny-account-store.h:
3517 * src/modest-tny-account-store.c:
3518 (modest_tny_account_store_get_session): Rename from
3519 tny_account_store_get_session().
3521 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3523 * src/modest-protocol-info.h: Split the ModestProtocol enum
3524 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3525 There was no need to have these unrelated values in one enum.
3527 * src/: many files: Adapted to changed enum. This makes the code a bit
3528 clearer, and the compiler could catch some errors.
3530 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3532 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3533 Show the detailed internal camel error message when an error happens
3534 during the configuration, so that our testers can give us more clues.
3535 For instance, in projects.maemo.org bug NB#56910 .
3537 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3539 * src/modest-tny-account.c:
3540 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3541 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3543 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3545 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3546 * src/maemo/modest-account-settings-dialog.c:
3547 (modest_account_settings_dialog_set_account_name),
3548 (save_configuration): For the incoming secure authentication checkbox,
3549 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3550 the UI specification. PLAIN does not seem to be supported for most IMAP
3551 servers anyway, and I am not sure what it would mean.
3552 However, we probably need to discover which of the secure-authentication
3553 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3554 * src/modest-account-mgr-helpers.c:
3555 (modest_account_mgr_get_server_account_data):
3557 * src/modest-tny-account.c:
3558 (modest_tny_account_new_from_server_account):
3559 Use tny_account_set_mech() to set secure-authentication methods,
3560 with some special-casing for IMAP, based on my observations of how
3563 * src/modest-account-mgr-helpers.h:
3564 * src/modest-account-mgr.c:
3565 * src/modest-defs.h: Comment that the URI is only used for local folders.
3567 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3569 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3570 parameter const, just to be neat.
3571 * src/modest-text-utils.c: (modest_text_utils_inline):
3572 End g_strconcat() with NULL, as its documentation says. This is almost
3573 certainly the cause of my crash at startup on the device. Interestingly,
3574 valgrind doesn't tell us about these errors.
3576 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3578 * scripts/build-packages: Added more precise comments about how to use
3579 this script, though I still get this error:
3580 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3581 error building tinymail
3583 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3585 * src/maemo/modest-main-window.c: (on_account_update):
3586 Very slight cleanup, hoping to make it simpler to discover what causes
3587 a crash here sometimes.
3589 * src/modest-tny-account.c:
3590 (modest_tny_account_new_from_server_account): Set the port. Added
3591 comments about the options and a TODO comment because I need to find out
3592 how to specify the secure authentication method.
3594 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3596 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3597 changed CFlags paths form modest to libmodest
3599 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3601 * src/modest-account-mgr-helpers.c:
3602 (modest_account_mgr_get_server_account_data),
3603 (modest_account_mgr_free_server_account_data):
3604 * src/modest-account-mgr-helpers.h:
3605 * src/modest-account-mgr.c:
3606 (modest_account_mgr_add_server_account):
3607 * src/modest-defs.h:
3608 * src/modest-tny-account.c:
3609 (modest_tny_account_new_from_server_account):
3610 Determine the options for tny_camel_account_add_option() here,
3611 based on the settings, rather than storing them directly in gconf.
3613 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3615 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3616 Show a more friendly error dialog now that we expect (from the tinymail
3617 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3619 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3621 * src/maemo/modest-main-window.c: (on_account_update): Check that
3622 account_name is not NULL, to prevent a crash at startup that I am
3623 seeing on the N800. I do wonder why it is NULL.
3625 * src/maemo/easysetup/modest-easysetup-wizard.c:
3626 (create_page_user_details):
3627 * src/maemo/modest-account-settings-dialog.c:
3628 (create_page_user_details), (create_page_outgoing):
3629 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3630 (modest_connection_specific_smtp_edit_window_init):
3631 * src/modest-ui-actions.c:
3632 (modest_ui_actions_on_password_requested):
3633 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3634 might do something useful with the on-screen keyboard.
3636 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3638 * src/maemo/modest-main-window.c: (on_account_update):
3639 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3640 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3642 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3644 * src/modest-tny-account-store.c: (on_account_changed):
3645 Correct the signature of this signal handler.
3647 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3649 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3650 Show a HildonNote instead of a GtkDialog for Maemo.
3652 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3654 * src/widgets/modest-account-view.h:
3655 * src/widgets/modest-account-view.c: (on_account_changed),
3656 (on_account_removed). Added a boolean flag, set/unset by
3657 modest_account_view_block_conf_updates(),
3658 modest_account_view_unblock_conf_updates() to prevent unnecessary
3659 updates, but this is not very useful because the gconf notifications are
3660 so delays (maybe only on Maemo Bora).
3661 So auto-updating is turned off, and these functions do an explicit
3662 update when necessary.
3663 However, something else is still doing too much work when adding/removing
3664 accounts, probably in another part of the application.
3666 * src/maemo/modest-account-view-window.c:
3667 (on_delete_button_clicked), (on_edit_button_clicked),
3668 (on_new_button_clicked): Use the new functions.
3670 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3672 * src/modest-account-mgr-helpers.c:
3673 (modest_account_mgr_set_first_account_as_default):
3674 Sort the list of names alphabetically-by-title, so we choose the first one
3676 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3677 alphabetically by the title.
3679 This fixes projects.maemo.org bug NB#56418 .
3681 * src/modest-account-mgr-priv.c:
3682 (_modest_account_mgr_account_from_key):
3683 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3684 avoid a valgrind error, and possible random behaviour.
3686 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3688 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3689 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3690 tinymail documentation to say that this can be expected.
3691 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3692 pretty, and should not happen, but I would prefer to know when it does.
3694 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3696 * configure.ac: When using the older hildon version, probably on Bora,
3697 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3699 * src/widgets/modest-attachment-view.c:
3700 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3703 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3705 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3706 Implemented the prototype. Can be tested with
3707 tests/dbus_api/test_open_message:
3709 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3711 * src/modest-tny-account-store.c:
3712 (modest_tny_account_store_instance_init), (get_password):
3713 * src/modest-ui-actions.c:
3714 (modest_ui_actions_on_password_requested):
3715 Do not store the password in gconf, because this function is called
3716 for non-remembered passwords. Actually use the cached (in the hash map)
3717 password instead of releasing it.
3718 The password will now not be remembered if it is asked via the protected
3719 password dialog, as per the UI spec.
3721 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3723 * src/modest-defs.h:
3724 * src/modest-account-mgr-helpers.h:
3725 * src/modest-account-mgr-helpers.c:
3726 Added modest_server_account_get_username_has_succeeded(),
3727 modest_server_account_set_username_has_succeeded().
3728 (modest_server_account_set_username),
3729 Reset the has-succeeded flag if the username changes.
3731 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3732 * src/maemo/modest-connection-specific-smtp-window.c:
3733 (modest_connection_specific_smtp_window_save_server_accounts):
3734 Use modest_server_account_set_username() instead of using
3735 modest_conf_set_string() directly, so that the has-succeeded flag is always
3738 * src/modest-ui-actions.c:
3739 (modest_ui_actions_on_password_requested): Dim the username entry if
3740 the username has ever worked, as per the UI spec.
3742 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3744 * src/modest-tny-account-store.c: (get_password):
3745 * src/modest-ui-actions.c:
3746 (modest_ui_actions_on_password_requested):
3747 Allow the username to be changed too, though there is more work to
3748 be done on exactly how this behaves.
3750 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3752 * src/modest-account-mgr-helpers.h:
3753 * src/modest-account-mgr-helpers.c:
3754 Added modest_account_mgr_get_display_name(),
3755 modest_server_account_get_username(),
3756 modest_server_account_set_username(),
3757 modest_server_account_set_password(),
3758 modest_server_account_get_hostname() functions so we do not need to
3759 use the conf API directly.
3761 * src/maemo/modest-main-window.c: (connect_signals):
3762 Actually connect ot the ModestAccountStore::request-password signal,
3763 so that we show the dialog when the password is requested by Tinymail,
3764 for isntance if it is empty.
3766 * src/modest-marshal.list:
3767 * src/modest-tny-account-store.c:
3768 (modest_tny_account_store_class_init), (get_password),
3769 (modest_tny_account_store_alert):
3770 * src/modest-tny-account-store.h:
3771 * src/modest-ui-actions.h:
3772 * src/modest-ui-actions.c:
3773 (modest_ui_actions_on_password_requested):
3774 Change the signal parameters, so it is obvious that we are providing
3775 the non human-readable server name, and receiving both the username
3776 and password, though changing of the username is not yet implemented.
3777 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3778 for the GNOME version.
3780 This should fix the projects.maemo.org bug NB#56209, though it does not
3781 work on Bora, because the gconf_client_get() for the password fails
3782 immediately after we save it with gconf_client_set().
3784 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3787 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3788 caused an undefined symbol error:
3789 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3791 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3793 * src/modest-tny-account-store.c:
3794 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3795 using a GError instead of a string message, so we can translate it in
3798 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3800 * src/maemo/modest-address-book.c:
3801 (modest_address_book_check_names):
3802 * src/maemo/modest-msg-view-window.c:
3803 (modest_msg_view_window_clipboard_owner_change):
3804 * src/modest-init.c: (modest_init_init_ui):
3805 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3806 (update_folders_cb), (modest_mail_operation_update_account):
3807 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3808 (modest_ui_actions_on_msg_attachment_clicked),
3809 (modest_ui_actions_on_msg_recpt_activated):
3810 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3811 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3812 (modest_msg_view_search_next):
3813 * src/widgets/modest-recpt-editor.c:
3814 (modest_recpt_editor_on_button_release_event),
3815 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3816 g_message(). At this point we should only be seeing interesting errors on
3817 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3819 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3821 (modest_wizard_dialog_force_title_update):
3822 * src/maemo/easysetup/modest-wizard-dialog.h:
3823 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3824 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3825 can update the title when appropriate. Otherwise the title is wrong if the
3826 pages are added after adding the notebook to the dialog.
3827 This must be a problem in HildonWizardDialog too.
3828 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3830 * src/maemo/easysetup/modest-easysetup-wizard.c:
3831 (create_subsequent_customsetup_pages),
3832 (create_subsequent_easysetup_pages):
3833 Call modest_wizard_dialog_force_title_update() so that the title is
3834 correct even with GTK+ < 2.10.
3835 This fixes projects.maemo.org bug NB#56145 .
3837 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3839 * src/maemo/modest-platform.c:
3840 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3841 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3844 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3846 * src/widgets/modest-window.h:
3847 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3848 and modest_window_save_state(), which invokes it.
3850 * src/widgets/modest-window-mgr.h:
3851 * src/widgets/modest-window-mgr.c:
3852 Added modest_window_mgr_save_state_for_all_windows(), which calls
3853 the save_state vfunc on all registered windows, if implemented.
3855 * src/gnome/modest-msg-edit-window.c:
3856 * src/gnome/modest-msg-view-window.c:
3857 * src/maemo/modest-msg-edit-window.c:
3858 * src/maemo/modest-msg-view-window.c:
3859 * src/maemo/modest-main-window.c:
3860 Specify the existing save_settings functions as implementations of
3861 ModestWindow::save_state_func().
3863 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3864 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3865 enabling hibernation, for instance.
3867 We may need to do the same thing for restoring settings.
3870 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3872 * src/widgets/modest-window-mgr.c:
3873 * src/widgets/modest-window-mgr.h:
3874 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3875 modest_window_mgr_get_hibernation_is_prevented().
3877 * src/maemo/modest-main-window.c:
3878 (on_hildon_program_is_topmost_notify): Prevent hibernation
3879 (possible when the application goes to the background in the WM),
3880 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3882 * src/maemo/easysetup/modest-easysetup-wizard.c:
3883 (modest_easysetup_wizard_dialog_init):
3884 * src/maemo/modest-account-settings-dialog.c:
3885 (modest_account_settings_dialog_init):
3886 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3887 (modest_connection_specific_smtp_edit_window_init):
3888 * src/maemo/modest-connection-specific-smtp-window.c:
3889 (modest_connection_specific_smtp_window_init):
3890 * src/maemo/modest-signature-editor-dialog.c:
3891 (modest_signature_editor_dialog_init):
3892 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3893 prevent hibernation while any of these account settings dialogs are open.
3895 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3897 * src/maemo/Makefile.am:
3898 * src/maemo/modest-osso-state-saving.c:
3899 * src/maemo/modest-osso-state-saving.h: Added
3900 modest_osso_load_state() and modest_osso_save_state() though they do
3901 nothing now. They should iterate through all the open windows and load/save
3903 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3904 save state when closing.
3906 * src/maemo/modest-main-window.c:
3907 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3908 Add a notification handler for the HildonProgram::is-topmost property,
3909 so we can allow hibernation when the application goes into the background.
3910 But we still need to detect when the accounts setup windows are open so
3911 we can stop hibernation when they are open.
3912 To do this, I also added the main window the HildonProgram. This might have
3913 other side-effects/benefits, and should maybe be done for other windows.
3915 * src/maemo/modest-osso-autosave-callbacks.h:
3916 * src/maemo/modest-osso-autosave-callbacks.c:
3917 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3918 though it does not do anything yet, and we might never need this to do
3919 anything. For instance, we already save drafts.
3921 * src/maemo/modest-platform.c: (modest_platform_init):
3922 Specify the libosso auto-save callback.
3924 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3926 * src/maemo/modest-platform.c:
3927 (modest_platform_set_update_interval):
3928 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3929 aparently stays valid between application instances, so we can use this
3930 to remove and reset it later. According to a maemo-developers email from
3933 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3935 * configure.ac: Depend on libalarm for Maemo.
3937 * src/dbus_api/modest-dbus-api.h:
3938 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3939 (on_send_receive), (modest_dbus_req_handler):
3940 Handle a SEND_RECEIVE D-Bus method.
3942 * libmodest-dbus-client/libmodest-dbus-client.c:
3943 (libmodest_dbus_client_send_and_receive):
3944 * libmodest-dbus-client/libmodest-dbus-client.h:
3945 Add C convenience functions for calling the new D-Bus method.
3947 * src/modest-platform.h:
3948 * src/gnome/modest-platform.c:
3949 * src/maemo/modest-platform.c:
3950 Added modest_platform_set_update_interval(), which uses the
3951 alarmd API on Maemo.
3952 (modest_platform_init),
3953 Call modest_platform_set_update_interval(), using a hard-coded
3954 interval for now (until the global settings dialog is implemented),
3955 though I am not sure that this makes sense yet.
3957 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3959 * src/dbus_api/modest-dbus-callbacks.c:
3960 (modest_osso_cb_hw_state_handler):
3961 * src/dbus_api/modest-dbus-callbacks.h:
3962 * src/maemo/modest-platform.c: (modest_platform_init):
3963 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3964 in case this has some effect on the ability for Maemo to ping the
3967 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3969 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3970 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3971 warning. It is probably a logic error, but I need to fix the build.
3973 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3975 * src/modest-account-mgr.h:
3976 * src/modest-account-mgr.c:
3977 (modest_account_mgr_account_names): Add a gboolean enabled_only
3978 parameter, so we can get lists of onlt the enabled accounts.
3980 (modest_account_mgr_add_account),,
3981 (modest_account_mgr_account_with_display_name_exists):
3982 * src/maemo/modest-msg-edit-window.c: (get_transports):
3983 * src/modest-account-mgr-helpers.c:
3984 (modest_account_mgr_set_first_account_as_default):
3985 * src/modest-init.c: (init_default_account_maybe):
3986 * src/modest-tny-account-store.c: (get_accounts):
3987 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3988 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3989 * tests/check_account-mgr.c: (START_TEST):
3990 Provide the extra parameter, as appropriate.
3992 * src/widgets/modest-account-view.c: (update_account_view):
3993 Do not show disabled accounts (meaning that there is no way to
3994 enable/disable accounts in the UI (the feature is not in our UI
3995 specification), so we can use this internally only to mark unfinished
3996 or temporary account data.
3998 * src/maemo/easysetup/modest-easysetup-wizard.c:
3999 (create_account): Add boolean enable parameter, so we can specify FALSE
4000 to create the temporary account.
4001 (on_button_edit_advanced_settings): Create the temporary account as disabled.
4002 (on_before_next): When finishing, when there is a temporary account, just
4004 Also, use a timeout to delay the showing of the dialog until gconf is likely
4005 to return correct information, due to a maemo gconf bug that is fixed in
4006 osso 1.1, but not yet in Bora.
4007 However, the dialog stays on screen after it is destroyed.
4009 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
4010 for invalid data when cancelling. Use a hildon note instead of a dialog
4011 to complain about invalid data. Do not show the account-saved note if the
4012 account is disabled (a temporary account that will not really be saved for use
4015 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4017 * src/modest-account-mgr-helpers.h:
4018 * src/modest-account-mgr-helpers.c:
4019 Added modest_account_mgr_unset_default_account(),
4020 Added modest_account_mgr_set_first_account_as_default().
4022 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
4023 If it was the default account, unset the default account name.
4025 * src/maemo/modest-account-view-window.c:
4026 (on_delete_button_clicked): If it was the default account,
4027 set the first remaining account as the default instead.
4029 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
4030 a NULL account or a NULL default account, to prevent a crash. This should
4031 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
4034 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4036 * src/widgets/modest-recpt-editor.c:
4037 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
4038 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
4039 TODO comment for this. This fixes the build.
4041 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
4042 be the best place for it. This will in future update all auto-update accounts,
4043 rather than just the current/default account, when that gconf key exists.
4044 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
4045 if there are no accounts, before calling do_send_receive().
4046 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
4048 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
4049 * src/maemo/modest-main-window-ui.h:
4050 * src/maemo/modest-main-window.c: (on_connection_changed),
4051 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
4052 directly, becaue the signal handler does more.
4054 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4056 * src/modest-account-mgr-helpers.c:
4057 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
4058 for the case that the account does not exist.
4060 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
4061 (equivalent to the modest account name) rather than the tinymail account name
4062 (equivalent to the modest account title - human readable) to get the account data.
4063 Check for null account data to prevent the crash, and add a TODO comment saying that
4064 this needs fixing because it is using the server account name instead of the account name.
4066 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4068 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
4069 * src/maemo/modest-account-settings-dialog.c: (show_error),
4071 Use hildon_note_new_information() for informative and error messages,
4072 which seems to be expected for Maemo applications (no documentation that I know of
4073 says this). I am surprised that there is no distinction between info and error
4076 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4078 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
4079 it is easy to find where this is used.
4081 * src/maemo/easysetup/modest-easysetup-wizard.c:
4082 (create_page_welcome), (create_page_account_details),
4083 (create_page_user_details), (create_page_complete_easysetup),
4084 (create_page_custom_incoming), (create_page_custom_outgoing),
4085 (create_page_complete_custom):
4086 * src/maemo/modest-account-settings-dialog.c:
4087 (create_page_account_details), (create_page_user_details),
4088 (create_page_incoming), (create_page_outgoing):
4089 * src/maemo/modest-account-view-window.c: (window_vbox_new):
4090 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4091 (modest_connection_specific_smtp_edit_window_init):
4092 * src/maemo/modest-connection-specific-smtp-window.c:
4093 (modest_connection_specific_smtp_window_init):
4094 * src/maemo/modest-signature-editor-dialog.c:
4095 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
4096 and scrolling policy as per the Email Application Layout Guide, if I have
4099 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4101 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
4102 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
4103 which were empty, because these vfuncs have been removed from TnyAccountStore.
4104 This fixes the build.
4106 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4108 * src/maemo/modest-main-window.c:
4109 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
4110 showing/hiding it. Added TODO because it probably should not be NULL.
4111 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
4112 because unnecessary g_warnings() make degugging difficult.
4114 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4116 * src/maemo/modest-msg-edit-window.c:
4117 (modest_msg_edit_window_select_color),
4118 (modest_msg_edit_window_select_background_color): 2 const corrections and
4119 moving 2 #endifs before closing brackets, to fix the build.
4121 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4123 * src/maemo/easysetup/modest-easysetup-wizard.h:
4124 * src/maemo/easysetup/modest-easysetup-wizard.c:
4125 (modest_easysetup_wizard_dialog_finalize),
4126 (on_button_edit_advanced_settings), (create_page_complete_custom),
4127 (on_response), (create_account):
4128 Implement the Advanced Settings edit button, by saving the account information,
4129 for the Advanded Settings dialog to use directly from gconf, and removing it
4130 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4131 Bug #5533 in the projects.maemo.org bugzilla.
4133 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4135 * src/maemo/modest-msg-view-window.c:
4136 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4137 when opening a message window.
4139 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4141 * src/maemo/easysetup/modest-easysetup-wizard.c:
4142 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4145 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4146 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4147 gconf settings. I probably added more checks than necessary, but that is safer.
4149 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4150 variable to fix the build, but this seems to be used when it is still NULL.
4152 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4154 * src/modest-platform.h:
4155 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4156 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4157 * src/modest-main.c: Implement this function so we can avoid using
4158 maemo-specific API from cross-platform code.
4160 * src/modest-tny-account-store.c:
4161 (get_smtp_specific_transport_account_for_open_connection):
4162 * src/modest-ui-actions.c: (check_for_connection),
4163 (modest_ui_actions_on_item_not_found):
4164 Use modest_platform_connect_and_wait() and put #idefs around other
4165 maemo-specific code, because only maemo currently has a way to
4166 identify connection names.
4168 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4170 * src/modest-tny-account-store.h:
4171 * src/modest-tny-account-store.c:
4172 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4173 the connection-specific SMTP server settings in the configuration.
4175 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4177 * src/maemo/modest-main-window.c: (on_connection_changed),
4179 * src/modest-main.c: (main), (start_ui), (send_mail):
4180 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4181 that is what is intended.
4183 * src/modest-ui-actions.c: (action_send), (action_receive),
4184 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4185 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4186 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4187 SMTP server is used when it is specified.
4189 (modest_ui_actions_on_send_receive):
4190 Check that a connection is open before proceeding.
4191 Receive and then send, instead of vice-versa, as per the specification.
4193 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4195 * src/modest-mail-operation.c:
4196 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4197 though I guess it should be something other than NULL.
4199 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4201 * src/maemo/easysetup/modest-easysetup-wizard.c:
4202 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4203 combo twice, to avoid an g_warning and to make it visible again.
4204 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4205 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4206 (already intended) dereference when detaching, because we then recreate the menu.
4207 But I am not sure why the warning was happening, and it is possible that this is a memory
4210 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4212 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4213 and uri_parse_mailto() utility functions.
4214 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4216 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4218 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4220 * src/dbus_api/modest-dbus-api.h:
4221 * src/dbus_api/modest-dbus-callbacks.c:
4222 Use an idle callback to execute the modest code in the application's own thread.
4223 Remove the helloworld example method.
4224 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4225 parsed, and the open-message method is not implemented because this is not yet implemented in
4227 * libmodest-dbus-client/libmodest-dbus-client.c:
4228 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4229 (libmodest_dbus_client_open_message):
4230 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4232 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4233 body without crashing.
4235 * tests/dbus_api/Makefile.am:
4236 * tests/dbus_api/test_mail_to.c:
4237 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4239 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4241 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4242 Added file to fix the build. Sorry.
4244 * src/dbus_api/Makefile.am:
4245 * src/dbus_api/modest-dbus-api.h:
4246 * src/dbus_api/modest-dbus-callbacks.h:
4247 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4248 (modest_dbus_req_handler):
4249 Put constants in a separate header so it can be reused by the
4250 client library, without duplication
4252 * libmodest-dbus-client/Makefile.am:
4253 * libmodest-dbus-client/libmodest-dbus-client.c:
4254 (libmodest_dbus_client_call_helloworld),
4255 (libmodfest_dbus_client_send_mail),
4256 (libmodfest_dbus_client_mailto),
4257 (libmodfest_dbus_client_open_message):
4258 * libmodest-dbus-client/libmodest-dbus-client.h:
4259 (Partly) Implement a send_mail D-Bus method.
4261 * tests/dbus_api/Makefile.am:
4262 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4263 the send_email D-Bus method.
4265 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4269 * libmodest-dbus-client/Makefile.am:
4270 * libmodest-dbus-client/libmodest-dbus-client.c:
4271 * libmodest-dbus-client/libmodest-dbus-client.h:
4272 * tests/dbus_api/Makefile.am:
4273 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4274 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4276 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4278 * src/maemo/easysetup/modest-easysetup-wizard.c:
4279 (create_page_account_details):
4280 * src/maemo/modest-account-settings-dialog.c:
4281 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4282 widgets, because this might not be the default in future versions of the Maemo GTK+.
4283 However, I can not not get capitalization to work even in a simple test case.
4285 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4287 * src/maemo/easysetup/modest-easysetup-wizard.c:
4288 (create_page_custom_incoming), (create_page_custom_outgoing):
4289 * src/maemo/modest-account-settings-dialog.c:
4290 (create_page_account_details), (create_page_incoming),
4291 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4292 instead of using gtk_check_button_with_label(), so they are aligned like the other
4293 widgets, as per the UI spec.
4295 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4297 * src/maemo/easysetup/modest-easysetup-wizard.c:
4298 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4299 * src/widgets/modest-validating-entry.c:
4300 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4301 Modest prefix instead of an EasySetup prefix.
4303 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4305 * src/widgets/modest-validating-entry.h:
4306 * src/widgets/modest-validating-entry.c: (on_insert_text),
4307 Added easysetup_validating_entry_set_max_func(), used to set a callback
4308 to call when the max number of characters is reached. GtkEntry has a max-length
4309 already but is silent about it.
4311 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4312 (create_page_account_details), (create_page_user_details),
4314 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4315 (create_page_account_details), (create_page_user_details),
4316 (create_page_outgoing):
4317 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4318 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4319 the UI spec, when the user tries to enter more than the max number of characters.
4321 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4323 * src/maemo/easysetup/modest-easysetup-wizard.c:
4324 (create_page_user_details), (create_page_custom_incoming),
4325 (create_page_custom_outgoing):
4326 * src/maemo/modest-account-settings-dialog.c:
4327 (create_page_user_details), (create_page_incoming),
4328 (create_page_outgoing):
4329 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4330 (modest_connection_specific_smtp_edit_window_init):
4331 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4332 not appropriate. Bad Maemo-specific defaults!.
4334 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4336 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4337 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4338 (modest_signature_editor_dialog_set_settings):
4339 Disable the label and textview when the checkbox is disabled, and use the
4340 specified (UI spec) default signature text.
4342 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4344 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4345 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4347 * src/modest-defs.h:
4348 * src/modest-account-mgr-helpers.h:
4349 * src/modest-account-mgr-helpers.c:
4350 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4352 * src/maemo/Makefile.am:
4353 * src/maemo/modest-signature-editor-dialog.c:
4354 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4357 * src/maemo/modest-account-settings-dialog.h:
4358 * src/maemo/modest-account-settings-dialog.c:
4359 (modest_account_settings_dialog_finalize), (on_button_signature),
4360 (save_configuration): Use the new dialog when the Edit button is pressed, and
4361 save the changes if necessary, as per the UI spec.
4363 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4365 * src/maemo/Makefile.am:
4366 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4367 based on maemo-develoers email from Dirk.
4369 * src/maemo/easysetup/modest-easysetup-wizard.c:
4370 (create_page_welcome), (create_page_account_details),
4371 (create_page_user_details), (create_page_complete_easysetup),
4372 (create_page_custom_incoming), (create_page_custom_outgoing),
4373 (create_page_complete_custom),
4374 (modest_easysetup_wizard_dialog_init):
4375 * src/maemo/modest-account-settings-dialog.c:
4376 (create_page_account_details), (create_page_user_details),
4377 (create_page_incoming), (create_page_outgoing),
4378 (modest_account_settings_dialog_init):
4379 * src/maemo/modest-connection-specific-smtp-window.c:
4380 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4382 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4384 * src/maemo/easysetup/modest-easysetup-wizard.c:
4385 (create_page_account_details), (create_page_custom_outgoing),
4386 (create_page_complete_custom):
4387 * src/maemo/modest-account-settings-dialog.c:
4388 (create_page_user_details), (create_page_incoming),
4389 (create_page_outgoing):
4390 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4391 (modest_connection_specific_smtp_edit_window_init):
4392 Use the correct (UI spec) port min/max, and use horizontal separators,
4395 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4397 * src/maemo/easysetup/modest-easysetup-wizard.c:
4398 (set_default_custom_servernames):
4399 * src/maemo/modest-account-settings-dialog.c:
4400 (create_page_incoming), (on_combo_outgoing_security_changed),
4401 (on_combo_incoming_security_changed), (create_page_outgoing),
4402 (modest_account_settings_dialog_set_account_name),
4403 (save_configuration):
4404 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4405 (on_combo_security_changed),
4406 (modest_connection_specific_smtp_edit_window_init),
4407 (modest_connection_specific_smtp_edit_window_set_connection),
4408 (modest_connection_specific_smtp_edit_window_get_settings):
4409 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4412 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4415 * src/maemo/easysetup/modest-easysetup-wizard.c:
4416 (create_page_custom_outgoing), (create_page_complete_custom):
4417 * src/maemo/modest-account-settings-dialog.c:
4418 (create_page_user_details), (create_page_outgoing):
4419 * src/maemo/modest-account-view-window.c: (button_box_new):
4420 Use changed logical IDs as per the most recent UI spec:
4421 mcen_bd_emailsetup_edit -> mcen_bd_edit
4422 mcen_bd_emailsetup_delete -> mcen_bd_delete
4423 mcen_bd_emailsetup_close -> mcen_bd_close
4425 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4429 * src/dbus_api/Makefile.am:
4430 * src/dbus_api/modest-dbus-callbacks.c:
4431 * src/dbus_api/modest-dbus-callbacks.h:
4432 * src/maemo/modest-platform.c: (modest_platform_init):
4433 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4435 * tests/Makefile.am:
4436 * tests/dbus_api/Makefile.am:
4437 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4439 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4441 * src/maemo/modest-account-settings-dialog.c:
4442 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4443 Removed unnecessary includes.
4445 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4447 * src/maemo/easysetup/modest-easysetup-wizard.c:
4448 * src/maemo/modest-account-settings-dialog.c:
4449 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4450 * src/widgets/Makefile.am:
4451 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4452 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4453 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4454 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4455 * src/widgets/modest-secureauth-combo-box.c:
4456 * src/widgets/modest-secureauth-combo-box.h:
4457 * src/widgets/modest-serversecurity-combo-box.c:
4458 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4459 made the GObject names more consistent with the rest of the Modest code.
4461 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4463 * src/maemo/easysetup/Makefile.am:
4464 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4465 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4466 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4467 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4468 * src/maemo/easysetup/modest-easysetup-wizard.c:
4469 * src/maemo/easysetup/modest-validating-entry.c:
4470 * src/maemo/easysetup/modest-validating-entry.h:
4471 * src/maemo/modest-account-settings-dialog.c:
4472 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4473 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4474 widgets/ because they are used outside of easysetup too. After checking in,
4475 svn will allow me to rename them too.
4477 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4479 * src/gnome/modest-msg-edit-window.c:
4480 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4481 linker error, to fix the build on the GNOME platform.
4482 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4483 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4484 ifdefed out to avoid a warning.
4486 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4488 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4489 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4490 some alternative for GTK+ 2.6.
4492 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4494 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4496 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4497 specified for EmailAccountsDialog in UI spec.
4499 * src/maemo/easysetup/modest-easysetup-wizard.c:
4500 * src/maemo/easysetup/modest-easysetup-wizard.h:
4501 * src/maemo/modest-account-settings-dialog.c:
4502 * src/maemo/modest-account-settings-dialog.h:
4503 Reuse a member window widget for the connection-specific SMTP server accounts,
4504 so we can tell it to create/save the accounts only if we actually save changes.
4506 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4507 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4508 (modest_connection_specific_smtp_edit_window_get_settings):
4509 Return a struct instance for temporarily remembering the entered data.
4511 * src/maemo/modest-connection-specific-smtp-window.h:
4512 * src/maemo/modest-connection-specific-smtp-window.c:
4513 (modest_connection_specific_smtp_window_finalize),
4514 (modest_connection_specific_smtp_window_fill_with_connections),
4516 (modest_connection_specific_smtp_window_save_server_accounts),
4517 (update_model_server_names): Do not actually save data until asked,
4518 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4520 (on_selection_changed),
4521 (modest_connection_specific_smtp_window_init): Disable the edit
4522 button when nothing is selected.
4524 * src/modest-account-mgr-helpers.c:
4525 * src/modest-account-mgr-helpers.h:
4526 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4529 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4531 * src/modest-account-mgr-helpers.h:
4532 * src/modest-account-mgr-helpers.c:
4533 (modest_account_mgr_get_unused_account_name),
4534 (modest_account_mgr_get_unused_account_display_name): Added these
4535 utility functions, to avoid code duplication.
4537 * src/maemo/easysetup/modest-easysetup-wizard.c:
4538 (create_page_account_details), (create_account):
4539 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4540 (on_combo_security_changed),
4541 (modest_connection_specific_smtp_edit_window_init),
4542 (modest_connection_specific_smtp_edit_window_save_settings):
4543 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4544 * src/maemo/modest-connection-specific-smtp-window.c:
4545 (modest_connection_specific_smtp_window_finalize),
4546 (modest_connection_specific_smtp_window_fill_with_connections),
4547 (on_button_edit), (modest_connection_specific_smtp_window_init):
4548 * src/maemo/modest-connection-specific-smtp-window.h:
4549 Implementing saving of connection-specific server accounts.
4551 But I need to refactor this so we can save the data for each
4552 possible connection-specific account and only actually create the server accounts
4553 when the easysetup finished, or the OK button is pressed on the account settings
4556 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4558 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4559 (on_combo_security_changed):
4560 (modest_connection_specific_smtp_edit_window_init):
4561 Auto-fill the port number as in the account settings.
4563 (modest_connection_specific_smtp_edit_window_set_connection):
4564 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4565 * src/maemo/modest-connection-specific-smtp-window.c:
4566 (fill_with_connections), (on_button_edit),
4567 (modest_connection_specific_smtp_window_init):
4568 Turn the edit window into a dialog to simplify the code, and
4569 set a WM hint as in a GtkDialog, because only a popup can be on top of
4570 another window in Maemo, and popups usually have no WM decoration.
4572 * src/modest-defs.h:
4573 * src/modest-account-mgr-helpers.c:
4574 (modest_account_mgr_set_connection_specific_smtp),
4575 (modest_account_mgr_remove_connection_specific_smtp),
4576 (modest_account_mgr_get_connection_specific_smtp):
4577 * src/modest-account-mgr-helpers.h: Some functions to write the
4578 connection-specific SMTP server information. Not yet used.
4581 * src/widgets/modest-folder-view.c: (text_cell_data):
4582 Fix a warning about an uninitialized variable.
4583 (on_configuration_key_changed): Put an #ifdef around the use
4584 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4586 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4588 * src/maemo/modest-account-settings-dialog.h:
4589 * src/maemo/modest-account-settings-dialog.c:
4590 Added connect_for_modified() utility function to mark the new modified boolean.
4592 (create_page_account_details), (create_page_user_details),
4593 (create_page_incoming), (create_page_outgoing), (on_response),
4594 (modest_account_settings_dialog_init),
4595 (modest_account_settings_dialog_set_account_name):
4596 Only warn about unsaved changes when there are actually unsaved changes.
4598 * src/modest-account-mgr-helpers.c:
4599 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4600 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4601 to get the data from there in future.
4603 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4605 * src/modest-defs.h:
4607 * src/modest-account-mgr-helpers.h:
4608 * src/modest-account-mgr-helpers.c:
4609 Store the security account setting in a single conf key instead of using
4610 the options list, so that the list is left for just the to-be-removed camel hack,
4611 and because gconf_client_set_list() is failing for some reason.
4613 * src/modest-account-mgr.c:
4614 (modest_account_mgr_add_server_account):
4615 * src/maemo/modest-account-settings-dialog.c:
4616 (modest_account_settings_dialog_set_account_name),
4617 (save_configuration): Use the renamed functions.
4620 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4622 * src/widgets/Makefile.am:
4623 * src/widgets/modest-limit-retrieve-combo-box.c:
4624 * src/widgets/modest-limit-retrieve-combo-box.h:
4625 * src/widgets/modest-retrieve-combo-box.c:
4626 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4627 the account settings dialog.
4629 * src/modest-defs.h:
4630 * src/modest-account-mgr-helpers.h:
4631 * src/modest-account-mgr-helpers.c:
4632 (modest_server_account_get_option_secure_auth),
4633 (modest_server_account_set_option_secure_auth):
4634 * src/modest-account-mgr.c:
4635 (modest_account_mgr_add_server_account):
4636 Use the existing AUTH_MECH conf key for the secure-auth setting,
4637 instead of putting it in the list options, because this was actually used already.
4639 * src/maemo/modest-account-settings-dialog.c:
4640 (create_page_account_details),
4641 (modest_account_settings_dialog_set_account_name),
4642 (save_configuration):
4643 * src/maemo/modest-account-settings-dialog.h:
4644 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4645 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4647 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4649 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4650 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4651 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4653 * src/modest-defs.h:
4654 * src/maemo/modest-account-settings-dialog.c:
4655 (create_page_incoming), (on_combo_outgoing_security_changed),
4656 (on_combo_incoming_security_changed), (create_page_outgoing),
4657 (modest_account_settings_dialog_set_account_name),
4658 (save_configuration): Load/Save the port number, and change it when the
4659 security combo changes, to suitable defaults.
4661 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4663 * src/modest-account-mgr.c:
4664 (modest_account_mgr_add_server_account): Set the security and secure-auth
4665 options, and add a comment saying that the other camel-specific options should be
4668 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4670 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4672 * src/modest-tny-account-store.c: (account_list_free),
4673 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4674 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4677 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4679 * src/modest-protocol-info.c:
4680 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4681 is required by our UI spec. Maybe something in our implementation will use this eventually.
4682 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4683 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4684 instead of the previous 0 placeholder.
4686 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4687 secure-auth settings.
4688 * src/modest-account-mgr-helpers.h:
4689 * src/modest-account-mgr-helpers.c:
4690 (modest_server_account_data_get_option_secure_auth),
4691 (modest_server_account_set_option_secure_auth),
4692 (modest_server_account_data_get_option_security),
4693 (modest_server_account_set_option_security): Added this API for getting and setting the security
4694 and secure-auth settings.
4696 * src/maemo/modest-account-settings-dialog.h:
4697 * src/maemo/modest-account-settings-dialog.c:
4698 (modest_account_settings_dialog_finalize), (check_data),
4699 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4700 about changing titles.
4701 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4702 (save_configuration): Save the security and secure-auth settings.
4704 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4705 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4707 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4709 * src/modest-defs.h:
4710 * src/modest-account-mgr.c:
4711 (modest_account_mgr_add_server_account):
4712 Added and used defines for the options key and value pair strings,
4713 that are used so far, though they do not seem to correspond to anything in our
4714 UI specs or ModestProtocol enum.
4716 * src/modest-account-mgr-helpers.h:
4717 * src/modest-account-mgr-helpers.c:
4718 (compare_option_strings_for_name),
4719 (modest_server_account_data_get_option_value),
4720 (modest_server_account_data_get_option_bool),
4721 (modest_account_mgr_get_server_account_option):
4722 Added helper functions for parsing the options GSList.
4724 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4726 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4727 display name is based on the supplied account name.
4728 * src/modest-account-mgr.c:
4729 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4730 with an inefficient, but good-enough, implementation.
4732 * src/maemo/easysetup/modest-easysetup-wizard.c:
4733 (create_page_account_details), (on_before_next), (create_account):
4734 Check for existing display names rather than (non-user-visible) account names, and just
4735 create and set a unique account name at the end.
4737 * src/maemo/modest-account-settings-dialog.c:
4738 (modest_account_settings_dialog_init),
4739 (modest_account_settings_dialog_set_account_name),
4740 (create_page_incoming): Show the display name, instead of the account name.
4741 (on_response): Do some (not all) extra checks, as in the UI spec.
4742 (save_configuration): Save the display name if it was changed.
4744 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4746 * po/en_GB.po: Added needed logical ID and translation.
4747 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4748 (init_view): Made the is-default column clicking work.
4750 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4753 * src/maemo/easysetup/Makefile.am:
4754 * src/maemo/easysetup/modest-easysetup-wizard.c:
4755 (modest_easysetup_wizard_dialog_init):
4756 * src/maemo/easysetup/provider-data-test.keyfile:
4757 * src/maemo/easysetup/provider-data.keyfile:
4758 Moved the provider data file to the new modest-providers-data package and used it from there.
4760 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4762 * src/modest-local-folder-info.c:
4763 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4764 N_() was already used on the static strings, but this just marks it for translation without
4765 using the translation.
4767 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4769 * src/maemo/modest-account-settings-dialog.c:
4770 (create_page_incoming),
4771 (modest_account_settings_dialog_set_account_name):
4772 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4773 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4774 I will do this if nobody else gets there first.
4776 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4778 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4779 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4780 save the security stuff.
4782 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4784 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4785 Set the email address and user fullname, which I now see must be
4788 * src/maemo/modest-account-settings-dialog.h:
4789 * src/maemo/modest-account-settings-dialog.c:
4791 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4792 leave-on-server and authentication.
4793 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4796 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4799 * src/maemo/modest-account-settings-dialog.c:
4800 * src/maemo/modest-account-settings-dialog.h:
4801 Most (but not all) of the widgets are now present as specified by the UI spec.
4802 No changes are yet saved, and some details are not properly shown yet.
4804 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4806 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4808 * src/maemo/Makefile.am:
4809 * src/maemo/modest-account-settings-dialog.c:
4810 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4811 an existing account. Doesn't do much yet.
4813 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4814 Open the accounts settings dialog when Edit is clicked.
4816 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4818 * src/maemo/easysetup/Makefile.am:
4819 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4821 * src/maemo/easysetup/modest-easysetup-wizard.c:
4822 (modest_easysetup_wizard_dialog_init):
4823 Try to get the source directory from the build system,
4824 instead of hard-coding "./" into the source code, when opening our local
4825 copies of the configuration files.
4826 But this still fails when opening the wizard from the Accounts window,
4827 maybe because the working directory seems to change at runtime.
4828 So the wizard will fail the second time unless you copy the files into their
4829 proper locations - see the stdout warnings for the paths.
4831 (create_page_account_details),(on_before_next):
4832 Check for existing non-server accounts instead of server accounts,
4833 so the default account name is useful again, and to prevent trying to
4836 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4837 Show the wizard when New is clicked.
4839 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4840 (init_view): Show the column headers, and show the columns that are
4841 specified in the UI specs. However, something in Maemo's GTK+ prevents
4842 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4843 change the default account. This is despite unsetting the special properties.
4845 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4847 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4848 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4849 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4850 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4851 to make that clearer.
4852 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4854 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4856 * src/maemo/modest-account-view-window.c:
4857 (modest_account_view_window_init),
4858 (modest_account_view_window_new):
4859 Use the same buttons as specified in the
4860 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4861 the existing widgets, which never had a chance of working.
4862 Put the ModestAccountView treeview in a scrolled window.
4863 Do not repeat the initialization in both _init() and _new().
4865 * src/widgets/modest-account-view.c: (update_account_view):
4866 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4867 this widget and window shows no accounts.
4869 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4871 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4873 * src/maemo/easysetup/modest-easysetup-wizard.c:
4874 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4875 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4876 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4879 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4880 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4881 accounts exist yet, as in the UI spec.
4883 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4885 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4887 * src/maemo/Makefile.am:
4888 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4889 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4890 New window for editing connection-specific smtp details.
4891 Not fully implemented.
4893 * src/maemo/modest-connection-specific-smtp-window.c:
4894 (modest_connection_specific_smtp_window_finalize) :
4895 unref the tree model.
4896 (on_button_edit): Show the edit window.
4898 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4900 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4903 * src/maemo/Makefile.am:
4904 * src/maemo/modest-connection-specific-smtp-window.c:
4905 * src/maemo/modest-connection-specific-smtp-window.h:
4906 New window for showing the list of connections, for connection-specific
4907 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4908 * src/maemo/easysetup/modest-easysetup-wizard.c:
4909 (create_page_custom_outgoing): Show the new window when the button is clicked.
4911 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4913 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4914 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4915 * src/maemo/modest-msg-edit-window.c:
4916 (modest_msg_edit_window_insert_image):
4917 * src/modest-conf.c: (modest_conf_key_escape):
4918 * src/modest-mail-operation.c:
4919 (modest_mail_operation_send_new_mail):
4920 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4921 (modest_ui_actions_on_new_account):
4922 * src/widgets/modest-attachment-view.c: (update_filename_request):
4923 * src/widgets/modest-mail-header-view.c:
4924 Corrected warnings that were breaking the build, by commenting out unused variables,
4925 and a function, and by including a header.
4927 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4929 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4930 so we can #ifdef around platform-specific code when necessary.
4931 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4932 to allow this to build for the GNOME platform too.
4934 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4936 * src/maemo/easysetup/modest-easysetup-wizard.c:
4937 Added util_increment_name() and used it in create_page_account_details()
4938 to make sure that the default account name is always a new name.
4940 (modest_easysetup_wizard_dialog_init),
4941 (set_default_custom_servernames): Some minor memory management fixes.
4943 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4947 * src/modest-runtime.c: (init_i18n): Restored the translation
4948 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4949 are defined in config.h, and the translations are installed.
4951 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4952 is defined for translation.
4954 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4956 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4958 * src/maemo/easysetup/modest-easysetup-wizard.c:
4959 (modest_easysetup_wizard_dialog_init):
4960 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4961 Use realistic paths (though they should use $prefix generically) to the
4962 mcc_mapping and provider-data.keyfile files which might work when they
4963 are installed by the future version of the operator-wizard package,
4964 and then fallback to paths in our source code, with an explanatory
4967 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4971 * src/maemo/Makefile.am:
4972 * src/maemo/easysetup/: Added files from the previously-exernal
4973 osso-modest-easysetup.
4974 * src/maemo/modest-main-window-ui.h:
4975 * src/modest-ui-actions.c:
4976 * src/modest-ui-actions.h:
4977 Added modest_ui_actions_on_new_account() as a signal handler for the
4978 New Account menu item. It shows the easysetup wizard.
4979 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob