1 2007-06-05 Murray Cumming <murrayc@murrayc.com>
4 * src/modest-tny-simple-folder-store.c:
5 * src/modest-tny-simple-folder-store.h: Removed.
7 * src/modest-tny-local-folders-account.h
8 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
9 for the local-folders maildir, with an extra TnyMergedFolder containing
10 the folders of the per-account outbox store accounts.
11 * src/modest-tny-account-store.c: (get_server_accounts):
12 Add the outboxes to the special local folders account after creating it.
14 * src/modest-tny-account.c:
15 (modest_tny_account_new_for_local_folders): Create the derived
16 account when creating the main local-folders account.
18 * src/maemo/modest-main-window.c: (create_details_widget),
19 (modest_main_window_set_contents_style):
20 Adapted to the use of the derived account instead of the folder store.
22 * src/modest-ui-actions.c:
23 (modest_ui_actions_on_folder_selection_changed):
24 * src/modest-ui-dimming-rules.c:
25 (modest_ui_dimming_rules_on_new_folder):
26 * src/widgets/modest-folder-view.c: (text_cell_data),
27 (icon_cell_data), (filter_row), (update_model),
28 (get_cmp_rows_type_pos):
31 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
32 Do not get the priv struct, because no priv struct has been set,
33 to avoid a runtime warning.
35 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
36 #ifelse with #else, to fix a warning, to fix the build.
39 2007-06-05 Christian Kellner <ckellner@openismus.com>
41 * libmodest-dbus-client/libmodest-dbus-client.c:
42 Fix small typo in doc (why do you always see them
43 AFTER committing stuff?)
46 2007-06-05 Christian Kellner <ckellner@openismus.com>
48 * libmodest-dbus-client/libmodest-dbus-client.c:
49 (libmodest_dbus_client_search):
50 Initialize hit list with NULL. Also set folder list
51 to "" if NULL was supplied.
54 2007-06-03 Christian Kellner <ckellner@openismus.com>
56 * libmodest-dbus-client/libmodest-dbus-client.c:
57 (modest_search_hit_list_free):
58 Make it save to call it with NULL.
60 * src/dbus_api/modest-dbus-callbacks.c:
61 * src/modest-search.c:
62 Return full ModestSearchHits as the search result list not TnyHeader
63 since can't be around withouth the correspoding TnyFolder.
65 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
67 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
68 Added currently commented code to check for secure auth
70 * src/maemo/modest-account-settings-dialog.c: (on_response),
71 (save_configuration), (show_ok):
72 Fixed projects.maemo.org bugs NB #59248 and #59251
74 * src/maemo/modest-maemo-utils.c:
75 (on_camel_account_get_supported_secure_authentication_status),
76 (on_camel_account_get_supported_secure_authentication),
77 (modest_maemo_utils_get_supported_secure_authentication_methods):
78 * src/maemo/modest-maemo-utils.h:
79 Moved get_supported_secure_authentication() method here to be able
80 to use it from easysetup wizard.
82 * src/modest-pair.c: (on_pair_compare_as_string):
83 Should compare string with first part of pair and not
84 strcmp pairs which will crash.
86 * src/modest-protocol-info.c:
87 (modest_protocol_info_protocol_is_store):
88 * src/modest-protocol-info.h:
89 Added modest_protocol_info_get_auth_protocol_name()
91 2007-06-03 Armin Burgmeier <armin@openismus.com>
93 * src/modest-mail-operation.c:
94 (modest_mail_operation_get_msgs_full): Set priv->account also when
95 only retrieving a single message. This avoids a crash when canceling
98 (modest_mail_operation_notify_end): Do not explicitely remove the
99 operation from the queue but only emit the progress_changed signal.
100 The queue itself listens to that signal to remove the operation when
101 it is finished. This reduces coupling and removes a potential deadlock
102 when modest_mail_operation_notify_end() is called from the queue
103 itself. If that is a problem performance-wise, I would suggest to
104 implement a status-changed signal or something.
106 * src/modest-mail-operation-queue.c: Make sure to never call a
107 function from another file while the queue is locked. This (hopefully)
108 fixes another deadlock when exiting the application while retrieving
111 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
113 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
114 Fixed build if libogs is not available
116 2007-06-03 Christian Kellner <ckellner@openismus.com>
118 * libmodest-dbus-client/libmodest-dbus-client.h:
119 * libmodest-dbus-client/libmodest-dbus-client.c:
120 (libmodest_dbus_client_delete_message):
121 Implement deletion of messages (Client side).
123 (modest_search_hit_free),
124 (modest_search_hit_list_free):
125 Utility functions to free the result hits.
127 * src/dbus_api/modest-dbus-api.h:
128 * src/dbus_api/modest-dbus-callbacks.c:
130 (modest_dbus_req_handler):
131 Implement deletion of messages (Server side).
133 * tests/dbus_api/test_search.c: (main):
136 * tests/dbus_api/Makefile.am:
137 * tests/dbus_api/test_delete_message:
138 Add little test for the message deletion logic
140 2007-06-03 Armin Burgmeier <armin@openismus.com>
142 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
143 when the operation queue was not empty. projects.maemo.org bug
146 2007-06-03 Armin Burgmeier <armin@openismus.com>
148 * src/widgets/modest-account-view.c
149 (on_account_default_toggled): Toggle default account column
150 explicitely instead of waiting for gconf notification (which is
151 currently ignored). This should fix projects.maemo.org bug NB#56910
152 for now. It should probably be removed when gconf notifications are
155 2007-06-03 Christian Kellner <ckellner@openismus.com>
157 * libmodest-dbus-client/libmodest-dbus-client.c:
158 Removed debugging spew.
160 * src/dbus_api/modest-dbus-callbacks.c:
161 Added debugging info.
163 * src/modest-search.c:
164 (modest_search_all_accounts):
165 Use tny_account_store_get_accounts () on the account store
166 to get all accounts which is the way to get all accounts.
168 * tests/dbus_api/test_search.c: (main):
169 Make it possible to supply the search term on the command line.
171 2007-06-03 Christian Kellner <ckellner@openismus.com>
173 * libmodest-dbus-client/libmodest-dbus-client.c:
174 * libmodest-dbus-client/libmodest-dbus-client.h:
175 Implement searching for mesages over raw dbus. (Client side)
177 * src/dbus_api/Makefile.am:
178 * src/dbus_api/modest-dbus-api.h:
179 * src/dbus_api/modest-dbus-callbacks.c:
180 * src/dbus_api/modest-dbus-callbacks.h:
181 Search framework (Server side). Also implement on_idle_open_message().
183 * src/maemo/modest-platform.c: (modest_platform_init):
184 Prepare for raw dbus/osso rpc interaction.
186 * src/modest-search.h:
187 Changed minsize from unspecific guint to guint32.
189 * src/modest-search.c:
191 Added strange hack which magically made tnymail work.
193 (modest_search_folder),
194 (modest_search_account),
195 (modest_search_all_accounts):
196 Implement helper functions to search all accounts, specific account
199 * tests/dbus_api/Makefile.am:
200 * tests/dbus_api/test_open_message.c:
201 Read url to open from commandline.
203 * tests/dbus_api/test_search.c:
204 Implement small test for dbus search stuff
206 2007-06-02 Armin Burgmeier <armin@openismus.com>
208 * src/maemo/modest-account-settings-dialog.c: Changed window title to
209 include account type and account title. This fixes projects.maemo.org
212 * src/maemo/modest-account-view-window.c: Set a title for the window.
214 2007-06-02 Armin Burgmeier <armin@openismus.com>
216 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
217 incoming and outgoing server name based on email address and server
218 types as long as the names have not been edited manually. This fixes
219 projects.maemo.org bug NB#58671.
221 2007-06-02 Armin Burgmeier <armin@openismus.com>
223 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
224 server type cannot be changed in future to the incoming details page
225 when creating an account. This fixes projects.maemo.org bug NB#59029.
227 2007-06-02 Armin Burgmeier <armin@openismus.com>
229 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
230 and assigned max width chars so that they wrap instead of being
231 truncated. Fixes projects.maemo.org bug NB#56126.
233 2007-06-02 Armin Burgmeier <armin@openismus.com>
235 * src/maemo/modest-connection-specific-smtp-window.c: Add an
236 introductory note to the connection specific smtp servers dialog, as
237 section 8.12 of the email UI specification requires. This fixes
238 projects.maemo.org bug NB#59212.
240 2007-06-01 Murray Cumming <murrayc@murrayc.com>
242 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
243 Check for running mail operations, and offer to cancel them, as per the UI
244 spec. This fixes projects.maemo.org bug NB#59041 .
245 However, I suspect that tinymail may still use the network connection
246 in ways that we cannot detect or cancel. But it should at least adapt to
249 2007-06-01 Murray Cumming <murrayc@murrayc.com>
251 * src/modest-tny-account-store.c: (recreate_all_accounts),
252 (get_cached_accounts), (get_server_accounts): Do more sensible
253 ref-counting of the temporarily-cached outbox accounts list. This seems
254 to fix a crash when entering the password when the password was wrong.
256 2007-06-01 Murray Cumming <murrayc@murrayc.com>
258 * src/gnome/modest-main-window.c: (connect_signals):
259 * src/modest-tny-account-store.c: (get_password),
260 (modest_tny_account_store_alert): Added comments and clues and
261 commented-out code about how we currently fail to deal with connection
262 errors and wrong passwords, and how we should.
264 2007-06-01 Murray Cumming <murrayc@murrayc.com>
266 * src/widgets/modest-retrieve-combo-box.c:
267 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
268 This fixes projects.maemo.org bug NB#58472 .
270 2007-06-01 Murray Cumming <murrayc@murrayc.com>
272 * src/maemo/easysetup/modest-easysetup-wizard.c:
273 (create_page_complete_easysetup):
274 (create_page_complete_custom): Correct the last commit,
275 putting the correct sentences in the correct pages.
277 2007-06-01 Murray Cumming <murrayc@murrayc.com>
279 * src/maemo/easysetup/modest-easysetup-wizard.c:
280 (create_page_complete_custom): Show the second sentence of text
281 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
284 2007-06-01 Murray Cumming <murrayc@murrayc.com>
286 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
287 Set the leave-on-server conf key by default. This fixes
288 projects.maemo.org bug NB#59258 .
290 2007-06-01 Murray Cumming <murrayc@murrayc.com>
292 * src/maemo/modest-account-view-window.c:
293 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
294 logical ID for the confirmation messages. Fixed projects.maemo.org bug
297 2007-06-01 Murray Cumming <murrayc@murrayc.com>
299 * src/maemo/easysetup/modest-easysetup-wizard.c:
300 (create_caption_new_with_asterisk):
301 * src/maemo/modest-account-settings-dialog.c:
302 (create_caption_new_with_asterisk):
303 Uncomment the code to add the asterisk, because they are no longer in the
304 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
305 (update_incoming_server_title): Add an asterisk here too.
307 2007-06-01 Murray Cumming <murrayc@murrayc.com>
309 * src/maemo/modest-maemo-global-settings-dialog.c:
310 (current_connection): Check that we are even connected before trying to
311 get the current connection name, to prevent a warning.
313 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
314 Change the comments because tny_maemo_conic_device_connect() is now meant to
316 * src/modest-mail-operation.c:
317 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
318 make sure we have a connection and fail if we can't connect.
320 2007-05-31 Murray Cumming <murrayc@murrayc.com>
322 * src/maemo/modest-main-window.c:
323 (on_account_store_connecting_finished): Do not try to get the
324 connection ID if we are not really connected. I am surprised that
325 this signal handler is called when we are not connected.
327 2007-05-31 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-error.h:
330 * src/modest-ui-actions.c:
331 (modest_ui_actions_get_msgs_full_error_handler):
332 Renamed an enum, added comments, added an enum
333 for retrieve-limit errors.
335 * src/modest-mail-operation.c: (foreach_add_item),
336 (internal_folder_observer_update), (update_account_thread),
337 (modest_mail_operation_get_msgs_full):
338 (modest_mail_operation_update_account),
339 Added comments about how this works, and some code that should
340 (but does not) check the retrieve-limit. See the TODO comment.
342 2007-05-31 Murray Cumming <murrayc@murrayc.com>
344 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
345 Initialize help_id to fix the build. Warnings are good.
347 2007-05-31 Murray Cumming <murrayc@murrayc.com>
349 * src/widgets/modest-hbox-cell-renderer.c:
350 (modest_hbox_cell_renderer_append):
351 * src/widgets/modest-vbox-cell-renderer.c:
352 (modest_vbox_cell_renderer_append):
353 Fix the last commit by doing an extra ref.
355 2007-05-31 Murray Cumming <murrayc@murrayc.com>
357 * src/widgets/modest-hbox-cell-renderer.c:
358 (modest_hbox_cell_renderer_append):
359 * src/widgets/modest-vbox-cell-renderer.c:
360 (modest_vbox_cell_renderer_append):
361 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
362 to fix the build with Maemo Bora.
363 However, there seems to be a remaining crash, probably due to reference
366 2007-05-30 Murray Cumming <murrayc@murrayc.com>
368 * src/modest-tny-account.c:
369 (modest_tny_account_new_for_local_folders):
370 Use hildon_file_system_info_async_new() to get a better name for
371 the memory card account, setting it as the account name.
372 The timing seems to work, but this is probably
373 not the best place to do this. See the TODO comment.
374 * src/maemo/modest-main-window.c: (create_details_widget):
375 * src/widgets/modest-folder-view.c: (text_cell_data):
376 Use the tny account name instead of hardcoding a name.
378 2007-05-30 Christian Kellner <ckellner@openismus.com>
380 * src/modest-search.c: (modest_search):
381 Correctly set part_search_func even if we have already parsed
382 the query and thus a valid OgsTextSearcher object.
384 2007-05-30 Christian Kellner <ckellner@openismus.com>
387 Search and check for libogs.
390 Incooparte the ogs build env.
392 * src/modest-mime-part-search-stream.c:
393 * src/modest-mime-part-search-stream.h:
394 Removed since we do the real searching now in modest-search.c.
396 * src/modest-search.c:
397 * src/modest-search.h:
398 Implement support for ogs. We use that if available and requested
399 and fall back to modest_text_utils_utf8_strcmp (). The search logic
400 should now handle the corner case when the search term is spread
401 across multiple reads.
402 Also the logic in modest_search () was corrected to search all
403 requested fields until one is found.
405 2007-05-30 Murray Cumming <murrayc@murrayc.com>
407 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
410 * src/modest-init.c: Made modest_init_local_folders() take a
411 path and be public so we can iniitialize maildir folders on
414 * src/modest-local-folder-info.h:
415 * src/modest-local-folder-info.c:
416 (modest_local_folder_info_get_maildir_path): Add a path parameter.
418 * src/modest-tny-account.c:
419 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
420 still means the standard local-folders path on the local volume.
422 * src/modest-tny-account-store.c:
423 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
424 signal so we can detect mount/unmount of the MMC1 card, and do an update of
425 all accounts when that happens.
426 (get_server_accounts): If the MMC1 card is mounted, create a store account for
427 this too, so it shows up in the treeview.
429 2007-05-28 Murray Cumming <murrayc@murrayc.com>
431 * src/maemo/modest-maemo-global-settings-dialog.c:
432 (current_connection):
433 * src/widgets/modest-global-settings-dialog.c:
434 (current_connection_default):
435 Use the enum values instead of 0, 1 and -1,
436 to make the code clearer.
438 * src/modest-account-mgr-helpers.c:
439 (modest_account_mgr_get_connection_specific_smtp): Make this code
442 * src/modest-runtime.h:
443 * src/modest-runtime.c:
444 Added modest_runtime_remove_all_send_queues().
445 * src/maemo/modest-main-window.c:
446 (on_account_store_connecting_finished): Recreate the send queues,
447 using the appropriate transport accounts for this new connection.
448 Some futher adapting might be needed if the old send queues are not
449 automatically stopped at this point.
451 * src/modest-tny-account-store.c: (get_server_accounts):
452 Create the connection-specific transport accounts, so that they can
453 be found later by their ID.
455 * src/modest-tny-account.h:
456 * src/modest-tny-account.c:
457 Added modest_tny_account_new_from_server_account_name().
458 modest_tny_account_new_from_server_account(): Do not create the
459 send queues here, because they will be
460 recreated anyway when the connection changes for the first time.
462 2007-05-28 Murray Cumming <murrayc@murrayc.com>
464 * src/modest-local-folder-info.h:
465 * src/modest-local-folder-info.c:
466 (modest_per_account_local_outbox_folder_info_get_maildir_path),
467 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
468 tbox_folder): Take a modest account name instead of a server TnyAccount,
469 so we can have per-modest-account rather than per-transport-account
471 We must make sure that we change or recreate the exisitng send queues
472 when the connection changes for connection-specific transport accounts.
474 * src/modest-tny-account-store.c:
475 (create_per_account_local_outbox_folders): Create outboxed per modest
476 account, not per transport account.
478 * src/modest-tny-account.h:
479 * src/modest-tny-account.c:
480 (modest_tny_account_get_special_folder): For outboxes, get the
481 parent modest account name. The account is ignored for other folders.
482 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
483 modest account name rather than a server TnyAccount.
485 2007-05-25 Murray Cumming <murrayc@murrayc.com>
487 * src/modest-tny-account.c:
488 (modest_tny_account_new_from_server_account):
489 Call modest_runtime_get_send_queue() immediately after creating transport
490 accounts, so that they start trying to send email from the outbox as soon
491 as possible at startup. This is probably what we want.
493 * src/modest-mail-operation.c: (update_account_thread):
494 * src/modest-runtime.c: (modest_runtime_get_send_queue):
495 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
496 * src/modest-tny-send-queue.h:
497 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
498 (modest_ui_actions_on_send):
499 Added comments about how sending works, though it needs some more work.
501 2007-05-25 Murray Cumming <murrayc@murrayc.com>
503 * src/modest-tny-account.c:
504 (modest_tny_account_get_special_folder): Add TODO because this fails when
506 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
507 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
508 Do not try to show this window when there is no active account. The UI
509 specs does not tell us what to do in this case.
511 2007-05-24 Murray Cumming <murrayc@murrayc.com>
515 * src/maemo/Makefile.am:
516 * src/widgets/Makefile.am: Some dist fixes.
518 2007-05-24 Murray Cumming <murrayc@murrayc.com>
520 * src/maemo/modest-connection-specific-smtp-window.c:
521 (on_button_edit): Make the code clearer, to prevent a double free.
523 2007-05-24 Murray Cumming <murrayc@murrayc.com>
525 * src/maemo/modest-account-settings-dialog.c:
526 (modest_account_settings_dialog_set_account_name),
527 Check the connection-specific smtp servers checkbox if there are any.
529 * src/maemo/modest-connection-specific-smtp-edit-window.c:
530 (modest_connection_specific_smtp_edit_window_init):
531 Start with a suitable port number.
533 * src/modest-account-mgr-helpers.h:
534 * src/modest-account-mgr-helpers.c: Added
535 modest_account_mgr_get_has_connection_specific_smtp().
537 (modest_account_mgr_set_connection_specific_smtp),
538 (modest_account_mgr_remove_connection_specific_smtp),
539 (modest_account_mgr_get_has_connection_specific_smtp),
540 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
541 connection-specific smtp server accounts in the account, rather than
542 the server account conf dir.
544 This fixes bug projects.maemo.org bug NB#58263 .
546 * src/modest-tny-account-store.c:
547 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
548 if there are no server accounts yet, to prevent an infinite loop when there
549 are no accounts. Document that one must be called before the other.
551 2007-05-24 Murray Cumming <murrayc@murrayc.com>
553 * src/modest-account-mgr-helpers.c:
554 (modest_account_mgr_get_default_account): Make sure that at least
555 one account is always the default, if there are any enabled accounts.
556 This is just a sanity check that shouldn't be necessary.
558 * src/modest-account-mgr-priv.c:
559 (_modest_account_mgr_account_from_key): Unescape the conf key to
560 get the real account name. For instance, this is an issue if a space
561 was in the account name, which can happen because the account name
562 is generated from the display name.
563 (_modest_account_mgr_get_account_keyname): Always escape the
565 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
566 Unescape the conf keys to get the real account names.
568 For instance, previously the is-default radio button in the accounts
569 list was not checked for any accounts at first. This fixes that,
570 and might fix several similar bugs.
572 2007-05-23 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
575 Removed some debug printfs.
577 2007-05-23 Murray Cumming <murrayc@murrayc.com>
579 Modest on-disk outbox directories are now here, for instance:
580 $HOME/.modest/outboxes/<account-id-1>/outbox
581 $HOME/.modest/outboxes/<account-id-2>/outbox
583 $HOME/.modest/local-folders/outbox
584 so we can have a separate outbox for each account.
585 But they are shown as one outbox in the GtkTreeView, by using a
586 TnyMergeFolder in a ModestTnySimpleFolderStore.
589 * src/modest-tny-simple-folder-store.c:
590 * src/modest-tny-simple-folder-store.h:
591 Added ModestTnySimpleFolderStore, used to contain folders from
592 other folder stores, such as other accounts.
594 * src/modest-tny-outbox-account.h:
595 * src/modest-tny-outbox-account.c:
596 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
597 used for the per-account local outbox folders.
599 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
600 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
601 only use this (internally) now for the non-outbox local folders.
604 * src/modest-init.c: Added modest_init_one_local_folder(), for
605 setting up the directory structure for each local folder.
607 * src/modest-local-folder-info.c:
608 (modest_per_account_local_outbox_folder_info_get_maildir_path),
609 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
611 * src/modest-local-folder-info.h:
612 * src/modest-tny-account-store.c: (on_account_removed),
613 (on_account_changed), (create_per_account_local_outbox_folders),
614 (get_server_accounts), (modest_tny_account_store_get_accounts),
615 (modest_tny_account_store_get_tny_account_by_account),
616 (modest_tny_folder_store_is_virtual_local_folders):
618 * src/modest-tny-account.h:
619 * src/modest-tny-account.c:
620 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
621 to create an on-disk per-account local outbox folder for each
623 (create_per_account_local_outbox_folders): Create a local outbox folder
624 for each transport account.
625 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
626 for all local folders.
628 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
629 instead of using g_object_get/set() directly. It is clearer.
631 (modest_tny_folder_store_get_message_count),
632 (modest_tny_folder_store_get_local_size
633 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
634 because we now use these with non-acount folder stores.
636 (modest_tny_account_get_special_folder),
637 (modest_tny_account_new_from_server_account),
638 (modest_tny_account_new_from_account):
639 (recurse_folders): Adjust to the new outbox system.
641 * src/modest-tny-folder.h:
642 * src/modest-tny-folder.c:
643 (modest_tny_folder_is_local_folder),
644 (modest_tny_folder_get_local_folder_type),
645 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
647 * src/widgets/modest-main-window.h:
648 * src/maemo/modest-main-window.c: (create_details_widget),
649 (modest_main_window_set_contents_style): Show details for any folder store,
652 (modest_tny_folder_get_rules):
653 Remove the const. C does not support constness enough for this.
655 * src/modest-ui-actions.c:
656 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
657 make all outboxes appear as one, in the usual local-folders tree node.
659 (set_active_account_from_tny_account),
660 (modest_ui_actions_on_folder_selection_changed):
661 * src/widgets/modest-folder-view.c: (text_cell_data),
662 (icon_cell_data), (filter_row),
663 (add_account_folders_to_merged_folder),
664 (add_account_folders_to_simple_folder_store), (),
665 (get_cmp_rows_type_pos), (cmp_rows),
666 (modest_folder_view_set_account_id_of_visible_server_account):
667 Adjust to the new outbox system, using generic folder stores and folders
670 2007-05-23 Christian Kellner <ckellner@openismus.com>
672 * src/modest-mail-operation.c:
673 (modest_mail_operation_update_account):
674 Use info->max_size instead of unintialized local var [small
675 build fix]. (Added TODO to review that change since I don't
678 2007-05-23 Marcus Bauer <marcusb@openismus.com>
680 * libmodest-dbus-client/libmodest-dbus-client.c:
681 (libmodest_dbus_client_compose_mail): function added
682 * src/dbus_api/modest-dbus-api.h:
683 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
684 (on_compose_mail): Implementation of the SendAsMail functionality
686 2007-05-22 Murray Cumming <murrayc@murrayc.com>
688 * src/modest-account-mgr.c:
689 (modest_account_mgr_add_server_account): Set the secure-connection
690 conf key for transport accounts as well as store accounts. I don't know
691 why the if was there. For instance, this makes sure that we use SSL
692 for the gmail preset from the easysetup wizard.
694 2007-05-22 Murray Cumming <murrayc@murrayc.com>
696 * src/gnome/modest-main-window.c:
697 (on_account_store_connecting_finished), (connect_signals):
698 * src/maemo/modest-main-window.c:
699 (on_account_store_connecting_finished), (connect_signals),
700 (modest_main_window_new):
701 Handle TnyAccountStore::connecting-finished instead of
702 TnyDevice::connection-changed, because we cannot actually perform
703 operations on accounts until TnyAccountStore has itself responded to
704 the TnyDevice::connection-changed signal. This prevents a GError from
706 Do not try to update at startup, because we (at least on scratchbox)
707 already do an update at startup when the device goes online.
708 This prevents a GError from tinymail.
709 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
710 Added TODO about stopping simultaneous operations.
712 2007-05-21 Murray Cumming <murrayc@murrayc.com>
714 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
715 * src/modest-mail-operation-queue.c:
716 (modest_mail_operation_queue_remove):
717 * src/modest-tny-account-store.c: When GErrors happen, give more clues
718 about where they happened.
720 2007-05-21 Murray Cumming <murrayc@murrayc.com>
722 * src/modest-ui-actions.c:
723 (modest_ui_actions_on_password_requested): Make sure that the remember
724 output parameter is always TRUE.
726 2007-05-21 Murray Cumming <murrayc@murrayc.com>
728 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
729 Show a OK/Cancel dialog if the error is a question, though we still do not
730 know anything more about what we are asking the user.
731 * src/widgets/modest-folder-view.c: (on_drag_data_received):
732 Fix an uninitialized variable (helper). This is a logic error, however.
734 2007-05-21 Christian Kellner <ckellner@openismus.com>
736 * src/modest-search.h:
737 Correct bit shifting in the ModestSearchFlags enum.
739 2007-05-21 Murray Cumming <murrayc@murrayc.com>
741 * src/modest-tny-account.c:
742 (modest_tny_account_new_from_server_account): Do not use the lsub and
743 check-all hard-coded IMAP options when using POP.
745 2007-05-21 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-tny-account.c:
748 (modest_tny_account_new_from_server_account):
749 Use NULL for the secure-auth method for POP when Password auth has been
750 specified by the user, as we already do for IMAP. "auth=Login" causes
751 an error from camel or the server.
753 2007-05-17 Murray Cumming <murrayc@murrayc.com>
755 * src/maemo/modest-account-settings-dialog.c:
756 (create_page_account_details),
757 (modest_account_settings_dialog_set_account_name):
758 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
759 for the leave-on-server checkbox, rathr than just the checkbox, when
760 the protocol is not POP.
762 2007-05-17 Murray Cumming <murrayc@murrayc.com>
764 * src/widgets/modest-account-view.c:
765 * src/widgets/modest-account-view.h:
766 Added modest_account_view_select_account() which will be useful later
767 to asynchronously re-select the edited account.
769 2007-05-17 Murray Cumming <murrayc@murrayc.com>
771 * src/maemo/modest-account-settings-dialog.c:
772 (modest_account_settings_dialog_set_account_name):
773 Automatically choose the port numbers based on the secure authentication
774 methods, if they have not been chosen before.
775 This fixes projects.maemo.org bug NB#56273 .
777 2007-05-17 Murray Cumming <murrayc@murrayc.com>
779 * src/maemo/modest-main-window-ui.h:
780 * src/modest-ui-actions.c:
781 * src/modest-ui-actions.h:
782 Connect the Tools/SMTP Servers menu item to
783 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
784 SMTP servers dialog, as in the UI specification and saves changes when it
785 is closed. This fixed projects.maemo.org bug NB#56305 .
787 2007-05-17 Murray Cumming <murrayc@murrayc.com>
789 * src/maemo/modest-connection-specific-smtp-window.c:
790 (modest_connection_specific_smtp_window_init):
791 Use gtk_window_set_default_size() to make this window big enough, so
792 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
794 2007-05-17 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/modest-connection-specific-smtp-edit-window.h:
797 * src/maemo/modest-connection-specific-smtp-edit-window.c:
798 (modest_connection_specific_smtp_edit_window_init),
799 Do not try to connect to a combobox signal before the combobox exists.
800 This fixes the cras in projects.maemo.org bug NB#56288 .
801 (modest_connection_specific_smtp_edit_window_get_settings):
802 Remove the server_account_name parameter which was being checked for NULL
803 though it was not used.
805 * src/maemo/modest-connection-specific-smtp-window.c:
806 (modest_connection_specific_smtp_window_fill_with_connections),
807 (on_button_edit), (modest_connection_specific_smtp_window_init):
808 Correct the number of treemodel columns to prevent a warning.
809 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
810 libconic does not work.
812 2007-05-16 Murray Cumming <murrayc@murrayc.com>
814 * src/modest-tny-account.c:
815 (modest_tny_account_new_from_server_account):
816 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
817 SMTP when "None" was chosen by the user. However, with my SMTP server that
818 does not support ANONYMOUS, the emails do not leave the Outbox and I see
821 2007-05-16 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
824 to explain the memory management issue with the ID in the ModestPair.
826 * src/gnome/modest-account-assistant.c: (add_receiving_page),
827 (add_sending_page), (modest_account_assistant_finalize):
828 * src/gnome/modest-gnome-global-settings-dialog.c:
829 (create_updating_page), (create_composing_page):
830 * src/gnome/modest-msg-edit-window.c: (get_transports),
831 (init_window), (modest_msg_edit_window_finalize),
832 (modest_msg_edit_window_get_msg_data):
833 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
834 * src/gnome/modest-transport-widget.c:
835 (modest_transport_widget_finalize), (smtp_configuration):
836 * src/maemo/modest-maemo-global-settings-dialog.c:
837 (create_updating_page), (create_composing_page):
838 * src/maemo/modest-msg-edit-window.c: (get_transports),
839 (init_window), (modest_msg_edit_window_finalize),
840 (modest_msg_edit_window_get_msg_data),
841 (modest_msg_edit_window_free_msg_data):
842 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
843 (modest_store_widget_finalize):
844 * src/maemo/modest-transport-widget.c:
845 (modest_transport_widget_finalize), (smtp_configuration):
846 * src/modest-main.c: (send_mail):
847 * src/widgets/modest-combo-box.h:
848 * src/widgets/modest-global-settings-dialog-priv.h:
849 * src/widgets/modest-global-settings-dialog.c:
850 (modest_global_settings_dialog_finalize):
851 * src/widgets/modest-msg-edit-window.h:
852 Whenever using modest_combo_box_new(), keep the ModestPairList alive
853 as long as the combo box, to prevent use of freed memory for the ID.
855 2007-05-15 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
858 get_accounts(), to make this clearer. Do not check for the enabled gconf
859 key, because we do not use this for server accounts (at least, not yet).
860 This allows us to send email again.
862 2007-05-15 Murray Cumming <murrayc@murrayc.com>
864 * src/maemo/modest-platform.c:
865 (on_modest_conf_update_interval_changed), (modest_platform_init):
866 Only respond to this particular key change. All these strcmp()s cannot be
869 2007-05-15 Murray Cumming <murrayc@murrayc.com>
871 * src/maemo/modest-maemo-global-settings-dialog.c:
872 (current_connection): Prevent a crash in scratchbox when
873 ny_maemo_conic_device_get_current_iap_id() returns NULL.
874 * src/maemo/modest-platform.c:
875 (on_modest_conf_update_interval_changed), (modest_platform_init):
876 Get the update interval from gconf and reset it when the gconf key changes.
878 2007-05-15 Murray Cumming <murrayc@murrayc.com>
880 * src/modest-protocol-info.c:
881 * src/modest-protocol-info.h: Adde enum-specific get functions,
882 instead of using a ModestProtocolType enum parameter.
884 * src/gnome/modest-account-assistant.c:
885 * src/gnome/modest-store-widget.c:
886 * src/gnome/modest-store-widget.h:
887 * src/gnome/modest-transport-widget.c:
888 * src/gnome/modest-transport-widget.h:
889 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
890 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
891 * src/maemo/easysetup/modest-easysetup-wizard.c:
892 * src/maemo/modest-account-settings-dialog.c:
893 * src/maemo/modest-account-settings-dialog.h:
894 * src/maemo/modest-store-widget.c:
895 * src/maemo/modest-store-widget.h:
896 * src/maemo/modest-transport-widget.c:
897 * src/maemo/modest-transport-widget.h:
898 * src/modest-account-mgr-helpers.c:
899 * src/modest-account-mgr-helpers.h:
900 * src/modest-account-mgr.c:
901 * src/modest-account-mgr.h:
902 * src/modest-tny-account.c:
903 * src/modest-tny-folder.c:
904 * src/widgets/modest-account-view.c:
905 * src/widgets/modest-retrieve-combo-box.c:
906 * src/widgets/modest-retrieve-combo-box.h:
907 * src/widgets/modest-secureauth-combo-box.c:
908 * src/widgets/modest-serversecurity-combo-box.c:
909 * src/widgets/modest-serversecurity-combo-box.h:
910 * tests/check_account-mgr.c:
911 Use the specific functions, and use the re-renamed enum values for GNOME too.
913 2007-05-15 Murray Cumming <murrayc@murrayc.com>
916 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
917 so we can get the second based on the first.
919 * src/maemo/modest-account-settings-dialog.h:
920 * src/maemo/modest-account-settings-dialog.c:
921 Added get_supported_secure_authentication_methods(), though it is mostly
922 commented-out for now until the necessary API is committed to tinymail.
923 (modest_account_settings_dialog_set_account_name),
924 (save_configuration): Request the supported authentication methods from the
925 server, so we can choose a working method.
927 * src/modest-tny-account-store.h:
928 * src/modest-tny-account-store.c:
929 (modest_tny_account_store_get_session): Rename from
930 tny_account_store_get_session().
932 2007-05-14 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-protocol-info.h: Split the ModestProtocol enum
935 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
936 There was no need to have these unrelated values in one enum.
938 * src/: many files: Adapted to changed enum. This makes the code a bit
939 clearer, and the compiler could catch some errors.
941 2007-05-14 Murray Cumming <murrayc@murrayc.com>
943 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
944 Show the detailed internal camel error message when an error happens
945 during the configuration, so that our testers can give us more clues.
946 For instance, in projects.maemo.org bug NB#56910 .
948 2007-05-14 Murray Cumming <murrayc@murrayc.com>
950 * src/modest-tny-account.c:
951 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
952 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
954 2007-05-14 Murray Cumming <murrayc@murrayc.com>
956 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
957 * src/maemo/modest-account-settings-dialog.c:
958 (modest_account_settings_dialog_set_account_name),
959 (save_configuration): For the incoming secure authentication checkbox,
960 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
961 the UI specification. PLAIN does not seem to be supported for most IMAP
962 servers anyway, and I am not sure what it would mean.
963 However, we probably need to discover which of the secure-authentication
964 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
965 * src/modest-account-mgr-helpers.c:
966 (modest_account_mgr_get_server_account_data):
968 * src/modest-tny-account.c:
969 (modest_tny_account_new_from_server_account):
970 Use tny_account_set_mech() to set secure-authentication methods,
971 with some special-casing for IMAP, based on my observations of how
974 * src/modest-account-mgr-helpers.h:
975 * src/modest-account-mgr.c:
976 * src/modest-defs.h: Comment that the URI is only used for local folders.
978 2007-05-11 Murray Cumming <murrayc@murrayc.com>
980 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
981 parameter const, just to be neat.
982 * src/modest-text-utils.c: (modest_text_utils_inline):
983 End g_strconcat() with NULL, as its documentation says. This is almost
984 certainly the cause of my crash at startup on the device. Interestingly,
985 valgrind doesn't tell us about these errors.
987 2007-05-11 Murray Cumming <murrayc@murrayc.com>
989 * scripts/build-packages: Added more precise comments about how to use
990 this script, though I still get this error:
991 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
992 error building tinymail
994 2007-05-11 Murray Cumming <murrayc@murrayc.com>
996 * src/maemo/modest-main-window.c: (on_account_update):
997 Very slight cleanup, hoping to make it simpler to discover what causes
998 a crash here sometimes.
1000 * src/modest-tny-account.c:
1001 (modest_tny_account_new_from_server_account): Set the port. Added
1002 comments about the options and a TODO comment because I need to find out
1003 how to specify the secure authentication method.
1005 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1007 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1008 changed CFlags paths form modest to libmodest
1010 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1012 * src/modest-account-mgr-helpers.c:
1013 (modest_account_mgr_get_server_account_data),
1014 (modest_account_mgr_free_server_account_data):
1015 * src/modest-account-mgr-helpers.h:
1016 * src/modest-account-mgr.c:
1017 (modest_account_mgr_add_server_account):
1018 * src/modest-defs.h:
1019 * src/modest-tny-account.c:
1020 (modest_tny_account_new_from_server_account):
1021 Determine the options for tny_camel_account_add_option() here,
1022 based on the settings, rather than storing them directly in gconf.
1024 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1026 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1027 Show a more friendly error dialog now that we expect (from the tinymail
1028 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1030 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1032 * src/maemo/modest-main-window.c: (on_account_update): Check that
1033 account_name is not NULL, to prevent a crash at startup that I am
1034 seeing on the N800. I do wonder why it is NULL.
1036 * src/maemo/easysetup/modest-easysetup-wizard.c:
1037 (create_page_user_details):
1038 * src/maemo/modest-account-settings-dialog.c:
1039 (create_page_user_details), (create_page_outgoing):
1040 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1041 (modest_connection_specific_smtp_edit_window_init):
1042 * src/modest-ui-actions.c:
1043 (modest_ui_actions_on_password_requested):
1044 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1045 might do something useful with the on-screen keyboard.
1047 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1049 * src/maemo/modest-main-window.c: (on_account_update):
1050 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1051 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1053 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1055 * src/modest-tny-account-store.c: (on_account_changed):
1056 Correct the signature of this signal handler.
1058 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1060 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1061 Show a HildonNote instead of a GtkDialog for Maemo.
1063 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1065 * src/widgets/modest-account-view.h:
1066 * src/widgets/modest-account-view.c: (on_account_changed),
1067 (on_account_removed). Added a boolean flag, set/unset by
1068 modest_account_view_block_conf_updates(),
1069 modest_account_view_unblock_conf_updates() to prevent unnecessary
1070 updates, but this is not very useful because the gconf notifications are
1071 so delays (maybe only on Maemo Bora).
1072 So auto-updating is turned off, and these functions do an explicit
1073 update when necessary.
1074 However, something else is still doing too much work when adding/removing
1075 accounts, probably in another part of the application.
1077 * src/maemo/modest-account-view-window.c:
1078 (on_delete_button_clicked), (on_edit_button_clicked),
1079 (on_new_button_clicked): Use the new functions.
1081 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1083 * src/modest-account-mgr-helpers.c:
1084 (modest_account_mgr_set_first_account_as_default):
1085 Sort the list of names alphabetically-by-title, so we choose the first one
1087 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1088 alphabetically by the title.
1090 This fixes projects.maemo.org bug NB#56418 .
1092 * src/modest-account-mgr-priv.c:
1093 (_modest_account_mgr_account_from_key):
1094 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1095 avoid a valgrind error, and possible random behaviour.
1097 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1099 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1100 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1101 tinymail documentation to say that this can be expected.
1102 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1103 pretty, and should not happen, but I would prefer to know when it does.
1105 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1107 * configure.ac: When using the older hildon version, probably on Bora,
1108 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1110 * src/widgets/modest-attachment-view.c:
1111 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1114 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1116 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1117 Implemented the prototype. Can be tested with
1118 tests/dbus_api/test_open_message:
1120 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1122 * src/modest-tny-account-store.c:
1123 (modest_tny_account_store_instance_init), (get_password):
1124 * src/modest-ui-actions.c:
1125 (modest_ui_actions_on_password_requested):
1126 Do not store the password in gconf, because this function is called
1127 for non-remembered passwords. Actually use the cached (in the hash map)
1128 password instead of releasing it.
1129 The password will now not be remembered if it is asked via the protected
1130 password dialog, as per the UI spec.
1132 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1134 * src/modest-defs.h:
1135 * src/modest-account-mgr-helpers.h:
1136 * src/modest-account-mgr-helpers.c:
1137 Added modest_server_account_get_username_has_succeeded(),
1138 modest_server_account_set_username_has_succeeded().
1139 (modest_server_account_set_username),
1140 Reset the has-succeeded flag if the username changes.
1142 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1143 * src/maemo/modest-connection-specific-smtp-window.c:
1144 (modest_connection_specific_smtp_window_save_server_accounts):
1145 Use modest_server_account_set_username() instead of using
1146 modest_conf_set_string() directly, so that the has-succeeded flag is always
1149 * src/modest-ui-actions.c:
1150 (modest_ui_actions_on_password_requested): Dim the username entry if
1151 the username has ever worked, as per the UI spec.
1153 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1155 * src/modest-tny-account-store.c: (get_password):
1156 * src/modest-ui-actions.c:
1157 (modest_ui_actions_on_password_requested):
1158 Allow the username to be changed too, though there is more work to
1159 be done on exactly how this behaves.
1161 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-account-mgr-helpers.h:
1164 * src/modest-account-mgr-helpers.c:
1165 Added modest_account_mgr_get_display_name(),
1166 modest_server_account_get_username(),
1167 modest_server_account_set_username(),
1168 modest_server_account_set_password(),
1169 modest_server_account_get_hostname() functions so we do not need to
1170 use the conf API directly.
1172 * src/maemo/modest-main-window.c: (connect_signals):
1173 Actually connect ot the ModestAccountStore::request-password signal,
1174 so that we show the dialog when the password is requested by Tinymail,
1175 for isntance if it is empty.
1177 * src/modest-marshal.list:
1178 * src/modest-tny-account-store.c:
1179 (modest_tny_account_store_class_init), (get_password),
1180 (modest_tny_account_store_alert):
1181 * src/modest-tny-account-store.h:
1182 * src/modest-ui-actions.h:
1183 * src/modest-ui-actions.c:
1184 (modest_ui_actions_on_password_requested):
1185 Change the signal parameters, so it is obvious that we are providing
1186 the non human-readable server name, and receiving both the username
1187 and password, though changing of the username is not yet implemented.
1188 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1189 for the GNOME version.
1191 This should fix the projects.maemo.org bug NB#56209, though it does not
1192 work on Bora, because the gconf_client_get() for the password fails
1193 immediately after we save it with gconf_client_set().
1195 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1198 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1199 caused an undefined symbol error:
1200 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1202 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1204 * src/modest-tny-account-store.c:
1205 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1206 using a GError instead of a string message, so we can translate it in
1209 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1211 * src/maemo/modest-address-book.c:
1212 (modest_address_book_check_names):
1213 * src/maemo/modest-msg-view-window.c:
1214 (modest_msg_view_window_clipboard_owner_change):
1215 * src/modest-init.c: (modest_init_init_ui):
1216 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1217 (update_folders_cb), (modest_mail_operation_update_account):
1218 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1219 (modest_ui_actions_on_msg_attachment_clicked),
1220 (modest_ui_actions_on_msg_recpt_activated):
1221 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1222 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1223 (modest_msg_view_search_next):
1224 * src/widgets/modest-recpt-editor.c:
1225 (modest_recpt_editor_on_button_release_event),
1226 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1227 g_message(). At this point we should only be seeing interesting errors on
1228 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1230 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1232 (modest_wizard_dialog_force_title_update):
1233 * src/maemo/easysetup/modest-wizard-dialog.h:
1234 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1235 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1236 can update the title when appropriate. Otherwise the title is wrong if the
1237 pages are added after adding the notebook to the dialog.
1238 This must be a problem in HildonWizardDialog too.
1239 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1241 * src/maemo/easysetup/modest-easysetup-wizard.c:
1242 (create_subsequent_customsetup_pages),
1243 (create_subsequent_easysetup_pages):
1244 Call modest_wizard_dialog_force_title_update() so that the title is
1245 correct even with GTK+ < 2.10.
1246 This fixes projects.maemo.org bug NB#56145 .
1248 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1250 * src/maemo/modest-platform.c:
1251 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1252 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1255 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1257 * src/widgets/modest-window.h:
1258 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1259 and modest_window_save_state(), which invokes it.
1261 * src/widgets/modest-window-mgr.h:
1262 * src/widgets/modest-window-mgr.c:
1263 Added modest_window_mgr_save_state_for_all_windows(), which calls
1264 the save_state vfunc on all registered windows, if implemented.
1266 * src/gnome/modest-msg-edit-window.c:
1267 * src/gnome/modest-msg-view-window.c:
1268 * src/maemo/modest-msg-edit-window.c:
1269 * src/maemo/modest-msg-view-window.c:
1270 * src/maemo/modest-main-window.c:
1271 Specify the existing save_settings functions as implementations of
1272 ModestWindow::save_state_func().
1274 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1275 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1276 enabling hibernation, for instance.
1278 We may need to do the same thing for restoring settings.
1281 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1283 * src/widgets/modest-window-mgr.c:
1284 * src/widgets/modest-window-mgr.h:
1285 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1286 modest_window_mgr_get_hibernation_is_prevented().
1288 * src/maemo/modest-main-window.c:
1289 (on_hildon_program_is_topmost_notify): Prevent hibernation
1290 (possible when the application goes to the background in the WM),
1291 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1293 * src/maemo/easysetup/modest-easysetup-wizard.c:
1294 (modest_easysetup_wizard_dialog_init):
1295 * src/maemo/modest-account-settings-dialog.c:
1296 (modest_account_settings_dialog_init):
1297 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1298 (modest_connection_specific_smtp_edit_window_init):
1299 * src/maemo/modest-connection-specific-smtp-window.c:
1300 (modest_connection_specific_smtp_window_init):
1301 * src/maemo/modest-signature-editor-dialog.c:
1302 (modest_signature_editor_dialog_init):
1303 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1304 prevent hibernation while any of these account settings dialogs are open.
1306 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1308 * src/maemo/Makefile.am:
1309 * src/maemo/modest-osso-state-saving.c:
1310 * src/maemo/modest-osso-state-saving.h: Added
1311 modest_osso_load_state() and modest_osso_save_state() though they do
1312 nothing now. They should iterate through all the open windows and load/save
1314 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1315 save state when closing.
1317 * src/maemo/modest-main-window.c:
1318 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1319 Add a notification handler for the HildonProgram::is-topmost property,
1320 so we can allow hibernation when the application goes into the background.
1321 But we still need to detect when the accounts setup windows are open so
1322 we can stop hibernation when they are open.
1323 To do this, I also added the main window the HildonProgram. This might have
1324 other side-effects/benefits, and should maybe be done for other windows.
1326 * src/maemo/modest-osso-autosave-callbacks.h:
1327 * src/maemo/modest-osso-autosave-callbacks.c:
1328 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1329 though it does not do anything yet, and we might never need this to do
1330 anything. For instance, we already save drafts.
1332 * src/maemo/modest-platform.c: (modest_platform_init):
1333 Specify the libosso auto-save callback.
1335 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1337 * src/maemo/modest-platform.c:
1338 (modest_platform_set_update_interval):
1339 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1340 aparently stays valid between application instances, so we can use this
1341 to remove and reset it later. According to a maemo-developers email from
1344 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1346 * configure.ac: Depend on libalarm for Maemo.
1348 * src/dbus_api/modest-dbus-api.h:
1349 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1350 (on_send_receive), (modest_dbus_req_handler):
1351 Handle a SEND_RECEIVE D-Bus method.
1353 * libmodest-dbus-client/libmodest-dbus-client.c:
1354 (libmodest_dbus_client_send_and_receive):
1355 * libmodest-dbus-client/libmodest-dbus-client.h:
1356 Add C convenience functions for calling the new D-Bus method.
1358 * src/modest-platform.h:
1359 * src/gnome/modest-platform.c:
1360 * src/maemo/modest-platform.c:
1361 Added modest_platform_set_update_interval(), which uses the
1362 alarmd API on Maemo.
1363 (modest_platform_init),
1364 Call modest_platform_set_update_interval(), using a hard-coded
1365 interval for now (until the global settings dialog is implemented),
1366 though I am not sure that this makes sense yet.
1368 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1370 * src/dbus_api/modest-dbus-callbacks.c:
1371 (modest_osso_cb_hw_state_handler):
1372 * src/dbus_api/modest-dbus-callbacks.h:
1373 * src/maemo/modest-platform.c: (modest_platform_init):
1374 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1375 in case this has some effect on the ability for Maemo to ping the
1378 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1380 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1381 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1382 warning. It is probably a logic error, but I need to fix the build.
1384 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1386 * src/modest-account-mgr.h:
1387 * src/modest-account-mgr.c:
1388 (modest_account_mgr_account_names): Add a gboolean enabled_only
1389 parameter, so we can get lists of onlt the enabled accounts.
1391 (modest_account_mgr_add_account),,
1392 (modest_account_mgr_account_with_display_name_exists):
1393 * src/maemo/modest-msg-edit-window.c: (get_transports):
1394 * src/modest-account-mgr-helpers.c:
1395 (modest_account_mgr_set_first_account_as_default):
1396 * src/modest-init.c: (init_default_account_maybe):
1397 * src/modest-tny-account-store.c: (get_accounts):
1398 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1399 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1400 * tests/check_account-mgr.c: (START_TEST):
1401 Provide the extra parameter, as appropriate.
1403 * src/widgets/modest-account-view.c: (update_account_view):
1404 Do not show disabled accounts (meaning that there is no way to
1405 enable/disable accounts in the UI (the feature is not in our UI
1406 specification), so we can use this internally only to mark unfinished
1407 or temporary account data.
1409 * src/maemo/easysetup/modest-easysetup-wizard.c:
1410 (create_account): Add boolean enable parameter, so we can specify FALSE
1411 to create the temporary account.
1412 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1413 (on_before_next): When finishing, when there is a temporary account, just
1415 Also, use a timeout to delay the showing of the dialog until gconf is likely
1416 to return correct information, due to a maemo gconf bug that is fixed in
1417 osso 1.1, but not yet in Bora.
1418 However, the dialog stays on screen after it is destroyed.
1420 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1421 for invalid data when cancelling. Use a hildon note instead of a dialog
1422 to complain about invalid data. Do not show the account-saved note if the
1423 account is disabled (a temporary account that will not really be saved for use
1426 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1428 * src/modest-account-mgr-helpers.h:
1429 * src/modest-account-mgr-helpers.c:
1430 Added modest_account_mgr_unset_default_account(),
1431 Added modest_account_mgr_set_first_account_as_default().
1433 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1434 If it was the default account, unset the default account name.
1436 * src/maemo/modest-account-view-window.c:
1437 (on_delete_button_clicked): If it was the default account,
1438 set the first remaining account as the default instead.
1440 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1441 a NULL account or a NULL default account, to prevent a crash. This should
1442 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1445 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1447 * src/widgets/modest-recpt-editor.c:
1448 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1449 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1450 TODO comment for this. This fixes the build.
1452 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1453 be the best place for it. This will in future update all auto-update accounts,
1454 rather than just the current/default account, when that gconf key exists.
1455 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1456 if there are no accounts, before calling do_send_receive().
1457 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1459 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1460 * src/maemo/modest-main-window-ui.h:
1461 * src/maemo/modest-main-window.c: (on_connection_changed),
1462 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1463 directly, becaue the signal handler does more.
1465 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-account-mgr-helpers.c:
1468 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1469 for the case that the account does not exist.
1471 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1472 (equivalent to the modest account name) rather than the tinymail account name
1473 (equivalent to the modest account title - human readable) to get the account data.
1474 Check for null account data to prevent the crash, and add a TODO comment saying that
1475 this needs fixing because it is using the server account name instead of the account name.
1477 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1479 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1480 * src/maemo/modest-account-settings-dialog.c: (show_error),
1482 Use hildon_note_new_information() for informative and error messages,
1483 which seems to be expected for Maemo applications (no documentation that I know of
1484 says this). I am surprised that there is no distinction between info and error
1487 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1490 it is easy to find where this is used.
1492 * src/maemo/easysetup/modest-easysetup-wizard.c:
1493 (create_page_welcome), (create_page_account_details),
1494 (create_page_user_details), (create_page_complete_easysetup),
1495 (create_page_custom_incoming), (create_page_custom_outgoing),
1496 (create_page_complete_custom):
1497 * src/maemo/modest-account-settings-dialog.c:
1498 (create_page_account_details), (create_page_user_details),
1499 (create_page_incoming), (create_page_outgoing):
1500 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1501 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1502 (modest_connection_specific_smtp_edit_window_init):
1503 * src/maemo/modest-connection-specific-smtp-window.c:
1504 (modest_connection_specific_smtp_window_init):
1505 * src/maemo/modest-signature-editor-dialog.c:
1506 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1507 and scrolling policy as per the Email Application Layout Guide, if I have
1510 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1512 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1513 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1514 which were empty, because these vfuncs have been removed from TnyAccountStore.
1515 This fixes the build.
1517 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1519 * src/maemo/modest-main-window.c:
1520 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1521 showing/hiding it. Added TODO because it probably should not be NULL.
1522 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1523 because unnecessary g_warnings() make degugging difficult.
1525 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1527 * src/maemo/modest-msg-edit-window.c:
1528 (modest_msg_edit_window_select_color),
1529 (modest_msg_edit_window_select_background_color): 2 const corrections and
1530 moving 2 #endifs before closing brackets, to fix the build.
1532 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1534 * src/maemo/easysetup/modest-easysetup-wizard.h:
1535 * src/maemo/easysetup/modest-easysetup-wizard.c:
1536 (modest_easysetup_wizard_dialog_finalize),
1537 (on_button_edit_advanced_settings), (create_page_complete_custom),
1538 (on_response), (create_account):
1539 Implement the Advanced Settings edit button, by saving the account information,
1540 for the Advanded Settings dialog to use directly from gconf, and removing it
1541 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1542 Bug #5533 in the projects.maemo.org bugzilla.
1544 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1546 * src/maemo/modest-msg-view-window.c:
1547 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1548 when opening a message window.
1550 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/easysetup/modest-easysetup-wizard.c:
1553 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1556 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1557 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1558 gconf settings. I probably added more checks than necessary, but that is safer.
1560 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1561 variable to fix the build, but this seems to be used when it is still NULL.
1563 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-platform.h:
1566 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1567 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1568 * src/modest-main.c: Implement this function so we can avoid using
1569 maemo-specific API from cross-platform code.
1571 * src/modest-tny-account-store.c:
1572 (get_smtp_specific_transport_account_for_open_connection):
1573 * src/modest-ui-actions.c: (check_for_connection),
1574 (modest_ui_actions_on_item_not_found):
1575 Use modest_platform_connect_and_wait() and put #idefs around other
1576 maemo-specific code, because only maemo currently has a way to
1577 identify connection names.
1579 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1581 * src/modest-tny-account-store.h:
1582 * src/modest-tny-account-store.c:
1583 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1584 the connection-specific SMTP server settings in the configuration.
1586 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1588 * src/maemo/modest-main-window.c: (on_connection_changed),
1590 * src/modest-main.c: (main), (start_ui), (send_mail):
1591 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1592 that is what is intended.
1594 * src/modest-ui-actions.c: (action_send), (action_receive),
1595 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1596 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1597 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1598 SMTP server is used when it is specified.
1600 (modest_ui_actions_on_send_receive):
1601 Check that a connection is open before proceeding.
1602 Receive and then send, instead of vice-versa, as per the specification.
1604 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-mail-operation.c:
1607 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1608 though I guess it should be something other than NULL.
1610 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1612 * src/maemo/easysetup/modest-easysetup-wizard.c:
1613 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1614 combo twice, to avoid an g_warning and to make it visible again.
1615 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1616 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1617 (already intended) dereference when detaching, because we then recreate the menu.
1618 But I am not sure why the warning was happening, and it is possible that this is a memory
1621 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1623 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1624 and uri_parse_mailto() utility functions.
1625 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1627 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1629 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1631 * src/dbus_api/modest-dbus-api.h:
1632 * src/dbus_api/modest-dbus-callbacks.c:
1633 Use an idle callback to execute the modest code in the application's own thread.
1634 Remove the helloworld example method.
1635 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1636 parsed, and the open-message method is not implemented because this is not yet implemented in
1638 * libmodest-dbus-client/libmodest-dbus-client.c:
1639 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1640 (libmodest_dbus_client_open_message):
1641 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1643 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1644 body without crashing.
1646 * tests/dbus_api/Makefile.am:
1647 * tests/dbus_api/test_mail_to.c:
1648 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1650 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1652 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1653 Added file to fix the build. Sorry.
1655 * src/dbus_api/Makefile.am:
1656 * src/dbus_api/modest-dbus-api.h:
1657 * src/dbus_api/modest-dbus-callbacks.h:
1658 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1659 (modest_dbus_req_handler):
1660 Put constants in a separate header so it can be reused by the
1661 client library, without duplication
1663 * libmodest-dbus-client/Makefile.am:
1664 * libmodest-dbus-client/libmodest-dbus-client.c:
1665 (libmodest_dbus_client_call_helloworld),
1666 (libmodfest_dbus_client_send_mail),
1667 (libmodfest_dbus_client_mailto),
1668 (libmodfest_dbus_client_open_message):
1669 * libmodest-dbus-client/libmodest-dbus-client.h:
1670 (Partly) Implement a send_mail D-Bus method.
1672 * tests/dbus_api/Makefile.am:
1673 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1674 the send_email D-Bus method.
1676 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1680 * libmodest-dbus-client/Makefile.am:
1681 * libmodest-dbus-client/libmodest-dbus-client.c:
1682 * libmodest-dbus-client/libmodest-dbus-client.h:
1683 * tests/dbus_api/Makefile.am:
1684 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1685 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1687 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1689 * src/maemo/easysetup/modest-easysetup-wizard.c:
1690 (create_page_account_details):
1691 * src/maemo/modest-account-settings-dialog.c:
1692 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1693 widgets, because this might not be the default in future versions of the Maemo GTK+.
1694 However, I can not not get capitalization to work even in a simple test case.
1696 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1698 * src/maemo/easysetup/modest-easysetup-wizard.c:
1699 (create_page_custom_incoming), (create_page_custom_outgoing):
1700 * src/maemo/modest-account-settings-dialog.c:
1701 (create_page_account_details), (create_page_incoming),
1702 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1703 instead of using gtk_check_button_with_label(), so they are aligned like the other
1704 widgets, as per the UI spec.
1706 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1708 * src/maemo/easysetup/modest-easysetup-wizard.c:
1709 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1710 * src/widgets/modest-validating-entry.c:
1711 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1712 Modest prefix instead of an EasySetup prefix.
1714 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1716 * src/widgets/modest-validating-entry.h:
1717 * src/widgets/modest-validating-entry.c: (on_insert_text),
1718 Added easysetup_validating_entry_set_max_func(), used to set a callback
1719 to call when the max number of characters is reached. GtkEntry has a max-length
1720 already but is silent about it.
1722 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1723 (create_page_account_details), (create_page_user_details),
1725 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1726 (create_page_account_details), (create_page_user_details),
1727 (create_page_outgoing):
1728 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1729 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1730 the UI spec, when the user tries to enter more than the max number of characters.
1732 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1734 * src/maemo/easysetup/modest-easysetup-wizard.c:
1735 (create_page_user_details), (create_page_custom_incoming),
1736 (create_page_custom_outgoing):
1737 * src/maemo/modest-account-settings-dialog.c:
1738 (create_page_user_details), (create_page_incoming),
1739 (create_page_outgoing):
1740 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1741 (modest_connection_specific_smtp_edit_window_init):
1742 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1743 not appropriate. Bad Maemo-specific defaults!.
1745 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1747 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1748 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1749 (modest_signature_editor_dialog_set_settings):
1750 Disable the label and textview when the checkbox is disabled, and use the
1751 specified (UI spec) default signature text.
1753 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1755 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1756 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1758 * src/modest-defs.h:
1759 * src/modest-account-mgr-helpers.h:
1760 * src/modest-account-mgr-helpers.c:
1761 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1763 * src/maemo/Makefile.am:
1764 * src/maemo/modest-signature-editor-dialog.c:
1765 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1768 * src/maemo/modest-account-settings-dialog.h:
1769 * src/maemo/modest-account-settings-dialog.c:
1770 (modest_account_settings_dialog_finalize), (on_button_signature),
1771 (save_configuration): Use the new dialog when the Edit button is pressed, and
1772 save the changes if necessary, as per the UI spec.
1774 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1776 * src/maemo/Makefile.am:
1777 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1778 based on maemo-develoers email from Dirk.
1780 * src/maemo/easysetup/modest-easysetup-wizard.c:
1781 (create_page_welcome), (create_page_account_details),
1782 (create_page_user_details), (create_page_complete_easysetup),
1783 (create_page_custom_incoming), (create_page_custom_outgoing),
1784 (create_page_complete_custom),
1785 (modest_easysetup_wizard_dialog_init):
1786 * src/maemo/modest-account-settings-dialog.c:
1787 (create_page_account_details), (create_page_user_details),
1788 (create_page_incoming), (create_page_outgoing),
1789 (modest_account_settings_dialog_init):
1790 * src/maemo/modest-connection-specific-smtp-window.c:
1791 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1793 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1795 * src/maemo/easysetup/modest-easysetup-wizard.c:
1796 (create_page_account_details), (create_page_custom_outgoing),
1797 (create_page_complete_custom):
1798 * src/maemo/modest-account-settings-dialog.c:
1799 (create_page_user_details), (create_page_incoming),
1800 (create_page_outgoing):
1801 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1802 (modest_connection_specific_smtp_edit_window_init):
1803 Use the correct (UI spec) port min/max, and use horizontal separators,
1806 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1808 * src/maemo/easysetup/modest-easysetup-wizard.c:
1809 (set_default_custom_servernames):
1810 * src/maemo/modest-account-settings-dialog.c:
1811 (create_page_incoming), (on_combo_outgoing_security_changed),
1812 (on_combo_incoming_security_changed), (create_page_outgoing),
1813 (modest_account_settings_dialog_set_account_name),
1814 (save_configuration):
1815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1816 (on_combo_security_changed),
1817 (modest_connection_specific_smtp_edit_window_init),
1818 (modest_connection_specific_smtp_edit_window_set_connection),
1819 (modest_connection_specific_smtp_edit_window_get_settings):
1820 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1823 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1826 * src/maemo/easysetup/modest-easysetup-wizard.c:
1827 (create_page_custom_outgoing), (create_page_complete_custom):
1828 * src/maemo/modest-account-settings-dialog.c:
1829 (create_page_user_details), (create_page_outgoing):
1830 * src/maemo/modest-account-view-window.c: (button_box_new):
1831 Use changed logical IDs as per the most recent UI spec:
1832 mcen_bd_emailsetup_edit -> mcen_bd_edit
1833 mcen_bd_emailsetup_delete -> mcen_bd_delete
1834 mcen_bd_emailsetup_close -> mcen_bd_close
1836 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1840 * src/dbus_api/Makefile.am:
1841 * src/dbus_api/modest-dbus-callbacks.c:
1842 * src/dbus_api/modest-dbus-callbacks.h:
1843 * src/maemo/modest-platform.c: (modest_platform_init):
1844 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1846 * tests/Makefile.am:
1847 * tests/dbus_api/Makefile.am:
1848 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1850 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/modest-account-settings-dialog.c:
1853 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1854 Removed unnecessary includes.
1856 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1858 * src/maemo/easysetup/modest-easysetup-wizard.c:
1859 * src/maemo/modest-account-settings-dialog.c:
1860 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1861 * src/widgets/Makefile.am:
1862 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1863 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1864 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1865 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1866 * src/widgets/modest-secureauth-combo-box.c:
1867 * src/widgets/modest-secureauth-combo-box.h:
1868 * src/widgets/modest-serversecurity-combo-box.c:
1869 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1870 made the GObject names more consistent with the rest of the Modest code.
1872 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1874 * src/maemo/easysetup/Makefile.am:
1875 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1876 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1877 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1878 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1879 * src/maemo/easysetup/modest-easysetup-wizard.c:
1880 * src/maemo/easysetup/modest-validating-entry.c:
1881 * src/maemo/easysetup/modest-validating-entry.h:
1882 * src/maemo/modest-account-settings-dialog.c:
1883 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1884 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1885 widgets/ because they are used outside of easysetup too. After checking in,
1886 svn will allow me to rename them too.
1888 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1890 * src/gnome/modest-msg-edit-window.c:
1891 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1892 linker error, to fix the build on the GNOME platform.
1893 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1894 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1895 ifdefed out to avoid a warning.
1897 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1899 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1900 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1901 some alternative for GTK+ 2.6.
1903 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1905 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1907 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1908 specified for EmailAccountsDialog in UI spec.
1910 * src/maemo/easysetup/modest-easysetup-wizard.c:
1911 * src/maemo/easysetup/modest-easysetup-wizard.h:
1912 * src/maemo/modest-account-settings-dialog.c:
1913 * src/maemo/modest-account-settings-dialog.h:
1914 Reuse a member window widget for the connection-specific SMTP server accounts,
1915 so we can tell it to create/save the accounts only if we actually save changes.
1917 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1918 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1919 (modest_connection_specific_smtp_edit_window_get_settings):
1920 Return a struct instance for temporarily remembering the entered data.
1922 * src/maemo/modest-connection-specific-smtp-window.h:
1923 * src/maemo/modest-connection-specific-smtp-window.c:
1924 (modest_connection_specific_smtp_window_finalize),
1925 (modest_connection_specific_smtp_window_fill_with_connections),
1927 (modest_connection_specific_smtp_window_save_server_accounts),
1928 (update_model_server_names): Do not actually save data until asked,
1929 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1931 (on_selection_changed),
1932 (modest_connection_specific_smtp_window_init): Disable the edit
1933 button when nothing is selected.
1935 * src/modest-account-mgr-helpers.c:
1936 * src/modest-account-mgr-helpers.h:
1937 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1940 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-account-mgr-helpers.h:
1943 * src/modest-account-mgr-helpers.c:
1944 (modest_account_mgr_get_unused_account_name),
1945 (modest_account_mgr_get_unused_account_display_name): Added these
1946 utility functions, to avoid code duplication.
1948 * src/maemo/easysetup/modest-easysetup-wizard.c:
1949 (create_page_account_details), (create_account):
1950 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1951 (on_combo_security_changed),
1952 (modest_connection_specific_smtp_edit_window_init),
1953 (modest_connection_specific_smtp_edit_window_save_settings):
1954 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1955 * src/maemo/modest-connection-specific-smtp-window.c:
1956 (modest_connection_specific_smtp_window_finalize),
1957 (modest_connection_specific_smtp_window_fill_with_connections),
1958 (on_button_edit), (modest_connection_specific_smtp_window_init):
1959 * src/maemo/modest-connection-specific-smtp-window.h:
1960 Implementing saving of connection-specific server accounts.
1962 But I need to refactor this so we can save the data for each
1963 possible connection-specific account and only actually create the server accounts
1964 when the easysetup finished, or the OK button is pressed on the account settings
1967 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1969 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1970 (on_combo_security_changed):
1971 (modest_connection_specific_smtp_edit_window_init):
1972 Auto-fill the port number as in the account settings.
1974 (modest_connection_specific_smtp_edit_window_set_connection):
1975 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1976 * src/maemo/modest-connection-specific-smtp-window.c:
1977 (fill_with_connections), (on_button_edit),
1978 (modest_connection_specific_smtp_window_init):
1979 Turn the edit window into a dialog to simplify the code, and
1980 set a WM hint as in a GtkDialog, because only a popup can be on top of
1981 another window in Maemo, and popups usually have no WM decoration.
1983 * src/modest-defs.h:
1984 * src/modest-account-mgr-helpers.c:
1985 (modest_account_mgr_set_connection_specific_smtp),
1986 (modest_account_mgr_remove_connection_specific_smtp),
1987 (modest_account_mgr_get_connection_specific_smtp):
1988 * src/modest-account-mgr-helpers.h: Some functions to write the
1989 connection-specific SMTP server information. Not yet used.
1992 * src/widgets/modest-folder-view.c: (text_cell_data):
1993 Fix a warning about an uninitialized variable.
1994 (on_configuration_key_changed): Put an #ifdef around the use
1995 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1997 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/modest-account-settings-dialog.h:
2000 * src/maemo/modest-account-settings-dialog.c:
2001 Added connect_for_modified() utility function to mark the new modified boolean.
2003 (create_page_account_details), (create_page_user_details),
2004 (create_page_incoming), (create_page_outgoing), (on_response),
2005 (modest_account_settings_dialog_init),
2006 (modest_account_settings_dialog_set_account_name):
2007 Only warn about unsaved changes when there are actually unsaved changes.
2009 * src/modest-account-mgr-helpers.c:
2010 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2011 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2012 to get the data from there in future.
2014 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2016 * src/modest-defs.h:
2018 * src/modest-account-mgr-helpers.h:
2019 * src/modest-account-mgr-helpers.c:
2020 Store the security account setting in a single conf key instead of using
2021 the options list, so that the list is left for just the to-be-removed camel hack,
2022 and because gconf_client_set_list() is failing for some reason.
2024 * src/modest-account-mgr.c:
2025 (modest_account_mgr_add_server_account):
2026 * src/maemo/modest-account-settings-dialog.c:
2027 (modest_account_settings_dialog_set_account_name),
2028 (save_configuration): Use the renamed functions.
2031 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2033 * src/widgets/Makefile.am:
2034 * src/widgets/modest-limit-retrieve-combo-box.c:
2035 * src/widgets/modest-limit-retrieve-combo-box.h:
2036 * src/widgets/modest-retrieve-combo-box.c:
2037 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2038 the account settings dialog.
2040 * src/modest-defs.h:
2041 * src/modest-account-mgr-helpers.h:
2042 * src/modest-account-mgr-helpers.c:
2043 (modest_server_account_get_option_secure_auth),
2044 (modest_server_account_set_option_secure_auth):
2045 * src/modest-account-mgr.c:
2046 (modest_account_mgr_add_server_account):
2047 Use the existing AUTH_MECH conf key for the secure-auth setting,
2048 instead of putting it in the list options, because this was actually used already.
2050 * src/maemo/modest-account-settings-dialog.c:
2051 (create_page_account_details),
2052 (modest_account_settings_dialog_set_account_name),
2053 (save_configuration):
2054 * src/maemo/modest-account-settings-dialog.h:
2055 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2056 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2058 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2060 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2061 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2062 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2064 * src/modest-defs.h:
2065 * src/maemo/modest-account-settings-dialog.c:
2066 (create_page_incoming), (on_combo_outgoing_security_changed),
2067 (on_combo_incoming_security_changed), (create_page_outgoing),
2068 (modest_account_settings_dialog_set_account_name),
2069 (save_configuration): Load/Save the port number, and change it when the
2070 security combo changes, to suitable defaults.
2072 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2074 * src/modest-account-mgr.c:
2075 (modest_account_mgr_add_server_account): Set the security and secure-auth
2076 options, and add a comment saying that the other camel-specific options should be
2079 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2081 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2083 * src/modest-tny-account-store.c: (account_list_free),
2084 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2085 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2088 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2090 * src/modest-protocol-info.c:
2091 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2092 is required by our UI spec. Maybe something in our implementation will use this eventually.
2093 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2094 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2095 instead of the previous 0 placeholder.
2097 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2098 secure-auth settings.
2099 * src/modest-account-mgr-helpers.h:
2100 * src/modest-account-mgr-helpers.c:
2101 (modest_server_account_data_get_option_secure_auth),
2102 (modest_server_account_set_option_secure_auth),
2103 (modest_server_account_data_get_option_security),
2104 (modest_server_account_set_option_security): Added this API for getting and setting the security
2105 and secure-auth settings.
2107 * src/maemo/modest-account-settings-dialog.h:
2108 * src/maemo/modest-account-settings-dialog.c:
2109 (modest_account_settings_dialog_finalize), (check_data),
2110 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2111 about changing titles.
2112 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2113 (save_configuration): Save the security and secure-auth settings.
2115 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2116 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2118 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2120 * src/modest-defs.h:
2121 * src/modest-account-mgr.c:
2122 (modest_account_mgr_add_server_account):
2123 Added and used defines for the options key and value pair strings,
2124 that are used so far, though they do not seem to correspond to anything in our
2125 UI specs or ModestProtocol enum.
2127 * src/modest-account-mgr-helpers.h:
2128 * src/modest-account-mgr-helpers.c:
2129 (compare_option_strings_for_name),
2130 (modest_server_account_data_get_option_value),
2131 (modest_server_account_data_get_option_bool),
2132 (modest_account_mgr_get_server_account_option):
2133 Added helper functions for parsing the options GSList.
2135 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2137 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2138 display name is based on the supplied account name.
2139 * src/modest-account-mgr.c:
2140 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2141 with an inefficient, but good-enough, implementation.
2143 * src/maemo/easysetup/modest-easysetup-wizard.c:
2144 (create_page_account_details), (on_before_next), (create_account):
2145 Check for existing display names rather than (non-user-visible) account names, and just
2146 create and set a unique account name at the end.
2148 * src/maemo/modest-account-settings-dialog.c:
2149 (modest_account_settings_dialog_init),
2150 (modest_account_settings_dialog_set_account_name),
2151 (create_page_incoming): Show the display name, instead of the account name.
2152 (on_response): Do some (not all) extra checks, as in the UI spec.
2153 (save_configuration): Save the display name if it was changed.
2155 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2157 * po/en_GB.po: Added needed logical ID and translation.
2158 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2159 (init_view): Made the is-default column clicking work.
2161 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2164 * src/maemo/easysetup/Makefile.am:
2165 * src/maemo/easysetup/modest-easysetup-wizard.c:
2166 (modest_easysetup_wizard_dialog_init):
2167 * src/maemo/easysetup/provider-data-test.keyfile:
2168 * src/maemo/easysetup/provider-data.keyfile:
2169 Moved the provider data file to the new modest-providers-data package and used it from there.
2171 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2173 * src/modest-local-folder-info.c:
2174 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2175 N_() was already used on the static strings, but this just marks it for translation without
2176 using the translation.
2178 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2180 * src/maemo/modest-account-settings-dialog.c:
2181 (create_page_incoming),
2182 (modest_account_settings_dialog_set_account_name):
2183 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2184 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2185 I will do this if nobody else gets there first.
2187 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2189 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2190 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2191 save the security stuff.
2193 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2195 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2196 Set the email address and user fullname, which I now see must be
2199 * src/maemo/modest-account-settings-dialog.h:
2200 * src/maemo/modest-account-settings-dialog.c:
2202 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2203 leave-on-server and authentication.
2204 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2207 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/modest-account-settings-dialog.c:
2211 * src/maemo/modest-account-settings-dialog.h:
2212 Most (but not all) of the widgets are now present as specified by the UI spec.
2213 No changes are yet saved, and some details are not properly shown yet.
2215 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2217 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2219 * src/maemo/Makefile.am:
2220 * src/maemo/modest-account-settings-dialog.c:
2221 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2222 an existing account. Doesn't do much yet.
2224 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2225 Open the accounts settings dialog when Edit is clicked.
2227 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2229 * src/maemo/easysetup/Makefile.am:
2230 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2232 * src/maemo/easysetup/modest-easysetup-wizard.c:
2233 (modest_easysetup_wizard_dialog_init):
2234 Try to get the source directory from the build system,
2235 instead of hard-coding "./" into the source code, when opening our local
2236 copies of the configuration files.
2237 But this still fails when opening the wizard from the Accounts window,
2238 maybe because the working directory seems to change at runtime.
2239 So the wizard will fail the second time unless you copy the files into their
2240 proper locations - see the stdout warnings for the paths.
2242 (create_page_account_details),(on_before_next):
2243 Check for existing non-server accounts instead of server accounts,
2244 so the default account name is useful again, and to prevent trying to
2247 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2248 Show the wizard when New is clicked.
2250 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2251 (init_view): Show the column headers, and show the columns that are
2252 specified in the UI specs. However, something in Maemo's GTK+ prevents
2253 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2254 change the default account. This is despite unsetting the special properties.
2256 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2258 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2259 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2260 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2261 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2262 to make that clearer.
2263 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2265 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2267 * src/maemo/modest-account-view-window.c:
2268 (modest_account_view_window_init),
2269 (modest_account_view_window_new):
2270 Use the same buttons as specified in the
2271 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2272 the existing widgets, which never had a chance of working.
2273 Put the ModestAccountView treeview in a scrolled window.
2274 Do not repeat the initialization in both _init() and _new().
2276 * src/widgets/modest-account-view.c: (update_account_view):
2277 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2278 this widget and window shows no accounts.
2280 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2282 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2284 * src/maemo/easysetup/modest-easysetup-wizard.c:
2285 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2286 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2287 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2290 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2291 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2292 accounts exist yet, as in the UI spec.
2294 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2296 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2298 * src/maemo/Makefile.am:
2299 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2300 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2301 New window for editing connection-specific smtp details.
2302 Not fully implemented.
2304 * src/maemo/modest-connection-specific-smtp-window.c:
2305 (modest_connection_specific_smtp_window_finalize) :
2306 unref the tree model.
2307 (on_button_edit): Show the edit window.
2309 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2311 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2314 * src/maemo/Makefile.am:
2315 * src/maemo/modest-connection-specific-smtp-window.c:
2316 * src/maemo/modest-connection-specific-smtp-window.h:
2317 New window for showing the list of connections, for connection-specific
2318 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2319 * src/maemo/easysetup/modest-easysetup-wizard.c:
2320 (create_page_custom_outgoing): Show the new window when the button is clicked.
2322 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2324 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2325 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2326 * src/maemo/modest-msg-edit-window.c:
2327 (modest_msg_edit_window_insert_image):
2328 * src/modest-conf.c: (modest_conf_key_escape):
2329 * src/modest-mail-operation.c:
2330 (modest_mail_operation_send_new_mail):
2331 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2332 (modest_ui_actions_on_new_account):
2333 * src/widgets/modest-attachment-view.c: (update_filename_request):
2334 * src/widgets/modest-mail-header-view.c:
2335 Corrected warnings that were breaking the build, by commenting out unused variables,
2336 and a function, and by including a header.
2338 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2340 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2341 so we can #ifdef around platform-specific code when necessary.
2342 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2343 to allow this to build for the GNOME platform too.
2345 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2347 * src/maemo/easysetup/modest-easysetup-wizard.c:
2348 Added util_increment_name() and used it in create_page_account_details()
2349 to make sure that the default account name is always a new name.
2351 (modest_easysetup_wizard_dialog_init),
2352 (set_default_custom_servernames): Some minor memory management fixes.
2354 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2358 * src/modest-runtime.c: (init_i18n): Restored the translation
2359 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2360 are defined in config.h, and the translations are installed.
2362 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2363 is defined for translation.
2365 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2367 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2369 * src/maemo/easysetup/modest-easysetup-wizard.c:
2370 (modest_easysetup_wizard_dialog_init):
2371 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2372 Use realistic paths (though they should use $prefix generically) to the
2373 mcc_mapping and provider-data.keyfile files which might work when they
2374 are installed by the future version of the operator-wizard package,
2375 and then fallback to paths in our source code, with an explanatory
2378 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2382 * src/maemo/Makefile.am:
2383 * src/maemo/easysetup/: Added files from the previously-exernal
2384 osso-modest-easysetup.
2385 * src/maemo/modest-main-window-ui.h:
2386 * src/modest-ui-actions.c:
2387 * src/modest-ui-actions.h:
2388 Added modest_ui_actions_on_new_account() as a signal handler for the
2389 New Account menu item. It shows the easysetup wizard.
2390 * po/en_GB.po: Added additional needed logical IDs and translations.
2392 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2393 Apparently ChangeLog is not used for some vague Nokia legal reasons.