1 2007-06-13 Murray Cumming <murrayc@murrayc.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
5 (libmodest_dbus_client_compose_mail),
6 (libmodest_dbus_client_open_message),
7 (libmodest_dbus_client_send_and_receive),
8 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
10 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
11 (on_idle_open_message), (modest_dbus_req_handler),
12 (search_result_to_message), (modest_dbus_req_filter):
13 * src/modest-search.c: (add_hit), (modest_search_folder),
14 (modest_search_all_accounts): Improved debug messages.
16 * tests/dbus_api/test_open_message.c: (main): Improved comments.
18 * src/modest-tny-account-store.c:
19 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
22 2007-06-13 Murray Cumming <murrayc@murrayc.com>
25 2007-06-12 Murray Cumming <murrayc@murrayc.com>
27 * src/modest-tny-account-store.c: (get_server_accounts):
28 Call modest_tny_local_folders_account_add_merged_outbox_folders()
29 even when there are no accounts, so that the Outbox folder is always
30 visible. This fixes projects.maemo.org bug NB#60158.
32 2007-06-12 Murray Cumming <murrayc@murrayc.com>
34 * src/maemo/modest-main-window.c: (create_details_widget):
35 Use the mcen_va_never logical ID.
37 2007-06-12 Murray Cumming <murrayc@murrayc.com>
39 * src/dbus_api/modest-dbus-api.h:
40 * src/dbus_api/modest-dbus-callbacks.c:
41 (on_idle_open_default_inbox), (on_open_default_inbox),
42 (modest_dbus_req_handler):
43 Added a new OpenDefaultInbox method.
45 * libmodest-dbus-client/libmodest-dbus-client.h:
46 * libmodest-dbus-client/libmodest-dbus-client.c:
47 Added libmodest_dbus_client_open_default_inbox() to call the new
48 dbus method. This should be useful to projects.maemo.org bug NB#57214,
49 though it should maybe be used by a new osso-email-interface function.
51 * tests/dbus_api/Makefile.am:
52 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
55 2007-06-12 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
58 NULL, so that the signals get all the keys. This should not actually
59 change any behaviour because we currently update everything when anything
62 2007-06-12 Murray Cumming <murrayc@murrayc.com>
64 * src/widgets/modest-folder-view.c: (text_cell_data),
65 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
66 (find_inbox_iter): If tinymail tells us that the folder is
67 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
68 This causes the inbox to be selected at startup, fixing part of
69 projects.maemo.org bug NB#56305.
71 * src/modest-ui-dimming-rules.c:
72 (modest_ui_dimming_rules_on_tools_smtp_servers):
73 * src/modest-ui-dimming-rules.h: Added a callback function to dim
74 the SMTP servers menu item.
75 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
76 that the SMTP Servers menu item is dimmed when there are no accounts,
77 as a future version of the UI spec will require. This fixes
78 projects.maemo.org bug NB#56305.
80 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
82 * src/maemo/modest-maemo-utils.c:
83 (modest_maemo_utils_get_supported_secure_authentication_methods):
84 Added label to dialog instead of unreadable title
86 * src/maemo/modest-main-window.c: (sync_accounts_cb),
87 (modest_main_window_new):
88 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
91 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
92 * src/modest-account-mgr.h:
93 Added method to avoid code duplication
95 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
96 (modest_ui_actions_on_send_receive):
97 Use modest_account_mgr_has_accounts
99 2007-06-11 Murray Cumming <murrayc@murrayc.com>
101 * src/maemo/easysetup/modest-presets.c:
102 (modest_presets_get_info_server_security): Do not report secure auth
104 * src/modest-protocol-info.c: Use the defines for the gconf key names
105 for secure authentication. This was not working because we were writing
106 Password and reading password, and the check was case sensitive.
107 With this, gmail now works for receiving and sending when created via
110 2007-06-11 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/easysetup/modest-presets.c:
113 (modest_presets_get_info_server_security): Correct the key name for
114 SecureSmtp, because it seems to be case-sensitive.
115 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
116 Do not try to get the 0th notebook page if there are 0 pages, to
119 2007-06-11 Murray Cumming <murrayc@murrayc.com>
121 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
122 Prevent use of the new notification feature for now, because it currently
123 shows one dialog for each new email, which is annoying.
125 2007-06-11 Murray Cumming <murrayc@murrayc.com>
127 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
128 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
129 when no country was selected, so that we show the global ones.
130 * src/maemo/easysetup/modest-presets.c:
131 (modest_presets_get_providers): Return only the global providers, not
132 all providers when mmc=0 was requested.
134 2007-06-11 Murray Cumming <murrayc@murrayc.com>
136 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
137 (easysetup_provider_combo_box_fill): Remove debug code that showed the
138 provider ID in the combo.
140 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
141 Do not show the page numbers, because it would be confusing when we add
142 the 2 extra pages for the custom setup, when the user chooses the "Other"
143 provider. This fixes projects.maemo.org bug NB#59028
145 * src/modest-init.c: (modest_init_init_core),
146 (modest_init_local_folders):
148 * src/modest-tny-account.c:
149 (modest_tny_account_new_for_local_folders): Do not create default folders
150 for the memory card. This should fix projects.maemo.org bug NB#59328.
152 2007-06-11 Murray Cumming <murrayc@murrayc.com>
154 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
155 Free the changed_conf_keys string items. They are already freed in the
156 idle handler if that runs first.
158 2007-06-11 Murray Cumming <murrayc@murrayc.com>
160 * src/modest-ui-actions.c:
161 (modest_ui_actions_on_password_requested): Check that the server name
162 is not NULL, because I just saw a password dialog with (null) as the
165 * src/modest-tny-folder.[h|c]: Added
166 modest_tny_folder_is_memory_card_folder().
167 * src/modest-ui-dimming-rules.c:
168 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
169 menu item for memory cards, as per the UI spec (section 7.4). This should
170 fix projects.maemo.org bug NB#59297.
172 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
174 * src/maemo/modest-main-window.c: (sync_accounts_cb):
175 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
176 is another problem with the code, see Murray's comment at line 772)
178 2007-06-08 Murray Cumming <murrayc@murrayc.com>
180 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
181 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
182 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
183 (load_from_file), (easysetup_country_combo_box_init),
184 (easysetup_country_combo_box_get_active_country_ids),
185 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
186 instead of just one ID, to avoid duplicate country names in the UI.
188 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
189 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
190 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
191 a single ID, avoiding duplicate providers.
192 * src/maemo/easysetup/modest-easysetup-wizard.c:
193 (on_combo_account_country): Adapt to use a list.
195 2007-06-08 Murray Cumming <murrayc@murrayc.com>
197 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
198 keys changed in the last X seconds.
200 * src/modest-account-mgr.h:
201 * src/modest-account-mgr.c: (on_timeout_notify_changes),
202 (on_key_change), (modest_account_mgr_class_init),
203 (modest_account_mgr_init), (modest_account_mgr_finalize):
204 As the keys are changed, save them in a GSList* and signal that GSList*
205 further every X seconds, to batch changes, to allow us to do just one
206 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
207 bug NB#56941 and other (UI-blocking) delays when changing account settings.
209 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
210 changed signal signature.
212 * src/modest-conf.c: (modest_conf_set_list),
213 (modest_conf_on_change): Reenable notification.
215 (modest_conf_maemo_fake_on_change): Comment out the hack that
216 notified immediately instead of asynchronously.
218 * src/widgets/modest-account-view.h:
219 * src/widgets/modest-account-view.c:
220 (update_account_view): Select the previously-selected account ID,
221 if possible. This fixes projects.maemo.org bug NB#56933.
223 (on_account_changed), (on_account_removed),
224 (modest_account_view_select_account):
226 Remove the block/unblock functions
227 because they were not useful.
229 * src/maemo/modest-account-view-window.c:
230 (on_delete_button_clicked), (on_edit_button_clicked),
231 (on_new_button_clicked): Remove the use of the non-working block/unblock.
233 2007-06-08 Murray Cumming <murrayc@murrayc.com>
235 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
236 Improve the error dialog to show Incorrect Account Settings, which seems
237 clearer, and say that the internal error message (to be removed from the
238 dialog later) is often misleading.
239 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
241 * src/modest-tny-account.c:
242 (modest_tny_account_new_from_server_account): Uncomment the printf of the
243 URL because this is so useful for debugging on the device.
245 * src/widgets/modest-serversecurity-combo-box.c:
246 (modest_serversecurity_combo_box_fill): Correct a logical ID.
248 2007-06-08 Murray Cumming <murrayc@murrayc.com>
250 * src/modest-mail-operation.c:
251 (modest_mail_operation_send_new_mail):
252 Added a comment about a nasty but apparently harmless message. Details
253 added to the wiki g_warnings() page.
255 2007-06-08 Murray Cumming <murrayc@murrayc.com>
257 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
258 (modest_tny_send_queue_class_init):
259 Do not use the priv struct because it is empty, to avoid g_warnings
260 about a non-existant priv struct.
262 * src/modest-tny-account-store.c:
263 (modest_tny_account_store_get_server_account),
264 (modest_tny_account_store_get_transport_account_for_open_connection
265 ): Do not try to get transport server accounts for local folders,
266 because they don't have any. This avoids a g_warning().
268 * src/maemo/modest-main-window.c:
269 (modest_main_window_notify_send_receive_initied),
270 (on_configuration_key_changed):
271 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
273 * src/modest-mail-operation.c:
274 (modest_mail_operation_update_account):
275 * src/modest-tny-account-store.h:
276 * src/modest-tny-account.c:
277 (modest_tny_account_get_special_folder),
278 (modest_tny_account_new_for_local_folders),
279 (modest_tny_account_new_for_per_account_local_outbox_folder):
280 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
281 * src/modest-tny-local-folders-account.c:
282 (add_account_folders_to_merged_folder):
283 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
284 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
285 (modest_ui_actions_on_send):
286 * src/widgets/modest-folder-view.c: (update_model):
287 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
288 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
289 modest_tny_account_store_get_tny_account_by_account() to
290 modest_tny_account_store_get_server_account() to make the code clearer.
292 2007-06-07 Marcus Bauer <marcusb@openismus.com>
294 * src/dbus_api/modest-dbus-api.h:
295 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
296 * src/maemo/modest-msg-edit-window.c:
297 (modest_msg_edit_window_attach_file_noninteractive):
298 added g_warning in case the file to be attached does not exist
299 * tests/dbus_api/test_compose_mail.c: (main):
300 removed obsolete comment, added generic files as test case
302 2007-06-07 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-tny-account-store.c: (get_server_accounts):
305 Create the local folders account only once, not once for each outbox, and
306 not only when there are some outboxes.
308 2007-06-07 Murray Cumming <murrayc@murrayc.com>
310 * src/widgets/modest-folder-view.c: (update_model): Comment out some
311 code that is causing a crash at startup. Sergio says that he is fixing this.
313 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
315 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
316 * src/maemo/modest-account-settings-dialog.c:
317 (create_page_outgoing),
318 (modest_account_settings_dialog_set_account_name),
319 (save_configuration):
320 - Fixed handling of the "Use secure authentication" toggle to comply with
321 the ui specification. See also projects.maemo.org bug NB#58400
323 - Restore the Secure connection setting combo correctly when loading
326 * src/maemo/modest-maemo-utils.c:
327 (on_camel_account_get_supported_secure_authentication),
328 (modest_maemo_utils_get_supported_secure_authentication_methods):
329 Fixed a crasher if operation is canceled
331 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
332 (modest_protocol_info_auth_is_secure):
333 * src/modest-protocol-info.h:
335 Added two new methods to determine if a protocol/auth method is secure/encrypted in
336 the sense of the "Use secure authentication" toggle.
338 2007-06-07 Murray Cumming <murrayc@murrayc.com>
340 * src/modest-tny-account-store.h:
341 * src/modest-tny-account-store.c:
342 Added modest_tny_account_store_get_local_folders_account().
344 * src/modest-tny-folder.h:
345 * src/modest-tny-folder.c:
346 (modest_tny_folder_get_account):
347 Added this replacement for tny_folder_get_account() which returns
348 the local-folders account for TnyMergeFolders, to avoid the
349 warning about the unimplemented get_account_func() vfunc().
351 (modest_tny_folder_get_rules),
352 * src/modest-ui-actions.c:
353 (modest_ui_actions_on_folder_selection_changed):
354 * src/modest-mail-operation.c:
355 (modest_mail_operation_remove_folder),
356 (modest_mail_operation_xfer_folder),
357 (modest_mail_operation_rename_folder),
358 (modest_mail_operation_get_msg),
359 (modest_mail_operation_get_msgs_full),
360 (modest_mail_operation_remove_msg),
361 (modest_mail_operation_xfer_msgs),
362 (modest_mail_operation_refresh_folder):
363 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
365 2007-06-07 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
368 (modest_server_account_set_security):
369 * src/modest-defs.h: Add comments explaining that our
370 UI spec means TLS when it says Normal, so these do not look like errors.
372 * src/modest-tny-account.c:
373 (modest_tny_account_new_from_server_account): Use the new tinymail
374 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
375 for TLS. This should fix projects.maemo.org bug NB#58460.
377 2007-06-06 Murray Cumming <murrayc@murrayc.com>
379 * src/maemo/easysetup/modest-easysetup-wizard.c:
380 (create_account): Correct the position of the gconf sanity check warning.
381 (on_button_edit_advanced_settings): Show the dialog immediately, instead
382 of using the g_idle_add() hack, because this does not seem to be necessary
383 on osso 1.1. It might even work on Maemo Bora if the problems were actually
384 caused by something other than maemo's gconf.
385 This fixes projects.maemo.org bug #59022.
387 2007-06-06 Murray Cumming <murrayc@murrayc.com>
389 * src/modest-account-mgr-helpers.c:
390 (modest_account_mgr_get_default_account): Do not check that the account
391 exists if there is no default account (NULL), to fix a runtime warning.
393 2007-06-06 Murray Cumming <murrayc@murrayc.com>
395 * src/widgets/modest-folder-view.c: (update_model):
396 Do not unref the treemodel before we have finished with it.
397 This prevents a valgrind warning and an occasional crash at startup.
399 2007-06-06 Marcus Bauer <marcusb@openismus.com>
401 * libmodest-dbus-client/libmodest-dbus-client.h:
402 added libmodest_dbus_client_compose_mail()
403 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
405 added functions needed for SendAsMail() functionality
406 * src/maemo/modest-msg-edit-window.c:
407 (modest_msg_edit_window_attach_file_noninteractive):
408 non interactively attaching files to message edit window
409 * src/widgets/modest-msg-edit-window.h:
410 * tests/dbus_api/Makefile.am:
411 added test_compose_mail.c
412 * tests/dbus_api/test_compose_mail.c: (main):
414 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
416 * src/modest-account-view.c:
417 Fixed bug projects.maemo.org bug NB#59307
419 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
421 * src/maemo/easysetup/modest-easysetup-wizard.c:
422 (get_serverport_incoming), (on_before_next), (create_account):
423 * src/maemo/modest-account-settings-dialog.c:
424 (modest_account_settings_dialog_set_account_name):
425 * src/maemo/modest-maemo-utils.c:
426 (on_camel_account_get_supported_secure_authentication_status),
427 (on_camel_account_get_supported_secure_authentication),
428 (on_secure_auth_cancel),
429 (modest_maemo_utils_get_supported_secure_authentication_methods):
431 Implemented security authentication for settings and easysetup.
433 2007-06-05 Murray Cumming <murrayc@murrayc.com>
435 * src/maemo/modest-main-window.c: (create_details_widget):
436 Show the total size for memory card accounts too, instead of showing
437 the name again. Fixes bug projects.maemo.org bug NB#59307.
439 2007-06-05 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-tny-simple-folder-store.c:
443 * src/modest-tny-simple-folder-store.h: Removed.
445 * src/modest-tny-local-folders-account.h
446 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
447 for the local-folders maildir, with an extra TnyMergedFolder containing
448 the folders of the per-account outbox store accounts.
449 * src/modest-tny-account-store.c: (get_server_accounts):
450 Add the outboxes to the special local folders account after creating it.
452 * src/modest-tny-account.c:
453 (modest_tny_account_new_for_local_folders): Create the derived
454 account when creating the main local-folders account.
456 * src/maemo/modest-main-window.c: (create_details_widget),
457 (modest_main_window_set_contents_style):
458 Adapted to the use of the derived account instead of the folder store.
460 * src/modest-ui-actions.c:
461 (modest_ui_actions_on_folder_selection_changed):
462 * src/modest-ui-dimming-rules.c:
463 (modest_ui_dimming_rules_on_new_folder):
464 * src/widgets/modest-folder-view.c: (text_cell_data),
465 (icon_cell_data), (filter_row), (update_model),
466 (get_cmp_rows_type_pos):
469 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
470 Do not get the priv struct, because no priv struct has been set,
471 to avoid a runtime warning.
473 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
474 #ifelse with #else, to fix a warning, to fix the build.
477 2007-06-05 Christian Kellner <ckellner@openismus.com>
479 * libmodest-dbus-client/libmodest-dbus-client.c:
480 Fix small typo in doc (why do you always see them
481 AFTER committing stuff?)
484 2007-06-05 Christian Kellner <ckellner@openismus.com>
486 * libmodest-dbus-client/libmodest-dbus-client.c:
487 (libmodest_dbus_client_search):
488 Initialize hit list with NULL. Also set folder list
489 to "" if NULL was supplied.
492 2007-06-03 Christian Kellner <ckellner@openismus.com>
494 * libmodest-dbus-client/libmodest-dbus-client.c:
495 (modest_search_hit_list_free):
496 Make it save to call it with NULL.
498 * src/dbus_api/modest-dbus-callbacks.c:
499 * src/modest-search.c:
500 Return full ModestSearchHits as the search result list not TnyHeader
501 since can't be around withouth the correspoding TnyFolder.
503 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
505 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
506 Added currently commented code to check for secure auth
508 * src/maemo/modest-account-settings-dialog.c: (on_response),
509 (save_configuration), (show_ok):
510 Fixed projects.maemo.org bugs NB #59248 and #59251
512 * src/maemo/modest-maemo-utils.c:
513 (on_camel_account_get_supported_secure_authentication_status),
514 (on_camel_account_get_supported_secure_authentication),
515 (modest_maemo_utils_get_supported_secure_authentication_methods):
516 * src/maemo/modest-maemo-utils.h:
517 Moved get_supported_secure_authentication() method here to be able
518 to use it from easysetup wizard.
520 * src/modest-pair.c: (on_pair_compare_as_string):
521 Should compare string with first part of pair and not
522 strcmp pairs which will crash.
524 * src/modest-protocol-info.c:
525 (modest_protocol_info_protocol_is_store):
526 * src/modest-protocol-info.h:
527 Added modest_protocol_info_get_auth_protocol_name()
529 2007-06-03 Armin Burgmeier <armin@openismus.com>
531 * src/modest-mail-operation.c:
532 (modest_mail_operation_get_msgs_full): Set priv->account also when
533 only retrieving a single message. This avoids a crash when canceling
536 (modest_mail_operation_notify_end): Do not explicitely remove the
537 operation from the queue but only emit the progress_changed signal.
538 The queue itself listens to that signal to remove the operation when
539 it is finished. This reduces coupling and removes a potential deadlock
540 when modest_mail_operation_notify_end() is called from the queue
541 itself. If that is a problem performance-wise, I would suggest to
542 implement a status-changed signal or something.
544 * src/modest-mail-operation-queue.c: Make sure to never call a
545 function from another file while the queue is locked. This (hopefully)
546 fixes another deadlock when exiting the application while retrieving
549 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
551 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
552 Fixed build if libogs is not available
554 2007-06-03 Christian Kellner <ckellner@openismus.com>
556 * libmodest-dbus-client/libmodest-dbus-client.h:
557 * libmodest-dbus-client/libmodest-dbus-client.c:
558 (libmodest_dbus_client_delete_message):
559 Implement deletion of messages (Client side).
561 (modest_search_hit_free),
562 (modest_search_hit_list_free):
563 Utility functions to free the result hits.
565 * src/dbus_api/modest-dbus-api.h:
566 * src/dbus_api/modest-dbus-callbacks.c:
568 (modest_dbus_req_handler):
569 Implement deletion of messages (Server side).
571 * tests/dbus_api/test_search.c: (main):
574 * tests/dbus_api/Makefile.am:
575 * tests/dbus_api/test_delete_message:
576 Add little test for the message deletion logic
578 2007-06-03 Armin Burgmeier <armin@openismus.com>
580 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
581 when the operation queue was not empty. projects.maemo.org bug
584 2007-06-03 Armin Burgmeier <armin@openismus.com>
586 * src/widgets/modest-account-view.c
587 (on_account_default_toggled): Toggle default account column
588 explicitely instead of waiting for gconf notification (which is
589 currently ignored). This should fix projects.maemo.org bug NB#56910
590 for now. It should probably be removed when gconf notifications are
593 2007-06-03 Christian Kellner <ckellner@openismus.com>
595 * libmodest-dbus-client/libmodest-dbus-client.c:
596 Removed debugging spew.
598 * src/dbus_api/modest-dbus-callbacks.c:
599 Added debugging info.
601 * src/modest-search.c:
602 (modest_search_all_accounts):
603 Use tny_account_store_get_accounts () on the account store
604 to get all accounts which is the way to get all accounts.
606 * tests/dbus_api/test_search.c: (main):
607 Make it possible to supply the search term on the command line.
609 2007-06-03 Christian Kellner <ckellner@openismus.com>
611 * libmodest-dbus-client/libmodest-dbus-client.c:
612 * libmodest-dbus-client/libmodest-dbus-client.h:
613 Implement searching for mesages over raw dbus. (Client side)
615 * src/dbus_api/Makefile.am:
616 * src/dbus_api/modest-dbus-api.h:
617 * src/dbus_api/modest-dbus-callbacks.c:
618 * src/dbus_api/modest-dbus-callbacks.h:
619 Search framework (Server side). Also implement on_idle_open_message().
621 * src/maemo/modest-platform.c: (modest_platform_init):
622 Prepare for raw dbus/osso rpc interaction.
624 * src/modest-search.h:
625 Changed minsize from unspecific guint to guint32.
627 * src/modest-search.c:
629 Added strange hack which magically made tnymail work.
631 (modest_search_folder),
632 (modest_search_account),
633 (modest_search_all_accounts):
634 Implement helper functions to search all accounts, specific account
637 * tests/dbus_api/Makefile.am:
638 * tests/dbus_api/test_open_message.c:
639 Read url to open from commandline.
641 * tests/dbus_api/test_search.c:
642 Implement small test for dbus search stuff
644 2007-06-02 Armin Burgmeier <armin@openismus.com>
646 * src/maemo/modest-account-settings-dialog.c: Changed window title to
647 include account type and account title. This fixes projects.maemo.org
650 * src/maemo/modest-account-view-window.c: Set a title for the window.
652 2007-06-02 Armin Burgmeier <armin@openismus.com>
654 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
655 incoming and outgoing server name based on email address and server
656 types as long as the names have not been edited manually. This fixes
657 projects.maemo.org bug NB#58671.
659 2007-06-02 Armin Burgmeier <armin@openismus.com>
661 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
662 server type cannot be changed in future to the incoming details page
663 when creating an account. This fixes projects.maemo.org bug NB#59029.
665 2007-06-02 Armin Burgmeier <armin@openismus.com>
667 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
668 and assigned max width chars so that they wrap instead of being
669 truncated. Fixes projects.maemo.org bug NB#56126.
671 2007-06-02 Armin Burgmeier <armin@openismus.com>
673 * src/maemo/modest-connection-specific-smtp-window.c: Add an
674 introductory note to the connection specific smtp servers dialog, as
675 section 8.12 of the email UI specification requires. This fixes
676 projects.maemo.org bug NB#59212.
678 2007-06-01 Murray Cumming <murrayc@murrayc.com>
680 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
681 Check for running mail operations, and offer to cancel them, as per the UI
682 spec. This fixes projects.maemo.org bug NB#59041 .
683 However, I suspect that tinymail may still use the network connection
684 in ways that we cannot detect or cancel. But it should at least adapt to
687 2007-06-01 Murray Cumming <murrayc@murrayc.com>
689 * src/modest-tny-account-store.c: (recreate_all_accounts),
690 (get_cached_accounts), (get_server_accounts): Do more sensible
691 ref-counting of the temporarily-cached outbox accounts list. This seems
692 to fix a crash when entering the password when the password was wrong.
694 2007-06-01 Murray Cumming <murrayc@murrayc.com>
696 * src/gnome/modest-main-window.c: (connect_signals):
697 * src/modest-tny-account-store.c: (get_password),
698 (modest_tny_account_store_alert): Added comments and clues and
699 commented-out code about how we currently fail to deal with connection
700 errors and wrong passwords, and how we should.
702 2007-06-01 Murray Cumming <murrayc@murrayc.com>
704 * src/widgets/modest-retrieve-combo-box.c:
705 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
706 This fixes projects.maemo.org bug NB#58472 .
708 2007-06-01 Murray Cumming <murrayc@murrayc.com>
710 * src/maemo/easysetup/modest-easysetup-wizard.c:
711 (create_page_complete_easysetup):
712 (create_page_complete_custom): Correct the last commit,
713 putting the correct sentences in the correct pages.
715 2007-06-01 Murray Cumming <murrayc@murrayc.com>
717 * src/maemo/easysetup/modest-easysetup-wizard.c:
718 (create_page_complete_custom): Show the second sentence of text
719 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
722 2007-06-01 Murray Cumming <murrayc@murrayc.com>
724 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
725 Set the leave-on-server conf key by default. This fixes
726 projects.maemo.org bug NB#59258 .
728 2007-06-01 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/modest-account-view-window.c:
731 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
732 logical ID for the confirmation messages. Fixed projects.maemo.org bug
735 2007-06-01 Murray Cumming <murrayc@murrayc.com>
737 * src/maemo/easysetup/modest-easysetup-wizard.c:
738 (create_caption_new_with_asterisk):
739 * src/maemo/modest-account-settings-dialog.c:
740 (create_caption_new_with_asterisk):
741 Uncomment the code to add the asterisk, because they are no longer in the
742 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
743 (update_incoming_server_title): Add an asterisk here too.
745 2007-06-01 Murray Cumming <murrayc@murrayc.com>
747 * src/maemo/modest-maemo-global-settings-dialog.c:
748 (current_connection): Check that we are even connected before trying to
749 get the current connection name, to prevent a warning.
751 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
752 Change the comments because tny_maemo_conic_device_connect() is now meant to
754 * src/modest-mail-operation.c:
755 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
756 make sure we have a connection and fail if we can't connect.
758 2007-05-31 Murray Cumming <murrayc@murrayc.com>
760 * src/maemo/modest-main-window.c:
761 (on_account_store_connecting_finished): Do not try to get the
762 connection ID if we are not really connected. I am surprised that
763 this signal handler is called when we are not connected.
765 2007-05-31 Murray Cumming <murrayc@murrayc.com>
767 * src/modest-error.h:
768 * src/modest-ui-actions.c:
769 (modest_ui_actions_get_msgs_full_error_handler):
770 Renamed an enum, added comments, added an enum
771 for retrieve-limit errors.
773 * src/modest-mail-operation.c: (foreach_add_item),
774 (internal_folder_observer_update), (update_account_thread),
775 (modest_mail_operation_get_msgs_full):
776 (modest_mail_operation_update_account),
777 Added comments about how this works, and some code that should
778 (but does not) check the retrieve-limit. See the TODO comment.
780 2007-05-31 Murray Cumming <murrayc@murrayc.com>
782 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
783 Initialize help_id to fix the build. Warnings are good.
785 2007-05-31 Murray Cumming <murrayc@murrayc.com>
787 * src/widgets/modest-hbox-cell-renderer.c:
788 (modest_hbox_cell_renderer_append):
789 * src/widgets/modest-vbox-cell-renderer.c:
790 (modest_vbox_cell_renderer_append):
791 Fix the last commit by doing an extra ref.
793 2007-05-31 Murray Cumming <murrayc@murrayc.com>
795 * src/widgets/modest-hbox-cell-renderer.c:
796 (modest_hbox_cell_renderer_append):
797 * src/widgets/modest-vbox-cell-renderer.c:
798 (modest_vbox_cell_renderer_append):
799 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
800 to fix the build with Maemo Bora.
801 However, there seems to be a remaining crash, probably due to reference
804 2007-05-30 Murray Cumming <murrayc@murrayc.com>
806 * src/modest-tny-account.c:
807 (modest_tny_account_new_for_local_folders):
808 Use hildon_file_system_info_async_new() to get a better name for
809 the memory card account, setting it as the account name.
810 The timing seems to work, but this is probably
811 not the best place to do this. See the TODO comment.
812 * src/maemo/modest-main-window.c: (create_details_widget):
813 * src/widgets/modest-folder-view.c: (text_cell_data):
814 Use the tny account name instead of hardcoding a name.
816 2007-05-30 Christian Kellner <ckellner@openismus.com>
818 * src/modest-search.c: (modest_search):
819 Correctly set part_search_func even if we have already parsed
820 the query and thus a valid OgsTextSearcher object.
822 2007-05-30 Christian Kellner <ckellner@openismus.com>
825 Search and check for libogs.
828 Incooparte the ogs build env.
830 * src/modest-mime-part-search-stream.c:
831 * src/modest-mime-part-search-stream.h:
832 Removed since we do the real searching now in modest-search.c.
834 * src/modest-search.c:
835 * src/modest-search.h:
836 Implement support for ogs. We use that if available and requested
837 and fall back to modest_text_utils_utf8_strcmp (). The search logic
838 should now handle the corner case when the search term is spread
839 across multiple reads.
840 Also the logic in modest_search () was corrected to search all
841 requested fields until one is found.
843 2007-05-30 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
848 * src/modest-init.c: Made modest_init_local_folders() take a
849 path and be public so we can iniitialize maildir folders on
852 * src/modest-local-folder-info.h:
853 * src/modest-local-folder-info.c:
854 (modest_local_folder_info_get_maildir_path): Add a path parameter.
856 * src/modest-tny-account.c:
857 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
858 still means the standard local-folders path on the local volume.
860 * src/modest-tny-account-store.c:
861 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
862 signal so we can detect mount/unmount of the MMC1 card, and do an update of
863 all accounts when that happens.
864 (get_server_accounts): If the MMC1 card is mounted, create a store account for
865 this too, so it shows up in the treeview.
867 2007-05-28 Murray Cumming <murrayc@murrayc.com>
869 * src/maemo/modest-maemo-global-settings-dialog.c:
870 (current_connection):
871 * src/widgets/modest-global-settings-dialog.c:
872 (current_connection_default):
873 Use the enum values instead of 0, 1 and -1,
874 to make the code clearer.
876 * src/modest-account-mgr-helpers.c:
877 (modest_account_mgr_get_connection_specific_smtp): Make this code
880 * src/modest-runtime.h:
881 * src/modest-runtime.c:
882 Added modest_runtime_remove_all_send_queues().
883 * src/maemo/modest-main-window.c:
884 (on_account_store_connecting_finished): Recreate the send queues,
885 using the appropriate transport accounts for this new connection.
886 Some futher adapting might be needed if the old send queues are not
887 automatically stopped at this point.
889 * src/modest-tny-account-store.c: (get_server_accounts):
890 Create the connection-specific transport accounts, so that they can
891 be found later by their ID.
893 * src/modest-tny-account.h:
894 * src/modest-tny-account.c:
895 Added modest_tny_account_new_from_server_account_name().
896 modest_tny_account_new_from_server_account(): Do not create the
897 send queues here, because they will be
898 recreated anyway when the connection changes for the first time.
900 2007-05-28 Murray Cumming <murrayc@murrayc.com>
902 * src/modest-local-folder-info.h:
903 * src/modest-local-folder-info.c:
904 (modest_per_account_local_outbox_folder_info_get_maildir_path),
905 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
906 tbox_folder): Take a modest account name instead of a server TnyAccount,
907 so we can have per-modest-account rather than per-transport-account
909 We must make sure that we change or recreate the exisitng send queues
910 when the connection changes for connection-specific transport accounts.
912 * src/modest-tny-account-store.c:
913 (create_per_account_local_outbox_folders): Create outboxed per modest
914 account, not per transport account.
916 * src/modest-tny-account.h:
917 * src/modest-tny-account.c:
918 (modest_tny_account_get_special_folder): For outboxes, get the
919 parent modest account name. The account is ignored for other folders.
920 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
921 modest account name rather than a server TnyAccount.
923 2007-05-25 Murray Cumming <murrayc@murrayc.com>
925 * src/modest-tny-account.c:
926 (modest_tny_account_new_from_server_account):
927 Call modest_runtime_get_send_queue() immediately after creating transport
928 accounts, so that they start trying to send email from the outbox as soon
929 as possible at startup. This is probably what we want.
931 * src/modest-mail-operation.c: (update_account_thread):
932 * src/modest-runtime.c: (modest_runtime_get_send_queue):
933 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
934 * src/modest-tny-send-queue.h:
935 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
936 (modest_ui_actions_on_send):
937 Added comments about how sending works, though it needs some more work.
939 2007-05-25 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-tny-account.c:
942 (modest_tny_account_get_special_folder): Add TODO because this fails when
944 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
945 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
946 Do not try to show this window when there is no active account. The UI
947 specs does not tell us what to do in this case.
949 2007-05-24 Murray Cumming <murrayc@murrayc.com>
953 * src/maemo/Makefile.am:
954 * src/widgets/Makefile.am: Some dist fixes.
956 2007-05-24 Murray Cumming <murrayc@murrayc.com>
958 * src/maemo/modest-connection-specific-smtp-window.c:
959 (on_button_edit): Make the code clearer, to prevent a double free.
961 2007-05-24 Murray Cumming <murrayc@murrayc.com>
963 * src/maemo/modest-account-settings-dialog.c:
964 (modest_account_settings_dialog_set_account_name),
965 Check the connection-specific smtp servers checkbox if there are any.
967 * src/maemo/modest-connection-specific-smtp-edit-window.c:
968 (modest_connection_specific_smtp_edit_window_init):
969 Start with a suitable port number.
971 * src/modest-account-mgr-helpers.h:
972 * src/modest-account-mgr-helpers.c: Added
973 modest_account_mgr_get_has_connection_specific_smtp().
975 (modest_account_mgr_set_connection_specific_smtp),
976 (modest_account_mgr_remove_connection_specific_smtp),
977 (modest_account_mgr_get_has_connection_specific_smtp),
978 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
979 connection-specific smtp server accounts in the account, rather than
980 the server account conf dir.
982 This fixes bug projects.maemo.org bug NB#58263 .
984 * src/modest-tny-account-store.c:
985 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
986 if there are no server accounts yet, to prevent an infinite loop when there
987 are no accounts. Document that one must be called before the other.
989 2007-05-24 Murray Cumming <murrayc@murrayc.com>
991 * src/modest-account-mgr-helpers.c:
992 (modest_account_mgr_get_default_account): Make sure that at least
993 one account is always the default, if there are any enabled accounts.
994 This is just a sanity check that shouldn't be necessary.
996 * src/modest-account-mgr-priv.c:
997 (_modest_account_mgr_account_from_key): Unescape the conf key to
998 get the real account name. For instance, this is an issue if a space
999 was in the account name, which can happen because the account name
1000 is generated from the display name.
1001 (_modest_account_mgr_get_account_keyname): Always escape the
1003 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1004 Unescape the conf keys to get the real account names.
1006 For instance, previously the is-default radio button in the accounts
1007 list was not checked for any accounts at first. This fixes that,
1008 and might fix several similar bugs.
1010 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1012 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1013 Removed some debug printfs.
1015 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1017 Modest on-disk outbox directories are now here, for instance:
1018 $HOME/.modest/outboxes/<account-id-1>/outbox
1019 $HOME/.modest/outboxes/<account-id-2>/outbox
1021 $HOME/.modest/local-folders/outbox
1022 so we can have a separate outbox for each account.
1023 But they are shown as one outbox in the GtkTreeView, by using a
1024 TnyMergeFolder in a ModestTnySimpleFolderStore.
1027 * src/modest-tny-simple-folder-store.c:
1028 * src/modest-tny-simple-folder-store.h:
1029 Added ModestTnySimpleFolderStore, used to contain folders from
1030 other folder stores, such as other accounts.
1032 * src/modest-tny-outbox-account.h:
1033 * src/modest-tny-outbox-account.c:
1034 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1035 used for the per-account local outbox folders.
1037 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1038 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1039 only use this (internally) now for the non-outbox local folders.
1041 * src/modest-init.h:
1042 * src/modest-init.c: Added modest_init_one_local_folder(), for
1043 setting up the directory structure for each local folder.
1045 * src/modest-local-folder-info.c:
1046 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1047 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1049 * src/modest-local-folder-info.h:
1050 * src/modest-tny-account-store.c: (on_account_removed),
1051 (on_account_changed), (create_per_account_local_outbox_folders),
1052 (get_server_accounts), (modest_tny_account_store_get_accounts),
1053 (modest_tny_account_store_get_tny_account_by_account),
1054 (modest_tny_folder_store_is_virtual_local_folders):
1056 * src/modest-tny-account.h:
1057 * src/modest-tny-account.c:
1058 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1059 to create an on-disk per-account local outbox folder for each
1061 (create_per_account_local_outbox_folders): Create a local outbox folder
1062 for each transport account.
1063 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1064 for all local folders.
1066 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1067 instead of using g_object_get/set() directly. It is clearer.
1069 (modest_tny_folder_store_get_message_count),
1070 (modest_tny_folder_store_get_local_size
1071 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1072 because we now use these with non-acount folder stores.
1074 (modest_tny_account_get_special_folder),
1075 (modest_tny_account_new_from_server_account),
1076 (modest_tny_account_new_from_account):
1077 (recurse_folders): Adjust to the new outbox system.
1079 * src/modest-tny-folder.h:
1080 * src/modest-tny-folder.c:
1081 (modest_tny_folder_is_local_folder),
1082 (modest_tny_folder_get_local_folder_type),
1083 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1085 * src/widgets/modest-main-window.h:
1086 * src/maemo/modest-main-window.c: (create_details_widget),
1087 (modest_main_window_set_contents_style): Show details for any folder store,
1090 (modest_tny_folder_get_rules):
1091 Remove the const. C does not support constness enough for this.
1093 * src/modest-ui-actions.c:
1094 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1095 make all outboxes appear as one, in the usual local-folders tree node.
1097 (set_active_account_from_tny_account),
1098 (modest_ui_actions_on_folder_selection_changed):
1099 * src/widgets/modest-folder-view.c: (text_cell_data),
1100 (icon_cell_data), (filter_row),
1101 (add_account_folders_to_merged_folder),
1102 (add_account_folders_to_simple_folder_store), (),
1103 (get_cmp_rows_type_pos), (cmp_rows),
1104 (modest_folder_view_set_account_id_of_visible_server_account):
1105 Adjust to the new outbox system, using generic folder stores and folders
1106 in the GtkTreeModel.
1108 2007-05-23 Christian Kellner <ckellner@openismus.com>
1110 * src/modest-mail-operation.c:
1111 (modest_mail_operation_update_account):
1112 Use info->max_size instead of unintialized local var [small
1113 build fix]. (Added TODO to review that change since I don't
1116 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1118 * libmodest-dbus-client/libmodest-dbus-client.c:
1119 (libmodest_dbus_client_compose_mail): function added
1120 * src/dbus_api/modest-dbus-api.h:
1121 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1122 (on_compose_mail): Implementation of the SendAsMail functionality
1124 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1126 * src/modest-account-mgr.c:
1127 (modest_account_mgr_add_server_account): Set the secure-connection
1128 conf key for transport accounts as well as store accounts. I don't know
1129 why the if was there. For instance, this makes sure that we use SSL
1130 for the gmail preset from the easysetup wizard.
1132 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1134 * src/gnome/modest-main-window.c:
1135 (on_account_store_connecting_finished), (connect_signals):
1136 * src/maemo/modest-main-window.c:
1137 (on_account_store_connecting_finished), (connect_signals),
1138 (modest_main_window_new):
1139 Handle TnyAccountStore::connecting-finished instead of
1140 TnyDevice::connection-changed, because we cannot actually perform
1141 operations on accounts until TnyAccountStore has itself responded to
1142 the TnyDevice::connection-changed signal. This prevents a GError from
1144 Do not try to update at startup, because we (at least on scratchbox)
1145 already do an update at startup when the device goes online.
1146 This prevents a GError from tinymail.
1147 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1148 Added TODO about stopping simultaneous operations.
1150 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1152 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1153 * src/modest-mail-operation-queue.c:
1154 (modest_mail_operation_queue_remove):
1155 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1156 about where they happened.
1158 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1160 * src/modest-ui-actions.c:
1161 (modest_ui_actions_on_password_requested): Make sure that the remember
1162 output parameter is always TRUE.
1164 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1166 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1167 Show a OK/Cancel dialog if the error is a question, though we still do not
1168 know anything more about what we are asking the user.
1169 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1170 Fix an uninitialized variable (helper). This is a logic error, however.
1172 2007-05-21 Christian Kellner <ckellner@openismus.com>
1174 * src/modest-search.h:
1175 Correct bit shifting in the ModestSearchFlags enum.
1177 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1179 * src/modest-tny-account.c:
1180 (modest_tny_account_new_from_server_account): Do not use the lsub and
1181 check-all hard-coded IMAP options when using POP.
1183 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1185 * src/modest-tny-account.c:
1186 (modest_tny_account_new_from_server_account):
1187 Use NULL for the secure-auth method for POP when Password auth has been
1188 specified by the user, as we already do for IMAP. "auth=Login" causes
1189 an error from camel or the server.
1191 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1193 * src/maemo/modest-account-settings-dialog.c:
1194 (create_page_account_details),
1195 (modest_account_settings_dialog_set_account_name):
1196 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1197 for the leave-on-server checkbox, rathr than just the checkbox, when
1198 the protocol is not POP.
1200 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1202 * src/widgets/modest-account-view.c:
1203 * src/widgets/modest-account-view.h:
1204 Added modest_account_view_select_account() which will be useful later
1205 to asynchronously re-select the edited account.
1207 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1209 * src/maemo/modest-account-settings-dialog.c:
1210 (modest_account_settings_dialog_set_account_name):
1211 Automatically choose the port numbers based on the secure authentication
1212 methods, if they have not been chosen before.
1213 This fixes projects.maemo.org bug NB#56273 .
1215 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1217 * src/maemo/modest-main-window-ui.h:
1218 * src/modest-ui-actions.c:
1219 * src/modest-ui-actions.h:
1220 Connect the Tools/SMTP Servers menu item to
1221 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1222 SMTP servers dialog, as in the UI specification and saves changes when it
1223 is closed. This fixed projects.maemo.org bug NB#56305 .
1225 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1227 * src/maemo/modest-connection-specific-smtp-window.c:
1228 (modest_connection_specific_smtp_window_init):
1229 Use gtk_window_set_default_size() to make this window big enough, so
1230 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1232 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1234 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1235 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1236 (modest_connection_specific_smtp_edit_window_init),
1237 Do not try to connect to a combobox signal before the combobox exists.
1238 This fixes the cras in projects.maemo.org bug NB#56288 .
1239 (modest_connection_specific_smtp_edit_window_get_settings):
1240 Remove the server_account_name parameter which was being checked for NULL
1241 though it was not used.
1243 * src/maemo/modest-connection-specific-smtp-window.c:
1244 (modest_connection_specific_smtp_window_fill_with_connections),
1245 (on_button_edit), (modest_connection_specific_smtp_window_init):
1246 Correct the number of treemodel columns to prevent a warning.
1247 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1248 libconic does not work.
1250 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1252 * src/modest-tny-account.c:
1253 (modest_tny_account_new_from_server_account):
1254 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1255 SMTP when "None" was chosen by the user. However, with my SMTP server that
1256 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1259 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1261 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1262 to explain the memory management issue with the ID in the ModestPair.
1264 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1265 (add_sending_page), (modest_account_assistant_finalize):
1266 * src/gnome/modest-gnome-global-settings-dialog.c:
1267 (create_updating_page), (create_composing_page):
1268 * src/gnome/modest-msg-edit-window.c: (get_transports),
1269 (init_window), (modest_msg_edit_window_finalize),
1270 (modest_msg_edit_window_get_msg_data):
1271 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1272 * src/gnome/modest-transport-widget.c:
1273 (modest_transport_widget_finalize), (smtp_configuration):
1274 * src/maemo/modest-maemo-global-settings-dialog.c:
1275 (create_updating_page), (create_composing_page):
1276 * src/maemo/modest-msg-edit-window.c: (get_transports),
1277 (init_window), (modest_msg_edit_window_finalize),
1278 (modest_msg_edit_window_get_msg_data),
1279 (modest_msg_edit_window_free_msg_data):
1280 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1281 (modest_store_widget_finalize):
1282 * src/maemo/modest-transport-widget.c:
1283 (modest_transport_widget_finalize), (smtp_configuration):
1284 * src/modest-main.c: (send_mail):
1285 * src/widgets/modest-combo-box.h:
1286 * src/widgets/modest-global-settings-dialog-priv.h:
1287 * src/widgets/modest-global-settings-dialog.c:
1288 (modest_global_settings_dialog_finalize):
1289 * src/widgets/modest-msg-edit-window.h:
1290 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1291 as long as the combo box, to prevent use of freed memory for the ID.
1293 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1295 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1296 get_accounts(), to make this clearer. Do not check for the enabled gconf
1297 key, because we do not use this for server accounts (at least, not yet).
1298 This allows us to send email again.
1300 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1302 * src/maemo/modest-platform.c:
1303 (on_modest_conf_update_interval_changed), (modest_platform_init):
1304 Only respond to this particular key change. All these strcmp()s cannot be
1307 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1309 * src/maemo/modest-maemo-global-settings-dialog.c:
1310 (current_connection): Prevent a crash in scratchbox when
1311 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1312 * src/maemo/modest-platform.c:
1313 (on_modest_conf_update_interval_changed), (modest_platform_init):
1314 Get the update interval from gconf and reset it when the gconf key changes.
1316 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1318 * src/modest-protocol-info.c:
1319 * src/modest-protocol-info.h: Adde enum-specific get functions,
1320 instead of using a ModestProtocolType enum parameter.
1322 * src/gnome/modest-account-assistant.c:
1323 * src/gnome/modest-store-widget.c:
1324 * src/gnome/modest-store-widget.h:
1325 * src/gnome/modest-transport-widget.c:
1326 * src/gnome/modest-transport-widget.h:
1327 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1328 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1329 * src/maemo/easysetup/modest-easysetup-wizard.c:
1330 * src/maemo/modest-account-settings-dialog.c:
1331 * src/maemo/modest-account-settings-dialog.h:
1332 * src/maemo/modest-store-widget.c:
1333 * src/maemo/modest-store-widget.h:
1334 * src/maemo/modest-transport-widget.c:
1335 * src/maemo/modest-transport-widget.h:
1336 * src/modest-account-mgr-helpers.c:
1337 * src/modest-account-mgr-helpers.h:
1338 * src/modest-account-mgr.c:
1339 * src/modest-account-mgr.h:
1340 * src/modest-tny-account.c:
1341 * src/modest-tny-folder.c:
1342 * src/widgets/modest-account-view.c:
1343 * src/widgets/modest-retrieve-combo-box.c:
1344 * src/widgets/modest-retrieve-combo-box.h:
1345 * src/widgets/modest-secureauth-combo-box.c:
1346 * src/widgets/modest-serversecurity-combo-box.c:
1347 * src/widgets/modest-serversecurity-combo-box.h:
1348 * tests/check_account-mgr.c:
1349 Use the specific functions, and use the re-renamed enum values for GNOME too.
1351 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1353 * src/modest-pair.h:
1354 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1355 so we can get the second based on the first.
1357 * src/maemo/modest-account-settings-dialog.h:
1358 * src/maemo/modest-account-settings-dialog.c:
1359 Added get_supported_secure_authentication_methods(), though it is mostly
1360 commented-out for now until the necessary API is committed to tinymail.
1361 (modest_account_settings_dialog_set_account_name),
1362 (save_configuration): Request the supported authentication methods from the
1363 server, so we can choose a working method.
1365 * src/modest-tny-account-store.h:
1366 * src/modest-tny-account-store.c:
1367 (modest_tny_account_store_get_session): Rename from
1368 tny_account_store_get_session().
1370 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1372 * src/modest-protocol-info.h: Split the ModestProtocol enum
1373 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1374 There was no need to have these unrelated values in one enum.
1376 * src/: many files: Adapted to changed enum. This makes the code a bit
1377 clearer, and the compiler could catch some errors.
1379 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1381 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1382 Show the detailed internal camel error message when an error happens
1383 during the configuration, so that our testers can give us more clues.
1384 For instance, in projects.maemo.org bug NB#56910 .
1386 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1388 * src/modest-tny-account.c:
1389 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1390 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1392 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1394 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1395 * src/maemo/modest-account-settings-dialog.c:
1396 (modest_account_settings_dialog_set_account_name),
1397 (save_configuration): For the incoming secure authentication checkbox,
1398 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1399 the UI specification. PLAIN does not seem to be supported for most IMAP
1400 servers anyway, and I am not sure what it would mean.
1401 However, we probably need to discover which of the secure-authentication
1402 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1403 * src/modest-account-mgr-helpers.c:
1404 (modest_account_mgr_get_server_account_data):
1406 * src/modest-tny-account.c:
1407 (modest_tny_account_new_from_server_account):
1408 Use tny_account_set_mech() to set secure-authentication methods,
1409 with some special-casing for IMAP, based on my observations of how
1412 * src/modest-account-mgr-helpers.h:
1413 * src/modest-account-mgr.c:
1414 * src/modest-defs.h: Comment that the URI is only used for local folders.
1416 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1418 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1419 parameter const, just to be neat.
1420 * src/modest-text-utils.c: (modest_text_utils_inline):
1421 End g_strconcat() with NULL, as its documentation says. This is almost
1422 certainly the cause of my crash at startup on the device. Interestingly,
1423 valgrind doesn't tell us about these errors.
1425 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1427 * scripts/build-packages: Added more precise comments about how to use
1428 this script, though I still get this error:
1429 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1430 error building tinymail
1432 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1434 * src/maemo/modest-main-window.c: (on_account_update):
1435 Very slight cleanup, hoping to make it simpler to discover what causes
1436 a crash here sometimes.
1438 * src/modest-tny-account.c:
1439 (modest_tny_account_new_from_server_account): Set the port. Added
1440 comments about the options and a TODO comment because I need to find out
1441 how to specify the secure authentication method.
1443 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1445 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1446 changed CFlags paths form modest to libmodest
1448 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1450 * src/modest-account-mgr-helpers.c:
1451 (modest_account_mgr_get_server_account_data),
1452 (modest_account_mgr_free_server_account_data):
1453 * src/modest-account-mgr-helpers.h:
1454 * src/modest-account-mgr.c:
1455 (modest_account_mgr_add_server_account):
1456 * src/modest-defs.h:
1457 * src/modest-tny-account.c:
1458 (modest_tny_account_new_from_server_account):
1459 Determine the options for tny_camel_account_add_option() here,
1460 based on the settings, rather than storing them directly in gconf.
1462 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1465 Show a more friendly error dialog now that we expect (from the tinymail
1466 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1468 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1470 * src/maemo/modest-main-window.c: (on_account_update): Check that
1471 account_name is not NULL, to prevent a crash at startup that I am
1472 seeing on the N800. I do wonder why it is NULL.
1474 * src/maemo/easysetup/modest-easysetup-wizard.c:
1475 (create_page_user_details):
1476 * src/maemo/modest-account-settings-dialog.c:
1477 (create_page_user_details), (create_page_outgoing):
1478 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1479 (modest_connection_specific_smtp_edit_window_init):
1480 * src/modest-ui-actions.c:
1481 (modest_ui_actions_on_password_requested):
1482 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1483 might do something useful with the on-screen keyboard.
1485 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1487 * src/maemo/modest-main-window.c: (on_account_update):
1488 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1489 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1491 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1493 * src/modest-tny-account-store.c: (on_account_changed):
1494 Correct the signature of this signal handler.
1496 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1498 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1499 Show a HildonNote instead of a GtkDialog for Maemo.
1501 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1503 * src/widgets/modest-account-view.h:
1504 * src/widgets/modest-account-view.c: (on_account_changed),
1505 (on_account_removed). Added a boolean flag, set/unset by
1506 modest_account_view_block_conf_updates(),
1507 modest_account_view_unblock_conf_updates() to prevent unnecessary
1508 updates, but this is not very useful because the gconf notifications are
1509 so delays (maybe only on Maemo Bora).
1510 So auto-updating is turned off, and these functions do an explicit
1511 update when necessary.
1512 However, something else is still doing too much work when adding/removing
1513 accounts, probably in another part of the application.
1515 * src/maemo/modest-account-view-window.c:
1516 (on_delete_button_clicked), (on_edit_button_clicked),
1517 (on_new_button_clicked): Use the new functions.
1519 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1521 * src/modest-account-mgr-helpers.c:
1522 (modest_account_mgr_set_first_account_as_default):
1523 Sort the list of names alphabetically-by-title, so we choose the first one
1525 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1526 alphabetically by the title.
1528 This fixes projects.maemo.org bug NB#56418 .
1530 * src/modest-account-mgr-priv.c:
1531 (_modest_account_mgr_account_from_key):
1532 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1533 avoid a valgrind error, and possible random behaviour.
1535 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1537 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1538 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1539 tinymail documentation to say that this can be expected.
1540 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1541 pretty, and should not happen, but I would prefer to know when it does.
1543 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1545 * configure.ac: When using the older hildon version, probably on Bora,
1546 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1548 * src/widgets/modest-attachment-view.c:
1549 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1552 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1554 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1555 Implemented the prototype. Can be tested with
1556 tests/dbus_api/test_open_message:
1558 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1560 * src/modest-tny-account-store.c:
1561 (modest_tny_account_store_instance_init), (get_password):
1562 * src/modest-ui-actions.c:
1563 (modest_ui_actions_on_password_requested):
1564 Do not store the password in gconf, because this function is called
1565 for non-remembered passwords. Actually use the cached (in the hash map)
1566 password instead of releasing it.
1567 The password will now not be remembered if it is asked via the protected
1568 password dialog, as per the UI spec.
1570 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1572 * src/modest-defs.h:
1573 * src/modest-account-mgr-helpers.h:
1574 * src/modest-account-mgr-helpers.c:
1575 Added modest_server_account_get_username_has_succeeded(),
1576 modest_server_account_set_username_has_succeeded().
1577 (modest_server_account_set_username),
1578 Reset the has-succeeded flag if the username changes.
1580 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1581 * src/maemo/modest-connection-specific-smtp-window.c:
1582 (modest_connection_specific_smtp_window_save_server_accounts):
1583 Use modest_server_account_set_username() instead of using
1584 modest_conf_set_string() directly, so that the has-succeeded flag is always
1587 * src/modest-ui-actions.c:
1588 (modest_ui_actions_on_password_requested): Dim the username entry if
1589 the username has ever worked, as per the UI spec.
1591 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1593 * src/modest-tny-account-store.c: (get_password):
1594 * src/modest-ui-actions.c:
1595 (modest_ui_actions_on_password_requested):
1596 Allow the username to be changed too, though there is more work to
1597 be done on exactly how this behaves.
1599 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1601 * src/modest-account-mgr-helpers.h:
1602 * src/modest-account-mgr-helpers.c:
1603 Added modest_account_mgr_get_display_name(),
1604 modest_server_account_get_username(),
1605 modest_server_account_set_username(),
1606 modest_server_account_set_password(),
1607 modest_server_account_get_hostname() functions so we do not need to
1608 use the conf API directly.
1610 * src/maemo/modest-main-window.c: (connect_signals):
1611 Actually connect ot the ModestAccountStore::request-password signal,
1612 so that we show the dialog when the password is requested by Tinymail,
1613 for isntance if it is empty.
1615 * src/modest-marshal.list:
1616 * src/modest-tny-account-store.c:
1617 (modest_tny_account_store_class_init), (get_password),
1618 (modest_tny_account_store_alert):
1619 * src/modest-tny-account-store.h:
1620 * src/modest-ui-actions.h:
1621 * src/modest-ui-actions.c:
1622 (modest_ui_actions_on_password_requested):
1623 Change the signal parameters, so it is obvious that we are providing
1624 the non human-readable server name, and receiving both the username
1625 and password, though changing of the username is not yet implemented.
1626 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1627 for the GNOME version.
1629 This should fix the projects.maemo.org bug NB#56209, though it does not
1630 work on Bora, because the gconf_client_get() for the password fails
1631 immediately after we save it with gconf_client_set().
1633 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1636 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1637 caused an undefined symbol error:
1638 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1640 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1642 * src/modest-tny-account-store.c:
1643 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1644 using a GError instead of a string message, so we can translate it in
1647 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1649 * src/maemo/modest-address-book.c:
1650 (modest_address_book_check_names):
1651 * src/maemo/modest-msg-view-window.c:
1652 (modest_msg_view_window_clipboard_owner_change):
1653 * src/modest-init.c: (modest_init_init_ui):
1654 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1655 (update_folders_cb), (modest_mail_operation_update_account):
1656 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1657 (modest_ui_actions_on_msg_attachment_clicked),
1658 (modest_ui_actions_on_msg_recpt_activated):
1659 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1660 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1661 (modest_msg_view_search_next):
1662 * src/widgets/modest-recpt-editor.c:
1663 (modest_recpt_editor_on_button_release_event),
1664 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1665 g_message(). At this point we should only be seeing interesting errors on
1666 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1668 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1670 (modest_wizard_dialog_force_title_update):
1671 * src/maemo/easysetup/modest-wizard-dialog.h:
1672 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1673 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1674 can update the title when appropriate. Otherwise the title is wrong if the
1675 pages are added after adding the notebook to the dialog.
1676 This must be a problem in HildonWizardDialog too.
1677 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1679 * src/maemo/easysetup/modest-easysetup-wizard.c:
1680 (create_subsequent_customsetup_pages),
1681 (create_subsequent_easysetup_pages):
1682 Call modest_wizard_dialog_force_title_update() so that the title is
1683 correct even with GTK+ < 2.10.
1684 This fixes projects.maemo.org bug NB#56145 .
1686 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1688 * src/maemo/modest-platform.c:
1689 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1690 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1693 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1695 * src/widgets/modest-window.h:
1696 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1697 and modest_window_save_state(), which invokes it.
1699 * src/widgets/modest-window-mgr.h:
1700 * src/widgets/modest-window-mgr.c:
1701 Added modest_window_mgr_save_state_for_all_windows(), which calls
1702 the save_state vfunc on all registered windows, if implemented.
1704 * src/gnome/modest-msg-edit-window.c:
1705 * src/gnome/modest-msg-view-window.c:
1706 * src/maemo/modest-msg-edit-window.c:
1707 * src/maemo/modest-msg-view-window.c:
1708 * src/maemo/modest-main-window.c:
1709 Specify the existing save_settings functions as implementations of
1710 ModestWindow::save_state_func().
1712 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1713 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1714 enabling hibernation, for instance.
1716 We may need to do the same thing for restoring settings.
1719 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1721 * src/widgets/modest-window-mgr.c:
1722 * src/widgets/modest-window-mgr.h:
1723 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1724 modest_window_mgr_get_hibernation_is_prevented().
1726 * src/maemo/modest-main-window.c:
1727 (on_hildon_program_is_topmost_notify): Prevent hibernation
1728 (possible when the application goes to the background in the WM),
1729 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1731 * src/maemo/easysetup/modest-easysetup-wizard.c:
1732 (modest_easysetup_wizard_dialog_init):
1733 * src/maemo/modest-account-settings-dialog.c:
1734 (modest_account_settings_dialog_init):
1735 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1736 (modest_connection_specific_smtp_edit_window_init):
1737 * src/maemo/modest-connection-specific-smtp-window.c:
1738 (modest_connection_specific_smtp_window_init):
1739 * src/maemo/modest-signature-editor-dialog.c:
1740 (modest_signature_editor_dialog_init):
1741 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1742 prevent hibernation while any of these account settings dialogs are open.
1744 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1746 * src/maemo/Makefile.am:
1747 * src/maemo/modest-osso-state-saving.c:
1748 * src/maemo/modest-osso-state-saving.h: Added
1749 modest_osso_load_state() and modest_osso_save_state() though they do
1750 nothing now. They should iterate through all the open windows and load/save
1752 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1753 save state when closing.
1755 * src/maemo/modest-main-window.c:
1756 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1757 Add a notification handler for the HildonProgram::is-topmost property,
1758 so we can allow hibernation when the application goes into the background.
1759 But we still need to detect when the accounts setup windows are open so
1760 we can stop hibernation when they are open.
1761 To do this, I also added the main window the HildonProgram. This might have
1762 other side-effects/benefits, and should maybe be done for other windows.
1764 * src/maemo/modest-osso-autosave-callbacks.h:
1765 * src/maemo/modest-osso-autosave-callbacks.c:
1766 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1767 though it does not do anything yet, and we might never need this to do
1768 anything. For instance, we already save drafts.
1770 * src/maemo/modest-platform.c: (modest_platform_init):
1771 Specify the libosso auto-save callback.
1773 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/modest-platform.c:
1776 (modest_platform_set_update_interval):
1777 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1778 aparently stays valid between application instances, so we can use this
1779 to remove and reset it later. According to a maemo-developers email from
1782 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1784 * configure.ac: Depend on libalarm for Maemo.
1786 * src/dbus_api/modest-dbus-api.h:
1787 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1788 (on_send_receive), (modest_dbus_req_handler):
1789 Handle a SEND_RECEIVE D-Bus method.
1791 * libmodest-dbus-client/libmodest-dbus-client.c:
1792 (libmodest_dbus_client_send_and_receive):
1793 * libmodest-dbus-client/libmodest-dbus-client.h:
1794 Add C convenience functions for calling the new D-Bus method.
1796 * src/modest-platform.h:
1797 * src/gnome/modest-platform.c:
1798 * src/maemo/modest-platform.c:
1799 Added modest_platform_set_update_interval(), which uses the
1800 alarmd API on Maemo.
1801 (modest_platform_init),
1802 Call modest_platform_set_update_interval(), using a hard-coded
1803 interval for now (until the global settings dialog is implemented),
1804 though I am not sure that this makes sense yet.
1806 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1808 * src/dbus_api/modest-dbus-callbacks.c:
1809 (modest_osso_cb_hw_state_handler):
1810 * src/dbus_api/modest-dbus-callbacks.h:
1811 * src/maemo/modest-platform.c: (modest_platform_init):
1812 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1813 in case this has some effect on the ability for Maemo to ping the
1816 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1818 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1819 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1820 warning. It is probably a logic error, but I need to fix the build.
1822 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-account-mgr.h:
1825 * src/modest-account-mgr.c:
1826 (modest_account_mgr_account_names): Add a gboolean enabled_only
1827 parameter, so we can get lists of onlt the enabled accounts.
1829 (modest_account_mgr_add_account),,
1830 (modest_account_mgr_account_with_display_name_exists):
1831 * src/maemo/modest-msg-edit-window.c: (get_transports):
1832 * src/modest-account-mgr-helpers.c:
1833 (modest_account_mgr_set_first_account_as_default):
1834 * src/modest-init.c: (init_default_account_maybe):
1835 * src/modest-tny-account-store.c: (get_accounts):
1836 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1837 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1838 * tests/check_account-mgr.c: (START_TEST):
1839 Provide the extra parameter, as appropriate.
1841 * src/widgets/modest-account-view.c: (update_account_view):
1842 Do not show disabled accounts (meaning that there is no way to
1843 enable/disable accounts in the UI (the feature is not in our UI
1844 specification), so we can use this internally only to mark unfinished
1845 or temporary account data.
1847 * src/maemo/easysetup/modest-easysetup-wizard.c:
1848 (create_account): Add boolean enable parameter, so we can specify FALSE
1849 to create the temporary account.
1850 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1851 (on_before_next): When finishing, when there is a temporary account, just
1853 Also, use a timeout to delay the showing of the dialog until gconf is likely
1854 to return correct information, due to a maemo gconf bug that is fixed in
1855 osso 1.1, but not yet in Bora.
1856 However, the dialog stays on screen after it is destroyed.
1858 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1859 for invalid data when cancelling. Use a hildon note instead of a dialog
1860 to complain about invalid data. Do not show the account-saved note if the
1861 account is disabled (a temporary account that will not really be saved for use
1864 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1866 * src/modest-account-mgr-helpers.h:
1867 * src/modest-account-mgr-helpers.c:
1868 Added modest_account_mgr_unset_default_account(),
1869 Added modest_account_mgr_set_first_account_as_default().
1871 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1872 If it was the default account, unset the default account name.
1874 * src/maemo/modest-account-view-window.c:
1875 (on_delete_button_clicked): If it was the default account,
1876 set the first remaining account as the default instead.
1878 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1879 a NULL account or a NULL default account, to prevent a crash. This should
1880 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1883 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1885 * src/widgets/modest-recpt-editor.c:
1886 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1887 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1888 TODO comment for this. This fixes the build.
1890 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1891 be the best place for it. This will in future update all auto-update accounts,
1892 rather than just the current/default account, when that gconf key exists.
1893 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1894 if there are no accounts, before calling do_send_receive().
1895 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1897 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1898 * src/maemo/modest-main-window-ui.h:
1899 * src/maemo/modest-main-window.c: (on_connection_changed),
1900 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1901 directly, becaue the signal handler does more.
1903 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1905 * src/modest-account-mgr-helpers.c:
1906 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1907 for the case that the account does not exist.
1909 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1910 (equivalent to the modest account name) rather than the tinymail account name
1911 (equivalent to the modest account title - human readable) to get the account data.
1912 Check for null account data to prevent the crash, and add a TODO comment saying that
1913 this needs fixing because it is using the server account name instead of the account name.
1915 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1917 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1918 * src/maemo/modest-account-settings-dialog.c: (show_error),
1920 Use hildon_note_new_information() for informative and error messages,
1921 which seems to be expected for Maemo applications (no documentation that I know of
1922 says this). I am surprised that there is no distinction between info and error
1925 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1927 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1928 it is easy to find where this is used.
1930 * src/maemo/easysetup/modest-easysetup-wizard.c:
1931 (create_page_welcome), (create_page_account_details),
1932 (create_page_user_details), (create_page_complete_easysetup),
1933 (create_page_custom_incoming), (create_page_custom_outgoing),
1934 (create_page_complete_custom):
1935 * src/maemo/modest-account-settings-dialog.c:
1936 (create_page_account_details), (create_page_user_details),
1937 (create_page_incoming), (create_page_outgoing):
1938 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1939 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1940 (modest_connection_specific_smtp_edit_window_init):
1941 * src/maemo/modest-connection-specific-smtp-window.c:
1942 (modest_connection_specific_smtp_window_init):
1943 * src/maemo/modest-signature-editor-dialog.c:
1944 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1945 and scrolling policy as per the Email Application Layout Guide, if I have
1948 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1950 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1951 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1952 which were empty, because these vfuncs have been removed from TnyAccountStore.
1953 This fixes the build.
1955 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1957 * src/maemo/modest-main-window.c:
1958 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1959 showing/hiding it. Added TODO because it probably should not be NULL.
1960 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1961 because unnecessary g_warnings() make degugging difficult.
1963 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1965 * src/maemo/modest-msg-edit-window.c:
1966 (modest_msg_edit_window_select_color),
1967 (modest_msg_edit_window_select_background_color): 2 const corrections and
1968 moving 2 #endifs before closing brackets, to fix the build.
1970 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1972 * src/maemo/easysetup/modest-easysetup-wizard.h:
1973 * src/maemo/easysetup/modest-easysetup-wizard.c:
1974 (modest_easysetup_wizard_dialog_finalize),
1975 (on_button_edit_advanced_settings), (create_page_complete_custom),
1976 (on_response), (create_account):
1977 Implement the Advanced Settings edit button, by saving the account information,
1978 for the Advanded Settings dialog to use directly from gconf, and removing it
1979 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1980 Bug #5533 in the projects.maemo.org bugzilla.
1982 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1984 * src/maemo/modest-msg-view-window.c:
1985 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1986 when opening a message window.
1988 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1990 * src/maemo/easysetup/modest-easysetup-wizard.c:
1991 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1994 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1995 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1996 gconf settings. I probably added more checks than necessary, but that is safer.
1998 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1999 variable to fix the build, but this seems to be used when it is still NULL.
2001 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2003 * src/modest-platform.h:
2004 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2005 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2006 * src/modest-main.c: Implement this function so we can avoid using
2007 maemo-specific API from cross-platform code.
2009 * src/modest-tny-account-store.c:
2010 (get_smtp_specific_transport_account_for_open_connection):
2011 * src/modest-ui-actions.c: (check_for_connection),
2012 (modest_ui_actions_on_item_not_found):
2013 Use modest_platform_connect_and_wait() and put #idefs around other
2014 maemo-specific code, because only maemo currently has a way to
2015 identify connection names.
2017 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2019 * src/modest-tny-account-store.h:
2020 * src/modest-tny-account-store.c:
2021 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2022 the connection-specific SMTP server settings in the configuration.
2024 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2026 * src/maemo/modest-main-window.c: (on_connection_changed),
2028 * src/modest-main.c: (main), (start_ui), (send_mail):
2029 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2030 that is what is intended.
2032 * src/modest-ui-actions.c: (action_send), (action_receive),
2033 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2034 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2035 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2036 SMTP server is used when it is specified.
2038 (modest_ui_actions_on_send_receive):
2039 Check that a connection is open before proceeding.
2040 Receive and then send, instead of vice-versa, as per the specification.
2042 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2044 * src/modest-mail-operation.c:
2045 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2046 though I guess it should be something other than NULL.
2048 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2050 * src/maemo/easysetup/modest-easysetup-wizard.c:
2051 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2052 combo twice, to avoid an g_warning and to make it visible again.
2053 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2054 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2055 (already intended) dereference when detaching, because we then recreate the menu.
2056 But I am not sure why the warning was happening, and it is possible that this is a memory
2059 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2061 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2062 and uri_parse_mailto() utility functions.
2063 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2065 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2067 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2069 * src/dbus_api/modest-dbus-api.h:
2070 * src/dbus_api/modest-dbus-callbacks.c:
2071 Use an idle callback to execute the modest code in the application's own thread.
2072 Remove the helloworld example method.
2073 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2074 parsed, and the open-message method is not implemented because this is not yet implemented in
2076 * libmodest-dbus-client/libmodest-dbus-client.c:
2077 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2078 (libmodest_dbus_client_open_message):
2079 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2081 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2082 body without crashing.
2084 * tests/dbus_api/Makefile.am:
2085 * tests/dbus_api/test_mail_to.c:
2086 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2088 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2090 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2091 Added file to fix the build. Sorry.
2093 * src/dbus_api/Makefile.am:
2094 * src/dbus_api/modest-dbus-api.h:
2095 * src/dbus_api/modest-dbus-callbacks.h:
2096 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2097 (modest_dbus_req_handler):
2098 Put constants in a separate header so it can be reused by the
2099 client library, without duplication
2101 * libmodest-dbus-client/Makefile.am:
2102 * libmodest-dbus-client/libmodest-dbus-client.c:
2103 (libmodest_dbus_client_call_helloworld),
2104 (libmodfest_dbus_client_send_mail),
2105 (libmodfest_dbus_client_mailto),
2106 (libmodfest_dbus_client_open_message):
2107 * libmodest-dbus-client/libmodest-dbus-client.h:
2108 (Partly) Implement a send_mail D-Bus method.
2110 * tests/dbus_api/Makefile.am:
2111 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2112 the send_email D-Bus method.
2114 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2118 * libmodest-dbus-client/Makefile.am:
2119 * libmodest-dbus-client/libmodest-dbus-client.c:
2120 * libmodest-dbus-client/libmodest-dbus-client.h:
2121 * tests/dbus_api/Makefile.am:
2122 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2123 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2125 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2127 * src/maemo/easysetup/modest-easysetup-wizard.c:
2128 (create_page_account_details):
2129 * src/maemo/modest-account-settings-dialog.c:
2130 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2131 widgets, because this might not be the default in future versions of the Maemo GTK+.
2132 However, I can not not get capitalization to work even in a simple test case.
2134 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2136 * src/maemo/easysetup/modest-easysetup-wizard.c:
2137 (create_page_custom_incoming), (create_page_custom_outgoing):
2138 * src/maemo/modest-account-settings-dialog.c:
2139 (create_page_account_details), (create_page_incoming),
2140 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2141 instead of using gtk_check_button_with_label(), so they are aligned like the other
2142 widgets, as per the UI spec.
2144 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2146 * src/maemo/easysetup/modest-easysetup-wizard.c:
2147 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2148 * src/widgets/modest-validating-entry.c:
2149 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2150 Modest prefix instead of an EasySetup prefix.
2152 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2154 * src/widgets/modest-validating-entry.h:
2155 * src/widgets/modest-validating-entry.c: (on_insert_text),
2156 Added easysetup_validating_entry_set_max_func(), used to set a callback
2157 to call when the max number of characters is reached. GtkEntry has a max-length
2158 already but is silent about it.
2160 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2161 (create_page_account_details), (create_page_user_details),
2163 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2164 (create_page_account_details), (create_page_user_details),
2165 (create_page_outgoing):
2166 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2167 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2168 the UI spec, when the user tries to enter more than the max number of characters.
2170 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/easysetup/modest-easysetup-wizard.c:
2173 (create_page_user_details), (create_page_custom_incoming),
2174 (create_page_custom_outgoing):
2175 * src/maemo/modest-account-settings-dialog.c:
2176 (create_page_user_details), (create_page_incoming),
2177 (create_page_outgoing):
2178 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2179 (modest_connection_specific_smtp_edit_window_init):
2180 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2181 not appropriate. Bad Maemo-specific defaults!.
2183 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2185 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2186 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2187 (modest_signature_editor_dialog_set_settings):
2188 Disable the label and textview when the checkbox is disabled, and use the
2189 specified (UI spec) default signature text.
2191 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2193 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2194 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2196 * src/modest-defs.h:
2197 * src/modest-account-mgr-helpers.h:
2198 * src/modest-account-mgr-helpers.c:
2199 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2201 * src/maemo/Makefile.am:
2202 * src/maemo/modest-signature-editor-dialog.c:
2203 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2206 * src/maemo/modest-account-settings-dialog.h:
2207 * src/maemo/modest-account-settings-dialog.c:
2208 (modest_account_settings_dialog_finalize), (on_button_signature),
2209 (save_configuration): Use the new dialog when the Edit button is pressed, and
2210 save the changes if necessary, as per the UI spec.
2212 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2214 * src/maemo/Makefile.am:
2215 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2216 based on maemo-develoers email from Dirk.
2218 * src/maemo/easysetup/modest-easysetup-wizard.c:
2219 (create_page_welcome), (create_page_account_details),
2220 (create_page_user_details), (create_page_complete_easysetup),
2221 (create_page_custom_incoming), (create_page_custom_outgoing),
2222 (create_page_complete_custom),
2223 (modest_easysetup_wizard_dialog_init):
2224 * src/maemo/modest-account-settings-dialog.c:
2225 (create_page_account_details), (create_page_user_details),
2226 (create_page_incoming), (create_page_outgoing),
2227 (modest_account_settings_dialog_init):
2228 * src/maemo/modest-connection-specific-smtp-window.c:
2229 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2231 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2233 * src/maemo/easysetup/modest-easysetup-wizard.c:
2234 (create_page_account_details), (create_page_custom_outgoing),
2235 (create_page_complete_custom):
2236 * src/maemo/modest-account-settings-dialog.c:
2237 (create_page_user_details), (create_page_incoming),
2238 (create_page_outgoing):
2239 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2240 (modest_connection_specific_smtp_edit_window_init):
2241 Use the correct (UI spec) port min/max, and use horizontal separators,
2244 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2246 * src/maemo/easysetup/modest-easysetup-wizard.c:
2247 (set_default_custom_servernames):
2248 * src/maemo/modest-account-settings-dialog.c:
2249 (create_page_incoming), (on_combo_outgoing_security_changed),
2250 (on_combo_incoming_security_changed), (create_page_outgoing),
2251 (modest_account_settings_dialog_set_account_name),
2252 (save_configuration):
2253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2254 (on_combo_security_changed),
2255 (modest_connection_specific_smtp_edit_window_init),
2256 (modest_connection_specific_smtp_edit_window_set_connection),
2257 (modest_connection_specific_smtp_edit_window_get_settings):
2258 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2261 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2264 * src/maemo/easysetup/modest-easysetup-wizard.c:
2265 (create_page_custom_outgoing), (create_page_complete_custom):
2266 * src/maemo/modest-account-settings-dialog.c:
2267 (create_page_user_details), (create_page_outgoing):
2268 * src/maemo/modest-account-view-window.c: (button_box_new):
2269 Use changed logical IDs as per the most recent UI spec:
2270 mcen_bd_emailsetup_edit -> mcen_bd_edit
2271 mcen_bd_emailsetup_delete -> mcen_bd_delete
2272 mcen_bd_emailsetup_close -> mcen_bd_close
2274 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2278 * src/dbus_api/Makefile.am:
2279 * src/dbus_api/modest-dbus-callbacks.c:
2280 * src/dbus_api/modest-dbus-callbacks.h:
2281 * src/maemo/modest-platform.c: (modest_platform_init):
2282 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2284 * tests/Makefile.am:
2285 * tests/dbus_api/Makefile.am:
2286 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2288 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2290 * src/maemo/modest-account-settings-dialog.c:
2291 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2292 Removed unnecessary includes.
2294 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2296 * src/maemo/easysetup/modest-easysetup-wizard.c:
2297 * src/maemo/modest-account-settings-dialog.c:
2298 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2299 * src/widgets/Makefile.am:
2300 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2301 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2302 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2303 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2304 * src/widgets/modest-secureauth-combo-box.c:
2305 * src/widgets/modest-secureauth-combo-box.h:
2306 * src/widgets/modest-serversecurity-combo-box.c:
2307 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2308 made the GObject names more consistent with the rest of the Modest code.
2310 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2312 * src/maemo/easysetup/Makefile.am:
2313 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2314 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2315 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2316 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2317 * src/maemo/easysetup/modest-easysetup-wizard.c:
2318 * src/maemo/easysetup/modest-validating-entry.c:
2319 * src/maemo/easysetup/modest-validating-entry.h:
2320 * src/maemo/modest-account-settings-dialog.c:
2321 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2322 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2323 widgets/ because they are used outside of easysetup too. After checking in,
2324 svn will allow me to rename them too.
2326 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2328 * src/gnome/modest-msg-edit-window.c:
2329 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2330 linker error, to fix the build on the GNOME platform.
2331 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2332 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2333 ifdefed out to avoid a warning.
2335 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2337 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2338 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2339 some alternative for GTK+ 2.6.
2341 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2345 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2346 specified for EmailAccountsDialog in UI spec.
2348 * src/maemo/easysetup/modest-easysetup-wizard.c:
2349 * src/maemo/easysetup/modest-easysetup-wizard.h:
2350 * src/maemo/modest-account-settings-dialog.c:
2351 * src/maemo/modest-account-settings-dialog.h:
2352 Reuse a member window widget for the connection-specific SMTP server accounts,
2353 so we can tell it to create/save the accounts only if we actually save changes.
2355 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2356 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2357 (modest_connection_specific_smtp_edit_window_get_settings):
2358 Return a struct instance for temporarily remembering the entered data.
2360 * src/maemo/modest-connection-specific-smtp-window.h:
2361 * src/maemo/modest-connection-specific-smtp-window.c:
2362 (modest_connection_specific_smtp_window_finalize),
2363 (modest_connection_specific_smtp_window_fill_with_connections),
2365 (modest_connection_specific_smtp_window_save_server_accounts),
2366 (update_model_server_names): Do not actually save data until asked,
2367 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2369 (on_selection_changed),
2370 (modest_connection_specific_smtp_window_init): Disable the edit
2371 button when nothing is selected.
2373 * src/modest-account-mgr-helpers.c:
2374 * src/modest-account-mgr-helpers.h:
2375 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2378 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2380 * src/modest-account-mgr-helpers.h:
2381 * src/modest-account-mgr-helpers.c:
2382 (modest_account_mgr_get_unused_account_name),
2383 (modest_account_mgr_get_unused_account_display_name): Added these
2384 utility functions, to avoid code duplication.
2386 * src/maemo/easysetup/modest-easysetup-wizard.c:
2387 (create_page_account_details), (create_account):
2388 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2389 (on_combo_security_changed),
2390 (modest_connection_specific_smtp_edit_window_init),
2391 (modest_connection_specific_smtp_edit_window_save_settings):
2392 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2393 * src/maemo/modest-connection-specific-smtp-window.c:
2394 (modest_connection_specific_smtp_window_finalize),
2395 (modest_connection_specific_smtp_window_fill_with_connections),
2396 (on_button_edit), (modest_connection_specific_smtp_window_init):
2397 * src/maemo/modest-connection-specific-smtp-window.h:
2398 Implementing saving of connection-specific server accounts.
2400 But I need to refactor this so we can save the data for each
2401 possible connection-specific account and only actually create the server accounts
2402 when the easysetup finished, or the OK button is pressed on the account settings
2405 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2407 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2408 (on_combo_security_changed):
2409 (modest_connection_specific_smtp_edit_window_init):
2410 Auto-fill the port number as in the account settings.
2412 (modest_connection_specific_smtp_edit_window_set_connection):
2413 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2414 * src/maemo/modest-connection-specific-smtp-window.c:
2415 (fill_with_connections), (on_button_edit),
2416 (modest_connection_specific_smtp_window_init):
2417 Turn the edit window into a dialog to simplify the code, and
2418 set a WM hint as in a GtkDialog, because only a popup can be on top of
2419 another window in Maemo, and popups usually have no WM decoration.
2421 * src/modest-defs.h:
2422 * src/modest-account-mgr-helpers.c:
2423 (modest_account_mgr_set_connection_specific_smtp),
2424 (modest_account_mgr_remove_connection_specific_smtp),
2425 (modest_account_mgr_get_connection_specific_smtp):
2426 * src/modest-account-mgr-helpers.h: Some functions to write the
2427 connection-specific SMTP server information. Not yet used.
2430 * src/widgets/modest-folder-view.c: (text_cell_data):
2431 Fix a warning about an uninitialized variable.
2432 (on_configuration_key_changed): Put an #ifdef around the use
2433 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2435 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2437 * src/maemo/modest-account-settings-dialog.h:
2438 * src/maemo/modest-account-settings-dialog.c:
2439 Added connect_for_modified() utility function to mark the new modified boolean.
2441 (create_page_account_details), (create_page_user_details),
2442 (create_page_incoming), (create_page_outgoing), (on_response),
2443 (modest_account_settings_dialog_init),
2444 (modest_account_settings_dialog_set_account_name):
2445 Only warn about unsaved changes when there are actually unsaved changes.
2447 * src/modest-account-mgr-helpers.c:
2448 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2449 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2450 to get the data from there in future.
2452 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2454 * src/modest-defs.h:
2456 * src/modest-account-mgr-helpers.h:
2457 * src/modest-account-mgr-helpers.c:
2458 Store the security account setting in a single conf key instead of using
2459 the options list, so that the list is left for just the to-be-removed camel hack,
2460 and because gconf_client_set_list() is failing for some reason.
2462 * src/modest-account-mgr.c:
2463 (modest_account_mgr_add_server_account):
2464 * src/maemo/modest-account-settings-dialog.c:
2465 (modest_account_settings_dialog_set_account_name),
2466 (save_configuration): Use the renamed functions.
2469 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2471 * src/widgets/Makefile.am:
2472 * src/widgets/modest-limit-retrieve-combo-box.c:
2473 * src/widgets/modest-limit-retrieve-combo-box.h:
2474 * src/widgets/modest-retrieve-combo-box.c:
2475 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2476 the account settings dialog.
2478 * src/modest-defs.h:
2479 * src/modest-account-mgr-helpers.h:
2480 * src/modest-account-mgr-helpers.c:
2481 (modest_server_account_get_option_secure_auth),
2482 (modest_server_account_set_option_secure_auth):
2483 * src/modest-account-mgr.c:
2484 (modest_account_mgr_add_server_account):
2485 Use the existing AUTH_MECH conf key for the secure-auth setting,
2486 instead of putting it in the list options, because this was actually used already.
2488 * src/maemo/modest-account-settings-dialog.c:
2489 (create_page_account_details),
2490 (modest_account_settings_dialog_set_account_name),
2491 (save_configuration):
2492 * src/maemo/modest-account-settings-dialog.h:
2493 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2494 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2496 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2498 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2499 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2500 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2502 * src/modest-defs.h:
2503 * src/maemo/modest-account-settings-dialog.c:
2504 (create_page_incoming), (on_combo_outgoing_security_changed),
2505 (on_combo_incoming_security_changed), (create_page_outgoing),
2506 (modest_account_settings_dialog_set_account_name),
2507 (save_configuration): Load/Save the port number, and change it when the
2508 security combo changes, to suitable defaults.
2510 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2512 * src/modest-account-mgr.c:
2513 (modest_account_mgr_add_server_account): Set the security and secure-auth
2514 options, and add a comment saying that the other camel-specific options should be
2517 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2519 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2521 * src/modest-tny-account-store.c: (account_list_free),
2522 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2523 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2526 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2528 * src/modest-protocol-info.c:
2529 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2530 is required by our UI spec. Maybe something in our implementation will use this eventually.
2531 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2532 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2533 instead of the previous 0 placeholder.
2535 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2536 secure-auth settings.
2537 * src/modest-account-mgr-helpers.h:
2538 * src/modest-account-mgr-helpers.c:
2539 (modest_server_account_data_get_option_secure_auth),
2540 (modest_server_account_set_option_secure_auth),
2541 (modest_server_account_data_get_option_security),
2542 (modest_server_account_set_option_security): Added this API for getting and setting the security
2543 and secure-auth settings.
2545 * src/maemo/modest-account-settings-dialog.h:
2546 * src/maemo/modest-account-settings-dialog.c:
2547 (modest_account_settings_dialog_finalize), (check_data),
2548 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2549 about changing titles.
2550 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2551 (save_configuration): Save the security and secure-auth settings.
2553 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2554 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2556 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2558 * src/modest-defs.h:
2559 * src/modest-account-mgr.c:
2560 (modest_account_mgr_add_server_account):
2561 Added and used defines for the options key and value pair strings,
2562 that are used so far, though they do not seem to correspond to anything in our
2563 UI specs or ModestProtocol enum.
2565 * src/modest-account-mgr-helpers.h:
2566 * src/modest-account-mgr-helpers.c:
2567 (compare_option_strings_for_name),
2568 (modest_server_account_data_get_option_value),
2569 (modest_server_account_data_get_option_bool),
2570 (modest_account_mgr_get_server_account_option):
2571 Added helper functions for parsing the options GSList.
2573 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2575 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2576 display name is based on the supplied account name.
2577 * src/modest-account-mgr.c:
2578 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2579 with an inefficient, but good-enough, implementation.
2581 * src/maemo/easysetup/modest-easysetup-wizard.c:
2582 (create_page_account_details), (on_before_next), (create_account):
2583 Check for existing display names rather than (non-user-visible) account names, and just
2584 create and set a unique account name at the end.
2586 * src/maemo/modest-account-settings-dialog.c:
2587 (modest_account_settings_dialog_init),
2588 (modest_account_settings_dialog_set_account_name),
2589 (create_page_incoming): Show the display name, instead of the account name.
2590 (on_response): Do some (not all) extra checks, as in the UI spec.
2591 (save_configuration): Save the display name if it was changed.
2593 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2595 * po/en_GB.po: Added needed logical ID and translation.
2596 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2597 (init_view): Made the is-default column clicking work.
2599 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2602 * src/maemo/easysetup/Makefile.am:
2603 * src/maemo/easysetup/modest-easysetup-wizard.c:
2604 (modest_easysetup_wizard_dialog_init):
2605 * src/maemo/easysetup/provider-data-test.keyfile:
2606 * src/maemo/easysetup/provider-data.keyfile:
2607 Moved the provider data file to the new modest-providers-data package and used it from there.
2609 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2611 * src/modest-local-folder-info.c:
2612 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2613 N_() was already used on the static strings, but this just marks it for translation without
2614 using the translation.
2616 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/modest-account-settings-dialog.c:
2619 (create_page_incoming),
2620 (modest_account_settings_dialog_set_account_name):
2621 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2622 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2623 I will do this if nobody else gets there first.
2625 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2627 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2628 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2629 save the security stuff.
2631 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2633 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2634 Set the email address and user fullname, which I now see must be
2637 * src/maemo/modest-account-settings-dialog.h:
2638 * src/maemo/modest-account-settings-dialog.c:
2640 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2641 leave-on-server and authentication.
2642 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2645 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2648 * src/maemo/modest-account-settings-dialog.c:
2649 * src/maemo/modest-account-settings-dialog.h:
2650 Most (but not all) of the widgets are now present as specified by the UI spec.
2651 No changes are yet saved, and some details are not properly shown yet.
2653 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2655 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2657 * src/maemo/Makefile.am:
2658 * src/maemo/modest-account-settings-dialog.c:
2659 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2660 an existing account. Doesn't do much yet.
2662 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2663 Open the accounts settings dialog when Edit is clicked.
2665 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2667 * src/maemo/easysetup/Makefile.am:
2668 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2670 * src/maemo/easysetup/modest-easysetup-wizard.c:
2671 (modest_easysetup_wizard_dialog_init):
2672 Try to get the source directory from the build system,
2673 instead of hard-coding "./" into the source code, when opening our local
2674 copies of the configuration files.
2675 But this still fails when opening the wizard from the Accounts window,
2676 maybe because the working directory seems to change at runtime.
2677 So the wizard will fail the second time unless you copy the files into their
2678 proper locations - see the stdout warnings for the paths.
2680 (create_page_account_details),(on_before_next):
2681 Check for existing non-server accounts instead of server accounts,
2682 so the default account name is useful again, and to prevent trying to
2685 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2686 Show the wizard when New is clicked.
2688 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2689 (init_view): Show the column headers, and show the columns that are
2690 specified in the UI specs. However, something in Maemo's GTK+ prevents
2691 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2692 change the default account. This is despite unsetting the special properties.
2694 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2696 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2697 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2698 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2699 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2700 to make that clearer.
2701 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2703 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2705 * src/maemo/modest-account-view-window.c:
2706 (modest_account_view_window_init),
2707 (modest_account_view_window_new):
2708 Use the same buttons as specified in the
2709 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2710 the existing widgets, which never had a chance of working.
2711 Put the ModestAccountView treeview in a scrolled window.
2712 Do not repeat the initialization in both _init() and _new().
2714 * src/widgets/modest-account-view.c: (update_account_view):
2715 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2716 this widget and window shows no accounts.
2718 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2720 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2722 * src/maemo/easysetup/modest-easysetup-wizard.c:
2723 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2724 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2725 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2728 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2729 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2730 accounts exist yet, as in the UI spec.
2732 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2734 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/Makefile.am:
2737 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2738 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2739 New window for editing connection-specific smtp details.
2740 Not fully implemented.
2742 * src/maemo/modest-connection-specific-smtp-window.c:
2743 (modest_connection_specific_smtp_window_finalize) :
2744 unref the tree model.
2745 (on_button_edit): Show the edit window.
2747 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2749 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2752 * src/maemo/Makefile.am:
2753 * src/maemo/modest-connection-specific-smtp-window.c:
2754 * src/maemo/modest-connection-specific-smtp-window.h:
2755 New window for showing the list of connections, for connection-specific
2756 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2757 * src/maemo/easysetup/modest-easysetup-wizard.c:
2758 (create_page_custom_outgoing): Show the new window when the button is clicked.
2760 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2763 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2764 * src/maemo/modest-msg-edit-window.c:
2765 (modest_msg_edit_window_insert_image):
2766 * src/modest-conf.c: (modest_conf_key_escape):
2767 * src/modest-mail-operation.c:
2768 (modest_mail_operation_send_new_mail):
2769 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2770 (modest_ui_actions_on_new_account):
2771 * src/widgets/modest-attachment-view.c: (update_filename_request):
2772 * src/widgets/modest-mail-header-view.c:
2773 Corrected warnings that were breaking the build, by commenting out unused variables,
2774 and a function, and by including a header.
2776 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2778 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2779 so we can #ifdef around platform-specific code when necessary.
2780 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2781 to allow this to build for the GNOME platform too.
2783 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2785 * src/maemo/easysetup/modest-easysetup-wizard.c:
2786 Added util_increment_name() and used it in create_page_account_details()
2787 to make sure that the default account name is always a new name.
2789 (modest_easysetup_wizard_dialog_init),
2790 (set_default_custom_servernames): Some minor memory management fixes.
2792 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2796 * src/modest-runtime.c: (init_i18n): Restored the translation
2797 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2798 are defined in config.h, and the translations are installed.
2800 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2801 is defined for translation.
2803 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2805 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2807 * src/maemo/easysetup/modest-easysetup-wizard.c:
2808 (modest_easysetup_wizard_dialog_init):
2809 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2810 Use realistic paths (though they should use $prefix generically) to the
2811 mcc_mapping and provider-data.keyfile files which might work when they
2812 are installed by the future version of the operator-wizard package,
2813 and then fallback to paths in our source code, with an explanatory
2816 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/Makefile.am:
2821 * src/maemo/easysetup/: Added files from the previously-exernal
2822 osso-modest-easysetup.
2823 * src/maemo/modest-main-window-ui.h:
2824 * src/modest-ui-actions.c:
2825 * src/modest-ui-actions.h:
2826 Added modest_ui_actions_on_new_account() as a signal handler for the
2827 New Account menu item. It shows the easysetup wizard.
2828 * po/en_GB.po: Added additional needed logical IDs and translations.
2830 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2831 Apparently ChangeLog is not used for some vague Nokia legal reasons.