1 2007-07-04 Johanens Schmid <johannes.schmid@openismus.com>
3 * src/modest-tny-local-folders-account.c:
4 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
5 (see projects.maemo.org NB#61580)
7 2007-07-04 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account.c: (on_connection_status_changed):
10 Commented out the call to modest_platform_connect_and_wait() because this
11 seems to always hang, and I would like to know if this is the only thing
12 that causes a hang when showing the connection dialog.
13 It is not very useful anyway.
15 2007-07-04 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/modest-msg-view-window.c:
18 (modest_msg_view_window_select_next_message):
20 * src/modest-platform.h:
21 * src/maemo/modest-platform.c:
22 Added modest_platform_connect_and_wait(), which calls
23 tny_maemo_conic_device_connect() always in the main thread, by calling it
24 in an idle handler and waiting for the idle handler to run. It should be
25 in the main thread because it uses GTK+ UI code. It just returns TRUE
26 if the device is already online.
28 There is some nasty code to ensure that subsequent calls to
29 modest_platform_connect_and_wait() just wait for the first one to finish,
30 by checking repeatedly in another idle handler. This is necessary,
31 because other threads (or even the main thread, via another idle handler)
32 can call modest_platform_connect_and_wait() while
33 modest_platform_connect_and_wait() is running.
35 (modest_platform_connect_and_wait_if_network_account),
36 (modest_platform_connect_and_wait_if_network_folderstore):
37 Convenience functions that calls modest_platform_connect_and_wait() if
38 the account or folder might want network access.
40 * src/modest-mail-operation.c:
41 (modest_mail_operation_update_account):
42 * src/modest-ui-actions.c: (download_uncached_messages),
43 (modest_ui_actions_on_rename_folder), (delete_folder),
44 (modest_ui_actions_on_main_window_move_to),
45 (modest_ui_actions_on_msg_view_window_move_to):
46 * src/widgets/modest-folder-view.c:
47 (drag_and_drop_from_folder_view):
48 Offer a connection if we are offline.
50 * src/modest-tny-account.c: (on_connection_status_changed):
51 Document this as only handling errors during network operations in progress,
52 and replace the idle code with a simple call to
53 modest_platform_connect_and_wait(), which does this instead.
55 2007-07-03 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-tny-account.c:
58 (modest_tny_account_get_special_folder): (util_on_idle),
59 Handle the GError so we can see when tny_folder_store_get_folders()
60 fails, as it currently does while something else is connecting.
62 Added util_run_in_main_thread_and_wait()
63 which uses an idlen handler and mainloop to ensure that the function
64 is called in the main thread.
65 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
66 to make sure that we call attempt the connection in the mainloop only,
67 which might solve some hangs.
69 2007-07-03 Murray Cumming <murrayc@murrayc.com>
71 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
72 be found by their display name. This is never useful.
73 * src/modest-tny-account-store.c: (on_account_removed): Find the account
74 by its ID, instead of trying to use its ID as its display name.
76 * src/modest-tny-account-store.h:
77 * src/modest-tny-account.c:
78 (modest_tny_account_get_special_folder): Add a g_warning() when
79 tny_folder_store_get_folders() returns an empty list for the maildir.
81 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
82 Add a g_warning() when this returns NULL, because that it not allowed
85 2007-07-02 Armin Burgmeier <armin@openismus.com>
87 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
88 note when trying to cancel the wizard. This fixes projects.maemo.org
91 2007-07-02 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-tny-account.h:
94 * src/modest-tny-account.c:
95 (modest_tny_account_new_from_server_account),
96 (modest_tny_account_new_from_server_account_name),
97 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
98 because this must now be set before setting the proto. This is usd in
99 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
100 warning in camel_session_get_service() caused by
101 tny_camel_transport_account_prepare().
103 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
106 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
110 (modest_connection_specific_smtp_edit_window_init):
112 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
115 2007-06-29 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-tny-account.c:
118 (modest_tny_account_new_from_server_account):
119 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
120 now uses to request a connection when it needs one, and which it uses
121 to tell us that something is wrong with the connection, so we can force
122 the accounts offline to prevent further problems.
125 * src/modest-init.c: (init_default_settings):
126 * src/modest-mail-operation.c:
127 (modest_mail_operation_update_account):
128 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
129 This should not be necessary anymore. Do not set the conf key that
130 determined this (it was always TRUE and not set anywhere else).
132 * src/modest-ui-actions.h: Remove unused and unimplemented
133 modest_ui_actions_on_online_toggle_toggled().
135 2007-06-29 Murray Cumming <murrayc@murrayc.com
137 * src/maemo/modest-main-window.c: (connect_signals):
138 Don't connect to delete_event twice. Maybe this was harmless.
140 2007-06-29 Murray Cumming <murrayc@murrayc.com
142 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
143 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
144 Debug output to give some more clue when a folder move is not allowed.
146 2007-06-28 Murray Cumming <murrayc@murrayc.com
148 * src/modest-tny-account.c: (on_modest_file_system_info),
149 (modest_tny_account_get_mmc_account_name):
150 Always call the callback, without checking whether the name has changed.
151 * src/widgets/modest-folder-view.c: (strings_are_equal),
152 (on_model_foreach_set_name), (on_get_mmc_account_name),
153 (text_cell_data): Compare the name here, and use the name from
154 the account rather than from the
155 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
156 if the name was changed after the account was added to the model.
157 That's a tinymail bug but not one that I want to fix now.
159 This finally fixes projects.maemo.org bug NB#59301.
161 2007-06-27 Armin Burgmeier <armin@openismus.com>
163 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
166 2007-06-27 Murray Cumming <murrayc@murrayc.com
168 * src/modest-tny-account.h:
169 * src/modest-tny-account.c:
170 Added modest_tny_account_get_mmc_account_name(), to set the memory
171 card name asynchronously for the given account and then notify.
172 (modest_tny_account_new_for_local_folders): Use this new function instead
173 of using hildon_file_system_info_async_new() directly.
175 * src/widgets/modest-folder-view.c: (text_cell_data):
176 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
177 gtk_tree_model_row_changed() when it is available.
179 This should fix projects.maemo.org bug NB#59301.
181 2007-06-27 Murray Cumming <murrayc@murrayc.com
183 * src/modest-mail-operation.c: (update_account_thread),
184 (get_msgs_full_thread): Fix typo failures in the revert
187 2007-06-27 Murray Cumming <murrayc@murrayc.com
189 * src/maemo/modest-maemo-global-settings-dialog.c:
190 (idle_select_default_focus):
191 * src/modest-mail-operation.c: (idle_notify_progress),
192 (idle_notify_progress_once), (set_last_updated_idle),
193 (update_account_thread), (get_msgs_full_thread):
194 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
195 * src/widgets/modest-header-view.c:
196 (idle_notify_headers_count_changed_destroy),
197 (idle_notify_headers_count_changed):
198 Reverted the additions of gdk_threads_enter/leave(), in case this
199 helps with a startup hang on the device.
201 2007-06-26 Armin Burgmeier <armin@openismus.com>
203 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
204 for supported secure authentication methods from server by
205 gtk_dialog_run(), saving CPU time and a potential race condition.
207 2007-06-26 Armin Burgmeier <armin@openismus.com>
209 * src/maemo/modest-maemo-utils.h:
210 * src/maemo/modest-maemo-utils.c: Added a
211 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
212 only error code to tell the calling code when the user canceled the
215 * src/maemo/modest-account-settings-dialog.h:
216 * src/maemo/modest-account-settings-dialog.c:
217 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
218 message if the retrieval of secure authentication methods was canceled
219 by the user. Perform the check before saving anything to configuration
220 to not end up with half-committed configuration changes, do not show
221 a "Saving to configuration failed" note when authentication methods
222 could not be retrieved.
224 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
227 2007-06-26 Murray Cumming <murrayc@murrayc.com>
229 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
230 Only return the first level of folders under accounts, because the
231 osso-global-search UI spec doesn't want the rest.
232 This fixed projects.maemo.org bug NB#61811.
234 2007-06-26 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-tny-account-store.c:
237 * src/modest-tny-account-store.h:
238 Added modest_tny_account_is_memory_card_account().
239 * src/maemo/modest-main-window.c: (create_details_widget):
240 Show the same information items for the memory card as we show for the
241 local-folders, to fix projects.maemo.org bug NB#59307.
243 2007-06-26 Murray Cumming <murrayc@murrayc.com>
245 * src/modest-tny-account-store.c: (get_password):
246 Added some checks for NULL to maybe prevent crashes, though I think
247 it was Philip's last commit that actually prevented the crash here
248 when creating a first new account.
249 But the new account is still not usable (no messages are shown)
250 until a restart of the application.
252 2007-06-26 Murray Cumming <murrayc@murrayc.com>
254 * src/maemo/modest-maemo-global-settings-dialog.c:
255 (idle_select_default_focus):
256 * src/modest-mail-operation.c: (idle_notify_progress),
257 (idle_notify_progress_once), (idle_notify_update_account_queue),
258 (set_last_updated_idle), (update_account_thread),
259 (notify_get_msgs_full), (get_msgs_full_destroyer),
260 (get_msgs_full_thread):
261 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
262 * src/widgets/modest-header-view.c:
263 (idle_notify_headers_count_changed_destroy),
264 (idle_notify_headers_count_changed):
265 Use gdk_threads_enter() and gdk_threads_enter_leave() in
266 all idle handlers, because some other thread could be blocking
267 the GDK lock, so that it can do GUI stuff.
269 2007-06-26 Murray Cumming <murrayc@murrayc.com>
271 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
272 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
273 (on_idle_send_receive), (on_idle_open_default_inbox):
274 * src/maemo/modest-msg-edit-window.c:
275 (modest_msg_edit_window_attach_file_noninteractive):
276 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
277 to prevent a hang. I don't quite understand why these are necessary,
278 beause we should already be in the main loop. I guess something outside
279 of the main loop is taking the lock.
281 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
282 we are really using URIs, and use files that are more likely to exist.
284 2007-06-26 Murray Cumming <murrayc@murrayc.com>
286 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
287 necessary because configure.ac now defines different variables.
289 2007-06-26 Murray Cumming <murrayc@murrayc.com>
291 * libmodest-dbus-client/libmodest-dbus-client.c:
292 * libmodest-dbus-client/libmodest-dbus-client.h:
293 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
294 libmodest_dbus_client_compose_mail() is what things actually use.
296 * src/dbus_api/modest-dbus-api.h:
297 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
298 * tests/dbus_api/Makefile.am:
299 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
302 2007-06-26 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-init.c: (modest_init_local_folders):
305 For memory-card (or other non local-folders) maildir accounts,
306 always create an Archive folder, so that there is somewhere to put
307 messages. This should be less confusing, because the user does not need
308 to guess that the need to create a folder.
310 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
312 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
313 Fixed icon size by using (50, 50) which is the same as defined by
316 2007-06-25 Armin Burgmeier <armin@openismus.com>
318 * src/widgets/modest-window-mgr.c:
320 * configure.ac: Correctly recognize hildon-notify presence and fixed
321 the build without it being installed.
323 2007-06-25 Murray Cumming <murrayc@murrayc.com>
325 * libmodest-dbus-client/libmodest-dbus-client.c:
326 (libmodest_dbus_client_search): Fix the build. Sorry.
327 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
328 (reply_forward_cb): Initialize variables to fix the build.
330 * src/modest-tny-account-store.c:
331 (modest_tny_account_store_get_tny_account_by): Fix the account URI
332 comparison (a silly typo) so that email search results can be opened
333 when there are more than one account.
335 2007-06-25 Murray Cumming <murrayc@murrayc.com>
337 * libmodest-dbus-client/libmodest-dbus-client.c:
338 (libmodest_dbus_client_search),
339 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
340 instead of 1 second, because the search gets folders and messages from
341 the server, which can take a long time. When it times out,
342 osso-global-search will report no results.
344 We need to specify whether we should search only cached information
345 (maybe with a user preference), and the osso-email-search-plugin
346 API should really be improved to allow that option, and to allow results
347 to be delivered asynchronously in batches.
349 2007-06-25 Murray Cumming <murrayc@murrayc.com>
351 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
352 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
353 GTK_ICON_SIZE_DIALOG is probably the wrong size.
355 2007-06-25 Murray Cumming <murrayc@murrayc.com>
357 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
358 that is an empty string. D-Bus seems to give us these instead of NULL.
360 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
362 * src/dbus_api/modest-dbus-callbacks.c:
363 * src/maemo/easysetup/modest-easysetup-wizard.h:
364 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
365 * src/maemo/modest-connection-specific-smtp-edit-window.c:
366 (modest_connection_specific_smtp_edit_window_init):
367 * src/maemo/modest-maemo-global-settings-dialog.c:
369 * src/maemo/modest-maemo-utils.c:
370 (modest_maemo_utils_setup_images_filechooser):
371 * src/maemo/modest-main-window.c: (create_details_widget):
372 * src/maemo/modest-msg-edit-window.c:
373 (modest_msg_edit_window_attach_file_noninteractive),
374 (modest_msg_edit_window_color_button_change),
375 (modest_msg_edit_window_set_zoom):
376 * src/modest-mail-operation.c: (update_account_thread):
377 * src/modest-tny-account-store.c:
378 * src/modest-tny-account.c:
379 * src/widgets/modest-global-settings-dialog.c:
380 * src/widgets/modest-window.h:
384 2007-06-25 Murray Cumming <murrayc@murrayc.com>
386 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
387 * src/modest-search.c: (modest_search_folder),
388 (modest_search_all_accounts): Actually search only in the specified folder,
389 doing a simple match on the folder ID.
390 * src/modest-search.h: Added a folder field to the ModestSearch struct,
391 and added some documentation.
393 2007-06-22 Armin Burgmeier <armin@openismus.com>
395 * src/maemo/modest-maemo-utils.h:
396 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
397 modest_maemo_utils_get_supported_secure_authentication_methods.
399 * src/maemo/easysetup/modest-easysetup-wizard.c:
400 * src/maemo/modest-account-settings-dialog.c: Show correct error if
401 one occured, not just "Server does not support secure authentication".
403 2007-06-22 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-tny-account-store.c: (get_password):
406 Restored the call to tny_account_set_user() because Philip seems to have
407 stopped this from crashing (by not using the freed string). It still does
408 not work, but now we can test it.
410 2007-06-22 Murray Cumming <murrayc@murrayc.com>
412 * src/maemo/modest-msg-edit-window.c: (init_window):
413 Comment out use of an uninitialzed GtkScrolledWindow variable,
414 to fix the build and stop a crash. Yet again.
416 2007-06-22 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-tny-account-store.c: (get_password):
419 Remove the call to tny_account_set_user() because this actually crashes.
420 As mentioned in the last commit, it is known to not work anyway.
422 2007-06-22 Murray Cumming <murrayc@murrayc.com>
424 * src/modest-tny-account-store.c: (get_password):
425 Use tny_account_set_username() to tell tinymail that the username might
426 have changed too. But tinymail ignores this: see projects.maemo.org
428 * src/modest-ui-actions.c:
429 (modest_ui_actions_on_password_requested): Remove the useless attempt to
430 reset the connection when changing the username, and improve the comments.
431 Save the changed username to gconf at least, so it is used when Modest is
434 2007-06-21 Murray Cumming <murrayc@murrayc.com>
436 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
437 Do not use a query, so that we get all folders, including for POP and
438 local-folders. They work as search criteria too.
439 This fixes projects.maemo.org bug NB#57740.
441 2007-06-21 Murray Cumming <murrayc@murrayc.com>
443 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
444 Comment out the use of hildon_notification_set_sound() because it is
445 not declared, to fix the build. Warnings are serious, people.
447 2007-06-21 Armin Burgmeier <armin@openismus.com>
449 * src/maemo/modest-maemo-utils.h:
450 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
451 modest_maemo_utils_get_supported_secure_authentication_methods()
452 to query authentication methods for a specific user. This should fix
453 projects.maemo.org bug NB#61369.
455 * src/maemo/easysetup/modest-easysetup-wizard.c:
456 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
459 2007-06-21 Murray Cumming <murrayc@murrayc.com>
461 * libmodest-dbus-client/libmodest-dbus-client.h:
462 * libmodest-dbus-client/libmodest-dbus-client.c:
463 (modest_dbus_message_iter_get_search_hit),
464 (libmodest_dbus_client_search):
465 Reorganised and commented this.
466 Removed modest_search_hit_free() from the public API because it
469 Added libmodest_dbus_client_get_folders() and
470 modest_folder_result_list_free().
472 * src/dbus_api/modest-dbus-api.h:
473 * src/dbus_api/modest-dbus-callbacks.c:
474 (modest_dbus_req_filter): Commented. Moved most code to
475 on_dbus_method_search() and added on_dbus_method_get_folders().
477 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
478 of the extra D-Bus handler.
480 * tests/dbus_api/Makefile.am:
481 * tests/dbus_api/test_get_folders.c: New test for
482 libmodest_dbus_client_get_folders(). This seems to return an empty list
483 at the moment. That could be the same error that causes the message list
484 to be empty sometimes.
485 This should help with projects.maemo.org bug NB#57740.
487 2007-06-21 Armin Burgmeier <armin@openismus.com>
489 * src/modest-mail-operation.c: Do not call
490 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
491 notify the operation's end after having set the status to CANCELED for
492 the operation queue to listen on. This fixes a deadlock when there
493 were mail operations in the queue during its finalization.
495 * src/modest-singletons.c: Reordered uninitialization of the account
496 manager to happen after the mail operation queue was uninitialized
497 because the mail operation's in the queue might still try to access
498 the account manager (see modest_mail_operation_notify_end()). This
499 fixes a potential crash when terminating the application.
501 2007-06-21 Murray Cumming <murrayc@murrayc.com>
503 * src/modest-search.c:
504 (search_mime_part_and_child_parts): Moved some code here so we
505 can search recursively in child folders.
506 (modest_search_folder): Search in the message as a mime part, instead
507 of just its child mime parts.
508 (read_chunk), (search_mime_part_ogs):
509 Check how many bytes were read, to prevent an endless loop.
510 Searching in message bodies now works. This finishes the fix for
511 projects.maemo.org bug NB#61007.
513 2007-06-20 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
516 Add a g_warning when the item is not a folder.
518 * src/modest-ui-dimming-rules.c:
519 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
520 when selected item is not a folder (for instance, an account), because
521 the UI spec only talks about folders.
522 I am not sure what the UI spec wants, so this might not totally fix
523 projects.maemo.org bug NB#60794.
525 2007-06-20 Murray Cumming <murrayc@murrayc.com>
527 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
528 (load_from_file): Sort the list. The unsorted list would be more noticeable
529 in non-English locales.
531 * src/maemo/modest-msg-edit-window.c:
532 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
533 warning and fix the build.
535 * src/maemo/modest-progress-bar-widget.c:
536 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
537 avoid a g_warning, and probably to avoid a crash.
539 2007-06-20 Murray Cumming <murrayc@murrayc.com>
541 * src/modest-search.c: (modest_search_folder): Check for a GError
542 when calling tny_folder_get_headers(), to show that this is not the cause
545 2007-06-20 Murray Cumming <murrayc@murrayc.com>
547 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
548 Actually set the body query instead of the subject query.
550 * src/modest-search.c: (search_mime_part_ogs),
551 (search_mime_part_strcmp): Remove extra space from the text/* regex,
552 which would probably cause it to fail if we got this far.
554 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
555 to simplify the code.
556 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
557 be causing search-in-body to fail.
559 2007-06-20 Murray Cumming <murrayc@murrayc.com>
561 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
563 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
564 Better debug message when the folder cannot be found.
565 This should help with fixing projects.maemo.org bug #61287.
566 * src/modest-search.c: (add_hit): Do not leak the furl string.
568 2007-06-20 Murray Cumming <murrayc@murrayc.com>
570 * src/modest-ui-actions.c:
571 (modest_ui_actions_on_folder_selection_changed):
572 Do not special-case TNY_MERGE_FOLDER here, because
573 modest_tny_folder_get_account() already does that. This fixes
574 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
575 shown when the Outbox was selected).
577 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
579 * libmodest-dbus-client/libmodest-dbus-client.c:
580 (_dbus_iter_get_string_or_null): Initialize the string variable in
581 case this helps with Dirk's crash.
583 2007-06-19 Murray Cumming <murrayc@murrayc.com>
585 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
586 though it is not implemented yet (this function is maybe not even used),
587 to avoid breaking ABI in future.
588 * libmodest-dbus-client/libmodest-dbus-client.c:
589 (get_attachments_string): Moved some code into this generic function.
590 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
591 sends email. It is maybe not used.
592 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
593 (on_send_mail): Use attachments.
595 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
596 * src/maemo/modest-msg-edit-window.c:
597 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
598 a filename before using it, to fix projects.maemo.org bug NB#58233.
600 2007-06-19 Murray Cumming <murrayc@murrayc.com>
602 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
603 Initialize the continue_download variable to fix the build, and probably
604 to fix randome behaviour.
606 2007-06-18 Armin Burgmeier <armin@openismus.com>
608 * src/modest-tny-send-queue.h:
609 * src/modest-tny-send-queue.c: Keep track of the status of messages in
610 the queue so we can later show it in the UI. Replaced
611 modest_tny_send_queue_msg_is_being_sent() by
612 modest_tny_send_queue_get_msg_status().
614 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
616 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
617 gpointer. This probably was not harmful, but just to be sure.
619 2007-06-18 Murray Cumming <murrayc@murrayc.com>
621 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
622 Fix the build, but leave the function broken on Bora, because
623 hildon_uri_action_get_service() does not exist.
624 osso_uri_action_get_service() does not exist either, it seems.
626 2007-06-18 Murray Cumming <murrayc@murrayc.com>
628 * src/modest-tny-account.c:
629 (modest_tny_account_new_from_server_account):
630 Uncommented the url debug output again, because it is useful for
631 debugging, as I said in the comment.
633 2007-06-18 Murray Cumming <murrayc@murrayc.com>
635 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
637 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
638 for Mameo Bora, to fix the build.
640 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
643 Fixed build with hildon < 0.99
645 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
646 Check if the selected account is busy instead of checking all accounts
648 * src/modest-account-mgr-priv.h:
649 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
650 (modest_account_mgr_init), (compare_account_name),
651 (modest_account_mgr_set_account_busy),
652 (modest_account_mgr_account_is_busy):
653 * src/modest-account-mgr.h:
654 Added busy information to the account manager. It possible to
655 set an account to busy or not busy now.
657 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
658 (modest_mail_operation_update_account),
659 (modest_mail_operation_notify_end):
660 Set the account to busy/not busy depending on the operation state.
662 * src/widgets/modest-account-view.c:
663 (modest_account_view_finalize), (get_last_updated_string),
664 (update_account_view), (on_account_busy_changed), (init_view):
665 Show string "Refreshing..." if the account is currently busy.
667 All this fixes projects.maemo.org bug NB#59711
669 2007-06-14 Armin Burgmeier <armin@openismus.com>
671 * src/widgets/modest-attachments-view.h:
672 * src/widgets/modest-attachments-view.c: Added
673 modest_attachments_view_has_attachments() and fixed coordinate
674 transformation in get_att_view_at_coords(). This fixes attachment
677 * src/widgets/modest-msg-view.c: Make use of
678 modest_attachments_view_has_attachments() to decide whether to show
679 attachments in the header.
681 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
683 * src/maemo/modest-connection-specific-smtp-edit-window.c:
684 (on_change), (on_combo_security_changed),
685 (modest_connection_specific_smtp_edit_window_init),
686 (modest_connection_specific_smtp_edit_window_set_connection),
687 (modest_connection_specific_smtp_edit_window_is_dirty):
688 * src/maemo/modest-connection-specific-smtp-edit-window.h:
689 * src/maemo/modest-connection-specific-smtp-window.c:
692 Show an comfirmation dialog for the smpt-edit-window if there are
693 unsaved changes and the user hits cancel.
694 (projects.maemo.org bug NB#60479)
696 2007-06-14 Armin Burgmeier <armin@openismus.com>
698 * src/maemo/easysetup/modest-easysetup-wizard.c:
699 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
700 address" info in banner instead of node, and select all the text as
701 per UI spec. This fixes projects.maemo.org bug NB#60550.
703 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
705 reviewed by: <delete if not using a buddy>
707 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
708 * src/modest-ui-actions.c: (folder_refreshed_cb):
710 2007-06-14 Murray Cumming <murrayc@murrayc.com>
712 * src/widgets/modest-folder-view.c: (filter_row):
713 Explictly filter out the per-account outbox accounts. I don't know why
714 these only sometimes show up, but now they should never show up in the UI.
715 This should fix projects.maemo.org bug NB#60160.
717 2007-06-14 Murray Cumming <murrayc@murrayc.com>
719 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
720 when the toolbar does not exist yet.
721 * src/modest-widget-memory.c: (save_settings_header_view):
722 Added g_warnings() to help us to discover when we are trying to set
723 an empty columns list in gconf.
725 2007-06-14 Murray Cumming <murrayc@murrayc.com>
729 Added modest_init_get_default_header_view_column_ids().
731 * src/modest-widget-memory.c: (restore_settings_header_view):
732 Use the new function to get defaults, if the gconf key is empty,
733 instead of not creating any columns. This seems to fix the
734 empty right-hand pane problems.
736 * src/widgets/modest-header-view.h: Improved documentation.
738 2007-06-13 Murray Cumming <murrayc@murrayc.com>
740 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
741 Revert the use of the display name as the account name, because this
742 is generally wrong and would break the code that follows.
744 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
746 * src/maemo/easysetup/modest-easysetup-wizard.c:
747 (check_for_supported_auth_methods), (on_before_next),
750 More correct fix for projects.maemo.org bug NB# 58991
751 Do not longer accept AUTH_PASSWORD as secure method and choose
752 correct method when creating the account.
754 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
756 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
757 Fixed projects.maemo.org bug NB# 58991
759 2007-06-13 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-init.c: (modest_init_init_core),
762 (modest_init_local_folders): Fixed compilation errors.
764 2007-06-13 Murray Cumming <murrayc@murrayc.com>
766 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
767 Remove unnecessary lib/include, though it is good in principle when needed.
769 * src/modest-init.c: (modest_init_one_local_folder),
770 (modest_init_local_folders):
771 * src/modest-init.h: Initialize the .modest library for memory cards,
772 instead of just doing nothing for them. This should allow us to create
773 folders there, fixing projects.maemo.org bug NB#59297.
775 2007-06-13 Murray Cumming <murrayc@murrayc.com>
777 * libmodest-dbus-client/libmodest-dbus-client.c:
778 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
779 (libmodest_dbus_client_compose_mail),
780 (libmodest_dbus_client_open_message),
781 (libmodest_dbus_client_send_and_receive),
782 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
784 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
785 (on_idle_open_message), (modest_dbus_req_handler),
786 (search_result_to_message), (modest_dbus_req_filter):
787 * src/modest-search.c: (add_hit), (modest_search_folder),
788 (modest_search_all_accounts): Improved debug messages.
790 * tests/dbus_api/test_open_message.c: (main): Improved comments.
792 * src/modest-tny-account-store.c:
793 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
796 2007-06-13 Murray Cumming <murrayc@murrayc.com>
799 2007-06-12 Murray Cumming <murrayc@murrayc.com>
801 * src/modest-tny-account-store.c: (get_server_accounts):
802 Call modest_tny_local_folders_account_add_merged_outbox_folders()
803 even when there are no accounts, so that the Outbox folder is always
804 visible. This fixes projects.maemo.org bug NB#60158.
806 2007-06-12 Murray Cumming <murrayc@murrayc.com>
808 * src/maemo/modest-main-window.c: (create_details_widget):
809 Use the mcen_va_never logical ID.
811 2007-06-12 Murray Cumming <murrayc@murrayc.com>
813 * src/dbus_api/modest-dbus-api.h:
814 * src/dbus_api/modest-dbus-callbacks.c:
815 (on_idle_open_default_inbox), (on_open_default_inbox),
816 (modest_dbus_req_handler):
817 Added a new OpenDefaultInbox method.
819 * libmodest-dbus-client/libmodest-dbus-client.h:
820 * libmodest-dbus-client/libmodest-dbus-client.c:
821 Added libmodest_dbus_client_open_default_inbox() to call the new
822 dbus method. This should be useful to projects.maemo.org bug NB#57214,
823 though it should maybe be used by a new osso-email-interface function.
825 * tests/dbus_api/Makefile.am:
826 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
829 2007-06-12 Murray Cumming <murrayc@murrayc.com>
831 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
832 NULL, so that the signals get all the keys. This should not actually
833 change any behaviour because we currently update everything when anything
836 2007-06-12 Murray Cumming <murrayc@murrayc.com>
838 * src/widgets/modest-folder-view.c: (text_cell_data),
839 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
840 (find_inbox_iter): If tinymail tells us that the folder is
841 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
842 This causes the inbox to be selected at startup, fixing part of
843 projects.maemo.org bug NB#56305.
845 * src/modest-ui-dimming-rules.c:
846 (modest_ui_dimming_rules_on_tools_smtp_servers):
847 * src/modest-ui-dimming-rules.h: Added a callback function to dim
848 the SMTP servers menu item.
849 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
850 that the SMTP Servers menu item is dimmed when there are no accounts,
851 as a future version of the UI spec will require. This fixes
852 projects.maemo.org bug NB#56305.
854 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
856 * src/maemo/modest-maemo-utils.c:
857 (modest_maemo_utils_get_supported_secure_authentication_methods):
858 Added label to dialog instead of unreadable title
860 * src/maemo/modest-main-window.c: (sync_accounts_cb),
861 (modest_main_window_new):
862 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
865 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
866 * src/modest-account-mgr.h:
867 Added method to avoid code duplication
869 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
870 (modest_ui_actions_on_send_receive):
871 Use modest_account_mgr_has_accounts
873 2007-06-11 Murray Cumming <murrayc@murrayc.com>
875 * src/maemo/easysetup/modest-presets.c:
876 (modest_presets_get_info_server_security): Do not report secure auth
878 * src/modest-protocol-info.c: Use the defines for the gconf key names
879 for secure authentication. This was not working because we were writing
880 Password and reading password, and the check was case sensitive.
881 With this, gmail now works for receiving and sending when created via
884 2007-06-11 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/easysetup/modest-presets.c:
887 (modest_presets_get_info_server_security): Correct the key name for
888 SecureSmtp, because it seems to be case-sensitive.
889 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
890 Do not try to get the 0th notebook page if there are 0 pages, to
893 2007-06-11 Murray Cumming <murrayc@murrayc.com>
895 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
896 Prevent use of the new notification feature for now, because it currently
897 shows one dialog for each new email, which is annoying.
899 2007-06-11 Murray Cumming <murrayc@murrayc.com>
901 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
902 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
903 when no country was selected, so that we show the global ones.
904 * src/maemo/easysetup/modest-presets.c:
905 (modest_presets_get_providers): Return only the global providers, not
906 all providers when mmc=0 was requested.
908 2007-06-11 Murray Cumming <murrayc@murrayc.com>
910 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
911 (easysetup_provider_combo_box_fill): Remove debug code that showed the
912 provider ID in the combo.
914 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
915 Do not show the page numbers, because it would be confusing when we add
916 the 2 extra pages for the custom setup, when the user chooses the "Other"
917 provider. This fixes projects.maemo.org bug NB#59028
919 * src/modest-init.c: (modest_init_init_core),
920 (modest_init_local_folders):
922 * src/modest-tny-account.c:
923 (modest_tny_account_new_for_local_folders): Do not create default folders
924 for the memory card. This should fix projects.maemo.org bug NB#59328.
926 2007-06-11 Murray Cumming <murrayc@murrayc.com>
928 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
929 Free the changed_conf_keys string items. They are already freed in the
930 idle handler if that runs first.
932 2007-06-11 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-ui-actions.c:
935 (modest_ui_actions_on_password_requested): Check that the server name
936 is not NULL, because I just saw a password dialog with (null) as the
939 * src/modest-tny-folder.[h|c]: Added
940 modest_tny_folder_is_memory_card_folder().
941 * src/modest-ui-dimming-rules.c:
942 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
943 menu item for memory cards, as per the UI spec (section 7.4). This should
944 fix projects.maemo.org bug NB#59297.
946 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
948 * src/maemo/modest-main-window.c: (sync_accounts_cb):
949 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
950 is another problem with the code, see Murray's comment at line 772)
952 2007-06-08 Murray Cumming <murrayc@murrayc.com>
954 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
955 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
956 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
957 (load_from_file), (easysetup_country_combo_box_init),
958 (easysetup_country_combo_box_get_active_country_ids),
959 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
960 instead of just one ID, to avoid duplicate country names in the UI.
962 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
963 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
964 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
965 a single ID, avoiding duplicate providers.
966 * src/maemo/easysetup/modest-easysetup-wizard.c:
967 (on_combo_account_country): Adapt to use a list.
969 2007-06-08 Murray Cumming <murrayc@murrayc.com>
971 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
972 keys changed in the last X seconds.
974 * src/modest-account-mgr.h:
975 * src/modest-account-mgr.c: (on_timeout_notify_changes),
976 (on_key_change), (modest_account_mgr_class_init),
977 (modest_account_mgr_init), (modest_account_mgr_finalize):
978 As the keys are changed, save them in a GSList* and signal that GSList*
979 further every X seconds, to batch changes, to allow us to do just one
980 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
981 bug NB#56941 and other (UI-blocking) delays when changing account settings.
983 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
984 changed signal signature.
986 * src/modest-conf.c: (modest_conf_set_list),
987 (modest_conf_on_change): Reenable notification.
989 (modest_conf_maemo_fake_on_change): Comment out the hack that
990 notified immediately instead of asynchronously.
992 * src/widgets/modest-account-view.h:
993 * src/widgets/modest-account-view.c:
994 (update_account_view): Select the previously-selected account ID,
995 if possible. This fixes projects.maemo.org bug NB#56933.
997 (on_account_changed), (on_account_removed),
998 (modest_account_view_select_account):
1000 Remove the block/unblock functions
1001 because they were not useful.
1003 * src/maemo/modest-account-view-window.c:
1004 (on_delete_button_clicked), (on_edit_button_clicked),
1005 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1007 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1010 Improve the error dialog to show Incorrect Account Settings, which seems
1011 clearer, and say that the internal error message (to be removed from the
1012 dialog later) is often misleading.
1013 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1015 * src/modest-tny-account.c:
1016 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1017 URL because this is so useful for debugging on the device.
1019 * src/widgets/modest-serversecurity-combo-box.c:
1020 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1022 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-mail-operation.c:
1025 (modest_mail_operation_send_new_mail):
1026 Added a comment about a nasty but apparently harmless message. Details
1027 added to the wiki g_warnings() page.
1029 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1031 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1032 (modest_tny_send_queue_class_init):
1033 Do not use the priv struct because it is empty, to avoid g_warnings
1034 about a non-existant priv struct.
1036 * src/modest-tny-account-store.c:
1037 (modest_tny_account_store_get_server_account),
1038 (modest_tny_account_store_get_transport_account_for_open_connection
1039 ): Do not try to get transport server accounts for local folders,
1040 because they don't have any. This avoids a g_warning().
1042 * src/maemo/modest-main-window.c:
1043 (modest_main_window_notify_send_receive_initied),
1044 (on_configuration_key_changed):
1045 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1046 * src/modest-defs.h:
1047 * src/modest-mail-operation.c:
1048 (modest_mail_operation_update_account):
1049 * src/modest-tny-account-store.h:
1050 * src/modest-tny-account.c:
1051 (modest_tny_account_get_special_folder),
1052 (modest_tny_account_new_for_local_folders),
1053 (modest_tny_account_new_for_per_account_local_outbox_folder):
1054 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1055 * src/modest-tny-local-folders-account.c:
1056 (add_account_folders_to_merged_folder):
1057 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1058 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1059 (modest_ui_actions_on_send):
1060 * src/widgets/modest-folder-view.c: (update_model):
1061 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1062 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1063 modest_tny_account_store_get_tny_account_by_account() to
1064 modest_tny_account_store_get_server_account() to make the code clearer.
1066 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1068 * src/dbus_api/modest-dbus-api.h:
1069 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1070 * src/maemo/modest-msg-edit-window.c:
1071 (modest_msg_edit_window_attach_file_noninteractive):
1072 added g_warning in case the file to be attached does not exist
1073 * tests/dbus_api/test_compose_mail.c: (main):
1074 removed obsolete comment, added generic files as test case
1076 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1078 * src/modest-tny-account-store.c: (get_server_accounts):
1079 Create the local folders account only once, not once for each outbox, and
1080 not only when there are some outboxes.
1082 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1084 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1085 code that is causing a crash at startup. Sergio says that he is fixing this.
1087 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1089 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1090 * src/maemo/modest-account-settings-dialog.c:
1091 (create_page_outgoing),
1092 (modest_account_settings_dialog_set_account_name),
1093 (save_configuration):
1094 - Fixed handling of the "Use secure authentication" toggle to comply with
1095 the ui specification. See also projects.maemo.org bug NB#58400
1097 - Restore the Secure connection setting combo correctly when loading
1100 * src/maemo/modest-maemo-utils.c:
1101 (on_camel_account_get_supported_secure_authentication),
1102 (modest_maemo_utils_get_supported_secure_authentication_methods):
1103 Fixed a crasher if operation is canceled
1105 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1106 (modest_protocol_info_auth_is_secure):
1107 * src/modest-protocol-info.h:
1109 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1110 the sense of the "Use secure authentication" toggle.
1112 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1114 * src/modest-tny-account-store.h:
1115 * src/modest-tny-account-store.c:
1116 Added modest_tny_account_store_get_local_folders_account().
1118 * src/modest-tny-folder.h:
1119 * src/modest-tny-folder.c:
1120 (modest_tny_folder_get_account):
1121 Added this replacement for tny_folder_get_account() which returns
1122 the local-folders account for TnyMergeFolders, to avoid the
1123 warning about the unimplemented get_account_func() vfunc().
1125 (modest_tny_folder_get_rules),
1126 * src/modest-ui-actions.c:
1127 (modest_ui_actions_on_folder_selection_changed):
1128 * src/modest-mail-operation.c:
1129 (modest_mail_operation_remove_folder),
1130 (modest_mail_operation_xfer_folder),
1131 (modest_mail_operation_rename_folder),
1132 (modest_mail_operation_get_msg),
1133 (modest_mail_operation_get_msgs_full),
1134 (modest_mail_operation_remove_msg),
1135 (modest_mail_operation_xfer_msgs),
1136 (modest_mail_operation_refresh_folder):
1137 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1139 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1142 (modest_server_account_set_security):
1143 * src/modest-defs.h: Add comments explaining that our
1144 UI spec means TLS when it says Normal, so these do not look like errors.
1146 * src/modest-tny-account.c:
1147 (modest_tny_account_new_from_server_account): Use the new tinymail
1148 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1149 for TLS. This should fix projects.maemo.org bug NB#58460.
1151 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1153 * src/maemo/easysetup/modest-easysetup-wizard.c:
1154 (create_account): Correct the position of the gconf sanity check warning.
1155 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1156 of using the g_idle_add() hack, because this does not seem to be necessary
1157 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1158 caused by something other than maemo's gconf.
1159 This fixes projects.maemo.org bug #59022.
1161 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-account-mgr-helpers.c:
1164 (modest_account_mgr_get_default_account): Do not check that the account
1165 exists if there is no default account (NULL), to fix a runtime warning.
1167 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1169 * src/widgets/modest-folder-view.c: (update_model):
1170 Do not unref the treemodel before we have finished with it.
1171 This prevents a valgrind warning and an occasional crash at startup.
1173 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1175 * libmodest-dbus-client/libmodest-dbus-client.h:
1176 added libmodest_dbus_client_compose_mail()
1177 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1179 added functions needed for SendAsMail() functionality
1180 * src/maemo/modest-msg-edit-window.c:
1181 (modest_msg_edit_window_attach_file_noninteractive):
1182 non interactively attaching files to message edit window
1183 * src/widgets/modest-msg-edit-window.h:
1184 * tests/dbus_api/Makefile.am:
1185 added test_compose_mail.c
1186 * tests/dbus_api/test_compose_mail.c: (main):
1188 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1190 * src/modest-account-view.c:
1191 Fixed bug projects.maemo.org bug NB#59307
1193 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1195 * src/maemo/easysetup/modest-easysetup-wizard.c:
1196 (get_serverport_incoming), (on_before_next), (create_account):
1197 * src/maemo/modest-account-settings-dialog.c:
1198 (modest_account_settings_dialog_set_account_name):
1199 * src/maemo/modest-maemo-utils.c:
1200 (on_camel_account_get_supported_secure_authentication_status),
1201 (on_camel_account_get_supported_secure_authentication),
1202 (on_secure_auth_cancel),
1203 (modest_maemo_utils_get_supported_secure_authentication_methods):
1205 Implemented security authentication for settings and easysetup.
1207 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1209 * src/maemo/modest-main-window.c: (create_details_widget):
1210 Show the total size for memory card accounts too, instead of showing
1211 the name again. Fixes bug projects.maemo.org bug NB#59307.
1213 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-tny-simple-folder-store.c:
1217 * src/modest-tny-simple-folder-store.h: Removed.
1219 * src/modest-tny-local-folders-account.h
1220 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1221 for the local-folders maildir, with an extra TnyMergedFolder containing
1222 the folders of the per-account outbox store accounts.
1223 * src/modest-tny-account-store.c: (get_server_accounts):
1224 Add the outboxes to the special local folders account after creating it.
1226 * src/modest-tny-account.c:
1227 (modest_tny_account_new_for_local_folders): Create the derived
1228 account when creating the main local-folders account.
1230 * src/maemo/modest-main-window.c: (create_details_widget),
1231 (modest_main_window_set_contents_style):
1232 Adapted to the use of the derived account instead of the folder store.
1234 * src/modest-ui-actions.c:
1235 (modest_ui_actions_on_folder_selection_changed):
1236 * src/modest-ui-dimming-rules.c:
1237 (modest_ui_dimming_rules_on_new_folder):
1238 * src/widgets/modest-folder-view.c: (text_cell_data),
1239 (icon_cell_data), (filter_row), (update_model),
1240 (get_cmp_rows_type_pos):
1243 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1244 Do not get the priv struct, because no priv struct has been set,
1245 to avoid a runtime warning.
1247 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1248 #ifelse with #else, to fix a warning, to fix the build.
1251 2007-06-05 Christian Kellner <ckellner@openismus.com>
1253 * libmodest-dbus-client/libmodest-dbus-client.c:
1254 Fix small typo in doc (why do you always see them
1255 AFTER committing stuff?)
1258 2007-06-05 Christian Kellner <ckellner@openismus.com>
1260 * libmodest-dbus-client/libmodest-dbus-client.c:
1261 (libmodest_dbus_client_search):
1262 Initialize hit list with NULL. Also set folder list
1263 to "" if NULL was supplied.
1266 2007-06-03 Christian Kellner <ckellner@openismus.com>
1268 * libmodest-dbus-client/libmodest-dbus-client.c:
1269 (modest_search_hit_list_free):
1270 Make it save to call it with NULL.
1272 * src/dbus_api/modest-dbus-callbacks.c:
1273 * src/modest-search.c:
1274 Return full ModestSearchHits as the search result list not TnyHeader
1275 since can't be around withouth the correspoding TnyFolder.
1277 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1279 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1280 Added currently commented code to check for secure auth
1282 * src/maemo/modest-account-settings-dialog.c: (on_response),
1283 (save_configuration), (show_ok):
1284 Fixed projects.maemo.org bugs NB #59248 and #59251
1286 * src/maemo/modest-maemo-utils.c:
1287 (on_camel_account_get_supported_secure_authentication_status),
1288 (on_camel_account_get_supported_secure_authentication),
1289 (modest_maemo_utils_get_supported_secure_authentication_methods):
1290 * src/maemo/modest-maemo-utils.h:
1291 Moved get_supported_secure_authentication() method here to be able
1292 to use it from easysetup wizard.
1294 * src/modest-pair.c: (on_pair_compare_as_string):
1295 Should compare string with first part of pair and not
1296 strcmp pairs which will crash.
1298 * src/modest-protocol-info.c:
1299 (modest_protocol_info_protocol_is_store):
1300 * src/modest-protocol-info.h:
1301 Added modest_protocol_info_get_auth_protocol_name()
1303 2007-06-03 Armin Burgmeier <armin@openismus.com>
1305 * src/modest-mail-operation.c:
1306 (modest_mail_operation_get_msgs_full): Set priv->account also when
1307 only retrieving a single message. This avoids a crash when canceling
1310 (modest_mail_operation_notify_end): Do not explicitely remove the
1311 operation from the queue but only emit the progress_changed signal.
1312 The queue itself listens to that signal to remove the operation when
1313 it is finished. This reduces coupling and removes a potential deadlock
1314 when modest_mail_operation_notify_end() is called from the queue
1315 itself. If that is a problem performance-wise, I would suggest to
1316 implement a status-changed signal or something.
1318 * src/modest-mail-operation-queue.c: Make sure to never call a
1319 function from another file while the queue is locked. This (hopefully)
1320 fixes another deadlock when exiting the application while retrieving
1323 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1325 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1326 Fixed build if libogs is not available
1328 2007-06-03 Christian Kellner <ckellner@openismus.com>
1330 * libmodest-dbus-client/libmodest-dbus-client.h:
1331 * libmodest-dbus-client/libmodest-dbus-client.c:
1332 (libmodest_dbus_client_delete_message):
1333 Implement deletion of messages (Client side).
1335 (modest_search_hit_free),
1336 (modest_search_hit_list_free):
1337 Utility functions to free the result hits.
1339 * src/dbus_api/modest-dbus-api.h:
1340 * src/dbus_api/modest-dbus-callbacks.c:
1341 (on_delete_message),
1342 (modest_dbus_req_handler):
1343 Implement deletion of messages (Server side).
1345 * tests/dbus_api/test_search.c: (main):
1348 * tests/dbus_api/Makefile.am:
1349 * tests/dbus_api/test_delete_message:
1350 Add little test for the message deletion logic
1352 2007-06-03 Armin Burgmeier <armin@openismus.com>
1354 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1355 when the operation queue was not empty. projects.maemo.org bug
1358 2007-06-03 Armin Burgmeier <armin@openismus.com>
1360 * src/widgets/modest-account-view.c
1361 (on_account_default_toggled): Toggle default account column
1362 explicitely instead of waiting for gconf notification (which is
1363 currently ignored). This should fix projects.maemo.org bug NB#56910
1364 for now. It should probably be removed when gconf notifications are
1367 2007-06-03 Christian Kellner <ckellner@openismus.com>
1369 * libmodest-dbus-client/libmodest-dbus-client.c:
1370 Removed debugging spew.
1372 * src/dbus_api/modest-dbus-callbacks.c:
1373 Added debugging info.
1375 * src/modest-search.c:
1376 (modest_search_all_accounts):
1377 Use tny_account_store_get_accounts () on the account store
1378 to get all accounts which is the way to get all accounts.
1380 * tests/dbus_api/test_search.c: (main):
1381 Make it possible to supply the search term on the command line.
1383 2007-06-03 Christian Kellner <ckellner@openismus.com>
1385 * libmodest-dbus-client/libmodest-dbus-client.c:
1386 * libmodest-dbus-client/libmodest-dbus-client.h:
1387 Implement searching for mesages over raw dbus. (Client side)
1389 * src/dbus_api/Makefile.am:
1390 * src/dbus_api/modest-dbus-api.h:
1391 * src/dbus_api/modest-dbus-callbacks.c:
1392 * src/dbus_api/modest-dbus-callbacks.h:
1393 Search framework (Server side). Also implement on_idle_open_message().
1395 * src/maemo/modest-platform.c: (modest_platform_init):
1396 Prepare for raw dbus/osso rpc interaction.
1398 * src/modest-search.h:
1399 Changed minsize from unspecific guint to guint32.
1401 * src/modest-search.c:
1403 Added strange hack which magically made tnymail work.
1405 (modest_search_folder),
1406 (modest_search_account),
1407 (modest_search_all_accounts):
1408 Implement helper functions to search all accounts, specific account
1411 * tests/dbus_api/Makefile.am:
1412 * tests/dbus_api/test_open_message.c:
1413 Read url to open from commandline.
1415 * tests/dbus_api/test_search.c:
1416 Implement small test for dbus search stuff
1418 2007-06-02 Armin Burgmeier <armin@openismus.com>
1420 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1421 include account type and account title. This fixes projects.maemo.org
1424 * src/maemo/modest-account-view-window.c: Set a title for the window.
1426 2007-06-02 Armin Burgmeier <armin@openismus.com>
1428 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1429 incoming and outgoing server name based on email address and server
1430 types as long as the names have not been edited manually. This fixes
1431 projects.maemo.org bug NB#58671.
1433 2007-06-02 Armin Burgmeier <armin@openismus.com>
1435 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1436 server type cannot be changed in future to the incoming details page
1437 when creating an account. This fixes projects.maemo.org bug NB#59029.
1439 2007-06-02 Armin Burgmeier <armin@openismus.com>
1441 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1442 and assigned max width chars so that they wrap instead of being
1443 truncated. Fixes projects.maemo.org bug NB#56126.
1445 2007-06-02 Armin Burgmeier <armin@openismus.com>
1447 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1448 introductory note to the connection specific smtp servers dialog, as
1449 section 8.12 of the email UI specification requires. This fixes
1450 projects.maemo.org bug NB#59212.
1452 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1454 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1455 Check for running mail operations, and offer to cancel them, as per the UI
1456 spec. This fixes projects.maemo.org bug NB#59041 .
1457 However, I suspect that tinymail may still use the network connection
1458 in ways that we cannot detect or cancel. But it should at least adapt to
1459 changes fairly well.
1461 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1463 * src/modest-tny-account-store.c: (recreate_all_accounts),
1464 (get_cached_accounts), (get_server_accounts): Do more sensible
1465 ref-counting of the temporarily-cached outbox accounts list. This seems
1466 to fix a crash when entering the password when the password was wrong.
1468 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1470 * src/gnome/modest-main-window.c: (connect_signals):
1471 * src/modest-tny-account-store.c: (get_password),
1472 (modest_tny_account_store_alert): Added comments and clues and
1473 commented-out code about how we currently fail to deal with connection
1474 errors and wrong passwords, and how we should.
1476 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1478 * src/widgets/modest-retrieve-combo-box.c:
1479 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1480 This fixes projects.maemo.org bug NB#58472 .
1482 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/easysetup/modest-easysetup-wizard.c:
1485 (create_page_complete_easysetup):
1486 (create_page_complete_custom): Correct the last commit,
1487 putting the correct sentences in the correct pages.
1489 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1491 * src/maemo/easysetup/modest-easysetup-wizard.c:
1492 (create_page_complete_custom): Show the second sentence of text
1493 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1496 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1498 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1499 Set the leave-on-server conf key by default. This fixes
1500 projects.maemo.org bug NB#59258 .
1502 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1504 * src/maemo/modest-account-view-window.c:
1505 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1506 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1509 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1511 * src/maemo/easysetup/modest-easysetup-wizard.c:
1512 (create_caption_new_with_asterisk):
1513 * src/maemo/modest-account-settings-dialog.c:
1514 (create_caption_new_with_asterisk):
1515 Uncomment the code to add the asterisk, because they are no longer in the
1516 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1517 (update_incoming_server_title): Add an asterisk here too.
1519 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1521 * src/maemo/modest-maemo-global-settings-dialog.c:
1522 (current_connection): Check that we are even connected before trying to
1523 get the current connection name, to prevent a warning.
1525 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1526 Change the comments because tny_maemo_conic_device_connect() is now meant to
1528 * src/modest-mail-operation.c:
1529 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1530 make sure we have a connection and fail if we can't connect.
1532 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1534 * src/maemo/modest-main-window.c:
1535 (on_account_store_connecting_finished): Do not try to get the
1536 connection ID if we are not really connected. I am surprised that
1537 this signal handler is called when we are not connected.
1539 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1541 * src/modest-error.h:
1542 * src/modest-ui-actions.c:
1543 (modest_ui_actions_get_msgs_full_error_handler):
1544 Renamed an enum, added comments, added an enum
1545 for retrieve-limit errors.
1547 * src/modest-mail-operation.c: (foreach_add_item),
1548 (internal_folder_observer_update), (update_account_thread),
1549 (modest_mail_operation_get_msgs_full):
1550 (modest_mail_operation_update_account),
1551 Added comments about how this works, and some code that should
1552 (but does not) check the retrieve-limit. See the TODO comment.
1554 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1556 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1557 Initialize help_id to fix the build. Warnings are good.
1559 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1561 * src/widgets/modest-hbox-cell-renderer.c:
1562 (modest_hbox_cell_renderer_append):
1563 * src/widgets/modest-vbox-cell-renderer.c:
1564 (modest_vbox_cell_renderer_append):
1565 Fix the last commit by doing an extra ref.
1567 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1569 * src/widgets/modest-hbox-cell-renderer.c:
1570 (modest_hbox_cell_renderer_append):
1571 * src/widgets/modest-vbox-cell-renderer.c:
1572 (modest_vbox_cell_renderer_append):
1573 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1574 to fix the build with Maemo Bora.
1575 However, there seems to be a remaining crash, probably due to reference
1578 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1580 * src/modest-tny-account.c:
1581 (modest_tny_account_new_for_local_folders):
1582 Use hildon_file_system_info_async_new() to get a better name for
1583 the memory card account, setting it as the account name.
1584 The timing seems to work, but this is probably
1585 not the best place to do this. See the TODO comment.
1586 * src/maemo/modest-main-window.c: (create_details_widget):
1587 * src/widgets/modest-folder-view.c: (text_cell_data):
1588 Use the tny account name instead of hardcoding a name.
1590 2007-05-30 Christian Kellner <ckellner@openismus.com>
1592 * src/modest-search.c: (modest_search):
1593 Correctly set part_search_func even if we have already parsed
1594 the query and thus a valid OgsTextSearcher object.
1596 2007-05-30 Christian Kellner <ckellner@openismus.com>
1599 Search and check for libogs.
1602 Incooparte the ogs build env.
1604 * src/modest-mime-part-search-stream.c:
1605 * src/modest-mime-part-search-stream.h:
1606 Removed since we do the real searching now in modest-search.c.
1608 * src/modest-search.c:
1609 * src/modest-search.h:
1610 Implement support for ogs. We use that if available and requested
1611 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1612 should now handle the corner case when the search term is spread
1613 across multiple reads.
1614 Also the logic in modest_search () was corrected to search all
1615 requested fields until one is found.
1617 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1621 * src/modest-init.h:
1622 * src/modest-init.c: Made modest_init_local_folders() take a
1623 path and be public so we can iniitialize maildir folders on
1626 * src/modest-local-folder-info.h:
1627 * src/modest-local-folder-info.c:
1628 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1630 * src/modest-tny-account.c:
1631 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1632 still means the standard local-folders path on the local volume.
1634 * src/modest-tny-account-store.c:
1635 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1636 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1637 all accounts when that happens.
1638 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1639 this too, so it shows up in the treeview.
1641 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/modest-maemo-global-settings-dialog.c:
1644 (current_connection):
1645 * src/widgets/modest-global-settings-dialog.c:
1646 (current_connection_default):
1647 Use the enum values instead of 0, 1 and -1,
1648 to make the code clearer.
1650 * src/modest-account-mgr-helpers.c:
1651 (modest_account_mgr_get_connection_specific_smtp): Make this code
1654 * src/modest-runtime.h:
1655 * src/modest-runtime.c:
1656 Added modest_runtime_remove_all_send_queues().
1657 * src/maemo/modest-main-window.c:
1658 (on_account_store_connecting_finished): Recreate the send queues,
1659 using the appropriate transport accounts for this new connection.
1660 Some futher adapting might be needed if the old send queues are not
1661 automatically stopped at this point.
1663 * src/modest-tny-account-store.c: (get_server_accounts):
1664 Create the connection-specific transport accounts, so that they can
1665 be found later by their ID.
1667 * src/modest-tny-account.h:
1668 * src/modest-tny-account.c:
1669 Added modest_tny_account_new_from_server_account_name().
1670 modest_tny_account_new_from_server_account(): Do not create the
1671 send queues here, because they will be
1672 recreated anyway when the connection changes for the first time.
1674 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1676 * src/modest-local-folder-info.h:
1677 * src/modest-local-folder-info.c:
1678 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1679 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1680 tbox_folder): Take a modest account name instead of a server TnyAccount,
1681 so we can have per-modest-account rather than per-transport-account
1683 We must make sure that we change or recreate the exisitng send queues
1684 when the connection changes for connection-specific transport accounts.
1686 * src/modest-tny-account-store.c:
1687 (create_per_account_local_outbox_folders): Create outboxed per modest
1688 account, not per transport account.
1690 * src/modest-tny-account.h:
1691 * src/modest-tny-account.c:
1692 (modest_tny_account_get_special_folder): For outboxes, get the
1693 parent modest account name. The account is ignored for other folders.
1694 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1695 modest account name rather than a server TnyAccount.
1697 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1699 * src/modest-tny-account.c:
1700 (modest_tny_account_new_from_server_account):
1701 Call modest_runtime_get_send_queue() immediately after creating transport
1702 accounts, so that they start trying to send email from the outbox as soon
1703 as possible at startup. This is probably what we want.
1705 * src/modest-mail-operation.c: (update_account_thread):
1706 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1707 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1708 * src/modest-tny-send-queue.h:
1709 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1710 (modest_ui_actions_on_send):
1711 Added comments about how sending works, though it needs some more work.
1713 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1715 * src/modest-tny-account.c:
1716 (modest_tny_account_get_special_folder): Add TODO because this fails when
1717 the network is busy.
1718 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1719 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1720 Do not try to show this window when there is no active account. The UI
1721 specs does not tell us what to do in this case.
1723 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1727 * src/maemo/Makefile.am:
1728 * src/widgets/Makefile.am: Some dist fixes.
1730 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1732 * src/maemo/modest-connection-specific-smtp-window.c:
1733 (on_button_edit): Make the code clearer, to prevent a double free.
1735 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1737 * src/maemo/modest-account-settings-dialog.c:
1738 (modest_account_settings_dialog_set_account_name),
1739 Check the connection-specific smtp servers checkbox if there are any.
1741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1742 (modest_connection_specific_smtp_edit_window_init):
1743 Start with a suitable port number.
1745 * src/modest-account-mgr-helpers.h:
1746 * src/modest-account-mgr-helpers.c: Added
1747 modest_account_mgr_get_has_connection_specific_smtp().
1749 (modest_account_mgr_set_connection_specific_smtp),
1750 (modest_account_mgr_remove_connection_specific_smtp),
1751 (modest_account_mgr_get_has_connection_specific_smtp),
1752 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1753 connection-specific smtp server accounts in the account, rather than
1754 the server account conf dir.
1756 This fixes bug projects.maemo.org bug NB#58263 .
1758 * src/modest-tny-account-store.c:
1759 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1760 if there are no server accounts yet, to prevent an infinite loop when there
1761 are no accounts. Document that one must be called before the other.
1763 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1765 * src/modest-account-mgr-helpers.c:
1766 (modest_account_mgr_get_default_account): Make sure that at least
1767 one account is always the default, if there are any enabled accounts.
1768 This is just a sanity check that shouldn't be necessary.
1770 * src/modest-account-mgr-priv.c:
1771 (_modest_account_mgr_account_from_key): Unescape the conf key to
1772 get the real account name. For instance, this is an issue if a space
1773 was in the account name, which can happen because the account name
1774 is generated from the display name.
1775 (_modest_account_mgr_get_account_keyname): Always escape the
1777 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1778 Unescape the conf keys to get the real account names.
1780 For instance, previously the is-default radio button in the accounts
1781 list was not checked for any accounts at first. This fixes that,
1782 and might fix several similar bugs.
1784 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1786 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1787 Removed some debug printfs.
1789 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1791 Modest on-disk outbox directories are now here, for instance:
1792 $HOME/.modest/outboxes/<account-id-1>/outbox
1793 $HOME/.modest/outboxes/<account-id-2>/outbox
1795 $HOME/.modest/local-folders/outbox
1796 so we can have a separate outbox for each account.
1797 But they are shown as one outbox in the GtkTreeView, by using a
1798 TnyMergeFolder in a ModestTnySimpleFolderStore.
1801 * src/modest-tny-simple-folder-store.c:
1802 * src/modest-tny-simple-folder-store.h:
1803 Added ModestTnySimpleFolderStore, used to contain folders from
1804 other folder stores, such as other accounts.
1806 * src/modest-tny-outbox-account.h:
1807 * src/modest-tny-outbox-account.c:
1808 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1809 used for the per-account local outbox folders.
1811 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1812 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1813 only use this (internally) now for the non-outbox local folders.
1815 * src/modest-init.h:
1816 * src/modest-init.c: Added modest_init_one_local_folder(), for
1817 setting up the directory structure for each local folder.
1819 * src/modest-local-folder-info.c:
1820 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1821 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1823 * src/modest-local-folder-info.h:
1824 * src/modest-tny-account-store.c: (on_account_removed),
1825 (on_account_changed), (create_per_account_local_outbox_folders),
1826 (get_server_accounts), (modest_tny_account_store_get_accounts),
1827 (modest_tny_account_store_get_tny_account_by_account),
1828 (modest_tny_folder_store_is_virtual_local_folders):
1830 * src/modest-tny-account.h:
1831 * src/modest-tny-account.c:
1832 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1833 to create an on-disk per-account local outbox folder for each
1835 (create_per_account_local_outbox_folders): Create a local outbox folder
1836 for each transport account.
1837 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1838 for all local folders.
1840 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1841 instead of using g_object_get/set() directly. It is clearer.
1843 (modest_tny_folder_store_get_message_count),
1844 (modest_tny_folder_store_get_local_size
1845 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1846 because we now use these with non-acount folder stores.
1848 (modest_tny_account_get_special_folder),
1849 (modest_tny_account_new_from_server_account),
1850 (modest_tny_account_new_from_account):
1851 (recurse_folders): Adjust to the new outbox system.
1853 * src/modest-tny-folder.h:
1854 * src/modest-tny-folder.c:
1855 (modest_tny_folder_is_local_folder),
1856 (modest_tny_folder_get_local_folder_type),
1857 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1859 * src/widgets/modest-main-window.h:
1860 * src/maemo/modest-main-window.c: (create_details_widget),
1861 (modest_main_window_set_contents_style): Show details for any folder store,
1864 (modest_tny_folder_get_rules):
1865 Remove the const. C does not support constness enough for this.
1867 * src/modest-ui-actions.c:
1868 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1869 make all outboxes appear as one, in the usual local-folders tree node.
1871 (set_active_account_from_tny_account),
1872 (modest_ui_actions_on_folder_selection_changed):
1873 * src/widgets/modest-folder-view.c: (text_cell_data),
1874 (icon_cell_data), (filter_row),
1875 (add_account_folders_to_merged_folder),
1876 (add_account_folders_to_simple_folder_store), (),
1877 (get_cmp_rows_type_pos), (cmp_rows),
1878 (modest_folder_view_set_account_id_of_visible_server_account):
1879 Adjust to the new outbox system, using generic folder stores and folders
1880 in the GtkTreeModel.
1882 2007-05-23 Christian Kellner <ckellner@openismus.com>
1884 * src/modest-mail-operation.c:
1885 (modest_mail_operation_update_account):
1886 Use info->max_size instead of unintialized local var [small
1887 build fix]. (Added TODO to review that change since I don't
1890 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1892 * libmodest-dbus-client/libmodest-dbus-client.c:
1893 (libmodest_dbus_client_compose_mail): function added
1894 * src/dbus_api/modest-dbus-api.h:
1895 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1896 (on_compose_mail): Implementation of the SendAsMail functionality
1898 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1900 * src/modest-account-mgr.c:
1901 (modest_account_mgr_add_server_account): Set the secure-connection
1902 conf key for transport accounts as well as store accounts. I don't know
1903 why the if was there. For instance, this makes sure that we use SSL
1904 for the gmail preset from the easysetup wizard.
1906 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1908 * src/gnome/modest-main-window.c:
1909 (on_account_store_connecting_finished), (connect_signals):
1910 * src/maemo/modest-main-window.c:
1911 (on_account_store_connecting_finished), (connect_signals),
1912 (modest_main_window_new):
1913 Handle TnyAccountStore::connecting-finished instead of
1914 TnyDevice::connection-changed, because we cannot actually perform
1915 operations on accounts until TnyAccountStore has itself responded to
1916 the TnyDevice::connection-changed signal. This prevents a GError from
1918 Do not try to update at startup, because we (at least on scratchbox)
1919 already do an update at startup when the device goes online.
1920 This prevents a GError from tinymail.
1921 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1922 Added TODO about stopping simultaneous operations.
1924 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1926 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1927 * src/modest-mail-operation-queue.c:
1928 (modest_mail_operation_queue_remove):
1929 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1930 about where they happened.
1932 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1934 * src/modest-ui-actions.c:
1935 (modest_ui_actions_on_password_requested): Make sure that the remember
1936 output parameter is always TRUE.
1938 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1940 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1941 Show a OK/Cancel dialog if the error is a question, though we still do not
1942 know anything more about what we are asking the user.
1943 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1944 Fix an uninitialized variable (helper). This is a logic error, however.
1946 2007-05-21 Christian Kellner <ckellner@openismus.com>
1948 * src/modest-search.h:
1949 Correct bit shifting in the ModestSearchFlags enum.
1951 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1953 * src/modest-tny-account.c:
1954 (modest_tny_account_new_from_server_account): Do not use the lsub and
1955 check-all hard-coded IMAP options when using POP.
1957 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1959 * src/modest-tny-account.c:
1960 (modest_tny_account_new_from_server_account):
1961 Use NULL for the secure-auth method for POP when Password auth has been
1962 specified by the user, as we already do for IMAP. "auth=Login" causes
1963 an error from camel or the server.
1965 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1967 * src/maemo/modest-account-settings-dialog.c:
1968 (create_page_account_details),
1969 (modest_account_settings_dialog_set_account_name):
1970 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1971 for the leave-on-server checkbox, rathr than just the checkbox, when
1972 the protocol is not POP.
1974 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1976 * src/widgets/modest-account-view.c:
1977 * src/widgets/modest-account-view.h:
1978 Added modest_account_view_select_account() which will be useful later
1979 to asynchronously re-select the edited account.
1981 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1983 * src/maemo/modest-account-settings-dialog.c:
1984 (modest_account_settings_dialog_set_account_name):
1985 Automatically choose the port numbers based on the secure authentication
1986 methods, if they have not been chosen before.
1987 This fixes projects.maemo.org bug NB#56273 .
1989 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1991 * src/maemo/modest-main-window-ui.h:
1992 * src/modest-ui-actions.c:
1993 * src/modest-ui-actions.h:
1994 Connect the Tools/SMTP Servers menu item to
1995 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1996 SMTP servers dialog, as in the UI specification and saves changes when it
1997 is closed. This fixed projects.maemo.org bug NB#56305 .
1999 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2001 * src/maemo/modest-connection-specific-smtp-window.c:
2002 (modest_connection_specific_smtp_window_init):
2003 Use gtk_window_set_default_size() to make this window big enough, so
2004 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2006 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2009 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2010 (modest_connection_specific_smtp_edit_window_init),
2011 Do not try to connect to a combobox signal before the combobox exists.
2012 This fixes the cras in projects.maemo.org bug NB#56288 .
2013 (modest_connection_specific_smtp_edit_window_get_settings):
2014 Remove the server_account_name parameter which was being checked for NULL
2015 though it was not used.
2017 * src/maemo/modest-connection-specific-smtp-window.c:
2018 (modest_connection_specific_smtp_window_fill_with_connections),
2019 (on_button_edit), (modest_connection_specific_smtp_window_init):
2020 Correct the number of treemodel columns to prevent a warning.
2021 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2022 libconic does not work.
2024 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2026 * src/modest-tny-account.c:
2027 (modest_tny_account_new_from_server_account):
2028 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2029 SMTP when "None" was chosen by the user. However, with my SMTP server that
2030 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2033 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2035 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2036 to explain the memory management issue with the ID in the ModestPair.
2038 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2039 (add_sending_page), (modest_account_assistant_finalize):
2040 * src/gnome/modest-gnome-global-settings-dialog.c:
2041 (create_updating_page), (create_composing_page):
2042 * src/gnome/modest-msg-edit-window.c: (get_transports),
2043 (init_window), (modest_msg_edit_window_finalize),
2044 (modest_msg_edit_window_get_msg_data):
2045 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2046 * src/gnome/modest-transport-widget.c:
2047 (modest_transport_widget_finalize), (smtp_configuration):
2048 * src/maemo/modest-maemo-global-settings-dialog.c:
2049 (create_updating_page), (create_composing_page):
2050 * src/maemo/modest-msg-edit-window.c: (get_transports),
2051 (init_window), (modest_msg_edit_window_finalize),
2052 (modest_msg_edit_window_get_msg_data),
2053 (modest_msg_edit_window_free_msg_data):
2054 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2055 (modest_store_widget_finalize):
2056 * src/maemo/modest-transport-widget.c:
2057 (modest_transport_widget_finalize), (smtp_configuration):
2058 * src/modest-main.c: (send_mail):
2059 * src/widgets/modest-combo-box.h:
2060 * src/widgets/modest-global-settings-dialog-priv.h:
2061 * src/widgets/modest-global-settings-dialog.c:
2062 (modest_global_settings_dialog_finalize):
2063 * src/widgets/modest-msg-edit-window.h:
2064 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2065 as long as the combo box, to prevent use of freed memory for the ID.
2067 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2069 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2070 get_accounts(), to make this clearer. Do not check for the enabled gconf
2071 key, because we do not use this for server accounts (at least, not yet).
2072 This allows us to send email again.
2074 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/modest-platform.c:
2077 (on_modest_conf_update_interval_changed), (modest_platform_init):
2078 Only respond to this particular key change. All these strcmp()s cannot be
2081 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2083 * src/maemo/modest-maemo-global-settings-dialog.c:
2084 (current_connection): Prevent a crash in scratchbox when
2085 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2086 * src/maemo/modest-platform.c:
2087 (on_modest_conf_update_interval_changed), (modest_platform_init):
2088 Get the update interval from gconf and reset it when the gconf key changes.
2090 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2092 * src/modest-protocol-info.c:
2093 * src/modest-protocol-info.h: Adde enum-specific get functions,
2094 instead of using a ModestProtocolType enum parameter.
2096 * src/gnome/modest-account-assistant.c:
2097 * src/gnome/modest-store-widget.c:
2098 * src/gnome/modest-store-widget.h:
2099 * src/gnome/modest-transport-widget.c:
2100 * src/gnome/modest-transport-widget.h:
2101 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2102 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2103 * src/maemo/easysetup/modest-easysetup-wizard.c:
2104 * src/maemo/modest-account-settings-dialog.c:
2105 * src/maemo/modest-account-settings-dialog.h:
2106 * src/maemo/modest-store-widget.c:
2107 * src/maemo/modest-store-widget.h:
2108 * src/maemo/modest-transport-widget.c:
2109 * src/maemo/modest-transport-widget.h:
2110 * src/modest-account-mgr-helpers.c:
2111 * src/modest-account-mgr-helpers.h:
2112 * src/modest-account-mgr.c:
2113 * src/modest-account-mgr.h:
2114 * src/modest-tny-account.c:
2115 * src/modest-tny-folder.c:
2116 * src/widgets/modest-account-view.c:
2117 * src/widgets/modest-retrieve-combo-box.c:
2118 * src/widgets/modest-retrieve-combo-box.h:
2119 * src/widgets/modest-secureauth-combo-box.c:
2120 * src/widgets/modest-serversecurity-combo-box.c:
2121 * src/widgets/modest-serversecurity-combo-box.h:
2122 * tests/check_account-mgr.c:
2123 Use the specific functions, and use the re-renamed enum values for GNOME too.
2125 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2127 * src/modest-pair.h:
2128 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2129 so we can get the second based on the first.
2131 * src/maemo/modest-account-settings-dialog.h:
2132 * src/maemo/modest-account-settings-dialog.c:
2133 Added get_supported_secure_authentication_methods(), though it is mostly
2134 commented-out for now until the necessary API is committed to tinymail.
2135 (modest_account_settings_dialog_set_account_name),
2136 (save_configuration): Request the supported authentication methods from the
2137 server, so we can choose a working method.
2139 * src/modest-tny-account-store.h:
2140 * src/modest-tny-account-store.c:
2141 (modest_tny_account_store_get_session): Rename from
2142 tny_account_store_get_session().
2144 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2146 * src/modest-protocol-info.h: Split the ModestProtocol enum
2147 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2148 There was no need to have these unrelated values in one enum.
2150 * src/: many files: Adapted to changed enum. This makes the code a bit
2151 clearer, and the compiler could catch some errors.
2153 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2155 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2156 Show the detailed internal camel error message when an error happens
2157 during the configuration, so that our testers can give us more clues.
2158 For instance, in projects.maemo.org bug NB#56910 .
2160 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2162 * src/modest-tny-account.c:
2163 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2164 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2166 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2168 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2169 * src/maemo/modest-account-settings-dialog.c:
2170 (modest_account_settings_dialog_set_account_name),
2171 (save_configuration): For the incoming secure authentication checkbox,
2172 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2173 the UI specification. PLAIN does not seem to be supported for most IMAP
2174 servers anyway, and I am not sure what it would mean.
2175 However, we probably need to discover which of the secure-authentication
2176 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2177 * src/modest-account-mgr-helpers.c:
2178 (modest_account_mgr_get_server_account_data):
2180 * src/modest-tny-account.c:
2181 (modest_tny_account_new_from_server_account):
2182 Use tny_account_set_mech() to set secure-authentication methods,
2183 with some special-casing for IMAP, based on my observations of how
2186 * src/modest-account-mgr-helpers.h:
2187 * src/modest-account-mgr.c:
2188 * src/modest-defs.h: Comment that the URI is only used for local folders.
2190 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2192 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2193 parameter const, just to be neat.
2194 * src/modest-text-utils.c: (modest_text_utils_inline):
2195 End g_strconcat() with NULL, as its documentation says. This is almost
2196 certainly the cause of my crash at startup on the device. Interestingly,
2197 valgrind doesn't tell us about these errors.
2199 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2201 * scripts/build-packages: Added more precise comments about how to use
2202 this script, though I still get this error:
2203 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2204 error building tinymail
2206 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2208 * src/maemo/modest-main-window.c: (on_account_update):
2209 Very slight cleanup, hoping to make it simpler to discover what causes
2210 a crash here sometimes.
2212 * src/modest-tny-account.c:
2213 (modest_tny_account_new_from_server_account): Set the port. Added
2214 comments about the options and a TODO comment because I need to find out
2215 how to specify the secure authentication method.
2217 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2219 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2220 changed CFlags paths form modest to libmodest
2222 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2224 * src/modest-account-mgr-helpers.c:
2225 (modest_account_mgr_get_server_account_data),
2226 (modest_account_mgr_free_server_account_data):
2227 * src/modest-account-mgr-helpers.h:
2228 * src/modest-account-mgr.c:
2229 (modest_account_mgr_add_server_account):
2230 * src/modest-defs.h:
2231 * src/modest-tny-account.c:
2232 (modest_tny_account_new_from_server_account):
2233 Determine the options for tny_camel_account_add_option() here,
2234 based on the settings, rather than storing them directly in gconf.
2236 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2238 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2239 Show a more friendly error dialog now that we expect (from the tinymail
2240 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2242 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2244 * src/maemo/modest-main-window.c: (on_account_update): Check that
2245 account_name is not NULL, to prevent a crash at startup that I am
2246 seeing on the N800. I do wonder why it is NULL.
2248 * src/maemo/easysetup/modest-easysetup-wizard.c:
2249 (create_page_user_details):
2250 * src/maemo/modest-account-settings-dialog.c:
2251 (create_page_user_details), (create_page_outgoing):
2252 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2253 (modest_connection_specific_smtp_edit_window_init):
2254 * src/modest-ui-actions.c:
2255 (modest_ui_actions_on_password_requested):
2256 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2257 might do something useful with the on-screen keyboard.
2259 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2261 * src/maemo/modest-main-window.c: (on_account_update):
2262 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2263 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2265 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2267 * src/modest-tny-account-store.c: (on_account_changed):
2268 Correct the signature of this signal handler.
2270 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2272 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2273 Show a HildonNote instead of a GtkDialog for Maemo.
2275 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2277 * src/widgets/modest-account-view.h:
2278 * src/widgets/modest-account-view.c: (on_account_changed),
2279 (on_account_removed). Added a boolean flag, set/unset by
2280 modest_account_view_block_conf_updates(),
2281 modest_account_view_unblock_conf_updates() to prevent unnecessary
2282 updates, but this is not very useful because the gconf notifications are
2283 so delays (maybe only on Maemo Bora).
2284 So auto-updating is turned off, and these functions do an explicit
2285 update when necessary.
2286 However, something else is still doing too much work when adding/removing
2287 accounts, probably in another part of the application.
2289 * src/maemo/modest-account-view-window.c:
2290 (on_delete_button_clicked), (on_edit_button_clicked),
2291 (on_new_button_clicked): Use the new functions.
2293 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2295 * src/modest-account-mgr-helpers.c:
2296 (modest_account_mgr_set_first_account_as_default):
2297 Sort the list of names alphabetically-by-title, so we choose the first one
2299 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2300 alphabetically by the title.
2302 This fixes projects.maemo.org bug NB#56418 .
2304 * src/modest-account-mgr-priv.c:
2305 (_modest_account_mgr_account_from_key):
2306 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2307 avoid a valgrind error, and possible random behaviour.
2309 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2311 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2312 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2313 tinymail documentation to say that this can be expected.
2314 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2315 pretty, and should not happen, but I would prefer to know when it does.
2317 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2319 * configure.ac: When using the older hildon version, probably on Bora,
2320 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2322 * src/widgets/modest-attachment-view.c:
2323 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2326 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2328 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2329 Implemented the prototype. Can be tested with
2330 tests/dbus_api/test_open_message:
2332 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2334 * src/modest-tny-account-store.c:
2335 (modest_tny_account_store_instance_init), (get_password):
2336 * src/modest-ui-actions.c:
2337 (modest_ui_actions_on_password_requested):
2338 Do not store the password in gconf, because this function is called
2339 for non-remembered passwords. Actually use the cached (in the hash map)
2340 password instead of releasing it.
2341 The password will now not be remembered if it is asked via the protected
2342 password dialog, as per the UI spec.
2344 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2346 * src/modest-defs.h:
2347 * src/modest-account-mgr-helpers.h:
2348 * src/modest-account-mgr-helpers.c:
2349 Added modest_server_account_get_username_has_succeeded(),
2350 modest_server_account_set_username_has_succeeded().
2351 (modest_server_account_set_username),
2352 Reset the has-succeeded flag if the username changes.
2354 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2355 * src/maemo/modest-connection-specific-smtp-window.c:
2356 (modest_connection_specific_smtp_window_save_server_accounts):
2357 Use modest_server_account_set_username() instead of using
2358 modest_conf_set_string() directly, so that the has-succeeded flag is always
2361 * src/modest-ui-actions.c:
2362 (modest_ui_actions_on_password_requested): Dim the username entry if
2363 the username has ever worked, as per the UI spec.
2365 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2367 * src/modest-tny-account-store.c: (get_password):
2368 * src/modest-ui-actions.c:
2369 (modest_ui_actions_on_password_requested):
2370 Allow the username to be changed too, though there is more work to
2371 be done on exactly how this behaves.
2373 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2375 * src/modest-account-mgr-helpers.h:
2376 * src/modest-account-mgr-helpers.c:
2377 Added modest_account_mgr_get_display_name(),
2378 modest_server_account_get_username(),
2379 modest_server_account_set_username(),
2380 modest_server_account_set_password(),
2381 modest_server_account_get_hostname() functions so we do not need to
2382 use the conf API directly.
2384 * src/maemo/modest-main-window.c: (connect_signals):
2385 Actually connect ot the ModestAccountStore::request-password signal,
2386 so that we show the dialog when the password is requested by Tinymail,
2387 for isntance if it is empty.
2389 * src/modest-marshal.list:
2390 * src/modest-tny-account-store.c:
2391 (modest_tny_account_store_class_init), (get_password),
2392 (modest_tny_account_store_alert):
2393 * src/modest-tny-account-store.h:
2394 * src/modest-ui-actions.h:
2395 * src/modest-ui-actions.c:
2396 (modest_ui_actions_on_password_requested):
2397 Change the signal parameters, so it is obvious that we are providing
2398 the non human-readable server name, and receiving both the username
2399 and password, though changing of the username is not yet implemented.
2400 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2401 for the GNOME version.
2403 This should fix the projects.maemo.org bug NB#56209, though it does not
2404 work on Bora, because the gconf_client_get() for the password fails
2405 immediately after we save it with gconf_client_set().
2407 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2410 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2411 caused an undefined symbol error:
2412 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2414 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2416 * src/modest-tny-account-store.c:
2417 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2418 using a GError instead of a string message, so we can translate it in
2421 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2423 * src/maemo/modest-address-book.c:
2424 (modest_address_book_check_names):
2425 * src/maemo/modest-msg-view-window.c:
2426 (modest_msg_view_window_clipboard_owner_change):
2427 * src/modest-init.c: (modest_init_init_ui):
2428 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2429 (update_folders_cb), (modest_mail_operation_update_account):
2430 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2431 (modest_ui_actions_on_msg_attachment_clicked),
2432 (modest_ui_actions_on_msg_recpt_activated):
2433 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2434 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2435 (modest_msg_view_search_next):
2436 * src/widgets/modest-recpt-editor.c:
2437 (modest_recpt_editor_on_button_release_event),
2438 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2439 g_message(). At this point we should only be seeing interesting errors on
2440 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2442 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2444 (modest_wizard_dialog_force_title_update):
2445 * src/maemo/easysetup/modest-wizard-dialog.h:
2446 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2447 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2448 can update the title when appropriate. Otherwise the title is wrong if the
2449 pages are added after adding the notebook to the dialog.
2450 This must be a problem in HildonWizardDialog too.
2451 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2453 * src/maemo/easysetup/modest-easysetup-wizard.c:
2454 (create_subsequent_customsetup_pages),
2455 (create_subsequent_easysetup_pages):
2456 Call modest_wizard_dialog_force_title_update() so that the title is
2457 correct even with GTK+ < 2.10.
2458 This fixes projects.maemo.org bug NB#56145 .
2460 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2462 * src/maemo/modest-platform.c:
2463 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2464 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2467 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2469 * src/widgets/modest-window.h:
2470 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2471 and modest_window_save_state(), which invokes it.
2473 * src/widgets/modest-window-mgr.h:
2474 * src/widgets/modest-window-mgr.c:
2475 Added modest_window_mgr_save_state_for_all_windows(), which calls
2476 the save_state vfunc on all registered windows, if implemented.
2478 * src/gnome/modest-msg-edit-window.c:
2479 * src/gnome/modest-msg-view-window.c:
2480 * src/maemo/modest-msg-edit-window.c:
2481 * src/maemo/modest-msg-view-window.c:
2482 * src/maemo/modest-main-window.c:
2483 Specify the existing save_settings functions as implementations of
2484 ModestWindow::save_state_func().
2486 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2487 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2488 enabling hibernation, for instance.
2490 We may need to do the same thing for restoring settings.
2493 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2495 * src/widgets/modest-window-mgr.c:
2496 * src/widgets/modest-window-mgr.h:
2497 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2498 modest_window_mgr_get_hibernation_is_prevented().
2500 * src/maemo/modest-main-window.c:
2501 (on_hildon_program_is_topmost_notify): Prevent hibernation
2502 (possible when the application goes to the background in the WM),
2503 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2505 * src/maemo/easysetup/modest-easysetup-wizard.c:
2506 (modest_easysetup_wizard_dialog_init):
2507 * src/maemo/modest-account-settings-dialog.c:
2508 (modest_account_settings_dialog_init):
2509 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2510 (modest_connection_specific_smtp_edit_window_init):
2511 * src/maemo/modest-connection-specific-smtp-window.c:
2512 (modest_connection_specific_smtp_window_init):
2513 * src/maemo/modest-signature-editor-dialog.c:
2514 (modest_signature_editor_dialog_init):
2515 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2516 prevent hibernation while any of these account settings dialogs are open.
2518 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2520 * src/maemo/Makefile.am:
2521 * src/maemo/modest-osso-state-saving.c:
2522 * src/maemo/modest-osso-state-saving.h: Added
2523 modest_osso_load_state() and modest_osso_save_state() though they do
2524 nothing now. They should iterate through all the open windows and load/save
2526 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2527 save state when closing.
2529 * src/maemo/modest-main-window.c:
2530 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2531 Add a notification handler for the HildonProgram::is-topmost property,
2532 so we can allow hibernation when the application goes into the background.
2533 But we still need to detect when the accounts setup windows are open so
2534 we can stop hibernation when they are open.
2535 To do this, I also added the main window the HildonProgram. This might have
2536 other side-effects/benefits, and should maybe be done for other windows.
2538 * src/maemo/modest-osso-autosave-callbacks.h:
2539 * src/maemo/modest-osso-autosave-callbacks.c:
2540 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2541 though it does not do anything yet, and we might never need this to do
2542 anything. For instance, we already save drafts.
2544 * src/maemo/modest-platform.c: (modest_platform_init):
2545 Specify the libosso auto-save callback.
2547 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2549 * src/maemo/modest-platform.c:
2550 (modest_platform_set_update_interval):
2551 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2552 aparently stays valid between application instances, so we can use this
2553 to remove and reset it later. According to a maemo-developers email from
2556 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2558 * configure.ac: Depend on libalarm for Maemo.
2560 * src/dbus_api/modest-dbus-api.h:
2561 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2562 (on_send_receive), (modest_dbus_req_handler):
2563 Handle a SEND_RECEIVE D-Bus method.
2565 * libmodest-dbus-client/libmodest-dbus-client.c:
2566 (libmodest_dbus_client_send_and_receive):
2567 * libmodest-dbus-client/libmodest-dbus-client.h:
2568 Add C convenience functions for calling the new D-Bus method.
2570 * src/modest-platform.h:
2571 * src/gnome/modest-platform.c:
2572 * src/maemo/modest-platform.c:
2573 Added modest_platform_set_update_interval(), which uses the
2574 alarmd API on Maemo.
2575 (modest_platform_init),
2576 Call modest_platform_set_update_interval(), using a hard-coded
2577 interval for now (until the global settings dialog is implemented),
2578 though I am not sure that this makes sense yet.
2580 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2582 * src/dbus_api/modest-dbus-callbacks.c:
2583 (modest_osso_cb_hw_state_handler):
2584 * src/dbus_api/modest-dbus-callbacks.h:
2585 * src/maemo/modest-platform.c: (modest_platform_init):
2586 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2587 in case this has some effect on the ability for Maemo to ping the
2590 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2592 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2593 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2594 warning. It is probably a logic error, but I need to fix the build.
2596 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2598 * src/modest-account-mgr.h:
2599 * src/modest-account-mgr.c:
2600 (modest_account_mgr_account_names): Add a gboolean enabled_only
2601 parameter, so we can get lists of onlt the enabled accounts.
2603 (modest_account_mgr_add_account),,
2604 (modest_account_mgr_account_with_display_name_exists):
2605 * src/maemo/modest-msg-edit-window.c: (get_transports):
2606 * src/modest-account-mgr-helpers.c:
2607 (modest_account_mgr_set_first_account_as_default):
2608 * src/modest-init.c: (init_default_account_maybe):
2609 * src/modest-tny-account-store.c: (get_accounts):
2610 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2611 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2612 * tests/check_account-mgr.c: (START_TEST):
2613 Provide the extra parameter, as appropriate.
2615 * src/widgets/modest-account-view.c: (update_account_view):
2616 Do not show disabled accounts (meaning that there is no way to
2617 enable/disable accounts in the UI (the feature is not in our UI
2618 specification), so we can use this internally only to mark unfinished
2619 or temporary account data.
2621 * src/maemo/easysetup/modest-easysetup-wizard.c:
2622 (create_account): Add boolean enable parameter, so we can specify FALSE
2623 to create the temporary account.
2624 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2625 (on_before_next): When finishing, when there is a temporary account, just
2627 Also, use a timeout to delay the showing of the dialog until gconf is likely
2628 to return correct information, due to a maemo gconf bug that is fixed in
2629 osso 1.1, but not yet in Bora.
2630 However, the dialog stays on screen after it is destroyed.
2632 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2633 for invalid data when cancelling. Use a hildon note instead of a dialog
2634 to complain about invalid data. Do not show the account-saved note if the
2635 account is disabled (a temporary account that will not really be saved for use
2638 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2640 * src/modest-account-mgr-helpers.h:
2641 * src/modest-account-mgr-helpers.c:
2642 Added modest_account_mgr_unset_default_account(),
2643 Added modest_account_mgr_set_first_account_as_default().
2645 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2646 If it was the default account, unset the default account name.
2648 * src/maemo/modest-account-view-window.c:
2649 (on_delete_button_clicked): If it was the default account,
2650 set the first remaining account as the default instead.
2652 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2653 a NULL account or a NULL default account, to prevent a crash. This should
2654 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2657 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2659 * src/widgets/modest-recpt-editor.c:
2660 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2661 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2662 TODO comment for this. This fixes the build.
2664 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2665 be the best place for it. This will in future update all auto-update accounts,
2666 rather than just the current/default account, when that gconf key exists.
2667 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2668 if there are no accounts, before calling do_send_receive().
2669 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2671 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2672 * src/maemo/modest-main-window-ui.h:
2673 * src/maemo/modest-main-window.c: (on_connection_changed),
2674 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2675 directly, becaue the signal handler does more.
2677 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2679 * src/modest-account-mgr-helpers.c:
2680 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2681 for the case that the account does not exist.
2683 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2684 (equivalent to the modest account name) rather than the tinymail account name
2685 (equivalent to the modest account title - human readable) to get the account data.
2686 Check for null account data to prevent the crash, and add a TODO comment saying that
2687 this needs fixing because it is using the server account name instead of the account name.
2689 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2691 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2692 * src/maemo/modest-account-settings-dialog.c: (show_error),
2694 Use hildon_note_new_information() for informative and error messages,
2695 which seems to be expected for Maemo applications (no documentation that I know of
2696 says this). I am surprised that there is no distinction between info and error
2699 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2701 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2702 it is easy to find where this is used.
2704 * src/maemo/easysetup/modest-easysetup-wizard.c:
2705 (create_page_welcome), (create_page_account_details),
2706 (create_page_user_details), (create_page_complete_easysetup),
2707 (create_page_custom_incoming), (create_page_custom_outgoing),
2708 (create_page_complete_custom):
2709 * src/maemo/modest-account-settings-dialog.c:
2710 (create_page_account_details), (create_page_user_details),
2711 (create_page_incoming), (create_page_outgoing):
2712 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2713 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2714 (modest_connection_specific_smtp_edit_window_init):
2715 * src/maemo/modest-connection-specific-smtp-window.c:
2716 (modest_connection_specific_smtp_window_init):
2717 * src/maemo/modest-signature-editor-dialog.c:
2718 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2719 and scrolling policy as per the Email Application Layout Guide, if I have
2722 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2724 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2725 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2726 which were empty, because these vfuncs have been removed from TnyAccountStore.
2727 This fixes the build.
2729 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2731 * src/maemo/modest-main-window.c:
2732 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2733 showing/hiding it. Added TODO because it probably should not be NULL.
2734 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2735 because unnecessary g_warnings() make degugging difficult.
2737 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2739 * src/maemo/modest-msg-edit-window.c:
2740 (modest_msg_edit_window_select_color),
2741 (modest_msg_edit_window_select_background_color): 2 const corrections and
2742 moving 2 #endifs before closing brackets, to fix the build.
2744 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2746 * src/maemo/easysetup/modest-easysetup-wizard.h:
2747 * src/maemo/easysetup/modest-easysetup-wizard.c:
2748 (modest_easysetup_wizard_dialog_finalize),
2749 (on_button_edit_advanced_settings), (create_page_complete_custom),
2750 (on_response), (create_account):
2751 Implement the Advanced Settings edit button, by saving the account information,
2752 for the Advanded Settings dialog to use directly from gconf, and removing it
2753 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2754 Bug #5533 in the projects.maemo.org bugzilla.
2756 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2758 * src/maemo/modest-msg-view-window.c:
2759 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2760 when opening a message window.
2762 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2764 * src/maemo/easysetup/modest-easysetup-wizard.c:
2765 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2768 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2769 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2770 gconf settings. I probably added more checks than necessary, but that is safer.
2772 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2773 variable to fix the build, but this seems to be used when it is still NULL.
2775 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2777 * src/modest-platform.h:
2778 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2779 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2780 * src/modest-main.c: Implement this function so we can avoid using
2781 maemo-specific API from cross-platform code.
2783 * src/modest-tny-account-store.c:
2784 (get_smtp_specific_transport_account_for_open_connection):
2785 * src/modest-ui-actions.c: (check_for_connection),
2786 (modest_ui_actions_on_item_not_found):
2787 Use modest_platform_connect_and_wait() and put #idefs around other
2788 maemo-specific code, because only maemo currently has a way to
2789 identify connection names.
2791 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2793 * src/modest-tny-account-store.h:
2794 * src/modest-tny-account-store.c:
2795 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2796 the connection-specific SMTP server settings in the configuration.
2798 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2800 * src/maemo/modest-main-window.c: (on_connection_changed),
2802 * src/modest-main.c: (main), (start_ui), (send_mail):
2803 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2804 that is what is intended.
2806 * src/modest-ui-actions.c: (action_send), (action_receive),
2807 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2808 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2809 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2810 SMTP server is used when it is specified.
2812 (modest_ui_actions_on_send_receive):
2813 Check that a connection is open before proceeding.
2814 Receive and then send, instead of vice-versa, as per the specification.
2816 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2818 * src/modest-mail-operation.c:
2819 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2820 though I guess it should be something other than NULL.
2822 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2824 * src/maemo/easysetup/modest-easysetup-wizard.c:
2825 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2826 combo twice, to avoid an g_warning and to make it visible again.
2827 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2828 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2829 (already intended) dereference when detaching, because we then recreate the menu.
2830 But I am not sure why the warning was happening, and it is possible that this is a memory
2833 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2835 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2836 and uri_parse_mailto() utility functions.
2837 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2839 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2841 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2843 * src/dbus_api/modest-dbus-api.h:
2844 * src/dbus_api/modest-dbus-callbacks.c:
2845 Use an idle callback to execute the modest code in the application's own thread.
2846 Remove the helloworld example method.
2847 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2848 parsed, and the open-message method is not implemented because this is not yet implemented in
2850 * libmodest-dbus-client/libmodest-dbus-client.c:
2851 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2852 (libmodest_dbus_client_open_message):
2853 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2855 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2856 body without crashing.
2858 * tests/dbus_api/Makefile.am:
2859 * tests/dbus_api/test_mail_to.c:
2860 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2862 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2864 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2865 Added file to fix the build. Sorry.
2867 * src/dbus_api/Makefile.am:
2868 * src/dbus_api/modest-dbus-api.h:
2869 * src/dbus_api/modest-dbus-callbacks.h:
2870 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2871 (modest_dbus_req_handler):
2872 Put constants in a separate header so it can be reused by the
2873 client library, without duplication
2875 * libmodest-dbus-client/Makefile.am:
2876 * libmodest-dbus-client/libmodest-dbus-client.c:
2877 (libmodest_dbus_client_call_helloworld),
2878 (libmodfest_dbus_client_send_mail),
2879 (libmodfest_dbus_client_mailto),
2880 (libmodfest_dbus_client_open_message):
2881 * libmodest-dbus-client/libmodest-dbus-client.h:
2882 (Partly) Implement a send_mail D-Bus method.
2884 * tests/dbus_api/Makefile.am:
2885 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2886 the send_email D-Bus method.
2888 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2892 * libmodest-dbus-client/Makefile.am:
2893 * libmodest-dbus-client/libmodest-dbus-client.c:
2894 * libmodest-dbus-client/libmodest-dbus-client.h:
2895 * tests/dbus_api/Makefile.am:
2896 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2897 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2899 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2901 * src/maemo/easysetup/modest-easysetup-wizard.c:
2902 (create_page_account_details):
2903 * src/maemo/modest-account-settings-dialog.c:
2904 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2905 widgets, because this might not be the default in future versions of the Maemo GTK+.
2906 However, I can not not get capitalization to work even in a simple test case.
2908 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2910 * src/maemo/easysetup/modest-easysetup-wizard.c:
2911 (create_page_custom_incoming), (create_page_custom_outgoing):
2912 * src/maemo/modest-account-settings-dialog.c:
2913 (create_page_account_details), (create_page_incoming),
2914 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2915 instead of using gtk_check_button_with_label(), so they are aligned like the other
2916 widgets, as per the UI spec.
2918 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2920 * src/maemo/easysetup/modest-easysetup-wizard.c:
2921 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2922 * src/widgets/modest-validating-entry.c:
2923 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2924 Modest prefix instead of an EasySetup prefix.
2926 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2928 * src/widgets/modest-validating-entry.h:
2929 * src/widgets/modest-validating-entry.c: (on_insert_text),
2930 Added easysetup_validating_entry_set_max_func(), used to set a callback
2931 to call when the max number of characters is reached. GtkEntry has a max-length
2932 already but is silent about it.
2934 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2935 (create_page_account_details), (create_page_user_details),
2937 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2938 (create_page_account_details), (create_page_user_details),
2939 (create_page_outgoing):
2940 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2941 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2942 the UI spec, when the user tries to enter more than the max number of characters.
2944 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2946 * src/maemo/easysetup/modest-easysetup-wizard.c:
2947 (create_page_user_details), (create_page_custom_incoming),
2948 (create_page_custom_outgoing):
2949 * src/maemo/modest-account-settings-dialog.c:
2950 (create_page_user_details), (create_page_incoming),
2951 (create_page_outgoing):
2952 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2953 (modest_connection_specific_smtp_edit_window_init):
2954 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2955 not appropriate. Bad Maemo-specific defaults!.
2957 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2959 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2960 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2961 (modest_signature_editor_dialog_set_settings):
2962 Disable the label and textview when the checkbox is disabled, and use the
2963 specified (UI spec) default signature text.
2965 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2968 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2970 * src/modest-defs.h:
2971 * src/modest-account-mgr-helpers.h:
2972 * src/modest-account-mgr-helpers.c:
2973 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2975 * src/maemo/Makefile.am:
2976 * src/maemo/modest-signature-editor-dialog.c:
2977 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2980 * src/maemo/modest-account-settings-dialog.h:
2981 * src/maemo/modest-account-settings-dialog.c:
2982 (modest_account_settings_dialog_finalize), (on_button_signature),
2983 (save_configuration): Use the new dialog when the Edit button is pressed, and
2984 save the changes if necessary, as per the UI spec.
2986 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2988 * src/maemo/Makefile.am:
2989 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2990 based on maemo-develoers email from Dirk.
2992 * src/maemo/easysetup/modest-easysetup-wizard.c:
2993 (create_page_welcome), (create_page_account_details),
2994 (create_page_user_details), (create_page_complete_easysetup),
2995 (create_page_custom_incoming), (create_page_custom_outgoing),
2996 (create_page_complete_custom),
2997 (modest_easysetup_wizard_dialog_init):
2998 * src/maemo/modest-account-settings-dialog.c:
2999 (create_page_account_details), (create_page_user_details),
3000 (create_page_incoming), (create_page_outgoing),
3001 (modest_account_settings_dialog_init):
3002 * src/maemo/modest-connection-specific-smtp-window.c:
3003 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3005 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3007 * src/maemo/easysetup/modest-easysetup-wizard.c:
3008 (create_page_account_details), (create_page_custom_outgoing),
3009 (create_page_complete_custom):
3010 * src/maemo/modest-account-settings-dialog.c:
3011 (create_page_user_details), (create_page_incoming),
3012 (create_page_outgoing):
3013 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3014 (modest_connection_specific_smtp_edit_window_init):
3015 Use the correct (UI spec) port min/max, and use horizontal separators,
3018 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3020 * src/maemo/easysetup/modest-easysetup-wizard.c:
3021 (set_default_custom_servernames):
3022 * src/maemo/modest-account-settings-dialog.c:
3023 (create_page_incoming), (on_combo_outgoing_security_changed),
3024 (on_combo_incoming_security_changed), (create_page_outgoing),
3025 (modest_account_settings_dialog_set_account_name),
3026 (save_configuration):
3027 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3028 (on_combo_security_changed),
3029 (modest_connection_specific_smtp_edit_window_init),
3030 (modest_connection_specific_smtp_edit_window_set_connection),
3031 (modest_connection_specific_smtp_edit_window_get_settings):
3032 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3035 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3038 * src/maemo/easysetup/modest-easysetup-wizard.c:
3039 (create_page_custom_outgoing), (create_page_complete_custom):
3040 * src/maemo/modest-account-settings-dialog.c:
3041 (create_page_user_details), (create_page_outgoing):
3042 * src/maemo/modest-account-view-window.c: (button_box_new):
3043 Use changed logical IDs as per the most recent UI spec:
3044 mcen_bd_emailsetup_edit -> mcen_bd_edit
3045 mcen_bd_emailsetup_delete -> mcen_bd_delete
3046 mcen_bd_emailsetup_close -> mcen_bd_close
3048 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3052 * src/dbus_api/Makefile.am:
3053 * src/dbus_api/modest-dbus-callbacks.c:
3054 * src/dbus_api/modest-dbus-callbacks.h:
3055 * src/maemo/modest-platform.c: (modest_platform_init):
3056 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3058 * tests/Makefile.am:
3059 * tests/dbus_api/Makefile.am:
3060 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3062 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3064 * src/maemo/modest-account-settings-dialog.c:
3065 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3066 Removed unnecessary includes.
3068 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3070 * src/maemo/easysetup/modest-easysetup-wizard.c:
3071 * src/maemo/modest-account-settings-dialog.c:
3072 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3073 * src/widgets/Makefile.am:
3074 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3075 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3076 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3077 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3078 * src/widgets/modest-secureauth-combo-box.c:
3079 * src/widgets/modest-secureauth-combo-box.h:
3080 * src/widgets/modest-serversecurity-combo-box.c:
3081 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3082 made the GObject names more consistent with the rest of the Modest code.
3084 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3086 * src/maemo/easysetup/Makefile.am:
3087 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3088 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3089 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3090 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3091 * src/maemo/easysetup/modest-easysetup-wizard.c:
3092 * src/maemo/easysetup/modest-validating-entry.c:
3093 * src/maemo/easysetup/modest-validating-entry.h:
3094 * src/maemo/modest-account-settings-dialog.c:
3095 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3096 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3097 widgets/ because they are used outside of easysetup too. After checking in,
3098 svn will allow me to rename them too.
3100 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3102 * src/gnome/modest-msg-edit-window.c:
3103 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3104 linker error, to fix the build on the GNOME platform.
3105 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3106 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3107 ifdefed out to avoid a warning.
3109 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3111 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3112 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3113 some alternative for GTK+ 2.6.
3115 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3117 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3119 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3120 specified for EmailAccountsDialog in UI spec.
3122 * src/maemo/easysetup/modest-easysetup-wizard.c:
3123 * src/maemo/easysetup/modest-easysetup-wizard.h:
3124 * src/maemo/modest-account-settings-dialog.c:
3125 * src/maemo/modest-account-settings-dialog.h:
3126 Reuse a member window widget for the connection-specific SMTP server accounts,
3127 so we can tell it to create/save the accounts only if we actually save changes.
3129 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3130 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3131 (modest_connection_specific_smtp_edit_window_get_settings):
3132 Return a struct instance for temporarily remembering the entered data.
3134 * src/maemo/modest-connection-specific-smtp-window.h:
3135 * src/maemo/modest-connection-specific-smtp-window.c:
3136 (modest_connection_specific_smtp_window_finalize),
3137 (modest_connection_specific_smtp_window_fill_with_connections),
3139 (modest_connection_specific_smtp_window_save_server_accounts),
3140 (update_model_server_names): Do not actually save data until asked,
3141 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3143 (on_selection_changed),
3144 (modest_connection_specific_smtp_window_init): Disable the edit
3145 button when nothing is selected.
3147 * src/modest-account-mgr-helpers.c:
3148 * src/modest-account-mgr-helpers.h:
3149 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3152 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3154 * src/modest-account-mgr-helpers.h:
3155 * src/modest-account-mgr-helpers.c:
3156 (modest_account_mgr_get_unused_account_name),
3157 (modest_account_mgr_get_unused_account_display_name): Added these
3158 utility functions, to avoid code duplication.
3160 * src/maemo/easysetup/modest-easysetup-wizard.c:
3161 (create_page_account_details), (create_account):
3162 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3163 (on_combo_security_changed),
3164 (modest_connection_specific_smtp_edit_window_init),
3165 (modest_connection_specific_smtp_edit_window_save_settings):
3166 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3167 * src/maemo/modest-connection-specific-smtp-window.c:
3168 (modest_connection_specific_smtp_window_finalize),
3169 (modest_connection_specific_smtp_window_fill_with_connections),
3170 (on_button_edit), (modest_connection_specific_smtp_window_init):
3171 * src/maemo/modest-connection-specific-smtp-window.h:
3172 Implementing saving of connection-specific server accounts.
3174 But I need to refactor this so we can save the data for each
3175 possible connection-specific account and only actually create the server accounts
3176 when the easysetup finished, or the OK button is pressed on the account settings
3179 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3181 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3182 (on_combo_security_changed):
3183 (modest_connection_specific_smtp_edit_window_init):
3184 Auto-fill the port number as in the account settings.
3186 (modest_connection_specific_smtp_edit_window_set_connection):
3187 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3188 * src/maemo/modest-connection-specific-smtp-window.c:
3189 (fill_with_connections), (on_button_edit),
3190 (modest_connection_specific_smtp_window_init):
3191 Turn the edit window into a dialog to simplify the code, and
3192 set a WM hint as in a GtkDialog, because only a popup can be on top of
3193 another window in Maemo, and popups usually have no WM decoration.
3195 * src/modest-defs.h:
3196 * src/modest-account-mgr-helpers.c:
3197 (modest_account_mgr_set_connection_specific_smtp),
3198 (modest_account_mgr_remove_connection_specific_smtp),
3199 (modest_account_mgr_get_connection_specific_smtp):
3200 * src/modest-account-mgr-helpers.h: Some functions to write the
3201 connection-specific SMTP server information. Not yet used.
3204 * src/widgets/modest-folder-view.c: (text_cell_data):
3205 Fix a warning about an uninitialized variable.
3206 (on_configuration_key_changed): Put an #ifdef around the use
3207 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3209 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3211 * src/maemo/modest-account-settings-dialog.h:
3212 * src/maemo/modest-account-settings-dialog.c:
3213 Added connect_for_modified() utility function to mark the new modified boolean.
3215 (create_page_account_details), (create_page_user_details),
3216 (create_page_incoming), (create_page_outgoing), (on_response),
3217 (modest_account_settings_dialog_init),
3218 (modest_account_settings_dialog_set_account_name):
3219 Only warn about unsaved changes when there are actually unsaved changes.
3221 * src/modest-account-mgr-helpers.c:
3222 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3223 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3224 to get the data from there in future.
3226 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3228 * src/modest-defs.h:
3230 * src/modest-account-mgr-helpers.h:
3231 * src/modest-account-mgr-helpers.c:
3232 Store the security account setting in a single conf key instead of using
3233 the options list, so that the list is left for just the to-be-removed camel hack,
3234 and because gconf_client_set_list() is failing for some reason.
3236 * src/modest-account-mgr.c:
3237 (modest_account_mgr_add_server_account):
3238 * src/maemo/modest-account-settings-dialog.c:
3239 (modest_account_settings_dialog_set_account_name),
3240 (save_configuration): Use the renamed functions.
3243 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3245 * src/widgets/Makefile.am:
3246 * src/widgets/modest-limit-retrieve-combo-box.c:
3247 * src/widgets/modest-limit-retrieve-combo-box.h:
3248 * src/widgets/modest-retrieve-combo-box.c:
3249 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3250 the account settings dialog.
3252 * src/modest-defs.h:
3253 * src/modest-account-mgr-helpers.h:
3254 * src/modest-account-mgr-helpers.c:
3255 (modest_server_account_get_option_secure_auth),
3256 (modest_server_account_set_option_secure_auth):
3257 * src/modest-account-mgr.c:
3258 (modest_account_mgr_add_server_account):
3259 Use the existing AUTH_MECH conf key for the secure-auth setting,
3260 instead of putting it in the list options, because this was actually used already.
3262 * src/maemo/modest-account-settings-dialog.c:
3263 (create_page_account_details),
3264 (modest_account_settings_dialog_set_account_name),
3265 (save_configuration):
3266 * src/maemo/modest-account-settings-dialog.h:
3267 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3268 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3270 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3272 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3273 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3274 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3276 * src/modest-defs.h:
3277 * src/maemo/modest-account-settings-dialog.c:
3278 (create_page_incoming), (on_combo_outgoing_security_changed),
3279 (on_combo_incoming_security_changed), (create_page_outgoing),
3280 (modest_account_settings_dialog_set_account_name),
3281 (save_configuration): Load/Save the port number, and change it when the
3282 security combo changes, to suitable defaults.
3284 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3286 * src/modest-account-mgr.c:
3287 (modest_account_mgr_add_server_account): Set the security and secure-auth
3288 options, and add a comment saying that the other camel-specific options should be
3291 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3295 * src/modest-tny-account-store.c: (account_list_free),
3296 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3297 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3300 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3302 * src/modest-protocol-info.c:
3303 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3304 is required by our UI spec. Maybe something in our implementation will use this eventually.
3305 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3306 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3307 instead of the previous 0 placeholder.
3309 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3310 secure-auth settings.
3311 * src/modest-account-mgr-helpers.h:
3312 * src/modest-account-mgr-helpers.c:
3313 (modest_server_account_data_get_option_secure_auth),
3314 (modest_server_account_set_option_secure_auth),
3315 (modest_server_account_data_get_option_security),
3316 (modest_server_account_set_option_security): Added this API for getting and setting the security
3317 and secure-auth settings.
3319 * src/maemo/modest-account-settings-dialog.h:
3320 * src/maemo/modest-account-settings-dialog.c:
3321 (modest_account_settings_dialog_finalize), (check_data),
3322 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3323 about changing titles.
3324 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3325 (save_configuration): Save the security and secure-auth settings.
3327 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3328 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3330 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3332 * src/modest-defs.h:
3333 * src/modest-account-mgr.c:
3334 (modest_account_mgr_add_server_account):
3335 Added and used defines for the options key and value pair strings,
3336 that are used so far, though they do not seem to correspond to anything in our
3337 UI specs or ModestProtocol enum.
3339 * src/modest-account-mgr-helpers.h:
3340 * src/modest-account-mgr-helpers.c:
3341 (compare_option_strings_for_name),
3342 (modest_server_account_data_get_option_value),
3343 (modest_server_account_data_get_option_bool),
3344 (modest_account_mgr_get_server_account_option):
3345 Added helper functions for parsing the options GSList.
3347 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3349 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3350 display name is based on the supplied account name.
3351 * src/modest-account-mgr.c:
3352 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3353 with an inefficient, but good-enough, implementation.
3355 * src/maemo/easysetup/modest-easysetup-wizard.c:
3356 (create_page_account_details), (on_before_next), (create_account):
3357 Check for existing display names rather than (non-user-visible) account names, and just
3358 create and set a unique account name at the end.
3360 * src/maemo/modest-account-settings-dialog.c:
3361 (modest_account_settings_dialog_init),
3362 (modest_account_settings_dialog_set_account_name),
3363 (create_page_incoming): Show the display name, instead of the account name.
3364 (on_response): Do some (not all) extra checks, as in the UI spec.
3365 (save_configuration): Save the display name if it was changed.
3367 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3369 * po/en_GB.po: Added needed logical ID and translation.
3370 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3371 (init_view): Made the is-default column clicking work.
3373 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3376 * src/maemo/easysetup/Makefile.am:
3377 * src/maemo/easysetup/modest-easysetup-wizard.c:
3378 (modest_easysetup_wizard_dialog_init):
3379 * src/maemo/easysetup/provider-data-test.keyfile:
3380 * src/maemo/easysetup/provider-data.keyfile:
3381 Moved the provider data file to the new modest-providers-data package and used it from there.
3383 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-local-folder-info.c:
3386 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3387 N_() was already used on the static strings, but this just marks it for translation without
3388 using the translation.
3390 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3392 * src/maemo/modest-account-settings-dialog.c:
3393 (create_page_incoming),
3394 (modest_account_settings_dialog_set_account_name):
3395 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3396 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3397 I will do this if nobody else gets there first.
3399 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3401 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3402 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3403 save the security stuff.
3405 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3407 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3408 Set the email address and user fullname, which I now see must be
3411 * src/maemo/modest-account-settings-dialog.h:
3412 * src/maemo/modest-account-settings-dialog.c:
3414 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3415 leave-on-server and authentication.
3416 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3419 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3422 * src/maemo/modest-account-settings-dialog.c:
3423 * src/maemo/modest-account-settings-dialog.h:
3424 Most (but not all) of the widgets are now present as specified by the UI spec.
3425 No changes are yet saved, and some details are not properly shown yet.
3427 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3429 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3431 * src/maemo/Makefile.am:
3432 * src/maemo/modest-account-settings-dialog.c:
3433 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3434 an existing account. Doesn't do much yet.
3436 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3437 Open the accounts settings dialog when Edit is clicked.
3439 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3441 * src/maemo/easysetup/Makefile.am:
3442 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3444 * src/maemo/easysetup/modest-easysetup-wizard.c:
3445 (modest_easysetup_wizard_dialog_init):
3446 Try to get the source directory from the build system,
3447 instead of hard-coding "./" into the source code, when opening our local
3448 copies of the configuration files.
3449 But this still fails when opening the wizard from the Accounts window,
3450 maybe because the working directory seems to change at runtime.
3451 So the wizard will fail the second time unless you copy the files into their
3452 proper locations - see the stdout warnings for the paths.
3454 (create_page_account_details),(on_before_next):
3455 Check for existing non-server accounts instead of server accounts,
3456 so the default account name is useful again, and to prevent trying to
3459 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3460 Show the wizard when New is clicked.
3462 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3463 (init_view): Show the column headers, and show the columns that are
3464 specified in the UI specs. However, something in Maemo's GTK+ prevents
3465 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3466 change the default account. This is despite unsetting the special properties.
3468 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3470 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3471 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3472 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3473 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3474 to make that clearer.
3475 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3477 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3479 * src/maemo/modest-account-view-window.c:
3480 (modest_account_view_window_init),
3481 (modest_account_view_window_new):
3482 Use the same buttons as specified in the
3483 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3484 the existing widgets, which never had a chance of working.
3485 Put the ModestAccountView treeview in a scrolled window.
3486 Do not repeat the initialization in both _init() and _new().
3488 * src/widgets/modest-account-view.c: (update_account_view):
3489 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3490 this widget and window shows no accounts.
3492 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3494 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3496 * src/maemo/easysetup/modest-easysetup-wizard.c:
3497 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3498 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3499 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3502 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3503 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3504 accounts exist yet, as in the UI spec.
3506 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3508 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3510 * src/maemo/Makefile.am:
3511 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3512 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3513 New window for editing connection-specific smtp details.
3514 Not fully implemented.
3516 * src/maemo/modest-connection-specific-smtp-window.c:
3517 (modest_connection_specific_smtp_window_finalize) :
3518 unref the tree model.
3519 (on_button_edit): Show the edit window.
3521 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3523 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3526 * src/maemo/Makefile.am:
3527 * src/maemo/modest-connection-specific-smtp-window.c:
3528 * src/maemo/modest-connection-specific-smtp-window.h:
3529 New window for showing the list of connections, for connection-specific
3530 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3531 * src/maemo/easysetup/modest-easysetup-wizard.c:
3532 (create_page_custom_outgoing): Show the new window when the button is clicked.
3534 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3536 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3537 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3538 * src/maemo/modest-msg-edit-window.c:
3539 (modest_msg_edit_window_insert_image):
3540 * src/modest-conf.c: (modest_conf_key_escape):
3541 * src/modest-mail-operation.c:
3542 (modest_mail_operation_send_new_mail):
3543 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3544 (modest_ui_actions_on_new_account):
3545 * src/widgets/modest-attachment-view.c: (update_filename_request):
3546 * src/widgets/modest-mail-header-view.c:
3547 Corrected warnings that were breaking the build, by commenting out unused variables,
3548 and a function, and by including a header.
3550 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3552 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3553 so we can #ifdef around platform-specific code when necessary.
3554 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3555 to allow this to build for the GNOME platform too.
3557 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3559 * src/maemo/easysetup/modest-easysetup-wizard.c:
3560 Added util_increment_name() and used it in create_page_account_details()
3561 to make sure that the default account name is always a new name.
3563 (modest_easysetup_wizard_dialog_init),
3564 (set_default_custom_servernames): Some minor memory management fixes.
3566 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3570 * src/modest-runtime.c: (init_i18n): Restored the translation
3571 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3572 are defined in config.h, and the translations are installed.
3574 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3575 is defined for translation.
3577 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3579 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3581 * src/maemo/easysetup/modest-easysetup-wizard.c:
3582 (modest_easysetup_wizard_dialog_init):
3583 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3584 Use realistic paths (though they should use $prefix generically) to the
3585 mcc_mapping and provider-data.keyfile files which might work when they
3586 are installed by the future version of the operator-wizard package,
3587 and then fallback to paths in our source code, with an explanatory
3590 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3594 * src/maemo/Makefile.am:
3595 * src/maemo/easysetup/: Added files from the previously-exernal
3596 osso-modest-easysetup.
3597 * src/maemo/modest-main-window-ui.h:
3598 * src/modest-ui-actions.c:
3599 * src/modest-ui-actions.h:
3600 Added modest_ui_actions_on_new_account() as a signal handler for the
3601 New Account menu item. It shows the easysetup wizard.
3602 * po/en_GB.po: Added additional needed logical IDs and translations.