1 2007-06-14 Armin Burgmeier <armin@openismus.com>
3 * src/widgets/modest-attachments-view.h:
4 * src/widgets/modest-attachments-view.c: Added
5 modest_attachments_view_has_attachments() and fixed coordinate
6 transformation in get_att_view_at_coords(). This fixes attachment
9 * src/widgets/modest-msg-view.c: Make use of
10 modest_attachments_view_has_attachments() to decide whether to show
11 attachments in the header.
13 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
15 * src/maemo/modest-connection-specific-smtp-edit-window.c:
16 (on_change), (on_combo_security_changed),
17 (modest_connection_specific_smtp_edit_window_init),
18 (modest_connection_specific_smtp_edit_window_set_connection),
19 (modest_connection_specific_smtp_edit_window_is_dirty):
20 * src/maemo/modest-connection-specific-smtp-edit-window.h:
21 * src/maemo/modest-connection-specific-smtp-window.c:
24 Show an comfirmation dialog for the smpt-edit-window if there are
25 unsaved changes and the user hits cancel.
26 (projects.maemo.org but NB#60479
28 2007-06-14 Armin Burgmeier <armin@openismus.com>
30 * src/maemo/easysetup/modest-easysetup-wizard.c:
31 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
32 address" info in banner instead of node, and select all the text as
33 per UI spec. This fixes projects.maemo.org bug NB#60550.
35 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
37 reviewed by: <delete if not using a buddy>
39 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
40 * src/modest-ui-actions.c: (folder_refreshed_cb):
42 2007-06-14 Murray Cumming <murrayc@murrayc.com>
44 * src/widgets/modest-folder-view.c: (filter_row):
45 Explictly filter out the per-account outbox accounts. I don't know why
46 these only sometimes show up, but now they should never show up in the UI.
47 This should fix projects.maemo.org bug NB#60160.
49 2007-06-14 Murray Cumming <murrayc@murrayc.com>
51 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
52 when the toolbar does not exist yet.
53 * src/modest-widget-memory.c: (save_settings_header_view):
54 Added g_warnings() to help us to discover when we are trying to set
55 an empty columns list in gconf.
57 2007-06-14 Murray Cumming <murrayc@murrayc.com>
61 Added modest_init_get_default_header_view_column_ids().
63 * src/modest-widget-memory.c: (restore_settings_header_view):
64 Use the new function to get defaults, if the gconf key is empty,
65 instead of not creating any columns. This seems to fix the
66 empty right-hand pane problems.
68 * src/widgets/modest-header-view.h: Improved documentation.
70 2007-06-13 Murray Cumming <murrayc@murrayc.com>
72 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
73 Revert the use of the display name as the account name, because this
74 is generally wrong and would break the code that follows.
76 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
78 * src/maemo/easysetup/modest-easysetup-wizard.c:
79 (check_for_supported_auth_methods), (on_before_next),
82 More correct fix for projects.maemo.org bug NB# 58991
83 Do not longer accept AUTH_PASSWORD as secure method and choose
84 correct method when creating the account.
86 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
88 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
89 Fixed projects.maemo.org bug NB# 58991
91 2007-06-13 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-init.c: (modest_init_init_core),
94 (modest_init_local_folders): Fixed compilation errors.
96 2007-06-13 Murray Cumming <murrayc@murrayc.com>
98 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
99 Remove unnecessary lib/include, though it is good in principle when needed.
101 * src/modest-init.c: (modest_init_one_local_folder),
102 (modest_init_local_folders):
103 * src/modest-init.h: Initialize the .modest library for memory cards,
104 instead of just doing nothing for them. This should allow us to create
105 folders there, fixing projects.maemo.org bug NB#59297.
107 2007-06-13 Murray Cumming <murrayc@murrayc.com>
109 * libmodest-dbus-client/libmodest-dbus-client.c:
110 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
111 (libmodest_dbus_client_compose_mail),
112 (libmodest_dbus_client_open_message),
113 (libmodest_dbus_client_send_and_receive),
114 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
116 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
117 (on_idle_open_message), (modest_dbus_req_handler),
118 (search_result_to_message), (modest_dbus_req_filter):
119 * src/modest-search.c: (add_hit), (modest_search_folder),
120 (modest_search_all_accounts): Improved debug messages.
122 * tests/dbus_api/test_open_message.c: (main): Improved comments.
124 * src/modest-tny-account-store.c:
125 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
128 2007-06-13 Murray Cumming <murrayc@murrayc.com>
131 2007-06-12 Murray Cumming <murrayc@murrayc.com>
133 * src/modest-tny-account-store.c: (get_server_accounts):
134 Call modest_tny_local_folders_account_add_merged_outbox_folders()
135 even when there are no accounts, so that the Outbox folder is always
136 visible. This fixes projects.maemo.org bug NB#60158.
138 2007-06-12 Murray Cumming <murrayc@murrayc.com>
140 * src/maemo/modest-main-window.c: (create_details_widget):
141 Use the mcen_va_never logical ID.
143 2007-06-12 Murray Cumming <murrayc@murrayc.com>
145 * src/dbus_api/modest-dbus-api.h:
146 * src/dbus_api/modest-dbus-callbacks.c:
147 (on_idle_open_default_inbox), (on_open_default_inbox),
148 (modest_dbus_req_handler):
149 Added a new OpenDefaultInbox method.
151 * libmodest-dbus-client/libmodest-dbus-client.h:
152 * libmodest-dbus-client/libmodest-dbus-client.c:
153 Added libmodest_dbus_client_open_default_inbox() to call the new
154 dbus method. This should be useful to projects.maemo.org bug NB#57214,
155 though it should maybe be used by a new osso-email-interface function.
157 * tests/dbus_api/Makefile.am:
158 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
161 2007-06-12 Murray Cumming <murrayc@murrayc.com>
163 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
164 NULL, so that the signals get all the keys. This should not actually
165 change any behaviour because we currently update everything when anything
168 2007-06-12 Murray Cumming <murrayc@murrayc.com>
170 * src/widgets/modest-folder-view.c: (text_cell_data),
171 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
172 (find_inbox_iter): If tinymail tells us that the folder is
173 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
174 This causes the inbox to be selected at startup, fixing part of
175 projects.maemo.org bug NB#56305.
177 * src/modest-ui-dimming-rules.c:
178 (modest_ui_dimming_rules_on_tools_smtp_servers):
179 * src/modest-ui-dimming-rules.h: Added a callback function to dim
180 the SMTP servers menu item.
181 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
182 that the SMTP Servers menu item is dimmed when there are no accounts,
183 as a future version of the UI spec will require. This fixes
184 projects.maemo.org bug NB#56305.
186 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
188 * src/maemo/modest-maemo-utils.c:
189 (modest_maemo_utils_get_supported_secure_authentication_methods):
190 Added label to dialog instead of unreadable title
192 * src/maemo/modest-main-window.c: (sync_accounts_cb),
193 (modest_main_window_new):
194 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
197 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
198 * src/modest-account-mgr.h:
199 Added method to avoid code duplication
201 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
202 (modest_ui_actions_on_send_receive):
203 Use modest_account_mgr_has_accounts
205 2007-06-11 Murray Cumming <murrayc@murrayc.com>
207 * src/maemo/easysetup/modest-presets.c:
208 (modest_presets_get_info_server_security): Do not report secure auth
210 * src/modest-protocol-info.c: Use the defines for the gconf key names
211 for secure authentication. This was not working because we were writing
212 Password and reading password, and the check was case sensitive.
213 With this, gmail now works for receiving and sending when created via
216 2007-06-11 Murray Cumming <murrayc@murrayc.com>
218 * src/maemo/easysetup/modest-presets.c:
219 (modest_presets_get_info_server_security): Correct the key name for
220 SecureSmtp, because it seems to be case-sensitive.
221 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
222 Do not try to get the 0th notebook page if there are 0 pages, to
225 2007-06-11 Murray Cumming <murrayc@murrayc.com>
227 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
228 Prevent use of the new notification feature for now, because it currently
229 shows one dialog for each new email, which is annoying.
231 2007-06-11 Murray Cumming <murrayc@murrayc.com>
233 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
234 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
235 when no country was selected, so that we show the global ones.
236 * src/maemo/easysetup/modest-presets.c:
237 (modest_presets_get_providers): Return only the global providers, not
238 all providers when mmc=0 was requested.
240 2007-06-11 Murray Cumming <murrayc@murrayc.com>
242 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
243 (easysetup_provider_combo_box_fill): Remove debug code that showed the
244 provider ID in the combo.
246 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
247 Do not show the page numbers, because it would be confusing when we add
248 the 2 extra pages for the custom setup, when the user chooses the "Other"
249 provider. This fixes projects.maemo.org bug NB#59028
251 * src/modest-init.c: (modest_init_init_core),
252 (modest_init_local_folders):
254 * src/modest-tny-account.c:
255 (modest_tny_account_new_for_local_folders): Do not create default folders
256 for the memory card. This should fix projects.maemo.org bug NB#59328.
258 2007-06-11 Murray Cumming <murrayc@murrayc.com>
260 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
261 Free the changed_conf_keys string items. They are already freed in the
262 idle handler if that runs first.
264 2007-06-11 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-ui-actions.c:
267 (modest_ui_actions_on_password_requested): Check that the server name
268 is not NULL, because I just saw a password dialog with (null) as the
271 * src/modest-tny-folder.[h|c]: Added
272 modest_tny_folder_is_memory_card_folder().
273 * src/modest-ui-dimming-rules.c:
274 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
275 menu item for memory cards, as per the UI spec (section 7.4). This should
276 fix projects.maemo.org bug NB#59297.
278 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
280 * src/maemo/modest-main-window.c: (sync_accounts_cb):
281 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
282 is another problem with the code, see Murray's comment at line 772)
284 2007-06-08 Murray Cumming <murrayc@murrayc.com>
286 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
287 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
288 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
289 (load_from_file), (easysetup_country_combo_box_init),
290 (easysetup_country_combo_box_get_active_country_ids),
291 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
292 instead of just one ID, to avoid duplicate country names in the UI.
294 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
295 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
296 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
297 a single ID, avoiding duplicate providers.
298 * src/maemo/easysetup/modest-easysetup-wizard.c:
299 (on_combo_account_country): Adapt to use a list.
301 2007-06-08 Murray Cumming <murrayc@murrayc.com>
303 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
304 keys changed in the last X seconds.
306 * src/modest-account-mgr.h:
307 * src/modest-account-mgr.c: (on_timeout_notify_changes),
308 (on_key_change), (modest_account_mgr_class_init),
309 (modest_account_mgr_init), (modest_account_mgr_finalize):
310 As the keys are changed, save them in a GSList* and signal that GSList*
311 further every X seconds, to batch changes, to allow us to do just one
312 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
313 bug NB#56941 and other (UI-blocking) delays when changing account settings.
315 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
316 changed signal signature.
318 * src/modest-conf.c: (modest_conf_set_list),
319 (modest_conf_on_change): Reenable notification.
321 (modest_conf_maemo_fake_on_change): Comment out the hack that
322 notified immediately instead of asynchronously.
324 * src/widgets/modest-account-view.h:
325 * src/widgets/modest-account-view.c:
326 (update_account_view): Select the previously-selected account ID,
327 if possible. This fixes projects.maemo.org bug NB#56933.
329 (on_account_changed), (on_account_removed),
330 (modest_account_view_select_account):
332 Remove the block/unblock functions
333 because they were not useful.
335 * src/maemo/modest-account-view-window.c:
336 (on_delete_button_clicked), (on_edit_button_clicked),
337 (on_new_button_clicked): Remove the use of the non-working block/unblock.
339 2007-06-08 Murray Cumming <murrayc@murrayc.com>
341 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
342 Improve the error dialog to show Incorrect Account Settings, which seems
343 clearer, and say that the internal error message (to be removed from the
344 dialog later) is often misleading.
345 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
347 * src/modest-tny-account.c:
348 (modest_tny_account_new_from_server_account): Uncomment the printf of the
349 URL because this is so useful for debugging on the device.
351 * src/widgets/modest-serversecurity-combo-box.c:
352 (modest_serversecurity_combo_box_fill): Correct a logical ID.
354 2007-06-08 Murray Cumming <murrayc@murrayc.com>
356 * src/modest-mail-operation.c:
357 (modest_mail_operation_send_new_mail):
358 Added a comment about a nasty but apparently harmless message. Details
359 added to the wiki g_warnings() page.
361 2007-06-08 Murray Cumming <murrayc@murrayc.com>
363 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
364 (modest_tny_send_queue_class_init):
365 Do not use the priv struct because it is empty, to avoid g_warnings
366 about a non-existant priv struct.
368 * src/modest-tny-account-store.c:
369 (modest_tny_account_store_get_server_account),
370 (modest_tny_account_store_get_transport_account_for_open_connection
371 ): Do not try to get transport server accounts for local folders,
372 because they don't have any. This avoids a g_warning().
374 * src/maemo/modest-main-window.c:
375 (modest_main_window_notify_send_receive_initied),
376 (on_configuration_key_changed):
377 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
379 * src/modest-mail-operation.c:
380 (modest_mail_operation_update_account):
381 * src/modest-tny-account-store.h:
382 * src/modest-tny-account.c:
383 (modest_tny_account_get_special_folder),
384 (modest_tny_account_new_for_local_folders),
385 (modest_tny_account_new_for_per_account_local_outbox_folder):
386 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
387 * src/modest-tny-local-folders-account.c:
388 (add_account_folders_to_merged_folder):
389 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
390 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
391 (modest_ui_actions_on_send):
392 * src/widgets/modest-folder-view.c: (update_model):
393 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
394 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
395 modest_tny_account_store_get_tny_account_by_account() to
396 modest_tny_account_store_get_server_account() to make the code clearer.
398 2007-06-07 Marcus Bauer <marcusb@openismus.com>
400 * src/dbus_api/modest-dbus-api.h:
401 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
402 * src/maemo/modest-msg-edit-window.c:
403 (modest_msg_edit_window_attach_file_noninteractive):
404 added g_warning in case the file to be attached does not exist
405 * tests/dbus_api/test_compose_mail.c: (main):
406 removed obsolete comment, added generic files as test case
408 2007-06-07 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-tny-account-store.c: (get_server_accounts):
411 Create the local folders account only once, not once for each outbox, and
412 not only when there are some outboxes.
414 2007-06-07 Murray Cumming <murrayc@murrayc.com>
416 * src/widgets/modest-folder-view.c: (update_model): Comment out some
417 code that is causing a crash at startup. Sergio says that he is fixing this.
419 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
421 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
422 * src/maemo/modest-account-settings-dialog.c:
423 (create_page_outgoing),
424 (modest_account_settings_dialog_set_account_name),
425 (save_configuration):
426 - Fixed handling of the "Use secure authentication" toggle to comply with
427 the ui specification. See also projects.maemo.org bug NB#58400
429 - Restore the Secure connection setting combo correctly when loading
432 * src/maemo/modest-maemo-utils.c:
433 (on_camel_account_get_supported_secure_authentication),
434 (modest_maemo_utils_get_supported_secure_authentication_methods):
435 Fixed a crasher if operation is canceled
437 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
438 (modest_protocol_info_auth_is_secure):
439 * src/modest-protocol-info.h:
441 Added two new methods to determine if a protocol/auth method is secure/encrypted in
442 the sense of the "Use secure authentication" toggle.
444 2007-06-07 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-tny-account-store.h:
447 * src/modest-tny-account-store.c:
448 Added modest_tny_account_store_get_local_folders_account().
450 * src/modest-tny-folder.h:
451 * src/modest-tny-folder.c:
452 (modest_tny_folder_get_account):
453 Added this replacement for tny_folder_get_account() which returns
454 the local-folders account for TnyMergeFolders, to avoid the
455 warning about the unimplemented get_account_func() vfunc().
457 (modest_tny_folder_get_rules),
458 * src/modest-ui-actions.c:
459 (modest_ui_actions_on_folder_selection_changed):
460 * src/modest-mail-operation.c:
461 (modest_mail_operation_remove_folder),
462 (modest_mail_operation_xfer_folder),
463 (modest_mail_operation_rename_folder),
464 (modest_mail_operation_get_msg),
465 (modest_mail_operation_get_msgs_full),
466 (modest_mail_operation_remove_msg),
467 (modest_mail_operation_xfer_msgs),
468 (modest_mail_operation_refresh_folder):
469 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
471 2007-06-07 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
474 (modest_server_account_set_security):
475 * src/modest-defs.h: Add comments explaining that our
476 UI spec means TLS when it says Normal, so these do not look like errors.
478 * src/modest-tny-account.c:
479 (modest_tny_account_new_from_server_account): Use the new tinymail
480 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
481 for TLS. This should fix projects.maemo.org bug NB#58460.
483 2007-06-06 Murray Cumming <murrayc@murrayc.com>
485 * src/maemo/easysetup/modest-easysetup-wizard.c:
486 (create_account): Correct the position of the gconf sanity check warning.
487 (on_button_edit_advanced_settings): Show the dialog immediately, instead
488 of using the g_idle_add() hack, because this does not seem to be necessary
489 on osso 1.1. It might even work on Maemo Bora if the problems were actually
490 caused by something other than maemo's gconf.
491 This fixes projects.maemo.org bug #59022.
493 2007-06-06 Murray Cumming <murrayc@murrayc.com>
495 * src/modest-account-mgr-helpers.c:
496 (modest_account_mgr_get_default_account): Do not check that the account
497 exists if there is no default account (NULL), to fix a runtime warning.
499 2007-06-06 Murray Cumming <murrayc@murrayc.com>
501 * src/widgets/modest-folder-view.c: (update_model):
502 Do not unref the treemodel before we have finished with it.
503 This prevents a valgrind warning and an occasional crash at startup.
505 2007-06-06 Marcus Bauer <marcusb@openismus.com>
507 * libmodest-dbus-client/libmodest-dbus-client.h:
508 added libmodest_dbus_client_compose_mail()
509 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
511 added functions needed for SendAsMail() functionality
512 * src/maemo/modest-msg-edit-window.c:
513 (modest_msg_edit_window_attach_file_noninteractive):
514 non interactively attaching files to message edit window
515 * src/widgets/modest-msg-edit-window.h:
516 * tests/dbus_api/Makefile.am:
517 added test_compose_mail.c
518 * tests/dbus_api/test_compose_mail.c: (main):
520 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
522 * src/modest-account-view.c:
523 Fixed bug projects.maemo.org bug NB#59307
525 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
527 * src/maemo/easysetup/modest-easysetup-wizard.c:
528 (get_serverport_incoming), (on_before_next), (create_account):
529 * src/maemo/modest-account-settings-dialog.c:
530 (modest_account_settings_dialog_set_account_name):
531 * src/maemo/modest-maemo-utils.c:
532 (on_camel_account_get_supported_secure_authentication_status),
533 (on_camel_account_get_supported_secure_authentication),
534 (on_secure_auth_cancel),
535 (modest_maemo_utils_get_supported_secure_authentication_methods):
537 Implemented security authentication for settings and easysetup.
539 2007-06-05 Murray Cumming <murrayc@murrayc.com>
541 * src/maemo/modest-main-window.c: (create_details_widget):
542 Show the total size for memory card accounts too, instead of showing
543 the name again. Fixes bug projects.maemo.org bug NB#59307.
545 2007-06-05 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-tny-simple-folder-store.c:
549 * src/modest-tny-simple-folder-store.h: Removed.
551 * src/modest-tny-local-folders-account.h
552 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
553 for the local-folders maildir, with an extra TnyMergedFolder containing
554 the folders of the per-account outbox store accounts.
555 * src/modest-tny-account-store.c: (get_server_accounts):
556 Add the outboxes to the special local folders account after creating it.
558 * src/modest-tny-account.c:
559 (modest_tny_account_new_for_local_folders): Create the derived
560 account when creating the main local-folders account.
562 * src/maemo/modest-main-window.c: (create_details_widget),
563 (modest_main_window_set_contents_style):
564 Adapted to the use of the derived account instead of the folder store.
566 * src/modest-ui-actions.c:
567 (modest_ui_actions_on_folder_selection_changed):
568 * src/modest-ui-dimming-rules.c:
569 (modest_ui_dimming_rules_on_new_folder):
570 * src/widgets/modest-folder-view.c: (text_cell_data),
571 (icon_cell_data), (filter_row), (update_model),
572 (get_cmp_rows_type_pos):
575 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
576 Do not get the priv struct, because no priv struct has been set,
577 to avoid a runtime warning.
579 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
580 #ifelse with #else, to fix a warning, to fix the build.
583 2007-06-05 Christian Kellner <ckellner@openismus.com>
585 * libmodest-dbus-client/libmodest-dbus-client.c:
586 Fix small typo in doc (why do you always see them
587 AFTER committing stuff?)
590 2007-06-05 Christian Kellner <ckellner@openismus.com>
592 * libmodest-dbus-client/libmodest-dbus-client.c:
593 (libmodest_dbus_client_search):
594 Initialize hit list with NULL. Also set folder list
595 to "" if NULL was supplied.
598 2007-06-03 Christian Kellner <ckellner@openismus.com>
600 * libmodest-dbus-client/libmodest-dbus-client.c:
601 (modest_search_hit_list_free):
602 Make it save to call it with NULL.
604 * src/dbus_api/modest-dbus-callbacks.c:
605 * src/modest-search.c:
606 Return full ModestSearchHits as the search result list not TnyHeader
607 since can't be around withouth the correspoding TnyFolder.
609 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
611 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
612 Added currently commented code to check for secure auth
614 * src/maemo/modest-account-settings-dialog.c: (on_response),
615 (save_configuration), (show_ok):
616 Fixed projects.maemo.org bugs NB #59248 and #59251
618 * src/maemo/modest-maemo-utils.c:
619 (on_camel_account_get_supported_secure_authentication_status),
620 (on_camel_account_get_supported_secure_authentication),
621 (modest_maemo_utils_get_supported_secure_authentication_methods):
622 * src/maemo/modest-maemo-utils.h:
623 Moved get_supported_secure_authentication() method here to be able
624 to use it from easysetup wizard.
626 * src/modest-pair.c: (on_pair_compare_as_string):
627 Should compare string with first part of pair and not
628 strcmp pairs which will crash.
630 * src/modest-protocol-info.c:
631 (modest_protocol_info_protocol_is_store):
632 * src/modest-protocol-info.h:
633 Added modest_protocol_info_get_auth_protocol_name()
635 2007-06-03 Armin Burgmeier <armin@openismus.com>
637 * src/modest-mail-operation.c:
638 (modest_mail_operation_get_msgs_full): Set priv->account also when
639 only retrieving a single message. This avoids a crash when canceling
642 (modest_mail_operation_notify_end): Do not explicitely remove the
643 operation from the queue but only emit the progress_changed signal.
644 The queue itself listens to that signal to remove the operation when
645 it is finished. This reduces coupling and removes a potential deadlock
646 when modest_mail_operation_notify_end() is called from the queue
647 itself. If that is a problem performance-wise, I would suggest to
648 implement a status-changed signal or something.
650 * src/modest-mail-operation-queue.c: Make sure to never call a
651 function from another file while the queue is locked. This (hopefully)
652 fixes another deadlock when exiting the application while retrieving
655 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
657 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
658 Fixed build if libogs is not available
660 2007-06-03 Christian Kellner <ckellner@openismus.com>
662 * libmodest-dbus-client/libmodest-dbus-client.h:
663 * libmodest-dbus-client/libmodest-dbus-client.c:
664 (libmodest_dbus_client_delete_message):
665 Implement deletion of messages (Client side).
667 (modest_search_hit_free),
668 (modest_search_hit_list_free):
669 Utility functions to free the result hits.
671 * src/dbus_api/modest-dbus-api.h:
672 * src/dbus_api/modest-dbus-callbacks.c:
674 (modest_dbus_req_handler):
675 Implement deletion of messages (Server side).
677 * tests/dbus_api/test_search.c: (main):
680 * tests/dbus_api/Makefile.am:
681 * tests/dbus_api/test_delete_message:
682 Add little test for the message deletion logic
684 2007-06-03 Armin Burgmeier <armin@openismus.com>
686 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
687 when the operation queue was not empty. projects.maemo.org bug
690 2007-06-03 Armin Burgmeier <armin@openismus.com>
692 * src/widgets/modest-account-view.c
693 (on_account_default_toggled): Toggle default account column
694 explicitely instead of waiting for gconf notification (which is
695 currently ignored). This should fix projects.maemo.org bug NB#56910
696 for now. It should probably be removed when gconf notifications are
699 2007-06-03 Christian Kellner <ckellner@openismus.com>
701 * libmodest-dbus-client/libmodest-dbus-client.c:
702 Removed debugging spew.
704 * src/dbus_api/modest-dbus-callbacks.c:
705 Added debugging info.
707 * src/modest-search.c:
708 (modest_search_all_accounts):
709 Use tny_account_store_get_accounts () on the account store
710 to get all accounts which is the way to get all accounts.
712 * tests/dbus_api/test_search.c: (main):
713 Make it possible to supply the search term on the command line.
715 2007-06-03 Christian Kellner <ckellner@openismus.com>
717 * libmodest-dbus-client/libmodest-dbus-client.c:
718 * libmodest-dbus-client/libmodest-dbus-client.h:
719 Implement searching for mesages over raw dbus. (Client side)
721 * src/dbus_api/Makefile.am:
722 * src/dbus_api/modest-dbus-api.h:
723 * src/dbus_api/modest-dbus-callbacks.c:
724 * src/dbus_api/modest-dbus-callbacks.h:
725 Search framework (Server side). Also implement on_idle_open_message().
727 * src/maemo/modest-platform.c: (modest_platform_init):
728 Prepare for raw dbus/osso rpc interaction.
730 * src/modest-search.h:
731 Changed minsize from unspecific guint to guint32.
733 * src/modest-search.c:
735 Added strange hack which magically made tnymail work.
737 (modest_search_folder),
738 (modest_search_account),
739 (modest_search_all_accounts):
740 Implement helper functions to search all accounts, specific account
743 * tests/dbus_api/Makefile.am:
744 * tests/dbus_api/test_open_message.c:
745 Read url to open from commandline.
747 * tests/dbus_api/test_search.c:
748 Implement small test for dbus search stuff
750 2007-06-02 Armin Burgmeier <armin@openismus.com>
752 * src/maemo/modest-account-settings-dialog.c: Changed window title to
753 include account type and account title. This fixes projects.maemo.org
756 * src/maemo/modest-account-view-window.c: Set a title for the window.
758 2007-06-02 Armin Burgmeier <armin@openismus.com>
760 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
761 incoming and outgoing server name based on email address and server
762 types as long as the names have not been edited manually. This fixes
763 projects.maemo.org bug NB#58671.
765 2007-06-02 Armin Burgmeier <armin@openismus.com>
767 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
768 server type cannot be changed in future to the incoming details page
769 when creating an account. This fixes projects.maemo.org bug NB#59029.
771 2007-06-02 Armin Burgmeier <armin@openismus.com>
773 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
774 and assigned max width chars so that they wrap instead of being
775 truncated. Fixes projects.maemo.org bug NB#56126.
777 2007-06-02 Armin Burgmeier <armin@openismus.com>
779 * src/maemo/modest-connection-specific-smtp-window.c: Add an
780 introductory note to the connection specific smtp servers dialog, as
781 section 8.12 of the email UI specification requires. This fixes
782 projects.maemo.org bug NB#59212.
784 2007-06-01 Murray Cumming <murrayc@murrayc.com>
786 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
787 Check for running mail operations, and offer to cancel them, as per the UI
788 spec. This fixes projects.maemo.org bug NB#59041 .
789 However, I suspect that tinymail may still use the network connection
790 in ways that we cannot detect or cancel. But it should at least adapt to
793 2007-06-01 Murray Cumming <murrayc@murrayc.com>
795 * src/modest-tny-account-store.c: (recreate_all_accounts),
796 (get_cached_accounts), (get_server_accounts): Do more sensible
797 ref-counting of the temporarily-cached outbox accounts list. This seems
798 to fix a crash when entering the password when the password was wrong.
800 2007-06-01 Murray Cumming <murrayc@murrayc.com>
802 * src/gnome/modest-main-window.c: (connect_signals):
803 * src/modest-tny-account-store.c: (get_password),
804 (modest_tny_account_store_alert): Added comments and clues and
805 commented-out code about how we currently fail to deal with connection
806 errors and wrong passwords, and how we should.
808 2007-06-01 Murray Cumming <murrayc@murrayc.com>
810 * src/widgets/modest-retrieve-combo-box.c:
811 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
812 This fixes projects.maemo.org bug NB#58472 .
814 2007-06-01 Murray Cumming <murrayc@murrayc.com>
816 * src/maemo/easysetup/modest-easysetup-wizard.c:
817 (create_page_complete_easysetup):
818 (create_page_complete_custom): Correct the last commit,
819 putting the correct sentences in the correct pages.
821 2007-06-01 Murray Cumming <murrayc@murrayc.com>
823 * src/maemo/easysetup/modest-easysetup-wizard.c:
824 (create_page_complete_custom): Show the second sentence of text
825 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
828 2007-06-01 Murray Cumming <murrayc@murrayc.com>
830 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
831 Set the leave-on-server conf key by default. This fixes
832 projects.maemo.org bug NB#59258 .
834 2007-06-01 Murray Cumming <murrayc@murrayc.com>
836 * src/maemo/modest-account-view-window.c:
837 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
838 logical ID for the confirmation messages. Fixed projects.maemo.org bug
841 2007-06-01 Murray Cumming <murrayc@murrayc.com>
843 * src/maemo/easysetup/modest-easysetup-wizard.c:
844 (create_caption_new_with_asterisk):
845 * src/maemo/modest-account-settings-dialog.c:
846 (create_caption_new_with_asterisk):
847 Uncomment the code to add the asterisk, because they are no longer in the
848 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
849 (update_incoming_server_title): Add an asterisk here too.
851 2007-06-01 Murray Cumming <murrayc@murrayc.com>
853 * src/maemo/modest-maemo-global-settings-dialog.c:
854 (current_connection): Check that we are even connected before trying to
855 get the current connection name, to prevent a warning.
857 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
858 Change the comments because tny_maemo_conic_device_connect() is now meant to
860 * src/modest-mail-operation.c:
861 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
862 make sure we have a connection and fail if we can't connect.
864 2007-05-31 Murray Cumming <murrayc@murrayc.com>
866 * src/maemo/modest-main-window.c:
867 (on_account_store_connecting_finished): Do not try to get the
868 connection ID if we are not really connected. I am surprised that
869 this signal handler is called when we are not connected.
871 2007-05-31 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-error.h:
874 * src/modest-ui-actions.c:
875 (modest_ui_actions_get_msgs_full_error_handler):
876 Renamed an enum, added comments, added an enum
877 for retrieve-limit errors.
879 * src/modest-mail-operation.c: (foreach_add_item),
880 (internal_folder_observer_update), (update_account_thread),
881 (modest_mail_operation_get_msgs_full):
882 (modest_mail_operation_update_account),
883 Added comments about how this works, and some code that should
884 (but does not) check the retrieve-limit. See the TODO comment.
886 2007-05-31 Murray Cumming <murrayc@murrayc.com>
888 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
889 Initialize help_id to fix the build. Warnings are good.
891 2007-05-31 Murray Cumming <murrayc@murrayc.com>
893 * src/widgets/modest-hbox-cell-renderer.c:
894 (modest_hbox_cell_renderer_append):
895 * src/widgets/modest-vbox-cell-renderer.c:
896 (modest_vbox_cell_renderer_append):
897 Fix the last commit by doing an extra ref.
899 2007-05-31 Murray Cumming <murrayc@murrayc.com>
901 * src/widgets/modest-hbox-cell-renderer.c:
902 (modest_hbox_cell_renderer_append):
903 * src/widgets/modest-vbox-cell-renderer.c:
904 (modest_vbox_cell_renderer_append):
905 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
906 to fix the build with Maemo Bora.
907 However, there seems to be a remaining crash, probably due to reference
910 2007-05-30 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-tny-account.c:
913 (modest_tny_account_new_for_local_folders):
914 Use hildon_file_system_info_async_new() to get a better name for
915 the memory card account, setting it as the account name.
916 The timing seems to work, but this is probably
917 not the best place to do this. See the TODO comment.
918 * src/maemo/modest-main-window.c: (create_details_widget):
919 * src/widgets/modest-folder-view.c: (text_cell_data):
920 Use the tny account name instead of hardcoding a name.
922 2007-05-30 Christian Kellner <ckellner@openismus.com>
924 * src/modest-search.c: (modest_search):
925 Correctly set part_search_func even if we have already parsed
926 the query and thus a valid OgsTextSearcher object.
928 2007-05-30 Christian Kellner <ckellner@openismus.com>
931 Search and check for libogs.
934 Incooparte the ogs build env.
936 * src/modest-mime-part-search-stream.c:
937 * src/modest-mime-part-search-stream.h:
938 Removed since we do the real searching now in modest-search.c.
940 * src/modest-search.c:
941 * src/modest-search.h:
942 Implement support for ogs. We use that if available and requested
943 and fall back to modest_text_utils_utf8_strcmp (). The search logic
944 should now handle the corner case when the search term is spread
945 across multiple reads.
946 Also the logic in modest_search () was corrected to search all
947 requested fields until one is found.
949 2007-05-30 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
954 * src/modest-init.c: Made modest_init_local_folders() take a
955 path and be public so we can iniitialize maildir folders on
958 * src/modest-local-folder-info.h:
959 * src/modest-local-folder-info.c:
960 (modest_local_folder_info_get_maildir_path): Add a path parameter.
962 * src/modest-tny-account.c:
963 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
964 still means the standard local-folders path on the local volume.
966 * src/modest-tny-account-store.c:
967 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
968 signal so we can detect mount/unmount of the MMC1 card, and do an update of
969 all accounts when that happens.
970 (get_server_accounts): If the MMC1 card is mounted, create a store account for
971 this too, so it shows up in the treeview.
973 2007-05-28 Murray Cumming <murrayc@murrayc.com>
975 * src/maemo/modest-maemo-global-settings-dialog.c:
976 (current_connection):
977 * src/widgets/modest-global-settings-dialog.c:
978 (current_connection_default):
979 Use the enum values instead of 0, 1 and -1,
980 to make the code clearer.
982 * src/modest-account-mgr-helpers.c:
983 (modest_account_mgr_get_connection_specific_smtp): Make this code
986 * src/modest-runtime.h:
987 * src/modest-runtime.c:
988 Added modest_runtime_remove_all_send_queues().
989 * src/maemo/modest-main-window.c:
990 (on_account_store_connecting_finished): Recreate the send queues,
991 using the appropriate transport accounts for this new connection.
992 Some futher adapting might be needed if the old send queues are not
993 automatically stopped at this point.
995 * src/modest-tny-account-store.c: (get_server_accounts):
996 Create the connection-specific transport accounts, so that they can
997 be found later by their ID.
999 * src/modest-tny-account.h:
1000 * src/modest-tny-account.c:
1001 Added modest_tny_account_new_from_server_account_name().
1002 modest_tny_account_new_from_server_account(): Do not create the
1003 send queues here, because they will be
1004 recreated anyway when the connection changes for the first time.
1006 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-local-folder-info.h:
1009 * src/modest-local-folder-info.c:
1010 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1011 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1012 tbox_folder): Take a modest account name instead of a server TnyAccount,
1013 so we can have per-modest-account rather than per-transport-account
1015 We must make sure that we change or recreate the exisitng send queues
1016 when the connection changes for connection-specific transport accounts.
1018 * src/modest-tny-account-store.c:
1019 (create_per_account_local_outbox_folders): Create outboxed per modest
1020 account, not per transport account.
1022 * src/modest-tny-account.h:
1023 * src/modest-tny-account.c:
1024 (modest_tny_account_get_special_folder): For outboxes, get the
1025 parent modest account name. The account is ignored for other folders.
1026 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1027 modest account name rather than a server TnyAccount.
1029 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1031 * src/modest-tny-account.c:
1032 (modest_tny_account_new_from_server_account):
1033 Call modest_runtime_get_send_queue() immediately after creating transport
1034 accounts, so that they start trying to send email from the outbox as soon
1035 as possible at startup. This is probably what we want.
1037 * src/modest-mail-operation.c: (update_account_thread):
1038 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1039 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1040 * src/modest-tny-send-queue.h:
1041 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1042 (modest_ui_actions_on_send):
1043 Added comments about how sending works, though it needs some more work.
1045 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1047 * src/modest-tny-account.c:
1048 (modest_tny_account_get_special_folder): Add TODO because this fails when
1049 the network is busy.
1050 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1051 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1052 Do not try to show this window when there is no active account. The UI
1053 specs does not tell us what to do in this case.
1055 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1059 * src/maemo/Makefile.am:
1060 * src/widgets/Makefile.am: Some dist fixes.
1062 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1064 * src/maemo/modest-connection-specific-smtp-window.c:
1065 (on_button_edit): Make the code clearer, to prevent a double free.
1067 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/modest-account-settings-dialog.c:
1070 (modest_account_settings_dialog_set_account_name),
1071 Check the connection-specific smtp servers checkbox if there are any.
1073 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1074 (modest_connection_specific_smtp_edit_window_init):
1075 Start with a suitable port number.
1077 * src/modest-account-mgr-helpers.h:
1078 * src/modest-account-mgr-helpers.c: Added
1079 modest_account_mgr_get_has_connection_specific_smtp().
1081 (modest_account_mgr_set_connection_specific_smtp),
1082 (modest_account_mgr_remove_connection_specific_smtp),
1083 (modest_account_mgr_get_has_connection_specific_smtp),
1084 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1085 connection-specific smtp server accounts in the account, rather than
1086 the server account conf dir.
1088 This fixes bug projects.maemo.org bug NB#58263 .
1090 * src/modest-tny-account-store.c:
1091 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1092 if there are no server accounts yet, to prevent an infinite loop when there
1093 are no accounts. Document that one must be called before the other.
1095 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1097 * src/modest-account-mgr-helpers.c:
1098 (modest_account_mgr_get_default_account): Make sure that at least
1099 one account is always the default, if there are any enabled accounts.
1100 This is just a sanity check that shouldn't be necessary.
1102 * src/modest-account-mgr-priv.c:
1103 (_modest_account_mgr_account_from_key): Unescape the conf key to
1104 get the real account name. For instance, this is an issue if a space
1105 was in the account name, which can happen because the account name
1106 is generated from the display name.
1107 (_modest_account_mgr_get_account_keyname): Always escape the
1109 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1110 Unescape the conf keys to get the real account names.
1112 For instance, previously the is-default radio button in the accounts
1113 list was not checked for any accounts at first. This fixes that,
1114 and might fix several similar bugs.
1116 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1118 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1119 Removed some debug printfs.
1121 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1123 Modest on-disk outbox directories are now here, for instance:
1124 $HOME/.modest/outboxes/<account-id-1>/outbox
1125 $HOME/.modest/outboxes/<account-id-2>/outbox
1127 $HOME/.modest/local-folders/outbox
1128 so we can have a separate outbox for each account.
1129 But they are shown as one outbox in the GtkTreeView, by using a
1130 TnyMergeFolder in a ModestTnySimpleFolderStore.
1133 * src/modest-tny-simple-folder-store.c:
1134 * src/modest-tny-simple-folder-store.h:
1135 Added ModestTnySimpleFolderStore, used to contain folders from
1136 other folder stores, such as other accounts.
1138 * src/modest-tny-outbox-account.h:
1139 * src/modest-tny-outbox-account.c:
1140 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1141 used for the per-account local outbox folders.
1143 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1144 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1145 only use this (internally) now for the non-outbox local folders.
1147 * src/modest-init.h:
1148 * src/modest-init.c: Added modest_init_one_local_folder(), for
1149 setting up the directory structure for each local folder.
1151 * src/modest-local-folder-info.c:
1152 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1153 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1155 * src/modest-local-folder-info.h:
1156 * src/modest-tny-account-store.c: (on_account_removed),
1157 (on_account_changed), (create_per_account_local_outbox_folders),
1158 (get_server_accounts), (modest_tny_account_store_get_accounts),
1159 (modest_tny_account_store_get_tny_account_by_account),
1160 (modest_tny_folder_store_is_virtual_local_folders):
1162 * src/modest-tny-account.h:
1163 * src/modest-tny-account.c:
1164 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1165 to create an on-disk per-account local outbox folder for each
1167 (create_per_account_local_outbox_folders): Create a local outbox folder
1168 for each transport account.
1169 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1170 for all local folders.
1172 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1173 instead of using g_object_get/set() directly. It is clearer.
1175 (modest_tny_folder_store_get_message_count),
1176 (modest_tny_folder_store_get_local_size
1177 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1178 because we now use these with non-acount folder stores.
1180 (modest_tny_account_get_special_folder),
1181 (modest_tny_account_new_from_server_account),
1182 (modest_tny_account_new_from_account):
1183 (recurse_folders): Adjust to the new outbox system.
1185 * src/modest-tny-folder.h:
1186 * src/modest-tny-folder.c:
1187 (modest_tny_folder_is_local_folder),
1188 (modest_tny_folder_get_local_folder_type),
1189 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1191 * src/widgets/modest-main-window.h:
1192 * src/maemo/modest-main-window.c: (create_details_widget),
1193 (modest_main_window_set_contents_style): Show details for any folder store,
1196 (modest_tny_folder_get_rules):
1197 Remove the const. C does not support constness enough for this.
1199 * src/modest-ui-actions.c:
1200 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1201 make all outboxes appear as one, in the usual local-folders tree node.
1203 (set_active_account_from_tny_account),
1204 (modest_ui_actions_on_folder_selection_changed):
1205 * src/widgets/modest-folder-view.c: (text_cell_data),
1206 (icon_cell_data), (filter_row),
1207 (add_account_folders_to_merged_folder),
1208 (add_account_folders_to_simple_folder_store), (),
1209 (get_cmp_rows_type_pos), (cmp_rows),
1210 (modest_folder_view_set_account_id_of_visible_server_account):
1211 Adjust to the new outbox system, using generic folder stores and folders
1212 in the GtkTreeModel.
1214 2007-05-23 Christian Kellner <ckellner@openismus.com>
1216 * src/modest-mail-operation.c:
1217 (modest_mail_operation_update_account):
1218 Use info->max_size instead of unintialized local var [small
1219 build fix]. (Added TODO to review that change since I don't
1222 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1224 * libmodest-dbus-client/libmodest-dbus-client.c:
1225 (libmodest_dbus_client_compose_mail): function added
1226 * src/dbus_api/modest-dbus-api.h:
1227 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1228 (on_compose_mail): Implementation of the SendAsMail functionality
1230 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-account-mgr.c:
1233 (modest_account_mgr_add_server_account): Set the secure-connection
1234 conf key for transport accounts as well as store accounts. I don't know
1235 why the if was there. For instance, this makes sure that we use SSL
1236 for the gmail preset from the easysetup wizard.
1238 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1240 * src/gnome/modest-main-window.c:
1241 (on_account_store_connecting_finished), (connect_signals):
1242 * src/maemo/modest-main-window.c:
1243 (on_account_store_connecting_finished), (connect_signals),
1244 (modest_main_window_new):
1245 Handle TnyAccountStore::connecting-finished instead of
1246 TnyDevice::connection-changed, because we cannot actually perform
1247 operations on accounts until TnyAccountStore has itself responded to
1248 the TnyDevice::connection-changed signal. This prevents a GError from
1250 Do not try to update at startup, because we (at least on scratchbox)
1251 already do an update at startup when the device goes online.
1252 This prevents a GError from tinymail.
1253 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1254 Added TODO about stopping simultaneous operations.
1256 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1258 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1259 * src/modest-mail-operation-queue.c:
1260 (modest_mail_operation_queue_remove):
1261 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1262 about where they happened.
1264 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1266 * src/modest-ui-actions.c:
1267 (modest_ui_actions_on_password_requested): Make sure that the remember
1268 output parameter is always TRUE.
1270 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1273 Show a OK/Cancel dialog if the error is a question, though we still do not
1274 know anything more about what we are asking the user.
1275 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1276 Fix an uninitialized variable (helper). This is a logic error, however.
1278 2007-05-21 Christian Kellner <ckellner@openismus.com>
1280 * src/modest-search.h:
1281 Correct bit shifting in the ModestSearchFlags enum.
1283 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-tny-account.c:
1286 (modest_tny_account_new_from_server_account): Do not use the lsub and
1287 check-all hard-coded IMAP options when using POP.
1289 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1291 * src/modest-tny-account.c:
1292 (modest_tny_account_new_from_server_account):
1293 Use NULL for the secure-auth method for POP when Password auth has been
1294 specified by the user, as we already do for IMAP. "auth=Login" causes
1295 an error from camel or the server.
1297 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/modest-account-settings-dialog.c:
1300 (create_page_account_details),
1301 (modest_account_settings_dialog_set_account_name):
1302 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1303 for the leave-on-server checkbox, rathr than just the checkbox, when
1304 the protocol is not POP.
1306 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1308 * src/widgets/modest-account-view.c:
1309 * src/widgets/modest-account-view.h:
1310 Added modest_account_view_select_account() which will be useful later
1311 to asynchronously re-select the edited account.
1313 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1315 * src/maemo/modest-account-settings-dialog.c:
1316 (modest_account_settings_dialog_set_account_name):
1317 Automatically choose the port numbers based on the secure authentication
1318 methods, if they have not been chosen before.
1319 This fixes projects.maemo.org bug NB#56273 .
1321 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1323 * src/maemo/modest-main-window-ui.h:
1324 * src/modest-ui-actions.c:
1325 * src/modest-ui-actions.h:
1326 Connect the Tools/SMTP Servers menu item to
1327 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1328 SMTP servers dialog, as in the UI specification and saves changes when it
1329 is closed. This fixed projects.maemo.org bug NB#56305 .
1331 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1333 * src/maemo/modest-connection-specific-smtp-window.c:
1334 (modest_connection_specific_smtp_window_init):
1335 Use gtk_window_set_default_size() to make this window big enough, so
1336 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1338 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1340 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1341 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1342 (modest_connection_specific_smtp_edit_window_init),
1343 Do not try to connect to a combobox signal before the combobox exists.
1344 This fixes the cras in projects.maemo.org bug NB#56288 .
1345 (modest_connection_specific_smtp_edit_window_get_settings):
1346 Remove the server_account_name parameter which was being checked for NULL
1347 though it was not used.
1349 * src/maemo/modest-connection-specific-smtp-window.c:
1350 (modest_connection_specific_smtp_window_fill_with_connections),
1351 (on_button_edit), (modest_connection_specific_smtp_window_init):
1352 Correct the number of treemodel columns to prevent a warning.
1353 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1354 libconic does not work.
1356 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1358 * src/modest-tny-account.c:
1359 (modest_tny_account_new_from_server_account):
1360 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1361 SMTP when "None" was chosen by the user. However, with my SMTP server that
1362 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1365 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1367 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1368 to explain the memory management issue with the ID in the ModestPair.
1370 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1371 (add_sending_page), (modest_account_assistant_finalize):
1372 * src/gnome/modest-gnome-global-settings-dialog.c:
1373 (create_updating_page), (create_composing_page):
1374 * src/gnome/modest-msg-edit-window.c: (get_transports),
1375 (init_window), (modest_msg_edit_window_finalize),
1376 (modest_msg_edit_window_get_msg_data):
1377 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1378 * src/gnome/modest-transport-widget.c:
1379 (modest_transport_widget_finalize), (smtp_configuration):
1380 * src/maemo/modest-maemo-global-settings-dialog.c:
1381 (create_updating_page), (create_composing_page):
1382 * src/maemo/modest-msg-edit-window.c: (get_transports),
1383 (init_window), (modest_msg_edit_window_finalize),
1384 (modest_msg_edit_window_get_msg_data),
1385 (modest_msg_edit_window_free_msg_data):
1386 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1387 (modest_store_widget_finalize):
1388 * src/maemo/modest-transport-widget.c:
1389 (modest_transport_widget_finalize), (smtp_configuration):
1390 * src/modest-main.c: (send_mail):
1391 * src/widgets/modest-combo-box.h:
1392 * src/widgets/modest-global-settings-dialog-priv.h:
1393 * src/widgets/modest-global-settings-dialog.c:
1394 (modest_global_settings_dialog_finalize):
1395 * src/widgets/modest-msg-edit-window.h:
1396 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1397 as long as the combo box, to prevent use of freed memory for the ID.
1399 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1402 get_accounts(), to make this clearer. Do not check for the enabled gconf
1403 key, because we do not use this for server accounts (at least, not yet).
1404 This allows us to send email again.
1406 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1408 * src/maemo/modest-platform.c:
1409 (on_modest_conf_update_interval_changed), (modest_platform_init):
1410 Only respond to this particular key change. All these strcmp()s cannot be
1413 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1415 * src/maemo/modest-maemo-global-settings-dialog.c:
1416 (current_connection): Prevent a crash in scratchbox when
1417 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1418 * src/maemo/modest-platform.c:
1419 (on_modest_conf_update_interval_changed), (modest_platform_init):
1420 Get the update interval from gconf and reset it when the gconf key changes.
1422 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1424 * src/modest-protocol-info.c:
1425 * src/modest-protocol-info.h: Adde enum-specific get functions,
1426 instead of using a ModestProtocolType enum parameter.
1428 * src/gnome/modest-account-assistant.c:
1429 * src/gnome/modest-store-widget.c:
1430 * src/gnome/modest-store-widget.h:
1431 * src/gnome/modest-transport-widget.c:
1432 * src/gnome/modest-transport-widget.h:
1433 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1434 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1435 * src/maemo/easysetup/modest-easysetup-wizard.c:
1436 * src/maemo/modest-account-settings-dialog.c:
1437 * src/maemo/modest-account-settings-dialog.h:
1438 * src/maemo/modest-store-widget.c:
1439 * src/maemo/modest-store-widget.h:
1440 * src/maemo/modest-transport-widget.c:
1441 * src/maemo/modest-transport-widget.h:
1442 * src/modest-account-mgr-helpers.c:
1443 * src/modest-account-mgr-helpers.h:
1444 * src/modest-account-mgr.c:
1445 * src/modest-account-mgr.h:
1446 * src/modest-tny-account.c:
1447 * src/modest-tny-folder.c:
1448 * src/widgets/modest-account-view.c:
1449 * src/widgets/modest-retrieve-combo-box.c:
1450 * src/widgets/modest-retrieve-combo-box.h:
1451 * src/widgets/modest-secureauth-combo-box.c:
1452 * src/widgets/modest-serversecurity-combo-box.c:
1453 * src/widgets/modest-serversecurity-combo-box.h:
1454 * tests/check_account-mgr.c:
1455 Use the specific functions, and use the re-renamed enum values for GNOME too.
1457 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1459 * src/modest-pair.h:
1460 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1461 so we can get the second based on the first.
1463 * src/maemo/modest-account-settings-dialog.h:
1464 * src/maemo/modest-account-settings-dialog.c:
1465 Added get_supported_secure_authentication_methods(), though it is mostly
1466 commented-out for now until the necessary API is committed to tinymail.
1467 (modest_account_settings_dialog_set_account_name),
1468 (save_configuration): Request the supported authentication methods from the
1469 server, so we can choose a working method.
1471 * src/modest-tny-account-store.h:
1472 * src/modest-tny-account-store.c:
1473 (modest_tny_account_store_get_session): Rename from
1474 tny_account_store_get_session().
1476 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1478 * src/modest-protocol-info.h: Split the ModestProtocol enum
1479 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1480 There was no need to have these unrelated values in one enum.
1482 * src/: many files: Adapted to changed enum. This makes the code a bit
1483 clearer, and the compiler could catch some errors.
1485 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1487 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1488 Show the detailed internal camel error message when an error happens
1489 during the configuration, so that our testers can give us more clues.
1490 For instance, in projects.maemo.org bug NB#56910 .
1492 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1494 * src/modest-tny-account.c:
1495 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1496 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1498 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1500 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1501 * src/maemo/modest-account-settings-dialog.c:
1502 (modest_account_settings_dialog_set_account_name),
1503 (save_configuration): For the incoming secure authentication checkbox,
1504 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1505 the UI specification. PLAIN does not seem to be supported for most IMAP
1506 servers anyway, and I am not sure what it would mean.
1507 However, we probably need to discover which of the secure-authentication
1508 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1509 * src/modest-account-mgr-helpers.c:
1510 (modest_account_mgr_get_server_account_data):
1512 * src/modest-tny-account.c:
1513 (modest_tny_account_new_from_server_account):
1514 Use tny_account_set_mech() to set secure-authentication methods,
1515 with some special-casing for IMAP, based on my observations of how
1518 * src/modest-account-mgr-helpers.h:
1519 * src/modest-account-mgr.c:
1520 * src/modest-defs.h: Comment that the URI is only used for local folders.
1522 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1524 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1525 parameter const, just to be neat.
1526 * src/modest-text-utils.c: (modest_text_utils_inline):
1527 End g_strconcat() with NULL, as its documentation says. This is almost
1528 certainly the cause of my crash at startup on the device. Interestingly,
1529 valgrind doesn't tell us about these errors.
1531 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1533 * scripts/build-packages: Added more precise comments about how to use
1534 this script, though I still get this error:
1535 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1536 error building tinymail
1538 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1540 * src/maemo/modest-main-window.c: (on_account_update):
1541 Very slight cleanup, hoping to make it simpler to discover what causes
1542 a crash here sometimes.
1544 * src/modest-tny-account.c:
1545 (modest_tny_account_new_from_server_account): Set the port. Added
1546 comments about the options and a TODO comment because I need to find out
1547 how to specify the secure authentication method.
1549 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1551 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1552 changed CFlags paths form modest to libmodest
1554 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1556 * src/modest-account-mgr-helpers.c:
1557 (modest_account_mgr_get_server_account_data),
1558 (modest_account_mgr_free_server_account_data):
1559 * src/modest-account-mgr-helpers.h:
1560 * src/modest-account-mgr.c:
1561 (modest_account_mgr_add_server_account):
1562 * src/modest-defs.h:
1563 * src/modest-tny-account.c:
1564 (modest_tny_account_new_from_server_account):
1565 Determine the options for tny_camel_account_add_option() here,
1566 based on the settings, rather than storing them directly in gconf.
1568 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1570 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1571 Show a more friendly error dialog now that we expect (from the tinymail
1572 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1574 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1576 * src/maemo/modest-main-window.c: (on_account_update): Check that
1577 account_name is not NULL, to prevent a crash at startup that I am
1578 seeing on the N800. I do wonder why it is NULL.
1580 * src/maemo/easysetup/modest-easysetup-wizard.c:
1581 (create_page_user_details):
1582 * src/maemo/modest-account-settings-dialog.c:
1583 (create_page_user_details), (create_page_outgoing):
1584 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1585 (modest_connection_specific_smtp_edit_window_init):
1586 * src/modest-ui-actions.c:
1587 (modest_ui_actions_on_password_requested):
1588 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1589 might do something useful with the on-screen keyboard.
1591 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/modest-main-window.c: (on_account_update):
1594 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1595 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1597 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1599 * src/modest-tny-account-store.c: (on_account_changed):
1600 Correct the signature of this signal handler.
1602 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1604 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1605 Show a HildonNote instead of a GtkDialog for Maemo.
1607 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1609 * src/widgets/modest-account-view.h:
1610 * src/widgets/modest-account-view.c: (on_account_changed),
1611 (on_account_removed). Added a boolean flag, set/unset by
1612 modest_account_view_block_conf_updates(),
1613 modest_account_view_unblock_conf_updates() to prevent unnecessary
1614 updates, but this is not very useful because the gconf notifications are
1615 so delays (maybe only on Maemo Bora).
1616 So auto-updating is turned off, and these functions do an explicit
1617 update when necessary.
1618 However, something else is still doing too much work when adding/removing
1619 accounts, probably in another part of the application.
1621 * src/maemo/modest-account-view-window.c:
1622 (on_delete_button_clicked), (on_edit_button_clicked),
1623 (on_new_button_clicked): Use the new functions.
1625 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1627 * src/modest-account-mgr-helpers.c:
1628 (modest_account_mgr_set_first_account_as_default):
1629 Sort the list of names alphabetically-by-title, so we choose the first one
1631 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1632 alphabetically by the title.
1634 This fixes projects.maemo.org bug NB#56418 .
1636 * src/modest-account-mgr-priv.c:
1637 (_modest_account_mgr_account_from_key):
1638 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1639 avoid a valgrind error, and possible random behaviour.
1641 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1643 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1644 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1645 tinymail documentation to say that this can be expected.
1646 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1647 pretty, and should not happen, but I would prefer to know when it does.
1649 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1651 * configure.ac: When using the older hildon version, probably on Bora,
1652 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1654 * src/widgets/modest-attachment-view.c:
1655 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1658 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1660 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1661 Implemented the prototype. Can be tested with
1662 tests/dbus_api/test_open_message:
1664 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-tny-account-store.c:
1667 (modest_tny_account_store_instance_init), (get_password):
1668 * src/modest-ui-actions.c:
1669 (modest_ui_actions_on_password_requested):
1670 Do not store the password in gconf, because this function is called
1671 for non-remembered passwords. Actually use the cached (in the hash map)
1672 password instead of releasing it.
1673 The password will now not be remembered if it is asked via the protected
1674 password dialog, as per the UI spec.
1676 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1678 * src/modest-defs.h:
1679 * src/modest-account-mgr-helpers.h:
1680 * src/modest-account-mgr-helpers.c:
1681 Added modest_server_account_get_username_has_succeeded(),
1682 modest_server_account_set_username_has_succeeded().
1683 (modest_server_account_set_username),
1684 Reset the has-succeeded flag if the username changes.
1686 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1687 * src/maemo/modest-connection-specific-smtp-window.c:
1688 (modest_connection_specific_smtp_window_save_server_accounts):
1689 Use modest_server_account_set_username() instead of using
1690 modest_conf_set_string() directly, so that the has-succeeded flag is always
1693 * src/modest-ui-actions.c:
1694 (modest_ui_actions_on_password_requested): Dim the username entry if
1695 the username has ever worked, as per the UI spec.
1697 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1699 * src/modest-tny-account-store.c: (get_password):
1700 * src/modest-ui-actions.c:
1701 (modest_ui_actions_on_password_requested):
1702 Allow the username to be changed too, though there is more work to
1703 be done on exactly how this behaves.
1705 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-account-mgr-helpers.h:
1708 * src/modest-account-mgr-helpers.c:
1709 Added modest_account_mgr_get_display_name(),
1710 modest_server_account_get_username(),
1711 modest_server_account_set_username(),
1712 modest_server_account_set_password(),
1713 modest_server_account_get_hostname() functions so we do not need to
1714 use the conf API directly.
1716 * src/maemo/modest-main-window.c: (connect_signals):
1717 Actually connect ot the ModestAccountStore::request-password signal,
1718 so that we show the dialog when the password is requested by Tinymail,
1719 for isntance if it is empty.
1721 * src/modest-marshal.list:
1722 * src/modest-tny-account-store.c:
1723 (modest_tny_account_store_class_init), (get_password),
1724 (modest_tny_account_store_alert):
1725 * src/modest-tny-account-store.h:
1726 * src/modest-ui-actions.h:
1727 * src/modest-ui-actions.c:
1728 (modest_ui_actions_on_password_requested):
1729 Change the signal parameters, so it is obvious that we are providing
1730 the non human-readable server name, and receiving both the username
1731 and password, though changing of the username is not yet implemented.
1732 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1733 for the GNOME version.
1735 This should fix the projects.maemo.org bug NB#56209, though it does not
1736 work on Bora, because the gconf_client_get() for the password fails
1737 immediately after we save it with gconf_client_set().
1739 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1742 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1743 caused an undefined symbol error:
1744 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1746 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1748 * src/modest-tny-account-store.c:
1749 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1750 using a GError instead of a string message, so we can translate it in
1753 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1755 * src/maemo/modest-address-book.c:
1756 (modest_address_book_check_names):
1757 * src/maemo/modest-msg-view-window.c:
1758 (modest_msg_view_window_clipboard_owner_change):
1759 * src/modest-init.c: (modest_init_init_ui):
1760 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1761 (update_folders_cb), (modest_mail_operation_update_account):
1762 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1763 (modest_ui_actions_on_msg_attachment_clicked),
1764 (modest_ui_actions_on_msg_recpt_activated):
1765 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1766 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1767 (modest_msg_view_search_next):
1768 * src/widgets/modest-recpt-editor.c:
1769 (modest_recpt_editor_on_button_release_event),
1770 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1771 g_message(). At this point we should only be seeing interesting errors on
1772 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1774 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1776 (modest_wizard_dialog_force_title_update):
1777 * src/maemo/easysetup/modest-wizard-dialog.h:
1778 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1779 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1780 can update the title when appropriate. Otherwise the title is wrong if the
1781 pages are added after adding the notebook to the dialog.
1782 This must be a problem in HildonWizardDialog too.
1783 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1785 * src/maemo/easysetup/modest-easysetup-wizard.c:
1786 (create_subsequent_customsetup_pages),
1787 (create_subsequent_easysetup_pages):
1788 Call modest_wizard_dialog_force_title_update() so that the title is
1789 correct even with GTK+ < 2.10.
1790 This fixes projects.maemo.org bug NB#56145 .
1792 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1794 * src/maemo/modest-platform.c:
1795 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1796 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1799 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1801 * src/widgets/modest-window.h:
1802 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1803 and modest_window_save_state(), which invokes it.
1805 * src/widgets/modest-window-mgr.h:
1806 * src/widgets/modest-window-mgr.c:
1807 Added modest_window_mgr_save_state_for_all_windows(), which calls
1808 the save_state vfunc on all registered windows, if implemented.
1810 * src/gnome/modest-msg-edit-window.c:
1811 * src/gnome/modest-msg-view-window.c:
1812 * src/maemo/modest-msg-edit-window.c:
1813 * src/maemo/modest-msg-view-window.c:
1814 * src/maemo/modest-main-window.c:
1815 Specify the existing save_settings functions as implementations of
1816 ModestWindow::save_state_func().
1818 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1819 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1820 enabling hibernation, for instance.
1822 We may need to do the same thing for restoring settings.
1825 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1827 * src/widgets/modest-window-mgr.c:
1828 * src/widgets/modest-window-mgr.h:
1829 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1830 modest_window_mgr_get_hibernation_is_prevented().
1832 * src/maemo/modest-main-window.c:
1833 (on_hildon_program_is_topmost_notify): Prevent hibernation
1834 (possible when the application goes to the background in the WM),
1835 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1837 * src/maemo/easysetup/modest-easysetup-wizard.c:
1838 (modest_easysetup_wizard_dialog_init):
1839 * src/maemo/modest-account-settings-dialog.c:
1840 (modest_account_settings_dialog_init):
1841 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1842 (modest_connection_specific_smtp_edit_window_init):
1843 * src/maemo/modest-connection-specific-smtp-window.c:
1844 (modest_connection_specific_smtp_window_init):
1845 * src/maemo/modest-signature-editor-dialog.c:
1846 (modest_signature_editor_dialog_init):
1847 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1848 prevent hibernation while any of these account settings dialogs are open.
1850 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/Makefile.am:
1853 * src/maemo/modest-osso-state-saving.c:
1854 * src/maemo/modest-osso-state-saving.h: Added
1855 modest_osso_load_state() and modest_osso_save_state() though they do
1856 nothing now. They should iterate through all the open windows and load/save
1858 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1859 save state when closing.
1861 * src/maemo/modest-main-window.c:
1862 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1863 Add a notification handler for the HildonProgram::is-topmost property,
1864 so we can allow hibernation when the application goes into the background.
1865 But we still need to detect when the accounts setup windows are open so
1866 we can stop hibernation when they are open.
1867 To do this, I also added the main window the HildonProgram. This might have
1868 other side-effects/benefits, and should maybe be done for other windows.
1870 * src/maemo/modest-osso-autosave-callbacks.h:
1871 * src/maemo/modest-osso-autosave-callbacks.c:
1872 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1873 though it does not do anything yet, and we might never need this to do
1874 anything. For instance, we already save drafts.
1876 * src/maemo/modest-platform.c: (modest_platform_init):
1877 Specify the libosso auto-save callback.
1879 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1881 * src/maemo/modest-platform.c:
1882 (modest_platform_set_update_interval):
1883 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1884 aparently stays valid between application instances, so we can use this
1885 to remove and reset it later. According to a maemo-developers email from
1888 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1890 * configure.ac: Depend on libalarm for Maemo.
1892 * src/dbus_api/modest-dbus-api.h:
1893 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1894 (on_send_receive), (modest_dbus_req_handler):
1895 Handle a SEND_RECEIVE D-Bus method.
1897 * libmodest-dbus-client/libmodest-dbus-client.c:
1898 (libmodest_dbus_client_send_and_receive):
1899 * libmodest-dbus-client/libmodest-dbus-client.h:
1900 Add C convenience functions for calling the new D-Bus method.
1902 * src/modest-platform.h:
1903 * src/gnome/modest-platform.c:
1904 * src/maemo/modest-platform.c:
1905 Added modest_platform_set_update_interval(), which uses the
1906 alarmd API on Maemo.
1907 (modest_platform_init),
1908 Call modest_platform_set_update_interval(), using a hard-coded
1909 interval for now (until the global settings dialog is implemented),
1910 though I am not sure that this makes sense yet.
1912 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1914 * src/dbus_api/modest-dbus-callbacks.c:
1915 (modest_osso_cb_hw_state_handler):
1916 * src/dbus_api/modest-dbus-callbacks.h:
1917 * src/maemo/modest-platform.c: (modest_platform_init):
1918 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1919 in case this has some effect on the ability for Maemo to ping the
1922 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1924 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1925 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1926 warning. It is probably a logic error, but I need to fix the build.
1928 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1930 * src/modest-account-mgr.h:
1931 * src/modest-account-mgr.c:
1932 (modest_account_mgr_account_names): Add a gboolean enabled_only
1933 parameter, so we can get lists of onlt the enabled accounts.
1935 (modest_account_mgr_add_account),,
1936 (modest_account_mgr_account_with_display_name_exists):
1937 * src/maemo/modest-msg-edit-window.c: (get_transports):
1938 * src/modest-account-mgr-helpers.c:
1939 (modest_account_mgr_set_first_account_as_default):
1940 * src/modest-init.c: (init_default_account_maybe):
1941 * src/modest-tny-account-store.c: (get_accounts):
1942 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1943 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1944 * tests/check_account-mgr.c: (START_TEST):
1945 Provide the extra parameter, as appropriate.
1947 * src/widgets/modest-account-view.c: (update_account_view):
1948 Do not show disabled accounts (meaning that there is no way to
1949 enable/disable accounts in the UI (the feature is not in our UI
1950 specification), so we can use this internally only to mark unfinished
1951 or temporary account data.
1953 * src/maemo/easysetup/modest-easysetup-wizard.c:
1954 (create_account): Add boolean enable parameter, so we can specify FALSE
1955 to create the temporary account.
1956 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1957 (on_before_next): When finishing, when there is a temporary account, just
1959 Also, use a timeout to delay the showing of the dialog until gconf is likely
1960 to return correct information, due to a maemo gconf bug that is fixed in
1961 osso 1.1, but not yet in Bora.
1962 However, the dialog stays on screen after it is destroyed.
1964 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1965 for invalid data when cancelling. Use a hildon note instead of a dialog
1966 to complain about invalid data. Do not show the account-saved note if the
1967 account is disabled (a temporary account that will not really be saved for use
1970 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1972 * src/modest-account-mgr-helpers.h:
1973 * src/modest-account-mgr-helpers.c:
1974 Added modest_account_mgr_unset_default_account(),
1975 Added modest_account_mgr_set_first_account_as_default().
1977 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1978 If it was the default account, unset the default account name.
1980 * src/maemo/modest-account-view-window.c:
1981 (on_delete_button_clicked): If it was the default account,
1982 set the first remaining account as the default instead.
1984 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1985 a NULL account or a NULL default account, to prevent a crash. This should
1986 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1989 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1991 * src/widgets/modest-recpt-editor.c:
1992 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1993 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1994 TODO comment for this. This fixes the build.
1996 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1997 be the best place for it. This will in future update all auto-update accounts,
1998 rather than just the current/default account, when that gconf key exists.
1999 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2000 if there are no accounts, before calling do_send_receive().
2001 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2003 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2004 * src/maemo/modest-main-window-ui.h:
2005 * src/maemo/modest-main-window.c: (on_connection_changed),
2006 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2007 directly, becaue the signal handler does more.
2009 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2011 * src/modest-account-mgr-helpers.c:
2012 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2013 for the case that the account does not exist.
2015 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2016 (equivalent to the modest account name) rather than the tinymail account name
2017 (equivalent to the modest account title - human readable) to get the account data.
2018 Check for null account data to prevent the crash, and add a TODO comment saying that
2019 this needs fixing because it is using the server account name instead of the account name.
2021 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2023 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2024 * src/maemo/modest-account-settings-dialog.c: (show_error),
2026 Use hildon_note_new_information() for informative and error messages,
2027 which seems to be expected for Maemo applications (no documentation that I know of
2028 says this). I am surprised that there is no distinction between info and error
2031 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2033 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2034 it is easy to find where this is used.
2036 * src/maemo/easysetup/modest-easysetup-wizard.c:
2037 (create_page_welcome), (create_page_account_details),
2038 (create_page_user_details), (create_page_complete_easysetup),
2039 (create_page_custom_incoming), (create_page_custom_outgoing),
2040 (create_page_complete_custom):
2041 * src/maemo/modest-account-settings-dialog.c:
2042 (create_page_account_details), (create_page_user_details),
2043 (create_page_incoming), (create_page_outgoing):
2044 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2045 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2046 (modest_connection_specific_smtp_edit_window_init):
2047 * src/maemo/modest-connection-specific-smtp-window.c:
2048 (modest_connection_specific_smtp_window_init):
2049 * src/maemo/modest-signature-editor-dialog.c:
2050 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2051 and scrolling policy as per the Email Application Layout Guide, if I have
2054 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2056 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2057 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2058 which were empty, because these vfuncs have been removed from TnyAccountStore.
2059 This fixes the build.
2061 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/modest-main-window.c:
2064 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2065 showing/hiding it. Added TODO because it probably should not be NULL.
2066 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2067 because unnecessary g_warnings() make degugging difficult.
2069 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2071 * src/maemo/modest-msg-edit-window.c:
2072 (modest_msg_edit_window_select_color),
2073 (modest_msg_edit_window_select_background_color): 2 const corrections and
2074 moving 2 #endifs before closing brackets, to fix the build.
2076 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/easysetup/modest-easysetup-wizard.h:
2079 * src/maemo/easysetup/modest-easysetup-wizard.c:
2080 (modest_easysetup_wizard_dialog_finalize),
2081 (on_button_edit_advanced_settings), (create_page_complete_custom),
2082 (on_response), (create_account):
2083 Implement the Advanced Settings edit button, by saving the account information,
2084 for the Advanded Settings dialog to use directly from gconf, and removing it
2085 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2086 Bug #5533 in the projects.maemo.org bugzilla.
2088 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2090 * src/maemo/modest-msg-view-window.c:
2091 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2092 when opening a message window.
2094 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/easysetup/modest-easysetup-wizard.c:
2097 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2100 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2101 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2102 gconf settings. I probably added more checks than necessary, but that is safer.
2104 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2105 variable to fix the build, but this seems to be used when it is still NULL.
2107 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2109 * src/modest-platform.h:
2110 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2111 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2112 * src/modest-main.c: Implement this function so we can avoid using
2113 maemo-specific API from cross-platform code.
2115 * src/modest-tny-account-store.c:
2116 (get_smtp_specific_transport_account_for_open_connection):
2117 * src/modest-ui-actions.c: (check_for_connection),
2118 (modest_ui_actions_on_item_not_found):
2119 Use modest_platform_connect_and_wait() and put #idefs around other
2120 maemo-specific code, because only maemo currently has a way to
2121 identify connection names.
2123 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2125 * src/modest-tny-account-store.h:
2126 * src/modest-tny-account-store.c:
2127 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2128 the connection-specific SMTP server settings in the configuration.
2130 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2132 * src/maemo/modest-main-window.c: (on_connection_changed),
2134 * src/modest-main.c: (main), (start_ui), (send_mail):
2135 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2136 that is what is intended.
2138 * src/modest-ui-actions.c: (action_send), (action_receive),
2139 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2140 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2141 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2142 SMTP server is used when it is specified.
2144 (modest_ui_actions_on_send_receive):
2145 Check that a connection is open before proceeding.
2146 Receive and then send, instead of vice-versa, as per the specification.
2148 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-mail-operation.c:
2151 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2152 though I guess it should be something other than NULL.
2154 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2156 * src/maemo/easysetup/modest-easysetup-wizard.c:
2157 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2158 combo twice, to avoid an g_warning and to make it visible again.
2159 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2160 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2161 (already intended) dereference when detaching, because we then recreate the menu.
2162 But I am not sure why the warning was happening, and it is possible that this is a memory
2165 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2167 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2168 and uri_parse_mailto() utility functions.
2169 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2171 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2173 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2175 * src/dbus_api/modest-dbus-api.h:
2176 * src/dbus_api/modest-dbus-callbacks.c:
2177 Use an idle callback to execute the modest code in the application's own thread.
2178 Remove the helloworld example method.
2179 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2180 parsed, and the open-message method is not implemented because this is not yet implemented in
2182 * libmodest-dbus-client/libmodest-dbus-client.c:
2183 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2184 (libmodest_dbus_client_open_message):
2185 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2187 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2188 body without crashing.
2190 * tests/dbus_api/Makefile.am:
2191 * tests/dbus_api/test_mail_to.c:
2192 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2194 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2196 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2197 Added file to fix the build. Sorry.
2199 * src/dbus_api/Makefile.am:
2200 * src/dbus_api/modest-dbus-api.h:
2201 * src/dbus_api/modest-dbus-callbacks.h:
2202 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2203 (modest_dbus_req_handler):
2204 Put constants in a separate header so it can be reused by the
2205 client library, without duplication
2207 * libmodest-dbus-client/Makefile.am:
2208 * libmodest-dbus-client/libmodest-dbus-client.c:
2209 (libmodest_dbus_client_call_helloworld),
2210 (libmodfest_dbus_client_send_mail),
2211 (libmodfest_dbus_client_mailto),
2212 (libmodfest_dbus_client_open_message):
2213 * libmodest-dbus-client/libmodest-dbus-client.h:
2214 (Partly) Implement a send_mail D-Bus method.
2216 * tests/dbus_api/Makefile.am:
2217 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2218 the send_email D-Bus method.
2220 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2224 * libmodest-dbus-client/Makefile.am:
2225 * libmodest-dbus-client/libmodest-dbus-client.c:
2226 * libmodest-dbus-client/libmodest-dbus-client.h:
2227 * tests/dbus_api/Makefile.am:
2228 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2229 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2231 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2233 * src/maemo/easysetup/modest-easysetup-wizard.c:
2234 (create_page_account_details):
2235 * src/maemo/modest-account-settings-dialog.c:
2236 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2237 widgets, because this might not be the default in future versions of the Maemo GTK+.
2238 However, I can not not get capitalization to work even in a simple test case.
2240 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2242 * src/maemo/easysetup/modest-easysetup-wizard.c:
2243 (create_page_custom_incoming), (create_page_custom_outgoing):
2244 * src/maemo/modest-account-settings-dialog.c:
2245 (create_page_account_details), (create_page_incoming),
2246 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2247 instead of using gtk_check_button_with_label(), so they are aligned like the other
2248 widgets, as per the UI spec.
2250 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2252 * src/maemo/easysetup/modest-easysetup-wizard.c:
2253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2254 * src/widgets/modest-validating-entry.c:
2255 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2256 Modest prefix instead of an EasySetup prefix.
2258 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2260 * src/widgets/modest-validating-entry.h:
2261 * src/widgets/modest-validating-entry.c: (on_insert_text),
2262 Added easysetup_validating_entry_set_max_func(), used to set a callback
2263 to call when the max number of characters is reached. GtkEntry has a max-length
2264 already but is silent about it.
2266 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2267 (create_page_account_details), (create_page_user_details),
2269 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2270 (create_page_account_details), (create_page_user_details),
2271 (create_page_outgoing):
2272 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2273 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2274 the UI spec, when the user tries to enter more than the max number of characters.
2276 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2278 * src/maemo/easysetup/modest-easysetup-wizard.c:
2279 (create_page_user_details), (create_page_custom_incoming),
2280 (create_page_custom_outgoing):
2281 * src/maemo/modest-account-settings-dialog.c:
2282 (create_page_user_details), (create_page_incoming),
2283 (create_page_outgoing):
2284 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2285 (modest_connection_specific_smtp_edit_window_init):
2286 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2287 not appropriate. Bad Maemo-specific defaults!.
2289 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2291 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2292 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2293 (modest_signature_editor_dialog_set_settings):
2294 Disable the label and textview when the checkbox is disabled, and use the
2295 specified (UI spec) default signature text.
2297 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2299 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2300 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2302 * src/modest-defs.h:
2303 * src/modest-account-mgr-helpers.h:
2304 * src/modest-account-mgr-helpers.c:
2305 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2307 * src/maemo/Makefile.am:
2308 * src/maemo/modest-signature-editor-dialog.c:
2309 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2312 * src/maemo/modest-account-settings-dialog.h:
2313 * src/maemo/modest-account-settings-dialog.c:
2314 (modest_account_settings_dialog_finalize), (on_button_signature),
2315 (save_configuration): Use the new dialog when the Edit button is pressed, and
2316 save the changes if necessary, as per the UI spec.
2318 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2320 * src/maemo/Makefile.am:
2321 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2322 based on maemo-develoers email from Dirk.
2324 * src/maemo/easysetup/modest-easysetup-wizard.c:
2325 (create_page_welcome), (create_page_account_details),
2326 (create_page_user_details), (create_page_complete_easysetup),
2327 (create_page_custom_incoming), (create_page_custom_outgoing),
2328 (create_page_complete_custom),
2329 (modest_easysetup_wizard_dialog_init):
2330 * src/maemo/modest-account-settings-dialog.c:
2331 (create_page_account_details), (create_page_user_details),
2332 (create_page_incoming), (create_page_outgoing),
2333 (modest_account_settings_dialog_init):
2334 * src/maemo/modest-connection-specific-smtp-window.c:
2335 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2337 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2339 * src/maemo/easysetup/modest-easysetup-wizard.c:
2340 (create_page_account_details), (create_page_custom_outgoing),
2341 (create_page_complete_custom):
2342 * src/maemo/modest-account-settings-dialog.c:
2343 (create_page_user_details), (create_page_incoming),
2344 (create_page_outgoing):
2345 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2346 (modest_connection_specific_smtp_edit_window_init):
2347 Use the correct (UI spec) port min/max, and use horizontal separators,
2350 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2352 * src/maemo/easysetup/modest-easysetup-wizard.c:
2353 (set_default_custom_servernames):
2354 * src/maemo/modest-account-settings-dialog.c:
2355 (create_page_incoming), (on_combo_outgoing_security_changed),
2356 (on_combo_incoming_security_changed), (create_page_outgoing),
2357 (modest_account_settings_dialog_set_account_name),
2358 (save_configuration):
2359 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2360 (on_combo_security_changed),
2361 (modest_connection_specific_smtp_edit_window_init),
2362 (modest_connection_specific_smtp_edit_window_set_connection),
2363 (modest_connection_specific_smtp_edit_window_get_settings):
2364 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2367 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2370 * src/maemo/easysetup/modest-easysetup-wizard.c:
2371 (create_page_custom_outgoing), (create_page_complete_custom):
2372 * src/maemo/modest-account-settings-dialog.c:
2373 (create_page_user_details), (create_page_outgoing):
2374 * src/maemo/modest-account-view-window.c: (button_box_new):
2375 Use changed logical IDs as per the most recent UI spec:
2376 mcen_bd_emailsetup_edit -> mcen_bd_edit
2377 mcen_bd_emailsetup_delete -> mcen_bd_delete
2378 mcen_bd_emailsetup_close -> mcen_bd_close
2380 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2384 * src/dbus_api/Makefile.am:
2385 * src/dbus_api/modest-dbus-callbacks.c:
2386 * src/dbus_api/modest-dbus-callbacks.h:
2387 * src/maemo/modest-platform.c: (modest_platform_init):
2388 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2390 * tests/Makefile.am:
2391 * tests/dbus_api/Makefile.am:
2392 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2394 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2396 * src/maemo/modest-account-settings-dialog.c:
2397 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2398 Removed unnecessary includes.
2400 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2402 * src/maemo/easysetup/modest-easysetup-wizard.c:
2403 * src/maemo/modest-account-settings-dialog.c:
2404 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2405 * src/widgets/Makefile.am:
2406 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2407 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2408 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2409 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2410 * src/widgets/modest-secureauth-combo-box.c:
2411 * src/widgets/modest-secureauth-combo-box.h:
2412 * src/widgets/modest-serversecurity-combo-box.c:
2413 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2414 made the GObject names more consistent with the rest of the Modest code.
2416 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2418 * src/maemo/easysetup/Makefile.am:
2419 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2420 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2421 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2422 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2423 * src/maemo/easysetup/modest-easysetup-wizard.c:
2424 * src/maemo/easysetup/modest-validating-entry.c:
2425 * src/maemo/easysetup/modest-validating-entry.h:
2426 * src/maemo/modest-account-settings-dialog.c:
2427 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2428 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2429 widgets/ because they are used outside of easysetup too. After checking in,
2430 svn will allow me to rename them too.
2432 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2434 * src/gnome/modest-msg-edit-window.c:
2435 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2436 linker error, to fix the build on the GNOME platform.
2437 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2438 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2439 ifdefed out to avoid a warning.
2441 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2443 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2444 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2445 some alternative for GTK+ 2.6.
2447 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2449 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2451 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2452 specified for EmailAccountsDialog in UI spec.
2454 * src/maemo/easysetup/modest-easysetup-wizard.c:
2455 * src/maemo/easysetup/modest-easysetup-wizard.h:
2456 * src/maemo/modest-account-settings-dialog.c:
2457 * src/maemo/modest-account-settings-dialog.h:
2458 Reuse a member window widget for the connection-specific SMTP server accounts,
2459 so we can tell it to create/save the accounts only if we actually save changes.
2461 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2462 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2463 (modest_connection_specific_smtp_edit_window_get_settings):
2464 Return a struct instance for temporarily remembering the entered data.
2466 * src/maemo/modest-connection-specific-smtp-window.h:
2467 * src/maemo/modest-connection-specific-smtp-window.c:
2468 (modest_connection_specific_smtp_window_finalize),
2469 (modest_connection_specific_smtp_window_fill_with_connections),
2471 (modest_connection_specific_smtp_window_save_server_accounts),
2472 (update_model_server_names): Do not actually save data until asked,
2473 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2475 (on_selection_changed),
2476 (modest_connection_specific_smtp_window_init): Disable the edit
2477 button when nothing is selected.
2479 * src/modest-account-mgr-helpers.c:
2480 * src/modest-account-mgr-helpers.h:
2481 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2484 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2486 * src/modest-account-mgr-helpers.h:
2487 * src/modest-account-mgr-helpers.c:
2488 (modest_account_mgr_get_unused_account_name),
2489 (modest_account_mgr_get_unused_account_display_name): Added these
2490 utility functions, to avoid code duplication.
2492 * src/maemo/easysetup/modest-easysetup-wizard.c:
2493 (create_page_account_details), (create_account):
2494 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2495 (on_combo_security_changed),
2496 (modest_connection_specific_smtp_edit_window_init),
2497 (modest_connection_specific_smtp_edit_window_save_settings):
2498 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2499 * src/maemo/modest-connection-specific-smtp-window.c:
2500 (modest_connection_specific_smtp_window_finalize),
2501 (modest_connection_specific_smtp_window_fill_with_connections),
2502 (on_button_edit), (modest_connection_specific_smtp_window_init):
2503 * src/maemo/modest-connection-specific-smtp-window.h:
2504 Implementing saving of connection-specific server accounts.
2506 But I need to refactor this so we can save the data for each
2507 possible connection-specific account and only actually create the server accounts
2508 when the easysetup finished, or the OK button is pressed on the account settings
2511 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2513 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2514 (on_combo_security_changed):
2515 (modest_connection_specific_smtp_edit_window_init):
2516 Auto-fill the port number as in the account settings.
2518 (modest_connection_specific_smtp_edit_window_set_connection):
2519 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2520 * src/maemo/modest-connection-specific-smtp-window.c:
2521 (fill_with_connections), (on_button_edit),
2522 (modest_connection_specific_smtp_window_init):
2523 Turn the edit window into a dialog to simplify the code, and
2524 set a WM hint as in a GtkDialog, because only a popup can be on top of
2525 another window in Maemo, and popups usually have no WM decoration.
2527 * src/modest-defs.h:
2528 * src/modest-account-mgr-helpers.c:
2529 (modest_account_mgr_set_connection_specific_smtp),
2530 (modest_account_mgr_remove_connection_specific_smtp),
2531 (modest_account_mgr_get_connection_specific_smtp):
2532 * src/modest-account-mgr-helpers.h: Some functions to write the
2533 connection-specific SMTP server information. Not yet used.
2536 * src/widgets/modest-folder-view.c: (text_cell_data):
2537 Fix a warning about an uninitialized variable.
2538 (on_configuration_key_changed): Put an #ifdef around the use
2539 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2541 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2543 * src/maemo/modest-account-settings-dialog.h:
2544 * src/maemo/modest-account-settings-dialog.c:
2545 Added connect_for_modified() utility function to mark the new modified boolean.
2547 (create_page_account_details), (create_page_user_details),
2548 (create_page_incoming), (create_page_outgoing), (on_response),
2549 (modest_account_settings_dialog_init),
2550 (modest_account_settings_dialog_set_account_name):
2551 Only warn about unsaved changes when there are actually unsaved changes.
2553 * src/modest-account-mgr-helpers.c:
2554 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2555 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2556 to get the data from there in future.
2558 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2560 * src/modest-defs.h:
2562 * src/modest-account-mgr-helpers.h:
2563 * src/modest-account-mgr-helpers.c:
2564 Store the security account setting in a single conf key instead of using
2565 the options list, so that the list is left for just the to-be-removed camel hack,
2566 and because gconf_client_set_list() is failing for some reason.
2568 * src/modest-account-mgr.c:
2569 (modest_account_mgr_add_server_account):
2570 * src/maemo/modest-account-settings-dialog.c:
2571 (modest_account_settings_dialog_set_account_name),
2572 (save_configuration): Use the renamed functions.
2575 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2577 * src/widgets/Makefile.am:
2578 * src/widgets/modest-limit-retrieve-combo-box.c:
2579 * src/widgets/modest-limit-retrieve-combo-box.h:
2580 * src/widgets/modest-retrieve-combo-box.c:
2581 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2582 the account settings dialog.
2584 * src/modest-defs.h:
2585 * src/modest-account-mgr-helpers.h:
2586 * src/modest-account-mgr-helpers.c:
2587 (modest_server_account_get_option_secure_auth),
2588 (modest_server_account_set_option_secure_auth):
2589 * src/modest-account-mgr.c:
2590 (modest_account_mgr_add_server_account):
2591 Use the existing AUTH_MECH conf key for the secure-auth setting,
2592 instead of putting it in the list options, because this was actually used already.
2594 * src/maemo/modest-account-settings-dialog.c:
2595 (create_page_account_details),
2596 (modest_account_settings_dialog_set_account_name),
2597 (save_configuration):
2598 * src/maemo/modest-account-settings-dialog.h:
2599 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2600 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2602 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2604 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2605 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2606 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2608 * src/modest-defs.h:
2609 * src/maemo/modest-account-settings-dialog.c:
2610 (create_page_incoming), (on_combo_outgoing_security_changed),
2611 (on_combo_incoming_security_changed), (create_page_outgoing),
2612 (modest_account_settings_dialog_set_account_name),
2613 (save_configuration): Load/Save the port number, and change it when the
2614 security combo changes, to suitable defaults.
2616 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2618 * src/modest-account-mgr.c:
2619 (modest_account_mgr_add_server_account): Set the security and secure-auth
2620 options, and add a comment saying that the other camel-specific options should be
2623 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2625 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2627 * src/modest-tny-account-store.c: (account_list_free),
2628 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2629 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2632 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2634 * src/modest-protocol-info.c:
2635 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2636 is required by our UI spec. Maybe something in our implementation will use this eventually.
2637 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2638 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2639 instead of the previous 0 placeholder.
2641 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2642 secure-auth settings.
2643 * src/modest-account-mgr-helpers.h:
2644 * src/modest-account-mgr-helpers.c:
2645 (modest_server_account_data_get_option_secure_auth),
2646 (modest_server_account_set_option_secure_auth),
2647 (modest_server_account_data_get_option_security),
2648 (modest_server_account_set_option_security): Added this API for getting and setting the security
2649 and secure-auth settings.
2651 * src/maemo/modest-account-settings-dialog.h:
2652 * src/maemo/modest-account-settings-dialog.c:
2653 (modest_account_settings_dialog_finalize), (check_data),
2654 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2655 about changing titles.
2656 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2657 (save_configuration): Save the security and secure-auth settings.
2659 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2660 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2662 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2664 * src/modest-defs.h:
2665 * src/modest-account-mgr.c:
2666 (modest_account_mgr_add_server_account):
2667 Added and used defines for the options key and value pair strings,
2668 that are used so far, though they do not seem to correspond to anything in our
2669 UI specs or ModestProtocol enum.
2671 * src/modest-account-mgr-helpers.h:
2672 * src/modest-account-mgr-helpers.c:
2673 (compare_option_strings_for_name),
2674 (modest_server_account_data_get_option_value),
2675 (modest_server_account_data_get_option_bool),
2676 (modest_account_mgr_get_server_account_option):
2677 Added helper functions for parsing the options GSList.
2679 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2681 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2682 display name is based on the supplied account name.
2683 * src/modest-account-mgr.c:
2684 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2685 with an inefficient, but good-enough, implementation.
2687 * src/maemo/easysetup/modest-easysetup-wizard.c:
2688 (create_page_account_details), (on_before_next), (create_account):
2689 Check for existing display names rather than (non-user-visible) account names, and just
2690 create and set a unique account name at the end.
2692 * src/maemo/modest-account-settings-dialog.c:
2693 (modest_account_settings_dialog_init),
2694 (modest_account_settings_dialog_set_account_name),
2695 (create_page_incoming): Show the display name, instead of the account name.
2696 (on_response): Do some (not all) extra checks, as in the UI spec.
2697 (save_configuration): Save the display name if it was changed.
2699 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2701 * po/en_GB.po: Added needed logical ID and translation.
2702 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2703 (init_view): Made the is-default column clicking work.
2705 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2708 * src/maemo/easysetup/Makefile.am:
2709 * src/maemo/easysetup/modest-easysetup-wizard.c:
2710 (modest_easysetup_wizard_dialog_init):
2711 * src/maemo/easysetup/provider-data-test.keyfile:
2712 * src/maemo/easysetup/provider-data.keyfile:
2713 Moved the provider data file to the new modest-providers-data package and used it from there.
2715 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2717 * src/modest-local-folder-info.c:
2718 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2719 N_() was already used on the static strings, but this just marks it for translation without
2720 using the translation.
2722 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2724 * src/maemo/modest-account-settings-dialog.c:
2725 (create_page_incoming),
2726 (modest_account_settings_dialog_set_account_name):
2727 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2728 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2729 I will do this if nobody else gets there first.
2731 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2733 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2734 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2735 save the security stuff.
2737 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2739 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2740 Set the email address and user fullname, which I now see must be
2743 * src/maemo/modest-account-settings-dialog.h:
2744 * src/maemo/modest-account-settings-dialog.c:
2746 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2747 leave-on-server and authentication.
2748 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2751 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2754 * src/maemo/modest-account-settings-dialog.c:
2755 * src/maemo/modest-account-settings-dialog.h:
2756 Most (but not all) of the widgets are now present as specified by the UI spec.
2757 No changes are yet saved, and some details are not properly shown yet.
2759 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2761 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2763 * src/maemo/Makefile.am:
2764 * src/maemo/modest-account-settings-dialog.c:
2765 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2766 an existing account. Doesn't do much yet.
2768 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2769 Open the accounts settings dialog when Edit is clicked.
2771 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2773 * src/maemo/easysetup/Makefile.am:
2774 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2776 * src/maemo/easysetup/modest-easysetup-wizard.c:
2777 (modest_easysetup_wizard_dialog_init):
2778 Try to get the source directory from the build system,
2779 instead of hard-coding "./" into the source code, when opening our local
2780 copies of the configuration files.
2781 But this still fails when opening the wizard from the Accounts window,
2782 maybe because the working directory seems to change at runtime.
2783 So the wizard will fail the second time unless you copy the files into their
2784 proper locations - see the stdout warnings for the paths.
2786 (create_page_account_details),(on_before_next):
2787 Check for existing non-server accounts instead of server accounts,
2788 so the default account name is useful again, and to prevent trying to
2791 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2792 Show the wizard when New is clicked.
2794 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2795 (init_view): Show the column headers, and show the columns that are
2796 specified in the UI specs. However, something in Maemo's GTK+ prevents
2797 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2798 change the default account. This is despite unsetting the special properties.
2800 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2802 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2803 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2804 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2805 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2806 to make that clearer.
2807 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2809 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/modest-account-view-window.c:
2812 (modest_account_view_window_init),
2813 (modest_account_view_window_new):
2814 Use the same buttons as specified in the
2815 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2816 the existing widgets, which never had a chance of working.
2817 Put the ModestAccountView treeview in a scrolled window.
2818 Do not repeat the initialization in both _init() and _new().
2820 * src/widgets/modest-account-view.c: (update_account_view):
2821 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2822 this widget and window shows no accounts.
2824 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2826 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2828 * src/maemo/easysetup/modest-easysetup-wizard.c:
2829 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2830 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2831 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2834 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2835 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2836 accounts exist yet, as in the UI spec.
2838 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2840 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2842 * src/maemo/Makefile.am:
2843 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2844 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2845 New window for editing connection-specific smtp details.
2846 Not fully implemented.
2848 * src/maemo/modest-connection-specific-smtp-window.c:
2849 (modest_connection_specific_smtp_window_finalize) :
2850 unref the tree model.
2851 (on_button_edit): Show the edit window.
2853 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2855 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2858 * src/maemo/Makefile.am:
2859 * src/maemo/modest-connection-specific-smtp-window.c:
2860 * src/maemo/modest-connection-specific-smtp-window.h:
2861 New window for showing the list of connections, for connection-specific
2862 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2863 * src/maemo/easysetup/modest-easysetup-wizard.c:
2864 (create_page_custom_outgoing): Show the new window when the button is clicked.
2866 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2868 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2869 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2870 * src/maemo/modest-msg-edit-window.c:
2871 (modest_msg_edit_window_insert_image):
2872 * src/modest-conf.c: (modest_conf_key_escape):
2873 * src/modest-mail-operation.c:
2874 (modest_mail_operation_send_new_mail):
2875 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2876 (modest_ui_actions_on_new_account):
2877 * src/widgets/modest-attachment-view.c: (update_filename_request):
2878 * src/widgets/modest-mail-header-view.c:
2879 Corrected warnings that were breaking the build, by commenting out unused variables,
2880 and a function, and by including a header.
2882 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2884 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2885 so we can #ifdef around platform-specific code when necessary.
2886 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2887 to allow this to build for the GNOME platform too.
2889 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2891 * src/maemo/easysetup/modest-easysetup-wizard.c:
2892 Added util_increment_name() and used it in create_page_account_details()
2893 to make sure that the default account name is always a new name.
2895 (modest_easysetup_wizard_dialog_init),
2896 (set_default_custom_servernames): Some minor memory management fixes.
2898 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2902 * src/modest-runtime.c: (init_i18n): Restored the translation
2903 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2904 are defined in config.h, and the translations are installed.
2906 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2907 is defined for translation.
2909 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2911 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2913 * src/maemo/easysetup/modest-easysetup-wizard.c:
2914 (modest_easysetup_wizard_dialog_init):
2915 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2916 Use realistic paths (though they should use $prefix generically) to the
2917 mcc_mapping and provider-data.keyfile files which might work when they
2918 are installed by the future version of the operator-wizard package,
2919 and then fallback to paths in our source code, with an explanatory
2922 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2926 * src/maemo/Makefile.am:
2927 * src/maemo/easysetup/: Added files from the previously-exernal
2928 osso-modest-easysetup.
2929 * src/maemo/modest-main-window-ui.h:
2930 * src/modest-ui-actions.c:
2931 * src/modest-ui-actions.h:
2932 Added modest_ui_actions_on_new_account() as a signal handler for the
2933 New Account menu item. It shows the easysetup wizard.
2934 * po/en_GB.po: Added additional needed logical IDs and translations.
2936 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2937 Apparently ChangeLog is not used for some vague Nokia legal reasons.