1 2007-06-05 Christian Kellner <ckellner@openismus.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 (libmodest_dbus_client_search):
5 Initialize hit list with NULL. Also set folder list
6 to "" if NULL was supplied.
9 2007-06-03 Christian Kellner <ckellner@openismus.com>
11 * libmodest-dbus-client/libmodest-dbus-client.c:
12 (modest_search_hit_list_free):
13 Make it save to call it with NULL.
15 * src/dbus_api/modest-dbus-callbacks.c:
16 * src/modest-search.c:
17 Return full ModestSearchHits as the search result list not TnyHeader
18 since can't be around withouth the correspoding TnyFolder.
20 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
22 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
23 Added currently commented code to check for secure auth
25 * src/maemo/modest-account-settings-dialog.c: (on_response),
26 (save_configuration), (show_ok):
27 Fixed projects.maemo.org bugs NB #59248 and #59251
29 * src/maemo/modest-maemo-utils.c:
30 (on_camel_account_get_supported_secure_authentication_status),
31 (on_camel_account_get_supported_secure_authentication),
32 (modest_maemo_utils_get_supported_secure_authentication_methods):
33 * src/maemo/modest-maemo-utils.h:
34 Moved get_supported_secure_authentication() method here to be able
35 to use it from easysetup wizard.
37 * src/modest-pair.c: (on_pair_compare_as_string):
38 Should compare string with first part of pair and not
39 strcmp pairs which will crash.
41 * src/modest-protocol-info.c:
42 (modest_protocol_info_protocol_is_store):
43 * src/modest-protocol-info.h:
44 Added modest_protocol_info_get_auth_protocol_name()
46 2007-06-03 Armin Burgmeier <armin@openismus.com>
48 * src/modest-mail-operation.c:
49 (modest_mail_operation_get_msgs_full): Set priv->account also when
50 only retrieving a single message. This avoids a crash when canceling
53 (modest_mail_operation_notify_end): Do not explicitely remove the
54 operation from the queue but only emit the progress_changed signal.
55 The queue itself listens to that signal to remove the operation when
56 it is finished. This reduces coupling and removes a potential deadlock
57 when modest_mail_operation_notify_end() is called from the queue
58 itself. If that is a problem performance-wise, I would suggest to
59 implement a status-changed signal or something.
61 * src/modest-mail-operation-queue.c: Make sure to never call a
62 function from another file while the queue is locked. This (hopefully)
63 fixes another deadlock when exiting the application while retrieving
66 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
68 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
69 Fixed build if libogs is not available
71 2007-06-03 Christian Kellner <ckellner@openismus.com>
73 * libmodest-dbus-client/libmodest-dbus-client.h:
74 * libmodest-dbus-client/libmodest-dbus-client.c:
75 (libmodest_dbus_client_delete_message):
76 Implement deletion of messages (Client side).
78 (modest_search_hit_free),
79 (modest_search_hit_list_free):
80 Utility functions to free the result hits.
82 * src/dbus_api/modest-dbus-api.h:
83 * src/dbus_api/modest-dbus-callbacks.c:
85 (modest_dbus_req_handler):
86 Implement deletion of messages (Server side).
88 * tests/dbus_api/test_search.c: (main):
91 * tests/dbus_api/Makefile.am:
92 * tests/dbus_api/test_delete_message:
93 Add little test for the message deletion logic
95 2007-06-03 Armin Burgmeier <armin@openismus.com>
97 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
98 when the operation queue was not empty. projects.maemo.org bug
101 2007-06-03 Armin Burgmeier <armin@openismus.com>
103 * src/widgets/modest-account-view.c
104 (on_account_default_toggled): Toggle default account column
105 explicitely instead of waiting for gconf notification (which is
106 currently ignored). This should fix projects.maemo.org bug NB#56910
107 for now. It should probably be removed when gconf notifications are
110 2007-06-03 Christian Kellner <ckellner@openismus.com>
112 * libmodest-dbus-client/libmodest-dbus-client.c:
113 Removed debugging spew.
115 * src/dbus_api/modest-dbus-callbacks.c:
116 Added debugging info.
118 * src/modest-search.c:
119 (modest_search_all_accounts):
120 Use tny_account_store_get_accounts () on the account store
121 to get all accounts which is the way to get all accounts.
123 * tests/dbus_api/test_search.c: (main):
124 Make it possible to supply the search term on the command line.
126 2007-06-03 Christian Kellner <ckellner@openismus.com>
128 * libmodest-dbus-client/libmodest-dbus-client.c:
129 * libmodest-dbus-client/libmodest-dbus-client.h:
130 Implement searching for mesages over raw dbus. (Client side)
132 * src/dbus_api/Makefile.am:
133 * src/dbus_api/modest-dbus-api.h:
134 * src/dbus_api/modest-dbus-callbacks.c:
135 * src/dbus_api/modest-dbus-callbacks.h:
136 Search framework (Server side). Also implement on_idle_open_message().
138 * src/maemo/modest-platform.c: (modest_platform_init):
139 Prepare for raw dbus/osso rpc interaction.
141 * src/modest-search.h:
142 Changed minsize from unspecific guint to guint32.
144 * src/modest-search.c:
146 Added strange hack which magically made tnymail work.
148 (modest_search_folder),
149 (modest_search_account),
150 (modest_search_all_accounts):
151 Implement helper functions to search all accounts, specific account
154 * tests/dbus_api/Makefile.am:
155 * tests/dbus_api/test_open_message.c:
156 Read url to open from commandline.
158 * tests/dbus_api/test_search.c:
159 Implement small test for dbus search stuff
161 2007-06-02 Armin Burgmeier <armin@openismus.com>
163 * src/maemo/modest-account-settings-dialog.c: Changed window title to
164 include account type and account title. This fixes projects.maemo.org
167 * src/maemo/modest-account-view-window.c: Set a title for the window.
169 2007-06-02 Armin Burgmeier <armin@openismus.com>
171 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
172 incoming and outgoing server name based on email address and server
173 types as long as the names have not been edited manually. This fixes
174 projects.maemo.org bug NB#58671.
176 2007-06-02 Armin Burgmeier <armin@openismus.com>
178 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
179 server type cannot be changed in future to the incoming details page
180 when creating an account. This fixes projects.maemo.org bug NB#59029.
182 2007-06-02 Armin Burgmeier <armin@openismus.com>
184 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
185 and assigned max width chars so that they wrap instead of being
186 truncated. Fixes projects.maemo.org bug NB#56126.
188 2007-06-02 Armin Burgmeier <armin@openismus.com>
190 * src/maemo/modest-connection-specific-smtp-window.c: Add an
191 introductory note to the connection specific smtp servers dialog, as
192 section 8.12 of the email UI specification requires. This fixes
193 projects.maemo.org bug NB#59212.
195 2007-06-01 Murray Cumming <murrayc@murrayc.com>
197 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
198 Check for running mail operations, and offer to cancel them, as per the UI
199 spec. This fixes projects.maemo.org bug NB#59041 .
200 However, I suspect that tinymail may still use the network connection
201 in ways that we cannot detect or cancel. But it should at least adapt to
204 2007-06-01 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-tny-account-store.c: (recreate_all_accounts),
207 (get_cached_accounts), (get_server_accounts): Do more sensible
208 ref-counting of the temporarily-cached outbox accounts list. This seems
209 to fix a crash when entering the password when the password was wrong.
211 2007-06-01 Murray Cumming <murrayc@murrayc.com>
213 * src/gnome/modest-main-window.c: (connect_signals):
214 * src/modest-tny-account-store.c: (get_password),
215 (modest_tny_account_store_alert): Added comments and clues and
216 commented-out code about how we currently fail to deal with connection
217 errors and wrong passwords, and how we should.
219 2007-06-01 Murray Cumming <murrayc@murrayc.com>
221 * src/widgets/modest-retrieve-combo-box.c:
222 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
223 This fixes projects.maemo.org bug NB#58472 .
225 2007-06-01 Murray Cumming <murrayc@murrayc.com>
227 * src/maemo/easysetup/modest-easysetup-wizard.c:
228 (create_page_complete_easysetup):
229 (create_page_complete_custom): Correct the last commit,
230 putting the correct sentences in the correct pages.
232 2007-06-01 Murray Cumming <murrayc@murrayc.com>
234 * src/maemo/easysetup/modest-easysetup-wizard.c:
235 (create_page_complete_custom): Show the second sentence of text
236 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
239 2007-06-01 Murray Cumming <murrayc@murrayc.com>
241 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
242 Set the leave-on-server conf key by default. This fixes
243 projects.maemo.org bug NB#59258 .
245 2007-06-01 Murray Cumming <murrayc@murrayc.com>
247 * src/maemo/modest-account-view-window.c:
248 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
249 logical ID for the confirmation messages. Fixed projects.maemo.org bug
252 2007-06-01 Murray Cumming <murrayc@murrayc.com>
254 * src/maemo/easysetup/modest-easysetup-wizard.c:
255 (create_caption_new_with_asterisk):
256 * src/maemo/modest-account-settings-dialog.c:
257 (create_caption_new_with_asterisk):
258 Uncomment the code to add the asterisk, because they are no longer in the
259 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
260 (update_incoming_server_title): Add an asterisk here too.
262 2007-06-01 Murray Cumming <murrayc@murrayc.com>
264 * src/maemo/modest-maemo-global-settings-dialog.c:
265 (current_connection): Check that we are even connected before trying to
266 get the current connection name, to prevent a warning.
268 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
269 Change the comments because tny_maemo_conic_device_connect() is now meant to
271 * src/modest-mail-operation.c:
272 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
273 make sure we have a connection and fail if we can't connect.
275 2007-05-31 Murray Cumming <murrayc@murrayc.com>
277 * src/maemo/modest-main-window.c:
278 (on_account_store_connecting_finished): Do not try to get the
279 connection ID if we are not really connected. I am surprised that
280 this signal handler is called when we are not connected.
282 2007-05-31 Murray Cumming <murrayc@murrayc.com>
284 * src/modest-error.h:
285 * src/modest-ui-actions.c:
286 (modest_ui_actions_get_msgs_full_error_handler):
287 Renamed an enum, added comments, added an enum
288 for retrieve-limit errors.
290 * src/modest-mail-operation.c: (foreach_add_item),
291 (internal_folder_observer_update), (update_account_thread),
292 (modest_mail_operation_get_msgs_full):
293 (modest_mail_operation_update_account),
294 Added comments about how this works, and some code that should
295 (but does not) check the retrieve-limit. See the TODO comment.
297 2007-05-31 Murray Cumming <murrayc@murrayc.com>
299 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
300 Initialize help_id to fix the build. Warnings are good.
302 2007-05-31 Murray Cumming <murrayc@murrayc.com>
304 * src/widgets/modest-hbox-cell-renderer.c:
305 (modest_hbox_cell_renderer_append):
306 * src/widgets/modest-vbox-cell-renderer.c:
307 (modest_vbox_cell_renderer_append):
308 Fix the last commit by doing an extra ref.
310 2007-05-31 Murray Cumming <murrayc@murrayc.com>
312 * src/widgets/modest-hbox-cell-renderer.c:
313 (modest_hbox_cell_renderer_append):
314 * src/widgets/modest-vbox-cell-renderer.c:
315 (modest_vbox_cell_renderer_append):
316 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
317 to fix the build with Maemo Bora.
318 However, there seems to be a remaining crash, probably due to reference
321 2007-05-30 Murray Cumming <murrayc@murrayc.com>
323 * src/modest-tny-account.c:
324 (modest_tny_account_new_for_local_folders):
325 Use hildon_file_system_info_async_new() to get a better name for
326 the memory card account, setting it as the account name.
327 The timing seems to work, but this is probably
328 not the best place to do this. See the TODO comment.
329 * src/maemo/modest-main-window.c: (create_details_widget):
330 * src/widgets/modest-folder-view.c: (text_cell_data):
331 Use the tny account name instead of hardcoding a name.
333 2007-05-30 Christian Kellner <ckellner@openismus.com>
335 * src/modest-search.c: (modest_search):
336 Correctly set part_search_func even if we have already parsed
337 the query and thus a valid OgsTextSearcher object.
339 2007-05-30 Christian Kellner <ckellner@openismus.com>
342 Search and check for libogs.
345 Incooparte the ogs build env.
347 * src/modest-mime-part-search-stream.c:
348 * src/modest-mime-part-search-stream.h:
349 Removed since we do the real searching now in modest-search.c.
351 * src/modest-search.c:
352 * src/modest-search.h:
353 Implement support for ogs. We use that if available and requested
354 and fall back to modest_text_utils_utf8_strcmp (). The search logic
355 should now handle the corner case when the search term is spread
356 across multiple reads.
357 Also the logic in modest_search () was corrected to search all
358 requested fields until one is found.
360 2007-05-30 Murray Cumming <murrayc@murrayc.com>
362 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
365 * src/modest-init.c: Made modest_init_local_folders() take a
366 path and be public so we can iniitialize maildir folders on
369 * src/modest-local-folder-info.h:
370 * src/modest-local-folder-info.c:
371 (modest_local_folder_info_get_maildir_path): Add a path parameter.
373 * src/modest-tny-account.c:
374 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
375 still means the standard local-folders path on the local volume.
377 * src/modest-tny-account-store.c:
378 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
379 signal so we can detect mount/unmount of the MMC1 card, and do an update of
380 all accounts when that happens.
381 (get_server_accounts): If the MMC1 card is mounted, create a store account for
382 this too, so it shows up in the treeview.
384 2007-05-28 Murray Cumming <murrayc@murrayc.com>
386 * src/maemo/modest-maemo-global-settings-dialog.c:
387 (current_connection):
388 * src/widgets/modest-global-settings-dialog.c:
389 (current_connection_default):
390 Use the enum values instead of 0, 1 and -1,
391 to make the code clearer.
393 * src/modest-account-mgr-helpers.c:
394 (modest_account_mgr_get_connection_specific_smtp): Make this code
397 * src/modest-runtime.h:
398 * src/modest-runtime.c:
399 Added modest_runtime_remove_all_send_queues().
400 * src/maemo/modest-main-window.c:
401 (on_account_store_connecting_finished): Recreate the send queues,
402 using the appropriate transport accounts for this new connection.
403 Some futher adapting might be needed if the old send queues are not
404 automatically stopped at this point.
406 * src/modest-tny-account-store.c: (get_server_accounts):
407 Create the connection-specific transport accounts, so that they can
408 be found later by their ID.
410 * src/modest-tny-account.h:
411 * src/modest-tny-account.c:
412 Added modest_tny_account_new_from_server_account_name().
413 modest_tny_account_new_from_server_account(): Do not create the
414 send queues here, because they will be
415 recreated anyway when the connection changes for the first time.
417 2007-05-28 Murray Cumming <murrayc@murrayc.com>
419 * src/modest-local-folder-info.h:
420 * src/modest-local-folder-info.c:
421 (modest_per_account_local_outbox_folder_info_get_maildir_path),
422 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
423 tbox_folder): Take a modest account name instead of a server TnyAccount,
424 so we can have per-modest-account rather than per-transport-account
426 We must make sure that we change or recreate the exisitng send queues
427 when the connection changes for connection-specific transport accounts.
429 * src/modest-tny-account-store.c:
430 (create_per_account_local_outbox_folders): Create outboxed per modest
431 account, not per transport account.
433 * src/modest-tny-account.h:
434 * src/modest-tny-account.c:
435 (modest_tny_account_get_special_folder): For outboxes, get the
436 parent modest account name. The account is ignored for other folders.
437 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
438 modest account name rather than a server TnyAccount.
440 2007-05-25 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-tny-account.c:
443 (modest_tny_account_new_from_server_account):
444 Call modest_runtime_get_send_queue() immediately after creating transport
445 accounts, so that they start trying to send email from the outbox as soon
446 as possible at startup. This is probably what we want.
448 * src/modest-mail-operation.c: (update_account_thread):
449 * src/modest-runtime.c: (modest_runtime_get_send_queue):
450 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
451 * src/modest-tny-send-queue.h:
452 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
453 (modest_ui_actions_on_send):
454 Added comments about how sending works, though it needs some more work.
456 2007-05-25 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-tny-account.c:
459 (modest_tny_account_get_special_folder): Add TODO because this fails when
461 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
462 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
463 Do not try to show this window when there is no active account. The UI
464 specs does not tell us what to do in this case.
466 2007-05-24 Murray Cumming <murrayc@murrayc.com>
470 * src/maemo/Makefile.am:
471 * src/widgets/Makefile.am: Some dist fixes.
473 2007-05-24 Murray Cumming <murrayc@murrayc.com>
475 * src/maemo/modest-connection-specific-smtp-window.c:
476 (on_button_edit): Make the code clearer, to prevent a double free.
478 2007-05-24 Murray Cumming <murrayc@murrayc.com>
480 * src/maemo/modest-account-settings-dialog.c:
481 (modest_account_settings_dialog_set_account_name),
482 Check the connection-specific smtp servers checkbox if there are any.
484 * src/maemo/modest-connection-specific-smtp-edit-window.c:
485 (modest_connection_specific_smtp_edit_window_init):
486 Start with a suitable port number.
488 * src/modest-account-mgr-helpers.h:
489 * src/modest-account-mgr-helpers.c: Added
490 modest_account_mgr_get_has_connection_specific_smtp().
492 (modest_account_mgr_set_connection_specific_smtp),
493 (modest_account_mgr_remove_connection_specific_smtp),
494 (modest_account_mgr_get_has_connection_specific_smtp),
495 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
496 connection-specific smtp server accounts in the account, rather than
497 the server account conf dir.
499 This fixes bug projects.maemo.org bug NB#58263 .
501 * src/modest-tny-account-store.c:
502 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
503 if there are no server accounts yet, to prevent an infinite loop when there
504 are no accounts. Document that one must be called before the other.
506 2007-05-24 Murray Cumming <murrayc@murrayc.com>
508 * src/modest-account-mgr-helpers.c:
509 (modest_account_mgr_get_default_account): Make sure that at least
510 one account is always the default, if there are any enabled accounts.
511 This is just a sanity check that shouldn't be necessary.
513 * src/modest-account-mgr-priv.c:
514 (_modest_account_mgr_account_from_key): Unescape the conf key to
515 get the real account name. For instance, this is an issue if a space
516 was in the account name, which can happen because the account name
517 is generated from the display name.
518 (_modest_account_mgr_get_account_keyname): Always escape the
520 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
521 Unescape the conf keys to get the real account names.
523 For instance, previously the is-default radio button in the accounts
524 list was not checked for any accounts at first. This fixes that,
525 and might fix several similar bugs.
527 2007-05-23 Murray Cumming <murrayc@murrayc.com>
529 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
530 Removed some debug printfs.
532 2007-05-23 Murray Cumming <murrayc@murrayc.com>
534 Modest on-disk outbox directories are now here, for instance:
535 $HOME/.modest/outboxes/<account-id-1>/outbox
536 $HOME/.modest/outboxes/<account-id-2>/outbox
538 $HOME/.modest/local-folders/outbox
539 so we can have a separate outbox for each account.
540 But they are shown as one outbox in the GtkTreeView, by using a
541 TnyMergeFolder in a ModestTnySimpleFolderStore.
544 * src/modest-tny-simple-folder-store.c:
545 * src/modest-tny-simple-folder-store.h:
546 Added ModestTnySimpleFolderStore, used to contain folders from
547 other folder stores, such as other accounts.
549 * src/modest-tny-outbox-account.h:
550 * src/modest-tny-outbox-account.c:
551 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
552 used for the per-account local outbox folders.
554 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
555 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
556 only use this (internally) now for the non-outbox local folders.
559 * src/modest-init.c: Added modest_init_one_local_folder(), for
560 setting up the directory structure for each local folder.
562 * src/modest-local-folder-info.c:
563 (modest_per_account_local_outbox_folder_info_get_maildir_path),
564 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
566 * src/modest-local-folder-info.h:
567 * src/modest-tny-account-store.c: (on_account_removed),
568 (on_account_changed), (create_per_account_local_outbox_folders),
569 (get_server_accounts), (modest_tny_account_store_get_accounts),
570 (modest_tny_account_store_get_tny_account_by_account),
571 (modest_tny_folder_store_is_virtual_local_folders):
573 * src/modest-tny-account.h:
574 * src/modest-tny-account.c:
575 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
576 to create an on-disk per-account local outbox folder for each
578 (create_per_account_local_outbox_folders): Create a local outbox folder
579 for each transport account.
580 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
581 for all local folders.
583 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
584 instead of using g_object_get/set() directly. It is clearer.
586 (modest_tny_folder_store_get_message_count),
587 (modest_tny_folder_store_get_local_size
588 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
589 because we now use these with non-acount folder stores.
591 (modest_tny_account_get_special_folder),
592 (modest_tny_account_new_from_server_account),
593 (modest_tny_account_new_from_account):
594 (recurse_folders): Adjust to the new outbox system.
596 * src/modest-tny-folder.h:
597 * src/modest-tny-folder.c:
598 (modest_tny_folder_is_local_folder),
599 (modest_tny_folder_get_local_folder_type),
600 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
602 * src/widgets/modest-main-window.h:
603 * src/maemo/modest-main-window.c: (create_details_widget),
604 (modest_main_window_set_contents_style): Show details for any folder store,
607 (modest_tny_folder_get_rules):
608 Remove the const. C does not support constness enough for this.
610 * src/modest-ui-actions.c:
611 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
612 make all outboxes appear as one, in the usual local-folders tree node.
614 (set_active_account_from_tny_account),
615 (modest_ui_actions_on_folder_selection_changed):
616 * src/widgets/modest-folder-view.c: (text_cell_data),
617 (icon_cell_data), (filter_row),
618 (add_account_folders_to_merged_folder),
619 (add_account_folders_to_simple_folder_store), (),
620 (get_cmp_rows_type_pos), (cmp_rows),
621 (modest_folder_view_set_account_id_of_visible_server_account):
622 Adjust to the new outbox system, using generic folder stores and folders
625 2007-05-23 Christian Kellner <ckellner@openismus.com>
627 * src/modest-mail-operation.c:
628 (modest_mail_operation_update_account):
629 Use info->max_size instead of unintialized local var [small
630 build fix]. (Added TODO to review that change since I don't
633 2007-05-23 Marcus Bauer <marcusb@openismus.com>
635 * libmodest-dbus-client/libmodest-dbus-client.c:
636 (libmodest_dbus_client_compose_mail): function added
637 * src/dbus_api/modest-dbus-api.h:
638 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
639 (on_compose_mail): Implementation of the SendAsMail functionality
641 2007-05-22 Murray Cumming <murrayc@murrayc.com>
643 * src/modest-account-mgr.c:
644 (modest_account_mgr_add_server_account): Set the secure-connection
645 conf key for transport accounts as well as store accounts. I don't know
646 why the if was there. For instance, this makes sure that we use SSL
647 for the gmail preset from the easysetup wizard.
649 2007-05-22 Murray Cumming <murrayc@murrayc.com>
651 * src/gnome/modest-main-window.c:
652 (on_account_store_connecting_finished), (connect_signals):
653 * src/maemo/modest-main-window.c:
654 (on_account_store_connecting_finished), (connect_signals),
655 (modest_main_window_new):
656 Handle TnyAccountStore::connecting-finished instead of
657 TnyDevice::connection-changed, because we cannot actually perform
658 operations on accounts until TnyAccountStore has itself responded to
659 the TnyDevice::connection-changed signal. This prevents a GError from
661 Do not try to update at startup, because we (at least on scratchbox)
662 already do an update at startup when the device goes online.
663 This prevents a GError from tinymail.
664 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
665 Added TODO about stopping simultaneous operations.
667 2007-05-21 Murray Cumming <murrayc@murrayc.com>
669 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
670 * src/modest-mail-operation-queue.c:
671 (modest_mail_operation_queue_remove):
672 * src/modest-tny-account-store.c: When GErrors happen, give more clues
673 about where they happened.
675 2007-05-21 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-ui-actions.c:
678 (modest_ui_actions_on_password_requested): Make sure that the remember
679 output parameter is always TRUE.
681 2007-05-21 Murray Cumming <murrayc@murrayc.com>
683 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
684 Show a OK/Cancel dialog if the error is a question, though we still do not
685 know anything more about what we are asking the user.
686 * src/widgets/modest-folder-view.c: (on_drag_data_received):
687 Fix an uninitialized variable (helper). This is a logic error, however.
689 2007-05-21 Christian Kellner <ckellner@openismus.com>
691 * src/modest-search.h:
692 Correct bit shifting in the ModestSearchFlags enum.
694 2007-05-21 Murray Cumming <murrayc@murrayc.com>
696 * src/modest-tny-account.c:
697 (modest_tny_account_new_from_server_account): Do not use the lsub and
698 check-all hard-coded IMAP options when using POP.
700 2007-05-21 Murray Cumming <murrayc@murrayc.com>
702 * src/modest-tny-account.c:
703 (modest_tny_account_new_from_server_account):
704 Use NULL for the secure-auth method for POP when Password auth has been
705 specified by the user, as we already do for IMAP. "auth=Login" causes
706 an error from camel or the server.
708 2007-05-17 Murray Cumming <murrayc@murrayc.com>
710 * src/maemo/modest-account-settings-dialog.c:
711 (create_page_account_details),
712 (modest_account_settings_dialog_set_account_name):
713 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
714 for the leave-on-server checkbox, rathr than just the checkbox, when
715 the protocol is not POP.
717 2007-05-17 Murray Cumming <murrayc@murrayc.com>
719 * src/widgets/modest-account-view.c:
720 * src/widgets/modest-account-view.h:
721 Added modest_account_view_select_account() which will be useful later
722 to asynchronously re-select the edited account.
724 2007-05-17 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/modest-account-settings-dialog.c:
727 (modest_account_settings_dialog_set_account_name):
728 Automatically choose the port numbers based on the secure authentication
729 methods, if they have not been chosen before.
730 This fixes projects.maemo.org bug NB#56273 .
732 2007-05-17 Murray Cumming <murrayc@murrayc.com>
734 * src/maemo/modest-main-window-ui.h:
735 * src/modest-ui-actions.c:
736 * src/modest-ui-actions.h:
737 Connect the Tools/SMTP Servers menu item to
738 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
739 SMTP servers dialog, as in the UI specification and saves changes when it
740 is closed. This fixed projects.maemo.org bug NB#56305 .
742 2007-05-17 Murray Cumming <murrayc@murrayc.com>
744 * src/maemo/modest-connection-specific-smtp-window.c:
745 (modest_connection_specific_smtp_window_init):
746 Use gtk_window_set_default_size() to make this window big enough, so
747 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
749 2007-05-17 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/modest-connection-specific-smtp-edit-window.h:
752 * src/maemo/modest-connection-specific-smtp-edit-window.c:
753 (modest_connection_specific_smtp_edit_window_init),
754 Do not try to connect to a combobox signal before the combobox exists.
755 This fixes the cras in projects.maemo.org bug NB#56288 .
756 (modest_connection_specific_smtp_edit_window_get_settings):
757 Remove the server_account_name parameter which was being checked for NULL
758 though it was not used.
760 * src/maemo/modest-connection-specific-smtp-window.c:
761 (modest_connection_specific_smtp_window_fill_with_connections),
762 (on_button_edit), (modest_connection_specific_smtp_window_init):
763 Correct the number of treemodel columns to prevent a warning.
764 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
765 libconic does not work.
767 2007-05-16 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-tny-account.c:
770 (modest_tny_account_new_from_server_account):
771 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
772 SMTP when "None" was chosen by the user. However, with my SMTP server that
773 does not support ANONYMOUS, the emails do not leave the Outbox and I see
776 2007-05-16 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
779 to explain the memory management issue with the ID in the ModestPair.
781 * src/gnome/modest-account-assistant.c: (add_receiving_page),
782 (add_sending_page), (modest_account_assistant_finalize):
783 * src/gnome/modest-gnome-global-settings-dialog.c:
784 (create_updating_page), (create_composing_page):
785 * src/gnome/modest-msg-edit-window.c: (get_transports),
786 (init_window), (modest_msg_edit_window_finalize),
787 (modest_msg_edit_window_get_msg_data):
788 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
789 * src/gnome/modest-transport-widget.c:
790 (modest_transport_widget_finalize), (smtp_configuration):
791 * src/maemo/modest-maemo-global-settings-dialog.c:
792 (create_updating_page), (create_composing_page):
793 * src/maemo/modest-msg-edit-window.c: (get_transports),
794 (init_window), (modest_msg_edit_window_finalize),
795 (modest_msg_edit_window_get_msg_data),
796 (modest_msg_edit_window_free_msg_data):
797 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
798 (modest_store_widget_finalize):
799 * src/maemo/modest-transport-widget.c:
800 (modest_transport_widget_finalize), (smtp_configuration):
801 * src/modest-main.c: (send_mail):
802 * src/widgets/modest-combo-box.h:
803 * src/widgets/modest-global-settings-dialog-priv.h:
804 * src/widgets/modest-global-settings-dialog.c:
805 (modest_global_settings_dialog_finalize):
806 * src/widgets/modest-msg-edit-window.h:
807 Whenever using modest_combo_box_new(), keep the ModestPairList alive
808 as long as the combo box, to prevent use of freed memory for the ID.
810 2007-05-15 Murray Cumming <murrayc@murrayc.com>
812 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
813 get_accounts(), to make this clearer. Do not check for the enabled gconf
814 key, because we do not use this for server accounts (at least, not yet).
815 This allows us to send email again.
817 2007-05-15 Murray Cumming <murrayc@murrayc.com>
819 * src/maemo/modest-platform.c:
820 (on_modest_conf_update_interval_changed), (modest_platform_init):
821 Only respond to this particular key change. All these strcmp()s cannot be
824 2007-05-15 Murray Cumming <murrayc@murrayc.com>
826 * src/maemo/modest-maemo-global-settings-dialog.c:
827 (current_connection): Prevent a crash in scratchbox when
828 ny_maemo_conic_device_get_current_iap_id() returns NULL.
829 * src/maemo/modest-platform.c:
830 (on_modest_conf_update_interval_changed), (modest_platform_init):
831 Get the update interval from gconf and reset it when the gconf key changes.
833 2007-05-15 Murray Cumming <murrayc@murrayc.com>
835 * src/modest-protocol-info.c:
836 * src/modest-protocol-info.h: Adde enum-specific get functions,
837 instead of using a ModestProtocolType enum parameter.
839 * src/gnome/modest-account-assistant.c:
840 * src/gnome/modest-store-widget.c:
841 * src/gnome/modest-store-widget.h:
842 * src/gnome/modest-transport-widget.c:
843 * src/gnome/modest-transport-widget.h:
844 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
845 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
846 * src/maemo/easysetup/modest-easysetup-wizard.c:
847 * src/maemo/modest-account-settings-dialog.c:
848 * src/maemo/modest-account-settings-dialog.h:
849 * src/maemo/modest-store-widget.c:
850 * src/maemo/modest-store-widget.h:
851 * src/maemo/modest-transport-widget.c:
852 * src/maemo/modest-transport-widget.h:
853 * src/modest-account-mgr-helpers.c:
854 * src/modest-account-mgr-helpers.h:
855 * src/modest-account-mgr.c:
856 * src/modest-account-mgr.h:
857 * src/modest-tny-account.c:
858 * src/modest-tny-folder.c:
859 * src/widgets/modest-account-view.c:
860 * src/widgets/modest-retrieve-combo-box.c:
861 * src/widgets/modest-retrieve-combo-box.h:
862 * src/widgets/modest-secureauth-combo-box.c:
863 * src/widgets/modest-serversecurity-combo-box.c:
864 * src/widgets/modest-serversecurity-combo-box.h:
865 * tests/check_account-mgr.c:
866 Use the specific functions, and use the re-renamed enum values for GNOME too.
868 2007-05-15 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
872 so we can get the second based on the first.
874 * src/maemo/modest-account-settings-dialog.h:
875 * src/maemo/modest-account-settings-dialog.c:
876 Added get_supported_secure_authentication_methods(), though it is mostly
877 commented-out for now until the necessary API is committed to tinymail.
878 (modest_account_settings_dialog_set_account_name),
879 (save_configuration): Request the supported authentication methods from the
880 server, so we can choose a working method.
882 * src/modest-tny-account-store.h:
883 * src/modest-tny-account-store.c:
884 (modest_tny_account_store_get_session): Rename from
885 tny_account_store_get_session().
887 2007-05-14 Murray Cumming <murrayc@murrayc.com>
889 * src/modest-protocol-info.h: Split the ModestProtocol enum
890 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
891 There was no need to have these unrelated values in one enum.
893 * src/: many files: Adapted to changed enum. This makes the code a bit
894 clearer, and the compiler could catch some errors.
896 2007-05-14 Murray Cumming <murrayc@murrayc.com>
898 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
899 Show the detailed internal camel error message when an error happens
900 during the configuration, so that our testers can give us more clues.
901 For instance, in projects.maemo.org bug NB#56910 .
903 2007-05-14 Murray Cumming <murrayc@murrayc.com>
905 * src/modest-tny-account.c:
906 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
907 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
909 2007-05-14 Murray Cumming <murrayc@murrayc.com>
911 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
912 * src/maemo/modest-account-settings-dialog.c:
913 (modest_account_settings_dialog_set_account_name),
914 (save_configuration): For the incoming secure authentication checkbox,
915 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
916 the UI specification. PLAIN does not seem to be supported for most IMAP
917 servers anyway, and I am not sure what it would mean.
918 However, we probably need to discover which of the secure-authentication
919 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
920 * src/modest-account-mgr-helpers.c:
921 (modest_account_mgr_get_server_account_data):
923 * src/modest-tny-account.c:
924 (modest_tny_account_new_from_server_account):
925 Use tny_account_set_mech() to set secure-authentication methods,
926 with some special-casing for IMAP, based on my observations of how
929 * src/modest-account-mgr-helpers.h:
930 * src/modest-account-mgr.c:
931 * src/modest-defs.h: Comment that the URI is only used for local folders.
933 2007-05-11 Murray Cumming <murrayc@murrayc.com>
935 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
936 parameter const, just to be neat.
937 * src/modest-text-utils.c: (modest_text_utils_inline):
938 End g_strconcat() with NULL, as its documentation says. This is almost
939 certainly the cause of my crash at startup on the device. Interestingly,
940 valgrind doesn't tell us about these errors.
942 2007-05-11 Murray Cumming <murrayc@murrayc.com>
944 * scripts/build-packages: Added more precise comments about how to use
945 this script, though I still get this error:
946 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
947 error building tinymail
949 2007-05-11 Murray Cumming <murrayc@murrayc.com>
951 * src/maemo/modest-main-window.c: (on_account_update):
952 Very slight cleanup, hoping to make it simpler to discover what causes
953 a crash here sometimes.
955 * src/modest-tny-account.c:
956 (modest_tny_account_new_from_server_account): Set the port. Added
957 comments about the options and a TODO comment because I need to find out
958 how to specify the secure authentication method.
960 2007-05-11 Marcus Bauer <marcusb@openismus.com>
962 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
963 changed CFlags paths form modest to libmodest
965 2007-05-10 Murray Cumming <murrayc@murrayc.com>
967 * src/modest-account-mgr-helpers.c:
968 (modest_account_mgr_get_server_account_data),
969 (modest_account_mgr_free_server_account_data):
970 * src/modest-account-mgr-helpers.h:
971 * src/modest-account-mgr.c:
972 (modest_account_mgr_add_server_account):
974 * src/modest-tny-account.c:
975 (modest_tny_account_new_from_server_account):
976 Determine the options for tny_camel_account_add_option() here,
977 based on the settings, rather than storing them directly in gconf.
979 2007-05-10 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
982 Show a more friendly error dialog now that we expect (from the tinymail
983 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
985 2007-05-10 Murray Cumming <murrayc@murrayc.com>
987 * src/maemo/modest-main-window.c: (on_account_update): Check that
988 account_name is not NULL, to prevent a crash at startup that I am
989 seeing on the N800. I do wonder why it is NULL.
991 * src/maemo/easysetup/modest-easysetup-wizard.c:
992 (create_page_user_details):
993 * src/maemo/modest-account-settings-dialog.c:
994 (create_page_user_details), (create_page_outgoing):
995 * src/maemo/modest-connection-specific-smtp-edit-window.c:
996 (modest_connection_specific_smtp_edit_window_init):
997 * src/modest-ui-actions.c:
998 (modest_ui_actions_on_password_requested):
999 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1000 might do something useful with the on-screen keyboard.
1002 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1004 * src/maemo/modest-main-window.c: (on_account_update):
1005 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1006 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1008 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-tny-account-store.c: (on_account_changed):
1011 Correct the signature of this signal handler.
1013 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1015 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1016 Show a HildonNote instead of a GtkDialog for Maemo.
1018 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1020 * src/widgets/modest-account-view.h:
1021 * src/widgets/modest-account-view.c: (on_account_changed),
1022 (on_account_removed). Added a boolean flag, set/unset by
1023 modest_account_view_block_conf_updates(),
1024 modest_account_view_unblock_conf_updates() to prevent unnecessary
1025 updates, but this is not very useful because the gconf notifications are
1026 so delays (maybe only on Maemo Bora).
1027 So auto-updating is turned off, and these functions do an explicit
1028 update when necessary.
1029 However, something else is still doing too much work when adding/removing
1030 accounts, probably in another part of the application.
1032 * src/maemo/modest-account-view-window.c:
1033 (on_delete_button_clicked), (on_edit_button_clicked),
1034 (on_new_button_clicked): Use the new functions.
1036 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1038 * src/modest-account-mgr-helpers.c:
1039 (modest_account_mgr_set_first_account_as_default):
1040 Sort the list of names alphabetically-by-title, so we choose the first one
1042 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1043 alphabetically by the title.
1045 This fixes projects.maemo.org bug NB#56418 .
1047 * src/modest-account-mgr-priv.c:
1048 (_modest_account_mgr_account_from_key):
1049 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1050 avoid a valgrind error, and possible random behaviour.
1052 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1054 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1055 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1056 tinymail documentation to say that this can be expected.
1057 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1058 pretty, and should not happen, but I would prefer to know when it does.
1060 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1062 * configure.ac: When using the older hildon version, probably on Bora,
1063 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1065 * src/widgets/modest-attachment-view.c:
1066 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1069 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1071 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1072 Implemented the prototype. Can be tested with
1073 tests/dbus_api/test_open_message:
1075 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-tny-account-store.c:
1078 (modest_tny_account_store_instance_init), (get_password):
1079 * src/modest-ui-actions.c:
1080 (modest_ui_actions_on_password_requested):
1081 Do not store the password in gconf, because this function is called
1082 for non-remembered passwords. Actually use the cached (in the hash map)
1083 password instead of releasing it.
1084 The password will now not be remembered if it is asked via the protected
1085 password dialog, as per the UI spec.
1087 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1089 * src/modest-defs.h:
1090 * src/modest-account-mgr-helpers.h:
1091 * src/modest-account-mgr-helpers.c:
1092 Added modest_server_account_get_username_has_succeeded(),
1093 modest_server_account_set_username_has_succeeded().
1094 (modest_server_account_set_username),
1095 Reset the has-succeeded flag if the username changes.
1097 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1098 * src/maemo/modest-connection-specific-smtp-window.c:
1099 (modest_connection_specific_smtp_window_save_server_accounts):
1100 Use modest_server_account_set_username() instead of using
1101 modest_conf_set_string() directly, so that the has-succeeded flag is always
1104 * src/modest-ui-actions.c:
1105 (modest_ui_actions_on_password_requested): Dim the username entry if
1106 the username has ever worked, as per the UI spec.
1108 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1110 * src/modest-tny-account-store.c: (get_password):
1111 * src/modest-ui-actions.c:
1112 (modest_ui_actions_on_password_requested):
1113 Allow the username to be changed too, though there is more work to
1114 be done on exactly how this behaves.
1116 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1118 * src/modest-account-mgr-helpers.h:
1119 * src/modest-account-mgr-helpers.c:
1120 Added modest_account_mgr_get_display_name(),
1121 modest_server_account_get_username(),
1122 modest_server_account_set_username(),
1123 modest_server_account_set_password(),
1124 modest_server_account_get_hostname() functions so we do not need to
1125 use the conf API directly.
1127 * src/maemo/modest-main-window.c: (connect_signals):
1128 Actually connect ot the ModestAccountStore::request-password signal,
1129 so that we show the dialog when the password is requested by Tinymail,
1130 for isntance if it is empty.
1132 * src/modest-marshal.list:
1133 * src/modest-tny-account-store.c:
1134 (modest_tny_account_store_class_init), (get_password),
1135 (modest_tny_account_store_alert):
1136 * src/modest-tny-account-store.h:
1137 * src/modest-ui-actions.h:
1138 * src/modest-ui-actions.c:
1139 (modest_ui_actions_on_password_requested):
1140 Change the signal parameters, so it is obvious that we are providing
1141 the non human-readable server name, and receiving both the username
1142 and password, though changing of the username is not yet implemented.
1143 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1144 for the GNOME version.
1146 This should fix the projects.maemo.org bug NB#56209, though it does not
1147 work on Bora, because the gconf_client_get() for the password fails
1148 immediately after we save it with gconf_client_set().
1150 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1153 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1154 caused an undefined symbol error:
1155 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1157 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1159 * src/modest-tny-account-store.c:
1160 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1161 using a GError instead of a string message, so we can translate it in
1164 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1166 * src/maemo/modest-address-book.c:
1167 (modest_address_book_check_names):
1168 * src/maemo/modest-msg-view-window.c:
1169 (modest_msg_view_window_clipboard_owner_change):
1170 * src/modest-init.c: (modest_init_init_ui):
1171 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1172 (update_folders_cb), (modest_mail_operation_update_account):
1173 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1174 (modest_ui_actions_on_msg_attachment_clicked),
1175 (modest_ui_actions_on_msg_recpt_activated):
1176 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1177 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1178 (modest_msg_view_search_next):
1179 * src/widgets/modest-recpt-editor.c:
1180 (modest_recpt_editor_on_button_release_event),
1181 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1182 g_message(). At this point we should only be seeing interesting errors on
1183 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1185 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1187 (modest_wizard_dialog_force_title_update):
1188 * src/maemo/easysetup/modest-wizard-dialog.h:
1189 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1190 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1191 can update the title when appropriate. Otherwise the title is wrong if the
1192 pages are added after adding the notebook to the dialog.
1193 This must be a problem in HildonWizardDialog too.
1194 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1196 * src/maemo/easysetup/modest-easysetup-wizard.c:
1197 (create_subsequent_customsetup_pages),
1198 (create_subsequent_easysetup_pages):
1199 Call modest_wizard_dialog_force_title_update() so that the title is
1200 correct even with GTK+ < 2.10.
1201 This fixes projects.maemo.org bug NB#56145 .
1203 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1205 * src/maemo/modest-platform.c:
1206 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1207 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1210 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1212 * src/widgets/modest-window.h:
1213 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1214 and modest_window_save_state(), which invokes it.
1216 * src/widgets/modest-window-mgr.h:
1217 * src/widgets/modest-window-mgr.c:
1218 Added modest_window_mgr_save_state_for_all_windows(), which calls
1219 the save_state vfunc on all registered windows, if implemented.
1221 * src/gnome/modest-msg-edit-window.c:
1222 * src/gnome/modest-msg-view-window.c:
1223 * src/maemo/modest-msg-edit-window.c:
1224 * src/maemo/modest-msg-view-window.c:
1225 * src/maemo/modest-main-window.c:
1226 Specify the existing save_settings functions as implementations of
1227 ModestWindow::save_state_func().
1229 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1230 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1231 enabling hibernation, for instance.
1233 We may need to do the same thing for restoring settings.
1236 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1238 * src/widgets/modest-window-mgr.c:
1239 * src/widgets/modest-window-mgr.h:
1240 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1241 modest_window_mgr_get_hibernation_is_prevented().
1243 * src/maemo/modest-main-window.c:
1244 (on_hildon_program_is_topmost_notify): Prevent hibernation
1245 (possible when the application goes to the background in the WM),
1246 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1248 * src/maemo/easysetup/modest-easysetup-wizard.c:
1249 (modest_easysetup_wizard_dialog_init):
1250 * src/maemo/modest-account-settings-dialog.c:
1251 (modest_account_settings_dialog_init):
1252 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1253 (modest_connection_specific_smtp_edit_window_init):
1254 * src/maemo/modest-connection-specific-smtp-window.c:
1255 (modest_connection_specific_smtp_window_init):
1256 * src/maemo/modest-signature-editor-dialog.c:
1257 (modest_signature_editor_dialog_init):
1258 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1259 prevent hibernation while any of these account settings dialogs are open.
1261 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1263 * src/maemo/Makefile.am:
1264 * src/maemo/modest-osso-state-saving.c:
1265 * src/maemo/modest-osso-state-saving.h: Added
1266 modest_osso_load_state() and modest_osso_save_state() though they do
1267 nothing now. They should iterate through all the open windows and load/save
1269 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1270 save state when closing.
1272 * src/maemo/modest-main-window.c:
1273 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1274 Add a notification handler for the HildonProgram::is-topmost property,
1275 so we can allow hibernation when the application goes into the background.
1276 But we still need to detect when the accounts setup windows are open so
1277 we can stop hibernation when they are open.
1278 To do this, I also added the main window the HildonProgram. This might have
1279 other side-effects/benefits, and should maybe be done for other windows.
1281 * src/maemo/modest-osso-autosave-callbacks.h:
1282 * src/maemo/modest-osso-autosave-callbacks.c:
1283 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1284 though it does not do anything yet, and we might never need this to do
1285 anything. For instance, we already save drafts.
1287 * src/maemo/modest-platform.c: (modest_platform_init):
1288 Specify the libosso auto-save callback.
1290 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1292 * src/maemo/modest-platform.c:
1293 (modest_platform_set_update_interval):
1294 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1295 aparently stays valid between application instances, so we can use this
1296 to remove and reset it later. According to a maemo-developers email from
1299 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1301 * configure.ac: Depend on libalarm for Maemo.
1303 * src/dbus_api/modest-dbus-api.h:
1304 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1305 (on_send_receive), (modest_dbus_req_handler):
1306 Handle a SEND_RECEIVE D-Bus method.
1308 * libmodest-dbus-client/libmodest-dbus-client.c:
1309 (libmodest_dbus_client_send_and_receive):
1310 * libmodest-dbus-client/libmodest-dbus-client.h:
1311 Add C convenience functions for calling the new D-Bus method.
1313 * src/modest-platform.h:
1314 * src/gnome/modest-platform.c:
1315 * src/maemo/modest-platform.c:
1316 Added modest_platform_set_update_interval(), which uses the
1317 alarmd API on Maemo.
1318 (modest_platform_init),
1319 Call modest_platform_set_update_interval(), using a hard-coded
1320 interval for now (until the global settings dialog is implemented),
1321 though I am not sure that this makes sense yet.
1323 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1325 * src/dbus_api/modest-dbus-callbacks.c:
1326 (modest_osso_cb_hw_state_handler):
1327 * src/dbus_api/modest-dbus-callbacks.h:
1328 * src/maemo/modest-platform.c: (modest_platform_init):
1329 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1330 in case this has some effect on the ability for Maemo to ping the
1333 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1335 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1336 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1337 warning. It is probably a logic error, but I need to fix the build.
1339 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-account-mgr.h:
1342 * src/modest-account-mgr.c:
1343 (modest_account_mgr_account_names): Add a gboolean enabled_only
1344 parameter, so we can get lists of onlt the enabled accounts.
1346 (modest_account_mgr_add_account),,
1347 (modest_account_mgr_account_with_display_name_exists):
1348 * src/maemo/modest-msg-edit-window.c: (get_transports):
1349 * src/modest-account-mgr-helpers.c:
1350 (modest_account_mgr_set_first_account_as_default):
1351 * src/modest-init.c: (init_default_account_maybe):
1352 * src/modest-tny-account-store.c: (get_accounts):
1353 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1354 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1355 * tests/check_account-mgr.c: (START_TEST):
1356 Provide the extra parameter, as appropriate.
1358 * src/widgets/modest-account-view.c: (update_account_view):
1359 Do not show disabled accounts (meaning that there is no way to
1360 enable/disable accounts in the UI (the feature is not in our UI
1361 specification), so we can use this internally only to mark unfinished
1362 or temporary account data.
1364 * src/maemo/easysetup/modest-easysetup-wizard.c:
1365 (create_account): Add boolean enable parameter, so we can specify FALSE
1366 to create the temporary account.
1367 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1368 (on_before_next): When finishing, when there is a temporary account, just
1370 Also, use a timeout to delay the showing of the dialog until gconf is likely
1371 to return correct information, due to a maemo gconf bug that is fixed in
1372 osso 1.1, but not yet in Bora.
1373 However, the dialog stays on screen after it is destroyed.
1375 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1376 for invalid data when cancelling. Use a hildon note instead of a dialog
1377 to complain about invalid data. Do not show the account-saved note if the
1378 account is disabled (a temporary account that will not really be saved for use
1381 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1383 * src/modest-account-mgr-helpers.h:
1384 * src/modest-account-mgr-helpers.c:
1385 Added modest_account_mgr_unset_default_account(),
1386 Added modest_account_mgr_set_first_account_as_default().
1388 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1389 If it was the default account, unset the default account name.
1391 * src/maemo/modest-account-view-window.c:
1392 (on_delete_button_clicked): If it was the default account,
1393 set the first remaining account as the default instead.
1395 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1396 a NULL account or a NULL default account, to prevent a crash. This should
1397 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1400 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1402 * src/widgets/modest-recpt-editor.c:
1403 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1404 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1405 TODO comment for this. This fixes the build.
1407 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1408 be the best place for it. This will in future update all auto-update accounts,
1409 rather than just the current/default account, when that gconf key exists.
1410 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1411 if there are no accounts, before calling do_send_receive().
1412 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1414 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1415 * src/maemo/modest-main-window-ui.h:
1416 * src/maemo/modest-main-window.c: (on_connection_changed),
1417 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1418 directly, becaue the signal handler does more.
1420 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1422 * src/modest-account-mgr-helpers.c:
1423 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1424 for the case that the account does not exist.
1426 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1427 (equivalent to the modest account name) rather than the tinymail account name
1428 (equivalent to the modest account title - human readable) to get the account data.
1429 Check for null account data to prevent the crash, and add a TODO comment saying that
1430 this needs fixing because it is using the server account name instead of the account name.
1432 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1434 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1435 * src/maemo/modest-account-settings-dialog.c: (show_error),
1437 Use hildon_note_new_information() for informative and error messages,
1438 which seems to be expected for Maemo applications (no documentation that I know of
1439 says this). I am surprised that there is no distinction between info and error
1442 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1445 it is easy to find where this is used.
1447 * src/maemo/easysetup/modest-easysetup-wizard.c:
1448 (create_page_welcome), (create_page_account_details),
1449 (create_page_user_details), (create_page_complete_easysetup),
1450 (create_page_custom_incoming), (create_page_custom_outgoing),
1451 (create_page_complete_custom):
1452 * src/maemo/modest-account-settings-dialog.c:
1453 (create_page_account_details), (create_page_user_details),
1454 (create_page_incoming), (create_page_outgoing):
1455 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1456 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1457 (modest_connection_specific_smtp_edit_window_init):
1458 * src/maemo/modest-connection-specific-smtp-window.c:
1459 (modest_connection_specific_smtp_window_init):
1460 * src/maemo/modest-signature-editor-dialog.c:
1461 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1462 and scrolling policy as per the Email Application Layout Guide, if I have
1465 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1468 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1469 which were empty, because these vfuncs have been removed from TnyAccountStore.
1470 This fixes the build.
1472 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1474 * src/maemo/modest-main-window.c:
1475 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1476 showing/hiding it. Added TODO because it probably should not be NULL.
1477 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1478 because unnecessary g_warnings() make degugging difficult.
1480 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1482 * src/maemo/modest-msg-edit-window.c:
1483 (modest_msg_edit_window_select_color),
1484 (modest_msg_edit_window_select_background_color): 2 const corrections and
1485 moving 2 #endifs before closing brackets, to fix the build.
1487 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/easysetup/modest-easysetup-wizard.h:
1490 * src/maemo/easysetup/modest-easysetup-wizard.c:
1491 (modest_easysetup_wizard_dialog_finalize),
1492 (on_button_edit_advanced_settings), (create_page_complete_custom),
1493 (on_response), (create_account):
1494 Implement the Advanced Settings edit button, by saving the account information,
1495 for the Advanded Settings dialog to use directly from gconf, and removing it
1496 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1497 Bug #5533 in the projects.maemo.org bugzilla.
1499 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1501 * src/maemo/modest-msg-view-window.c:
1502 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1503 when opening a message window.
1505 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1507 * src/maemo/easysetup/modest-easysetup-wizard.c:
1508 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1511 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1512 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1513 gconf settings. I probably added more checks than necessary, but that is safer.
1515 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1516 variable to fix the build, but this seems to be used when it is still NULL.
1518 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1520 * src/modest-platform.h:
1521 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1522 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1523 * src/modest-main.c: Implement this function so we can avoid using
1524 maemo-specific API from cross-platform code.
1526 * src/modest-tny-account-store.c:
1527 (get_smtp_specific_transport_account_for_open_connection):
1528 * src/modest-ui-actions.c: (check_for_connection),
1529 (modest_ui_actions_on_item_not_found):
1530 Use modest_platform_connect_and_wait() and put #idefs around other
1531 maemo-specific code, because only maemo currently has a way to
1532 identify connection names.
1534 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1536 * src/modest-tny-account-store.h:
1537 * src/modest-tny-account-store.c:
1538 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1539 the connection-specific SMTP server settings in the configuration.
1541 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1543 * src/maemo/modest-main-window.c: (on_connection_changed),
1545 * src/modest-main.c: (main), (start_ui), (send_mail):
1546 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1547 that is what is intended.
1549 * src/modest-ui-actions.c: (action_send), (action_receive),
1550 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1551 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1552 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1553 SMTP server is used when it is specified.
1555 (modest_ui_actions_on_send_receive):
1556 Check that a connection is open before proceeding.
1557 Receive and then send, instead of vice-versa, as per the specification.
1559 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1561 * src/modest-mail-operation.c:
1562 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1563 though I guess it should be something other than NULL.
1565 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1567 * src/maemo/easysetup/modest-easysetup-wizard.c:
1568 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1569 combo twice, to avoid an g_warning and to make it visible again.
1570 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1571 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1572 (already intended) dereference when detaching, because we then recreate the menu.
1573 But I am not sure why the warning was happening, and it is possible that this is a memory
1576 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1578 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1579 and uri_parse_mailto() utility functions.
1580 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1582 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1584 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1586 * src/dbus_api/modest-dbus-api.h:
1587 * src/dbus_api/modest-dbus-callbacks.c:
1588 Use an idle callback to execute the modest code in the application's own thread.
1589 Remove the helloworld example method.
1590 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1591 parsed, and the open-message method is not implemented because this is not yet implemented in
1593 * libmodest-dbus-client/libmodest-dbus-client.c:
1594 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1595 (libmodest_dbus_client_open_message):
1596 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1598 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1599 body without crashing.
1601 * tests/dbus_api/Makefile.am:
1602 * tests/dbus_api/test_mail_to.c:
1603 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1605 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1607 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1608 Added file to fix the build. Sorry.
1610 * src/dbus_api/Makefile.am:
1611 * src/dbus_api/modest-dbus-api.h:
1612 * src/dbus_api/modest-dbus-callbacks.h:
1613 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1614 (modest_dbus_req_handler):
1615 Put constants in a separate header so it can be reused by the
1616 client library, without duplication
1618 * libmodest-dbus-client/Makefile.am:
1619 * libmodest-dbus-client/libmodest-dbus-client.c:
1620 (libmodest_dbus_client_call_helloworld),
1621 (libmodfest_dbus_client_send_mail),
1622 (libmodfest_dbus_client_mailto),
1623 (libmodfest_dbus_client_open_message):
1624 * libmodest-dbus-client/libmodest-dbus-client.h:
1625 (Partly) Implement a send_mail D-Bus method.
1627 * tests/dbus_api/Makefile.am:
1628 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1629 the send_email D-Bus method.
1631 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1635 * libmodest-dbus-client/Makefile.am:
1636 * libmodest-dbus-client/libmodest-dbus-client.c:
1637 * libmodest-dbus-client/libmodest-dbus-client.h:
1638 * tests/dbus_api/Makefile.am:
1639 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1640 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1642 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1644 * src/maemo/easysetup/modest-easysetup-wizard.c:
1645 (create_page_account_details):
1646 * src/maemo/modest-account-settings-dialog.c:
1647 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1648 widgets, because this might not be the default in future versions of the Maemo GTK+.
1649 However, I can not not get capitalization to work even in a simple test case.
1651 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/easysetup/modest-easysetup-wizard.c:
1654 (create_page_custom_incoming), (create_page_custom_outgoing):
1655 * src/maemo/modest-account-settings-dialog.c:
1656 (create_page_account_details), (create_page_incoming),
1657 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1658 instead of using gtk_check_button_with_label(), so they are aligned like the other
1659 widgets, as per the UI spec.
1661 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1663 * src/maemo/easysetup/modest-easysetup-wizard.c:
1664 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1665 * src/widgets/modest-validating-entry.c:
1666 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1667 Modest prefix instead of an EasySetup prefix.
1669 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1671 * src/widgets/modest-validating-entry.h:
1672 * src/widgets/modest-validating-entry.c: (on_insert_text),
1673 Added easysetup_validating_entry_set_max_func(), used to set a callback
1674 to call when the max number of characters is reached. GtkEntry has a max-length
1675 already but is silent about it.
1677 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1678 (create_page_account_details), (create_page_user_details),
1680 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1681 (create_page_account_details), (create_page_user_details),
1682 (create_page_outgoing):
1683 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1684 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1685 the UI spec, when the user tries to enter more than the max number of characters.
1687 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1689 * src/maemo/easysetup/modest-easysetup-wizard.c:
1690 (create_page_user_details), (create_page_custom_incoming),
1691 (create_page_custom_outgoing):
1692 * src/maemo/modest-account-settings-dialog.c:
1693 (create_page_user_details), (create_page_incoming),
1694 (create_page_outgoing):
1695 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1696 (modest_connection_specific_smtp_edit_window_init):
1697 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1698 not appropriate. Bad Maemo-specific defaults!.
1700 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1702 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1703 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1704 (modest_signature_editor_dialog_set_settings):
1705 Disable the label and textview when the checkbox is disabled, and use the
1706 specified (UI spec) default signature text.
1708 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1710 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1711 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1713 * src/modest-defs.h:
1714 * src/modest-account-mgr-helpers.h:
1715 * src/modest-account-mgr-helpers.c:
1716 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1718 * src/maemo/Makefile.am:
1719 * src/maemo/modest-signature-editor-dialog.c:
1720 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1723 * src/maemo/modest-account-settings-dialog.h:
1724 * src/maemo/modest-account-settings-dialog.c:
1725 (modest_account_settings_dialog_finalize), (on_button_signature),
1726 (save_configuration): Use the new dialog when the Edit button is pressed, and
1727 save the changes if necessary, as per the UI spec.
1729 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1731 * src/maemo/Makefile.am:
1732 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1733 based on maemo-develoers email from Dirk.
1735 * src/maemo/easysetup/modest-easysetup-wizard.c:
1736 (create_page_welcome), (create_page_account_details),
1737 (create_page_user_details), (create_page_complete_easysetup),
1738 (create_page_custom_incoming), (create_page_custom_outgoing),
1739 (create_page_complete_custom),
1740 (modest_easysetup_wizard_dialog_init):
1741 * src/maemo/modest-account-settings-dialog.c:
1742 (create_page_account_details), (create_page_user_details),
1743 (create_page_incoming), (create_page_outgoing),
1744 (modest_account_settings_dialog_init):
1745 * src/maemo/modest-connection-specific-smtp-window.c:
1746 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1748 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1750 * src/maemo/easysetup/modest-easysetup-wizard.c:
1751 (create_page_account_details), (create_page_custom_outgoing),
1752 (create_page_complete_custom):
1753 * src/maemo/modest-account-settings-dialog.c:
1754 (create_page_user_details), (create_page_incoming),
1755 (create_page_outgoing):
1756 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1757 (modest_connection_specific_smtp_edit_window_init):
1758 Use the correct (UI spec) port min/max, and use horizontal separators,
1761 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1763 * src/maemo/easysetup/modest-easysetup-wizard.c:
1764 (set_default_custom_servernames):
1765 * src/maemo/modest-account-settings-dialog.c:
1766 (create_page_incoming), (on_combo_outgoing_security_changed),
1767 (on_combo_incoming_security_changed), (create_page_outgoing),
1768 (modest_account_settings_dialog_set_account_name),
1769 (save_configuration):
1770 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1771 (on_combo_security_changed),
1772 (modest_connection_specific_smtp_edit_window_init),
1773 (modest_connection_specific_smtp_edit_window_set_connection),
1774 (modest_connection_specific_smtp_edit_window_get_settings):
1775 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1778 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1781 * src/maemo/easysetup/modest-easysetup-wizard.c:
1782 (create_page_custom_outgoing), (create_page_complete_custom):
1783 * src/maemo/modest-account-settings-dialog.c:
1784 (create_page_user_details), (create_page_outgoing):
1785 * src/maemo/modest-account-view-window.c: (button_box_new):
1786 Use changed logical IDs as per the most recent UI spec:
1787 mcen_bd_emailsetup_edit -> mcen_bd_edit
1788 mcen_bd_emailsetup_delete -> mcen_bd_delete
1789 mcen_bd_emailsetup_close -> mcen_bd_close
1791 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1795 * src/dbus_api/Makefile.am:
1796 * src/dbus_api/modest-dbus-callbacks.c:
1797 * src/dbus_api/modest-dbus-callbacks.h:
1798 * src/maemo/modest-platform.c: (modest_platform_init):
1799 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1801 * tests/Makefile.am:
1802 * tests/dbus_api/Makefile.am:
1803 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1805 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1807 * src/maemo/modest-account-settings-dialog.c:
1808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1809 Removed unnecessary includes.
1811 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1813 * src/maemo/easysetup/modest-easysetup-wizard.c:
1814 * src/maemo/modest-account-settings-dialog.c:
1815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1816 * src/widgets/Makefile.am:
1817 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1818 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1819 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1820 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1821 * src/widgets/modest-secureauth-combo-box.c:
1822 * src/widgets/modest-secureauth-combo-box.h:
1823 * src/widgets/modest-serversecurity-combo-box.c:
1824 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1825 made the GObject names more consistent with the rest of the Modest code.
1827 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1829 * src/maemo/easysetup/Makefile.am:
1830 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1831 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1832 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1833 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1834 * src/maemo/easysetup/modest-easysetup-wizard.c:
1835 * src/maemo/easysetup/modest-validating-entry.c:
1836 * src/maemo/easysetup/modest-validating-entry.h:
1837 * src/maemo/modest-account-settings-dialog.c:
1838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1839 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1840 widgets/ because they are used outside of easysetup too. After checking in,
1841 svn will allow me to rename them too.
1843 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1845 * src/gnome/modest-msg-edit-window.c:
1846 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1847 linker error, to fix the build on the GNOME platform.
1848 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1849 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1850 ifdefed out to avoid a warning.
1852 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1854 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1855 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1856 some alternative for GTK+ 2.6.
1858 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1860 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1862 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1863 specified for EmailAccountsDialog in UI spec.
1865 * src/maemo/easysetup/modest-easysetup-wizard.c:
1866 * src/maemo/easysetup/modest-easysetup-wizard.h:
1867 * src/maemo/modest-account-settings-dialog.c:
1868 * src/maemo/modest-account-settings-dialog.h:
1869 Reuse a member window widget for the connection-specific SMTP server accounts,
1870 so we can tell it to create/save the accounts only if we actually save changes.
1872 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1873 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1874 (modest_connection_specific_smtp_edit_window_get_settings):
1875 Return a struct instance for temporarily remembering the entered data.
1877 * src/maemo/modest-connection-specific-smtp-window.h:
1878 * src/maemo/modest-connection-specific-smtp-window.c:
1879 (modest_connection_specific_smtp_window_finalize),
1880 (modest_connection_specific_smtp_window_fill_with_connections),
1882 (modest_connection_specific_smtp_window_save_server_accounts),
1883 (update_model_server_names): Do not actually save data until asked,
1884 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1886 (on_selection_changed),
1887 (modest_connection_specific_smtp_window_init): Disable the edit
1888 button when nothing is selected.
1890 * src/modest-account-mgr-helpers.c:
1891 * src/modest-account-mgr-helpers.h:
1892 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1895 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1897 * src/modest-account-mgr-helpers.h:
1898 * src/modest-account-mgr-helpers.c:
1899 (modest_account_mgr_get_unused_account_name),
1900 (modest_account_mgr_get_unused_account_display_name): Added these
1901 utility functions, to avoid code duplication.
1903 * src/maemo/easysetup/modest-easysetup-wizard.c:
1904 (create_page_account_details), (create_account):
1905 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1906 (on_combo_security_changed),
1907 (modest_connection_specific_smtp_edit_window_init),
1908 (modest_connection_specific_smtp_edit_window_save_settings):
1909 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1910 * src/maemo/modest-connection-specific-smtp-window.c:
1911 (modest_connection_specific_smtp_window_finalize),
1912 (modest_connection_specific_smtp_window_fill_with_connections),
1913 (on_button_edit), (modest_connection_specific_smtp_window_init):
1914 * src/maemo/modest-connection-specific-smtp-window.h:
1915 Implementing saving of connection-specific server accounts.
1917 But I need to refactor this so we can save the data for each
1918 possible connection-specific account and only actually create the server accounts
1919 when the easysetup finished, or the OK button is pressed on the account settings
1922 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1924 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1925 (on_combo_security_changed):
1926 (modest_connection_specific_smtp_edit_window_init):
1927 Auto-fill the port number as in the account settings.
1929 (modest_connection_specific_smtp_edit_window_set_connection):
1930 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1931 * src/maemo/modest-connection-specific-smtp-window.c:
1932 (fill_with_connections), (on_button_edit),
1933 (modest_connection_specific_smtp_window_init):
1934 Turn the edit window into a dialog to simplify the code, and
1935 set a WM hint as in a GtkDialog, because only a popup can be on top of
1936 another window in Maemo, and popups usually have no WM decoration.
1938 * src/modest-defs.h:
1939 * src/modest-account-mgr-helpers.c:
1940 (modest_account_mgr_set_connection_specific_smtp),
1941 (modest_account_mgr_remove_connection_specific_smtp),
1942 (modest_account_mgr_get_connection_specific_smtp):
1943 * src/modest-account-mgr-helpers.h: Some functions to write the
1944 connection-specific SMTP server information. Not yet used.
1947 * src/widgets/modest-folder-view.c: (text_cell_data):
1948 Fix a warning about an uninitialized variable.
1949 (on_configuration_key_changed): Put an #ifdef around the use
1950 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1952 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1954 * src/maemo/modest-account-settings-dialog.h:
1955 * src/maemo/modest-account-settings-dialog.c:
1956 Added connect_for_modified() utility function to mark the new modified boolean.
1958 (create_page_account_details), (create_page_user_details),
1959 (create_page_incoming), (create_page_outgoing), (on_response),
1960 (modest_account_settings_dialog_init),
1961 (modest_account_settings_dialog_set_account_name):
1962 Only warn about unsaved changes when there are actually unsaved changes.
1964 * src/modest-account-mgr-helpers.c:
1965 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1966 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1967 to get the data from there in future.
1969 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1971 * src/modest-defs.h:
1973 * src/modest-account-mgr-helpers.h:
1974 * src/modest-account-mgr-helpers.c:
1975 Store the security account setting in a single conf key instead of using
1976 the options list, so that the list is left for just the to-be-removed camel hack,
1977 and because gconf_client_set_list() is failing for some reason.
1979 * src/modest-account-mgr.c:
1980 (modest_account_mgr_add_server_account):
1981 * src/maemo/modest-account-settings-dialog.c:
1982 (modest_account_settings_dialog_set_account_name),
1983 (save_configuration): Use the renamed functions.
1986 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1988 * src/widgets/Makefile.am:
1989 * src/widgets/modest-limit-retrieve-combo-box.c:
1990 * src/widgets/modest-limit-retrieve-combo-box.h:
1991 * src/widgets/modest-retrieve-combo-box.c:
1992 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1993 the account settings dialog.
1995 * src/modest-defs.h:
1996 * src/modest-account-mgr-helpers.h:
1997 * src/modest-account-mgr-helpers.c:
1998 (modest_server_account_get_option_secure_auth),
1999 (modest_server_account_set_option_secure_auth):
2000 * src/modest-account-mgr.c:
2001 (modest_account_mgr_add_server_account):
2002 Use the existing AUTH_MECH conf key for the secure-auth setting,
2003 instead of putting it in the list options, because this was actually used already.
2005 * src/maemo/modest-account-settings-dialog.c:
2006 (create_page_account_details),
2007 (modest_account_settings_dialog_set_account_name),
2008 (save_configuration):
2009 * src/maemo/modest-account-settings-dialog.h:
2010 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2011 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2013 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2015 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2016 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2017 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2019 * src/modest-defs.h:
2020 * src/maemo/modest-account-settings-dialog.c:
2021 (create_page_incoming), (on_combo_outgoing_security_changed),
2022 (on_combo_incoming_security_changed), (create_page_outgoing),
2023 (modest_account_settings_dialog_set_account_name),
2024 (save_configuration): Load/Save the port number, and change it when the
2025 security combo changes, to suitable defaults.
2027 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2029 * src/modest-account-mgr.c:
2030 (modest_account_mgr_add_server_account): Set the security and secure-auth
2031 options, and add a comment saying that the other camel-specific options should be
2034 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2036 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2038 * src/modest-tny-account-store.c: (account_list_free),
2039 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2040 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2043 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2045 * src/modest-protocol-info.c:
2046 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2047 is required by our UI spec. Maybe something in our implementation will use this eventually.
2048 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2049 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2050 instead of the previous 0 placeholder.
2052 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2053 secure-auth settings.
2054 * src/modest-account-mgr-helpers.h:
2055 * src/modest-account-mgr-helpers.c:
2056 (modest_server_account_data_get_option_secure_auth),
2057 (modest_server_account_set_option_secure_auth),
2058 (modest_server_account_data_get_option_security),
2059 (modest_server_account_set_option_security): Added this API for getting and setting the security
2060 and secure-auth settings.
2062 * src/maemo/modest-account-settings-dialog.h:
2063 * src/maemo/modest-account-settings-dialog.c:
2064 (modest_account_settings_dialog_finalize), (check_data),
2065 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2066 about changing titles.
2067 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2068 (save_configuration): Save the security and secure-auth settings.
2070 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2071 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2073 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2075 * src/modest-defs.h:
2076 * src/modest-account-mgr.c:
2077 (modest_account_mgr_add_server_account):
2078 Added and used defines for the options key and value pair strings,
2079 that are used so far, though they do not seem to correspond to anything in our
2080 UI specs or ModestProtocol enum.
2082 * src/modest-account-mgr-helpers.h:
2083 * src/modest-account-mgr-helpers.c:
2084 (compare_option_strings_for_name),
2085 (modest_server_account_data_get_option_value),
2086 (modest_server_account_data_get_option_bool),
2087 (modest_account_mgr_get_server_account_option):
2088 Added helper functions for parsing the options GSList.
2090 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2092 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2093 display name is based on the supplied account name.
2094 * src/modest-account-mgr.c:
2095 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2096 with an inefficient, but good-enough, implementation.
2098 * src/maemo/easysetup/modest-easysetup-wizard.c:
2099 (create_page_account_details), (on_before_next), (create_account):
2100 Check for existing display names rather than (non-user-visible) account names, and just
2101 create and set a unique account name at the end.
2103 * src/maemo/modest-account-settings-dialog.c:
2104 (modest_account_settings_dialog_init),
2105 (modest_account_settings_dialog_set_account_name),
2106 (create_page_incoming): Show the display name, instead of the account name.
2107 (on_response): Do some (not all) extra checks, as in the UI spec.
2108 (save_configuration): Save the display name if it was changed.
2110 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2112 * po/en_GB.po: Added needed logical ID and translation.
2113 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2114 (init_view): Made the is-default column clicking work.
2116 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/easysetup/Makefile.am:
2120 * src/maemo/easysetup/modest-easysetup-wizard.c:
2121 (modest_easysetup_wizard_dialog_init):
2122 * src/maemo/easysetup/provider-data-test.keyfile:
2123 * src/maemo/easysetup/provider-data.keyfile:
2124 Moved the provider data file to the new modest-providers-data package and used it from there.
2126 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-local-folder-info.c:
2129 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2130 N_() was already used on the static strings, but this just marks it for translation without
2131 using the translation.
2133 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2135 * src/maemo/modest-account-settings-dialog.c:
2136 (create_page_incoming),
2137 (modest_account_settings_dialog_set_account_name):
2138 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2139 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2140 I will do this if nobody else gets there first.
2142 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2144 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2145 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2146 save the security stuff.
2148 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2150 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2151 Set the email address and user fullname, which I now see must be
2154 * src/maemo/modest-account-settings-dialog.h:
2155 * src/maemo/modest-account-settings-dialog.c:
2157 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2158 leave-on-server and authentication.
2159 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2162 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2165 * src/maemo/modest-account-settings-dialog.c:
2166 * src/maemo/modest-account-settings-dialog.h:
2167 Most (but not all) of the widgets are now present as specified by the UI spec.
2168 No changes are yet saved, and some details are not properly shown yet.
2170 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2172 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2174 * src/maemo/Makefile.am:
2175 * src/maemo/modest-account-settings-dialog.c:
2176 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2177 an existing account. Doesn't do much yet.
2179 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2180 Open the accounts settings dialog when Edit is clicked.
2182 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2184 * src/maemo/easysetup/Makefile.am:
2185 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2187 * src/maemo/easysetup/modest-easysetup-wizard.c:
2188 (modest_easysetup_wizard_dialog_init):
2189 Try to get the source directory from the build system,
2190 instead of hard-coding "./" into the source code, when opening our local
2191 copies of the configuration files.
2192 But this still fails when opening the wizard from the Accounts window,
2193 maybe because the working directory seems to change at runtime.
2194 So the wizard will fail the second time unless you copy the files into their
2195 proper locations - see the stdout warnings for the paths.
2197 (create_page_account_details),(on_before_next):
2198 Check for existing non-server accounts instead of server accounts,
2199 so the default account name is useful again, and to prevent trying to
2202 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2203 Show the wizard when New is clicked.
2205 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2206 (init_view): Show the column headers, and show the columns that are
2207 specified in the UI specs. However, something in Maemo's GTK+ prevents
2208 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2209 change the default account. This is despite unsetting the special properties.
2211 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2213 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2214 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2215 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2216 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2217 to make that clearer.
2218 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2220 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2222 * src/maemo/modest-account-view-window.c:
2223 (modest_account_view_window_init),
2224 (modest_account_view_window_new):
2225 Use the same buttons as specified in the
2226 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2227 the existing widgets, which never had a chance of working.
2228 Put the ModestAccountView treeview in a scrolled window.
2229 Do not repeat the initialization in both _init() and _new().
2231 * src/widgets/modest-account-view.c: (update_account_view):
2232 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2233 this widget and window shows no accounts.
2235 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2237 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2239 * src/maemo/easysetup/modest-easysetup-wizard.c:
2240 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2241 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2242 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2245 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2246 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2247 accounts exist yet, as in the UI spec.
2249 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2251 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2253 * src/maemo/Makefile.am:
2254 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2255 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2256 New window for editing connection-specific smtp details.
2257 Not fully implemented.
2259 * src/maemo/modest-connection-specific-smtp-window.c:
2260 (modest_connection_specific_smtp_window_finalize) :
2261 unref the tree model.
2262 (on_button_edit): Show the edit window.
2264 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2266 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2269 * src/maemo/Makefile.am:
2270 * src/maemo/modest-connection-specific-smtp-window.c:
2271 * src/maemo/modest-connection-specific-smtp-window.h:
2272 New window for showing the list of connections, for connection-specific
2273 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2274 * src/maemo/easysetup/modest-easysetup-wizard.c:
2275 (create_page_custom_outgoing): Show the new window when the button is clicked.
2277 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2279 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2280 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2281 * src/maemo/modest-msg-edit-window.c:
2282 (modest_msg_edit_window_insert_image):
2283 * src/modest-conf.c: (modest_conf_key_escape):
2284 * src/modest-mail-operation.c:
2285 (modest_mail_operation_send_new_mail):
2286 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2287 (modest_ui_actions_on_new_account):
2288 * src/widgets/modest-attachment-view.c: (update_filename_request):
2289 * src/widgets/modest-mail-header-view.c:
2290 Corrected warnings that were breaking the build, by commenting out unused variables,
2291 and a function, and by including a header.
2293 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2295 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2296 so we can #ifdef around platform-specific code when necessary.
2297 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2298 to allow this to build for the GNOME platform too.
2300 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2302 * src/maemo/easysetup/modest-easysetup-wizard.c:
2303 Added util_increment_name() and used it in create_page_account_details()
2304 to make sure that the default account name is always a new name.
2306 (modest_easysetup_wizard_dialog_init),
2307 (set_default_custom_servernames): Some minor memory management fixes.
2309 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2313 * src/modest-runtime.c: (init_i18n): Restored the translation
2314 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2315 are defined in config.h, and the translations are installed.
2317 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2318 is defined for translation.
2320 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2322 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2324 * src/maemo/easysetup/modest-easysetup-wizard.c:
2325 (modest_easysetup_wizard_dialog_init):
2326 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2327 Use realistic paths (though they should use $prefix generically) to the
2328 mcc_mapping and provider-data.keyfile files which might work when they
2329 are installed by the future version of the operator-wizard package,
2330 and then fallback to paths in our source code, with an explanatory
2333 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2337 * src/maemo/Makefile.am:
2338 * src/maemo/easysetup/: Added files from the previously-exernal
2339 osso-modest-easysetup.
2340 * src/maemo/modest-main-window-ui.h:
2341 * src/modest-ui-actions.c:
2342 * src/modest-ui-actions.h:
2343 Added modest_ui_actions_on_new_account() as a signal handler for the
2344 New Account menu item. It shows the easysetup wizard.
2345 * po/en_GB.po: Added additional needed logical IDs and translations.
2347 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2348 Apparently ChangeLog is not used for some vague Nokia legal reasons.