1 2007-05-28 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-global-settings-dialog.c:
5 * src/widgets/modest-global-settings-dialog.c:
6 (current_connection_default):
7 Use the enum values instead of 0, 1 and -1,
8 to make the code clearer.
10 * src/modest-account-mgr-helpers.c:
11 (modest_account_mgr_get_connection_specific_smtp): Make this code
14 * src/modest-runtime.h:
15 * src/modest-runtime.c:
16 Added modest_runtime_remove_all_send_queues().
17 * src/maemo/modest-main-window.c:
18 (on_account_store_connecting_finished): Recreate the send queues,
19 using the appropriate transport accounts for this new connection.
20 Some futher adapting might be needed if the old send queues are not
21 automatically stopped at this point.
23 * src/modest-tny-account-store.c: (get_server_accounts):
24 Create the connection-specific transport accounts, so that they can
25 be found later by their ID.
27 * src/modest-tny-account.h:
28 * src/modest-tny-account.c:
29 Added modest_tny_account_new_from_server_account_name().
30 modest_tny_account_new_from_server_account(): Do not create the
31 send queues here, because they will be
32 recreated anyway when the connection changes for the first time.
34 2007-05-28 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-local-folder-info.h:
37 * src/modest-local-folder-info.c:
38 (modest_per_account_local_outbox_folder_info_get_maildir_path),
39 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
40 tbox_folder): Take a modest account name instead of a server TnyAccount,
41 so we can have per-modest-account rather than per-transport-account
43 We must make sure that we change or recreate the exisitng send queues
44 when the connection changes for connection-specific transport accounts.
46 * src/modest-tny-account-store.c:
47 (create_per_account_local_outbox_folders): Create outboxed per modest
48 account, not per transport account.
50 * src/modest-tny-account.h:
51 * src/modest-tny-account.c:
52 (modest_tny_account_get_special_folder): For outboxes, get the
53 parent modest account name. The account is ignored for other folders.
54 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
55 modest account name rather than a server TnyAccount.
57 2007-05-25 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-tny-account.c:
60 (modest_tny_account_new_from_server_account):
61 Call modest_runtime_get_send_queue() immediately after creating transport
62 accounts, so that they start trying to send email from the outbox as soon
63 as possible at startup. This is probably what we want.
65 * src/modest-mail-operation.c: (update_account_thread):
66 * src/modest-runtime.c: (modest_runtime_get_send_queue):
67 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
68 * src/modest-tny-send-queue.h:
69 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
70 (modest_ui_actions_on_send):
71 Added comments about how sending works, though it needs some more work.
73 2007-05-25 Murray Cumming <murrayc@murrayc.com>
75 * src/modest-tny-account.c:
76 (modest_tny_account_get_special_folder): Add TODO because this fails when
78 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
79 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
80 Do not try to show this window when there is no active account. The UI
81 specs does not tell us what to do in this case.
83 2007-05-24 Murray Cumming <murrayc@murrayc.com>
87 * src/maemo/Makefile.am:
88 * src/widgets/Makefile.am: Some dist fixes.
90 2007-05-24 Murray Cumming <murrayc@murrayc.com>
92 * src/maemo/modest-connection-specific-smtp-window.c:
93 (on_button_edit): Make the code clearer, to prevent a double free.
95 2007-05-24 Murray Cumming <murrayc@murrayc.com>
97 * src/maemo/modest-account-settings-dialog.c:
98 (modest_account_settings_dialog_set_account_name),
99 Check the connection-specific smtp servers checkbox if there are any.
101 * src/maemo/modest-connection-specific-smtp-edit-window.c:
102 (modest_connection_specific_smtp_edit_window_init):
103 Start with a suitable port number.
105 * src/modest-account-mgr-helpers.h:
106 * src/modest-account-mgr-helpers.c: Added
107 modest_account_mgr_get_has_connection_specific_smtp().
109 (modest_account_mgr_set_connection_specific_smtp),
110 (modest_account_mgr_remove_connection_specific_smtp),
111 (modest_account_mgr_get_has_connection_specific_smtp),
112 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
113 connection-specific smtp server accounts in the account, rather than
114 the server account conf dir.
116 This fixes bug projects.maemo.org bug NB#58263 .
118 * src/modest-tny-account-store.c:
119 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
120 if there are no server accounts yet, to prevent an infinite loop when there
121 are no accounts. Document that one must be called before the other.
123 2007-05-24 Murray Cumming <murrayc@murrayc.com>
125 * src/modest-account-mgr-helpers.c:
126 (modest_account_mgr_get_default_account): Make sure that at least
127 one account is always the default, if there are any enabled accounts.
128 This is just a sanity check that shouldn't be necessary.
130 * src/modest-account-mgr-priv.c:
131 (_modest_account_mgr_account_from_key): Unescape the conf key to
132 get the real account name. For instance, this is an issue if a space
133 was in the account name, which can happen because the account name
134 is generated from the display name.
135 (_modest_account_mgr_get_account_keyname): Always escape the
137 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
138 Unescape the conf keys to get the real account names.
140 For instance, previously the is-default radio button in the accounts
141 list was not checked for any accounts at first. This fixes that,
142 and might fix several similar bugs.
144 2007-05-23 Murray Cumming <murrayc@murrayc.com>
146 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
147 Removed some debug printfs.
149 2007-05-23 Murray Cumming <murrayc@murrayc.com>
151 Modest on-disk outbox directories are now here, for instance:
152 $HOME/.modest/outboxes/<account-id-1>/outbox
153 $HOME/.modest/outboxes/<account-id-2>/outbox
155 $HOME/.modest/local-folders/outbox
156 so we can have a separate outbox for each account.
157 But they are shown as one outbox in the GtkTreeView, by using a
158 TnyMergeFolder in a ModestTnySimpleFolderStore.
161 * src/modest-tny-simple-folder-store.c:
162 * src/modest-tny-simple-folder-store.h:
163 Added ModestTnySimpleFolderStore, used to contain folders from
164 other folder stores, such as other accounts.
166 * src/modest-tny-outbox-account.h:
167 * src/modest-tny-outbox-account.c:
168 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
169 used for the per-account local outbox folders.
171 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
172 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
173 only use this (internally) now for the non-outbox local folders.
176 * src/modest-init.c: Added modest_init_one_local_folder(), for
177 setting up the directory structure for each local folder.
179 * src/modest-local-folder-info.c:
180 (modest_per_account_local_outbox_folder_info_get_maildir_path),
181 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
183 * src/modest-local-folder-info.h:
184 * src/modest-tny-account-store.c: (on_account_removed),
185 (on_account_changed), (create_per_account_local_outbox_folders),
186 (get_server_accounts), (modest_tny_account_store_get_accounts),
187 (modest_tny_account_store_get_tny_account_by_account),
188 (modest_tny_folder_store_is_virtual_local_folders):
190 * src/modest-tny-account.h:
191 * src/modest-tny-account.c:
192 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
193 to create an on-disk per-account local outbox folder for each
195 (create_per_account_local_outbox_folders): Create a local outbox folder
196 for each transport account.
197 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
198 for all local folders.
200 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
201 instead of using g_object_get/set() directly. It is clearer.
203 (modest_tny_folder_store_get_message_count),
204 (modest_tny_folder_store_get_local_size
205 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
206 because we now use these with non-acount folder stores.
208 (modest_tny_account_get_special_folder),
209 (modest_tny_account_new_from_server_account),
210 (modest_tny_account_new_from_account):
211 (recurse_folders): Adjust to the new outbox system.
213 * src/modest-tny-folder.h:
214 * src/modest-tny-folder.c:
215 (modest_tny_folder_is_local_folder),
216 (modest_tny_folder_get_local_folder_type),
217 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
219 * src/widgets/modest-main-window.h:
220 * src/maemo/modest-main-window.c: (create_details_widget),
221 (modest_main_window_set_contents_style): Show details for any folder store,
224 (modest_tny_folder_get_rules):
225 Remove the const. C does not support constness enough for this.
227 * src/modest-ui-actions.c:
228 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
229 make all outboxes appear as one, in the usual local-folders tree node.
231 (set_active_account_from_tny_account),
232 (modest_ui_actions_on_folder_selection_changed):
233 * src/widgets/modest-folder-view.c: (text_cell_data),
234 (icon_cell_data), (filter_row),
235 (add_account_folders_to_merged_folder),
236 (add_account_folders_to_simple_folder_store), (),
237 (get_cmp_rows_type_pos), (cmp_rows),
238 (modest_folder_view_set_account_id_of_visible_server_account):
239 Adjust to the new outbox system, using generic folder stores and folders
242 2007-05-23 Christian Kellner <ckellner@openismus.com>
244 * src/modest-mail-operation.c:
245 (modest_mail_operation_update_account):
246 Use info->max_size instead of unintialized local var [small
247 build fix]. (Added TODO to review that change since I don't
250 2007-05-23 Marcus Bauer <marcusb@openismus.com>
252 * libmodest-dbus-client/libmodest-dbus-client.c:
253 (libmodest_dbus_client_compose_mail): function added
254 * src/dbus_api/modest-dbus-api.h:
255 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
256 (on_compose_mail): Implementation of the SendAsMail functionality
258 2007-05-22 Murray Cumming <murrayc@murrayc.com>
260 * src/modest-account-mgr.c:
261 (modest_account_mgr_add_server_account): Set the secure-connection
262 conf key for transport accounts as well as store accounts. I don't know
263 why the if was there. For instance, this makes sure that we use SSL
264 for the gmail preset from the easysetup wizard.
266 2007-05-22 Murray Cumming <murrayc@murrayc.com>
268 * src/gnome/modest-main-window.c:
269 (on_account_store_connecting_finished), (connect_signals):
270 * src/maemo/modest-main-window.c:
271 (on_account_store_connecting_finished), (connect_signals),
272 (modest_main_window_new):
273 Handle TnyAccountStore::connecting-finished instead of
274 TnyDevice::connection-changed, because we cannot actually perform
275 operations on accounts until TnyAccountStore has itself responded to
276 the TnyDevice::connection-changed signal. This prevents a GError from
278 Do not try to update at startup, because we (at least on scratchbox)
279 already do an update at startup when the device goes online.
280 This prevents a GError from tinymail.
281 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
282 Added TODO about stopping simultaneous operations.
284 2007-05-21 Murray Cumming <murrayc@murrayc.com>
286 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
287 * src/modest-mail-operation-queue.c:
288 (modest_mail_operation_queue_remove):
289 * src/modest-tny-account-store.c: When GErrors happen, give more clues
290 about where they happened.
292 2007-05-21 Murray Cumming <murrayc@murrayc.com>
294 * src/modest-ui-actions.c:
295 (modest_ui_actions_on_password_requested): Make sure that the remember
296 output parameter is always TRUE.
298 2007-05-21 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
301 Show a OK/Cancel dialog if the error is a question, though we still do not
302 know anything more about what we are asking the user.
303 * src/widgets/modest-folder-view.c: (on_drag_data_received):
304 Fix an uninitialized variable (helper). This is a logic error, however.
306 2007-05-21 Christian Kellner <ckellner@openismus.com>
308 * src/modest-search.h:
309 Correct bit shifting in the ModestSearchFlags enum.
311 2007-05-21 Murray Cumming <murrayc@murrayc.com>
313 * src/modest-tny-account.c:
314 (modest_tny_account_new_from_server_account): Do not use the lsub and
315 check-all hard-coded IMAP options when using POP.
317 2007-05-21 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-tny-account.c:
320 (modest_tny_account_new_from_server_account):
321 Use NULL for the secure-auth method for POP when Password auth has been
322 specified by the user, as we already do for IMAP. "auth=Login" causes
323 an error from camel or the server.
325 2007-05-17 Murray Cumming <murrayc@murrayc.com>
327 * src/maemo/modest-account-settings-dialog.c:
328 (create_page_account_details),
329 (modest_account_settings_dialog_set_account_name):
330 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
331 for the leave-on-server checkbox, rathr than just the checkbox, when
332 the protocol is not POP.
334 2007-05-17 Murray Cumming <murrayc@murrayc.com>
336 * src/widgets/modest-account-view.c:
337 * src/widgets/modest-account-view.h:
338 Added modest_account_view_select_account() which will be useful later
339 to asynchronously re-select the edited account.
341 2007-05-17 Murray Cumming <murrayc@murrayc.com>
343 * src/maemo/modest-account-settings-dialog.c:
344 (modest_account_settings_dialog_set_account_name):
345 Automatically choose the port numbers based on the secure authentication
346 methods, if they have not been chosen before.
347 This fixes projects.maemo.org bug NB#56273 .
349 2007-05-17 Murray Cumming <murrayc@murrayc.com>
351 * src/maemo/modest-main-window-ui.h:
352 * src/modest-ui-actions.c:
353 * src/modest-ui-actions.h:
354 Connect the Tools/SMTP Servers menu item to
355 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
356 SMTP servers dialog, as in the UI specification and saves changes when it
357 is closed. This fixed projects.maemo.org bug NB#56305 .
359 2007-05-17 Murray Cumming <murrayc@murrayc.com>
361 * src/maemo/modest-connection-specific-smtp-window.c:
362 (modest_connection_specific_smtp_window_init):
363 Use gtk_window_set_default_size() to make this window big enough, so
364 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
366 2007-05-17 Murray Cumming <murrayc@murrayc.com>
368 * src/maemo/modest-connection-specific-smtp-edit-window.h:
369 * src/maemo/modest-connection-specific-smtp-edit-window.c:
370 (modest_connection_specific_smtp_edit_window_init),
371 Do not try to connect to a combobox signal before the combobox exists.
372 This fixes the cras in projects.maemo.org bug NB#56288 .
373 (modest_connection_specific_smtp_edit_window_get_settings):
374 Remove the server_account_name parameter which was being checked for NULL
375 though it was not used.
377 * src/maemo/modest-connection-specific-smtp-window.c:
378 (modest_connection_specific_smtp_window_fill_with_connections),
379 (on_button_edit), (modest_connection_specific_smtp_window_init):
380 Correct the number of treemodel columns to prevent a warning.
381 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
382 libconic does not work.
384 2007-05-16 Murray Cumming <murrayc@murrayc.com>
386 * src/modest-tny-account.c:
387 (modest_tny_account_new_from_server_account):
388 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
389 SMTP when "None" was chosen by the user. However, with my SMTP server that
390 does not support ANONYMOUS, the emails do not leave the Outbox and I see
393 2007-05-16 Murray Cumming <murrayc@murrayc.com>
395 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
396 to explain the memory management issue with the ID in the ModestPair.
398 * src/gnome/modest-account-assistant.c: (add_receiving_page),
399 (add_sending_page), (modest_account_assistant_finalize):
400 * src/gnome/modest-gnome-global-settings-dialog.c:
401 (create_updating_page), (create_composing_page):
402 * src/gnome/modest-msg-edit-window.c: (get_transports),
403 (init_window), (modest_msg_edit_window_finalize),
404 (modest_msg_edit_window_get_msg_data):
405 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
406 * src/gnome/modest-transport-widget.c:
407 (modest_transport_widget_finalize), (smtp_configuration):
408 * src/maemo/modest-maemo-global-settings-dialog.c:
409 (create_updating_page), (create_composing_page):
410 * src/maemo/modest-msg-edit-window.c: (get_transports),
411 (init_window), (modest_msg_edit_window_finalize),
412 (modest_msg_edit_window_get_msg_data),
413 (modest_msg_edit_window_free_msg_data):
414 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
415 (modest_store_widget_finalize):
416 * src/maemo/modest-transport-widget.c:
417 (modest_transport_widget_finalize), (smtp_configuration):
418 * src/modest-main.c: (send_mail):
419 * src/widgets/modest-combo-box.h:
420 * src/widgets/modest-global-settings-dialog-priv.h:
421 * src/widgets/modest-global-settings-dialog.c:
422 (modest_global_settings_dialog_finalize):
423 * src/widgets/modest-msg-edit-window.h:
424 Whenever using modest_combo_box_new(), keep the ModestPairList alive
425 as long as the combo box, to prevent use of freed memory for the ID.
427 2007-05-15 Murray Cumming <murrayc@murrayc.com>
429 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
430 get_accounts(), to make this clearer. Do not check for the enabled gconf
431 key, because we do not use this for server accounts (at least, not yet).
432 This allows us to send email again.
434 2007-05-15 Murray Cumming <murrayc@murrayc.com>
436 * src/maemo/modest-platform.c:
437 (on_modest_conf_update_interval_changed), (modest_platform_init):
438 Only respond to this particular key change. All these strcmp()s cannot be
441 2007-05-15 Murray Cumming <murrayc@murrayc.com>
443 * src/maemo/modest-maemo-global-settings-dialog.c:
444 (current_connection): Prevent a crash in scratchbox when
445 ny_maemo_conic_device_get_current_iap_id() returns NULL.
446 * src/maemo/modest-platform.c:
447 (on_modest_conf_update_interval_changed), (modest_platform_init):
448 Get the update interval from gconf and reset it when the gconf key changes.
450 2007-05-15 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-protocol-info.c:
453 * src/modest-protocol-info.h: Adde enum-specific get functions,
454 instead of using a ModestProtocolType enum parameter.
456 * src/gnome/modest-account-assistant.c:
457 * src/gnome/modest-store-widget.c:
458 * src/gnome/modest-store-widget.h:
459 * src/gnome/modest-transport-widget.c:
460 * src/gnome/modest-transport-widget.h:
461 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
462 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
463 * src/maemo/easysetup/modest-easysetup-wizard.c:
464 * src/maemo/modest-account-settings-dialog.c:
465 * src/maemo/modest-account-settings-dialog.h:
466 * src/maemo/modest-store-widget.c:
467 * src/maemo/modest-store-widget.h:
468 * src/maemo/modest-transport-widget.c:
469 * src/maemo/modest-transport-widget.h:
470 * src/modest-account-mgr-helpers.c:
471 * src/modest-account-mgr-helpers.h:
472 * src/modest-account-mgr.c:
473 * src/modest-account-mgr.h:
474 * src/modest-tny-account.c:
475 * src/modest-tny-folder.c:
476 * src/widgets/modest-account-view.c:
477 * src/widgets/modest-retrieve-combo-box.c:
478 * src/widgets/modest-retrieve-combo-box.h:
479 * src/widgets/modest-secureauth-combo-box.c:
480 * src/widgets/modest-serversecurity-combo-box.c:
481 * src/widgets/modest-serversecurity-combo-box.h:
482 * tests/check_account-mgr.c:
483 Use the specific functions, and use the re-renamed enum values for GNOME too.
485 2007-05-15 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
489 so we can get the second based on the first.
491 * src/maemo/modest-account-settings-dialog.h:
492 * src/maemo/modest-account-settings-dialog.c:
493 Added get_supported_secure_authentication_methods(), though it is mostly
494 commented-out for now until the necessary API is committed to tinymail.
495 (modest_account_settings_dialog_set_account_name),
496 (save_configuration): Request the supported authentication methods from the
497 server, so we can choose a working method.
499 * src/modest-tny-account-store.h:
500 * src/modest-tny-account-store.c:
501 (modest_tny_account_store_get_session): Rename from
502 tny_account_store_get_session().
504 2007-05-14 Murray Cumming <murrayc@murrayc.com>
506 * src/modest-protocol-info.h: Split the ModestProtocol enum
507 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
508 There was no need to have these unrelated values in one enum.
510 * src/: many files: Adapted to changed enum. This makes the code a bit
511 clearer, and the compiler could catch some errors.
513 2007-05-14 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
516 Show the detailed internal camel error message when an error happens
517 during the configuration, so that our testers can give us more clues.
518 For instance, in projects.maemo.org bug NB#56910 .
520 2007-05-14 Murray Cumming <murrayc@murrayc.com>
522 * src/modest-tny-account.c:
523 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
524 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
526 2007-05-14 Murray Cumming <murrayc@murrayc.com>
528 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
529 * src/maemo/modest-account-settings-dialog.c:
530 (modest_account_settings_dialog_set_account_name),
531 (save_configuration): For the incoming secure authentication checkbox,
532 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
533 the UI specification. PLAIN does not seem to be supported for most IMAP
534 servers anyway, and I am not sure what it would mean.
535 However, we probably need to discover which of the secure-authentication
536 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
537 * src/modest-account-mgr-helpers.c:
538 (modest_account_mgr_get_server_account_data):
540 * src/modest-tny-account.c:
541 (modest_tny_account_new_from_server_account):
542 Use tny_account_set_mech() to set secure-authentication methods,
543 with some special-casing for IMAP, based on my observations of how
546 * src/modest-account-mgr-helpers.h:
547 * src/modest-account-mgr.c:
548 * src/modest-defs.h: Comment that the URI is only used for local folders.
550 2007-05-11 Murray Cumming <murrayc@murrayc.com>
552 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
553 parameter const, just to be neat.
554 * src/modest-text-utils.c: (modest_text_utils_inline):
555 End g_strconcat() with NULL, as its documentation says. This is almost
556 certainly the cause of my crash at startup on the device. Interestingly,
557 valgrind doesn't tell us about these errors.
559 2007-05-11 Murray Cumming <murrayc@murrayc.com>
561 * scripts/build-packages: Added more precise comments about how to use
562 this script, though I still get this error:
563 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
564 error building tinymail
566 2007-05-11 Murray Cumming <murrayc@murrayc.com>
568 * src/maemo/modest-main-window.c: (on_account_update):
569 Very slight cleanup, hoping to make it simpler to discover what causes
570 a crash here sometimes.
572 * src/modest-tny-account.c:
573 (modest_tny_account_new_from_server_account): Set the port. Added
574 comments about the options and a TODO comment because I need to find out
575 how to specify the secure authentication method.
577 2007-05-11 Marcus Bauer <marcusb@openismus.com>
579 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
580 changed CFlags paths form modest to libmodest
582 2007-05-10 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-account-mgr-helpers.c:
585 (modest_account_mgr_get_server_account_data),
586 (modest_account_mgr_free_server_account_data):
587 * src/modest-account-mgr-helpers.h:
588 * src/modest-account-mgr.c:
589 (modest_account_mgr_add_server_account):
591 * src/modest-tny-account.c:
592 (modest_tny_account_new_from_server_account):
593 Determine the options for tny_camel_account_add_option() here,
594 based on the settings, rather than storing them directly in gconf.
596 2007-05-10 Murray Cumming <murrayc@murrayc.com>
598 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
599 Show a more friendly error dialog now that we expect (from the tinymail
600 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
602 2007-05-10 Murray Cumming <murrayc@murrayc.com>
604 * src/maemo/modest-main-window.c: (on_account_update): Check that
605 account_name is not NULL, to prevent a crash at startup that I am
606 seeing on the N800. I do wonder why it is NULL.
608 * src/maemo/easysetup/modest-easysetup-wizard.c:
609 (create_page_user_details):
610 * src/maemo/modest-account-settings-dialog.c:
611 (create_page_user_details), (create_page_outgoing):
612 * src/maemo/modest-connection-specific-smtp-edit-window.c:
613 (modest_connection_specific_smtp_edit_window_init):
614 * src/modest-ui-actions.c:
615 (modest_ui_actions_on_password_requested):
616 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
617 might do something useful with the on-screen keyboard.
619 2007-05-10 Murray Cumming <murrayc@murrayc.com>
621 * src/maemo/modest-main-window.c: (on_account_update):
622 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
623 NULL, to avoid lots of warnings. However, it probably should not be NULL.
625 2007-05-09 Murray Cumming <murrayc@murrayc.com>
627 * src/modest-tny-account-store.c: (on_account_changed):
628 Correct the signature of this signal handler.
630 2007-05-09 Murray Cumming <murrayc@murrayc.com>
632 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
633 Show a HildonNote instead of a GtkDialog for Maemo.
635 2007-05-09 Murray Cumming <murrayc@murrayc.com>
637 * src/widgets/modest-account-view.h:
638 * src/widgets/modest-account-view.c: (on_account_changed),
639 (on_account_removed). Added a boolean flag, set/unset by
640 modest_account_view_block_conf_updates(),
641 modest_account_view_unblock_conf_updates() to prevent unnecessary
642 updates, but this is not very useful because the gconf notifications are
643 so delays (maybe only on Maemo Bora).
644 So auto-updating is turned off, and these functions do an explicit
645 update when necessary.
646 However, something else is still doing too much work when adding/removing
647 accounts, probably in another part of the application.
649 * src/maemo/modest-account-view-window.c:
650 (on_delete_button_clicked), (on_edit_button_clicked),
651 (on_new_button_clicked): Use the new functions.
653 2007-05-09 Murray Cumming <murrayc@murrayc.com>
655 * src/modest-account-mgr-helpers.c:
656 (modest_account_mgr_set_first_account_as_default):
657 Sort the list of names alphabetically-by-title, so we choose the first one
659 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
660 alphabetically by the title.
662 This fixes projects.maemo.org bug NB#56418 .
664 * src/modest-account-mgr-priv.c:
665 (_modest_account_mgr_account_from_key):
666 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
667 avoid a valgrind error, and possible random behaviour.
669 2007-05-09 Murray Cumming <murrayc@murrayc.com>
671 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
672 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
673 tinymail documentation to say that this can be expected.
674 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
675 pretty, and should not happen, but I would prefer to know when it does.
677 2007-05-09 Murray Cumming <murrayc@murrayc.com>
679 * configure.ac: When using the older hildon version, probably on Bora,
680 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
682 * src/widgets/modest-attachment-view.c:
683 (modest_attachment_view_set_part_default): Initialize variables, to fix the
686 2007-05-09 Marcus Bauer <marcusb@openismus.com>
688 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
689 Implemented the prototype. Can be tested with
690 tests/dbus_api/test_open_message:
692 2007-05-08 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-tny-account-store.c:
695 (modest_tny_account_store_instance_init), (get_password):
696 * src/modest-ui-actions.c:
697 (modest_ui_actions_on_password_requested):
698 Do not store the password in gconf, because this function is called
699 for non-remembered passwords. Actually use the cached (in the hash map)
700 password instead of releasing it.
701 The password will now not be remembered if it is asked via the protected
702 password dialog, as per the UI spec.
704 2007-05-08 Murray Cumming <murrayc@murrayc.com>
707 * src/modest-account-mgr-helpers.h:
708 * src/modest-account-mgr-helpers.c:
709 Added modest_server_account_get_username_has_succeeded(),
710 modest_server_account_set_username_has_succeeded().
711 (modest_server_account_set_username),
712 Reset the has-succeeded flag if the username changes.
714 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
715 * src/maemo/modest-connection-specific-smtp-window.c:
716 (modest_connection_specific_smtp_window_save_server_accounts):
717 Use modest_server_account_set_username() instead of using
718 modest_conf_set_string() directly, so that the has-succeeded flag is always
721 * src/modest-ui-actions.c:
722 (modest_ui_actions_on_password_requested): Dim the username entry if
723 the username has ever worked, as per the UI spec.
725 2007-05-08 Murray Cumming <murrayc@murrayc.com>
727 * src/modest-tny-account-store.c: (get_password):
728 * src/modest-ui-actions.c:
729 (modest_ui_actions_on_password_requested):
730 Allow the username to be changed too, though there is more work to
731 be done on exactly how this behaves.
733 2007-05-08 Murray Cumming <murrayc@murrayc.com>
735 * src/modest-account-mgr-helpers.h:
736 * src/modest-account-mgr-helpers.c:
737 Added modest_account_mgr_get_display_name(),
738 modest_server_account_get_username(),
739 modest_server_account_set_username(),
740 modest_server_account_set_password(),
741 modest_server_account_get_hostname() functions so we do not need to
742 use the conf API directly.
744 * src/maemo/modest-main-window.c: (connect_signals):
745 Actually connect ot the ModestAccountStore::request-password signal,
746 so that we show the dialog when the password is requested by Tinymail,
747 for isntance if it is empty.
749 * src/modest-marshal.list:
750 * src/modest-tny-account-store.c:
751 (modest_tny_account_store_class_init), (get_password),
752 (modest_tny_account_store_alert):
753 * src/modest-tny-account-store.h:
754 * src/modest-ui-actions.h:
755 * src/modest-ui-actions.c:
756 (modest_ui_actions_on_password_requested):
757 Change the signal parameters, so it is obvious that we are providing
758 the non human-readable server name, and receiving both the username
759 and password, though changing of the username is not yet implemented.
760 Change the dialog UI to match the Maemo UI specifications, with #idfefing
761 for the GNOME version.
763 This should fix the projects.maemo.org bug NB#56209, though it does not
764 work on Bora, because the gconf_client_get() for the password fails
765 immediately after we save it with gconf_client_set().
767 2007-05-08 Murray Cumming <murrayc@murrayc.com>
770 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
771 caused an undefined symbol error:
772 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
774 2007-05-08 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-tny-account-store.c:
777 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
778 using a GError instead of a string message, so we can translate it in
781 2007-05-08 Murray Cumming <murrayc@murrayc.com>
783 * src/maemo/modest-address-book.c:
784 (modest_address_book_check_names):
785 * src/maemo/modest-msg-view-window.c:
786 (modest_msg_view_window_clipboard_owner_change):
787 * src/modest-init.c: (modest_init_init_ui):
788 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
789 (update_folders_cb), (modest_mail_operation_update_account):
790 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
791 (modest_ui_actions_on_msg_attachment_clicked),
792 (modest_ui_actions_on_msg_recpt_activated):
793 * src/widgets/modest-header-view.c: (drag_data_get_cb):
794 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
795 (modest_msg_view_search_next):
796 * src/widgets/modest-recpt-editor.c:
797 (modest_recpt_editor_on_button_release_event),
798 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
799 g_message(). At this point we should only be seeing interesting errors on
800 stdout. Debugging messages could be #ifdefed-out if they are still useful.
802 2007-05-07 Murray Cumming <murrayc@murrayc.com>
804 (modest_wizard_dialog_force_title_update):
805 * src/maemo/easysetup/modest-wizard-dialog.h:
806 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
807 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
808 can update the title when appropriate. Otherwise the title is wrong if the
809 pages are added after adding the notebook to the dialog.
810 This must be a problem in HildonWizardDialog too.
811 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
813 * src/maemo/easysetup/modest-easysetup-wizard.c:
814 (create_subsequent_customsetup_pages),
815 (create_subsequent_easysetup_pages):
816 Call modest_wizard_dialog_force_title_update() so that the title is
817 correct even with GTK+ < 2.10.
818 This fixes projects.maemo.org bug NB#56145 .
820 2007-05-07 Murray Cumming <murrayc@murrayc.com>
822 * src/maemo/modest-platform.c:
823 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
824 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
827 2007-05-07 Murray Cumming <murrayc@murrayc.com>
829 * src/widgets/modest-window.h:
830 * src/widgets/modest-window.c: Added a save_state_func vfunc,
831 and modest_window_save_state(), which invokes it.
833 * src/widgets/modest-window-mgr.h:
834 * src/widgets/modest-window-mgr.c:
835 Added modest_window_mgr_save_state_for_all_windows(), which calls
836 the save_state vfunc on all registered windows, if implemented.
838 * src/gnome/modest-msg-edit-window.c:
839 * src/gnome/modest-msg-view-window.c:
840 * src/maemo/modest-msg-edit-window.c:
841 * src/maemo/modest-msg-view-window.c:
842 * src/maemo/modest-main-window.c:
843 Specify the existing save_settings functions as implementations of
844 ModestWindow::save_state_func().
846 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
847 Call modest_window_mgr_save_state_for_all_windows(). This happens before
848 enabling hibernation, for instance.
850 We may need to do the same thing for restoring settings.
853 2007-05-07 Murray Cumming <murrayc@murrayc.com>
855 * src/widgets/modest-window-mgr.c:
856 * src/widgets/modest-window-mgr.h:
857 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
858 modest_window_mgr_get_hibernation_is_prevented().
860 * src/maemo/modest-main-window.c:
861 (on_hildon_program_is_topmost_notify): Prevent hibernation
862 (possible when the application goes to the background in the WM),
863 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
865 * src/maemo/easysetup/modest-easysetup-wizard.c:
866 (modest_easysetup_wizard_dialog_init):
867 * src/maemo/modest-account-settings-dialog.c:
868 (modest_account_settings_dialog_init):
869 * src/maemo/modest-connection-specific-smtp-edit-window.c:
870 (modest_connection_specific_smtp_edit_window_init):
871 * src/maemo/modest-connection-specific-smtp-window.c:
872 (modest_connection_specific_smtp_window_init):
873 * src/maemo/modest-signature-editor-dialog.c:
874 (modest_signature_editor_dialog_init):
875 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
876 prevent hibernation while any of these account settings dialogs are open.
878 2007-05-04 Murray Cumming <murrayc@murrayc.com>
880 * src/maemo/Makefile.am:
881 * src/maemo/modest-osso-state-saving.c:
882 * src/maemo/modest-osso-state-saving.h: Added
883 modest_osso_load_state() and modest_osso_save_state() though they do
884 nothing now. They should iterate through all the open windows and load/save
886 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
887 save state when closing.
889 * src/maemo/modest-main-window.c:
890 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
891 Add a notification handler for the HildonProgram::is-topmost property,
892 so we can allow hibernation when the application goes into the background.
893 But we still need to detect when the accounts setup windows are open so
894 we can stop hibernation when they are open.
895 To do this, I also added the main window the HildonProgram. This might have
896 other side-effects/benefits, and should maybe be done for other windows.
898 * src/maemo/modest-osso-autosave-callbacks.h:
899 * src/maemo/modest-osso-autosave-callbacks.c:
900 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
901 though it does not do anything yet, and we might never need this to do
902 anything. For instance, we already save drafts.
904 * src/maemo/modest-platform.c: (modest_platform_init):
905 Specify the libosso auto-save callback.
907 2007-05-03 Murray Cumming <murrayc@murrayc.com>
909 * src/maemo/modest-platform.c:
910 (modest_platform_set_update_interval):
911 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
912 aparently stays valid between application instances, so we can use this
913 to remove and reset it later. According to a maemo-developers email from
916 2007-05-03 Murray Cumming <murrayc@murrayc.com>
918 * configure.ac: Depend on libalarm for Maemo.
920 * src/dbus_api/modest-dbus-api.h:
921 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
922 (on_send_receive), (modest_dbus_req_handler):
923 Handle a SEND_RECEIVE D-Bus method.
925 * libmodest-dbus-client/libmodest-dbus-client.c:
926 (libmodest_dbus_client_send_and_receive):
927 * libmodest-dbus-client/libmodest-dbus-client.h:
928 Add C convenience functions for calling the new D-Bus method.
930 * src/modest-platform.h:
931 * src/gnome/modest-platform.c:
932 * src/maemo/modest-platform.c:
933 Added modest_platform_set_update_interval(), which uses the
935 (modest_platform_init),
936 Call modest_platform_set_update_interval(), using a hard-coded
937 interval for now (until the global settings dialog is implemented),
938 though I am not sure that this makes sense yet.
940 2007-05-02 Murray Cumming <murrayc@murrayc.com>
942 * src/dbus_api/modest-dbus-callbacks.c:
943 (modest_osso_cb_hw_state_handler):
944 * src/dbus_api/modest-dbus-callbacks.h:
945 * src/maemo/modest-platform.c: (modest_platform_init):
946 Registered (empty) callbacks for the osso hardware state D-Bus signals,
947 in case this has some effect on the ability for Maemo to ping the
950 2007-05-02 Murray Cumming <murrayc@murrayc.com>
952 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
953 Comment out an if() that checks a gchar for < 0, causing a build-breaking
954 warning. It is probably a logic error, but I need to fix the build.
956 2007-05-02 Murray Cumming <murrayc@murrayc.com>
958 * src/modest-account-mgr.h:
959 * src/modest-account-mgr.c:
960 (modest_account_mgr_account_names): Add a gboolean enabled_only
961 parameter, so we can get lists of onlt the enabled accounts.
963 (modest_account_mgr_add_account),,
964 (modest_account_mgr_account_with_display_name_exists):
965 * src/maemo/modest-msg-edit-window.c: (get_transports):
966 * src/modest-account-mgr-helpers.c:
967 (modest_account_mgr_set_first_account_as_default):
968 * src/modest-init.c: (init_default_account_maybe):
969 * src/modest-tny-account-store.c: (get_accounts):
970 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
971 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
972 * tests/check_account-mgr.c: (START_TEST):
973 Provide the extra parameter, as appropriate.
975 * src/widgets/modest-account-view.c: (update_account_view):
976 Do not show disabled accounts (meaning that there is no way to
977 enable/disable accounts in the UI (the feature is not in our UI
978 specification), so we can use this internally only to mark unfinished
979 or temporary account data.
981 * src/maemo/easysetup/modest-easysetup-wizard.c:
982 (create_account): Add boolean enable parameter, so we can specify FALSE
983 to create the temporary account.
984 (on_button_edit_advanced_settings): Create the temporary account as disabled.
985 (on_before_next): When finishing, when there is a temporary account, just
987 Also, use a timeout to delay the showing of the dialog until gconf is likely
988 to return correct information, due to a maemo gconf bug that is fixed in
989 osso 1.1, but not yet in Bora.
990 However, the dialog stays on screen after it is destroyed.
992 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
993 for invalid data when cancelling. Use a hildon note instead of a dialog
994 to complain about invalid data. Do not show the account-saved note if the
995 account is disabled (a temporary account that will not really be saved for use
998 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1000 * src/modest-account-mgr-helpers.h:
1001 * src/modest-account-mgr-helpers.c:
1002 Added modest_account_mgr_unset_default_account(),
1003 Added modest_account_mgr_set_first_account_as_default().
1005 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1006 If it was the default account, unset the default account name.
1008 * src/maemo/modest-account-view-window.c:
1009 (on_delete_button_clicked): If it was the default account,
1010 set the first remaining account as the default instead.
1012 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1013 a NULL account or a NULL default account, to prevent a crash. This should
1014 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1017 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1019 * src/widgets/modest-recpt-editor.c:
1020 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1021 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1022 TODO comment for this. This fixes the build.
1024 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1025 be the best place for it. This will in future update all auto-update accounts,
1026 rather than just the current/default account, when that gconf key exists.
1027 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1028 if there are no accounts, before calling do_send_receive().
1029 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1031 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1032 * src/maemo/modest-main-window-ui.h:
1033 * src/maemo/modest-main-window.c: (on_connection_changed),
1034 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1035 directly, becaue the signal handler does more.
1037 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1039 * src/modest-account-mgr-helpers.c:
1040 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1041 for the case that the account does not exist.
1043 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1044 (equivalent to the modest account name) rather than the tinymail account name
1045 (equivalent to the modest account title - human readable) to get the account data.
1046 Check for null account data to prevent the crash, and add a TODO comment saying that
1047 this needs fixing because it is using the server account name instead of the account name.
1049 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1051 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1052 * src/maemo/modest-account-settings-dialog.c: (show_error),
1054 Use hildon_note_new_information() for informative and error messages,
1055 which seems to be expected for Maemo applications (no documentation that I know of
1056 says this). I am surprised that there is no distinction between info and error
1059 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1061 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1062 it is easy to find where this is used.
1064 * src/maemo/easysetup/modest-easysetup-wizard.c:
1065 (create_page_welcome), (create_page_account_details),
1066 (create_page_user_details), (create_page_complete_easysetup),
1067 (create_page_custom_incoming), (create_page_custom_outgoing),
1068 (create_page_complete_custom):
1069 * src/maemo/modest-account-settings-dialog.c:
1070 (create_page_account_details), (create_page_user_details),
1071 (create_page_incoming), (create_page_outgoing):
1072 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1073 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1074 (modest_connection_specific_smtp_edit_window_init):
1075 * src/maemo/modest-connection-specific-smtp-window.c:
1076 (modest_connection_specific_smtp_window_init):
1077 * src/maemo/modest-signature-editor-dialog.c:
1078 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1079 and scrolling policy as per the Email Application Layout Guide, if I have
1082 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1085 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1086 which were empty, because these vfuncs have been removed from TnyAccountStore.
1087 This fixes the build.
1089 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1091 * src/maemo/modest-main-window.c:
1092 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1093 showing/hiding it. Added TODO because it probably should not be NULL.
1094 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1095 because unnecessary g_warnings() make degugging difficult.
1097 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1099 * src/maemo/modest-msg-edit-window.c:
1100 (modest_msg_edit_window_select_color),
1101 (modest_msg_edit_window_select_background_color): 2 const corrections and
1102 moving 2 #endifs before closing brackets, to fix the build.
1104 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/easysetup/modest-easysetup-wizard.h:
1107 * src/maemo/easysetup/modest-easysetup-wizard.c:
1108 (modest_easysetup_wizard_dialog_finalize),
1109 (on_button_edit_advanced_settings), (create_page_complete_custom),
1110 (on_response), (create_account):
1111 Implement the Advanced Settings edit button, by saving the account information,
1112 for the Advanded Settings dialog to use directly from gconf, and removing it
1113 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1114 Bug #5533 in the projects.maemo.org bugzilla.
1116 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1118 * src/maemo/modest-msg-view-window.c:
1119 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1120 when opening a message window.
1122 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1124 * src/maemo/easysetup/modest-easysetup-wizard.c:
1125 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1128 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1129 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1130 gconf settings. I probably added more checks than necessary, but that is safer.
1132 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1133 variable to fix the build, but this seems to be used when it is still NULL.
1135 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1137 * src/modest-platform.h:
1138 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1139 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1140 * src/modest-main.c: Implement this function so we can avoid using
1141 maemo-specific API from cross-platform code.
1143 * src/modest-tny-account-store.c:
1144 (get_smtp_specific_transport_account_for_open_connection):
1145 * src/modest-ui-actions.c: (check_for_connection),
1146 (modest_ui_actions_on_item_not_found):
1147 Use modest_platform_connect_and_wait() and put #idefs around other
1148 maemo-specific code, because only maemo currently has a way to
1149 identify connection names.
1151 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1153 * src/modest-tny-account-store.h:
1154 * src/modest-tny-account-store.c:
1155 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1156 the connection-specific SMTP server settings in the configuration.
1158 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1160 * src/maemo/modest-main-window.c: (on_connection_changed),
1162 * src/modest-main.c: (main), (start_ui), (send_mail):
1163 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1164 that is what is intended.
1166 * src/modest-ui-actions.c: (action_send), (action_receive),
1167 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1168 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1169 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1170 SMTP server is used when it is specified.
1172 (modest_ui_actions_on_send_receive):
1173 Check that a connection is open before proceeding.
1174 Receive and then send, instead of vice-versa, as per the specification.
1176 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1178 * src/modest-mail-operation.c:
1179 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1180 though I guess it should be something other than NULL.
1182 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1184 * src/maemo/easysetup/modest-easysetup-wizard.c:
1185 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1186 combo twice, to avoid an g_warning and to make it visible again.
1187 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1188 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1189 (already intended) dereference when detaching, because we then recreate the menu.
1190 But I am not sure why the warning was happening, and it is possible that this is a memory
1193 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1195 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1196 and uri_parse_mailto() utility functions.
1197 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1199 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1201 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1203 * src/dbus_api/modest-dbus-api.h:
1204 * src/dbus_api/modest-dbus-callbacks.c:
1205 Use an idle callback to execute the modest code in the application's own thread.
1206 Remove the helloworld example method.
1207 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1208 parsed, and the open-message method is not implemented because this is not yet implemented in
1210 * libmodest-dbus-client/libmodest-dbus-client.c:
1211 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1212 (libmodest_dbus_client_open_message):
1213 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1215 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1216 body without crashing.
1218 * tests/dbus_api/Makefile.am:
1219 * tests/dbus_api/test_mail_to.c:
1220 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1222 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1224 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1225 Added file to fix the build. Sorry.
1227 * src/dbus_api/Makefile.am:
1228 * src/dbus_api/modest-dbus-api.h:
1229 * src/dbus_api/modest-dbus-callbacks.h:
1230 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1231 (modest_dbus_req_handler):
1232 Put constants in a separate header so it can be reused by the
1233 client library, without duplication
1235 * libmodest-dbus-client/Makefile.am:
1236 * libmodest-dbus-client/libmodest-dbus-client.c:
1237 (libmodest_dbus_client_call_helloworld),
1238 (libmodfest_dbus_client_send_mail),
1239 (libmodfest_dbus_client_mailto),
1240 (libmodfest_dbus_client_open_message):
1241 * libmodest-dbus-client/libmodest-dbus-client.h:
1242 (Partly) Implement a send_mail D-Bus method.
1244 * tests/dbus_api/Makefile.am:
1245 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1246 the send_email D-Bus method.
1248 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1252 * libmodest-dbus-client/Makefile.am:
1253 * libmodest-dbus-client/libmodest-dbus-client.c:
1254 * libmodest-dbus-client/libmodest-dbus-client.h:
1255 * tests/dbus_api/Makefile.am:
1256 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1257 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1259 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1261 * src/maemo/easysetup/modest-easysetup-wizard.c:
1262 (create_page_account_details):
1263 * src/maemo/modest-account-settings-dialog.c:
1264 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1265 widgets, because this might not be the default in future versions of the Maemo GTK+.
1266 However, I can not not get capitalization to work even in a simple test case.
1268 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/easysetup/modest-easysetup-wizard.c:
1271 (create_page_custom_incoming), (create_page_custom_outgoing):
1272 * src/maemo/modest-account-settings-dialog.c:
1273 (create_page_account_details), (create_page_incoming),
1274 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1275 instead of using gtk_check_button_with_label(), so they are aligned like the other
1276 widgets, as per the UI spec.
1278 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1280 * src/maemo/easysetup/modest-easysetup-wizard.c:
1281 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1282 * src/widgets/modest-validating-entry.c:
1283 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1284 Modest prefix instead of an EasySetup prefix.
1286 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1288 * src/widgets/modest-validating-entry.h:
1289 * src/widgets/modest-validating-entry.c: (on_insert_text),
1290 Added easysetup_validating_entry_set_max_func(), used to set a callback
1291 to call when the max number of characters is reached. GtkEntry has a max-length
1292 already but is silent about it.
1294 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1295 (create_page_account_details), (create_page_user_details),
1297 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1298 (create_page_account_details), (create_page_user_details),
1299 (create_page_outgoing):
1300 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1301 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1302 the UI spec, when the user tries to enter more than the max number of characters.
1304 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/easysetup/modest-easysetup-wizard.c:
1307 (create_page_user_details), (create_page_custom_incoming),
1308 (create_page_custom_outgoing):
1309 * src/maemo/modest-account-settings-dialog.c:
1310 (create_page_user_details), (create_page_incoming),
1311 (create_page_outgoing):
1312 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1313 (modest_connection_specific_smtp_edit_window_init):
1314 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1315 not appropriate. Bad Maemo-specific defaults!.
1317 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1319 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1320 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1321 (modest_signature_editor_dialog_set_settings):
1322 Disable the label and textview when the checkbox is disabled, and use the
1323 specified (UI spec) default signature text.
1325 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1327 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1328 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1330 * src/modest-defs.h:
1331 * src/modest-account-mgr-helpers.h:
1332 * src/modest-account-mgr-helpers.c:
1333 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1335 * src/maemo/Makefile.am:
1336 * src/maemo/modest-signature-editor-dialog.c:
1337 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1340 * src/maemo/modest-account-settings-dialog.h:
1341 * src/maemo/modest-account-settings-dialog.c:
1342 (modest_account_settings_dialog_finalize), (on_button_signature),
1343 (save_configuration): Use the new dialog when the Edit button is pressed, and
1344 save the changes if necessary, as per the UI spec.
1346 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1348 * src/maemo/Makefile.am:
1349 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1350 based on maemo-develoers email from Dirk.
1352 * src/maemo/easysetup/modest-easysetup-wizard.c:
1353 (create_page_welcome), (create_page_account_details),
1354 (create_page_user_details), (create_page_complete_easysetup),
1355 (create_page_custom_incoming), (create_page_custom_outgoing),
1356 (create_page_complete_custom),
1357 (modest_easysetup_wizard_dialog_init):
1358 * src/maemo/modest-account-settings-dialog.c:
1359 (create_page_account_details), (create_page_user_details),
1360 (create_page_incoming), (create_page_outgoing),
1361 (modest_account_settings_dialog_init):
1362 * src/maemo/modest-connection-specific-smtp-window.c:
1363 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1365 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1367 * src/maemo/easysetup/modest-easysetup-wizard.c:
1368 (create_page_account_details), (create_page_custom_outgoing),
1369 (create_page_complete_custom):
1370 * src/maemo/modest-account-settings-dialog.c:
1371 (create_page_user_details), (create_page_incoming),
1372 (create_page_outgoing):
1373 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1374 (modest_connection_specific_smtp_edit_window_init):
1375 Use the correct (UI spec) port min/max, and use horizontal separators,
1378 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1380 * src/maemo/easysetup/modest-easysetup-wizard.c:
1381 (set_default_custom_servernames):
1382 * src/maemo/modest-account-settings-dialog.c:
1383 (create_page_incoming), (on_combo_outgoing_security_changed),
1384 (on_combo_incoming_security_changed), (create_page_outgoing),
1385 (modest_account_settings_dialog_set_account_name),
1386 (save_configuration):
1387 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1388 (on_combo_security_changed),
1389 (modest_connection_specific_smtp_edit_window_init),
1390 (modest_connection_specific_smtp_edit_window_set_connection),
1391 (modest_connection_specific_smtp_edit_window_get_settings):
1392 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1395 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1398 * src/maemo/easysetup/modest-easysetup-wizard.c:
1399 (create_page_custom_outgoing), (create_page_complete_custom):
1400 * src/maemo/modest-account-settings-dialog.c:
1401 (create_page_user_details), (create_page_outgoing):
1402 * src/maemo/modest-account-view-window.c: (button_box_new):
1403 Use changed logical IDs as per the most recent UI spec:
1404 mcen_bd_emailsetup_edit -> mcen_bd_edit
1405 mcen_bd_emailsetup_delete -> mcen_bd_delete
1406 mcen_bd_emailsetup_close -> mcen_bd_close
1408 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1412 * src/dbus_api/Makefile.am:
1413 * src/dbus_api/modest-dbus-callbacks.c:
1414 * src/dbus_api/modest-dbus-callbacks.h:
1415 * src/maemo/modest-platform.c: (modest_platform_init):
1416 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1418 * tests/Makefile.am:
1419 * tests/dbus_api/Makefile.am:
1420 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1422 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1424 * src/maemo/modest-account-settings-dialog.c:
1425 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1426 Removed unnecessary includes.
1428 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/easysetup/modest-easysetup-wizard.c:
1431 * src/maemo/modest-account-settings-dialog.c:
1432 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1433 * src/widgets/Makefile.am:
1434 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1435 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1436 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1437 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1438 * src/widgets/modest-secureauth-combo-box.c:
1439 * src/widgets/modest-secureauth-combo-box.h:
1440 * src/widgets/modest-serversecurity-combo-box.c:
1441 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1442 made the GObject names more consistent with the rest of the Modest code.
1444 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1446 * src/maemo/easysetup/Makefile.am:
1447 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1448 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1449 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1450 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1451 * src/maemo/easysetup/modest-easysetup-wizard.c:
1452 * src/maemo/easysetup/modest-validating-entry.c:
1453 * src/maemo/easysetup/modest-validating-entry.h:
1454 * src/maemo/modest-account-settings-dialog.c:
1455 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1456 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1457 widgets/ because they are used outside of easysetup too. After checking in,
1458 svn will allow me to rename them too.
1460 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1462 * src/gnome/modest-msg-edit-window.c:
1463 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1464 linker error, to fix the build on the GNOME platform.
1465 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1466 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1467 ifdefed out to avoid a warning.
1469 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1471 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1472 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1473 some alternative for GTK+ 2.6.
1475 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1479 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1480 specified for EmailAccountsDialog in UI spec.
1482 * src/maemo/easysetup/modest-easysetup-wizard.c:
1483 * src/maemo/easysetup/modest-easysetup-wizard.h:
1484 * src/maemo/modest-account-settings-dialog.c:
1485 * src/maemo/modest-account-settings-dialog.h:
1486 Reuse a member window widget for the connection-specific SMTP server accounts,
1487 so we can tell it to create/save the accounts only if we actually save changes.
1489 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1490 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1491 (modest_connection_specific_smtp_edit_window_get_settings):
1492 Return a struct instance for temporarily remembering the entered data.
1494 * src/maemo/modest-connection-specific-smtp-window.h:
1495 * src/maemo/modest-connection-specific-smtp-window.c:
1496 (modest_connection_specific_smtp_window_finalize),
1497 (modest_connection_specific_smtp_window_fill_with_connections),
1499 (modest_connection_specific_smtp_window_save_server_accounts),
1500 (update_model_server_names): Do not actually save data until asked,
1501 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1503 (on_selection_changed),
1504 (modest_connection_specific_smtp_window_init): Disable the edit
1505 button when nothing is selected.
1507 * src/modest-account-mgr-helpers.c:
1508 * src/modest-account-mgr-helpers.h:
1509 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1512 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-account-mgr-helpers.h:
1515 * src/modest-account-mgr-helpers.c:
1516 (modest_account_mgr_get_unused_account_name),
1517 (modest_account_mgr_get_unused_account_display_name): Added these
1518 utility functions, to avoid code duplication.
1520 * src/maemo/easysetup/modest-easysetup-wizard.c:
1521 (create_page_account_details), (create_account):
1522 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1523 (on_combo_security_changed),
1524 (modest_connection_specific_smtp_edit_window_init),
1525 (modest_connection_specific_smtp_edit_window_save_settings):
1526 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1527 * src/maemo/modest-connection-specific-smtp-window.c:
1528 (modest_connection_specific_smtp_window_finalize),
1529 (modest_connection_specific_smtp_window_fill_with_connections),
1530 (on_button_edit), (modest_connection_specific_smtp_window_init):
1531 * src/maemo/modest-connection-specific-smtp-window.h:
1532 Implementing saving of connection-specific server accounts.
1534 But I need to refactor this so we can save the data for each
1535 possible connection-specific account and only actually create the server accounts
1536 when the easysetup finished, or the OK button is pressed on the account settings
1539 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1541 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1542 (on_combo_security_changed):
1543 (modest_connection_specific_smtp_edit_window_init):
1544 Auto-fill the port number as in the account settings.
1546 (modest_connection_specific_smtp_edit_window_set_connection):
1547 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1548 * src/maemo/modest-connection-specific-smtp-window.c:
1549 (fill_with_connections), (on_button_edit),
1550 (modest_connection_specific_smtp_window_init):
1551 Turn the edit window into a dialog to simplify the code, and
1552 set a WM hint as in a GtkDialog, because only a popup can be on top of
1553 another window in Maemo, and popups usually have no WM decoration.
1555 * src/modest-defs.h:
1556 * src/modest-account-mgr-helpers.c:
1557 (modest_account_mgr_set_connection_specific_smtp),
1558 (modest_account_mgr_remove_connection_specific_smtp),
1559 (modest_account_mgr_get_connection_specific_smtp):
1560 * src/modest-account-mgr-helpers.h: Some functions to write the
1561 connection-specific SMTP server information. Not yet used.
1564 * src/widgets/modest-folder-view.c: (text_cell_data):
1565 Fix a warning about an uninitialized variable.
1566 (on_configuration_key_changed): Put an #ifdef around the use
1567 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1569 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1571 * src/maemo/modest-account-settings-dialog.h:
1572 * src/maemo/modest-account-settings-dialog.c:
1573 Added connect_for_modified() utility function to mark the new modified boolean.
1575 (create_page_account_details), (create_page_user_details),
1576 (create_page_incoming), (create_page_outgoing), (on_response),
1577 (modest_account_settings_dialog_init),
1578 (modest_account_settings_dialog_set_account_name):
1579 Only warn about unsaved changes when there are actually unsaved changes.
1581 * src/modest-account-mgr-helpers.c:
1582 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1583 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1584 to get the data from there in future.
1586 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-defs.h:
1590 * src/modest-account-mgr-helpers.h:
1591 * src/modest-account-mgr-helpers.c:
1592 Store the security account setting in a single conf key instead of using
1593 the options list, so that the list is left for just the to-be-removed camel hack,
1594 and because gconf_client_set_list() is failing for some reason.
1596 * src/modest-account-mgr.c:
1597 (modest_account_mgr_add_server_account):
1598 * src/maemo/modest-account-settings-dialog.c:
1599 (modest_account_settings_dialog_set_account_name),
1600 (save_configuration): Use the renamed functions.
1603 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1605 * src/widgets/Makefile.am:
1606 * src/widgets/modest-limit-retrieve-combo-box.c:
1607 * src/widgets/modest-limit-retrieve-combo-box.h:
1608 * src/widgets/modest-retrieve-combo-box.c:
1609 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1610 the account settings dialog.
1612 * src/modest-defs.h:
1613 * src/modest-account-mgr-helpers.h:
1614 * src/modest-account-mgr-helpers.c:
1615 (modest_server_account_get_option_secure_auth),
1616 (modest_server_account_set_option_secure_auth):
1617 * src/modest-account-mgr.c:
1618 (modest_account_mgr_add_server_account):
1619 Use the existing AUTH_MECH conf key for the secure-auth setting,
1620 instead of putting it in the list options, because this was actually used already.
1622 * src/maemo/modest-account-settings-dialog.c:
1623 (create_page_account_details),
1624 (modest_account_settings_dialog_set_account_name),
1625 (save_configuration):
1626 * src/maemo/modest-account-settings-dialog.h:
1627 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1628 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1630 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1632 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1633 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1634 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1636 * src/modest-defs.h:
1637 * src/maemo/modest-account-settings-dialog.c:
1638 (create_page_incoming), (on_combo_outgoing_security_changed),
1639 (on_combo_incoming_security_changed), (create_page_outgoing),
1640 (modest_account_settings_dialog_set_account_name),
1641 (save_configuration): Load/Save the port number, and change it when the
1642 security combo changes, to suitable defaults.
1644 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1646 * src/modest-account-mgr.c:
1647 (modest_account_mgr_add_server_account): Set the security and secure-auth
1648 options, and add a comment saying that the other camel-specific options should be
1651 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1655 * src/modest-tny-account-store.c: (account_list_free),
1656 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1657 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1660 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1662 * src/modest-protocol-info.c:
1663 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1664 is required by our UI spec. Maybe something in our implementation will use this eventually.
1665 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1666 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1667 instead of the previous 0 placeholder.
1669 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1670 secure-auth settings.
1671 * src/modest-account-mgr-helpers.h:
1672 * src/modest-account-mgr-helpers.c:
1673 (modest_server_account_data_get_option_secure_auth),
1674 (modest_server_account_set_option_secure_auth),
1675 (modest_server_account_data_get_option_security),
1676 (modest_server_account_set_option_security): Added this API for getting and setting the security
1677 and secure-auth settings.
1679 * src/maemo/modest-account-settings-dialog.h:
1680 * src/maemo/modest-account-settings-dialog.c:
1681 (modest_account_settings_dialog_finalize), (check_data),
1682 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1683 about changing titles.
1684 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1685 (save_configuration): Save the security and secure-auth settings.
1687 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1688 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1690 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1692 * src/modest-defs.h:
1693 * src/modest-account-mgr.c:
1694 (modest_account_mgr_add_server_account):
1695 Added and used defines for the options key and value pair strings,
1696 that are used so far, though they do not seem to correspond to anything in our
1697 UI specs or ModestProtocol enum.
1699 * src/modest-account-mgr-helpers.h:
1700 * src/modest-account-mgr-helpers.c:
1701 (compare_option_strings_for_name),
1702 (modest_server_account_data_get_option_value),
1703 (modest_server_account_data_get_option_bool),
1704 (modest_account_mgr_get_server_account_option):
1705 Added helper functions for parsing the options GSList.
1707 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1710 display name is based on the supplied account name.
1711 * src/modest-account-mgr.c:
1712 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1713 with an inefficient, but good-enough, implementation.
1715 * src/maemo/easysetup/modest-easysetup-wizard.c:
1716 (create_page_account_details), (on_before_next), (create_account):
1717 Check for existing display names rather than (non-user-visible) account names, and just
1718 create and set a unique account name at the end.
1720 * src/maemo/modest-account-settings-dialog.c:
1721 (modest_account_settings_dialog_init),
1722 (modest_account_settings_dialog_set_account_name),
1723 (create_page_incoming): Show the display name, instead of the account name.
1724 (on_response): Do some (not all) extra checks, as in the UI spec.
1725 (save_configuration): Save the display name if it was changed.
1727 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1729 * po/en_GB.po: Added needed logical ID and translation.
1730 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1731 (init_view): Made the is-default column clicking work.
1733 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1736 * src/maemo/easysetup/Makefile.am:
1737 * src/maemo/easysetup/modest-easysetup-wizard.c:
1738 (modest_easysetup_wizard_dialog_init):
1739 * src/maemo/easysetup/provider-data-test.keyfile:
1740 * src/maemo/easysetup/provider-data.keyfile:
1741 Moved the provider data file to the new modest-providers-data package and used it from there.
1743 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1745 * src/modest-local-folder-info.c:
1746 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1747 N_() was already used on the static strings, but this just marks it for translation without
1748 using the translation.
1750 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1752 * src/maemo/modest-account-settings-dialog.c:
1753 (create_page_incoming),
1754 (modest_account_settings_dialog_set_account_name):
1755 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1756 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1757 I will do this if nobody else gets there first.
1759 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1761 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1762 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1763 save the security stuff.
1765 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1767 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1768 Set the email address and user fullname, which I now see must be
1771 * src/maemo/modest-account-settings-dialog.h:
1772 * src/maemo/modest-account-settings-dialog.c:
1774 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1775 leave-on-server and authentication.
1776 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1779 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1782 * src/maemo/modest-account-settings-dialog.c:
1783 * src/maemo/modest-account-settings-dialog.h:
1784 Most (but not all) of the widgets are now present as specified by the UI spec.
1785 No changes are yet saved, and some details are not properly shown yet.
1787 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1789 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1791 * src/maemo/Makefile.am:
1792 * src/maemo/modest-account-settings-dialog.c:
1793 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1794 an existing account. Doesn't do much yet.
1796 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1797 Open the accounts settings dialog when Edit is clicked.
1799 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1801 * src/maemo/easysetup/Makefile.am:
1802 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1804 * src/maemo/easysetup/modest-easysetup-wizard.c:
1805 (modest_easysetup_wizard_dialog_init):
1806 Try to get the source directory from the build system,
1807 instead of hard-coding "./" into the source code, when opening our local
1808 copies of the configuration files.
1809 But this still fails when opening the wizard from the Accounts window,
1810 maybe because the working directory seems to change at runtime.
1811 So the wizard will fail the second time unless you copy the files into their
1812 proper locations - see the stdout warnings for the paths.
1814 (create_page_account_details),(on_before_next):
1815 Check for existing non-server accounts instead of server accounts,
1816 so the default account name is useful again, and to prevent trying to
1819 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1820 Show the wizard when New is clicked.
1822 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1823 (init_view): Show the column headers, and show the columns that are
1824 specified in the UI specs. However, something in Maemo's GTK+ prevents
1825 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1826 change the default account. This is despite unsetting the special properties.
1828 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1830 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1831 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1832 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1833 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1834 to make that clearer.
1835 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1837 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1839 * src/maemo/modest-account-view-window.c:
1840 (modest_account_view_window_init),
1841 (modest_account_view_window_new):
1842 Use the same buttons as specified in the
1843 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1844 the existing widgets, which never had a chance of working.
1845 Put the ModestAccountView treeview in a scrolled window.
1846 Do not repeat the initialization in both _init() and _new().
1848 * src/widgets/modest-account-view.c: (update_account_view):
1849 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1850 this widget and window shows no accounts.
1852 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1854 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1856 * src/maemo/easysetup/modest-easysetup-wizard.c:
1857 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1858 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1859 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1862 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1863 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1864 accounts exist yet, as in the UI spec.
1866 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1868 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1870 * src/maemo/Makefile.am:
1871 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1872 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1873 New window for editing connection-specific smtp details.
1874 Not fully implemented.
1876 * src/maemo/modest-connection-specific-smtp-window.c:
1877 (modest_connection_specific_smtp_window_finalize) :
1878 unref the tree model.
1879 (on_button_edit): Show the edit window.
1881 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1883 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1886 * src/maemo/Makefile.am:
1887 * src/maemo/modest-connection-specific-smtp-window.c:
1888 * src/maemo/modest-connection-specific-smtp-window.h:
1889 New window for showing the list of connections, for connection-specific
1890 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1891 * src/maemo/easysetup/modest-easysetup-wizard.c:
1892 (create_page_custom_outgoing): Show the new window when the button is clicked.
1894 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1896 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1897 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1898 * src/maemo/modest-msg-edit-window.c:
1899 (modest_msg_edit_window_insert_image):
1900 * src/modest-conf.c: (modest_conf_key_escape):
1901 * src/modest-mail-operation.c:
1902 (modest_mail_operation_send_new_mail):
1903 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1904 (modest_ui_actions_on_new_account):
1905 * src/widgets/modest-attachment-view.c: (update_filename_request):
1906 * src/widgets/modest-mail-header-view.c:
1907 Corrected warnings that were breaking the build, by commenting out unused variables,
1908 and a function, and by including a header.
1910 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1912 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1913 so we can #ifdef around platform-specific code when necessary.
1914 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1915 to allow this to build for the GNOME platform too.
1917 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1919 * src/maemo/easysetup/modest-easysetup-wizard.c:
1920 Added util_increment_name() and used it in create_page_account_details()
1921 to make sure that the default account name is always a new name.
1923 (modest_easysetup_wizard_dialog_init),
1924 (set_default_custom_servernames): Some minor memory management fixes.
1926 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1930 * src/modest-runtime.c: (init_i18n): Restored the translation
1931 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1932 are defined in config.h, and the translations are installed.
1934 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1935 is defined for translation.
1937 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1939 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1941 * src/maemo/easysetup/modest-easysetup-wizard.c:
1942 (modest_easysetup_wizard_dialog_init):
1943 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1944 Use realistic paths (though they should use $prefix generically) to the
1945 mcc_mapping and provider-data.keyfile files which might work when they
1946 are installed by the future version of the operator-wizard package,
1947 and then fallback to paths in our source code, with an explanatory
1950 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1954 * src/maemo/Makefile.am:
1955 * src/maemo/easysetup/: Added files from the previously-exernal
1956 osso-modest-easysetup.
1957 * src/maemo/modest-main-window-ui.h:
1958 * src/modest-ui-actions.c:
1959 * src/modest-ui-actions.h:
1960 Added modest_ui_actions_on_new_account() as a signal handler for the
1961 New Account menu item. It shows the easysetup wizard.
1962 * po/en_GB.po: Added additional needed logical IDs and translations.
1964 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1965 Apparently ChangeLog is not used for some vague Nokia legal reasons.