git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-16  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
   4         to explain the memory management issue with the ID in the ModestPair.
   5
   6         * src/gnome/modest-account-assistant.c: (add_receiving_page),
   7         (add_sending_page), (modest_account_assistant_finalize):
   8         * src/gnome/modest-gnome-global-settings-dialog.c:
   9         (create_updating_page), (create_composing_page):
  10         * src/gnome/modest-msg-edit-window.c: (get_transports),
  11         (init_window), (modest_msg_edit_window_finalize),
  12         (modest_msg_edit_window_get_msg_data):
  13         * src/gnome/modest-store-widget.c: (imap_pop_configuration):
  14         * src/gnome/modest-transport-widget.c:
  15         (modest_transport_widget_finalize), (smtp_configuration):
  16         * src/maemo/modest-maemo-global-settings-dialog.c:
  17         (create_updating_page), (create_composing_page):
  18         * src/maemo/modest-msg-edit-window.c: (get_transports),
  19         (init_window), (modest_msg_edit_window_finalize),
  20         (modest_msg_edit_window_get_msg_data),
  21         (modest_msg_edit_window_free_msg_data):
  22         * src/maemo/modest-store-widget.c: (imap_pop_configuration),
  23         (modest_store_widget_finalize):
  24         * src/maemo/modest-transport-widget.c:
  25         (modest_transport_widget_finalize), (smtp_configuration):
  26         * src/modest-main.c: (send_mail):
  27         * src/widgets/modest-combo-box.h:
  28         * src/widgets/modest-global-settings-dialog-priv.h:
  29         * src/widgets/modest-global-settings-dialog.c:
  30         (modest_global_settings_dialog_finalize):
  31         * src/widgets/modest-msg-edit-window.h:
  32         Whenever using modest_combo_box_new(), keep the ModestPairList alive
  33         as long as the combo box, to prevent use of freed memory for the ID.
  34
  35 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  36
  37         * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
  38         get_accounts(), to make this clearer. Do not check for the enabled gconf
  39         key, because we do not use this for server accounts (at least, not yet).
  40         This allows us to send email again.
  41
  42 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  43
  44         * src/maemo/modest-platform.c:
  45         (on_modest_conf_update_interval_changed), (modest_platform_init):
  46         Only respond to this particular key change. All these strcmp()s cannot be
  47         efficient.
  48
  49 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  50
  51         * src/maemo/modest-maemo-global-settings-dialog.c:
  52         (current_connection): Prevent a crash in scratchbox when
  53         ny_maemo_conic_device_get_current_iap_id() returns NULL.
  54         * src/maemo/modest-platform.c:
  55         (on_modest_conf_update_interval_changed), (modest_platform_init):
  56         Get the update interval from gconf and reset it when the gconf key changes.
  57
  58 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  59
  60         * src/modest-protocol-info.c:
  61         * src/modest-protocol-info.h: Adde enum-specific get functions,
  62         instead of using a ModestProtocolType enum parameter.
  63
  64         * src/gnome/modest-account-assistant.c:
  65         * src/gnome/modest-store-widget.c:
  66         * src/gnome/modest-store-widget.h:
  67         * src/gnome/modest-transport-widget.c:
  68         * src/gnome/modest-transport-widget.h:
  69         * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
  70         * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
  71         * src/maemo/easysetup/modest-easysetup-wizard.c:
  72         * src/maemo/modest-account-settings-dialog.c:
  73         * src/maemo/modest-account-settings-dialog.h:
  74         * src/maemo/modest-store-widget.c:
  75         * src/maemo/modest-store-widget.h:
  76         * src/maemo/modest-transport-widget.c:
  77         * src/maemo/modest-transport-widget.h:
  78         * src/modest-account-mgr-helpers.c:
  79         * src/modest-account-mgr-helpers.h:
  80         * src/modest-account-mgr.c:
  81         * src/modest-account-mgr.h:
  82         * src/modest-tny-account.c:
  83         * src/modest-tny-folder.c:
  84         * src/widgets/modest-account-view.c:
  85         * src/widgets/modest-retrieve-combo-box.c:
  86         * src/widgets/modest-retrieve-combo-box.h:
  87         * src/widgets/modest-secureauth-combo-box.c:
  88         * src/widgets/modest-serversecurity-combo-box.c:
  89         * src/widgets/modest-serversecurity-combo-box.h:
  90         * tests/check_account-mgr.c:
  91         Use the specific functions, and use the re-renamed enum values for GNOME too.
  92
  93 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  94
  95         * src/modest-pair.h:
  96         * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
  97         so we can get the second based on the first.
  98
  99         * src/maemo/modest-account-settings-dialog.h:
 100         * src/maemo/modest-account-settings-dialog.c:
 101         Added get_supported_secure_authentication_methods(), though it is mostly
 102         commented-out for now until the necessary API is committed to tinymail.
 103         (modest_account_settings_dialog_set_account_name),
 104         (save_configuration): Request the supported authentication methods from the
 105         server, so we can choose a working method.
 106
 107         * src/modest-tny-account-store.h:
 108         * src/modest-tny-account-store.c:
 109         (modest_tny_account_store_get_session): Rename from
 110         tny_account_store_get_session().
 111
 112 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 113
 114         * src/modest-protocol-info.h: Split the ModestProtocol enum
 115         into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
 116         There was no need to have these unrelated values in one enum.
 117
 118         * src/: many files: Adapted to changed enum. This makes the code a bit
 119         clearer, and the compiler could catch some errors.
 120
 121 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 122
 123         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 124         Show the detailed internal camel error message when an error happens
 125         during the configuration, so that our testers can give us more clues.
 126         For instance, in projects.maemo.org bug NB#56910 .
 127
 128 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 129
 130         * src/modest-tny-account.c:
 131         (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
 132         change tny_account_set_mech() to tny_account_set_secure_auth_mech().
 133
 134 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 135
 136         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 137         * src/maemo/modest-account-settings-dialog.c:
 138         (modest_account_settings_dialog_set_account_name),
 139         (save_configuration): For the incoming secure authentication checkbox,
 140         use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
 141         the UI specification. PLAIN does not seem to be supported for most IMAP
 142         servers anyway, and I am not sure what it would mean.
 143         However, we probably need to discover which of the secure-authentication
 144         mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
 145         * src/modest-account-mgr-helpers.c:
 146         (modest_account_mgr_get_server_account_data):
 147
 148         * src/modest-tny-account.c:
 149         (modest_tny_account_new_from_server_account):
 150         Use tny_account_set_mech() to set secure-authentication methods,
 151         with some special-casing for IMAP, based on my observations of how
 152         evolution behaves.
 153
 154         * src/modest-account-mgr-helpers.h:
 155         * src/modest-account-mgr.c:
 156         * src/modest-defs.h: Comment that the URI is only used for local folders.
 157
 158 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 159
 160         * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
 161         parameter const, just to be neat.
 162         * src/modest-text-utils.c: (modest_text_utils_inline):
 163         End g_strconcat() with NULL, as its documentation says. This is almost
 164         certainly the cause of my crash at startup on the device. Interestingly,
 165         valgrind doesn't tell us about these errors.
 166
 167 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 168
 169         * scripts/build-packages: Added more precise comments about how to use
 170         this script, though I still get this error:
 171         dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
 172         error building tinymail
 173
 174 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 175
 176         * src/maemo/modest-main-window.c: (on_account_update):
 177         Very slight cleanup, hoping to make it simpler to discover what causes
 178         a crash here sometimes.
 179
 180         * src/modest-tny-account.c:
 181         (modest_tny_account_new_from_server_account): Set the port. Added
 182         comments about the options and a TODO comment because I need to find out
 183         how to specify the secure authentication method.
 184
 185 2007-05-11  Marcus Bauer  <marcusb@openismus.com>
 186
 187         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 188         changed CFlags paths form modest to libmodest
 189
 190 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 191
 192         * src/modest-account-mgr-helpers.c:
 193         (modest_account_mgr_get_server_account_data),
 194         (modest_account_mgr_free_server_account_data):
 195         * src/modest-account-mgr-helpers.h:
 196         * src/modest-account-mgr.c:
 197         (modest_account_mgr_add_server_account):
 198         * src/modest-defs.h:
 199         * src/modest-tny-account.c:
 200         (modest_tny_account_new_from_server_account):
 201         Determine the options for tny_camel_account_add_option() here,
 202         based on the settings, rather than storing them directly in gconf.
 203
 204 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 205
 206         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 207         Show a more friendly error dialog now that we expect (from the tinymail
 208         documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
 209
 210 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 211
 212         * src/maemo/modest-main-window.c: (on_account_update): Check that
 213         account_name is not NULL, to prevent a crash at startup that I am
 214         seeing on the N800. I do wonder why it is NULL.
 215
 216         * src/maemo/easysetup/modest-easysetup-wizard.c:
 217         (create_page_user_details):
 218         * src/maemo/modest-account-settings-dialog.c:
 219         (create_page_user_details), (create_page_outgoing):
 220         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 221         (modest_connection_specific_smtp_edit_window_init):
 222         * src/modest-ui-actions.c:
 223         (modest_ui_actions_on_password_requested):
 224         Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
 225         might do something useful with the on-screen keyboard.
 226
 227 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 228
 229         * src/maemo/modest-main-window.c: (on_account_update):
 230         Avoid adding a menu item to priv->accounts_popup if accounts_popup is
 231         NULL, to avoid lots of warnings. However, it probably should not be NULL.
 232
 233 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 234
 235         * src/modest-tny-account-store.c: (on_account_changed):
 236         Correct the signature of this signal handler.
 237
 238 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 239
 240         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 241         Show a HildonNote instead of a GtkDialog for Maemo.
 242
 243 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 244
 245         * src/widgets/modest-account-view.h:
 246         * src/widgets/modest-account-view.c: (on_account_changed),
 247         (on_account_removed). Added a boolean flag, set/unset by
 248         modest_account_view_block_conf_updates(),
 249         modest_account_view_unblock_conf_updates() to prevent unnecessary
 250         updates, but this is not very useful because the gconf notifications are
 251         so delays (maybe only on Maemo Bora).
 252         So auto-updating is turned off, and these functions do an explicit
 253         update when necessary.
 254         However, something else is still doing too much work when adding/removing
 255         accounts, probably in another part of the application.
 256
 257         * src/maemo/modest-account-view-window.c:
 258         (on_delete_button_clicked), (on_edit_button_clicked),
 259         (on_new_button_clicked): Use the new functions.
 260
 261 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 262
 263         * src/modest-account-mgr-helpers.c:
 264         (modest_account_mgr_set_first_account_as_default):
 265         Sort the list of names alphabetically-by-title, so we choose the first one
 266         based on that.
 267         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
 268         alphabetically by the title.
 269
 270         This fixes projects.maemo.org bug NB#56418 .
 271
 272         * src/modest-account-mgr-priv.c:
 273         (_modest_account_mgr_account_from_key):
 274         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
 275         avoid a valgrind error, and possible random behaviour.
 276
 277 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 278
 279         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 280         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
 281         tinymail documentation to say that this can be expected.
 282         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
 283         pretty, and should not happen, but I would prefer to know when it does.
 284
 285 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 286
 287         * configure.ac: When using the older hildon version, probably on Bora,
 288         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
 289         to fix the build.
 290         * src/widgets/modest-attachment-view.c:
 291         (modest_attachment_view_set_part_default): Initialize variables, to fix the
 292         build.
 293
 294 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
 295
 296         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
 297         Implemented the prototype. Can be tested with
 298         tests/dbus_api/test_open_message:
 299
 300 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 301
 302         * src/modest-tny-account-store.c:
 303         (modest_tny_account_store_instance_init), (get_password):
 304         * src/modest-ui-actions.c:
 305         (modest_ui_actions_on_password_requested):
 306         Do not store the password in gconf, because this function is called
 307         for non-remembered passwords. Actually use the cached (in the hash map)
 308         password instead of releasing it.
 309         The password will now not be remembered if it is asked via the protected
 310         password dialog, as per the UI spec.
 311
 312 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 313
 314         * src/modest-defs.h:
 315         * src/modest-account-mgr-helpers.h:
 316         * src/modest-account-mgr-helpers.c:
 317         Added modest_server_account_get_username_has_succeeded(),
 318         modest_server_account_set_username_has_succeeded().
 319         (modest_server_account_set_username),
 320         Reset the has-succeeded flag if the username changes.
 321
 322         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 323         * src/maemo/modest-connection-specific-smtp-window.c:
 324         (modest_connection_specific_smtp_window_save_server_accounts):
 325         Use modest_server_account_set_username() instead of using
 326         modest_conf_set_string() directly, so that the has-succeeded flag is always
 327         reset.
 328
 329         * src/modest-ui-actions.c:
 330         (modest_ui_actions_on_password_requested): Dim the username entry if
 331         the username has ever worked, as per the UI spec.
 332
 333 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 334
 335         * src/modest-tny-account-store.c: (get_password):
 336         * src/modest-ui-actions.c:
 337         (modest_ui_actions_on_password_requested):
 338         Allow the username to be changed too, though there is more work to
 339         be done on exactly how this behaves.
 340
 341 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 342
 343         * src/modest-account-mgr-helpers.h:
 344         * src/modest-account-mgr-helpers.c:
 345         Added modest_account_mgr_get_display_name(),
 346         modest_server_account_get_username(),
 347         modest_server_account_set_username(),
 348         modest_server_account_set_password(),
 349         modest_server_account_get_hostname() functions so we do not need to
 350         use the conf API directly.
 351
 352         * src/maemo/modest-main-window.c: (connect_signals):
 353         Actually connect ot the ModestAccountStore::request-password signal,
 354         so that we show the dialog when the password is requested by Tinymail,
 355         for isntance if it is empty.
 356
 357         * src/modest-marshal.list:
 358         * src/modest-tny-account-store.c:
 359         (modest_tny_account_store_class_init), (get_password),
 360         (modest_tny_account_store_alert):
 361         * src/modest-tny-account-store.h:
 362         * src/modest-ui-actions.h:
 363         * src/modest-ui-actions.c:
 364         (modest_ui_actions_on_password_requested):
 365         Change the signal parameters, so it is obvious that we are providing
 366         the non human-readable server name, and receiving both the username
 367         and password, though changing of the username is not yet implemented.
 368         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 369         for the GNOME version.
 370
 371         This should fix the projects.maemo.org bug NB#56209, though it does not
 372         work on Bora, because the gconf_client_get() for the password fails
 373         immediately after we save it with gconf_client_set().
 374
 375 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 376
 377         * configure.ac:
 378         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 379         caused an undefined symbol error:
 380         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 381
 382 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 383
 384         * src/modest-tny-account-store.c:
 385         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 386         using a GError instead of a string message, so we can translate it in
 387         Modest.
 388
 389 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 390
 391         * src/maemo/modest-address-book.c:
 392         (modest_address_book_check_names):
 393         * src/maemo/modest-msg-view-window.c:
 394         (modest_msg_view_window_clipboard_owner_change):
 395         * src/modest-init.c: (modest_init_init_ui):
 396         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 397         (update_folders_cb), (modest_mail_operation_update_account):
 398         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 399         (modest_ui_actions_on_msg_attachment_clicked),
 400         (modest_ui_actions_on_msg_recpt_activated):
 401         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 402         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 403         (modest_msg_view_search_next):
 404         * src/widgets/modest-recpt-editor.c:
 405         (modest_recpt_editor_on_button_release_event),
 406         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 407         g_message(). At this point we should only be seeing interesting errors on
 408         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 409
 410 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 411
 412         (modest_wizard_dialog_force_title_update):
 413         * src/maemo/easysetup/modest-wizard-dialog.h:
 414         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 415         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 416         can update the title when appropriate. Otherwise the title is wrong if the
 417         pages are added after adding the notebook to the dialog.
 418         This must be a problem in HildonWizardDialog too.
 419         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 420
 421         * src/maemo/easysetup/modest-easysetup-wizard.c:
 422         (create_subsequent_customsetup_pages),
 423         (create_subsequent_easysetup_pages):
 424         Call modest_wizard_dialog_force_title_update() so that the title is
 425         correct even with GTK+ < 2.10.
 426         This fixes projects.maemo.org bug NB#56145 .
 427
 428 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 429
 430         * src/maemo/modest-platform.c:
 431         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 432         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 433         from being shown.
 434
 435 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 436
 437         * src/widgets/modest-window.h:
 438         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 439         and modest_window_save_state(), which invokes it.
 440
 441         * src/widgets/modest-window-mgr.h:
 442         * src/widgets/modest-window-mgr.c:
 443         Added modest_window_mgr_save_state_for_all_windows(), which calls
 444         the save_state vfunc on all registered windows, if implemented.
 445
 446         * src/gnome/modest-msg-edit-window.c:
 447         * src/gnome/modest-msg-view-window.c:
 448         * src/maemo/modest-msg-edit-window.c:
 449         * src/maemo/modest-msg-view-window.c:
 450         * src/maemo/modest-main-window.c:
 451         Specify the existing save_settings functions as implementations of
 452         ModestWindow::save_state_func().
 453
 454         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 455         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 456         enabling hibernation, for instance.
 457
 458         We may need to do the same thing for restoring settings.
 459
 460
 461 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 462
 463         * src/widgets/modest-window-mgr.c:
 464         * src/widgets/modest-window-mgr.h:
 465         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 466         modest_window_mgr_get_hibernation_is_prevented().
 467
 468         * src/maemo/modest-main-window.c:
 469         (on_hildon_program_is_topmost_notify): Prevent hibernation
 470         (possible when the application goes to the background in the WM),
 471         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 472
 473         * src/maemo/easysetup/modest-easysetup-wizard.c:
 474         (modest_easysetup_wizard_dialog_init):
 475         * src/maemo/modest-account-settings-dialog.c:
 476         (modest_account_settings_dialog_init):
 477         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 478         (modest_connection_specific_smtp_edit_window_init):
 479         * src/maemo/modest-connection-specific-smtp-window.c:
 480         (modest_connection_specific_smtp_window_init):
 481         * src/maemo/modest-signature-editor-dialog.c:
 482         (modest_signature_editor_dialog_init):
 483         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 484         prevent hibernation while any of these account settings dialogs are open.
 485
 486 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 487
 488         * src/maemo/Makefile.am:
 489         * src/maemo/modest-osso-state-saving.c:
 490         * src/maemo/modest-osso-state-saving.h: Added
 491         modest_osso_load_state() and modest_osso_save_state() though they do
 492         nothing now. They should iterate through all the open windows and load/save
 493         their state.
 494         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 495         save state when closing.
 496
 497         * src/maemo/modest-main-window.c:
 498         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 499         Add a notification handler for the HildonProgram::is-topmost property,
 500         so we can allow hibernation when the application goes into the background.
 501         But we still need to detect when the accounts setup windows are open so
 502         we can stop hibernation when they are open.
 503         To do this, I also added the main window the HildonProgram. This might have
 504         other side-effects/benefits, and should maybe be done for other windows.
 505
 506         * src/maemo/modest-osso-autosave-callbacks.h:
 507         * src/maemo/modest-osso-autosave-callbacks.c:
 508         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 509         though it does not do anything yet, and we might never need this to do
 510         anything. For instance, we already save drafts.
 511
 512         * src/maemo/modest-platform.c: (modest_platform_init):
 513         Specify the libosso auto-save callback.
 514
 515 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 516
 517         * src/maemo/modest-platform.c:
 518         (modest_platform_set_update_interval):
 519         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 520         aparently stays valid between application instances, so we can use this
 521         to remove and reset it later. According to a maemo-developers email from
 522         David Weinehall.
 523
 524 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 525
 526         * configure.ac: Depend on libalarm for Maemo.
 527
 528         * src/dbus_api/modest-dbus-api.h:
 529         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 530         (on_send_receive), (modest_dbus_req_handler):
 531         Handle a SEND_RECEIVE D-Bus method.
 532
 533         * libmodest-dbus-client/libmodest-dbus-client.c:
 534         (libmodest_dbus_client_send_and_receive):
 535         * libmodest-dbus-client/libmodest-dbus-client.h:
 536         Add C convenience functions for calling the new D-Bus method.
 537
 538         * src/modest-platform.h:
 539         * src/gnome/modest-platform.c:
 540         * src/maemo/modest-platform.c:
 541         Added modest_platform_set_update_interval(), which uses the
 542         alarmd API on Maemo.
 543         (modest_platform_init),
 544         Call modest_platform_set_update_interval(), using a hard-coded
 545         interval for now (until the global settings dialog is implemented),
 546         though I am not sure that this makes sense yet.
 547
 548 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 549
 550         * src/dbus_api/modest-dbus-callbacks.c:
 551         (modest_osso_cb_hw_state_handler):
 552         * src/dbus_api/modest-dbus-callbacks.h:
 553         * src/maemo/modest-platform.c: (modest_platform_init):
 554         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 555         in case this has some effect on the ability for Maemo to ping the
 556         application.
 557
 558 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 559
 560         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 561         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 562         warning. It is probably a logic error, but I need to fix the build.
 563
 564 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 565
 566         * src/modest-account-mgr.h:
 567         * src/modest-account-mgr.c:
 568         (modest_account_mgr_account_names): Add a gboolean enabled_only
 569         parameter, so we can get lists of onlt the enabled accounts.
 570
 571         (modest_account_mgr_add_account),,
 572         (modest_account_mgr_account_with_display_name_exists):
 573         * src/maemo/modest-msg-edit-window.c: (get_transports):
 574         * src/modest-account-mgr-helpers.c:
 575         (modest_account_mgr_set_first_account_as_default):
 576         * src/modest-init.c: (init_default_account_maybe):
 577         * src/modest-tny-account-store.c: (get_accounts):
 578         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 579         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 580         * tests/check_account-mgr.c: (START_TEST):
 581         Provide the extra parameter, as appropriate.
 582
 583         * src/widgets/modest-account-view.c: (update_account_view):
 584         Do not show disabled accounts (meaning that there is no way to
 585         enable/disable accounts in the UI (the feature is not in our UI
 586         specification), so we can use this internally only to mark unfinished
 587         or temporary account data.
 588
 589         * src/maemo/easysetup/modest-easysetup-wizard.c:
 590         (create_account): Add boolean enable parameter, so we can specify FALSE
 591         to create the temporary account.
 592         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 593         (on_before_next): When finishing, when there is a temporary account, just
 594         set it as enabled.
 595         Also, use a timeout to delay the showing of the dialog until gconf is likely
 596         to return correct information, due to a maemo gconf bug that is fixed in
 597         osso 1.1, but not yet in Bora.
 598         However, the dialog stays on screen after it is destroyed.
 599
 600         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 601         for invalid data when cancelling. Use a hildon note instead of a dialog
 602         to complain about invalid data. Do not show the account-saved note if the
 603         account is disabled (a temporary account that will not really be saved for use
 604         until later.)
 605
 606 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 607
 608         * src/modest-account-mgr-helpers.h:
 609         * src/modest-account-mgr-helpers.c:
 610         Added modest_account_mgr_unset_default_account(),
 611         Added modest_account_mgr_set_first_account_as_default().
 612
 613         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 614         If it was the default account, unset the default account name.
 615
 616         * src/maemo/modest-account-view-window.c:
 617         (on_delete_button_clicked): If it was the default account,
 618         set the first remaining account as the default instead.
 619
 620         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 621         a NULL account or a NULL default account, to prevent a crash. This should
 622         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 623
 624
 625 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 626
 627         * src/widgets/modest-recpt-editor.c:
 628         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 629         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 630         TODO comment for this. This fixes the build.
 631
 632         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 633         be the best place for it. This will in future update all auto-update accounts,
 634         rather than just the current/default account, when that gconf key exists.
 635         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 636         if there are no accounts, before calling do_send_receive().
 637         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 638
 639         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 640         * src/maemo/modest-main-window-ui.h:
 641         * src/maemo/modest-main-window.c: (on_connection_changed),
 642         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 643         directly, becaue the signal handler does more.
 644
 645 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 646
 647         * src/modest-account-mgr-helpers.c:
 648         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 649         for the case that the account does not exist.
 650
 651         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 652         (equivalent to the modest account name) rather than the tinymail account name
 653         (equivalent to the modest account title - human readable) to get the account data.
 654         Check for null account data to prevent the crash, and add a TODO comment saying that
 655         this needs fixing because it is using the server account name instead of the account name.
 656
 657 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 658
 659         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 660         * src/maemo/modest-account-settings-dialog.c: (show_error),
 661         (show_ok):
 662         Use hildon_note_new_information() for informative and error messages,
 663         which seems to be expected for Maemo applications (no documentation that I know of
 664         says this). I am surprised that there is no distinction between info and error
 665         dialogs.
 666
 667 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 668
 669         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 670         it is easy to find where this is used.
 671
 672         * src/maemo/easysetup/modest-easysetup-wizard.c:
 673         (create_page_welcome), (create_page_account_details),
 674         (create_page_user_details), (create_page_complete_easysetup),
 675         (create_page_custom_incoming), (create_page_custom_outgoing),
 676         (create_page_complete_custom):
 677         * src/maemo/modest-account-settings-dialog.c:
 678         (create_page_account_details), (create_page_user_details),
 679         (create_page_incoming), (create_page_outgoing):
 680         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 681         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 682         (modest_connection_specific_smtp_edit_window_init):
 683         * src/maemo/modest-connection-specific-smtp-window.c:
 684         (modest_connection_specific_smtp_window_init):
 685         * src/maemo/modest-signature-editor-dialog.c:
 686         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 687         and scrolling policy as per the Email Application Layout Guide, if I have
 688         understood it.
 689
 690 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 691
 692         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 693         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 694         which were empty, because these vfuncs have been removed from TnyAccountStore.
 695         This fixes the build.
 696
 697 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 698
 699         * src/maemo/modest-main-window.c:
 700         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 701         showing/hiding it. Added TODO because it probably should not be NULL.
 702         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 703         because unnecessary g_warnings() make degugging difficult.
 704
 705 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 706
 707         * src/maemo/modest-msg-edit-window.c:
 708         (modest_msg_edit_window_select_color),
 709         (modest_msg_edit_window_select_background_color): 2 const corrections and
 710         moving 2 #endifs before closing brackets, to fix the build.
 711
 712 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 713
 714         * src/maemo/easysetup/modest-easysetup-wizard.h:
 715         * src/maemo/easysetup/modest-easysetup-wizard.c:
 716         (modest_easysetup_wizard_dialog_finalize),
 717         (on_button_edit_advanced_settings), (create_page_complete_custom),
 718         (on_response), (create_account):
 719         Implement the Advanced Settings edit button, by saving the account information,
 720         for the Advanded Settings dialog to use directly from gconf, and removing it
 721         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 722         Bug #5533 in the projects.maemo.org bugzilla.
 723
 724 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 725
 726         * src/maemo/modest-msg-view-window.c:
 727         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 728         when opening a message window.
 729
 730 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 731
 732         * src/maemo/easysetup/modest-easysetup-wizard.c:
 733         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 734         match the UI spec.
 735
 736         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 737         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 738         gconf settings. I probably added more checks than necessary, but that is safer.
 739
 740         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 741         variable to fix the build, but this seems to be used when it is still NULL.
 742
 743 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 744
 745         * src/modest-platform.h:
 746         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 747         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 748         * src/modest-main.c: Implement this function so we can avoid using
 749         maemo-specific API from cross-platform code.
 750         (main):
 751         * src/modest-tny-account-store.c:
 752         (get_smtp_specific_transport_account_for_open_connection):
 753         * src/modest-ui-actions.c: (check_for_connection),
 754         (modest_ui_actions_on_item_not_found):
 755         Use modest_platform_connect_and_wait() and put #idefs around other
 756         maemo-specific code, because only maemo currently has a way to
 757         identify connection names.
 758
 759 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 760
 761         * src/modest-tny-account-store.h:
 762         * src/modest-tny-account-store.c:
 763         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 764         the connection-specific SMTP server settings in the configuration.
 765
 766         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 767         (on_idle_mail_to):
 768         * src/maemo/modest-main-window.c: (on_connection_changed),
 769         (connect_signals):
 770         * src/modest-main.c: (main), (start_ui), (send_mail):
 771         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 772         that is what is intended.
 773
 774         * src/modest-ui-actions.c: (action_send), (action_receive),
 775         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 776         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 777         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 778         SMTP server is used when it is specified.
 779
 780         (modest_ui_actions_on_send_receive):
 781         Check that a connection is open before proceeding.
 782         Receive and then send, instead of vice-versa, as per the specification.
 783
 784 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 785
 786         * src/modest-mail-operation.c:
 787         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 788         though I guess it should be something other than NULL.
 789
 790 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 791
 792         * src/maemo/easysetup/modest-easysetup-wizard.c:
 793         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 794         combo twice, to avoid an g_warning and to make it visible again.
 795         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 796         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 797         (already intended) dereference when detaching, because we then recreate the menu.
 798         But I am not sure why the warning was happening, and it is possible that this is a memory
 799         leak.
 800
 801 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 802
 803         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 804         and uri_parse_mailto() utility functions.
 805         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 806         the mailto URI.
 807         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 808
 809 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 810
 811         * src/dbus_api/modest-dbus-api.h:
 812         * src/dbus_api/modest-dbus-callbacks.c:
 813         Use an idle callback to execute the modest code in the application's own thread.
 814         Remove the helloworld example method.
 815         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 816         parsed, and the open-message method is not implemented because this is not yet implemented in
 817         modest itself.
 818         * libmodest-dbus-client/libmodest-dbus-client.c:
 819         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 820         (libmodest_dbus_client_open_message):
 821         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 822
 823         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 824         body without crashing.
 825
 826         * tests/dbus_api/Makefile.am:
 827         * tests/dbus_api/test_mail_to.c:
 828         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 829
 830 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 831
 832         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 833         Added file to fix the build. Sorry.
 834
 835         * src/dbus_api/Makefile.am:
 836         * src/dbus_api/modest-dbus-api.h:
 837         * src/dbus_api/modest-dbus-callbacks.h:
 838         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 839         (modest_dbus_req_handler):
 840         Put constants in a separate header so it can be reused by the
 841         client library, without duplication
 842
 843         * libmodest-dbus-client/Makefile.am:
 844         * libmodest-dbus-client/libmodest-dbus-client.c:
 845         (libmodest_dbus_client_call_helloworld),
 846         (libmodfest_dbus_client_send_mail),
 847         (libmodfest_dbus_client_mailto),
 848         (libmodfest_dbus_client_open_message):
 849         * libmodest-dbus-client/libmodest-dbus-client.h:
 850         (Partly) Implement a send_mail D-Bus method.
 851
 852         * tests/dbus_api/Makefile.am:
 853         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 854         the send_email D-Bus method.
 855
 856 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 857
 858         * Makefile.am:
 859         * configure.ac:
 860         * libmodest-dbus-client/Makefile.am:
 861         * libmodest-dbus-client/libmodest-dbus-client.c:
 862         * libmodest-dbus-client/libmodest-dbus-client.h:
 863         * tests/dbus_api/Makefile.am:
 864         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 865         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 866
 867 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 868
 869         * src/maemo/easysetup/modest-easysetup-wizard.c:
 870         (create_page_account_details):
 871         * src/maemo/modest-account-settings-dialog.c:
 872         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 873         widgets, because this might not be the default in future versions of the Maemo GTK+.
 874         However, I can not not get capitalization to work even in a simple test case.
 875
 876 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 877
 878         * src/maemo/easysetup/modest-easysetup-wizard.c:
 879         (create_page_custom_incoming), (create_page_custom_outgoing):
 880         * src/maemo/modest-account-settings-dialog.c:
 881         (create_page_account_details), (create_page_incoming),
 882         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 883         instead of using gtk_check_button_with_label(), so they are aligned like the other
 884         widgets, as per the UI spec.
 885
 886 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 887
 888         * src/maemo/easysetup/modest-easysetup-wizard.c:
 889         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 890         * src/widgets/modest-validating-entry.c:
 891         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 892         Modest prefix instead of an EasySetup prefix.
 893
 894 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 895
 896         * src/widgets/modest-validating-entry.h:
 897         * src/widgets/modest-validating-entry.c: (on_insert_text),
 898         Added easysetup_validating_entry_set_max_func(), used to set a callback
 899         to call when the max number of characters is reached. GtkEntry has a max-length
 900         already but is silent about it.
 901
 902         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 903         (create_page_account_details), (create_page_user_details),
 904         (create_account):
 905         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 906         (create_page_account_details), (create_page_user_details),
 907         (create_page_outgoing):
 908         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 909         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 910         the UI spec, when the user tries to enter more than the max number of characters.
 911
 912 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 913
 914         * src/maemo/easysetup/modest-easysetup-wizard.c:
 915         (create_page_user_details), (create_page_custom_incoming),
 916         (create_page_custom_outgoing):
 917         * src/maemo/modest-account-settings-dialog.c:
 918         (create_page_user_details), (create_page_incoming),
 919         (create_page_outgoing):
 920         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 921         (modest_connection_specific_smtp_edit_window_init):
 922         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 923         not appropriate. Bad Maemo-specific defaults!.
 924
 925 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 926
 927         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 928         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 929         (modest_signature_editor_dialog_set_settings):
 930         Disable the label and textview when the checkbox is disabled, and use the
 931         specified (UI spec) default signature text.
 932
 933 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 934
 935         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 936         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 937
 938         * src/modest-defs.h:
 939         * src/modest-account-mgr-helpers.h:
 940         * src/modest-account-mgr-helpers.c:
 941         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 942
 943         * src/maemo/Makefile.am:
 944         * src/maemo/modest-signature-editor-dialog.c:
 945         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 946         as per the UI spec.
 947
 948         * src/maemo/modest-account-settings-dialog.h:
 949         * src/maemo/modest-account-settings-dialog.c:
 950         (modest_account_settings_dialog_finalize), (on_button_signature),
 951         (save_configuration): Use the new dialog when the Edit button is pressed, and
 952         save the changes if necessary, as per the UI spec.
 953
 954 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 955
 956         * src/maemo/Makefile.am:
 957         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 958         based on maemo-develoers email from Dirk.
 959
 960         * src/maemo/easysetup/modest-easysetup-wizard.c:
 961         (create_page_welcome), (create_page_account_details),
 962         (create_page_user_details), (create_page_complete_easysetup),
 963         (create_page_custom_incoming), (create_page_custom_outgoing),
 964         (create_page_complete_custom),
 965         (modest_easysetup_wizard_dialog_init):
 966         * src/maemo/modest-account-settings-dialog.c:
 967         (create_page_account_details), (create_page_user_details),
 968         (create_page_incoming), (create_page_outgoing),
 969         (modest_account_settings_dialog_init):
 970         * src/maemo/modest-connection-specific-smtp-window.c:
 971         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 972
 973 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 974
 975         * src/maemo/easysetup/modest-easysetup-wizard.c:
 976         (create_page_account_details), (create_page_custom_outgoing),
 977         (create_page_complete_custom):
 978         * src/maemo/modest-account-settings-dialog.c:
 979         (create_page_user_details), (create_page_incoming),
 980         (create_page_outgoing):
 981         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 982         (modest_connection_specific_smtp_edit_window_init):
 983         Use the correct (UI spec) port min/max, and use horizontal separators,
 984         as per the UI spec.
 985
 986 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 987
 988         * src/maemo/easysetup/modest-easysetup-wizard.c:
 989         (set_default_custom_servernames):
 990         * src/maemo/modest-account-settings-dialog.c:
 991         (create_page_incoming), (on_combo_outgoing_security_changed),
 992         (on_combo_incoming_security_changed), (create_page_outgoing),
 993         (modest_account_settings_dialog_set_account_name),
 994         (save_configuration):
 995         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 996         (on_combo_security_changed),
 997         (modest_connection_specific_smtp_edit_window_init),
 998         (modest_connection_specific_smtp_edit_window_set_connection),
 999         (modest_connection_specific_smtp_edit_window_get_settings):
1000         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1001         as per the UI spec.
1002
1003 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1004
1005         * po/en_GB.po:
1006         * src/maemo/easysetup/modest-easysetup-wizard.c:
1007         (create_page_custom_outgoing), (create_page_complete_custom):
1008         * src/maemo/modest-account-settings-dialog.c:
1009         (create_page_user_details), (create_page_outgoing):
1010         * src/maemo/modest-account-view-window.c: (button_box_new):
1011         Use changed logical IDs as per the most recent UI spec:
1012         mcen_bd_emailsetup_edit -> mcen_bd_edit
1013         mcen_bd_emailsetup_delete -> mcen_bd_delete
1014         mcen_bd_emailsetup_close -> mcen_bd_close
1015
1016 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1017
1018         * configure.ac:
1019         * src/Makefile.am:
1020         * src/dbus_api/Makefile.am:
1021         * src/dbus_api/modest-dbus-callbacks.c:
1022         * src/dbus_api/modest-dbus-callbacks.h:
1023         * src/maemo/modest-platform.c: (modest_platform_init):
1024         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1025         method.
1026         * tests/Makefile.am:
1027         * tests/dbus_api/Makefile.am:
1028         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1029
1030 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1031
1032         * src/maemo/modest-account-settings-dialog.c:
1033         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1034         Removed unnecessary includes.
1035
1036 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1037
1038         * src/maemo/easysetup/modest-easysetup-wizard.c:
1039         * src/maemo/modest-account-settings-dialog.c:
1040         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1041         * src/widgets/Makefile.am:
1042         * src/widgets/modest-easysetup-secureauth-combo-box.c:
1043         * src/widgets/modest-easysetup-secureauth-combo-box.h:
1044         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1045         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1046         * src/widgets/modest-secureauth-combo-box.c:
1047         * src/widgets/modest-secureauth-combo-box.h:
1048         * src/widgets/modest-serversecurity-combo-box.c:
1049         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1050         made the GObject names more consistent with the rest of the Modest code.
1051
1052 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1053
1054         * src/maemo/easysetup/Makefile.am:
1055         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1056         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1057         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1058         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1059         * src/maemo/easysetup/modest-easysetup-wizard.c:
1060         * src/maemo/easysetup/modest-validating-entry.c:
1061         * src/maemo/easysetup/modest-validating-entry.h:
1062         * src/maemo/modest-account-settings-dialog.c:
1063         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1064         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1065         widgets/ because they are used outside of easysetup too. After checking in,
1066         svn will allow me to rename them too.
1067
1068 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1069
1070         * src/gnome/modest-msg-edit-window.c:
1071         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1072         linker error, to fix the build on the GNOME platform.
1073         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1074         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1075         ifdefed out to avoid a warning.
1076
1077 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1078
1079         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1080         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1081         some alternative for GTK+ 2.6.
1082
1083 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
1084
1085         * src/maemo/modest-address-book.c: Added include to avoid a warning.
1086
1087         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1088         specified for EmailAccountsDialog in UI spec.
1089
1090         * src/maemo/easysetup/modest-easysetup-wizard.c:
1091         * src/maemo/easysetup/modest-easysetup-wizard.h:
1092         * src/maemo/modest-account-settings-dialog.c:
1093         * src/maemo/modest-account-settings-dialog.h:
1094         Reuse a member window widget for the connection-specific SMTP server accounts,
1095         so we can tell it to create/save the accounts only if we actually save changes.
1096
1097         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1098         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1099         (modest_connection_specific_smtp_edit_window_get_settings):
1100         Return a struct instance for temporarily remembering the entered data.
1101
1102         * src/maemo/modest-connection-specific-smtp-window.h:
1103         * src/maemo/modest-connection-specific-smtp-window.c:
1104         (modest_connection_specific_smtp_window_finalize),
1105         (modest_connection_specific_smtp_window_fill_with_connections),
1106         (on_button_edit),
1107         (modest_connection_specific_smtp_window_save_server_accounts),
1108         (update_model_server_names): Do not actually save data until asked,
1109         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1110
1111         (on_selection_changed),
1112         (modest_connection_specific_smtp_window_init): Disable the edit
1113         button when nothing is selected.
1114
1115         * src/modest-account-mgr-helpers.c:
1116         * src/modest-account-mgr-helpers.h:
1117         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1118         elsewhere.
1119
1120 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
1121
1122         * src/modest-account-mgr-helpers.h:
1123         * src/modest-account-mgr-helpers.c:
1124         (modest_account_mgr_get_unused_account_name),
1125         (modest_account_mgr_get_unused_account_display_name): Added these
1126         utility functions, to avoid code duplication.
1127
1128         * src/maemo/easysetup/modest-easysetup-wizard.c:
1129         (create_page_account_details), (create_account):
1130         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1131         (on_combo_security_changed),
1132         (modest_connection_specific_smtp_edit_window_init),
1133         (modest_connection_specific_smtp_edit_window_save_settings):
1134         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1135         * src/maemo/modest-connection-specific-smtp-window.c:
1136         (modest_connection_specific_smtp_window_finalize),
1137         (modest_connection_specific_smtp_window_fill_with_connections),
1138         (on_button_edit), (modest_connection_specific_smtp_window_init):
1139         * src/maemo/modest-connection-specific-smtp-window.h:
1140         Implementing saving of connection-specific server accounts.
1141
1142         But I need to refactor this so we can save the data for each
1143         possible connection-specific account and only actually create the server accounts
1144         when the easysetup finished, or the OK button is pressed on the account settings
1145         dialog.
1146
1147 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1148
1149         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1150         (on_combo_security_changed):
1151         (modest_connection_specific_smtp_edit_window_init):
1152         Auto-fill the port number as in the account settings.
1153
1154         (modest_connection_specific_smtp_edit_window_set_connection):
1155         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1156         * src/maemo/modest-connection-specific-smtp-window.c:
1157         (fill_with_connections), (on_button_edit),
1158         (modest_connection_specific_smtp_window_init):
1159         Turn the edit window into a dialog to simplify the code, and
1160         set a WM hint as in a GtkDialog, because only a popup can be on top of
1161         another window in Maemo, and popups usually have no WM decoration.
1162
1163         * src/modest-defs.h:
1164         * src/modest-account-mgr-helpers.c:
1165         (modest_account_mgr_set_connection_specific_smtp),
1166         (modest_account_mgr_remove_connection_specific_smtp),
1167         (modest_account_mgr_get_connection_specific_smtp):
1168         * src/modest-account-mgr-helpers.h: Some functions to write the
1169         connection-specific SMTP server information. Not yet used.
1170
1171
1172         * src/widgets/modest-folder-view.c: (text_cell_data):
1173         Fix a warning about an uninitialized variable.
1174         (on_configuration_key_changed): Put an #ifdef around the use
1175         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1176
1177 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1178
1179         * src/maemo/modest-account-settings-dialog.h:
1180         * src/maemo/modest-account-settings-dialog.c:
1181         Added connect_for_modified() utility function to mark the new modified boolean.
1182
1183         (create_page_account_details), (create_page_user_details),
1184         (create_page_incoming), (create_page_outgoing), (on_response),
1185         (modest_account_settings_dialog_init),
1186         (modest_account_settings_dialog_set_account_name):
1187         Only warn about unsaved changes when there are actually unsaved changes.
1188
1189         * src/modest-account-mgr-helpers.c:
1190         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1191         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1192         to get the data from there in future.
1193
1194 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1195
1196         * src/modest-defs.h:
1197
1198         * src/modest-account-mgr-helpers.h:
1199         * src/modest-account-mgr-helpers.c:
1200         Store the security account setting in a single conf key instead of using
1201         the options list, so that the list is left for just the to-be-removed camel hack,
1202         and because gconf_client_set_list() is failing for some reason.
1203
1204         * src/modest-account-mgr.c:
1205         (modest_account_mgr_add_server_account):
1206         * src/maemo/modest-account-settings-dialog.c:
1207         (modest_account_settings_dialog_set_account_name),
1208         (save_configuration): Use the renamed functions.
1209
1210
1211 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1212
1213         * src/widgets/Makefile.am:
1214         * src/widgets/modest-limit-retrieve-combo-box.c:
1215         * src/widgets/modest-limit-retrieve-combo-box.h:
1216         * src/widgets/modest-retrieve-combo-box.c:
1217         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1218         the account settings dialog.
1219
1220         * src/modest-defs.h:
1221         * src/modest-account-mgr-helpers.h:
1222         * src/modest-account-mgr-helpers.c:
1223         (modest_server_account_get_option_secure_auth),
1224         (modest_server_account_set_option_secure_auth):
1225         * src/modest-account-mgr.c:
1226         (modest_account_mgr_add_server_account):
1227         Use the existing AUTH_MECH conf key for the secure-auth setting,
1228         instead of putting it in the list options, because this was actually used already.
1229
1230         * src/maemo/modest-account-settings-dialog.c:
1231         (create_page_account_details),
1232         (modest_account_settings_dialog_set_account_name),
1233         (save_configuration):
1234         * src/maemo/modest-account-settings-dialog.h:
1235         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1236         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1237
1238 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1239
1240         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1241         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1242         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1243
1244         * src/modest-defs.h:
1245         * src/maemo/modest-account-settings-dialog.c:
1246         (create_page_incoming), (on_combo_outgoing_security_changed),
1247         (on_combo_incoming_security_changed), (create_page_outgoing),
1248         (modest_account_settings_dialog_set_account_name),
1249         (save_configuration): Load/Save the port number, and change it when the
1250         security combo changes, to suitable defaults.
1251
1252 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1253
1254         * src/modest-account-mgr.c:
1255         (modest_account_mgr_add_server_account): Set the security and secure-auth
1256         options, and add a comment saying that the other camel-specific options should be
1257         removed in future.
1258
1259 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1260
1261         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1262         found by valgrind.
1263         * src/modest-tny-account-store.c: (account_list_free),
1264         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1265         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1266         easy to fix.
1267
1268 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1269
1270         * src/modest-protocol-info.c:
1271         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1272         is required by our UI spec. Maybe something in our implementation will use this eventually.
1273         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1274         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1275         instead of the previous 0 placeholder.
1276
1277         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1278         secure-auth settings.
1279         * src/modest-account-mgr-helpers.h:
1280         * src/modest-account-mgr-helpers.c:
1281         (modest_server_account_data_get_option_secure_auth),
1282         (modest_server_account_set_option_secure_auth),
1283         (modest_server_account_data_get_option_security),
1284         (modest_server_account_set_option_security): Added this API for getting and setting the security
1285         and secure-auth settings.
1286
1287         * src/maemo/modest-account-settings-dialog.h:
1288         * src/maemo/modest-account-settings-dialog.c:
1289         (modest_account_settings_dialog_finalize), (check_data),
1290         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1291         about changing titles.
1292         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1293         (save_configuration): Save the security and secure-auth settings.
1294
1295         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1296         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1297
1298 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1299
1300         * src/modest-defs.h:
1301         * src/modest-account-mgr.c:
1302         (modest_account_mgr_add_server_account):
1303         Added and used defines for the options key and value pair strings,
1304         that are used so far, though they do not seem to correspond to anything in our
1305         UI specs or ModestProtocol enum.
1306
1307         * src/modest-account-mgr-helpers.h:
1308         * src/modest-account-mgr-helpers.c:
1309         (compare_option_strings_for_name),
1310         (modest_server_account_data_get_option_value),
1311         (modest_server_account_data_get_option_bool),
1312         (modest_account_mgr_get_server_account_option):
1313         Added helper functions for parsing the options GSList.
1314
1315 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1316
1317         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1318         display name is based on the supplied account name.
1319         * src/modest-account-mgr.c:
1320         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1321         with an inefficient, but good-enough, implementation.
1322
1323         * src/maemo/easysetup/modest-easysetup-wizard.c:
1324         (create_page_account_details), (on_before_next), (create_account):
1325         Check for existing display names rather than (non-user-visible) account names, and just
1326         create and set a unique account name at the end.
1327
1328         * src/maemo/modest-account-settings-dialog.c:
1329         (modest_account_settings_dialog_init),
1330         (modest_account_settings_dialog_set_account_name),
1331         (create_page_incoming): Show the display name, instead of the account name.
1332         (on_response): Do some (not all) extra checks, as in the UI spec.
1333         (save_configuration): Save the display name if it was changed.
1334
1335 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1336
1337         * po/en_GB.po: Added needed logical ID and translation.
1338         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1339         (init_view): Made the is-default column clicking work.
1340
1341 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1342
1343         * configure.ac:
1344         * src/maemo/easysetup/Makefile.am:
1345         * src/maemo/easysetup/modest-easysetup-wizard.c:
1346         (modest_easysetup_wizard_dialog_init):
1347         * src/maemo/easysetup/provider-data-test.keyfile:
1348         * src/maemo/easysetup/provider-data.keyfile:
1349         Moved the provider data file to the new modest-providers-data package and used it from there.
1350
1351 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1352
1353         * src/modest-local-folder-info.c:
1354         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1355         N_() was already used on the static strings, but this just marks it for translation without
1356         using the translation.
1357
1358 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1359
1360         * src/maemo/modest-account-settings-dialog.c:
1361         (create_page_incoming),
1362         (modest_account_settings_dialog_set_account_name):
1363         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1364         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1365         I will do this if nobody else gets there first.
1366
1367 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1368
1369         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1370         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1371         save the security stuff.
1372
1373 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1374
1375         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1376         Set the email address and user fullname, which I now see must be
1377         done separately.
1378
1379         * src/maemo/modest-account-settings-dialog.h:
1380         * src/maemo/modest-account-settings-dialog.c:
1381          (on_response),
1382         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1383         leave-on-server and authentication.
1384         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1385         how to do the rest.
1386
1387 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1388
1389
1390         * src/maemo/modest-account-settings-dialog.c:
1391         * src/maemo/modest-account-settings-dialog.h:
1392         Most (but not all) of the widgets are now present as specified by the UI spec.
1393         No changes are yet saved, and some details are not properly shown yet.
1394
1395         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1396
1397 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1398
1399         * src/maemo/Makefile.am:
1400         * src/maemo/modest-account-settings-dialog.c:
1401         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1402         an existing account. Doesn't do much yet.
1403
1404         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1405         Open the accounts settings dialog when Edit is clicked.
1406
1407 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1408
1409         * src/maemo/easysetup/Makefile.am:
1410         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1411         (load_from_file):
1412         * src/maemo/easysetup/modest-easysetup-wizard.c:
1413         (modest_easysetup_wizard_dialog_init):
1414         Try to get the source directory from the build system,
1415         instead of hard-coding "./" into the source code, when opening our local
1416         copies of the configuration files.
1417         But this still fails when opening the wizard from the Accounts window,
1418         maybe because the working directory seems to change at runtime.
1419         So the wizard will fail the second time unless you copy the files into their
1420         proper locations - see the stdout warnings for the paths.
1421
1422         (create_page_account_details),(on_before_next):
1423         Check for existing non-server accounts instead of server accounts,
1424         so the default account name is useful again, and to prevent trying to
1425         recreate accounts.
1426
1427         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1428         Show the wizard when New is clicked.
1429
1430         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1431         (init_view): Show the column headers, and show the columns that are
1432         specified in the UI specs. However, something in Maemo's GTK+ prevents
1433         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1434         change the default account. This is despite unsetting the special properties.
1435
1436 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1437
1438         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1439         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1440         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1441         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1442         to make that clearer.
1443         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1444
1445 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1446
1447         * src/maemo/modest-account-view-window.c:
1448         (modest_account_view_window_init),
1449         (modest_account_view_window_new):
1450         Use the same buttons as specified in the
1451         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1452         the existing widgets, which never had a chance of working.
1453         Put the ModestAccountView treeview in a scrolled window.
1454         Do not repeat the initialization in both _init() and _new().
1455
1456         * src/widgets/modest-account-view.c: (update_account_view):
1457         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1458         this widget and window shows no accounts.
1459
1460         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1461
1462 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1463
1464         * src/maemo/easysetup/modest-easysetup-wizard.c:
1465         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1466         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1467         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1468         which seems wrong.
1469
1470         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1471         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1472         accounts exist yet, as in the UI spec.
1473
1474         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1475
1476 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1477
1478         * src/maemo/Makefile.am:
1479         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1480         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1481         New window for editing connection-specific smtp details.
1482         Not fully implemented.
1483
1484         * src/maemo/modest-connection-specific-smtp-window.c:
1485         (modest_connection_specific_smtp_window_finalize) :
1486         unref the tree model.
1487         (on_button_edit): Show the edit window.
1488
1489 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1490
1491         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1492         error for me.
1493
1494         * src/maemo/Makefile.am:
1495         * src/maemo/modest-connection-specific-smtp-window.c:
1496         * src/maemo/modest-connection-specific-smtp-window.h:
1497         New window for showing the list of connections, for connection-specific
1498         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1499         * src/maemo/easysetup/modest-easysetup-wizard.c:
1500         (create_page_custom_outgoing): Show the new window when the button is clicked.
1501
1502 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1503
1504         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1505         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1506         * src/maemo/modest-msg-edit-window.c:
1507         (modest_msg_edit_window_insert_image):
1508         * src/modest-conf.c: (modest_conf_key_escape):
1509         * src/modest-mail-operation.c:
1510         (modest_mail_operation_send_new_mail):
1511         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1512         (modest_ui_actions_on_new_account):
1513         * src/widgets/modest-attachment-view.c: (update_filename_request):
1514         * src/widgets/modest-mail-header-view.c:
1515         Corrected warnings that were breaking the build, by commenting out unused variables,
1516         and a function, and by including a header.
1517
1518 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1519
1520         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1521         so we can #ifdef around platform-specific code when necessary.
1522         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1523         to allow this to build for the GNOME platform too.
1524
1525 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1526
1527         * src/maemo/easysetup/modest-easysetup-wizard.c:
1528         Added util_increment_name() and used it in create_page_account_details()
1529         to make sure that the default account name is always a new name.
1530
1531         (modest_easysetup_wizard_dialog_init),
1532         (set_default_custom_servernames): Some minor memory management fixes.
1533
1534 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1535
1536         * Makefile.am:
1537         * configure.ac:
1538         * src/modest-runtime.c: (init_i18n): Restored the translation
1539         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1540         are defined in config.h, and the translations are installed.
1541
1542         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1543         is defined for translation.
1544
1545 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1546
1547         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1548         (load_from_file):
1549         * src/maemo/easysetup/modest-easysetup-wizard.c:
1550         (modest_easysetup_wizard_dialog_init):
1551         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1552         Use realistic paths (though they should use $prefix generically) to the
1553         mcc_mapping and provider-data.keyfile files which might work when they
1554         are installed by the future version of the operator-wizard package,
1555         and then fallback to paths in our source code, with an explanatory
1556         warning.
1557
1558 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1559
1560         * configure.ac:
1561         * src/Makefile.am:
1562         * src/maemo/Makefile.am:
1563         * src/maemo/easysetup/: Added files from the previously-exernal
1564         osso-modest-easysetup.
1565         * src/maemo/modest-main-window-ui.h:
1566         * src/modest-ui-actions.c:
1567         * src/modest-ui-actions.h:
1568         Added modest_ui_actions_on_new_account() as a signal handler for the
1569         New Account menu item. It shows the easysetup wizard.
1570         * po/en_GB.po: Added additional needed logical IDs and translations.
1571
1572 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1573 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1574