git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
   4         and uri_parse_mailto() utility functions.
   5         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
   6         the mailto URI.
   7         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
   8
   9 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  10
  11         * src/dbus_api/modest-dbus-api.h:
  12         * src/dbus_api/modest-dbus-callbacks.c:
  13         Use an idle callback to execute the modest code in the application's own thread.
  14         Remove the helloworld example method.
  15         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
  16         parsed, and the open-message method is not implemented because this is not yet implemented in
  17         modest itself.
  18         * libmodest-dbus-client/libmodest-dbus-client.c:
  19         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
  20         (libmodest_dbus_client_open_message):
  21         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
  22
  23         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
  24         body without crashing.
  25
  26         * tests/dbus_api/Makefile.am:
  27         * tests/dbus_api/test_mail_to.c:
  28         * tests/dbus_api/test_open_message.c: New tests for the new methods.
  29
  30 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  31
  32         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
  33         Added file to fix the build. Sorry.
  34
  35         * src/dbus_api/Makefile.am:
  36         * src/dbus_api/modest-dbus-api.h:
  37         * src/dbus_api/modest-dbus-callbacks.h:
  38         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
  39         (modest_dbus_req_handler):
  40         Put constants in a separate header so it can be reused by the
  41         client library, without duplication
  42
  43         * libmodest-dbus-client/Makefile.am:
  44         * libmodest-dbus-client/libmodest-dbus-client.c:
  45         (libmodest_dbus_client_call_helloworld),
  46         (libmodfest_dbus_client_send_mail),
  47         (libmodfest_dbus_client_mailto),
  48         (libmodfest_dbus_client_open_message):
  49         * libmodest-dbus-client/libmodest-dbus-client.h:
  50         (Partly) Implement a send_mail D-Bus method.
  51
  52         * tests/dbus_api/Makefile.am:
  53         * tests/dbus_api/test_send_mail.c: (main): Added a test for
  54         the send_email D-Bus method.
  55
  56 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  57
  58         * Makefile.am:
  59         * configure.ac:
  60         * libmodest-dbus-client/Makefile.am:
  61         * libmodest-dbus-client/libmodest-dbus-client.c:
  62         * libmodest-dbus-client/libmodest-dbus-client.h:
  63         * tests/dbus_api/Makefile.am:
  64         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
  65         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
  66
  67 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  68
  69         * src/maemo/easysetup/modest-easysetup-wizard.c:
  70         (create_page_account_details):
  71         * src/maemo/modest-account-settings-dialog.c:
  72         (create_page_account_details): Explicitly set auto-capitalization mode for the title
  73         widgets, because this might not be the default in future versions of the Maemo GTK+.
  74         However, I can not not get capitalization to work even in a simple test case.
  75
  76 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  77
  78         * src/maemo/easysetup/modest-easysetup-wizard.c:
  79         (create_page_custom_incoming), (create_page_custom_outgoing):
  80         * src/maemo/modest-account-settings-dialog.c:
  81         (create_page_account_details), (create_page_incoming),
  82         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
  83         instead of using gtk_check_button_with_label(), so they are aligned like the other
  84         widgets, as per the UI spec.
  85
  86 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  87
  88         * src/maemo/easysetup/modest-easysetup-wizard.c:
  89         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  90         * src/widgets/modest-validating-entry.c:
  91         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
  92         Modest prefix instead of an EasySetup prefix.
  93
  94 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  95
  96         * src/widgets/modest-validating-entry.h:
  97         * src/widgets/modest-validating-entry.c: (on_insert_text),
  98         Added easysetup_validating_entry_set_max_func(), used to set a callback
  99         to call when the max number of characters is reached. GtkEntry has a max-length
 100         already but is silent about it.
 101
 102         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 103         (create_page_account_details), (create_page_user_details),
 104         (create_account):
 105         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 106         (create_page_account_details), (create_page_user_details),
 107         (create_page_outgoing):
 108         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 109         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 110         the UI spec, when the user tries to enter more than the max number of characters.
 111
 112 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 113
 114         * src/maemo/easysetup/modest-easysetup-wizard.c:
 115         (create_page_user_details), (create_page_custom_incoming),
 116         (create_page_custom_outgoing):
 117         * src/maemo/modest-account-settings-dialog.c:
 118         (create_page_user_details), (create_page_incoming),
 119         (create_page_outgoing):
 120         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 121         (modest_connection_specific_smtp_edit_window_init):
 122         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 123         not appropriate. Bad Maemo-specific defaults!.
 124
 125 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 126
 127         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 128         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 129         (modest_signature_editor_dialog_set_settings):
 130         Disable the label and textview when the checkbox is disabled, and use the
 131         specified (UI spec) default signature text.
 132
 133 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 134
 135         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 136         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 137
 138         * src/modest-defs.h:
 139         * src/modest-account-mgr-helpers.h:
 140         * src/modest-account-mgr-helpers.c:
 141         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 142
 143         * src/maemo/Makefile.am:
 144         * src/maemo/modest-signature-editor-dialog.c:
 145         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 146         as per the UI spec.
 147
 148         * src/maemo/modest-account-settings-dialog.h:
 149         * src/maemo/modest-account-settings-dialog.c:
 150         (modest_account_settings_dialog_finalize), (on_button_signature),
 151         (save_configuration): Use the new dialog when the Edit button is pressed, and
 152         save the changes if necessary, as per the UI spec.
 153
 154 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 155
 156         * src/maemo/Makefile.am:
 157         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 158         based on maemo-develoers email from Dirk.
 159
 160         * src/maemo/easysetup/modest-easysetup-wizard.c:
 161         (create_page_welcome), (create_page_account_details),
 162         (create_page_user_details), (create_page_complete_easysetup),
 163         (create_page_custom_incoming), (create_page_custom_outgoing),
 164         (create_page_complete_custom),
 165         (modest_easysetup_wizard_dialog_init):
 166         * src/maemo/modest-account-settings-dialog.c:
 167         (create_page_account_details), (create_page_user_details),
 168         (create_page_incoming), (create_page_outgoing),
 169         (modest_account_settings_dialog_init):
 170         * src/maemo/modest-connection-specific-smtp-window.c:
 171         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 172
 173 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 174
 175         * src/maemo/easysetup/modest-easysetup-wizard.c:
 176         (create_page_account_details), (create_page_custom_outgoing),
 177         (create_page_complete_custom):
 178         * src/maemo/modest-account-settings-dialog.c:
 179         (create_page_user_details), (create_page_incoming),
 180         (create_page_outgoing):
 181         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 182         (modest_connection_specific_smtp_edit_window_init):
 183         Use the correct (UI spec) port min/max, and use horizontal separators,
 184         as per the UI spec.
 185
 186 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 187
 188         * src/maemo/easysetup/modest-easysetup-wizard.c:
 189         (set_default_custom_servernames):
 190         * src/maemo/modest-account-settings-dialog.c:
 191         (create_page_incoming), (on_combo_outgoing_security_changed),
 192         (on_combo_incoming_security_changed), (create_page_outgoing),
 193         (modest_account_settings_dialog_set_account_name),
 194         (save_configuration):
 195         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 196         (on_combo_security_changed),
 197         (modest_connection_specific_smtp_edit_window_init),
 198         (modest_connection_specific_smtp_edit_window_set_connection),
 199         (modest_connection_specific_smtp_edit_window_get_settings):
 200         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 201         as per the UI spec.
 202
 203 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 204
 205         * po/en_GB.po:
 206         * src/maemo/easysetup/modest-easysetup-wizard.c:
 207         (create_page_custom_outgoing), (create_page_complete_custom):
 208         * src/maemo/modest-account-settings-dialog.c:
 209         (create_page_user_details), (create_page_outgoing):
 210         * src/maemo/modest-account-view-window.c: (button_box_new):
 211         Use changed logical IDs as per the most recent UI spec:
 212         mcen_bd_emailsetup_edit -> mcen_bd_edit
 213         mcen_bd_emailsetup_delete -> mcen_bd_delete
 214         mcen_bd_emailsetup_close -> mcen_bd_close
 215
 216 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 217
 218         * configure.ac:
 219         * src/Makefile.am:
 220         * src/dbus_api/Makefile.am:
 221         * src/dbus_api/modest-dbus-callbacks.c:
 222         * src/dbus_api/modest-dbus-callbacks.h:
 223         * src/maemo/modest-platform.c: (modest_platform_init):
 224         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 225         method.
 226         * tests/Makefile.am:
 227         * tests/dbus_api/Makefile.am:
 228         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 229
 230 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 231
 232         * src/maemo/modest-account-settings-dialog.c:
 233         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 234         Removed unnecessary includes.
 235
 236 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 237
 238         * src/maemo/easysetup/modest-easysetup-wizard.c:
 239         * src/maemo/modest-account-settings-dialog.c:
 240         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 241         * src/widgets/Makefile.am:
 242         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 243         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 244         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 245         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 246         * src/widgets/modest-secureauth-combo-box.c:
 247         * src/widgets/modest-secureauth-combo-box.h:
 248         * src/widgets/modest-serversecurity-combo-box.c:
 249         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 250         made the GObject names more consistent with the rest of the Modest code.
 251
 252 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 253
 254         * src/maemo/easysetup/Makefile.am:
 255         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 256         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 257         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 258         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 259         * src/maemo/easysetup/modest-easysetup-wizard.c:
 260         * src/maemo/easysetup/modest-validating-entry.c:
 261         * src/maemo/easysetup/modest-validating-entry.h:
 262         * src/maemo/modest-account-settings-dialog.c:
 263         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 264         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 265         widgets/ because they are used outside of easysetup too. After checking in,
 266         svn will allow me to rename them too.
 267
 268 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 269
 270         * src/gnome/modest-msg-edit-window.c:
 271         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 272         linker error, to fix the build on the GNOME platform.
 273         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 274         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 275         ifdefed out to avoid a warning.
 276
 277 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 278
 279         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 280         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 281         some alternative for GTK+ 2.6.
 282
 283 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 284
 285         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 286
 287         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 288         specified for EmailAccountsDialog in UI spec.
 289
 290         * src/maemo/easysetup/modest-easysetup-wizard.c:
 291         * src/maemo/easysetup/modest-easysetup-wizard.h:
 292         * src/maemo/modest-account-settings-dialog.c:
 293         * src/maemo/modest-account-settings-dialog.h:
 294         Reuse a member window widget for the connection-specific SMTP server accounts,
 295         so we can tell it to create/save the accounts only if we actually save changes.
 296
 297         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 298         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 299         (modest_connection_specific_smtp_edit_window_get_settings):
 300         Return a struct instance for temporarily remembering the entered data.
 301
 302         * src/maemo/modest-connection-specific-smtp-window.h:
 303         * src/maemo/modest-connection-specific-smtp-window.c:
 304         (modest_connection_specific_smtp_window_finalize),
 305         (modest_connection_specific_smtp_window_fill_with_connections),
 306         (on_button_edit),
 307         (modest_connection_specific_smtp_window_save_server_accounts),
 308         (update_model_server_names): Do not actually save data until asked,
 309         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 310
 311         (on_selection_changed),
 312         (modest_connection_specific_smtp_window_init): Disable the edit
 313         button when nothing is selected.
 314
 315         * src/modest-account-mgr-helpers.c:
 316         * src/modest-account-mgr-helpers.h:
 317         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 318         elsewhere.
 319
 320 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 321
 322         * src/modest-account-mgr-helpers.h:
 323         * src/modest-account-mgr-helpers.c:
 324         (modest_account_mgr_get_unused_account_name),
 325         (modest_account_mgr_get_unused_account_display_name): Added these
 326         utility functions, to avoid code duplication.
 327
 328         * src/maemo/easysetup/modest-easysetup-wizard.c:
 329         (create_page_account_details), (create_account):
 330         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 331         (on_combo_security_changed),
 332         (modest_connection_specific_smtp_edit_window_init),
 333         (modest_connection_specific_smtp_edit_window_save_settings):
 334         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 335         * src/maemo/modest-connection-specific-smtp-window.c:
 336         (modest_connection_specific_smtp_window_finalize),
 337         (modest_connection_specific_smtp_window_fill_with_connections),
 338         (on_button_edit), (modest_connection_specific_smtp_window_init):
 339         * src/maemo/modest-connection-specific-smtp-window.h:
 340         Implementing saving of connection-specific server accounts.
 341
 342         But I need to refactor this so we can save the data for each
 343         possible connection-specific account and only actually create the server accounts
 344         when the easysetup finished, or the OK button is pressed on the account settings
 345         dialog.
 346
 347 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 348
 349         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 350         (on_combo_security_changed):
 351         (modest_connection_specific_smtp_edit_window_init):
 352         Auto-fill the port number as in the account settings.
 353
 354         (modest_connection_specific_smtp_edit_window_set_connection):
 355         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 356         * src/maemo/modest-connection-specific-smtp-window.c:
 357         (fill_with_connections), (on_button_edit),
 358         (modest_connection_specific_smtp_window_init):
 359         Turn the edit window into a dialog to simplify the code, and
 360         set a WM hint as in a GtkDialog, because only a popup can be on top of
 361         another window in Maemo, and popups usually have no WM decoration.
 362
 363         * src/modest-defs.h:
 364         * src/modest-account-mgr-helpers.c:
 365         (modest_account_mgr_set_connection_specific_smtp),
 366         (modest_account_mgr_remove_connection_specific_smtp),
 367         (modest_account_mgr_get_connection_specific_smtp):
 368         * src/modest-account-mgr-helpers.h: Some functions to write the
 369         connection-specific SMTP server information. Not yet used.
 370
 371
 372         * src/widgets/modest-folder-view.c: (text_cell_data):
 373         Fix a warning about an uninitialized variable.
 374         (on_configuration_key_changed): Put an #ifdef around the use
 375         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 376
 377 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 378
 379         * src/maemo/modest-account-settings-dialog.h:
 380         * src/maemo/modest-account-settings-dialog.c:
 381         Added connect_for_modified() utility function to mark the new modified boolean.
 382
 383         (create_page_account_details), (create_page_user_details),
 384         (create_page_incoming), (create_page_outgoing), (on_response),
 385         (modest_account_settings_dialog_init),
 386         (modest_account_settings_dialog_set_account_name):
 387         Only warn about unsaved changes when there are actually unsaved changes.
 388
 389         * src/modest-account-mgr-helpers.c:
 390         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 391         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 392         to get the data from there in future.
 393
 394 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 395
 396         * src/modest-defs.h:
 397
 398         * src/modest-account-mgr-helpers.h:
 399         * src/modest-account-mgr-helpers.c:
 400         Store the security account setting in a single conf key instead of using
 401         the options list, so that the list is left for just the to-be-removed camel hack,
 402         and because gconf_client_set_list() is failing for some reason.
 403
 404         * src/modest-account-mgr.c:
 405         (modest_account_mgr_add_server_account):
 406         * src/maemo/modest-account-settings-dialog.c:
 407         (modest_account_settings_dialog_set_account_name),
 408         (save_configuration): Use the renamed functions.
 409
 410
 411 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 412
 413         * src/widgets/Makefile.am:
 414         * src/widgets/modest-limit-retrieve-combo-box.c:
 415         * src/widgets/modest-limit-retrieve-combo-box.h:
 416         * src/widgets/modest-retrieve-combo-box.c:
 417         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 418         the account settings dialog.
 419
 420         * src/modest-defs.h:
 421         * src/modest-account-mgr-helpers.h:
 422         * src/modest-account-mgr-helpers.c:
 423         (modest_server_account_get_option_secure_auth),
 424         (modest_server_account_set_option_secure_auth):
 425         * src/modest-account-mgr.c:
 426         (modest_account_mgr_add_server_account):
 427         Use the existing AUTH_MECH conf key for the secure-auth setting,
 428         instead of putting it in the list options, because this was actually used already.
 429
 430         * src/maemo/modest-account-settings-dialog.c:
 431         (create_page_account_details),
 432         (modest_account_settings_dialog_set_account_name),
 433         (save_configuration):
 434         * src/maemo/modest-account-settings-dialog.h:
 435         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 436         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 437
 438 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 439
 440         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 441         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 442         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 443
 444         * src/modest-defs.h:
 445         * src/maemo/modest-account-settings-dialog.c:
 446         (create_page_incoming), (on_combo_outgoing_security_changed),
 447         (on_combo_incoming_security_changed), (create_page_outgoing),
 448         (modest_account_settings_dialog_set_account_name),
 449         (save_configuration): Load/Save the port number, and change it when the
 450         security combo changes, to suitable defaults.
 451
 452 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 453
 454         * src/modest-account-mgr.c:
 455         (modest_account_mgr_add_server_account): Set the security and secure-auth
 456         options, and add a comment saying that the other camel-specific options should be
 457         removed in future.
 458
 459 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 460
 461         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 462         found by valgrind.
 463         * src/modest-tny-account-store.c: (account_list_free),
 464         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 465         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 466         easy to fix.
 467
 468 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 469
 470         * src/modest-protocol-info.c:
 471         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 472         is required by our UI spec. Maybe something in our implementation will use this eventually.
 473         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 474         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 475         instead of the previous 0 placeholder.
 476
 477         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 478         secure-auth settings.
 479         * src/modest-account-mgr-helpers.h:
 480         * src/modest-account-mgr-helpers.c:
 481         (modest_server_account_data_get_option_secure_auth),
 482         (modest_server_account_set_option_secure_auth),
 483         (modest_server_account_data_get_option_security),
 484         (modest_server_account_set_option_security): Added this API for getting and setting the security
 485         and secure-auth settings.
 486
 487         * src/maemo/modest-account-settings-dialog.h:
 488         * src/maemo/modest-account-settings-dialog.c:
 489         (modest_account_settings_dialog_finalize), (check_data),
 490         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 491         about changing titles.
 492         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 493         (save_configuration): Save the security and secure-auth settings.
 494
 495         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 496         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 497
 498 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 499
 500         * src/modest-defs.h:
 501         * src/modest-account-mgr.c:
 502         (modest_account_mgr_add_server_account):
 503         Added and used defines for the options key and value pair strings,
 504         that are used so far, though they do not seem to correspond to anything in our
 505         UI specs or ModestProtocol enum.
 506
 507         * src/modest-account-mgr-helpers.h:
 508         * src/modest-account-mgr-helpers.c:
 509         (compare_option_strings_for_name),
 510         (modest_server_account_data_get_option_value),
 511         (modest_server_account_data_get_option_bool),
 512         (modest_account_mgr_get_server_account_option):
 513         Added helper functions for parsing the options GSList.
 514
 515 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 516
 517         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 518         display name is based on the supplied account name.
 519         * src/modest-account-mgr.c:
 520         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 521         with an inefficient, but good-enough, implementation.
 522
 523         * src/maemo/easysetup/modest-easysetup-wizard.c:
 524         (create_page_account_details), (on_before_next), (create_account):
 525         Check for existing display names rather than (non-user-visible) account names, and just
 526         create and set a unique account name at the end.
 527
 528         * src/maemo/modest-account-settings-dialog.c:
 529         (modest_account_settings_dialog_init),
 530         (modest_account_settings_dialog_set_account_name),
 531         (create_page_incoming): Show the display name, instead of the account name.
 532         (on_response): Do some (not all) extra checks, as in the UI spec.
 533         (save_configuration): Save the display name if it was changed.
 534
 535 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 536
 537         * po/en_GB.po: Added needed logical ID and translation.
 538         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 539         (init_view): Made the is-default column clicking work.
 540
 541 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 542
 543         * configure.ac:
 544         * src/maemo/easysetup/Makefile.am:
 545         * src/maemo/easysetup/modest-easysetup-wizard.c:
 546         (modest_easysetup_wizard_dialog_init):
 547         * src/maemo/easysetup/provider-data-test.keyfile:
 548         * src/maemo/easysetup/provider-data.keyfile:
 549         Moved the provider data file to the new modest-providers-data package and used it from there.
 550
 551 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 552
 553         * src/modest-local-folder-info.c:
 554         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 555         N_() was already used on the static strings, but this just marks it for translation without
 556         using the translation.
 557
 558 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 559
 560         * src/maemo/modest-account-settings-dialog.c:
 561         (create_page_incoming),
 562         (modest_account_settings_dialog_set_account_name):
 563         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 564         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 565         I will do this if nobody else gets there first.
 566
 567 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 568
 569         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 570         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 571         save the security stuff.
 572
 573 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 574
 575         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 576         Set the email address and user fullname, which I now see must be
 577         done separately.
 578
 579         * src/maemo/modest-account-settings-dialog.h:
 580         * src/maemo/modest-account-settings-dialog.c:
 581          (on_response),
 582         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 583         leave-on-server and authentication.
 584         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 585         how to do the rest.
 586
 587 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 588
 589
 590         * src/maemo/modest-account-settings-dialog.c:
 591         * src/maemo/modest-account-settings-dialog.h:
 592         Most (but not all) of the widgets are now present as specified by the UI spec.
 593         No changes are yet saved, and some details are not properly shown yet.
 594
 595         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 596
 597 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 598
 599         * src/maemo/Makefile.am:
 600         * src/maemo/modest-account-settings-dialog.c:
 601         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 602         an existing account. Doesn't do much yet.
 603
 604         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 605         Open the accounts settings dialog when Edit is clicked.
 606
 607 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 608
 609         * src/maemo/easysetup/Makefile.am:
 610         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 611         (load_from_file):
 612         * src/maemo/easysetup/modest-easysetup-wizard.c:
 613         (modest_easysetup_wizard_dialog_init):
 614         Try to get the source directory from the build system,
 615         instead of hard-coding "./" into the source code, when opening our local
 616         copies of the configuration files.
 617         But this still fails when opening the wizard from the Accounts window,
 618         maybe because the working directory seems to change at runtime.
 619         So the wizard will fail the second time unless you copy the files into their
 620         proper locations - see the stdout warnings for the paths.
 621
 622         (create_page_account_details),(on_before_next):
 623         Check for existing non-server accounts instead of server accounts,
 624         so the default account name is useful again, and to prevent trying to
 625         recreate accounts.
 626
 627         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 628         Show the wizard when New is clicked.
 629
 630         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 631         (init_view): Show the column headers, and show the columns that are
 632         specified in the UI specs. However, something in Maemo's GTK+ prevents
 633         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 634         change the default account. This is despite unsetting the special properties.
 635
 636 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 637
 638         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 639         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 640         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 641         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 642         to make that clearer.
 643         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 644
 645 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 646
 647         * src/maemo/modest-account-view-window.c:
 648         (modest_account_view_window_init),
 649         (modest_account_view_window_new):
 650         Use the same buttons as specified in the
 651         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 652         the existing widgets, which never had a chance of working.
 653         Put the ModestAccountView treeview in a scrolled window.
 654         Do not repeat the initialization in both _init() and _new().
 655
 656         * src/widgets/modest-account-view.c: (update_account_view):
 657         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 658         this widget and window shows no accounts.
 659
 660         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 661
 662 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 663
 664         * src/maemo/easysetup/modest-easysetup-wizard.c:
 665         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 666         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 667         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 668         which seems wrong.
 669
 670         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 671         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 672         accounts exist yet, as in the UI spec.
 673
 674         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 675
 676 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 677
 678         * src/maemo/Makefile.am:
 679         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 680         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 681         New window for editing connection-specific smtp details.
 682         Not fully implemented.
 683
 684         * src/maemo/modest-connection-specific-smtp-window.c:
 685         (modest_connection_specific_smtp_window_finalize) :
 686         unref the tree model.
 687         (on_button_edit): Show the edit window.
 688
 689 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 690
 691         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 692         error for me.
 693
 694         * src/maemo/Makefile.am:
 695         * src/maemo/modest-connection-specific-smtp-window.c:
 696         * src/maemo/modest-connection-specific-smtp-window.h:
 697         New window for showing the list of connections, for connection-specific
 698         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 699         * src/maemo/easysetup/modest-easysetup-wizard.c:
 700         (create_page_custom_outgoing): Show the new window when the button is clicked.
 701
 702 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 703
 704         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 705         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 706         * src/maemo/modest-msg-edit-window.c:
 707         (modest_msg_edit_window_insert_image):
 708         * src/modest-conf.c: (modest_conf_key_escape):
 709         * src/modest-mail-operation.c:
 710         (modest_mail_operation_send_new_mail):
 711         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 712         (modest_ui_actions_on_new_account):
 713         * src/widgets/modest-attachment-view.c: (update_filename_request):
 714         * src/widgets/modest-mail-header-view.c:
 715         Corrected warnings that were breaking the build, by commenting out unused variables,
 716         and a function, and by including a header.
 717
 718 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 719
 720         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 721         so we can #ifdef around platform-specific code when necessary.
 722         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 723         to allow this to build for the GNOME platform too.
 724
 725 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 726
 727         * src/maemo/easysetup/modest-easysetup-wizard.c:
 728         Added util_increment_name() and used it in create_page_account_details()
 729         to make sure that the default account name is always a new name.
 730
 731         (modest_easysetup_wizard_dialog_init),
 732         (set_default_custom_servernames): Some minor memory management fixes.
 733
 734 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 735
 736         * Makefile.am:
 737         * configure.ac:
 738         * src/modest-runtime.c: (init_i18n): Restored the translation
 739         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 740         are defined in config.h, and the translations are installed.
 741
 742         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 743         is defined for translation.
 744
 745 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 746
 747         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 748         (load_from_file):
 749         * src/maemo/easysetup/modest-easysetup-wizard.c:
 750         (modest_easysetup_wizard_dialog_init):
 751         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 752         Use realistic paths (though they should use $prefix generically) to the
 753         mcc_mapping and provider-data.keyfile files which might work when they
 754         are installed by the future version of the operator-wizard package,
 755         and then fallback to paths in our source code, with an explanatory
 756         warning.
 757
 758 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 759
 760         * configure.ac:
 761         * src/Makefile.am:
 762         * src/maemo/Makefile.am:
 763         * src/maemo/easysetup/: Added files from the previously-exernal
 764         osso-modest-easysetup.
 765         * src/maemo/modest-main-window-ui.h:
 766         * src/modest-ui-actions.c:
 767         * src/modest-ui-actions.h:
 768         Added modest_ui_actions_on_new_account() as a signal handler for the
 769         New Account menu item. It shows the easysetup wizard.
 770         * po/en_GB.po: Added additional needed logical IDs and translations.
 771
 772 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 773 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 774