1 2007-07-13 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-mail-operation.c: (update_account_thread):
4 Initialized num_new_headers to fix the build.
6 2007-07-13 Murray Cumming <murrayc@murrayc.com>
8 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
9 Ignore modest accounts whose server accounts don't exist in gconf.
10 This prevents us trying to create TnyAccount instances for those
11 server accounts when the server account has been removed from gconf,
12 but the parent modest account has not yet been removed from modest.
13 I don't know why this is only noticeable now. It was probably just
14 a harmeless g_warning() anyway.
16 2007-07-13 Murray Cumming <murrayc@murrayc.com>
18 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
19 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
21 2007-07-12 Armin Burgmeier <armin@openismus.com>
23 * src/maemo/modest-main-window.c: Make default account appear bold
24 in view, tools/send & receive and toolbar/send & receive SCM menus.
25 This fixes projects.maemo.org bug NB#59010.
27 2007-07-12 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
30 Add a short-cut, by checking if the folder store is an account.
31 This ensures that the Sort menu item and toolbar is dimmed for
32 the local-folders account root item, fixing
33 projects.maemo.org bug NB#62545.
35 2007-07-12 Murray Cumming <murrayc@murrayc.com>
37 * src/modest-tny-account-store.c: (get_password):
38 Show the password dialog (via the signal) only in the mainloop, via
39 an idle handler that we wait for. This could theoretically prevent
40 hangs, though I worry that it could introduce some too.
42 2007-07-12 Murray Cumming <murrayc@murrayc.com>
44 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
45 * src/maemo/modest-platform.c:
46 (modest_platform_connect_and_wait):
47 Take a TnyAccount* parameter and try to set it to online
48 (a TnyCamel-only API), because tinymail sets accounts to offline
49 when the user cancels a password dialog, and doesn't ask again until
50 it has been set to online.
51 However, this is commented out because it causes a hang now.
53 (modest_platform_connect_and_wait_if_network_account):
54 * src/modest-mail-operation.c:
55 (modest_mail_operation_update_account):
56 * src/modest-platform.h:
57 * src/modest-ui-actions.c: (_modest_ui_actions_open),
58 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
60 2007-07-12 Armin Burgmeier <armin@openismus.com>
62 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
64 * src/modest-mail-operation.c:
65 * src/modest-ui-actions.c: Check for already existing folder before
66 querying the server, show error message from camel if the request
67 still fails. This fixes projects.maemo.org bug NB#58701.
69 2007-07-12 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-tny-account-store.h:
72 * src/modest-tny-account-store.c:
73 Added modest_tny_account_store_forget_password_in_memory(),
74 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
75 when creating a new account, so that new passwords will be used, instead of
76 us thinking that it's a second request as a result of a failed password again.
78 2007-07-12 Murray Cumming <murrayc@murrayc.com>
80 * src/dbus_api/modest-dbus-callbacks.c:
81 (on_idle_open_message): If the message is in drafts then open it
82 in an edit window instead of a view window. This fixes
83 projects.maemo.org bug NB#63005.
85 2007-07-12 Murray Cumming <murrayc@murrayc.com>
87 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
88 Avoided a harmless g_warning().
90 2007-07-12 Murray Cumming <murrayc@murrayc.com>
92 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
93 Pass the modest account name, not the TnyAccount display name to
94 modest_msg_view_window_new() so that the reply feature works,
95 fixing projects.maemo.org bug NB#62892.
97 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
98 (modest_msg_view_window_new_with_header_model):
99 * src/maemo/modest-msg-view-window.c:
100 (modest_msg_view_window_new_with_header_model),
101 (modest_msg_view_window_new):
102 * src/modest-ui-actions.c: (reply_forward):
103 * src/widgets/modest-msg-view-window.h:
104 * src/widgets/modest-window.c: (modest_window_set_active_account):
105 Rename an account parameter to modest_account_name to make this clearer.
107 2007-07-11 Murray Cumming <murrayc@murrayc.com>
109 * src/modest-ui-actions.h:
110 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
111 modest_do_message_delete().
112 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
113 Call modest_do_message_delete(), hoping that this would cause messages
114 to be really deleted from search instead of just marked with strike through.
115 Does not seem to help.
117 2007-07-11 Armin Burgmeier <armin@openismus.com>
119 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
120 priv->reselect to FALSE prior to calling
121 modest_folder_view_select_first_inbox_or_local() to prevent endless
122 recursion and thus a crash on startup.
124 2007-07-11 Armin Burgmeier <armin@openismus.com>
126 * src/maemo/modest-account-settings-dialog.h: Include
127 <gtk/gtknotebook.h> to fix the build (at least for me).
129 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
130 Use "New FolderN" as default suggested name if "New folder" already
131 exists, with N being the first free number, though never exceed "New
132 folder99" in which case we just fall back to "New Folder" even though
133 it already exists. This fixes projects.maemo.org bug NB#58663.
135 2007-07-11 Murray Cumming <murrayc@murrayc.com>
137 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
138 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
139 projects.maemo.org bug NB#62778.
141 2007-07-11 Murray Cumming <murrayc@murrayc.com>
143 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
144 Ignore the wrong (for now) secure-smtp setting in the presets -
145 just default to requiring secure authentication for SMTP, because
148 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
150 * src/widgets/modest-folder-view.c: (filter_row)
151 Do not show drafts folder (see UI specs)
153 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
155 * src/modest-ui-actions.c:
156 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
157 place and also not necessary.
159 * src/widgets/modest-folder-view.c: (filter_row)
160 Guess folder type and hide Sent & Outbox if necessary.
161 Fixed project.maemo.org NB#57328
163 2007-07-11 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-ui-actions.h:
166 * src/modest-ui-actions.c:
167 (modest_ui_actions_on_delete_message):
168 Move some code into a new
169 modest_ui_actions_refresh_message_window_after_delete()
170 function so we can use it from elsewhere.
172 * src/dbus_api/modest-dbus-callbacks.c:
173 (on_idle_delete_message), (on_delete_message): Used an idle
174 handler, as we do for the other D-Bus method handlers.
175 Call modest_ui_actions_refresh_message_window_after_delete()
176 if the deleted message was open in a window. This fixed
177 projects.maemo.org bug NB#62862.
179 2007-07-11 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-main.c: (main): Only show the UI at the start if
182 the showui command line option was given. For instance,
183 run-standalone src/modest showui
184 Otherwise, we wait for the top_application D-Bus method to
185 be sent by hildon-desktop when the application is selected
187 This allows us to run without a UI when osso-global-search
188 uses our D-Bus methods.
190 2007-07-11 Murray Cumming <murrayc@murrayc.com>
192 * src/dbus_api/modest-dbus-api.h: Added a define for a
193 top-application D-Bus method.
194 * src/dbus_api/modest-dbus-callbacks.c:
195 (on_top_application),
196 (modest_dbus_req_handler): Handle the top-application D-Bus
197 method, which might be an undocumented D-Bus signal sent by
198 hildon-desktop when it starts the application from the menu.
199 But I am not sure and I need to test it on the device, because
200 my scratchbox does not have the application in the menu now.
201 This method shows the main window, so that it can be invisible
202 when started, for instance, just for email searching from
205 * src/maemo/modest-main-window.c: (restore_settings),
206 (modest_main_window_new): Do not show the window immediately
207 upon creation. We show it later.
208 * src/modest-widget-memory.c: (save_settings_paned):
209 Try (unsuccessfully) to avoid saving the paned position when
210 it is not even visible.
211 (restore_settings_paned): Do not allow a silly paned position.
212 This seems necessary when not showing the window at first.
214 * tests/dbus_api/Makefile.am:
215 * tests/dbus_api/test_top_application.c: (main): Test for the
218 2007-07-10 Murray Cumming <murrayc@murrayc.com>
220 * src/modest-ui-dimming-rules.c:
221 (modest_ui_dimming_rules_on_new_msg),
222 (modest_ui_dimming_rules_on_reply_msg),
223 (modest_ui_dimming_rules_on_delete_msg),
224 (modest_ui_dimming_rules_on_details),
225 (modest_ui_dimming_rules_on_view_window_move_to),
226 (modest_ui_dimming_rules_on_view_previous),
227 (modest_ui_dimming_rules_on_view_next),
228 (_invalid_folder_for_purge): Added checks before
229 casting the window. This looks like an actual
230 logic error in _invalid_folder_for_purge(), because it
231 tries to use a ModestMainWindow as a message window.
233 2007-07-10 Murray Cumming <murrayc@murrayc.com>
235 * src/maemo/modest-account-settings-dialog.c:
236 (show_error): Use the same implementation as in
237 modest-easysetup-wizard.c:
238 (on_entry_invalid_character): The logical ID contains a %s.
239 Guessed what it should be.
240 (on_entry_max), (check_data), (on_response): Adapt to
241 changed show_error().
242 (create_page_account_details): Really call
243 modest_validating_entry_set_func() on the correct widgets.
244 * src/maemo/easysetup/modest-easysetup-wizard.c:
245 (on_entry_invalid_character): Fix the logical ID here too.
246 (create_page_account_details),
247 (create_page_user_details):
249 modest_validating_entry_set_func() on the correct widgets.
251 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
252 Do not try to use the account if it is NULL.
254 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
256 * src/modest-ui-actions.c: (create_move_to_dialog),
257 (modest_ui_actions_on_main_window_move_to),
258 (modest_ui_actions_on_msg_view_window_move_to):
259 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
260 (filter_row), (modest_folder_view_show_non_move_folders):
261 * src/widgets/modest-folder-view.h:
263 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
264 the Sent folder yet as it does not report the correct folder type.
266 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
268 * src/maemo/modest-msg-edit-window.c: (init_window):
271 2007-07-10 Murray Cumming <murrayc@murrayc.com>
273 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
274 Take a parent widget instead of a parent window, and
275 implement this with hildon_banner_show_information() instead.
276 Non-Maemo builds can just ifdef that there.
277 This fixed projects.maemo.org bug NB#62766.
279 (on_entry_invalid_character): Use show_error() again instead
280 of using hildon directly, and use the _CS() macro to use the correct
282 (create_account), (check_for_supported_auth_methods), (on_entry_max):
283 Pass a widget instead od a window to show_error().
285 2007-07-10 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
288 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
289 This allows us to show the server name in the error message, fixing
290 projects.maemo.org bug NB#62904.
291 Also, use the appropriate logical ID message for the account protocol.
293 2007-07-10 Murray Cumming <murrayc@murrayc.com>
295 * src/modest-tny-account-store.c: (on_idle_wrong_password):
296 A compilation fix, though the build wasn't broken for me.
298 2007-07-09 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
301 Do not try to unref a NULL folder store, to avoid a runtime warning.
302 This seems to happen sometimes when changing accounts settings.
304 2007-07-09 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-tny-account-store.c:
307 (modest_tny_account_store_instance_init),
308 (modest_tny_account_store_finalize),
309 (on_account_settings_hide), (on_idle_wrong_password):
310 Use a GHashTable to ensure that we only show one account settings
311 dialog per modest account. This avoids us having a dialog open for
312 both the store and transport accounts, or due to repeated get_password()
313 calls that shouldn't happen anyway.
315 2007-07-09 Murray Cumming <murrayc@murrayc.com>
317 * src/maemo/modest-maemo-utils.c: (on_hide),
318 (modest_maemo_show_dialog_and_forget): Handle the response, because
319 the window is not even hidden by default.
321 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
322 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
323 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
324 which seems to prevent some modality problems.
326 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
327 Ignore user cancellation errors.
329 * src/modest-account-mgr-helpers.h:
330 * src/modest-account-mgr-helpers.c:
331 Added modest_server_account_get_password() and
332 modest_server_account_get_has_password() to avoid direct use of
335 * src/maemo/modest-account-settings-dialog.h:
336 * src/maemo/modest-account-settings-dialog.c:
337 (modest_account_settings_dialog_init): Store the notebook so we can
339 Added modest_account_settings_dialog_switch_to_user_info().
341 * src/modest-tny-account-store.c:
342 (get_password): When the password in the account settings is wrong (we think),
343 show the relevant page of the account settings dialog, in the mainloop.
344 However, we currently get many of these at once because cancel does not
346 (forget_password): Do not forget the password
347 from the account settings, because this causes side-effects when
348 tinymail seems to call it at strange time, maybe because of how we
349 are cancelling get_password().
350 (modest_tny_account_store_alert): Ignore user cancellations.
352 2007-07-09 Murray Cumming <murrayc@murrayc.com>
354 * src/maemo/modest-maemo-utils.h:
355 * src/maemo/modest-maemo-utils.c:
356 Added modest_maemo_show_information_note_and_forget() for use instead of
357 gtk_dialog_run() when the response is not needed, to avoid an extra
358 mainloop which could cause a hang.
360 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
361 Use the logical IDs for the error message, though they are not
362 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
363 because gtk_dialog_run() caused a hang here (the window did not close).
364 This fixes projects.maemo.org bug NB#62646.
366 2007-07-09 Murray Cumming <murrayc@murrayc.com>
368 * src/modest-account-mgr-helpers.h:
369 * src/modest-account-mgr-helpers.c:
370 Added modest_account_mgr_get_store_protocol().
372 * src/maemo/modest-account-view-window.c:
373 (on_delete_button_clicked): Show different warning text depending on
374 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
375 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
378 2007-07-09 Murray Cumming <murrayc@murrayc.com>
380 * src/maemo/modest-msg-edit-window.c:
381 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
382 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
384 2007-07-07 Armin Burgmeier <armin@openismus.com>
386 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
387 ckdg_ib_maximum_characters_reached from correct package.
389 * src/modest-ui-actions.c: Show an error message when a folder could
390 not be created. Tinymail does not give us specific error codes about
391 what has gone wrong, so we assume that a folder with that name
392 already exists, though there might be other reasons.
394 2007-07-06 Murray Cumming <murrayc@murrayc.com>
396 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
397 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
398 give a more exact error message that can be partly translated.
400 2007-07-05 Murray Cumming <murrayc@murrayc.com>
402 * src/maemo/modest-address-book.c:
403 (select_email_addrs_for_contact): Specify a default window size for the
404 select-email-address dialog, so that it is probably big enough for the
405 title. This should fix projects.maemo.org bug NB#62277.
407 2007-07-05 Murray Cumming <murrayc@murrayc.com>
409 * src/maemo/easysetup/modest-easysetup-wizard.c:
410 (create_page_complete_easysetup): Use
411 gtk_widget_set_size() request to ensure that the text wraps
414 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
416 * src/maemo/easysetup/modest-easysetup-wizard.c:
417 (on_entry_invalid_character), (create_page_account_details),
418 (create_page_user_details):
419 Use new API of ModestValidatingEntry. But for some reason the banner is
420 not shown. I will have to investigate that further.
422 * src/widgets/modest-validating-entry.c: (on_insert_text),
423 (modest_validating_entry_set_func):
424 * src/widgets/modest-validating-entry.h:
425 Added a new callback function to be able to react to prevented
426 characters whitespaces to e.g show a banner.
428 2007-07-05 Armin Burgmeier <armin@openismus.com>
430 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
431 notification of HildonNumberEditor instead of remembering the port
432 number. Thanks to Johannes for pointing this out.
434 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
436 * src/maemo/easysetup/modest-easysetup-wizard.c:
437 Check if there are any user changes before showing a confirmation
438 dialog (projects.maemo.org NB#60946)
440 2007-07-05 Armin Burgmeier <armin@openismus.com>
442 * src/maemo/modest-account-settings-dialog.c: Remember custom port
443 number at the beginning of the dialog and set the modified flag at the
444 end if the port number has changed. This is necessary because
445 HildonNumberEditor does not support notification when the value has
448 2007-07-05 Murray Cumming <murrayc@murrayc.com>
450 * src/modest-ui-actions.c:
451 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
452 a connection before asking anything else. Correct the check for the destination
453 folder so that it succeeds when online.
454 This fixed projects.maemo.org bug NB#61645.
456 2007-07-05 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
459 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
460 to fix projects.maemo.org bug NB#62439.
462 2007-07-05 Murray Cumming <murrayc@murrayc.com>
464 * src/modest-tny-account.c: (on_connection_status_changed):
465 Really do not use tny_device_force_offline() here. See the previous comment.
467 2007-07-04 Murray Cumming <murrayc@murrayc.com>
469 * src/modest-tny-account.c: (on_connection_status_changed):
470 Do not use tny_device_force_offline() when tinymail says that something
471 went wrong with the connection. It seems to report this unnecessarily.
473 2007-07-04 Murray Cumming <murrayc@murrayc.com>
475 * src/maemo/modest-connection-specific-smtp-window.c:
476 (modest_connection_specific_smtp_window_init):
477 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
478 does not seem to have any effect in osso 1.1 (though it works in
479 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
481 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
483 * src/maemo/modest-connection-specific-smtp-window.c:
484 Fix UI specification problems with projects.meamo.org NB#60479
486 2007-07-04 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
489 clue when this has failed, because the error dialog is not always shown
490 (at least in earlier version).
492 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
493 GError message, because the generic error dialog is not helpful.
495 'This message is not currently available (can't let a new connection go online)'
496 when trying to open an IMAP message.
498 (_modest_ui_actions_open): Offer a connection when some messages would
499 have to be downloaded and we are offline.
501 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
503 * src/widgets/modest-folder-view.c:
504 Don't check for MERGE type anymore as we use the correct type
506 NOTE: For the last two changes you need to update your tinymail copy
507 because of API changes!
509 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
511 * src/modest-tny-local-folders-account.c:
512 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
513 (see projects.maemo.org NB#61580)
515 2007-07-04 Murray Cumming <murrayc@murrayc.com>
517 * src/modest-tny-account.c: (on_connection_status_changed):
518 Commented out the call to modest_platform_connect_and_wait() because this
519 seems to always hang, and I would like to know if this is the only thing
520 that causes a hang when showing the connection dialog.
521 It is not very useful anyway.
523 2007-07-04 Murray Cumming <murrayc@murrayc.com>
525 * src/maemo/modest-msg-view-window.c:
526 (modest_msg_view_window_select_next_message):
528 * src/modest-platform.h:
529 * src/maemo/modest-platform.c:
530 Added modest_platform_connect_and_wait(), which calls
531 tny_maemo_conic_device_connect() always in the main thread, by calling it
532 in an idle handler and waiting for the idle handler to run. It should be
533 in the main thread because it uses GTK+ UI code. It just returns TRUE
534 if the device is already online.
536 There is some nasty code to ensure that subsequent calls to
537 modest_platform_connect_and_wait() just wait for the first one to finish,
538 by checking repeatedly in another idle handler. This is necessary,
539 because other threads (or even the main thread, via another idle handler)
540 can call modest_platform_connect_and_wait() while
541 modest_platform_connect_and_wait() is running.
543 (modest_platform_connect_and_wait_if_network_account),
544 (modest_platform_connect_and_wait_if_network_folderstore):
545 Convenience functions that calls modest_platform_connect_and_wait() if
546 the account or folder might want network access.
548 * src/modest-mail-operation.c:
549 (modest_mail_operation_update_account):
550 * src/modest-ui-actions.c: (download_uncached_messages),
551 (modest_ui_actions_on_rename_folder), (delete_folder),
552 (modest_ui_actions_on_main_window_move_to),
553 (modest_ui_actions_on_msg_view_window_move_to):
554 * src/widgets/modest-folder-view.c:
555 (drag_and_drop_from_folder_view):
556 Offer a connection if we are offline.
558 * src/modest-tny-account.c: (on_connection_status_changed):
559 Document this as only handling errors during network operations in progress,
560 and replace the idle code with a simple call to
561 modest_platform_connect_and_wait(), which does this instead.
563 2007-07-03 Murray Cumming <murrayc@murrayc.com>
565 * src/modest-tny-account.c:
566 (modest_tny_account_get_special_folder): (util_on_idle),
567 Handle the GError so we can see when tny_folder_store_get_folders()
568 fails, as it currently does while something else is connecting.
570 Added util_run_in_main_thread_and_wait()
571 which uses an idlen handler and mainloop to ensure that the function
572 is called in the main thread.
573 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
574 to make sure that we call attempt the connection in the mainloop only,
575 which might solve some hangs.
577 2007-07-03 Murray Cumming <murrayc@murrayc.com>
579 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
580 be found by their display name. This is never useful.
581 * src/modest-tny-account-store.c: (on_account_removed): Find the account
582 by its ID, instead of trying to use its ID as its display name.
584 * src/modest-tny-account-store.h:
585 * src/modest-tny-account.c:
586 (modest_tny_account_get_special_folder): Add a g_warning() when
587 tny_folder_store_get_folders() returns an empty list for the maildir.
589 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
590 Add a g_warning() when this returns NULL, because that it not allowed
593 2007-07-02 Armin Burgmeier <armin@openismus.com>
595 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
596 note when trying to cancel the wizard. This fixes projects.maemo.org
599 2007-07-02 Murray Cumming <murrayc@murrayc.com>
601 * src/modest-tny-account.h:
602 * src/modest-tny-account.c:
603 (modest_tny_account_new_from_server_account),
604 (modest_tny_account_new_from_server_account_name),
605 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
606 because this must now be set before setting the proto. This is usd in
607 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
608 warning in camel_session_get_service() caused by
609 tny_camel_transport_account_prepare().
611 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
614 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
616 * src/maemo/modest-connection-specific-smtp-edit-window.c:
618 (modest_connection_specific_smtp_edit_window_init):
620 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
623 2007-06-29 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-tny-account.c:
626 (modest_tny_account_new_from_server_account):
627 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
628 now uses to request a connection when it needs one, and which it uses
629 to tell us that something is wrong with the connection, so we can force
630 the accounts offline to prevent further problems.
633 * src/modest-init.c: (init_default_settings):
634 * src/modest-mail-operation.c:
635 (modest_mail_operation_update_account):
636 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
637 This should not be necessary anymore. Do not set the conf key that
638 determined this (it was always TRUE and not set anywhere else).
640 * src/modest-ui-actions.h: Remove unused and unimplemented
641 modest_ui_actions_on_online_toggle_toggled().
643 2007-06-29 Murray Cumming <murrayc@murrayc.com
645 * src/maemo/modest-main-window.c: (connect_signals):
646 Don't connect to delete_event twice. Maybe this was harmless.
648 2007-06-29 Murray Cumming <murrayc@murrayc.com
650 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
651 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
652 Debug output to give some more clue when a folder move is not allowed.
654 2007-06-28 Murray Cumming <murrayc@murrayc.com
656 * src/modest-tny-account.c: (on_modest_file_system_info),
657 (modest_tny_account_get_mmc_account_name):
658 Always call the callback, without checking whether the name has changed.
659 * src/widgets/modest-folder-view.c: (strings_are_equal),
660 (on_model_foreach_set_name), (on_get_mmc_account_name),
661 (text_cell_data): Compare the name here, and use the name from
662 the account rather than from the
663 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
664 if the name was changed after the account was added to the model.
665 That's a tinymail bug but not one that I want to fix now.
667 This finally fixes projects.maemo.org bug NB#59301.
669 2007-06-27 Armin Burgmeier <armin@openismus.com>
671 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
674 2007-06-27 Murray Cumming <murrayc@murrayc.com
676 * src/modest-tny-account.h:
677 * src/modest-tny-account.c:
678 Added modest_tny_account_get_mmc_account_name(), to set the memory
679 card name asynchronously for the given account and then notify.
680 (modest_tny_account_new_for_local_folders): Use this new function instead
681 of using hildon_file_system_info_async_new() directly.
683 * src/widgets/modest-folder-view.c: (text_cell_data):
684 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
685 gtk_tree_model_row_changed() when it is available.
687 This should fix projects.maemo.org bug NB#59301.
689 2007-06-27 Murray Cumming <murrayc@murrayc.com
691 * src/modest-mail-operation.c: (update_account_thread),
692 (get_msgs_full_thread): Fix typo failures in the revert
695 2007-06-27 Murray Cumming <murrayc@murrayc.com
697 * src/maemo/modest-maemo-global-settings-dialog.c:
698 (idle_select_default_focus):
699 * src/modest-mail-operation.c: (idle_notify_progress),
700 (idle_notify_progress_once), (set_last_updated_idle),
701 (update_account_thread), (get_msgs_full_thread):
702 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
703 * src/widgets/modest-header-view.c:
704 (idle_notify_headers_count_changed_destroy),
705 (idle_notify_headers_count_changed):
706 Reverted the additions of gdk_threads_enter/leave(), in case this
707 helps with a startup hang on the device.
709 2007-06-26 Armin Burgmeier <armin@openismus.com>
711 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
712 for supported secure authentication methods from server by
713 gtk_dialog_run(), saving CPU time and a potential race condition.
715 2007-06-26 Armin Burgmeier <armin@openismus.com>
717 * src/maemo/modest-maemo-utils.h:
718 * src/maemo/modest-maemo-utils.c: Added a
719 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
720 only error code to tell the calling code when the user canceled the
723 * src/maemo/modest-account-settings-dialog.h:
724 * src/maemo/modest-account-settings-dialog.c:
725 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
726 message if the retrieval of secure authentication methods was canceled
727 by the user. Perform the check before saving anything to configuration
728 to not end up with half-committed configuration changes, do not show
729 a "Saving to configuration failed" note when authentication methods
730 could not be retrieved.
732 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
735 2007-06-26 Murray Cumming <murrayc@murrayc.com>
737 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
738 Only return the first level of folders under accounts, because the
739 osso-global-search UI spec doesn't want the rest.
740 This fixed projects.maemo.org bug NB#61811.
742 2007-06-26 Murray Cumming <murrayc@murrayc.com>
744 * src/modest-tny-account-store.c:
745 * src/modest-tny-account-store.h:
746 Added modest_tny_account_is_memory_card_account().
747 * src/maemo/modest-main-window.c: (create_details_widget):
748 Show the same information items for the memory card as we show for the
749 local-folders, to fix projects.maemo.org bug NB#59307.
751 2007-06-26 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-tny-account-store.c: (get_password):
754 Added some checks for NULL to maybe prevent crashes, though I think
755 it was Philip's last commit that actually prevented the crash here
756 when creating a first new account.
757 But the new account is still not usable (no messages are shown)
758 until a restart of the application.
760 2007-06-26 Murray Cumming <murrayc@murrayc.com>
762 * src/maemo/modest-maemo-global-settings-dialog.c:
763 (idle_select_default_focus):
764 * src/modest-mail-operation.c: (idle_notify_progress),
765 (idle_notify_progress_once), (idle_notify_update_account_queue),
766 (set_last_updated_idle), (update_account_thread),
767 (notify_get_msgs_full), (get_msgs_full_destroyer),
768 (get_msgs_full_thread):
769 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
770 * src/widgets/modest-header-view.c:
771 (idle_notify_headers_count_changed_destroy),
772 (idle_notify_headers_count_changed):
773 Use gdk_threads_enter() and gdk_threads_enter_leave() in
774 all idle handlers, because some other thread could be blocking
775 the GDK lock, so that it can do GUI stuff.
777 2007-06-26 Murray Cumming <murrayc@murrayc.com>
779 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
780 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
781 (on_idle_send_receive), (on_idle_open_default_inbox):
782 * src/maemo/modest-msg-edit-window.c:
783 (modest_msg_edit_window_attach_file_noninteractive):
784 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
785 to prevent a hang. I don't quite understand why these are necessary,
786 beause we should already be in the main loop. I guess something outside
787 of the main loop is taking the lock.
789 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
790 we are really using URIs, and use files that are more likely to exist.
792 2007-06-26 Murray Cumming <murrayc@murrayc.com>
794 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
795 necessary because configure.ac now defines different variables.
797 2007-06-26 Murray Cumming <murrayc@murrayc.com>
799 * libmodest-dbus-client/libmodest-dbus-client.c:
800 * libmodest-dbus-client/libmodest-dbus-client.h:
801 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
802 libmodest_dbus_client_compose_mail() is what things actually use.
804 * src/dbus_api/modest-dbus-api.h:
805 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
806 * tests/dbus_api/Makefile.am:
807 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
810 2007-06-26 Murray Cumming <murrayc@murrayc.com>
812 * src/modest-init.c: (modest_init_local_folders):
813 For memory-card (or other non local-folders) maildir accounts,
814 always create an Archive folder, so that there is somewhere to put
815 messages. This should be less confusing, because the user does not need
816 to guess that the need to create a folder.
818 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
820 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
821 Fixed icon size by using (50, 50) which is the same as defined by
824 2007-06-25 Armin Burgmeier <armin@openismus.com>
826 * src/widgets/modest-window-mgr.c:
828 * configure.ac: Correctly recognize hildon-notify presence and fixed
829 the build without it being installed.
831 2007-06-25 Murray Cumming <murrayc@murrayc.com>
833 * libmodest-dbus-client/libmodest-dbus-client.c:
834 (libmodest_dbus_client_search): Fix the build. Sorry.
835 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
836 (reply_forward_cb): Initialize variables to fix the build.
838 * src/modest-tny-account-store.c:
839 (modest_tny_account_store_get_tny_account_by): Fix the account URI
840 comparison (a silly typo) so that email search results can be opened
841 when there are more than one account.
843 2007-06-25 Murray Cumming <murrayc@murrayc.com>
845 * libmodest-dbus-client/libmodest-dbus-client.c:
846 (libmodest_dbus_client_search),
847 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
848 instead of 1 second, because the search gets folders and messages from
849 the server, which can take a long time. When it times out,
850 osso-global-search will report no results.
852 We need to specify whether we should search only cached information
853 (maybe with a user preference), and the osso-email-search-plugin
854 API should really be improved to allow that option, and to allow results
855 to be delivered asynchronously in batches.
857 2007-06-25 Murray Cumming <murrayc@murrayc.com>
859 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
860 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
861 GTK_ICON_SIZE_DIALOG is probably the wrong size.
863 2007-06-25 Murray Cumming <murrayc@murrayc.com>
865 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
866 that is an empty string. D-Bus seems to give us these instead of NULL.
868 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
870 * src/dbus_api/modest-dbus-callbacks.c:
871 * src/maemo/easysetup/modest-easysetup-wizard.h:
872 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
873 * src/maemo/modest-connection-specific-smtp-edit-window.c:
874 (modest_connection_specific_smtp_edit_window_init):
875 * src/maemo/modest-maemo-global-settings-dialog.c:
877 * src/maemo/modest-maemo-utils.c:
878 (modest_maemo_utils_setup_images_filechooser):
879 * src/maemo/modest-main-window.c: (create_details_widget):
880 * src/maemo/modest-msg-edit-window.c:
881 (modest_msg_edit_window_attach_file_noninteractive),
882 (modest_msg_edit_window_color_button_change),
883 (modest_msg_edit_window_set_zoom):
884 * src/modest-mail-operation.c: (update_account_thread):
885 * src/modest-tny-account-store.c:
886 * src/modest-tny-account.c:
887 * src/widgets/modest-global-settings-dialog.c:
888 * src/widgets/modest-window.h:
892 2007-06-25 Murray Cumming <murrayc@murrayc.com>
894 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
895 * src/modest-search.c: (modest_search_folder),
896 (modest_search_all_accounts): Actually search only in the specified folder,
897 doing a simple match on the folder ID.
898 * src/modest-search.h: Added a folder field to the ModestSearch struct,
899 and added some documentation.
901 2007-06-22 Armin Burgmeier <armin@openismus.com>
903 * src/maemo/modest-maemo-utils.h:
904 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
905 modest_maemo_utils_get_supported_secure_authentication_methods.
907 * src/maemo/easysetup/modest-easysetup-wizard.c:
908 * src/maemo/modest-account-settings-dialog.c: Show correct error if
909 one occured, not just "Server does not support secure authentication".
911 2007-06-22 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-tny-account-store.c: (get_password):
914 Restored the call to tny_account_set_user() because Philip seems to have
915 stopped this from crashing (by not using the freed string). It still does
916 not work, but now we can test it.
918 2007-06-22 Murray Cumming <murrayc@murrayc.com>
920 * src/maemo/modest-msg-edit-window.c: (init_window):
921 Comment out use of an uninitialzed GtkScrolledWindow variable,
922 to fix the build and stop a crash. Yet again.
924 2007-06-22 Murray Cumming <murrayc@murrayc.com>
926 * src/modest-tny-account-store.c: (get_password):
927 Remove the call to tny_account_set_user() because this actually crashes.
928 As mentioned in the last commit, it is known to not work anyway.
930 2007-06-22 Murray Cumming <murrayc@murrayc.com>
932 * src/modest-tny-account-store.c: (get_password):
933 Use tny_account_set_username() to tell tinymail that the username might
934 have changed too. But tinymail ignores this: see projects.maemo.org
936 * src/modest-ui-actions.c:
937 (modest_ui_actions_on_password_requested): Remove the useless attempt to
938 reset the connection when changing the username, and improve the comments.
939 Save the changed username to gconf at least, so it is used when Modest is
942 2007-06-21 Murray Cumming <murrayc@murrayc.com>
944 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
945 Do not use a query, so that we get all folders, including for POP and
946 local-folders. They work as search criteria too.
947 This fixes projects.maemo.org bug NB#57740.
949 2007-06-21 Murray Cumming <murrayc@murrayc.com>
951 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
952 Comment out the use of hildon_notification_set_sound() because it is
953 not declared, to fix the build. Warnings are serious, people.
955 2007-06-21 Armin Burgmeier <armin@openismus.com>
957 * src/maemo/modest-maemo-utils.h:
958 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
959 modest_maemo_utils_get_supported_secure_authentication_methods()
960 to query authentication methods for a specific user. This should fix
961 projects.maemo.org bug NB#61369.
963 * src/maemo/easysetup/modest-easysetup-wizard.c:
964 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
967 2007-06-21 Murray Cumming <murrayc@murrayc.com>
969 * libmodest-dbus-client/libmodest-dbus-client.h:
970 * libmodest-dbus-client/libmodest-dbus-client.c:
971 (modest_dbus_message_iter_get_search_hit),
972 (libmodest_dbus_client_search):
973 Reorganised and commented this.
974 Removed modest_search_hit_free() from the public API because it
977 Added libmodest_dbus_client_get_folders() and
978 modest_folder_result_list_free().
980 * src/dbus_api/modest-dbus-api.h:
981 * src/dbus_api/modest-dbus-callbacks.c:
982 (modest_dbus_req_filter): Commented. Moved most code to
983 on_dbus_method_search() and added on_dbus_method_get_folders().
985 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
986 of the extra D-Bus handler.
988 * tests/dbus_api/Makefile.am:
989 * tests/dbus_api/test_get_folders.c: New test for
990 libmodest_dbus_client_get_folders(). This seems to return an empty list
991 at the moment. That could be the same error that causes the message list
992 to be empty sometimes.
993 This should help with projects.maemo.org bug NB#57740.
995 2007-06-21 Armin Burgmeier <armin@openismus.com>
997 * src/modest-mail-operation.c: Do not call
998 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
999 notify the operation's end after having set the status to CANCELED for
1000 the operation queue to listen on. This fixes a deadlock when there
1001 were mail operations in the queue during its finalization.
1003 * src/modest-singletons.c: Reordered uninitialization of the account
1004 manager to happen after the mail operation queue was uninitialized
1005 because the mail operation's in the queue might still try to access
1006 the account manager (see modest_mail_operation_notify_end()). This
1007 fixes a potential crash when terminating the application.
1009 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1011 * src/modest-search.c:
1012 (search_mime_part_and_child_parts): Moved some code here so we
1013 can search recursively in child folders.
1014 (modest_search_folder): Search in the message as a mime part, instead
1015 of just its child mime parts.
1016 (read_chunk), (search_mime_part_ogs):
1017 Check how many bytes were read, to prevent an endless loop.
1018 Searching in message bodies now works. This finishes the fix for
1019 projects.maemo.org bug NB#61007.
1021 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1023 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1024 Add a g_warning when the item is not a folder.
1026 * src/modest-ui-dimming-rules.c:
1027 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1028 when selected item is not a folder (for instance, an account), because
1029 the UI spec only talks about folders.
1030 I am not sure what the UI spec wants, so this might not totally fix
1031 projects.maemo.org bug NB#60794.
1033 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1035 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1036 (load_from_file): Sort the list. The unsorted list would be more noticeable
1037 in non-English locales.
1039 * src/maemo/modest-msg-edit-window.c:
1040 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1041 warning and fix the build.
1043 * src/maemo/modest-progress-bar-widget.c:
1044 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1045 avoid a g_warning, and probably to avoid a crash.
1047 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1049 * src/modest-search.c: (modest_search_folder): Check for a GError
1050 when calling tny_folder_get_headers(), to show that this is not the cause
1053 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1055 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1056 Actually set the body query instead of the subject query.
1058 * src/modest-search.c: (search_mime_part_ogs),
1059 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1060 which would probably cause it to fail if we got this far.
1062 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1063 to simplify the code.
1064 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1065 be causing search-in-body to fail.
1067 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1069 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1071 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1072 Better debug message when the folder cannot be found.
1073 This should help with fixing projects.maemo.org bug #61287.
1074 * src/modest-search.c: (add_hit): Do not leak the furl string.
1076 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1078 * src/modest-ui-actions.c:
1079 (modest_ui_actions_on_folder_selection_changed):
1080 Do not special-case TNY_MERGE_FOLDER here, because
1081 modest_tny_folder_get_account() already does that. This fixes
1082 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1083 shown when the Outbox was selected).
1085 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1087 * libmodest-dbus-client/libmodest-dbus-client.c:
1088 (_dbus_iter_get_string_or_null): Initialize the string variable in
1089 case this helps with Dirk's crash.
1091 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1093 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1094 though it is not implemented yet (this function is maybe not even used),
1095 to avoid breaking ABI in future.
1096 * libmodest-dbus-client/libmodest-dbus-client.c:
1097 (get_attachments_string): Moved some code into this generic function.
1098 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1099 sends email. It is maybe not used.
1100 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1101 (on_send_mail): Use attachments.
1103 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1104 * src/maemo/modest-msg-edit-window.c:
1105 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1106 a filename before using it, to fix projects.maemo.org bug NB#58233.
1108 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1110 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1111 Initialize the continue_download variable to fix the build, and probably
1112 to fix randome behaviour.
1114 2007-06-18 Armin Burgmeier <armin@openismus.com>
1116 * src/modest-tny-send-queue.h:
1117 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1118 the queue so we can later show it in the UI. Replaced
1119 modest_tny_send_queue_msg_is_being_sent() by
1120 modest_tny_send_queue_get_msg_status().
1122 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1124 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1125 gpointer. This probably was not harmful, but just to be sure.
1127 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1129 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1130 Fix the build, but leave the function broken on Bora, because
1131 hildon_uri_action_get_service() does not exist.
1132 osso_uri_action_get_service() does not exist either, it seems.
1134 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1136 * src/modest-tny-account.c:
1137 (modest_tny_account_new_from_server_account):
1138 Uncommented the url debug output again, because it is useful for
1139 debugging, as I said in the comment.
1141 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1143 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1145 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1146 for Mameo Bora, to fix the build.
1148 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1151 Fixed build with hildon < 0.99
1153 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1154 Check if the selected account is busy instead of checking all accounts
1156 * src/modest-account-mgr-priv.h:
1157 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1158 (modest_account_mgr_init), (compare_account_name),
1159 (modest_account_mgr_set_account_busy),
1160 (modest_account_mgr_account_is_busy):
1161 * src/modest-account-mgr.h:
1162 Added busy information to the account manager. It possible to
1163 set an account to busy or not busy now.
1165 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1166 (modest_mail_operation_update_account),
1167 (modest_mail_operation_notify_end):
1168 Set the account to busy/not busy depending on the operation state.
1170 * src/widgets/modest-account-view.c:
1171 (modest_account_view_finalize), (get_last_updated_string),
1172 (update_account_view), (on_account_busy_changed), (init_view):
1173 Show string "Refreshing..." if the account is currently busy.
1175 All this fixes projects.maemo.org bug NB#59711
1177 2007-06-14 Armin Burgmeier <armin@openismus.com>
1179 * src/widgets/modest-attachments-view.h:
1180 * src/widgets/modest-attachments-view.c: Added
1181 modest_attachments_view_has_attachments() and fixed coordinate
1182 transformation in get_att_view_at_coords(). This fixes attachment
1185 * src/widgets/modest-msg-view.c: Make use of
1186 modest_attachments_view_has_attachments() to decide whether to show
1187 attachments in the header.
1189 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1191 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1192 (on_change), (on_combo_security_changed),
1193 (modest_connection_specific_smtp_edit_window_init),
1194 (modest_connection_specific_smtp_edit_window_set_connection),
1195 (modest_connection_specific_smtp_edit_window_is_dirty):
1196 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1197 * src/maemo/modest-connection-specific-smtp-window.c:
1200 Show an comfirmation dialog for the smpt-edit-window if there are
1201 unsaved changes and the user hits cancel.
1202 (projects.maemo.org bug NB#60479)
1204 2007-06-14 Armin Burgmeier <armin@openismus.com>
1206 * src/maemo/easysetup/modest-easysetup-wizard.c:
1207 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1208 address" info in banner instead of node, and select all the text as
1209 per UI spec. This fixes projects.maemo.org bug NB#60550.
1211 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1213 reviewed by: <delete if not using a buddy>
1215 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1216 * src/modest-ui-actions.c: (folder_refreshed_cb):
1218 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1220 * src/widgets/modest-folder-view.c: (filter_row):
1221 Explictly filter out the per-account outbox accounts. I don't know why
1222 these only sometimes show up, but now they should never show up in the UI.
1223 This should fix projects.maemo.org bug NB#60160.
1225 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1227 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1228 when the toolbar does not exist yet.
1229 * src/modest-widget-memory.c: (save_settings_header_view):
1230 Added g_warnings() to help us to discover when we are trying to set
1231 an empty columns list in gconf.
1233 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-init.h:
1236 * src/modest-init.c:
1237 Added modest_init_get_default_header_view_column_ids().
1239 * src/modest-widget-memory.c: (restore_settings_header_view):
1240 Use the new function to get defaults, if the gconf key is empty,
1241 instead of not creating any columns. This seems to fix the
1242 empty right-hand pane problems.
1244 * src/widgets/modest-header-view.h: Improved documentation.
1246 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1248 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1249 Revert the use of the display name as the account name, because this
1250 is generally wrong and would break the code that follows.
1252 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1254 * src/maemo/easysetup/modest-easysetup-wizard.c:
1255 (check_for_supported_auth_methods), (on_before_next),
1258 More correct fix for projects.maemo.org bug NB# 58991
1259 Do not longer accept AUTH_PASSWORD as secure method and choose
1260 correct method when creating the account.
1262 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1264 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1265 Fixed projects.maemo.org bug NB# 58991
1267 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1269 * src/modest-init.c: (modest_init_init_core),
1270 (modest_init_local_folders): Fixed compilation errors.
1272 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1274 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1275 Remove unnecessary lib/include, though it is good in principle when needed.
1277 * src/modest-init.c: (modest_init_one_local_folder),
1278 (modest_init_local_folders):
1279 * src/modest-init.h: Initialize the .modest library for memory cards,
1280 instead of just doing nothing for them. This should allow us to create
1281 folders there, fixing projects.maemo.org bug NB#59297.
1283 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1285 * libmodest-dbus-client/libmodest-dbus-client.c:
1286 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1287 (libmodest_dbus_client_compose_mail),
1288 (libmodest_dbus_client_open_message),
1289 (libmodest_dbus_client_send_and_receive),
1290 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1292 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1293 (on_idle_open_message), (modest_dbus_req_handler),
1294 (search_result_to_message), (modest_dbus_req_filter):
1295 * src/modest-search.c: (add_hit), (modest_search_folder),
1296 (modest_search_all_accounts): Improved debug messages.
1298 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1300 * src/modest-tny-account-store.c:
1301 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1304 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1307 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1309 * src/modest-tny-account-store.c: (get_server_accounts):
1310 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1311 even when there are no accounts, so that the Outbox folder is always
1312 visible. This fixes projects.maemo.org bug NB#60158.
1314 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1316 * src/maemo/modest-main-window.c: (create_details_widget):
1317 Use the mcen_va_never logical ID.
1319 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1321 * src/dbus_api/modest-dbus-api.h:
1322 * src/dbus_api/modest-dbus-callbacks.c:
1323 (on_idle_open_default_inbox), (on_open_default_inbox),
1324 (modest_dbus_req_handler):
1325 Added a new OpenDefaultInbox method.
1327 * libmodest-dbus-client/libmodest-dbus-client.h:
1328 * libmodest-dbus-client/libmodest-dbus-client.c:
1329 Added libmodest_dbus_client_open_default_inbox() to call the new
1330 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1331 though it should maybe be used by a new osso-email-interface function.
1333 * tests/dbus_api/Makefile.am:
1334 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1337 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1339 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1340 NULL, so that the signals get all the keys. This should not actually
1341 change any behaviour because we currently update everything when anything
1344 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1346 * src/widgets/modest-folder-view.c: (text_cell_data),
1347 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1348 (find_inbox_iter): If tinymail tells us that the folder is
1349 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1350 This causes the inbox to be selected at startup, fixing part of
1351 projects.maemo.org bug NB#56305.
1353 * src/modest-ui-dimming-rules.c:
1354 (modest_ui_dimming_rules_on_tools_smtp_servers):
1355 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1356 the SMTP servers menu item.
1357 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1358 that the SMTP Servers menu item is dimmed when there are no accounts,
1359 as a future version of the UI spec will require. This fixes
1360 projects.maemo.org bug NB#56305.
1362 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1364 * src/maemo/modest-maemo-utils.c:
1365 (modest_maemo_utils_get_supported_secure_authentication_methods):
1366 Added label to dialog instead of unreadable title
1368 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1369 (modest_main_window_new):
1370 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1373 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1374 * src/modest-account-mgr.h:
1375 Added method to avoid code duplication
1377 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1378 (modest_ui_actions_on_send_receive):
1379 Use modest_account_mgr_has_accounts
1381 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1383 * src/maemo/easysetup/modest-presets.c:
1384 (modest_presets_get_info_server_security): Do not report secure auth
1386 * src/modest-protocol-info.c: Use the defines for the gconf key names
1387 for secure authentication. This was not working because we were writing
1388 Password and reading password, and the check was case sensitive.
1389 With this, gmail now works for receiving and sending when created via
1392 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1394 * src/maemo/easysetup/modest-presets.c:
1395 (modest_presets_get_info_server_security): Correct the key name for
1396 SecureSmtp, because it seems to be case-sensitive.
1397 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1398 Do not try to get the 0th notebook page if there are 0 pages, to
1399 avoid a g_warning().
1401 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1404 Prevent use of the new notification feature for now, because it currently
1405 shows one dialog for each new email, which is annoying.
1407 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1409 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1410 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1411 when no country was selected, so that we show the global ones.
1412 * src/maemo/easysetup/modest-presets.c:
1413 (modest_presets_get_providers): Return only the global providers, not
1414 all providers when mmc=0 was requested.
1416 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1418 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1419 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1420 provider ID in the combo.
1422 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1423 Do not show the page numbers, because it would be confusing when we add
1424 the 2 extra pages for the custom setup, when the user chooses the "Other"
1425 provider. This fixes projects.maemo.org bug NB#59028
1427 * src/modest-init.c: (modest_init_init_core),
1428 (modest_init_local_folders):
1429 * src/modest-init.h:
1430 * src/modest-tny-account.c:
1431 (modest_tny_account_new_for_local_folders): Do not create default folders
1432 for the memory card. This should fix projects.maemo.org bug NB#59328.
1434 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1436 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1437 Free the changed_conf_keys string items. They are already freed in the
1438 idle handler if that runs first.
1440 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1442 * src/modest-ui-actions.c:
1443 (modest_ui_actions_on_password_requested): Check that the server name
1444 is not NULL, because I just saw a password dialog with (null) as the
1447 * src/modest-tny-folder.[h|c]: Added
1448 modest_tny_folder_is_memory_card_folder().
1449 * src/modest-ui-dimming-rules.c:
1450 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1451 menu item for memory cards, as per the UI spec (section 7.4). This should
1452 fix projects.maemo.org bug NB#59297.
1454 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1456 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1457 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1458 is another problem with the code, see Murray's comment at line 772)
1460 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1462 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1463 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1464 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1465 (load_from_file), (easysetup_country_combo_box_init),
1466 (easysetup_country_combo_box_get_active_country_ids),
1467 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1468 instead of just one ID, to avoid duplicate country names in the UI.
1470 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1471 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1472 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1473 a single ID, avoiding duplicate providers.
1474 * src/maemo/easysetup/modest-easysetup-wizard.c:
1475 (on_combo_account_country): Adapt to use a list.
1477 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1479 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1480 keys changed in the last X seconds.
1482 * src/modest-account-mgr.h:
1483 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1484 (on_key_change), (modest_account_mgr_class_init),
1485 (modest_account_mgr_init), (modest_account_mgr_finalize):
1486 As the keys are changed, save them in a GSList* and signal that GSList*
1487 further every X seconds, to batch changes, to allow us to do just one
1488 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1489 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1491 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1492 changed signal signature.
1494 * src/modest-conf.c: (modest_conf_set_list),
1495 (modest_conf_on_change): Reenable notification.
1497 (modest_conf_maemo_fake_on_change): Comment out the hack that
1498 notified immediately instead of asynchronously.
1500 * src/widgets/modest-account-view.h:
1501 * src/widgets/modest-account-view.c:
1502 (update_account_view): Select the previously-selected account ID,
1503 if possible. This fixes projects.maemo.org bug NB#56933.
1505 (on_account_changed), (on_account_removed),
1506 (modest_account_view_select_account):
1508 Remove the block/unblock functions
1509 because they were not useful.
1511 * src/maemo/modest-account-view-window.c:
1512 (on_delete_button_clicked), (on_edit_button_clicked),
1513 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1515 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1517 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1518 Improve the error dialog to show Incorrect Account Settings, which seems
1519 clearer, and say that the internal error message (to be removed from the
1520 dialog later) is often misleading.
1521 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1523 * src/modest-tny-account.c:
1524 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1525 URL because this is so useful for debugging on the device.
1527 * src/widgets/modest-serversecurity-combo-box.c:
1528 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1530 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1532 * src/modest-mail-operation.c:
1533 (modest_mail_operation_send_new_mail):
1534 Added a comment about a nasty but apparently harmless message. Details
1535 added to the wiki g_warnings() page.
1537 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1539 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1540 (modest_tny_send_queue_class_init):
1541 Do not use the priv struct because it is empty, to avoid g_warnings
1542 about a non-existant priv struct.
1544 * src/modest-tny-account-store.c:
1545 (modest_tny_account_store_get_server_account),
1546 (modest_tny_account_store_get_transport_account_for_open_connection
1547 ): Do not try to get transport server accounts for local folders,
1548 because they don't have any. This avoids a g_warning().
1550 * src/maemo/modest-main-window.c:
1551 (modest_main_window_notify_send_receive_initied),
1552 (on_configuration_key_changed):
1553 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1554 * src/modest-defs.h:
1555 * src/modest-mail-operation.c:
1556 (modest_mail_operation_update_account):
1557 * src/modest-tny-account-store.h:
1558 * src/modest-tny-account.c:
1559 (modest_tny_account_get_special_folder),
1560 (modest_tny_account_new_for_local_folders),
1561 (modest_tny_account_new_for_per_account_local_outbox_folder):
1562 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1563 * src/modest-tny-local-folders-account.c:
1564 (add_account_folders_to_merged_folder):
1565 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1566 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1567 (modest_ui_actions_on_send):
1568 * src/widgets/modest-folder-view.c: (update_model):
1569 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1570 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1571 modest_tny_account_store_get_tny_account_by_account() to
1572 modest_tny_account_store_get_server_account() to make the code clearer.
1574 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1576 * src/dbus_api/modest-dbus-api.h:
1577 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1578 * src/maemo/modest-msg-edit-window.c:
1579 (modest_msg_edit_window_attach_file_noninteractive):
1580 added g_warning in case the file to be attached does not exist
1581 * tests/dbus_api/test_compose_mail.c: (main):
1582 removed obsolete comment, added generic files as test case
1584 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-tny-account-store.c: (get_server_accounts):
1587 Create the local folders account only once, not once for each outbox, and
1588 not only when there are some outboxes.
1590 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1592 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1593 code that is causing a crash at startup. Sergio says that he is fixing this.
1595 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1597 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1598 * src/maemo/modest-account-settings-dialog.c:
1599 (create_page_outgoing),
1600 (modest_account_settings_dialog_set_account_name),
1601 (save_configuration):
1602 - Fixed handling of the "Use secure authentication" toggle to comply with
1603 the ui specification. See also projects.maemo.org bug NB#58400
1605 - Restore the Secure connection setting combo correctly when loading
1608 * src/maemo/modest-maemo-utils.c:
1609 (on_camel_account_get_supported_secure_authentication),
1610 (modest_maemo_utils_get_supported_secure_authentication_methods):
1611 Fixed a crasher if operation is canceled
1613 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1614 (modest_protocol_info_auth_is_secure):
1615 * src/modest-protocol-info.h:
1617 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1618 the sense of the "Use secure authentication" toggle.
1620 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-tny-account-store.h:
1623 * src/modest-tny-account-store.c:
1624 Added modest_tny_account_store_get_local_folders_account().
1626 * src/modest-tny-folder.h:
1627 * src/modest-tny-folder.c:
1628 (modest_tny_folder_get_account):
1629 Added this replacement for tny_folder_get_account() which returns
1630 the local-folders account for TnyMergeFolders, to avoid the
1631 warning about the unimplemented get_account_func() vfunc().
1633 (modest_tny_folder_get_rules),
1634 * src/modest-ui-actions.c:
1635 (modest_ui_actions_on_folder_selection_changed):
1636 * src/modest-mail-operation.c:
1637 (modest_mail_operation_remove_folder),
1638 (modest_mail_operation_xfer_folder),
1639 (modest_mail_operation_rename_folder),
1640 (modest_mail_operation_get_msg),
1641 (modest_mail_operation_get_msgs_full),
1642 (modest_mail_operation_remove_msg),
1643 (modest_mail_operation_xfer_msgs),
1644 (modest_mail_operation_refresh_folder):
1645 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1647 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1649 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1650 (modest_server_account_set_security):
1651 * src/modest-defs.h: Add comments explaining that our
1652 UI spec means TLS when it says Normal, so these do not look like errors.
1654 * src/modest-tny-account.c:
1655 (modest_tny_account_new_from_server_account): Use the new tinymail
1656 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1657 for TLS. This should fix projects.maemo.org bug NB#58460.
1659 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1661 * src/maemo/easysetup/modest-easysetup-wizard.c:
1662 (create_account): Correct the position of the gconf sanity check warning.
1663 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1664 of using the g_idle_add() hack, because this does not seem to be necessary
1665 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1666 caused by something other than maemo's gconf.
1667 This fixes projects.maemo.org bug #59022.
1669 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1671 * src/modest-account-mgr-helpers.c:
1672 (modest_account_mgr_get_default_account): Do not check that the account
1673 exists if there is no default account (NULL), to fix a runtime warning.
1675 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1677 * src/widgets/modest-folder-view.c: (update_model):
1678 Do not unref the treemodel before we have finished with it.
1679 This prevents a valgrind warning and an occasional crash at startup.
1681 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1683 * libmodest-dbus-client/libmodest-dbus-client.h:
1684 added libmodest_dbus_client_compose_mail()
1685 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1687 added functions needed for SendAsMail() functionality
1688 * src/maemo/modest-msg-edit-window.c:
1689 (modest_msg_edit_window_attach_file_noninteractive):
1690 non interactively attaching files to message edit window
1691 * src/widgets/modest-msg-edit-window.h:
1692 * tests/dbus_api/Makefile.am:
1693 added test_compose_mail.c
1694 * tests/dbus_api/test_compose_mail.c: (main):
1696 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1698 * src/modest-account-view.c:
1699 Fixed bug projects.maemo.org bug NB#59307
1701 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1703 * src/maemo/easysetup/modest-easysetup-wizard.c:
1704 (get_serverport_incoming), (on_before_next), (create_account):
1705 * src/maemo/modest-account-settings-dialog.c:
1706 (modest_account_settings_dialog_set_account_name):
1707 * src/maemo/modest-maemo-utils.c:
1708 (on_camel_account_get_supported_secure_authentication_status),
1709 (on_camel_account_get_supported_secure_authentication),
1710 (on_secure_auth_cancel),
1711 (modest_maemo_utils_get_supported_secure_authentication_methods):
1713 Implemented security authentication for settings and easysetup.
1715 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1717 * src/maemo/modest-main-window.c: (create_details_widget):
1718 Show the total size for memory card accounts too, instead of showing
1719 the name again. Fixes bug projects.maemo.org bug NB#59307.
1721 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1724 * src/modest-tny-simple-folder-store.c:
1725 * src/modest-tny-simple-folder-store.h: Removed.
1727 * src/modest-tny-local-folders-account.h
1728 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1729 for the local-folders maildir, with an extra TnyMergedFolder containing
1730 the folders of the per-account outbox store accounts.
1731 * src/modest-tny-account-store.c: (get_server_accounts):
1732 Add the outboxes to the special local folders account after creating it.
1734 * src/modest-tny-account.c:
1735 (modest_tny_account_new_for_local_folders): Create the derived
1736 account when creating the main local-folders account.
1738 * src/maemo/modest-main-window.c: (create_details_widget),
1739 (modest_main_window_set_contents_style):
1740 Adapted to the use of the derived account instead of the folder store.
1742 * src/modest-ui-actions.c:
1743 (modest_ui_actions_on_folder_selection_changed):
1744 * src/modest-ui-dimming-rules.c:
1745 (modest_ui_dimming_rules_on_new_folder):
1746 * src/widgets/modest-folder-view.c: (text_cell_data),
1747 (icon_cell_data), (filter_row), (update_model),
1748 (get_cmp_rows_type_pos):
1751 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1752 Do not get the priv struct, because no priv struct has been set,
1753 to avoid a runtime warning.
1755 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1756 #ifelse with #else, to fix a warning, to fix the build.
1759 2007-06-05 Christian Kellner <ckellner@openismus.com>
1761 * libmodest-dbus-client/libmodest-dbus-client.c:
1762 Fix small typo in doc (why do you always see them
1763 AFTER committing stuff?)
1766 2007-06-05 Christian Kellner <ckellner@openismus.com>
1768 * libmodest-dbus-client/libmodest-dbus-client.c:
1769 (libmodest_dbus_client_search):
1770 Initialize hit list with NULL. Also set folder list
1771 to "" if NULL was supplied.
1774 2007-06-03 Christian Kellner <ckellner@openismus.com>
1776 * libmodest-dbus-client/libmodest-dbus-client.c:
1777 (modest_search_hit_list_free):
1778 Make it save to call it with NULL.
1780 * src/dbus_api/modest-dbus-callbacks.c:
1781 * src/modest-search.c:
1782 Return full ModestSearchHits as the search result list not TnyHeader
1783 since can't be around withouth the correspoding TnyFolder.
1785 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1787 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1788 Added currently commented code to check for secure auth
1790 * src/maemo/modest-account-settings-dialog.c: (on_response),
1791 (save_configuration), (show_ok):
1792 Fixed projects.maemo.org bugs NB #59248 and #59251
1794 * src/maemo/modest-maemo-utils.c:
1795 (on_camel_account_get_supported_secure_authentication_status),
1796 (on_camel_account_get_supported_secure_authentication),
1797 (modest_maemo_utils_get_supported_secure_authentication_methods):
1798 * src/maemo/modest-maemo-utils.h:
1799 Moved get_supported_secure_authentication() method here to be able
1800 to use it from easysetup wizard.
1802 * src/modest-pair.c: (on_pair_compare_as_string):
1803 Should compare string with first part of pair and not
1804 strcmp pairs which will crash.
1806 * src/modest-protocol-info.c:
1807 (modest_protocol_info_protocol_is_store):
1808 * src/modest-protocol-info.h:
1809 Added modest_protocol_info_get_auth_protocol_name()
1811 2007-06-03 Armin Burgmeier <armin@openismus.com>
1813 * src/modest-mail-operation.c:
1814 (modest_mail_operation_get_msgs_full): Set priv->account also when
1815 only retrieving a single message. This avoids a crash when canceling
1818 (modest_mail_operation_notify_end): Do not explicitely remove the
1819 operation from the queue but only emit the progress_changed signal.
1820 The queue itself listens to that signal to remove the operation when
1821 it is finished. This reduces coupling and removes a potential deadlock
1822 when modest_mail_operation_notify_end() is called from the queue
1823 itself. If that is a problem performance-wise, I would suggest to
1824 implement a status-changed signal or something.
1826 * src/modest-mail-operation-queue.c: Make sure to never call a
1827 function from another file while the queue is locked. This (hopefully)
1828 fixes another deadlock when exiting the application while retrieving
1831 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1833 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1834 Fixed build if libogs is not available
1836 2007-06-03 Christian Kellner <ckellner@openismus.com>
1838 * libmodest-dbus-client/libmodest-dbus-client.h:
1839 * libmodest-dbus-client/libmodest-dbus-client.c:
1840 (libmodest_dbus_client_delete_message):
1841 Implement deletion of messages (Client side).
1843 (modest_search_hit_free),
1844 (modest_search_hit_list_free):
1845 Utility functions to free the result hits.
1847 * src/dbus_api/modest-dbus-api.h:
1848 * src/dbus_api/modest-dbus-callbacks.c:
1849 (on_delete_message),
1850 (modest_dbus_req_handler):
1851 Implement deletion of messages (Server side).
1853 * tests/dbus_api/test_search.c: (main):
1856 * tests/dbus_api/Makefile.am:
1857 * tests/dbus_api/test_delete_message:
1858 Add little test for the message deletion logic
1860 2007-06-03 Armin Burgmeier <armin@openismus.com>
1862 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1863 when the operation queue was not empty. projects.maemo.org bug
1866 2007-06-03 Armin Burgmeier <armin@openismus.com>
1868 * src/widgets/modest-account-view.c
1869 (on_account_default_toggled): Toggle default account column
1870 explicitely instead of waiting for gconf notification (which is
1871 currently ignored). This should fix projects.maemo.org bug NB#56910
1872 for now. It should probably be removed when gconf notifications are
1875 2007-06-03 Christian Kellner <ckellner@openismus.com>
1877 * libmodest-dbus-client/libmodest-dbus-client.c:
1878 Removed debugging spew.
1880 * src/dbus_api/modest-dbus-callbacks.c:
1881 Added debugging info.
1883 * src/modest-search.c:
1884 (modest_search_all_accounts):
1885 Use tny_account_store_get_accounts () on the account store
1886 to get all accounts which is the way to get all accounts.
1888 * tests/dbus_api/test_search.c: (main):
1889 Make it possible to supply the search term on the command line.
1891 2007-06-03 Christian Kellner <ckellner@openismus.com>
1893 * libmodest-dbus-client/libmodest-dbus-client.c:
1894 * libmodest-dbus-client/libmodest-dbus-client.h:
1895 Implement searching for mesages over raw dbus. (Client side)
1897 * src/dbus_api/Makefile.am:
1898 * src/dbus_api/modest-dbus-api.h:
1899 * src/dbus_api/modest-dbus-callbacks.c:
1900 * src/dbus_api/modest-dbus-callbacks.h:
1901 Search framework (Server side). Also implement on_idle_open_message().
1903 * src/maemo/modest-platform.c: (modest_platform_init):
1904 Prepare for raw dbus/osso rpc interaction.
1906 * src/modest-search.h:
1907 Changed minsize from unspecific guint to guint32.
1909 * src/modest-search.c:
1911 Added strange hack which magically made tnymail work.
1913 (modest_search_folder),
1914 (modest_search_account),
1915 (modest_search_all_accounts):
1916 Implement helper functions to search all accounts, specific account
1919 * tests/dbus_api/Makefile.am:
1920 * tests/dbus_api/test_open_message.c:
1921 Read url to open from commandline.
1923 * tests/dbus_api/test_search.c:
1924 Implement small test for dbus search stuff
1926 2007-06-02 Armin Burgmeier <armin@openismus.com>
1928 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1929 include account type and account title. This fixes projects.maemo.org
1932 * src/maemo/modest-account-view-window.c: Set a title for the window.
1934 2007-06-02 Armin Burgmeier <armin@openismus.com>
1936 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1937 incoming and outgoing server name based on email address and server
1938 types as long as the names have not been edited manually. This fixes
1939 projects.maemo.org bug NB#58671.
1941 2007-06-02 Armin Burgmeier <armin@openismus.com>
1943 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1944 server type cannot be changed in future to the incoming details page
1945 when creating an account. This fixes projects.maemo.org bug NB#59029.
1947 2007-06-02 Armin Burgmeier <armin@openismus.com>
1949 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1950 and assigned max width chars so that they wrap instead of being
1951 truncated. Fixes projects.maemo.org bug NB#56126.
1953 2007-06-02 Armin Burgmeier <armin@openismus.com>
1955 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1956 introductory note to the connection specific smtp servers dialog, as
1957 section 8.12 of the email UI specification requires. This fixes
1958 projects.maemo.org bug NB#59212.
1960 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1962 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1963 Check for running mail operations, and offer to cancel them, as per the UI
1964 spec. This fixes projects.maemo.org bug NB#59041 .
1965 However, I suspect that tinymail may still use the network connection
1966 in ways that we cannot detect or cancel. But it should at least adapt to
1967 changes fairly well.
1969 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1971 * src/modest-tny-account-store.c: (recreate_all_accounts),
1972 (get_cached_accounts), (get_server_accounts): Do more sensible
1973 ref-counting of the temporarily-cached outbox accounts list. This seems
1974 to fix a crash when entering the password when the password was wrong.
1976 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1978 * src/gnome/modest-main-window.c: (connect_signals):
1979 * src/modest-tny-account-store.c: (get_password),
1980 (modest_tny_account_store_alert): Added comments and clues and
1981 commented-out code about how we currently fail to deal with connection
1982 errors and wrong passwords, and how we should.
1984 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1986 * src/widgets/modest-retrieve-combo-box.c:
1987 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1988 This fixes projects.maemo.org bug NB#58472 .
1990 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1992 * src/maemo/easysetup/modest-easysetup-wizard.c:
1993 (create_page_complete_easysetup):
1994 (create_page_complete_custom): Correct the last commit,
1995 putting the correct sentences in the correct pages.
1997 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/easysetup/modest-easysetup-wizard.c:
2000 (create_page_complete_custom): Show the second sentence of text
2001 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2004 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2007 Set the leave-on-server conf key by default. This fixes
2008 projects.maemo.org bug NB#59258 .
2010 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2012 * src/maemo/modest-account-view-window.c:
2013 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2014 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2017 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/easysetup/modest-easysetup-wizard.c:
2020 (create_caption_new_with_asterisk):
2021 * src/maemo/modest-account-settings-dialog.c:
2022 (create_caption_new_with_asterisk):
2023 Uncomment the code to add the asterisk, because they are no longer in the
2024 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2025 (update_incoming_server_title): Add an asterisk here too.
2027 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2029 * src/maemo/modest-maemo-global-settings-dialog.c:
2030 (current_connection): Check that we are even connected before trying to
2031 get the current connection name, to prevent a warning.
2033 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2034 Change the comments because tny_maemo_conic_device_connect() is now meant to
2036 * src/modest-mail-operation.c:
2037 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2038 make sure we have a connection and fail if we can't connect.
2040 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2042 * src/maemo/modest-main-window.c:
2043 (on_account_store_connecting_finished): Do not try to get the
2044 connection ID if we are not really connected. I am surprised that
2045 this signal handler is called when we are not connected.
2047 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2049 * src/modest-error.h:
2050 * src/modest-ui-actions.c:
2051 (modest_ui_actions_get_msgs_full_error_handler):
2052 Renamed an enum, added comments, added an enum
2053 for retrieve-limit errors.
2055 * src/modest-mail-operation.c: (foreach_add_item),
2056 (internal_folder_observer_update), (update_account_thread),
2057 (modest_mail_operation_get_msgs_full):
2058 (modest_mail_operation_update_account),
2059 Added comments about how this works, and some code that should
2060 (but does not) check the retrieve-limit. See the TODO comment.
2062 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2064 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2065 Initialize help_id to fix the build. Warnings are good.
2067 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2069 * src/widgets/modest-hbox-cell-renderer.c:
2070 (modest_hbox_cell_renderer_append):
2071 * src/widgets/modest-vbox-cell-renderer.c:
2072 (modest_vbox_cell_renderer_append):
2073 Fix the last commit by doing an extra ref.
2075 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2077 * src/widgets/modest-hbox-cell-renderer.c:
2078 (modest_hbox_cell_renderer_append):
2079 * src/widgets/modest-vbox-cell-renderer.c:
2080 (modest_vbox_cell_renderer_append):
2081 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2082 to fix the build with Maemo Bora.
2083 However, there seems to be a remaining crash, probably due to reference
2086 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2088 * src/modest-tny-account.c:
2089 (modest_tny_account_new_for_local_folders):
2090 Use hildon_file_system_info_async_new() to get a better name for
2091 the memory card account, setting it as the account name.
2092 The timing seems to work, but this is probably
2093 not the best place to do this. See the TODO comment.
2094 * src/maemo/modest-main-window.c: (create_details_widget):
2095 * src/widgets/modest-folder-view.c: (text_cell_data):
2096 Use the tny account name instead of hardcoding a name.
2098 2007-05-30 Christian Kellner <ckellner@openismus.com>
2100 * src/modest-search.c: (modest_search):
2101 Correctly set part_search_func even if we have already parsed
2102 the query and thus a valid OgsTextSearcher object.
2104 2007-05-30 Christian Kellner <ckellner@openismus.com>
2107 Search and check for libogs.
2110 Incooparte the ogs build env.
2112 * src/modest-mime-part-search-stream.c:
2113 * src/modest-mime-part-search-stream.h:
2114 Removed since we do the real searching now in modest-search.c.
2116 * src/modest-search.c:
2117 * src/modest-search.h:
2118 Implement support for ogs. We use that if available and requested
2119 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2120 should now handle the corner case when the search term is spread
2121 across multiple reads.
2122 Also the logic in modest_search () was corrected to search all
2123 requested fields until one is found.
2125 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2127 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2129 * src/modest-init.h:
2130 * src/modest-init.c: Made modest_init_local_folders() take a
2131 path and be public so we can iniitialize maildir folders on
2134 * src/modest-local-folder-info.h:
2135 * src/modest-local-folder-info.c:
2136 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2138 * src/modest-tny-account.c:
2139 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2140 still means the standard local-folders path on the local volume.
2142 * src/modest-tny-account-store.c:
2143 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2144 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2145 all accounts when that happens.
2146 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2147 this too, so it shows up in the treeview.
2149 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2151 * src/maemo/modest-maemo-global-settings-dialog.c:
2152 (current_connection):
2153 * src/widgets/modest-global-settings-dialog.c:
2154 (current_connection_default):
2155 Use the enum values instead of 0, 1 and -1,
2156 to make the code clearer.
2158 * src/modest-account-mgr-helpers.c:
2159 (modest_account_mgr_get_connection_specific_smtp): Make this code
2162 * src/modest-runtime.h:
2163 * src/modest-runtime.c:
2164 Added modest_runtime_remove_all_send_queues().
2165 * src/maemo/modest-main-window.c:
2166 (on_account_store_connecting_finished): Recreate the send queues,
2167 using the appropriate transport accounts for this new connection.
2168 Some futher adapting might be needed if the old send queues are not
2169 automatically stopped at this point.
2171 * src/modest-tny-account-store.c: (get_server_accounts):
2172 Create the connection-specific transport accounts, so that they can
2173 be found later by their ID.
2175 * src/modest-tny-account.h:
2176 * src/modest-tny-account.c:
2177 Added modest_tny_account_new_from_server_account_name().
2178 modest_tny_account_new_from_server_account(): Do not create the
2179 send queues here, because they will be
2180 recreated anyway when the connection changes for the first time.
2182 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2184 * src/modest-local-folder-info.h:
2185 * src/modest-local-folder-info.c:
2186 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2187 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2188 tbox_folder): Take a modest account name instead of a server TnyAccount,
2189 so we can have per-modest-account rather than per-transport-account
2191 We must make sure that we change or recreate the exisitng send queues
2192 when the connection changes for connection-specific transport accounts.
2194 * src/modest-tny-account-store.c:
2195 (create_per_account_local_outbox_folders): Create outboxed per modest
2196 account, not per transport account.
2198 * src/modest-tny-account.h:
2199 * src/modest-tny-account.c:
2200 (modest_tny_account_get_special_folder): For outboxes, get the
2201 parent modest account name. The account is ignored for other folders.
2202 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2203 modest account name rather than a server TnyAccount.
2205 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2207 * src/modest-tny-account.c:
2208 (modest_tny_account_new_from_server_account):
2209 Call modest_runtime_get_send_queue() immediately after creating transport
2210 accounts, so that they start trying to send email from the outbox as soon
2211 as possible at startup. This is probably what we want.
2213 * src/modest-mail-operation.c: (update_account_thread):
2214 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2215 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2216 * src/modest-tny-send-queue.h:
2217 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2218 (modest_ui_actions_on_send):
2219 Added comments about how sending works, though it needs some more work.
2221 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2223 * src/modest-tny-account.c:
2224 (modest_tny_account_get_special_folder): Add TODO because this fails when
2225 the network is busy.
2226 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2227 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2228 Do not try to show this window when there is no active account. The UI
2229 specs does not tell us what to do in this case.
2231 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2235 * src/maemo/Makefile.am:
2236 * src/widgets/Makefile.am: Some dist fixes.
2238 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2240 * src/maemo/modest-connection-specific-smtp-window.c:
2241 (on_button_edit): Make the code clearer, to prevent a double free.
2243 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2245 * src/maemo/modest-account-settings-dialog.c:
2246 (modest_account_settings_dialog_set_account_name),
2247 Check the connection-specific smtp servers checkbox if there are any.
2249 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2250 (modest_connection_specific_smtp_edit_window_init):
2251 Start with a suitable port number.
2253 * src/modest-account-mgr-helpers.h:
2254 * src/modest-account-mgr-helpers.c: Added
2255 modest_account_mgr_get_has_connection_specific_smtp().
2257 (modest_account_mgr_set_connection_specific_smtp),
2258 (modest_account_mgr_remove_connection_specific_smtp),
2259 (modest_account_mgr_get_has_connection_specific_smtp),
2260 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2261 connection-specific smtp server accounts in the account, rather than
2262 the server account conf dir.
2264 This fixes bug projects.maemo.org bug NB#58263 .
2266 * src/modest-tny-account-store.c:
2267 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2268 if there are no server accounts yet, to prevent an infinite loop when there
2269 are no accounts. Document that one must be called before the other.
2271 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2273 * src/modest-account-mgr-helpers.c:
2274 (modest_account_mgr_get_default_account): Make sure that at least
2275 one account is always the default, if there are any enabled accounts.
2276 This is just a sanity check that shouldn't be necessary.
2278 * src/modest-account-mgr-priv.c:
2279 (_modest_account_mgr_account_from_key): Unescape the conf key to
2280 get the real account name. For instance, this is an issue if a space
2281 was in the account name, which can happen because the account name
2282 is generated from the display name.
2283 (_modest_account_mgr_get_account_keyname): Always escape the
2285 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2286 Unescape the conf keys to get the real account names.
2288 For instance, previously the is-default radio button in the accounts
2289 list was not checked for any accounts at first. This fixes that,
2290 and might fix several similar bugs.
2292 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2294 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2295 Removed some debug printfs.
2297 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2299 Modest on-disk outbox directories are now here, for instance:
2300 $HOME/.modest/outboxes/<account-id-1>/outbox
2301 $HOME/.modest/outboxes/<account-id-2>/outbox
2303 $HOME/.modest/local-folders/outbox
2304 so we can have a separate outbox for each account.
2305 But they are shown as one outbox in the GtkTreeView, by using a
2306 TnyMergeFolder in a ModestTnySimpleFolderStore.
2309 * src/modest-tny-simple-folder-store.c:
2310 * src/modest-tny-simple-folder-store.h:
2311 Added ModestTnySimpleFolderStore, used to contain folders from
2312 other folder stores, such as other accounts.
2314 * src/modest-tny-outbox-account.h:
2315 * src/modest-tny-outbox-account.c:
2316 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2317 used for the per-account local outbox folders.
2319 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2320 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2321 only use this (internally) now for the non-outbox local folders.
2323 * src/modest-init.h:
2324 * src/modest-init.c: Added modest_init_one_local_folder(), for
2325 setting up the directory structure for each local folder.
2327 * src/modest-local-folder-info.c:
2328 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2329 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2331 * src/modest-local-folder-info.h:
2332 * src/modest-tny-account-store.c: (on_account_removed),
2333 (on_account_changed), (create_per_account_local_outbox_folders),
2334 (get_server_accounts), (modest_tny_account_store_get_accounts),
2335 (modest_tny_account_store_get_tny_account_by_account),
2336 (modest_tny_folder_store_is_virtual_local_folders):
2338 * src/modest-tny-account.h:
2339 * src/modest-tny-account.c:
2340 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2341 to create an on-disk per-account local outbox folder for each
2343 (create_per_account_local_outbox_folders): Create a local outbox folder
2344 for each transport account.
2345 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2346 for all local folders.
2348 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2349 instead of using g_object_get/set() directly. It is clearer.
2351 (modest_tny_folder_store_get_message_count),
2352 (modest_tny_folder_store_get_local_size
2353 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2354 because we now use these with non-acount folder stores.
2356 (modest_tny_account_get_special_folder),
2357 (modest_tny_account_new_from_server_account),
2358 (modest_tny_account_new_from_account):
2359 (recurse_folders): Adjust to the new outbox system.
2361 * src/modest-tny-folder.h:
2362 * src/modest-tny-folder.c:
2363 (modest_tny_folder_is_local_folder),
2364 (modest_tny_folder_get_local_folder_type),
2365 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2367 * src/widgets/modest-main-window.h:
2368 * src/maemo/modest-main-window.c: (create_details_widget),
2369 (modest_main_window_set_contents_style): Show details for any folder store,
2372 (modest_tny_folder_get_rules):
2373 Remove the const. C does not support constness enough for this.
2375 * src/modest-ui-actions.c:
2376 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2377 make all outboxes appear as one, in the usual local-folders tree node.
2379 (set_active_account_from_tny_account),
2380 (modest_ui_actions_on_folder_selection_changed):
2381 * src/widgets/modest-folder-view.c: (text_cell_data),
2382 (icon_cell_data), (filter_row),
2383 (add_account_folders_to_merged_folder),
2384 (add_account_folders_to_simple_folder_store), (),
2385 (get_cmp_rows_type_pos), (cmp_rows),
2386 (modest_folder_view_set_account_id_of_visible_server_account):
2387 Adjust to the new outbox system, using generic folder stores and folders
2388 in the GtkTreeModel.
2390 2007-05-23 Christian Kellner <ckellner@openismus.com>
2392 * src/modest-mail-operation.c:
2393 (modest_mail_operation_update_account):
2394 Use info->max_size instead of unintialized local var [small
2395 build fix]. (Added TODO to review that change since I don't
2398 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2400 * libmodest-dbus-client/libmodest-dbus-client.c:
2401 (libmodest_dbus_client_compose_mail): function added
2402 * src/dbus_api/modest-dbus-api.h:
2403 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2404 (on_compose_mail): Implementation of the SendAsMail functionality
2406 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2408 * src/modest-account-mgr.c:
2409 (modest_account_mgr_add_server_account): Set the secure-connection
2410 conf key for transport accounts as well as store accounts. I don't know
2411 why the if was there. For instance, this makes sure that we use SSL
2412 for the gmail preset from the easysetup wizard.
2414 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2416 * src/gnome/modest-main-window.c:
2417 (on_account_store_connecting_finished), (connect_signals):
2418 * src/maemo/modest-main-window.c:
2419 (on_account_store_connecting_finished), (connect_signals),
2420 (modest_main_window_new):
2421 Handle TnyAccountStore::connecting-finished instead of
2422 TnyDevice::connection-changed, because we cannot actually perform
2423 operations on accounts until TnyAccountStore has itself responded to
2424 the TnyDevice::connection-changed signal. This prevents a GError from
2426 Do not try to update at startup, because we (at least on scratchbox)
2427 already do an update at startup when the device goes online.
2428 This prevents a GError from tinymail.
2429 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2430 Added TODO about stopping simultaneous operations.
2432 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2434 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2435 * src/modest-mail-operation-queue.c:
2436 (modest_mail_operation_queue_remove):
2437 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2438 about where they happened.
2440 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2442 * src/modest-ui-actions.c:
2443 (modest_ui_actions_on_password_requested): Make sure that the remember
2444 output parameter is always TRUE.
2446 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2448 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2449 Show a OK/Cancel dialog if the error is a question, though we still do not
2450 know anything more about what we are asking the user.
2451 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2452 Fix an uninitialized variable (helper). This is a logic error, however.
2454 2007-05-21 Christian Kellner <ckellner@openismus.com>
2456 * src/modest-search.h:
2457 Correct bit shifting in the ModestSearchFlags enum.
2459 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2461 * src/modest-tny-account.c:
2462 (modest_tny_account_new_from_server_account): Do not use the lsub and
2463 check-all hard-coded IMAP options when using POP.
2465 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2467 * src/modest-tny-account.c:
2468 (modest_tny_account_new_from_server_account):
2469 Use NULL for the secure-auth method for POP when Password auth has been
2470 specified by the user, as we already do for IMAP. "auth=Login" causes
2471 an error from camel or the server.
2473 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2475 * src/maemo/modest-account-settings-dialog.c:
2476 (create_page_account_details),
2477 (modest_account_settings_dialog_set_account_name):
2478 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2479 for the leave-on-server checkbox, rathr than just the checkbox, when
2480 the protocol is not POP.
2482 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2484 * src/widgets/modest-account-view.c:
2485 * src/widgets/modest-account-view.h:
2486 Added modest_account_view_select_account() which will be useful later
2487 to asynchronously re-select the edited account.
2489 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2491 * src/maemo/modest-account-settings-dialog.c:
2492 (modest_account_settings_dialog_set_account_name):
2493 Automatically choose the port numbers based on the secure authentication
2494 methods, if they have not been chosen before.
2495 This fixes projects.maemo.org bug NB#56273 .
2497 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2499 * src/maemo/modest-main-window-ui.h:
2500 * src/modest-ui-actions.c:
2501 * src/modest-ui-actions.h:
2502 Connect the Tools/SMTP Servers menu item to
2503 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2504 SMTP servers dialog, as in the UI specification and saves changes when it
2505 is closed. This fixed projects.maemo.org bug NB#56305 .
2507 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/modest-connection-specific-smtp-window.c:
2510 (modest_connection_specific_smtp_window_init):
2511 Use gtk_window_set_default_size() to make this window big enough, so
2512 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2514 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2516 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2517 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2518 (modest_connection_specific_smtp_edit_window_init),
2519 Do not try to connect to a combobox signal before the combobox exists.
2520 This fixes the cras in projects.maemo.org bug NB#56288 .
2521 (modest_connection_specific_smtp_edit_window_get_settings):
2522 Remove the server_account_name parameter which was being checked for NULL
2523 though it was not used.
2525 * src/maemo/modest-connection-specific-smtp-window.c:
2526 (modest_connection_specific_smtp_window_fill_with_connections),
2527 (on_button_edit), (modest_connection_specific_smtp_window_init):
2528 Correct the number of treemodel columns to prevent a warning.
2529 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2530 libconic does not work.
2532 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2534 * src/modest-tny-account.c:
2535 (modest_tny_account_new_from_server_account):
2536 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2537 SMTP when "None" was chosen by the user. However, with my SMTP server that
2538 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2541 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2543 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2544 to explain the memory management issue with the ID in the ModestPair.
2546 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2547 (add_sending_page), (modest_account_assistant_finalize):
2548 * src/gnome/modest-gnome-global-settings-dialog.c:
2549 (create_updating_page), (create_composing_page):
2550 * src/gnome/modest-msg-edit-window.c: (get_transports),
2551 (init_window), (modest_msg_edit_window_finalize),
2552 (modest_msg_edit_window_get_msg_data):
2553 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2554 * src/gnome/modest-transport-widget.c:
2555 (modest_transport_widget_finalize), (smtp_configuration):
2556 * src/maemo/modest-maemo-global-settings-dialog.c:
2557 (create_updating_page), (create_composing_page):
2558 * src/maemo/modest-msg-edit-window.c: (get_transports),
2559 (init_window), (modest_msg_edit_window_finalize),
2560 (modest_msg_edit_window_get_msg_data),
2561 (modest_msg_edit_window_free_msg_data):
2562 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2563 (modest_store_widget_finalize):
2564 * src/maemo/modest-transport-widget.c:
2565 (modest_transport_widget_finalize), (smtp_configuration):
2566 * src/modest-main.c: (send_mail):
2567 * src/widgets/modest-combo-box.h:
2568 * src/widgets/modest-global-settings-dialog-priv.h:
2569 * src/widgets/modest-global-settings-dialog.c:
2570 (modest_global_settings_dialog_finalize):
2571 * src/widgets/modest-msg-edit-window.h:
2572 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2573 as long as the combo box, to prevent use of freed memory for the ID.
2575 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2577 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2578 get_accounts(), to make this clearer. Do not check for the enabled gconf
2579 key, because we do not use this for server accounts (at least, not yet).
2580 This allows us to send email again.
2582 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2584 * src/maemo/modest-platform.c:
2585 (on_modest_conf_update_interval_changed), (modest_platform_init):
2586 Only respond to this particular key change. All these strcmp()s cannot be
2589 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2591 * src/maemo/modest-maemo-global-settings-dialog.c:
2592 (current_connection): Prevent a crash in scratchbox when
2593 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2594 * src/maemo/modest-platform.c:
2595 (on_modest_conf_update_interval_changed), (modest_platform_init):
2596 Get the update interval from gconf and reset it when the gconf key changes.
2598 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2600 * src/modest-protocol-info.c:
2601 * src/modest-protocol-info.h: Adde enum-specific get functions,
2602 instead of using a ModestProtocolType enum parameter.
2604 * src/gnome/modest-account-assistant.c:
2605 * src/gnome/modest-store-widget.c:
2606 * src/gnome/modest-store-widget.h:
2607 * src/gnome/modest-transport-widget.c:
2608 * src/gnome/modest-transport-widget.h:
2609 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2610 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2611 * src/maemo/easysetup/modest-easysetup-wizard.c:
2612 * src/maemo/modest-account-settings-dialog.c:
2613 * src/maemo/modest-account-settings-dialog.h:
2614 * src/maemo/modest-store-widget.c:
2615 * src/maemo/modest-store-widget.h:
2616 * src/maemo/modest-transport-widget.c:
2617 * src/maemo/modest-transport-widget.h:
2618 * src/modest-account-mgr-helpers.c:
2619 * src/modest-account-mgr-helpers.h:
2620 * src/modest-account-mgr.c:
2621 * src/modest-account-mgr.h:
2622 * src/modest-tny-account.c:
2623 * src/modest-tny-folder.c:
2624 * src/widgets/modest-account-view.c:
2625 * src/widgets/modest-retrieve-combo-box.c:
2626 * src/widgets/modest-retrieve-combo-box.h:
2627 * src/widgets/modest-secureauth-combo-box.c:
2628 * src/widgets/modest-serversecurity-combo-box.c:
2629 * src/widgets/modest-serversecurity-combo-box.h:
2630 * tests/check_account-mgr.c:
2631 Use the specific functions, and use the re-renamed enum values for GNOME too.
2633 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2635 * src/modest-pair.h:
2636 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2637 so we can get the second based on the first.
2639 * src/maemo/modest-account-settings-dialog.h:
2640 * src/maemo/modest-account-settings-dialog.c:
2641 Added get_supported_secure_authentication_methods(), though it is mostly
2642 commented-out for now until the necessary API is committed to tinymail.
2643 (modest_account_settings_dialog_set_account_name),
2644 (save_configuration): Request the supported authentication methods from the
2645 server, so we can choose a working method.
2647 * src/modest-tny-account-store.h:
2648 * src/modest-tny-account-store.c:
2649 (modest_tny_account_store_get_session): Rename from
2650 tny_account_store_get_session().
2652 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2654 * src/modest-protocol-info.h: Split the ModestProtocol enum
2655 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2656 There was no need to have these unrelated values in one enum.
2658 * src/: many files: Adapted to changed enum. This makes the code a bit
2659 clearer, and the compiler could catch some errors.
2661 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2663 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2664 Show the detailed internal camel error message when an error happens
2665 during the configuration, so that our testers can give us more clues.
2666 For instance, in projects.maemo.org bug NB#56910 .
2668 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2670 * src/modest-tny-account.c:
2671 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2672 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2674 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2676 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2677 * src/maemo/modest-account-settings-dialog.c:
2678 (modest_account_settings_dialog_set_account_name),
2679 (save_configuration): For the incoming secure authentication checkbox,
2680 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2681 the UI specification. PLAIN does not seem to be supported for most IMAP
2682 servers anyway, and I am not sure what it would mean.
2683 However, we probably need to discover which of the secure-authentication
2684 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2685 * src/modest-account-mgr-helpers.c:
2686 (modest_account_mgr_get_server_account_data):
2688 * src/modest-tny-account.c:
2689 (modest_tny_account_new_from_server_account):
2690 Use tny_account_set_mech() to set secure-authentication methods,
2691 with some special-casing for IMAP, based on my observations of how
2694 * src/modest-account-mgr-helpers.h:
2695 * src/modest-account-mgr.c:
2696 * src/modest-defs.h: Comment that the URI is only used for local folders.
2698 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2700 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2701 parameter const, just to be neat.
2702 * src/modest-text-utils.c: (modest_text_utils_inline):
2703 End g_strconcat() with NULL, as its documentation says. This is almost
2704 certainly the cause of my crash at startup on the device. Interestingly,
2705 valgrind doesn't tell us about these errors.
2707 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2709 * scripts/build-packages: Added more precise comments about how to use
2710 this script, though I still get this error:
2711 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2712 error building tinymail
2714 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2716 * src/maemo/modest-main-window.c: (on_account_update):
2717 Very slight cleanup, hoping to make it simpler to discover what causes
2718 a crash here sometimes.
2720 * src/modest-tny-account.c:
2721 (modest_tny_account_new_from_server_account): Set the port. Added
2722 comments about the options and a TODO comment because I need to find out
2723 how to specify the secure authentication method.
2725 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2727 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2728 changed CFlags paths form modest to libmodest
2730 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2732 * src/modest-account-mgr-helpers.c:
2733 (modest_account_mgr_get_server_account_data),
2734 (modest_account_mgr_free_server_account_data):
2735 * src/modest-account-mgr-helpers.h:
2736 * src/modest-account-mgr.c:
2737 (modest_account_mgr_add_server_account):
2738 * src/modest-defs.h:
2739 * src/modest-tny-account.c:
2740 (modest_tny_account_new_from_server_account):
2741 Determine the options for tny_camel_account_add_option() here,
2742 based on the settings, rather than storing them directly in gconf.
2744 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2746 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2747 Show a more friendly error dialog now that we expect (from the tinymail
2748 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2750 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/modest-main-window.c: (on_account_update): Check that
2753 account_name is not NULL, to prevent a crash at startup that I am
2754 seeing on the N800. I do wonder why it is NULL.
2756 * src/maemo/easysetup/modest-easysetup-wizard.c:
2757 (create_page_user_details):
2758 * src/maemo/modest-account-settings-dialog.c:
2759 (create_page_user_details), (create_page_outgoing):
2760 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2761 (modest_connection_specific_smtp_edit_window_init):
2762 * src/modest-ui-actions.c:
2763 (modest_ui_actions_on_password_requested):
2764 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2765 might do something useful with the on-screen keyboard.
2767 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2769 * src/maemo/modest-main-window.c: (on_account_update):
2770 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2771 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2773 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2775 * src/modest-tny-account-store.c: (on_account_changed):
2776 Correct the signature of this signal handler.
2778 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2780 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2781 Show a HildonNote instead of a GtkDialog for Maemo.
2783 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2785 * src/widgets/modest-account-view.h:
2786 * src/widgets/modest-account-view.c: (on_account_changed),
2787 (on_account_removed). Added a boolean flag, set/unset by
2788 modest_account_view_block_conf_updates(),
2789 modest_account_view_unblock_conf_updates() to prevent unnecessary
2790 updates, but this is not very useful because the gconf notifications are
2791 so delays (maybe only on Maemo Bora).
2792 So auto-updating is turned off, and these functions do an explicit
2793 update when necessary.
2794 However, something else is still doing too much work when adding/removing
2795 accounts, probably in another part of the application.
2797 * src/maemo/modest-account-view-window.c:
2798 (on_delete_button_clicked), (on_edit_button_clicked),
2799 (on_new_button_clicked): Use the new functions.
2801 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2803 * src/modest-account-mgr-helpers.c:
2804 (modest_account_mgr_set_first_account_as_default):
2805 Sort the list of names alphabetically-by-title, so we choose the first one
2807 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2808 alphabetically by the title.
2810 This fixes projects.maemo.org bug NB#56418 .
2812 * src/modest-account-mgr-priv.c:
2813 (_modest_account_mgr_account_from_key):
2814 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2815 avoid a valgrind error, and possible random behaviour.
2817 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2819 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2820 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2821 tinymail documentation to say that this can be expected.
2822 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2823 pretty, and should not happen, but I would prefer to know when it does.
2825 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2827 * configure.ac: When using the older hildon version, probably on Bora,
2828 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2830 * src/widgets/modest-attachment-view.c:
2831 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2834 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2836 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2837 Implemented the prototype. Can be tested with
2838 tests/dbus_api/test_open_message:
2840 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2842 * src/modest-tny-account-store.c:
2843 (modest_tny_account_store_instance_init), (get_password):
2844 * src/modest-ui-actions.c:
2845 (modest_ui_actions_on_password_requested):
2846 Do not store the password in gconf, because this function is called
2847 for non-remembered passwords. Actually use the cached (in the hash map)
2848 password instead of releasing it.
2849 The password will now not be remembered if it is asked via the protected
2850 password dialog, as per the UI spec.
2852 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2854 * src/modest-defs.h:
2855 * src/modest-account-mgr-helpers.h:
2856 * src/modest-account-mgr-helpers.c:
2857 Added modest_server_account_get_username_has_succeeded(),
2858 modest_server_account_set_username_has_succeeded().
2859 (modest_server_account_set_username),
2860 Reset the has-succeeded flag if the username changes.
2862 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2863 * src/maemo/modest-connection-specific-smtp-window.c:
2864 (modest_connection_specific_smtp_window_save_server_accounts):
2865 Use modest_server_account_set_username() instead of using
2866 modest_conf_set_string() directly, so that the has-succeeded flag is always
2869 * src/modest-ui-actions.c:
2870 (modest_ui_actions_on_password_requested): Dim the username entry if
2871 the username has ever worked, as per the UI spec.
2873 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2875 * src/modest-tny-account-store.c: (get_password):
2876 * src/modest-ui-actions.c:
2877 (modest_ui_actions_on_password_requested):
2878 Allow the username to be changed too, though there is more work to
2879 be done on exactly how this behaves.
2881 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2883 * src/modest-account-mgr-helpers.h:
2884 * src/modest-account-mgr-helpers.c:
2885 Added modest_account_mgr_get_display_name(),
2886 modest_server_account_get_username(),
2887 modest_server_account_set_username(),
2888 modest_server_account_set_password(),
2889 modest_server_account_get_hostname() functions so we do not need to
2890 use the conf API directly.
2892 * src/maemo/modest-main-window.c: (connect_signals):
2893 Actually connect ot the ModestAccountStore::request-password signal,
2894 so that we show the dialog when the password is requested by Tinymail,
2895 for isntance if it is empty.
2897 * src/modest-marshal.list:
2898 * src/modest-tny-account-store.c:
2899 (modest_tny_account_store_class_init), (get_password),
2900 (modest_tny_account_store_alert):
2901 * src/modest-tny-account-store.h:
2902 * src/modest-ui-actions.h:
2903 * src/modest-ui-actions.c:
2904 (modest_ui_actions_on_password_requested):
2905 Change the signal parameters, so it is obvious that we are providing
2906 the non human-readable server name, and receiving both the username
2907 and password, though changing of the username is not yet implemented.
2908 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2909 for the GNOME version.
2911 This should fix the projects.maemo.org bug NB#56209, though it does not
2912 work on Bora, because the gconf_client_get() for the password fails
2913 immediately after we save it with gconf_client_set().
2915 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2918 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2919 caused an undefined symbol error:
2920 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2922 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2924 * src/modest-tny-account-store.c:
2925 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2926 using a GError instead of a string message, so we can translate it in
2929 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2931 * src/maemo/modest-address-book.c:
2932 (modest_address_book_check_names):
2933 * src/maemo/modest-msg-view-window.c:
2934 (modest_msg_view_window_clipboard_owner_change):
2935 * src/modest-init.c: (modest_init_init_ui):
2936 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2937 (update_folders_cb), (modest_mail_operation_update_account):
2938 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2939 (modest_ui_actions_on_msg_attachment_clicked),
2940 (modest_ui_actions_on_msg_recpt_activated):
2941 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2942 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2943 (modest_msg_view_search_next):
2944 * src/widgets/modest-recpt-editor.c:
2945 (modest_recpt_editor_on_button_release_event),
2946 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2947 g_message(). At this point we should only be seeing interesting errors on
2948 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2950 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2952 (modest_wizard_dialog_force_title_update):
2953 * src/maemo/easysetup/modest-wizard-dialog.h:
2954 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2955 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2956 can update the title when appropriate. Otherwise the title is wrong if the
2957 pages are added after adding the notebook to the dialog.
2958 This must be a problem in HildonWizardDialog too.
2959 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2961 * src/maemo/easysetup/modest-easysetup-wizard.c:
2962 (create_subsequent_customsetup_pages),
2963 (create_subsequent_easysetup_pages):
2964 Call modest_wizard_dialog_force_title_update() so that the title is
2965 correct even with GTK+ < 2.10.
2966 This fixes projects.maemo.org bug NB#56145 .
2968 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2970 * src/maemo/modest-platform.c:
2971 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2972 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2975 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2977 * src/widgets/modest-window.h:
2978 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2979 and modest_window_save_state(), which invokes it.
2981 * src/widgets/modest-window-mgr.h:
2982 * src/widgets/modest-window-mgr.c:
2983 Added modest_window_mgr_save_state_for_all_windows(), which calls
2984 the save_state vfunc on all registered windows, if implemented.
2986 * src/gnome/modest-msg-edit-window.c:
2987 * src/gnome/modest-msg-view-window.c:
2988 * src/maemo/modest-msg-edit-window.c:
2989 * src/maemo/modest-msg-view-window.c:
2990 * src/maemo/modest-main-window.c:
2991 Specify the existing save_settings functions as implementations of
2992 ModestWindow::save_state_func().
2994 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2995 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2996 enabling hibernation, for instance.
2998 We may need to do the same thing for restoring settings.
3001 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3003 * src/widgets/modest-window-mgr.c:
3004 * src/widgets/modest-window-mgr.h:
3005 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3006 modest_window_mgr_get_hibernation_is_prevented().
3008 * src/maemo/modest-main-window.c:
3009 (on_hildon_program_is_topmost_notify): Prevent hibernation
3010 (possible when the application goes to the background in the WM),
3011 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3013 * src/maemo/easysetup/modest-easysetup-wizard.c:
3014 (modest_easysetup_wizard_dialog_init):
3015 * src/maemo/modest-account-settings-dialog.c:
3016 (modest_account_settings_dialog_init):
3017 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3018 (modest_connection_specific_smtp_edit_window_init):
3019 * src/maemo/modest-connection-specific-smtp-window.c:
3020 (modest_connection_specific_smtp_window_init):
3021 * src/maemo/modest-signature-editor-dialog.c:
3022 (modest_signature_editor_dialog_init):
3023 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3024 prevent hibernation while any of these account settings dialogs are open.
3026 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3028 * src/maemo/Makefile.am:
3029 * src/maemo/modest-osso-state-saving.c:
3030 * src/maemo/modest-osso-state-saving.h: Added
3031 modest_osso_load_state() and modest_osso_save_state() though they do
3032 nothing now. They should iterate through all the open windows and load/save
3034 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3035 save state when closing.
3037 * src/maemo/modest-main-window.c:
3038 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3039 Add a notification handler for the HildonProgram::is-topmost property,
3040 so we can allow hibernation when the application goes into the background.
3041 But we still need to detect when the accounts setup windows are open so
3042 we can stop hibernation when they are open.
3043 To do this, I also added the main window the HildonProgram. This might have
3044 other side-effects/benefits, and should maybe be done for other windows.
3046 * src/maemo/modest-osso-autosave-callbacks.h:
3047 * src/maemo/modest-osso-autosave-callbacks.c:
3048 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3049 though it does not do anything yet, and we might never need this to do
3050 anything. For instance, we already save drafts.
3052 * src/maemo/modest-platform.c: (modest_platform_init):
3053 Specify the libosso auto-save callback.
3055 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3057 * src/maemo/modest-platform.c:
3058 (modest_platform_set_update_interval):
3059 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3060 aparently stays valid between application instances, so we can use this
3061 to remove and reset it later. According to a maemo-developers email from
3064 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3066 * configure.ac: Depend on libalarm for Maemo.
3068 * src/dbus_api/modest-dbus-api.h:
3069 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3070 (on_send_receive), (modest_dbus_req_handler):
3071 Handle a SEND_RECEIVE D-Bus method.
3073 * libmodest-dbus-client/libmodest-dbus-client.c:
3074 (libmodest_dbus_client_send_and_receive):
3075 * libmodest-dbus-client/libmodest-dbus-client.h:
3076 Add C convenience functions for calling the new D-Bus method.
3078 * src/modest-platform.h:
3079 * src/gnome/modest-platform.c:
3080 * src/maemo/modest-platform.c:
3081 Added modest_platform_set_update_interval(), which uses the
3082 alarmd API on Maemo.
3083 (modest_platform_init),
3084 Call modest_platform_set_update_interval(), using a hard-coded
3085 interval for now (until the global settings dialog is implemented),
3086 though I am not sure that this makes sense yet.
3088 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3090 * src/dbus_api/modest-dbus-callbacks.c:
3091 (modest_osso_cb_hw_state_handler):
3092 * src/dbus_api/modest-dbus-callbacks.h:
3093 * src/maemo/modest-platform.c: (modest_platform_init):
3094 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3095 in case this has some effect on the ability for Maemo to ping the
3098 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3100 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3101 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3102 warning. It is probably a logic error, but I need to fix the build.
3104 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3106 * src/modest-account-mgr.h:
3107 * src/modest-account-mgr.c:
3108 (modest_account_mgr_account_names): Add a gboolean enabled_only
3109 parameter, so we can get lists of onlt the enabled accounts.
3111 (modest_account_mgr_add_account),,
3112 (modest_account_mgr_account_with_display_name_exists):
3113 * src/maemo/modest-msg-edit-window.c: (get_transports):
3114 * src/modest-account-mgr-helpers.c:
3115 (modest_account_mgr_set_first_account_as_default):
3116 * src/modest-init.c: (init_default_account_maybe):
3117 * src/modest-tny-account-store.c: (get_accounts):
3118 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3119 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3120 * tests/check_account-mgr.c: (START_TEST):
3121 Provide the extra parameter, as appropriate.
3123 * src/widgets/modest-account-view.c: (update_account_view):
3124 Do not show disabled accounts (meaning that there is no way to
3125 enable/disable accounts in the UI (the feature is not in our UI
3126 specification), so we can use this internally only to mark unfinished
3127 or temporary account data.
3129 * src/maemo/easysetup/modest-easysetup-wizard.c:
3130 (create_account): Add boolean enable parameter, so we can specify FALSE
3131 to create the temporary account.
3132 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3133 (on_before_next): When finishing, when there is a temporary account, just
3135 Also, use a timeout to delay the showing of the dialog until gconf is likely
3136 to return correct information, due to a maemo gconf bug that is fixed in
3137 osso 1.1, but not yet in Bora.
3138 However, the dialog stays on screen after it is destroyed.
3140 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3141 for invalid data when cancelling. Use a hildon note instead of a dialog
3142 to complain about invalid data. Do not show the account-saved note if the
3143 account is disabled (a temporary account that will not really be saved for use
3146 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3148 * src/modest-account-mgr-helpers.h:
3149 * src/modest-account-mgr-helpers.c:
3150 Added modest_account_mgr_unset_default_account(),
3151 Added modest_account_mgr_set_first_account_as_default().
3153 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3154 If it was the default account, unset the default account name.
3156 * src/maemo/modest-account-view-window.c:
3157 (on_delete_button_clicked): If it was the default account,
3158 set the first remaining account as the default instead.
3160 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3161 a NULL account or a NULL default account, to prevent a crash. This should
3162 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3165 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3167 * src/widgets/modest-recpt-editor.c:
3168 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3169 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3170 TODO comment for this. This fixes the build.
3172 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3173 be the best place for it. This will in future update all auto-update accounts,
3174 rather than just the current/default account, when that gconf key exists.
3175 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3176 if there are no accounts, before calling do_send_receive().
3177 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3179 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3180 * src/maemo/modest-main-window-ui.h:
3181 * src/maemo/modest-main-window.c: (on_connection_changed),
3182 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3183 directly, becaue the signal handler does more.
3185 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3187 * src/modest-account-mgr-helpers.c:
3188 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3189 for the case that the account does not exist.
3191 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3192 (equivalent to the modest account name) rather than the tinymail account name
3193 (equivalent to the modest account title - human readable) to get the account data.
3194 Check for null account data to prevent the crash, and add a TODO comment saying that
3195 this needs fixing because it is using the server account name instead of the account name.
3197 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3199 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3200 * src/maemo/modest-account-settings-dialog.c: (show_error),
3202 Use hildon_note_new_information() for informative and error messages,
3203 which seems to be expected for Maemo applications (no documentation that I know of
3204 says this). I am surprised that there is no distinction between info and error
3207 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3209 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3210 it is easy to find where this is used.
3212 * src/maemo/easysetup/modest-easysetup-wizard.c:
3213 (create_page_welcome), (create_page_account_details),
3214 (create_page_user_details), (create_page_complete_easysetup),
3215 (create_page_custom_incoming), (create_page_custom_outgoing),
3216 (create_page_complete_custom):
3217 * src/maemo/modest-account-settings-dialog.c:
3218 (create_page_account_details), (create_page_user_details),
3219 (create_page_incoming), (create_page_outgoing):
3220 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3221 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3222 (modest_connection_specific_smtp_edit_window_init):
3223 * src/maemo/modest-connection-specific-smtp-window.c:
3224 (modest_connection_specific_smtp_window_init):
3225 * src/maemo/modest-signature-editor-dialog.c:
3226 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3227 and scrolling policy as per the Email Application Layout Guide, if I have
3230 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3232 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3233 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3234 which were empty, because these vfuncs have been removed from TnyAccountStore.
3235 This fixes the build.
3237 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3239 * src/maemo/modest-main-window.c:
3240 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3241 showing/hiding it. Added TODO because it probably should not be NULL.
3242 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3243 because unnecessary g_warnings() make degugging difficult.
3245 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3247 * src/maemo/modest-msg-edit-window.c:
3248 (modest_msg_edit_window_select_color),
3249 (modest_msg_edit_window_select_background_color): 2 const corrections and
3250 moving 2 #endifs before closing brackets, to fix the build.
3252 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3254 * src/maemo/easysetup/modest-easysetup-wizard.h:
3255 * src/maemo/easysetup/modest-easysetup-wizard.c:
3256 (modest_easysetup_wizard_dialog_finalize),
3257 (on_button_edit_advanced_settings), (create_page_complete_custom),
3258 (on_response), (create_account):
3259 Implement the Advanced Settings edit button, by saving the account information,
3260 for the Advanded Settings dialog to use directly from gconf, and removing it
3261 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3262 Bug #5533 in the projects.maemo.org bugzilla.
3264 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3266 * src/maemo/modest-msg-view-window.c:
3267 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3268 when opening a message window.
3270 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3272 * src/maemo/easysetup/modest-easysetup-wizard.c:
3273 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3276 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3277 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3278 gconf settings. I probably added more checks than necessary, but that is safer.
3280 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3281 variable to fix the build, but this seems to be used when it is still NULL.
3283 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3285 * src/modest-platform.h:
3286 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3287 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3288 * src/modest-main.c: Implement this function so we can avoid using
3289 maemo-specific API from cross-platform code.
3291 * src/modest-tny-account-store.c:
3292 (get_smtp_specific_transport_account_for_open_connection):
3293 * src/modest-ui-actions.c: (check_for_connection),
3294 (modest_ui_actions_on_item_not_found):
3295 Use modest_platform_connect_and_wait() and put #idefs around other
3296 maemo-specific code, because only maemo currently has a way to
3297 identify connection names.
3299 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3301 * src/modest-tny-account-store.h:
3302 * src/modest-tny-account-store.c:
3303 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3304 the connection-specific SMTP server settings in the configuration.
3306 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3308 * src/maemo/modest-main-window.c: (on_connection_changed),
3310 * src/modest-main.c: (main), (start_ui), (send_mail):
3311 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3312 that is what is intended.
3314 * src/modest-ui-actions.c: (action_send), (action_receive),
3315 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3316 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3317 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3318 SMTP server is used when it is specified.
3320 (modest_ui_actions_on_send_receive):
3321 Check that a connection is open before proceeding.
3322 Receive and then send, instead of vice-versa, as per the specification.
3324 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3326 * src/modest-mail-operation.c:
3327 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3328 though I guess it should be something other than NULL.
3330 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3332 * src/maemo/easysetup/modest-easysetup-wizard.c:
3333 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3334 combo twice, to avoid an g_warning and to make it visible again.
3335 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3336 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3337 (already intended) dereference when detaching, because we then recreate the menu.
3338 But I am not sure why the warning was happening, and it is possible that this is a memory
3341 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3343 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3344 and uri_parse_mailto() utility functions.
3345 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3347 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3349 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3351 * src/dbus_api/modest-dbus-api.h:
3352 * src/dbus_api/modest-dbus-callbacks.c:
3353 Use an idle callback to execute the modest code in the application's own thread.
3354 Remove the helloworld example method.
3355 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3356 parsed, and the open-message method is not implemented because this is not yet implemented in
3358 * libmodest-dbus-client/libmodest-dbus-client.c:
3359 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3360 (libmodest_dbus_client_open_message):
3361 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3363 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3364 body without crashing.
3366 * tests/dbus_api/Makefile.am:
3367 * tests/dbus_api/test_mail_to.c:
3368 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3370 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3372 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3373 Added file to fix the build. Sorry.
3375 * src/dbus_api/Makefile.am:
3376 * src/dbus_api/modest-dbus-api.h:
3377 * src/dbus_api/modest-dbus-callbacks.h:
3378 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3379 (modest_dbus_req_handler):
3380 Put constants in a separate header so it can be reused by the
3381 client library, without duplication
3383 * libmodest-dbus-client/Makefile.am:
3384 * libmodest-dbus-client/libmodest-dbus-client.c:
3385 (libmodest_dbus_client_call_helloworld),
3386 (libmodfest_dbus_client_send_mail),
3387 (libmodfest_dbus_client_mailto),
3388 (libmodfest_dbus_client_open_message):
3389 * libmodest-dbus-client/libmodest-dbus-client.h:
3390 (Partly) Implement a send_mail D-Bus method.
3392 * tests/dbus_api/Makefile.am:
3393 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3394 the send_email D-Bus method.
3396 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3400 * libmodest-dbus-client/Makefile.am:
3401 * libmodest-dbus-client/libmodest-dbus-client.c:
3402 * libmodest-dbus-client/libmodest-dbus-client.h:
3403 * tests/dbus_api/Makefile.am:
3404 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3405 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3407 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3409 * src/maemo/easysetup/modest-easysetup-wizard.c:
3410 (create_page_account_details):
3411 * src/maemo/modest-account-settings-dialog.c:
3412 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3413 widgets, because this might not be the default in future versions of the Maemo GTK+.
3414 However, I can not not get capitalization to work even in a simple test case.
3416 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3418 * src/maemo/easysetup/modest-easysetup-wizard.c:
3419 (create_page_custom_incoming), (create_page_custom_outgoing):
3420 * src/maemo/modest-account-settings-dialog.c:
3421 (create_page_account_details), (create_page_incoming),
3422 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3423 instead of using gtk_check_button_with_label(), so they are aligned like the other
3424 widgets, as per the UI spec.
3426 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3428 * src/maemo/easysetup/modest-easysetup-wizard.c:
3429 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3430 * src/widgets/modest-validating-entry.c:
3431 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3432 Modest prefix instead of an EasySetup prefix.
3434 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3436 * src/widgets/modest-validating-entry.h:
3437 * src/widgets/modest-validating-entry.c: (on_insert_text),
3438 Added easysetup_validating_entry_set_max_func(), used to set a callback
3439 to call when the max number of characters is reached. GtkEntry has a max-length
3440 already but is silent about it.
3442 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3443 (create_page_account_details), (create_page_user_details),
3445 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3446 (create_page_account_details), (create_page_user_details),
3447 (create_page_outgoing):
3448 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3449 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3450 the UI spec, when the user tries to enter more than the max number of characters.
3452 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/easysetup/modest-easysetup-wizard.c:
3455 (create_page_user_details), (create_page_custom_incoming),
3456 (create_page_custom_outgoing):
3457 * src/maemo/modest-account-settings-dialog.c:
3458 (create_page_user_details), (create_page_incoming),
3459 (create_page_outgoing):
3460 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3461 (modest_connection_specific_smtp_edit_window_init):
3462 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3463 not appropriate. Bad Maemo-specific defaults!.
3465 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3467 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3468 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3469 (modest_signature_editor_dialog_set_settings):
3470 Disable the label and textview when the checkbox is disabled, and use the
3471 specified (UI spec) default signature text.
3473 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3475 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3476 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3478 * src/modest-defs.h:
3479 * src/modest-account-mgr-helpers.h:
3480 * src/modest-account-mgr-helpers.c:
3481 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3483 * src/maemo/Makefile.am:
3484 * src/maemo/modest-signature-editor-dialog.c:
3485 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3488 * src/maemo/modest-account-settings-dialog.h:
3489 * src/maemo/modest-account-settings-dialog.c:
3490 (modest_account_settings_dialog_finalize), (on_button_signature),
3491 (save_configuration): Use the new dialog when the Edit button is pressed, and
3492 save the changes if necessary, as per the UI spec.
3494 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3496 * src/maemo/Makefile.am:
3497 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3498 based on maemo-develoers email from Dirk.
3500 * src/maemo/easysetup/modest-easysetup-wizard.c:
3501 (create_page_welcome), (create_page_account_details),
3502 (create_page_user_details), (create_page_complete_easysetup),
3503 (create_page_custom_incoming), (create_page_custom_outgoing),
3504 (create_page_complete_custom),
3505 (modest_easysetup_wizard_dialog_init):
3506 * src/maemo/modest-account-settings-dialog.c:
3507 (create_page_account_details), (create_page_user_details),
3508 (create_page_incoming), (create_page_outgoing),
3509 (modest_account_settings_dialog_init):
3510 * src/maemo/modest-connection-specific-smtp-window.c:
3511 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3513 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3515 * src/maemo/easysetup/modest-easysetup-wizard.c:
3516 (create_page_account_details), (create_page_custom_outgoing),
3517 (create_page_complete_custom):
3518 * src/maemo/modest-account-settings-dialog.c:
3519 (create_page_user_details), (create_page_incoming),
3520 (create_page_outgoing):
3521 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3522 (modest_connection_specific_smtp_edit_window_init):
3523 Use the correct (UI spec) port min/max, and use horizontal separators,
3526 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3528 * src/maemo/easysetup/modest-easysetup-wizard.c:
3529 (set_default_custom_servernames):
3530 * src/maemo/modest-account-settings-dialog.c:
3531 (create_page_incoming), (on_combo_outgoing_security_changed),
3532 (on_combo_incoming_security_changed), (create_page_outgoing),
3533 (modest_account_settings_dialog_set_account_name),
3534 (save_configuration):
3535 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3536 (on_combo_security_changed),
3537 (modest_connection_specific_smtp_edit_window_init),
3538 (modest_connection_specific_smtp_edit_window_set_connection),
3539 (modest_connection_specific_smtp_edit_window_get_settings):
3540 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3543 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3546 * src/maemo/easysetup/modest-easysetup-wizard.c:
3547 (create_page_custom_outgoing), (create_page_complete_custom):
3548 * src/maemo/modest-account-settings-dialog.c:
3549 (create_page_user_details), (create_page_outgoing):
3550 * src/maemo/modest-account-view-window.c: (button_box_new):
3551 Use changed logical IDs as per the most recent UI spec:
3552 mcen_bd_emailsetup_edit -> mcen_bd_edit
3553 mcen_bd_emailsetup_delete -> mcen_bd_delete
3554 mcen_bd_emailsetup_close -> mcen_bd_close
3556 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3560 * src/dbus_api/Makefile.am:
3561 * src/dbus_api/modest-dbus-callbacks.c:
3562 * src/dbus_api/modest-dbus-callbacks.h:
3563 * src/maemo/modest-platform.c: (modest_platform_init):
3564 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3566 * tests/Makefile.am:
3567 * tests/dbus_api/Makefile.am:
3568 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3570 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3572 * src/maemo/modest-account-settings-dialog.c:
3573 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3574 Removed unnecessary includes.
3576 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3578 * src/maemo/easysetup/modest-easysetup-wizard.c:
3579 * src/maemo/modest-account-settings-dialog.c:
3580 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3581 * src/widgets/Makefile.am:
3582 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3583 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3584 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3585 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3586 * src/widgets/modest-secureauth-combo-box.c:
3587 * src/widgets/modest-secureauth-combo-box.h:
3588 * src/widgets/modest-serversecurity-combo-box.c:
3589 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3590 made the GObject names more consistent with the rest of the Modest code.
3592 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3594 * src/maemo/easysetup/Makefile.am:
3595 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3596 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3597 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3598 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3599 * src/maemo/easysetup/modest-easysetup-wizard.c:
3600 * src/maemo/easysetup/modest-validating-entry.c:
3601 * src/maemo/easysetup/modest-validating-entry.h:
3602 * src/maemo/modest-account-settings-dialog.c:
3603 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3604 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3605 widgets/ because they are used outside of easysetup too. After checking in,
3606 svn will allow me to rename them too.
3608 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3610 * src/gnome/modest-msg-edit-window.c:
3611 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3612 linker error, to fix the build on the GNOME platform.
3613 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3614 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3615 ifdefed out to avoid a warning.
3617 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3619 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3620 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3621 some alternative for GTK+ 2.6.
3623 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3625 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3627 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3628 specified for EmailAccountsDialog in UI spec.
3630 * src/maemo/easysetup/modest-easysetup-wizard.c:
3631 * src/maemo/easysetup/modest-easysetup-wizard.h:
3632 * src/maemo/modest-account-settings-dialog.c:
3633 * src/maemo/modest-account-settings-dialog.h:
3634 Reuse a member window widget for the connection-specific SMTP server accounts,
3635 so we can tell it to create/save the accounts only if we actually save changes.
3637 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3638 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3639 (modest_connection_specific_smtp_edit_window_get_settings):
3640 Return a struct instance for temporarily remembering the entered data.
3642 * src/maemo/modest-connection-specific-smtp-window.h:
3643 * src/maemo/modest-connection-specific-smtp-window.c:
3644 (modest_connection_specific_smtp_window_finalize),
3645 (modest_connection_specific_smtp_window_fill_with_connections),
3647 (modest_connection_specific_smtp_window_save_server_accounts),
3648 (update_model_server_names): Do not actually save data until asked,
3649 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3651 (on_selection_changed),
3652 (modest_connection_specific_smtp_window_init): Disable the edit
3653 button when nothing is selected.
3655 * src/modest-account-mgr-helpers.c:
3656 * src/modest-account-mgr-helpers.h:
3657 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3660 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3662 * src/modest-account-mgr-helpers.h:
3663 * src/modest-account-mgr-helpers.c:
3664 (modest_account_mgr_get_unused_account_name),
3665 (modest_account_mgr_get_unused_account_display_name): Added these
3666 utility functions, to avoid code duplication.
3668 * src/maemo/easysetup/modest-easysetup-wizard.c:
3669 (create_page_account_details), (create_account):
3670 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3671 (on_combo_security_changed),
3672 (modest_connection_specific_smtp_edit_window_init),
3673 (modest_connection_specific_smtp_edit_window_save_settings):
3674 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3675 * src/maemo/modest-connection-specific-smtp-window.c:
3676 (modest_connection_specific_smtp_window_finalize),
3677 (modest_connection_specific_smtp_window_fill_with_connections),
3678 (on_button_edit), (modest_connection_specific_smtp_window_init):
3679 * src/maemo/modest-connection-specific-smtp-window.h:
3680 Implementing saving of connection-specific server accounts.
3682 But I need to refactor this so we can save the data for each
3683 possible connection-specific account and only actually create the server accounts
3684 when the easysetup finished, or the OK button is pressed on the account settings
3687 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3689 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3690 (on_combo_security_changed):
3691 (modest_connection_specific_smtp_edit_window_init):
3692 Auto-fill the port number as in the account settings.
3694 (modest_connection_specific_smtp_edit_window_set_connection):
3695 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3696 * src/maemo/modest-connection-specific-smtp-window.c:
3697 (fill_with_connections), (on_button_edit),
3698 (modest_connection_specific_smtp_window_init):
3699 Turn the edit window into a dialog to simplify the code, and
3700 set a WM hint as in a GtkDialog, because only a popup can be on top of
3701 another window in Maemo, and popups usually have no WM decoration.
3703 * src/modest-defs.h:
3704 * src/modest-account-mgr-helpers.c:
3705 (modest_account_mgr_set_connection_specific_smtp),
3706 (modest_account_mgr_remove_connection_specific_smtp),
3707 (modest_account_mgr_get_connection_specific_smtp):
3708 * src/modest-account-mgr-helpers.h: Some functions to write the
3709 connection-specific SMTP server information. Not yet used.
3712 * src/widgets/modest-folder-view.c: (text_cell_data):
3713 Fix a warning about an uninitialized variable.
3714 (on_configuration_key_changed): Put an #ifdef around the use
3715 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3717 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3719 * src/maemo/modest-account-settings-dialog.h:
3720 * src/maemo/modest-account-settings-dialog.c:
3721 Added connect_for_modified() utility function to mark the new modified boolean.
3723 (create_page_account_details), (create_page_user_details),
3724 (create_page_incoming), (create_page_outgoing), (on_response),
3725 (modest_account_settings_dialog_init),
3726 (modest_account_settings_dialog_set_account_name):
3727 Only warn about unsaved changes when there are actually unsaved changes.
3729 * src/modest-account-mgr-helpers.c:
3730 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3731 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3732 to get the data from there in future.
3734 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3736 * src/modest-defs.h:
3738 * src/modest-account-mgr-helpers.h:
3739 * src/modest-account-mgr-helpers.c:
3740 Store the security account setting in a single conf key instead of using
3741 the options list, so that the list is left for just the to-be-removed camel hack,
3742 and because gconf_client_set_list() is failing for some reason.
3744 * src/modest-account-mgr.c:
3745 (modest_account_mgr_add_server_account):
3746 * src/maemo/modest-account-settings-dialog.c:
3747 (modest_account_settings_dialog_set_account_name),
3748 (save_configuration): Use the renamed functions.
3751 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3753 * src/widgets/Makefile.am:
3754 * src/widgets/modest-limit-retrieve-combo-box.c:
3755 * src/widgets/modest-limit-retrieve-combo-box.h:
3756 * src/widgets/modest-retrieve-combo-box.c:
3757 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3758 the account settings dialog.
3760 * src/modest-defs.h:
3761 * src/modest-account-mgr-helpers.h:
3762 * src/modest-account-mgr-helpers.c:
3763 (modest_server_account_get_option_secure_auth),
3764 (modest_server_account_set_option_secure_auth):
3765 * src/modest-account-mgr.c:
3766 (modest_account_mgr_add_server_account):
3767 Use the existing AUTH_MECH conf key for the secure-auth setting,
3768 instead of putting it in the list options, because this was actually used already.
3770 * src/maemo/modest-account-settings-dialog.c:
3771 (create_page_account_details),
3772 (modest_account_settings_dialog_set_account_name),
3773 (save_configuration):
3774 * src/maemo/modest-account-settings-dialog.h:
3775 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3776 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3778 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3780 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3781 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3782 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3784 * src/modest-defs.h:
3785 * src/maemo/modest-account-settings-dialog.c:
3786 (create_page_incoming), (on_combo_outgoing_security_changed),
3787 (on_combo_incoming_security_changed), (create_page_outgoing),
3788 (modest_account_settings_dialog_set_account_name),
3789 (save_configuration): Load/Save the port number, and change it when the
3790 security combo changes, to suitable defaults.
3792 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3794 * src/modest-account-mgr.c:
3795 (modest_account_mgr_add_server_account): Set the security and secure-auth
3796 options, and add a comment saying that the other camel-specific options should be
3799 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3801 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3803 * src/modest-tny-account-store.c: (account_list_free),
3804 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3805 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3808 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3810 * src/modest-protocol-info.c:
3811 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3812 is required by our UI spec. Maybe something in our implementation will use this eventually.
3813 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3814 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3815 instead of the previous 0 placeholder.
3817 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3818 secure-auth settings.
3819 * src/modest-account-mgr-helpers.h:
3820 * src/modest-account-mgr-helpers.c:
3821 (modest_server_account_data_get_option_secure_auth),
3822 (modest_server_account_set_option_secure_auth),
3823 (modest_server_account_data_get_option_security),
3824 (modest_server_account_set_option_security): Added this API for getting and setting the security
3825 and secure-auth settings.
3827 * src/maemo/modest-account-settings-dialog.h:
3828 * src/maemo/modest-account-settings-dialog.c:
3829 (modest_account_settings_dialog_finalize), (check_data),
3830 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3831 about changing titles.
3832 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3833 (save_configuration): Save the security and secure-auth settings.
3835 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3836 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3838 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3840 * src/modest-defs.h:
3841 * src/modest-account-mgr.c:
3842 (modest_account_mgr_add_server_account):
3843 Added and used defines for the options key and value pair strings,
3844 that are used so far, though they do not seem to correspond to anything in our
3845 UI specs or ModestProtocol enum.
3847 * src/modest-account-mgr-helpers.h:
3848 * src/modest-account-mgr-helpers.c:
3849 (compare_option_strings_for_name),
3850 (modest_server_account_data_get_option_value),
3851 (modest_server_account_data_get_option_bool),
3852 (modest_account_mgr_get_server_account_option):
3853 Added helper functions for parsing the options GSList.
3855 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3857 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3858 display name is based on the supplied account name.
3859 * src/modest-account-mgr.c:
3860 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3861 with an inefficient, but good-enough, implementation.
3863 * src/maemo/easysetup/modest-easysetup-wizard.c:
3864 (create_page_account_details), (on_before_next), (create_account):
3865 Check for existing display names rather than (non-user-visible) account names, and just
3866 create and set a unique account name at the end.
3868 * src/maemo/modest-account-settings-dialog.c:
3869 (modest_account_settings_dialog_init),
3870 (modest_account_settings_dialog_set_account_name),
3871 (create_page_incoming): Show the display name, instead of the account name.
3872 (on_response): Do some (not all) extra checks, as in the UI spec.
3873 (save_configuration): Save the display name if it was changed.
3875 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3877 * po/en_GB.po: Added needed logical ID and translation.
3878 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3879 (init_view): Made the is-default column clicking work.
3881 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3884 * src/maemo/easysetup/Makefile.am:
3885 * src/maemo/easysetup/modest-easysetup-wizard.c:
3886 (modest_easysetup_wizard_dialog_init):
3887 * src/maemo/easysetup/provider-data-test.keyfile:
3888 * src/maemo/easysetup/provider-data.keyfile:
3889 Moved the provider data file to the new modest-providers-data package and used it from there.
3891 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3893 * src/modest-local-folder-info.c:
3894 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3895 N_() was already used on the static strings, but this just marks it for translation without
3896 using the translation.
3898 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3900 * src/maemo/modest-account-settings-dialog.c:
3901 (create_page_incoming),
3902 (modest_account_settings_dialog_set_account_name):
3903 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3904 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3905 I will do this if nobody else gets there first.
3907 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3909 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3910 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3911 save the security stuff.
3913 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3915 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3916 Set the email address and user fullname, which I now see must be
3919 * src/maemo/modest-account-settings-dialog.h:
3920 * src/maemo/modest-account-settings-dialog.c:
3922 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3923 leave-on-server and authentication.
3924 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3927 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3930 * src/maemo/modest-account-settings-dialog.c:
3931 * src/maemo/modest-account-settings-dialog.h:
3932 Most (but not all) of the widgets are now present as specified by the UI spec.
3933 No changes are yet saved, and some details are not properly shown yet.
3935 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3937 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3939 * src/maemo/Makefile.am:
3940 * src/maemo/modest-account-settings-dialog.c:
3941 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3942 an existing account. Doesn't do much yet.
3944 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3945 Open the accounts settings dialog when Edit is clicked.
3947 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3949 * src/maemo/easysetup/Makefile.am:
3950 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3952 * src/maemo/easysetup/modest-easysetup-wizard.c:
3953 (modest_easysetup_wizard_dialog_init):
3954 Try to get the source directory from the build system,
3955 instead of hard-coding "./" into the source code, when opening our local
3956 copies of the configuration files.
3957 But this still fails when opening the wizard from the Accounts window,
3958 maybe because the working directory seems to change at runtime.
3959 So the wizard will fail the second time unless you copy the files into their
3960 proper locations - see the stdout warnings for the paths.
3962 (create_page_account_details),(on_before_next):
3963 Check for existing non-server accounts instead of server accounts,
3964 so the default account name is useful again, and to prevent trying to
3967 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3968 Show the wizard when New is clicked.
3970 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3971 (init_view): Show the column headers, and show the columns that are
3972 specified in the UI specs. However, something in Maemo's GTK+ prevents
3973 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3974 change the default account. This is despite unsetting the special properties.
3976 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3978 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3979 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3980 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3981 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3982 to make that clearer.
3983 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3985 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3987 * src/maemo/modest-account-view-window.c:
3988 (modest_account_view_window_init),
3989 (modest_account_view_window_new):
3990 Use the same buttons as specified in the
3991 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3992 the existing widgets, which never had a chance of working.
3993 Put the ModestAccountView treeview in a scrolled window.
3994 Do not repeat the initialization in both _init() and _new().
3996 * src/widgets/modest-account-view.c: (update_account_view):
3997 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3998 this widget and window shows no accounts.
4000 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4002 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4004 * src/maemo/easysetup/modest-easysetup-wizard.c:
4005 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4006 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4007 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4010 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4011 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4012 accounts exist yet, as in the UI spec.
4014 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4016 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4018 * src/maemo/Makefile.am:
4019 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4020 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4021 New window for editing connection-specific smtp details.
4022 Not fully implemented.
4024 * src/maemo/modest-connection-specific-smtp-window.c:
4025 (modest_connection_specific_smtp_window_finalize) :
4026 unref the tree model.
4027 (on_button_edit): Show the edit window.
4029 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4031 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4034 * src/maemo/Makefile.am:
4035 * src/maemo/modest-connection-specific-smtp-window.c:
4036 * src/maemo/modest-connection-specific-smtp-window.h:
4037 New window for showing the list of connections, for connection-specific
4038 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4039 * src/maemo/easysetup/modest-easysetup-wizard.c:
4040 (create_page_custom_outgoing): Show the new window when the button is clicked.
4042 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4044 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4045 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4046 * src/maemo/modest-msg-edit-window.c:
4047 (modest_msg_edit_window_insert_image):
4048 * src/modest-conf.c: (modest_conf_key_escape):
4049 * src/modest-mail-operation.c:
4050 (modest_mail_operation_send_new_mail):
4051 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4052 (modest_ui_actions_on_new_account):
4053 * src/widgets/modest-attachment-view.c: (update_filename_request):
4054 * src/widgets/modest-mail-header-view.c:
4055 Corrected warnings that were breaking the build, by commenting out unused variables,
4056 and a function, and by including a header.
4058 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4060 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4061 so we can #ifdef around platform-specific code when necessary.
4062 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4063 to allow this to build for the GNOME platform too.
4065 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4067 * src/maemo/easysetup/modest-easysetup-wizard.c:
4068 Added util_increment_name() and used it in create_page_account_details()
4069 to make sure that the default account name is always a new name.
4071 (modest_easysetup_wizard_dialog_init),
4072 (set_default_custom_servernames): Some minor memory management fixes.
4074 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4078 * src/modest-runtime.c: (init_i18n): Restored the translation
4079 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4080 are defined in config.h, and the translations are installed.
4082 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4083 is defined for translation.
4085 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4087 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4089 * src/maemo/easysetup/modest-easysetup-wizard.c:
4090 (modest_easysetup_wizard_dialog_init):
4091 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4092 Use realistic paths (though they should use $prefix generically) to the
4093 mcc_mapping and provider-data.keyfile files which might work when they
4094 are installed by the future version of the operator-wizard package,
4095 and then fallback to paths in our source code, with an explanatory
4098 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4102 * src/maemo/Makefile.am:
4103 * src/maemo/easysetup/: Added files from the previously-exernal
4104 osso-modest-easysetup.
4105 * src/maemo/modest-main-window-ui.h:
4106 * src/modest-ui-actions.c:
4107 * src/modest-ui-actions.h:
4108 Added modest_ui_actions_on_new_account() as a signal handler for the
4109 New Account menu item. It shows the easysetup wizard.
4110 * po/en_GB.po: Added additional needed logical IDs and translations.