1 2007-05-24 Murray Cumming <murrayc@murrayc.com>
5 * src/maemo/Makefile.am:
6 * src/widgets/Makefile.am: Some dist fixes.
8 2007-05-24 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-connection-specific-smtp-window.c:
11 (on_button_edit): Make the code clearer, to prevent a double free.
13 2007-05-24 Murray Cumming <murrayc@murrayc.com>
15 * src/maemo/modest-account-settings-dialog.c:
16 (modest_account_settings_dialog_set_account_name),
17 Check the connection-specific smtp servers checkbox if there are any.
19 * src/maemo/modest-connection-specific-smtp-edit-window.c:
20 (modest_connection_specific_smtp_edit_window_init):
21 Start with a suitable port number.
23 * src/modest-account-mgr-helpers.h:
24 * src/modest-account-mgr-helpers.c: Added
25 modest_account_mgr_get_has_connection_specific_smtp().
27 (modest_account_mgr_set_connection_specific_smtp),
28 (modest_account_mgr_remove_connection_specific_smtp),
29 (modest_account_mgr_get_has_connection_specific_smtp),
30 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
31 connection-specific smtp server accounts in the account, rather than
32 the server account conf dir.
34 This fixes bug projects.maemo.org bug NB#58263 .
36 * src/modest-tny-account-store.c:
37 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
38 if there are no server accounts yet, to prevent an infinite loop when there
39 are no accounts. Document that one must be called before the other.
41 2007-05-24 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-account-mgr-helpers.c:
44 (modest_account_mgr_get_default_account): Make sure that at least
45 one account is always the default, if there are any enabled accounts.
46 This is just a sanity check that shouldn't be necessary.
48 * src/modest-account-mgr-priv.c:
49 (_modest_account_mgr_account_from_key): Unescape the conf key to
50 get the real account name. For instance, this is an issue if a space
51 was in the account name, which can happen because the account name
52 is generated from the display name.
53 (_modest_account_mgr_get_account_keyname): Always escape the
55 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
56 Unescape the conf keys to get the real account names.
58 For instance, previously the is-default radio button in the accounts
59 list was not checked for any accounts at first. This fixes that,
60 and might fix several similar bugs.
62 2007-05-23 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
65 Removed some debug printfs.
67 2007-05-23 Murray Cumming <murrayc@murrayc.com>
69 Modest on-disk outbox directories are now here, for instance:
70 $HOME/.modest/outboxes/<account-id-1>/outbox
71 $HOME/.modest/outboxes/<account-id-2>/outbox
73 $HOME/.modest/local-folders/outbox
74 so we can have a separate outbox for each account.
75 But they are shown as one outbox in the GtkTreeView, by using a
76 TnyMergeFolder in a ModestTnySimpleFolderStore.
79 * src/modest-tny-simple-folder-store.c:
80 * src/modest-tny-simple-folder-store.h:
81 Added ModestTnySimpleFolderStore, used to contain folders from
82 other folder stores, such as other accounts.
84 * src/modest-tny-outbox-account.h:
85 * src/modest-tny-outbox-account.c:
86 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
87 used for the per-account local outbox folders.
89 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
90 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
91 only use this (internally) now for the non-outbox local folders.
94 * src/modest-init.c: Added modest_init_one_local_folder(), for
95 setting up the directory structure for each local folder.
97 * src/modest-local-folder-info.c:
98 (modest_per_account_local_outbox_folder_info_get_maildir_path),
99 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
101 * src/modest-local-folder-info.h:
102 * src/modest-tny-account-store.c: (on_account_removed),
103 (on_account_changed), (create_per_account_local_outbox_folders),
104 (get_server_accounts), (modest_tny_account_store_get_accounts),
105 (modest_tny_account_store_get_tny_account_by_account),
106 (modest_tny_folder_store_is_virtual_local_folders):
108 * src/modest-tny-account.h:
109 * src/modest-tny-account.c:
110 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
111 to create an on-disk per-account local outbox folder for each
113 (create_per_account_local_outbox_folders): Create a local outbox folder
114 for each transport account.
115 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
116 for all local folders.
118 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
119 instead of using g_object_get/set() directly. It is clearer.
121 (modest_tny_folder_store_get_message_count),
122 (modest_tny_folder_store_get_local_size
123 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
124 because we now use these with non-acount folder stores.
126 (modest_tny_account_get_special_folder),
127 (modest_tny_account_new_from_server_account),
128 (modest_tny_account_new_from_account):
129 (recurse_folders): Adjust to the new outbox system.
131 * src/modest-tny-folder.h:
132 * src/modest-tny-folder.c:
133 (modest_tny_folder_is_local_folder),
134 (modest_tny_folder_get_local_folder_type),
135 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
137 * src/widgets/modest-main-window.h:
138 * src/maemo/modest-main-window.c: (create_details_widget),
139 (modest_main_window_set_contents_style): Show details for any folder store,
142 (modest_tny_folder_get_rules):
143 Remove the const. C does not support constness enough for this.
145 * src/modest-ui-actions.c:
146 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
147 make all outboxes appear as one, in the usual local-folders tree node.
149 (set_active_account_from_tny_account),
150 (modest_ui_actions_on_folder_selection_changed):
151 * src/widgets/modest-folder-view.c: (text_cell_data),
152 (icon_cell_data), (filter_row),
153 (add_account_folders_to_merged_folder),
154 (add_account_folders_to_simple_folder_store), (),
155 (get_cmp_rows_type_pos), (cmp_rows),
156 (modest_folder_view_set_account_id_of_visible_server_account):
157 Adjust to the new outbox system, using generic folder stores and folders
160 2007-05-23 Christian Kellner <ckellner@openismus.com>
162 * src/modest-mail-operation.c:
163 (modest_mail_operation_update_account):
164 Use info->max_size instead of unintialized local var [small
165 build fix]. (Added TODO to review that change since I don't
168 2007-05-23 Marcus Bauer <marcusb@openismus.com>
170 * libmodest-dbus-client/libmodest-dbus-client.c:
171 (libmodest_dbus_client_compose_mail): function added
172 * src/dbus_api/modest-dbus-api.h:
173 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
174 (on_compose_mail): Implementation of the SendAsMail functionality
176 2007-05-22 Murray Cumming <murrayc@murrayc.com>
178 * src/modest-account-mgr.c:
179 (modest_account_mgr_add_server_account): Set the secure-connection
180 conf key for transport accounts as well as store accounts. I don't know
181 why the if was there. For instance, this makes sure that we use SSL
182 for the gmail preset from the easysetup wizard.
184 2007-05-22 Murray Cumming <murrayc@murrayc.com>
186 * src/gnome/modest-main-window.c:
187 (on_account_store_connecting_finished), (connect_signals):
188 * src/maemo/modest-main-window.c:
189 (on_account_store_connecting_finished), (connect_signals),
190 (modest_main_window_new):
191 Handle TnyAccountStore::connecting-finished instead of
192 TnyDevice::connection-changed, because we cannot actually perform
193 operations on accounts until TnyAccountStore has itself responded to
194 the TnyDevice::connection-changed signal. This prevents a GError from
196 Do not try to update at startup, because we (at least on scratchbox)
197 already do an update at startup when the device goes online.
198 This prevents a GError from tinymail.
199 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
200 Added TODO about stopping simultaneous operations.
202 2007-05-21 Murray Cumming <murrayc@murrayc.com>
204 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
205 * src/modest-mail-operation-queue.c:
206 (modest_mail_operation_queue_remove):
207 * src/modest-tny-account-store.c: When GErrors happen, give more clues
208 about where they happened.
210 2007-05-21 Murray Cumming <murrayc@murrayc.com>
212 * src/modest-ui-actions.c:
213 (modest_ui_actions_on_password_requested): Make sure that the remember
214 output parameter is always TRUE.
216 2007-05-21 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
219 Show a OK/Cancel dialog if the error is a question, though we still do not
220 know anything more about what we are asking the user.
221 * src/widgets/modest-folder-view.c: (on_drag_data_received):
222 Fix an uninitialized variable (helper). This is a logic error, however.
224 2007-05-21 Christian Kellner <ckellner@openismus.com>
226 * src/modest-search.h:
227 Correct bit shifting in the ModestSearchFlags enum.
229 2007-05-21 Murray Cumming <murrayc@murrayc.com>
231 * src/modest-tny-account.c:
232 (modest_tny_account_new_from_server_account): Do not use the lsub and
233 check-all hard-coded IMAP options when using POP.
235 2007-05-21 Murray Cumming <murrayc@murrayc.com>
237 * src/modest-tny-account.c:
238 (modest_tny_account_new_from_server_account):
239 Use NULL for the secure-auth method for POP when Password auth has been
240 specified by the user, as we already do for IMAP. "auth=Login" causes
241 an error from camel or the server.
243 2007-05-17 Murray Cumming <murrayc@murrayc.com>
245 * src/maemo/modest-account-settings-dialog.c:
246 (create_page_account_details),
247 (modest_account_settings_dialog_set_account_name):
248 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
249 for the leave-on-server checkbox, rathr than just the checkbox, when
250 the protocol is not POP.
252 2007-05-17 Murray Cumming <murrayc@murrayc.com>
254 * src/widgets/modest-account-view.c:
255 * src/widgets/modest-account-view.h:
256 Added modest_account_view_select_account() which will be useful later
257 to asynchronously re-select the edited account.
259 2007-05-17 Murray Cumming <murrayc@murrayc.com>
261 * src/maemo/modest-account-settings-dialog.c:
262 (modest_account_settings_dialog_set_account_name):
263 Automatically choose the port numbers based on the secure authentication
264 methods, if they have not been chosen before.
265 This fixes projects.maemo.org bug NB#56273 .
267 2007-05-17 Murray Cumming <murrayc@murrayc.com>
269 * src/maemo/modest-main-window-ui.h:
270 * src/modest-ui-actions.c:
271 * src/modest-ui-actions.h:
272 Connect the Tools/SMTP Servers menu item to
273 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
274 SMTP servers dialog, as in the UI specification and saves changes when it
275 is closed. This fixed projects.maemo.org bug NB#56305 .
277 2007-05-17 Murray Cumming <murrayc@murrayc.com>
279 * src/maemo/modest-connection-specific-smtp-window.c:
280 (modest_connection_specific_smtp_window_init):
281 Use gtk_window_set_default_size() to make this window big enough, so
282 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
284 2007-05-17 Murray Cumming <murrayc@murrayc.com>
286 * src/maemo/modest-connection-specific-smtp-edit-window.h:
287 * src/maemo/modest-connection-specific-smtp-edit-window.c:
288 (modest_connection_specific_smtp_edit_window_init),
289 Do not try to connect to a combobox signal before the combobox exists.
290 This fixes the cras in projects.maemo.org bug NB#56288 .
291 (modest_connection_specific_smtp_edit_window_get_settings):
292 Remove the server_account_name parameter which was being checked for NULL
293 though it was not used.
295 * src/maemo/modest-connection-specific-smtp-window.c:
296 (modest_connection_specific_smtp_window_fill_with_connections),
297 (on_button_edit), (modest_connection_specific_smtp_window_init):
298 Correct the number of treemodel columns to prevent a warning.
299 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
300 libconic does not work.
302 2007-05-16 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-tny-account.c:
305 (modest_tny_account_new_from_server_account):
306 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
307 SMTP when "None" was chosen by the user. However, with my SMTP server that
308 does not support ANONYMOUS, the emails do not leave the Outbox and I see
311 2007-05-16 Murray Cumming <murrayc@murrayc.com>
313 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
314 to explain the memory management issue with the ID in the ModestPair.
316 * src/gnome/modest-account-assistant.c: (add_receiving_page),
317 (add_sending_page), (modest_account_assistant_finalize):
318 * src/gnome/modest-gnome-global-settings-dialog.c:
319 (create_updating_page), (create_composing_page):
320 * src/gnome/modest-msg-edit-window.c: (get_transports),
321 (init_window), (modest_msg_edit_window_finalize),
322 (modest_msg_edit_window_get_msg_data):
323 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
324 * src/gnome/modest-transport-widget.c:
325 (modest_transport_widget_finalize), (smtp_configuration):
326 * src/maemo/modest-maemo-global-settings-dialog.c:
327 (create_updating_page), (create_composing_page):
328 * src/maemo/modest-msg-edit-window.c: (get_transports),
329 (init_window), (modest_msg_edit_window_finalize),
330 (modest_msg_edit_window_get_msg_data),
331 (modest_msg_edit_window_free_msg_data):
332 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
333 (modest_store_widget_finalize):
334 * src/maemo/modest-transport-widget.c:
335 (modest_transport_widget_finalize), (smtp_configuration):
336 * src/modest-main.c: (send_mail):
337 * src/widgets/modest-combo-box.h:
338 * src/widgets/modest-global-settings-dialog-priv.h:
339 * src/widgets/modest-global-settings-dialog.c:
340 (modest_global_settings_dialog_finalize):
341 * src/widgets/modest-msg-edit-window.h:
342 Whenever using modest_combo_box_new(), keep the ModestPairList alive
343 as long as the combo box, to prevent use of freed memory for the ID.
345 2007-05-15 Murray Cumming <murrayc@murrayc.com>
347 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
348 get_accounts(), to make this clearer. Do not check for the enabled gconf
349 key, because we do not use this for server accounts (at least, not yet).
350 This allows us to send email again.
352 2007-05-15 Murray Cumming <murrayc@murrayc.com>
354 * src/maemo/modest-platform.c:
355 (on_modest_conf_update_interval_changed), (modest_platform_init):
356 Only respond to this particular key change. All these strcmp()s cannot be
359 2007-05-15 Murray Cumming <murrayc@murrayc.com>
361 * src/maemo/modest-maemo-global-settings-dialog.c:
362 (current_connection): Prevent a crash in scratchbox when
363 ny_maemo_conic_device_get_current_iap_id() returns NULL.
364 * src/maemo/modest-platform.c:
365 (on_modest_conf_update_interval_changed), (modest_platform_init):
366 Get the update interval from gconf and reset it when the gconf key changes.
368 2007-05-15 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-protocol-info.c:
371 * src/modest-protocol-info.h: Adde enum-specific get functions,
372 instead of using a ModestProtocolType enum parameter.
374 * src/gnome/modest-account-assistant.c:
375 * src/gnome/modest-store-widget.c:
376 * src/gnome/modest-store-widget.h:
377 * src/gnome/modest-transport-widget.c:
378 * src/gnome/modest-transport-widget.h:
379 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
380 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
381 * src/maemo/easysetup/modest-easysetup-wizard.c:
382 * src/maemo/modest-account-settings-dialog.c:
383 * src/maemo/modest-account-settings-dialog.h:
384 * src/maemo/modest-store-widget.c:
385 * src/maemo/modest-store-widget.h:
386 * src/maemo/modest-transport-widget.c:
387 * src/maemo/modest-transport-widget.h:
388 * src/modest-account-mgr-helpers.c:
389 * src/modest-account-mgr-helpers.h:
390 * src/modest-account-mgr.c:
391 * src/modest-account-mgr.h:
392 * src/modest-tny-account.c:
393 * src/modest-tny-folder.c:
394 * src/widgets/modest-account-view.c:
395 * src/widgets/modest-retrieve-combo-box.c:
396 * src/widgets/modest-retrieve-combo-box.h:
397 * src/widgets/modest-secureauth-combo-box.c:
398 * src/widgets/modest-serversecurity-combo-box.c:
399 * src/widgets/modest-serversecurity-combo-box.h:
400 * tests/check_account-mgr.c:
401 Use the specific functions, and use the re-renamed enum values for GNOME too.
403 2007-05-15 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
407 so we can get the second based on the first.
409 * src/maemo/modest-account-settings-dialog.h:
410 * src/maemo/modest-account-settings-dialog.c:
411 Added get_supported_secure_authentication_methods(), though it is mostly
412 commented-out for now until the necessary API is committed to tinymail.
413 (modest_account_settings_dialog_set_account_name),
414 (save_configuration): Request the supported authentication methods from the
415 server, so we can choose a working method.
417 * src/modest-tny-account-store.h:
418 * src/modest-tny-account-store.c:
419 (modest_tny_account_store_get_session): Rename from
420 tny_account_store_get_session().
422 2007-05-14 Murray Cumming <murrayc@murrayc.com>
424 * src/modest-protocol-info.h: Split the ModestProtocol enum
425 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
426 There was no need to have these unrelated values in one enum.
428 * src/: many files: Adapted to changed enum. This makes the code a bit
429 clearer, and the compiler could catch some errors.
431 2007-05-14 Murray Cumming <murrayc@murrayc.com>
433 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
434 Show the detailed internal camel error message when an error happens
435 during the configuration, so that our testers can give us more clues.
436 For instance, in projects.maemo.org bug NB#56910 .
438 2007-05-14 Murray Cumming <murrayc@murrayc.com>
440 * src/modest-tny-account.c:
441 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
442 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
444 2007-05-14 Murray Cumming <murrayc@murrayc.com>
446 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
447 * src/maemo/modest-account-settings-dialog.c:
448 (modest_account_settings_dialog_set_account_name),
449 (save_configuration): For the incoming secure authentication checkbox,
450 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
451 the UI specification. PLAIN does not seem to be supported for most IMAP
452 servers anyway, and I am not sure what it would mean.
453 However, we probably need to discover which of the secure-authentication
454 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
455 * src/modest-account-mgr-helpers.c:
456 (modest_account_mgr_get_server_account_data):
458 * src/modest-tny-account.c:
459 (modest_tny_account_new_from_server_account):
460 Use tny_account_set_mech() to set secure-authentication methods,
461 with some special-casing for IMAP, based on my observations of how
464 * src/modest-account-mgr-helpers.h:
465 * src/modest-account-mgr.c:
466 * src/modest-defs.h: Comment that the URI is only used for local folders.
468 2007-05-11 Murray Cumming <murrayc@murrayc.com>
470 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
471 parameter const, just to be neat.
472 * src/modest-text-utils.c: (modest_text_utils_inline):
473 End g_strconcat() with NULL, as its documentation says. This is almost
474 certainly the cause of my crash at startup on the device. Interestingly,
475 valgrind doesn't tell us about these errors.
477 2007-05-11 Murray Cumming <murrayc@murrayc.com>
479 * scripts/build-packages: Added more precise comments about how to use
480 this script, though I still get this error:
481 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
482 error building tinymail
484 2007-05-11 Murray Cumming <murrayc@murrayc.com>
486 * src/maemo/modest-main-window.c: (on_account_update):
487 Very slight cleanup, hoping to make it simpler to discover what causes
488 a crash here sometimes.
490 * src/modest-tny-account.c:
491 (modest_tny_account_new_from_server_account): Set the port. Added
492 comments about the options and a TODO comment because I need to find out
493 how to specify the secure authentication method.
495 2007-05-11 Marcus Bauer <marcusb@openismus.com>
497 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
498 changed CFlags paths form modest to libmodest
500 2007-05-10 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-account-mgr-helpers.c:
503 (modest_account_mgr_get_server_account_data),
504 (modest_account_mgr_free_server_account_data):
505 * src/modest-account-mgr-helpers.h:
506 * src/modest-account-mgr.c:
507 (modest_account_mgr_add_server_account):
509 * src/modest-tny-account.c:
510 (modest_tny_account_new_from_server_account):
511 Determine the options for tny_camel_account_add_option() here,
512 based on the settings, rather than storing them directly in gconf.
514 2007-05-10 Murray Cumming <murrayc@murrayc.com>
516 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
517 Show a more friendly error dialog now that we expect (from the tinymail
518 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
520 2007-05-10 Murray Cumming <murrayc@murrayc.com>
522 * src/maemo/modest-main-window.c: (on_account_update): Check that
523 account_name is not NULL, to prevent a crash at startup that I am
524 seeing on the N800. I do wonder why it is NULL.
526 * src/maemo/easysetup/modest-easysetup-wizard.c:
527 (create_page_user_details):
528 * src/maemo/modest-account-settings-dialog.c:
529 (create_page_user_details), (create_page_outgoing):
530 * src/maemo/modest-connection-specific-smtp-edit-window.c:
531 (modest_connection_specific_smtp_edit_window_init):
532 * src/modest-ui-actions.c:
533 (modest_ui_actions_on_password_requested):
534 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
535 might do something useful with the on-screen keyboard.
537 2007-05-10 Murray Cumming <murrayc@murrayc.com>
539 * src/maemo/modest-main-window.c: (on_account_update):
540 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
541 NULL, to avoid lots of warnings. However, it probably should not be NULL.
543 2007-05-09 Murray Cumming <murrayc@murrayc.com>
545 * src/modest-tny-account-store.c: (on_account_changed):
546 Correct the signature of this signal handler.
548 2007-05-09 Murray Cumming <murrayc@murrayc.com>
550 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
551 Show a HildonNote instead of a GtkDialog for Maemo.
553 2007-05-09 Murray Cumming <murrayc@murrayc.com>
555 * src/widgets/modest-account-view.h:
556 * src/widgets/modest-account-view.c: (on_account_changed),
557 (on_account_removed). Added a boolean flag, set/unset by
558 modest_account_view_block_conf_updates(),
559 modest_account_view_unblock_conf_updates() to prevent unnecessary
560 updates, but this is not very useful because the gconf notifications are
561 so delays (maybe only on Maemo Bora).
562 So auto-updating is turned off, and these functions do an explicit
563 update when necessary.
564 However, something else is still doing too much work when adding/removing
565 accounts, probably in another part of the application.
567 * src/maemo/modest-account-view-window.c:
568 (on_delete_button_clicked), (on_edit_button_clicked),
569 (on_new_button_clicked): Use the new functions.
571 2007-05-09 Murray Cumming <murrayc@murrayc.com>
573 * src/modest-account-mgr-helpers.c:
574 (modest_account_mgr_set_first_account_as_default):
575 Sort the list of names alphabetically-by-title, so we choose the first one
577 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
578 alphabetically by the title.
580 This fixes projects.maemo.org bug NB#56418 .
582 * src/modest-account-mgr-priv.c:
583 (_modest_account_mgr_account_from_key):
584 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
585 avoid a valgrind error, and possible random behaviour.
587 2007-05-09 Murray Cumming <murrayc@murrayc.com>
589 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
590 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
591 tinymail documentation to say that this can be expected.
592 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
593 pretty, and should not happen, but I would prefer to know when it does.
595 2007-05-09 Murray Cumming <murrayc@murrayc.com>
597 * configure.ac: When using the older hildon version, probably on Bora,
598 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
600 * src/widgets/modest-attachment-view.c:
601 (modest_attachment_view_set_part_default): Initialize variables, to fix the
604 2007-05-09 Marcus Bauer <marcusb@openismus.com>
606 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
607 Implemented the prototype. Can be tested with
608 tests/dbus_api/test_open_message:
610 2007-05-08 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-tny-account-store.c:
613 (modest_tny_account_store_instance_init), (get_password):
614 * src/modest-ui-actions.c:
615 (modest_ui_actions_on_password_requested):
616 Do not store the password in gconf, because this function is called
617 for non-remembered passwords. Actually use the cached (in the hash map)
618 password instead of releasing it.
619 The password will now not be remembered if it is asked via the protected
620 password dialog, as per the UI spec.
622 2007-05-08 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-account-mgr-helpers.h:
626 * src/modest-account-mgr-helpers.c:
627 Added modest_server_account_get_username_has_succeeded(),
628 modest_server_account_set_username_has_succeeded().
629 (modest_server_account_set_username),
630 Reset the has-succeeded flag if the username changes.
632 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
633 * src/maemo/modest-connection-specific-smtp-window.c:
634 (modest_connection_specific_smtp_window_save_server_accounts):
635 Use modest_server_account_set_username() instead of using
636 modest_conf_set_string() directly, so that the has-succeeded flag is always
639 * src/modest-ui-actions.c:
640 (modest_ui_actions_on_password_requested): Dim the username entry if
641 the username has ever worked, as per the UI spec.
643 2007-05-08 Murray Cumming <murrayc@murrayc.com>
645 * src/modest-tny-account-store.c: (get_password):
646 * src/modest-ui-actions.c:
647 (modest_ui_actions_on_password_requested):
648 Allow the username to be changed too, though there is more work to
649 be done on exactly how this behaves.
651 2007-05-08 Murray Cumming <murrayc@murrayc.com>
653 * src/modest-account-mgr-helpers.h:
654 * src/modest-account-mgr-helpers.c:
655 Added modest_account_mgr_get_display_name(),
656 modest_server_account_get_username(),
657 modest_server_account_set_username(),
658 modest_server_account_set_password(),
659 modest_server_account_get_hostname() functions so we do not need to
660 use the conf API directly.
662 * src/maemo/modest-main-window.c: (connect_signals):
663 Actually connect ot the ModestAccountStore::request-password signal,
664 so that we show the dialog when the password is requested by Tinymail,
665 for isntance if it is empty.
667 * src/modest-marshal.list:
668 * src/modest-tny-account-store.c:
669 (modest_tny_account_store_class_init), (get_password),
670 (modest_tny_account_store_alert):
671 * src/modest-tny-account-store.h:
672 * src/modest-ui-actions.h:
673 * src/modest-ui-actions.c:
674 (modest_ui_actions_on_password_requested):
675 Change the signal parameters, so it is obvious that we are providing
676 the non human-readable server name, and receiving both the username
677 and password, though changing of the username is not yet implemented.
678 Change the dialog UI to match the Maemo UI specifications, with #idfefing
679 for the GNOME version.
681 This should fix the projects.maemo.org bug NB#56209, though it does not
682 work on Bora, because the gconf_client_get() for the password fails
683 immediately after we save it with gconf_client_set().
685 2007-05-08 Murray Cumming <murrayc@murrayc.com>
688 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
689 caused an undefined symbol error:
690 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
692 2007-05-08 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-tny-account-store.c:
695 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
696 using a GError instead of a string message, so we can translate it in
699 2007-05-08 Murray Cumming <murrayc@murrayc.com>
701 * src/maemo/modest-address-book.c:
702 (modest_address_book_check_names):
703 * src/maemo/modest-msg-view-window.c:
704 (modest_msg_view_window_clipboard_owner_change):
705 * src/modest-init.c: (modest_init_init_ui):
706 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
707 (update_folders_cb), (modest_mail_operation_update_account):
708 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
709 (modest_ui_actions_on_msg_attachment_clicked),
710 (modest_ui_actions_on_msg_recpt_activated):
711 * src/widgets/modest-header-view.c: (drag_data_get_cb):
712 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
713 (modest_msg_view_search_next):
714 * src/widgets/modest-recpt-editor.c:
715 (modest_recpt_editor_on_button_release_event),
716 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
717 g_message(). At this point we should only be seeing interesting errors on
718 stdout. Debugging messages could be #ifdefed-out if they are still useful.
720 2007-05-07 Murray Cumming <murrayc@murrayc.com>
722 (modest_wizard_dialog_force_title_update):
723 * src/maemo/easysetup/modest-wizard-dialog.h:
724 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
725 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
726 can update the title when appropriate. Otherwise the title is wrong if the
727 pages are added after adding the notebook to the dialog.
728 This must be a problem in HildonWizardDialog too.
729 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
731 * src/maemo/easysetup/modest-easysetup-wizard.c:
732 (create_subsequent_customsetup_pages),
733 (create_subsequent_easysetup_pages):
734 Call modest_wizard_dialog_force_title_update() so that the title is
735 correct even with GTK+ < 2.10.
736 This fixes projects.maemo.org bug NB#56145 .
738 2007-05-07 Murray Cumming <murrayc@murrayc.com>
740 * src/maemo/modest-platform.c:
741 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
742 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
745 2007-05-07 Murray Cumming <murrayc@murrayc.com>
747 * src/widgets/modest-window.h:
748 * src/widgets/modest-window.c: Added a save_state_func vfunc,
749 and modest_window_save_state(), which invokes it.
751 * src/widgets/modest-window-mgr.h:
752 * src/widgets/modest-window-mgr.c:
753 Added modest_window_mgr_save_state_for_all_windows(), which calls
754 the save_state vfunc on all registered windows, if implemented.
756 * src/gnome/modest-msg-edit-window.c:
757 * src/gnome/modest-msg-view-window.c:
758 * src/maemo/modest-msg-edit-window.c:
759 * src/maemo/modest-msg-view-window.c:
760 * src/maemo/modest-main-window.c:
761 Specify the existing save_settings functions as implementations of
762 ModestWindow::save_state_func().
764 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
765 Call modest_window_mgr_save_state_for_all_windows(). This happens before
766 enabling hibernation, for instance.
768 We may need to do the same thing for restoring settings.
771 2007-05-07 Murray Cumming <murrayc@murrayc.com>
773 * src/widgets/modest-window-mgr.c:
774 * src/widgets/modest-window-mgr.h:
775 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
776 modest_window_mgr_get_hibernation_is_prevented().
778 * src/maemo/modest-main-window.c:
779 (on_hildon_program_is_topmost_notify): Prevent hibernation
780 (possible when the application goes to the background in the WM),
781 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
783 * src/maemo/easysetup/modest-easysetup-wizard.c:
784 (modest_easysetup_wizard_dialog_init):
785 * src/maemo/modest-account-settings-dialog.c:
786 (modest_account_settings_dialog_init):
787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
788 (modest_connection_specific_smtp_edit_window_init):
789 * src/maemo/modest-connection-specific-smtp-window.c:
790 (modest_connection_specific_smtp_window_init):
791 * src/maemo/modest-signature-editor-dialog.c:
792 (modest_signature_editor_dialog_init):
793 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
794 prevent hibernation while any of these account settings dialogs are open.
796 2007-05-04 Murray Cumming <murrayc@murrayc.com>
798 * src/maemo/Makefile.am:
799 * src/maemo/modest-osso-state-saving.c:
800 * src/maemo/modest-osso-state-saving.h: Added
801 modest_osso_load_state() and modest_osso_save_state() though they do
802 nothing now. They should iterate through all the open windows and load/save
804 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
805 save state when closing.
807 * src/maemo/modest-main-window.c:
808 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
809 Add a notification handler for the HildonProgram::is-topmost property,
810 so we can allow hibernation when the application goes into the background.
811 But we still need to detect when the accounts setup windows are open so
812 we can stop hibernation when they are open.
813 To do this, I also added the main window the HildonProgram. This might have
814 other side-effects/benefits, and should maybe be done for other windows.
816 * src/maemo/modest-osso-autosave-callbacks.h:
817 * src/maemo/modest-osso-autosave-callbacks.c:
818 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
819 though it does not do anything yet, and we might never need this to do
820 anything. For instance, we already save drafts.
822 * src/maemo/modest-platform.c: (modest_platform_init):
823 Specify the libosso auto-save callback.
825 2007-05-03 Murray Cumming <murrayc@murrayc.com>
827 * src/maemo/modest-platform.c:
828 (modest_platform_set_update_interval):
829 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
830 aparently stays valid between application instances, so we can use this
831 to remove and reset it later. According to a maemo-developers email from
834 2007-05-03 Murray Cumming <murrayc@murrayc.com>
836 * configure.ac: Depend on libalarm for Maemo.
838 * src/dbus_api/modest-dbus-api.h:
839 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
840 (on_send_receive), (modest_dbus_req_handler):
841 Handle a SEND_RECEIVE D-Bus method.
843 * libmodest-dbus-client/libmodest-dbus-client.c:
844 (libmodest_dbus_client_send_and_receive):
845 * libmodest-dbus-client/libmodest-dbus-client.h:
846 Add C convenience functions for calling the new D-Bus method.
848 * src/modest-platform.h:
849 * src/gnome/modest-platform.c:
850 * src/maemo/modest-platform.c:
851 Added modest_platform_set_update_interval(), which uses the
853 (modest_platform_init),
854 Call modest_platform_set_update_interval(), using a hard-coded
855 interval for now (until the global settings dialog is implemented),
856 though I am not sure that this makes sense yet.
858 2007-05-02 Murray Cumming <murrayc@murrayc.com>
860 * src/dbus_api/modest-dbus-callbacks.c:
861 (modest_osso_cb_hw_state_handler):
862 * src/dbus_api/modest-dbus-callbacks.h:
863 * src/maemo/modest-platform.c: (modest_platform_init):
864 Registered (empty) callbacks for the osso hardware state D-Bus signals,
865 in case this has some effect on the ability for Maemo to ping the
868 2007-05-02 Murray Cumming <murrayc@murrayc.com>
870 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
871 Comment out an if() that checks a gchar for < 0, causing a build-breaking
872 warning. It is probably a logic error, but I need to fix the build.
874 2007-05-02 Murray Cumming <murrayc@murrayc.com>
876 * src/modest-account-mgr.h:
877 * src/modest-account-mgr.c:
878 (modest_account_mgr_account_names): Add a gboolean enabled_only
879 parameter, so we can get lists of onlt the enabled accounts.
881 (modest_account_mgr_add_account),,
882 (modest_account_mgr_account_with_display_name_exists):
883 * src/maemo/modest-msg-edit-window.c: (get_transports):
884 * src/modest-account-mgr-helpers.c:
885 (modest_account_mgr_set_first_account_as_default):
886 * src/modest-init.c: (init_default_account_maybe):
887 * src/modest-tny-account-store.c: (get_accounts):
888 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
889 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
890 * tests/check_account-mgr.c: (START_TEST):
891 Provide the extra parameter, as appropriate.
893 * src/widgets/modest-account-view.c: (update_account_view):
894 Do not show disabled accounts (meaning that there is no way to
895 enable/disable accounts in the UI (the feature is not in our UI
896 specification), so we can use this internally only to mark unfinished
897 or temporary account data.
899 * src/maemo/easysetup/modest-easysetup-wizard.c:
900 (create_account): Add boolean enable parameter, so we can specify FALSE
901 to create the temporary account.
902 (on_button_edit_advanced_settings): Create the temporary account as disabled.
903 (on_before_next): When finishing, when there is a temporary account, just
905 Also, use a timeout to delay the showing of the dialog until gconf is likely
906 to return correct information, due to a maemo gconf bug that is fixed in
907 osso 1.1, but not yet in Bora.
908 However, the dialog stays on screen after it is destroyed.
910 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
911 for invalid data when cancelling. Use a hildon note instead of a dialog
912 to complain about invalid data. Do not show the account-saved note if the
913 account is disabled (a temporary account that will not really be saved for use
916 2007-04-30 Murray Cumming <murrayc@murrayc.com>
918 * src/modest-account-mgr-helpers.h:
919 * src/modest-account-mgr-helpers.c:
920 Added modest_account_mgr_unset_default_account(),
921 Added modest_account_mgr_set_first_account_as_default().
923 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
924 If it was the default account, unset the default account name.
926 * src/maemo/modest-account-view-window.c:
927 (on_delete_button_clicked): If it was the default account,
928 set the first remaining account as the default instead.
930 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
931 a NULL account or a NULL default account, to prevent a crash. This should
932 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
935 2007-04-30 Murray Cumming <murrayc@murrayc.com>
937 * src/widgets/modest-recpt-editor.c:
938 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
939 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
940 TODO comment for this. This fixes the build.
942 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
943 be the best place for it. This will in future update all auto-update accounts,
944 rather than just the current/default account, when that gconf key exists.
945 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
946 if there are no accounts, before calling do_send_receive().
947 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
949 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
950 * src/maemo/modest-main-window-ui.h:
951 * src/maemo/modest-main-window.c: (on_connection_changed),
952 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
953 directly, becaue the signal handler does more.
955 2007-04-30 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-account-mgr-helpers.c:
958 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
959 for the case that the account does not exist.
961 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
962 (equivalent to the modest account name) rather than the tinymail account name
963 (equivalent to the modest account title - human readable) to get the account data.
964 Check for null account data to prevent the crash, and add a TODO comment saying that
965 this needs fixing because it is using the server account name instead of the account name.
967 2007-04-29 Murray Cumming <murrayc@murrayc.com>
969 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
970 * src/maemo/modest-account-settings-dialog.c: (show_error),
972 Use hildon_note_new_information() for informative and error messages,
973 which seems to be expected for Maemo applications (no documentation that I know of
974 says this). I am surprised that there is no distinction between info and error
977 2007-04-29 Murray Cumming <murrayc@murrayc.com>
979 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
980 it is easy to find where this is used.
982 * src/maemo/easysetup/modest-easysetup-wizard.c:
983 (create_page_welcome), (create_page_account_details),
984 (create_page_user_details), (create_page_complete_easysetup),
985 (create_page_custom_incoming), (create_page_custom_outgoing),
986 (create_page_complete_custom):
987 * src/maemo/modest-account-settings-dialog.c:
988 (create_page_account_details), (create_page_user_details),
989 (create_page_incoming), (create_page_outgoing):
990 * src/maemo/modest-account-view-window.c: (window_vbox_new):
991 * src/maemo/modest-connection-specific-smtp-edit-window.c:
992 (modest_connection_specific_smtp_edit_window_init):
993 * src/maemo/modest-connection-specific-smtp-window.c:
994 (modest_connection_specific_smtp_window_init):
995 * src/maemo/modest-signature-editor-dialog.c:
996 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
997 and scrolling policy as per the Email Application Layout Guide, if I have
1000 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1002 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1003 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1004 which were empty, because these vfuncs have been removed from TnyAccountStore.
1005 This fixes the build.
1007 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1009 * src/maemo/modest-main-window.c:
1010 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1011 showing/hiding it. Added TODO because it probably should not be NULL.
1012 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1013 because unnecessary g_warnings() make degugging difficult.
1015 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1017 * src/maemo/modest-msg-edit-window.c:
1018 (modest_msg_edit_window_select_color),
1019 (modest_msg_edit_window_select_background_color): 2 const corrections and
1020 moving 2 #endifs before closing brackets, to fix the build.
1022 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1024 * src/maemo/easysetup/modest-easysetup-wizard.h:
1025 * src/maemo/easysetup/modest-easysetup-wizard.c:
1026 (modest_easysetup_wizard_dialog_finalize),
1027 (on_button_edit_advanced_settings), (create_page_complete_custom),
1028 (on_response), (create_account):
1029 Implement the Advanced Settings edit button, by saving the account information,
1030 for the Advanded Settings dialog to use directly from gconf, and removing it
1031 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1032 Bug #5533 in the projects.maemo.org bugzilla.
1034 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1036 * src/maemo/modest-msg-view-window.c:
1037 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1038 when opening a message window.
1040 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1042 * src/maemo/easysetup/modest-easysetup-wizard.c:
1043 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1046 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1047 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1048 gconf settings. I probably added more checks than necessary, but that is safer.
1050 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1051 variable to fix the build, but this seems to be used when it is still NULL.
1053 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1055 * src/modest-platform.h:
1056 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1057 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1058 * src/modest-main.c: Implement this function so we can avoid using
1059 maemo-specific API from cross-platform code.
1061 * src/modest-tny-account-store.c:
1062 (get_smtp_specific_transport_account_for_open_connection):
1063 * src/modest-ui-actions.c: (check_for_connection),
1064 (modest_ui_actions_on_item_not_found):
1065 Use modest_platform_connect_and_wait() and put #idefs around other
1066 maemo-specific code, because only maemo currently has a way to
1067 identify connection names.
1069 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-tny-account-store.h:
1072 * src/modest-tny-account-store.c:
1073 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1074 the connection-specific SMTP server settings in the configuration.
1076 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1078 * src/maemo/modest-main-window.c: (on_connection_changed),
1080 * src/modest-main.c: (main), (start_ui), (send_mail):
1081 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1082 that is what is intended.
1084 * src/modest-ui-actions.c: (action_send), (action_receive),
1085 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1086 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1087 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1088 SMTP server is used when it is specified.
1090 (modest_ui_actions_on_send_receive):
1091 Check that a connection is open before proceeding.
1092 Receive and then send, instead of vice-versa, as per the specification.
1094 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1096 * src/modest-mail-operation.c:
1097 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1098 though I guess it should be something other than NULL.
1100 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1102 * src/maemo/easysetup/modest-easysetup-wizard.c:
1103 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1104 combo twice, to avoid an g_warning and to make it visible again.
1105 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1106 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1107 (already intended) dereference when detaching, because we then recreate the menu.
1108 But I am not sure why the warning was happening, and it is possible that this is a memory
1111 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1113 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1114 and uri_parse_mailto() utility functions.
1115 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1117 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1119 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1121 * src/dbus_api/modest-dbus-api.h:
1122 * src/dbus_api/modest-dbus-callbacks.c:
1123 Use an idle callback to execute the modest code in the application's own thread.
1124 Remove the helloworld example method.
1125 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1126 parsed, and the open-message method is not implemented because this is not yet implemented in
1128 * libmodest-dbus-client/libmodest-dbus-client.c:
1129 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1130 (libmodest_dbus_client_open_message):
1131 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1133 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1134 body without crashing.
1136 * tests/dbus_api/Makefile.am:
1137 * tests/dbus_api/test_mail_to.c:
1138 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1140 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1142 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1143 Added file to fix the build. Sorry.
1145 * src/dbus_api/Makefile.am:
1146 * src/dbus_api/modest-dbus-api.h:
1147 * src/dbus_api/modest-dbus-callbacks.h:
1148 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1149 (modest_dbus_req_handler):
1150 Put constants in a separate header so it can be reused by the
1151 client library, without duplication
1153 * libmodest-dbus-client/Makefile.am:
1154 * libmodest-dbus-client/libmodest-dbus-client.c:
1155 (libmodest_dbus_client_call_helloworld),
1156 (libmodfest_dbus_client_send_mail),
1157 (libmodfest_dbus_client_mailto),
1158 (libmodfest_dbus_client_open_message):
1159 * libmodest-dbus-client/libmodest-dbus-client.h:
1160 (Partly) Implement a send_mail D-Bus method.
1162 * tests/dbus_api/Makefile.am:
1163 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1164 the send_email D-Bus method.
1166 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1170 * libmodest-dbus-client/Makefile.am:
1171 * libmodest-dbus-client/libmodest-dbus-client.c:
1172 * libmodest-dbus-client/libmodest-dbus-client.h:
1173 * tests/dbus_api/Makefile.am:
1174 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1175 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1177 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1179 * src/maemo/easysetup/modest-easysetup-wizard.c:
1180 (create_page_account_details):
1181 * src/maemo/modest-account-settings-dialog.c:
1182 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1183 widgets, because this might not be the default in future versions of the Maemo GTK+.
1184 However, I can not not get capitalization to work even in a simple test case.
1186 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1188 * src/maemo/easysetup/modest-easysetup-wizard.c:
1189 (create_page_custom_incoming), (create_page_custom_outgoing):
1190 * src/maemo/modest-account-settings-dialog.c:
1191 (create_page_account_details), (create_page_incoming),
1192 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1193 instead of using gtk_check_button_with_label(), so they are aligned like the other
1194 widgets, as per the UI spec.
1196 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1198 * src/maemo/easysetup/modest-easysetup-wizard.c:
1199 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1200 * src/widgets/modest-validating-entry.c:
1201 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1202 Modest prefix instead of an EasySetup prefix.
1204 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1206 * src/widgets/modest-validating-entry.h:
1207 * src/widgets/modest-validating-entry.c: (on_insert_text),
1208 Added easysetup_validating_entry_set_max_func(), used to set a callback
1209 to call when the max number of characters is reached. GtkEntry has a max-length
1210 already but is silent about it.
1212 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1213 (create_page_account_details), (create_page_user_details),
1215 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1216 (create_page_account_details), (create_page_user_details),
1217 (create_page_outgoing):
1218 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1219 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1220 the UI spec, when the user tries to enter more than the max number of characters.
1222 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1224 * src/maemo/easysetup/modest-easysetup-wizard.c:
1225 (create_page_user_details), (create_page_custom_incoming),
1226 (create_page_custom_outgoing):
1227 * src/maemo/modest-account-settings-dialog.c:
1228 (create_page_user_details), (create_page_incoming),
1229 (create_page_outgoing):
1230 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1231 (modest_connection_specific_smtp_edit_window_init):
1232 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1233 not appropriate. Bad Maemo-specific defaults!.
1235 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1237 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1238 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1239 (modest_signature_editor_dialog_set_settings):
1240 Disable the label and textview when the checkbox is disabled, and use the
1241 specified (UI spec) default signature text.
1243 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1245 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1246 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1248 * src/modest-defs.h:
1249 * src/modest-account-mgr-helpers.h:
1250 * src/modest-account-mgr-helpers.c:
1251 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1253 * src/maemo/Makefile.am:
1254 * src/maemo/modest-signature-editor-dialog.c:
1255 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1258 * src/maemo/modest-account-settings-dialog.h:
1259 * src/maemo/modest-account-settings-dialog.c:
1260 (modest_account_settings_dialog_finalize), (on_button_signature),
1261 (save_configuration): Use the new dialog when the Edit button is pressed, and
1262 save the changes if necessary, as per the UI spec.
1264 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1266 * src/maemo/Makefile.am:
1267 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1268 based on maemo-develoers email from Dirk.
1270 * src/maemo/easysetup/modest-easysetup-wizard.c:
1271 (create_page_welcome), (create_page_account_details),
1272 (create_page_user_details), (create_page_complete_easysetup),
1273 (create_page_custom_incoming), (create_page_custom_outgoing),
1274 (create_page_complete_custom),
1275 (modest_easysetup_wizard_dialog_init):
1276 * src/maemo/modest-account-settings-dialog.c:
1277 (create_page_account_details), (create_page_user_details),
1278 (create_page_incoming), (create_page_outgoing),
1279 (modest_account_settings_dialog_init):
1280 * src/maemo/modest-connection-specific-smtp-window.c:
1281 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1283 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1285 * src/maemo/easysetup/modest-easysetup-wizard.c:
1286 (create_page_account_details), (create_page_custom_outgoing),
1287 (create_page_complete_custom):
1288 * src/maemo/modest-account-settings-dialog.c:
1289 (create_page_user_details), (create_page_incoming),
1290 (create_page_outgoing):
1291 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1292 (modest_connection_specific_smtp_edit_window_init):
1293 Use the correct (UI spec) port min/max, and use horizontal separators,
1296 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1298 * src/maemo/easysetup/modest-easysetup-wizard.c:
1299 (set_default_custom_servernames):
1300 * src/maemo/modest-account-settings-dialog.c:
1301 (create_page_incoming), (on_combo_outgoing_security_changed),
1302 (on_combo_incoming_security_changed), (create_page_outgoing),
1303 (modest_account_settings_dialog_set_account_name),
1304 (save_configuration):
1305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1306 (on_combo_security_changed),
1307 (modest_connection_specific_smtp_edit_window_init),
1308 (modest_connection_specific_smtp_edit_window_set_connection),
1309 (modest_connection_specific_smtp_edit_window_get_settings):
1310 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1313 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1316 * src/maemo/easysetup/modest-easysetup-wizard.c:
1317 (create_page_custom_outgoing), (create_page_complete_custom):
1318 * src/maemo/modest-account-settings-dialog.c:
1319 (create_page_user_details), (create_page_outgoing):
1320 * src/maemo/modest-account-view-window.c: (button_box_new):
1321 Use changed logical IDs as per the most recent UI spec:
1322 mcen_bd_emailsetup_edit -> mcen_bd_edit
1323 mcen_bd_emailsetup_delete -> mcen_bd_delete
1324 mcen_bd_emailsetup_close -> mcen_bd_close
1326 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1330 * src/dbus_api/Makefile.am:
1331 * src/dbus_api/modest-dbus-callbacks.c:
1332 * src/dbus_api/modest-dbus-callbacks.h:
1333 * src/maemo/modest-platform.c: (modest_platform_init):
1334 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1336 * tests/Makefile.am:
1337 * tests/dbus_api/Makefile.am:
1338 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1340 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1342 * src/maemo/modest-account-settings-dialog.c:
1343 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1344 Removed unnecessary includes.
1346 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1348 * src/maemo/easysetup/modest-easysetup-wizard.c:
1349 * src/maemo/modest-account-settings-dialog.c:
1350 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1351 * src/widgets/Makefile.am:
1352 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1353 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1354 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1355 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1356 * src/widgets/modest-secureauth-combo-box.c:
1357 * src/widgets/modest-secureauth-combo-box.h:
1358 * src/widgets/modest-serversecurity-combo-box.c:
1359 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1360 made the GObject names more consistent with the rest of the Modest code.
1362 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1364 * src/maemo/easysetup/Makefile.am:
1365 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1366 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1367 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1368 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1369 * src/maemo/easysetup/modest-easysetup-wizard.c:
1370 * src/maemo/easysetup/modest-validating-entry.c:
1371 * src/maemo/easysetup/modest-validating-entry.h:
1372 * src/maemo/modest-account-settings-dialog.c:
1373 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1374 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1375 widgets/ because they are used outside of easysetup too. After checking in,
1376 svn will allow me to rename them too.
1378 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1380 * src/gnome/modest-msg-edit-window.c:
1381 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1382 linker error, to fix the build on the GNOME platform.
1383 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1384 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1385 ifdefed out to avoid a warning.
1387 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1389 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1390 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1391 some alternative for GTK+ 2.6.
1393 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1395 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1397 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1398 specified for EmailAccountsDialog in UI spec.
1400 * src/maemo/easysetup/modest-easysetup-wizard.c:
1401 * src/maemo/easysetup/modest-easysetup-wizard.h:
1402 * src/maemo/modest-account-settings-dialog.c:
1403 * src/maemo/modest-account-settings-dialog.h:
1404 Reuse a member window widget for the connection-specific SMTP server accounts,
1405 so we can tell it to create/save the accounts only if we actually save changes.
1407 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1408 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1409 (modest_connection_specific_smtp_edit_window_get_settings):
1410 Return a struct instance for temporarily remembering the entered data.
1412 * src/maemo/modest-connection-specific-smtp-window.h:
1413 * src/maemo/modest-connection-specific-smtp-window.c:
1414 (modest_connection_specific_smtp_window_finalize),
1415 (modest_connection_specific_smtp_window_fill_with_connections),
1417 (modest_connection_specific_smtp_window_save_server_accounts),
1418 (update_model_server_names): Do not actually save data until asked,
1419 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1421 (on_selection_changed),
1422 (modest_connection_specific_smtp_window_init): Disable the edit
1423 button when nothing is selected.
1425 * src/modest-account-mgr-helpers.c:
1426 * src/modest-account-mgr-helpers.h:
1427 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1430 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1432 * src/modest-account-mgr-helpers.h:
1433 * src/modest-account-mgr-helpers.c:
1434 (modest_account_mgr_get_unused_account_name),
1435 (modest_account_mgr_get_unused_account_display_name): Added these
1436 utility functions, to avoid code duplication.
1438 * src/maemo/easysetup/modest-easysetup-wizard.c:
1439 (create_page_account_details), (create_account):
1440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1441 (on_combo_security_changed),
1442 (modest_connection_specific_smtp_edit_window_init),
1443 (modest_connection_specific_smtp_edit_window_save_settings):
1444 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1445 * src/maemo/modest-connection-specific-smtp-window.c:
1446 (modest_connection_specific_smtp_window_finalize),
1447 (modest_connection_specific_smtp_window_fill_with_connections),
1448 (on_button_edit), (modest_connection_specific_smtp_window_init):
1449 * src/maemo/modest-connection-specific-smtp-window.h:
1450 Implementing saving of connection-specific server accounts.
1452 But I need to refactor this so we can save the data for each
1453 possible connection-specific account and only actually create the server accounts
1454 when the easysetup finished, or the OK button is pressed on the account settings
1457 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1459 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1460 (on_combo_security_changed):
1461 (modest_connection_specific_smtp_edit_window_init):
1462 Auto-fill the port number as in the account settings.
1464 (modest_connection_specific_smtp_edit_window_set_connection):
1465 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1466 * src/maemo/modest-connection-specific-smtp-window.c:
1467 (fill_with_connections), (on_button_edit),
1468 (modest_connection_specific_smtp_window_init):
1469 Turn the edit window into a dialog to simplify the code, and
1470 set a WM hint as in a GtkDialog, because only a popup can be on top of
1471 another window in Maemo, and popups usually have no WM decoration.
1473 * src/modest-defs.h:
1474 * src/modest-account-mgr-helpers.c:
1475 (modest_account_mgr_set_connection_specific_smtp),
1476 (modest_account_mgr_remove_connection_specific_smtp),
1477 (modest_account_mgr_get_connection_specific_smtp):
1478 * src/modest-account-mgr-helpers.h: Some functions to write the
1479 connection-specific SMTP server information. Not yet used.
1482 * src/widgets/modest-folder-view.c: (text_cell_data):
1483 Fix a warning about an uninitialized variable.
1484 (on_configuration_key_changed): Put an #ifdef around the use
1485 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1487 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/modest-account-settings-dialog.h:
1490 * src/maemo/modest-account-settings-dialog.c:
1491 Added connect_for_modified() utility function to mark the new modified boolean.
1493 (create_page_account_details), (create_page_user_details),
1494 (create_page_incoming), (create_page_outgoing), (on_response),
1495 (modest_account_settings_dialog_init),
1496 (modest_account_settings_dialog_set_account_name):
1497 Only warn about unsaved changes when there are actually unsaved changes.
1499 * src/modest-account-mgr-helpers.c:
1500 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1501 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1502 to get the data from there in future.
1504 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1506 * src/modest-defs.h:
1508 * src/modest-account-mgr-helpers.h:
1509 * src/modest-account-mgr-helpers.c:
1510 Store the security account setting in a single conf key instead of using
1511 the options list, so that the list is left for just the to-be-removed camel hack,
1512 and because gconf_client_set_list() is failing for some reason.
1514 * src/modest-account-mgr.c:
1515 (modest_account_mgr_add_server_account):
1516 * src/maemo/modest-account-settings-dialog.c:
1517 (modest_account_settings_dialog_set_account_name),
1518 (save_configuration): Use the renamed functions.
1521 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1523 * src/widgets/Makefile.am:
1524 * src/widgets/modest-limit-retrieve-combo-box.c:
1525 * src/widgets/modest-limit-retrieve-combo-box.h:
1526 * src/widgets/modest-retrieve-combo-box.c:
1527 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1528 the account settings dialog.
1530 * src/modest-defs.h:
1531 * src/modest-account-mgr-helpers.h:
1532 * src/modest-account-mgr-helpers.c:
1533 (modest_server_account_get_option_secure_auth),
1534 (modest_server_account_set_option_secure_auth):
1535 * src/modest-account-mgr.c:
1536 (modest_account_mgr_add_server_account):
1537 Use the existing AUTH_MECH conf key for the secure-auth setting,
1538 instead of putting it in the list options, because this was actually used already.
1540 * src/maemo/modest-account-settings-dialog.c:
1541 (create_page_account_details),
1542 (modest_account_settings_dialog_set_account_name),
1543 (save_configuration):
1544 * src/maemo/modest-account-settings-dialog.h:
1545 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1546 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1548 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1551 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1552 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1554 * src/modest-defs.h:
1555 * src/maemo/modest-account-settings-dialog.c:
1556 (create_page_incoming), (on_combo_outgoing_security_changed),
1557 (on_combo_incoming_security_changed), (create_page_outgoing),
1558 (modest_account_settings_dialog_set_account_name),
1559 (save_configuration): Load/Save the port number, and change it when the
1560 security combo changes, to suitable defaults.
1562 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1564 * src/modest-account-mgr.c:
1565 (modest_account_mgr_add_server_account): Set the security and secure-auth
1566 options, and add a comment saying that the other camel-specific options should be
1569 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1571 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1573 * src/modest-tny-account-store.c: (account_list_free),
1574 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1575 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1578 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1580 * src/modest-protocol-info.c:
1581 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1582 is required by our UI spec. Maybe something in our implementation will use this eventually.
1583 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1584 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1585 instead of the previous 0 placeholder.
1587 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1588 secure-auth settings.
1589 * src/modest-account-mgr-helpers.h:
1590 * src/modest-account-mgr-helpers.c:
1591 (modest_server_account_data_get_option_secure_auth),
1592 (modest_server_account_set_option_secure_auth),
1593 (modest_server_account_data_get_option_security),
1594 (modest_server_account_set_option_security): Added this API for getting and setting the security
1595 and secure-auth settings.
1597 * src/maemo/modest-account-settings-dialog.h:
1598 * src/maemo/modest-account-settings-dialog.c:
1599 (modest_account_settings_dialog_finalize), (check_data),
1600 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1601 about changing titles.
1602 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1603 (save_configuration): Save the security and secure-auth settings.
1605 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1606 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1608 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1610 * src/modest-defs.h:
1611 * src/modest-account-mgr.c:
1612 (modest_account_mgr_add_server_account):
1613 Added and used defines for the options key and value pair strings,
1614 that are used so far, though they do not seem to correspond to anything in our
1615 UI specs or ModestProtocol enum.
1617 * src/modest-account-mgr-helpers.h:
1618 * src/modest-account-mgr-helpers.c:
1619 (compare_option_strings_for_name),
1620 (modest_server_account_data_get_option_value),
1621 (modest_server_account_data_get_option_bool),
1622 (modest_account_mgr_get_server_account_option):
1623 Added helper functions for parsing the options GSList.
1625 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1627 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1628 display name is based on the supplied account name.
1629 * src/modest-account-mgr.c:
1630 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1631 with an inefficient, but good-enough, implementation.
1633 * src/maemo/easysetup/modest-easysetup-wizard.c:
1634 (create_page_account_details), (on_before_next), (create_account):
1635 Check for existing display names rather than (non-user-visible) account names, and just
1636 create and set a unique account name at the end.
1638 * src/maemo/modest-account-settings-dialog.c:
1639 (modest_account_settings_dialog_init),
1640 (modest_account_settings_dialog_set_account_name),
1641 (create_page_incoming): Show the display name, instead of the account name.
1642 (on_response): Do some (not all) extra checks, as in the UI spec.
1643 (save_configuration): Save the display name if it was changed.
1645 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1647 * po/en_GB.po: Added needed logical ID and translation.
1648 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1649 (init_view): Made the is-default column clicking work.
1651 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1654 * src/maemo/easysetup/Makefile.am:
1655 * src/maemo/easysetup/modest-easysetup-wizard.c:
1656 (modest_easysetup_wizard_dialog_init):
1657 * src/maemo/easysetup/provider-data-test.keyfile:
1658 * src/maemo/easysetup/provider-data.keyfile:
1659 Moved the provider data file to the new modest-providers-data package and used it from there.
1661 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1663 * src/modest-local-folder-info.c:
1664 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1665 N_() was already used on the static strings, but this just marks it for translation without
1666 using the translation.
1668 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1670 * src/maemo/modest-account-settings-dialog.c:
1671 (create_page_incoming),
1672 (modest_account_settings_dialog_set_account_name):
1673 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1674 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1675 I will do this if nobody else gets there first.
1677 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1679 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1680 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1681 save the security stuff.
1683 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1686 Set the email address and user fullname, which I now see must be
1689 * src/maemo/modest-account-settings-dialog.h:
1690 * src/maemo/modest-account-settings-dialog.c:
1692 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1693 leave-on-server and authentication.
1694 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1697 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1700 * src/maemo/modest-account-settings-dialog.c:
1701 * src/maemo/modest-account-settings-dialog.h:
1702 Most (but not all) of the widgets are now present as specified by the UI spec.
1703 No changes are yet saved, and some details are not properly shown yet.
1705 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1707 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1709 * src/maemo/Makefile.am:
1710 * src/maemo/modest-account-settings-dialog.c:
1711 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1712 an existing account. Doesn't do much yet.
1714 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1715 Open the accounts settings dialog when Edit is clicked.
1717 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1719 * src/maemo/easysetup/Makefile.am:
1720 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1722 * src/maemo/easysetup/modest-easysetup-wizard.c:
1723 (modest_easysetup_wizard_dialog_init):
1724 Try to get the source directory from the build system,
1725 instead of hard-coding "./" into the source code, when opening our local
1726 copies of the configuration files.
1727 But this still fails when opening the wizard from the Accounts window,
1728 maybe because the working directory seems to change at runtime.
1729 So the wizard will fail the second time unless you copy the files into their
1730 proper locations - see the stdout warnings for the paths.
1732 (create_page_account_details),(on_before_next):
1733 Check for existing non-server accounts instead of server accounts,
1734 so the default account name is useful again, and to prevent trying to
1737 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1738 Show the wizard when New is clicked.
1740 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1741 (init_view): Show the column headers, and show the columns that are
1742 specified in the UI specs. However, something in Maemo's GTK+ prevents
1743 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1744 change the default account. This is despite unsetting the special properties.
1746 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1748 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1749 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1750 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1751 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1752 to make that clearer.
1753 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1755 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1757 * src/maemo/modest-account-view-window.c:
1758 (modest_account_view_window_init),
1759 (modest_account_view_window_new):
1760 Use the same buttons as specified in the
1761 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1762 the existing widgets, which never had a chance of working.
1763 Put the ModestAccountView treeview in a scrolled window.
1764 Do not repeat the initialization in both _init() and _new().
1766 * src/widgets/modest-account-view.c: (update_account_view):
1767 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1768 this widget and window shows no accounts.
1770 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1772 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1774 * src/maemo/easysetup/modest-easysetup-wizard.c:
1775 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1776 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1777 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1780 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1781 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1782 accounts exist yet, as in the UI spec.
1784 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1786 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1788 * src/maemo/Makefile.am:
1789 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1790 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1791 New window for editing connection-specific smtp details.
1792 Not fully implemented.
1794 * src/maemo/modest-connection-specific-smtp-window.c:
1795 (modest_connection_specific_smtp_window_finalize) :
1796 unref the tree model.
1797 (on_button_edit): Show the edit window.
1799 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1801 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1804 * src/maemo/Makefile.am:
1805 * src/maemo/modest-connection-specific-smtp-window.c:
1806 * src/maemo/modest-connection-specific-smtp-window.h:
1807 New window for showing the list of connections, for connection-specific
1808 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1809 * src/maemo/easysetup/modest-easysetup-wizard.c:
1810 (create_page_custom_outgoing): Show the new window when the button is clicked.
1812 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1814 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1815 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1816 * src/maemo/modest-msg-edit-window.c:
1817 (modest_msg_edit_window_insert_image):
1818 * src/modest-conf.c: (modest_conf_key_escape):
1819 * src/modest-mail-operation.c:
1820 (modest_mail_operation_send_new_mail):
1821 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1822 (modest_ui_actions_on_new_account):
1823 * src/widgets/modest-attachment-view.c: (update_filename_request):
1824 * src/widgets/modest-mail-header-view.c:
1825 Corrected warnings that were breaking the build, by commenting out unused variables,
1826 and a function, and by including a header.
1828 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1830 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1831 so we can #ifdef around platform-specific code when necessary.
1832 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1833 to allow this to build for the GNOME platform too.
1835 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1837 * src/maemo/easysetup/modest-easysetup-wizard.c:
1838 Added util_increment_name() and used it in create_page_account_details()
1839 to make sure that the default account name is always a new name.
1841 (modest_easysetup_wizard_dialog_init),
1842 (set_default_custom_servernames): Some minor memory management fixes.
1844 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1848 * src/modest-runtime.c: (init_i18n): Restored the translation
1849 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1850 are defined in config.h, and the translations are installed.
1852 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1853 is defined for translation.
1855 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1857 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1859 * src/maemo/easysetup/modest-easysetup-wizard.c:
1860 (modest_easysetup_wizard_dialog_init):
1861 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1862 Use realistic paths (though they should use $prefix generically) to the
1863 mcc_mapping and provider-data.keyfile files which might work when they
1864 are installed by the future version of the operator-wizard package,
1865 and then fallback to paths in our source code, with an explanatory
1868 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1872 * src/maemo/Makefile.am:
1873 * src/maemo/easysetup/: Added files from the previously-exernal
1874 osso-modest-easysetup.
1875 * src/maemo/modest-main-window-ui.h:
1876 * src/modest-ui-actions.c:
1877 * src/modest-ui-actions.h:
1878 Added modest_ui_actions_on_new_account() as a signal handler for the
1879 New Account menu item. It shows the easysetup wizard.
1880 * po/en_GB.po: Added additional needed logical IDs and translations.
1882 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1883 Apparently ChangeLog is not used for some vague Nokia legal reasons.