1 2007-06-19 Murray Cumming,,, <murrayc@murrayc-desktop>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 (_dbus_iter_get_string_or_null): Initialize the string variable in
5 case this helps with Dirk's crash.
7 2007-06-19 Murray Cumming <murrayc@murrayc.com>
9 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
10 though it is not implemented yet (this function is maybe not even used),
11 to avoid breaking ABI in future.
12 * libmodest-dbus-client/libmodest-dbus-client.c:
13 (get_attachments_string): Moved some code into this generic function.
14 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
15 sends email. It is maybe not used.
16 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
17 (on_send_mail): Use attachments.
19 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
20 * src/maemo/modest-msg-edit-window.c:
21 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
22 a filename before using it, to fix projects.maemo.org bug NB#58233.
24 2007-06-19 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
27 Initialize the continue_download variable to fix the build, and probably
28 to fix randome behaviour.
30 2007-06-18 Armin Burgmeier <armin@openismus.com>
32 * src/modest-tny-send-queue.h:
33 * src/modest-tny-send-queue.c: Keep track of the status of messages in
34 the queue so we can later show it in the UI. Replaced
35 modest_tny_send_queue_msg_is_being_sent() by
36 modest_tny_send_queue_get_msg_status().
38 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
40 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
41 gpointer. This probably was not harmful, but just to be sure.
43 2007-06-18 Murray Cumming <murrayc@murrayc.com>
45 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
46 Fix the build, but leave the function broken on Bora, because
47 hildon_uri_action_get_service() does not exist.
48 osso_uri_action_get_service() does not exist either, it seems.
50 2007-06-18 Murray Cumming <murrayc@murrayc.com>
52 * src/modest-tny-account.c:
53 (modest_tny_account_new_from_server_account):
54 Uncommented the url debug output again, because it is useful for
55 debugging, as I said in the comment.
57 2007-06-18 Murray Cumming <murrayc@murrayc.com>
59 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
61 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
62 for Mameo Bora, to fix the build.
64 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
67 Fixed build with hildon < 0.99
69 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
70 Check if the selected account is busy instead of checking all accounts
72 * src/modest-account-mgr-priv.h:
73 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
74 (modest_account_mgr_init), (compare_account_name),
75 (modest_account_mgr_set_account_busy),
76 (modest_account_mgr_account_is_busy):
77 * src/modest-account-mgr.h:
78 Added busy information to the account manager. It possible to
79 set an account to busy or not busy now.
81 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
82 (modest_mail_operation_update_account),
83 (modest_mail_operation_notify_end):
84 Set the account to busy/not busy depending on the operation state.
86 * src/widgets/modest-account-view.c:
87 (modest_account_view_finalize), (get_last_updated_string),
88 (update_account_view), (on_account_busy_changed), (init_view):
89 Show string "Refreshing..." if the account is currently busy.
91 All this fixes projects.maemo.org bug NB#59711
93 2007-06-14 Armin Burgmeier <armin@openismus.com>
95 * src/widgets/modest-attachments-view.h:
96 * src/widgets/modest-attachments-view.c: Added
97 modest_attachments_view_has_attachments() and fixed coordinate
98 transformation in get_att_view_at_coords(). This fixes attachment
101 * src/widgets/modest-msg-view.c: Make use of
102 modest_attachments_view_has_attachments() to decide whether to show
103 attachments in the header.
105 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
107 * src/maemo/modest-connection-specific-smtp-edit-window.c:
108 (on_change), (on_combo_security_changed),
109 (modest_connection_specific_smtp_edit_window_init),
110 (modest_connection_specific_smtp_edit_window_set_connection),
111 (modest_connection_specific_smtp_edit_window_is_dirty):
112 * src/maemo/modest-connection-specific-smtp-edit-window.h:
113 * src/maemo/modest-connection-specific-smtp-window.c:
116 Show an comfirmation dialog for the smpt-edit-window if there are
117 unsaved changes and the user hits cancel.
118 (projects.maemo.org bug NB#60479)
120 2007-06-14 Armin Burgmeier <armin@openismus.com>
122 * src/maemo/easysetup/modest-easysetup-wizard.c:
123 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
124 address" info in banner instead of node, and select all the text as
125 per UI spec. This fixes projects.maemo.org bug NB#60550.
127 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
129 reviewed by: <delete if not using a buddy>
131 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
132 * src/modest-ui-actions.c: (folder_refreshed_cb):
134 2007-06-14 Murray Cumming <murrayc@murrayc.com>
136 * src/widgets/modest-folder-view.c: (filter_row):
137 Explictly filter out the per-account outbox accounts. I don't know why
138 these only sometimes show up, but now they should never show up in the UI.
139 This should fix projects.maemo.org bug NB#60160.
141 2007-06-14 Murray Cumming <murrayc@murrayc.com>
143 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
144 when the toolbar does not exist yet.
145 * src/modest-widget-memory.c: (save_settings_header_view):
146 Added g_warnings() to help us to discover when we are trying to set
147 an empty columns list in gconf.
149 2007-06-14 Murray Cumming <murrayc@murrayc.com>
153 Added modest_init_get_default_header_view_column_ids().
155 * src/modest-widget-memory.c: (restore_settings_header_view):
156 Use the new function to get defaults, if the gconf key is empty,
157 instead of not creating any columns. This seems to fix the
158 empty right-hand pane problems.
160 * src/widgets/modest-header-view.h: Improved documentation.
162 2007-06-13 Murray Cumming <murrayc@murrayc.com>
164 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
165 Revert the use of the display name as the account name, because this
166 is generally wrong and would break the code that follows.
168 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
170 * src/maemo/easysetup/modest-easysetup-wizard.c:
171 (check_for_supported_auth_methods), (on_before_next),
174 More correct fix for projects.maemo.org bug NB# 58991
175 Do not longer accept AUTH_PASSWORD as secure method and choose
176 correct method when creating the account.
178 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
180 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
181 Fixed projects.maemo.org bug NB# 58991
183 2007-06-13 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-init.c: (modest_init_init_core),
186 (modest_init_local_folders): Fixed compilation errors.
188 2007-06-13 Murray Cumming <murrayc@murrayc.com>
190 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
191 Remove unnecessary lib/include, though it is good in principle when needed.
193 * src/modest-init.c: (modest_init_one_local_folder),
194 (modest_init_local_folders):
195 * src/modest-init.h: Initialize the .modest library for memory cards,
196 instead of just doing nothing for them. This should allow us to create
197 folders there, fixing projects.maemo.org bug NB#59297.
199 2007-06-13 Murray Cumming <murrayc@murrayc.com>
201 * libmodest-dbus-client/libmodest-dbus-client.c:
202 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
203 (libmodest_dbus_client_compose_mail),
204 (libmodest_dbus_client_open_message),
205 (libmodest_dbus_client_send_and_receive),
206 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
208 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
209 (on_idle_open_message), (modest_dbus_req_handler),
210 (search_result_to_message), (modest_dbus_req_filter):
211 * src/modest-search.c: (add_hit), (modest_search_folder),
212 (modest_search_all_accounts): Improved debug messages.
214 * tests/dbus_api/test_open_message.c: (main): Improved comments.
216 * src/modest-tny-account-store.c:
217 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
220 2007-06-13 Murray Cumming <murrayc@murrayc.com>
223 2007-06-12 Murray Cumming <murrayc@murrayc.com>
225 * src/modest-tny-account-store.c: (get_server_accounts):
226 Call modest_tny_local_folders_account_add_merged_outbox_folders()
227 even when there are no accounts, so that the Outbox folder is always
228 visible. This fixes projects.maemo.org bug NB#60158.
230 2007-06-12 Murray Cumming <murrayc@murrayc.com>
232 * src/maemo/modest-main-window.c: (create_details_widget):
233 Use the mcen_va_never logical ID.
235 2007-06-12 Murray Cumming <murrayc@murrayc.com>
237 * src/dbus_api/modest-dbus-api.h:
238 * src/dbus_api/modest-dbus-callbacks.c:
239 (on_idle_open_default_inbox), (on_open_default_inbox),
240 (modest_dbus_req_handler):
241 Added a new OpenDefaultInbox method.
243 * libmodest-dbus-client/libmodest-dbus-client.h:
244 * libmodest-dbus-client/libmodest-dbus-client.c:
245 Added libmodest_dbus_client_open_default_inbox() to call the new
246 dbus method. This should be useful to projects.maemo.org bug NB#57214,
247 though it should maybe be used by a new osso-email-interface function.
249 * tests/dbus_api/Makefile.am:
250 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
253 2007-06-12 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
256 NULL, so that the signals get all the keys. This should not actually
257 change any behaviour because we currently update everything when anything
260 2007-06-12 Murray Cumming <murrayc@murrayc.com>
262 * src/widgets/modest-folder-view.c: (text_cell_data),
263 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
264 (find_inbox_iter): If tinymail tells us that the folder is
265 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
266 This causes the inbox to be selected at startup, fixing part of
267 projects.maemo.org bug NB#56305.
269 * src/modest-ui-dimming-rules.c:
270 (modest_ui_dimming_rules_on_tools_smtp_servers):
271 * src/modest-ui-dimming-rules.h: Added a callback function to dim
272 the SMTP servers menu item.
273 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
274 that the SMTP Servers menu item is dimmed when there are no accounts,
275 as a future version of the UI spec will require. This fixes
276 projects.maemo.org bug NB#56305.
278 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
280 * src/maemo/modest-maemo-utils.c:
281 (modest_maemo_utils_get_supported_secure_authentication_methods):
282 Added label to dialog instead of unreadable title
284 * src/maemo/modest-main-window.c: (sync_accounts_cb),
285 (modest_main_window_new):
286 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
289 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
290 * src/modest-account-mgr.h:
291 Added method to avoid code duplication
293 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
294 (modest_ui_actions_on_send_receive):
295 Use modest_account_mgr_has_accounts
297 2007-06-11 Murray Cumming <murrayc@murrayc.com>
299 * src/maemo/easysetup/modest-presets.c:
300 (modest_presets_get_info_server_security): Do not report secure auth
302 * src/modest-protocol-info.c: Use the defines for the gconf key names
303 for secure authentication. This was not working because we were writing
304 Password and reading password, and the check was case sensitive.
305 With this, gmail now works for receiving and sending when created via
308 2007-06-11 Murray Cumming <murrayc@murrayc.com>
310 * src/maemo/easysetup/modest-presets.c:
311 (modest_presets_get_info_server_security): Correct the key name for
312 SecureSmtp, because it seems to be case-sensitive.
313 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
314 Do not try to get the 0th notebook page if there are 0 pages, to
317 2007-06-11 Murray Cumming <murrayc@murrayc.com>
319 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
320 Prevent use of the new notification feature for now, because it currently
321 shows one dialog for each new email, which is annoying.
323 2007-06-11 Murray Cumming <murrayc@murrayc.com>
325 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
326 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
327 when no country was selected, so that we show the global ones.
328 * src/maemo/easysetup/modest-presets.c:
329 (modest_presets_get_providers): Return only the global providers, not
330 all providers when mmc=0 was requested.
332 2007-06-11 Murray Cumming <murrayc@murrayc.com>
334 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
335 (easysetup_provider_combo_box_fill): Remove debug code that showed the
336 provider ID in the combo.
338 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
339 Do not show the page numbers, because it would be confusing when we add
340 the 2 extra pages for the custom setup, when the user chooses the "Other"
341 provider. This fixes projects.maemo.org bug NB#59028
343 * src/modest-init.c: (modest_init_init_core),
344 (modest_init_local_folders):
346 * src/modest-tny-account.c:
347 (modest_tny_account_new_for_local_folders): Do not create default folders
348 for the memory card. This should fix projects.maemo.org bug NB#59328.
350 2007-06-11 Murray Cumming <murrayc@murrayc.com>
352 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
353 Free the changed_conf_keys string items. They are already freed in the
354 idle handler if that runs first.
356 2007-06-11 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-ui-actions.c:
359 (modest_ui_actions_on_password_requested): Check that the server name
360 is not NULL, because I just saw a password dialog with (null) as the
363 * src/modest-tny-folder.[h|c]: Added
364 modest_tny_folder_is_memory_card_folder().
365 * src/modest-ui-dimming-rules.c:
366 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
367 menu item for memory cards, as per the UI spec (section 7.4). This should
368 fix projects.maemo.org bug NB#59297.
370 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
372 * src/maemo/modest-main-window.c: (sync_accounts_cb):
373 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
374 is another problem with the code, see Murray's comment at line 772)
376 2007-06-08 Murray Cumming <murrayc@murrayc.com>
378 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
379 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
380 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
381 (load_from_file), (easysetup_country_combo_box_init),
382 (easysetup_country_combo_box_get_active_country_ids),
383 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
384 instead of just one ID, to avoid duplicate country names in the UI.
386 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
387 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
388 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
389 a single ID, avoiding duplicate providers.
390 * src/maemo/easysetup/modest-easysetup-wizard.c:
391 (on_combo_account_country): Adapt to use a list.
393 2007-06-08 Murray Cumming <murrayc@murrayc.com>
395 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
396 keys changed in the last X seconds.
398 * src/modest-account-mgr.h:
399 * src/modest-account-mgr.c: (on_timeout_notify_changes),
400 (on_key_change), (modest_account_mgr_class_init),
401 (modest_account_mgr_init), (modest_account_mgr_finalize):
402 As the keys are changed, save them in a GSList* and signal that GSList*
403 further every X seconds, to batch changes, to allow us to do just one
404 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
405 bug NB#56941 and other (UI-blocking) delays when changing account settings.
407 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
408 changed signal signature.
410 * src/modest-conf.c: (modest_conf_set_list),
411 (modest_conf_on_change): Reenable notification.
413 (modest_conf_maemo_fake_on_change): Comment out the hack that
414 notified immediately instead of asynchronously.
416 * src/widgets/modest-account-view.h:
417 * src/widgets/modest-account-view.c:
418 (update_account_view): Select the previously-selected account ID,
419 if possible. This fixes projects.maemo.org bug NB#56933.
421 (on_account_changed), (on_account_removed),
422 (modest_account_view_select_account):
424 Remove the block/unblock functions
425 because they were not useful.
427 * src/maemo/modest-account-view-window.c:
428 (on_delete_button_clicked), (on_edit_button_clicked),
429 (on_new_button_clicked): Remove the use of the non-working block/unblock.
431 2007-06-08 Murray Cumming <murrayc@murrayc.com>
433 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
434 Improve the error dialog to show Incorrect Account Settings, which seems
435 clearer, and say that the internal error message (to be removed from the
436 dialog later) is often misleading.
437 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
439 * src/modest-tny-account.c:
440 (modest_tny_account_new_from_server_account): Uncomment the printf of the
441 URL because this is so useful for debugging on the device.
443 * src/widgets/modest-serversecurity-combo-box.c:
444 (modest_serversecurity_combo_box_fill): Correct a logical ID.
446 2007-06-08 Murray Cumming <murrayc@murrayc.com>
448 * src/modest-mail-operation.c:
449 (modest_mail_operation_send_new_mail):
450 Added a comment about a nasty but apparently harmless message. Details
451 added to the wiki g_warnings() page.
453 2007-06-08 Murray Cumming <murrayc@murrayc.com>
455 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
456 (modest_tny_send_queue_class_init):
457 Do not use the priv struct because it is empty, to avoid g_warnings
458 about a non-existant priv struct.
460 * src/modest-tny-account-store.c:
461 (modest_tny_account_store_get_server_account),
462 (modest_tny_account_store_get_transport_account_for_open_connection
463 ): Do not try to get transport server accounts for local folders,
464 because they don't have any. This avoids a g_warning().
466 * src/maemo/modest-main-window.c:
467 (modest_main_window_notify_send_receive_initied),
468 (on_configuration_key_changed):
469 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
471 * src/modest-mail-operation.c:
472 (modest_mail_operation_update_account):
473 * src/modest-tny-account-store.h:
474 * src/modest-tny-account.c:
475 (modest_tny_account_get_special_folder),
476 (modest_tny_account_new_for_local_folders),
477 (modest_tny_account_new_for_per_account_local_outbox_folder):
478 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
479 * src/modest-tny-local-folders-account.c:
480 (add_account_folders_to_merged_folder):
481 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
482 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
483 (modest_ui_actions_on_send):
484 * src/widgets/modest-folder-view.c: (update_model):
485 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
486 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
487 modest_tny_account_store_get_tny_account_by_account() to
488 modest_tny_account_store_get_server_account() to make the code clearer.
490 2007-06-07 Marcus Bauer <marcusb@openismus.com>
492 * src/dbus_api/modest-dbus-api.h:
493 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
494 * src/maemo/modest-msg-edit-window.c:
495 (modest_msg_edit_window_attach_file_noninteractive):
496 added g_warning in case the file to be attached does not exist
497 * tests/dbus_api/test_compose_mail.c: (main):
498 removed obsolete comment, added generic files as test case
500 2007-06-07 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-tny-account-store.c: (get_server_accounts):
503 Create the local folders account only once, not once for each outbox, and
504 not only when there are some outboxes.
506 2007-06-07 Murray Cumming <murrayc@murrayc.com>
508 * src/widgets/modest-folder-view.c: (update_model): Comment out some
509 code that is causing a crash at startup. Sergio says that he is fixing this.
511 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
513 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
514 * src/maemo/modest-account-settings-dialog.c:
515 (create_page_outgoing),
516 (modest_account_settings_dialog_set_account_name),
517 (save_configuration):
518 - Fixed handling of the "Use secure authentication" toggle to comply with
519 the ui specification. See also projects.maemo.org bug NB#58400
521 - Restore the Secure connection setting combo correctly when loading
524 * src/maemo/modest-maemo-utils.c:
525 (on_camel_account_get_supported_secure_authentication),
526 (modest_maemo_utils_get_supported_secure_authentication_methods):
527 Fixed a crasher if operation is canceled
529 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
530 (modest_protocol_info_auth_is_secure):
531 * src/modest-protocol-info.h:
533 Added two new methods to determine if a protocol/auth method is secure/encrypted in
534 the sense of the "Use secure authentication" toggle.
536 2007-06-07 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-tny-account-store.h:
539 * src/modest-tny-account-store.c:
540 Added modest_tny_account_store_get_local_folders_account().
542 * src/modest-tny-folder.h:
543 * src/modest-tny-folder.c:
544 (modest_tny_folder_get_account):
545 Added this replacement for tny_folder_get_account() which returns
546 the local-folders account for TnyMergeFolders, to avoid the
547 warning about the unimplemented get_account_func() vfunc().
549 (modest_tny_folder_get_rules),
550 * src/modest-ui-actions.c:
551 (modest_ui_actions_on_folder_selection_changed):
552 * src/modest-mail-operation.c:
553 (modest_mail_operation_remove_folder),
554 (modest_mail_operation_xfer_folder),
555 (modest_mail_operation_rename_folder),
556 (modest_mail_operation_get_msg),
557 (modest_mail_operation_get_msgs_full),
558 (modest_mail_operation_remove_msg),
559 (modest_mail_operation_xfer_msgs),
560 (modest_mail_operation_refresh_folder):
561 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
563 2007-06-07 Murray Cumming <murrayc@murrayc.com>
565 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
566 (modest_server_account_set_security):
567 * src/modest-defs.h: Add comments explaining that our
568 UI spec means TLS when it says Normal, so these do not look like errors.
570 * src/modest-tny-account.c:
571 (modest_tny_account_new_from_server_account): Use the new tinymail
572 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
573 for TLS. This should fix projects.maemo.org bug NB#58460.
575 2007-06-06 Murray Cumming <murrayc@murrayc.com>
577 * src/maemo/easysetup/modest-easysetup-wizard.c:
578 (create_account): Correct the position of the gconf sanity check warning.
579 (on_button_edit_advanced_settings): Show the dialog immediately, instead
580 of using the g_idle_add() hack, because this does not seem to be necessary
581 on osso 1.1. It might even work on Maemo Bora if the problems were actually
582 caused by something other than maemo's gconf.
583 This fixes projects.maemo.org bug #59022.
585 2007-06-06 Murray Cumming <murrayc@murrayc.com>
587 * src/modest-account-mgr-helpers.c:
588 (modest_account_mgr_get_default_account): Do not check that the account
589 exists if there is no default account (NULL), to fix a runtime warning.
591 2007-06-06 Murray Cumming <murrayc@murrayc.com>
593 * src/widgets/modest-folder-view.c: (update_model):
594 Do not unref the treemodel before we have finished with it.
595 This prevents a valgrind warning and an occasional crash at startup.
597 2007-06-06 Marcus Bauer <marcusb@openismus.com>
599 * libmodest-dbus-client/libmodest-dbus-client.h:
600 added libmodest_dbus_client_compose_mail()
601 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
603 added functions needed for SendAsMail() functionality
604 * src/maemo/modest-msg-edit-window.c:
605 (modest_msg_edit_window_attach_file_noninteractive):
606 non interactively attaching files to message edit window
607 * src/widgets/modest-msg-edit-window.h:
608 * tests/dbus_api/Makefile.am:
609 added test_compose_mail.c
610 * tests/dbus_api/test_compose_mail.c: (main):
612 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
614 * src/modest-account-view.c:
615 Fixed bug projects.maemo.org bug NB#59307
617 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
619 * src/maemo/easysetup/modest-easysetup-wizard.c:
620 (get_serverport_incoming), (on_before_next), (create_account):
621 * src/maemo/modest-account-settings-dialog.c:
622 (modest_account_settings_dialog_set_account_name):
623 * src/maemo/modest-maemo-utils.c:
624 (on_camel_account_get_supported_secure_authentication_status),
625 (on_camel_account_get_supported_secure_authentication),
626 (on_secure_auth_cancel),
627 (modest_maemo_utils_get_supported_secure_authentication_methods):
629 Implemented security authentication for settings and easysetup.
631 2007-06-05 Murray Cumming <murrayc@murrayc.com>
633 * src/maemo/modest-main-window.c: (create_details_widget):
634 Show the total size for memory card accounts too, instead of showing
635 the name again. Fixes bug projects.maemo.org bug NB#59307.
637 2007-06-05 Murray Cumming <murrayc@murrayc.com>
640 * src/modest-tny-simple-folder-store.c:
641 * src/modest-tny-simple-folder-store.h: Removed.
643 * src/modest-tny-local-folders-account.h
644 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
645 for the local-folders maildir, with an extra TnyMergedFolder containing
646 the folders of the per-account outbox store accounts.
647 * src/modest-tny-account-store.c: (get_server_accounts):
648 Add the outboxes to the special local folders account after creating it.
650 * src/modest-tny-account.c:
651 (modest_tny_account_new_for_local_folders): Create the derived
652 account when creating the main local-folders account.
654 * src/maemo/modest-main-window.c: (create_details_widget),
655 (modest_main_window_set_contents_style):
656 Adapted to the use of the derived account instead of the folder store.
658 * src/modest-ui-actions.c:
659 (modest_ui_actions_on_folder_selection_changed):
660 * src/modest-ui-dimming-rules.c:
661 (modest_ui_dimming_rules_on_new_folder):
662 * src/widgets/modest-folder-view.c: (text_cell_data),
663 (icon_cell_data), (filter_row), (update_model),
664 (get_cmp_rows_type_pos):
667 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
668 Do not get the priv struct, because no priv struct has been set,
669 to avoid a runtime warning.
671 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
672 #ifelse with #else, to fix a warning, to fix the build.
675 2007-06-05 Christian Kellner <ckellner@openismus.com>
677 * libmodest-dbus-client/libmodest-dbus-client.c:
678 Fix small typo in doc (why do you always see them
679 AFTER committing stuff?)
682 2007-06-05 Christian Kellner <ckellner@openismus.com>
684 * libmodest-dbus-client/libmodest-dbus-client.c:
685 (libmodest_dbus_client_search):
686 Initialize hit list with NULL. Also set folder list
687 to "" if NULL was supplied.
690 2007-06-03 Christian Kellner <ckellner@openismus.com>
692 * libmodest-dbus-client/libmodest-dbus-client.c:
693 (modest_search_hit_list_free):
694 Make it save to call it with NULL.
696 * src/dbus_api/modest-dbus-callbacks.c:
697 * src/modest-search.c:
698 Return full ModestSearchHits as the search result list not TnyHeader
699 since can't be around withouth the correspoding TnyFolder.
701 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
703 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
704 Added currently commented code to check for secure auth
706 * src/maemo/modest-account-settings-dialog.c: (on_response),
707 (save_configuration), (show_ok):
708 Fixed projects.maemo.org bugs NB #59248 and #59251
710 * src/maemo/modest-maemo-utils.c:
711 (on_camel_account_get_supported_secure_authentication_status),
712 (on_camel_account_get_supported_secure_authentication),
713 (modest_maemo_utils_get_supported_secure_authentication_methods):
714 * src/maemo/modest-maemo-utils.h:
715 Moved get_supported_secure_authentication() method here to be able
716 to use it from easysetup wizard.
718 * src/modest-pair.c: (on_pair_compare_as_string):
719 Should compare string with first part of pair and not
720 strcmp pairs which will crash.
722 * src/modest-protocol-info.c:
723 (modest_protocol_info_protocol_is_store):
724 * src/modest-protocol-info.h:
725 Added modest_protocol_info_get_auth_protocol_name()
727 2007-06-03 Armin Burgmeier <armin@openismus.com>
729 * src/modest-mail-operation.c:
730 (modest_mail_operation_get_msgs_full): Set priv->account also when
731 only retrieving a single message. This avoids a crash when canceling
734 (modest_mail_operation_notify_end): Do not explicitely remove the
735 operation from the queue but only emit the progress_changed signal.
736 The queue itself listens to that signal to remove the operation when
737 it is finished. This reduces coupling and removes a potential deadlock
738 when modest_mail_operation_notify_end() is called from the queue
739 itself. If that is a problem performance-wise, I would suggest to
740 implement a status-changed signal or something.
742 * src/modest-mail-operation-queue.c: Make sure to never call a
743 function from another file while the queue is locked. This (hopefully)
744 fixes another deadlock when exiting the application while retrieving
747 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
749 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
750 Fixed build if libogs is not available
752 2007-06-03 Christian Kellner <ckellner@openismus.com>
754 * libmodest-dbus-client/libmodest-dbus-client.h:
755 * libmodest-dbus-client/libmodest-dbus-client.c:
756 (libmodest_dbus_client_delete_message):
757 Implement deletion of messages (Client side).
759 (modest_search_hit_free),
760 (modest_search_hit_list_free):
761 Utility functions to free the result hits.
763 * src/dbus_api/modest-dbus-api.h:
764 * src/dbus_api/modest-dbus-callbacks.c:
766 (modest_dbus_req_handler):
767 Implement deletion of messages (Server side).
769 * tests/dbus_api/test_search.c: (main):
772 * tests/dbus_api/Makefile.am:
773 * tests/dbus_api/test_delete_message:
774 Add little test for the message deletion logic
776 2007-06-03 Armin Burgmeier <armin@openismus.com>
778 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
779 when the operation queue was not empty. projects.maemo.org bug
782 2007-06-03 Armin Burgmeier <armin@openismus.com>
784 * src/widgets/modest-account-view.c
785 (on_account_default_toggled): Toggle default account column
786 explicitely instead of waiting for gconf notification (which is
787 currently ignored). This should fix projects.maemo.org bug NB#56910
788 for now. It should probably be removed when gconf notifications are
791 2007-06-03 Christian Kellner <ckellner@openismus.com>
793 * libmodest-dbus-client/libmodest-dbus-client.c:
794 Removed debugging spew.
796 * src/dbus_api/modest-dbus-callbacks.c:
797 Added debugging info.
799 * src/modest-search.c:
800 (modest_search_all_accounts):
801 Use tny_account_store_get_accounts () on the account store
802 to get all accounts which is the way to get all accounts.
804 * tests/dbus_api/test_search.c: (main):
805 Make it possible to supply the search term on the command line.
807 2007-06-03 Christian Kellner <ckellner@openismus.com>
809 * libmodest-dbus-client/libmodest-dbus-client.c:
810 * libmodest-dbus-client/libmodest-dbus-client.h:
811 Implement searching for mesages over raw dbus. (Client side)
813 * src/dbus_api/Makefile.am:
814 * src/dbus_api/modest-dbus-api.h:
815 * src/dbus_api/modest-dbus-callbacks.c:
816 * src/dbus_api/modest-dbus-callbacks.h:
817 Search framework (Server side). Also implement on_idle_open_message().
819 * src/maemo/modest-platform.c: (modest_platform_init):
820 Prepare for raw dbus/osso rpc interaction.
822 * src/modest-search.h:
823 Changed minsize from unspecific guint to guint32.
825 * src/modest-search.c:
827 Added strange hack which magically made tnymail work.
829 (modest_search_folder),
830 (modest_search_account),
831 (modest_search_all_accounts):
832 Implement helper functions to search all accounts, specific account
835 * tests/dbus_api/Makefile.am:
836 * tests/dbus_api/test_open_message.c:
837 Read url to open from commandline.
839 * tests/dbus_api/test_search.c:
840 Implement small test for dbus search stuff
842 2007-06-02 Armin Burgmeier <armin@openismus.com>
844 * src/maemo/modest-account-settings-dialog.c: Changed window title to
845 include account type and account title. This fixes projects.maemo.org
848 * src/maemo/modest-account-view-window.c: Set a title for the window.
850 2007-06-02 Armin Burgmeier <armin@openismus.com>
852 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
853 incoming and outgoing server name based on email address and server
854 types as long as the names have not been edited manually. This fixes
855 projects.maemo.org bug NB#58671.
857 2007-06-02 Armin Burgmeier <armin@openismus.com>
859 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
860 server type cannot be changed in future to the incoming details page
861 when creating an account. This fixes projects.maemo.org bug NB#59029.
863 2007-06-02 Armin Burgmeier <armin@openismus.com>
865 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
866 and assigned max width chars so that they wrap instead of being
867 truncated. Fixes projects.maemo.org bug NB#56126.
869 2007-06-02 Armin Burgmeier <armin@openismus.com>
871 * src/maemo/modest-connection-specific-smtp-window.c: Add an
872 introductory note to the connection specific smtp servers dialog, as
873 section 8.12 of the email UI specification requires. This fixes
874 projects.maemo.org bug NB#59212.
876 2007-06-01 Murray Cumming <murrayc@murrayc.com>
878 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
879 Check for running mail operations, and offer to cancel them, as per the UI
880 spec. This fixes projects.maemo.org bug NB#59041 .
881 However, I suspect that tinymail may still use the network connection
882 in ways that we cannot detect or cancel. But it should at least adapt to
885 2007-06-01 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-tny-account-store.c: (recreate_all_accounts),
888 (get_cached_accounts), (get_server_accounts): Do more sensible
889 ref-counting of the temporarily-cached outbox accounts list. This seems
890 to fix a crash when entering the password when the password was wrong.
892 2007-06-01 Murray Cumming <murrayc@murrayc.com>
894 * src/gnome/modest-main-window.c: (connect_signals):
895 * src/modest-tny-account-store.c: (get_password),
896 (modest_tny_account_store_alert): Added comments and clues and
897 commented-out code about how we currently fail to deal with connection
898 errors and wrong passwords, and how we should.
900 2007-06-01 Murray Cumming <murrayc@murrayc.com>
902 * src/widgets/modest-retrieve-combo-box.c:
903 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
904 This fixes projects.maemo.org bug NB#58472 .
906 2007-06-01 Murray Cumming <murrayc@murrayc.com>
908 * src/maemo/easysetup/modest-easysetup-wizard.c:
909 (create_page_complete_easysetup):
910 (create_page_complete_custom): Correct the last commit,
911 putting the correct sentences in the correct pages.
913 2007-06-01 Murray Cumming <murrayc@murrayc.com>
915 * src/maemo/easysetup/modest-easysetup-wizard.c:
916 (create_page_complete_custom): Show the second sentence of text
917 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
920 2007-06-01 Murray Cumming <murrayc@murrayc.com>
922 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
923 Set the leave-on-server conf key by default. This fixes
924 projects.maemo.org bug NB#59258 .
926 2007-06-01 Murray Cumming <murrayc@murrayc.com>
928 * src/maemo/modest-account-view-window.c:
929 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
930 logical ID for the confirmation messages. Fixed projects.maemo.org bug
933 2007-06-01 Murray Cumming <murrayc@murrayc.com>
935 * src/maemo/easysetup/modest-easysetup-wizard.c:
936 (create_caption_new_with_asterisk):
937 * src/maemo/modest-account-settings-dialog.c:
938 (create_caption_new_with_asterisk):
939 Uncomment the code to add the asterisk, because they are no longer in the
940 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
941 (update_incoming_server_title): Add an asterisk here too.
943 2007-06-01 Murray Cumming <murrayc@murrayc.com>
945 * src/maemo/modest-maemo-global-settings-dialog.c:
946 (current_connection): Check that we are even connected before trying to
947 get the current connection name, to prevent a warning.
949 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
950 Change the comments because tny_maemo_conic_device_connect() is now meant to
952 * src/modest-mail-operation.c:
953 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
954 make sure we have a connection and fail if we can't connect.
956 2007-05-31 Murray Cumming <murrayc@murrayc.com>
958 * src/maemo/modest-main-window.c:
959 (on_account_store_connecting_finished): Do not try to get the
960 connection ID if we are not really connected. I am surprised that
961 this signal handler is called when we are not connected.
963 2007-05-31 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-error.h:
966 * src/modest-ui-actions.c:
967 (modest_ui_actions_get_msgs_full_error_handler):
968 Renamed an enum, added comments, added an enum
969 for retrieve-limit errors.
971 * src/modest-mail-operation.c: (foreach_add_item),
972 (internal_folder_observer_update), (update_account_thread),
973 (modest_mail_operation_get_msgs_full):
974 (modest_mail_operation_update_account),
975 Added comments about how this works, and some code that should
976 (but does not) check the retrieve-limit. See the TODO comment.
978 2007-05-31 Murray Cumming <murrayc@murrayc.com>
980 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
981 Initialize help_id to fix the build. Warnings are good.
983 2007-05-31 Murray Cumming <murrayc@murrayc.com>
985 * src/widgets/modest-hbox-cell-renderer.c:
986 (modest_hbox_cell_renderer_append):
987 * src/widgets/modest-vbox-cell-renderer.c:
988 (modest_vbox_cell_renderer_append):
989 Fix the last commit by doing an extra ref.
991 2007-05-31 Murray Cumming <murrayc@murrayc.com>
993 * src/widgets/modest-hbox-cell-renderer.c:
994 (modest_hbox_cell_renderer_append):
995 * src/widgets/modest-vbox-cell-renderer.c:
996 (modest_vbox_cell_renderer_append):
997 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
998 to fix the build with Maemo Bora.
999 However, there seems to be a remaining crash, probably due to reference
1002 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1004 * src/modest-tny-account.c:
1005 (modest_tny_account_new_for_local_folders):
1006 Use hildon_file_system_info_async_new() to get a better name for
1007 the memory card account, setting it as the account name.
1008 The timing seems to work, but this is probably
1009 not the best place to do this. See the TODO comment.
1010 * src/maemo/modest-main-window.c: (create_details_widget):
1011 * src/widgets/modest-folder-view.c: (text_cell_data):
1012 Use the tny account name instead of hardcoding a name.
1014 2007-05-30 Christian Kellner <ckellner@openismus.com>
1016 * src/modest-search.c: (modest_search):
1017 Correctly set part_search_func even if we have already parsed
1018 the query and thus a valid OgsTextSearcher object.
1020 2007-05-30 Christian Kellner <ckellner@openismus.com>
1023 Search and check for libogs.
1026 Incooparte the ogs build env.
1028 * src/modest-mime-part-search-stream.c:
1029 * src/modest-mime-part-search-stream.h:
1030 Removed since we do the real searching now in modest-search.c.
1032 * src/modest-search.c:
1033 * src/modest-search.h:
1034 Implement support for ogs. We use that if available and requested
1035 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1036 should now handle the corner case when the search term is spread
1037 across multiple reads.
1038 Also the logic in modest_search () was corrected to search all
1039 requested fields until one is found.
1041 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1043 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1045 * src/modest-init.h:
1046 * src/modest-init.c: Made modest_init_local_folders() take a
1047 path and be public so we can iniitialize maildir folders on
1050 * src/modest-local-folder-info.h:
1051 * src/modest-local-folder-info.c:
1052 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1054 * src/modest-tny-account.c:
1055 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1056 still means the standard local-folders path on the local volume.
1058 * src/modest-tny-account-store.c:
1059 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1060 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1061 all accounts when that happens.
1062 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1063 this too, so it shows up in the treeview.
1065 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1067 * src/maemo/modest-maemo-global-settings-dialog.c:
1068 (current_connection):
1069 * src/widgets/modest-global-settings-dialog.c:
1070 (current_connection_default):
1071 Use the enum values instead of 0, 1 and -1,
1072 to make the code clearer.
1074 * src/modest-account-mgr-helpers.c:
1075 (modest_account_mgr_get_connection_specific_smtp): Make this code
1078 * src/modest-runtime.h:
1079 * src/modest-runtime.c:
1080 Added modest_runtime_remove_all_send_queues().
1081 * src/maemo/modest-main-window.c:
1082 (on_account_store_connecting_finished): Recreate the send queues,
1083 using the appropriate transport accounts for this new connection.
1084 Some futher adapting might be needed if the old send queues are not
1085 automatically stopped at this point.
1087 * src/modest-tny-account-store.c: (get_server_accounts):
1088 Create the connection-specific transport accounts, so that they can
1089 be found later by their ID.
1091 * src/modest-tny-account.h:
1092 * src/modest-tny-account.c:
1093 Added modest_tny_account_new_from_server_account_name().
1094 modest_tny_account_new_from_server_account(): Do not create the
1095 send queues here, because they will be
1096 recreated anyway when the connection changes for the first time.
1098 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-local-folder-info.h:
1101 * src/modest-local-folder-info.c:
1102 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1103 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1104 tbox_folder): Take a modest account name instead of a server TnyAccount,
1105 so we can have per-modest-account rather than per-transport-account
1107 We must make sure that we change or recreate the exisitng send queues
1108 when the connection changes for connection-specific transport accounts.
1110 * src/modest-tny-account-store.c:
1111 (create_per_account_local_outbox_folders): Create outboxed per modest
1112 account, not per transport account.
1114 * src/modest-tny-account.h:
1115 * src/modest-tny-account.c:
1116 (modest_tny_account_get_special_folder): For outboxes, get the
1117 parent modest account name. The account is ignored for other folders.
1118 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1119 modest account name rather than a server TnyAccount.
1121 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1123 * src/modest-tny-account.c:
1124 (modest_tny_account_new_from_server_account):
1125 Call modest_runtime_get_send_queue() immediately after creating transport
1126 accounts, so that they start trying to send email from the outbox as soon
1127 as possible at startup. This is probably what we want.
1129 * src/modest-mail-operation.c: (update_account_thread):
1130 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1131 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1132 * src/modest-tny-send-queue.h:
1133 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1134 (modest_ui_actions_on_send):
1135 Added comments about how sending works, though it needs some more work.
1137 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-tny-account.c:
1140 (modest_tny_account_get_special_folder): Add TODO because this fails when
1141 the network is busy.
1142 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1143 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1144 Do not try to show this window when there is no active account. The UI
1145 specs does not tell us what to do in this case.
1147 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1151 * src/maemo/Makefile.am:
1152 * src/widgets/Makefile.am: Some dist fixes.
1154 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1156 * src/maemo/modest-connection-specific-smtp-window.c:
1157 (on_button_edit): Make the code clearer, to prevent a double free.
1159 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1161 * src/maemo/modest-account-settings-dialog.c:
1162 (modest_account_settings_dialog_set_account_name),
1163 Check the connection-specific smtp servers checkbox if there are any.
1165 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1166 (modest_connection_specific_smtp_edit_window_init):
1167 Start with a suitable port number.
1169 * src/modest-account-mgr-helpers.h:
1170 * src/modest-account-mgr-helpers.c: Added
1171 modest_account_mgr_get_has_connection_specific_smtp().
1173 (modest_account_mgr_set_connection_specific_smtp),
1174 (modest_account_mgr_remove_connection_specific_smtp),
1175 (modest_account_mgr_get_has_connection_specific_smtp),
1176 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1177 connection-specific smtp server accounts in the account, rather than
1178 the server account conf dir.
1180 This fixes bug projects.maemo.org bug NB#58263 .
1182 * src/modest-tny-account-store.c:
1183 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1184 if there are no server accounts yet, to prevent an infinite loop when there
1185 are no accounts. Document that one must be called before the other.
1187 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1189 * src/modest-account-mgr-helpers.c:
1190 (modest_account_mgr_get_default_account): Make sure that at least
1191 one account is always the default, if there are any enabled accounts.
1192 This is just a sanity check that shouldn't be necessary.
1194 * src/modest-account-mgr-priv.c:
1195 (_modest_account_mgr_account_from_key): Unescape the conf key to
1196 get the real account name. For instance, this is an issue if a space
1197 was in the account name, which can happen because the account name
1198 is generated from the display name.
1199 (_modest_account_mgr_get_account_keyname): Always escape the
1201 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1202 Unescape the conf keys to get the real account names.
1204 For instance, previously the is-default radio button in the accounts
1205 list was not checked for any accounts at first. This fixes that,
1206 and might fix several similar bugs.
1208 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1211 Removed some debug printfs.
1213 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1215 Modest on-disk outbox directories are now here, for instance:
1216 $HOME/.modest/outboxes/<account-id-1>/outbox
1217 $HOME/.modest/outboxes/<account-id-2>/outbox
1219 $HOME/.modest/local-folders/outbox
1220 so we can have a separate outbox for each account.
1221 But they are shown as one outbox in the GtkTreeView, by using a
1222 TnyMergeFolder in a ModestTnySimpleFolderStore.
1225 * src/modest-tny-simple-folder-store.c:
1226 * src/modest-tny-simple-folder-store.h:
1227 Added ModestTnySimpleFolderStore, used to contain folders from
1228 other folder stores, such as other accounts.
1230 * src/modest-tny-outbox-account.h:
1231 * src/modest-tny-outbox-account.c:
1232 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1233 used for the per-account local outbox folders.
1235 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1236 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1237 only use this (internally) now for the non-outbox local folders.
1239 * src/modest-init.h:
1240 * src/modest-init.c: Added modest_init_one_local_folder(), for
1241 setting up the directory structure for each local folder.
1243 * src/modest-local-folder-info.c:
1244 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1245 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1247 * src/modest-local-folder-info.h:
1248 * src/modest-tny-account-store.c: (on_account_removed),
1249 (on_account_changed), (create_per_account_local_outbox_folders),
1250 (get_server_accounts), (modest_tny_account_store_get_accounts),
1251 (modest_tny_account_store_get_tny_account_by_account),
1252 (modest_tny_folder_store_is_virtual_local_folders):
1254 * src/modest-tny-account.h:
1255 * src/modest-tny-account.c:
1256 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1257 to create an on-disk per-account local outbox folder for each
1259 (create_per_account_local_outbox_folders): Create a local outbox folder
1260 for each transport account.
1261 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1262 for all local folders.
1264 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1265 instead of using g_object_get/set() directly. It is clearer.
1267 (modest_tny_folder_store_get_message_count),
1268 (modest_tny_folder_store_get_local_size
1269 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1270 because we now use these with non-acount folder stores.
1272 (modest_tny_account_get_special_folder),
1273 (modest_tny_account_new_from_server_account),
1274 (modest_tny_account_new_from_account):
1275 (recurse_folders): Adjust to the new outbox system.
1277 * src/modest-tny-folder.h:
1278 * src/modest-tny-folder.c:
1279 (modest_tny_folder_is_local_folder),
1280 (modest_tny_folder_get_local_folder_type),
1281 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1283 * src/widgets/modest-main-window.h:
1284 * src/maemo/modest-main-window.c: (create_details_widget),
1285 (modest_main_window_set_contents_style): Show details for any folder store,
1288 (modest_tny_folder_get_rules):
1289 Remove the const. C does not support constness enough for this.
1291 * src/modest-ui-actions.c:
1292 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1293 make all outboxes appear as one, in the usual local-folders tree node.
1295 (set_active_account_from_tny_account),
1296 (modest_ui_actions_on_folder_selection_changed):
1297 * src/widgets/modest-folder-view.c: (text_cell_data),
1298 (icon_cell_data), (filter_row),
1299 (add_account_folders_to_merged_folder),
1300 (add_account_folders_to_simple_folder_store), (),
1301 (get_cmp_rows_type_pos), (cmp_rows),
1302 (modest_folder_view_set_account_id_of_visible_server_account):
1303 Adjust to the new outbox system, using generic folder stores and folders
1304 in the GtkTreeModel.
1306 2007-05-23 Christian Kellner <ckellner@openismus.com>
1308 * src/modest-mail-operation.c:
1309 (modest_mail_operation_update_account):
1310 Use info->max_size instead of unintialized local var [small
1311 build fix]. (Added TODO to review that change since I don't
1314 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1316 * libmodest-dbus-client/libmodest-dbus-client.c:
1317 (libmodest_dbus_client_compose_mail): function added
1318 * src/dbus_api/modest-dbus-api.h:
1319 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1320 (on_compose_mail): Implementation of the SendAsMail functionality
1322 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1324 * src/modest-account-mgr.c:
1325 (modest_account_mgr_add_server_account): Set the secure-connection
1326 conf key for transport accounts as well as store accounts. I don't know
1327 why the if was there. For instance, this makes sure that we use SSL
1328 for the gmail preset from the easysetup wizard.
1330 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1332 * src/gnome/modest-main-window.c:
1333 (on_account_store_connecting_finished), (connect_signals):
1334 * src/maemo/modest-main-window.c:
1335 (on_account_store_connecting_finished), (connect_signals),
1336 (modest_main_window_new):
1337 Handle TnyAccountStore::connecting-finished instead of
1338 TnyDevice::connection-changed, because we cannot actually perform
1339 operations on accounts until TnyAccountStore has itself responded to
1340 the TnyDevice::connection-changed signal. This prevents a GError from
1342 Do not try to update at startup, because we (at least on scratchbox)
1343 already do an update at startup when the device goes online.
1344 This prevents a GError from tinymail.
1345 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1346 Added TODO about stopping simultaneous operations.
1348 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1350 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1351 * src/modest-mail-operation-queue.c:
1352 (modest_mail_operation_queue_remove):
1353 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1354 about where they happened.
1356 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1358 * src/modest-ui-actions.c:
1359 (modest_ui_actions_on_password_requested): Make sure that the remember
1360 output parameter is always TRUE.
1362 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1364 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1365 Show a OK/Cancel dialog if the error is a question, though we still do not
1366 know anything more about what we are asking the user.
1367 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1368 Fix an uninitialized variable (helper). This is a logic error, however.
1370 2007-05-21 Christian Kellner <ckellner@openismus.com>
1372 * src/modest-search.h:
1373 Correct bit shifting in the ModestSearchFlags enum.
1375 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1377 * src/modest-tny-account.c:
1378 (modest_tny_account_new_from_server_account): Do not use the lsub and
1379 check-all hard-coded IMAP options when using POP.
1381 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1383 * src/modest-tny-account.c:
1384 (modest_tny_account_new_from_server_account):
1385 Use NULL for the secure-auth method for POP when Password auth has been
1386 specified by the user, as we already do for IMAP. "auth=Login" causes
1387 an error from camel or the server.
1389 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1391 * src/maemo/modest-account-settings-dialog.c:
1392 (create_page_account_details),
1393 (modest_account_settings_dialog_set_account_name):
1394 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1395 for the leave-on-server checkbox, rathr than just the checkbox, when
1396 the protocol is not POP.
1398 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1400 * src/widgets/modest-account-view.c:
1401 * src/widgets/modest-account-view.h:
1402 Added modest_account_view_select_account() which will be useful later
1403 to asynchronously re-select the edited account.
1405 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1407 * src/maemo/modest-account-settings-dialog.c:
1408 (modest_account_settings_dialog_set_account_name):
1409 Automatically choose the port numbers based on the secure authentication
1410 methods, if they have not been chosen before.
1411 This fixes projects.maemo.org bug NB#56273 .
1413 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1415 * src/maemo/modest-main-window-ui.h:
1416 * src/modest-ui-actions.c:
1417 * src/modest-ui-actions.h:
1418 Connect the Tools/SMTP Servers menu item to
1419 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1420 SMTP servers dialog, as in the UI specification and saves changes when it
1421 is closed. This fixed projects.maemo.org bug NB#56305 .
1423 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/modest-connection-specific-smtp-window.c:
1426 (modest_connection_specific_smtp_window_init):
1427 Use gtk_window_set_default_size() to make this window big enough, so
1428 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1430 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1432 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1433 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1434 (modest_connection_specific_smtp_edit_window_init),
1435 Do not try to connect to a combobox signal before the combobox exists.
1436 This fixes the cras in projects.maemo.org bug NB#56288 .
1437 (modest_connection_specific_smtp_edit_window_get_settings):
1438 Remove the server_account_name parameter which was being checked for NULL
1439 though it was not used.
1441 * src/maemo/modest-connection-specific-smtp-window.c:
1442 (modest_connection_specific_smtp_window_fill_with_connections),
1443 (on_button_edit), (modest_connection_specific_smtp_window_init):
1444 Correct the number of treemodel columns to prevent a warning.
1445 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1446 libconic does not work.
1448 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1450 * src/modest-tny-account.c:
1451 (modest_tny_account_new_from_server_account):
1452 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1453 SMTP when "None" was chosen by the user. However, with my SMTP server that
1454 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1457 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1459 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1460 to explain the memory management issue with the ID in the ModestPair.
1462 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1463 (add_sending_page), (modest_account_assistant_finalize):
1464 * src/gnome/modest-gnome-global-settings-dialog.c:
1465 (create_updating_page), (create_composing_page):
1466 * src/gnome/modest-msg-edit-window.c: (get_transports),
1467 (init_window), (modest_msg_edit_window_finalize),
1468 (modest_msg_edit_window_get_msg_data):
1469 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1470 * src/gnome/modest-transport-widget.c:
1471 (modest_transport_widget_finalize), (smtp_configuration):
1472 * src/maemo/modest-maemo-global-settings-dialog.c:
1473 (create_updating_page), (create_composing_page):
1474 * src/maemo/modest-msg-edit-window.c: (get_transports),
1475 (init_window), (modest_msg_edit_window_finalize),
1476 (modest_msg_edit_window_get_msg_data),
1477 (modest_msg_edit_window_free_msg_data):
1478 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1479 (modest_store_widget_finalize):
1480 * src/maemo/modest-transport-widget.c:
1481 (modest_transport_widget_finalize), (smtp_configuration):
1482 * src/modest-main.c: (send_mail):
1483 * src/widgets/modest-combo-box.h:
1484 * src/widgets/modest-global-settings-dialog-priv.h:
1485 * src/widgets/modest-global-settings-dialog.c:
1486 (modest_global_settings_dialog_finalize):
1487 * src/widgets/modest-msg-edit-window.h:
1488 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1489 as long as the combo box, to prevent use of freed memory for the ID.
1491 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1493 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1494 get_accounts(), to make this clearer. Do not check for the enabled gconf
1495 key, because we do not use this for server accounts (at least, not yet).
1496 This allows us to send email again.
1498 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1500 * src/maemo/modest-platform.c:
1501 (on_modest_conf_update_interval_changed), (modest_platform_init):
1502 Only respond to this particular key change. All these strcmp()s cannot be
1505 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1507 * src/maemo/modest-maemo-global-settings-dialog.c:
1508 (current_connection): Prevent a crash in scratchbox when
1509 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1510 * src/maemo/modest-platform.c:
1511 (on_modest_conf_update_interval_changed), (modest_platform_init):
1512 Get the update interval from gconf and reset it when the gconf key changes.
1514 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1516 * src/modest-protocol-info.c:
1517 * src/modest-protocol-info.h: Adde enum-specific get functions,
1518 instead of using a ModestProtocolType enum parameter.
1520 * src/gnome/modest-account-assistant.c:
1521 * src/gnome/modest-store-widget.c:
1522 * src/gnome/modest-store-widget.h:
1523 * src/gnome/modest-transport-widget.c:
1524 * src/gnome/modest-transport-widget.h:
1525 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1526 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1527 * src/maemo/easysetup/modest-easysetup-wizard.c:
1528 * src/maemo/modest-account-settings-dialog.c:
1529 * src/maemo/modest-account-settings-dialog.h:
1530 * src/maemo/modest-store-widget.c:
1531 * src/maemo/modest-store-widget.h:
1532 * src/maemo/modest-transport-widget.c:
1533 * src/maemo/modest-transport-widget.h:
1534 * src/modest-account-mgr-helpers.c:
1535 * src/modest-account-mgr-helpers.h:
1536 * src/modest-account-mgr.c:
1537 * src/modest-account-mgr.h:
1538 * src/modest-tny-account.c:
1539 * src/modest-tny-folder.c:
1540 * src/widgets/modest-account-view.c:
1541 * src/widgets/modest-retrieve-combo-box.c:
1542 * src/widgets/modest-retrieve-combo-box.h:
1543 * src/widgets/modest-secureauth-combo-box.c:
1544 * src/widgets/modest-serversecurity-combo-box.c:
1545 * src/widgets/modest-serversecurity-combo-box.h:
1546 * tests/check_account-mgr.c:
1547 Use the specific functions, and use the re-renamed enum values for GNOME too.
1549 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1551 * src/modest-pair.h:
1552 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1553 so we can get the second based on the first.
1555 * src/maemo/modest-account-settings-dialog.h:
1556 * src/maemo/modest-account-settings-dialog.c:
1557 Added get_supported_secure_authentication_methods(), though it is mostly
1558 commented-out for now until the necessary API is committed to tinymail.
1559 (modest_account_settings_dialog_set_account_name),
1560 (save_configuration): Request the supported authentication methods from the
1561 server, so we can choose a working method.
1563 * src/modest-tny-account-store.h:
1564 * src/modest-tny-account-store.c:
1565 (modest_tny_account_store_get_session): Rename from
1566 tny_account_store_get_session().
1568 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1570 * src/modest-protocol-info.h: Split the ModestProtocol enum
1571 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1572 There was no need to have these unrelated values in one enum.
1574 * src/: many files: Adapted to changed enum. This makes the code a bit
1575 clearer, and the compiler could catch some errors.
1577 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1579 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1580 Show the detailed internal camel error message when an error happens
1581 during the configuration, so that our testers can give us more clues.
1582 For instance, in projects.maemo.org bug NB#56910 .
1584 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-tny-account.c:
1587 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1588 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1590 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1592 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1593 * src/maemo/modest-account-settings-dialog.c:
1594 (modest_account_settings_dialog_set_account_name),
1595 (save_configuration): For the incoming secure authentication checkbox,
1596 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1597 the UI specification. PLAIN does not seem to be supported for most IMAP
1598 servers anyway, and I am not sure what it would mean.
1599 However, we probably need to discover which of the secure-authentication
1600 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1601 * src/modest-account-mgr-helpers.c:
1602 (modest_account_mgr_get_server_account_data):
1604 * src/modest-tny-account.c:
1605 (modest_tny_account_new_from_server_account):
1606 Use tny_account_set_mech() to set secure-authentication methods,
1607 with some special-casing for IMAP, based on my observations of how
1610 * src/modest-account-mgr-helpers.h:
1611 * src/modest-account-mgr.c:
1612 * src/modest-defs.h: Comment that the URI is only used for local folders.
1614 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1616 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1617 parameter const, just to be neat.
1618 * src/modest-text-utils.c: (modest_text_utils_inline):
1619 End g_strconcat() with NULL, as its documentation says. This is almost
1620 certainly the cause of my crash at startup on the device. Interestingly,
1621 valgrind doesn't tell us about these errors.
1623 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1625 * scripts/build-packages: Added more precise comments about how to use
1626 this script, though I still get this error:
1627 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1628 error building tinymail
1630 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1632 * src/maemo/modest-main-window.c: (on_account_update):
1633 Very slight cleanup, hoping to make it simpler to discover what causes
1634 a crash here sometimes.
1636 * src/modest-tny-account.c:
1637 (modest_tny_account_new_from_server_account): Set the port. Added
1638 comments about the options and a TODO comment because I need to find out
1639 how to specify the secure authentication method.
1641 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1643 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1644 changed CFlags paths form modest to libmodest
1646 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1648 * src/modest-account-mgr-helpers.c:
1649 (modest_account_mgr_get_server_account_data),
1650 (modest_account_mgr_free_server_account_data):
1651 * src/modest-account-mgr-helpers.h:
1652 * src/modest-account-mgr.c:
1653 (modest_account_mgr_add_server_account):
1654 * src/modest-defs.h:
1655 * src/modest-tny-account.c:
1656 (modest_tny_account_new_from_server_account):
1657 Determine the options for tny_camel_account_add_option() here,
1658 based on the settings, rather than storing them directly in gconf.
1660 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1662 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1663 Show a more friendly error dialog now that we expect (from the tinymail
1664 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1666 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1668 * src/maemo/modest-main-window.c: (on_account_update): Check that
1669 account_name is not NULL, to prevent a crash at startup that I am
1670 seeing on the N800. I do wonder why it is NULL.
1672 * src/maemo/easysetup/modest-easysetup-wizard.c:
1673 (create_page_user_details):
1674 * src/maemo/modest-account-settings-dialog.c:
1675 (create_page_user_details), (create_page_outgoing):
1676 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1677 (modest_connection_specific_smtp_edit_window_init):
1678 * src/modest-ui-actions.c:
1679 (modest_ui_actions_on_password_requested):
1680 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1681 might do something useful with the on-screen keyboard.
1683 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/modest-main-window.c: (on_account_update):
1686 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1687 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1689 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1691 * src/modest-tny-account-store.c: (on_account_changed):
1692 Correct the signature of this signal handler.
1694 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1696 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1697 Show a HildonNote instead of a GtkDialog for Maemo.
1699 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1701 * src/widgets/modest-account-view.h:
1702 * src/widgets/modest-account-view.c: (on_account_changed),
1703 (on_account_removed). Added a boolean flag, set/unset by
1704 modest_account_view_block_conf_updates(),
1705 modest_account_view_unblock_conf_updates() to prevent unnecessary
1706 updates, but this is not very useful because the gconf notifications are
1707 so delays (maybe only on Maemo Bora).
1708 So auto-updating is turned off, and these functions do an explicit
1709 update when necessary.
1710 However, something else is still doing too much work when adding/removing
1711 accounts, probably in another part of the application.
1713 * src/maemo/modest-account-view-window.c:
1714 (on_delete_button_clicked), (on_edit_button_clicked),
1715 (on_new_button_clicked): Use the new functions.
1717 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1719 * src/modest-account-mgr-helpers.c:
1720 (modest_account_mgr_set_first_account_as_default):
1721 Sort the list of names alphabetically-by-title, so we choose the first one
1723 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1724 alphabetically by the title.
1726 This fixes projects.maemo.org bug NB#56418 .
1728 * src/modest-account-mgr-priv.c:
1729 (_modest_account_mgr_account_from_key):
1730 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1731 avoid a valgrind error, and possible random behaviour.
1733 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1736 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1737 tinymail documentation to say that this can be expected.
1738 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1739 pretty, and should not happen, but I would prefer to know when it does.
1741 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1743 * configure.ac: When using the older hildon version, probably on Bora,
1744 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1746 * src/widgets/modest-attachment-view.c:
1747 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1750 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1752 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1753 Implemented the prototype. Can be tested with
1754 tests/dbus_api/test_open_message:
1756 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1758 * src/modest-tny-account-store.c:
1759 (modest_tny_account_store_instance_init), (get_password):
1760 * src/modest-ui-actions.c:
1761 (modest_ui_actions_on_password_requested):
1762 Do not store the password in gconf, because this function is called
1763 for non-remembered passwords. Actually use the cached (in the hash map)
1764 password instead of releasing it.
1765 The password will now not be remembered if it is asked via the protected
1766 password dialog, as per the UI spec.
1768 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1770 * src/modest-defs.h:
1771 * src/modest-account-mgr-helpers.h:
1772 * src/modest-account-mgr-helpers.c:
1773 Added modest_server_account_get_username_has_succeeded(),
1774 modest_server_account_set_username_has_succeeded().
1775 (modest_server_account_set_username),
1776 Reset the has-succeeded flag if the username changes.
1778 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1779 * src/maemo/modest-connection-specific-smtp-window.c:
1780 (modest_connection_specific_smtp_window_save_server_accounts):
1781 Use modest_server_account_set_username() instead of using
1782 modest_conf_set_string() directly, so that the has-succeeded flag is always
1785 * src/modest-ui-actions.c:
1786 (modest_ui_actions_on_password_requested): Dim the username entry if
1787 the username has ever worked, as per the UI spec.
1789 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-tny-account-store.c: (get_password):
1792 * src/modest-ui-actions.c:
1793 (modest_ui_actions_on_password_requested):
1794 Allow the username to be changed too, though there is more work to
1795 be done on exactly how this behaves.
1797 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1799 * src/modest-account-mgr-helpers.h:
1800 * src/modest-account-mgr-helpers.c:
1801 Added modest_account_mgr_get_display_name(),
1802 modest_server_account_get_username(),
1803 modest_server_account_set_username(),
1804 modest_server_account_set_password(),
1805 modest_server_account_get_hostname() functions so we do not need to
1806 use the conf API directly.
1808 * src/maemo/modest-main-window.c: (connect_signals):
1809 Actually connect ot the ModestAccountStore::request-password signal,
1810 so that we show the dialog when the password is requested by Tinymail,
1811 for isntance if it is empty.
1813 * src/modest-marshal.list:
1814 * src/modest-tny-account-store.c:
1815 (modest_tny_account_store_class_init), (get_password),
1816 (modest_tny_account_store_alert):
1817 * src/modest-tny-account-store.h:
1818 * src/modest-ui-actions.h:
1819 * src/modest-ui-actions.c:
1820 (modest_ui_actions_on_password_requested):
1821 Change the signal parameters, so it is obvious that we are providing
1822 the non human-readable server name, and receiving both the username
1823 and password, though changing of the username is not yet implemented.
1824 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1825 for the GNOME version.
1827 This should fix the projects.maemo.org bug NB#56209, though it does not
1828 work on Bora, because the gconf_client_get() for the password fails
1829 immediately after we save it with gconf_client_set().
1831 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1834 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1835 caused an undefined symbol error:
1836 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1838 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1840 * src/modest-tny-account-store.c:
1841 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1842 using a GError instead of a string message, so we can translate it in
1845 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1847 * src/maemo/modest-address-book.c:
1848 (modest_address_book_check_names):
1849 * src/maemo/modest-msg-view-window.c:
1850 (modest_msg_view_window_clipboard_owner_change):
1851 * src/modest-init.c: (modest_init_init_ui):
1852 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1853 (update_folders_cb), (modest_mail_operation_update_account):
1854 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1855 (modest_ui_actions_on_msg_attachment_clicked),
1856 (modest_ui_actions_on_msg_recpt_activated):
1857 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1858 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1859 (modest_msg_view_search_next):
1860 * src/widgets/modest-recpt-editor.c:
1861 (modest_recpt_editor_on_button_release_event),
1862 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1863 g_message(). At this point we should only be seeing interesting errors on
1864 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1866 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1868 (modest_wizard_dialog_force_title_update):
1869 * src/maemo/easysetup/modest-wizard-dialog.h:
1870 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1871 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1872 can update the title when appropriate. Otherwise the title is wrong if the
1873 pages are added after adding the notebook to the dialog.
1874 This must be a problem in HildonWizardDialog too.
1875 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1877 * src/maemo/easysetup/modest-easysetup-wizard.c:
1878 (create_subsequent_customsetup_pages),
1879 (create_subsequent_easysetup_pages):
1880 Call modest_wizard_dialog_force_title_update() so that the title is
1881 correct even with GTK+ < 2.10.
1882 This fixes projects.maemo.org bug NB#56145 .
1884 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/modest-platform.c:
1887 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1888 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1891 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1893 * src/widgets/modest-window.h:
1894 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1895 and modest_window_save_state(), which invokes it.
1897 * src/widgets/modest-window-mgr.h:
1898 * src/widgets/modest-window-mgr.c:
1899 Added modest_window_mgr_save_state_for_all_windows(), which calls
1900 the save_state vfunc on all registered windows, if implemented.
1902 * src/gnome/modest-msg-edit-window.c:
1903 * src/gnome/modest-msg-view-window.c:
1904 * src/maemo/modest-msg-edit-window.c:
1905 * src/maemo/modest-msg-view-window.c:
1906 * src/maemo/modest-main-window.c:
1907 Specify the existing save_settings functions as implementations of
1908 ModestWindow::save_state_func().
1910 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1911 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1912 enabling hibernation, for instance.
1914 We may need to do the same thing for restoring settings.
1917 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1919 * src/widgets/modest-window-mgr.c:
1920 * src/widgets/modest-window-mgr.h:
1921 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1922 modest_window_mgr_get_hibernation_is_prevented().
1924 * src/maemo/modest-main-window.c:
1925 (on_hildon_program_is_topmost_notify): Prevent hibernation
1926 (possible when the application goes to the background in the WM),
1927 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1929 * src/maemo/easysetup/modest-easysetup-wizard.c:
1930 (modest_easysetup_wizard_dialog_init):
1931 * src/maemo/modest-account-settings-dialog.c:
1932 (modest_account_settings_dialog_init):
1933 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1934 (modest_connection_specific_smtp_edit_window_init):
1935 * src/maemo/modest-connection-specific-smtp-window.c:
1936 (modest_connection_specific_smtp_window_init):
1937 * src/maemo/modest-signature-editor-dialog.c:
1938 (modest_signature_editor_dialog_init):
1939 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1940 prevent hibernation while any of these account settings dialogs are open.
1942 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1944 * src/maemo/Makefile.am:
1945 * src/maemo/modest-osso-state-saving.c:
1946 * src/maemo/modest-osso-state-saving.h: Added
1947 modest_osso_load_state() and modest_osso_save_state() though they do
1948 nothing now. They should iterate through all the open windows and load/save
1950 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1951 save state when closing.
1953 * src/maemo/modest-main-window.c:
1954 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1955 Add a notification handler for the HildonProgram::is-topmost property,
1956 so we can allow hibernation when the application goes into the background.
1957 But we still need to detect when the accounts setup windows are open so
1958 we can stop hibernation when they are open.
1959 To do this, I also added the main window the HildonProgram. This might have
1960 other side-effects/benefits, and should maybe be done for other windows.
1962 * src/maemo/modest-osso-autosave-callbacks.h:
1963 * src/maemo/modest-osso-autosave-callbacks.c:
1964 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1965 though it does not do anything yet, and we might never need this to do
1966 anything. For instance, we already save drafts.
1968 * src/maemo/modest-platform.c: (modest_platform_init):
1969 Specify the libosso auto-save callback.
1971 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1973 * src/maemo/modest-platform.c:
1974 (modest_platform_set_update_interval):
1975 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1976 aparently stays valid between application instances, so we can use this
1977 to remove and reset it later. According to a maemo-developers email from
1980 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1982 * configure.ac: Depend on libalarm for Maemo.
1984 * src/dbus_api/modest-dbus-api.h:
1985 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1986 (on_send_receive), (modest_dbus_req_handler):
1987 Handle a SEND_RECEIVE D-Bus method.
1989 * libmodest-dbus-client/libmodest-dbus-client.c:
1990 (libmodest_dbus_client_send_and_receive):
1991 * libmodest-dbus-client/libmodest-dbus-client.h:
1992 Add C convenience functions for calling the new D-Bus method.
1994 * src/modest-platform.h:
1995 * src/gnome/modest-platform.c:
1996 * src/maemo/modest-platform.c:
1997 Added modest_platform_set_update_interval(), which uses the
1998 alarmd API on Maemo.
1999 (modest_platform_init),
2000 Call modest_platform_set_update_interval(), using a hard-coded
2001 interval for now (until the global settings dialog is implemented),
2002 though I am not sure that this makes sense yet.
2004 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2006 * src/dbus_api/modest-dbus-callbacks.c:
2007 (modest_osso_cb_hw_state_handler):
2008 * src/dbus_api/modest-dbus-callbacks.h:
2009 * src/maemo/modest-platform.c: (modest_platform_init):
2010 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2011 in case this has some effect on the ability for Maemo to ping the
2014 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2016 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2017 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2018 warning. It is probably a logic error, but I need to fix the build.
2020 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2022 * src/modest-account-mgr.h:
2023 * src/modest-account-mgr.c:
2024 (modest_account_mgr_account_names): Add a gboolean enabled_only
2025 parameter, so we can get lists of onlt the enabled accounts.
2027 (modest_account_mgr_add_account),,
2028 (modest_account_mgr_account_with_display_name_exists):
2029 * src/maemo/modest-msg-edit-window.c: (get_transports):
2030 * src/modest-account-mgr-helpers.c:
2031 (modest_account_mgr_set_first_account_as_default):
2032 * src/modest-init.c: (init_default_account_maybe):
2033 * src/modest-tny-account-store.c: (get_accounts):
2034 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2035 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2036 * tests/check_account-mgr.c: (START_TEST):
2037 Provide the extra parameter, as appropriate.
2039 * src/widgets/modest-account-view.c: (update_account_view):
2040 Do not show disabled accounts (meaning that there is no way to
2041 enable/disable accounts in the UI (the feature is not in our UI
2042 specification), so we can use this internally only to mark unfinished
2043 or temporary account data.
2045 * src/maemo/easysetup/modest-easysetup-wizard.c:
2046 (create_account): Add boolean enable parameter, so we can specify FALSE
2047 to create the temporary account.
2048 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2049 (on_before_next): When finishing, when there is a temporary account, just
2051 Also, use a timeout to delay the showing of the dialog until gconf is likely
2052 to return correct information, due to a maemo gconf bug that is fixed in
2053 osso 1.1, but not yet in Bora.
2054 However, the dialog stays on screen after it is destroyed.
2056 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2057 for invalid data when cancelling. Use a hildon note instead of a dialog
2058 to complain about invalid data. Do not show the account-saved note if the
2059 account is disabled (a temporary account that will not really be saved for use
2062 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2064 * src/modest-account-mgr-helpers.h:
2065 * src/modest-account-mgr-helpers.c:
2066 Added modest_account_mgr_unset_default_account(),
2067 Added modest_account_mgr_set_first_account_as_default().
2069 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2070 If it was the default account, unset the default account name.
2072 * src/maemo/modest-account-view-window.c:
2073 (on_delete_button_clicked): If it was the default account,
2074 set the first remaining account as the default instead.
2076 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2077 a NULL account or a NULL default account, to prevent a crash. This should
2078 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2081 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2083 * src/widgets/modest-recpt-editor.c:
2084 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2085 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2086 TODO comment for this. This fixes the build.
2088 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2089 be the best place for it. This will in future update all auto-update accounts,
2090 rather than just the current/default account, when that gconf key exists.
2091 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2092 if there are no accounts, before calling do_send_receive().
2093 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2095 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2096 * src/maemo/modest-main-window-ui.h:
2097 * src/maemo/modest-main-window.c: (on_connection_changed),
2098 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2099 directly, becaue the signal handler does more.
2101 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2103 * src/modest-account-mgr-helpers.c:
2104 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2105 for the case that the account does not exist.
2107 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2108 (equivalent to the modest account name) rather than the tinymail account name
2109 (equivalent to the modest account title - human readable) to get the account data.
2110 Check for null account data to prevent the crash, and add a TODO comment saying that
2111 this needs fixing because it is using the server account name instead of the account name.
2113 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2115 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2116 * src/maemo/modest-account-settings-dialog.c: (show_error),
2118 Use hildon_note_new_information() for informative and error messages,
2119 which seems to be expected for Maemo applications (no documentation that I know of
2120 says this). I am surprised that there is no distinction between info and error
2123 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2125 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2126 it is easy to find where this is used.
2128 * src/maemo/easysetup/modest-easysetup-wizard.c:
2129 (create_page_welcome), (create_page_account_details),
2130 (create_page_user_details), (create_page_complete_easysetup),
2131 (create_page_custom_incoming), (create_page_custom_outgoing),
2132 (create_page_complete_custom):
2133 * src/maemo/modest-account-settings-dialog.c:
2134 (create_page_account_details), (create_page_user_details),
2135 (create_page_incoming), (create_page_outgoing):
2136 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2137 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2138 (modest_connection_specific_smtp_edit_window_init):
2139 * src/maemo/modest-connection-specific-smtp-window.c:
2140 (modest_connection_specific_smtp_window_init):
2141 * src/maemo/modest-signature-editor-dialog.c:
2142 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2143 and scrolling policy as per the Email Application Layout Guide, if I have
2146 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2149 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2150 which were empty, because these vfuncs have been removed from TnyAccountStore.
2151 This fixes the build.
2153 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2155 * src/maemo/modest-main-window.c:
2156 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2157 showing/hiding it. Added TODO because it probably should not be NULL.
2158 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2159 because unnecessary g_warnings() make degugging difficult.
2161 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2163 * src/maemo/modest-msg-edit-window.c:
2164 (modest_msg_edit_window_select_color),
2165 (modest_msg_edit_window_select_background_color): 2 const corrections and
2166 moving 2 #endifs before closing brackets, to fix the build.
2168 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2170 * src/maemo/easysetup/modest-easysetup-wizard.h:
2171 * src/maemo/easysetup/modest-easysetup-wizard.c:
2172 (modest_easysetup_wizard_dialog_finalize),
2173 (on_button_edit_advanced_settings), (create_page_complete_custom),
2174 (on_response), (create_account):
2175 Implement the Advanced Settings edit button, by saving the account information,
2176 for the Advanded Settings dialog to use directly from gconf, and removing it
2177 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2178 Bug #5533 in the projects.maemo.org bugzilla.
2180 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2182 * src/maemo/modest-msg-view-window.c:
2183 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2184 when opening a message window.
2186 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2188 * src/maemo/easysetup/modest-easysetup-wizard.c:
2189 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2192 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2193 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2194 gconf settings. I probably added more checks than necessary, but that is safer.
2196 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2197 variable to fix the build, but this seems to be used when it is still NULL.
2199 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2201 * src/modest-platform.h:
2202 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2203 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2204 * src/modest-main.c: Implement this function so we can avoid using
2205 maemo-specific API from cross-platform code.
2207 * src/modest-tny-account-store.c:
2208 (get_smtp_specific_transport_account_for_open_connection):
2209 * src/modest-ui-actions.c: (check_for_connection),
2210 (modest_ui_actions_on_item_not_found):
2211 Use modest_platform_connect_and_wait() and put #idefs around other
2212 maemo-specific code, because only maemo currently has a way to
2213 identify connection names.
2215 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2217 * src/modest-tny-account-store.h:
2218 * src/modest-tny-account-store.c:
2219 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2220 the connection-specific SMTP server settings in the configuration.
2222 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2224 * src/maemo/modest-main-window.c: (on_connection_changed),
2226 * src/modest-main.c: (main), (start_ui), (send_mail):
2227 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2228 that is what is intended.
2230 * src/modest-ui-actions.c: (action_send), (action_receive),
2231 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2232 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2233 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2234 SMTP server is used when it is specified.
2236 (modest_ui_actions_on_send_receive):
2237 Check that a connection is open before proceeding.
2238 Receive and then send, instead of vice-versa, as per the specification.
2240 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2242 * src/modest-mail-operation.c:
2243 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2244 though I guess it should be something other than NULL.
2246 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2248 * src/maemo/easysetup/modest-easysetup-wizard.c:
2249 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2250 combo twice, to avoid an g_warning and to make it visible again.
2251 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2252 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2253 (already intended) dereference when detaching, because we then recreate the menu.
2254 But I am not sure why the warning was happening, and it is possible that this is a memory
2257 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2259 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2260 and uri_parse_mailto() utility functions.
2261 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2263 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2265 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2267 * src/dbus_api/modest-dbus-api.h:
2268 * src/dbus_api/modest-dbus-callbacks.c:
2269 Use an idle callback to execute the modest code in the application's own thread.
2270 Remove the helloworld example method.
2271 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2272 parsed, and the open-message method is not implemented because this is not yet implemented in
2274 * libmodest-dbus-client/libmodest-dbus-client.c:
2275 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2276 (libmodest_dbus_client_open_message):
2277 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2279 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2280 body without crashing.
2282 * tests/dbus_api/Makefile.am:
2283 * tests/dbus_api/test_mail_to.c:
2284 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2286 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2288 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2289 Added file to fix the build. Sorry.
2291 * src/dbus_api/Makefile.am:
2292 * src/dbus_api/modest-dbus-api.h:
2293 * src/dbus_api/modest-dbus-callbacks.h:
2294 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2295 (modest_dbus_req_handler):
2296 Put constants in a separate header so it can be reused by the
2297 client library, without duplication
2299 * libmodest-dbus-client/Makefile.am:
2300 * libmodest-dbus-client/libmodest-dbus-client.c:
2301 (libmodest_dbus_client_call_helloworld),
2302 (libmodfest_dbus_client_send_mail),
2303 (libmodfest_dbus_client_mailto),
2304 (libmodfest_dbus_client_open_message):
2305 * libmodest-dbus-client/libmodest-dbus-client.h:
2306 (Partly) Implement a send_mail D-Bus method.
2308 * tests/dbus_api/Makefile.am:
2309 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2310 the send_email D-Bus method.
2312 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2316 * libmodest-dbus-client/Makefile.am:
2317 * libmodest-dbus-client/libmodest-dbus-client.c:
2318 * libmodest-dbus-client/libmodest-dbus-client.h:
2319 * tests/dbus_api/Makefile.am:
2320 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2321 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2323 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/easysetup/modest-easysetup-wizard.c:
2326 (create_page_account_details):
2327 * src/maemo/modest-account-settings-dialog.c:
2328 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2329 widgets, because this might not be the default in future versions of the Maemo GTK+.
2330 However, I can not not get capitalization to work even in a simple test case.
2332 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2334 * src/maemo/easysetup/modest-easysetup-wizard.c:
2335 (create_page_custom_incoming), (create_page_custom_outgoing):
2336 * src/maemo/modest-account-settings-dialog.c:
2337 (create_page_account_details), (create_page_incoming),
2338 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2339 instead of using gtk_check_button_with_label(), so they are aligned like the other
2340 widgets, as per the UI spec.
2342 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2344 * src/maemo/easysetup/modest-easysetup-wizard.c:
2345 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2346 * src/widgets/modest-validating-entry.c:
2347 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2348 Modest prefix instead of an EasySetup prefix.
2350 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2352 * src/widgets/modest-validating-entry.h:
2353 * src/widgets/modest-validating-entry.c: (on_insert_text),
2354 Added easysetup_validating_entry_set_max_func(), used to set a callback
2355 to call when the max number of characters is reached. GtkEntry has a max-length
2356 already but is silent about it.
2358 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2359 (create_page_account_details), (create_page_user_details),
2361 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2362 (create_page_account_details), (create_page_user_details),
2363 (create_page_outgoing):
2364 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2365 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2366 the UI spec, when the user tries to enter more than the max number of characters.
2368 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2370 * src/maemo/easysetup/modest-easysetup-wizard.c:
2371 (create_page_user_details), (create_page_custom_incoming),
2372 (create_page_custom_outgoing):
2373 * src/maemo/modest-account-settings-dialog.c:
2374 (create_page_user_details), (create_page_incoming),
2375 (create_page_outgoing):
2376 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2377 (modest_connection_specific_smtp_edit_window_init):
2378 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2379 not appropriate. Bad Maemo-specific defaults!.
2381 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2383 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2384 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2385 (modest_signature_editor_dialog_set_settings):
2386 Disable the label and textview when the checkbox is disabled, and use the
2387 specified (UI spec) default signature text.
2389 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2391 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2392 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2394 * src/modest-defs.h:
2395 * src/modest-account-mgr-helpers.h:
2396 * src/modest-account-mgr-helpers.c:
2397 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2399 * src/maemo/Makefile.am:
2400 * src/maemo/modest-signature-editor-dialog.c:
2401 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2404 * src/maemo/modest-account-settings-dialog.h:
2405 * src/maemo/modest-account-settings-dialog.c:
2406 (modest_account_settings_dialog_finalize), (on_button_signature),
2407 (save_configuration): Use the new dialog when the Edit button is pressed, and
2408 save the changes if necessary, as per the UI spec.
2410 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2412 * src/maemo/Makefile.am:
2413 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2414 based on maemo-develoers email from Dirk.
2416 * src/maemo/easysetup/modest-easysetup-wizard.c:
2417 (create_page_welcome), (create_page_account_details),
2418 (create_page_user_details), (create_page_complete_easysetup),
2419 (create_page_custom_incoming), (create_page_custom_outgoing),
2420 (create_page_complete_custom),
2421 (modest_easysetup_wizard_dialog_init):
2422 * src/maemo/modest-account-settings-dialog.c:
2423 (create_page_account_details), (create_page_user_details),
2424 (create_page_incoming), (create_page_outgoing),
2425 (modest_account_settings_dialog_init):
2426 * src/maemo/modest-connection-specific-smtp-window.c:
2427 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2429 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/easysetup/modest-easysetup-wizard.c:
2432 (create_page_account_details), (create_page_custom_outgoing),
2433 (create_page_complete_custom):
2434 * src/maemo/modest-account-settings-dialog.c:
2435 (create_page_user_details), (create_page_incoming),
2436 (create_page_outgoing):
2437 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2438 (modest_connection_specific_smtp_edit_window_init):
2439 Use the correct (UI spec) port min/max, and use horizontal separators,
2442 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2444 * src/maemo/easysetup/modest-easysetup-wizard.c:
2445 (set_default_custom_servernames):
2446 * src/maemo/modest-account-settings-dialog.c:
2447 (create_page_incoming), (on_combo_outgoing_security_changed),
2448 (on_combo_incoming_security_changed), (create_page_outgoing),
2449 (modest_account_settings_dialog_set_account_name),
2450 (save_configuration):
2451 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2452 (on_combo_security_changed),
2453 (modest_connection_specific_smtp_edit_window_init),
2454 (modest_connection_specific_smtp_edit_window_set_connection),
2455 (modest_connection_specific_smtp_edit_window_get_settings):
2456 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2459 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2462 * src/maemo/easysetup/modest-easysetup-wizard.c:
2463 (create_page_custom_outgoing), (create_page_complete_custom):
2464 * src/maemo/modest-account-settings-dialog.c:
2465 (create_page_user_details), (create_page_outgoing):
2466 * src/maemo/modest-account-view-window.c: (button_box_new):
2467 Use changed logical IDs as per the most recent UI spec:
2468 mcen_bd_emailsetup_edit -> mcen_bd_edit
2469 mcen_bd_emailsetup_delete -> mcen_bd_delete
2470 mcen_bd_emailsetup_close -> mcen_bd_close
2472 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2476 * src/dbus_api/Makefile.am:
2477 * src/dbus_api/modest-dbus-callbacks.c:
2478 * src/dbus_api/modest-dbus-callbacks.h:
2479 * src/maemo/modest-platform.c: (modest_platform_init):
2480 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2482 * tests/Makefile.am:
2483 * tests/dbus_api/Makefile.am:
2484 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2486 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2488 * src/maemo/modest-account-settings-dialog.c:
2489 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2490 Removed unnecessary includes.
2492 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2494 * src/maemo/easysetup/modest-easysetup-wizard.c:
2495 * src/maemo/modest-account-settings-dialog.c:
2496 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2497 * src/widgets/Makefile.am:
2498 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2499 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2500 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2501 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2502 * src/widgets/modest-secureauth-combo-box.c:
2503 * src/widgets/modest-secureauth-combo-box.h:
2504 * src/widgets/modest-serversecurity-combo-box.c:
2505 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2506 made the GObject names more consistent with the rest of the Modest code.
2508 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2510 * src/maemo/easysetup/Makefile.am:
2511 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2512 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2513 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2514 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2515 * src/maemo/easysetup/modest-easysetup-wizard.c:
2516 * src/maemo/easysetup/modest-validating-entry.c:
2517 * src/maemo/easysetup/modest-validating-entry.h:
2518 * src/maemo/modest-account-settings-dialog.c:
2519 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2520 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2521 widgets/ because they are used outside of easysetup too. After checking in,
2522 svn will allow me to rename them too.
2524 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2526 * src/gnome/modest-msg-edit-window.c:
2527 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2528 linker error, to fix the build on the GNOME platform.
2529 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2530 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2531 ifdefed out to avoid a warning.
2533 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2535 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2536 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2537 some alternative for GTK+ 2.6.
2539 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2541 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2543 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2544 specified for EmailAccountsDialog in UI spec.
2546 * src/maemo/easysetup/modest-easysetup-wizard.c:
2547 * src/maemo/easysetup/modest-easysetup-wizard.h:
2548 * src/maemo/modest-account-settings-dialog.c:
2549 * src/maemo/modest-account-settings-dialog.h:
2550 Reuse a member window widget for the connection-specific SMTP server accounts,
2551 so we can tell it to create/save the accounts only if we actually save changes.
2553 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2554 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2555 (modest_connection_specific_smtp_edit_window_get_settings):
2556 Return a struct instance for temporarily remembering the entered data.
2558 * src/maemo/modest-connection-specific-smtp-window.h:
2559 * src/maemo/modest-connection-specific-smtp-window.c:
2560 (modest_connection_specific_smtp_window_finalize),
2561 (modest_connection_specific_smtp_window_fill_with_connections),
2563 (modest_connection_specific_smtp_window_save_server_accounts),
2564 (update_model_server_names): Do not actually save data until asked,
2565 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2567 (on_selection_changed),
2568 (modest_connection_specific_smtp_window_init): Disable the edit
2569 button when nothing is selected.
2571 * src/modest-account-mgr-helpers.c:
2572 * src/modest-account-mgr-helpers.h:
2573 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2576 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2578 * src/modest-account-mgr-helpers.h:
2579 * src/modest-account-mgr-helpers.c:
2580 (modest_account_mgr_get_unused_account_name),
2581 (modest_account_mgr_get_unused_account_display_name): Added these
2582 utility functions, to avoid code duplication.
2584 * src/maemo/easysetup/modest-easysetup-wizard.c:
2585 (create_page_account_details), (create_account):
2586 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2587 (on_combo_security_changed),
2588 (modest_connection_specific_smtp_edit_window_init),
2589 (modest_connection_specific_smtp_edit_window_save_settings):
2590 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2591 * src/maemo/modest-connection-specific-smtp-window.c:
2592 (modest_connection_specific_smtp_window_finalize),
2593 (modest_connection_specific_smtp_window_fill_with_connections),
2594 (on_button_edit), (modest_connection_specific_smtp_window_init):
2595 * src/maemo/modest-connection-specific-smtp-window.h:
2596 Implementing saving of connection-specific server accounts.
2598 But I need to refactor this so we can save the data for each
2599 possible connection-specific account and only actually create the server accounts
2600 when the easysetup finished, or the OK button is pressed on the account settings
2603 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2606 (on_combo_security_changed):
2607 (modest_connection_specific_smtp_edit_window_init):
2608 Auto-fill the port number as in the account settings.
2610 (modest_connection_specific_smtp_edit_window_set_connection):
2611 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2612 * src/maemo/modest-connection-specific-smtp-window.c:
2613 (fill_with_connections), (on_button_edit),
2614 (modest_connection_specific_smtp_window_init):
2615 Turn the edit window into a dialog to simplify the code, and
2616 set a WM hint as in a GtkDialog, because only a popup can be on top of
2617 another window in Maemo, and popups usually have no WM decoration.
2619 * src/modest-defs.h:
2620 * src/modest-account-mgr-helpers.c:
2621 (modest_account_mgr_set_connection_specific_smtp),
2622 (modest_account_mgr_remove_connection_specific_smtp),
2623 (modest_account_mgr_get_connection_specific_smtp):
2624 * src/modest-account-mgr-helpers.h: Some functions to write the
2625 connection-specific SMTP server information. Not yet used.
2628 * src/widgets/modest-folder-view.c: (text_cell_data):
2629 Fix a warning about an uninitialized variable.
2630 (on_configuration_key_changed): Put an #ifdef around the use
2631 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2633 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2635 * src/maemo/modest-account-settings-dialog.h:
2636 * src/maemo/modest-account-settings-dialog.c:
2637 Added connect_for_modified() utility function to mark the new modified boolean.
2639 (create_page_account_details), (create_page_user_details),
2640 (create_page_incoming), (create_page_outgoing), (on_response),
2641 (modest_account_settings_dialog_init),
2642 (modest_account_settings_dialog_set_account_name):
2643 Only warn about unsaved changes when there are actually unsaved changes.
2645 * src/modest-account-mgr-helpers.c:
2646 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2647 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2648 to get the data from there in future.
2650 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2652 * src/modest-defs.h:
2654 * src/modest-account-mgr-helpers.h:
2655 * src/modest-account-mgr-helpers.c:
2656 Store the security account setting in a single conf key instead of using
2657 the options list, so that the list is left for just the to-be-removed camel hack,
2658 and because gconf_client_set_list() is failing for some reason.
2660 * src/modest-account-mgr.c:
2661 (modest_account_mgr_add_server_account):
2662 * src/maemo/modest-account-settings-dialog.c:
2663 (modest_account_settings_dialog_set_account_name),
2664 (save_configuration): Use the renamed functions.
2667 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2669 * src/widgets/Makefile.am:
2670 * src/widgets/modest-limit-retrieve-combo-box.c:
2671 * src/widgets/modest-limit-retrieve-combo-box.h:
2672 * src/widgets/modest-retrieve-combo-box.c:
2673 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2674 the account settings dialog.
2676 * src/modest-defs.h:
2677 * src/modest-account-mgr-helpers.h:
2678 * src/modest-account-mgr-helpers.c:
2679 (modest_server_account_get_option_secure_auth),
2680 (modest_server_account_set_option_secure_auth):
2681 * src/modest-account-mgr.c:
2682 (modest_account_mgr_add_server_account):
2683 Use the existing AUTH_MECH conf key for the secure-auth setting,
2684 instead of putting it in the list options, because this was actually used already.
2686 * src/maemo/modest-account-settings-dialog.c:
2687 (create_page_account_details),
2688 (modest_account_settings_dialog_set_account_name),
2689 (save_configuration):
2690 * src/maemo/modest-account-settings-dialog.h:
2691 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2692 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2694 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2696 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2697 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2698 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2700 * src/modest-defs.h:
2701 * src/maemo/modest-account-settings-dialog.c:
2702 (create_page_incoming), (on_combo_outgoing_security_changed),
2703 (on_combo_incoming_security_changed), (create_page_outgoing),
2704 (modest_account_settings_dialog_set_account_name),
2705 (save_configuration): Load/Save the port number, and change it when the
2706 security combo changes, to suitable defaults.
2708 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2710 * src/modest-account-mgr.c:
2711 (modest_account_mgr_add_server_account): Set the security and secure-auth
2712 options, and add a comment saying that the other camel-specific options should be
2715 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2717 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2719 * src/modest-tny-account-store.c: (account_list_free),
2720 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2721 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2724 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2726 * src/modest-protocol-info.c:
2727 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2728 is required by our UI spec. Maybe something in our implementation will use this eventually.
2729 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2730 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2731 instead of the previous 0 placeholder.
2733 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2734 secure-auth settings.
2735 * src/modest-account-mgr-helpers.h:
2736 * src/modest-account-mgr-helpers.c:
2737 (modest_server_account_data_get_option_secure_auth),
2738 (modest_server_account_set_option_secure_auth),
2739 (modest_server_account_data_get_option_security),
2740 (modest_server_account_set_option_security): Added this API for getting and setting the security
2741 and secure-auth settings.
2743 * src/maemo/modest-account-settings-dialog.h:
2744 * src/maemo/modest-account-settings-dialog.c:
2745 (modest_account_settings_dialog_finalize), (check_data),
2746 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2747 about changing titles.
2748 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2749 (save_configuration): Save the security and secure-auth settings.
2751 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2752 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2754 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2756 * src/modest-defs.h:
2757 * src/modest-account-mgr.c:
2758 (modest_account_mgr_add_server_account):
2759 Added and used defines for the options key and value pair strings,
2760 that are used so far, though they do not seem to correspond to anything in our
2761 UI specs or ModestProtocol enum.
2763 * src/modest-account-mgr-helpers.h:
2764 * src/modest-account-mgr-helpers.c:
2765 (compare_option_strings_for_name),
2766 (modest_server_account_data_get_option_value),
2767 (modest_server_account_data_get_option_bool),
2768 (modest_account_mgr_get_server_account_option):
2769 Added helper functions for parsing the options GSList.
2771 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2773 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2774 display name is based on the supplied account name.
2775 * src/modest-account-mgr.c:
2776 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2777 with an inefficient, but good-enough, implementation.
2779 * src/maemo/easysetup/modest-easysetup-wizard.c:
2780 (create_page_account_details), (on_before_next), (create_account):
2781 Check for existing display names rather than (non-user-visible) account names, and just
2782 create and set a unique account name at the end.
2784 * src/maemo/modest-account-settings-dialog.c:
2785 (modest_account_settings_dialog_init),
2786 (modest_account_settings_dialog_set_account_name),
2787 (create_page_incoming): Show the display name, instead of the account name.
2788 (on_response): Do some (not all) extra checks, as in the UI spec.
2789 (save_configuration): Save the display name if it was changed.
2791 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2793 * po/en_GB.po: Added needed logical ID and translation.
2794 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2795 (init_view): Made the is-default column clicking work.
2797 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2800 * src/maemo/easysetup/Makefile.am:
2801 * src/maemo/easysetup/modest-easysetup-wizard.c:
2802 (modest_easysetup_wizard_dialog_init):
2803 * src/maemo/easysetup/provider-data-test.keyfile:
2804 * src/maemo/easysetup/provider-data.keyfile:
2805 Moved the provider data file to the new modest-providers-data package and used it from there.
2807 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2809 * src/modest-local-folder-info.c:
2810 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2811 N_() was already used on the static strings, but this just marks it for translation without
2812 using the translation.
2814 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2816 * src/maemo/modest-account-settings-dialog.c:
2817 (create_page_incoming),
2818 (modest_account_settings_dialog_set_account_name):
2819 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2820 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2821 I will do this if nobody else gets there first.
2823 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2825 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2826 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2827 save the security stuff.
2829 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2831 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2832 Set the email address and user fullname, which I now see must be
2835 * src/maemo/modest-account-settings-dialog.h:
2836 * src/maemo/modest-account-settings-dialog.c:
2838 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2839 leave-on-server and authentication.
2840 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2843 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2846 * src/maemo/modest-account-settings-dialog.c:
2847 * src/maemo/modest-account-settings-dialog.h:
2848 Most (but not all) of the widgets are now present as specified by the UI spec.
2849 No changes are yet saved, and some details are not properly shown yet.
2851 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2853 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2855 * src/maemo/Makefile.am:
2856 * src/maemo/modest-account-settings-dialog.c:
2857 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2858 an existing account. Doesn't do much yet.
2860 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2861 Open the accounts settings dialog when Edit is clicked.
2863 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2865 * src/maemo/easysetup/Makefile.am:
2866 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2868 * src/maemo/easysetup/modest-easysetup-wizard.c:
2869 (modest_easysetup_wizard_dialog_init):
2870 Try to get the source directory from the build system,
2871 instead of hard-coding "./" into the source code, when opening our local
2872 copies of the configuration files.
2873 But this still fails when opening the wizard from the Accounts window,
2874 maybe because the working directory seems to change at runtime.
2875 So the wizard will fail the second time unless you copy the files into their
2876 proper locations - see the stdout warnings for the paths.
2878 (create_page_account_details),(on_before_next):
2879 Check for existing non-server accounts instead of server accounts,
2880 so the default account name is useful again, and to prevent trying to
2883 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2884 Show the wizard when New is clicked.
2886 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2887 (init_view): Show the column headers, and show the columns that are
2888 specified in the UI specs. However, something in Maemo's GTK+ prevents
2889 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2890 change the default account. This is despite unsetting the special properties.
2892 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2894 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2895 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2896 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2897 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2898 to make that clearer.
2899 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2901 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2903 * src/maemo/modest-account-view-window.c:
2904 (modest_account_view_window_init),
2905 (modest_account_view_window_new):
2906 Use the same buttons as specified in the
2907 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2908 the existing widgets, which never had a chance of working.
2909 Put the ModestAccountView treeview in a scrolled window.
2910 Do not repeat the initialization in both _init() and _new().
2912 * src/widgets/modest-account-view.c: (update_account_view):
2913 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2914 this widget and window shows no accounts.
2916 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2918 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2920 * src/maemo/easysetup/modest-easysetup-wizard.c:
2921 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2922 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2923 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2926 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2927 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2928 accounts exist yet, as in the UI spec.
2930 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2932 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2934 * src/maemo/Makefile.am:
2935 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2936 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2937 New window for editing connection-specific smtp details.
2938 Not fully implemented.
2940 * src/maemo/modest-connection-specific-smtp-window.c:
2941 (modest_connection_specific_smtp_window_finalize) :
2942 unref the tree model.
2943 (on_button_edit): Show the edit window.
2945 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2947 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2950 * src/maemo/Makefile.am:
2951 * src/maemo/modest-connection-specific-smtp-window.c:
2952 * src/maemo/modest-connection-specific-smtp-window.h:
2953 New window for showing the list of connections, for connection-specific
2954 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2955 * src/maemo/easysetup/modest-easysetup-wizard.c:
2956 (create_page_custom_outgoing): Show the new window when the button is clicked.
2958 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2960 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2961 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2962 * src/maemo/modest-msg-edit-window.c:
2963 (modest_msg_edit_window_insert_image):
2964 * src/modest-conf.c: (modest_conf_key_escape):
2965 * src/modest-mail-operation.c:
2966 (modest_mail_operation_send_new_mail):
2967 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2968 (modest_ui_actions_on_new_account):
2969 * src/widgets/modest-attachment-view.c: (update_filename_request):
2970 * src/widgets/modest-mail-header-view.c:
2971 Corrected warnings that were breaking the build, by commenting out unused variables,
2972 and a function, and by including a header.
2974 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2976 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2977 so we can #ifdef around platform-specific code when necessary.
2978 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2979 to allow this to build for the GNOME platform too.
2981 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2983 * src/maemo/easysetup/modest-easysetup-wizard.c:
2984 Added util_increment_name() and used it in create_page_account_details()
2985 to make sure that the default account name is always a new name.
2987 (modest_easysetup_wizard_dialog_init),
2988 (set_default_custom_servernames): Some minor memory management fixes.
2990 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2994 * src/modest-runtime.c: (init_i18n): Restored the translation
2995 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2996 are defined in config.h, and the translations are installed.
2998 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2999 is defined for translation.
3001 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3003 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3005 * src/maemo/easysetup/modest-easysetup-wizard.c:
3006 (modest_easysetup_wizard_dialog_init):
3007 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3008 Use realistic paths (though they should use $prefix generically) to the
3009 mcc_mapping and provider-data.keyfile files which might work when they
3010 are installed by the future version of the operator-wizard package,
3011 and then fallback to paths in our source code, with an explanatory
3014 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3018 * src/maemo/Makefile.am:
3019 * src/maemo/easysetup/: Added files from the previously-exernal
3020 osso-modest-easysetup.
3021 * src/maemo/modest-main-window-ui.h:
3022 * src/modest-ui-actions.c:
3023 * src/modest-ui-actions.h:
3024 Added modest_ui_actions_on_new_account() as a signal handler for the
3025 New Account menu item. It shows the easysetup wizard.
3026 * po/en_GB.po: Added additional needed logical IDs and translations.
3028 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
3029 Apparently ChangeLog is not used for some vague Nokia legal reasons.