1 2007-06-26 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-init.c: (modest_init_local_folders):
4 For memory-card (or other non local-folders) maildir accounts,
5 always create an Archive folder, so that there is somewhere to put
6 messages. This should be less confusing, because the user does not need
7 to guess that the need to create a folder.
9 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
11 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
12 Fixed icon size by using (50, 50) which is the same as defined by
15 2007-06-25 Armin Burgmeier <armin@openismus.com>
17 * src/widgets/modest-window-mgr.c:
19 * configure.ac: Correctly recognize hildon-notify presence and fixed
20 the build without it being installed.
22 2007-06-25 Murray Cumming <murrayc@murrayc.com>
24 * libmodest-dbus-client/libmodest-dbus-client.c:
25 (libmodest_dbus_client_search): Fix the build. Sorry.
26 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
27 (reply_forward_cb): Initialize variables to fix the build.
29 * src/modest-tny-account-store.c:
30 (modest_tny_account_store_get_tny_account_by): Fix the account URI
31 comparison (a silly typo) so that email search results can be opened
32 when there are more than one account.
34 2007-06-25 Murray Cumming <murrayc@murrayc.com>
36 * libmodest-dbus-client/libmodest-dbus-client.c:
37 (libmodest_dbus_client_search),
38 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
39 instead of 1 second, because the search gets folders and messages from
40 the server, which can take a long time. When it times out,
41 osso-global-search will report no results.
43 We need to specify whether we should search only cached information
44 (maybe with a user preference), and the osso-email-search-plugin
45 API should really be improved to allow that option, and to allow results
46 to be delivered asynchronously in batches.
48 2007-06-25 Murray Cumming <murrayc@murrayc.com>
50 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
51 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
52 GTK_ICON_SIZE_DIALOG is probably the wrong size.
54 2007-06-25 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
57 that is an empty string. D-Bus seems to give us these instead of NULL.
59 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
61 * src/dbus_api/modest-dbus-callbacks.c:
62 * src/maemo/easysetup/modest-easysetup-wizard.h:
63 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
64 * src/maemo/modest-connection-specific-smtp-edit-window.c:
65 (modest_connection_specific_smtp_edit_window_init):
66 * src/maemo/modest-maemo-global-settings-dialog.c:
68 * src/maemo/modest-maemo-utils.c:
69 (modest_maemo_utils_setup_images_filechooser):
70 * src/maemo/modest-main-window.c: (create_details_widget):
71 * src/maemo/modest-msg-edit-window.c:
72 (modest_msg_edit_window_attach_file_noninteractive),
73 (modest_msg_edit_window_color_button_change),
74 (modest_msg_edit_window_set_zoom):
75 * src/modest-mail-operation.c: (update_account_thread):
76 * src/modest-tny-account-store.c:
77 * src/modest-tny-account.c:
78 * src/widgets/modest-global-settings-dialog.c:
79 * src/widgets/modest-window.h:
83 2007-06-25 Murray Cumming <murrayc@murrayc.com>
85 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
86 * src/modest-search.c: (modest_search_folder),
87 (modest_search_all_accounts): Actually search only in the specified folder,
88 doing a simple match on the folder ID.
89 * src/modest-search.h: Added a folder field to the ModestSearch struct,
90 and added some documentation.
92 2007-06-22 Armin Burgmeier <armin@openismus.com>
94 * src/maemo/modest-maemo-utils.h:
95 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
96 modest_maemo_utils_get_supported_secure_authentication_methods.
98 * src/maemo/easysetup/modest-easysetup-wizard.c:
99 * src/maemo/modest-account-settings-dialog.c: Show correct error if
100 one occured, not just "Server does not support secure authentication".
102 2007-06-22 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-tny-account-store.c: (get_password):
105 Restored the call to tny_account_set_user() because Philip seems to have
106 stopped this from crashing (by not using the freed string). It still does
107 not work, but now we can test it.
109 2007-06-22 Murray Cumming <murrayc@murrayc.com>
111 * src/maemo/modest-msg-edit-window.c: (init_window):
112 Comment out use of an uninitialzed GtkScrolledWindow variable,
113 to fix the build and stop a crash. Yet again.
115 2007-06-22 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-tny-account-store.c: (get_password):
118 Remove the call to tny_account_set_user() because this actually crashes.
119 As mentioned in the last commit, it is known to not work anyway.
121 2007-06-22 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-tny-account-store.c: (get_password):
124 Use tny_account_set_username() to tell tinymail that the username might
125 have changed too. But tinymail ignores this: see projects.maemo.org
127 * src/modest-ui-actions.c:
128 (modest_ui_actions_on_password_requested): Remove the useless attempt to
129 reset the connection when changing the username, and improve the comments.
130 Save the changed username to gconf at least, so it is used when Modest is
133 2007-06-21 Murray Cumming <murrayc@murrayc.com>
135 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
136 Do not use a query, so that we get all folders, including for POP and
137 local-folders. They work as search criteria too.
138 This fixes projects.maemo.org bug NB#57740.
140 2007-06-21 Murray Cumming <murrayc@murrayc.com>
142 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
143 Comment out the use of hildon_notification_set_sound() because it is
144 not declared, to fix the build. Warnings are serious, people.
146 2007-06-21 Armin Burgmeier <armin@openismus.com>
148 * src/maemo/modest-maemo-utils.h:
149 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
150 modest_maemo_utils_get_supported_secure_authentication_methods()
151 to query authentication methods for a specific user. This should fix
152 projects.maemo.org bug NB#61369.
154 * src/maemo/easysetup/modest-easysetup-wizard.c:
155 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
158 2007-06-21 Murray Cumming <murrayc@murrayc.com>
160 * libmodest-dbus-client/libmodest-dbus-client.h:
161 * libmodest-dbus-client/libmodest-dbus-client.c:
162 (modest_dbus_message_iter_get_search_hit),
163 (libmodest_dbus_client_search):
164 Reorganised and commented this.
165 Removed modest_search_hit_free() from the public API because it
168 Added libmodest_dbus_client_get_folders() and
169 modest_folder_result_list_free().
171 * src/dbus_api/modest-dbus-api.h:
172 * src/dbus_api/modest-dbus-callbacks.c:
173 (modest_dbus_req_filter): Commented. Moved most code to
174 on_dbus_method_search() and added on_dbus_method_get_folders().
176 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
177 of the extra D-Bus handler.
179 * tests/dbus_api/Makefile.am:
180 * tests/dbus_api/test_get_folders.c: New test for
181 libmodest_dbus_client_get_folders(). This seems to return an empty list
182 at the moment. That could be the same error that causes the message list
183 to be empty sometimes.
184 This should help with projects.maemo.org bug NB#57740.
186 2007-06-21 Armin Burgmeier <armin@openismus.com>
188 * src/modest-mail-operation.c: Do not call
189 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
190 notify the operation's end after having set the status to CANCELED for
191 the operation queue to listen on. This fixes a deadlock when there
192 were mail operations in the queue during its finalization.
194 * src/modest-singletons.c: Reordered uninitialization of the account
195 manager to happen after the mail operation queue was uninitialized
196 because the mail operation's in the queue might still try to access
197 the account manager (see modest_mail_operation_notify_end()). This
198 fixes a potential crash when terminating the application.
200 2007-06-21 Murray Cumming <murrayc@murrayc.com>
202 * src/modest-search.c:
203 (search_mime_part_and_child_parts): Moved some code here so we
204 can search recursively in child folders.
205 (modest_search_folder): Search in the message as a mime part, instead
206 of just its child mime parts.
207 (read_chunk), (search_mime_part_ogs):
208 Check how many bytes were read, to prevent an endless loop.
209 Searching in message bodies now works. This finishes the fix for
210 projects.maemo.org bug NB#61007.
212 2007-06-20 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
215 Add a g_warning when the item is not a folder.
217 * src/modest-ui-dimming-rules.c:
218 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
219 when selected item is not a folder (for instance, an account), because
220 the UI spec only talks about folders.
221 I am not sure what the UI spec wants, so this might not totally fix
222 projects.maemo.org bug NB#60794.
224 2007-06-20 Murray Cumming <murrayc@murrayc.com>
226 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
227 (load_from_file): Sort the list. The unsorted list would be more noticeable
228 in non-English locales.
230 * src/maemo/modest-msg-edit-window.c:
231 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
232 warning and fix the build.
234 * src/maemo/modest-progress-bar-widget.c:
235 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
236 avoid a g_warning, and probably to avoid a crash.
238 2007-06-20 Murray Cumming <murrayc@murrayc.com>
240 * src/modest-search.c: (modest_search_folder): Check for a GError
241 when calling tny_folder_get_headers(), to show that this is not the cause
244 2007-06-20 Murray Cumming <murrayc@murrayc.com>
246 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
247 Actually set the body query instead of the subject query.
249 * src/modest-search.c: (search_mime_part_ogs),
250 (search_mime_part_strcmp): Remove extra space from the text/* regex,
251 which would probably cause it to fail if we got this far.
253 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
254 to simplify the code.
255 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
256 be causing search-in-body to fail.
258 2007-06-20 Murray Cumming <murrayc@murrayc.com>
260 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
262 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
263 Better debug message when the folder cannot be found.
264 This should help with fixing projects.maemo.org bug #61287.
265 * src/modest-search.c: (add_hit): Do not leak the furl string.
267 2007-06-20 Murray Cumming <murrayc@murrayc.com>
269 * src/modest-ui-actions.c:
270 (modest_ui_actions_on_folder_selection_changed):
271 Do not special-case TNY_MERGE_FOLDER here, because
272 modest_tny_folder_get_account() already does that. This fixes
273 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
274 shown when the Outbox was selected).
276 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
278 * libmodest-dbus-client/libmodest-dbus-client.c:
279 (_dbus_iter_get_string_or_null): Initialize the string variable in
280 case this helps with Dirk's crash.
282 2007-06-19 Murray Cumming <murrayc@murrayc.com>
284 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
285 though it is not implemented yet (this function is maybe not even used),
286 to avoid breaking ABI in future.
287 * libmodest-dbus-client/libmodest-dbus-client.c:
288 (get_attachments_string): Moved some code into this generic function.
289 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
290 sends email. It is maybe not used.
291 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
292 (on_send_mail): Use attachments.
294 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
295 * src/maemo/modest-msg-edit-window.c:
296 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
297 a filename before using it, to fix projects.maemo.org bug NB#58233.
299 2007-06-19 Murray Cumming <murrayc@murrayc.com>
301 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
302 Initialize the continue_download variable to fix the build, and probably
303 to fix randome behaviour.
305 2007-06-18 Armin Burgmeier <armin@openismus.com>
307 * src/modest-tny-send-queue.h:
308 * src/modest-tny-send-queue.c: Keep track of the status of messages in
309 the queue so we can later show it in the UI. Replaced
310 modest_tny_send_queue_msg_is_being_sent() by
311 modest_tny_send_queue_get_msg_status().
313 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
315 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
316 gpointer. This probably was not harmful, but just to be sure.
318 2007-06-18 Murray Cumming <murrayc@murrayc.com>
320 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
321 Fix the build, but leave the function broken on Bora, because
322 hildon_uri_action_get_service() does not exist.
323 osso_uri_action_get_service() does not exist either, it seems.
325 2007-06-18 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-tny-account.c:
328 (modest_tny_account_new_from_server_account):
329 Uncommented the url debug output again, because it is useful for
330 debugging, as I said in the comment.
332 2007-06-18 Murray Cumming <murrayc@murrayc.com>
334 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
336 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
337 for Mameo Bora, to fix the build.
339 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
342 Fixed build with hildon < 0.99
344 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
345 Check if the selected account is busy instead of checking all accounts
347 * src/modest-account-mgr-priv.h:
348 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
349 (modest_account_mgr_init), (compare_account_name),
350 (modest_account_mgr_set_account_busy),
351 (modest_account_mgr_account_is_busy):
352 * src/modest-account-mgr.h:
353 Added busy information to the account manager. It possible to
354 set an account to busy or not busy now.
356 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
357 (modest_mail_operation_update_account),
358 (modest_mail_operation_notify_end):
359 Set the account to busy/not busy depending on the operation state.
361 * src/widgets/modest-account-view.c:
362 (modest_account_view_finalize), (get_last_updated_string),
363 (update_account_view), (on_account_busy_changed), (init_view):
364 Show string "Refreshing..." if the account is currently busy.
366 All this fixes projects.maemo.org bug NB#59711
368 2007-06-14 Armin Burgmeier <armin@openismus.com>
370 * src/widgets/modest-attachments-view.h:
371 * src/widgets/modest-attachments-view.c: Added
372 modest_attachments_view_has_attachments() and fixed coordinate
373 transformation in get_att_view_at_coords(). This fixes attachment
376 * src/widgets/modest-msg-view.c: Make use of
377 modest_attachments_view_has_attachments() to decide whether to show
378 attachments in the header.
380 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
382 * src/maemo/modest-connection-specific-smtp-edit-window.c:
383 (on_change), (on_combo_security_changed),
384 (modest_connection_specific_smtp_edit_window_init),
385 (modest_connection_specific_smtp_edit_window_set_connection),
386 (modest_connection_specific_smtp_edit_window_is_dirty):
387 * src/maemo/modest-connection-specific-smtp-edit-window.h:
388 * src/maemo/modest-connection-specific-smtp-window.c:
391 Show an comfirmation dialog for the smpt-edit-window if there are
392 unsaved changes and the user hits cancel.
393 (projects.maemo.org bug NB#60479)
395 2007-06-14 Armin Burgmeier <armin@openismus.com>
397 * src/maemo/easysetup/modest-easysetup-wizard.c:
398 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
399 address" info in banner instead of node, and select all the text as
400 per UI spec. This fixes projects.maemo.org bug NB#60550.
402 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
404 reviewed by: <delete if not using a buddy>
406 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
407 * src/modest-ui-actions.c: (folder_refreshed_cb):
409 2007-06-14 Murray Cumming <murrayc@murrayc.com>
411 * src/widgets/modest-folder-view.c: (filter_row):
412 Explictly filter out the per-account outbox accounts. I don't know why
413 these only sometimes show up, but now they should never show up in the UI.
414 This should fix projects.maemo.org bug NB#60160.
416 2007-06-14 Murray Cumming <murrayc@murrayc.com>
418 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
419 when the toolbar does not exist yet.
420 * src/modest-widget-memory.c: (save_settings_header_view):
421 Added g_warnings() to help us to discover when we are trying to set
422 an empty columns list in gconf.
424 2007-06-14 Murray Cumming <murrayc@murrayc.com>
428 Added modest_init_get_default_header_view_column_ids().
430 * src/modest-widget-memory.c: (restore_settings_header_view):
431 Use the new function to get defaults, if the gconf key is empty,
432 instead of not creating any columns. This seems to fix the
433 empty right-hand pane problems.
435 * src/widgets/modest-header-view.h: Improved documentation.
437 2007-06-13 Murray Cumming <murrayc@murrayc.com>
439 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
440 Revert the use of the display name as the account name, because this
441 is generally wrong and would break the code that follows.
443 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
445 * src/maemo/easysetup/modest-easysetup-wizard.c:
446 (check_for_supported_auth_methods), (on_before_next),
449 More correct fix for projects.maemo.org bug NB# 58991
450 Do not longer accept AUTH_PASSWORD as secure method and choose
451 correct method when creating the account.
453 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
455 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
456 Fixed projects.maemo.org bug NB# 58991
458 2007-06-13 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-init.c: (modest_init_init_core),
461 (modest_init_local_folders): Fixed compilation errors.
463 2007-06-13 Murray Cumming <murrayc@murrayc.com>
465 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
466 Remove unnecessary lib/include, though it is good in principle when needed.
468 * src/modest-init.c: (modest_init_one_local_folder),
469 (modest_init_local_folders):
470 * src/modest-init.h: Initialize the .modest library for memory cards,
471 instead of just doing nothing for them. This should allow us to create
472 folders there, fixing projects.maemo.org bug NB#59297.
474 2007-06-13 Murray Cumming <murrayc@murrayc.com>
476 * libmodest-dbus-client/libmodest-dbus-client.c:
477 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
478 (libmodest_dbus_client_compose_mail),
479 (libmodest_dbus_client_open_message),
480 (libmodest_dbus_client_send_and_receive),
481 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
483 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
484 (on_idle_open_message), (modest_dbus_req_handler),
485 (search_result_to_message), (modest_dbus_req_filter):
486 * src/modest-search.c: (add_hit), (modest_search_folder),
487 (modest_search_all_accounts): Improved debug messages.
489 * tests/dbus_api/test_open_message.c: (main): Improved comments.
491 * src/modest-tny-account-store.c:
492 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
495 2007-06-13 Murray Cumming <murrayc@murrayc.com>
498 2007-06-12 Murray Cumming <murrayc@murrayc.com>
500 * src/modest-tny-account-store.c: (get_server_accounts):
501 Call modest_tny_local_folders_account_add_merged_outbox_folders()
502 even when there are no accounts, so that the Outbox folder is always
503 visible. This fixes projects.maemo.org bug NB#60158.
505 2007-06-12 Murray Cumming <murrayc@murrayc.com>
507 * src/maemo/modest-main-window.c: (create_details_widget):
508 Use the mcen_va_never logical ID.
510 2007-06-12 Murray Cumming <murrayc@murrayc.com>
512 * src/dbus_api/modest-dbus-api.h:
513 * src/dbus_api/modest-dbus-callbacks.c:
514 (on_idle_open_default_inbox), (on_open_default_inbox),
515 (modest_dbus_req_handler):
516 Added a new OpenDefaultInbox method.
518 * libmodest-dbus-client/libmodest-dbus-client.h:
519 * libmodest-dbus-client/libmodest-dbus-client.c:
520 Added libmodest_dbus_client_open_default_inbox() to call the new
521 dbus method. This should be useful to projects.maemo.org bug NB#57214,
522 though it should maybe be used by a new osso-email-interface function.
524 * tests/dbus_api/Makefile.am:
525 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
528 2007-06-12 Murray Cumming <murrayc@murrayc.com>
530 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
531 NULL, so that the signals get all the keys. This should not actually
532 change any behaviour because we currently update everything when anything
535 2007-06-12 Murray Cumming <murrayc@murrayc.com>
537 * src/widgets/modest-folder-view.c: (text_cell_data),
538 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
539 (find_inbox_iter): If tinymail tells us that the folder is
540 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
541 This causes the inbox to be selected at startup, fixing part of
542 projects.maemo.org bug NB#56305.
544 * src/modest-ui-dimming-rules.c:
545 (modest_ui_dimming_rules_on_tools_smtp_servers):
546 * src/modest-ui-dimming-rules.h: Added a callback function to dim
547 the SMTP servers menu item.
548 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
549 that the SMTP Servers menu item is dimmed when there are no accounts,
550 as a future version of the UI spec will require. This fixes
551 projects.maemo.org bug NB#56305.
553 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
555 * src/maemo/modest-maemo-utils.c:
556 (modest_maemo_utils_get_supported_secure_authentication_methods):
557 Added label to dialog instead of unreadable title
559 * src/maemo/modest-main-window.c: (sync_accounts_cb),
560 (modest_main_window_new):
561 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
564 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
565 * src/modest-account-mgr.h:
566 Added method to avoid code duplication
568 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
569 (modest_ui_actions_on_send_receive):
570 Use modest_account_mgr_has_accounts
572 2007-06-11 Murray Cumming <murrayc@murrayc.com>
574 * src/maemo/easysetup/modest-presets.c:
575 (modest_presets_get_info_server_security): Do not report secure auth
577 * src/modest-protocol-info.c: Use the defines for the gconf key names
578 for secure authentication. This was not working because we were writing
579 Password and reading password, and the check was case sensitive.
580 With this, gmail now works for receiving and sending when created via
583 2007-06-11 Murray Cumming <murrayc@murrayc.com>
585 * src/maemo/easysetup/modest-presets.c:
586 (modest_presets_get_info_server_security): Correct the key name for
587 SecureSmtp, because it seems to be case-sensitive.
588 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
589 Do not try to get the 0th notebook page if there are 0 pages, to
592 2007-06-11 Murray Cumming <murrayc@murrayc.com>
594 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
595 Prevent use of the new notification feature for now, because it currently
596 shows one dialog for each new email, which is annoying.
598 2007-06-11 Murray Cumming <murrayc@murrayc.com>
600 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
601 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
602 when no country was selected, so that we show the global ones.
603 * src/maemo/easysetup/modest-presets.c:
604 (modest_presets_get_providers): Return only the global providers, not
605 all providers when mmc=0 was requested.
607 2007-06-11 Murray Cumming <murrayc@murrayc.com>
609 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
610 (easysetup_provider_combo_box_fill): Remove debug code that showed the
611 provider ID in the combo.
613 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
614 Do not show the page numbers, because it would be confusing when we add
615 the 2 extra pages for the custom setup, when the user chooses the "Other"
616 provider. This fixes projects.maemo.org bug NB#59028
618 * src/modest-init.c: (modest_init_init_core),
619 (modest_init_local_folders):
621 * src/modest-tny-account.c:
622 (modest_tny_account_new_for_local_folders): Do not create default folders
623 for the memory card. This should fix projects.maemo.org bug NB#59328.
625 2007-06-11 Murray Cumming <murrayc@murrayc.com>
627 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
628 Free the changed_conf_keys string items. They are already freed in the
629 idle handler if that runs first.
631 2007-06-11 Murray Cumming <murrayc@murrayc.com>
633 * src/modest-ui-actions.c:
634 (modest_ui_actions_on_password_requested): Check that the server name
635 is not NULL, because I just saw a password dialog with (null) as the
638 * src/modest-tny-folder.[h|c]: Added
639 modest_tny_folder_is_memory_card_folder().
640 * src/modest-ui-dimming-rules.c:
641 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
642 menu item for memory cards, as per the UI spec (section 7.4). This should
643 fix projects.maemo.org bug NB#59297.
645 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
647 * src/maemo/modest-main-window.c: (sync_accounts_cb):
648 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
649 is another problem with the code, see Murray's comment at line 772)
651 2007-06-08 Murray Cumming <murrayc@murrayc.com>
653 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
654 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
655 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
656 (load_from_file), (easysetup_country_combo_box_init),
657 (easysetup_country_combo_box_get_active_country_ids),
658 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
659 instead of just one ID, to avoid duplicate country names in the UI.
661 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
662 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
663 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
664 a single ID, avoiding duplicate providers.
665 * src/maemo/easysetup/modest-easysetup-wizard.c:
666 (on_combo_account_country): Adapt to use a list.
668 2007-06-08 Murray Cumming <murrayc@murrayc.com>
670 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
671 keys changed in the last X seconds.
673 * src/modest-account-mgr.h:
674 * src/modest-account-mgr.c: (on_timeout_notify_changes),
675 (on_key_change), (modest_account_mgr_class_init),
676 (modest_account_mgr_init), (modest_account_mgr_finalize):
677 As the keys are changed, save them in a GSList* and signal that GSList*
678 further every X seconds, to batch changes, to allow us to do just one
679 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
680 bug NB#56941 and other (UI-blocking) delays when changing account settings.
682 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
683 changed signal signature.
685 * src/modest-conf.c: (modest_conf_set_list),
686 (modest_conf_on_change): Reenable notification.
688 (modest_conf_maemo_fake_on_change): Comment out the hack that
689 notified immediately instead of asynchronously.
691 * src/widgets/modest-account-view.h:
692 * src/widgets/modest-account-view.c:
693 (update_account_view): Select the previously-selected account ID,
694 if possible. This fixes projects.maemo.org bug NB#56933.
696 (on_account_changed), (on_account_removed),
697 (modest_account_view_select_account):
699 Remove the block/unblock functions
700 because they were not useful.
702 * src/maemo/modest-account-view-window.c:
703 (on_delete_button_clicked), (on_edit_button_clicked),
704 (on_new_button_clicked): Remove the use of the non-working block/unblock.
706 2007-06-08 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
709 Improve the error dialog to show Incorrect Account Settings, which seems
710 clearer, and say that the internal error message (to be removed from the
711 dialog later) is often misleading.
712 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
714 * src/modest-tny-account.c:
715 (modest_tny_account_new_from_server_account): Uncomment the printf of the
716 URL because this is so useful for debugging on the device.
718 * src/widgets/modest-serversecurity-combo-box.c:
719 (modest_serversecurity_combo_box_fill): Correct a logical ID.
721 2007-06-08 Murray Cumming <murrayc@murrayc.com>
723 * src/modest-mail-operation.c:
724 (modest_mail_operation_send_new_mail):
725 Added a comment about a nasty but apparently harmless message. Details
726 added to the wiki g_warnings() page.
728 2007-06-08 Murray Cumming <murrayc@murrayc.com>
730 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
731 (modest_tny_send_queue_class_init):
732 Do not use the priv struct because it is empty, to avoid g_warnings
733 about a non-existant priv struct.
735 * src/modest-tny-account-store.c:
736 (modest_tny_account_store_get_server_account),
737 (modest_tny_account_store_get_transport_account_for_open_connection
738 ): Do not try to get transport server accounts for local folders,
739 because they don't have any. This avoids a g_warning().
741 * src/maemo/modest-main-window.c:
742 (modest_main_window_notify_send_receive_initied),
743 (on_configuration_key_changed):
744 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
746 * src/modest-mail-operation.c:
747 (modest_mail_operation_update_account):
748 * src/modest-tny-account-store.h:
749 * src/modest-tny-account.c:
750 (modest_tny_account_get_special_folder),
751 (modest_tny_account_new_for_local_folders),
752 (modest_tny_account_new_for_per_account_local_outbox_folder):
753 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
754 * src/modest-tny-local-folders-account.c:
755 (add_account_folders_to_merged_folder):
756 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
757 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
758 (modest_ui_actions_on_send):
759 * src/widgets/modest-folder-view.c: (update_model):
760 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
761 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
762 modest_tny_account_store_get_tny_account_by_account() to
763 modest_tny_account_store_get_server_account() to make the code clearer.
765 2007-06-07 Marcus Bauer <marcusb@openismus.com>
767 * src/dbus_api/modest-dbus-api.h:
768 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
769 * src/maemo/modest-msg-edit-window.c:
770 (modest_msg_edit_window_attach_file_noninteractive):
771 added g_warning in case the file to be attached does not exist
772 * tests/dbus_api/test_compose_mail.c: (main):
773 removed obsolete comment, added generic files as test case
775 2007-06-07 Murray Cumming <murrayc@murrayc.com>
777 * src/modest-tny-account-store.c: (get_server_accounts):
778 Create the local folders account only once, not once for each outbox, and
779 not only when there are some outboxes.
781 2007-06-07 Murray Cumming <murrayc@murrayc.com>
783 * src/widgets/modest-folder-view.c: (update_model): Comment out some
784 code that is causing a crash at startup. Sergio says that he is fixing this.
786 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
788 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
789 * src/maemo/modest-account-settings-dialog.c:
790 (create_page_outgoing),
791 (modest_account_settings_dialog_set_account_name),
792 (save_configuration):
793 - Fixed handling of the "Use secure authentication" toggle to comply with
794 the ui specification. See also projects.maemo.org bug NB#58400
796 - Restore the Secure connection setting combo correctly when loading
799 * src/maemo/modest-maemo-utils.c:
800 (on_camel_account_get_supported_secure_authentication),
801 (modest_maemo_utils_get_supported_secure_authentication_methods):
802 Fixed a crasher if operation is canceled
804 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
805 (modest_protocol_info_auth_is_secure):
806 * src/modest-protocol-info.h:
808 Added two new methods to determine if a protocol/auth method is secure/encrypted in
809 the sense of the "Use secure authentication" toggle.
811 2007-06-07 Murray Cumming <murrayc@murrayc.com>
813 * src/modest-tny-account-store.h:
814 * src/modest-tny-account-store.c:
815 Added modest_tny_account_store_get_local_folders_account().
817 * src/modest-tny-folder.h:
818 * src/modest-tny-folder.c:
819 (modest_tny_folder_get_account):
820 Added this replacement for tny_folder_get_account() which returns
821 the local-folders account for TnyMergeFolders, to avoid the
822 warning about the unimplemented get_account_func() vfunc().
824 (modest_tny_folder_get_rules),
825 * src/modest-ui-actions.c:
826 (modest_ui_actions_on_folder_selection_changed):
827 * src/modest-mail-operation.c:
828 (modest_mail_operation_remove_folder),
829 (modest_mail_operation_xfer_folder),
830 (modest_mail_operation_rename_folder),
831 (modest_mail_operation_get_msg),
832 (modest_mail_operation_get_msgs_full),
833 (modest_mail_operation_remove_msg),
834 (modest_mail_operation_xfer_msgs),
835 (modest_mail_operation_refresh_folder):
836 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
838 2007-06-07 Murray Cumming <murrayc@murrayc.com>
840 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
841 (modest_server_account_set_security):
842 * src/modest-defs.h: Add comments explaining that our
843 UI spec means TLS when it says Normal, so these do not look like errors.
845 * src/modest-tny-account.c:
846 (modest_tny_account_new_from_server_account): Use the new tinymail
847 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
848 for TLS. This should fix projects.maemo.org bug NB#58460.
850 2007-06-06 Murray Cumming <murrayc@murrayc.com>
852 * src/maemo/easysetup/modest-easysetup-wizard.c:
853 (create_account): Correct the position of the gconf sanity check warning.
854 (on_button_edit_advanced_settings): Show the dialog immediately, instead
855 of using the g_idle_add() hack, because this does not seem to be necessary
856 on osso 1.1. It might even work on Maemo Bora if the problems were actually
857 caused by something other than maemo's gconf.
858 This fixes projects.maemo.org bug #59022.
860 2007-06-06 Murray Cumming <murrayc@murrayc.com>
862 * src/modest-account-mgr-helpers.c:
863 (modest_account_mgr_get_default_account): Do not check that the account
864 exists if there is no default account (NULL), to fix a runtime warning.
866 2007-06-06 Murray Cumming <murrayc@murrayc.com>
868 * src/widgets/modest-folder-view.c: (update_model):
869 Do not unref the treemodel before we have finished with it.
870 This prevents a valgrind warning and an occasional crash at startup.
872 2007-06-06 Marcus Bauer <marcusb@openismus.com>
874 * libmodest-dbus-client/libmodest-dbus-client.h:
875 added libmodest_dbus_client_compose_mail()
876 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
878 added functions needed for SendAsMail() functionality
879 * src/maemo/modest-msg-edit-window.c:
880 (modest_msg_edit_window_attach_file_noninteractive):
881 non interactively attaching files to message edit window
882 * src/widgets/modest-msg-edit-window.h:
883 * tests/dbus_api/Makefile.am:
884 added test_compose_mail.c
885 * tests/dbus_api/test_compose_mail.c: (main):
887 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
889 * src/modest-account-view.c:
890 Fixed bug projects.maemo.org bug NB#59307
892 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
894 * src/maemo/easysetup/modest-easysetup-wizard.c:
895 (get_serverport_incoming), (on_before_next), (create_account):
896 * src/maemo/modest-account-settings-dialog.c:
897 (modest_account_settings_dialog_set_account_name):
898 * src/maemo/modest-maemo-utils.c:
899 (on_camel_account_get_supported_secure_authentication_status),
900 (on_camel_account_get_supported_secure_authentication),
901 (on_secure_auth_cancel),
902 (modest_maemo_utils_get_supported_secure_authentication_methods):
904 Implemented security authentication for settings and easysetup.
906 2007-06-05 Murray Cumming <murrayc@murrayc.com>
908 * src/maemo/modest-main-window.c: (create_details_widget):
909 Show the total size for memory card accounts too, instead of showing
910 the name again. Fixes bug projects.maemo.org bug NB#59307.
912 2007-06-05 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-tny-simple-folder-store.c:
916 * src/modest-tny-simple-folder-store.h: Removed.
918 * src/modest-tny-local-folders-account.h
919 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
920 for the local-folders maildir, with an extra TnyMergedFolder containing
921 the folders of the per-account outbox store accounts.
922 * src/modest-tny-account-store.c: (get_server_accounts):
923 Add the outboxes to the special local folders account after creating it.
925 * src/modest-tny-account.c:
926 (modest_tny_account_new_for_local_folders): Create the derived
927 account when creating the main local-folders account.
929 * src/maemo/modest-main-window.c: (create_details_widget),
930 (modest_main_window_set_contents_style):
931 Adapted to the use of the derived account instead of the folder store.
933 * src/modest-ui-actions.c:
934 (modest_ui_actions_on_folder_selection_changed):
935 * src/modest-ui-dimming-rules.c:
936 (modest_ui_dimming_rules_on_new_folder):
937 * src/widgets/modest-folder-view.c: (text_cell_data),
938 (icon_cell_data), (filter_row), (update_model),
939 (get_cmp_rows_type_pos):
942 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
943 Do not get the priv struct, because no priv struct has been set,
944 to avoid a runtime warning.
946 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
947 #ifelse with #else, to fix a warning, to fix the build.
950 2007-06-05 Christian Kellner <ckellner@openismus.com>
952 * libmodest-dbus-client/libmodest-dbus-client.c:
953 Fix small typo in doc (why do you always see them
954 AFTER committing stuff?)
957 2007-06-05 Christian Kellner <ckellner@openismus.com>
959 * libmodest-dbus-client/libmodest-dbus-client.c:
960 (libmodest_dbus_client_search):
961 Initialize hit list with NULL. Also set folder list
962 to "" if NULL was supplied.
965 2007-06-03 Christian Kellner <ckellner@openismus.com>
967 * libmodest-dbus-client/libmodest-dbus-client.c:
968 (modest_search_hit_list_free):
969 Make it save to call it with NULL.
971 * src/dbus_api/modest-dbus-callbacks.c:
972 * src/modest-search.c:
973 Return full ModestSearchHits as the search result list not TnyHeader
974 since can't be around withouth the correspoding TnyFolder.
976 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
978 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
979 Added currently commented code to check for secure auth
981 * src/maemo/modest-account-settings-dialog.c: (on_response),
982 (save_configuration), (show_ok):
983 Fixed projects.maemo.org bugs NB #59248 and #59251
985 * src/maemo/modest-maemo-utils.c:
986 (on_camel_account_get_supported_secure_authentication_status),
987 (on_camel_account_get_supported_secure_authentication),
988 (modest_maemo_utils_get_supported_secure_authentication_methods):
989 * src/maemo/modest-maemo-utils.h:
990 Moved get_supported_secure_authentication() method here to be able
991 to use it from easysetup wizard.
993 * src/modest-pair.c: (on_pair_compare_as_string):
994 Should compare string with first part of pair and not
995 strcmp pairs which will crash.
997 * src/modest-protocol-info.c:
998 (modest_protocol_info_protocol_is_store):
999 * src/modest-protocol-info.h:
1000 Added modest_protocol_info_get_auth_protocol_name()
1002 2007-06-03 Armin Burgmeier <armin@openismus.com>
1004 * src/modest-mail-operation.c:
1005 (modest_mail_operation_get_msgs_full): Set priv->account also when
1006 only retrieving a single message. This avoids a crash when canceling
1009 (modest_mail_operation_notify_end): Do not explicitely remove the
1010 operation from the queue but only emit the progress_changed signal.
1011 The queue itself listens to that signal to remove the operation when
1012 it is finished. This reduces coupling and removes a potential deadlock
1013 when modest_mail_operation_notify_end() is called from the queue
1014 itself. If that is a problem performance-wise, I would suggest to
1015 implement a status-changed signal or something.
1017 * src/modest-mail-operation-queue.c: Make sure to never call a
1018 function from another file while the queue is locked. This (hopefully)
1019 fixes another deadlock when exiting the application while retrieving
1022 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1024 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1025 Fixed build if libogs is not available
1027 2007-06-03 Christian Kellner <ckellner@openismus.com>
1029 * libmodest-dbus-client/libmodest-dbus-client.h:
1030 * libmodest-dbus-client/libmodest-dbus-client.c:
1031 (libmodest_dbus_client_delete_message):
1032 Implement deletion of messages (Client side).
1034 (modest_search_hit_free),
1035 (modest_search_hit_list_free):
1036 Utility functions to free the result hits.
1038 * src/dbus_api/modest-dbus-api.h:
1039 * src/dbus_api/modest-dbus-callbacks.c:
1040 (on_delete_message),
1041 (modest_dbus_req_handler):
1042 Implement deletion of messages (Server side).
1044 * tests/dbus_api/test_search.c: (main):
1047 * tests/dbus_api/Makefile.am:
1048 * tests/dbus_api/test_delete_message:
1049 Add little test for the message deletion logic
1051 2007-06-03 Armin Burgmeier <armin@openismus.com>
1053 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1054 when the operation queue was not empty. projects.maemo.org bug
1057 2007-06-03 Armin Burgmeier <armin@openismus.com>
1059 * src/widgets/modest-account-view.c
1060 (on_account_default_toggled): Toggle default account column
1061 explicitely instead of waiting for gconf notification (which is
1062 currently ignored). This should fix projects.maemo.org bug NB#56910
1063 for now. It should probably be removed when gconf notifications are
1066 2007-06-03 Christian Kellner <ckellner@openismus.com>
1068 * libmodest-dbus-client/libmodest-dbus-client.c:
1069 Removed debugging spew.
1071 * src/dbus_api/modest-dbus-callbacks.c:
1072 Added debugging info.
1074 * src/modest-search.c:
1075 (modest_search_all_accounts):
1076 Use tny_account_store_get_accounts () on the account store
1077 to get all accounts which is the way to get all accounts.
1079 * tests/dbus_api/test_search.c: (main):
1080 Make it possible to supply the search term on the command line.
1082 2007-06-03 Christian Kellner <ckellner@openismus.com>
1084 * libmodest-dbus-client/libmodest-dbus-client.c:
1085 * libmodest-dbus-client/libmodest-dbus-client.h:
1086 Implement searching for mesages over raw dbus. (Client side)
1088 * src/dbus_api/Makefile.am:
1089 * src/dbus_api/modest-dbus-api.h:
1090 * src/dbus_api/modest-dbus-callbacks.c:
1091 * src/dbus_api/modest-dbus-callbacks.h:
1092 Search framework (Server side). Also implement on_idle_open_message().
1094 * src/maemo/modest-platform.c: (modest_platform_init):
1095 Prepare for raw dbus/osso rpc interaction.
1097 * src/modest-search.h:
1098 Changed minsize from unspecific guint to guint32.
1100 * src/modest-search.c:
1102 Added strange hack which magically made tnymail work.
1104 (modest_search_folder),
1105 (modest_search_account),
1106 (modest_search_all_accounts):
1107 Implement helper functions to search all accounts, specific account
1110 * tests/dbus_api/Makefile.am:
1111 * tests/dbus_api/test_open_message.c:
1112 Read url to open from commandline.
1114 * tests/dbus_api/test_search.c:
1115 Implement small test for dbus search stuff
1117 2007-06-02 Armin Burgmeier <armin@openismus.com>
1119 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1120 include account type and account title. This fixes projects.maemo.org
1123 * src/maemo/modest-account-view-window.c: Set a title for the window.
1125 2007-06-02 Armin Burgmeier <armin@openismus.com>
1127 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1128 incoming and outgoing server name based on email address and server
1129 types as long as the names have not been edited manually. This fixes
1130 projects.maemo.org bug NB#58671.
1132 2007-06-02 Armin Burgmeier <armin@openismus.com>
1134 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1135 server type cannot be changed in future to the incoming details page
1136 when creating an account. This fixes projects.maemo.org bug NB#59029.
1138 2007-06-02 Armin Burgmeier <armin@openismus.com>
1140 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1141 and assigned max width chars so that they wrap instead of being
1142 truncated. Fixes projects.maemo.org bug NB#56126.
1144 2007-06-02 Armin Burgmeier <armin@openismus.com>
1146 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1147 introductory note to the connection specific smtp servers dialog, as
1148 section 8.12 of the email UI specification requires. This fixes
1149 projects.maemo.org bug NB#59212.
1151 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1153 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1154 Check for running mail operations, and offer to cancel them, as per the UI
1155 spec. This fixes projects.maemo.org bug NB#59041 .
1156 However, I suspect that tinymail may still use the network connection
1157 in ways that we cannot detect or cancel. But it should at least adapt to
1158 changes fairly well.
1160 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1162 * src/modest-tny-account-store.c: (recreate_all_accounts),
1163 (get_cached_accounts), (get_server_accounts): Do more sensible
1164 ref-counting of the temporarily-cached outbox accounts list. This seems
1165 to fix a crash when entering the password when the password was wrong.
1167 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1169 * src/gnome/modest-main-window.c: (connect_signals):
1170 * src/modest-tny-account-store.c: (get_password),
1171 (modest_tny_account_store_alert): Added comments and clues and
1172 commented-out code about how we currently fail to deal with connection
1173 errors and wrong passwords, and how we should.
1175 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1177 * src/widgets/modest-retrieve-combo-box.c:
1178 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1179 This fixes projects.maemo.org bug NB#58472 .
1181 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1183 * src/maemo/easysetup/modest-easysetup-wizard.c:
1184 (create_page_complete_easysetup):
1185 (create_page_complete_custom): Correct the last commit,
1186 putting the correct sentences in the correct pages.
1188 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1190 * src/maemo/easysetup/modest-easysetup-wizard.c:
1191 (create_page_complete_custom): Show the second sentence of text
1192 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1195 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1198 Set the leave-on-server conf key by default. This fixes
1199 projects.maemo.org bug NB#59258 .
1201 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/modest-account-view-window.c:
1204 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1205 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1208 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1210 * src/maemo/easysetup/modest-easysetup-wizard.c:
1211 (create_caption_new_with_asterisk):
1212 * src/maemo/modest-account-settings-dialog.c:
1213 (create_caption_new_with_asterisk):
1214 Uncomment the code to add the asterisk, because they are no longer in the
1215 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1216 (update_incoming_server_title): Add an asterisk here too.
1218 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1220 * src/maemo/modest-maemo-global-settings-dialog.c:
1221 (current_connection): Check that we are even connected before trying to
1222 get the current connection name, to prevent a warning.
1224 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1225 Change the comments because tny_maemo_conic_device_connect() is now meant to
1227 * src/modest-mail-operation.c:
1228 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1229 make sure we have a connection and fail if we can't connect.
1231 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/modest-main-window.c:
1234 (on_account_store_connecting_finished): Do not try to get the
1235 connection ID if we are not really connected. I am surprised that
1236 this signal handler is called when we are not connected.
1238 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1240 * src/modest-error.h:
1241 * src/modest-ui-actions.c:
1242 (modest_ui_actions_get_msgs_full_error_handler):
1243 Renamed an enum, added comments, added an enum
1244 for retrieve-limit errors.
1246 * src/modest-mail-operation.c: (foreach_add_item),
1247 (internal_folder_observer_update), (update_account_thread),
1248 (modest_mail_operation_get_msgs_full):
1249 (modest_mail_operation_update_account),
1250 Added comments about how this works, and some code that should
1251 (but does not) check the retrieve-limit. See the TODO comment.
1253 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1256 Initialize help_id to fix the build. Warnings are good.
1258 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1260 * src/widgets/modest-hbox-cell-renderer.c:
1261 (modest_hbox_cell_renderer_append):
1262 * src/widgets/modest-vbox-cell-renderer.c:
1263 (modest_vbox_cell_renderer_append):
1264 Fix the last commit by doing an extra ref.
1266 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1268 * src/widgets/modest-hbox-cell-renderer.c:
1269 (modest_hbox_cell_renderer_append):
1270 * src/widgets/modest-vbox-cell-renderer.c:
1271 (modest_vbox_cell_renderer_append):
1272 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1273 to fix the build with Maemo Bora.
1274 However, there seems to be a remaining crash, probably due to reference
1277 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1279 * src/modest-tny-account.c:
1280 (modest_tny_account_new_for_local_folders):
1281 Use hildon_file_system_info_async_new() to get a better name for
1282 the memory card account, setting it as the account name.
1283 The timing seems to work, but this is probably
1284 not the best place to do this. See the TODO comment.
1285 * src/maemo/modest-main-window.c: (create_details_widget):
1286 * src/widgets/modest-folder-view.c: (text_cell_data):
1287 Use the tny account name instead of hardcoding a name.
1289 2007-05-30 Christian Kellner <ckellner@openismus.com>
1291 * src/modest-search.c: (modest_search):
1292 Correctly set part_search_func even if we have already parsed
1293 the query and thus a valid OgsTextSearcher object.
1295 2007-05-30 Christian Kellner <ckellner@openismus.com>
1298 Search and check for libogs.
1301 Incooparte the ogs build env.
1303 * src/modest-mime-part-search-stream.c:
1304 * src/modest-mime-part-search-stream.h:
1305 Removed since we do the real searching now in modest-search.c.
1307 * src/modest-search.c:
1308 * src/modest-search.h:
1309 Implement support for ogs. We use that if available and requested
1310 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1311 should now handle the corner case when the search term is spread
1312 across multiple reads.
1313 Also the logic in modest_search () was corrected to search all
1314 requested fields until one is found.
1316 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1318 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1320 * src/modest-init.h:
1321 * src/modest-init.c: Made modest_init_local_folders() take a
1322 path and be public so we can iniitialize maildir folders on
1325 * src/modest-local-folder-info.h:
1326 * src/modest-local-folder-info.c:
1327 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1329 * src/modest-tny-account.c:
1330 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1331 still means the standard local-folders path on the local volume.
1333 * src/modest-tny-account-store.c:
1334 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1335 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1336 all accounts when that happens.
1337 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1338 this too, so it shows up in the treeview.
1340 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1342 * src/maemo/modest-maemo-global-settings-dialog.c:
1343 (current_connection):
1344 * src/widgets/modest-global-settings-dialog.c:
1345 (current_connection_default):
1346 Use the enum values instead of 0, 1 and -1,
1347 to make the code clearer.
1349 * src/modest-account-mgr-helpers.c:
1350 (modest_account_mgr_get_connection_specific_smtp): Make this code
1353 * src/modest-runtime.h:
1354 * src/modest-runtime.c:
1355 Added modest_runtime_remove_all_send_queues().
1356 * src/maemo/modest-main-window.c:
1357 (on_account_store_connecting_finished): Recreate the send queues,
1358 using the appropriate transport accounts for this new connection.
1359 Some futher adapting might be needed if the old send queues are not
1360 automatically stopped at this point.
1362 * src/modest-tny-account-store.c: (get_server_accounts):
1363 Create the connection-specific transport accounts, so that they can
1364 be found later by their ID.
1366 * src/modest-tny-account.h:
1367 * src/modest-tny-account.c:
1368 Added modest_tny_account_new_from_server_account_name().
1369 modest_tny_account_new_from_server_account(): Do not create the
1370 send queues here, because they will be
1371 recreated anyway when the connection changes for the first time.
1373 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1375 * src/modest-local-folder-info.h:
1376 * src/modest-local-folder-info.c:
1377 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1378 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1379 tbox_folder): Take a modest account name instead of a server TnyAccount,
1380 so we can have per-modest-account rather than per-transport-account
1382 We must make sure that we change or recreate the exisitng send queues
1383 when the connection changes for connection-specific transport accounts.
1385 * src/modest-tny-account-store.c:
1386 (create_per_account_local_outbox_folders): Create outboxed per modest
1387 account, not per transport account.
1389 * src/modest-tny-account.h:
1390 * src/modest-tny-account.c:
1391 (modest_tny_account_get_special_folder): For outboxes, get the
1392 parent modest account name. The account is ignored for other folders.
1393 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1394 modest account name rather than a server TnyAccount.
1396 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1398 * src/modest-tny-account.c:
1399 (modest_tny_account_new_from_server_account):
1400 Call modest_runtime_get_send_queue() immediately after creating transport
1401 accounts, so that they start trying to send email from the outbox as soon
1402 as possible at startup. This is probably what we want.
1404 * src/modest-mail-operation.c: (update_account_thread):
1405 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1406 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1407 * src/modest-tny-send-queue.h:
1408 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1409 (modest_ui_actions_on_send):
1410 Added comments about how sending works, though it needs some more work.
1412 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1414 * src/modest-tny-account.c:
1415 (modest_tny_account_get_special_folder): Add TODO because this fails when
1416 the network is busy.
1417 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1418 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1419 Do not try to show this window when there is no active account. The UI
1420 specs does not tell us what to do in this case.
1422 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1426 * src/maemo/Makefile.am:
1427 * src/widgets/Makefile.am: Some dist fixes.
1429 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1431 * src/maemo/modest-connection-specific-smtp-window.c:
1432 (on_button_edit): Make the code clearer, to prevent a double free.
1434 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1436 * src/maemo/modest-account-settings-dialog.c:
1437 (modest_account_settings_dialog_set_account_name),
1438 Check the connection-specific smtp servers checkbox if there are any.
1440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1441 (modest_connection_specific_smtp_edit_window_init):
1442 Start with a suitable port number.
1444 * src/modest-account-mgr-helpers.h:
1445 * src/modest-account-mgr-helpers.c: Added
1446 modest_account_mgr_get_has_connection_specific_smtp().
1448 (modest_account_mgr_set_connection_specific_smtp),
1449 (modest_account_mgr_remove_connection_specific_smtp),
1450 (modest_account_mgr_get_has_connection_specific_smtp),
1451 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1452 connection-specific smtp server accounts in the account, rather than
1453 the server account conf dir.
1455 This fixes bug projects.maemo.org bug NB#58263 .
1457 * src/modest-tny-account-store.c:
1458 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1459 if there are no server accounts yet, to prevent an infinite loop when there
1460 are no accounts. Document that one must be called before the other.
1462 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-account-mgr-helpers.c:
1465 (modest_account_mgr_get_default_account): Make sure that at least
1466 one account is always the default, if there are any enabled accounts.
1467 This is just a sanity check that shouldn't be necessary.
1469 * src/modest-account-mgr-priv.c:
1470 (_modest_account_mgr_account_from_key): Unescape the conf key to
1471 get the real account name. For instance, this is an issue if a space
1472 was in the account name, which can happen because the account name
1473 is generated from the display name.
1474 (_modest_account_mgr_get_account_keyname): Always escape the
1476 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1477 Unescape the conf keys to get the real account names.
1479 For instance, previously the is-default radio button in the accounts
1480 list was not checked for any accounts at first. This fixes that,
1481 and might fix several similar bugs.
1483 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1485 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1486 Removed some debug printfs.
1488 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1490 Modest on-disk outbox directories are now here, for instance:
1491 $HOME/.modest/outboxes/<account-id-1>/outbox
1492 $HOME/.modest/outboxes/<account-id-2>/outbox
1494 $HOME/.modest/local-folders/outbox
1495 so we can have a separate outbox for each account.
1496 But they are shown as one outbox in the GtkTreeView, by using a
1497 TnyMergeFolder in a ModestTnySimpleFolderStore.
1500 * src/modest-tny-simple-folder-store.c:
1501 * src/modest-tny-simple-folder-store.h:
1502 Added ModestTnySimpleFolderStore, used to contain folders from
1503 other folder stores, such as other accounts.
1505 * src/modest-tny-outbox-account.h:
1506 * src/modest-tny-outbox-account.c:
1507 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1508 used for the per-account local outbox folders.
1510 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1511 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1512 only use this (internally) now for the non-outbox local folders.
1514 * src/modest-init.h:
1515 * src/modest-init.c: Added modest_init_one_local_folder(), for
1516 setting up the directory structure for each local folder.
1518 * src/modest-local-folder-info.c:
1519 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1520 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1522 * src/modest-local-folder-info.h:
1523 * src/modest-tny-account-store.c: (on_account_removed),
1524 (on_account_changed), (create_per_account_local_outbox_folders),
1525 (get_server_accounts), (modest_tny_account_store_get_accounts),
1526 (modest_tny_account_store_get_tny_account_by_account),
1527 (modest_tny_folder_store_is_virtual_local_folders):
1529 * src/modest-tny-account.h:
1530 * src/modest-tny-account.c:
1531 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1532 to create an on-disk per-account local outbox folder for each
1534 (create_per_account_local_outbox_folders): Create a local outbox folder
1535 for each transport account.
1536 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1537 for all local folders.
1539 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1540 instead of using g_object_get/set() directly. It is clearer.
1542 (modest_tny_folder_store_get_message_count),
1543 (modest_tny_folder_store_get_local_size
1544 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1545 because we now use these with non-acount folder stores.
1547 (modest_tny_account_get_special_folder),
1548 (modest_tny_account_new_from_server_account),
1549 (modest_tny_account_new_from_account):
1550 (recurse_folders): Adjust to the new outbox system.
1552 * src/modest-tny-folder.h:
1553 * src/modest-tny-folder.c:
1554 (modest_tny_folder_is_local_folder),
1555 (modest_tny_folder_get_local_folder_type),
1556 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1558 * src/widgets/modest-main-window.h:
1559 * src/maemo/modest-main-window.c: (create_details_widget),
1560 (modest_main_window_set_contents_style): Show details for any folder store,
1563 (modest_tny_folder_get_rules):
1564 Remove the const. C does not support constness enough for this.
1566 * src/modest-ui-actions.c:
1567 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1568 make all outboxes appear as one, in the usual local-folders tree node.
1570 (set_active_account_from_tny_account),
1571 (modest_ui_actions_on_folder_selection_changed):
1572 * src/widgets/modest-folder-view.c: (text_cell_data),
1573 (icon_cell_data), (filter_row),
1574 (add_account_folders_to_merged_folder),
1575 (add_account_folders_to_simple_folder_store), (),
1576 (get_cmp_rows_type_pos), (cmp_rows),
1577 (modest_folder_view_set_account_id_of_visible_server_account):
1578 Adjust to the new outbox system, using generic folder stores and folders
1579 in the GtkTreeModel.
1581 2007-05-23 Christian Kellner <ckellner@openismus.com>
1583 * src/modest-mail-operation.c:
1584 (modest_mail_operation_update_account):
1585 Use info->max_size instead of unintialized local var [small
1586 build fix]. (Added TODO to review that change since I don't
1589 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1591 * libmodest-dbus-client/libmodest-dbus-client.c:
1592 (libmodest_dbus_client_compose_mail): function added
1593 * src/dbus_api/modest-dbus-api.h:
1594 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1595 (on_compose_mail): Implementation of the SendAsMail functionality
1597 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1599 * src/modest-account-mgr.c:
1600 (modest_account_mgr_add_server_account): Set the secure-connection
1601 conf key for transport accounts as well as store accounts. I don't know
1602 why the if was there. For instance, this makes sure that we use SSL
1603 for the gmail preset from the easysetup wizard.
1605 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1607 * src/gnome/modest-main-window.c:
1608 (on_account_store_connecting_finished), (connect_signals):
1609 * src/maemo/modest-main-window.c:
1610 (on_account_store_connecting_finished), (connect_signals),
1611 (modest_main_window_new):
1612 Handle TnyAccountStore::connecting-finished instead of
1613 TnyDevice::connection-changed, because we cannot actually perform
1614 operations on accounts until TnyAccountStore has itself responded to
1615 the TnyDevice::connection-changed signal. This prevents a GError from
1617 Do not try to update at startup, because we (at least on scratchbox)
1618 already do an update at startup when the device goes online.
1619 This prevents a GError from tinymail.
1620 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1621 Added TODO about stopping simultaneous operations.
1623 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1626 * src/modest-mail-operation-queue.c:
1627 (modest_mail_operation_queue_remove):
1628 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1629 about where they happened.
1631 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1633 * src/modest-ui-actions.c:
1634 (modest_ui_actions_on_password_requested): Make sure that the remember
1635 output parameter is always TRUE.
1637 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1639 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1640 Show a OK/Cancel dialog if the error is a question, though we still do not
1641 know anything more about what we are asking the user.
1642 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1643 Fix an uninitialized variable (helper). This is a logic error, however.
1645 2007-05-21 Christian Kellner <ckellner@openismus.com>
1647 * src/modest-search.h:
1648 Correct bit shifting in the ModestSearchFlags enum.
1650 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1652 * src/modest-tny-account.c:
1653 (modest_tny_account_new_from_server_account): Do not use the lsub and
1654 check-all hard-coded IMAP options when using POP.
1656 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-tny-account.c:
1659 (modest_tny_account_new_from_server_account):
1660 Use NULL for the secure-auth method for POP when Password auth has been
1661 specified by the user, as we already do for IMAP. "auth=Login" causes
1662 an error from camel or the server.
1664 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1666 * src/maemo/modest-account-settings-dialog.c:
1667 (create_page_account_details),
1668 (modest_account_settings_dialog_set_account_name):
1669 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1670 for the leave-on-server checkbox, rathr than just the checkbox, when
1671 the protocol is not POP.
1673 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1675 * src/widgets/modest-account-view.c:
1676 * src/widgets/modest-account-view.h:
1677 Added modest_account_view_select_account() which will be useful later
1678 to asynchronously re-select the edited account.
1680 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1682 * src/maemo/modest-account-settings-dialog.c:
1683 (modest_account_settings_dialog_set_account_name):
1684 Automatically choose the port numbers based on the secure authentication
1685 methods, if they have not been chosen before.
1686 This fixes projects.maemo.org bug NB#56273 .
1688 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1690 * src/maemo/modest-main-window-ui.h:
1691 * src/modest-ui-actions.c:
1692 * src/modest-ui-actions.h:
1693 Connect the Tools/SMTP Servers menu item to
1694 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1695 SMTP servers dialog, as in the UI specification and saves changes when it
1696 is closed. This fixed projects.maemo.org bug NB#56305 .
1698 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1700 * src/maemo/modest-connection-specific-smtp-window.c:
1701 (modest_connection_specific_smtp_window_init):
1702 Use gtk_window_set_default_size() to make this window big enough, so
1703 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1705 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1707 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1708 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1709 (modest_connection_specific_smtp_edit_window_init),
1710 Do not try to connect to a combobox signal before the combobox exists.
1711 This fixes the cras in projects.maemo.org bug NB#56288 .
1712 (modest_connection_specific_smtp_edit_window_get_settings):
1713 Remove the server_account_name parameter which was being checked for NULL
1714 though it was not used.
1716 * src/maemo/modest-connection-specific-smtp-window.c:
1717 (modest_connection_specific_smtp_window_fill_with_connections),
1718 (on_button_edit), (modest_connection_specific_smtp_window_init):
1719 Correct the number of treemodel columns to prevent a warning.
1720 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1721 libconic does not work.
1723 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1725 * src/modest-tny-account.c:
1726 (modest_tny_account_new_from_server_account):
1727 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1728 SMTP when "None" was chosen by the user. However, with my SMTP server that
1729 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1732 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1734 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1735 to explain the memory management issue with the ID in the ModestPair.
1737 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1738 (add_sending_page), (modest_account_assistant_finalize):
1739 * src/gnome/modest-gnome-global-settings-dialog.c:
1740 (create_updating_page), (create_composing_page):
1741 * src/gnome/modest-msg-edit-window.c: (get_transports),
1742 (init_window), (modest_msg_edit_window_finalize),
1743 (modest_msg_edit_window_get_msg_data):
1744 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1745 * src/gnome/modest-transport-widget.c:
1746 (modest_transport_widget_finalize), (smtp_configuration):
1747 * src/maemo/modest-maemo-global-settings-dialog.c:
1748 (create_updating_page), (create_composing_page):
1749 * src/maemo/modest-msg-edit-window.c: (get_transports),
1750 (init_window), (modest_msg_edit_window_finalize),
1751 (modest_msg_edit_window_get_msg_data),
1752 (modest_msg_edit_window_free_msg_data):
1753 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1754 (modest_store_widget_finalize):
1755 * src/maemo/modest-transport-widget.c:
1756 (modest_transport_widget_finalize), (smtp_configuration):
1757 * src/modest-main.c: (send_mail):
1758 * src/widgets/modest-combo-box.h:
1759 * src/widgets/modest-global-settings-dialog-priv.h:
1760 * src/widgets/modest-global-settings-dialog.c:
1761 (modest_global_settings_dialog_finalize):
1762 * src/widgets/modest-msg-edit-window.h:
1763 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1764 as long as the combo box, to prevent use of freed memory for the ID.
1766 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1769 get_accounts(), to make this clearer. Do not check for the enabled gconf
1770 key, because we do not use this for server accounts (at least, not yet).
1771 This allows us to send email again.
1773 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/modest-platform.c:
1776 (on_modest_conf_update_interval_changed), (modest_platform_init):
1777 Only respond to this particular key change. All these strcmp()s cannot be
1780 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1782 * src/maemo/modest-maemo-global-settings-dialog.c:
1783 (current_connection): Prevent a crash in scratchbox when
1784 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1785 * src/maemo/modest-platform.c:
1786 (on_modest_conf_update_interval_changed), (modest_platform_init):
1787 Get the update interval from gconf and reset it when the gconf key changes.
1789 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-protocol-info.c:
1792 * src/modest-protocol-info.h: Adde enum-specific get functions,
1793 instead of using a ModestProtocolType enum parameter.
1795 * src/gnome/modest-account-assistant.c:
1796 * src/gnome/modest-store-widget.c:
1797 * src/gnome/modest-store-widget.h:
1798 * src/gnome/modest-transport-widget.c:
1799 * src/gnome/modest-transport-widget.h:
1800 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1801 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1802 * src/maemo/easysetup/modest-easysetup-wizard.c:
1803 * src/maemo/modest-account-settings-dialog.c:
1804 * src/maemo/modest-account-settings-dialog.h:
1805 * src/maemo/modest-store-widget.c:
1806 * src/maemo/modest-store-widget.h:
1807 * src/maemo/modest-transport-widget.c:
1808 * src/maemo/modest-transport-widget.h:
1809 * src/modest-account-mgr-helpers.c:
1810 * src/modest-account-mgr-helpers.h:
1811 * src/modest-account-mgr.c:
1812 * src/modest-account-mgr.h:
1813 * src/modest-tny-account.c:
1814 * src/modest-tny-folder.c:
1815 * src/widgets/modest-account-view.c:
1816 * src/widgets/modest-retrieve-combo-box.c:
1817 * src/widgets/modest-retrieve-combo-box.h:
1818 * src/widgets/modest-secureauth-combo-box.c:
1819 * src/widgets/modest-serversecurity-combo-box.c:
1820 * src/widgets/modest-serversecurity-combo-box.h:
1821 * tests/check_account-mgr.c:
1822 Use the specific functions, and use the re-renamed enum values for GNOME too.
1824 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-pair.h:
1827 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1828 so we can get the second based on the first.
1830 * src/maemo/modest-account-settings-dialog.h:
1831 * src/maemo/modest-account-settings-dialog.c:
1832 Added get_supported_secure_authentication_methods(), though it is mostly
1833 commented-out for now until the necessary API is committed to tinymail.
1834 (modest_account_settings_dialog_set_account_name),
1835 (save_configuration): Request the supported authentication methods from the
1836 server, so we can choose a working method.
1838 * src/modest-tny-account-store.h:
1839 * src/modest-tny-account-store.c:
1840 (modest_tny_account_store_get_session): Rename from
1841 tny_account_store_get_session().
1843 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1845 * src/modest-protocol-info.h: Split the ModestProtocol enum
1846 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1847 There was no need to have these unrelated values in one enum.
1849 * src/: many files: Adapted to changed enum. This makes the code a bit
1850 clearer, and the compiler could catch some errors.
1852 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1854 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1855 Show the detailed internal camel error message when an error happens
1856 during the configuration, so that our testers can give us more clues.
1857 For instance, in projects.maemo.org bug NB#56910 .
1859 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1861 * src/modest-tny-account.c:
1862 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1863 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1865 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1867 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1868 * src/maemo/modest-account-settings-dialog.c:
1869 (modest_account_settings_dialog_set_account_name),
1870 (save_configuration): For the incoming secure authentication checkbox,
1871 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1872 the UI specification. PLAIN does not seem to be supported for most IMAP
1873 servers anyway, and I am not sure what it would mean.
1874 However, we probably need to discover which of the secure-authentication
1875 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1876 * src/modest-account-mgr-helpers.c:
1877 (modest_account_mgr_get_server_account_data):
1879 * src/modest-tny-account.c:
1880 (modest_tny_account_new_from_server_account):
1881 Use tny_account_set_mech() to set secure-authentication methods,
1882 with some special-casing for IMAP, based on my observations of how
1885 * src/modest-account-mgr-helpers.h:
1886 * src/modest-account-mgr.c:
1887 * src/modest-defs.h: Comment that the URI is only used for local folders.
1889 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1891 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1892 parameter const, just to be neat.
1893 * src/modest-text-utils.c: (modest_text_utils_inline):
1894 End g_strconcat() with NULL, as its documentation says. This is almost
1895 certainly the cause of my crash at startup on the device. Interestingly,
1896 valgrind doesn't tell us about these errors.
1898 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1900 * scripts/build-packages: Added more precise comments about how to use
1901 this script, though I still get this error:
1902 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1903 error building tinymail
1905 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1907 * src/maemo/modest-main-window.c: (on_account_update):
1908 Very slight cleanup, hoping to make it simpler to discover what causes
1909 a crash here sometimes.
1911 * src/modest-tny-account.c:
1912 (modest_tny_account_new_from_server_account): Set the port. Added
1913 comments about the options and a TODO comment because I need to find out
1914 how to specify the secure authentication method.
1916 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1918 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1919 changed CFlags paths form modest to libmodest
1921 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1923 * src/modest-account-mgr-helpers.c:
1924 (modest_account_mgr_get_server_account_data),
1925 (modest_account_mgr_free_server_account_data):
1926 * src/modest-account-mgr-helpers.h:
1927 * src/modest-account-mgr.c:
1928 (modest_account_mgr_add_server_account):
1929 * src/modest-defs.h:
1930 * src/modest-tny-account.c:
1931 (modest_tny_account_new_from_server_account):
1932 Determine the options for tny_camel_account_add_option() here,
1933 based on the settings, rather than storing them directly in gconf.
1935 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1937 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1938 Show a more friendly error dialog now that we expect (from the tinymail
1939 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1941 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1943 * src/maemo/modest-main-window.c: (on_account_update): Check that
1944 account_name is not NULL, to prevent a crash at startup that I am
1945 seeing on the N800. I do wonder why it is NULL.
1947 * src/maemo/easysetup/modest-easysetup-wizard.c:
1948 (create_page_user_details):
1949 * src/maemo/modest-account-settings-dialog.c:
1950 (create_page_user_details), (create_page_outgoing):
1951 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1952 (modest_connection_specific_smtp_edit_window_init):
1953 * src/modest-ui-actions.c:
1954 (modest_ui_actions_on_password_requested):
1955 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1956 might do something useful with the on-screen keyboard.
1958 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1960 * src/maemo/modest-main-window.c: (on_account_update):
1961 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1962 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1964 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1966 * src/modest-tny-account-store.c: (on_account_changed):
1967 Correct the signature of this signal handler.
1969 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1971 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1972 Show a HildonNote instead of a GtkDialog for Maemo.
1974 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1976 * src/widgets/modest-account-view.h:
1977 * src/widgets/modest-account-view.c: (on_account_changed),
1978 (on_account_removed). Added a boolean flag, set/unset by
1979 modest_account_view_block_conf_updates(),
1980 modest_account_view_unblock_conf_updates() to prevent unnecessary
1981 updates, but this is not very useful because the gconf notifications are
1982 so delays (maybe only on Maemo Bora).
1983 So auto-updating is turned off, and these functions do an explicit
1984 update when necessary.
1985 However, something else is still doing too much work when adding/removing
1986 accounts, probably in another part of the application.
1988 * src/maemo/modest-account-view-window.c:
1989 (on_delete_button_clicked), (on_edit_button_clicked),
1990 (on_new_button_clicked): Use the new functions.
1992 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1994 * src/modest-account-mgr-helpers.c:
1995 (modest_account_mgr_set_first_account_as_default):
1996 Sort the list of names alphabetically-by-title, so we choose the first one
1998 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1999 alphabetically by the title.
2001 This fixes projects.maemo.org bug NB#56418 .
2003 * src/modest-account-mgr-priv.c:
2004 (_modest_account_mgr_account_from_key):
2005 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2006 avoid a valgrind error, and possible random behaviour.
2008 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2010 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2011 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2012 tinymail documentation to say that this can be expected.
2013 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2014 pretty, and should not happen, but I would prefer to know when it does.
2016 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2018 * configure.ac: When using the older hildon version, probably on Bora,
2019 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2021 * src/widgets/modest-attachment-view.c:
2022 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2025 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2027 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2028 Implemented the prototype. Can be tested with
2029 tests/dbus_api/test_open_message:
2031 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2033 * src/modest-tny-account-store.c:
2034 (modest_tny_account_store_instance_init), (get_password):
2035 * src/modest-ui-actions.c:
2036 (modest_ui_actions_on_password_requested):
2037 Do not store the password in gconf, because this function is called
2038 for non-remembered passwords. Actually use the cached (in the hash map)
2039 password instead of releasing it.
2040 The password will now not be remembered if it is asked via the protected
2041 password dialog, as per the UI spec.
2043 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2045 * src/modest-defs.h:
2046 * src/modest-account-mgr-helpers.h:
2047 * src/modest-account-mgr-helpers.c:
2048 Added modest_server_account_get_username_has_succeeded(),
2049 modest_server_account_set_username_has_succeeded().
2050 (modest_server_account_set_username),
2051 Reset the has-succeeded flag if the username changes.
2053 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2054 * src/maemo/modest-connection-specific-smtp-window.c:
2055 (modest_connection_specific_smtp_window_save_server_accounts):
2056 Use modest_server_account_set_username() instead of using
2057 modest_conf_set_string() directly, so that the has-succeeded flag is always
2060 * src/modest-ui-actions.c:
2061 (modest_ui_actions_on_password_requested): Dim the username entry if
2062 the username has ever worked, as per the UI spec.
2064 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2066 * src/modest-tny-account-store.c: (get_password):
2067 * src/modest-ui-actions.c:
2068 (modest_ui_actions_on_password_requested):
2069 Allow the username to be changed too, though there is more work to
2070 be done on exactly how this behaves.
2072 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2074 * src/modest-account-mgr-helpers.h:
2075 * src/modest-account-mgr-helpers.c:
2076 Added modest_account_mgr_get_display_name(),
2077 modest_server_account_get_username(),
2078 modest_server_account_set_username(),
2079 modest_server_account_set_password(),
2080 modest_server_account_get_hostname() functions so we do not need to
2081 use the conf API directly.
2083 * src/maemo/modest-main-window.c: (connect_signals):
2084 Actually connect ot the ModestAccountStore::request-password signal,
2085 so that we show the dialog when the password is requested by Tinymail,
2086 for isntance if it is empty.
2088 * src/modest-marshal.list:
2089 * src/modest-tny-account-store.c:
2090 (modest_tny_account_store_class_init), (get_password),
2091 (modest_tny_account_store_alert):
2092 * src/modest-tny-account-store.h:
2093 * src/modest-ui-actions.h:
2094 * src/modest-ui-actions.c:
2095 (modest_ui_actions_on_password_requested):
2096 Change the signal parameters, so it is obvious that we are providing
2097 the non human-readable server name, and receiving both the username
2098 and password, though changing of the username is not yet implemented.
2099 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2100 for the GNOME version.
2102 This should fix the projects.maemo.org bug NB#56209, though it does not
2103 work on Bora, because the gconf_client_get() for the password fails
2104 immediately after we save it with gconf_client_set().
2106 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2109 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2110 caused an undefined symbol error:
2111 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2113 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2115 * src/modest-tny-account-store.c:
2116 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2117 using a GError instead of a string message, so we can translate it in
2120 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/modest-address-book.c:
2123 (modest_address_book_check_names):
2124 * src/maemo/modest-msg-view-window.c:
2125 (modest_msg_view_window_clipboard_owner_change):
2126 * src/modest-init.c: (modest_init_init_ui):
2127 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2128 (update_folders_cb), (modest_mail_operation_update_account):
2129 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2130 (modest_ui_actions_on_msg_attachment_clicked),
2131 (modest_ui_actions_on_msg_recpt_activated):
2132 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2133 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2134 (modest_msg_view_search_next):
2135 * src/widgets/modest-recpt-editor.c:
2136 (modest_recpt_editor_on_button_release_event),
2137 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2138 g_message(). At this point we should only be seeing interesting errors on
2139 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2141 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2143 (modest_wizard_dialog_force_title_update):
2144 * src/maemo/easysetup/modest-wizard-dialog.h:
2145 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2146 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2147 can update the title when appropriate. Otherwise the title is wrong if the
2148 pages are added after adding the notebook to the dialog.
2149 This must be a problem in HildonWizardDialog too.
2150 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2152 * src/maemo/easysetup/modest-easysetup-wizard.c:
2153 (create_subsequent_customsetup_pages),
2154 (create_subsequent_easysetup_pages):
2155 Call modest_wizard_dialog_force_title_update() so that the title is
2156 correct even with GTK+ < 2.10.
2157 This fixes projects.maemo.org bug NB#56145 .
2159 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2161 * src/maemo/modest-platform.c:
2162 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2163 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2166 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2168 * src/widgets/modest-window.h:
2169 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2170 and modest_window_save_state(), which invokes it.
2172 * src/widgets/modest-window-mgr.h:
2173 * src/widgets/modest-window-mgr.c:
2174 Added modest_window_mgr_save_state_for_all_windows(), which calls
2175 the save_state vfunc on all registered windows, if implemented.
2177 * src/gnome/modest-msg-edit-window.c:
2178 * src/gnome/modest-msg-view-window.c:
2179 * src/maemo/modest-msg-edit-window.c:
2180 * src/maemo/modest-msg-view-window.c:
2181 * src/maemo/modest-main-window.c:
2182 Specify the existing save_settings functions as implementations of
2183 ModestWindow::save_state_func().
2185 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2186 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2187 enabling hibernation, for instance.
2189 We may need to do the same thing for restoring settings.
2192 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2194 * src/widgets/modest-window-mgr.c:
2195 * src/widgets/modest-window-mgr.h:
2196 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2197 modest_window_mgr_get_hibernation_is_prevented().
2199 * src/maemo/modest-main-window.c:
2200 (on_hildon_program_is_topmost_notify): Prevent hibernation
2201 (possible when the application goes to the background in the WM),
2202 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2204 * src/maemo/easysetup/modest-easysetup-wizard.c:
2205 (modest_easysetup_wizard_dialog_init):
2206 * src/maemo/modest-account-settings-dialog.c:
2207 (modest_account_settings_dialog_init):
2208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2209 (modest_connection_specific_smtp_edit_window_init):
2210 * src/maemo/modest-connection-specific-smtp-window.c:
2211 (modest_connection_specific_smtp_window_init):
2212 * src/maemo/modest-signature-editor-dialog.c:
2213 (modest_signature_editor_dialog_init):
2214 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2215 prevent hibernation while any of these account settings dialogs are open.
2217 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2219 * src/maemo/Makefile.am:
2220 * src/maemo/modest-osso-state-saving.c:
2221 * src/maemo/modest-osso-state-saving.h: Added
2222 modest_osso_load_state() and modest_osso_save_state() though they do
2223 nothing now. They should iterate through all the open windows and load/save
2225 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2226 save state when closing.
2228 * src/maemo/modest-main-window.c:
2229 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2230 Add a notification handler for the HildonProgram::is-topmost property,
2231 so we can allow hibernation when the application goes into the background.
2232 But we still need to detect when the accounts setup windows are open so
2233 we can stop hibernation when they are open.
2234 To do this, I also added the main window the HildonProgram. This might have
2235 other side-effects/benefits, and should maybe be done for other windows.
2237 * src/maemo/modest-osso-autosave-callbacks.h:
2238 * src/maemo/modest-osso-autosave-callbacks.c:
2239 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2240 though it does not do anything yet, and we might never need this to do
2241 anything. For instance, we already save drafts.
2243 * src/maemo/modest-platform.c: (modest_platform_init):
2244 Specify the libosso auto-save callback.
2246 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2248 * src/maemo/modest-platform.c:
2249 (modest_platform_set_update_interval):
2250 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2251 aparently stays valid between application instances, so we can use this
2252 to remove and reset it later. According to a maemo-developers email from
2255 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2257 * configure.ac: Depend on libalarm for Maemo.
2259 * src/dbus_api/modest-dbus-api.h:
2260 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2261 (on_send_receive), (modest_dbus_req_handler):
2262 Handle a SEND_RECEIVE D-Bus method.
2264 * libmodest-dbus-client/libmodest-dbus-client.c:
2265 (libmodest_dbus_client_send_and_receive):
2266 * libmodest-dbus-client/libmodest-dbus-client.h:
2267 Add C convenience functions for calling the new D-Bus method.
2269 * src/modest-platform.h:
2270 * src/gnome/modest-platform.c:
2271 * src/maemo/modest-platform.c:
2272 Added modest_platform_set_update_interval(), which uses the
2273 alarmd API on Maemo.
2274 (modest_platform_init),
2275 Call modest_platform_set_update_interval(), using a hard-coded
2276 interval for now (until the global settings dialog is implemented),
2277 though I am not sure that this makes sense yet.
2279 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2281 * src/dbus_api/modest-dbus-callbacks.c:
2282 (modest_osso_cb_hw_state_handler):
2283 * src/dbus_api/modest-dbus-callbacks.h:
2284 * src/maemo/modest-platform.c: (modest_platform_init):
2285 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2286 in case this has some effect on the ability for Maemo to ping the
2289 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2291 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2292 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2293 warning. It is probably a logic error, but I need to fix the build.
2295 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2297 * src/modest-account-mgr.h:
2298 * src/modest-account-mgr.c:
2299 (modest_account_mgr_account_names): Add a gboolean enabled_only
2300 parameter, so we can get lists of onlt the enabled accounts.
2302 (modest_account_mgr_add_account),,
2303 (modest_account_mgr_account_with_display_name_exists):
2304 * src/maemo/modest-msg-edit-window.c: (get_transports):
2305 * src/modest-account-mgr-helpers.c:
2306 (modest_account_mgr_set_first_account_as_default):
2307 * src/modest-init.c: (init_default_account_maybe):
2308 * src/modest-tny-account-store.c: (get_accounts):
2309 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2310 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2311 * tests/check_account-mgr.c: (START_TEST):
2312 Provide the extra parameter, as appropriate.
2314 * src/widgets/modest-account-view.c: (update_account_view):
2315 Do not show disabled accounts (meaning that there is no way to
2316 enable/disable accounts in the UI (the feature is not in our UI
2317 specification), so we can use this internally only to mark unfinished
2318 or temporary account data.
2320 * src/maemo/easysetup/modest-easysetup-wizard.c:
2321 (create_account): Add boolean enable parameter, so we can specify FALSE
2322 to create the temporary account.
2323 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2324 (on_before_next): When finishing, when there is a temporary account, just
2326 Also, use a timeout to delay the showing of the dialog until gconf is likely
2327 to return correct information, due to a maemo gconf bug that is fixed in
2328 osso 1.1, but not yet in Bora.
2329 However, the dialog stays on screen after it is destroyed.
2331 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2332 for invalid data when cancelling. Use a hildon note instead of a dialog
2333 to complain about invalid data. Do not show the account-saved note if the
2334 account is disabled (a temporary account that will not really be saved for use
2337 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2339 * src/modest-account-mgr-helpers.h:
2340 * src/modest-account-mgr-helpers.c:
2341 Added modest_account_mgr_unset_default_account(),
2342 Added modest_account_mgr_set_first_account_as_default().
2344 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2345 If it was the default account, unset the default account name.
2347 * src/maemo/modest-account-view-window.c:
2348 (on_delete_button_clicked): If it was the default account,
2349 set the first remaining account as the default instead.
2351 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2352 a NULL account or a NULL default account, to prevent a crash. This should
2353 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2356 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2358 * src/widgets/modest-recpt-editor.c:
2359 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2360 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2361 TODO comment for this. This fixes the build.
2363 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2364 be the best place for it. This will in future update all auto-update accounts,
2365 rather than just the current/default account, when that gconf key exists.
2366 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2367 if there are no accounts, before calling do_send_receive().
2368 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2370 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2371 * src/maemo/modest-main-window-ui.h:
2372 * src/maemo/modest-main-window.c: (on_connection_changed),
2373 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2374 directly, becaue the signal handler does more.
2376 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2378 * src/modest-account-mgr-helpers.c:
2379 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2380 for the case that the account does not exist.
2382 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2383 (equivalent to the modest account name) rather than the tinymail account name
2384 (equivalent to the modest account title - human readable) to get the account data.
2385 Check for null account data to prevent the crash, and add a TODO comment saying that
2386 this needs fixing because it is using the server account name instead of the account name.
2388 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2390 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2391 * src/maemo/modest-account-settings-dialog.c: (show_error),
2393 Use hildon_note_new_information() for informative and error messages,
2394 which seems to be expected for Maemo applications (no documentation that I know of
2395 says this). I am surprised that there is no distinction between info and error
2398 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2400 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2401 it is easy to find where this is used.
2403 * src/maemo/easysetup/modest-easysetup-wizard.c:
2404 (create_page_welcome), (create_page_account_details),
2405 (create_page_user_details), (create_page_complete_easysetup),
2406 (create_page_custom_incoming), (create_page_custom_outgoing),
2407 (create_page_complete_custom):
2408 * src/maemo/modest-account-settings-dialog.c:
2409 (create_page_account_details), (create_page_user_details),
2410 (create_page_incoming), (create_page_outgoing):
2411 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2412 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2413 (modest_connection_specific_smtp_edit_window_init):
2414 * src/maemo/modest-connection-specific-smtp-window.c:
2415 (modest_connection_specific_smtp_window_init):
2416 * src/maemo/modest-signature-editor-dialog.c:
2417 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2418 and scrolling policy as per the Email Application Layout Guide, if I have
2421 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2423 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2424 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2425 which were empty, because these vfuncs have been removed from TnyAccountStore.
2426 This fixes the build.
2428 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2430 * src/maemo/modest-main-window.c:
2431 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2432 showing/hiding it. Added TODO because it probably should not be NULL.
2433 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2434 because unnecessary g_warnings() make degugging difficult.
2436 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2438 * src/maemo/modest-msg-edit-window.c:
2439 (modest_msg_edit_window_select_color),
2440 (modest_msg_edit_window_select_background_color): 2 const corrections and
2441 moving 2 #endifs before closing brackets, to fix the build.
2443 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2445 * src/maemo/easysetup/modest-easysetup-wizard.h:
2446 * src/maemo/easysetup/modest-easysetup-wizard.c:
2447 (modest_easysetup_wizard_dialog_finalize),
2448 (on_button_edit_advanced_settings), (create_page_complete_custom),
2449 (on_response), (create_account):
2450 Implement the Advanced Settings edit button, by saving the account information,
2451 for the Advanded Settings dialog to use directly from gconf, and removing it
2452 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2453 Bug #5533 in the projects.maemo.org bugzilla.
2455 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2457 * src/maemo/modest-msg-view-window.c:
2458 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2459 when opening a message window.
2461 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2463 * src/maemo/easysetup/modest-easysetup-wizard.c:
2464 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2467 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2468 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2469 gconf settings. I probably added more checks than necessary, but that is safer.
2471 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2472 variable to fix the build, but this seems to be used when it is still NULL.
2474 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2476 * src/modest-platform.h:
2477 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2478 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2479 * src/modest-main.c: Implement this function so we can avoid using
2480 maemo-specific API from cross-platform code.
2482 * src/modest-tny-account-store.c:
2483 (get_smtp_specific_transport_account_for_open_connection):
2484 * src/modest-ui-actions.c: (check_for_connection),
2485 (modest_ui_actions_on_item_not_found):
2486 Use modest_platform_connect_and_wait() and put #idefs around other
2487 maemo-specific code, because only maemo currently has a way to
2488 identify connection names.
2490 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2492 * src/modest-tny-account-store.h:
2493 * src/modest-tny-account-store.c:
2494 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2495 the connection-specific SMTP server settings in the configuration.
2497 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2499 * src/maemo/modest-main-window.c: (on_connection_changed),
2501 * src/modest-main.c: (main), (start_ui), (send_mail):
2502 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2503 that is what is intended.
2505 * src/modest-ui-actions.c: (action_send), (action_receive),
2506 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2507 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2508 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2509 SMTP server is used when it is specified.
2511 (modest_ui_actions_on_send_receive):
2512 Check that a connection is open before proceeding.
2513 Receive and then send, instead of vice-versa, as per the specification.
2515 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2517 * src/modest-mail-operation.c:
2518 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2519 though I guess it should be something other than NULL.
2521 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2523 * src/maemo/easysetup/modest-easysetup-wizard.c:
2524 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2525 combo twice, to avoid an g_warning and to make it visible again.
2526 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2527 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2528 (already intended) dereference when detaching, because we then recreate the menu.
2529 But I am not sure why the warning was happening, and it is possible that this is a memory
2532 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2534 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2535 and uri_parse_mailto() utility functions.
2536 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2538 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2540 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2542 * src/dbus_api/modest-dbus-api.h:
2543 * src/dbus_api/modest-dbus-callbacks.c:
2544 Use an idle callback to execute the modest code in the application's own thread.
2545 Remove the helloworld example method.
2546 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2547 parsed, and the open-message method is not implemented because this is not yet implemented in
2549 * libmodest-dbus-client/libmodest-dbus-client.c:
2550 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2551 (libmodest_dbus_client_open_message):
2552 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2554 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2555 body without crashing.
2557 * tests/dbus_api/Makefile.am:
2558 * tests/dbus_api/test_mail_to.c:
2559 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2561 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2563 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2564 Added file to fix the build. Sorry.
2566 * src/dbus_api/Makefile.am:
2567 * src/dbus_api/modest-dbus-api.h:
2568 * src/dbus_api/modest-dbus-callbacks.h:
2569 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2570 (modest_dbus_req_handler):
2571 Put constants in a separate header so it can be reused by the
2572 client library, without duplication
2574 * libmodest-dbus-client/Makefile.am:
2575 * libmodest-dbus-client/libmodest-dbus-client.c:
2576 (libmodest_dbus_client_call_helloworld),
2577 (libmodfest_dbus_client_send_mail),
2578 (libmodfest_dbus_client_mailto),
2579 (libmodfest_dbus_client_open_message):
2580 * libmodest-dbus-client/libmodest-dbus-client.h:
2581 (Partly) Implement a send_mail D-Bus method.
2583 * tests/dbus_api/Makefile.am:
2584 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2585 the send_email D-Bus method.
2587 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2591 * libmodest-dbus-client/Makefile.am:
2592 * libmodest-dbus-client/libmodest-dbus-client.c:
2593 * libmodest-dbus-client/libmodest-dbus-client.h:
2594 * tests/dbus_api/Makefile.am:
2595 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2596 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2598 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2600 * src/maemo/easysetup/modest-easysetup-wizard.c:
2601 (create_page_account_details):
2602 * src/maemo/modest-account-settings-dialog.c:
2603 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2604 widgets, because this might not be the default in future versions of the Maemo GTK+.
2605 However, I can not not get capitalization to work even in a simple test case.
2607 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2609 * src/maemo/easysetup/modest-easysetup-wizard.c:
2610 (create_page_custom_incoming), (create_page_custom_outgoing):
2611 * src/maemo/modest-account-settings-dialog.c:
2612 (create_page_account_details), (create_page_incoming),
2613 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2614 instead of using gtk_check_button_with_label(), so they are aligned like the other
2615 widgets, as per the UI spec.
2617 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2619 * src/maemo/easysetup/modest-easysetup-wizard.c:
2620 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2621 * src/widgets/modest-validating-entry.c:
2622 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2623 Modest prefix instead of an EasySetup prefix.
2625 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2627 * src/widgets/modest-validating-entry.h:
2628 * src/widgets/modest-validating-entry.c: (on_insert_text),
2629 Added easysetup_validating_entry_set_max_func(), used to set a callback
2630 to call when the max number of characters is reached. GtkEntry has a max-length
2631 already but is silent about it.
2633 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2634 (create_page_account_details), (create_page_user_details),
2636 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2637 (create_page_account_details), (create_page_user_details),
2638 (create_page_outgoing):
2639 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2640 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2641 the UI spec, when the user tries to enter more than the max number of characters.
2643 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2645 * src/maemo/easysetup/modest-easysetup-wizard.c:
2646 (create_page_user_details), (create_page_custom_incoming),
2647 (create_page_custom_outgoing):
2648 * src/maemo/modest-account-settings-dialog.c:
2649 (create_page_user_details), (create_page_incoming),
2650 (create_page_outgoing):
2651 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2652 (modest_connection_specific_smtp_edit_window_init):
2653 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2654 not appropriate. Bad Maemo-specific defaults!.
2656 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2658 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2659 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2660 (modest_signature_editor_dialog_set_settings):
2661 Disable the label and textview when the checkbox is disabled, and use the
2662 specified (UI spec) default signature text.
2664 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2666 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2667 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2669 * src/modest-defs.h:
2670 * src/modest-account-mgr-helpers.h:
2671 * src/modest-account-mgr-helpers.c:
2672 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2674 * src/maemo/Makefile.am:
2675 * src/maemo/modest-signature-editor-dialog.c:
2676 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2679 * src/maemo/modest-account-settings-dialog.h:
2680 * src/maemo/modest-account-settings-dialog.c:
2681 (modest_account_settings_dialog_finalize), (on_button_signature),
2682 (save_configuration): Use the new dialog when the Edit button is pressed, and
2683 save the changes if necessary, as per the UI spec.
2685 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2687 * src/maemo/Makefile.am:
2688 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2689 based on maemo-develoers email from Dirk.
2691 * src/maemo/easysetup/modest-easysetup-wizard.c:
2692 (create_page_welcome), (create_page_account_details),
2693 (create_page_user_details), (create_page_complete_easysetup),
2694 (create_page_custom_incoming), (create_page_custom_outgoing),
2695 (create_page_complete_custom),
2696 (modest_easysetup_wizard_dialog_init):
2697 * src/maemo/modest-account-settings-dialog.c:
2698 (create_page_account_details), (create_page_user_details),
2699 (create_page_incoming), (create_page_outgoing),
2700 (modest_account_settings_dialog_init):
2701 * src/maemo/modest-connection-specific-smtp-window.c:
2702 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2704 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2706 * src/maemo/easysetup/modest-easysetup-wizard.c:
2707 (create_page_account_details), (create_page_custom_outgoing),
2708 (create_page_complete_custom):
2709 * src/maemo/modest-account-settings-dialog.c:
2710 (create_page_user_details), (create_page_incoming),
2711 (create_page_outgoing):
2712 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2713 (modest_connection_specific_smtp_edit_window_init):
2714 Use the correct (UI spec) port min/max, and use horizontal separators,
2717 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2719 * src/maemo/easysetup/modest-easysetup-wizard.c:
2720 (set_default_custom_servernames):
2721 * src/maemo/modest-account-settings-dialog.c:
2722 (create_page_incoming), (on_combo_outgoing_security_changed),
2723 (on_combo_incoming_security_changed), (create_page_outgoing),
2724 (modest_account_settings_dialog_set_account_name),
2725 (save_configuration):
2726 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2727 (on_combo_security_changed),
2728 (modest_connection_specific_smtp_edit_window_init),
2729 (modest_connection_specific_smtp_edit_window_set_connection),
2730 (modest_connection_specific_smtp_edit_window_get_settings):
2731 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2734 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2737 * src/maemo/easysetup/modest-easysetup-wizard.c:
2738 (create_page_custom_outgoing), (create_page_complete_custom):
2739 * src/maemo/modest-account-settings-dialog.c:
2740 (create_page_user_details), (create_page_outgoing):
2741 * src/maemo/modest-account-view-window.c: (button_box_new):
2742 Use changed logical IDs as per the most recent UI spec:
2743 mcen_bd_emailsetup_edit -> mcen_bd_edit
2744 mcen_bd_emailsetup_delete -> mcen_bd_delete
2745 mcen_bd_emailsetup_close -> mcen_bd_close
2747 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2751 * src/dbus_api/Makefile.am:
2752 * src/dbus_api/modest-dbus-callbacks.c:
2753 * src/dbus_api/modest-dbus-callbacks.h:
2754 * src/maemo/modest-platform.c: (modest_platform_init):
2755 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2757 * tests/Makefile.am:
2758 * tests/dbus_api/Makefile.am:
2759 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2761 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2763 * src/maemo/modest-account-settings-dialog.c:
2764 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2765 Removed unnecessary includes.
2767 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2769 * src/maemo/easysetup/modest-easysetup-wizard.c:
2770 * src/maemo/modest-account-settings-dialog.c:
2771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2772 * src/widgets/Makefile.am:
2773 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2774 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2775 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2776 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2777 * src/widgets/modest-secureauth-combo-box.c:
2778 * src/widgets/modest-secureauth-combo-box.h:
2779 * src/widgets/modest-serversecurity-combo-box.c:
2780 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2781 made the GObject names more consistent with the rest of the Modest code.
2783 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2785 * src/maemo/easysetup/Makefile.am:
2786 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2787 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2788 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2789 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2790 * src/maemo/easysetup/modest-easysetup-wizard.c:
2791 * src/maemo/easysetup/modest-validating-entry.c:
2792 * src/maemo/easysetup/modest-validating-entry.h:
2793 * src/maemo/modest-account-settings-dialog.c:
2794 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2795 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2796 widgets/ because they are used outside of easysetup too. After checking in,
2797 svn will allow me to rename them too.
2799 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2801 * src/gnome/modest-msg-edit-window.c:
2802 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2803 linker error, to fix the build on the GNOME platform.
2804 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2805 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2806 ifdefed out to avoid a warning.
2808 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2810 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2811 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2812 some alternative for GTK+ 2.6.
2814 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2816 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2818 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2819 specified for EmailAccountsDialog in UI spec.
2821 * src/maemo/easysetup/modest-easysetup-wizard.c:
2822 * src/maemo/easysetup/modest-easysetup-wizard.h:
2823 * src/maemo/modest-account-settings-dialog.c:
2824 * src/maemo/modest-account-settings-dialog.h:
2825 Reuse a member window widget for the connection-specific SMTP server accounts,
2826 so we can tell it to create/save the accounts only if we actually save changes.
2828 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2829 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2830 (modest_connection_specific_smtp_edit_window_get_settings):
2831 Return a struct instance for temporarily remembering the entered data.
2833 * src/maemo/modest-connection-specific-smtp-window.h:
2834 * src/maemo/modest-connection-specific-smtp-window.c:
2835 (modest_connection_specific_smtp_window_finalize),
2836 (modest_connection_specific_smtp_window_fill_with_connections),
2838 (modest_connection_specific_smtp_window_save_server_accounts),
2839 (update_model_server_names): Do not actually save data until asked,
2840 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2842 (on_selection_changed),
2843 (modest_connection_specific_smtp_window_init): Disable the edit
2844 button when nothing is selected.
2846 * src/modest-account-mgr-helpers.c:
2847 * src/modest-account-mgr-helpers.h:
2848 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2851 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2853 * src/modest-account-mgr-helpers.h:
2854 * src/modest-account-mgr-helpers.c:
2855 (modest_account_mgr_get_unused_account_name),
2856 (modest_account_mgr_get_unused_account_display_name): Added these
2857 utility functions, to avoid code duplication.
2859 * src/maemo/easysetup/modest-easysetup-wizard.c:
2860 (create_page_account_details), (create_account):
2861 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2862 (on_combo_security_changed),
2863 (modest_connection_specific_smtp_edit_window_init),
2864 (modest_connection_specific_smtp_edit_window_save_settings):
2865 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2866 * src/maemo/modest-connection-specific-smtp-window.c:
2867 (modest_connection_specific_smtp_window_finalize),
2868 (modest_connection_specific_smtp_window_fill_with_connections),
2869 (on_button_edit), (modest_connection_specific_smtp_window_init):
2870 * src/maemo/modest-connection-specific-smtp-window.h:
2871 Implementing saving of connection-specific server accounts.
2873 But I need to refactor this so we can save the data for each
2874 possible connection-specific account and only actually create the server accounts
2875 when the easysetup finished, or the OK button is pressed on the account settings
2878 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2880 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2881 (on_combo_security_changed):
2882 (modest_connection_specific_smtp_edit_window_init):
2883 Auto-fill the port number as in the account settings.
2885 (modest_connection_specific_smtp_edit_window_set_connection):
2886 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2887 * src/maemo/modest-connection-specific-smtp-window.c:
2888 (fill_with_connections), (on_button_edit),
2889 (modest_connection_specific_smtp_window_init):
2890 Turn the edit window into a dialog to simplify the code, and
2891 set a WM hint as in a GtkDialog, because only a popup can be on top of
2892 another window in Maemo, and popups usually have no WM decoration.
2894 * src/modest-defs.h:
2895 * src/modest-account-mgr-helpers.c:
2896 (modest_account_mgr_set_connection_specific_smtp),
2897 (modest_account_mgr_remove_connection_specific_smtp),
2898 (modest_account_mgr_get_connection_specific_smtp):
2899 * src/modest-account-mgr-helpers.h: Some functions to write the
2900 connection-specific SMTP server information. Not yet used.
2903 * src/widgets/modest-folder-view.c: (text_cell_data):
2904 Fix a warning about an uninitialized variable.
2905 (on_configuration_key_changed): Put an #ifdef around the use
2906 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2908 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2910 * src/maemo/modest-account-settings-dialog.h:
2911 * src/maemo/modest-account-settings-dialog.c:
2912 Added connect_for_modified() utility function to mark the new modified boolean.
2914 (create_page_account_details), (create_page_user_details),
2915 (create_page_incoming), (create_page_outgoing), (on_response),
2916 (modest_account_settings_dialog_init),
2917 (modest_account_settings_dialog_set_account_name):
2918 Only warn about unsaved changes when there are actually unsaved changes.
2920 * src/modest-account-mgr-helpers.c:
2921 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2922 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2923 to get the data from there in future.
2925 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2927 * src/modest-defs.h:
2929 * src/modest-account-mgr-helpers.h:
2930 * src/modest-account-mgr-helpers.c:
2931 Store the security account setting in a single conf key instead of using
2932 the options list, so that the list is left for just the to-be-removed camel hack,
2933 and because gconf_client_set_list() is failing for some reason.
2935 * src/modest-account-mgr.c:
2936 (modest_account_mgr_add_server_account):
2937 * src/maemo/modest-account-settings-dialog.c:
2938 (modest_account_settings_dialog_set_account_name),
2939 (save_configuration): Use the renamed functions.
2942 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2944 * src/widgets/Makefile.am:
2945 * src/widgets/modest-limit-retrieve-combo-box.c:
2946 * src/widgets/modest-limit-retrieve-combo-box.h:
2947 * src/widgets/modest-retrieve-combo-box.c:
2948 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2949 the account settings dialog.
2951 * src/modest-defs.h:
2952 * src/modest-account-mgr-helpers.h:
2953 * src/modest-account-mgr-helpers.c:
2954 (modest_server_account_get_option_secure_auth),
2955 (modest_server_account_set_option_secure_auth):
2956 * src/modest-account-mgr.c:
2957 (modest_account_mgr_add_server_account):
2958 Use the existing AUTH_MECH conf key for the secure-auth setting,
2959 instead of putting it in the list options, because this was actually used already.
2961 * src/maemo/modest-account-settings-dialog.c:
2962 (create_page_account_details),
2963 (modest_account_settings_dialog_set_account_name),
2964 (save_configuration):
2965 * src/maemo/modest-account-settings-dialog.h:
2966 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2967 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2969 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2971 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2972 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2973 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2975 * src/modest-defs.h:
2976 * src/maemo/modest-account-settings-dialog.c:
2977 (create_page_incoming), (on_combo_outgoing_security_changed),
2978 (on_combo_incoming_security_changed), (create_page_outgoing),
2979 (modest_account_settings_dialog_set_account_name),
2980 (save_configuration): Load/Save the port number, and change it when the
2981 security combo changes, to suitable defaults.
2983 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2985 * src/modest-account-mgr.c:
2986 (modest_account_mgr_add_server_account): Set the security and secure-auth
2987 options, and add a comment saying that the other camel-specific options should be
2990 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2992 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2994 * src/modest-tny-account-store.c: (account_list_free),
2995 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2996 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2999 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3001 * src/modest-protocol-info.c:
3002 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3003 is required by our UI spec. Maybe something in our implementation will use this eventually.
3004 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3005 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3006 instead of the previous 0 placeholder.
3008 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3009 secure-auth settings.
3010 * src/modest-account-mgr-helpers.h:
3011 * src/modest-account-mgr-helpers.c:
3012 (modest_server_account_data_get_option_secure_auth),
3013 (modest_server_account_set_option_secure_auth),
3014 (modest_server_account_data_get_option_security),
3015 (modest_server_account_set_option_security): Added this API for getting and setting the security
3016 and secure-auth settings.
3018 * src/maemo/modest-account-settings-dialog.h:
3019 * src/maemo/modest-account-settings-dialog.c:
3020 (modest_account_settings_dialog_finalize), (check_data),
3021 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3022 about changing titles.
3023 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3024 (save_configuration): Save the security and secure-auth settings.
3026 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3027 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3029 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3031 * src/modest-defs.h:
3032 * src/modest-account-mgr.c:
3033 (modest_account_mgr_add_server_account):
3034 Added and used defines for the options key and value pair strings,
3035 that are used so far, though they do not seem to correspond to anything in our
3036 UI specs or ModestProtocol enum.
3038 * src/modest-account-mgr-helpers.h:
3039 * src/modest-account-mgr-helpers.c:
3040 (compare_option_strings_for_name),
3041 (modest_server_account_data_get_option_value),
3042 (modest_server_account_data_get_option_bool),
3043 (modest_account_mgr_get_server_account_option):
3044 Added helper functions for parsing the options GSList.
3046 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3048 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3049 display name is based on the supplied account name.
3050 * src/modest-account-mgr.c:
3051 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3052 with an inefficient, but good-enough, implementation.
3054 * src/maemo/easysetup/modest-easysetup-wizard.c:
3055 (create_page_account_details), (on_before_next), (create_account):
3056 Check for existing display names rather than (non-user-visible) account names, and just
3057 create and set a unique account name at the end.
3059 * src/maemo/modest-account-settings-dialog.c:
3060 (modest_account_settings_dialog_init),
3061 (modest_account_settings_dialog_set_account_name),
3062 (create_page_incoming): Show the display name, instead of the account name.
3063 (on_response): Do some (not all) extra checks, as in the UI spec.
3064 (save_configuration): Save the display name if it was changed.
3066 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3068 * po/en_GB.po: Added needed logical ID and translation.
3069 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3070 (init_view): Made the is-default column clicking work.
3072 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3075 * src/maemo/easysetup/Makefile.am:
3076 * src/maemo/easysetup/modest-easysetup-wizard.c:
3077 (modest_easysetup_wizard_dialog_init):
3078 * src/maemo/easysetup/provider-data-test.keyfile:
3079 * src/maemo/easysetup/provider-data.keyfile:
3080 Moved the provider data file to the new modest-providers-data package and used it from there.
3082 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3084 * src/modest-local-folder-info.c:
3085 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3086 N_() was already used on the static strings, but this just marks it for translation without
3087 using the translation.
3089 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3091 * src/maemo/modest-account-settings-dialog.c:
3092 (create_page_incoming),
3093 (modest_account_settings_dialog_set_account_name):
3094 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3095 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3096 I will do this if nobody else gets there first.
3098 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3100 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3101 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3102 save the security stuff.
3104 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3106 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3107 Set the email address and user fullname, which I now see must be
3110 * src/maemo/modest-account-settings-dialog.h:
3111 * src/maemo/modest-account-settings-dialog.c:
3113 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3114 leave-on-server and authentication.
3115 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3118 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3121 * src/maemo/modest-account-settings-dialog.c:
3122 * src/maemo/modest-account-settings-dialog.h:
3123 Most (but not all) of the widgets are now present as specified by the UI spec.
3124 No changes are yet saved, and some details are not properly shown yet.
3126 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3128 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3130 * src/maemo/Makefile.am:
3131 * src/maemo/modest-account-settings-dialog.c:
3132 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3133 an existing account. Doesn't do much yet.
3135 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3136 Open the accounts settings dialog when Edit is clicked.
3138 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3140 * src/maemo/easysetup/Makefile.am:
3141 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3143 * src/maemo/easysetup/modest-easysetup-wizard.c:
3144 (modest_easysetup_wizard_dialog_init):
3145 Try to get the source directory from the build system,
3146 instead of hard-coding "./" into the source code, when opening our local
3147 copies of the configuration files.
3148 But this still fails when opening the wizard from the Accounts window,
3149 maybe because the working directory seems to change at runtime.
3150 So the wizard will fail the second time unless you copy the files into their
3151 proper locations - see the stdout warnings for the paths.
3153 (create_page_account_details),(on_before_next):
3154 Check for existing non-server accounts instead of server accounts,
3155 so the default account name is useful again, and to prevent trying to
3158 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3159 Show the wizard when New is clicked.
3161 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3162 (init_view): Show the column headers, and show the columns that are
3163 specified in the UI specs. However, something in Maemo's GTK+ prevents
3164 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3165 change the default account. This is despite unsetting the special properties.
3167 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3169 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3170 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3171 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3172 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3173 to make that clearer.
3174 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3176 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3178 * src/maemo/modest-account-view-window.c:
3179 (modest_account_view_window_init),
3180 (modest_account_view_window_new):
3181 Use the same buttons as specified in the
3182 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3183 the existing widgets, which never had a chance of working.
3184 Put the ModestAccountView treeview in a scrolled window.
3185 Do not repeat the initialization in both _init() and _new().
3187 * src/widgets/modest-account-view.c: (update_account_view):
3188 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3189 this widget and window shows no accounts.
3191 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3193 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/easysetup/modest-easysetup-wizard.c:
3196 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3197 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3198 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3201 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3202 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3203 accounts exist yet, as in the UI spec.
3205 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3207 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3209 * src/maemo/Makefile.am:
3210 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3211 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3212 New window for editing connection-specific smtp details.
3213 Not fully implemented.
3215 * src/maemo/modest-connection-specific-smtp-window.c:
3216 (modest_connection_specific_smtp_window_finalize) :
3217 unref the tree model.
3218 (on_button_edit): Show the edit window.
3220 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3222 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3225 * src/maemo/Makefile.am:
3226 * src/maemo/modest-connection-specific-smtp-window.c:
3227 * src/maemo/modest-connection-specific-smtp-window.h:
3228 New window for showing the list of connections, for connection-specific
3229 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3230 * src/maemo/easysetup/modest-easysetup-wizard.c:
3231 (create_page_custom_outgoing): Show the new window when the button is clicked.
3233 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3235 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3236 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3237 * src/maemo/modest-msg-edit-window.c:
3238 (modest_msg_edit_window_insert_image):
3239 * src/modest-conf.c: (modest_conf_key_escape):
3240 * src/modest-mail-operation.c:
3241 (modest_mail_operation_send_new_mail):
3242 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3243 (modest_ui_actions_on_new_account):
3244 * src/widgets/modest-attachment-view.c: (update_filename_request):
3245 * src/widgets/modest-mail-header-view.c:
3246 Corrected warnings that were breaking the build, by commenting out unused variables,
3247 and a function, and by including a header.
3249 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3251 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3252 so we can #ifdef around platform-specific code when necessary.
3253 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3254 to allow this to build for the GNOME platform too.
3256 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3258 * src/maemo/easysetup/modest-easysetup-wizard.c:
3259 Added util_increment_name() and used it in create_page_account_details()
3260 to make sure that the default account name is always a new name.
3262 (modest_easysetup_wizard_dialog_init),
3263 (set_default_custom_servernames): Some minor memory management fixes.
3265 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3269 * src/modest-runtime.c: (init_i18n): Restored the translation
3270 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3271 are defined in config.h, and the translations are installed.
3273 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3274 is defined for translation.
3276 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3278 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3280 * src/maemo/easysetup/modest-easysetup-wizard.c:
3281 (modest_easysetup_wizard_dialog_init):
3282 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3283 Use realistic paths (though they should use $prefix generically) to the
3284 mcc_mapping and provider-data.keyfile files which might work when they
3285 are installed by the future version of the operator-wizard package,
3286 and then fallback to paths in our source code, with an explanatory
3289 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/Makefile.am:
3294 * src/maemo/easysetup/: Added files from the previously-exernal
3295 osso-modest-easysetup.
3296 * src/maemo/modest-main-window-ui.h:
3297 * src/modest-ui-actions.c:
3298 * src/modest-ui-actions.h:
3299 Added modest_ui_actions_on_new_account() as a signal handler for the
3300 New Account menu item. It shows the easysetup wizard.
3301 * po/en_GB.po: Added additional needed logical IDs and translations.