1 2007-07-25 Murray Cumming <murrayc@murrayc.com>
3 (modest_platform_set_update_interval): Set the alarm recurrence
4 fields so that auto-update does not just happen the first time.
5 This should have fixed projects.maemo.org bug NB#63938.
7 When this happens you can see a printf when the D-Bus method is
9 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
11 However, I do not actually seem to get new POP messages even when
12 clicking the refresh button manually. A restart gets them.
13 This might be a problem in today's tinymail only.
15 2007-07-24 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/modest-maemo-global-settings-dialog.c:
19 Avoid a crash (probably only in scratchbox) when strcmp()ing a
20 NULL when closing the dialog.
22 2007-07-24 Murray Cumming <murrayc@murrayc.com>
24 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
25 Remove the hacky send/receive that didn't work, and instead
26 refilter the treemodel to make the deleted email really vanish from
27 the UI (though the delete-from-menu code does has commented out
28 the code that does that). This fixes projects.maemo.org bug
31 2007-07-24 Murray Cumming <murrayc@murrayc.com>
33 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
34 Try a couple of tricks to force the treeview to update (
35 poke the folder, and do a send/receive refresh), but the deleted
36 email still appears with a strike-through instead of really being
39 2007-07-23 Murray Cumming <murrayc@murrayc.com>
41 * src/dbus_api/modest-dbus-callbacks.c:
42 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
43 because their ID is not human-readable (see the comment about
44 improvements needed to the osso-email-interface API) and
45 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
47 2007-07-23 Murray Cumming <murrayc@murrayc.com>
49 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
50 (add_folders_to_list), (on_dbus_method_get_folders),
51 (modest_dbus_req_filter):
52 * src/maemo/modest-maemo-utils.c:
53 (on_camel_account_get_supported_secure_authentication):
54 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
55 (on_header_view_focus_in):
56 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
57 * src/modest-formatter.c: (modest_formatter_create_body_part):
58 * src/modest-mail-operation.c: (recurse_folders),
59 (update_account_thread), (get_msgs_full_thread),
60 (modest_mail_operation_get_msgs_full),
61 (modest_mail_operation_xfer_msgs):
62 * src/modest-search.c: (search_mime_part_and_child_parts),
63 (modest_search_account), (modest_search_all_accounts):
64 * src/modest-tny-account.c:
65 (modest_tny_account_get_special_folder), (recurse_folders):
66 * src/modest-tny-local-folders-account.c:
67 (modest_tny_local_folders_account_query_passes):
68 * src/modest-tny-msg.c: (copy_mime_part),
69 (modest_tny_msg_find_body_part_from_mime_part):
70 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
71 (modest_tny_send_queue_try_to_send):
72 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
73 (_modest_ui_actions_open), (download_uncached_messages),
74 (reply_forward), (modest_ui_actions_on_copy),
75 (modest_ui_actions_on_details), (has_retrieved_msgs),
76 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
78 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
79 (_selected_msg_marked_as), (_msg_download_completed),
80 (_selected_msg_sent_in_progress):
81 * src/widgets/modest-attachments-view.c:
82 (modest_attachments_view_set_message):
83 * src/widgets/modest-msg-view.c: (find_cid_image):
84 * tests/check_folder-transfer.c: (find_folders):
85 * tests/check_update-account.c: (func):
86 * tests/dbus_api/test_get_folders.c: (main):
87 Checked all uses of tny_iterator_get_current(), making sure
88 that the object is unreferenced (3 or 4 places did not),
89 and adding checks for NULL.
91 2007-07-23 Murray Cumming <murrayc@murrayc.com>
93 * src/dbus_api/modest-dbus-callbacks.c:
94 (on_idle_open_default_inbox): Make sure that the application UI is
96 * src/maemo/easysetup/modest-easysetup-wizard.c:
97 (on_entry_invalid_character): Show the word whitespace instead
98 of (null) in the banner when whitespace was entered.
99 (show_error): Add a comment that this does not work in
100 Maemo Bora, though we do not know why.
102 2007-07-23 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-tny-account.c:
105 (modest_tny_account_get_special_folder): Use an if instead of
106 an assert for when the parent account name is NULL, because this
107 might be causing a crash in projects.maemo.org bug 63192.
108 * src/modest-mail-operation.c:
109 (modest_mail_operation_send_new_mail_cb),
110 (modest_mail_operation_remove_folder): unref the folder that is
111 returned from modest_tny_account_get_special_folder().
113 2007-07-23 Murray Cumming <murrayc@murrayc.com>
115 * src/modest-ui-actions.c:
116 (modest_ui_actions_on_password_requested):
117 Show mail_ib_login_cancelled info banner when the user cancels
118 the protected password dialog, to fix projects.maemo.org
121 2007-07-23 Murray Cumming <murrayc@murrayc.com>
123 * src/maemo/modest-account-settings-dialog.c:
124 (create_page_outgoing): Put this page in a GtkScrolledWindow,
125 matching the UI mock-up in the UI spec, and allowing access
126 to all widgets even when the on-screen keyboard is active.
128 2007-07-23 Murray Cumming <murrayc@murrayc.com>
130 Reverted this previous commit from Johannes,
131 because the scrollbars are always visible and because
132 I think we only need it on onepage of the account
133 settings, not the account wizard.
134 (I wrote the wrong instructions in the bug.)
136 * src/maemo/easysetup/modest-easysetup-wizard.c:
137 Added scrollbars to account wizard dialog.
138 Fixed projects.maemo.org NB #62744
140 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
142 * src/maemo/easysetup/modest-easysetup-wizard.c:
143 (create_page_user_details):
144 Use auto-cap for name (projects.maemo.org NB#63716)
145 * src/widgets/modest-account-view.c: (on_account_busy_changed):
147 2007-07-22 Armin Burgmeier <armin@openismus.com>
149 * src/maemo/modest-ui-actions.c: Use current account instead of
150 default account for creating viewer windows, so that the viewer
151 window knows to which account the viewed message belongs.
153 * src/maemo/modest-msg-view-window.c: Destroy the window when the
154 corresponding account is deleted. This fixes projects.maemo.org bug
157 2007-07-18 Armin Burgmeier <armin@openismus.com>
159 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
160 the dialog close after entering an invalid port number and clicking
161 OK. This fixes projects.maemo.org bug NB#63602.
163 2007-07-18 Armin Burgmeier <armin@openismus.com>
165 * src/modest-tny-account-store.c:
166 (get_server_accounts): Set parent modest account name for each
167 connection-specific transport account so that special folders of such
168 an account can be looked up. This fixes a crash when changing account
169 settings. This might also be related to projects.maemo.org bug
172 2007-07-16 Armin Burgmeier <armin@openismus.com>
174 * src/modest-ui-actions.c: Added a button to create a folder to the
175 move-to dialog. This fixes projects.maemo.org bug NB#.
177 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
179 * src/maemo/easysetup/modest-easysetup-wizard.c:
180 Added scrollbars to account wizard dialog.
181 Fixed projects.maemo.org NB #62744
183 2007-07-16 Murray Cumming <murrayc@murrayc.com>
185 * src/widgets/modest-msg-view.h:
186 * src/widgets/modest-msg-view.c:
187 Added modest_msg_view_get_message_is_empty() but this needs
189 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
190 Check if there is any text in the message yet.
191 But this needs to be implemented properly.
192 (modest_msg_edit_window_toggle_find_toolbar):
193 * src/maemo/modest-msg-view-window.c:
194 (modest_msg_view_window_toggle_find_toolbar):
195 Show a banner warning if there is no text to search, when
196 trying to start a search. This partially fixes
197 projects.maemo.org bug NB#62350.
199 2007-07-13 Murray Cumming <murrayc@murrayc.com>
201 * src/modest-mail-operation.c: (update_account_thread):
202 Initialized num_new_headers to fix the build.
204 2007-07-13 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
207 Ignore modest accounts whose server accounts don't exist in gconf.
208 This prevents us trying to create TnyAccount instances for those
209 server accounts when the server account has been removed from gconf,
210 but the parent modest account has not yet been removed from modest.
211 I don't know why this is only noticeable now. It was probably just
212 a harmeless g_warning() anyway.
214 2007-07-13 Murray Cumming <murrayc@murrayc.com>
216 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
217 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
219 2007-07-12 Armin Burgmeier <armin@openismus.com>
221 * src/maemo/modest-main-window.c: Make default account appear bold
222 in view, tools/send & receive and toolbar/send & receive SCM menus.
223 This fixes projects.maemo.org bug NB#59010.
225 2007-07-12 Murray Cumming <murrayc@murrayc.com>
227 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
228 Add a short-cut, by checking if the folder store is an account.
229 This ensures that the Sort menu item and toolbar is dimmed for
230 the local-folders account root item, fixing
231 projects.maemo.org bug NB#62545.
233 2007-07-12 Murray Cumming <murrayc@murrayc.com>
235 * src/modest-tny-account-store.c: (get_password):
236 Show the password dialog (via the signal) only in the mainloop, via
237 an idle handler that we wait for. This could theoretically prevent
238 hangs, though I worry that it could introduce some too.
240 2007-07-12 Murray Cumming <murrayc@murrayc.com>
242 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
243 * src/maemo/modest-platform.c:
244 (modest_platform_connect_and_wait):
245 Take a TnyAccount* parameter and try to set it to online
246 (a TnyCamel-only API), because tinymail sets accounts to offline
247 when the user cancels a password dialog, and doesn't ask again until
248 it has been set to online.
249 However, this is commented out because it causes a hang now.
251 (modest_platform_connect_and_wait_if_network_account):
252 * src/modest-mail-operation.c:
253 (modest_mail_operation_update_account):
254 * src/modest-platform.h:
255 * src/modest-ui-actions.c: (_modest_ui_actions_open),
256 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
258 2007-07-12 Armin Burgmeier <armin@openismus.com>
260 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
262 * src/modest-mail-operation.c:
263 * src/modest-ui-actions.c: Check for already existing folder before
264 querying the server, show error message from camel if the request
265 still fails. This fixes projects.maemo.org bug NB#58701.
267 2007-07-12 Murray Cumming <murrayc@murrayc.com>
269 * src/modest-tny-account-store.h:
270 * src/modest-tny-account-store.c:
271 Added modest_tny_account_store_forget_password_in_memory(),
272 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
273 when creating a new account, so that new passwords will be used, instead of
274 us thinking that it's a second request as a result of a failed password again.
276 2007-07-12 Murray Cumming <murrayc@murrayc.com>
278 * src/dbus_api/modest-dbus-callbacks.c:
279 (on_idle_open_message): If the message is in drafts then open it
280 in an edit window instead of a view window. This fixes
281 projects.maemo.org bug NB#63005.
283 2007-07-12 Murray Cumming <murrayc@murrayc.com>
285 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
286 Avoided a harmless g_warning().
288 2007-07-12 Murray Cumming <murrayc@murrayc.com>
290 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
291 Pass the modest account name, not the TnyAccount display name to
292 modest_msg_view_window_new() so that the reply feature works,
293 fixing projects.maemo.org bug NB#62892.
295 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
296 (modest_msg_view_window_new_with_header_model):
297 * src/maemo/modest-msg-view-window.c:
298 (modest_msg_view_window_new_with_header_model),
299 (modest_msg_view_window_new):
300 * src/modest-ui-actions.c: (reply_forward):
301 * src/widgets/modest-msg-view-window.h:
302 * src/widgets/modest-window.c: (modest_window_set_active_account):
303 Rename an account parameter to modest_account_name to make this clearer.
305 2007-07-11 Murray Cumming <murrayc@murrayc.com>
307 * src/modest-ui-actions.h:
308 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
309 modest_do_message_delete().
310 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
311 Call modest_do_message_delete(), hoping that this would cause messages
312 to be really deleted from search instead of just marked with strike through.
313 Does not seem to help.
315 2007-07-11 Armin Burgmeier <armin@openismus.com>
317 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
318 priv->reselect to FALSE prior to calling
319 modest_folder_view_select_first_inbox_or_local() to prevent endless
320 recursion and thus a crash on startup.
322 2007-07-11 Armin Burgmeier <armin@openismus.com>
324 * src/maemo/modest-account-settings-dialog.h: Include
325 <gtk/gtknotebook.h> to fix the build (at least for me).
327 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
328 Use "New FolderN" as default suggested name if "New folder" already
329 exists, with N being the first free number, though never exceed "New
330 folder99" in which case we just fall back to "New Folder" even though
331 it already exists. This fixes projects.maemo.org bug NB#58663.
333 2007-07-11 Murray Cumming <murrayc@murrayc.com>
335 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
336 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
337 projects.maemo.org bug NB#62778.
339 2007-07-11 Murray Cumming <murrayc@murrayc.com>
341 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
342 Ignore the wrong (for now) secure-smtp setting in the presets -
343 just default to requiring secure authentication for SMTP, because
346 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
348 * src/widgets/modest-folder-view.c: (filter_row)
349 Do not show drafts folder (see UI specs)
351 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
353 * src/modest-ui-actions.c:
354 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
355 place and also not necessary.
357 * src/widgets/modest-folder-view.c: (filter_row)
358 Guess folder type and hide Sent & Outbox if necessary.
359 Fixed project.maemo.org NB#57328
361 2007-07-11 Murray Cumming <murrayc@murrayc.com>
363 * src/modest-ui-actions.h:
364 * src/modest-ui-actions.c:
365 (modest_ui_actions_on_delete_message):
366 Move some code into a new
367 modest_ui_actions_refresh_message_window_after_delete()
368 function so we can use it from elsewhere.
370 * src/dbus_api/modest-dbus-callbacks.c:
371 (on_idle_delete_message), (on_delete_message): Used an idle
372 handler, as we do for the other D-Bus method handlers.
373 Call modest_ui_actions_refresh_message_window_after_delete()
374 if the deleted message was open in a window. This fixed
375 projects.maemo.org bug NB#62862.
377 2007-07-11 Murray Cumming <murrayc@murrayc.com>
379 * src/modest-main.c: (main): Only show the UI at the start if
380 the showui command line option was given. For instance,
381 run-standalone src/modest showui
382 Otherwise, we wait for the top_application D-Bus method to
383 be sent by hildon-desktop when the application is selected
385 This allows us to run without a UI when osso-global-search
386 uses our D-Bus methods.
388 2007-07-11 Murray Cumming <murrayc@murrayc.com>
390 * src/dbus_api/modest-dbus-api.h: Added a define for a
391 top-application D-Bus method.
392 * src/dbus_api/modest-dbus-callbacks.c:
393 (on_top_application),
394 (modest_dbus_req_handler): Handle the top-application D-Bus
395 method, which might be an undocumented D-Bus signal sent by
396 hildon-desktop when it starts the application from the menu.
397 But I am not sure and I need to test it on the device, because
398 my scratchbox does not have the application in the menu now.
399 This method shows the main window, so that it can be invisible
400 when started, for instance, just for email searching from
403 * src/maemo/modest-main-window.c: (restore_settings),
404 (modest_main_window_new): Do not show the window immediately
405 upon creation. We show it later.
406 * src/modest-widget-memory.c: (save_settings_paned):
407 Try (unsuccessfully) to avoid saving the paned position when
408 it is not even visible.
409 (restore_settings_paned): Do not allow a silly paned position.
410 This seems necessary when not showing the window at first.
412 * tests/dbus_api/Makefile.am:
413 * tests/dbus_api/test_top_application.c: (main): Test for the
416 2007-07-10 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-ui-dimming-rules.c:
419 (modest_ui_dimming_rules_on_new_msg),
420 (modest_ui_dimming_rules_on_reply_msg),
421 (modest_ui_dimming_rules_on_delete_msg),
422 (modest_ui_dimming_rules_on_details),
423 (modest_ui_dimming_rules_on_view_window_move_to),
424 (modest_ui_dimming_rules_on_view_previous),
425 (modest_ui_dimming_rules_on_view_next),
426 (_invalid_folder_for_purge): Added checks before
427 casting the window. This looks like an actual
428 logic error in _invalid_folder_for_purge(), because it
429 tries to use a ModestMainWindow as a message window.
431 2007-07-10 Murray Cumming <murrayc@murrayc.com>
433 * src/maemo/modest-account-settings-dialog.c:
434 (show_error): Use the same implementation as in
435 modest-easysetup-wizard.c:
436 (on_entry_invalid_character): The logical ID contains a %s.
437 Guessed what it should be.
438 (on_entry_max), (check_data), (on_response): Adapt to
439 changed show_error().
440 (create_page_account_details): Really call
441 modest_validating_entry_set_func() on the correct widgets.
442 * src/maemo/easysetup/modest-easysetup-wizard.c:
443 (on_entry_invalid_character): Fix the logical ID here too.
444 (create_page_account_details),
445 (create_page_user_details):
447 modest_validating_entry_set_func() on the correct widgets.
449 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
450 Do not try to use the account if it is NULL.
452 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
454 * src/modest-ui-actions.c: (create_move_to_dialog),
455 (modest_ui_actions_on_main_window_move_to),
456 (modest_ui_actions_on_msg_view_window_move_to):
457 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
458 (filter_row), (modest_folder_view_show_non_move_folders):
459 * src/widgets/modest-folder-view.h:
461 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
462 the Sent folder yet as it does not report the correct folder type.
464 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
466 * src/maemo/modest-msg-edit-window.c: (init_window):
469 2007-07-10 Murray Cumming <murrayc@murrayc.com>
471 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
472 Take a parent widget instead of a parent window, and
473 implement this with hildon_banner_show_information() instead.
474 Non-Maemo builds can just ifdef that there.
475 This fixed projects.maemo.org bug NB#62766.
477 (on_entry_invalid_character): Use show_error() again instead
478 of using hildon directly, and use the _CS() macro to use the correct
480 (create_account), (check_for_supported_auth_methods), (on_entry_max):
481 Pass a widget instead od a window to show_error().
483 2007-07-10 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
486 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
487 This allows us to show the server name in the error message, fixing
488 projects.maemo.org bug NB#62904.
489 Also, use the appropriate logical ID message for the account protocol.
491 2007-07-10 Murray Cumming <murrayc@murrayc.com>
493 * src/modest-tny-account-store.c: (on_idle_wrong_password):
494 A compilation fix, though the build wasn't broken for me.
496 2007-07-09 Murray Cumming <murrayc@murrayc.com>
498 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
499 Do not try to unref a NULL folder store, to avoid a runtime warning.
500 This seems to happen sometimes when changing accounts settings.
502 2007-07-09 Murray Cumming <murrayc@murrayc.com>
504 * src/modest-tny-account-store.c:
505 (modest_tny_account_store_instance_init),
506 (modest_tny_account_store_finalize),
507 (on_account_settings_hide), (on_idle_wrong_password):
508 Use a GHashTable to ensure that we only show one account settings
509 dialog per modest account. This avoids us having a dialog open for
510 both the store and transport accounts, or due to repeated get_password()
511 calls that shouldn't happen anyway.
513 2007-07-09 Murray Cumming <murrayc@murrayc.com>
515 * src/maemo/modest-maemo-utils.c: (on_hide),
516 (modest_maemo_show_dialog_and_forget): Handle the response, because
517 the window is not even hidden by default.
519 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
520 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
521 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
522 which seems to prevent some modality problems.
524 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
525 Ignore user cancellation errors.
527 * src/modest-account-mgr-helpers.h:
528 * src/modest-account-mgr-helpers.c:
529 Added modest_server_account_get_password() and
530 modest_server_account_get_has_password() to avoid direct use of
533 * src/maemo/modest-account-settings-dialog.h:
534 * src/maemo/modest-account-settings-dialog.c:
535 (modest_account_settings_dialog_init): Store the notebook so we can
537 Added modest_account_settings_dialog_switch_to_user_info().
539 * src/modest-tny-account-store.c:
540 (get_password): When the password in the account settings is wrong (we think),
541 show the relevant page of the account settings dialog, in the mainloop.
542 However, we currently get many of these at once because cancel does not
544 (forget_password): Do not forget the password
545 from the account settings, because this causes side-effects when
546 tinymail seems to call it at strange time, maybe because of how we
547 are cancelling get_password().
548 (modest_tny_account_store_alert): Ignore user cancellations.
550 2007-07-09 Murray Cumming <murrayc@murrayc.com>
552 * src/maemo/modest-maemo-utils.h:
553 * src/maemo/modest-maemo-utils.c:
554 Added modest_maemo_show_information_note_and_forget() for use instead of
555 gtk_dialog_run() when the response is not needed, to avoid an extra
556 mainloop which could cause a hang.
558 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
559 Use the logical IDs for the error message, though they are not
560 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
561 because gtk_dialog_run() caused a hang here (the window did not close).
562 This fixes projects.maemo.org bug NB#62646.
564 2007-07-09 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-account-mgr-helpers.h:
567 * src/modest-account-mgr-helpers.c:
568 Added modest_account_mgr_get_store_protocol().
570 * src/maemo/modest-account-view-window.c:
571 (on_delete_button_clicked): Show different warning text depending on
572 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
573 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
576 2007-07-09 Murray Cumming <murrayc@murrayc.com>
578 * src/maemo/modest-msg-edit-window.c:
579 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
580 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
582 2007-07-07 Armin Burgmeier <armin@openismus.com>
584 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
585 ckdg_ib_maximum_characters_reached from correct package.
587 * src/modest-ui-actions.c: Show an error message when a folder could
588 not be created. Tinymail does not give us specific error codes about
589 what has gone wrong, so we assume that a folder with that name
590 already exists, though there might be other reasons.
592 2007-07-06 Murray Cumming <murrayc@murrayc.com>
594 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
595 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
596 give a more exact error message that can be partly translated.
598 2007-07-05 Murray Cumming <murrayc@murrayc.com>
600 * src/maemo/modest-address-book.c:
601 (select_email_addrs_for_contact): Specify a default window size for the
602 select-email-address dialog, so that it is probably big enough for the
603 title. This should fix projects.maemo.org bug NB#62277.
605 2007-07-05 Murray Cumming <murrayc@murrayc.com>
607 * src/maemo/easysetup/modest-easysetup-wizard.c:
608 (create_page_complete_easysetup): Use
609 gtk_widget_set_size() request to ensure that the text wraps
612 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
614 * src/maemo/easysetup/modest-easysetup-wizard.c:
615 (on_entry_invalid_character), (create_page_account_details),
616 (create_page_user_details):
617 Use new API of ModestValidatingEntry. But for some reason the banner is
618 not shown. I will have to investigate that further.
620 * src/widgets/modest-validating-entry.c: (on_insert_text),
621 (modest_validating_entry_set_func):
622 * src/widgets/modest-validating-entry.h:
623 Added a new callback function to be able to react to prevented
624 characters whitespaces to e.g show a banner.
626 2007-07-05 Armin Burgmeier <armin@openismus.com>
628 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
629 notification of HildonNumberEditor instead of remembering the port
630 number. Thanks to Johannes for pointing this out.
632 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
634 * src/maemo/easysetup/modest-easysetup-wizard.c:
635 Check if there are any user changes before showing a confirmation
636 dialog (projects.maemo.org NB#60946)
638 2007-07-05 Armin Burgmeier <armin@openismus.com>
640 * src/maemo/modest-account-settings-dialog.c: Remember custom port
641 number at the beginning of the dialog and set the modified flag at the
642 end if the port number has changed. This is necessary because
643 HildonNumberEditor does not support notification when the value has
646 2007-07-05 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-ui-actions.c:
649 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
650 a connection before asking anything else. Correct the check for the destination
651 folder so that it succeeds when online.
652 This fixed projects.maemo.org bug NB#61645.
654 2007-07-05 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
657 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
658 to fix projects.maemo.org bug NB#62439.
660 2007-07-05 Murray Cumming <murrayc@murrayc.com>
662 * src/modest-tny-account.c: (on_connection_status_changed):
663 Really do not use tny_device_force_offline() here. See the previous comment.
665 2007-07-04 Murray Cumming <murrayc@murrayc.com>
667 * src/modest-tny-account.c: (on_connection_status_changed):
668 Do not use tny_device_force_offline() when tinymail says that something
669 went wrong with the connection. It seems to report this unnecessarily.
671 2007-07-04 Murray Cumming <murrayc@murrayc.com>
673 * src/maemo/modest-connection-specific-smtp-window.c:
674 (modest_connection_specific_smtp_window_init):
675 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
676 does not seem to have any effect in osso 1.1 (though it works in
677 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
679 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
681 * src/maemo/modest-connection-specific-smtp-window.c:
682 Fix UI specification problems with projects.meamo.org NB#60479
684 2007-07-04 Murray Cumming <murrayc@murrayc.com>
686 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
687 clue when this has failed, because the error dialog is not always shown
688 (at least in earlier version).
690 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
691 GError message, because the generic error dialog is not helpful.
693 'This message is not currently available (can't let a new connection go online)'
694 when trying to open an IMAP message.
696 (_modest_ui_actions_open): Offer a connection when some messages would
697 have to be downloaded and we are offline.
699 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
701 * src/widgets/modest-folder-view.c:
702 Don't check for MERGE type anymore as we use the correct type
704 NOTE: For the last two changes you need to update your tinymail copy
705 because of API changes!
707 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
709 * src/modest-tny-local-folders-account.c:
710 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
711 (see projects.maemo.org NB#61580)
713 2007-07-04 Murray Cumming <murrayc@murrayc.com>
715 * src/modest-tny-account.c: (on_connection_status_changed):
716 Commented out the call to modest_platform_connect_and_wait() because this
717 seems to always hang, and I would like to know if this is the only thing
718 that causes a hang when showing the connection dialog.
719 It is not very useful anyway.
721 2007-07-04 Murray Cumming <murrayc@murrayc.com>
723 * src/maemo/modest-msg-view-window.c:
724 (modest_msg_view_window_select_next_message):
726 * src/modest-platform.h:
727 * src/maemo/modest-platform.c:
728 Added modest_platform_connect_and_wait(), which calls
729 tny_maemo_conic_device_connect() always in the main thread, by calling it
730 in an idle handler and waiting for the idle handler to run. It should be
731 in the main thread because it uses GTK+ UI code. It just returns TRUE
732 if the device is already online.
734 There is some nasty code to ensure that subsequent calls to
735 modest_platform_connect_and_wait() just wait for the first one to finish,
736 by checking repeatedly in another idle handler. This is necessary,
737 because other threads (or even the main thread, via another idle handler)
738 can call modest_platform_connect_and_wait() while
739 modest_platform_connect_and_wait() is running.
741 (modest_platform_connect_and_wait_if_network_account),
742 (modest_platform_connect_and_wait_if_network_folderstore):
743 Convenience functions that calls modest_platform_connect_and_wait() if
744 the account or folder might want network access.
746 * src/modest-mail-operation.c:
747 (modest_mail_operation_update_account):
748 * src/modest-ui-actions.c: (download_uncached_messages),
749 (modest_ui_actions_on_rename_folder), (delete_folder),
750 (modest_ui_actions_on_main_window_move_to),
751 (modest_ui_actions_on_msg_view_window_move_to):
752 * src/widgets/modest-folder-view.c:
753 (drag_and_drop_from_folder_view):
754 Offer a connection if we are offline.
756 * src/modest-tny-account.c: (on_connection_status_changed):
757 Document this as only handling errors during network operations in progress,
758 and replace the idle code with a simple call to
759 modest_platform_connect_and_wait(), which does this instead.
761 2007-07-03 Murray Cumming <murrayc@murrayc.com>
763 * src/modest-tny-account.c:
764 (modest_tny_account_get_special_folder): (util_on_idle),
765 Handle the GError so we can see when tny_folder_store_get_folders()
766 fails, as it currently does while something else is connecting.
768 Added util_run_in_main_thread_and_wait()
769 which uses an idlen handler and mainloop to ensure that the function
770 is called in the main thread.
771 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
772 to make sure that we call attempt the connection in the mainloop only,
773 which might solve some hangs.
775 2007-07-03 Murray Cumming <murrayc@murrayc.com>
777 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
778 be found by their display name. This is never useful.
779 * src/modest-tny-account-store.c: (on_account_removed): Find the account
780 by its ID, instead of trying to use its ID as its display name.
782 * src/modest-tny-account-store.h:
783 * src/modest-tny-account.c:
784 (modest_tny_account_get_special_folder): Add a g_warning() when
785 tny_folder_store_get_folders() returns an empty list for the maildir.
787 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
788 Add a g_warning() when this returns NULL, because that it not allowed
791 2007-07-02 Armin Burgmeier <armin@openismus.com>
793 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
794 note when trying to cancel the wizard. This fixes projects.maemo.org
797 2007-07-02 Murray Cumming <murrayc@murrayc.com>
799 * src/modest-tny-account.h:
800 * src/modest-tny-account.c:
801 (modest_tny_account_new_from_server_account),
802 (modest_tny_account_new_from_server_account_name),
803 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
804 because this must now be set before setting the proto. This is usd in
805 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
806 warning in camel_session_get_service() caused by
807 tny_camel_transport_account_prepare().
809 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
812 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
814 * src/maemo/modest-connection-specific-smtp-edit-window.c:
816 (modest_connection_specific_smtp_edit_window_init):
818 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
821 2007-06-29 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-tny-account.c:
824 (modest_tny_account_new_from_server_account):
825 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
826 now uses to request a connection when it needs one, and which it uses
827 to tell us that something is wrong with the connection, so we can force
828 the accounts offline to prevent further problems.
831 * src/modest-init.c: (init_default_settings):
832 * src/modest-mail-operation.c:
833 (modest_mail_operation_update_account):
834 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
835 This should not be necessary anymore. Do not set the conf key that
836 determined this (it was always TRUE and not set anywhere else).
838 * src/modest-ui-actions.h: Remove unused and unimplemented
839 modest_ui_actions_on_online_toggle_toggled().
841 2007-06-29 Murray Cumming <murrayc@murrayc.com
843 * src/maemo/modest-main-window.c: (connect_signals):
844 Don't connect to delete_event twice. Maybe this was harmless.
846 2007-06-29 Murray Cumming <murrayc@murrayc.com
848 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
849 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
850 Debug output to give some more clue when a folder move is not allowed.
852 2007-06-28 Murray Cumming <murrayc@murrayc.com
854 * src/modest-tny-account.c: (on_modest_file_system_info),
855 (modest_tny_account_get_mmc_account_name):
856 Always call the callback, without checking whether the name has changed.
857 * src/widgets/modest-folder-view.c: (strings_are_equal),
858 (on_model_foreach_set_name), (on_get_mmc_account_name),
859 (text_cell_data): Compare the name here, and use the name from
860 the account rather than from the
861 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
862 if the name was changed after the account was added to the model.
863 That's a tinymail bug but not one that I want to fix now.
865 This finally fixes projects.maemo.org bug NB#59301.
867 2007-06-27 Armin Burgmeier <armin@openismus.com>
869 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
872 2007-06-27 Murray Cumming <murrayc@murrayc.com
874 * src/modest-tny-account.h:
875 * src/modest-tny-account.c:
876 Added modest_tny_account_get_mmc_account_name(), to set the memory
877 card name asynchronously for the given account and then notify.
878 (modest_tny_account_new_for_local_folders): Use this new function instead
879 of using hildon_file_system_info_async_new() directly.
881 * src/widgets/modest-folder-view.c: (text_cell_data):
882 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
883 gtk_tree_model_row_changed() when it is available.
885 This should fix projects.maemo.org bug NB#59301.
887 2007-06-27 Murray Cumming <murrayc@murrayc.com
889 * src/modest-mail-operation.c: (update_account_thread),
890 (get_msgs_full_thread): Fix typo failures in the revert
893 2007-06-27 Murray Cumming <murrayc@murrayc.com
895 * src/maemo/modest-maemo-global-settings-dialog.c:
896 (idle_select_default_focus):
897 * src/modest-mail-operation.c: (idle_notify_progress),
898 (idle_notify_progress_once), (set_last_updated_idle),
899 (update_account_thread), (get_msgs_full_thread):
900 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
901 * src/widgets/modest-header-view.c:
902 (idle_notify_headers_count_changed_destroy),
903 (idle_notify_headers_count_changed):
904 Reverted the additions of gdk_threads_enter/leave(), in case this
905 helps with a startup hang on the device.
907 2007-06-26 Armin Burgmeier <armin@openismus.com>
909 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
910 for supported secure authentication methods from server by
911 gtk_dialog_run(), saving CPU time and a potential race condition.
913 2007-06-26 Armin Burgmeier <armin@openismus.com>
915 * src/maemo/modest-maemo-utils.h:
916 * src/maemo/modest-maemo-utils.c: Added a
917 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
918 only error code to tell the calling code when the user canceled the
921 * src/maemo/modest-account-settings-dialog.h:
922 * src/maemo/modest-account-settings-dialog.c:
923 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
924 message if the retrieval of secure authentication methods was canceled
925 by the user. Perform the check before saving anything to configuration
926 to not end up with half-committed configuration changes, do not show
927 a "Saving to configuration failed" note when authentication methods
928 could not be retrieved.
930 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
933 2007-06-26 Murray Cumming <murrayc@murrayc.com>
935 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
936 Only return the first level of folders under accounts, because the
937 osso-global-search UI spec doesn't want the rest.
938 This fixed projects.maemo.org bug NB#61811.
940 2007-06-26 Murray Cumming <murrayc@murrayc.com>
942 * src/modest-tny-account-store.c:
943 * src/modest-tny-account-store.h:
944 Added modest_tny_account_is_memory_card_account().
945 * src/maemo/modest-main-window.c: (create_details_widget):
946 Show the same information items for the memory card as we show for the
947 local-folders, to fix projects.maemo.org bug NB#59307.
949 2007-06-26 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-tny-account-store.c: (get_password):
952 Added some checks for NULL to maybe prevent crashes, though I think
953 it was Philip's last commit that actually prevented the crash here
954 when creating a first new account.
955 But the new account is still not usable (no messages are shown)
956 until a restart of the application.
958 2007-06-26 Murray Cumming <murrayc@murrayc.com>
960 * src/maemo/modest-maemo-global-settings-dialog.c:
961 (idle_select_default_focus):
962 * src/modest-mail-operation.c: (idle_notify_progress),
963 (idle_notify_progress_once), (idle_notify_update_account_queue),
964 (set_last_updated_idle), (update_account_thread),
965 (notify_get_msgs_full), (get_msgs_full_destroyer),
966 (get_msgs_full_thread):
967 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
968 * src/widgets/modest-header-view.c:
969 (idle_notify_headers_count_changed_destroy),
970 (idle_notify_headers_count_changed):
971 Use gdk_threads_enter() and gdk_threads_enter_leave() in
972 all idle handlers, because some other thread could be blocking
973 the GDK lock, so that it can do GUI stuff.
975 2007-06-26 Murray Cumming <murrayc@murrayc.com>
977 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
978 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
979 (on_idle_send_receive), (on_idle_open_default_inbox):
980 * src/maemo/modest-msg-edit-window.c:
981 (modest_msg_edit_window_attach_file_noninteractive):
982 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
983 to prevent a hang. I don't quite understand why these are necessary,
984 beause we should already be in the main loop. I guess something outside
985 of the main loop is taking the lock.
987 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
988 we are really using URIs, and use files that are more likely to exist.
990 2007-06-26 Murray Cumming <murrayc@murrayc.com>
992 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
993 necessary because configure.ac now defines different variables.
995 2007-06-26 Murray Cumming <murrayc@murrayc.com>
997 * libmodest-dbus-client/libmodest-dbus-client.c:
998 * libmodest-dbus-client/libmodest-dbus-client.h:
999 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1000 libmodest_dbus_client_compose_mail() is what things actually use.
1002 * src/dbus_api/modest-dbus-api.h:
1003 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1004 * tests/dbus_api/Makefile.am:
1005 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1008 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-init.c: (modest_init_local_folders):
1011 For memory-card (or other non local-folders) maildir accounts,
1012 always create an Archive folder, so that there is somewhere to put
1013 messages. This should be less confusing, because the user does not need
1014 to guess that the need to create a folder.
1016 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1018 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1019 Fixed icon size by using (50, 50) which is the same as defined by
1022 2007-06-25 Armin Burgmeier <armin@openismus.com>
1024 * src/widgets/modest-window-mgr.c:
1025 * src/modest-init.c:
1026 * configure.ac: Correctly recognize hildon-notify presence and fixed
1027 the build without it being installed.
1029 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1031 * libmodest-dbus-client/libmodest-dbus-client.c:
1032 (libmodest_dbus_client_search): Fix the build. Sorry.
1033 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1034 (reply_forward_cb): Initialize variables to fix the build.
1036 * src/modest-tny-account-store.c:
1037 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1038 comparison (a silly typo) so that email search results can be opened
1039 when there are more than one account.
1041 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1043 * libmodest-dbus-client/libmodest-dbus-client.c:
1044 (libmodest_dbus_client_search),
1045 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1046 instead of 1 second, because the search gets folders and messages from
1047 the server, which can take a long time. When it times out,
1048 osso-global-search will report no results.
1050 We need to specify whether we should search only cached information
1051 (maybe with a user preference), and the osso-email-search-plugin
1052 API should really be improved to allow that option, and to allow results
1053 to be delivered asynchronously in batches.
1055 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1057 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1058 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1059 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1061 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1063 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1064 that is an empty string. D-Bus seems to give us these instead of NULL.
1066 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1068 * src/dbus_api/modest-dbus-callbacks.c:
1069 * src/maemo/easysetup/modest-easysetup-wizard.h:
1070 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1072 (modest_connection_specific_smtp_edit_window_init):
1073 * src/maemo/modest-maemo-global-settings-dialog.c:
1075 * src/maemo/modest-maemo-utils.c:
1076 (modest_maemo_utils_setup_images_filechooser):
1077 * src/maemo/modest-main-window.c: (create_details_widget):
1078 * src/maemo/modest-msg-edit-window.c:
1079 (modest_msg_edit_window_attach_file_noninteractive),
1080 (modest_msg_edit_window_color_button_change),
1081 (modest_msg_edit_window_set_zoom):
1082 * src/modest-mail-operation.c: (update_account_thread):
1083 * src/modest-tny-account-store.c:
1084 * src/modest-tny-account.c:
1085 * src/widgets/modest-global-settings-dialog.c:
1086 * src/widgets/modest-window.h:
1088 Fixed build on bora!
1090 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1092 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1093 * src/modest-search.c: (modest_search_folder),
1094 (modest_search_all_accounts): Actually search only in the specified folder,
1095 doing a simple match on the folder ID.
1096 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1097 and added some documentation.
1099 2007-06-22 Armin Burgmeier <armin@openismus.com>
1101 * src/maemo/modest-maemo-utils.h:
1102 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1103 modest_maemo_utils_get_supported_secure_authentication_methods.
1105 * src/maemo/easysetup/modest-easysetup-wizard.c:
1106 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1107 one occured, not just "Server does not support secure authentication".
1109 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1111 * src/modest-tny-account-store.c: (get_password):
1112 Restored the call to tny_account_set_user() because Philip seems to have
1113 stopped this from crashing (by not using the freed string). It still does
1114 not work, but now we can test it.
1116 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1118 * src/maemo/modest-msg-edit-window.c: (init_window):
1119 Comment out use of an uninitialzed GtkScrolledWindow variable,
1120 to fix the build and stop a crash. Yet again.
1122 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1124 * src/modest-tny-account-store.c: (get_password):
1125 Remove the call to tny_account_set_user() because this actually crashes.
1126 As mentioned in the last commit, it is known to not work anyway.
1128 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1130 * src/modest-tny-account-store.c: (get_password):
1131 Use tny_account_set_username() to tell tinymail that the username might
1132 have changed too. But tinymail ignores this: see projects.maemo.org
1134 * src/modest-ui-actions.c:
1135 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1136 reset the connection when changing the username, and improve the comments.
1137 Save the changed username to gconf at least, so it is used when Modest is
1140 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1142 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1143 Do not use a query, so that we get all folders, including for POP and
1144 local-folders. They work as search criteria too.
1145 This fixes projects.maemo.org bug NB#57740.
1147 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1149 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1150 Comment out the use of hildon_notification_set_sound() because it is
1151 not declared, to fix the build. Warnings are serious, people.
1153 2007-06-21 Armin Burgmeier <armin@openismus.com>
1155 * src/maemo/modest-maemo-utils.h:
1156 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1157 modest_maemo_utils_get_supported_secure_authentication_methods()
1158 to query authentication methods for a specific user. This should fix
1159 projects.maemo.org bug NB#61369.
1161 * src/maemo/easysetup/modest-easysetup-wizard.c:
1162 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1165 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1167 * libmodest-dbus-client/libmodest-dbus-client.h:
1168 * libmodest-dbus-client/libmodest-dbus-client.c:
1169 (modest_dbus_message_iter_get_search_hit),
1170 (libmodest_dbus_client_search):
1171 Reorganised and commented this.
1172 Removed modest_search_hit_free() from the public API because it
1175 Added libmodest_dbus_client_get_folders() and
1176 modest_folder_result_list_free().
1178 * src/dbus_api/modest-dbus-api.h:
1179 * src/dbus_api/modest-dbus-callbacks.c:
1180 (modest_dbus_req_filter): Commented. Moved most code to
1181 on_dbus_method_search() and added on_dbus_method_get_folders().
1183 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1184 of the extra D-Bus handler.
1186 * tests/dbus_api/Makefile.am:
1187 * tests/dbus_api/test_get_folders.c: New test for
1188 libmodest_dbus_client_get_folders(). This seems to return an empty list
1189 at the moment. That could be the same error that causes the message list
1190 to be empty sometimes.
1191 This should help with projects.maemo.org bug NB#57740.
1193 2007-06-21 Armin Burgmeier <armin@openismus.com>
1195 * src/modest-mail-operation.c: Do not call
1196 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1197 notify the operation's end after having set the status to CANCELED for
1198 the operation queue to listen on. This fixes a deadlock when there
1199 were mail operations in the queue during its finalization.
1201 * src/modest-singletons.c: Reordered uninitialization of the account
1202 manager to happen after the mail operation queue was uninitialized
1203 because the mail operation's in the queue might still try to access
1204 the account manager (see modest_mail_operation_notify_end()). This
1205 fixes a potential crash when terminating the application.
1207 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1209 * src/modest-search.c:
1210 (search_mime_part_and_child_parts): Moved some code here so we
1211 can search recursively in child folders.
1212 (modest_search_folder): Search in the message as a mime part, instead
1213 of just its child mime parts.
1214 (read_chunk), (search_mime_part_ogs):
1215 Check how many bytes were read, to prevent an endless loop.
1216 Searching in message bodies now works. This finishes the fix for
1217 projects.maemo.org bug NB#61007.
1219 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1221 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1222 Add a g_warning when the item is not a folder.
1224 * src/modest-ui-dimming-rules.c:
1225 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1226 when selected item is not a folder (for instance, an account), because
1227 the UI spec only talks about folders.
1228 I am not sure what the UI spec wants, so this might not totally fix
1229 projects.maemo.org bug NB#60794.
1231 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1234 (load_from_file): Sort the list. The unsorted list would be more noticeable
1235 in non-English locales.
1237 * src/maemo/modest-msg-edit-window.c:
1238 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1239 warning and fix the build.
1241 * src/maemo/modest-progress-bar-widget.c:
1242 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1243 avoid a g_warning, and probably to avoid a crash.
1245 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-search.c: (modest_search_folder): Check for a GError
1248 when calling tny_folder_get_headers(), to show that this is not the cause
1251 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1253 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1254 Actually set the body query instead of the subject query.
1256 * src/modest-search.c: (search_mime_part_ogs),
1257 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1258 which would probably cause it to fail if we got this far.
1260 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1261 to simplify the code.
1262 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1263 be causing search-in-body to fail.
1265 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1267 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1269 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1270 Better debug message when the folder cannot be found.
1271 This should help with fixing projects.maemo.org bug #61287.
1272 * src/modest-search.c: (add_hit): Do not leak the furl string.
1274 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1276 * src/modest-ui-actions.c:
1277 (modest_ui_actions_on_folder_selection_changed):
1278 Do not special-case TNY_MERGE_FOLDER here, because
1279 modest_tny_folder_get_account() already does that. This fixes
1280 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1281 shown when the Outbox was selected).
1283 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1285 * libmodest-dbus-client/libmodest-dbus-client.c:
1286 (_dbus_iter_get_string_or_null): Initialize the string variable in
1287 case this helps with Dirk's crash.
1289 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1291 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1292 though it is not implemented yet (this function is maybe not even used),
1293 to avoid breaking ABI in future.
1294 * libmodest-dbus-client/libmodest-dbus-client.c:
1295 (get_attachments_string): Moved some code into this generic function.
1296 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1297 sends email. It is maybe not used.
1298 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1299 (on_send_mail): Use attachments.
1301 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1302 * src/maemo/modest-msg-edit-window.c:
1303 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1304 a filename before using it, to fix projects.maemo.org bug NB#58233.
1306 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1308 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1309 Initialize the continue_download variable to fix the build, and probably
1310 to fix randome behaviour.
1312 2007-06-18 Armin Burgmeier <armin@openismus.com>
1314 * src/modest-tny-send-queue.h:
1315 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1316 the queue so we can later show it in the UI. Replaced
1317 modest_tny_send_queue_msg_is_being_sent() by
1318 modest_tny_send_queue_get_msg_status().
1320 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1322 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1323 gpointer. This probably was not harmful, but just to be sure.
1325 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1327 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1328 Fix the build, but leave the function broken on Bora, because
1329 hildon_uri_action_get_service() does not exist.
1330 osso_uri_action_get_service() does not exist either, it seems.
1332 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1334 * src/modest-tny-account.c:
1335 (modest_tny_account_new_from_server_account):
1336 Uncommented the url debug output again, because it is useful for
1337 debugging, as I said in the comment.
1339 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1341 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1343 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1344 for Mameo Bora, to fix the build.
1346 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1349 Fixed build with hildon < 0.99
1351 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1352 Check if the selected account is busy instead of checking all accounts
1354 * src/modest-account-mgr-priv.h:
1355 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1356 (modest_account_mgr_init), (compare_account_name),
1357 (modest_account_mgr_set_account_busy),
1358 (modest_account_mgr_account_is_busy):
1359 * src/modest-account-mgr.h:
1360 Added busy information to the account manager. It possible to
1361 set an account to busy or not busy now.
1363 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1364 (modest_mail_operation_update_account),
1365 (modest_mail_operation_notify_end):
1366 Set the account to busy/not busy depending on the operation state.
1368 * src/widgets/modest-account-view.c:
1369 (modest_account_view_finalize), (get_last_updated_string),
1370 (update_account_view), (on_account_busy_changed), (init_view):
1371 Show string "Refreshing..." if the account is currently busy.
1373 All this fixes projects.maemo.org bug NB#59711
1375 2007-06-14 Armin Burgmeier <armin@openismus.com>
1377 * src/widgets/modest-attachments-view.h:
1378 * src/widgets/modest-attachments-view.c: Added
1379 modest_attachments_view_has_attachments() and fixed coordinate
1380 transformation in get_att_view_at_coords(). This fixes attachment
1383 * src/widgets/modest-msg-view.c: Make use of
1384 modest_attachments_view_has_attachments() to decide whether to show
1385 attachments in the header.
1387 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1389 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1390 (on_change), (on_combo_security_changed),
1391 (modest_connection_specific_smtp_edit_window_init),
1392 (modest_connection_specific_smtp_edit_window_set_connection),
1393 (modest_connection_specific_smtp_edit_window_is_dirty):
1394 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1395 * src/maemo/modest-connection-specific-smtp-window.c:
1398 Show an comfirmation dialog for the smpt-edit-window if there are
1399 unsaved changes and the user hits cancel.
1400 (projects.maemo.org bug NB#60479)
1402 2007-06-14 Armin Burgmeier <armin@openismus.com>
1404 * src/maemo/easysetup/modest-easysetup-wizard.c:
1405 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1406 address" info in banner instead of node, and select all the text as
1407 per UI spec. This fixes projects.maemo.org bug NB#60550.
1409 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1411 reviewed by: <delete if not using a buddy>
1413 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1414 * src/modest-ui-actions.c: (folder_refreshed_cb):
1416 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1418 * src/widgets/modest-folder-view.c: (filter_row):
1419 Explictly filter out the per-account outbox accounts. I don't know why
1420 these only sometimes show up, but now they should never show up in the UI.
1421 This should fix projects.maemo.org bug NB#60160.
1423 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1426 when the toolbar does not exist yet.
1427 * src/modest-widget-memory.c: (save_settings_header_view):
1428 Added g_warnings() to help us to discover when we are trying to set
1429 an empty columns list in gconf.
1431 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1433 * src/modest-init.h:
1434 * src/modest-init.c:
1435 Added modest_init_get_default_header_view_column_ids().
1437 * src/modest-widget-memory.c: (restore_settings_header_view):
1438 Use the new function to get defaults, if the gconf key is empty,
1439 instead of not creating any columns. This seems to fix the
1440 empty right-hand pane problems.
1442 * src/widgets/modest-header-view.h: Improved documentation.
1444 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1446 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1447 Revert the use of the display name as the account name, because this
1448 is generally wrong and would break the code that follows.
1450 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1452 * src/maemo/easysetup/modest-easysetup-wizard.c:
1453 (check_for_supported_auth_methods), (on_before_next),
1456 More correct fix for projects.maemo.org bug NB# 58991
1457 Do not longer accept AUTH_PASSWORD as secure method and choose
1458 correct method when creating the account.
1460 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1462 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1463 Fixed projects.maemo.org bug NB# 58991
1465 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-init.c: (modest_init_init_core),
1468 (modest_init_local_folders): Fixed compilation errors.
1470 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1472 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1473 Remove unnecessary lib/include, though it is good in principle when needed.
1475 * src/modest-init.c: (modest_init_one_local_folder),
1476 (modest_init_local_folders):
1477 * src/modest-init.h: Initialize the .modest library for memory cards,
1478 instead of just doing nothing for them. This should allow us to create
1479 folders there, fixing projects.maemo.org bug NB#59297.
1481 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1483 * libmodest-dbus-client/libmodest-dbus-client.c:
1484 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1485 (libmodest_dbus_client_compose_mail),
1486 (libmodest_dbus_client_open_message),
1487 (libmodest_dbus_client_send_and_receive),
1488 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1490 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1491 (on_idle_open_message), (modest_dbus_req_handler),
1492 (search_result_to_message), (modest_dbus_req_filter):
1493 * src/modest-search.c: (add_hit), (modest_search_folder),
1494 (modest_search_all_accounts): Improved debug messages.
1496 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1498 * src/modest-tny-account-store.c:
1499 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1502 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1505 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1507 * src/modest-tny-account-store.c: (get_server_accounts):
1508 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1509 even when there are no accounts, so that the Outbox folder is always
1510 visible. This fixes projects.maemo.org bug NB#60158.
1512 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1514 * src/maemo/modest-main-window.c: (create_details_widget):
1515 Use the mcen_va_never logical ID.
1517 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1519 * src/dbus_api/modest-dbus-api.h:
1520 * src/dbus_api/modest-dbus-callbacks.c:
1521 (on_idle_open_default_inbox), (on_open_default_inbox),
1522 (modest_dbus_req_handler):
1523 Added a new OpenDefaultInbox method.
1525 * libmodest-dbus-client/libmodest-dbus-client.h:
1526 * libmodest-dbus-client/libmodest-dbus-client.c:
1527 Added libmodest_dbus_client_open_default_inbox() to call the new
1528 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1529 though it should maybe be used by a new osso-email-interface function.
1531 * tests/dbus_api/Makefile.am:
1532 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1535 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1537 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1538 NULL, so that the signals get all the keys. This should not actually
1539 change any behaviour because we currently update everything when anything
1542 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1544 * src/widgets/modest-folder-view.c: (text_cell_data),
1545 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1546 (find_inbox_iter): If tinymail tells us that the folder is
1547 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1548 This causes the inbox to be selected at startup, fixing part of
1549 projects.maemo.org bug NB#56305.
1551 * src/modest-ui-dimming-rules.c:
1552 (modest_ui_dimming_rules_on_tools_smtp_servers):
1553 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1554 the SMTP servers menu item.
1555 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1556 that the SMTP Servers menu item is dimmed when there are no accounts,
1557 as a future version of the UI spec will require. This fixes
1558 projects.maemo.org bug NB#56305.
1560 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1562 * src/maemo/modest-maemo-utils.c:
1563 (modest_maemo_utils_get_supported_secure_authentication_methods):
1564 Added label to dialog instead of unreadable title
1566 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1567 (modest_main_window_new):
1568 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1571 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1572 * src/modest-account-mgr.h:
1573 Added method to avoid code duplication
1575 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1576 (modest_ui_actions_on_send_receive):
1577 Use modest_account_mgr_has_accounts
1579 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1581 * src/maemo/easysetup/modest-presets.c:
1582 (modest_presets_get_info_server_security): Do not report secure auth
1584 * src/modest-protocol-info.c: Use the defines for the gconf key names
1585 for secure authentication. This was not working because we were writing
1586 Password and reading password, and the check was case sensitive.
1587 With this, gmail now works for receiving and sending when created via
1590 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1592 * src/maemo/easysetup/modest-presets.c:
1593 (modest_presets_get_info_server_security): Correct the key name for
1594 SecureSmtp, because it seems to be case-sensitive.
1595 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1596 Do not try to get the 0th notebook page if there are 0 pages, to
1597 avoid a g_warning().
1599 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1601 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1602 Prevent use of the new notification feature for now, because it currently
1603 shows one dialog for each new email, which is annoying.
1605 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1607 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1608 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1609 when no country was selected, so that we show the global ones.
1610 * src/maemo/easysetup/modest-presets.c:
1611 (modest_presets_get_providers): Return only the global providers, not
1612 all providers when mmc=0 was requested.
1614 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1616 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1617 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1618 provider ID in the combo.
1620 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1621 Do not show the page numbers, because it would be confusing when we add
1622 the 2 extra pages for the custom setup, when the user chooses the "Other"
1623 provider. This fixes projects.maemo.org bug NB#59028
1625 * src/modest-init.c: (modest_init_init_core),
1626 (modest_init_local_folders):
1627 * src/modest-init.h:
1628 * src/modest-tny-account.c:
1629 (modest_tny_account_new_for_local_folders): Do not create default folders
1630 for the memory card. This should fix projects.maemo.org bug NB#59328.
1632 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1634 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1635 Free the changed_conf_keys string items. They are already freed in the
1636 idle handler if that runs first.
1638 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1640 * src/modest-ui-actions.c:
1641 (modest_ui_actions_on_password_requested): Check that the server name
1642 is not NULL, because I just saw a password dialog with (null) as the
1645 * src/modest-tny-folder.[h|c]: Added
1646 modest_tny_folder_is_memory_card_folder().
1647 * src/modest-ui-dimming-rules.c:
1648 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1649 menu item for memory cards, as per the UI spec (section 7.4). This should
1650 fix projects.maemo.org bug NB#59297.
1652 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1654 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1655 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1656 is another problem with the code, see Murray's comment at line 772)
1658 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1660 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1661 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1662 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1663 (load_from_file), (easysetup_country_combo_box_init),
1664 (easysetup_country_combo_box_get_active_country_ids),
1665 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1666 instead of just one ID, to avoid duplicate country names in the UI.
1668 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1669 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1670 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1671 a single ID, avoiding duplicate providers.
1672 * src/maemo/easysetup/modest-easysetup-wizard.c:
1673 (on_combo_account_country): Adapt to use a list.
1675 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1677 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1678 keys changed in the last X seconds.
1680 * src/modest-account-mgr.h:
1681 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1682 (on_key_change), (modest_account_mgr_class_init),
1683 (modest_account_mgr_init), (modest_account_mgr_finalize):
1684 As the keys are changed, save them in a GSList* and signal that GSList*
1685 further every X seconds, to batch changes, to allow us to do just one
1686 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1687 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1689 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1690 changed signal signature.
1692 * src/modest-conf.c: (modest_conf_set_list),
1693 (modest_conf_on_change): Reenable notification.
1695 (modest_conf_maemo_fake_on_change): Comment out the hack that
1696 notified immediately instead of asynchronously.
1698 * src/widgets/modest-account-view.h:
1699 * src/widgets/modest-account-view.c:
1700 (update_account_view): Select the previously-selected account ID,
1701 if possible. This fixes projects.maemo.org bug NB#56933.
1703 (on_account_changed), (on_account_removed),
1704 (modest_account_view_select_account):
1706 Remove the block/unblock functions
1707 because they were not useful.
1709 * src/maemo/modest-account-view-window.c:
1710 (on_delete_button_clicked), (on_edit_button_clicked),
1711 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1713 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1715 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1716 Improve the error dialog to show Incorrect Account Settings, which seems
1717 clearer, and say that the internal error message (to be removed from the
1718 dialog later) is often misleading.
1719 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1721 * src/modest-tny-account.c:
1722 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1723 URL because this is so useful for debugging on the device.
1725 * src/widgets/modest-serversecurity-combo-box.c:
1726 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1728 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1730 * src/modest-mail-operation.c:
1731 (modest_mail_operation_send_new_mail):
1732 Added a comment about a nasty but apparently harmless message. Details
1733 added to the wiki g_warnings() page.
1735 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1737 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1738 (modest_tny_send_queue_class_init):
1739 Do not use the priv struct because it is empty, to avoid g_warnings
1740 about a non-existant priv struct.
1742 * src/modest-tny-account-store.c:
1743 (modest_tny_account_store_get_server_account),
1744 (modest_tny_account_store_get_transport_account_for_open_connection
1745 ): Do not try to get transport server accounts for local folders,
1746 because they don't have any. This avoids a g_warning().
1748 * src/maemo/modest-main-window.c:
1749 (modest_main_window_notify_send_receive_initied),
1750 (on_configuration_key_changed):
1751 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1752 * src/modest-defs.h:
1753 * src/modest-mail-operation.c:
1754 (modest_mail_operation_update_account):
1755 * src/modest-tny-account-store.h:
1756 * src/modest-tny-account.c:
1757 (modest_tny_account_get_special_folder),
1758 (modest_tny_account_new_for_local_folders),
1759 (modest_tny_account_new_for_per_account_local_outbox_folder):
1760 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1761 * src/modest-tny-local-folders-account.c:
1762 (add_account_folders_to_merged_folder):
1763 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1764 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1765 (modest_ui_actions_on_send):
1766 * src/widgets/modest-folder-view.c: (update_model):
1767 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1768 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1769 modest_tny_account_store_get_tny_account_by_account() to
1770 modest_tny_account_store_get_server_account() to make the code clearer.
1772 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1774 * src/dbus_api/modest-dbus-api.h:
1775 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1776 * src/maemo/modest-msg-edit-window.c:
1777 (modest_msg_edit_window_attach_file_noninteractive):
1778 added g_warning in case the file to be attached does not exist
1779 * tests/dbus_api/test_compose_mail.c: (main):
1780 removed obsolete comment, added generic files as test case
1782 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1784 * src/modest-tny-account-store.c: (get_server_accounts):
1785 Create the local folders account only once, not once for each outbox, and
1786 not only when there are some outboxes.
1788 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1790 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1791 code that is causing a crash at startup. Sergio says that he is fixing this.
1793 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1795 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1796 * src/maemo/modest-account-settings-dialog.c:
1797 (create_page_outgoing),
1798 (modest_account_settings_dialog_set_account_name),
1799 (save_configuration):
1800 - Fixed handling of the "Use secure authentication" toggle to comply with
1801 the ui specification. See also projects.maemo.org bug NB#58400
1803 - Restore the Secure connection setting combo correctly when loading
1806 * src/maemo/modest-maemo-utils.c:
1807 (on_camel_account_get_supported_secure_authentication),
1808 (modest_maemo_utils_get_supported_secure_authentication_methods):
1809 Fixed a crasher if operation is canceled
1811 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1812 (modest_protocol_info_auth_is_secure):
1813 * src/modest-protocol-info.h:
1815 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1816 the sense of the "Use secure authentication" toggle.
1818 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1820 * src/modest-tny-account-store.h:
1821 * src/modest-tny-account-store.c:
1822 Added modest_tny_account_store_get_local_folders_account().
1824 * src/modest-tny-folder.h:
1825 * src/modest-tny-folder.c:
1826 (modest_tny_folder_get_account):
1827 Added this replacement for tny_folder_get_account() which returns
1828 the local-folders account for TnyMergeFolders, to avoid the
1829 warning about the unimplemented get_account_func() vfunc().
1831 (modest_tny_folder_get_rules),
1832 * src/modest-ui-actions.c:
1833 (modest_ui_actions_on_folder_selection_changed):
1834 * src/modest-mail-operation.c:
1835 (modest_mail_operation_remove_folder),
1836 (modest_mail_operation_xfer_folder),
1837 (modest_mail_operation_rename_folder),
1838 (modest_mail_operation_get_msg),
1839 (modest_mail_operation_get_msgs_full),
1840 (modest_mail_operation_remove_msg),
1841 (modest_mail_operation_xfer_msgs),
1842 (modest_mail_operation_refresh_folder):
1843 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1845 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1847 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1848 (modest_server_account_set_security):
1849 * src/modest-defs.h: Add comments explaining that our
1850 UI spec means TLS when it says Normal, so these do not look like errors.
1852 * src/modest-tny-account.c:
1853 (modest_tny_account_new_from_server_account): Use the new tinymail
1854 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1855 for TLS. This should fix projects.maemo.org bug NB#58460.
1857 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1859 * src/maemo/easysetup/modest-easysetup-wizard.c:
1860 (create_account): Correct the position of the gconf sanity check warning.
1861 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1862 of using the g_idle_add() hack, because this does not seem to be necessary
1863 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1864 caused by something other than maemo's gconf.
1865 This fixes projects.maemo.org bug #59022.
1867 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1869 * src/modest-account-mgr-helpers.c:
1870 (modest_account_mgr_get_default_account): Do not check that the account
1871 exists if there is no default account (NULL), to fix a runtime warning.
1873 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1875 * src/widgets/modest-folder-view.c: (update_model):
1876 Do not unref the treemodel before we have finished with it.
1877 This prevents a valgrind warning and an occasional crash at startup.
1879 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1881 * libmodest-dbus-client/libmodest-dbus-client.h:
1882 added libmodest_dbus_client_compose_mail()
1883 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1885 added functions needed for SendAsMail() functionality
1886 * src/maemo/modest-msg-edit-window.c:
1887 (modest_msg_edit_window_attach_file_noninteractive):
1888 non interactively attaching files to message edit window
1889 * src/widgets/modest-msg-edit-window.h:
1890 * tests/dbus_api/Makefile.am:
1891 added test_compose_mail.c
1892 * tests/dbus_api/test_compose_mail.c: (main):
1894 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1896 * src/modest-account-view.c:
1897 Fixed bug projects.maemo.org bug NB#59307
1899 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1901 * src/maemo/easysetup/modest-easysetup-wizard.c:
1902 (get_serverport_incoming), (on_before_next), (create_account):
1903 * src/maemo/modest-account-settings-dialog.c:
1904 (modest_account_settings_dialog_set_account_name):
1905 * src/maemo/modest-maemo-utils.c:
1906 (on_camel_account_get_supported_secure_authentication_status),
1907 (on_camel_account_get_supported_secure_authentication),
1908 (on_secure_auth_cancel),
1909 (modest_maemo_utils_get_supported_secure_authentication_methods):
1911 Implemented security authentication for settings and easysetup.
1913 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/modest-main-window.c: (create_details_widget):
1916 Show the total size for memory card accounts too, instead of showing
1917 the name again. Fixes bug projects.maemo.org bug NB#59307.
1919 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1922 * src/modest-tny-simple-folder-store.c:
1923 * src/modest-tny-simple-folder-store.h: Removed.
1925 * src/modest-tny-local-folders-account.h
1926 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1927 for the local-folders maildir, with an extra TnyMergedFolder containing
1928 the folders of the per-account outbox store accounts.
1929 * src/modest-tny-account-store.c: (get_server_accounts):
1930 Add the outboxes to the special local folders account after creating it.
1932 * src/modest-tny-account.c:
1933 (modest_tny_account_new_for_local_folders): Create the derived
1934 account when creating the main local-folders account.
1936 * src/maemo/modest-main-window.c: (create_details_widget),
1937 (modest_main_window_set_contents_style):
1938 Adapted to the use of the derived account instead of the folder store.
1940 * src/modest-ui-actions.c:
1941 (modest_ui_actions_on_folder_selection_changed):
1942 * src/modest-ui-dimming-rules.c:
1943 (modest_ui_dimming_rules_on_new_folder):
1944 * src/widgets/modest-folder-view.c: (text_cell_data),
1945 (icon_cell_data), (filter_row), (update_model),
1946 (get_cmp_rows_type_pos):
1949 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1950 Do not get the priv struct, because no priv struct has been set,
1951 to avoid a runtime warning.
1953 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1954 #ifelse with #else, to fix a warning, to fix the build.
1957 2007-06-05 Christian Kellner <ckellner@openismus.com>
1959 * libmodest-dbus-client/libmodest-dbus-client.c:
1960 Fix small typo in doc (why do you always see them
1961 AFTER committing stuff?)
1964 2007-06-05 Christian Kellner <ckellner@openismus.com>
1966 * libmodest-dbus-client/libmodest-dbus-client.c:
1967 (libmodest_dbus_client_search):
1968 Initialize hit list with NULL. Also set folder list
1969 to "" if NULL was supplied.
1972 2007-06-03 Christian Kellner <ckellner@openismus.com>
1974 * libmodest-dbus-client/libmodest-dbus-client.c:
1975 (modest_search_hit_list_free):
1976 Make it save to call it with NULL.
1978 * src/dbus_api/modest-dbus-callbacks.c:
1979 * src/modest-search.c:
1980 Return full ModestSearchHits as the search result list not TnyHeader
1981 since can't be around withouth the correspoding TnyFolder.
1983 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1985 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1986 Added currently commented code to check for secure auth
1988 * src/maemo/modest-account-settings-dialog.c: (on_response),
1989 (save_configuration), (show_ok):
1990 Fixed projects.maemo.org bugs NB #59248 and #59251
1992 * src/maemo/modest-maemo-utils.c:
1993 (on_camel_account_get_supported_secure_authentication_status),
1994 (on_camel_account_get_supported_secure_authentication),
1995 (modest_maemo_utils_get_supported_secure_authentication_methods):
1996 * src/maemo/modest-maemo-utils.h:
1997 Moved get_supported_secure_authentication() method here to be able
1998 to use it from easysetup wizard.
2000 * src/modest-pair.c: (on_pair_compare_as_string):
2001 Should compare string with first part of pair and not
2002 strcmp pairs which will crash.
2004 * src/modest-protocol-info.c:
2005 (modest_protocol_info_protocol_is_store):
2006 * src/modest-protocol-info.h:
2007 Added modest_protocol_info_get_auth_protocol_name()
2009 2007-06-03 Armin Burgmeier <armin@openismus.com>
2011 * src/modest-mail-operation.c:
2012 (modest_mail_operation_get_msgs_full): Set priv->account also when
2013 only retrieving a single message. This avoids a crash when canceling
2016 (modest_mail_operation_notify_end): Do not explicitely remove the
2017 operation from the queue but only emit the progress_changed signal.
2018 The queue itself listens to that signal to remove the operation when
2019 it is finished. This reduces coupling and removes a potential deadlock
2020 when modest_mail_operation_notify_end() is called from the queue
2021 itself. If that is a problem performance-wise, I would suggest to
2022 implement a status-changed signal or something.
2024 * src/modest-mail-operation-queue.c: Make sure to never call a
2025 function from another file while the queue is locked. This (hopefully)
2026 fixes another deadlock when exiting the application while retrieving
2029 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2031 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2032 Fixed build if libogs is not available
2034 2007-06-03 Christian Kellner <ckellner@openismus.com>
2036 * libmodest-dbus-client/libmodest-dbus-client.h:
2037 * libmodest-dbus-client/libmodest-dbus-client.c:
2038 (libmodest_dbus_client_delete_message):
2039 Implement deletion of messages (Client side).
2041 (modest_search_hit_free),
2042 (modest_search_hit_list_free):
2043 Utility functions to free the result hits.
2045 * src/dbus_api/modest-dbus-api.h:
2046 * src/dbus_api/modest-dbus-callbacks.c:
2047 (on_delete_message),
2048 (modest_dbus_req_handler):
2049 Implement deletion of messages (Server side).
2051 * tests/dbus_api/test_search.c: (main):
2054 * tests/dbus_api/Makefile.am:
2055 * tests/dbus_api/test_delete_message:
2056 Add little test for the message deletion logic
2058 2007-06-03 Armin Burgmeier <armin@openismus.com>
2060 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2061 when the operation queue was not empty. projects.maemo.org bug
2064 2007-06-03 Armin Burgmeier <armin@openismus.com>
2066 * src/widgets/modest-account-view.c
2067 (on_account_default_toggled): Toggle default account column
2068 explicitely instead of waiting for gconf notification (which is
2069 currently ignored). This should fix projects.maemo.org bug NB#56910
2070 for now. It should probably be removed when gconf notifications are
2073 2007-06-03 Christian Kellner <ckellner@openismus.com>
2075 * libmodest-dbus-client/libmodest-dbus-client.c:
2076 Removed debugging spew.
2078 * src/dbus_api/modest-dbus-callbacks.c:
2079 Added debugging info.
2081 * src/modest-search.c:
2082 (modest_search_all_accounts):
2083 Use tny_account_store_get_accounts () on the account store
2084 to get all accounts which is the way to get all accounts.
2086 * tests/dbus_api/test_search.c: (main):
2087 Make it possible to supply the search term on the command line.
2089 2007-06-03 Christian Kellner <ckellner@openismus.com>
2091 * libmodest-dbus-client/libmodest-dbus-client.c:
2092 * libmodest-dbus-client/libmodest-dbus-client.h:
2093 Implement searching for mesages over raw dbus. (Client side)
2095 * src/dbus_api/Makefile.am:
2096 * src/dbus_api/modest-dbus-api.h:
2097 * src/dbus_api/modest-dbus-callbacks.c:
2098 * src/dbus_api/modest-dbus-callbacks.h:
2099 Search framework (Server side). Also implement on_idle_open_message().
2101 * src/maemo/modest-platform.c: (modest_platform_init):
2102 Prepare for raw dbus/osso rpc interaction.
2104 * src/modest-search.h:
2105 Changed minsize from unspecific guint to guint32.
2107 * src/modest-search.c:
2109 Added strange hack which magically made tnymail work.
2111 (modest_search_folder),
2112 (modest_search_account),
2113 (modest_search_all_accounts):
2114 Implement helper functions to search all accounts, specific account
2117 * tests/dbus_api/Makefile.am:
2118 * tests/dbus_api/test_open_message.c:
2119 Read url to open from commandline.
2121 * tests/dbus_api/test_search.c:
2122 Implement small test for dbus search stuff
2124 2007-06-02 Armin Burgmeier <armin@openismus.com>
2126 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2127 include account type and account title. This fixes projects.maemo.org
2130 * src/maemo/modest-account-view-window.c: Set a title for the window.
2132 2007-06-02 Armin Burgmeier <armin@openismus.com>
2134 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2135 incoming and outgoing server name based on email address and server
2136 types as long as the names have not been edited manually. This fixes
2137 projects.maemo.org bug NB#58671.
2139 2007-06-02 Armin Burgmeier <armin@openismus.com>
2141 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2142 server type cannot be changed in future to the incoming details page
2143 when creating an account. This fixes projects.maemo.org bug NB#59029.
2145 2007-06-02 Armin Burgmeier <armin@openismus.com>
2147 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2148 and assigned max width chars so that they wrap instead of being
2149 truncated. Fixes projects.maemo.org bug NB#56126.
2151 2007-06-02 Armin Burgmeier <armin@openismus.com>
2153 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2154 introductory note to the connection specific smtp servers dialog, as
2155 section 8.12 of the email UI specification requires. This fixes
2156 projects.maemo.org bug NB#59212.
2158 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2160 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2161 Check for running mail operations, and offer to cancel them, as per the UI
2162 spec. This fixes projects.maemo.org bug NB#59041 .
2163 However, I suspect that tinymail may still use the network connection
2164 in ways that we cannot detect or cancel. But it should at least adapt to
2165 changes fairly well.
2167 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-tny-account-store.c: (recreate_all_accounts),
2170 (get_cached_accounts), (get_server_accounts): Do more sensible
2171 ref-counting of the temporarily-cached outbox accounts list. This seems
2172 to fix a crash when entering the password when the password was wrong.
2174 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2176 * src/gnome/modest-main-window.c: (connect_signals):
2177 * src/modest-tny-account-store.c: (get_password),
2178 (modest_tny_account_store_alert): Added comments and clues and
2179 commented-out code about how we currently fail to deal with connection
2180 errors and wrong passwords, and how we should.
2182 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2184 * src/widgets/modest-retrieve-combo-box.c:
2185 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2186 This fixes projects.maemo.org bug NB#58472 .
2188 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2190 * src/maemo/easysetup/modest-easysetup-wizard.c:
2191 (create_page_complete_easysetup):
2192 (create_page_complete_custom): Correct the last commit,
2193 putting the correct sentences in the correct pages.
2195 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2197 * src/maemo/easysetup/modest-easysetup-wizard.c:
2198 (create_page_complete_custom): Show the second sentence of text
2199 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2202 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2204 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2205 Set the leave-on-server conf key by default. This fixes
2206 projects.maemo.org bug NB#59258 .
2208 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/modest-account-view-window.c:
2211 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2212 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2215 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2217 * src/maemo/easysetup/modest-easysetup-wizard.c:
2218 (create_caption_new_with_asterisk):
2219 * src/maemo/modest-account-settings-dialog.c:
2220 (create_caption_new_with_asterisk):
2221 Uncomment the code to add the asterisk, because they are no longer in the
2222 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2223 (update_incoming_server_title): Add an asterisk here too.
2225 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2227 * src/maemo/modest-maemo-global-settings-dialog.c:
2228 (current_connection): Check that we are even connected before trying to
2229 get the current connection name, to prevent a warning.
2231 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2232 Change the comments because tny_maemo_conic_device_connect() is now meant to
2234 * src/modest-mail-operation.c:
2235 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2236 make sure we have a connection and fail if we can't connect.
2238 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2240 * src/maemo/modest-main-window.c:
2241 (on_account_store_connecting_finished): Do not try to get the
2242 connection ID if we are not really connected. I am surprised that
2243 this signal handler is called when we are not connected.
2245 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2247 * src/modest-error.h:
2248 * src/modest-ui-actions.c:
2249 (modest_ui_actions_get_msgs_full_error_handler):
2250 Renamed an enum, added comments, added an enum
2251 for retrieve-limit errors.
2253 * src/modest-mail-operation.c: (foreach_add_item),
2254 (internal_folder_observer_update), (update_account_thread),
2255 (modest_mail_operation_get_msgs_full):
2256 (modest_mail_operation_update_account),
2257 Added comments about how this works, and some code that should
2258 (but does not) check the retrieve-limit. See the TODO comment.
2260 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2262 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2263 Initialize help_id to fix the build. Warnings are good.
2265 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2267 * src/widgets/modest-hbox-cell-renderer.c:
2268 (modest_hbox_cell_renderer_append):
2269 * src/widgets/modest-vbox-cell-renderer.c:
2270 (modest_vbox_cell_renderer_append):
2271 Fix the last commit by doing an extra ref.
2273 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2275 * src/widgets/modest-hbox-cell-renderer.c:
2276 (modest_hbox_cell_renderer_append):
2277 * src/widgets/modest-vbox-cell-renderer.c:
2278 (modest_vbox_cell_renderer_append):
2279 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2280 to fix the build with Maemo Bora.
2281 However, there seems to be a remaining crash, probably due to reference
2284 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2286 * src/modest-tny-account.c:
2287 (modest_tny_account_new_for_local_folders):
2288 Use hildon_file_system_info_async_new() to get a better name for
2289 the memory card account, setting it as the account name.
2290 The timing seems to work, but this is probably
2291 not the best place to do this. See the TODO comment.
2292 * src/maemo/modest-main-window.c: (create_details_widget):
2293 * src/widgets/modest-folder-view.c: (text_cell_data):
2294 Use the tny account name instead of hardcoding a name.
2296 2007-05-30 Christian Kellner <ckellner@openismus.com>
2298 * src/modest-search.c: (modest_search):
2299 Correctly set part_search_func even if we have already parsed
2300 the query and thus a valid OgsTextSearcher object.
2302 2007-05-30 Christian Kellner <ckellner@openismus.com>
2305 Search and check for libogs.
2308 Incooparte the ogs build env.
2310 * src/modest-mime-part-search-stream.c:
2311 * src/modest-mime-part-search-stream.h:
2312 Removed since we do the real searching now in modest-search.c.
2314 * src/modest-search.c:
2315 * src/modest-search.h:
2316 Implement support for ogs. We use that if available and requested
2317 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2318 should now handle the corner case when the search term is spread
2319 across multiple reads.
2320 Also the logic in modest_search () was corrected to search all
2321 requested fields until one is found.
2323 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2325 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2327 * src/modest-init.h:
2328 * src/modest-init.c: Made modest_init_local_folders() take a
2329 path and be public so we can iniitialize maildir folders on
2332 * src/modest-local-folder-info.h:
2333 * src/modest-local-folder-info.c:
2334 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2336 * src/modest-tny-account.c:
2337 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2338 still means the standard local-folders path on the local volume.
2340 * src/modest-tny-account-store.c:
2341 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2342 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2343 all accounts when that happens.
2344 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2345 this too, so it shows up in the treeview.
2347 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/modest-maemo-global-settings-dialog.c:
2350 (current_connection):
2351 * src/widgets/modest-global-settings-dialog.c:
2352 (current_connection_default):
2353 Use the enum values instead of 0, 1 and -1,
2354 to make the code clearer.
2356 * src/modest-account-mgr-helpers.c:
2357 (modest_account_mgr_get_connection_specific_smtp): Make this code
2360 * src/modest-runtime.h:
2361 * src/modest-runtime.c:
2362 Added modest_runtime_remove_all_send_queues().
2363 * src/maemo/modest-main-window.c:
2364 (on_account_store_connecting_finished): Recreate the send queues,
2365 using the appropriate transport accounts for this new connection.
2366 Some futher adapting might be needed if the old send queues are not
2367 automatically stopped at this point.
2369 * src/modest-tny-account-store.c: (get_server_accounts):
2370 Create the connection-specific transport accounts, so that they can
2371 be found later by their ID.
2373 * src/modest-tny-account.h:
2374 * src/modest-tny-account.c:
2375 Added modest_tny_account_new_from_server_account_name().
2376 modest_tny_account_new_from_server_account(): Do not create the
2377 send queues here, because they will be
2378 recreated anyway when the connection changes for the first time.
2380 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2382 * src/modest-local-folder-info.h:
2383 * src/modest-local-folder-info.c:
2384 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2385 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2386 tbox_folder): Take a modest account name instead of a server TnyAccount,
2387 so we can have per-modest-account rather than per-transport-account
2389 We must make sure that we change or recreate the exisitng send queues
2390 when the connection changes for connection-specific transport accounts.
2392 * src/modest-tny-account-store.c:
2393 (create_per_account_local_outbox_folders): Create outboxed per modest
2394 account, not per transport account.
2396 * src/modest-tny-account.h:
2397 * src/modest-tny-account.c:
2398 (modest_tny_account_get_special_folder): For outboxes, get the
2399 parent modest account name. The account is ignored for other folders.
2400 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2401 modest account name rather than a server TnyAccount.
2403 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2405 * src/modest-tny-account.c:
2406 (modest_tny_account_new_from_server_account):
2407 Call modest_runtime_get_send_queue() immediately after creating transport
2408 accounts, so that they start trying to send email from the outbox as soon
2409 as possible at startup. This is probably what we want.
2411 * src/modest-mail-operation.c: (update_account_thread):
2412 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2413 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2414 * src/modest-tny-send-queue.h:
2415 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2416 (modest_ui_actions_on_send):
2417 Added comments about how sending works, though it needs some more work.
2419 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2421 * src/modest-tny-account.c:
2422 (modest_tny_account_get_special_folder): Add TODO because this fails when
2423 the network is busy.
2424 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2425 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2426 Do not try to show this window when there is no active account. The UI
2427 specs does not tell us what to do in this case.
2429 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2433 * src/maemo/Makefile.am:
2434 * src/widgets/Makefile.am: Some dist fixes.
2436 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2438 * src/maemo/modest-connection-specific-smtp-window.c:
2439 (on_button_edit): Make the code clearer, to prevent a double free.
2441 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2443 * src/maemo/modest-account-settings-dialog.c:
2444 (modest_account_settings_dialog_set_account_name),
2445 Check the connection-specific smtp servers checkbox if there are any.
2447 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2448 (modest_connection_specific_smtp_edit_window_init):
2449 Start with a suitable port number.
2451 * src/modest-account-mgr-helpers.h:
2452 * src/modest-account-mgr-helpers.c: Added
2453 modest_account_mgr_get_has_connection_specific_smtp().
2455 (modest_account_mgr_set_connection_specific_smtp),
2456 (modest_account_mgr_remove_connection_specific_smtp),
2457 (modest_account_mgr_get_has_connection_specific_smtp),
2458 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2459 connection-specific smtp server accounts in the account, rather than
2460 the server account conf dir.
2462 This fixes bug projects.maemo.org bug NB#58263 .
2464 * src/modest-tny-account-store.c:
2465 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2466 if there are no server accounts yet, to prevent an infinite loop when there
2467 are no accounts. Document that one must be called before the other.
2469 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2471 * src/modest-account-mgr-helpers.c:
2472 (modest_account_mgr_get_default_account): Make sure that at least
2473 one account is always the default, if there are any enabled accounts.
2474 This is just a sanity check that shouldn't be necessary.
2476 * src/modest-account-mgr-priv.c:
2477 (_modest_account_mgr_account_from_key): Unescape the conf key to
2478 get the real account name. For instance, this is an issue if a space
2479 was in the account name, which can happen because the account name
2480 is generated from the display name.
2481 (_modest_account_mgr_get_account_keyname): Always escape the
2483 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2484 Unescape the conf keys to get the real account names.
2486 For instance, previously the is-default radio button in the accounts
2487 list was not checked for any accounts at first. This fixes that,
2488 and might fix several similar bugs.
2490 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2492 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2493 Removed some debug printfs.
2495 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2497 Modest on-disk outbox directories are now here, for instance:
2498 $HOME/.modest/outboxes/<account-id-1>/outbox
2499 $HOME/.modest/outboxes/<account-id-2>/outbox
2501 $HOME/.modest/local-folders/outbox
2502 so we can have a separate outbox for each account.
2503 But they are shown as one outbox in the GtkTreeView, by using a
2504 TnyMergeFolder in a ModestTnySimpleFolderStore.
2507 * src/modest-tny-simple-folder-store.c:
2508 * src/modest-tny-simple-folder-store.h:
2509 Added ModestTnySimpleFolderStore, used to contain folders from
2510 other folder stores, such as other accounts.
2512 * src/modest-tny-outbox-account.h:
2513 * src/modest-tny-outbox-account.c:
2514 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2515 used for the per-account local outbox folders.
2517 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2518 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2519 only use this (internally) now for the non-outbox local folders.
2521 * src/modest-init.h:
2522 * src/modest-init.c: Added modest_init_one_local_folder(), for
2523 setting up the directory structure for each local folder.
2525 * src/modest-local-folder-info.c:
2526 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2527 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2529 * src/modest-local-folder-info.h:
2530 * src/modest-tny-account-store.c: (on_account_removed),
2531 (on_account_changed), (create_per_account_local_outbox_folders),
2532 (get_server_accounts), (modest_tny_account_store_get_accounts),
2533 (modest_tny_account_store_get_tny_account_by_account),
2534 (modest_tny_folder_store_is_virtual_local_folders):
2536 * src/modest-tny-account.h:
2537 * src/modest-tny-account.c:
2538 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2539 to create an on-disk per-account local outbox folder for each
2541 (create_per_account_local_outbox_folders): Create a local outbox folder
2542 for each transport account.
2543 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2544 for all local folders.
2546 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2547 instead of using g_object_get/set() directly. It is clearer.
2549 (modest_tny_folder_store_get_message_count),
2550 (modest_tny_folder_store_get_local_size
2551 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2552 because we now use these with non-acount folder stores.
2554 (modest_tny_account_get_special_folder),
2555 (modest_tny_account_new_from_server_account),
2556 (modest_tny_account_new_from_account):
2557 (recurse_folders): Adjust to the new outbox system.
2559 * src/modest-tny-folder.h:
2560 * src/modest-tny-folder.c:
2561 (modest_tny_folder_is_local_folder),
2562 (modest_tny_folder_get_local_folder_type),
2563 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2565 * src/widgets/modest-main-window.h:
2566 * src/maemo/modest-main-window.c: (create_details_widget),
2567 (modest_main_window_set_contents_style): Show details for any folder store,
2570 (modest_tny_folder_get_rules):
2571 Remove the const. C does not support constness enough for this.
2573 * src/modest-ui-actions.c:
2574 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2575 make all outboxes appear as one, in the usual local-folders tree node.
2577 (set_active_account_from_tny_account),
2578 (modest_ui_actions_on_folder_selection_changed):
2579 * src/widgets/modest-folder-view.c: (text_cell_data),
2580 (icon_cell_data), (filter_row),
2581 (add_account_folders_to_merged_folder),
2582 (add_account_folders_to_simple_folder_store), (),
2583 (get_cmp_rows_type_pos), (cmp_rows),
2584 (modest_folder_view_set_account_id_of_visible_server_account):
2585 Adjust to the new outbox system, using generic folder stores and folders
2586 in the GtkTreeModel.
2588 2007-05-23 Christian Kellner <ckellner@openismus.com>
2590 * src/modest-mail-operation.c:
2591 (modest_mail_operation_update_account):
2592 Use info->max_size instead of unintialized local var [small
2593 build fix]. (Added TODO to review that change since I don't
2596 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2598 * libmodest-dbus-client/libmodest-dbus-client.c:
2599 (libmodest_dbus_client_compose_mail): function added
2600 * src/dbus_api/modest-dbus-api.h:
2601 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2602 (on_compose_mail): Implementation of the SendAsMail functionality
2604 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2606 * src/modest-account-mgr.c:
2607 (modest_account_mgr_add_server_account): Set the secure-connection
2608 conf key for transport accounts as well as store accounts. I don't know
2609 why the if was there. For instance, this makes sure that we use SSL
2610 for the gmail preset from the easysetup wizard.
2612 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2614 * src/gnome/modest-main-window.c:
2615 (on_account_store_connecting_finished), (connect_signals):
2616 * src/maemo/modest-main-window.c:
2617 (on_account_store_connecting_finished), (connect_signals),
2618 (modest_main_window_new):
2619 Handle TnyAccountStore::connecting-finished instead of
2620 TnyDevice::connection-changed, because we cannot actually perform
2621 operations on accounts until TnyAccountStore has itself responded to
2622 the TnyDevice::connection-changed signal. This prevents a GError from
2624 Do not try to update at startup, because we (at least on scratchbox)
2625 already do an update at startup when the device goes online.
2626 This prevents a GError from tinymail.
2627 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2628 Added TODO about stopping simultaneous operations.
2630 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2632 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2633 * src/modest-mail-operation-queue.c:
2634 (modest_mail_operation_queue_remove):
2635 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2636 about where they happened.
2638 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2640 * src/modest-ui-actions.c:
2641 (modest_ui_actions_on_password_requested): Make sure that the remember
2642 output parameter is always TRUE.
2644 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2646 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2647 Show a OK/Cancel dialog if the error is a question, though we still do not
2648 know anything more about what we are asking the user.
2649 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2650 Fix an uninitialized variable (helper). This is a logic error, however.
2652 2007-05-21 Christian Kellner <ckellner@openismus.com>
2654 * src/modest-search.h:
2655 Correct bit shifting in the ModestSearchFlags enum.
2657 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2659 * src/modest-tny-account.c:
2660 (modest_tny_account_new_from_server_account): Do not use the lsub and
2661 check-all hard-coded IMAP options when using POP.
2663 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2665 * src/modest-tny-account.c:
2666 (modest_tny_account_new_from_server_account):
2667 Use NULL for the secure-auth method for POP when Password auth has been
2668 specified by the user, as we already do for IMAP. "auth=Login" causes
2669 an error from camel or the server.
2671 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2673 * src/maemo/modest-account-settings-dialog.c:
2674 (create_page_account_details),
2675 (modest_account_settings_dialog_set_account_name):
2676 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2677 for the leave-on-server checkbox, rathr than just the checkbox, when
2678 the protocol is not POP.
2680 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2682 * src/widgets/modest-account-view.c:
2683 * src/widgets/modest-account-view.h:
2684 Added modest_account_view_select_account() which will be useful later
2685 to asynchronously re-select the edited account.
2687 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2689 * src/maemo/modest-account-settings-dialog.c:
2690 (modest_account_settings_dialog_set_account_name):
2691 Automatically choose the port numbers based on the secure authentication
2692 methods, if they have not been chosen before.
2693 This fixes projects.maemo.org bug NB#56273 .
2695 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2697 * src/maemo/modest-main-window-ui.h:
2698 * src/modest-ui-actions.c:
2699 * src/modest-ui-actions.h:
2700 Connect the Tools/SMTP Servers menu item to
2701 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2702 SMTP servers dialog, as in the UI specification and saves changes when it
2703 is closed. This fixed projects.maemo.org bug NB#56305 .
2705 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2707 * src/maemo/modest-connection-specific-smtp-window.c:
2708 (modest_connection_specific_smtp_window_init):
2709 Use gtk_window_set_default_size() to make this window big enough, so
2710 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2712 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2714 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2715 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2716 (modest_connection_specific_smtp_edit_window_init),
2717 Do not try to connect to a combobox signal before the combobox exists.
2718 This fixes the cras in projects.maemo.org bug NB#56288 .
2719 (modest_connection_specific_smtp_edit_window_get_settings):
2720 Remove the server_account_name parameter which was being checked for NULL
2721 though it was not used.
2723 * src/maemo/modest-connection-specific-smtp-window.c:
2724 (modest_connection_specific_smtp_window_fill_with_connections),
2725 (on_button_edit), (modest_connection_specific_smtp_window_init):
2726 Correct the number of treemodel columns to prevent a warning.
2727 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2728 libconic does not work.
2730 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2732 * src/modest-tny-account.c:
2733 (modest_tny_account_new_from_server_account):
2734 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2735 SMTP when "None" was chosen by the user. However, with my SMTP server that
2736 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2739 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2741 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2742 to explain the memory management issue with the ID in the ModestPair.
2744 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2745 (add_sending_page), (modest_account_assistant_finalize):
2746 * src/gnome/modest-gnome-global-settings-dialog.c:
2747 (create_updating_page), (create_composing_page):
2748 * src/gnome/modest-msg-edit-window.c: (get_transports),
2749 (init_window), (modest_msg_edit_window_finalize),
2750 (modest_msg_edit_window_get_msg_data):
2751 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2752 * src/gnome/modest-transport-widget.c:
2753 (modest_transport_widget_finalize), (smtp_configuration):
2754 * src/maemo/modest-maemo-global-settings-dialog.c:
2755 (create_updating_page), (create_composing_page):
2756 * src/maemo/modest-msg-edit-window.c: (get_transports),
2757 (init_window), (modest_msg_edit_window_finalize),
2758 (modest_msg_edit_window_get_msg_data),
2759 (modest_msg_edit_window_free_msg_data):
2760 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2761 (modest_store_widget_finalize):
2762 * src/maemo/modest-transport-widget.c:
2763 (modest_transport_widget_finalize), (smtp_configuration):
2764 * src/modest-main.c: (send_mail):
2765 * src/widgets/modest-combo-box.h:
2766 * src/widgets/modest-global-settings-dialog-priv.h:
2767 * src/widgets/modest-global-settings-dialog.c:
2768 (modest_global_settings_dialog_finalize):
2769 * src/widgets/modest-msg-edit-window.h:
2770 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2771 as long as the combo box, to prevent use of freed memory for the ID.
2773 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2775 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2776 get_accounts(), to make this clearer. Do not check for the enabled gconf
2777 key, because we do not use this for server accounts (at least, not yet).
2778 This allows us to send email again.
2780 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2782 * src/maemo/modest-platform.c:
2783 (on_modest_conf_update_interval_changed), (modest_platform_init):
2784 Only respond to this particular key change. All these strcmp()s cannot be
2787 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2789 * src/maemo/modest-maemo-global-settings-dialog.c:
2790 (current_connection): Prevent a crash in scratchbox when
2791 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2792 * src/maemo/modest-platform.c:
2793 (on_modest_conf_update_interval_changed), (modest_platform_init):
2794 Get the update interval from gconf and reset it when the gconf key changes.
2796 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2798 * src/modest-protocol-info.c:
2799 * src/modest-protocol-info.h: Adde enum-specific get functions,
2800 instead of using a ModestProtocolType enum parameter.
2802 * src/gnome/modest-account-assistant.c:
2803 * src/gnome/modest-store-widget.c:
2804 * src/gnome/modest-store-widget.h:
2805 * src/gnome/modest-transport-widget.c:
2806 * src/gnome/modest-transport-widget.h:
2807 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2808 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2809 * src/maemo/easysetup/modest-easysetup-wizard.c:
2810 * src/maemo/modest-account-settings-dialog.c:
2811 * src/maemo/modest-account-settings-dialog.h:
2812 * src/maemo/modest-store-widget.c:
2813 * src/maemo/modest-store-widget.h:
2814 * src/maemo/modest-transport-widget.c:
2815 * src/maemo/modest-transport-widget.h:
2816 * src/modest-account-mgr-helpers.c:
2817 * src/modest-account-mgr-helpers.h:
2818 * src/modest-account-mgr.c:
2819 * src/modest-account-mgr.h:
2820 * src/modest-tny-account.c:
2821 * src/modest-tny-folder.c:
2822 * src/widgets/modest-account-view.c:
2823 * src/widgets/modest-retrieve-combo-box.c:
2824 * src/widgets/modest-retrieve-combo-box.h:
2825 * src/widgets/modest-secureauth-combo-box.c:
2826 * src/widgets/modest-serversecurity-combo-box.c:
2827 * src/widgets/modest-serversecurity-combo-box.h:
2828 * tests/check_account-mgr.c:
2829 Use the specific functions, and use the re-renamed enum values for GNOME too.
2831 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2833 * src/modest-pair.h:
2834 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2835 so we can get the second based on the first.
2837 * src/maemo/modest-account-settings-dialog.h:
2838 * src/maemo/modest-account-settings-dialog.c:
2839 Added get_supported_secure_authentication_methods(), though it is mostly
2840 commented-out for now until the necessary API is committed to tinymail.
2841 (modest_account_settings_dialog_set_account_name),
2842 (save_configuration): Request the supported authentication methods from the
2843 server, so we can choose a working method.
2845 * src/modest-tny-account-store.h:
2846 * src/modest-tny-account-store.c:
2847 (modest_tny_account_store_get_session): Rename from
2848 tny_account_store_get_session().
2850 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2852 * src/modest-protocol-info.h: Split the ModestProtocol enum
2853 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2854 There was no need to have these unrelated values in one enum.
2856 * src/: many files: Adapted to changed enum. This makes the code a bit
2857 clearer, and the compiler could catch some errors.
2859 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2861 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2862 Show the detailed internal camel error message when an error happens
2863 during the configuration, so that our testers can give us more clues.
2864 For instance, in projects.maemo.org bug NB#56910 .
2866 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2868 * src/modest-tny-account.c:
2869 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2870 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2872 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2874 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2875 * src/maemo/modest-account-settings-dialog.c:
2876 (modest_account_settings_dialog_set_account_name),
2877 (save_configuration): For the incoming secure authentication checkbox,
2878 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2879 the UI specification. PLAIN does not seem to be supported for most IMAP
2880 servers anyway, and I am not sure what it would mean.
2881 However, we probably need to discover which of the secure-authentication
2882 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2883 * src/modest-account-mgr-helpers.c:
2884 (modest_account_mgr_get_server_account_data):
2886 * src/modest-tny-account.c:
2887 (modest_tny_account_new_from_server_account):
2888 Use tny_account_set_mech() to set secure-authentication methods,
2889 with some special-casing for IMAP, based on my observations of how
2892 * src/modest-account-mgr-helpers.h:
2893 * src/modest-account-mgr.c:
2894 * src/modest-defs.h: Comment that the URI is only used for local folders.
2896 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2898 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2899 parameter const, just to be neat.
2900 * src/modest-text-utils.c: (modest_text_utils_inline):
2901 End g_strconcat() with NULL, as its documentation says. This is almost
2902 certainly the cause of my crash at startup on the device. Interestingly,
2903 valgrind doesn't tell us about these errors.
2905 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2907 * scripts/build-packages: Added more precise comments about how to use
2908 this script, though I still get this error:
2909 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2910 error building tinymail
2912 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2914 * src/maemo/modest-main-window.c: (on_account_update):
2915 Very slight cleanup, hoping to make it simpler to discover what causes
2916 a crash here sometimes.
2918 * src/modest-tny-account.c:
2919 (modest_tny_account_new_from_server_account): Set the port. Added
2920 comments about the options and a TODO comment because I need to find out
2921 how to specify the secure authentication method.
2923 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2925 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2926 changed CFlags paths form modest to libmodest
2928 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2930 * src/modest-account-mgr-helpers.c:
2931 (modest_account_mgr_get_server_account_data),
2932 (modest_account_mgr_free_server_account_data):
2933 * src/modest-account-mgr-helpers.h:
2934 * src/modest-account-mgr.c:
2935 (modest_account_mgr_add_server_account):
2936 * src/modest-defs.h:
2937 * src/modest-tny-account.c:
2938 (modest_tny_account_new_from_server_account):
2939 Determine the options for tny_camel_account_add_option() here,
2940 based on the settings, rather than storing them directly in gconf.
2942 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2944 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2945 Show a more friendly error dialog now that we expect (from the tinymail
2946 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2948 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2950 * src/maemo/modest-main-window.c: (on_account_update): Check that
2951 account_name is not NULL, to prevent a crash at startup that I am
2952 seeing on the N800. I do wonder why it is NULL.
2954 * src/maemo/easysetup/modest-easysetup-wizard.c:
2955 (create_page_user_details):
2956 * src/maemo/modest-account-settings-dialog.c:
2957 (create_page_user_details), (create_page_outgoing):
2958 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2959 (modest_connection_specific_smtp_edit_window_init):
2960 * src/modest-ui-actions.c:
2961 (modest_ui_actions_on_password_requested):
2962 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2963 might do something useful with the on-screen keyboard.
2965 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/modest-main-window.c: (on_account_update):
2968 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2969 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2971 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2973 * src/modest-tny-account-store.c: (on_account_changed):
2974 Correct the signature of this signal handler.
2976 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2978 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2979 Show a HildonNote instead of a GtkDialog for Maemo.
2981 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2983 * src/widgets/modest-account-view.h:
2984 * src/widgets/modest-account-view.c: (on_account_changed),
2985 (on_account_removed). Added a boolean flag, set/unset by
2986 modest_account_view_block_conf_updates(),
2987 modest_account_view_unblock_conf_updates() to prevent unnecessary
2988 updates, but this is not very useful because the gconf notifications are
2989 so delays (maybe only on Maemo Bora).
2990 So auto-updating is turned off, and these functions do an explicit
2991 update when necessary.
2992 However, something else is still doing too much work when adding/removing
2993 accounts, probably in another part of the application.
2995 * src/maemo/modest-account-view-window.c:
2996 (on_delete_button_clicked), (on_edit_button_clicked),
2997 (on_new_button_clicked): Use the new functions.
2999 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3001 * src/modest-account-mgr-helpers.c:
3002 (modest_account_mgr_set_first_account_as_default):
3003 Sort the list of names alphabetically-by-title, so we choose the first one
3005 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3006 alphabetically by the title.
3008 This fixes projects.maemo.org bug NB#56418 .
3010 * src/modest-account-mgr-priv.c:
3011 (_modest_account_mgr_account_from_key):
3012 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3013 avoid a valgrind error, and possible random behaviour.
3015 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3017 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3018 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3019 tinymail documentation to say that this can be expected.
3020 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3021 pretty, and should not happen, but I would prefer to know when it does.
3023 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3025 * configure.ac: When using the older hildon version, probably on Bora,
3026 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3028 * src/widgets/modest-attachment-view.c:
3029 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3032 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3034 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3035 Implemented the prototype. Can be tested with
3036 tests/dbus_api/test_open_message:
3038 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3040 * src/modest-tny-account-store.c:
3041 (modest_tny_account_store_instance_init), (get_password):
3042 * src/modest-ui-actions.c:
3043 (modest_ui_actions_on_password_requested):
3044 Do not store the password in gconf, because this function is called
3045 for non-remembered passwords. Actually use the cached (in the hash map)
3046 password instead of releasing it.
3047 The password will now not be remembered if it is asked via the protected
3048 password dialog, as per the UI spec.
3050 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3052 * src/modest-defs.h:
3053 * src/modest-account-mgr-helpers.h:
3054 * src/modest-account-mgr-helpers.c:
3055 Added modest_server_account_get_username_has_succeeded(),
3056 modest_server_account_set_username_has_succeeded().
3057 (modest_server_account_set_username),
3058 Reset the has-succeeded flag if the username changes.
3060 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3061 * src/maemo/modest-connection-specific-smtp-window.c:
3062 (modest_connection_specific_smtp_window_save_server_accounts):
3063 Use modest_server_account_set_username() instead of using
3064 modest_conf_set_string() directly, so that the has-succeeded flag is always
3067 * src/modest-ui-actions.c:
3068 (modest_ui_actions_on_password_requested): Dim the username entry if
3069 the username has ever worked, as per the UI spec.
3071 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3073 * src/modest-tny-account-store.c: (get_password):
3074 * src/modest-ui-actions.c:
3075 (modest_ui_actions_on_password_requested):
3076 Allow the username to be changed too, though there is more work to
3077 be done on exactly how this behaves.
3079 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3081 * src/modest-account-mgr-helpers.h:
3082 * src/modest-account-mgr-helpers.c:
3083 Added modest_account_mgr_get_display_name(),
3084 modest_server_account_get_username(),
3085 modest_server_account_set_username(),
3086 modest_server_account_set_password(),
3087 modest_server_account_get_hostname() functions so we do not need to
3088 use the conf API directly.
3090 * src/maemo/modest-main-window.c: (connect_signals):
3091 Actually connect ot the ModestAccountStore::request-password signal,
3092 so that we show the dialog when the password is requested by Tinymail,
3093 for isntance if it is empty.
3095 * src/modest-marshal.list:
3096 * src/modest-tny-account-store.c:
3097 (modest_tny_account_store_class_init), (get_password),
3098 (modest_tny_account_store_alert):
3099 * src/modest-tny-account-store.h:
3100 * src/modest-ui-actions.h:
3101 * src/modest-ui-actions.c:
3102 (modest_ui_actions_on_password_requested):
3103 Change the signal parameters, so it is obvious that we are providing
3104 the non human-readable server name, and receiving both the username
3105 and password, though changing of the username is not yet implemented.
3106 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3107 for the GNOME version.
3109 This should fix the projects.maemo.org bug NB#56209, though it does not
3110 work on Bora, because the gconf_client_get() for the password fails
3111 immediately after we save it with gconf_client_set().
3113 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3116 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3117 caused an undefined symbol error:
3118 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3120 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3122 * src/modest-tny-account-store.c:
3123 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3124 using a GError instead of a string message, so we can translate it in
3127 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3129 * src/maemo/modest-address-book.c:
3130 (modest_address_book_check_names):
3131 * src/maemo/modest-msg-view-window.c:
3132 (modest_msg_view_window_clipboard_owner_change):
3133 * src/modest-init.c: (modest_init_init_ui):
3134 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3135 (update_folders_cb), (modest_mail_operation_update_account):
3136 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3137 (modest_ui_actions_on_msg_attachment_clicked),
3138 (modest_ui_actions_on_msg_recpt_activated):
3139 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3140 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3141 (modest_msg_view_search_next):
3142 * src/widgets/modest-recpt-editor.c:
3143 (modest_recpt_editor_on_button_release_event),
3144 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3145 g_message(). At this point we should only be seeing interesting errors on
3146 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3148 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3150 (modest_wizard_dialog_force_title_update):
3151 * src/maemo/easysetup/modest-wizard-dialog.h:
3152 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3153 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3154 can update the title when appropriate. Otherwise the title is wrong if the
3155 pages are added after adding the notebook to the dialog.
3156 This must be a problem in HildonWizardDialog too.
3157 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3159 * src/maemo/easysetup/modest-easysetup-wizard.c:
3160 (create_subsequent_customsetup_pages),
3161 (create_subsequent_easysetup_pages):
3162 Call modest_wizard_dialog_force_title_update() so that the title is
3163 correct even with GTK+ < 2.10.
3164 This fixes projects.maemo.org bug NB#56145 .
3166 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3168 * src/maemo/modest-platform.c:
3169 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3170 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3173 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3175 * src/widgets/modest-window.h:
3176 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3177 and modest_window_save_state(), which invokes it.
3179 * src/widgets/modest-window-mgr.h:
3180 * src/widgets/modest-window-mgr.c:
3181 Added modest_window_mgr_save_state_for_all_windows(), which calls
3182 the save_state vfunc on all registered windows, if implemented.
3184 * src/gnome/modest-msg-edit-window.c:
3185 * src/gnome/modest-msg-view-window.c:
3186 * src/maemo/modest-msg-edit-window.c:
3187 * src/maemo/modest-msg-view-window.c:
3188 * src/maemo/modest-main-window.c:
3189 Specify the existing save_settings functions as implementations of
3190 ModestWindow::save_state_func().
3192 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3193 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3194 enabling hibernation, for instance.
3196 We may need to do the same thing for restoring settings.
3199 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3201 * src/widgets/modest-window-mgr.c:
3202 * src/widgets/modest-window-mgr.h:
3203 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3204 modest_window_mgr_get_hibernation_is_prevented().
3206 * src/maemo/modest-main-window.c:
3207 (on_hildon_program_is_topmost_notify): Prevent hibernation
3208 (possible when the application goes to the background in the WM),
3209 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3211 * src/maemo/easysetup/modest-easysetup-wizard.c:
3212 (modest_easysetup_wizard_dialog_init):
3213 * src/maemo/modest-account-settings-dialog.c:
3214 (modest_account_settings_dialog_init):
3215 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3216 (modest_connection_specific_smtp_edit_window_init):
3217 * src/maemo/modest-connection-specific-smtp-window.c:
3218 (modest_connection_specific_smtp_window_init):
3219 * src/maemo/modest-signature-editor-dialog.c:
3220 (modest_signature_editor_dialog_init):
3221 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3222 prevent hibernation while any of these account settings dialogs are open.
3224 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3226 * src/maemo/Makefile.am:
3227 * src/maemo/modest-osso-state-saving.c:
3228 * src/maemo/modest-osso-state-saving.h: Added
3229 modest_osso_load_state() and modest_osso_save_state() though they do
3230 nothing now. They should iterate through all the open windows and load/save
3232 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3233 save state when closing.
3235 * src/maemo/modest-main-window.c:
3236 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3237 Add a notification handler for the HildonProgram::is-topmost property,
3238 so we can allow hibernation when the application goes into the background.
3239 But we still need to detect when the accounts setup windows are open so
3240 we can stop hibernation when they are open.
3241 To do this, I also added the main window the HildonProgram. This might have
3242 other side-effects/benefits, and should maybe be done for other windows.
3244 * src/maemo/modest-osso-autosave-callbacks.h:
3245 * src/maemo/modest-osso-autosave-callbacks.c:
3246 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3247 though it does not do anything yet, and we might never need this to do
3248 anything. For instance, we already save drafts.
3250 * src/maemo/modest-platform.c: (modest_platform_init):
3251 Specify the libosso auto-save callback.
3253 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3255 * src/maemo/modest-platform.c:
3256 (modest_platform_set_update_interval):
3257 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3258 aparently stays valid between application instances, so we can use this
3259 to remove and reset it later. According to a maemo-developers email from
3262 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3264 * configure.ac: Depend on libalarm for Maemo.
3266 * src/dbus_api/modest-dbus-api.h:
3267 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3268 (on_send_receive), (modest_dbus_req_handler):
3269 Handle a SEND_RECEIVE D-Bus method.
3271 * libmodest-dbus-client/libmodest-dbus-client.c:
3272 (libmodest_dbus_client_send_and_receive):
3273 * libmodest-dbus-client/libmodest-dbus-client.h:
3274 Add C convenience functions for calling the new D-Bus method.
3276 * src/modest-platform.h:
3277 * src/gnome/modest-platform.c:
3278 * src/maemo/modest-platform.c:
3279 Added modest_platform_set_update_interval(), which uses the
3280 alarmd API on Maemo.
3281 (modest_platform_init),
3282 Call modest_platform_set_update_interval(), using a hard-coded
3283 interval for now (until the global settings dialog is implemented),
3284 though I am not sure that this makes sense yet.
3286 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3288 * src/dbus_api/modest-dbus-callbacks.c:
3289 (modest_osso_cb_hw_state_handler):
3290 * src/dbus_api/modest-dbus-callbacks.h:
3291 * src/maemo/modest-platform.c: (modest_platform_init):
3292 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3293 in case this has some effect on the ability for Maemo to ping the
3296 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3298 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3299 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3300 warning. It is probably a logic error, but I need to fix the build.
3302 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3304 * src/modest-account-mgr.h:
3305 * src/modest-account-mgr.c:
3306 (modest_account_mgr_account_names): Add a gboolean enabled_only
3307 parameter, so we can get lists of onlt the enabled accounts.
3309 (modest_account_mgr_add_account),,
3310 (modest_account_mgr_account_with_display_name_exists):
3311 * src/maemo/modest-msg-edit-window.c: (get_transports):
3312 * src/modest-account-mgr-helpers.c:
3313 (modest_account_mgr_set_first_account_as_default):
3314 * src/modest-init.c: (init_default_account_maybe):
3315 * src/modest-tny-account-store.c: (get_accounts):
3316 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3317 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3318 * tests/check_account-mgr.c: (START_TEST):
3319 Provide the extra parameter, as appropriate.
3321 * src/widgets/modest-account-view.c: (update_account_view):
3322 Do not show disabled accounts (meaning that there is no way to
3323 enable/disable accounts in the UI (the feature is not in our UI
3324 specification), so we can use this internally only to mark unfinished
3325 or temporary account data.
3327 * src/maemo/easysetup/modest-easysetup-wizard.c:
3328 (create_account): Add boolean enable parameter, so we can specify FALSE
3329 to create the temporary account.
3330 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3331 (on_before_next): When finishing, when there is a temporary account, just
3333 Also, use a timeout to delay the showing of the dialog until gconf is likely
3334 to return correct information, due to a maemo gconf bug that is fixed in
3335 osso 1.1, but not yet in Bora.
3336 However, the dialog stays on screen after it is destroyed.
3338 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3339 for invalid data when cancelling. Use a hildon note instead of a dialog
3340 to complain about invalid data. Do not show the account-saved note if the
3341 account is disabled (a temporary account that will not really be saved for use
3344 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3346 * src/modest-account-mgr-helpers.h:
3347 * src/modest-account-mgr-helpers.c:
3348 Added modest_account_mgr_unset_default_account(),
3349 Added modest_account_mgr_set_first_account_as_default().
3351 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3352 If it was the default account, unset the default account name.
3354 * src/maemo/modest-account-view-window.c:
3355 (on_delete_button_clicked): If it was the default account,
3356 set the first remaining account as the default instead.
3358 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3359 a NULL account or a NULL default account, to prevent a crash. This should
3360 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3363 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3365 * src/widgets/modest-recpt-editor.c:
3366 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3367 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3368 TODO comment for this. This fixes the build.
3370 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3371 be the best place for it. This will in future update all auto-update accounts,
3372 rather than just the current/default account, when that gconf key exists.
3373 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3374 if there are no accounts, before calling do_send_receive().
3375 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3377 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3378 * src/maemo/modest-main-window-ui.h:
3379 * src/maemo/modest-main-window.c: (on_connection_changed),
3380 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3381 directly, becaue the signal handler does more.
3383 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-account-mgr-helpers.c:
3386 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3387 for the case that the account does not exist.
3389 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3390 (equivalent to the modest account name) rather than the tinymail account name
3391 (equivalent to the modest account title - human readable) to get the account data.
3392 Check for null account data to prevent the crash, and add a TODO comment saying that
3393 this needs fixing because it is using the server account name instead of the account name.
3395 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3397 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3398 * src/maemo/modest-account-settings-dialog.c: (show_error),
3400 Use hildon_note_new_information() for informative and error messages,
3401 which seems to be expected for Maemo applications (no documentation that I know of
3402 says this). I am surprised that there is no distinction between info and error
3405 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3407 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3408 it is easy to find where this is used.
3410 * src/maemo/easysetup/modest-easysetup-wizard.c:
3411 (create_page_welcome), (create_page_account_details),
3412 (create_page_user_details), (create_page_complete_easysetup),
3413 (create_page_custom_incoming), (create_page_custom_outgoing),
3414 (create_page_complete_custom):
3415 * src/maemo/modest-account-settings-dialog.c:
3416 (create_page_account_details), (create_page_user_details),
3417 (create_page_incoming), (create_page_outgoing):
3418 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3419 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3420 (modest_connection_specific_smtp_edit_window_init):
3421 * src/maemo/modest-connection-specific-smtp-window.c:
3422 (modest_connection_specific_smtp_window_init):
3423 * src/maemo/modest-signature-editor-dialog.c:
3424 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3425 and scrolling policy as per the Email Application Layout Guide, if I have
3428 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3430 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3431 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3432 which were empty, because these vfuncs have been removed from TnyAccountStore.
3433 This fixes the build.
3435 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3437 * src/maemo/modest-main-window.c:
3438 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3439 showing/hiding it. Added TODO because it probably should not be NULL.
3440 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3441 because unnecessary g_warnings() make degugging difficult.
3443 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3445 * src/maemo/modest-msg-edit-window.c:
3446 (modest_msg_edit_window_select_color),
3447 (modest_msg_edit_window_select_background_color): 2 const corrections and
3448 moving 2 #endifs before closing brackets, to fix the build.
3450 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3452 * src/maemo/easysetup/modest-easysetup-wizard.h:
3453 * src/maemo/easysetup/modest-easysetup-wizard.c:
3454 (modest_easysetup_wizard_dialog_finalize),
3455 (on_button_edit_advanced_settings), (create_page_complete_custom),
3456 (on_response), (create_account):
3457 Implement the Advanced Settings edit button, by saving the account information,
3458 for the Advanded Settings dialog to use directly from gconf, and removing it
3459 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3460 Bug #5533 in the projects.maemo.org bugzilla.
3462 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3464 * src/maemo/modest-msg-view-window.c:
3465 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3466 when opening a message window.
3468 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3470 * src/maemo/easysetup/modest-easysetup-wizard.c:
3471 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3474 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3475 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3476 gconf settings. I probably added more checks than necessary, but that is safer.
3478 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3479 variable to fix the build, but this seems to be used when it is still NULL.
3481 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3483 * src/modest-platform.h:
3484 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3485 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3486 * src/modest-main.c: Implement this function so we can avoid using
3487 maemo-specific API from cross-platform code.
3489 * src/modest-tny-account-store.c:
3490 (get_smtp_specific_transport_account_for_open_connection):
3491 * src/modest-ui-actions.c: (check_for_connection),
3492 (modest_ui_actions_on_item_not_found):
3493 Use modest_platform_connect_and_wait() and put #idefs around other
3494 maemo-specific code, because only maemo currently has a way to
3495 identify connection names.
3497 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3499 * src/modest-tny-account-store.h:
3500 * src/modest-tny-account-store.c:
3501 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3502 the connection-specific SMTP server settings in the configuration.
3504 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3506 * src/maemo/modest-main-window.c: (on_connection_changed),
3508 * src/modest-main.c: (main), (start_ui), (send_mail):
3509 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3510 that is what is intended.
3512 * src/modest-ui-actions.c: (action_send), (action_receive),
3513 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3514 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3515 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3516 SMTP server is used when it is specified.
3518 (modest_ui_actions_on_send_receive):
3519 Check that a connection is open before proceeding.
3520 Receive and then send, instead of vice-versa, as per the specification.
3522 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3524 * src/modest-mail-operation.c:
3525 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3526 though I guess it should be something other than NULL.
3528 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3530 * src/maemo/easysetup/modest-easysetup-wizard.c:
3531 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3532 combo twice, to avoid an g_warning and to make it visible again.
3533 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3534 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3535 (already intended) dereference when detaching, because we then recreate the menu.
3536 But I am not sure why the warning was happening, and it is possible that this is a memory
3539 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3541 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3542 and uri_parse_mailto() utility functions.
3543 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3545 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3547 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3549 * src/dbus_api/modest-dbus-api.h:
3550 * src/dbus_api/modest-dbus-callbacks.c:
3551 Use an idle callback to execute the modest code in the application's own thread.
3552 Remove the helloworld example method.
3553 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3554 parsed, and the open-message method is not implemented because this is not yet implemented in
3556 * libmodest-dbus-client/libmodest-dbus-client.c:
3557 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3558 (libmodest_dbus_client_open_message):
3559 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3561 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3562 body without crashing.
3564 * tests/dbus_api/Makefile.am:
3565 * tests/dbus_api/test_mail_to.c:
3566 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3568 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3570 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3571 Added file to fix the build. Sorry.
3573 * src/dbus_api/Makefile.am:
3574 * src/dbus_api/modest-dbus-api.h:
3575 * src/dbus_api/modest-dbus-callbacks.h:
3576 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3577 (modest_dbus_req_handler):
3578 Put constants in a separate header so it can be reused by the
3579 client library, without duplication
3581 * libmodest-dbus-client/Makefile.am:
3582 * libmodest-dbus-client/libmodest-dbus-client.c:
3583 (libmodest_dbus_client_call_helloworld),
3584 (libmodfest_dbus_client_send_mail),
3585 (libmodfest_dbus_client_mailto),
3586 (libmodfest_dbus_client_open_message):
3587 * libmodest-dbus-client/libmodest-dbus-client.h:
3588 (Partly) Implement a send_mail D-Bus method.
3590 * tests/dbus_api/Makefile.am:
3591 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3592 the send_email D-Bus method.
3594 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3598 * libmodest-dbus-client/Makefile.am:
3599 * libmodest-dbus-client/libmodest-dbus-client.c:
3600 * libmodest-dbus-client/libmodest-dbus-client.h:
3601 * tests/dbus_api/Makefile.am:
3602 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3603 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3605 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3607 * src/maemo/easysetup/modest-easysetup-wizard.c:
3608 (create_page_account_details):
3609 * src/maemo/modest-account-settings-dialog.c:
3610 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3611 widgets, because this might not be the default in future versions of the Maemo GTK+.
3612 However, I can not not get capitalization to work even in a simple test case.
3614 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3616 * src/maemo/easysetup/modest-easysetup-wizard.c:
3617 (create_page_custom_incoming), (create_page_custom_outgoing):
3618 * src/maemo/modest-account-settings-dialog.c:
3619 (create_page_account_details), (create_page_incoming),
3620 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3621 instead of using gtk_check_button_with_label(), so they are aligned like the other
3622 widgets, as per the UI spec.
3624 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3626 * src/maemo/easysetup/modest-easysetup-wizard.c:
3627 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3628 * src/widgets/modest-validating-entry.c:
3629 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3630 Modest prefix instead of an EasySetup prefix.
3632 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3634 * src/widgets/modest-validating-entry.h:
3635 * src/widgets/modest-validating-entry.c: (on_insert_text),
3636 Added easysetup_validating_entry_set_max_func(), used to set a callback
3637 to call when the max number of characters is reached. GtkEntry has a max-length
3638 already but is silent about it.
3640 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3641 (create_page_account_details), (create_page_user_details),
3643 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3644 (create_page_account_details), (create_page_user_details),
3645 (create_page_outgoing):
3646 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3647 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3648 the UI spec, when the user tries to enter more than the max number of characters.
3650 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3652 * src/maemo/easysetup/modest-easysetup-wizard.c:
3653 (create_page_user_details), (create_page_custom_incoming),
3654 (create_page_custom_outgoing):
3655 * src/maemo/modest-account-settings-dialog.c:
3656 (create_page_user_details), (create_page_incoming),
3657 (create_page_outgoing):
3658 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3659 (modest_connection_specific_smtp_edit_window_init):
3660 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3661 not appropriate. Bad Maemo-specific defaults!.
3663 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3665 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3666 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3667 (modest_signature_editor_dialog_set_settings):
3668 Disable the label and textview when the checkbox is disabled, and use the
3669 specified (UI spec) default signature text.
3671 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3673 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3674 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3676 * src/modest-defs.h:
3677 * src/modest-account-mgr-helpers.h:
3678 * src/modest-account-mgr-helpers.c:
3679 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3681 * src/maemo/Makefile.am:
3682 * src/maemo/modest-signature-editor-dialog.c:
3683 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3686 * src/maemo/modest-account-settings-dialog.h:
3687 * src/maemo/modest-account-settings-dialog.c:
3688 (modest_account_settings_dialog_finalize), (on_button_signature),
3689 (save_configuration): Use the new dialog when the Edit button is pressed, and
3690 save the changes if necessary, as per the UI spec.
3692 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3694 * src/maemo/Makefile.am:
3695 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3696 based on maemo-develoers email from Dirk.
3698 * src/maemo/easysetup/modest-easysetup-wizard.c:
3699 (create_page_welcome), (create_page_account_details),
3700 (create_page_user_details), (create_page_complete_easysetup),
3701 (create_page_custom_incoming), (create_page_custom_outgoing),
3702 (create_page_complete_custom),
3703 (modest_easysetup_wizard_dialog_init):
3704 * src/maemo/modest-account-settings-dialog.c:
3705 (create_page_account_details), (create_page_user_details),
3706 (create_page_incoming), (create_page_outgoing),
3707 (modest_account_settings_dialog_init):
3708 * src/maemo/modest-connection-specific-smtp-window.c:
3709 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3711 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3713 * src/maemo/easysetup/modest-easysetup-wizard.c:
3714 (create_page_account_details), (create_page_custom_outgoing),
3715 (create_page_complete_custom):
3716 * src/maemo/modest-account-settings-dialog.c:
3717 (create_page_user_details), (create_page_incoming),
3718 (create_page_outgoing):
3719 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3720 (modest_connection_specific_smtp_edit_window_init):
3721 Use the correct (UI spec) port min/max, and use horizontal separators,
3724 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3726 * src/maemo/easysetup/modest-easysetup-wizard.c:
3727 (set_default_custom_servernames):
3728 * src/maemo/modest-account-settings-dialog.c:
3729 (create_page_incoming), (on_combo_outgoing_security_changed),
3730 (on_combo_incoming_security_changed), (create_page_outgoing),
3731 (modest_account_settings_dialog_set_account_name),
3732 (save_configuration):
3733 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3734 (on_combo_security_changed),
3735 (modest_connection_specific_smtp_edit_window_init),
3736 (modest_connection_specific_smtp_edit_window_set_connection),
3737 (modest_connection_specific_smtp_edit_window_get_settings):
3738 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3741 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3744 * src/maemo/easysetup/modest-easysetup-wizard.c:
3745 (create_page_custom_outgoing), (create_page_complete_custom):
3746 * src/maemo/modest-account-settings-dialog.c:
3747 (create_page_user_details), (create_page_outgoing):
3748 * src/maemo/modest-account-view-window.c: (button_box_new):
3749 Use changed logical IDs as per the most recent UI spec:
3750 mcen_bd_emailsetup_edit -> mcen_bd_edit
3751 mcen_bd_emailsetup_delete -> mcen_bd_delete
3752 mcen_bd_emailsetup_close -> mcen_bd_close
3754 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3758 * src/dbus_api/Makefile.am:
3759 * src/dbus_api/modest-dbus-callbacks.c:
3760 * src/dbus_api/modest-dbus-callbacks.h:
3761 * src/maemo/modest-platform.c: (modest_platform_init):
3762 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3764 * tests/Makefile.am:
3765 * tests/dbus_api/Makefile.am:
3766 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3768 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3770 * src/maemo/modest-account-settings-dialog.c:
3771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3772 Removed unnecessary includes.
3774 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3776 * src/maemo/easysetup/modest-easysetup-wizard.c:
3777 * src/maemo/modest-account-settings-dialog.c:
3778 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3779 * src/widgets/Makefile.am:
3780 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3781 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3782 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3783 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3784 * src/widgets/modest-secureauth-combo-box.c:
3785 * src/widgets/modest-secureauth-combo-box.h:
3786 * src/widgets/modest-serversecurity-combo-box.c:
3787 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3788 made the GObject names more consistent with the rest of the Modest code.
3790 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3792 * src/maemo/easysetup/Makefile.am:
3793 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3794 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3795 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3796 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3797 * src/maemo/easysetup/modest-easysetup-wizard.c:
3798 * src/maemo/easysetup/modest-validating-entry.c:
3799 * src/maemo/easysetup/modest-validating-entry.h:
3800 * src/maemo/modest-account-settings-dialog.c:
3801 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3802 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3803 widgets/ because they are used outside of easysetup too. After checking in,
3804 svn will allow me to rename them too.
3806 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3808 * src/gnome/modest-msg-edit-window.c:
3809 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3810 linker error, to fix the build on the GNOME platform.
3811 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3812 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3813 ifdefed out to avoid a warning.
3815 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3817 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3818 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3819 some alternative for GTK+ 2.6.
3821 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3823 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3825 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3826 specified for EmailAccountsDialog in UI spec.
3828 * src/maemo/easysetup/modest-easysetup-wizard.c:
3829 * src/maemo/easysetup/modest-easysetup-wizard.h:
3830 * src/maemo/modest-account-settings-dialog.c:
3831 * src/maemo/modest-account-settings-dialog.h:
3832 Reuse a member window widget for the connection-specific SMTP server accounts,
3833 so we can tell it to create/save the accounts only if we actually save changes.
3835 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3836 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3837 (modest_connection_specific_smtp_edit_window_get_settings):
3838 Return a struct instance for temporarily remembering the entered data.
3840 * src/maemo/modest-connection-specific-smtp-window.h:
3841 * src/maemo/modest-connection-specific-smtp-window.c:
3842 (modest_connection_specific_smtp_window_finalize),
3843 (modest_connection_specific_smtp_window_fill_with_connections),
3845 (modest_connection_specific_smtp_window_save_server_accounts),
3846 (update_model_server_names): Do not actually save data until asked,
3847 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3849 (on_selection_changed),
3850 (modest_connection_specific_smtp_window_init): Disable the edit
3851 button when nothing is selected.
3853 * src/modest-account-mgr-helpers.c:
3854 * src/modest-account-mgr-helpers.h:
3855 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3858 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3860 * src/modest-account-mgr-helpers.h:
3861 * src/modest-account-mgr-helpers.c:
3862 (modest_account_mgr_get_unused_account_name),
3863 (modest_account_mgr_get_unused_account_display_name): Added these
3864 utility functions, to avoid code duplication.
3866 * src/maemo/easysetup/modest-easysetup-wizard.c:
3867 (create_page_account_details), (create_account):
3868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3869 (on_combo_security_changed),
3870 (modest_connection_specific_smtp_edit_window_init),
3871 (modest_connection_specific_smtp_edit_window_save_settings):
3872 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3873 * src/maemo/modest-connection-specific-smtp-window.c:
3874 (modest_connection_specific_smtp_window_finalize),
3875 (modest_connection_specific_smtp_window_fill_with_connections),
3876 (on_button_edit), (modest_connection_specific_smtp_window_init):
3877 * src/maemo/modest-connection-specific-smtp-window.h:
3878 Implementing saving of connection-specific server accounts.
3880 But I need to refactor this so we can save the data for each
3881 possible connection-specific account and only actually create the server accounts
3882 when the easysetup finished, or the OK button is pressed on the account settings
3885 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3887 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3888 (on_combo_security_changed):
3889 (modest_connection_specific_smtp_edit_window_init):
3890 Auto-fill the port number as in the account settings.
3892 (modest_connection_specific_smtp_edit_window_set_connection):
3893 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3894 * src/maemo/modest-connection-specific-smtp-window.c:
3895 (fill_with_connections), (on_button_edit),
3896 (modest_connection_specific_smtp_window_init):
3897 Turn the edit window into a dialog to simplify the code, and
3898 set a WM hint as in a GtkDialog, because only a popup can be on top of
3899 another window in Maemo, and popups usually have no WM decoration.
3901 * src/modest-defs.h:
3902 * src/modest-account-mgr-helpers.c:
3903 (modest_account_mgr_set_connection_specific_smtp),
3904 (modest_account_mgr_remove_connection_specific_smtp),
3905 (modest_account_mgr_get_connection_specific_smtp):
3906 * src/modest-account-mgr-helpers.h: Some functions to write the
3907 connection-specific SMTP server information. Not yet used.
3910 * src/widgets/modest-folder-view.c: (text_cell_data):
3911 Fix a warning about an uninitialized variable.
3912 (on_configuration_key_changed): Put an #ifdef around the use
3913 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3915 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3917 * src/maemo/modest-account-settings-dialog.h:
3918 * src/maemo/modest-account-settings-dialog.c:
3919 Added connect_for_modified() utility function to mark the new modified boolean.
3921 (create_page_account_details), (create_page_user_details),
3922 (create_page_incoming), (create_page_outgoing), (on_response),
3923 (modest_account_settings_dialog_init),
3924 (modest_account_settings_dialog_set_account_name):
3925 Only warn about unsaved changes when there are actually unsaved changes.
3927 * src/modest-account-mgr-helpers.c:
3928 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3929 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3930 to get the data from there in future.
3932 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3934 * src/modest-defs.h:
3936 * src/modest-account-mgr-helpers.h:
3937 * src/modest-account-mgr-helpers.c:
3938 Store the security account setting in a single conf key instead of using
3939 the options list, so that the list is left for just the to-be-removed camel hack,
3940 and because gconf_client_set_list() is failing for some reason.
3942 * src/modest-account-mgr.c:
3943 (modest_account_mgr_add_server_account):
3944 * src/maemo/modest-account-settings-dialog.c:
3945 (modest_account_settings_dialog_set_account_name),
3946 (save_configuration): Use the renamed functions.
3949 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3951 * src/widgets/Makefile.am:
3952 * src/widgets/modest-limit-retrieve-combo-box.c:
3953 * src/widgets/modest-limit-retrieve-combo-box.h:
3954 * src/widgets/modest-retrieve-combo-box.c:
3955 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3956 the account settings dialog.
3958 * src/modest-defs.h:
3959 * src/modest-account-mgr-helpers.h:
3960 * src/modest-account-mgr-helpers.c:
3961 (modest_server_account_get_option_secure_auth),
3962 (modest_server_account_set_option_secure_auth):
3963 * src/modest-account-mgr.c:
3964 (modest_account_mgr_add_server_account):
3965 Use the existing AUTH_MECH conf key for the secure-auth setting,
3966 instead of putting it in the list options, because this was actually used already.
3968 * src/maemo/modest-account-settings-dialog.c:
3969 (create_page_account_details),
3970 (modest_account_settings_dialog_set_account_name),
3971 (save_configuration):
3972 * src/maemo/modest-account-settings-dialog.h:
3973 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3974 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3976 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3978 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3979 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3980 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3982 * src/modest-defs.h:
3983 * src/maemo/modest-account-settings-dialog.c:
3984 (create_page_incoming), (on_combo_outgoing_security_changed),
3985 (on_combo_incoming_security_changed), (create_page_outgoing),
3986 (modest_account_settings_dialog_set_account_name),
3987 (save_configuration): Load/Save the port number, and change it when the
3988 security combo changes, to suitable defaults.
3990 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3992 * src/modest-account-mgr.c:
3993 (modest_account_mgr_add_server_account): Set the security and secure-auth
3994 options, and add a comment saying that the other camel-specific options should be
3997 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3999 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4001 * src/modest-tny-account-store.c: (account_list_free),
4002 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4003 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4006 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4008 * src/modest-protocol-info.c:
4009 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4010 is required by our UI spec. Maybe something in our implementation will use this eventually.
4011 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4012 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4013 instead of the previous 0 placeholder.
4015 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4016 secure-auth settings.
4017 * src/modest-account-mgr-helpers.h:
4018 * src/modest-account-mgr-helpers.c:
4019 (modest_server_account_data_get_option_secure_auth),
4020 (modest_server_account_set_option_secure_auth),
4021 (modest_server_account_data_get_option_security),
4022 (modest_server_account_set_option_security): Added this API for getting and setting the security
4023 and secure-auth settings.
4025 * src/maemo/modest-account-settings-dialog.h:
4026 * src/maemo/modest-account-settings-dialog.c:
4027 (modest_account_settings_dialog_finalize), (check_data),
4028 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4029 about changing titles.
4030 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4031 (save_configuration): Save the security and secure-auth settings.
4033 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4034 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4036 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4038 * src/modest-defs.h:
4039 * src/modest-account-mgr.c:
4040 (modest_account_mgr_add_server_account):
4041 Added and used defines for the options key and value pair strings,
4042 that are used so far, though they do not seem to correspond to anything in our
4043 UI specs or ModestProtocol enum.
4045 * src/modest-account-mgr-helpers.h:
4046 * src/modest-account-mgr-helpers.c:
4047 (compare_option_strings_for_name),
4048 (modest_server_account_data_get_option_value),
4049 (modest_server_account_data_get_option_bool),
4050 (modest_account_mgr_get_server_account_option):
4051 Added helper functions for parsing the options GSList.
4053 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4055 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4056 display name is based on the supplied account name.
4057 * src/modest-account-mgr.c:
4058 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4059 with an inefficient, but good-enough, implementation.
4061 * src/maemo/easysetup/modest-easysetup-wizard.c:
4062 (create_page_account_details), (on_before_next), (create_account):
4063 Check for existing display names rather than (non-user-visible) account names, and just
4064 create and set a unique account name at the end.
4066 * src/maemo/modest-account-settings-dialog.c:
4067 (modest_account_settings_dialog_init),
4068 (modest_account_settings_dialog_set_account_name),
4069 (create_page_incoming): Show the display name, instead of the account name.
4070 (on_response): Do some (not all) extra checks, as in the UI spec.
4071 (save_configuration): Save the display name if it was changed.
4073 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4075 * po/en_GB.po: Added needed logical ID and translation.
4076 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4077 (init_view): Made the is-default column clicking work.
4079 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4082 * src/maemo/easysetup/Makefile.am:
4083 * src/maemo/easysetup/modest-easysetup-wizard.c:
4084 (modest_easysetup_wizard_dialog_init):
4085 * src/maemo/easysetup/provider-data-test.keyfile:
4086 * src/maemo/easysetup/provider-data.keyfile:
4087 Moved the provider data file to the new modest-providers-data package and used it from there.
4089 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4091 * src/modest-local-folder-info.c:
4092 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4093 N_() was already used on the static strings, but this just marks it for translation without
4094 using the translation.
4096 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4098 * src/maemo/modest-account-settings-dialog.c:
4099 (create_page_incoming),
4100 (modest_account_settings_dialog_set_account_name):
4101 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4102 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4103 I will do this if nobody else gets there first.
4105 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4107 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4108 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4109 save the security stuff.
4111 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4113 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4114 Set the email address and user fullname, which I now see must be
4117 * src/maemo/modest-account-settings-dialog.h:
4118 * src/maemo/modest-account-settings-dialog.c:
4120 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4121 leave-on-server and authentication.
4122 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4125 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4128 * src/maemo/modest-account-settings-dialog.c:
4129 * src/maemo/modest-account-settings-dialog.h:
4130 Most (but not all) of the widgets are now present as specified by the UI spec.
4131 No changes are yet saved, and some details are not properly shown yet.
4133 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4135 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4137 * src/maemo/Makefile.am:
4138 * src/maemo/modest-account-settings-dialog.c:
4139 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4140 an existing account. Doesn't do much yet.
4142 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4143 Open the accounts settings dialog when Edit is clicked.
4145 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4147 * src/maemo/easysetup/Makefile.am:
4148 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4150 * src/maemo/easysetup/modest-easysetup-wizard.c:
4151 (modest_easysetup_wizard_dialog_init):
4152 Try to get the source directory from the build system,
4153 instead of hard-coding "./" into the source code, when opening our local
4154 copies of the configuration files.
4155 But this still fails when opening the wizard from the Accounts window,
4156 maybe because the working directory seems to change at runtime.
4157 So the wizard will fail the second time unless you copy the files into their
4158 proper locations - see the stdout warnings for the paths.
4160 (create_page_account_details),(on_before_next):
4161 Check for existing non-server accounts instead of server accounts,
4162 so the default account name is useful again, and to prevent trying to
4165 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4166 Show the wizard when New is clicked.
4168 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4169 (init_view): Show the column headers, and show the columns that are
4170 specified in the UI specs. However, something in Maemo's GTK+ prevents
4171 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4172 change the default account. This is despite unsetting the special properties.
4174 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4176 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4177 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4178 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4179 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4180 to make that clearer.
4181 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4183 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4185 * src/maemo/modest-account-view-window.c:
4186 (modest_account_view_window_init),
4187 (modest_account_view_window_new):
4188 Use the same buttons as specified in the
4189 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4190 the existing widgets, which never had a chance of working.
4191 Put the ModestAccountView treeview in a scrolled window.
4192 Do not repeat the initialization in both _init() and _new().
4194 * src/widgets/modest-account-view.c: (update_account_view):
4195 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4196 this widget and window shows no accounts.
4198 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4200 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4202 * src/maemo/easysetup/modest-easysetup-wizard.c:
4203 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4204 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4205 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4208 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4209 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4210 accounts exist yet, as in the UI spec.
4212 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4214 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4216 * src/maemo/Makefile.am:
4217 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4218 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4219 New window for editing connection-specific smtp details.
4220 Not fully implemented.
4222 * src/maemo/modest-connection-specific-smtp-window.c:
4223 (modest_connection_specific_smtp_window_finalize) :
4224 unref the tree model.
4225 (on_button_edit): Show the edit window.
4227 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4229 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4232 * src/maemo/Makefile.am:
4233 * src/maemo/modest-connection-specific-smtp-window.c:
4234 * src/maemo/modest-connection-specific-smtp-window.h:
4235 New window for showing the list of connections, for connection-specific
4236 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4237 * src/maemo/easysetup/modest-easysetup-wizard.c:
4238 (create_page_custom_outgoing): Show the new window when the button is clicked.
4240 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4242 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4243 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4244 * src/maemo/modest-msg-edit-window.c:
4245 (modest_msg_edit_window_insert_image):
4246 * src/modest-conf.c: (modest_conf_key_escape):
4247 * src/modest-mail-operation.c:
4248 (modest_mail_operation_send_new_mail):
4249 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4250 (modest_ui_actions_on_new_account):
4251 * src/widgets/modest-attachment-view.c: (update_filename_request):
4252 * src/widgets/modest-mail-header-view.c:
4253 Corrected warnings that were breaking the build, by commenting out unused variables,
4254 and a function, and by including a header.
4256 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4258 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4259 so we can #ifdef around platform-specific code when necessary.
4260 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4261 to allow this to build for the GNOME platform too.
4263 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4265 * src/maemo/easysetup/modest-easysetup-wizard.c:
4266 Added util_increment_name() and used it in create_page_account_details()
4267 to make sure that the default account name is always a new name.
4269 (modest_easysetup_wizard_dialog_init),
4270 (set_default_custom_servernames): Some minor memory management fixes.
4272 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4276 * src/modest-runtime.c: (init_i18n): Restored the translation
4277 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4278 are defined in config.h, and the translations are installed.
4280 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4281 is defined for translation.
4283 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4285 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4287 * src/maemo/easysetup/modest-easysetup-wizard.c:
4288 (modest_easysetup_wizard_dialog_init):
4289 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4290 Use realistic paths (though they should use $prefix generically) to the
4291 mcc_mapping and provider-data.keyfile files which might work when they
4292 are installed by the future version of the operator-wizard package,
4293 and then fallback to paths in our source code, with an explanatory
4296 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4300 * src/maemo/Makefile.am:
4301 * src/maemo/easysetup/: Added files from the previously-exernal
4302 osso-modest-easysetup.
4303 * src/maemo/modest-main-window-ui.h:
4304 * src/modest-ui-actions.c:
4305 * src/modest-ui-actions.h:
4306 Added modest_ui_actions_on_new_account() as a signal handler for the
4307 New Account menu item. It shows the easysetup wizard.
4308 * po/en_GB.po: Added additional needed logical IDs and translations.