1 2007-06-25 Murray Cumming <murrayc@murrayc.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 (libmodest_dbus_client_search): Fix the build. Sorry.
5 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
6 (reply_forward_cb): Initialize variables to fix the build.
8 * src/modest-tny-account-store.c:
9 (modest_tny_account_store_get_tny_account_by): Fix the account URI
10 comparison (a silly typo) so that email search results can be opened
11 when there are more than one account.
13 2007-06-25 Murray Cumming <murrayc@murrayc.com>
15 * libmodest-dbus-client/libmodest-dbus-client.c:
16 (libmodest_dbus_client_search),
17 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
18 instead of 1 second, because the search gets folders and messages from
19 the server, which can take a long time. When it times out,
20 osso-global-search will report no results.
22 We need to specify whether we should search only cached information
23 (maybe with a user preference), and the osso-email-search-plugin
24 API should really be improved to allow that option, and to allow results
25 to be delivered asynchronously in batches.
27 2007-06-25 Murray Cumming <murrayc@murrayc.com>
29 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
30 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
31 GTK_ICON_SIZE_DIALOG is probably the wrong size.
33 2007-06-25 Murray Cumming <murrayc@murrayc.com>
35 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
36 that is an empty string. D-Bus seems to give us these instead of NULL.
38 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
40 * src/dbus_api/modest-dbus-callbacks.c:
41 * src/maemo/easysetup/modest-easysetup-wizard.h:
42 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
43 * src/maemo/modest-connection-specific-smtp-edit-window.c:
44 (modest_connection_specific_smtp_edit_window_init):
45 * src/maemo/modest-maemo-global-settings-dialog.c:
47 * src/maemo/modest-maemo-utils.c:
48 (modest_maemo_utils_setup_images_filechooser):
49 * src/maemo/modest-main-window.c: (create_details_widget):
50 * src/maemo/modest-msg-edit-window.c:
51 (modest_msg_edit_window_attach_file_noninteractive),
52 (modest_msg_edit_window_color_button_change),
53 (modest_msg_edit_window_set_zoom):
54 * src/modest-mail-operation.c: (update_account_thread):
55 * src/modest-tny-account-store.c:
56 * src/modest-tny-account.c:
57 * src/widgets/modest-global-settings-dialog.c:
58 * src/widgets/modest-window.h:
62 2007-06-25 Murray Cumming <murrayc@murrayc.com>
64 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
65 * src/modest-search.c: (modest_search_folder),
66 (modest_search_all_accounts): Actually search only in the specified folder,
67 doing a simple match on the folder ID.
68 * src/modest-search.h: Added a folder field to the ModestSearch struct,
69 and added some documentation.
71 2007-06-22 Armin Burgmeier <armin@openismus.com>
73 * src/maemo/modest-maemo-utils.h:
74 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
75 modest_maemo_utils_get_supported_secure_authentication_methods.
77 * src/maemo/easysetup/modest-easysetup-wizard.c:
78 * src/maemo/modest-account-settings-dialog.c: Show correct error if
79 one occured, not just "Server does not support secure authentication".
81 2007-06-22 Murray Cumming <murrayc@murrayc.com>
83 * src/modest-tny-account-store.c: (get_password):
84 Restored the call to tny_account_set_user() because Philip seems to have
85 stopped this from crashing (by not using the freed string). It still does
86 not work, but now we can test it.
88 2007-06-22 Murray Cumming <murrayc@murrayc.com>
90 * src/maemo/modest-msg-edit-window.c: (init_window):
91 Comment out use of an uninitialzed GtkScrolledWindow variable,
92 to fix the build and stop a crash. Yet again.
94 2007-06-22 Murray Cumming <murrayc@murrayc.com>
96 * src/modest-tny-account-store.c: (get_password):
97 Remove the call to tny_account_set_user() because this actually crashes.
98 As mentioned in the last commit, it is known to not work anyway.
100 2007-06-22 Murray Cumming <murrayc@murrayc.com>
102 * src/modest-tny-account-store.c: (get_password):
103 Use tny_account_set_username() to tell tinymail that the username might
104 have changed too. But tinymail ignores this: see projects.maemo.org
106 * src/modest-ui-actions.c:
107 (modest_ui_actions_on_password_requested): Remove the useless attempt to
108 reset the connection when changing the username, and improve the comments.
109 Save the changed username to gconf at least, so it is used when Modest is
112 2007-06-21 Murray Cumming <murrayc@murrayc.com>
114 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
115 Do not use a query, so that we get all folders, including for POP and
116 local-folders. They work as search criteria too.
117 This fixes projects.maemo.org bug NB#57740.
119 2007-06-21 Murray Cumming <murrayc@murrayc.com>
121 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
122 Comment out the use of hildon_notification_set_sound() because it is
123 not declared, to fix the build. Warnings are serious, people.
125 2007-06-21 Armin Burgmeier <armin@openismus.com>
127 * src/maemo/modest-maemo-utils.h:
128 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
129 modest_maemo_utils_get_supported_secure_authentication_methods()
130 to query authentication methods for a specific user. This should fix
131 projects.maemo.org bug NB#61369.
133 * src/maemo/easysetup/modest-easysetup-wizard.c:
134 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
137 2007-06-21 Murray Cumming <murrayc@murrayc.com>
139 * libmodest-dbus-client/libmodest-dbus-client.h:
140 * libmodest-dbus-client/libmodest-dbus-client.c:
141 (modest_dbus_message_iter_get_search_hit),
142 (libmodest_dbus_client_search):
143 Reorganised and commented this.
144 Removed modest_search_hit_free() from the public API because it
147 Added libmodest_dbus_client_get_folders() and
148 modest_folder_result_list_free().
150 * src/dbus_api/modest-dbus-api.h:
151 * src/dbus_api/modest-dbus-callbacks.c:
152 (modest_dbus_req_filter): Commented. Moved most code to
153 on_dbus_method_search() and added on_dbus_method_get_folders().
155 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
156 of the extra D-Bus handler.
158 * tests/dbus_api/Makefile.am:
159 * tests/dbus_api/test_get_folders.c: New test for
160 libmodest_dbus_client_get_folders(). This seems to return an empty list
161 at the moment. That could be the same error that causes the message list
162 to be empty sometimes.
163 This should help with projects.maemo.org bug NB#57740.
165 2007-06-21 Armin Burgmeier <armin@openismus.com>
167 * src/modest-mail-operation.c: Do not call
168 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
169 notify the operation's end after having set the status to CANCELED for
170 the operation queue to listen on. This fixes a deadlock when there
171 were mail operations in the queue during its finalization.
173 * src/modest-singletons.c: Reordered uninitialization of the account
174 manager to happen after the mail operation queue was uninitialized
175 because the mail operation's in the queue might still try to access
176 the account manager (see modest_mail_operation_notify_end()). This
177 fixes a potential crash when terminating the application.
179 2007-06-21 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-search.c:
182 (search_mime_part_and_child_parts): Moved some code here so we
183 can search recursively in child folders.
184 (modest_search_folder): Search in the message as a mime part, instead
185 of just its child mime parts.
186 (read_chunk), (search_mime_part_ogs):
187 Check how many bytes were read, to prevent an endless loop.
188 Searching in message bodies now works. This finishes the fix for
189 projects.maemo.org bug NB#61007.
191 2007-06-20 Murray Cumming <murrayc@murrayc.com>
193 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
194 Add a g_warning when the item is not a folder.
196 * src/modest-ui-dimming-rules.c:
197 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
198 when selected item is not a folder (for instance, an account), because
199 the UI spec only talks about folders.
200 I am not sure what the UI spec wants, so this might not totally fix
201 projects.maemo.org bug NB#60794.
203 2007-06-20 Murray Cumming <murrayc@murrayc.com>
205 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
206 (load_from_file): Sort the list. The unsorted list would be more noticeable
207 in non-English locales.
209 * src/maemo/modest-msg-edit-window.c:
210 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
211 warning and fix the build.
213 * src/maemo/modest-progress-bar-widget.c:
214 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
215 avoid a g_warning, and probably to avoid a crash.
217 2007-06-20 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-search.c: (modest_search_folder): Check for a GError
220 when calling tny_folder_get_headers(), to show that this is not the cause
223 2007-06-20 Murray Cumming <murrayc@murrayc.com>
225 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
226 Actually set the body query instead of the subject query.
228 * src/modest-search.c: (search_mime_part_ogs),
229 (search_mime_part_strcmp): Remove extra space from the text/* regex,
230 which would probably cause it to fail if we got this far.
232 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
233 to simplify the code.
234 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
235 be causing search-in-body to fail.
237 2007-06-20 Murray Cumming <murrayc@murrayc.com>
239 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
241 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
242 Better debug message when the folder cannot be found.
243 This should help with fixing projects.maemo.org bug #61287.
244 * src/modest-search.c: (add_hit): Do not leak the furl string.
246 2007-06-20 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-ui-actions.c:
249 (modest_ui_actions_on_folder_selection_changed):
250 Do not special-case TNY_MERGE_FOLDER here, because
251 modest_tny_folder_get_account() already does that. This fixes
252 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
253 shown when the Outbox was selected).
255 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
257 * libmodest-dbus-client/libmodest-dbus-client.c:
258 (_dbus_iter_get_string_or_null): Initialize the string variable in
259 case this helps with Dirk's crash.
261 2007-06-19 Murray Cumming <murrayc@murrayc.com>
263 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
264 though it is not implemented yet (this function is maybe not even used),
265 to avoid breaking ABI in future.
266 * libmodest-dbus-client/libmodest-dbus-client.c:
267 (get_attachments_string): Moved some code into this generic function.
268 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
269 sends email. It is maybe not used.
270 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
271 (on_send_mail): Use attachments.
273 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
274 * src/maemo/modest-msg-edit-window.c:
275 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
276 a filename before using it, to fix projects.maemo.org bug NB#58233.
278 2007-06-19 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
281 Initialize the continue_download variable to fix the build, and probably
282 to fix randome behaviour.
284 2007-06-18 Armin Burgmeier <armin@openismus.com>
286 * src/modest-tny-send-queue.h:
287 * src/modest-tny-send-queue.c: Keep track of the status of messages in
288 the queue so we can later show it in the UI. Replaced
289 modest_tny_send_queue_msg_is_being_sent() by
290 modest_tny_send_queue_get_msg_status().
292 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
294 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
295 gpointer. This probably was not harmful, but just to be sure.
297 2007-06-18 Murray Cumming <murrayc@murrayc.com>
299 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
300 Fix the build, but leave the function broken on Bora, because
301 hildon_uri_action_get_service() does not exist.
302 osso_uri_action_get_service() does not exist either, it seems.
304 2007-06-18 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-tny-account.c:
307 (modest_tny_account_new_from_server_account):
308 Uncommented the url debug output again, because it is useful for
309 debugging, as I said in the comment.
311 2007-06-18 Murray Cumming <murrayc@murrayc.com>
313 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
315 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
316 for Mameo Bora, to fix the build.
318 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
321 Fixed build with hildon < 0.99
323 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
324 Check if the selected account is busy instead of checking all accounts
326 * src/modest-account-mgr-priv.h:
327 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
328 (modest_account_mgr_init), (compare_account_name),
329 (modest_account_mgr_set_account_busy),
330 (modest_account_mgr_account_is_busy):
331 * src/modest-account-mgr.h:
332 Added busy information to the account manager. It possible to
333 set an account to busy or not busy now.
335 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
336 (modest_mail_operation_update_account),
337 (modest_mail_operation_notify_end):
338 Set the account to busy/not busy depending on the operation state.
340 * src/widgets/modest-account-view.c:
341 (modest_account_view_finalize), (get_last_updated_string),
342 (update_account_view), (on_account_busy_changed), (init_view):
343 Show string "Refreshing..." if the account is currently busy.
345 All this fixes projects.maemo.org bug NB#59711
347 2007-06-14 Armin Burgmeier <armin@openismus.com>
349 * src/widgets/modest-attachments-view.h:
350 * src/widgets/modest-attachments-view.c: Added
351 modest_attachments_view_has_attachments() and fixed coordinate
352 transformation in get_att_view_at_coords(). This fixes attachment
355 * src/widgets/modest-msg-view.c: Make use of
356 modest_attachments_view_has_attachments() to decide whether to show
357 attachments in the header.
359 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
361 * src/maemo/modest-connection-specific-smtp-edit-window.c:
362 (on_change), (on_combo_security_changed),
363 (modest_connection_specific_smtp_edit_window_init),
364 (modest_connection_specific_smtp_edit_window_set_connection),
365 (modest_connection_specific_smtp_edit_window_is_dirty):
366 * src/maemo/modest-connection-specific-smtp-edit-window.h:
367 * src/maemo/modest-connection-specific-smtp-window.c:
370 Show an comfirmation dialog for the smpt-edit-window if there are
371 unsaved changes and the user hits cancel.
372 (projects.maemo.org bug NB#60479)
374 2007-06-14 Armin Burgmeier <armin@openismus.com>
376 * src/maemo/easysetup/modest-easysetup-wizard.c:
377 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
378 address" info in banner instead of node, and select all the text as
379 per UI spec. This fixes projects.maemo.org bug NB#60550.
381 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
383 reviewed by: <delete if not using a buddy>
385 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
386 * src/modest-ui-actions.c: (folder_refreshed_cb):
388 2007-06-14 Murray Cumming <murrayc@murrayc.com>
390 * src/widgets/modest-folder-view.c: (filter_row):
391 Explictly filter out the per-account outbox accounts. I don't know why
392 these only sometimes show up, but now they should never show up in the UI.
393 This should fix projects.maemo.org bug NB#60160.
395 2007-06-14 Murray Cumming <murrayc@murrayc.com>
397 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
398 when the toolbar does not exist yet.
399 * src/modest-widget-memory.c: (save_settings_header_view):
400 Added g_warnings() to help us to discover when we are trying to set
401 an empty columns list in gconf.
403 2007-06-14 Murray Cumming <murrayc@murrayc.com>
407 Added modest_init_get_default_header_view_column_ids().
409 * src/modest-widget-memory.c: (restore_settings_header_view):
410 Use the new function to get defaults, if the gconf key is empty,
411 instead of not creating any columns. This seems to fix the
412 empty right-hand pane problems.
414 * src/widgets/modest-header-view.h: Improved documentation.
416 2007-06-13 Murray Cumming <murrayc@murrayc.com>
418 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
419 Revert the use of the display name as the account name, because this
420 is generally wrong and would break the code that follows.
422 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
424 * src/maemo/easysetup/modest-easysetup-wizard.c:
425 (check_for_supported_auth_methods), (on_before_next),
428 More correct fix for projects.maemo.org bug NB# 58991
429 Do not longer accept AUTH_PASSWORD as secure method and choose
430 correct method when creating the account.
432 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
434 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
435 Fixed projects.maemo.org bug NB# 58991
437 2007-06-13 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-init.c: (modest_init_init_core),
440 (modest_init_local_folders): Fixed compilation errors.
442 2007-06-13 Murray Cumming <murrayc@murrayc.com>
444 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
445 Remove unnecessary lib/include, though it is good in principle when needed.
447 * src/modest-init.c: (modest_init_one_local_folder),
448 (modest_init_local_folders):
449 * src/modest-init.h: Initialize the .modest library for memory cards,
450 instead of just doing nothing for them. This should allow us to create
451 folders there, fixing projects.maemo.org bug NB#59297.
453 2007-06-13 Murray Cumming <murrayc@murrayc.com>
455 * libmodest-dbus-client/libmodest-dbus-client.c:
456 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
457 (libmodest_dbus_client_compose_mail),
458 (libmodest_dbus_client_open_message),
459 (libmodest_dbus_client_send_and_receive),
460 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
462 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
463 (on_idle_open_message), (modest_dbus_req_handler),
464 (search_result_to_message), (modest_dbus_req_filter):
465 * src/modest-search.c: (add_hit), (modest_search_folder),
466 (modest_search_all_accounts): Improved debug messages.
468 * tests/dbus_api/test_open_message.c: (main): Improved comments.
470 * src/modest-tny-account-store.c:
471 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
474 2007-06-13 Murray Cumming <murrayc@murrayc.com>
477 2007-06-12 Murray Cumming <murrayc@murrayc.com>
479 * src/modest-tny-account-store.c: (get_server_accounts):
480 Call modest_tny_local_folders_account_add_merged_outbox_folders()
481 even when there are no accounts, so that the Outbox folder is always
482 visible. This fixes projects.maemo.org bug NB#60158.
484 2007-06-12 Murray Cumming <murrayc@murrayc.com>
486 * src/maemo/modest-main-window.c: (create_details_widget):
487 Use the mcen_va_never logical ID.
489 2007-06-12 Murray Cumming <murrayc@murrayc.com>
491 * src/dbus_api/modest-dbus-api.h:
492 * src/dbus_api/modest-dbus-callbacks.c:
493 (on_idle_open_default_inbox), (on_open_default_inbox),
494 (modest_dbus_req_handler):
495 Added a new OpenDefaultInbox method.
497 * libmodest-dbus-client/libmodest-dbus-client.h:
498 * libmodest-dbus-client/libmodest-dbus-client.c:
499 Added libmodest_dbus_client_open_default_inbox() to call the new
500 dbus method. This should be useful to projects.maemo.org bug NB#57214,
501 though it should maybe be used by a new osso-email-interface function.
503 * tests/dbus_api/Makefile.am:
504 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
507 2007-06-12 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
510 NULL, so that the signals get all the keys. This should not actually
511 change any behaviour because we currently update everything when anything
514 2007-06-12 Murray Cumming <murrayc@murrayc.com>
516 * src/widgets/modest-folder-view.c: (text_cell_data),
517 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
518 (find_inbox_iter): If tinymail tells us that the folder is
519 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
520 This causes the inbox to be selected at startup, fixing part of
521 projects.maemo.org bug NB#56305.
523 * src/modest-ui-dimming-rules.c:
524 (modest_ui_dimming_rules_on_tools_smtp_servers):
525 * src/modest-ui-dimming-rules.h: Added a callback function to dim
526 the SMTP servers menu item.
527 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
528 that the SMTP Servers menu item is dimmed when there are no accounts,
529 as a future version of the UI spec will require. This fixes
530 projects.maemo.org bug NB#56305.
532 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
534 * src/maemo/modest-maemo-utils.c:
535 (modest_maemo_utils_get_supported_secure_authentication_methods):
536 Added label to dialog instead of unreadable title
538 * src/maemo/modest-main-window.c: (sync_accounts_cb),
539 (modest_main_window_new):
540 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
543 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
544 * src/modest-account-mgr.h:
545 Added method to avoid code duplication
547 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
548 (modest_ui_actions_on_send_receive):
549 Use modest_account_mgr_has_accounts
551 2007-06-11 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/easysetup/modest-presets.c:
554 (modest_presets_get_info_server_security): Do not report secure auth
556 * src/modest-protocol-info.c: Use the defines for the gconf key names
557 for secure authentication. This was not working because we were writing
558 Password and reading password, and the check was case sensitive.
559 With this, gmail now works for receiving and sending when created via
562 2007-06-11 Murray Cumming <murrayc@murrayc.com>
564 * src/maemo/easysetup/modest-presets.c:
565 (modest_presets_get_info_server_security): Correct the key name for
566 SecureSmtp, because it seems to be case-sensitive.
567 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
568 Do not try to get the 0th notebook page if there are 0 pages, to
571 2007-06-11 Murray Cumming <murrayc@murrayc.com>
573 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
574 Prevent use of the new notification feature for now, because it currently
575 shows one dialog for each new email, which is annoying.
577 2007-06-11 Murray Cumming <murrayc@murrayc.com>
579 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
580 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
581 when no country was selected, so that we show the global ones.
582 * src/maemo/easysetup/modest-presets.c:
583 (modest_presets_get_providers): Return only the global providers, not
584 all providers when mmc=0 was requested.
586 2007-06-11 Murray Cumming <murrayc@murrayc.com>
588 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
589 (easysetup_provider_combo_box_fill): Remove debug code that showed the
590 provider ID in the combo.
592 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
593 Do not show the page numbers, because it would be confusing when we add
594 the 2 extra pages for the custom setup, when the user chooses the "Other"
595 provider. This fixes projects.maemo.org bug NB#59028
597 * src/modest-init.c: (modest_init_init_core),
598 (modest_init_local_folders):
600 * src/modest-tny-account.c:
601 (modest_tny_account_new_for_local_folders): Do not create default folders
602 for the memory card. This should fix projects.maemo.org bug NB#59328.
604 2007-06-11 Murray Cumming <murrayc@murrayc.com>
606 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
607 Free the changed_conf_keys string items. They are already freed in the
608 idle handler if that runs first.
610 2007-06-11 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-ui-actions.c:
613 (modest_ui_actions_on_password_requested): Check that the server name
614 is not NULL, because I just saw a password dialog with (null) as the
617 * src/modest-tny-folder.[h|c]: Added
618 modest_tny_folder_is_memory_card_folder().
619 * src/modest-ui-dimming-rules.c:
620 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
621 menu item for memory cards, as per the UI spec (section 7.4). This should
622 fix projects.maemo.org bug NB#59297.
624 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
626 * src/maemo/modest-main-window.c: (sync_accounts_cb):
627 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
628 is another problem with the code, see Murray's comment at line 772)
630 2007-06-08 Murray Cumming <murrayc@murrayc.com>
632 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
633 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
634 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
635 (load_from_file), (easysetup_country_combo_box_init),
636 (easysetup_country_combo_box_get_active_country_ids),
637 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
638 instead of just one ID, to avoid duplicate country names in the UI.
640 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
641 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
642 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
643 a single ID, avoiding duplicate providers.
644 * src/maemo/easysetup/modest-easysetup-wizard.c:
645 (on_combo_account_country): Adapt to use a list.
647 2007-06-08 Murray Cumming <murrayc@murrayc.com>
649 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
650 keys changed in the last X seconds.
652 * src/modest-account-mgr.h:
653 * src/modest-account-mgr.c: (on_timeout_notify_changes),
654 (on_key_change), (modest_account_mgr_class_init),
655 (modest_account_mgr_init), (modest_account_mgr_finalize):
656 As the keys are changed, save them in a GSList* and signal that GSList*
657 further every X seconds, to batch changes, to allow us to do just one
658 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
659 bug NB#56941 and other (UI-blocking) delays when changing account settings.
661 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
662 changed signal signature.
664 * src/modest-conf.c: (modest_conf_set_list),
665 (modest_conf_on_change): Reenable notification.
667 (modest_conf_maemo_fake_on_change): Comment out the hack that
668 notified immediately instead of asynchronously.
670 * src/widgets/modest-account-view.h:
671 * src/widgets/modest-account-view.c:
672 (update_account_view): Select the previously-selected account ID,
673 if possible. This fixes projects.maemo.org bug NB#56933.
675 (on_account_changed), (on_account_removed),
676 (modest_account_view_select_account):
678 Remove the block/unblock functions
679 because they were not useful.
681 * src/maemo/modest-account-view-window.c:
682 (on_delete_button_clicked), (on_edit_button_clicked),
683 (on_new_button_clicked): Remove the use of the non-working block/unblock.
685 2007-06-08 Murray Cumming <murrayc@murrayc.com>
687 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
688 Improve the error dialog to show Incorrect Account Settings, which seems
689 clearer, and say that the internal error message (to be removed from the
690 dialog later) is often misleading.
691 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
693 * src/modest-tny-account.c:
694 (modest_tny_account_new_from_server_account): Uncomment the printf of the
695 URL because this is so useful for debugging on the device.
697 * src/widgets/modest-serversecurity-combo-box.c:
698 (modest_serversecurity_combo_box_fill): Correct a logical ID.
700 2007-06-08 Murray Cumming <murrayc@murrayc.com>
702 * src/modest-mail-operation.c:
703 (modest_mail_operation_send_new_mail):
704 Added a comment about a nasty but apparently harmless message. Details
705 added to the wiki g_warnings() page.
707 2007-06-08 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
710 (modest_tny_send_queue_class_init):
711 Do not use the priv struct because it is empty, to avoid g_warnings
712 about a non-existant priv struct.
714 * src/modest-tny-account-store.c:
715 (modest_tny_account_store_get_server_account),
716 (modest_tny_account_store_get_transport_account_for_open_connection
717 ): Do not try to get transport server accounts for local folders,
718 because they don't have any. This avoids a g_warning().
720 * src/maemo/modest-main-window.c:
721 (modest_main_window_notify_send_receive_initied),
722 (on_configuration_key_changed):
723 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
725 * src/modest-mail-operation.c:
726 (modest_mail_operation_update_account):
727 * src/modest-tny-account-store.h:
728 * src/modest-tny-account.c:
729 (modest_tny_account_get_special_folder),
730 (modest_tny_account_new_for_local_folders),
731 (modest_tny_account_new_for_per_account_local_outbox_folder):
732 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
733 * src/modest-tny-local-folders-account.c:
734 (add_account_folders_to_merged_folder):
735 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
736 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
737 (modest_ui_actions_on_send):
738 * src/widgets/modest-folder-view.c: (update_model):
739 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
740 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
741 modest_tny_account_store_get_tny_account_by_account() to
742 modest_tny_account_store_get_server_account() to make the code clearer.
744 2007-06-07 Marcus Bauer <marcusb@openismus.com>
746 * src/dbus_api/modest-dbus-api.h:
747 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
748 * src/maemo/modest-msg-edit-window.c:
749 (modest_msg_edit_window_attach_file_noninteractive):
750 added g_warning in case the file to be attached does not exist
751 * tests/dbus_api/test_compose_mail.c: (main):
752 removed obsolete comment, added generic files as test case
754 2007-06-07 Murray Cumming <murrayc@murrayc.com>
756 * src/modest-tny-account-store.c: (get_server_accounts):
757 Create the local folders account only once, not once for each outbox, and
758 not only when there are some outboxes.
760 2007-06-07 Murray Cumming <murrayc@murrayc.com>
762 * src/widgets/modest-folder-view.c: (update_model): Comment out some
763 code that is causing a crash at startup. Sergio says that he is fixing this.
765 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
767 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
768 * src/maemo/modest-account-settings-dialog.c:
769 (create_page_outgoing),
770 (modest_account_settings_dialog_set_account_name),
771 (save_configuration):
772 - Fixed handling of the "Use secure authentication" toggle to comply with
773 the ui specification. See also projects.maemo.org bug NB#58400
775 - Restore the Secure connection setting combo correctly when loading
778 * src/maemo/modest-maemo-utils.c:
779 (on_camel_account_get_supported_secure_authentication),
780 (modest_maemo_utils_get_supported_secure_authentication_methods):
781 Fixed a crasher if operation is canceled
783 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
784 (modest_protocol_info_auth_is_secure):
785 * src/modest-protocol-info.h:
787 Added two new methods to determine if a protocol/auth method is secure/encrypted in
788 the sense of the "Use secure authentication" toggle.
790 2007-06-07 Murray Cumming <murrayc@murrayc.com>
792 * src/modest-tny-account-store.h:
793 * src/modest-tny-account-store.c:
794 Added modest_tny_account_store_get_local_folders_account().
796 * src/modest-tny-folder.h:
797 * src/modest-tny-folder.c:
798 (modest_tny_folder_get_account):
799 Added this replacement for tny_folder_get_account() which returns
800 the local-folders account for TnyMergeFolders, to avoid the
801 warning about the unimplemented get_account_func() vfunc().
803 (modest_tny_folder_get_rules),
804 * src/modest-ui-actions.c:
805 (modest_ui_actions_on_folder_selection_changed):
806 * src/modest-mail-operation.c:
807 (modest_mail_operation_remove_folder),
808 (modest_mail_operation_xfer_folder),
809 (modest_mail_operation_rename_folder),
810 (modest_mail_operation_get_msg),
811 (modest_mail_operation_get_msgs_full),
812 (modest_mail_operation_remove_msg),
813 (modest_mail_operation_xfer_msgs),
814 (modest_mail_operation_refresh_folder):
815 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
817 2007-06-07 Murray Cumming <murrayc@murrayc.com>
819 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
820 (modest_server_account_set_security):
821 * src/modest-defs.h: Add comments explaining that our
822 UI spec means TLS when it says Normal, so these do not look like errors.
824 * src/modest-tny-account.c:
825 (modest_tny_account_new_from_server_account): Use the new tinymail
826 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
827 for TLS. This should fix projects.maemo.org bug NB#58460.
829 2007-06-06 Murray Cumming <murrayc@murrayc.com>
831 * src/maemo/easysetup/modest-easysetup-wizard.c:
832 (create_account): Correct the position of the gconf sanity check warning.
833 (on_button_edit_advanced_settings): Show the dialog immediately, instead
834 of using the g_idle_add() hack, because this does not seem to be necessary
835 on osso 1.1. It might even work on Maemo Bora if the problems were actually
836 caused by something other than maemo's gconf.
837 This fixes projects.maemo.org bug #59022.
839 2007-06-06 Murray Cumming <murrayc@murrayc.com>
841 * src/modest-account-mgr-helpers.c:
842 (modest_account_mgr_get_default_account): Do not check that the account
843 exists if there is no default account (NULL), to fix a runtime warning.
845 2007-06-06 Murray Cumming <murrayc@murrayc.com>
847 * src/widgets/modest-folder-view.c: (update_model):
848 Do not unref the treemodel before we have finished with it.
849 This prevents a valgrind warning and an occasional crash at startup.
851 2007-06-06 Marcus Bauer <marcusb@openismus.com>
853 * libmodest-dbus-client/libmodest-dbus-client.h:
854 added libmodest_dbus_client_compose_mail()
855 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
857 added functions needed for SendAsMail() functionality
858 * src/maemo/modest-msg-edit-window.c:
859 (modest_msg_edit_window_attach_file_noninteractive):
860 non interactively attaching files to message edit window
861 * src/widgets/modest-msg-edit-window.h:
862 * tests/dbus_api/Makefile.am:
863 added test_compose_mail.c
864 * tests/dbus_api/test_compose_mail.c: (main):
866 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
868 * src/modest-account-view.c:
869 Fixed bug projects.maemo.org bug NB#59307
871 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
873 * src/maemo/easysetup/modest-easysetup-wizard.c:
874 (get_serverport_incoming), (on_before_next), (create_account):
875 * src/maemo/modest-account-settings-dialog.c:
876 (modest_account_settings_dialog_set_account_name):
877 * src/maemo/modest-maemo-utils.c:
878 (on_camel_account_get_supported_secure_authentication_status),
879 (on_camel_account_get_supported_secure_authentication),
880 (on_secure_auth_cancel),
881 (modest_maemo_utils_get_supported_secure_authentication_methods):
883 Implemented security authentication for settings and easysetup.
885 2007-06-05 Murray Cumming <murrayc@murrayc.com>
887 * src/maemo/modest-main-window.c: (create_details_widget):
888 Show the total size for memory card accounts too, instead of showing
889 the name again. Fixes bug projects.maemo.org bug NB#59307.
891 2007-06-05 Murray Cumming <murrayc@murrayc.com>
894 * src/modest-tny-simple-folder-store.c:
895 * src/modest-tny-simple-folder-store.h: Removed.
897 * src/modest-tny-local-folders-account.h
898 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
899 for the local-folders maildir, with an extra TnyMergedFolder containing
900 the folders of the per-account outbox store accounts.
901 * src/modest-tny-account-store.c: (get_server_accounts):
902 Add the outboxes to the special local folders account after creating it.
904 * src/modest-tny-account.c:
905 (modest_tny_account_new_for_local_folders): Create the derived
906 account when creating the main local-folders account.
908 * src/maemo/modest-main-window.c: (create_details_widget),
909 (modest_main_window_set_contents_style):
910 Adapted to the use of the derived account instead of the folder store.
912 * src/modest-ui-actions.c:
913 (modest_ui_actions_on_folder_selection_changed):
914 * src/modest-ui-dimming-rules.c:
915 (modest_ui_dimming_rules_on_new_folder):
916 * src/widgets/modest-folder-view.c: (text_cell_data),
917 (icon_cell_data), (filter_row), (update_model),
918 (get_cmp_rows_type_pos):
921 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
922 Do not get the priv struct, because no priv struct has been set,
923 to avoid a runtime warning.
925 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
926 #ifelse with #else, to fix a warning, to fix the build.
929 2007-06-05 Christian Kellner <ckellner@openismus.com>
931 * libmodest-dbus-client/libmodest-dbus-client.c:
932 Fix small typo in doc (why do you always see them
933 AFTER committing stuff?)
936 2007-06-05 Christian Kellner <ckellner@openismus.com>
938 * libmodest-dbus-client/libmodest-dbus-client.c:
939 (libmodest_dbus_client_search):
940 Initialize hit list with NULL. Also set folder list
941 to "" if NULL was supplied.
944 2007-06-03 Christian Kellner <ckellner@openismus.com>
946 * libmodest-dbus-client/libmodest-dbus-client.c:
947 (modest_search_hit_list_free):
948 Make it save to call it with NULL.
950 * src/dbus_api/modest-dbus-callbacks.c:
951 * src/modest-search.c:
952 Return full ModestSearchHits as the search result list not TnyHeader
953 since can't be around withouth the correspoding TnyFolder.
955 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
957 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
958 Added currently commented code to check for secure auth
960 * src/maemo/modest-account-settings-dialog.c: (on_response),
961 (save_configuration), (show_ok):
962 Fixed projects.maemo.org bugs NB #59248 and #59251
964 * src/maemo/modest-maemo-utils.c:
965 (on_camel_account_get_supported_secure_authentication_status),
966 (on_camel_account_get_supported_secure_authentication),
967 (modest_maemo_utils_get_supported_secure_authentication_methods):
968 * src/maemo/modest-maemo-utils.h:
969 Moved get_supported_secure_authentication() method here to be able
970 to use it from easysetup wizard.
972 * src/modest-pair.c: (on_pair_compare_as_string):
973 Should compare string with first part of pair and not
974 strcmp pairs which will crash.
976 * src/modest-protocol-info.c:
977 (modest_protocol_info_protocol_is_store):
978 * src/modest-protocol-info.h:
979 Added modest_protocol_info_get_auth_protocol_name()
981 2007-06-03 Armin Burgmeier <armin@openismus.com>
983 * src/modest-mail-operation.c:
984 (modest_mail_operation_get_msgs_full): Set priv->account also when
985 only retrieving a single message. This avoids a crash when canceling
988 (modest_mail_operation_notify_end): Do not explicitely remove the
989 operation from the queue but only emit the progress_changed signal.
990 The queue itself listens to that signal to remove the operation when
991 it is finished. This reduces coupling and removes a potential deadlock
992 when modest_mail_operation_notify_end() is called from the queue
993 itself. If that is a problem performance-wise, I would suggest to
994 implement a status-changed signal or something.
996 * src/modest-mail-operation-queue.c: Make sure to never call a
997 function from another file while the queue is locked. This (hopefully)
998 fixes another deadlock when exiting the application while retrieving
1001 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1003 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1004 Fixed build if libogs is not available
1006 2007-06-03 Christian Kellner <ckellner@openismus.com>
1008 * libmodest-dbus-client/libmodest-dbus-client.h:
1009 * libmodest-dbus-client/libmodest-dbus-client.c:
1010 (libmodest_dbus_client_delete_message):
1011 Implement deletion of messages (Client side).
1013 (modest_search_hit_free),
1014 (modest_search_hit_list_free):
1015 Utility functions to free the result hits.
1017 * src/dbus_api/modest-dbus-api.h:
1018 * src/dbus_api/modest-dbus-callbacks.c:
1019 (on_delete_message),
1020 (modest_dbus_req_handler):
1021 Implement deletion of messages (Server side).
1023 * tests/dbus_api/test_search.c: (main):
1026 * tests/dbus_api/Makefile.am:
1027 * tests/dbus_api/test_delete_message:
1028 Add little test for the message deletion logic
1030 2007-06-03 Armin Burgmeier <armin@openismus.com>
1032 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1033 when the operation queue was not empty. projects.maemo.org bug
1036 2007-06-03 Armin Burgmeier <armin@openismus.com>
1038 * src/widgets/modest-account-view.c
1039 (on_account_default_toggled): Toggle default account column
1040 explicitely instead of waiting for gconf notification (which is
1041 currently ignored). This should fix projects.maemo.org bug NB#56910
1042 for now. It should probably be removed when gconf notifications are
1045 2007-06-03 Christian Kellner <ckellner@openismus.com>
1047 * libmodest-dbus-client/libmodest-dbus-client.c:
1048 Removed debugging spew.
1050 * src/dbus_api/modest-dbus-callbacks.c:
1051 Added debugging info.
1053 * src/modest-search.c:
1054 (modest_search_all_accounts):
1055 Use tny_account_store_get_accounts () on the account store
1056 to get all accounts which is the way to get all accounts.
1058 * tests/dbus_api/test_search.c: (main):
1059 Make it possible to supply the search term on the command line.
1061 2007-06-03 Christian Kellner <ckellner@openismus.com>
1063 * libmodest-dbus-client/libmodest-dbus-client.c:
1064 * libmodest-dbus-client/libmodest-dbus-client.h:
1065 Implement searching for mesages over raw dbus. (Client side)
1067 * src/dbus_api/Makefile.am:
1068 * src/dbus_api/modest-dbus-api.h:
1069 * src/dbus_api/modest-dbus-callbacks.c:
1070 * src/dbus_api/modest-dbus-callbacks.h:
1071 Search framework (Server side). Also implement on_idle_open_message().
1073 * src/maemo/modest-platform.c: (modest_platform_init):
1074 Prepare for raw dbus/osso rpc interaction.
1076 * src/modest-search.h:
1077 Changed minsize from unspecific guint to guint32.
1079 * src/modest-search.c:
1081 Added strange hack which magically made tnymail work.
1083 (modest_search_folder),
1084 (modest_search_account),
1085 (modest_search_all_accounts):
1086 Implement helper functions to search all accounts, specific account
1089 * tests/dbus_api/Makefile.am:
1090 * tests/dbus_api/test_open_message.c:
1091 Read url to open from commandline.
1093 * tests/dbus_api/test_search.c:
1094 Implement small test for dbus search stuff
1096 2007-06-02 Armin Burgmeier <armin@openismus.com>
1098 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1099 include account type and account title. This fixes projects.maemo.org
1102 * src/maemo/modest-account-view-window.c: Set a title for the window.
1104 2007-06-02 Armin Burgmeier <armin@openismus.com>
1106 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1107 incoming and outgoing server name based on email address and server
1108 types as long as the names have not been edited manually. This fixes
1109 projects.maemo.org bug NB#58671.
1111 2007-06-02 Armin Burgmeier <armin@openismus.com>
1113 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1114 server type cannot be changed in future to the incoming details page
1115 when creating an account. This fixes projects.maemo.org bug NB#59029.
1117 2007-06-02 Armin Burgmeier <armin@openismus.com>
1119 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1120 and assigned max width chars so that they wrap instead of being
1121 truncated. Fixes projects.maemo.org bug NB#56126.
1123 2007-06-02 Armin Burgmeier <armin@openismus.com>
1125 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1126 introductory note to the connection specific smtp servers dialog, as
1127 section 8.12 of the email UI specification requires. This fixes
1128 projects.maemo.org bug NB#59212.
1130 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1133 Check for running mail operations, and offer to cancel them, as per the UI
1134 spec. This fixes projects.maemo.org bug NB#59041 .
1135 However, I suspect that tinymail may still use the network connection
1136 in ways that we cannot detect or cancel. But it should at least adapt to
1137 changes fairly well.
1139 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-tny-account-store.c: (recreate_all_accounts),
1142 (get_cached_accounts), (get_server_accounts): Do more sensible
1143 ref-counting of the temporarily-cached outbox accounts list. This seems
1144 to fix a crash when entering the password when the password was wrong.
1146 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1148 * src/gnome/modest-main-window.c: (connect_signals):
1149 * src/modest-tny-account-store.c: (get_password),
1150 (modest_tny_account_store_alert): Added comments and clues and
1151 commented-out code about how we currently fail to deal with connection
1152 errors and wrong passwords, and how we should.
1154 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1156 * src/widgets/modest-retrieve-combo-box.c:
1157 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1158 This fixes projects.maemo.org bug NB#58472 .
1160 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1162 * src/maemo/easysetup/modest-easysetup-wizard.c:
1163 (create_page_complete_easysetup):
1164 (create_page_complete_custom): Correct the last commit,
1165 putting the correct sentences in the correct pages.
1167 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/easysetup/modest-easysetup-wizard.c:
1170 (create_page_complete_custom): Show the second sentence of text
1171 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1174 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1176 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1177 Set the leave-on-server conf key by default. This fixes
1178 projects.maemo.org bug NB#59258 .
1180 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1182 * src/maemo/modest-account-view-window.c:
1183 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1184 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1187 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1189 * src/maemo/easysetup/modest-easysetup-wizard.c:
1190 (create_caption_new_with_asterisk):
1191 * src/maemo/modest-account-settings-dialog.c:
1192 (create_caption_new_with_asterisk):
1193 Uncomment the code to add the asterisk, because they are no longer in the
1194 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1195 (update_incoming_server_title): Add an asterisk here too.
1197 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1199 * src/maemo/modest-maemo-global-settings-dialog.c:
1200 (current_connection): Check that we are even connected before trying to
1201 get the current connection name, to prevent a warning.
1203 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1204 Change the comments because tny_maemo_conic_device_connect() is now meant to
1206 * src/modest-mail-operation.c:
1207 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1208 make sure we have a connection and fail if we can't connect.
1210 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/modest-main-window.c:
1213 (on_account_store_connecting_finished): Do not try to get the
1214 connection ID if we are not really connected. I am surprised that
1215 this signal handler is called when we are not connected.
1217 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1219 * src/modest-error.h:
1220 * src/modest-ui-actions.c:
1221 (modest_ui_actions_get_msgs_full_error_handler):
1222 Renamed an enum, added comments, added an enum
1223 for retrieve-limit errors.
1225 * src/modest-mail-operation.c: (foreach_add_item),
1226 (internal_folder_observer_update), (update_account_thread),
1227 (modest_mail_operation_get_msgs_full):
1228 (modest_mail_operation_update_account),
1229 Added comments about how this works, and some code that should
1230 (but does not) check the retrieve-limit. See the TODO comment.
1232 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1234 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1235 Initialize help_id to fix the build. Warnings are good.
1237 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1239 * src/widgets/modest-hbox-cell-renderer.c:
1240 (modest_hbox_cell_renderer_append):
1241 * src/widgets/modest-vbox-cell-renderer.c:
1242 (modest_vbox_cell_renderer_append):
1243 Fix the last commit by doing an extra ref.
1245 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1247 * src/widgets/modest-hbox-cell-renderer.c:
1248 (modest_hbox_cell_renderer_append):
1249 * src/widgets/modest-vbox-cell-renderer.c:
1250 (modest_vbox_cell_renderer_append):
1251 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1252 to fix the build with Maemo Bora.
1253 However, there seems to be a remaining crash, probably due to reference
1256 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1258 * src/modest-tny-account.c:
1259 (modest_tny_account_new_for_local_folders):
1260 Use hildon_file_system_info_async_new() to get a better name for
1261 the memory card account, setting it as the account name.
1262 The timing seems to work, but this is probably
1263 not the best place to do this. See the TODO comment.
1264 * src/maemo/modest-main-window.c: (create_details_widget):
1265 * src/widgets/modest-folder-view.c: (text_cell_data):
1266 Use the tny account name instead of hardcoding a name.
1268 2007-05-30 Christian Kellner <ckellner@openismus.com>
1270 * src/modest-search.c: (modest_search):
1271 Correctly set part_search_func even if we have already parsed
1272 the query and thus a valid OgsTextSearcher object.
1274 2007-05-30 Christian Kellner <ckellner@openismus.com>
1277 Search and check for libogs.
1280 Incooparte the ogs build env.
1282 * src/modest-mime-part-search-stream.c:
1283 * src/modest-mime-part-search-stream.h:
1284 Removed since we do the real searching now in modest-search.c.
1286 * src/modest-search.c:
1287 * src/modest-search.h:
1288 Implement support for ogs. We use that if available and requested
1289 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1290 should now handle the corner case when the search term is spread
1291 across multiple reads.
1292 Also the logic in modest_search () was corrected to search all
1293 requested fields until one is found.
1295 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1297 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1299 * src/modest-init.h:
1300 * src/modest-init.c: Made modest_init_local_folders() take a
1301 path and be public so we can iniitialize maildir folders on
1304 * src/modest-local-folder-info.h:
1305 * src/modest-local-folder-info.c:
1306 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1308 * src/modest-tny-account.c:
1309 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1310 still means the standard local-folders path on the local volume.
1312 * src/modest-tny-account-store.c:
1313 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1314 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1315 all accounts when that happens.
1316 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1317 this too, so it shows up in the treeview.
1319 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1321 * src/maemo/modest-maemo-global-settings-dialog.c:
1322 (current_connection):
1323 * src/widgets/modest-global-settings-dialog.c:
1324 (current_connection_default):
1325 Use the enum values instead of 0, 1 and -1,
1326 to make the code clearer.
1328 * src/modest-account-mgr-helpers.c:
1329 (modest_account_mgr_get_connection_specific_smtp): Make this code
1332 * src/modest-runtime.h:
1333 * src/modest-runtime.c:
1334 Added modest_runtime_remove_all_send_queues().
1335 * src/maemo/modest-main-window.c:
1336 (on_account_store_connecting_finished): Recreate the send queues,
1337 using the appropriate transport accounts for this new connection.
1338 Some futher adapting might be needed if the old send queues are not
1339 automatically stopped at this point.
1341 * src/modest-tny-account-store.c: (get_server_accounts):
1342 Create the connection-specific transport accounts, so that they can
1343 be found later by their ID.
1345 * src/modest-tny-account.h:
1346 * src/modest-tny-account.c:
1347 Added modest_tny_account_new_from_server_account_name().
1348 modest_tny_account_new_from_server_account(): Do not create the
1349 send queues here, because they will be
1350 recreated anyway when the connection changes for the first time.
1352 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-local-folder-info.h:
1355 * src/modest-local-folder-info.c:
1356 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1357 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1358 tbox_folder): Take a modest account name instead of a server TnyAccount,
1359 so we can have per-modest-account rather than per-transport-account
1361 We must make sure that we change or recreate the exisitng send queues
1362 when the connection changes for connection-specific transport accounts.
1364 * src/modest-tny-account-store.c:
1365 (create_per_account_local_outbox_folders): Create outboxed per modest
1366 account, not per transport account.
1368 * src/modest-tny-account.h:
1369 * src/modest-tny-account.c:
1370 (modest_tny_account_get_special_folder): For outboxes, get the
1371 parent modest account name. The account is ignored for other folders.
1372 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1373 modest account name rather than a server TnyAccount.
1375 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1377 * src/modest-tny-account.c:
1378 (modest_tny_account_new_from_server_account):
1379 Call modest_runtime_get_send_queue() immediately after creating transport
1380 accounts, so that they start trying to send email from the outbox as soon
1381 as possible at startup. This is probably what we want.
1383 * src/modest-mail-operation.c: (update_account_thread):
1384 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1385 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1386 * src/modest-tny-send-queue.h:
1387 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1388 (modest_ui_actions_on_send):
1389 Added comments about how sending works, though it needs some more work.
1391 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1393 * src/modest-tny-account.c:
1394 (modest_tny_account_get_special_folder): Add TODO because this fails when
1395 the network is busy.
1396 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1397 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1398 Do not try to show this window when there is no active account. The UI
1399 specs does not tell us what to do in this case.
1401 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1405 * src/maemo/Makefile.am:
1406 * src/widgets/Makefile.am: Some dist fixes.
1408 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1410 * src/maemo/modest-connection-specific-smtp-window.c:
1411 (on_button_edit): Make the code clearer, to prevent a double free.
1413 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1415 * src/maemo/modest-account-settings-dialog.c:
1416 (modest_account_settings_dialog_set_account_name),
1417 Check the connection-specific smtp servers checkbox if there are any.
1419 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1420 (modest_connection_specific_smtp_edit_window_init):
1421 Start with a suitable port number.
1423 * src/modest-account-mgr-helpers.h:
1424 * src/modest-account-mgr-helpers.c: Added
1425 modest_account_mgr_get_has_connection_specific_smtp().
1427 (modest_account_mgr_set_connection_specific_smtp),
1428 (modest_account_mgr_remove_connection_specific_smtp),
1429 (modest_account_mgr_get_has_connection_specific_smtp),
1430 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1431 connection-specific smtp server accounts in the account, rather than
1432 the server account conf dir.
1434 This fixes bug projects.maemo.org bug NB#58263 .
1436 * src/modest-tny-account-store.c:
1437 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1438 if there are no server accounts yet, to prevent an infinite loop when there
1439 are no accounts. Document that one must be called before the other.
1441 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1443 * src/modest-account-mgr-helpers.c:
1444 (modest_account_mgr_get_default_account): Make sure that at least
1445 one account is always the default, if there are any enabled accounts.
1446 This is just a sanity check that shouldn't be necessary.
1448 * src/modest-account-mgr-priv.c:
1449 (_modest_account_mgr_account_from_key): Unescape the conf key to
1450 get the real account name. For instance, this is an issue if a space
1451 was in the account name, which can happen because the account name
1452 is generated from the display name.
1453 (_modest_account_mgr_get_account_keyname): Always escape the
1455 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1456 Unescape the conf keys to get the real account names.
1458 For instance, previously the is-default radio button in the accounts
1459 list was not checked for any accounts at first. This fixes that,
1460 and might fix several similar bugs.
1462 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1465 Removed some debug printfs.
1467 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1469 Modest on-disk outbox directories are now here, for instance:
1470 $HOME/.modest/outboxes/<account-id-1>/outbox
1471 $HOME/.modest/outboxes/<account-id-2>/outbox
1473 $HOME/.modest/local-folders/outbox
1474 so we can have a separate outbox for each account.
1475 But they are shown as one outbox in the GtkTreeView, by using a
1476 TnyMergeFolder in a ModestTnySimpleFolderStore.
1479 * src/modest-tny-simple-folder-store.c:
1480 * src/modest-tny-simple-folder-store.h:
1481 Added ModestTnySimpleFolderStore, used to contain folders from
1482 other folder stores, such as other accounts.
1484 * src/modest-tny-outbox-account.h:
1485 * src/modest-tny-outbox-account.c:
1486 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1487 used for the per-account local outbox folders.
1489 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1490 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1491 only use this (internally) now for the non-outbox local folders.
1493 * src/modest-init.h:
1494 * src/modest-init.c: Added modest_init_one_local_folder(), for
1495 setting up the directory structure for each local folder.
1497 * src/modest-local-folder-info.c:
1498 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1499 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1501 * src/modest-local-folder-info.h:
1502 * src/modest-tny-account-store.c: (on_account_removed),
1503 (on_account_changed), (create_per_account_local_outbox_folders),
1504 (get_server_accounts), (modest_tny_account_store_get_accounts),
1505 (modest_tny_account_store_get_tny_account_by_account),
1506 (modest_tny_folder_store_is_virtual_local_folders):
1508 * src/modest-tny-account.h:
1509 * src/modest-tny-account.c:
1510 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1511 to create an on-disk per-account local outbox folder for each
1513 (create_per_account_local_outbox_folders): Create a local outbox folder
1514 for each transport account.
1515 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1516 for all local folders.
1518 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1519 instead of using g_object_get/set() directly. It is clearer.
1521 (modest_tny_folder_store_get_message_count),
1522 (modest_tny_folder_store_get_local_size
1523 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1524 because we now use these with non-acount folder stores.
1526 (modest_tny_account_get_special_folder),
1527 (modest_tny_account_new_from_server_account),
1528 (modest_tny_account_new_from_account):
1529 (recurse_folders): Adjust to the new outbox system.
1531 * src/modest-tny-folder.h:
1532 * src/modest-tny-folder.c:
1533 (modest_tny_folder_is_local_folder),
1534 (modest_tny_folder_get_local_folder_type),
1535 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1537 * src/widgets/modest-main-window.h:
1538 * src/maemo/modest-main-window.c: (create_details_widget),
1539 (modest_main_window_set_contents_style): Show details for any folder store,
1542 (modest_tny_folder_get_rules):
1543 Remove the const. C does not support constness enough for this.
1545 * src/modest-ui-actions.c:
1546 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1547 make all outboxes appear as one, in the usual local-folders tree node.
1549 (set_active_account_from_tny_account),
1550 (modest_ui_actions_on_folder_selection_changed):
1551 * src/widgets/modest-folder-view.c: (text_cell_data),
1552 (icon_cell_data), (filter_row),
1553 (add_account_folders_to_merged_folder),
1554 (add_account_folders_to_simple_folder_store), (),
1555 (get_cmp_rows_type_pos), (cmp_rows),
1556 (modest_folder_view_set_account_id_of_visible_server_account):
1557 Adjust to the new outbox system, using generic folder stores and folders
1558 in the GtkTreeModel.
1560 2007-05-23 Christian Kellner <ckellner@openismus.com>
1562 * src/modest-mail-operation.c:
1563 (modest_mail_operation_update_account):
1564 Use info->max_size instead of unintialized local var [small
1565 build fix]. (Added TODO to review that change since I don't
1568 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1570 * libmodest-dbus-client/libmodest-dbus-client.c:
1571 (libmodest_dbus_client_compose_mail): function added
1572 * src/dbus_api/modest-dbus-api.h:
1573 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1574 (on_compose_mail): Implementation of the SendAsMail functionality
1576 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1578 * src/modest-account-mgr.c:
1579 (modest_account_mgr_add_server_account): Set the secure-connection
1580 conf key for transport accounts as well as store accounts. I don't know
1581 why the if was there. For instance, this makes sure that we use SSL
1582 for the gmail preset from the easysetup wizard.
1584 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1586 * src/gnome/modest-main-window.c:
1587 (on_account_store_connecting_finished), (connect_signals):
1588 * src/maemo/modest-main-window.c:
1589 (on_account_store_connecting_finished), (connect_signals),
1590 (modest_main_window_new):
1591 Handle TnyAccountStore::connecting-finished instead of
1592 TnyDevice::connection-changed, because we cannot actually perform
1593 operations on accounts until TnyAccountStore has itself responded to
1594 the TnyDevice::connection-changed signal. This prevents a GError from
1596 Do not try to update at startup, because we (at least on scratchbox)
1597 already do an update at startup when the device goes online.
1598 This prevents a GError from tinymail.
1599 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1600 Added TODO about stopping simultaneous operations.
1602 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1604 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1605 * src/modest-mail-operation-queue.c:
1606 (modest_mail_operation_queue_remove):
1607 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1608 about where they happened.
1610 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1612 * src/modest-ui-actions.c:
1613 (modest_ui_actions_on_password_requested): Make sure that the remember
1614 output parameter is always TRUE.
1616 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1618 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1619 Show a OK/Cancel dialog if the error is a question, though we still do not
1620 know anything more about what we are asking the user.
1621 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1622 Fix an uninitialized variable (helper). This is a logic error, however.
1624 2007-05-21 Christian Kellner <ckellner@openismus.com>
1626 * src/modest-search.h:
1627 Correct bit shifting in the ModestSearchFlags enum.
1629 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-tny-account.c:
1632 (modest_tny_account_new_from_server_account): Do not use the lsub and
1633 check-all hard-coded IMAP options when using POP.
1635 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1637 * src/modest-tny-account.c:
1638 (modest_tny_account_new_from_server_account):
1639 Use NULL for the secure-auth method for POP when Password auth has been
1640 specified by the user, as we already do for IMAP. "auth=Login" causes
1641 an error from camel or the server.
1643 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/modest-account-settings-dialog.c:
1646 (create_page_account_details),
1647 (modest_account_settings_dialog_set_account_name):
1648 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1649 for the leave-on-server checkbox, rathr than just the checkbox, when
1650 the protocol is not POP.
1652 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1654 * src/widgets/modest-account-view.c:
1655 * src/widgets/modest-account-view.h:
1656 Added modest_account_view_select_account() which will be useful later
1657 to asynchronously re-select the edited account.
1659 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1661 * src/maemo/modest-account-settings-dialog.c:
1662 (modest_account_settings_dialog_set_account_name):
1663 Automatically choose the port numbers based on the secure authentication
1664 methods, if they have not been chosen before.
1665 This fixes projects.maemo.org bug NB#56273 .
1667 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1669 * src/maemo/modest-main-window-ui.h:
1670 * src/modest-ui-actions.c:
1671 * src/modest-ui-actions.h:
1672 Connect the Tools/SMTP Servers menu item to
1673 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1674 SMTP servers dialog, as in the UI specification and saves changes when it
1675 is closed. This fixed projects.maemo.org bug NB#56305 .
1677 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1679 * src/maemo/modest-connection-specific-smtp-window.c:
1680 (modest_connection_specific_smtp_window_init):
1681 Use gtk_window_set_default_size() to make this window big enough, so
1682 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1684 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1686 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1687 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1688 (modest_connection_specific_smtp_edit_window_init),
1689 Do not try to connect to a combobox signal before the combobox exists.
1690 This fixes the cras in projects.maemo.org bug NB#56288 .
1691 (modest_connection_specific_smtp_edit_window_get_settings):
1692 Remove the server_account_name parameter which was being checked for NULL
1693 though it was not used.
1695 * src/maemo/modest-connection-specific-smtp-window.c:
1696 (modest_connection_specific_smtp_window_fill_with_connections),
1697 (on_button_edit), (modest_connection_specific_smtp_window_init):
1698 Correct the number of treemodel columns to prevent a warning.
1699 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1700 libconic does not work.
1702 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1704 * src/modest-tny-account.c:
1705 (modest_tny_account_new_from_server_account):
1706 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1707 SMTP when "None" was chosen by the user. However, with my SMTP server that
1708 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1711 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1713 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1714 to explain the memory management issue with the ID in the ModestPair.
1716 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1717 (add_sending_page), (modest_account_assistant_finalize):
1718 * src/gnome/modest-gnome-global-settings-dialog.c:
1719 (create_updating_page), (create_composing_page):
1720 * src/gnome/modest-msg-edit-window.c: (get_transports),
1721 (init_window), (modest_msg_edit_window_finalize),
1722 (modest_msg_edit_window_get_msg_data):
1723 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1724 * src/gnome/modest-transport-widget.c:
1725 (modest_transport_widget_finalize), (smtp_configuration):
1726 * src/maemo/modest-maemo-global-settings-dialog.c:
1727 (create_updating_page), (create_composing_page):
1728 * src/maemo/modest-msg-edit-window.c: (get_transports),
1729 (init_window), (modest_msg_edit_window_finalize),
1730 (modest_msg_edit_window_get_msg_data),
1731 (modest_msg_edit_window_free_msg_data):
1732 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1733 (modest_store_widget_finalize):
1734 * src/maemo/modest-transport-widget.c:
1735 (modest_transport_widget_finalize), (smtp_configuration):
1736 * src/modest-main.c: (send_mail):
1737 * src/widgets/modest-combo-box.h:
1738 * src/widgets/modest-global-settings-dialog-priv.h:
1739 * src/widgets/modest-global-settings-dialog.c:
1740 (modest_global_settings_dialog_finalize):
1741 * src/widgets/modest-msg-edit-window.h:
1742 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1743 as long as the combo box, to prevent use of freed memory for the ID.
1745 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1747 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1748 get_accounts(), to make this clearer. Do not check for the enabled gconf
1749 key, because we do not use this for server accounts (at least, not yet).
1750 This allows us to send email again.
1752 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1754 * src/maemo/modest-platform.c:
1755 (on_modest_conf_update_interval_changed), (modest_platform_init):
1756 Only respond to this particular key change. All these strcmp()s cannot be
1759 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1761 * src/maemo/modest-maemo-global-settings-dialog.c:
1762 (current_connection): Prevent a crash in scratchbox when
1763 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1764 * src/maemo/modest-platform.c:
1765 (on_modest_conf_update_interval_changed), (modest_platform_init):
1766 Get the update interval from gconf and reset it when the gconf key changes.
1768 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1770 * src/modest-protocol-info.c:
1771 * src/modest-protocol-info.h: Adde enum-specific get functions,
1772 instead of using a ModestProtocolType enum parameter.
1774 * src/gnome/modest-account-assistant.c:
1775 * src/gnome/modest-store-widget.c:
1776 * src/gnome/modest-store-widget.h:
1777 * src/gnome/modest-transport-widget.c:
1778 * src/gnome/modest-transport-widget.h:
1779 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1780 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1781 * src/maemo/easysetup/modest-easysetup-wizard.c:
1782 * src/maemo/modest-account-settings-dialog.c:
1783 * src/maemo/modest-account-settings-dialog.h:
1784 * src/maemo/modest-store-widget.c:
1785 * src/maemo/modest-store-widget.h:
1786 * src/maemo/modest-transport-widget.c:
1787 * src/maemo/modest-transport-widget.h:
1788 * src/modest-account-mgr-helpers.c:
1789 * src/modest-account-mgr-helpers.h:
1790 * src/modest-account-mgr.c:
1791 * src/modest-account-mgr.h:
1792 * src/modest-tny-account.c:
1793 * src/modest-tny-folder.c:
1794 * src/widgets/modest-account-view.c:
1795 * src/widgets/modest-retrieve-combo-box.c:
1796 * src/widgets/modest-retrieve-combo-box.h:
1797 * src/widgets/modest-secureauth-combo-box.c:
1798 * src/widgets/modest-serversecurity-combo-box.c:
1799 * src/widgets/modest-serversecurity-combo-box.h:
1800 * tests/check_account-mgr.c:
1801 Use the specific functions, and use the re-renamed enum values for GNOME too.
1803 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1805 * src/modest-pair.h:
1806 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1807 so we can get the second based on the first.
1809 * src/maemo/modest-account-settings-dialog.h:
1810 * src/maemo/modest-account-settings-dialog.c:
1811 Added get_supported_secure_authentication_methods(), though it is mostly
1812 commented-out for now until the necessary API is committed to tinymail.
1813 (modest_account_settings_dialog_set_account_name),
1814 (save_configuration): Request the supported authentication methods from the
1815 server, so we can choose a working method.
1817 * src/modest-tny-account-store.h:
1818 * src/modest-tny-account-store.c:
1819 (modest_tny_account_store_get_session): Rename from
1820 tny_account_store_get_session().
1822 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-protocol-info.h: Split the ModestProtocol enum
1825 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1826 There was no need to have these unrelated values in one enum.
1828 * src/: many files: Adapted to changed enum. This makes the code a bit
1829 clearer, and the compiler could catch some errors.
1831 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1833 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1834 Show the detailed internal camel error message when an error happens
1835 during the configuration, so that our testers can give us more clues.
1836 For instance, in projects.maemo.org bug NB#56910 .
1838 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1840 * src/modest-tny-account.c:
1841 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1842 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1844 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1846 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1847 * src/maemo/modest-account-settings-dialog.c:
1848 (modest_account_settings_dialog_set_account_name),
1849 (save_configuration): For the incoming secure authentication checkbox,
1850 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1851 the UI specification. PLAIN does not seem to be supported for most IMAP
1852 servers anyway, and I am not sure what it would mean.
1853 However, we probably need to discover which of the secure-authentication
1854 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1855 * src/modest-account-mgr-helpers.c:
1856 (modest_account_mgr_get_server_account_data):
1858 * src/modest-tny-account.c:
1859 (modest_tny_account_new_from_server_account):
1860 Use tny_account_set_mech() to set secure-authentication methods,
1861 with some special-casing for IMAP, based on my observations of how
1864 * src/modest-account-mgr-helpers.h:
1865 * src/modest-account-mgr.c:
1866 * src/modest-defs.h: Comment that the URI is only used for local folders.
1868 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1870 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1871 parameter const, just to be neat.
1872 * src/modest-text-utils.c: (modest_text_utils_inline):
1873 End g_strconcat() with NULL, as its documentation says. This is almost
1874 certainly the cause of my crash at startup on the device. Interestingly,
1875 valgrind doesn't tell us about these errors.
1877 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1879 * scripts/build-packages: Added more precise comments about how to use
1880 this script, though I still get this error:
1881 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1882 error building tinymail
1884 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/modest-main-window.c: (on_account_update):
1887 Very slight cleanup, hoping to make it simpler to discover what causes
1888 a crash here sometimes.
1890 * src/modest-tny-account.c:
1891 (modest_tny_account_new_from_server_account): Set the port. Added
1892 comments about the options and a TODO comment because I need to find out
1893 how to specify the secure authentication method.
1895 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1897 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1898 changed CFlags paths form modest to libmodest
1900 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1902 * src/modest-account-mgr-helpers.c:
1903 (modest_account_mgr_get_server_account_data),
1904 (modest_account_mgr_free_server_account_data):
1905 * src/modest-account-mgr-helpers.h:
1906 * src/modest-account-mgr.c:
1907 (modest_account_mgr_add_server_account):
1908 * src/modest-defs.h:
1909 * src/modest-tny-account.c:
1910 (modest_tny_account_new_from_server_account):
1911 Determine the options for tny_camel_account_add_option() here,
1912 based on the settings, rather than storing them directly in gconf.
1914 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1916 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1917 Show a more friendly error dialog now that we expect (from the tinymail
1918 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1920 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1922 * src/maemo/modest-main-window.c: (on_account_update): Check that
1923 account_name is not NULL, to prevent a crash at startup that I am
1924 seeing on the N800. I do wonder why it is NULL.
1926 * src/maemo/easysetup/modest-easysetup-wizard.c:
1927 (create_page_user_details):
1928 * src/maemo/modest-account-settings-dialog.c:
1929 (create_page_user_details), (create_page_outgoing):
1930 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1931 (modest_connection_specific_smtp_edit_window_init):
1932 * src/modest-ui-actions.c:
1933 (modest_ui_actions_on_password_requested):
1934 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1935 might do something useful with the on-screen keyboard.
1937 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1939 * src/maemo/modest-main-window.c: (on_account_update):
1940 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1941 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1943 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1945 * src/modest-tny-account-store.c: (on_account_changed):
1946 Correct the signature of this signal handler.
1948 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1950 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1951 Show a HildonNote instead of a GtkDialog for Maemo.
1953 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1955 * src/widgets/modest-account-view.h:
1956 * src/widgets/modest-account-view.c: (on_account_changed),
1957 (on_account_removed). Added a boolean flag, set/unset by
1958 modest_account_view_block_conf_updates(),
1959 modest_account_view_unblock_conf_updates() to prevent unnecessary
1960 updates, but this is not very useful because the gconf notifications are
1961 so delays (maybe only on Maemo Bora).
1962 So auto-updating is turned off, and these functions do an explicit
1963 update when necessary.
1964 However, something else is still doing too much work when adding/removing
1965 accounts, probably in another part of the application.
1967 * src/maemo/modest-account-view-window.c:
1968 (on_delete_button_clicked), (on_edit_button_clicked),
1969 (on_new_button_clicked): Use the new functions.
1971 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1973 * src/modest-account-mgr-helpers.c:
1974 (modest_account_mgr_set_first_account_as_default):
1975 Sort the list of names alphabetically-by-title, so we choose the first one
1977 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1978 alphabetically by the title.
1980 This fixes projects.maemo.org bug NB#56418 .
1982 * src/modest-account-mgr-priv.c:
1983 (_modest_account_mgr_account_from_key):
1984 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1985 avoid a valgrind error, and possible random behaviour.
1987 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1989 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1990 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1991 tinymail documentation to say that this can be expected.
1992 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1993 pretty, and should not happen, but I would prefer to know when it does.
1995 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1997 * configure.ac: When using the older hildon version, probably on Bora,
1998 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2000 * src/widgets/modest-attachment-view.c:
2001 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2004 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2006 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2007 Implemented the prototype. Can be tested with
2008 tests/dbus_api/test_open_message:
2010 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-tny-account-store.c:
2013 (modest_tny_account_store_instance_init), (get_password):
2014 * src/modest-ui-actions.c:
2015 (modest_ui_actions_on_password_requested):
2016 Do not store the password in gconf, because this function is called
2017 for non-remembered passwords. Actually use the cached (in the hash map)
2018 password instead of releasing it.
2019 The password will now not be remembered if it is asked via the protected
2020 password dialog, as per the UI spec.
2022 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2024 * src/modest-defs.h:
2025 * src/modest-account-mgr-helpers.h:
2026 * src/modest-account-mgr-helpers.c:
2027 Added modest_server_account_get_username_has_succeeded(),
2028 modest_server_account_set_username_has_succeeded().
2029 (modest_server_account_set_username),
2030 Reset the has-succeeded flag if the username changes.
2032 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2033 * src/maemo/modest-connection-specific-smtp-window.c:
2034 (modest_connection_specific_smtp_window_save_server_accounts):
2035 Use modest_server_account_set_username() instead of using
2036 modest_conf_set_string() directly, so that the has-succeeded flag is always
2039 * src/modest-ui-actions.c:
2040 (modest_ui_actions_on_password_requested): Dim the username entry if
2041 the username has ever worked, as per the UI spec.
2043 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2045 * src/modest-tny-account-store.c: (get_password):
2046 * src/modest-ui-actions.c:
2047 (modest_ui_actions_on_password_requested):
2048 Allow the username to be changed too, though there is more work to
2049 be done on exactly how this behaves.
2051 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2053 * src/modest-account-mgr-helpers.h:
2054 * src/modest-account-mgr-helpers.c:
2055 Added modest_account_mgr_get_display_name(),
2056 modest_server_account_get_username(),
2057 modest_server_account_set_username(),
2058 modest_server_account_set_password(),
2059 modest_server_account_get_hostname() functions so we do not need to
2060 use the conf API directly.
2062 * src/maemo/modest-main-window.c: (connect_signals):
2063 Actually connect ot the ModestAccountStore::request-password signal,
2064 so that we show the dialog when the password is requested by Tinymail,
2065 for isntance if it is empty.
2067 * src/modest-marshal.list:
2068 * src/modest-tny-account-store.c:
2069 (modest_tny_account_store_class_init), (get_password),
2070 (modest_tny_account_store_alert):
2071 * src/modest-tny-account-store.h:
2072 * src/modest-ui-actions.h:
2073 * src/modest-ui-actions.c:
2074 (modest_ui_actions_on_password_requested):
2075 Change the signal parameters, so it is obvious that we are providing
2076 the non human-readable server name, and receiving both the username
2077 and password, though changing of the username is not yet implemented.
2078 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2079 for the GNOME version.
2081 This should fix the projects.maemo.org bug NB#56209, though it does not
2082 work on Bora, because the gconf_client_get() for the password fails
2083 immediately after we save it with gconf_client_set().
2085 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2088 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2089 caused an undefined symbol error:
2090 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2092 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2094 * src/modest-tny-account-store.c:
2095 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2096 using a GError instead of a string message, so we can translate it in
2099 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2101 * src/maemo/modest-address-book.c:
2102 (modest_address_book_check_names):
2103 * src/maemo/modest-msg-view-window.c:
2104 (modest_msg_view_window_clipboard_owner_change):
2105 * src/modest-init.c: (modest_init_init_ui):
2106 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2107 (update_folders_cb), (modest_mail_operation_update_account):
2108 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2109 (modest_ui_actions_on_msg_attachment_clicked),
2110 (modest_ui_actions_on_msg_recpt_activated):
2111 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2112 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2113 (modest_msg_view_search_next):
2114 * src/widgets/modest-recpt-editor.c:
2115 (modest_recpt_editor_on_button_release_event),
2116 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2117 g_message(). At this point we should only be seeing interesting errors on
2118 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2120 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2122 (modest_wizard_dialog_force_title_update):
2123 * src/maemo/easysetup/modest-wizard-dialog.h:
2124 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2125 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2126 can update the title when appropriate. Otherwise the title is wrong if the
2127 pages are added after adding the notebook to the dialog.
2128 This must be a problem in HildonWizardDialog too.
2129 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2131 * src/maemo/easysetup/modest-easysetup-wizard.c:
2132 (create_subsequent_customsetup_pages),
2133 (create_subsequent_easysetup_pages):
2134 Call modest_wizard_dialog_force_title_update() so that the title is
2135 correct even with GTK+ < 2.10.
2136 This fixes projects.maemo.org bug NB#56145 .
2138 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/modest-platform.c:
2141 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2142 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2145 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2147 * src/widgets/modest-window.h:
2148 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2149 and modest_window_save_state(), which invokes it.
2151 * src/widgets/modest-window-mgr.h:
2152 * src/widgets/modest-window-mgr.c:
2153 Added modest_window_mgr_save_state_for_all_windows(), which calls
2154 the save_state vfunc on all registered windows, if implemented.
2156 * src/gnome/modest-msg-edit-window.c:
2157 * src/gnome/modest-msg-view-window.c:
2158 * src/maemo/modest-msg-edit-window.c:
2159 * src/maemo/modest-msg-view-window.c:
2160 * src/maemo/modest-main-window.c:
2161 Specify the existing save_settings functions as implementations of
2162 ModestWindow::save_state_func().
2164 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2165 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2166 enabling hibernation, for instance.
2168 We may need to do the same thing for restoring settings.
2171 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2173 * src/widgets/modest-window-mgr.c:
2174 * src/widgets/modest-window-mgr.h:
2175 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2176 modest_window_mgr_get_hibernation_is_prevented().
2178 * src/maemo/modest-main-window.c:
2179 (on_hildon_program_is_topmost_notify): Prevent hibernation
2180 (possible when the application goes to the background in the WM),
2181 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2183 * src/maemo/easysetup/modest-easysetup-wizard.c:
2184 (modest_easysetup_wizard_dialog_init):
2185 * src/maemo/modest-account-settings-dialog.c:
2186 (modest_account_settings_dialog_init):
2187 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2188 (modest_connection_specific_smtp_edit_window_init):
2189 * src/maemo/modest-connection-specific-smtp-window.c:
2190 (modest_connection_specific_smtp_window_init):
2191 * src/maemo/modest-signature-editor-dialog.c:
2192 (modest_signature_editor_dialog_init):
2193 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2194 prevent hibernation while any of these account settings dialogs are open.
2196 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2198 * src/maemo/Makefile.am:
2199 * src/maemo/modest-osso-state-saving.c:
2200 * src/maemo/modest-osso-state-saving.h: Added
2201 modest_osso_load_state() and modest_osso_save_state() though they do
2202 nothing now. They should iterate through all the open windows and load/save
2204 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2205 save state when closing.
2207 * src/maemo/modest-main-window.c:
2208 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2209 Add a notification handler for the HildonProgram::is-topmost property,
2210 so we can allow hibernation when the application goes into the background.
2211 But we still need to detect when the accounts setup windows are open so
2212 we can stop hibernation when they are open.
2213 To do this, I also added the main window the HildonProgram. This might have
2214 other side-effects/benefits, and should maybe be done for other windows.
2216 * src/maemo/modest-osso-autosave-callbacks.h:
2217 * src/maemo/modest-osso-autosave-callbacks.c:
2218 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2219 though it does not do anything yet, and we might never need this to do
2220 anything. For instance, we already save drafts.
2222 * src/maemo/modest-platform.c: (modest_platform_init):
2223 Specify the libosso auto-save callback.
2225 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2227 * src/maemo/modest-platform.c:
2228 (modest_platform_set_update_interval):
2229 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2230 aparently stays valid between application instances, so we can use this
2231 to remove and reset it later. According to a maemo-developers email from
2234 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2236 * configure.ac: Depend on libalarm for Maemo.
2238 * src/dbus_api/modest-dbus-api.h:
2239 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2240 (on_send_receive), (modest_dbus_req_handler):
2241 Handle a SEND_RECEIVE D-Bus method.
2243 * libmodest-dbus-client/libmodest-dbus-client.c:
2244 (libmodest_dbus_client_send_and_receive):
2245 * libmodest-dbus-client/libmodest-dbus-client.h:
2246 Add C convenience functions for calling the new D-Bus method.
2248 * src/modest-platform.h:
2249 * src/gnome/modest-platform.c:
2250 * src/maemo/modest-platform.c:
2251 Added modest_platform_set_update_interval(), which uses the
2252 alarmd API on Maemo.
2253 (modest_platform_init),
2254 Call modest_platform_set_update_interval(), using a hard-coded
2255 interval for now (until the global settings dialog is implemented),
2256 though I am not sure that this makes sense yet.
2258 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2260 * src/dbus_api/modest-dbus-callbacks.c:
2261 (modest_osso_cb_hw_state_handler):
2262 * src/dbus_api/modest-dbus-callbacks.h:
2263 * src/maemo/modest-platform.c: (modest_platform_init):
2264 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2265 in case this has some effect on the ability for Maemo to ping the
2268 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2270 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2271 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2272 warning. It is probably a logic error, but I need to fix the build.
2274 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2276 * src/modest-account-mgr.h:
2277 * src/modest-account-mgr.c:
2278 (modest_account_mgr_account_names): Add a gboolean enabled_only
2279 parameter, so we can get lists of onlt the enabled accounts.
2281 (modest_account_mgr_add_account),,
2282 (modest_account_mgr_account_with_display_name_exists):
2283 * src/maemo/modest-msg-edit-window.c: (get_transports):
2284 * src/modest-account-mgr-helpers.c:
2285 (modest_account_mgr_set_first_account_as_default):
2286 * src/modest-init.c: (init_default_account_maybe):
2287 * src/modest-tny-account-store.c: (get_accounts):
2288 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2289 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2290 * tests/check_account-mgr.c: (START_TEST):
2291 Provide the extra parameter, as appropriate.
2293 * src/widgets/modest-account-view.c: (update_account_view):
2294 Do not show disabled accounts (meaning that there is no way to
2295 enable/disable accounts in the UI (the feature is not in our UI
2296 specification), so we can use this internally only to mark unfinished
2297 or temporary account data.
2299 * src/maemo/easysetup/modest-easysetup-wizard.c:
2300 (create_account): Add boolean enable parameter, so we can specify FALSE
2301 to create the temporary account.
2302 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2303 (on_before_next): When finishing, when there is a temporary account, just
2305 Also, use a timeout to delay the showing of the dialog until gconf is likely
2306 to return correct information, due to a maemo gconf bug that is fixed in
2307 osso 1.1, but not yet in Bora.
2308 However, the dialog stays on screen after it is destroyed.
2310 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2311 for invalid data when cancelling. Use a hildon note instead of a dialog
2312 to complain about invalid data. Do not show the account-saved note if the
2313 account is disabled (a temporary account that will not really be saved for use
2316 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2318 * src/modest-account-mgr-helpers.h:
2319 * src/modest-account-mgr-helpers.c:
2320 Added modest_account_mgr_unset_default_account(),
2321 Added modest_account_mgr_set_first_account_as_default().
2323 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2324 If it was the default account, unset the default account name.
2326 * src/maemo/modest-account-view-window.c:
2327 (on_delete_button_clicked): If it was the default account,
2328 set the first remaining account as the default instead.
2330 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2331 a NULL account or a NULL default account, to prevent a crash. This should
2332 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2335 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2337 * src/widgets/modest-recpt-editor.c:
2338 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2339 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2340 TODO comment for this. This fixes the build.
2342 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2343 be the best place for it. This will in future update all auto-update accounts,
2344 rather than just the current/default account, when that gconf key exists.
2345 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2346 if there are no accounts, before calling do_send_receive().
2347 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2349 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2350 * src/maemo/modest-main-window-ui.h:
2351 * src/maemo/modest-main-window.c: (on_connection_changed),
2352 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2353 directly, becaue the signal handler does more.
2355 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2357 * src/modest-account-mgr-helpers.c:
2358 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2359 for the case that the account does not exist.
2361 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2362 (equivalent to the modest account name) rather than the tinymail account name
2363 (equivalent to the modest account title - human readable) to get the account data.
2364 Check for null account data to prevent the crash, and add a TODO comment saying that
2365 this needs fixing because it is using the server account name instead of the account name.
2367 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2369 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2370 * src/maemo/modest-account-settings-dialog.c: (show_error),
2372 Use hildon_note_new_information() for informative and error messages,
2373 which seems to be expected for Maemo applications (no documentation that I know of
2374 says this). I am surprised that there is no distinction between info and error
2377 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2379 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2380 it is easy to find where this is used.
2382 * src/maemo/easysetup/modest-easysetup-wizard.c:
2383 (create_page_welcome), (create_page_account_details),
2384 (create_page_user_details), (create_page_complete_easysetup),
2385 (create_page_custom_incoming), (create_page_custom_outgoing),
2386 (create_page_complete_custom):
2387 * src/maemo/modest-account-settings-dialog.c:
2388 (create_page_account_details), (create_page_user_details),
2389 (create_page_incoming), (create_page_outgoing):
2390 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2391 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2392 (modest_connection_specific_smtp_edit_window_init):
2393 * src/maemo/modest-connection-specific-smtp-window.c:
2394 (modest_connection_specific_smtp_window_init):
2395 * src/maemo/modest-signature-editor-dialog.c:
2396 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2397 and scrolling policy as per the Email Application Layout Guide, if I have
2400 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2402 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2403 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2404 which were empty, because these vfuncs have been removed from TnyAccountStore.
2405 This fixes the build.
2407 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2409 * src/maemo/modest-main-window.c:
2410 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2411 showing/hiding it. Added TODO because it probably should not be NULL.
2412 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2413 because unnecessary g_warnings() make degugging difficult.
2415 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2417 * src/maemo/modest-msg-edit-window.c:
2418 (modest_msg_edit_window_select_color),
2419 (modest_msg_edit_window_select_background_color): 2 const corrections and
2420 moving 2 #endifs before closing brackets, to fix the build.
2422 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2424 * src/maemo/easysetup/modest-easysetup-wizard.h:
2425 * src/maemo/easysetup/modest-easysetup-wizard.c:
2426 (modest_easysetup_wizard_dialog_finalize),
2427 (on_button_edit_advanced_settings), (create_page_complete_custom),
2428 (on_response), (create_account):
2429 Implement the Advanced Settings edit button, by saving the account information,
2430 for the Advanded Settings dialog to use directly from gconf, and removing it
2431 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2432 Bug #5533 in the projects.maemo.org bugzilla.
2434 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2436 * src/maemo/modest-msg-view-window.c:
2437 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2438 when opening a message window.
2440 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2442 * src/maemo/easysetup/modest-easysetup-wizard.c:
2443 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2446 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2447 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2448 gconf settings. I probably added more checks than necessary, but that is safer.
2450 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2451 variable to fix the build, but this seems to be used when it is still NULL.
2453 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2455 * src/modest-platform.h:
2456 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2457 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2458 * src/modest-main.c: Implement this function so we can avoid using
2459 maemo-specific API from cross-platform code.
2461 * src/modest-tny-account-store.c:
2462 (get_smtp_specific_transport_account_for_open_connection):
2463 * src/modest-ui-actions.c: (check_for_connection),
2464 (modest_ui_actions_on_item_not_found):
2465 Use modest_platform_connect_and_wait() and put #idefs around other
2466 maemo-specific code, because only maemo currently has a way to
2467 identify connection names.
2469 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2471 * src/modest-tny-account-store.h:
2472 * src/modest-tny-account-store.c:
2473 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2474 the connection-specific SMTP server settings in the configuration.
2476 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2478 * src/maemo/modest-main-window.c: (on_connection_changed),
2480 * src/modest-main.c: (main), (start_ui), (send_mail):
2481 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2482 that is what is intended.
2484 * src/modest-ui-actions.c: (action_send), (action_receive),
2485 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2486 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2487 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2488 SMTP server is used when it is specified.
2490 (modest_ui_actions_on_send_receive):
2491 Check that a connection is open before proceeding.
2492 Receive and then send, instead of vice-versa, as per the specification.
2494 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2496 * src/modest-mail-operation.c:
2497 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2498 though I guess it should be something other than NULL.
2500 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2502 * src/maemo/easysetup/modest-easysetup-wizard.c:
2503 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2504 combo twice, to avoid an g_warning and to make it visible again.
2505 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2506 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2507 (already intended) dereference when detaching, because we then recreate the menu.
2508 But I am not sure why the warning was happening, and it is possible that this is a memory
2511 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2513 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2514 and uri_parse_mailto() utility functions.
2515 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2517 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2519 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2521 * src/dbus_api/modest-dbus-api.h:
2522 * src/dbus_api/modest-dbus-callbacks.c:
2523 Use an idle callback to execute the modest code in the application's own thread.
2524 Remove the helloworld example method.
2525 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2526 parsed, and the open-message method is not implemented because this is not yet implemented in
2528 * libmodest-dbus-client/libmodest-dbus-client.c:
2529 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2530 (libmodest_dbus_client_open_message):
2531 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2533 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2534 body without crashing.
2536 * tests/dbus_api/Makefile.am:
2537 * tests/dbus_api/test_mail_to.c:
2538 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2540 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2542 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2543 Added file to fix the build. Sorry.
2545 * src/dbus_api/Makefile.am:
2546 * src/dbus_api/modest-dbus-api.h:
2547 * src/dbus_api/modest-dbus-callbacks.h:
2548 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2549 (modest_dbus_req_handler):
2550 Put constants in a separate header so it can be reused by the
2551 client library, without duplication
2553 * libmodest-dbus-client/Makefile.am:
2554 * libmodest-dbus-client/libmodest-dbus-client.c:
2555 (libmodest_dbus_client_call_helloworld),
2556 (libmodfest_dbus_client_send_mail),
2557 (libmodfest_dbus_client_mailto),
2558 (libmodfest_dbus_client_open_message):
2559 * libmodest-dbus-client/libmodest-dbus-client.h:
2560 (Partly) Implement a send_mail D-Bus method.
2562 * tests/dbus_api/Makefile.am:
2563 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2564 the send_email D-Bus method.
2566 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2570 * libmodest-dbus-client/Makefile.am:
2571 * libmodest-dbus-client/libmodest-dbus-client.c:
2572 * libmodest-dbus-client/libmodest-dbus-client.h:
2573 * tests/dbus_api/Makefile.am:
2574 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2575 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2577 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/easysetup/modest-easysetup-wizard.c:
2580 (create_page_account_details):
2581 * src/maemo/modest-account-settings-dialog.c:
2582 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2583 widgets, because this might not be the default in future versions of the Maemo GTK+.
2584 However, I can not not get capitalization to work even in a simple test case.
2586 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2588 * src/maemo/easysetup/modest-easysetup-wizard.c:
2589 (create_page_custom_incoming), (create_page_custom_outgoing):
2590 * src/maemo/modest-account-settings-dialog.c:
2591 (create_page_account_details), (create_page_incoming),
2592 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2593 instead of using gtk_check_button_with_label(), so they are aligned like the other
2594 widgets, as per the UI spec.
2596 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2598 * src/maemo/easysetup/modest-easysetup-wizard.c:
2599 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2600 * src/widgets/modest-validating-entry.c:
2601 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2602 Modest prefix instead of an EasySetup prefix.
2604 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2606 * src/widgets/modest-validating-entry.h:
2607 * src/widgets/modest-validating-entry.c: (on_insert_text),
2608 Added easysetup_validating_entry_set_max_func(), used to set a callback
2609 to call when the max number of characters is reached. GtkEntry has a max-length
2610 already but is silent about it.
2612 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2613 (create_page_account_details), (create_page_user_details),
2615 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2616 (create_page_account_details), (create_page_user_details),
2617 (create_page_outgoing):
2618 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2619 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2620 the UI spec, when the user tries to enter more than the max number of characters.
2622 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2624 * src/maemo/easysetup/modest-easysetup-wizard.c:
2625 (create_page_user_details), (create_page_custom_incoming),
2626 (create_page_custom_outgoing):
2627 * src/maemo/modest-account-settings-dialog.c:
2628 (create_page_user_details), (create_page_incoming),
2629 (create_page_outgoing):
2630 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2631 (modest_connection_specific_smtp_edit_window_init):
2632 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2633 not appropriate. Bad Maemo-specific defaults!.
2635 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2637 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2638 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2639 (modest_signature_editor_dialog_set_settings):
2640 Disable the label and textview when the checkbox is disabled, and use the
2641 specified (UI spec) default signature text.
2643 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2645 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2646 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2648 * src/modest-defs.h:
2649 * src/modest-account-mgr-helpers.h:
2650 * src/modest-account-mgr-helpers.c:
2651 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2653 * src/maemo/Makefile.am:
2654 * src/maemo/modest-signature-editor-dialog.c:
2655 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2658 * src/maemo/modest-account-settings-dialog.h:
2659 * src/maemo/modest-account-settings-dialog.c:
2660 (modest_account_settings_dialog_finalize), (on_button_signature),
2661 (save_configuration): Use the new dialog when the Edit button is pressed, and
2662 save the changes if necessary, as per the UI spec.
2664 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2666 * src/maemo/Makefile.am:
2667 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2668 based on maemo-develoers email from Dirk.
2670 * src/maemo/easysetup/modest-easysetup-wizard.c:
2671 (create_page_welcome), (create_page_account_details),
2672 (create_page_user_details), (create_page_complete_easysetup),
2673 (create_page_custom_incoming), (create_page_custom_outgoing),
2674 (create_page_complete_custom),
2675 (modest_easysetup_wizard_dialog_init):
2676 * src/maemo/modest-account-settings-dialog.c:
2677 (create_page_account_details), (create_page_user_details),
2678 (create_page_incoming), (create_page_outgoing),
2679 (modest_account_settings_dialog_init):
2680 * src/maemo/modest-connection-specific-smtp-window.c:
2681 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2683 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2685 * src/maemo/easysetup/modest-easysetup-wizard.c:
2686 (create_page_account_details), (create_page_custom_outgoing),
2687 (create_page_complete_custom):
2688 * src/maemo/modest-account-settings-dialog.c:
2689 (create_page_user_details), (create_page_incoming),
2690 (create_page_outgoing):
2691 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2692 (modest_connection_specific_smtp_edit_window_init):
2693 Use the correct (UI spec) port min/max, and use horizontal separators,
2696 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2698 * src/maemo/easysetup/modest-easysetup-wizard.c:
2699 (set_default_custom_servernames):
2700 * src/maemo/modest-account-settings-dialog.c:
2701 (create_page_incoming), (on_combo_outgoing_security_changed),
2702 (on_combo_incoming_security_changed), (create_page_outgoing),
2703 (modest_account_settings_dialog_set_account_name),
2704 (save_configuration):
2705 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2706 (on_combo_security_changed),
2707 (modest_connection_specific_smtp_edit_window_init),
2708 (modest_connection_specific_smtp_edit_window_set_connection),
2709 (modest_connection_specific_smtp_edit_window_get_settings):
2710 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2713 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2716 * src/maemo/easysetup/modest-easysetup-wizard.c:
2717 (create_page_custom_outgoing), (create_page_complete_custom):
2718 * src/maemo/modest-account-settings-dialog.c:
2719 (create_page_user_details), (create_page_outgoing):
2720 * src/maemo/modest-account-view-window.c: (button_box_new):
2721 Use changed logical IDs as per the most recent UI spec:
2722 mcen_bd_emailsetup_edit -> mcen_bd_edit
2723 mcen_bd_emailsetup_delete -> mcen_bd_delete
2724 mcen_bd_emailsetup_close -> mcen_bd_close
2726 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2730 * src/dbus_api/Makefile.am:
2731 * src/dbus_api/modest-dbus-callbacks.c:
2732 * src/dbus_api/modest-dbus-callbacks.h:
2733 * src/maemo/modest-platform.c: (modest_platform_init):
2734 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2736 * tests/Makefile.am:
2737 * tests/dbus_api/Makefile.am:
2738 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2740 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2742 * src/maemo/modest-account-settings-dialog.c:
2743 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2744 Removed unnecessary includes.
2746 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2748 * src/maemo/easysetup/modest-easysetup-wizard.c:
2749 * src/maemo/modest-account-settings-dialog.c:
2750 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2751 * src/widgets/Makefile.am:
2752 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2753 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2754 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2755 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2756 * src/widgets/modest-secureauth-combo-box.c:
2757 * src/widgets/modest-secureauth-combo-box.h:
2758 * src/widgets/modest-serversecurity-combo-box.c:
2759 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2760 made the GObject names more consistent with the rest of the Modest code.
2762 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2764 * src/maemo/easysetup/Makefile.am:
2765 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2766 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2767 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2768 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2769 * src/maemo/easysetup/modest-easysetup-wizard.c:
2770 * src/maemo/easysetup/modest-validating-entry.c:
2771 * src/maemo/easysetup/modest-validating-entry.h:
2772 * src/maemo/modest-account-settings-dialog.c:
2773 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2774 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2775 widgets/ because they are used outside of easysetup too. After checking in,
2776 svn will allow me to rename them too.
2778 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2780 * src/gnome/modest-msg-edit-window.c:
2781 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2782 linker error, to fix the build on the GNOME platform.
2783 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2784 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2785 ifdefed out to avoid a warning.
2787 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2789 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2790 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2791 some alternative for GTK+ 2.6.
2793 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2795 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2797 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2798 specified for EmailAccountsDialog in UI spec.
2800 * src/maemo/easysetup/modest-easysetup-wizard.c:
2801 * src/maemo/easysetup/modest-easysetup-wizard.h:
2802 * src/maemo/modest-account-settings-dialog.c:
2803 * src/maemo/modest-account-settings-dialog.h:
2804 Reuse a member window widget for the connection-specific SMTP server accounts,
2805 so we can tell it to create/save the accounts only if we actually save changes.
2807 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2809 (modest_connection_specific_smtp_edit_window_get_settings):
2810 Return a struct instance for temporarily remembering the entered data.
2812 * src/maemo/modest-connection-specific-smtp-window.h:
2813 * src/maemo/modest-connection-specific-smtp-window.c:
2814 (modest_connection_specific_smtp_window_finalize),
2815 (modest_connection_specific_smtp_window_fill_with_connections),
2817 (modest_connection_specific_smtp_window_save_server_accounts),
2818 (update_model_server_names): Do not actually save data until asked,
2819 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2821 (on_selection_changed),
2822 (modest_connection_specific_smtp_window_init): Disable the edit
2823 button when nothing is selected.
2825 * src/modest-account-mgr-helpers.c:
2826 * src/modest-account-mgr-helpers.h:
2827 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2830 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2832 * src/modest-account-mgr-helpers.h:
2833 * src/modest-account-mgr-helpers.c:
2834 (modest_account_mgr_get_unused_account_name),
2835 (modest_account_mgr_get_unused_account_display_name): Added these
2836 utility functions, to avoid code duplication.
2838 * src/maemo/easysetup/modest-easysetup-wizard.c:
2839 (create_page_account_details), (create_account):
2840 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2841 (on_combo_security_changed),
2842 (modest_connection_specific_smtp_edit_window_init),
2843 (modest_connection_specific_smtp_edit_window_save_settings):
2844 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2845 * src/maemo/modest-connection-specific-smtp-window.c:
2846 (modest_connection_specific_smtp_window_finalize),
2847 (modest_connection_specific_smtp_window_fill_with_connections),
2848 (on_button_edit), (modest_connection_specific_smtp_window_init):
2849 * src/maemo/modest-connection-specific-smtp-window.h:
2850 Implementing saving of connection-specific server accounts.
2852 But I need to refactor this so we can save the data for each
2853 possible connection-specific account and only actually create the server accounts
2854 when the easysetup finished, or the OK button is pressed on the account settings
2857 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2859 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2860 (on_combo_security_changed):
2861 (modest_connection_specific_smtp_edit_window_init):
2862 Auto-fill the port number as in the account settings.
2864 (modest_connection_specific_smtp_edit_window_set_connection):
2865 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2866 * src/maemo/modest-connection-specific-smtp-window.c:
2867 (fill_with_connections), (on_button_edit),
2868 (modest_connection_specific_smtp_window_init):
2869 Turn the edit window into a dialog to simplify the code, and
2870 set a WM hint as in a GtkDialog, because only a popup can be on top of
2871 another window in Maemo, and popups usually have no WM decoration.
2873 * src/modest-defs.h:
2874 * src/modest-account-mgr-helpers.c:
2875 (modest_account_mgr_set_connection_specific_smtp),
2876 (modest_account_mgr_remove_connection_specific_smtp),
2877 (modest_account_mgr_get_connection_specific_smtp):
2878 * src/modest-account-mgr-helpers.h: Some functions to write the
2879 connection-specific SMTP server information. Not yet used.
2882 * src/widgets/modest-folder-view.c: (text_cell_data):
2883 Fix a warning about an uninitialized variable.
2884 (on_configuration_key_changed): Put an #ifdef around the use
2885 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2887 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2889 * src/maemo/modest-account-settings-dialog.h:
2890 * src/maemo/modest-account-settings-dialog.c:
2891 Added connect_for_modified() utility function to mark the new modified boolean.
2893 (create_page_account_details), (create_page_user_details),
2894 (create_page_incoming), (create_page_outgoing), (on_response),
2895 (modest_account_settings_dialog_init),
2896 (modest_account_settings_dialog_set_account_name):
2897 Only warn about unsaved changes when there are actually unsaved changes.
2899 * src/modest-account-mgr-helpers.c:
2900 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2901 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2902 to get the data from there in future.
2904 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2906 * src/modest-defs.h:
2908 * src/modest-account-mgr-helpers.h:
2909 * src/modest-account-mgr-helpers.c:
2910 Store the security account setting in a single conf key instead of using
2911 the options list, so that the list is left for just the to-be-removed camel hack,
2912 and because gconf_client_set_list() is failing for some reason.
2914 * src/modest-account-mgr.c:
2915 (modest_account_mgr_add_server_account):
2916 * src/maemo/modest-account-settings-dialog.c:
2917 (modest_account_settings_dialog_set_account_name),
2918 (save_configuration): Use the renamed functions.
2921 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2923 * src/widgets/Makefile.am:
2924 * src/widgets/modest-limit-retrieve-combo-box.c:
2925 * src/widgets/modest-limit-retrieve-combo-box.h:
2926 * src/widgets/modest-retrieve-combo-box.c:
2927 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2928 the account settings dialog.
2930 * src/modest-defs.h:
2931 * src/modest-account-mgr-helpers.h:
2932 * src/modest-account-mgr-helpers.c:
2933 (modest_server_account_get_option_secure_auth),
2934 (modest_server_account_set_option_secure_auth):
2935 * src/modest-account-mgr.c:
2936 (modest_account_mgr_add_server_account):
2937 Use the existing AUTH_MECH conf key for the secure-auth setting,
2938 instead of putting it in the list options, because this was actually used already.
2940 * src/maemo/modest-account-settings-dialog.c:
2941 (create_page_account_details),
2942 (modest_account_settings_dialog_set_account_name),
2943 (save_configuration):
2944 * src/maemo/modest-account-settings-dialog.h:
2945 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2946 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2948 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2950 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2951 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2952 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2954 * src/modest-defs.h:
2955 * src/maemo/modest-account-settings-dialog.c:
2956 (create_page_incoming), (on_combo_outgoing_security_changed),
2957 (on_combo_incoming_security_changed), (create_page_outgoing),
2958 (modest_account_settings_dialog_set_account_name),
2959 (save_configuration): Load/Save the port number, and change it when the
2960 security combo changes, to suitable defaults.
2962 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2964 * src/modest-account-mgr.c:
2965 (modest_account_mgr_add_server_account): Set the security and secure-auth
2966 options, and add a comment saying that the other camel-specific options should be
2969 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2971 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2973 * src/modest-tny-account-store.c: (account_list_free),
2974 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2975 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2978 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2980 * src/modest-protocol-info.c:
2981 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2982 is required by our UI spec. Maybe something in our implementation will use this eventually.
2983 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2984 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2985 instead of the previous 0 placeholder.
2987 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2988 secure-auth settings.
2989 * src/modest-account-mgr-helpers.h:
2990 * src/modest-account-mgr-helpers.c:
2991 (modest_server_account_data_get_option_secure_auth),
2992 (modest_server_account_set_option_secure_auth),
2993 (modest_server_account_data_get_option_security),
2994 (modest_server_account_set_option_security): Added this API for getting and setting the security
2995 and secure-auth settings.
2997 * src/maemo/modest-account-settings-dialog.h:
2998 * src/maemo/modest-account-settings-dialog.c:
2999 (modest_account_settings_dialog_finalize), (check_data),
3000 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3001 about changing titles.
3002 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3003 (save_configuration): Save the security and secure-auth settings.
3005 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3006 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3008 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3010 * src/modest-defs.h:
3011 * src/modest-account-mgr.c:
3012 (modest_account_mgr_add_server_account):
3013 Added and used defines for the options key and value pair strings,
3014 that are used so far, though they do not seem to correspond to anything in our
3015 UI specs or ModestProtocol enum.
3017 * src/modest-account-mgr-helpers.h:
3018 * src/modest-account-mgr-helpers.c:
3019 (compare_option_strings_for_name),
3020 (modest_server_account_data_get_option_value),
3021 (modest_server_account_data_get_option_bool),
3022 (modest_account_mgr_get_server_account_option):
3023 Added helper functions for parsing the options GSList.
3025 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3027 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3028 display name is based on the supplied account name.
3029 * src/modest-account-mgr.c:
3030 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3031 with an inefficient, but good-enough, implementation.
3033 * src/maemo/easysetup/modest-easysetup-wizard.c:
3034 (create_page_account_details), (on_before_next), (create_account):
3035 Check for existing display names rather than (non-user-visible) account names, and just
3036 create and set a unique account name at the end.
3038 * src/maemo/modest-account-settings-dialog.c:
3039 (modest_account_settings_dialog_init),
3040 (modest_account_settings_dialog_set_account_name),
3041 (create_page_incoming): Show the display name, instead of the account name.
3042 (on_response): Do some (not all) extra checks, as in the UI spec.
3043 (save_configuration): Save the display name if it was changed.
3045 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3047 * po/en_GB.po: Added needed logical ID and translation.
3048 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3049 (init_view): Made the is-default column clicking work.
3051 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3054 * src/maemo/easysetup/Makefile.am:
3055 * src/maemo/easysetup/modest-easysetup-wizard.c:
3056 (modest_easysetup_wizard_dialog_init):
3057 * src/maemo/easysetup/provider-data-test.keyfile:
3058 * src/maemo/easysetup/provider-data.keyfile:
3059 Moved the provider data file to the new modest-providers-data package and used it from there.
3061 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3063 * src/modest-local-folder-info.c:
3064 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3065 N_() was already used on the static strings, but this just marks it for translation without
3066 using the translation.
3068 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3070 * src/maemo/modest-account-settings-dialog.c:
3071 (create_page_incoming),
3072 (modest_account_settings_dialog_set_account_name):
3073 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3074 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3075 I will do this if nobody else gets there first.
3077 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3079 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3080 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3081 save the security stuff.
3083 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3085 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3086 Set the email address and user fullname, which I now see must be
3089 * src/maemo/modest-account-settings-dialog.h:
3090 * src/maemo/modest-account-settings-dialog.c:
3092 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3093 leave-on-server and authentication.
3094 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3097 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3100 * src/maemo/modest-account-settings-dialog.c:
3101 * src/maemo/modest-account-settings-dialog.h:
3102 Most (but not all) of the widgets are now present as specified by the UI spec.
3103 No changes are yet saved, and some details are not properly shown yet.
3105 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3107 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3109 * src/maemo/Makefile.am:
3110 * src/maemo/modest-account-settings-dialog.c:
3111 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3112 an existing account. Doesn't do much yet.
3114 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3115 Open the accounts settings dialog when Edit is clicked.
3117 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3119 * src/maemo/easysetup/Makefile.am:
3120 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3122 * src/maemo/easysetup/modest-easysetup-wizard.c:
3123 (modest_easysetup_wizard_dialog_init):
3124 Try to get the source directory from the build system,
3125 instead of hard-coding "./" into the source code, when opening our local
3126 copies of the configuration files.
3127 But this still fails when opening the wizard from the Accounts window,
3128 maybe because the working directory seems to change at runtime.
3129 So the wizard will fail the second time unless you copy the files into their
3130 proper locations - see the stdout warnings for the paths.
3132 (create_page_account_details),(on_before_next):
3133 Check for existing non-server accounts instead of server accounts,
3134 so the default account name is useful again, and to prevent trying to
3137 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3138 Show the wizard when New is clicked.
3140 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3141 (init_view): Show the column headers, and show the columns that are
3142 specified in the UI specs. However, something in Maemo's GTK+ prevents
3143 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3144 change the default account. This is despite unsetting the special properties.
3146 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3148 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3149 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3150 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3151 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3152 to make that clearer.
3153 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3155 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3157 * src/maemo/modest-account-view-window.c:
3158 (modest_account_view_window_init),
3159 (modest_account_view_window_new):
3160 Use the same buttons as specified in the
3161 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3162 the existing widgets, which never had a chance of working.
3163 Put the ModestAccountView treeview in a scrolled window.
3164 Do not repeat the initialization in both _init() and _new().
3166 * src/widgets/modest-account-view.c: (update_account_view):
3167 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3168 this widget and window shows no accounts.
3170 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3172 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3174 * src/maemo/easysetup/modest-easysetup-wizard.c:
3175 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3176 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3177 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3180 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3181 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3182 accounts exist yet, as in the UI spec.
3184 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3186 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3188 * src/maemo/Makefile.am:
3189 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3190 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3191 New window for editing connection-specific smtp details.
3192 Not fully implemented.
3194 * src/maemo/modest-connection-specific-smtp-window.c:
3195 (modest_connection_specific_smtp_window_finalize) :
3196 unref the tree model.
3197 (on_button_edit): Show the edit window.
3199 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3201 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3204 * src/maemo/Makefile.am:
3205 * src/maemo/modest-connection-specific-smtp-window.c:
3206 * src/maemo/modest-connection-specific-smtp-window.h:
3207 New window for showing the list of connections, for connection-specific
3208 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3209 * src/maemo/easysetup/modest-easysetup-wizard.c:
3210 (create_page_custom_outgoing): Show the new window when the button is clicked.
3212 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3214 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3215 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3216 * src/maemo/modest-msg-edit-window.c:
3217 (modest_msg_edit_window_insert_image):
3218 * src/modest-conf.c: (modest_conf_key_escape):
3219 * src/modest-mail-operation.c:
3220 (modest_mail_operation_send_new_mail):
3221 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3222 (modest_ui_actions_on_new_account):
3223 * src/widgets/modest-attachment-view.c: (update_filename_request):
3224 * src/widgets/modest-mail-header-view.c:
3225 Corrected warnings that were breaking the build, by commenting out unused variables,
3226 and a function, and by including a header.
3228 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3230 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3231 so we can #ifdef around platform-specific code when necessary.
3232 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3233 to allow this to build for the GNOME platform too.
3235 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3237 * src/maemo/easysetup/modest-easysetup-wizard.c:
3238 Added util_increment_name() and used it in create_page_account_details()
3239 to make sure that the default account name is always a new name.
3241 (modest_easysetup_wizard_dialog_init),
3242 (set_default_custom_servernames): Some minor memory management fixes.
3244 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3248 * src/modest-runtime.c: (init_i18n): Restored the translation
3249 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3250 are defined in config.h, and the translations are installed.
3252 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3253 is defined for translation.
3255 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3257 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3259 * src/maemo/easysetup/modest-easysetup-wizard.c:
3260 (modest_easysetup_wizard_dialog_init):
3261 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3262 Use realistic paths (though they should use $prefix generically) to the
3263 mcc_mapping and provider-data.keyfile files which might work when they
3264 are installed by the future version of the operator-wizard package,
3265 and then fallback to paths in our source code, with an explanatory
3268 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3272 * src/maemo/Makefile.am:
3273 * src/maemo/easysetup/: Added files from the previously-exernal
3274 osso-modest-easysetup.
3275 * src/maemo/modest-main-window-ui.h:
3276 * src/modest-ui-actions.c:
3277 * src/modest-ui-actions.h:
3278 Added modest_ui_actions_on_new_account() as a signal handler for the
3279 New Account menu item. It shows the easysetup wizard.
3280 * po/en_GB.po: Added additional needed logical IDs and translations.