1 2007-07-05 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-account-settings-dialog.c: Remember custom port
4 number at the beginning of the dialog and set the modified flag at the
5 end if the port number has changed. This is necessary because
6 HildonNumberEditor does not support notification when the value has
9 2007-07-05 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-ui-actions.c:
12 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
13 a connection before asking anything else. Correct the check for the destination
14 folder so that it succeeds when online.
15 This fixed projects.maemo.org bug NB#61645.
17 2007-07-05 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
20 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
21 to fix projects.maemo.org bug NB#62439.
23 2007-07-05 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-tny-account.c: (on_connection_status_changed):
26 Really do not use tny_device_force_offline() here. See the previous comment.
28 2007-07-04 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-tny-account.c: (on_connection_status_changed):
31 Do not use tny_device_force_offline() when tinymail says that something
32 went wrong with the connection. It seems to report this unnecessarily.
34 2007-07-04 Murray Cumming <murrayc@murrayc.com>
36 * src/maemo/modest-connection-specific-smtp-window.c:
37 (modest_connection_specific_smtp_window_init):
38 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
39 does not seem to have any effect in osso 1.1 (though it works in
40 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
42 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
44 * src/maemo/modest-connection-specific-smtp-window.c:
45 Fix UI specification problems with projects.meamo.org NB#60479
47 2007-07-04 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
50 clue when this has failed, because the error dialog is not always shown
51 (at least in earlier version).
53 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
54 GError message, because the generic error dialog is not helpful.
56 'This message is not currently available (can't let a new connection go online)'
57 when trying to open an IMAP message.
59 (_modest_ui_actions_open): Offer a connection when some messages would
60 have to be downloaded and we are offline.
62 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
64 * src/widgets/modest-folder-view.c:
65 Don't check for MERGE type anymore as we use the correct type
67 NOTE: For the last two changes you need to update your tinymail copy
68 because of API changes!
70 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
72 * src/modest-tny-local-folders-account.c:
73 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
74 (see projects.maemo.org NB#61580)
76 2007-07-04 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-tny-account.c: (on_connection_status_changed):
79 Commented out the call to modest_platform_connect_and_wait() because this
80 seems to always hang, and I would like to know if this is the only thing
81 that causes a hang when showing the connection dialog.
82 It is not very useful anyway.
84 2007-07-04 Murray Cumming <murrayc@murrayc.com>
86 * src/maemo/modest-msg-view-window.c:
87 (modest_msg_view_window_select_next_message):
89 * src/modest-platform.h:
90 * src/maemo/modest-platform.c:
91 Added modest_platform_connect_and_wait(), which calls
92 tny_maemo_conic_device_connect() always in the main thread, by calling it
93 in an idle handler and waiting for the idle handler to run. It should be
94 in the main thread because it uses GTK+ UI code. It just returns TRUE
95 if the device is already online.
97 There is some nasty code to ensure that subsequent calls to
98 modest_platform_connect_and_wait() just wait for the first one to finish,
99 by checking repeatedly in another idle handler. This is necessary,
100 because other threads (or even the main thread, via another idle handler)
101 can call modest_platform_connect_and_wait() while
102 modest_platform_connect_and_wait() is running.
104 (modest_platform_connect_and_wait_if_network_account),
105 (modest_platform_connect_and_wait_if_network_folderstore):
106 Convenience functions that calls modest_platform_connect_and_wait() if
107 the account or folder might want network access.
109 * src/modest-mail-operation.c:
110 (modest_mail_operation_update_account):
111 * src/modest-ui-actions.c: (download_uncached_messages),
112 (modest_ui_actions_on_rename_folder), (delete_folder),
113 (modest_ui_actions_on_main_window_move_to),
114 (modest_ui_actions_on_msg_view_window_move_to):
115 * src/widgets/modest-folder-view.c:
116 (drag_and_drop_from_folder_view):
117 Offer a connection if we are offline.
119 * src/modest-tny-account.c: (on_connection_status_changed):
120 Document this as only handling errors during network operations in progress,
121 and replace the idle code with a simple call to
122 modest_platform_connect_and_wait(), which does this instead.
124 2007-07-03 Murray Cumming <murrayc@murrayc.com>
126 * src/modest-tny-account.c:
127 (modest_tny_account_get_special_folder): (util_on_idle),
128 Handle the GError so we can see when tny_folder_store_get_folders()
129 fails, as it currently does while something else is connecting.
131 Added util_run_in_main_thread_and_wait()
132 which uses an idlen handler and mainloop to ensure that the function
133 is called in the main thread.
134 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
135 to make sure that we call attempt the connection in the mainloop only,
136 which might solve some hangs.
138 2007-07-03 Murray Cumming <murrayc@murrayc.com>
140 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
141 be found by their display name. This is never useful.
142 * src/modest-tny-account-store.c: (on_account_removed): Find the account
143 by its ID, instead of trying to use its ID as its display name.
145 * src/modest-tny-account-store.h:
146 * src/modest-tny-account.c:
147 (modest_tny_account_get_special_folder): Add a g_warning() when
148 tny_folder_store_get_folders() returns an empty list for the maildir.
150 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
151 Add a g_warning() when this returns NULL, because that it not allowed
154 2007-07-02 Armin Burgmeier <armin@openismus.com>
156 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
157 note when trying to cancel the wizard. This fixes projects.maemo.org
160 2007-07-02 Murray Cumming <murrayc@murrayc.com>
162 * src/modest-tny-account.h:
163 * src/modest-tny-account.c:
164 (modest_tny_account_new_from_server_account),
165 (modest_tny_account_new_from_server_account_name),
166 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
167 because this must now be set before setting the proto. This is usd in
168 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
169 warning in camel_session_get_service() caused by
170 tny_camel_transport_account_prepare().
172 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
175 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
177 * src/maemo/modest-connection-specific-smtp-edit-window.c:
179 (modest_connection_specific_smtp_edit_window_init):
181 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
184 2007-06-29 Murray Cumming <murrayc@murrayc.com>
186 * src/modest-tny-account.c:
187 (modest_tny_account_new_from_server_account):
188 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
189 now uses to request a connection when it needs one, and which it uses
190 to tell us that something is wrong with the connection, so we can force
191 the accounts offline to prevent further problems.
194 * src/modest-init.c: (init_default_settings):
195 * src/modest-mail-operation.c:
196 (modest_mail_operation_update_account):
197 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
198 This should not be necessary anymore. Do not set the conf key that
199 determined this (it was always TRUE and not set anywhere else).
201 * src/modest-ui-actions.h: Remove unused and unimplemented
202 modest_ui_actions_on_online_toggle_toggled().
204 2007-06-29 Murray Cumming <murrayc@murrayc.com
206 * src/maemo/modest-main-window.c: (connect_signals):
207 Don't connect to delete_event twice. Maybe this was harmless.
209 2007-06-29 Murray Cumming <murrayc@murrayc.com
211 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
212 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
213 Debug output to give some more clue when a folder move is not allowed.
215 2007-06-28 Murray Cumming <murrayc@murrayc.com
217 * src/modest-tny-account.c: (on_modest_file_system_info),
218 (modest_tny_account_get_mmc_account_name):
219 Always call the callback, without checking whether the name has changed.
220 * src/widgets/modest-folder-view.c: (strings_are_equal),
221 (on_model_foreach_set_name), (on_get_mmc_account_name),
222 (text_cell_data): Compare the name here, and use the name from
223 the account rather than from the
224 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
225 if the name was changed after the account was added to the model.
226 That's a tinymail bug but not one that I want to fix now.
228 This finally fixes projects.maemo.org bug NB#59301.
230 2007-06-27 Armin Burgmeier <armin@openismus.com>
232 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
235 2007-06-27 Murray Cumming <murrayc@murrayc.com
237 * src/modest-tny-account.h:
238 * src/modest-tny-account.c:
239 Added modest_tny_account_get_mmc_account_name(), to set the memory
240 card name asynchronously for the given account and then notify.
241 (modest_tny_account_new_for_local_folders): Use this new function instead
242 of using hildon_file_system_info_async_new() directly.
244 * src/widgets/modest-folder-view.c: (text_cell_data):
245 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
246 gtk_tree_model_row_changed() when it is available.
248 This should fix projects.maemo.org bug NB#59301.
250 2007-06-27 Murray Cumming <murrayc@murrayc.com
252 * src/modest-mail-operation.c: (update_account_thread),
253 (get_msgs_full_thread): Fix typo failures in the revert
256 2007-06-27 Murray Cumming <murrayc@murrayc.com
258 * src/maemo/modest-maemo-global-settings-dialog.c:
259 (idle_select_default_focus):
260 * src/modest-mail-operation.c: (idle_notify_progress),
261 (idle_notify_progress_once), (set_last_updated_idle),
262 (update_account_thread), (get_msgs_full_thread):
263 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
264 * src/widgets/modest-header-view.c:
265 (idle_notify_headers_count_changed_destroy),
266 (idle_notify_headers_count_changed):
267 Reverted the additions of gdk_threads_enter/leave(), in case this
268 helps with a startup hang on the device.
270 2007-06-26 Armin Burgmeier <armin@openismus.com>
272 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
273 for supported secure authentication methods from server by
274 gtk_dialog_run(), saving CPU time and a potential race condition.
276 2007-06-26 Armin Burgmeier <armin@openismus.com>
278 * src/maemo/modest-maemo-utils.h:
279 * src/maemo/modest-maemo-utils.c: Added a
280 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
281 only error code to tell the calling code when the user canceled the
284 * src/maemo/modest-account-settings-dialog.h:
285 * src/maemo/modest-account-settings-dialog.c:
286 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
287 message if the retrieval of secure authentication methods was canceled
288 by the user. Perform the check before saving anything to configuration
289 to not end up with half-committed configuration changes, do not show
290 a "Saving to configuration failed" note when authentication methods
291 could not be retrieved.
293 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
296 2007-06-26 Murray Cumming <murrayc@murrayc.com>
298 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
299 Only return the first level of folders under accounts, because the
300 osso-global-search UI spec doesn't want the rest.
301 This fixed projects.maemo.org bug NB#61811.
303 2007-06-26 Murray Cumming <murrayc@murrayc.com>
305 * src/modest-tny-account-store.c:
306 * src/modest-tny-account-store.h:
307 Added modest_tny_account_is_memory_card_account().
308 * src/maemo/modest-main-window.c: (create_details_widget):
309 Show the same information items for the memory card as we show for the
310 local-folders, to fix projects.maemo.org bug NB#59307.
312 2007-06-26 Murray Cumming <murrayc@murrayc.com>
314 * src/modest-tny-account-store.c: (get_password):
315 Added some checks for NULL to maybe prevent crashes, though I think
316 it was Philip's last commit that actually prevented the crash here
317 when creating a first new account.
318 But the new account is still not usable (no messages are shown)
319 until a restart of the application.
321 2007-06-26 Murray Cumming <murrayc@murrayc.com>
323 * src/maemo/modest-maemo-global-settings-dialog.c:
324 (idle_select_default_focus):
325 * src/modest-mail-operation.c: (idle_notify_progress),
326 (idle_notify_progress_once), (idle_notify_update_account_queue),
327 (set_last_updated_idle), (update_account_thread),
328 (notify_get_msgs_full), (get_msgs_full_destroyer),
329 (get_msgs_full_thread):
330 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
331 * src/widgets/modest-header-view.c:
332 (idle_notify_headers_count_changed_destroy),
333 (idle_notify_headers_count_changed):
334 Use gdk_threads_enter() and gdk_threads_enter_leave() in
335 all idle handlers, because some other thread could be blocking
336 the GDK lock, so that it can do GUI stuff.
338 2007-06-26 Murray Cumming <murrayc@murrayc.com>
340 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
341 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
342 (on_idle_send_receive), (on_idle_open_default_inbox):
343 * src/maemo/modest-msg-edit-window.c:
344 (modest_msg_edit_window_attach_file_noninteractive):
345 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
346 to prevent a hang. I don't quite understand why these are necessary,
347 beause we should already be in the main loop. I guess something outside
348 of the main loop is taking the lock.
350 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
351 we are really using URIs, and use files that are more likely to exist.
353 2007-06-26 Murray Cumming <murrayc@murrayc.com>
355 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
356 necessary because configure.ac now defines different variables.
358 2007-06-26 Murray Cumming <murrayc@murrayc.com>
360 * libmodest-dbus-client/libmodest-dbus-client.c:
361 * libmodest-dbus-client/libmodest-dbus-client.h:
362 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
363 libmodest_dbus_client_compose_mail() is what things actually use.
365 * src/dbus_api/modest-dbus-api.h:
366 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
367 * tests/dbus_api/Makefile.am:
368 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
371 2007-06-26 Murray Cumming <murrayc@murrayc.com>
373 * src/modest-init.c: (modest_init_local_folders):
374 For memory-card (or other non local-folders) maildir accounts,
375 always create an Archive folder, so that there is somewhere to put
376 messages. This should be less confusing, because the user does not need
377 to guess that the need to create a folder.
379 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
381 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
382 Fixed icon size by using (50, 50) which is the same as defined by
385 2007-06-25 Armin Burgmeier <armin@openismus.com>
387 * src/widgets/modest-window-mgr.c:
389 * configure.ac: Correctly recognize hildon-notify presence and fixed
390 the build without it being installed.
392 2007-06-25 Murray Cumming <murrayc@murrayc.com>
394 * libmodest-dbus-client/libmodest-dbus-client.c:
395 (libmodest_dbus_client_search): Fix the build. Sorry.
396 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
397 (reply_forward_cb): Initialize variables to fix the build.
399 * src/modest-tny-account-store.c:
400 (modest_tny_account_store_get_tny_account_by): Fix the account URI
401 comparison (a silly typo) so that email search results can be opened
402 when there are more than one account.
404 2007-06-25 Murray Cumming <murrayc@murrayc.com>
406 * libmodest-dbus-client/libmodest-dbus-client.c:
407 (libmodest_dbus_client_search),
408 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
409 instead of 1 second, because the search gets folders and messages from
410 the server, which can take a long time. When it times out,
411 osso-global-search will report no results.
413 We need to specify whether we should search only cached information
414 (maybe with a user preference), and the osso-email-search-plugin
415 API should really be improved to allow that option, and to allow results
416 to be delivered asynchronously in batches.
418 2007-06-25 Murray Cumming <murrayc@murrayc.com>
420 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
421 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
422 GTK_ICON_SIZE_DIALOG is probably the wrong size.
424 2007-06-25 Murray Cumming <murrayc@murrayc.com>
426 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
427 that is an empty string. D-Bus seems to give us these instead of NULL.
429 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
431 * src/dbus_api/modest-dbus-callbacks.c:
432 * src/maemo/easysetup/modest-easysetup-wizard.h:
433 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
434 * src/maemo/modest-connection-specific-smtp-edit-window.c:
435 (modest_connection_specific_smtp_edit_window_init):
436 * src/maemo/modest-maemo-global-settings-dialog.c:
438 * src/maemo/modest-maemo-utils.c:
439 (modest_maemo_utils_setup_images_filechooser):
440 * src/maemo/modest-main-window.c: (create_details_widget):
441 * src/maemo/modest-msg-edit-window.c:
442 (modest_msg_edit_window_attach_file_noninteractive),
443 (modest_msg_edit_window_color_button_change),
444 (modest_msg_edit_window_set_zoom):
445 * src/modest-mail-operation.c: (update_account_thread):
446 * src/modest-tny-account-store.c:
447 * src/modest-tny-account.c:
448 * src/widgets/modest-global-settings-dialog.c:
449 * src/widgets/modest-window.h:
453 2007-06-25 Murray Cumming <murrayc@murrayc.com>
455 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
456 * src/modest-search.c: (modest_search_folder),
457 (modest_search_all_accounts): Actually search only in the specified folder,
458 doing a simple match on the folder ID.
459 * src/modest-search.h: Added a folder field to the ModestSearch struct,
460 and added some documentation.
462 2007-06-22 Armin Burgmeier <armin@openismus.com>
464 * src/maemo/modest-maemo-utils.h:
465 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
466 modest_maemo_utils_get_supported_secure_authentication_methods.
468 * src/maemo/easysetup/modest-easysetup-wizard.c:
469 * src/maemo/modest-account-settings-dialog.c: Show correct error if
470 one occured, not just "Server does not support secure authentication".
472 2007-06-22 Murray Cumming <murrayc@murrayc.com>
474 * src/modest-tny-account-store.c: (get_password):
475 Restored the call to tny_account_set_user() because Philip seems to have
476 stopped this from crashing (by not using the freed string). It still does
477 not work, but now we can test it.
479 2007-06-22 Murray Cumming <murrayc@murrayc.com>
481 * src/maemo/modest-msg-edit-window.c: (init_window):
482 Comment out use of an uninitialzed GtkScrolledWindow variable,
483 to fix the build and stop a crash. Yet again.
485 2007-06-22 Murray Cumming <murrayc@murrayc.com>
487 * src/modest-tny-account-store.c: (get_password):
488 Remove the call to tny_account_set_user() because this actually crashes.
489 As mentioned in the last commit, it is known to not work anyway.
491 2007-06-22 Murray Cumming <murrayc@murrayc.com>
493 * src/modest-tny-account-store.c: (get_password):
494 Use tny_account_set_username() to tell tinymail that the username might
495 have changed too. But tinymail ignores this: see projects.maemo.org
497 * src/modest-ui-actions.c:
498 (modest_ui_actions_on_password_requested): Remove the useless attempt to
499 reset the connection when changing the username, and improve the comments.
500 Save the changed username to gconf at least, so it is used when Modest is
503 2007-06-21 Murray Cumming <murrayc@murrayc.com>
505 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
506 Do not use a query, so that we get all folders, including for POP and
507 local-folders. They work as search criteria too.
508 This fixes projects.maemo.org bug NB#57740.
510 2007-06-21 Murray Cumming <murrayc@murrayc.com>
512 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
513 Comment out the use of hildon_notification_set_sound() because it is
514 not declared, to fix the build. Warnings are serious, people.
516 2007-06-21 Armin Burgmeier <armin@openismus.com>
518 * src/maemo/modest-maemo-utils.h:
519 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
520 modest_maemo_utils_get_supported_secure_authentication_methods()
521 to query authentication methods for a specific user. This should fix
522 projects.maemo.org bug NB#61369.
524 * src/maemo/easysetup/modest-easysetup-wizard.c:
525 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
528 2007-06-21 Murray Cumming <murrayc@murrayc.com>
530 * libmodest-dbus-client/libmodest-dbus-client.h:
531 * libmodest-dbus-client/libmodest-dbus-client.c:
532 (modest_dbus_message_iter_get_search_hit),
533 (libmodest_dbus_client_search):
534 Reorganised and commented this.
535 Removed modest_search_hit_free() from the public API because it
538 Added libmodest_dbus_client_get_folders() and
539 modest_folder_result_list_free().
541 * src/dbus_api/modest-dbus-api.h:
542 * src/dbus_api/modest-dbus-callbacks.c:
543 (modest_dbus_req_filter): Commented. Moved most code to
544 on_dbus_method_search() and added on_dbus_method_get_folders().
546 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
547 of the extra D-Bus handler.
549 * tests/dbus_api/Makefile.am:
550 * tests/dbus_api/test_get_folders.c: New test for
551 libmodest_dbus_client_get_folders(). This seems to return an empty list
552 at the moment. That could be the same error that causes the message list
553 to be empty sometimes.
554 This should help with projects.maemo.org bug NB#57740.
556 2007-06-21 Armin Burgmeier <armin@openismus.com>
558 * src/modest-mail-operation.c: Do not call
559 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
560 notify the operation's end after having set the status to CANCELED for
561 the operation queue to listen on. This fixes a deadlock when there
562 were mail operations in the queue during its finalization.
564 * src/modest-singletons.c: Reordered uninitialization of the account
565 manager to happen after the mail operation queue was uninitialized
566 because the mail operation's in the queue might still try to access
567 the account manager (see modest_mail_operation_notify_end()). This
568 fixes a potential crash when terminating the application.
570 2007-06-21 Murray Cumming <murrayc@murrayc.com>
572 * src/modest-search.c:
573 (search_mime_part_and_child_parts): Moved some code here so we
574 can search recursively in child folders.
575 (modest_search_folder): Search in the message as a mime part, instead
576 of just its child mime parts.
577 (read_chunk), (search_mime_part_ogs):
578 Check how many bytes were read, to prevent an endless loop.
579 Searching in message bodies now works. This finishes the fix for
580 projects.maemo.org bug NB#61007.
582 2007-06-20 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
585 Add a g_warning when the item is not a folder.
587 * src/modest-ui-dimming-rules.c:
588 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
589 when selected item is not a folder (for instance, an account), because
590 the UI spec only talks about folders.
591 I am not sure what the UI spec wants, so this might not totally fix
592 projects.maemo.org bug NB#60794.
594 2007-06-20 Murray Cumming <murrayc@murrayc.com>
596 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
597 (load_from_file): Sort the list. The unsorted list would be more noticeable
598 in non-English locales.
600 * src/maemo/modest-msg-edit-window.c:
601 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
602 warning and fix the build.
604 * src/maemo/modest-progress-bar-widget.c:
605 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
606 avoid a g_warning, and probably to avoid a crash.
608 2007-06-20 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-search.c: (modest_search_folder): Check for a GError
611 when calling tny_folder_get_headers(), to show that this is not the cause
614 2007-06-20 Murray Cumming <murrayc@murrayc.com>
616 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
617 Actually set the body query instead of the subject query.
619 * src/modest-search.c: (search_mime_part_ogs),
620 (search_mime_part_strcmp): Remove extra space from the text/* regex,
621 which would probably cause it to fail if we got this far.
623 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
624 to simplify the code.
625 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
626 be causing search-in-body to fail.
628 2007-06-20 Murray Cumming <murrayc@murrayc.com>
630 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
632 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
633 Better debug message when the folder cannot be found.
634 This should help with fixing projects.maemo.org bug #61287.
635 * src/modest-search.c: (add_hit): Do not leak the furl string.
637 2007-06-20 Murray Cumming <murrayc@murrayc.com>
639 * src/modest-ui-actions.c:
640 (modest_ui_actions_on_folder_selection_changed):
641 Do not special-case TNY_MERGE_FOLDER here, because
642 modest_tny_folder_get_account() already does that. This fixes
643 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
644 shown when the Outbox was selected).
646 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
648 * libmodest-dbus-client/libmodest-dbus-client.c:
649 (_dbus_iter_get_string_or_null): Initialize the string variable in
650 case this helps with Dirk's crash.
652 2007-06-19 Murray Cumming <murrayc@murrayc.com>
654 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
655 though it is not implemented yet (this function is maybe not even used),
656 to avoid breaking ABI in future.
657 * libmodest-dbus-client/libmodest-dbus-client.c:
658 (get_attachments_string): Moved some code into this generic function.
659 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
660 sends email. It is maybe not used.
661 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
662 (on_send_mail): Use attachments.
664 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
665 * src/maemo/modest-msg-edit-window.c:
666 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
667 a filename before using it, to fix projects.maemo.org bug NB#58233.
669 2007-06-19 Murray Cumming <murrayc@murrayc.com>
671 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
672 Initialize the continue_download variable to fix the build, and probably
673 to fix randome behaviour.
675 2007-06-18 Armin Burgmeier <armin@openismus.com>
677 * src/modest-tny-send-queue.h:
678 * src/modest-tny-send-queue.c: Keep track of the status of messages in
679 the queue so we can later show it in the UI. Replaced
680 modest_tny_send_queue_msg_is_being_sent() by
681 modest_tny_send_queue_get_msg_status().
683 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
685 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
686 gpointer. This probably was not harmful, but just to be sure.
688 2007-06-18 Murray Cumming <murrayc@murrayc.com>
690 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
691 Fix the build, but leave the function broken on Bora, because
692 hildon_uri_action_get_service() does not exist.
693 osso_uri_action_get_service() does not exist either, it seems.
695 2007-06-18 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-tny-account.c:
698 (modest_tny_account_new_from_server_account):
699 Uncommented the url debug output again, because it is useful for
700 debugging, as I said in the comment.
702 2007-06-18 Murray Cumming <murrayc@murrayc.com>
704 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
706 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
707 for Mameo Bora, to fix the build.
709 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
712 Fixed build with hildon < 0.99
714 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
715 Check if the selected account is busy instead of checking all accounts
717 * src/modest-account-mgr-priv.h:
718 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
719 (modest_account_mgr_init), (compare_account_name),
720 (modest_account_mgr_set_account_busy),
721 (modest_account_mgr_account_is_busy):
722 * src/modest-account-mgr.h:
723 Added busy information to the account manager. It possible to
724 set an account to busy or not busy now.
726 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
727 (modest_mail_operation_update_account),
728 (modest_mail_operation_notify_end):
729 Set the account to busy/not busy depending on the operation state.
731 * src/widgets/modest-account-view.c:
732 (modest_account_view_finalize), (get_last_updated_string),
733 (update_account_view), (on_account_busy_changed), (init_view):
734 Show string "Refreshing..." if the account is currently busy.
736 All this fixes projects.maemo.org bug NB#59711
738 2007-06-14 Armin Burgmeier <armin@openismus.com>
740 * src/widgets/modest-attachments-view.h:
741 * src/widgets/modest-attachments-view.c: Added
742 modest_attachments_view_has_attachments() and fixed coordinate
743 transformation in get_att_view_at_coords(). This fixes attachment
746 * src/widgets/modest-msg-view.c: Make use of
747 modest_attachments_view_has_attachments() to decide whether to show
748 attachments in the header.
750 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
752 * src/maemo/modest-connection-specific-smtp-edit-window.c:
753 (on_change), (on_combo_security_changed),
754 (modest_connection_specific_smtp_edit_window_init),
755 (modest_connection_specific_smtp_edit_window_set_connection),
756 (modest_connection_specific_smtp_edit_window_is_dirty):
757 * src/maemo/modest-connection-specific-smtp-edit-window.h:
758 * src/maemo/modest-connection-specific-smtp-window.c:
761 Show an comfirmation dialog for the smpt-edit-window if there are
762 unsaved changes and the user hits cancel.
763 (projects.maemo.org bug NB#60479)
765 2007-06-14 Armin Burgmeier <armin@openismus.com>
767 * src/maemo/easysetup/modest-easysetup-wizard.c:
768 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
769 address" info in banner instead of node, and select all the text as
770 per UI spec. This fixes projects.maemo.org bug NB#60550.
772 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
774 reviewed by: <delete if not using a buddy>
776 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
777 * src/modest-ui-actions.c: (folder_refreshed_cb):
779 2007-06-14 Murray Cumming <murrayc@murrayc.com>
781 * src/widgets/modest-folder-view.c: (filter_row):
782 Explictly filter out the per-account outbox accounts. I don't know why
783 these only sometimes show up, but now they should never show up in the UI.
784 This should fix projects.maemo.org bug NB#60160.
786 2007-06-14 Murray Cumming <murrayc@murrayc.com>
788 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
789 when the toolbar does not exist yet.
790 * src/modest-widget-memory.c: (save_settings_header_view):
791 Added g_warnings() to help us to discover when we are trying to set
792 an empty columns list in gconf.
794 2007-06-14 Murray Cumming <murrayc@murrayc.com>
798 Added modest_init_get_default_header_view_column_ids().
800 * src/modest-widget-memory.c: (restore_settings_header_view):
801 Use the new function to get defaults, if the gconf key is empty,
802 instead of not creating any columns. This seems to fix the
803 empty right-hand pane problems.
805 * src/widgets/modest-header-view.h: Improved documentation.
807 2007-06-13 Murray Cumming <murrayc@murrayc.com>
809 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
810 Revert the use of the display name as the account name, because this
811 is generally wrong and would break the code that follows.
813 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
815 * src/maemo/easysetup/modest-easysetup-wizard.c:
816 (check_for_supported_auth_methods), (on_before_next),
819 More correct fix for projects.maemo.org bug NB# 58991
820 Do not longer accept AUTH_PASSWORD as secure method and choose
821 correct method when creating the account.
823 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
825 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
826 Fixed projects.maemo.org bug NB# 58991
828 2007-06-13 Murray Cumming <murrayc@murrayc.com>
830 * src/modest-init.c: (modest_init_init_core),
831 (modest_init_local_folders): Fixed compilation errors.
833 2007-06-13 Murray Cumming <murrayc@murrayc.com>
835 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
836 Remove unnecessary lib/include, though it is good in principle when needed.
838 * src/modest-init.c: (modest_init_one_local_folder),
839 (modest_init_local_folders):
840 * src/modest-init.h: Initialize the .modest library for memory cards,
841 instead of just doing nothing for them. This should allow us to create
842 folders there, fixing projects.maemo.org bug NB#59297.
844 2007-06-13 Murray Cumming <murrayc@murrayc.com>
846 * libmodest-dbus-client/libmodest-dbus-client.c:
847 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
848 (libmodest_dbus_client_compose_mail),
849 (libmodest_dbus_client_open_message),
850 (libmodest_dbus_client_send_and_receive),
851 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
853 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
854 (on_idle_open_message), (modest_dbus_req_handler),
855 (search_result_to_message), (modest_dbus_req_filter):
856 * src/modest-search.c: (add_hit), (modest_search_folder),
857 (modest_search_all_accounts): Improved debug messages.
859 * tests/dbus_api/test_open_message.c: (main): Improved comments.
861 * src/modest-tny-account-store.c:
862 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
865 2007-06-13 Murray Cumming <murrayc@murrayc.com>
868 2007-06-12 Murray Cumming <murrayc@murrayc.com>
870 * src/modest-tny-account-store.c: (get_server_accounts):
871 Call modest_tny_local_folders_account_add_merged_outbox_folders()
872 even when there are no accounts, so that the Outbox folder is always
873 visible. This fixes projects.maemo.org bug NB#60158.
875 2007-06-12 Murray Cumming <murrayc@murrayc.com>
877 * src/maemo/modest-main-window.c: (create_details_widget):
878 Use the mcen_va_never logical ID.
880 2007-06-12 Murray Cumming <murrayc@murrayc.com>
882 * src/dbus_api/modest-dbus-api.h:
883 * src/dbus_api/modest-dbus-callbacks.c:
884 (on_idle_open_default_inbox), (on_open_default_inbox),
885 (modest_dbus_req_handler):
886 Added a new OpenDefaultInbox method.
888 * libmodest-dbus-client/libmodest-dbus-client.h:
889 * libmodest-dbus-client/libmodest-dbus-client.c:
890 Added libmodest_dbus_client_open_default_inbox() to call the new
891 dbus method. This should be useful to projects.maemo.org bug NB#57214,
892 though it should maybe be used by a new osso-email-interface function.
894 * tests/dbus_api/Makefile.am:
895 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
898 2007-06-12 Murray Cumming <murrayc@murrayc.com>
900 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
901 NULL, so that the signals get all the keys. This should not actually
902 change any behaviour because we currently update everything when anything
905 2007-06-12 Murray Cumming <murrayc@murrayc.com>
907 * src/widgets/modest-folder-view.c: (text_cell_data),
908 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
909 (find_inbox_iter): If tinymail tells us that the folder is
910 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
911 This causes the inbox to be selected at startup, fixing part of
912 projects.maemo.org bug NB#56305.
914 * src/modest-ui-dimming-rules.c:
915 (modest_ui_dimming_rules_on_tools_smtp_servers):
916 * src/modest-ui-dimming-rules.h: Added a callback function to dim
917 the SMTP servers menu item.
918 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
919 that the SMTP Servers menu item is dimmed when there are no accounts,
920 as a future version of the UI spec will require. This fixes
921 projects.maemo.org bug NB#56305.
923 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
925 * src/maemo/modest-maemo-utils.c:
926 (modest_maemo_utils_get_supported_secure_authentication_methods):
927 Added label to dialog instead of unreadable title
929 * src/maemo/modest-main-window.c: (sync_accounts_cb),
930 (modest_main_window_new):
931 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
934 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
935 * src/modest-account-mgr.h:
936 Added method to avoid code duplication
938 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
939 (modest_ui_actions_on_send_receive):
940 Use modest_account_mgr_has_accounts
942 2007-06-11 Murray Cumming <murrayc@murrayc.com>
944 * src/maemo/easysetup/modest-presets.c:
945 (modest_presets_get_info_server_security): Do not report secure auth
947 * src/modest-protocol-info.c: Use the defines for the gconf key names
948 for secure authentication. This was not working because we were writing
949 Password and reading password, and the check was case sensitive.
950 With this, gmail now works for receiving and sending when created via
953 2007-06-11 Murray Cumming <murrayc@murrayc.com>
955 * src/maemo/easysetup/modest-presets.c:
956 (modest_presets_get_info_server_security): Correct the key name for
957 SecureSmtp, because it seems to be case-sensitive.
958 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
959 Do not try to get the 0th notebook page if there are 0 pages, to
962 2007-06-11 Murray Cumming <murrayc@murrayc.com>
964 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
965 Prevent use of the new notification feature for now, because it currently
966 shows one dialog for each new email, which is annoying.
968 2007-06-11 Murray Cumming <murrayc@murrayc.com>
970 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
971 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
972 when no country was selected, so that we show the global ones.
973 * src/maemo/easysetup/modest-presets.c:
974 (modest_presets_get_providers): Return only the global providers, not
975 all providers when mmc=0 was requested.
977 2007-06-11 Murray Cumming <murrayc@murrayc.com>
979 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
980 (easysetup_provider_combo_box_fill): Remove debug code that showed the
981 provider ID in the combo.
983 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
984 Do not show the page numbers, because it would be confusing when we add
985 the 2 extra pages for the custom setup, when the user chooses the "Other"
986 provider. This fixes projects.maemo.org bug NB#59028
988 * src/modest-init.c: (modest_init_init_core),
989 (modest_init_local_folders):
991 * src/modest-tny-account.c:
992 (modest_tny_account_new_for_local_folders): Do not create default folders
993 for the memory card. This should fix projects.maemo.org bug NB#59328.
995 2007-06-11 Murray Cumming <murrayc@murrayc.com>
997 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
998 Free the changed_conf_keys string items. They are already freed in the
999 idle handler if that runs first.
1001 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-ui-actions.c:
1004 (modest_ui_actions_on_password_requested): Check that the server name
1005 is not NULL, because I just saw a password dialog with (null) as the
1008 * src/modest-tny-folder.[h|c]: Added
1009 modest_tny_folder_is_memory_card_folder().
1010 * src/modest-ui-dimming-rules.c:
1011 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1012 menu item for memory cards, as per the UI spec (section 7.4). This should
1013 fix projects.maemo.org bug NB#59297.
1015 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1017 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1018 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1019 is another problem with the code, see Murray's comment at line 772)
1021 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1023 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1024 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1025 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1026 (load_from_file), (easysetup_country_combo_box_init),
1027 (easysetup_country_combo_box_get_active_country_ids),
1028 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1029 instead of just one ID, to avoid duplicate country names in the UI.
1031 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1032 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1033 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1034 a single ID, avoiding duplicate providers.
1035 * src/maemo/easysetup/modest-easysetup-wizard.c:
1036 (on_combo_account_country): Adapt to use a list.
1038 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1040 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1041 keys changed in the last X seconds.
1043 * src/modest-account-mgr.h:
1044 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1045 (on_key_change), (modest_account_mgr_class_init),
1046 (modest_account_mgr_init), (modest_account_mgr_finalize):
1047 As the keys are changed, save them in a GSList* and signal that GSList*
1048 further every X seconds, to batch changes, to allow us to do just one
1049 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1050 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1052 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1053 changed signal signature.
1055 * src/modest-conf.c: (modest_conf_set_list),
1056 (modest_conf_on_change): Reenable notification.
1058 (modest_conf_maemo_fake_on_change): Comment out the hack that
1059 notified immediately instead of asynchronously.
1061 * src/widgets/modest-account-view.h:
1062 * src/widgets/modest-account-view.c:
1063 (update_account_view): Select the previously-selected account ID,
1064 if possible. This fixes projects.maemo.org bug NB#56933.
1066 (on_account_changed), (on_account_removed),
1067 (modest_account_view_select_account):
1069 Remove the block/unblock functions
1070 because they were not useful.
1072 * src/maemo/modest-account-view-window.c:
1073 (on_delete_button_clicked), (on_edit_button_clicked),
1074 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1076 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1078 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1079 Improve the error dialog to show Incorrect Account Settings, which seems
1080 clearer, and say that the internal error message (to be removed from the
1081 dialog later) is often misleading.
1082 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1084 * src/modest-tny-account.c:
1085 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1086 URL because this is so useful for debugging on the device.
1088 * src/widgets/modest-serversecurity-combo-box.c:
1089 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1091 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1093 * src/modest-mail-operation.c:
1094 (modest_mail_operation_send_new_mail):
1095 Added a comment about a nasty but apparently harmless message. Details
1096 added to the wiki g_warnings() page.
1098 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1101 (modest_tny_send_queue_class_init):
1102 Do not use the priv struct because it is empty, to avoid g_warnings
1103 about a non-existant priv struct.
1105 * src/modest-tny-account-store.c:
1106 (modest_tny_account_store_get_server_account),
1107 (modest_tny_account_store_get_transport_account_for_open_connection
1108 ): Do not try to get transport server accounts for local folders,
1109 because they don't have any. This avoids a g_warning().
1111 * src/maemo/modest-main-window.c:
1112 (modest_main_window_notify_send_receive_initied),
1113 (on_configuration_key_changed):
1114 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1115 * src/modest-defs.h:
1116 * src/modest-mail-operation.c:
1117 (modest_mail_operation_update_account):
1118 * src/modest-tny-account-store.h:
1119 * src/modest-tny-account.c:
1120 (modest_tny_account_get_special_folder),
1121 (modest_tny_account_new_for_local_folders),
1122 (modest_tny_account_new_for_per_account_local_outbox_folder):
1123 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1124 * src/modest-tny-local-folders-account.c:
1125 (add_account_folders_to_merged_folder):
1126 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1127 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1128 (modest_ui_actions_on_send):
1129 * src/widgets/modest-folder-view.c: (update_model):
1130 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1131 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1132 modest_tny_account_store_get_tny_account_by_account() to
1133 modest_tny_account_store_get_server_account() to make the code clearer.
1135 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1137 * src/dbus_api/modest-dbus-api.h:
1138 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1139 * src/maemo/modest-msg-edit-window.c:
1140 (modest_msg_edit_window_attach_file_noninteractive):
1141 added g_warning in case the file to be attached does not exist
1142 * tests/dbus_api/test_compose_mail.c: (main):
1143 removed obsolete comment, added generic files as test case
1145 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-tny-account-store.c: (get_server_accounts):
1148 Create the local folders account only once, not once for each outbox, and
1149 not only when there are some outboxes.
1151 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1153 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1154 code that is causing a crash at startup. Sergio says that he is fixing this.
1156 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1158 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1159 * src/maemo/modest-account-settings-dialog.c:
1160 (create_page_outgoing),
1161 (modest_account_settings_dialog_set_account_name),
1162 (save_configuration):
1163 - Fixed handling of the "Use secure authentication" toggle to comply with
1164 the ui specification. See also projects.maemo.org bug NB#58400
1166 - Restore the Secure connection setting combo correctly when loading
1169 * src/maemo/modest-maemo-utils.c:
1170 (on_camel_account_get_supported_secure_authentication),
1171 (modest_maemo_utils_get_supported_secure_authentication_methods):
1172 Fixed a crasher if operation is canceled
1174 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1175 (modest_protocol_info_auth_is_secure):
1176 * src/modest-protocol-info.h:
1178 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1179 the sense of the "Use secure authentication" toggle.
1181 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1183 * src/modest-tny-account-store.h:
1184 * src/modest-tny-account-store.c:
1185 Added modest_tny_account_store_get_local_folders_account().
1187 * src/modest-tny-folder.h:
1188 * src/modest-tny-folder.c:
1189 (modest_tny_folder_get_account):
1190 Added this replacement for tny_folder_get_account() which returns
1191 the local-folders account for TnyMergeFolders, to avoid the
1192 warning about the unimplemented get_account_func() vfunc().
1194 (modest_tny_folder_get_rules),
1195 * src/modest-ui-actions.c:
1196 (modest_ui_actions_on_folder_selection_changed):
1197 * src/modest-mail-operation.c:
1198 (modest_mail_operation_remove_folder),
1199 (modest_mail_operation_xfer_folder),
1200 (modest_mail_operation_rename_folder),
1201 (modest_mail_operation_get_msg),
1202 (modest_mail_operation_get_msgs_full),
1203 (modest_mail_operation_remove_msg),
1204 (modest_mail_operation_xfer_msgs),
1205 (modest_mail_operation_refresh_folder):
1206 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1208 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1211 (modest_server_account_set_security):
1212 * src/modest-defs.h: Add comments explaining that our
1213 UI spec means TLS when it says Normal, so these do not look like errors.
1215 * src/modest-tny-account.c:
1216 (modest_tny_account_new_from_server_account): Use the new tinymail
1217 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1218 for TLS. This should fix projects.maemo.org bug NB#58460.
1220 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1222 * src/maemo/easysetup/modest-easysetup-wizard.c:
1223 (create_account): Correct the position of the gconf sanity check warning.
1224 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1225 of using the g_idle_add() hack, because this does not seem to be necessary
1226 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1227 caused by something other than maemo's gconf.
1228 This fixes projects.maemo.org bug #59022.
1230 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-account-mgr-helpers.c:
1233 (modest_account_mgr_get_default_account): Do not check that the account
1234 exists if there is no default account (NULL), to fix a runtime warning.
1236 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1238 * src/widgets/modest-folder-view.c: (update_model):
1239 Do not unref the treemodel before we have finished with it.
1240 This prevents a valgrind warning and an occasional crash at startup.
1242 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1244 * libmodest-dbus-client/libmodest-dbus-client.h:
1245 added libmodest_dbus_client_compose_mail()
1246 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1248 added functions needed for SendAsMail() functionality
1249 * src/maemo/modest-msg-edit-window.c:
1250 (modest_msg_edit_window_attach_file_noninteractive):
1251 non interactively attaching files to message edit window
1252 * src/widgets/modest-msg-edit-window.h:
1253 * tests/dbus_api/Makefile.am:
1254 added test_compose_mail.c
1255 * tests/dbus_api/test_compose_mail.c: (main):
1257 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1259 * src/modest-account-view.c:
1260 Fixed bug projects.maemo.org bug NB#59307
1262 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1264 * src/maemo/easysetup/modest-easysetup-wizard.c:
1265 (get_serverport_incoming), (on_before_next), (create_account):
1266 * src/maemo/modest-account-settings-dialog.c:
1267 (modest_account_settings_dialog_set_account_name):
1268 * src/maemo/modest-maemo-utils.c:
1269 (on_camel_account_get_supported_secure_authentication_status),
1270 (on_camel_account_get_supported_secure_authentication),
1271 (on_secure_auth_cancel),
1272 (modest_maemo_utils_get_supported_secure_authentication_methods):
1274 Implemented security authentication for settings and easysetup.
1276 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/modest-main-window.c: (create_details_widget):
1279 Show the total size for memory card accounts too, instead of showing
1280 the name again. Fixes bug projects.maemo.org bug NB#59307.
1282 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-tny-simple-folder-store.c:
1286 * src/modest-tny-simple-folder-store.h: Removed.
1288 * src/modest-tny-local-folders-account.h
1289 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1290 for the local-folders maildir, with an extra TnyMergedFolder containing
1291 the folders of the per-account outbox store accounts.
1292 * src/modest-tny-account-store.c: (get_server_accounts):
1293 Add the outboxes to the special local folders account after creating it.
1295 * src/modest-tny-account.c:
1296 (modest_tny_account_new_for_local_folders): Create the derived
1297 account when creating the main local-folders account.
1299 * src/maemo/modest-main-window.c: (create_details_widget),
1300 (modest_main_window_set_contents_style):
1301 Adapted to the use of the derived account instead of the folder store.
1303 * src/modest-ui-actions.c:
1304 (modest_ui_actions_on_folder_selection_changed):
1305 * src/modest-ui-dimming-rules.c:
1306 (modest_ui_dimming_rules_on_new_folder):
1307 * src/widgets/modest-folder-view.c: (text_cell_data),
1308 (icon_cell_data), (filter_row), (update_model),
1309 (get_cmp_rows_type_pos):
1312 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1313 Do not get the priv struct, because no priv struct has been set,
1314 to avoid a runtime warning.
1316 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1317 #ifelse with #else, to fix a warning, to fix the build.
1320 2007-06-05 Christian Kellner <ckellner@openismus.com>
1322 * libmodest-dbus-client/libmodest-dbus-client.c:
1323 Fix small typo in doc (why do you always see them
1324 AFTER committing stuff?)
1327 2007-06-05 Christian Kellner <ckellner@openismus.com>
1329 * libmodest-dbus-client/libmodest-dbus-client.c:
1330 (libmodest_dbus_client_search):
1331 Initialize hit list with NULL. Also set folder list
1332 to "" if NULL was supplied.
1335 2007-06-03 Christian Kellner <ckellner@openismus.com>
1337 * libmodest-dbus-client/libmodest-dbus-client.c:
1338 (modest_search_hit_list_free):
1339 Make it save to call it with NULL.
1341 * src/dbus_api/modest-dbus-callbacks.c:
1342 * src/modest-search.c:
1343 Return full ModestSearchHits as the search result list not TnyHeader
1344 since can't be around withouth the correspoding TnyFolder.
1346 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1348 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1349 Added currently commented code to check for secure auth
1351 * src/maemo/modest-account-settings-dialog.c: (on_response),
1352 (save_configuration), (show_ok):
1353 Fixed projects.maemo.org bugs NB #59248 and #59251
1355 * src/maemo/modest-maemo-utils.c:
1356 (on_camel_account_get_supported_secure_authentication_status),
1357 (on_camel_account_get_supported_secure_authentication),
1358 (modest_maemo_utils_get_supported_secure_authentication_methods):
1359 * src/maemo/modest-maemo-utils.h:
1360 Moved get_supported_secure_authentication() method here to be able
1361 to use it from easysetup wizard.
1363 * src/modest-pair.c: (on_pair_compare_as_string):
1364 Should compare string with first part of pair and not
1365 strcmp pairs which will crash.
1367 * src/modest-protocol-info.c:
1368 (modest_protocol_info_protocol_is_store):
1369 * src/modest-protocol-info.h:
1370 Added modest_protocol_info_get_auth_protocol_name()
1372 2007-06-03 Armin Burgmeier <armin@openismus.com>
1374 * src/modest-mail-operation.c:
1375 (modest_mail_operation_get_msgs_full): Set priv->account also when
1376 only retrieving a single message. This avoids a crash when canceling
1379 (modest_mail_operation_notify_end): Do not explicitely remove the
1380 operation from the queue but only emit the progress_changed signal.
1381 The queue itself listens to that signal to remove the operation when
1382 it is finished. This reduces coupling and removes a potential deadlock
1383 when modest_mail_operation_notify_end() is called from the queue
1384 itself. If that is a problem performance-wise, I would suggest to
1385 implement a status-changed signal or something.
1387 * src/modest-mail-operation-queue.c: Make sure to never call a
1388 function from another file while the queue is locked. This (hopefully)
1389 fixes another deadlock when exiting the application while retrieving
1392 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1394 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1395 Fixed build if libogs is not available
1397 2007-06-03 Christian Kellner <ckellner@openismus.com>
1399 * libmodest-dbus-client/libmodest-dbus-client.h:
1400 * libmodest-dbus-client/libmodest-dbus-client.c:
1401 (libmodest_dbus_client_delete_message):
1402 Implement deletion of messages (Client side).
1404 (modest_search_hit_free),
1405 (modest_search_hit_list_free):
1406 Utility functions to free the result hits.
1408 * src/dbus_api/modest-dbus-api.h:
1409 * src/dbus_api/modest-dbus-callbacks.c:
1410 (on_delete_message),
1411 (modest_dbus_req_handler):
1412 Implement deletion of messages (Server side).
1414 * tests/dbus_api/test_search.c: (main):
1417 * tests/dbus_api/Makefile.am:
1418 * tests/dbus_api/test_delete_message:
1419 Add little test for the message deletion logic
1421 2007-06-03 Armin Burgmeier <armin@openismus.com>
1423 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1424 when the operation queue was not empty. projects.maemo.org bug
1427 2007-06-03 Armin Burgmeier <armin@openismus.com>
1429 * src/widgets/modest-account-view.c
1430 (on_account_default_toggled): Toggle default account column
1431 explicitely instead of waiting for gconf notification (which is
1432 currently ignored). This should fix projects.maemo.org bug NB#56910
1433 for now. It should probably be removed when gconf notifications are
1436 2007-06-03 Christian Kellner <ckellner@openismus.com>
1438 * libmodest-dbus-client/libmodest-dbus-client.c:
1439 Removed debugging spew.
1441 * src/dbus_api/modest-dbus-callbacks.c:
1442 Added debugging info.
1444 * src/modest-search.c:
1445 (modest_search_all_accounts):
1446 Use tny_account_store_get_accounts () on the account store
1447 to get all accounts which is the way to get all accounts.
1449 * tests/dbus_api/test_search.c: (main):
1450 Make it possible to supply the search term on the command line.
1452 2007-06-03 Christian Kellner <ckellner@openismus.com>
1454 * libmodest-dbus-client/libmodest-dbus-client.c:
1455 * libmodest-dbus-client/libmodest-dbus-client.h:
1456 Implement searching for mesages over raw dbus. (Client side)
1458 * src/dbus_api/Makefile.am:
1459 * src/dbus_api/modest-dbus-api.h:
1460 * src/dbus_api/modest-dbus-callbacks.c:
1461 * src/dbus_api/modest-dbus-callbacks.h:
1462 Search framework (Server side). Also implement on_idle_open_message().
1464 * src/maemo/modest-platform.c: (modest_platform_init):
1465 Prepare for raw dbus/osso rpc interaction.
1467 * src/modest-search.h:
1468 Changed minsize from unspecific guint to guint32.
1470 * src/modest-search.c:
1472 Added strange hack which magically made tnymail work.
1474 (modest_search_folder),
1475 (modest_search_account),
1476 (modest_search_all_accounts):
1477 Implement helper functions to search all accounts, specific account
1480 * tests/dbus_api/Makefile.am:
1481 * tests/dbus_api/test_open_message.c:
1482 Read url to open from commandline.
1484 * tests/dbus_api/test_search.c:
1485 Implement small test for dbus search stuff
1487 2007-06-02 Armin Burgmeier <armin@openismus.com>
1489 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1490 include account type and account title. This fixes projects.maemo.org
1493 * src/maemo/modest-account-view-window.c: Set a title for the window.
1495 2007-06-02 Armin Burgmeier <armin@openismus.com>
1497 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1498 incoming and outgoing server name based on email address and server
1499 types as long as the names have not been edited manually. This fixes
1500 projects.maemo.org bug NB#58671.
1502 2007-06-02 Armin Burgmeier <armin@openismus.com>
1504 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1505 server type cannot be changed in future to the incoming details page
1506 when creating an account. This fixes projects.maemo.org bug NB#59029.
1508 2007-06-02 Armin Burgmeier <armin@openismus.com>
1510 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1511 and assigned max width chars so that they wrap instead of being
1512 truncated. Fixes projects.maemo.org bug NB#56126.
1514 2007-06-02 Armin Burgmeier <armin@openismus.com>
1516 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1517 introductory note to the connection specific smtp servers dialog, as
1518 section 8.12 of the email UI specification requires. This fixes
1519 projects.maemo.org bug NB#59212.
1521 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1523 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1524 Check for running mail operations, and offer to cancel them, as per the UI
1525 spec. This fixes projects.maemo.org bug NB#59041 .
1526 However, I suspect that tinymail may still use the network connection
1527 in ways that we cannot detect or cancel. But it should at least adapt to
1528 changes fairly well.
1530 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1532 * src/modest-tny-account-store.c: (recreate_all_accounts),
1533 (get_cached_accounts), (get_server_accounts): Do more sensible
1534 ref-counting of the temporarily-cached outbox accounts list. This seems
1535 to fix a crash when entering the password when the password was wrong.
1537 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1539 * src/gnome/modest-main-window.c: (connect_signals):
1540 * src/modest-tny-account-store.c: (get_password),
1541 (modest_tny_account_store_alert): Added comments and clues and
1542 commented-out code about how we currently fail to deal with connection
1543 errors and wrong passwords, and how we should.
1545 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1547 * src/widgets/modest-retrieve-combo-box.c:
1548 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1549 This fixes projects.maemo.org bug NB#58472 .
1551 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1553 * src/maemo/easysetup/modest-easysetup-wizard.c:
1554 (create_page_complete_easysetup):
1555 (create_page_complete_custom): Correct the last commit,
1556 putting the correct sentences in the correct pages.
1558 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1560 * src/maemo/easysetup/modest-easysetup-wizard.c:
1561 (create_page_complete_custom): Show the second sentence of text
1562 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1565 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1567 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1568 Set the leave-on-server conf key by default. This fixes
1569 projects.maemo.org bug NB#59258 .
1571 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1573 * src/maemo/modest-account-view-window.c:
1574 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1575 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1578 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1580 * src/maemo/easysetup/modest-easysetup-wizard.c:
1581 (create_caption_new_with_asterisk):
1582 * src/maemo/modest-account-settings-dialog.c:
1583 (create_caption_new_with_asterisk):
1584 Uncomment the code to add the asterisk, because they are no longer in the
1585 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1586 (update_incoming_server_title): Add an asterisk here too.
1588 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1590 * src/maemo/modest-maemo-global-settings-dialog.c:
1591 (current_connection): Check that we are even connected before trying to
1592 get the current connection name, to prevent a warning.
1594 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1595 Change the comments because tny_maemo_conic_device_connect() is now meant to
1597 * src/modest-mail-operation.c:
1598 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1599 make sure we have a connection and fail if we can't connect.
1601 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1603 * src/maemo/modest-main-window.c:
1604 (on_account_store_connecting_finished): Do not try to get the
1605 connection ID if we are not really connected. I am surprised that
1606 this signal handler is called when we are not connected.
1608 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1610 * src/modest-error.h:
1611 * src/modest-ui-actions.c:
1612 (modest_ui_actions_get_msgs_full_error_handler):
1613 Renamed an enum, added comments, added an enum
1614 for retrieve-limit errors.
1616 * src/modest-mail-operation.c: (foreach_add_item),
1617 (internal_folder_observer_update), (update_account_thread),
1618 (modest_mail_operation_get_msgs_full):
1619 (modest_mail_operation_update_account),
1620 Added comments about how this works, and some code that should
1621 (but does not) check the retrieve-limit. See the TODO comment.
1623 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1626 Initialize help_id to fix the build. Warnings are good.
1628 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1630 * src/widgets/modest-hbox-cell-renderer.c:
1631 (modest_hbox_cell_renderer_append):
1632 * src/widgets/modest-vbox-cell-renderer.c:
1633 (modest_vbox_cell_renderer_append):
1634 Fix the last commit by doing an extra ref.
1636 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1638 * src/widgets/modest-hbox-cell-renderer.c:
1639 (modest_hbox_cell_renderer_append):
1640 * src/widgets/modest-vbox-cell-renderer.c:
1641 (modest_vbox_cell_renderer_append):
1642 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1643 to fix the build with Maemo Bora.
1644 However, there seems to be a remaining crash, probably due to reference
1647 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1649 * src/modest-tny-account.c:
1650 (modest_tny_account_new_for_local_folders):
1651 Use hildon_file_system_info_async_new() to get a better name for
1652 the memory card account, setting it as the account name.
1653 The timing seems to work, but this is probably
1654 not the best place to do this. See the TODO comment.
1655 * src/maemo/modest-main-window.c: (create_details_widget):
1656 * src/widgets/modest-folder-view.c: (text_cell_data):
1657 Use the tny account name instead of hardcoding a name.
1659 2007-05-30 Christian Kellner <ckellner@openismus.com>
1661 * src/modest-search.c: (modest_search):
1662 Correctly set part_search_func even if we have already parsed
1663 the query and thus a valid OgsTextSearcher object.
1665 2007-05-30 Christian Kellner <ckellner@openismus.com>
1668 Search and check for libogs.
1671 Incooparte the ogs build env.
1673 * src/modest-mime-part-search-stream.c:
1674 * src/modest-mime-part-search-stream.h:
1675 Removed since we do the real searching now in modest-search.c.
1677 * src/modest-search.c:
1678 * src/modest-search.h:
1679 Implement support for ogs. We use that if available and requested
1680 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1681 should now handle the corner case when the search term is spread
1682 across multiple reads.
1683 Also the logic in modest_search () was corrected to search all
1684 requested fields until one is found.
1686 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1688 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1690 * src/modest-init.h:
1691 * src/modest-init.c: Made modest_init_local_folders() take a
1692 path and be public so we can iniitialize maildir folders on
1695 * src/modest-local-folder-info.h:
1696 * src/modest-local-folder-info.c:
1697 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1699 * src/modest-tny-account.c:
1700 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1701 still means the standard local-folders path on the local volume.
1703 * src/modest-tny-account-store.c:
1704 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1705 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1706 all accounts when that happens.
1707 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1708 this too, so it shows up in the treeview.
1710 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1712 * src/maemo/modest-maemo-global-settings-dialog.c:
1713 (current_connection):
1714 * src/widgets/modest-global-settings-dialog.c:
1715 (current_connection_default):
1716 Use the enum values instead of 0, 1 and -1,
1717 to make the code clearer.
1719 * src/modest-account-mgr-helpers.c:
1720 (modest_account_mgr_get_connection_specific_smtp): Make this code
1723 * src/modest-runtime.h:
1724 * src/modest-runtime.c:
1725 Added modest_runtime_remove_all_send_queues().
1726 * src/maemo/modest-main-window.c:
1727 (on_account_store_connecting_finished): Recreate the send queues,
1728 using the appropriate transport accounts for this new connection.
1729 Some futher adapting might be needed if the old send queues are not
1730 automatically stopped at this point.
1732 * src/modest-tny-account-store.c: (get_server_accounts):
1733 Create the connection-specific transport accounts, so that they can
1734 be found later by their ID.
1736 * src/modest-tny-account.h:
1737 * src/modest-tny-account.c:
1738 Added modest_tny_account_new_from_server_account_name().
1739 modest_tny_account_new_from_server_account(): Do not create the
1740 send queues here, because they will be
1741 recreated anyway when the connection changes for the first time.
1743 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1745 * src/modest-local-folder-info.h:
1746 * src/modest-local-folder-info.c:
1747 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1748 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1749 tbox_folder): Take a modest account name instead of a server TnyAccount,
1750 so we can have per-modest-account rather than per-transport-account
1752 We must make sure that we change or recreate the exisitng send queues
1753 when the connection changes for connection-specific transport accounts.
1755 * src/modest-tny-account-store.c:
1756 (create_per_account_local_outbox_folders): Create outboxed per modest
1757 account, not per transport account.
1759 * src/modest-tny-account.h:
1760 * src/modest-tny-account.c:
1761 (modest_tny_account_get_special_folder): For outboxes, get the
1762 parent modest account name. The account is ignored for other folders.
1763 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1764 modest account name rather than a server TnyAccount.
1766 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-tny-account.c:
1769 (modest_tny_account_new_from_server_account):
1770 Call modest_runtime_get_send_queue() immediately after creating transport
1771 accounts, so that they start trying to send email from the outbox as soon
1772 as possible at startup. This is probably what we want.
1774 * src/modest-mail-operation.c: (update_account_thread):
1775 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1776 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1777 * src/modest-tny-send-queue.h:
1778 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1779 (modest_ui_actions_on_send):
1780 Added comments about how sending works, though it needs some more work.
1782 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1784 * src/modest-tny-account.c:
1785 (modest_tny_account_get_special_folder): Add TODO because this fails when
1786 the network is busy.
1787 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1788 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1789 Do not try to show this window when there is no active account. The UI
1790 specs does not tell us what to do in this case.
1792 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1796 * src/maemo/Makefile.am:
1797 * src/widgets/Makefile.am: Some dist fixes.
1799 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1801 * src/maemo/modest-connection-specific-smtp-window.c:
1802 (on_button_edit): Make the code clearer, to prevent a double free.
1804 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1806 * src/maemo/modest-account-settings-dialog.c:
1807 (modest_account_settings_dialog_set_account_name),
1808 Check the connection-specific smtp servers checkbox if there are any.
1810 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1811 (modest_connection_specific_smtp_edit_window_init):
1812 Start with a suitable port number.
1814 * src/modest-account-mgr-helpers.h:
1815 * src/modest-account-mgr-helpers.c: Added
1816 modest_account_mgr_get_has_connection_specific_smtp().
1818 (modest_account_mgr_set_connection_specific_smtp),
1819 (modest_account_mgr_remove_connection_specific_smtp),
1820 (modest_account_mgr_get_has_connection_specific_smtp),
1821 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1822 connection-specific smtp server accounts in the account, rather than
1823 the server account conf dir.
1825 This fixes bug projects.maemo.org bug NB#58263 .
1827 * src/modest-tny-account-store.c:
1828 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1829 if there are no server accounts yet, to prevent an infinite loop when there
1830 are no accounts. Document that one must be called before the other.
1832 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1834 * src/modest-account-mgr-helpers.c:
1835 (modest_account_mgr_get_default_account): Make sure that at least
1836 one account is always the default, if there are any enabled accounts.
1837 This is just a sanity check that shouldn't be necessary.
1839 * src/modest-account-mgr-priv.c:
1840 (_modest_account_mgr_account_from_key): Unescape the conf key to
1841 get the real account name. For instance, this is an issue if a space
1842 was in the account name, which can happen because the account name
1843 is generated from the display name.
1844 (_modest_account_mgr_get_account_keyname): Always escape the
1846 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1847 Unescape the conf keys to get the real account names.
1849 For instance, previously the is-default radio button in the accounts
1850 list was not checked for any accounts at first. This fixes that,
1851 and might fix several similar bugs.
1853 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1856 Removed some debug printfs.
1858 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1860 Modest on-disk outbox directories are now here, for instance:
1861 $HOME/.modest/outboxes/<account-id-1>/outbox
1862 $HOME/.modest/outboxes/<account-id-2>/outbox
1864 $HOME/.modest/local-folders/outbox
1865 so we can have a separate outbox for each account.
1866 But they are shown as one outbox in the GtkTreeView, by using a
1867 TnyMergeFolder in a ModestTnySimpleFolderStore.
1870 * src/modest-tny-simple-folder-store.c:
1871 * src/modest-tny-simple-folder-store.h:
1872 Added ModestTnySimpleFolderStore, used to contain folders from
1873 other folder stores, such as other accounts.
1875 * src/modest-tny-outbox-account.h:
1876 * src/modest-tny-outbox-account.c:
1877 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1878 used for the per-account local outbox folders.
1880 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1881 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1882 only use this (internally) now for the non-outbox local folders.
1884 * src/modest-init.h:
1885 * src/modest-init.c: Added modest_init_one_local_folder(), for
1886 setting up the directory structure for each local folder.
1888 * src/modest-local-folder-info.c:
1889 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1890 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1892 * src/modest-local-folder-info.h:
1893 * src/modest-tny-account-store.c: (on_account_removed),
1894 (on_account_changed), (create_per_account_local_outbox_folders),
1895 (get_server_accounts), (modest_tny_account_store_get_accounts),
1896 (modest_tny_account_store_get_tny_account_by_account),
1897 (modest_tny_folder_store_is_virtual_local_folders):
1899 * src/modest-tny-account.h:
1900 * src/modest-tny-account.c:
1901 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1902 to create an on-disk per-account local outbox folder for each
1904 (create_per_account_local_outbox_folders): Create a local outbox folder
1905 for each transport account.
1906 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1907 for all local folders.
1909 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1910 instead of using g_object_get/set() directly. It is clearer.
1912 (modest_tny_folder_store_get_message_count),
1913 (modest_tny_folder_store_get_local_size
1914 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1915 because we now use these with non-acount folder stores.
1917 (modest_tny_account_get_special_folder),
1918 (modest_tny_account_new_from_server_account),
1919 (modest_tny_account_new_from_account):
1920 (recurse_folders): Adjust to the new outbox system.
1922 * src/modest-tny-folder.h:
1923 * src/modest-tny-folder.c:
1924 (modest_tny_folder_is_local_folder),
1925 (modest_tny_folder_get_local_folder_type),
1926 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1928 * src/widgets/modest-main-window.h:
1929 * src/maemo/modest-main-window.c: (create_details_widget),
1930 (modest_main_window_set_contents_style): Show details for any folder store,
1933 (modest_tny_folder_get_rules):
1934 Remove the const. C does not support constness enough for this.
1936 * src/modest-ui-actions.c:
1937 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1938 make all outboxes appear as one, in the usual local-folders tree node.
1940 (set_active_account_from_tny_account),
1941 (modest_ui_actions_on_folder_selection_changed):
1942 * src/widgets/modest-folder-view.c: (text_cell_data),
1943 (icon_cell_data), (filter_row),
1944 (add_account_folders_to_merged_folder),
1945 (add_account_folders_to_simple_folder_store), (),
1946 (get_cmp_rows_type_pos), (cmp_rows),
1947 (modest_folder_view_set_account_id_of_visible_server_account):
1948 Adjust to the new outbox system, using generic folder stores and folders
1949 in the GtkTreeModel.
1951 2007-05-23 Christian Kellner <ckellner@openismus.com>
1953 * src/modest-mail-operation.c:
1954 (modest_mail_operation_update_account):
1955 Use info->max_size instead of unintialized local var [small
1956 build fix]. (Added TODO to review that change since I don't
1959 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1961 * libmodest-dbus-client/libmodest-dbus-client.c:
1962 (libmodest_dbus_client_compose_mail): function added
1963 * src/dbus_api/modest-dbus-api.h:
1964 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1965 (on_compose_mail): Implementation of the SendAsMail functionality
1967 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1969 * src/modest-account-mgr.c:
1970 (modest_account_mgr_add_server_account): Set the secure-connection
1971 conf key for transport accounts as well as store accounts. I don't know
1972 why the if was there. For instance, this makes sure that we use SSL
1973 for the gmail preset from the easysetup wizard.
1975 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1977 * src/gnome/modest-main-window.c:
1978 (on_account_store_connecting_finished), (connect_signals):
1979 * src/maemo/modest-main-window.c:
1980 (on_account_store_connecting_finished), (connect_signals),
1981 (modest_main_window_new):
1982 Handle TnyAccountStore::connecting-finished instead of
1983 TnyDevice::connection-changed, because we cannot actually perform
1984 operations on accounts until TnyAccountStore has itself responded to
1985 the TnyDevice::connection-changed signal. This prevents a GError from
1987 Do not try to update at startup, because we (at least on scratchbox)
1988 already do an update at startup when the device goes online.
1989 This prevents a GError from tinymail.
1990 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1991 Added TODO about stopping simultaneous operations.
1993 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1995 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1996 * src/modest-mail-operation-queue.c:
1997 (modest_mail_operation_queue_remove):
1998 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1999 about where they happened.
2001 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2003 * src/modest-ui-actions.c:
2004 (modest_ui_actions_on_password_requested): Make sure that the remember
2005 output parameter is always TRUE.
2007 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2009 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2010 Show a OK/Cancel dialog if the error is a question, though we still do not
2011 know anything more about what we are asking the user.
2012 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2013 Fix an uninitialized variable (helper). This is a logic error, however.
2015 2007-05-21 Christian Kellner <ckellner@openismus.com>
2017 * src/modest-search.h:
2018 Correct bit shifting in the ModestSearchFlags enum.
2020 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2022 * src/modest-tny-account.c:
2023 (modest_tny_account_new_from_server_account): Do not use the lsub and
2024 check-all hard-coded IMAP options when using POP.
2026 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2028 * src/modest-tny-account.c:
2029 (modest_tny_account_new_from_server_account):
2030 Use NULL for the secure-auth method for POP when Password auth has been
2031 specified by the user, as we already do for IMAP. "auth=Login" causes
2032 an error from camel or the server.
2034 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2036 * src/maemo/modest-account-settings-dialog.c:
2037 (create_page_account_details),
2038 (modest_account_settings_dialog_set_account_name):
2039 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2040 for the leave-on-server checkbox, rathr than just the checkbox, when
2041 the protocol is not POP.
2043 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2045 * src/widgets/modest-account-view.c:
2046 * src/widgets/modest-account-view.h:
2047 Added modest_account_view_select_account() which will be useful later
2048 to asynchronously re-select the edited account.
2050 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2052 * src/maemo/modest-account-settings-dialog.c:
2053 (modest_account_settings_dialog_set_account_name):
2054 Automatically choose the port numbers based on the secure authentication
2055 methods, if they have not been chosen before.
2056 This fixes projects.maemo.org bug NB#56273 .
2058 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2060 * src/maemo/modest-main-window-ui.h:
2061 * src/modest-ui-actions.c:
2062 * src/modest-ui-actions.h:
2063 Connect the Tools/SMTP Servers menu item to
2064 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2065 SMTP servers dialog, as in the UI specification and saves changes when it
2066 is closed. This fixed projects.maemo.org bug NB#56305 .
2068 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/modest-connection-specific-smtp-window.c:
2071 (modest_connection_specific_smtp_window_init):
2072 Use gtk_window_set_default_size() to make this window big enough, so
2073 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2075 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2077 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2078 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2079 (modest_connection_specific_smtp_edit_window_init),
2080 Do not try to connect to a combobox signal before the combobox exists.
2081 This fixes the cras in projects.maemo.org bug NB#56288 .
2082 (modest_connection_specific_smtp_edit_window_get_settings):
2083 Remove the server_account_name parameter which was being checked for NULL
2084 though it was not used.
2086 * src/maemo/modest-connection-specific-smtp-window.c:
2087 (modest_connection_specific_smtp_window_fill_with_connections),
2088 (on_button_edit), (modest_connection_specific_smtp_window_init):
2089 Correct the number of treemodel columns to prevent a warning.
2090 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2091 libconic does not work.
2093 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2095 * src/modest-tny-account.c:
2096 (modest_tny_account_new_from_server_account):
2097 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2098 SMTP when "None" was chosen by the user. However, with my SMTP server that
2099 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2102 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2104 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2105 to explain the memory management issue with the ID in the ModestPair.
2107 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2108 (add_sending_page), (modest_account_assistant_finalize):
2109 * src/gnome/modest-gnome-global-settings-dialog.c:
2110 (create_updating_page), (create_composing_page):
2111 * src/gnome/modest-msg-edit-window.c: (get_transports),
2112 (init_window), (modest_msg_edit_window_finalize),
2113 (modest_msg_edit_window_get_msg_data):
2114 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2115 * src/gnome/modest-transport-widget.c:
2116 (modest_transport_widget_finalize), (smtp_configuration):
2117 * src/maemo/modest-maemo-global-settings-dialog.c:
2118 (create_updating_page), (create_composing_page):
2119 * src/maemo/modest-msg-edit-window.c: (get_transports),
2120 (init_window), (modest_msg_edit_window_finalize),
2121 (modest_msg_edit_window_get_msg_data),
2122 (modest_msg_edit_window_free_msg_data):
2123 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2124 (modest_store_widget_finalize):
2125 * src/maemo/modest-transport-widget.c:
2126 (modest_transport_widget_finalize), (smtp_configuration):
2127 * src/modest-main.c: (send_mail):
2128 * src/widgets/modest-combo-box.h:
2129 * src/widgets/modest-global-settings-dialog-priv.h:
2130 * src/widgets/modest-global-settings-dialog.c:
2131 (modest_global_settings_dialog_finalize):
2132 * src/widgets/modest-msg-edit-window.h:
2133 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2134 as long as the combo box, to prevent use of freed memory for the ID.
2136 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2138 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2139 get_accounts(), to make this clearer. Do not check for the enabled gconf
2140 key, because we do not use this for server accounts (at least, not yet).
2141 This allows us to send email again.
2143 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2145 * src/maemo/modest-platform.c:
2146 (on_modest_conf_update_interval_changed), (modest_platform_init):
2147 Only respond to this particular key change. All these strcmp()s cannot be
2150 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2152 * src/maemo/modest-maemo-global-settings-dialog.c:
2153 (current_connection): Prevent a crash in scratchbox when
2154 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2155 * src/maemo/modest-platform.c:
2156 (on_modest_conf_update_interval_changed), (modest_platform_init):
2157 Get the update interval from gconf and reset it when the gconf key changes.
2159 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2161 * src/modest-protocol-info.c:
2162 * src/modest-protocol-info.h: Adde enum-specific get functions,
2163 instead of using a ModestProtocolType enum parameter.
2165 * src/gnome/modest-account-assistant.c:
2166 * src/gnome/modest-store-widget.c:
2167 * src/gnome/modest-store-widget.h:
2168 * src/gnome/modest-transport-widget.c:
2169 * src/gnome/modest-transport-widget.h:
2170 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2171 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2172 * src/maemo/easysetup/modest-easysetup-wizard.c:
2173 * src/maemo/modest-account-settings-dialog.c:
2174 * src/maemo/modest-account-settings-dialog.h:
2175 * src/maemo/modest-store-widget.c:
2176 * src/maemo/modest-store-widget.h:
2177 * src/maemo/modest-transport-widget.c:
2178 * src/maemo/modest-transport-widget.h:
2179 * src/modest-account-mgr-helpers.c:
2180 * src/modest-account-mgr-helpers.h:
2181 * src/modest-account-mgr.c:
2182 * src/modest-account-mgr.h:
2183 * src/modest-tny-account.c:
2184 * src/modest-tny-folder.c:
2185 * src/widgets/modest-account-view.c:
2186 * src/widgets/modest-retrieve-combo-box.c:
2187 * src/widgets/modest-retrieve-combo-box.h:
2188 * src/widgets/modest-secureauth-combo-box.c:
2189 * src/widgets/modest-serversecurity-combo-box.c:
2190 * src/widgets/modest-serversecurity-combo-box.h:
2191 * tests/check_account-mgr.c:
2192 Use the specific functions, and use the re-renamed enum values for GNOME too.
2194 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2196 * src/modest-pair.h:
2197 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2198 so we can get the second based on the first.
2200 * src/maemo/modest-account-settings-dialog.h:
2201 * src/maemo/modest-account-settings-dialog.c:
2202 Added get_supported_secure_authentication_methods(), though it is mostly
2203 commented-out for now until the necessary API is committed to tinymail.
2204 (modest_account_settings_dialog_set_account_name),
2205 (save_configuration): Request the supported authentication methods from the
2206 server, so we can choose a working method.
2208 * src/modest-tny-account-store.h:
2209 * src/modest-tny-account-store.c:
2210 (modest_tny_account_store_get_session): Rename from
2211 tny_account_store_get_session().
2213 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2215 * src/modest-protocol-info.h: Split the ModestProtocol enum
2216 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2217 There was no need to have these unrelated values in one enum.
2219 * src/: many files: Adapted to changed enum. This makes the code a bit
2220 clearer, and the compiler could catch some errors.
2222 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2224 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2225 Show the detailed internal camel error message when an error happens
2226 during the configuration, so that our testers can give us more clues.
2227 For instance, in projects.maemo.org bug NB#56910 .
2229 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2231 * src/modest-tny-account.c:
2232 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2233 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2235 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2237 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2238 * src/maemo/modest-account-settings-dialog.c:
2239 (modest_account_settings_dialog_set_account_name),
2240 (save_configuration): For the incoming secure authentication checkbox,
2241 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2242 the UI specification. PLAIN does not seem to be supported for most IMAP
2243 servers anyway, and I am not sure what it would mean.
2244 However, we probably need to discover which of the secure-authentication
2245 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2246 * src/modest-account-mgr-helpers.c:
2247 (modest_account_mgr_get_server_account_data):
2249 * src/modest-tny-account.c:
2250 (modest_tny_account_new_from_server_account):
2251 Use tny_account_set_mech() to set secure-authentication methods,
2252 with some special-casing for IMAP, based on my observations of how
2255 * src/modest-account-mgr-helpers.h:
2256 * src/modest-account-mgr.c:
2257 * src/modest-defs.h: Comment that the URI is only used for local folders.
2259 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2261 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2262 parameter const, just to be neat.
2263 * src/modest-text-utils.c: (modest_text_utils_inline):
2264 End g_strconcat() with NULL, as its documentation says. This is almost
2265 certainly the cause of my crash at startup on the device. Interestingly,
2266 valgrind doesn't tell us about these errors.
2268 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2270 * scripts/build-packages: Added more precise comments about how to use
2271 this script, though I still get this error:
2272 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2273 error building tinymail
2275 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2277 * src/maemo/modest-main-window.c: (on_account_update):
2278 Very slight cleanup, hoping to make it simpler to discover what causes
2279 a crash here sometimes.
2281 * src/modest-tny-account.c:
2282 (modest_tny_account_new_from_server_account): Set the port. Added
2283 comments about the options and a TODO comment because I need to find out
2284 how to specify the secure authentication method.
2286 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2288 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2289 changed CFlags paths form modest to libmodest
2291 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2293 * src/modest-account-mgr-helpers.c:
2294 (modest_account_mgr_get_server_account_data),
2295 (modest_account_mgr_free_server_account_data):
2296 * src/modest-account-mgr-helpers.h:
2297 * src/modest-account-mgr.c:
2298 (modest_account_mgr_add_server_account):
2299 * src/modest-defs.h:
2300 * src/modest-tny-account.c:
2301 (modest_tny_account_new_from_server_account):
2302 Determine the options for tny_camel_account_add_option() here,
2303 based on the settings, rather than storing them directly in gconf.
2305 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2307 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2308 Show a more friendly error dialog now that we expect (from the tinymail
2309 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2311 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2313 * src/maemo/modest-main-window.c: (on_account_update): Check that
2314 account_name is not NULL, to prevent a crash at startup that I am
2315 seeing on the N800. I do wonder why it is NULL.
2317 * src/maemo/easysetup/modest-easysetup-wizard.c:
2318 (create_page_user_details):
2319 * src/maemo/modest-account-settings-dialog.c:
2320 (create_page_user_details), (create_page_outgoing):
2321 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2322 (modest_connection_specific_smtp_edit_window_init):
2323 * src/modest-ui-actions.c:
2324 (modest_ui_actions_on_password_requested):
2325 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2326 might do something useful with the on-screen keyboard.
2328 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2330 * src/maemo/modest-main-window.c: (on_account_update):
2331 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2332 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2334 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2336 * src/modest-tny-account-store.c: (on_account_changed):
2337 Correct the signature of this signal handler.
2339 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2341 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2342 Show a HildonNote instead of a GtkDialog for Maemo.
2344 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2346 * src/widgets/modest-account-view.h:
2347 * src/widgets/modest-account-view.c: (on_account_changed),
2348 (on_account_removed). Added a boolean flag, set/unset by
2349 modest_account_view_block_conf_updates(),
2350 modest_account_view_unblock_conf_updates() to prevent unnecessary
2351 updates, but this is not very useful because the gconf notifications are
2352 so delays (maybe only on Maemo Bora).
2353 So auto-updating is turned off, and these functions do an explicit
2354 update when necessary.
2355 However, something else is still doing too much work when adding/removing
2356 accounts, probably in another part of the application.
2358 * src/maemo/modest-account-view-window.c:
2359 (on_delete_button_clicked), (on_edit_button_clicked),
2360 (on_new_button_clicked): Use the new functions.
2362 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2364 * src/modest-account-mgr-helpers.c:
2365 (modest_account_mgr_set_first_account_as_default):
2366 Sort the list of names alphabetically-by-title, so we choose the first one
2368 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2369 alphabetically by the title.
2371 This fixes projects.maemo.org bug NB#56418 .
2373 * src/modest-account-mgr-priv.c:
2374 (_modest_account_mgr_account_from_key):
2375 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2376 avoid a valgrind error, and possible random behaviour.
2378 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2380 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2381 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2382 tinymail documentation to say that this can be expected.
2383 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2384 pretty, and should not happen, but I would prefer to know when it does.
2386 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2388 * configure.ac: When using the older hildon version, probably on Bora,
2389 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2391 * src/widgets/modest-attachment-view.c:
2392 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2395 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2397 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2398 Implemented the prototype. Can be tested with
2399 tests/dbus_api/test_open_message:
2401 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-tny-account-store.c:
2404 (modest_tny_account_store_instance_init), (get_password):
2405 * src/modest-ui-actions.c:
2406 (modest_ui_actions_on_password_requested):
2407 Do not store the password in gconf, because this function is called
2408 for non-remembered passwords. Actually use the cached (in the hash map)
2409 password instead of releasing it.
2410 The password will now not be remembered if it is asked via the protected
2411 password dialog, as per the UI spec.
2413 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2415 * src/modest-defs.h:
2416 * src/modest-account-mgr-helpers.h:
2417 * src/modest-account-mgr-helpers.c:
2418 Added modest_server_account_get_username_has_succeeded(),
2419 modest_server_account_set_username_has_succeeded().
2420 (modest_server_account_set_username),
2421 Reset the has-succeeded flag if the username changes.
2423 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2424 * src/maemo/modest-connection-specific-smtp-window.c:
2425 (modest_connection_specific_smtp_window_save_server_accounts):
2426 Use modest_server_account_set_username() instead of using
2427 modest_conf_set_string() directly, so that the has-succeeded flag is always
2430 * src/modest-ui-actions.c:
2431 (modest_ui_actions_on_password_requested): Dim the username entry if
2432 the username has ever worked, as per the UI spec.
2434 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2436 * src/modest-tny-account-store.c: (get_password):
2437 * src/modest-ui-actions.c:
2438 (modest_ui_actions_on_password_requested):
2439 Allow the username to be changed too, though there is more work to
2440 be done on exactly how this behaves.
2442 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2444 * src/modest-account-mgr-helpers.h:
2445 * src/modest-account-mgr-helpers.c:
2446 Added modest_account_mgr_get_display_name(),
2447 modest_server_account_get_username(),
2448 modest_server_account_set_username(),
2449 modest_server_account_set_password(),
2450 modest_server_account_get_hostname() functions so we do not need to
2451 use the conf API directly.
2453 * src/maemo/modest-main-window.c: (connect_signals):
2454 Actually connect ot the ModestAccountStore::request-password signal,
2455 so that we show the dialog when the password is requested by Tinymail,
2456 for isntance if it is empty.
2458 * src/modest-marshal.list:
2459 * src/modest-tny-account-store.c:
2460 (modest_tny_account_store_class_init), (get_password),
2461 (modest_tny_account_store_alert):
2462 * src/modest-tny-account-store.h:
2463 * src/modest-ui-actions.h:
2464 * src/modest-ui-actions.c:
2465 (modest_ui_actions_on_password_requested):
2466 Change the signal parameters, so it is obvious that we are providing
2467 the non human-readable server name, and receiving both the username
2468 and password, though changing of the username is not yet implemented.
2469 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2470 for the GNOME version.
2472 This should fix the projects.maemo.org bug NB#56209, though it does not
2473 work on Bora, because the gconf_client_get() for the password fails
2474 immediately after we save it with gconf_client_set().
2476 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2479 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2480 caused an undefined symbol error:
2481 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2483 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2485 * src/modest-tny-account-store.c:
2486 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2487 using a GError instead of a string message, so we can translate it in
2490 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2492 * src/maemo/modest-address-book.c:
2493 (modest_address_book_check_names):
2494 * src/maemo/modest-msg-view-window.c:
2495 (modest_msg_view_window_clipboard_owner_change):
2496 * src/modest-init.c: (modest_init_init_ui):
2497 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2498 (update_folders_cb), (modest_mail_operation_update_account):
2499 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2500 (modest_ui_actions_on_msg_attachment_clicked),
2501 (modest_ui_actions_on_msg_recpt_activated):
2502 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2503 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2504 (modest_msg_view_search_next):
2505 * src/widgets/modest-recpt-editor.c:
2506 (modest_recpt_editor_on_button_release_event),
2507 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2508 g_message(). At this point we should only be seeing interesting errors on
2509 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2511 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2513 (modest_wizard_dialog_force_title_update):
2514 * src/maemo/easysetup/modest-wizard-dialog.h:
2515 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2516 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2517 can update the title when appropriate. Otherwise the title is wrong if the
2518 pages are added after adding the notebook to the dialog.
2519 This must be a problem in HildonWizardDialog too.
2520 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2522 * src/maemo/easysetup/modest-easysetup-wizard.c:
2523 (create_subsequent_customsetup_pages),
2524 (create_subsequent_easysetup_pages):
2525 Call modest_wizard_dialog_force_title_update() so that the title is
2526 correct even with GTK+ < 2.10.
2527 This fixes projects.maemo.org bug NB#56145 .
2529 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2531 * src/maemo/modest-platform.c:
2532 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2533 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2536 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2538 * src/widgets/modest-window.h:
2539 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2540 and modest_window_save_state(), which invokes it.
2542 * src/widgets/modest-window-mgr.h:
2543 * src/widgets/modest-window-mgr.c:
2544 Added modest_window_mgr_save_state_for_all_windows(), which calls
2545 the save_state vfunc on all registered windows, if implemented.
2547 * src/gnome/modest-msg-edit-window.c:
2548 * src/gnome/modest-msg-view-window.c:
2549 * src/maemo/modest-msg-edit-window.c:
2550 * src/maemo/modest-msg-view-window.c:
2551 * src/maemo/modest-main-window.c:
2552 Specify the existing save_settings functions as implementations of
2553 ModestWindow::save_state_func().
2555 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2556 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2557 enabling hibernation, for instance.
2559 We may need to do the same thing for restoring settings.
2562 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2564 * src/widgets/modest-window-mgr.c:
2565 * src/widgets/modest-window-mgr.h:
2566 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2567 modest_window_mgr_get_hibernation_is_prevented().
2569 * src/maemo/modest-main-window.c:
2570 (on_hildon_program_is_topmost_notify): Prevent hibernation
2571 (possible when the application goes to the background in the WM),
2572 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2574 * src/maemo/easysetup/modest-easysetup-wizard.c:
2575 (modest_easysetup_wizard_dialog_init):
2576 * src/maemo/modest-account-settings-dialog.c:
2577 (modest_account_settings_dialog_init):
2578 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2579 (modest_connection_specific_smtp_edit_window_init):
2580 * src/maemo/modest-connection-specific-smtp-window.c:
2581 (modest_connection_specific_smtp_window_init):
2582 * src/maemo/modest-signature-editor-dialog.c:
2583 (modest_signature_editor_dialog_init):
2584 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2585 prevent hibernation while any of these account settings dialogs are open.
2587 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2589 * src/maemo/Makefile.am:
2590 * src/maemo/modest-osso-state-saving.c:
2591 * src/maemo/modest-osso-state-saving.h: Added
2592 modest_osso_load_state() and modest_osso_save_state() though they do
2593 nothing now. They should iterate through all the open windows and load/save
2595 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2596 save state when closing.
2598 * src/maemo/modest-main-window.c:
2599 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2600 Add a notification handler for the HildonProgram::is-topmost property,
2601 so we can allow hibernation when the application goes into the background.
2602 But we still need to detect when the accounts setup windows are open so
2603 we can stop hibernation when they are open.
2604 To do this, I also added the main window the HildonProgram. This might have
2605 other side-effects/benefits, and should maybe be done for other windows.
2607 * src/maemo/modest-osso-autosave-callbacks.h:
2608 * src/maemo/modest-osso-autosave-callbacks.c:
2609 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2610 though it does not do anything yet, and we might never need this to do
2611 anything. For instance, we already save drafts.
2613 * src/maemo/modest-platform.c: (modest_platform_init):
2614 Specify the libosso auto-save callback.
2616 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/modest-platform.c:
2619 (modest_platform_set_update_interval):
2620 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2621 aparently stays valid between application instances, so we can use this
2622 to remove and reset it later. According to a maemo-developers email from
2625 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2627 * configure.ac: Depend on libalarm for Maemo.
2629 * src/dbus_api/modest-dbus-api.h:
2630 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2631 (on_send_receive), (modest_dbus_req_handler):
2632 Handle a SEND_RECEIVE D-Bus method.
2634 * libmodest-dbus-client/libmodest-dbus-client.c:
2635 (libmodest_dbus_client_send_and_receive):
2636 * libmodest-dbus-client/libmodest-dbus-client.h:
2637 Add C convenience functions for calling the new D-Bus method.
2639 * src/modest-platform.h:
2640 * src/gnome/modest-platform.c:
2641 * src/maemo/modest-platform.c:
2642 Added modest_platform_set_update_interval(), which uses the
2643 alarmd API on Maemo.
2644 (modest_platform_init),
2645 Call modest_platform_set_update_interval(), using a hard-coded
2646 interval for now (until the global settings dialog is implemented),
2647 though I am not sure that this makes sense yet.
2649 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2651 * src/dbus_api/modest-dbus-callbacks.c:
2652 (modest_osso_cb_hw_state_handler):
2653 * src/dbus_api/modest-dbus-callbacks.h:
2654 * src/maemo/modest-platform.c: (modest_platform_init):
2655 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2656 in case this has some effect on the ability for Maemo to ping the
2659 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2661 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2662 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2663 warning. It is probably a logic error, but I need to fix the build.
2665 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2667 * src/modest-account-mgr.h:
2668 * src/modest-account-mgr.c:
2669 (modest_account_mgr_account_names): Add a gboolean enabled_only
2670 parameter, so we can get lists of onlt the enabled accounts.
2672 (modest_account_mgr_add_account),,
2673 (modest_account_mgr_account_with_display_name_exists):
2674 * src/maemo/modest-msg-edit-window.c: (get_transports):
2675 * src/modest-account-mgr-helpers.c:
2676 (modest_account_mgr_set_first_account_as_default):
2677 * src/modest-init.c: (init_default_account_maybe):
2678 * src/modest-tny-account-store.c: (get_accounts):
2679 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2680 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2681 * tests/check_account-mgr.c: (START_TEST):
2682 Provide the extra parameter, as appropriate.
2684 * src/widgets/modest-account-view.c: (update_account_view):
2685 Do not show disabled accounts (meaning that there is no way to
2686 enable/disable accounts in the UI (the feature is not in our UI
2687 specification), so we can use this internally only to mark unfinished
2688 or temporary account data.
2690 * src/maemo/easysetup/modest-easysetup-wizard.c:
2691 (create_account): Add boolean enable parameter, so we can specify FALSE
2692 to create the temporary account.
2693 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2694 (on_before_next): When finishing, when there is a temporary account, just
2696 Also, use a timeout to delay the showing of the dialog until gconf is likely
2697 to return correct information, due to a maemo gconf bug that is fixed in
2698 osso 1.1, but not yet in Bora.
2699 However, the dialog stays on screen after it is destroyed.
2701 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2702 for invalid data when cancelling. Use a hildon note instead of a dialog
2703 to complain about invalid data. Do not show the account-saved note if the
2704 account is disabled (a temporary account that will not really be saved for use
2707 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2709 * src/modest-account-mgr-helpers.h:
2710 * src/modest-account-mgr-helpers.c:
2711 Added modest_account_mgr_unset_default_account(),
2712 Added modest_account_mgr_set_first_account_as_default().
2714 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2715 If it was the default account, unset the default account name.
2717 * src/maemo/modest-account-view-window.c:
2718 (on_delete_button_clicked): If it was the default account,
2719 set the first remaining account as the default instead.
2721 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2722 a NULL account or a NULL default account, to prevent a crash. This should
2723 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2726 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2728 * src/widgets/modest-recpt-editor.c:
2729 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2730 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2731 TODO comment for this. This fixes the build.
2733 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2734 be the best place for it. This will in future update all auto-update accounts,
2735 rather than just the current/default account, when that gconf key exists.
2736 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2737 if there are no accounts, before calling do_send_receive().
2738 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2740 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2741 * src/maemo/modest-main-window-ui.h:
2742 * src/maemo/modest-main-window.c: (on_connection_changed),
2743 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2744 directly, becaue the signal handler does more.
2746 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2748 * src/modest-account-mgr-helpers.c:
2749 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2750 for the case that the account does not exist.
2752 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2753 (equivalent to the modest account name) rather than the tinymail account name
2754 (equivalent to the modest account title - human readable) to get the account data.
2755 Check for null account data to prevent the crash, and add a TODO comment saying that
2756 this needs fixing because it is using the server account name instead of the account name.
2758 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2760 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2761 * src/maemo/modest-account-settings-dialog.c: (show_error),
2763 Use hildon_note_new_information() for informative and error messages,
2764 which seems to be expected for Maemo applications (no documentation that I know of
2765 says this). I am surprised that there is no distinction between info and error
2768 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2770 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2771 it is easy to find where this is used.
2773 * src/maemo/easysetup/modest-easysetup-wizard.c:
2774 (create_page_welcome), (create_page_account_details),
2775 (create_page_user_details), (create_page_complete_easysetup),
2776 (create_page_custom_incoming), (create_page_custom_outgoing),
2777 (create_page_complete_custom):
2778 * src/maemo/modest-account-settings-dialog.c:
2779 (create_page_account_details), (create_page_user_details),
2780 (create_page_incoming), (create_page_outgoing):
2781 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2782 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2783 (modest_connection_specific_smtp_edit_window_init):
2784 * src/maemo/modest-connection-specific-smtp-window.c:
2785 (modest_connection_specific_smtp_window_init):
2786 * src/maemo/modest-signature-editor-dialog.c:
2787 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2788 and scrolling policy as per the Email Application Layout Guide, if I have
2791 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2793 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2794 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2795 which were empty, because these vfuncs have been removed from TnyAccountStore.
2796 This fixes the build.
2798 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2800 * src/maemo/modest-main-window.c:
2801 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2802 showing/hiding it. Added TODO because it probably should not be NULL.
2803 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2804 because unnecessary g_warnings() make degugging difficult.
2806 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2808 * src/maemo/modest-msg-edit-window.c:
2809 (modest_msg_edit_window_select_color),
2810 (modest_msg_edit_window_select_background_color): 2 const corrections and
2811 moving 2 #endifs before closing brackets, to fix the build.
2813 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2815 * src/maemo/easysetup/modest-easysetup-wizard.h:
2816 * src/maemo/easysetup/modest-easysetup-wizard.c:
2817 (modest_easysetup_wizard_dialog_finalize),
2818 (on_button_edit_advanced_settings), (create_page_complete_custom),
2819 (on_response), (create_account):
2820 Implement the Advanced Settings edit button, by saving the account information,
2821 for the Advanded Settings dialog to use directly from gconf, and removing it
2822 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2823 Bug #5533 in the projects.maemo.org bugzilla.
2825 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2827 * src/maemo/modest-msg-view-window.c:
2828 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2829 when opening a message window.
2831 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2833 * src/maemo/easysetup/modest-easysetup-wizard.c:
2834 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2837 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2838 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2839 gconf settings. I probably added more checks than necessary, but that is safer.
2841 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2842 variable to fix the build, but this seems to be used when it is still NULL.
2844 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2846 * src/modest-platform.h:
2847 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2848 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2849 * src/modest-main.c: Implement this function so we can avoid using
2850 maemo-specific API from cross-platform code.
2852 * src/modest-tny-account-store.c:
2853 (get_smtp_specific_transport_account_for_open_connection):
2854 * src/modest-ui-actions.c: (check_for_connection),
2855 (modest_ui_actions_on_item_not_found):
2856 Use modest_platform_connect_and_wait() and put #idefs around other
2857 maemo-specific code, because only maemo currently has a way to
2858 identify connection names.
2860 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2862 * src/modest-tny-account-store.h:
2863 * src/modest-tny-account-store.c:
2864 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2865 the connection-specific SMTP server settings in the configuration.
2867 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2869 * src/maemo/modest-main-window.c: (on_connection_changed),
2871 * src/modest-main.c: (main), (start_ui), (send_mail):
2872 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2873 that is what is intended.
2875 * src/modest-ui-actions.c: (action_send), (action_receive),
2876 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2877 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2878 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2879 SMTP server is used when it is specified.
2881 (modest_ui_actions_on_send_receive):
2882 Check that a connection is open before proceeding.
2883 Receive and then send, instead of vice-versa, as per the specification.
2885 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2887 * src/modest-mail-operation.c:
2888 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2889 though I guess it should be something other than NULL.
2891 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2893 * src/maemo/easysetup/modest-easysetup-wizard.c:
2894 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2895 combo twice, to avoid an g_warning and to make it visible again.
2896 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2897 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2898 (already intended) dereference when detaching, because we then recreate the menu.
2899 But I am not sure why the warning was happening, and it is possible that this is a memory
2902 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2904 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2905 and uri_parse_mailto() utility functions.
2906 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2908 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2910 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2912 * src/dbus_api/modest-dbus-api.h:
2913 * src/dbus_api/modest-dbus-callbacks.c:
2914 Use an idle callback to execute the modest code in the application's own thread.
2915 Remove the helloworld example method.
2916 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2917 parsed, and the open-message method is not implemented because this is not yet implemented in
2919 * libmodest-dbus-client/libmodest-dbus-client.c:
2920 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2921 (libmodest_dbus_client_open_message):
2922 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2924 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2925 body without crashing.
2927 * tests/dbus_api/Makefile.am:
2928 * tests/dbus_api/test_mail_to.c:
2929 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2931 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2933 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2934 Added file to fix the build. Sorry.
2936 * src/dbus_api/Makefile.am:
2937 * src/dbus_api/modest-dbus-api.h:
2938 * src/dbus_api/modest-dbus-callbacks.h:
2939 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2940 (modest_dbus_req_handler):
2941 Put constants in a separate header so it can be reused by the
2942 client library, without duplication
2944 * libmodest-dbus-client/Makefile.am:
2945 * libmodest-dbus-client/libmodest-dbus-client.c:
2946 (libmodest_dbus_client_call_helloworld),
2947 (libmodfest_dbus_client_send_mail),
2948 (libmodfest_dbus_client_mailto),
2949 (libmodfest_dbus_client_open_message):
2950 * libmodest-dbus-client/libmodest-dbus-client.h:
2951 (Partly) Implement a send_mail D-Bus method.
2953 * tests/dbus_api/Makefile.am:
2954 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2955 the send_email D-Bus method.
2957 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2961 * libmodest-dbus-client/Makefile.am:
2962 * libmodest-dbus-client/libmodest-dbus-client.c:
2963 * libmodest-dbus-client/libmodest-dbus-client.h:
2964 * tests/dbus_api/Makefile.am:
2965 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2966 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2968 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2970 * src/maemo/easysetup/modest-easysetup-wizard.c:
2971 (create_page_account_details):
2972 * src/maemo/modest-account-settings-dialog.c:
2973 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2974 widgets, because this might not be the default in future versions of the Maemo GTK+.
2975 However, I can not not get capitalization to work even in a simple test case.
2977 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2979 * src/maemo/easysetup/modest-easysetup-wizard.c:
2980 (create_page_custom_incoming), (create_page_custom_outgoing):
2981 * src/maemo/modest-account-settings-dialog.c:
2982 (create_page_account_details), (create_page_incoming),
2983 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2984 instead of using gtk_check_button_with_label(), so they are aligned like the other
2985 widgets, as per the UI spec.
2987 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2989 * src/maemo/easysetup/modest-easysetup-wizard.c:
2990 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2991 * src/widgets/modest-validating-entry.c:
2992 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2993 Modest prefix instead of an EasySetup prefix.
2995 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2997 * src/widgets/modest-validating-entry.h:
2998 * src/widgets/modest-validating-entry.c: (on_insert_text),
2999 Added easysetup_validating_entry_set_max_func(), used to set a callback
3000 to call when the max number of characters is reached. GtkEntry has a max-length
3001 already but is silent about it.
3003 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3004 (create_page_account_details), (create_page_user_details),
3006 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3007 (create_page_account_details), (create_page_user_details),
3008 (create_page_outgoing):
3009 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3010 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3011 the UI spec, when the user tries to enter more than the max number of characters.
3013 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3015 * src/maemo/easysetup/modest-easysetup-wizard.c:
3016 (create_page_user_details), (create_page_custom_incoming),
3017 (create_page_custom_outgoing):
3018 * src/maemo/modest-account-settings-dialog.c:
3019 (create_page_user_details), (create_page_incoming),
3020 (create_page_outgoing):
3021 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3022 (modest_connection_specific_smtp_edit_window_init):
3023 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3024 not appropriate. Bad Maemo-specific defaults!.
3026 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3028 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3029 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3030 (modest_signature_editor_dialog_set_settings):
3031 Disable the label and textview when the checkbox is disabled, and use the
3032 specified (UI spec) default signature text.
3034 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3036 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3037 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3039 * src/modest-defs.h:
3040 * src/modest-account-mgr-helpers.h:
3041 * src/modest-account-mgr-helpers.c:
3042 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3044 * src/maemo/Makefile.am:
3045 * src/maemo/modest-signature-editor-dialog.c:
3046 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3049 * src/maemo/modest-account-settings-dialog.h:
3050 * src/maemo/modest-account-settings-dialog.c:
3051 (modest_account_settings_dialog_finalize), (on_button_signature),
3052 (save_configuration): Use the new dialog when the Edit button is pressed, and
3053 save the changes if necessary, as per the UI spec.
3055 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3057 * src/maemo/Makefile.am:
3058 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3059 based on maemo-develoers email from Dirk.
3061 * src/maemo/easysetup/modest-easysetup-wizard.c:
3062 (create_page_welcome), (create_page_account_details),
3063 (create_page_user_details), (create_page_complete_easysetup),
3064 (create_page_custom_incoming), (create_page_custom_outgoing),
3065 (create_page_complete_custom),
3066 (modest_easysetup_wizard_dialog_init):
3067 * src/maemo/modest-account-settings-dialog.c:
3068 (create_page_account_details), (create_page_user_details),
3069 (create_page_incoming), (create_page_outgoing),
3070 (modest_account_settings_dialog_init):
3071 * src/maemo/modest-connection-specific-smtp-window.c:
3072 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3074 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3076 * src/maemo/easysetup/modest-easysetup-wizard.c:
3077 (create_page_account_details), (create_page_custom_outgoing),
3078 (create_page_complete_custom):
3079 * src/maemo/modest-account-settings-dialog.c:
3080 (create_page_user_details), (create_page_incoming),
3081 (create_page_outgoing):
3082 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3083 (modest_connection_specific_smtp_edit_window_init):
3084 Use the correct (UI spec) port min/max, and use horizontal separators,
3087 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3089 * src/maemo/easysetup/modest-easysetup-wizard.c:
3090 (set_default_custom_servernames):
3091 * src/maemo/modest-account-settings-dialog.c:
3092 (create_page_incoming), (on_combo_outgoing_security_changed),
3093 (on_combo_incoming_security_changed), (create_page_outgoing),
3094 (modest_account_settings_dialog_set_account_name),
3095 (save_configuration):
3096 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3097 (on_combo_security_changed),
3098 (modest_connection_specific_smtp_edit_window_init),
3099 (modest_connection_specific_smtp_edit_window_set_connection),
3100 (modest_connection_specific_smtp_edit_window_get_settings):
3101 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3104 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3107 * src/maemo/easysetup/modest-easysetup-wizard.c:
3108 (create_page_custom_outgoing), (create_page_complete_custom):
3109 * src/maemo/modest-account-settings-dialog.c:
3110 (create_page_user_details), (create_page_outgoing):
3111 * src/maemo/modest-account-view-window.c: (button_box_new):
3112 Use changed logical IDs as per the most recent UI spec:
3113 mcen_bd_emailsetup_edit -> mcen_bd_edit
3114 mcen_bd_emailsetup_delete -> mcen_bd_delete
3115 mcen_bd_emailsetup_close -> mcen_bd_close
3117 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3121 * src/dbus_api/Makefile.am:
3122 * src/dbus_api/modest-dbus-callbacks.c:
3123 * src/dbus_api/modest-dbus-callbacks.h:
3124 * src/maemo/modest-platform.c: (modest_platform_init):
3125 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3127 * tests/Makefile.am:
3128 * tests/dbus_api/Makefile.am:
3129 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3131 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3133 * src/maemo/modest-account-settings-dialog.c:
3134 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3135 Removed unnecessary includes.
3137 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3139 * src/maemo/easysetup/modest-easysetup-wizard.c:
3140 * src/maemo/modest-account-settings-dialog.c:
3141 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3142 * src/widgets/Makefile.am:
3143 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3144 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3145 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3146 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3147 * src/widgets/modest-secureauth-combo-box.c:
3148 * src/widgets/modest-secureauth-combo-box.h:
3149 * src/widgets/modest-serversecurity-combo-box.c:
3150 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3151 made the GObject names more consistent with the rest of the Modest code.
3153 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3155 * src/maemo/easysetup/Makefile.am:
3156 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3157 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3158 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3159 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3160 * src/maemo/easysetup/modest-easysetup-wizard.c:
3161 * src/maemo/easysetup/modest-validating-entry.c:
3162 * src/maemo/easysetup/modest-validating-entry.h:
3163 * src/maemo/modest-account-settings-dialog.c:
3164 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3165 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3166 widgets/ because they are used outside of easysetup too. After checking in,
3167 svn will allow me to rename them too.
3169 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3171 * src/gnome/modest-msg-edit-window.c:
3172 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3173 linker error, to fix the build on the GNOME platform.
3174 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3175 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3176 ifdefed out to avoid a warning.
3178 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3180 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3181 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3182 some alternative for GTK+ 2.6.
3184 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3186 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3188 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3189 specified for EmailAccountsDialog in UI spec.
3191 * src/maemo/easysetup/modest-easysetup-wizard.c:
3192 * src/maemo/easysetup/modest-easysetup-wizard.h:
3193 * src/maemo/modest-account-settings-dialog.c:
3194 * src/maemo/modest-account-settings-dialog.h:
3195 Reuse a member window widget for the connection-specific SMTP server accounts,
3196 so we can tell it to create/save the accounts only if we actually save changes.
3198 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3199 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3200 (modest_connection_specific_smtp_edit_window_get_settings):
3201 Return a struct instance for temporarily remembering the entered data.
3203 * src/maemo/modest-connection-specific-smtp-window.h:
3204 * src/maemo/modest-connection-specific-smtp-window.c:
3205 (modest_connection_specific_smtp_window_finalize),
3206 (modest_connection_specific_smtp_window_fill_with_connections),
3208 (modest_connection_specific_smtp_window_save_server_accounts),
3209 (update_model_server_names): Do not actually save data until asked,
3210 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3212 (on_selection_changed),
3213 (modest_connection_specific_smtp_window_init): Disable the edit
3214 button when nothing is selected.
3216 * src/modest-account-mgr-helpers.c:
3217 * src/modest-account-mgr-helpers.h:
3218 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3221 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3223 * src/modest-account-mgr-helpers.h:
3224 * src/modest-account-mgr-helpers.c:
3225 (modest_account_mgr_get_unused_account_name),
3226 (modest_account_mgr_get_unused_account_display_name): Added these
3227 utility functions, to avoid code duplication.
3229 * src/maemo/easysetup/modest-easysetup-wizard.c:
3230 (create_page_account_details), (create_account):
3231 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3232 (on_combo_security_changed),
3233 (modest_connection_specific_smtp_edit_window_init),
3234 (modest_connection_specific_smtp_edit_window_save_settings):
3235 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3236 * src/maemo/modest-connection-specific-smtp-window.c:
3237 (modest_connection_specific_smtp_window_finalize),
3238 (modest_connection_specific_smtp_window_fill_with_connections),
3239 (on_button_edit), (modest_connection_specific_smtp_window_init):
3240 * src/maemo/modest-connection-specific-smtp-window.h:
3241 Implementing saving of connection-specific server accounts.
3243 But I need to refactor this so we can save the data for each
3244 possible connection-specific account and only actually create the server accounts
3245 when the easysetup finished, or the OK button is pressed on the account settings
3248 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3250 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3251 (on_combo_security_changed):
3252 (modest_connection_specific_smtp_edit_window_init):
3253 Auto-fill the port number as in the account settings.
3255 (modest_connection_specific_smtp_edit_window_set_connection):
3256 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3257 * src/maemo/modest-connection-specific-smtp-window.c:
3258 (fill_with_connections), (on_button_edit),
3259 (modest_connection_specific_smtp_window_init):
3260 Turn the edit window into a dialog to simplify the code, and
3261 set a WM hint as in a GtkDialog, because only a popup can be on top of
3262 another window in Maemo, and popups usually have no WM decoration.
3264 * src/modest-defs.h:
3265 * src/modest-account-mgr-helpers.c:
3266 (modest_account_mgr_set_connection_specific_smtp),
3267 (modest_account_mgr_remove_connection_specific_smtp),
3268 (modest_account_mgr_get_connection_specific_smtp):
3269 * src/modest-account-mgr-helpers.h: Some functions to write the
3270 connection-specific SMTP server information. Not yet used.
3273 * src/widgets/modest-folder-view.c: (text_cell_data):
3274 Fix a warning about an uninitialized variable.
3275 (on_configuration_key_changed): Put an #ifdef around the use
3276 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3278 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3280 * src/maemo/modest-account-settings-dialog.h:
3281 * src/maemo/modest-account-settings-dialog.c:
3282 Added connect_for_modified() utility function to mark the new modified boolean.
3284 (create_page_account_details), (create_page_user_details),
3285 (create_page_incoming), (create_page_outgoing), (on_response),
3286 (modest_account_settings_dialog_init),
3287 (modest_account_settings_dialog_set_account_name):
3288 Only warn about unsaved changes when there are actually unsaved changes.
3290 * src/modest-account-mgr-helpers.c:
3291 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3292 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3293 to get the data from there in future.
3295 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3297 * src/modest-defs.h:
3299 * src/modest-account-mgr-helpers.h:
3300 * src/modest-account-mgr-helpers.c:
3301 Store the security account setting in a single conf key instead of using
3302 the options list, so that the list is left for just the to-be-removed camel hack,
3303 and because gconf_client_set_list() is failing for some reason.
3305 * src/modest-account-mgr.c:
3306 (modest_account_mgr_add_server_account):
3307 * src/maemo/modest-account-settings-dialog.c:
3308 (modest_account_settings_dialog_set_account_name),
3309 (save_configuration): Use the renamed functions.
3312 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3314 * src/widgets/Makefile.am:
3315 * src/widgets/modest-limit-retrieve-combo-box.c:
3316 * src/widgets/modest-limit-retrieve-combo-box.h:
3317 * src/widgets/modest-retrieve-combo-box.c:
3318 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3319 the account settings dialog.
3321 * src/modest-defs.h:
3322 * src/modest-account-mgr-helpers.h:
3323 * src/modest-account-mgr-helpers.c:
3324 (modest_server_account_get_option_secure_auth),
3325 (modest_server_account_set_option_secure_auth):
3326 * src/modest-account-mgr.c:
3327 (modest_account_mgr_add_server_account):
3328 Use the existing AUTH_MECH conf key for the secure-auth setting,
3329 instead of putting it in the list options, because this was actually used already.
3331 * src/maemo/modest-account-settings-dialog.c:
3332 (create_page_account_details),
3333 (modest_account_settings_dialog_set_account_name),
3334 (save_configuration):
3335 * src/maemo/modest-account-settings-dialog.h:
3336 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3337 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3339 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3341 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3342 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3343 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3345 * src/modest-defs.h:
3346 * src/maemo/modest-account-settings-dialog.c:
3347 (create_page_incoming), (on_combo_outgoing_security_changed),
3348 (on_combo_incoming_security_changed), (create_page_outgoing),
3349 (modest_account_settings_dialog_set_account_name),
3350 (save_configuration): Load/Save the port number, and change it when the
3351 security combo changes, to suitable defaults.
3353 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3355 * src/modest-account-mgr.c:
3356 (modest_account_mgr_add_server_account): Set the security and secure-auth
3357 options, and add a comment saying that the other camel-specific options should be
3360 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3362 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3364 * src/modest-tny-account-store.c: (account_list_free),
3365 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3366 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3369 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3371 * src/modest-protocol-info.c:
3372 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3373 is required by our UI spec. Maybe something in our implementation will use this eventually.
3374 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3375 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3376 instead of the previous 0 placeholder.
3378 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3379 secure-auth settings.
3380 * src/modest-account-mgr-helpers.h:
3381 * src/modest-account-mgr-helpers.c:
3382 (modest_server_account_data_get_option_secure_auth),
3383 (modest_server_account_set_option_secure_auth),
3384 (modest_server_account_data_get_option_security),
3385 (modest_server_account_set_option_security): Added this API for getting and setting the security
3386 and secure-auth settings.
3388 * src/maemo/modest-account-settings-dialog.h:
3389 * src/maemo/modest-account-settings-dialog.c:
3390 (modest_account_settings_dialog_finalize), (check_data),
3391 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3392 about changing titles.
3393 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3394 (save_configuration): Save the security and secure-auth settings.
3396 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3397 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3399 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3401 * src/modest-defs.h:
3402 * src/modest-account-mgr.c:
3403 (modest_account_mgr_add_server_account):
3404 Added and used defines for the options key and value pair strings,
3405 that are used so far, though they do not seem to correspond to anything in our
3406 UI specs or ModestProtocol enum.
3408 * src/modest-account-mgr-helpers.h:
3409 * src/modest-account-mgr-helpers.c:
3410 (compare_option_strings_for_name),
3411 (modest_server_account_data_get_option_value),
3412 (modest_server_account_data_get_option_bool),
3413 (modest_account_mgr_get_server_account_option):
3414 Added helper functions for parsing the options GSList.
3416 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3418 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3419 display name is based on the supplied account name.
3420 * src/modest-account-mgr.c:
3421 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3422 with an inefficient, but good-enough, implementation.
3424 * src/maemo/easysetup/modest-easysetup-wizard.c:
3425 (create_page_account_details), (on_before_next), (create_account):
3426 Check for existing display names rather than (non-user-visible) account names, and just
3427 create and set a unique account name at the end.
3429 * src/maemo/modest-account-settings-dialog.c:
3430 (modest_account_settings_dialog_init),
3431 (modest_account_settings_dialog_set_account_name),
3432 (create_page_incoming): Show the display name, instead of the account name.
3433 (on_response): Do some (not all) extra checks, as in the UI spec.
3434 (save_configuration): Save the display name if it was changed.
3436 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3438 * po/en_GB.po: Added needed logical ID and translation.
3439 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3440 (init_view): Made the is-default column clicking work.
3442 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3445 * src/maemo/easysetup/Makefile.am:
3446 * src/maemo/easysetup/modest-easysetup-wizard.c:
3447 (modest_easysetup_wizard_dialog_init):
3448 * src/maemo/easysetup/provider-data-test.keyfile:
3449 * src/maemo/easysetup/provider-data.keyfile:
3450 Moved the provider data file to the new modest-providers-data package and used it from there.
3452 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3454 * src/modest-local-folder-info.c:
3455 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3456 N_() was already used on the static strings, but this just marks it for translation without
3457 using the translation.
3459 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3461 * src/maemo/modest-account-settings-dialog.c:
3462 (create_page_incoming),
3463 (modest_account_settings_dialog_set_account_name):
3464 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3465 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3466 I will do this if nobody else gets there first.
3468 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3470 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3471 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3472 save the security stuff.
3474 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3476 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3477 Set the email address and user fullname, which I now see must be
3480 * src/maemo/modest-account-settings-dialog.h:
3481 * src/maemo/modest-account-settings-dialog.c:
3483 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3484 leave-on-server and authentication.
3485 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3488 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3491 * src/maemo/modest-account-settings-dialog.c:
3492 * src/maemo/modest-account-settings-dialog.h:
3493 Most (but not all) of the widgets are now present as specified by the UI spec.
3494 No changes are yet saved, and some details are not properly shown yet.
3496 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3498 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3500 * src/maemo/Makefile.am:
3501 * src/maemo/modest-account-settings-dialog.c:
3502 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3503 an existing account. Doesn't do much yet.
3505 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3506 Open the accounts settings dialog when Edit is clicked.
3508 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3510 * src/maemo/easysetup/Makefile.am:
3511 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3513 * src/maemo/easysetup/modest-easysetup-wizard.c:
3514 (modest_easysetup_wizard_dialog_init):
3515 Try to get the source directory from the build system,
3516 instead of hard-coding "./" into the source code, when opening our local
3517 copies of the configuration files.
3518 But this still fails when opening the wizard from the Accounts window,
3519 maybe because the working directory seems to change at runtime.
3520 So the wizard will fail the second time unless you copy the files into their
3521 proper locations - see the stdout warnings for the paths.
3523 (create_page_account_details),(on_before_next):
3524 Check for existing non-server accounts instead of server accounts,
3525 so the default account name is useful again, and to prevent trying to
3528 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3529 Show the wizard when New is clicked.
3531 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3532 (init_view): Show the column headers, and show the columns that are
3533 specified in the UI specs. However, something in Maemo's GTK+ prevents
3534 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3535 change the default account. This is despite unsetting the special properties.
3537 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3539 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3540 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3541 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3542 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3543 to make that clearer.
3544 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3546 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3548 * src/maemo/modest-account-view-window.c:
3549 (modest_account_view_window_init),
3550 (modest_account_view_window_new):
3551 Use the same buttons as specified in the
3552 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3553 the existing widgets, which never had a chance of working.
3554 Put the ModestAccountView treeview in a scrolled window.
3555 Do not repeat the initialization in both _init() and _new().
3557 * src/widgets/modest-account-view.c: (update_account_view):
3558 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3559 this widget and window shows no accounts.
3561 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3563 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3565 * src/maemo/easysetup/modest-easysetup-wizard.c:
3566 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3567 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3568 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3571 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3572 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3573 accounts exist yet, as in the UI spec.
3575 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3577 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3579 * src/maemo/Makefile.am:
3580 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3581 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3582 New window for editing connection-specific smtp details.
3583 Not fully implemented.
3585 * src/maemo/modest-connection-specific-smtp-window.c:
3586 (modest_connection_specific_smtp_window_finalize) :
3587 unref the tree model.
3588 (on_button_edit): Show the edit window.
3590 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3592 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3595 * src/maemo/Makefile.am:
3596 * src/maemo/modest-connection-specific-smtp-window.c:
3597 * src/maemo/modest-connection-specific-smtp-window.h:
3598 New window for showing the list of connections, for connection-specific
3599 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3600 * src/maemo/easysetup/modest-easysetup-wizard.c:
3601 (create_page_custom_outgoing): Show the new window when the button is clicked.
3603 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3605 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3606 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3607 * src/maemo/modest-msg-edit-window.c:
3608 (modest_msg_edit_window_insert_image):
3609 * src/modest-conf.c: (modest_conf_key_escape):
3610 * src/modest-mail-operation.c:
3611 (modest_mail_operation_send_new_mail):
3612 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3613 (modest_ui_actions_on_new_account):
3614 * src/widgets/modest-attachment-view.c: (update_filename_request):
3615 * src/widgets/modest-mail-header-view.c:
3616 Corrected warnings that were breaking the build, by commenting out unused variables,
3617 and a function, and by including a header.
3619 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3621 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3622 so we can #ifdef around platform-specific code when necessary.
3623 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3624 to allow this to build for the GNOME platform too.
3626 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3628 * src/maemo/easysetup/modest-easysetup-wizard.c:
3629 Added util_increment_name() and used it in create_page_account_details()
3630 to make sure that the default account name is always a new name.
3632 (modest_easysetup_wizard_dialog_init),
3633 (set_default_custom_servernames): Some minor memory management fixes.
3635 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3639 * src/modest-runtime.c: (init_i18n): Restored the translation
3640 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3641 are defined in config.h, and the translations are installed.
3643 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3644 is defined for translation.
3646 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3648 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3650 * src/maemo/easysetup/modest-easysetup-wizard.c:
3651 (modest_easysetup_wizard_dialog_init):
3652 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3653 Use realistic paths (though they should use $prefix generically) to the
3654 mcc_mapping and provider-data.keyfile files which might work when they
3655 are installed by the future version of the operator-wizard package,
3656 and then fallback to paths in our source code, with an explanatory
3659 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3663 * src/maemo/Makefile.am:
3664 * src/maemo/easysetup/: Added files from the previously-exernal
3665 osso-modest-easysetup.
3666 * src/maemo/modest-main-window-ui.h:
3667 * src/modest-ui-actions.c:
3668 * src/modest-ui-actions.h:
3669 Added modest_ui_actions_on_new_account() as a signal handler for the
3670 New Account menu item. It shows the easysetup wizard.
3671 * po/en_GB.po: Added additional needed logical IDs and translations.