1 2007-06-29 Murray Cumming <murrayc@murrayc.com
3 * src/modest-tny-account.c:
4 (modest_tny_account_new_from_server_account):
5 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
6 now uses to request a connection when it needs one, and which it uses
7 to tell us that something is wrong with the connection, so we can force
8 the accounts offline to prevent further problems.
11 * src/modest-init.c: (init_default_settings):
12 * src/modest-mail-operation.c:
13 (modest_mail_operation_update_account):
14 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
15 This should not be necessary anymore. Do not set the conf key that
16 determined this (it was always TRUE and not set anywhere else).
18 * src/modest-ui-actions.h: Remove unused and unimplemented
19 modest_ui_actions_on_online_toggle_toggled().
21 2007-06-29 Murray Cumming <murrayc@murrayc.com
23 * src/maemo/modest-main-window.c: (connect_signals):
24 Don't connect to delete_event twice. Maybe this was harmless.
26 2007-06-29 Murray Cumming <murrayc@murrayc.com
28 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
29 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
30 Debug output to give some more clue when a folder move is not allowed.
32 2007-06-28 Murray Cumming <murrayc@murrayc.com
34 * src/modest-tny-account.c: (on_modest_file_system_info),
35 (modest_tny_account_get_mmc_account_name):
36 Always call the callback, without checking whether the name has changed.
37 * src/widgets/modest-folder-view.c: (strings_are_equal),
38 (on_model_foreach_set_name), (on_get_mmc_account_name),
39 (text_cell_data): Compare the name here, and use the name from
40 the account rather than from the
41 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
42 if the name was changed after the account was added to the model.
43 That's a tinymail bug but not one that I want to fix now.
45 This finally fixes projects.maemo.org bug NB#59301.
47 2007-06-27 Armin Burgmeier <armin@openismus.com>
49 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
52 2007-06-27 Murray Cumming <murrayc@murrayc.com
54 * src/modest-tny-account.h:
55 * src/modest-tny-account.c:
56 Added modest_tny_account_get_mmc_account_name(), to set the memory
57 card name asynchronously for the given account and then notify.
58 (modest_tny_account_new_for_local_folders): Use this new function instead
59 of using hildon_file_system_info_async_new() directly.
61 * src/widgets/modest-folder-view.c: (text_cell_data):
62 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
63 gtk_tree_model_row_changed() when it is available.
65 This should fix projects.maemo.org bug NB#59301.
67 2007-06-27 Murray Cumming <murrayc@murrayc.com
69 * src/modest-mail-operation.c: (update_account_thread),
70 (get_msgs_full_thread): Fix typo failures in the revert
73 2007-06-27 Murray Cumming <murrayc@murrayc.com
75 * src/maemo/modest-maemo-global-settings-dialog.c:
76 (idle_select_default_focus):
77 * src/modest-mail-operation.c: (idle_notify_progress),
78 (idle_notify_progress_once), (set_last_updated_idle),
79 (update_account_thread), (get_msgs_full_thread):
80 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
81 * src/widgets/modest-header-view.c:
82 (idle_notify_headers_count_changed_destroy),
83 (idle_notify_headers_count_changed):
84 Reverted the additions of gdk_threads_enter/leave(), in case this
85 helps with a startup hang on the device.
87 2007-06-26 Armin Burgmeier <armin@openismus.com>
89 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
90 for supported secure authentication methods from server by
91 gtk_dialog_run(), saving CPU time and a potential race condition.
93 2007-06-26 Armin Burgmeier <armin@openismus.com>
95 * src/maemo/modest-maemo-utils.h:
96 * src/maemo/modest-maemo-utils.c: Added a
97 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
98 only error code to tell the calling code when the user canceled the
101 * src/maemo/modest-account-settings-dialog.h:
102 * src/maemo/modest-account-settings-dialog.c:
103 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
104 message if the retrieval of secure authentication methods was canceled
105 by the user. Perform the check before saving anything to configuration
106 to not end up with half-committed configuration changes, do not show
107 a "Saving to configuration failed" note when authentication methods
108 could not be retrieved.
110 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
113 2007-06-26 Murray Cumming <murrayc@murrayc.com>
115 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
116 Only return the first level of folders under accounts, because the
117 osso-global-search UI spec doesn't want the rest.
118 This fixed projects.maemo.org bug NB#61811.
120 2007-06-26 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-tny-account-store.c:
123 * src/modest-tny-account-store.h:
124 Added modest_tny_account_is_memory_card_account().
125 * src/maemo/modest-main-window.c: (create_details_widget):
126 Show the same information items for the memory card as we show for the
127 local-folders, to fix projects.maemo.org bug NB#59307.
129 2007-06-26 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-tny-account-store.c: (get_password):
132 Added some checks for NULL to maybe prevent crashes, though I think
133 it was Philip's last commit that actually prevented the crash here
134 when creating a first new account.
135 But the new account is still not usable (no messages are shown)
136 until a restart of the application.
138 2007-06-26 Murray Cumming <murrayc@murrayc.com>
140 * src/maemo/modest-maemo-global-settings-dialog.c:
141 (idle_select_default_focus):
142 * src/modest-mail-operation.c: (idle_notify_progress),
143 (idle_notify_progress_once), (idle_notify_update_account_queue),
144 (set_last_updated_idle), (update_account_thread),
145 (notify_get_msgs_full), (get_msgs_full_destroyer),
146 (get_msgs_full_thread):
147 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
148 * src/widgets/modest-header-view.c:
149 (idle_notify_headers_count_changed_destroy),
150 (idle_notify_headers_count_changed):
151 Use gdk_threads_enter() and gdk_threads_enter_leave() in
152 all idle handlers, because some other thread could be blocking
153 the GDK lock, so that it can do GUI stuff.
155 2007-06-26 Murray Cumming <murrayc@murrayc.com>
157 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
158 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
159 (on_idle_send_receive), (on_idle_open_default_inbox):
160 * src/maemo/modest-msg-edit-window.c:
161 (modest_msg_edit_window_attach_file_noninteractive):
162 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
163 to prevent a hang. I don't quite understand why these are necessary,
164 beause we should already be in the main loop. I guess something outside
165 of the main loop is taking the lock.
167 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
168 we are really using URIs, and use files that are more likely to exist.
170 2007-06-26 Murray Cumming <murrayc@murrayc.com>
172 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
173 necessary because configure.ac now defines different variables.
175 2007-06-26 Murray Cumming <murrayc@murrayc.com>
177 * libmodest-dbus-client/libmodest-dbus-client.c:
178 * libmodest-dbus-client/libmodest-dbus-client.h:
179 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
180 libmodest_dbus_client_compose_mail() is what things actually use.
182 * src/dbus_api/modest-dbus-api.h:
183 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
184 * tests/dbus_api/Makefile.am:
185 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
188 2007-06-26 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-init.c: (modest_init_local_folders):
191 For memory-card (or other non local-folders) maildir accounts,
192 always create an Archive folder, so that there is somewhere to put
193 messages. This should be less confusing, because the user does not need
194 to guess that the need to create a folder.
196 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
198 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
199 Fixed icon size by using (50, 50) which is the same as defined by
202 2007-06-25 Armin Burgmeier <armin@openismus.com>
204 * src/widgets/modest-window-mgr.c:
206 * configure.ac: Correctly recognize hildon-notify presence and fixed
207 the build without it being installed.
209 2007-06-25 Murray Cumming <murrayc@murrayc.com>
211 * libmodest-dbus-client/libmodest-dbus-client.c:
212 (libmodest_dbus_client_search): Fix the build. Sorry.
213 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
214 (reply_forward_cb): Initialize variables to fix the build.
216 * src/modest-tny-account-store.c:
217 (modest_tny_account_store_get_tny_account_by): Fix the account URI
218 comparison (a silly typo) so that email search results can be opened
219 when there are more than one account.
221 2007-06-25 Murray Cumming <murrayc@murrayc.com>
223 * libmodest-dbus-client/libmodest-dbus-client.c:
224 (libmodest_dbus_client_search),
225 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
226 instead of 1 second, because the search gets folders and messages from
227 the server, which can take a long time. When it times out,
228 osso-global-search will report no results.
230 We need to specify whether we should search only cached information
231 (maybe with a user preference), and the osso-email-search-plugin
232 API should really be improved to allow that option, and to allow results
233 to be delivered asynchronously in batches.
235 2007-06-25 Murray Cumming <murrayc@murrayc.com>
237 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
238 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
239 GTK_ICON_SIZE_DIALOG is probably the wrong size.
241 2007-06-25 Murray Cumming <murrayc@murrayc.com>
243 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
244 that is an empty string. D-Bus seems to give us these instead of NULL.
246 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
248 * src/dbus_api/modest-dbus-callbacks.c:
249 * src/maemo/easysetup/modest-easysetup-wizard.h:
250 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
251 * src/maemo/modest-connection-specific-smtp-edit-window.c:
252 (modest_connection_specific_smtp_edit_window_init):
253 * src/maemo/modest-maemo-global-settings-dialog.c:
255 * src/maemo/modest-maemo-utils.c:
256 (modest_maemo_utils_setup_images_filechooser):
257 * src/maemo/modest-main-window.c: (create_details_widget):
258 * src/maemo/modest-msg-edit-window.c:
259 (modest_msg_edit_window_attach_file_noninteractive),
260 (modest_msg_edit_window_color_button_change),
261 (modest_msg_edit_window_set_zoom):
262 * src/modest-mail-operation.c: (update_account_thread):
263 * src/modest-tny-account-store.c:
264 * src/modest-tny-account.c:
265 * src/widgets/modest-global-settings-dialog.c:
266 * src/widgets/modest-window.h:
270 2007-06-25 Murray Cumming <murrayc@murrayc.com>
272 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
273 * src/modest-search.c: (modest_search_folder),
274 (modest_search_all_accounts): Actually search only in the specified folder,
275 doing a simple match on the folder ID.
276 * src/modest-search.h: Added a folder field to the ModestSearch struct,
277 and added some documentation.
279 2007-06-22 Armin Burgmeier <armin@openismus.com>
281 * src/maemo/modest-maemo-utils.h:
282 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
283 modest_maemo_utils_get_supported_secure_authentication_methods.
285 * src/maemo/easysetup/modest-easysetup-wizard.c:
286 * src/maemo/modest-account-settings-dialog.c: Show correct error if
287 one occured, not just "Server does not support secure authentication".
289 2007-06-22 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-tny-account-store.c: (get_password):
292 Restored the call to tny_account_set_user() because Philip seems to have
293 stopped this from crashing (by not using the freed string). It still does
294 not work, but now we can test it.
296 2007-06-22 Murray Cumming <murrayc@murrayc.com>
298 * src/maemo/modest-msg-edit-window.c: (init_window):
299 Comment out use of an uninitialzed GtkScrolledWindow variable,
300 to fix the build and stop a crash. Yet again.
302 2007-06-22 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-tny-account-store.c: (get_password):
305 Remove the call to tny_account_set_user() because this actually crashes.
306 As mentioned in the last commit, it is known to not work anyway.
308 2007-06-22 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-tny-account-store.c: (get_password):
311 Use tny_account_set_username() to tell tinymail that the username might
312 have changed too. But tinymail ignores this: see projects.maemo.org
314 * src/modest-ui-actions.c:
315 (modest_ui_actions_on_password_requested): Remove the useless attempt to
316 reset the connection when changing the username, and improve the comments.
317 Save the changed username to gconf at least, so it is used when Modest is
320 2007-06-21 Murray Cumming <murrayc@murrayc.com>
322 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
323 Do not use a query, so that we get all folders, including for POP and
324 local-folders. They work as search criteria too.
325 This fixes projects.maemo.org bug NB#57740.
327 2007-06-21 Murray Cumming <murrayc@murrayc.com>
329 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
330 Comment out the use of hildon_notification_set_sound() because it is
331 not declared, to fix the build. Warnings are serious, people.
333 2007-06-21 Armin Burgmeier <armin@openismus.com>
335 * src/maemo/modest-maemo-utils.h:
336 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
337 modest_maemo_utils_get_supported_secure_authentication_methods()
338 to query authentication methods for a specific user. This should fix
339 projects.maemo.org bug NB#61369.
341 * src/maemo/easysetup/modest-easysetup-wizard.c:
342 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
345 2007-06-21 Murray Cumming <murrayc@murrayc.com>
347 * libmodest-dbus-client/libmodest-dbus-client.h:
348 * libmodest-dbus-client/libmodest-dbus-client.c:
349 (modest_dbus_message_iter_get_search_hit),
350 (libmodest_dbus_client_search):
351 Reorganised and commented this.
352 Removed modest_search_hit_free() from the public API because it
355 Added libmodest_dbus_client_get_folders() and
356 modest_folder_result_list_free().
358 * src/dbus_api/modest-dbus-api.h:
359 * src/dbus_api/modest-dbus-callbacks.c:
360 (modest_dbus_req_filter): Commented. Moved most code to
361 on_dbus_method_search() and added on_dbus_method_get_folders().
363 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
364 of the extra D-Bus handler.
366 * tests/dbus_api/Makefile.am:
367 * tests/dbus_api/test_get_folders.c: New test for
368 libmodest_dbus_client_get_folders(). This seems to return an empty list
369 at the moment. That could be the same error that causes the message list
370 to be empty sometimes.
371 This should help with projects.maemo.org bug NB#57740.
373 2007-06-21 Armin Burgmeier <armin@openismus.com>
375 * src/modest-mail-operation.c: Do not call
376 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
377 notify the operation's end after having set the status to CANCELED for
378 the operation queue to listen on. This fixes a deadlock when there
379 were mail operations in the queue during its finalization.
381 * src/modest-singletons.c: Reordered uninitialization of the account
382 manager to happen after the mail operation queue was uninitialized
383 because the mail operation's in the queue might still try to access
384 the account manager (see modest_mail_operation_notify_end()). This
385 fixes a potential crash when terminating the application.
387 2007-06-21 Murray Cumming <murrayc@murrayc.com>
389 * src/modest-search.c:
390 (search_mime_part_and_child_parts): Moved some code here so we
391 can search recursively in child folders.
392 (modest_search_folder): Search in the message as a mime part, instead
393 of just its child mime parts.
394 (read_chunk), (search_mime_part_ogs):
395 Check how many bytes were read, to prevent an endless loop.
396 Searching in message bodies now works. This finishes the fix for
397 projects.maemo.org bug NB#61007.
399 2007-06-20 Murray Cumming <murrayc@murrayc.com>
401 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
402 Add a g_warning when the item is not a folder.
404 * src/modest-ui-dimming-rules.c:
405 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
406 when selected item is not a folder (for instance, an account), because
407 the UI spec only talks about folders.
408 I am not sure what the UI spec wants, so this might not totally fix
409 projects.maemo.org bug NB#60794.
411 2007-06-20 Murray Cumming <murrayc@murrayc.com>
413 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
414 (load_from_file): Sort the list. The unsorted list would be more noticeable
415 in non-English locales.
417 * src/maemo/modest-msg-edit-window.c:
418 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
419 warning and fix the build.
421 * src/maemo/modest-progress-bar-widget.c:
422 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
423 avoid a g_warning, and probably to avoid a crash.
425 2007-06-20 Murray Cumming <murrayc@murrayc.com>
427 * src/modest-search.c: (modest_search_folder): Check for a GError
428 when calling tny_folder_get_headers(), to show that this is not the cause
431 2007-06-20 Murray Cumming <murrayc@murrayc.com>
433 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
434 Actually set the body query instead of the subject query.
436 * src/modest-search.c: (search_mime_part_ogs),
437 (search_mime_part_strcmp): Remove extra space from the text/* regex,
438 which would probably cause it to fail if we got this far.
440 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
441 to simplify the code.
442 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
443 be causing search-in-body to fail.
445 2007-06-20 Murray Cumming <murrayc@murrayc.com>
447 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
449 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
450 Better debug message when the folder cannot be found.
451 This should help with fixing projects.maemo.org bug #61287.
452 * src/modest-search.c: (add_hit): Do not leak the furl string.
454 2007-06-20 Murray Cumming <murrayc@murrayc.com>
456 * src/modest-ui-actions.c:
457 (modest_ui_actions_on_folder_selection_changed):
458 Do not special-case TNY_MERGE_FOLDER here, because
459 modest_tny_folder_get_account() already does that. This fixes
460 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
461 shown when the Outbox was selected).
463 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
465 * libmodest-dbus-client/libmodest-dbus-client.c:
466 (_dbus_iter_get_string_or_null): Initialize the string variable in
467 case this helps with Dirk's crash.
469 2007-06-19 Murray Cumming <murrayc@murrayc.com>
471 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
472 though it is not implemented yet (this function is maybe not even used),
473 to avoid breaking ABI in future.
474 * libmodest-dbus-client/libmodest-dbus-client.c:
475 (get_attachments_string): Moved some code into this generic function.
476 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
477 sends email. It is maybe not used.
478 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
479 (on_send_mail): Use attachments.
481 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
482 * src/maemo/modest-msg-edit-window.c:
483 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
484 a filename before using it, to fix projects.maemo.org bug NB#58233.
486 2007-06-19 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
489 Initialize the continue_download variable to fix the build, and probably
490 to fix randome behaviour.
492 2007-06-18 Armin Burgmeier <armin@openismus.com>
494 * src/modest-tny-send-queue.h:
495 * src/modest-tny-send-queue.c: Keep track of the status of messages in
496 the queue so we can later show it in the UI. Replaced
497 modest_tny_send_queue_msg_is_being_sent() by
498 modest_tny_send_queue_get_msg_status().
500 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
502 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
503 gpointer. This probably was not harmful, but just to be sure.
505 2007-06-18 Murray Cumming <murrayc@murrayc.com>
507 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
508 Fix the build, but leave the function broken on Bora, because
509 hildon_uri_action_get_service() does not exist.
510 osso_uri_action_get_service() does not exist either, it seems.
512 2007-06-18 Murray Cumming <murrayc@murrayc.com>
514 * src/modest-tny-account.c:
515 (modest_tny_account_new_from_server_account):
516 Uncommented the url debug output again, because it is useful for
517 debugging, as I said in the comment.
519 2007-06-18 Murray Cumming <murrayc@murrayc.com>
521 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
523 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
524 for Mameo Bora, to fix the build.
526 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
529 Fixed build with hildon < 0.99
531 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
532 Check if the selected account is busy instead of checking all accounts
534 * src/modest-account-mgr-priv.h:
535 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
536 (modest_account_mgr_init), (compare_account_name),
537 (modest_account_mgr_set_account_busy),
538 (modest_account_mgr_account_is_busy):
539 * src/modest-account-mgr.h:
540 Added busy information to the account manager. It possible to
541 set an account to busy or not busy now.
543 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
544 (modest_mail_operation_update_account),
545 (modest_mail_operation_notify_end):
546 Set the account to busy/not busy depending on the operation state.
548 * src/widgets/modest-account-view.c:
549 (modest_account_view_finalize), (get_last_updated_string),
550 (update_account_view), (on_account_busy_changed), (init_view):
551 Show string "Refreshing..." if the account is currently busy.
553 All this fixes projects.maemo.org bug NB#59711
555 2007-06-14 Armin Burgmeier <armin@openismus.com>
557 * src/widgets/modest-attachments-view.h:
558 * src/widgets/modest-attachments-view.c: Added
559 modest_attachments_view_has_attachments() and fixed coordinate
560 transformation in get_att_view_at_coords(). This fixes attachment
563 * src/widgets/modest-msg-view.c: Make use of
564 modest_attachments_view_has_attachments() to decide whether to show
565 attachments in the header.
567 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
569 * src/maemo/modest-connection-specific-smtp-edit-window.c:
570 (on_change), (on_combo_security_changed),
571 (modest_connection_specific_smtp_edit_window_init),
572 (modest_connection_specific_smtp_edit_window_set_connection),
573 (modest_connection_specific_smtp_edit_window_is_dirty):
574 * src/maemo/modest-connection-specific-smtp-edit-window.h:
575 * src/maemo/modest-connection-specific-smtp-window.c:
578 Show an comfirmation dialog for the smpt-edit-window if there are
579 unsaved changes and the user hits cancel.
580 (projects.maemo.org bug NB#60479)
582 2007-06-14 Armin Burgmeier <armin@openismus.com>
584 * src/maemo/easysetup/modest-easysetup-wizard.c:
585 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
586 address" info in banner instead of node, and select all the text as
587 per UI spec. This fixes projects.maemo.org bug NB#60550.
589 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
591 reviewed by: <delete if not using a buddy>
593 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
594 * src/modest-ui-actions.c: (folder_refreshed_cb):
596 2007-06-14 Murray Cumming <murrayc@murrayc.com>
598 * src/widgets/modest-folder-view.c: (filter_row):
599 Explictly filter out the per-account outbox accounts. I don't know why
600 these only sometimes show up, but now they should never show up in the UI.
601 This should fix projects.maemo.org bug NB#60160.
603 2007-06-14 Murray Cumming <murrayc@murrayc.com>
605 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
606 when the toolbar does not exist yet.
607 * src/modest-widget-memory.c: (save_settings_header_view):
608 Added g_warnings() to help us to discover when we are trying to set
609 an empty columns list in gconf.
611 2007-06-14 Murray Cumming <murrayc@murrayc.com>
615 Added modest_init_get_default_header_view_column_ids().
617 * src/modest-widget-memory.c: (restore_settings_header_view):
618 Use the new function to get defaults, if the gconf key is empty,
619 instead of not creating any columns. This seems to fix the
620 empty right-hand pane problems.
622 * src/widgets/modest-header-view.h: Improved documentation.
624 2007-06-13 Murray Cumming <murrayc@murrayc.com>
626 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
627 Revert the use of the display name as the account name, because this
628 is generally wrong and would break the code that follows.
630 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
632 * src/maemo/easysetup/modest-easysetup-wizard.c:
633 (check_for_supported_auth_methods), (on_before_next),
636 More correct fix for projects.maemo.org bug NB# 58991
637 Do not longer accept AUTH_PASSWORD as secure method and choose
638 correct method when creating the account.
640 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
642 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
643 Fixed projects.maemo.org bug NB# 58991
645 2007-06-13 Murray Cumming <murrayc@murrayc.com>
647 * src/modest-init.c: (modest_init_init_core),
648 (modest_init_local_folders): Fixed compilation errors.
650 2007-06-13 Murray Cumming <murrayc@murrayc.com>
652 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
653 Remove unnecessary lib/include, though it is good in principle when needed.
655 * src/modest-init.c: (modest_init_one_local_folder),
656 (modest_init_local_folders):
657 * src/modest-init.h: Initialize the .modest library for memory cards,
658 instead of just doing nothing for them. This should allow us to create
659 folders there, fixing projects.maemo.org bug NB#59297.
661 2007-06-13 Murray Cumming <murrayc@murrayc.com>
663 * libmodest-dbus-client/libmodest-dbus-client.c:
664 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
665 (libmodest_dbus_client_compose_mail),
666 (libmodest_dbus_client_open_message),
667 (libmodest_dbus_client_send_and_receive),
668 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
670 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
671 (on_idle_open_message), (modest_dbus_req_handler),
672 (search_result_to_message), (modest_dbus_req_filter):
673 * src/modest-search.c: (add_hit), (modest_search_folder),
674 (modest_search_all_accounts): Improved debug messages.
676 * tests/dbus_api/test_open_message.c: (main): Improved comments.
678 * src/modest-tny-account-store.c:
679 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
682 2007-06-13 Murray Cumming <murrayc@murrayc.com>
685 2007-06-12 Murray Cumming <murrayc@murrayc.com>
687 * src/modest-tny-account-store.c: (get_server_accounts):
688 Call modest_tny_local_folders_account_add_merged_outbox_folders()
689 even when there are no accounts, so that the Outbox folder is always
690 visible. This fixes projects.maemo.org bug NB#60158.
692 2007-06-12 Murray Cumming <murrayc@murrayc.com>
694 * src/maemo/modest-main-window.c: (create_details_widget):
695 Use the mcen_va_never logical ID.
697 2007-06-12 Murray Cumming <murrayc@murrayc.com>
699 * src/dbus_api/modest-dbus-api.h:
700 * src/dbus_api/modest-dbus-callbacks.c:
701 (on_idle_open_default_inbox), (on_open_default_inbox),
702 (modest_dbus_req_handler):
703 Added a new OpenDefaultInbox method.
705 * libmodest-dbus-client/libmodest-dbus-client.h:
706 * libmodest-dbus-client/libmodest-dbus-client.c:
707 Added libmodest_dbus_client_open_default_inbox() to call the new
708 dbus method. This should be useful to projects.maemo.org bug NB#57214,
709 though it should maybe be used by a new osso-email-interface function.
711 * tests/dbus_api/Makefile.am:
712 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
715 2007-06-12 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
718 NULL, so that the signals get all the keys. This should not actually
719 change any behaviour because we currently update everything when anything
722 2007-06-12 Murray Cumming <murrayc@murrayc.com>
724 * src/widgets/modest-folder-view.c: (text_cell_data),
725 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
726 (find_inbox_iter): If tinymail tells us that the folder is
727 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
728 This causes the inbox to be selected at startup, fixing part of
729 projects.maemo.org bug NB#56305.
731 * src/modest-ui-dimming-rules.c:
732 (modest_ui_dimming_rules_on_tools_smtp_servers):
733 * src/modest-ui-dimming-rules.h: Added a callback function to dim
734 the SMTP servers menu item.
735 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
736 that the SMTP Servers menu item is dimmed when there are no accounts,
737 as a future version of the UI spec will require. This fixes
738 projects.maemo.org bug NB#56305.
740 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
742 * src/maemo/modest-maemo-utils.c:
743 (modest_maemo_utils_get_supported_secure_authentication_methods):
744 Added label to dialog instead of unreadable title
746 * src/maemo/modest-main-window.c: (sync_accounts_cb),
747 (modest_main_window_new):
748 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
751 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
752 * src/modest-account-mgr.h:
753 Added method to avoid code duplication
755 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
756 (modest_ui_actions_on_send_receive):
757 Use modest_account_mgr_has_accounts
759 2007-06-11 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/easysetup/modest-presets.c:
762 (modest_presets_get_info_server_security): Do not report secure auth
764 * src/modest-protocol-info.c: Use the defines for the gconf key names
765 for secure authentication. This was not working because we were writing
766 Password and reading password, and the check was case sensitive.
767 With this, gmail now works for receiving and sending when created via
770 2007-06-11 Murray Cumming <murrayc@murrayc.com>
772 * src/maemo/easysetup/modest-presets.c:
773 (modest_presets_get_info_server_security): Correct the key name for
774 SecureSmtp, because it seems to be case-sensitive.
775 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
776 Do not try to get the 0th notebook page if there are 0 pages, to
779 2007-06-11 Murray Cumming <murrayc@murrayc.com>
781 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
782 Prevent use of the new notification feature for now, because it currently
783 shows one dialog for each new email, which is annoying.
785 2007-06-11 Murray Cumming <murrayc@murrayc.com>
787 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
788 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
789 when no country was selected, so that we show the global ones.
790 * src/maemo/easysetup/modest-presets.c:
791 (modest_presets_get_providers): Return only the global providers, not
792 all providers when mmc=0 was requested.
794 2007-06-11 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
797 (easysetup_provider_combo_box_fill): Remove debug code that showed the
798 provider ID in the combo.
800 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
801 Do not show the page numbers, because it would be confusing when we add
802 the 2 extra pages for the custom setup, when the user chooses the "Other"
803 provider. This fixes projects.maemo.org bug NB#59028
805 * src/modest-init.c: (modest_init_init_core),
806 (modest_init_local_folders):
808 * src/modest-tny-account.c:
809 (modest_tny_account_new_for_local_folders): Do not create default folders
810 for the memory card. This should fix projects.maemo.org bug NB#59328.
812 2007-06-11 Murray Cumming <murrayc@murrayc.com>
814 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
815 Free the changed_conf_keys string items. They are already freed in the
816 idle handler if that runs first.
818 2007-06-11 Murray Cumming <murrayc@murrayc.com>
820 * src/modest-ui-actions.c:
821 (modest_ui_actions_on_password_requested): Check that the server name
822 is not NULL, because I just saw a password dialog with (null) as the
825 * src/modest-tny-folder.[h|c]: Added
826 modest_tny_folder_is_memory_card_folder().
827 * src/modest-ui-dimming-rules.c:
828 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
829 menu item for memory cards, as per the UI spec (section 7.4). This should
830 fix projects.maemo.org bug NB#59297.
832 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
834 * src/maemo/modest-main-window.c: (sync_accounts_cb):
835 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
836 is another problem with the code, see Murray's comment at line 772)
838 2007-06-08 Murray Cumming <murrayc@murrayc.com>
840 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
841 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
842 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
843 (load_from_file), (easysetup_country_combo_box_init),
844 (easysetup_country_combo_box_get_active_country_ids),
845 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
846 instead of just one ID, to avoid duplicate country names in the UI.
848 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
849 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
850 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
851 a single ID, avoiding duplicate providers.
852 * src/maemo/easysetup/modest-easysetup-wizard.c:
853 (on_combo_account_country): Adapt to use a list.
855 2007-06-08 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
858 keys changed in the last X seconds.
860 * src/modest-account-mgr.h:
861 * src/modest-account-mgr.c: (on_timeout_notify_changes),
862 (on_key_change), (modest_account_mgr_class_init),
863 (modest_account_mgr_init), (modest_account_mgr_finalize):
864 As the keys are changed, save them in a GSList* and signal that GSList*
865 further every X seconds, to batch changes, to allow us to do just one
866 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
867 bug NB#56941 and other (UI-blocking) delays when changing account settings.
869 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
870 changed signal signature.
872 * src/modest-conf.c: (modest_conf_set_list),
873 (modest_conf_on_change): Reenable notification.
875 (modest_conf_maemo_fake_on_change): Comment out the hack that
876 notified immediately instead of asynchronously.
878 * src/widgets/modest-account-view.h:
879 * src/widgets/modest-account-view.c:
880 (update_account_view): Select the previously-selected account ID,
881 if possible. This fixes projects.maemo.org bug NB#56933.
883 (on_account_changed), (on_account_removed),
884 (modest_account_view_select_account):
886 Remove the block/unblock functions
887 because they were not useful.
889 * src/maemo/modest-account-view-window.c:
890 (on_delete_button_clicked), (on_edit_button_clicked),
891 (on_new_button_clicked): Remove the use of the non-working block/unblock.
893 2007-06-08 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
896 Improve the error dialog to show Incorrect Account Settings, which seems
897 clearer, and say that the internal error message (to be removed from the
898 dialog later) is often misleading.
899 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
901 * src/modest-tny-account.c:
902 (modest_tny_account_new_from_server_account): Uncomment the printf of the
903 URL because this is so useful for debugging on the device.
905 * src/widgets/modest-serversecurity-combo-box.c:
906 (modest_serversecurity_combo_box_fill): Correct a logical ID.
908 2007-06-08 Murray Cumming <murrayc@murrayc.com>
910 * src/modest-mail-operation.c:
911 (modest_mail_operation_send_new_mail):
912 Added a comment about a nasty but apparently harmless message. Details
913 added to the wiki g_warnings() page.
915 2007-06-08 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
918 (modest_tny_send_queue_class_init):
919 Do not use the priv struct because it is empty, to avoid g_warnings
920 about a non-existant priv struct.
922 * src/modest-tny-account-store.c:
923 (modest_tny_account_store_get_server_account),
924 (modest_tny_account_store_get_transport_account_for_open_connection
925 ): Do not try to get transport server accounts for local folders,
926 because they don't have any. This avoids a g_warning().
928 * src/maemo/modest-main-window.c:
929 (modest_main_window_notify_send_receive_initied),
930 (on_configuration_key_changed):
931 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
933 * src/modest-mail-operation.c:
934 (modest_mail_operation_update_account):
935 * src/modest-tny-account-store.h:
936 * src/modest-tny-account.c:
937 (modest_tny_account_get_special_folder),
938 (modest_tny_account_new_for_local_folders),
939 (modest_tny_account_new_for_per_account_local_outbox_folder):
940 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
941 * src/modest-tny-local-folders-account.c:
942 (add_account_folders_to_merged_folder):
943 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
944 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
945 (modest_ui_actions_on_send):
946 * src/widgets/modest-folder-view.c: (update_model):
947 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
948 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
949 modest_tny_account_store_get_tny_account_by_account() to
950 modest_tny_account_store_get_server_account() to make the code clearer.
952 2007-06-07 Marcus Bauer <marcusb@openismus.com>
954 * src/dbus_api/modest-dbus-api.h:
955 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
956 * src/maemo/modest-msg-edit-window.c:
957 (modest_msg_edit_window_attach_file_noninteractive):
958 added g_warning in case the file to be attached does not exist
959 * tests/dbus_api/test_compose_mail.c: (main):
960 removed obsolete comment, added generic files as test case
962 2007-06-07 Murray Cumming <murrayc@murrayc.com>
964 * src/modest-tny-account-store.c: (get_server_accounts):
965 Create the local folders account only once, not once for each outbox, and
966 not only when there are some outboxes.
968 2007-06-07 Murray Cumming <murrayc@murrayc.com>
970 * src/widgets/modest-folder-view.c: (update_model): Comment out some
971 code that is causing a crash at startup. Sergio says that he is fixing this.
973 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
975 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
976 * src/maemo/modest-account-settings-dialog.c:
977 (create_page_outgoing),
978 (modest_account_settings_dialog_set_account_name),
979 (save_configuration):
980 - Fixed handling of the "Use secure authentication" toggle to comply with
981 the ui specification. See also projects.maemo.org bug NB#58400
983 - Restore the Secure connection setting combo correctly when loading
986 * src/maemo/modest-maemo-utils.c:
987 (on_camel_account_get_supported_secure_authentication),
988 (modest_maemo_utils_get_supported_secure_authentication_methods):
989 Fixed a crasher if operation is canceled
991 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
992 (modest_protocol_info_auth_is_secure):
993 * src/modest-protocol-info.h:
995 Added two new methods to determine if a protocol/auth method is secure/encrypted in
996 the sense of the "Use secure authentication" toggle.
998 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1000 * src/modest-tny-account-store.h:
1001 * src/modest-tny-account-store.c:
1002 Added modest_tny_account_store_get_local_folders_account().
1004 * src/modest-tny-folder.h:
1005 * src/modest-tny-folder.c:
1006 (modest_tny_folder_get_account):
1007 Added this replacement for tny_folder_get_account() which returns
1008 the local-folders account for TnyMergeFolders, to avoid the
1009 warning about the unimplemented get_account_func() vfunc().
1011 (modest_tny_folder_get_rules),
1012 * src/modest-ui-actions.c:
1013 (modest_ui_actions_on_folder_selection_changed):
1014 * src/modest-mail-operation.c:
1015 (modest_mail_operation_remove_folder),
1016 (modest_mail_operation_xfer_folder),
1017 (modest_mail_operation_rename_folder),
1018 (modest_mail_operation_get_msg),
1019 (modest_mail_operation_get_msgs_full),
1020 (modest_mail_operation_remove_msg),
1021 (modest_mail_operation_xfer_msgs),
1022 (modest_mail_operation_refresh_folder):
1023 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1025 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1027 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1028 (modest_server_account_set_security):
1029 * src/modest-defs.h: Add comments explaining that our
1030 UI spec means TLS when it says Normal, so these do not look like errors.
1032 * src/modest-tny-account.c:
1033 (modest_tny_account_new_from_server_account): Use the new tinymail
1034 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1035 for TLS. This should fix projects.maemo.org bug NB#58460.
1037 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1039 * src/maemo/easysetup/modest-easysetup-wizard.c:
1040 (create_account): Correct the position of the gconf sanity check warning.
1041 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1042 of using the g_idle_add() hack, because this does not seem to be necessary
1043 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1044 caused by something other than maemo's gconf.
1045 This fixes projects.maemo.org bug #59022.
1047 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1049 * src/modest-account-mgr-helpers.c:
1050 (modest_account_mgr_get_default_account): Do not check that the account
1051 exists if there is no default account (NULL), to fix a runtime warning.
1053 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1055 * src/widgets/modest-folder-view.c: (update_model):
1056 Do not unref the treemodel before we have finished with it.
1057 This prevents a valgrind warning and an occasional crash at startup.
1059 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1061 * libmodest-dbus-client/libmodest-dbus-client.h:
1062 added libmodest_dbus_client_compose_mail()
1063 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1065 added functions needed for SendAsMail() functionality
1066 * src/maemo/modest-msg-edit-window.c:
1067 (modest_msg_edit_window_attach_file_noninteractive):
1068 non interactively attaching files to message edit window
1069 * src/widgets/modest-msg-edit-window.h:
1070 * tests/dbus_api/Makefile.am:
1071 added test_compose_mail.c
1072 * tests/dbus_api/test_compose_mail.c: (main):
1074 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1076 * src/modest-account-view.c:
1077 Fixed bug projects.maemo.org bug NB#59307
1079 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1081 * src/maemo/easysetup/modest-easysetup-wizard.c:
1082 (get_serverport_incoming), (on_before_next), (create_account):
1083 * src/maemo/modest-account-settings-dialog.c:
1084 (modest_account_settings_dialog_set_account_name):
1085 * src/maemo/modest-maemo-utils.c:
1086 (on_camel_account_get_supported_secure_authentication_status),
1087 (on_camel_account_get_supported_secure_authentication),
1088 (on_secure_auth_cancel),
1089 (modest_maemo_utils_get_supported_secure_authentication_methods):
1091 Implemented security authentication for settings and easysetup.
1093 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/modest-main-window.c: (create_details_widget):
1096 Show the total size for memory card accounts too, instead of showing
1097 the name again. Fixes bug projects.maemo.org bug NB#59307.
1099 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1102 * src/modest-tny-simple-folder-store.c:
1103 * src/modest-tny-simple-folder-store.h: Removed.
1105 * src/modest-tny-local-folders-account.h
1106 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1107 for the local-folders maildir, with an extra TnyMergedFolder containing
1108 the folders of the per-account outbox store accounts.
1109 * src/modest-tny-account-store.c: (get_server_accounts):
1110 Add the outboxes to the special local folders account after creating it.
1112 * src/modest-tny-account.c:
1113 (modest_tny_account_new_for_local_folders): Create the derived
1114 account when creating the main local-folders account.
1116 * src/maemo/modest-main-window.c: (create_details_widget),
1117 (modest_main_window_set_contents_style):
1118 Adapted to the use of the derived account instead of the folder store.
1120 * src/modest-ui-actions.c:
1121 (modest_ui_actions_on_folder_selection_changed):
1122 * src/modest-ui-dimming-rules.c:
1123 (modest_ui_dimming_rules_on_new_folder):
1124 * src/widgets/modest-folder-view.c: (text_cell_data),
1125 (icon_cell_data), (filter_row), (update_model),
1126 (get_cmp_rows_type_pos):
1129 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1130 Do not get the priv struct, because no priv struct has been set,
1131 to avoid a runtime warning.
1133 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1134 #ifelse with #else, to fix a warning, to fix the build.
1137 2007-06-05 Christian Kellner <ckellner@openismus.com>
1139 * libmodest-dbus-client/libmodest-dbus-client.c:
1140 Fix small typo in doc (why do you always see them
1141 AFTER committing stuff?)
1144 2007-06-05 Christian Kellner <ckellner@openismus.com>
1146 * libmodest-dbus-client/libmodest-dbus-client.c:
1147 (libmodest_dbus_client_search):
1148 Initialize hit list with NULL. Also set folder list
1149 to "" if NULL was supplied.
1152 2007-06-03 Christian Kellner <ckellner@openismus.com>
1154 * libmodest-dbus-client/libmodest-dbus-client.c:
1155 (modest_search_hit_list_free):
1156 Make it save to call it with NULL.
1158 * src/dbus_api/modest-dbus-callbacks.c:
1159 * src/modest-search.c:
1160 Return full ModestSearchHits as the search result list not TnyHeader
1161 since can't be around withouth the correspoding TnyFolder.
1163 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1165 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1166 Added currently commented code to check for secure auth
1168 * src/maemo/modest-account-settings-dialog.c: (on_response),
1169 (save_configuration), (show_ok):
1170 Fixed projects.maemo.org bugs NB #59248 and #59251
1172 * src/maemo/modest-maemo-utils.c:
1173 (on_camel_account_get_supported_secure_authentication_status),
1174 (on_camel_account_get_supported_secure_authentication),
1175 (modest_maemo_utils_get_supported_secure_authentication_methods):
1176 * src/maemo/modest-maemo-utils.h:
1177 Moved get_supported_secure_authentication() method here to be able
1178 to use it from easysetup wizard.
1180 * src/modest-pair.c: (on_pair_compare_as_string):
1181 Should compare string with first part of pair and not
1182 strcmp pairs which will crash.
1184 * src/modest-protocol-info.c:
1185 (modest_protocol_info_protocol_is_store):
1186 * src/modest-protocol-info.h:
1187 Added modest_protocol_info_get_auth_protocol_name()
1189 2007-06-03 Armin Burgmeier <armin@openismus.com>
1191 * src/modest-mail-operation.c:
1192 (modest_mail_operation_get_msgs_full): Set priv->account also when
1193 only retrieving a single message. This avoids a crash when canceling
1196 (modest_mail_operation_notify_end): Do not explicitely remove the
1197 operation from the queue but only emit the progress_changed signal.
1198 The queue itself listens to that signal to remove the operation when
1199 it is finished. This reduces coupling and removes a potential deadlock
1200 when modest_mail_operation_notify_end() is called from the queue
1201 itself. If that is a problem performance-wise, I would suggest to
1202 implement a status-changed signal or something.
1204 * src/modest-mail-operation-queue.c: Make sure to never call a
1205 function from another file while the queue is locked. This (hopefully)
1206 fixes another deadlock when exiting the application while retrieving
1209 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1211 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1212 Fixed build if libogs is not available
1214 2007-06-03 Christian Kellner <ckellner@openismus.com>
1216 * libmodest-dbus-client/libmodest-dbus-client.h:
1217 * libmodest-dbus-client/libmodest-dbus-client.c:
1218 (libmodest_dbus_client_delete_message):
1219 Implement deletion of messages (Client side).
1221 (modest_search_hit_free),
1222 (modest_search_hit_list_free):
1223 Utility functions to free the result hits.
1225 * src/dbus_api/modest-dbus-api.h:
1226 * src/dbus_api/modest-dbus-callbacks.c:
1227 (on_delete_message),
1228 (modest_dbus_req_handler):
1229 Implement deletion of messages (Server side).
1231 * tests/dbus_api/test_search.c: (main):
1234 * tests/dbus_api/Makefile.am:
1235 * tests/dbus_api/test_delete_message:
1236 Add little test for the message deletion logic
1238 2007-06-03 Armin Burgmeier <armin@openismus.com>
1240 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1241 when the operation queue was not empty. projects.maemo.org bug
1244 2007-06-03 Armin Burgmeier <armin@openismus.com>
1246 * src/widgets/modest-account-view.c
1247 (on_account_default_toggled): Toggle default account column
1248 explicitely instead of waiting for gconf notification (which is
1249 currently ignored). This should fix projects.maemo.org bug NB#56910
1250 for now. It should probably be removed when gconf notifications are
1253 2007-06-03 Christian Kellner <ckellner@openismus.com>
1255 * libmodest-dbus-client/libmodest-dbus-client.c:
1256 Removed debugging spew.
1258 * src/dbus_api/modest-dbus-callbacks.c:
1259 Added debugging info.
1261 * src/modest-search.c:
1262 (modest_search_all_accounts):
1263 Use tny_account_store_get_accounts () on the account store
1264 to get all accounts which is the way to get all accounts.
1266 * tests/dbus_api/test_search.c: (main):
1267 Make it possible to supply the search term on the command line.
1269 2007-06-03 Christian Kellner <ckellner@openismus.com>
1271 * libmodest-dbus-client/libmodest-dbus-client.c:
1272 * libmodest-dbus-client/libmodest-dbus-client.h:
1273 Implement searching for mesages over raw dbus. (Client side)
1275 * src/dbus_api/Makefile.am:
1276 * src/dbus_api/modest-dbus-api.h:
1277 * src/dbus_api/modest-dbus-callbacks.c:
1278 * src/dbus_api/modest-dbus-callbacks.h:
1279 Search framework (Server side). Also implement on_idle_open_message().
1281 * src/maemo/modest-platform.c: (modest_platform_init):
1282 Prepare for raw dbus/osso rpc interaction.
1284 * src/modest-search.h:
1285 Changed minsize from unspecific guint to guint32.
1287 * src/modest-search.c:
1289 Added strange hack which magically made tnymail work.
1291 (modest_search_folder),
1292 (modest_search_account),
1293 (modest_search_all_accounts):
1294 Implement helper functions to search all accounts, specific account
1297 * tests/dbus_api/Makefile.am:
1298 * tests/dbus_api/test_open_message.c:
1299 Read url to open from commandline.
1301 * tests/dbus_api/test_search.c:
1302 Implement small test for dbus search stuff
1304 2007-06-02 Armin Burgmeier <armin@openismus.com>
1306 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1307 include account type and account title. This fixes projects.maemo.org
1310 * src/maemo/modest-account-view-window.c: Set a title for the window.
1312 2007-06-02 Armin Burgmeier <armin@openismus.com>
1314 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1315 incoming and outgoing server name based on email address and server
1316 types as long as the names have not been edited manually. This fixes
1317 projects.maemo.org bug NB#58671.
1319 2007-06-02 Armin Burgmeier <armin@openismus.com>
1321 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1322 server type cannot be changed in future to the incoming details page
1323 when creating an account. This fixes projects.maemo.org bug NB#59029.
1325 2007-06-02 Armin Burgmeier <armin@openismus.com>
1327 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1328 and assigned max width chars so that they wrap instead of being
1329 truncated. Fixes projects.maemo.org bug NB#56126.
1331 2007-06-02 Armin Burgmeier <armin@openismus.com>
1333 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1334 introductory note to the connection specific smtp servers dialog, as
1335 section 8.12 of the email UI specification requires. This fixes
1336 projects.maemo.org bug NB#59212.
1338 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1340 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1341 Check for running mail operations, and offer to cancel them, as per the UI
1342 spec. This fixes projects.maemo.org bug NB#59041 .
1343 However, I suspect that tinymail may still use the network connection
1344 in ways that we cannot detect or cancel. But it should at least adapt to
1345 changes fairly well.
1347 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1349 * src/modest-tny-account-store.c: (recreate_all_accounts),
1350 (get_cached_accounts), (get_server_accounts): Do more sensible
1351 ref-counting of the temporarily-cached outbox accounts list. This seems
1352 to fix a crash when entering the password when the password was wrong.
1354 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1356 * src/gnome/modest-main-window.c: (connect_signals):
1357 * src/modest-tny-account-store.c: (get_password),
1358 (modest_tny_account_store_alert): Added comments and clues and
1359 commented-out code about how we currently fail to deal with connection
1360 errors and wrong passwords, and how we should.
1362 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1364 * src/widgets/modest-retrieve-combo-box.c:
1365 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1366 This fixes projects.maemo.org bug NB#58472 .
1368 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/easysetup/modest-easysetup-wizard.c:
1371 (create_page_complete_easysetup):
1372 (create_page_complete_custom): Correct the last commit,
1373 putting the correct sentences in the correct pages.
1375 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1377 * src/maemo/easysetup/modest-easysetup-wizard.c:
1378 (create_page_complete_custom): Show the second sentence of text
1379 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1382 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1384 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1385 Set the leave-on-server conf key by default. This fixes
1386 projects.maemo.org bug NB#59258 .
1388 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1390 * src/maemo/modest-account-view-window.c:
1391 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1392 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1395 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1397 * src/maemo/easysetup/modest-easysetup-wizard.c:
1398 (create_caption_new_with_asterisk):
1399 * src/maemo/modest-account-settings-dialog.c:
1400 (create_caption_new_with_asterisk):
1401 Uncomment the code to add the asterisk, because they are no longer in the
1402 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1403 (update_incoming_server_title): Add an asterisk here too.
1405 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1407 * src/maemo/modest-maemo-global-settings-dialog.c:
1408 (current_connection): Check that we are even connected before trying to
1409 get the current connection name, to prevent a warning.
1411 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1412 Change the comments because tny_maemo_conic_device_connect() is now meant to
1414 * src/modest-mail-operation.c:
1415 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1416 make sure we have a connection and fail if we can't connect.
1418 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1420 * src/maemo/modest-main-window.c:
1421 (on_account_store_connecting_finished): Do not try to get the
1422 connection ID if we are not really connected. I am surprised that
1423 this signal handler is called when we are not connected.
1425 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-error.h:
1428 * src/modest-ui-actions.c:
1429 (modest_ui_actions_get_msgs_full_error_handler):
1430 Renamed an enum, added comments, added an enum
1431 for retrieve-limit errors.
1433 * src/modest-mail-operation.c: (foreach_add_item),
1434 (internal_folder_observer_update), (update_account_thread),
1435 (modest_mail_operation_get_msgs_full):
1436 (modest_mail_operation_update_account),
1437 Added comments about how this works, and some code that should
1438 (but does not) check the retrieve-limit. See the TODO comment.
1440 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1442 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1443 Initialize help_id to fix the build. Warnings are good.
1445 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1447 * src/widgets/modest-hbox-cell-renderer.c:
1448 (modest_hbox_cell_renderer_append):
1449 * src/widgets/modest-vbox-cell-renderer.c:
1450 (modest_vbox_cell_renderer_append):
1451 Fix the last commit by doing an extra ref.
1453 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1455 * src/widgets/modest-hbox-cell-renderer.c:
1456 (modest_hbox_cell_renderer_append):
1457 * src/widgets/modest-vbox-cell-renderer.c:
1458 (modest_vbox_cell_renderer_append):
1459 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1460 to fix the build with Maemo Bora.
1461 However, there seems to be a remaining crash, probably due to reference
1464 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1466 * src/modest-tny-account.c:
1467 (modest_tny_account_new_for_local_folders):
1468 Use hildon_file_system_info_async_new() to get a better name for
1469 the memory card account, setting it as the account name.
1470 The timing seems to work, but this is probably
1471 not the best place to do this. See the TODO comment.
1472 * src/maemo/modest-main-window.c: (create_details_widget):
1473 * src/widgets/modest-folder-view.c: (text_cell_data):
1474 Use the tny account name instead of hardcoding a name.
1476 2007-05-30 Christian Kellner <ckellner@openismus.com>
1478 * src/modest-search.c: (modest_search):
1479 Correctly set part_search_func even if we have already parsed
1480 the query and thus a valid OgsTextSearcher object.
1482 2007-05-30 Christian Kellner <ckellner@openismus.com>
1485 Search and check for libogs.
1488 Incooparte the ogs build env.
1490 * src/modest-mime-part-search-stream.c:
1491 * src/modest-mime-part-search-stream.h:
1492 Removed since we do the real searching now in modest-search.c.
1494 * src/modest-search.c:
1495 * src/modest-search.h:
1496 Implement support for ogs. We use that if available and requested
1497 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1498 should now handle the corner case when the search term is spread
1499 across multiple reads.
1500 Also the logic in modest_search () was corrected to search all
1501 requested fields until one is found.
1503 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1505 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1507 * src/modest-init.h:
1508 * src/modest-init.c: Made modest_init_local_folders() take a
1509 path and be public so we can iniitialize maildir folders on
1512 * src/modest-local-folder-info.h:
1513 * src/modest-local-folder-info.c:
1514 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1516 * src/modest-tny-account.c:
1517 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1518 still means the standard local-folders path on the local volume.
1520 * src/modest-tny-account-store.c:
1521 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1522 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1523 all accounts when that happens.
1524 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1525 this too, so it shows up in the treeview.
1527 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1529 * src/maemo/modest-maemo-global-settings-dialog.c:
1530 (current_connection):
1531 * src/widgets/modest-global-settings-dialog.c:
1532 (current_connection_default):
1533 Use the enum values instead of 0, 1 and -1,
1534 to make the code clearer.
1536 * src/modest-account-mgr-helpers.c:
1537 (modest_account_mgr_get_connection_specific_smtp): Make this code
1540 * src/modest-runtime.h:
1541 * src/modest-runtime.c:
1542 Added modest_runtime_remove_all_send_queues().
1543 * src/maemo/modest-main-window.c:
1544 (on_account_store_connecting_finished): Recreate the send queues,
1545 using the appropriate transport accounts for this new connection.
1546 Some futher adapting might be needed if the old send queues are not
1547 automatically stopped at this point.
1549 * src/modest-tny-account-store.c: (get_server_accounts):
1550 Create the connection-specific transport accounts, so that they can
1551 be found later by their ID.
1553 * src/modest-tny-account.h:
1554 * src/modest-tny-account.c:
1555 Added modest_tny_account_new_from_server_account_name().
1556 modest_tny_account_new_from_server_account(): Do not create the
1557 send queues here, because they will be
1558 recreated anyway when the connection changes for the first time.
1560 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1562 * src/modest-local-folder-info.h:
1563 * src/modest-local-folder-info.c:
1564 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1565 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1566 tbox_folder): Take a modest account name instead of a server TnyAccount,
1567 so we can have per-modest-account rather than per-transport-account
1569 We must make sure that we change or recreate the exisitng send queues
1570 when the connection changes for connection-specific transport accounts.
1572 * src/modest-tny-account-store.c:
1573 (create_per_account_local_outbox_folders): Create outboxed per modest
1574 account, not per transport account.
1576 * src/modest-tny-account.h:
1577 * src/modest-tny-account.c:
1578 (modest_tny_account_get_special_folder): For outboxes, get the
1579 parent modest account name. The account is ignored for other folders.
1580 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1581 modest account name rather than a server TnyAccount.
1583 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1585 * src/modest-tny-account.c:
1586 (modest_tny_account_new_from_server_account):
1587 Call modest_runtime_get_send_queue() immediately after creating transport
1588 accounts, so that they start trying to send email from the outbox as soon
1589 as possible at startup. This is probably what we want.
1591 * src/modest-mail-operation.c: (update_account_thread):
1592 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1593 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1594 * src/modest-tny-send-queue.h:
1595 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1596 (modest_ui_actions_on_send):
1597 Added comments about how sending works, though it needs some more work.
1599 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1601 * src/modest-tny-account.c:
1602 (modest_tny_account_get_special_folder): Add TODO because this fails when
1603 the network is busy.
1604 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1605 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1606 Do not try to show this window when there is no active account. The UI
1607 specs does not tell us what to do in this case.
1609 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/Makefile.am:
1614 * src/widgets/Makefile.am: Some dist fixes.
1616 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/modest-connection-specific-smtp-window.c:
1619 (on_button_edit): Make the code clearer, to prevent a double free.
1621 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1623 * src/maemo/modest-account-settings-dialog.c:
1624 (modest_account_settings_dialog_set_account_name),
1625 Check the connection-specific smtp servers checkbox if there are any.
1627 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1628 (modest_connection_specific_smtp_edit_window_init):
1629 Start with a suitable port number.
1631 * src/modest-account-mgr-helpers.h:
1632 * src/modest-account-mgr-helpers.c: Added
1633 modest_account_mgr_get_has_connection_specific_smtp().
1635 (modest_account_mgr_set_connection_specific_smtp),
1636 (modest_account_mgr_remove_connection_specific_smtp),
1637 (modest_account_mgr_get_has_connection_specific_smtp),
1638 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1639 connection-specific smtp server accounts in the account, rather than
1640 the server account conf dir.
1642 This fixes bug projects.maemo.org bug NB#58263 .
1644 * src/modest-tny-account-store.c:
1645 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1646 if there are no server accounts yet, to prevent an infinite loop when there
1647 are no accounts. Document that one must be called before the other.
1649 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1651 * src/modest-account-mgr-helpers.c:
1652 (modest_account_mgr_get_default_account): Make sure that at least
1653 one account is always the default, if there are any enabled accounts.
1654 This is just a sanity check that shouldn't be necessary.
1656 * src/modest-account-mgr-priv.c:
1657 (_modest_account_mgr_account_from_key): Unescape the conf key to
1658 get the real account name. For instance, this is an issue if a space
1659 was in the account name, which can happen because the account name
1660 is generated from the display name.
1661 (_modest_account_mgr_get_account_keyname): Always escape the
1663 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1664 Unescape the conf keys to get the real account names.
1666 For instance, previously the is-default radio button in the accounts
1667 list was not checked for any accounts at first. This fixes that,
1668 and might fix several similar bugs.
1670 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1673 Removed some debug printfs.
1675 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1677 Modest on-disk outbox directories are now here, for instance:
1678 $HOME/.modest/outboxes/<account-id-1>/outbox
1679 $HOME/.modest/outboxes/<account-id-2>/outbox
1681 $HOME/.modest/local-folders/outbox
1682 so we can have a separate outbox for each account.
1683 But they are shown as one outbox in the GtkTreeView, by using a
1684 TnyMergeFolder in a ModestTnySimpleFolderStore.
1687 * src/modest-tny-simple-folder-store.c:
1688 * src/modest-tny-simple-folder-store.h:
1689 Added ModestTnySimpleFolderStore, used to contain folders from
1690 other folder stores, such as other accounts.
1692 * src/modest-tny-outbox-account.h:
1693 * src/modest-tny-outbox-account.c:
1694 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1695 used for the per-account local outbox folders.
1697 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1698 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1699 only use this (internally) now for the non-outbox local folders.
1701 * src/modest-init.h:
1702 * src/modest-init.c: Added modest_init_one_local_folder(), for
1703 setting up the directory structure for each local folder.
1705 * src/modest-local-folder-info.c:
1706 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1707 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1709 * src/modest-local-folder-info.h:
1710 * src/modest-tny-account-store.c: (on_account_removed),
1711 (on_account_changed), (create_per_account_local_outbox_folders),
1712 (get_server_accounts), (modest_tny_account_store_get_accounts),
1713 (modest_tny_account_store_get_tny_account_by_account),
1714 (modest_tny_folder_store_is_virtual_local_folders):
1716 * src/modest-tny-account.h:
1717 * src/modest-tny-account.c:
1718 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1719 to create an on-disk per-account local outbox folder for each
1721 (create_per_account_local_outbox_folders): Create a local outbox folder
1722 for each transport account.
1723 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1724 for all local folders.
1726 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1727 instead of using g_object_get/set() directly. It is clearer.
1729 (modest_tny_folder_store_get_message_count),
1730 (modest_tny_folder_store_get_local_size
1731 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1732 because we now use these with non-acount folder stores.
1734 (modest_tny_account_get_special_folder),
1735 (modest_tny_account_new_from_server_account),
1736 (modest_tny_account_new_from_account):
1737 (recurse_folders): Adjust to the new outbox system.
1739 * src/modest-tny-folder.h:
1740 * src/modest-tny-folder.c:
1741 (modest_tny_folder_is_local_folder),
1742 (modest_tny_folder_get_local_folder_type),
1743 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1745 * src/widgets/modest-main-window.h:
1746 * src/maemo/modest-main-window.c: (create_details_widget),
1747 (modest_main_window_set_contents_style): Show details for any folder store,
1750 (modest_tny_folder_get_rules):
1751 Remove the const. C does not support constness enough for this.
1753 * src/modest-ui-actions.c:
1754 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1755 make all outboxes appear as one, in the usual local-folders tree node.
1757 (set_active_account_from_tny_account),
1758 (modest_ui_actions_on_folder_selection_changed):
1759 * src/widgets/modest-folder-view.c: (text_cell_data),
1760 (icon_cell_data), (filter_row),
1761 (add_account_folders_to_merged_folder),
1762 (add_account_folders_to_simple_folder_store), (),
1763 (get_cmp_rows_type_pos), (cmp_rows),
1764 (modest_folder_view_set_account_id_of_visible_server_account):
1765 Adjust to the new outbox system, using generic folder stores and folders
1766 in the GtkTreeModel.
1768 2007-05-23 Christian Kellner <ckellner@openismus.com>
1770 * src/modest-mail-operation.c:
1771 (modest_mail_operation_update_account):
1772 Use info->max_size instead of unintialized local var [small
1773 build fix]. (Added TODO to review that change since I don't
1776 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1778 * libmodest-dbus-client/libmodest-dbus-client.c:
1779 (libmodest_dbus_client_compose_mail): function added
1780 * src/dbus_api/modest-dbus-api.h:
1781 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1782 (on_compose_mail): Implementation of the SendAsMail functionality
1784 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1786 * src/modest-account-mgr.c:
1787 (modest_account_mgr_add_server_account): Set the secure-connection
1788 conf key for transport accounts as well as store accounts. I don't know
1789 why the if was there. For instance, this makes sure that we use SSL
1790 for the gmail preset from the easysetup wizard.
1792 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1794 * src/gnome/modest-main-window.c:
1795 (on_account_store_connecting_finished), (connect_signals):
1796 * src/maemo/modest-main-window.c:
1797 (on_account_store_connecting_finished), (connect_signals),
1798 (modest_main_window_new):
1799 Handle TnyAccountStore::connecting-finished instead of
1800 TnyDevice::connection-changed, because we cannot actually perform
1801 operations on accounts until TnyAccountStore has itself responded to
1802 the TnyDevice::connection-changed signal. This prevents a GError from
1804 Do not try to update at startup, because we (at least on scratchbox)
1805 already do an update at startup when the device goes online.
1806 This prevents a GError from tinymail.
1807 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1808 Added TODO about stopping simultaneous operations.
1810 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1812 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1813 * src/modest-mail-operation-queue.c:
1814 (modest_mail_operation_queue_remove):
1815 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1816 about where they happened.
1818 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1820 * src/modest-ui-actions.c:
1821 (modest_ui_actions_on_password_requested): Make sure that the remember
1822 output parameter is always TRUE.
1824 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1827 Show a OK/Cancel dialog if the error is a question, though we still do not
1828 know anything more about what we are asking the user.
1829 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1830 Fix an uninitialized variable (helper). This is a logic error, however.
1832 2007-05-21 Christian Kellner <ckellner@openismus.com>
1834 * src/modest-search.h:
1835 Correct bit shifting in the ModestSearchFlags enum.
1837 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1839 * src/modest-tny-account.c:
1840 (modest_tny_account_new_from_server_account): Do not use the lsub and
1841 check-all hard-coded IMAP options when using POP.
1843 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1845 * src/modest-tny-account.c:
1846 (modest_tny_account_new_from_server_account):
1847 Use NULL for the secure-auth method for POP when Password auth has been
1848 specified by the user, as we already do for IMAP. "auth=Login" causes
1849 an error from camel or the server.
1851 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1853 * src/maemo/modest-account-settings-dialog.c:
1854 (create_page_account_details),
1855 (modest_account_settings_dialog_set_account_name):
1856 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1857 for the leave-on-server checkbox, rathr than just the checkbox, when
1858 the protocol is not POP.
1860 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1862 * src/widgets/modest-account-view.c:
1863 * src/widgets/modest-account-view.h:
1864 Added modest_account_view_select_account() which will be useful later
1865 to asynchronously re-select the edited account.
1867 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1869 * src/maemo/modest-account-settings-dialog.c:
1870 (modest_account_settings_dialog_set_account_name):
1871 Automatically choose the port numbers based on the secure authentication
1872 methods, if they have not been chosen before.
1873 This fixes projects.maemo.org bug NB#56273 .
1875 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1877 * src/maemo/modest-main-window-ui.h:
1878 * src/modest-ui-actions.c:
1879 * src/modest-ui-actions.h:
1880 Connect the Tools/SMTP Servers menu item to
1881 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1882 SMTP servers dialog, as in the UI specification and saves changes when it
1883 is closed. This fixed projects.maemo.org bug NB#56305 .
1885 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1887 * src/maemo/modest-connection-specific-smtp-window.c:
1888 (modest_connection_specific_smtp_window_init):
1889 Use gtk_window_set_default_size() to make this window big enough, so
1890 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1892 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1894 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1895 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1896 (modest_connection_specific_smtp_edit_window_init),
1897 Do not try to connect to a combobox signal before the combobox exists.
1898 This fixes the cras in projects.maemo.org bug NB#56288 .
1899 (modest_connection_specific_smtp_edit_window_get_settings):
1900 Remove the server_account_name parameter which was being checked for NULL
1901 though it was not used.
1903 * src/maemo/modest-connection-specific-smtp-window.c:
1904 (modest_connection_specific_smtp_window_fill_with_connections),
1905 (on_button_edit), (modest_connection_specific_smtp_window_init):
1906 Correct the number of treemodel columns to prevent a warning.
1907 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1908 libconic does not work.
1910 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1912 * src/modest-tny-account.c:
1913 (modest_tny_account_new_from_server_account):
1914 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1915 SMTP when "None" was chosen by the user. However, with my SMTP server that
1916 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1919 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1921 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1922 to explain the memory management issue with the ID in the ModestPair.
1924 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1925 (add_sending_page), (modest_account_assistant_finalize):
1926 * src/gnome/modest-gnome-global-settings-dialog.c:
1927 (create_updating_page), (create_composing_page):
1928 * src/gnome/modest-msg-edit-window.c: (get_transports),
1929 (init_window), (modest_msg_edit_window_finalize),
1930 (modest_msg_edit_window_get_msg_data):
1931 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1932 * src/gnome/modest-transport-widget.c:
1933 (modest_transport_widget_finalize), (smtp_configuration):
1934 * src/maemo/modest-maemo-global-settings-dialog.c:
1935 (create_updating_page), (create_composing_page):
1936 * src/maemo/modest-msg-edit-window.c: (get_transports),
1937 (init_window), (modest_msg_edit_window_finalize),
1938 (modest_msg_edit_window_get_msg_data),
1939 (modest_msg_edit_window_free_msg_data):
1940 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1941 (modest_store_widget_finalize):
1942 * src/maemo/modest-transport-widget.c:
1943 (modest_transport_widget_finalize), (smtp_configuration):
1944 * src/modest-main.c: (send_mail):
1945 * src/widgets/modest-combo-box.h:
1946 * src/widgets/modest-global-settings-dialog-priv.h:
1947 * src/widgets/modest-global-settings-dialog.c:
1948 (modest_global_settings_dialog_finalize):
1949 * src/widgets/modest-msg-edit-window.h:
1950 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1951 as long as the combo box, to prevent use of freed memory for the ID.
1953 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1955 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1956 get_accounts(), to make this clearer. Do not check for the enabled gconf
1957 key, because we do not use this for server accounts (at least, not yet).
1958 This allows us to send email again.
1960 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1962 * src/maemo/modest-platform.c:
1963 (on_modest_conf_update_interval_changed), (modest_platform_init):
1964 Only respond to this particular key change. All these strcmp()s cannot be
1967 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1969 * src/maemo/modest-maemo-global-settings-dialog.c:
1970 (current_connection): Prevent a crash in scratchbox when
1971 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1972 * src/maemo/modest-platform.c:
1973 (on_modest_conf_update_interval_changed), (modest_platform_init):
1974 Get the update interval from gconf and reset it when the gconf key changes.
1976 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1978 * src/modest-protocol-info.c:
1979 * src/modest-protocol-info.h: Adde enum-specific get functions,
1980 instead of using a ModestProtocolType enum parameter.
1982 * src/gnome/modest-account-assistant.c:
1983 * src/gnome/modest-store-widget.c:
1984 * src/gnome/modest-store-widget.h:
1985 * src/gnome/modest-transport-widget.c:
1986 * src/gnome/modest-transport-widget.h:
1987 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1988 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1989 * src/maemo/easysetup/modest-easysetup-wizard.c:
1990 * src/maemo/modest-account-settings-dialog.c:
1991 * src/maemo/modest-account-settings-dialog.h:
1992 * src/maemo/modest-store-widget.c:
1993 * src/maemo/modest-store-widget.h:
1994 * src/maemo/modest-transport-widget.c:
1995 * src/maemo/modest-transport-widget.h:
1996 * src/modest-account-mgr-helpers.c:
1997 * src/modest-account-mgr-helpers.h:
1998 * src/modest-account-mgr.c:
1999 * src/modest-account-mgr.h:
2000 * src/modest-tny-account.c:
2001 * src/modest-tny-folder.c:
2002 * src/widgets/modest-account-view.c:
2003 * src/widgets/modest-retrieve-combo-box.c:
2004 * src/widgets/modest-retrieve-combo-box.h:
2005 * src/widgets/modest-secureauth-combo-box.c:
2006 * src/widgets/modest-serversecurity-combo-box.c:
2007 * src/widgets/modest-serversecurity-combo-box.h:
2008 * tests/check_account-mgr.c:
2009 Use the specific functions, and use the re-renamed enum values for GNOME too.
2011 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2013 * src/modest-pair.h:
2014 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2015 so we can get the second based on the first.
2017 * src/maemo/modest-account-settings-dialog.h:
2018 * src/maemo/modest-account-settings-dialog.c:
2019 Added get_supported_secure_authentication_methods(), though it is mostly
2020 commented-out for now until the necessary API is committed to tinymail.
2021 (modest_account_settings_dialog_set_account_name),
2022 (save_configuration): Request the supported authentication methods from the
2023 server, so we can choose a working method.
2025 * src/modest-tny-account-store.h:
2026 * src/modest-tny-account-store.c:
2027 (modest_tny_account_store_get_session): Rename from
2028 tny_account_store_get_session().
2030 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2032 * src/modest-protocol-info.h: Split the ModestProtocol enum
2033 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2034 There was no need to have these unrelated values in one enum.
2036 * src/: many files: Adapted to changed enum. This makes the code a bit
2037 clearer, and the compiler could catch some errors.
2039 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2042 Show the detailed internal camel error message when an error happens
2043 during the configuration, so that our testers can give us more clues.
2044 For instance, in projects.maemo.org bug NB#56910 .
2046 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2048 * src/modest-tny-account.c:
2049 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2050 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2052 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2054 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2055 * src/maemo/modest-account-settings-dialog.c:
2056 (modest_account_settings_dialog_set_account_name),
2057 (save_configuration): For the incoming secure authentication checkbox,
2058 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2059 the UI specification. PLAIN does not seem to be supported for most IMAP
2060 servers anyway, and I am not sure what it would mean.
2061 However, we probably need to discover which of the secure-authentication
2062 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2063 * src/modest-account-mgr-helpers.c:
2064 (modest_account_mgr_get_server_account_data):
2066 * src/modest-tny-account.c:
2067 (modest_tny_account_new_from_server_account):
2068 Use tny_account_set_mech() to set secure-authentication methods,
2069 with some special-casing for IMAP, based on my observations of how
2072 * src/modest-account-mgr-helpers.h:
2073 * src/modest-account-mgr.c:
2074 * src/modest-defs.h: Comment that the URI is only used for local folders.
2076 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2079 parameter const, just to be neat.
2080 * src/modest-text-utils.c: (modest_text_utils_inline):
2081 End g_strconcat() with NULL, as its documentation says. This is almost
2082 certainly the cause of my crash at startup on the device. Interestingly,
2083 valgrind doesn't tell us about these errors.
2085 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2087 * scripts/build-packages: Added more precise comments about how to use
2088 this script, though I still get this error:
2089 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2090 error building tinymail
2092 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2094 * src/maemo/modest-main-window.c: (on_account_update):
2095 Very slight cleanup, hoping to make it simpler to discover what causes
2096 a crash here sometimes.
2098 * src/modest-tny-account.c:
2099 (modest_tny_account_new_from_server_account): Set the port. Added
2100 comments about the options and a TODO comment because I need to find out
2101 how to specify the secure authentication method.
2103 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2105 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2106 changed CFlags paths form modest to libmodest
2108 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2110 * src/modest-account-mgr-helpers.c:
2111 (modest_account_mgr_get_server_account_data),
2112 (modest_account_mgr_free_server_account_data):
2113 * src/modest-account-mgr-helpers.h:
2114 * src/modest-account-mgr.c:
2115 (modest_account_mgr_add_server_account):
2116 * src/modest-defs.h:
2117 * src/modest-tny-account.c:
2118 (modest_tny_account_new_from_server_account):
2119 Determine the options for tny_camel_account_add_option() here,
2120 based on the settings, rather than storing them directly in gconf.
2122 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2124 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2125 Show a more friendly error dialog now that we expect (from the tinymail
2126 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2128 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2130 * src/maemo/modest-main-window.c: (on_account_update): Check that
2131 account_name is not NULL, to prevent a crash at startup that I am
2132 seeing on the N800. I do wonder why it is NULL.
2134 * src/maemo/easysetup/modest-easysetup-wizard.c:
2135 (create_page_user_details):
2136 * src/maemo/modest-account-settings-dialog.c:
2137 (create_page_user_details), (create_page_outgoing):
2138 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2139 (modest_connection_specific_smtp_edit_window_init):
2140 * src/modest-ui-actions.c:
2141 (modest_ui_actions_on_password_requested):
2142 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2143 might do something useful with the on-screen keyboard.
2145 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2147 * src/maemo/modest-main-window.c: (on_account_update):
2148 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2149 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2151 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2153 * src/modest-tny-account-store.c: (on_account_changed):
2154 Correct the signature of this signal handler.
2156 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2158 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2159 Show a HildonNote instead of a GtkDialog for Maemo.
2161 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2163 * src/widgets/modest-account-view.h:
2164 * src/widgets/modest-account-view.c: (on_account_changed),
2165 (on_account_removed). Added a boolean flag, set/unset by
2166 modest_account_view_block_conf_updates(),
2167 modest_account_view_unblock_conf_updates() to prevent unnecessary
2168 updates, but this is not very useful because the gconf notifications are
2169 so delays (maybe only on Maemo Bora).
2170 So auto-updating is turned off, and these functions do an explicit
2171 update when necessary.
2172 However, something else is still doing too much work when adding/removing
2173 accounts, probably in another part of the application.
2175 * src/maemo/modest-account-view-window.c:
2176 (on_delete_button_clicked), (on_edit_button_clicked),
2177 (on_new_button_clicked): Use the new functions.
2179 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2181 * src/modest-account-mgr-helpers.c:
2182 (modest_account_mgr_set_first_account_as_default):
2183 Sort the list of names alphabetically-by-title, so we choose the first one
2185 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2186 alphabetically by the title.
2188 This fixes projects.maemo.org bug NB#56418 .
2190 * src/modest-account-mgr-priv.c:
2191 (_modest_account_mgr_account_from_key):
2192 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2193 avoid a valgrind error, and possible random behaviour.
2195 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2197 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2198 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2199 tinymail documentation to say that this can be expected.
2200 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2201 pretty, and should not happen, but I would prefer to know when it does.
2203 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2205 * configure.ac: When using the older hildon version, probably on Bora,
2206 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2208 * src/widgets/modest-attachment-view.c:
2209 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2212 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2214 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2215 Implemented the prototype. Can be tested with
2216 tests/dbus_api/test_open_message:
2218 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2220 * src/modest-tny-account-store.c:
2221 (modest_tny_account_store_instance_init), (get_password):
2222 * src/modest-ui-actions.c:
2223 (modest_ui_actions_on_password_requested):
2224 Do not store the password in gconf, because this function is called
2225 for non-remembered passwords. Actually use the cached (in the hash map)
2226 password instead of releasing it.
2227 The password will now not be remembered if it is asked via the protected
2228 password dialog, as per the UI spec.
2230 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2232 * src/modest-defs.h:
2233 * src/modest-account-mgr-helpers.h:
2234 * src/modest-account-mgr-helpers.c:
2235 Added modest_server_account_get_username_has_succeeded(),
2236 modest_server_account_set_username_has_succeeded().
2237 (modest_server_account_set_username),
2238 Reset the has-succeeded flag if the username changes.
2240 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2241 * src/maemo/modest-connection-specific-smtp-window.c:
2242 (modest_connection_specific_smtp_window_save_server_accounts):
2243 Use modest_server_account_set_username() instead of using
2244 modest_conf_set_string() directly, so that the has-succeeded flag is always
2247 * src/modest-ui-actions.c:
2248 (modest_ui_actions_on_password_requested): Dim the username entry if
2249 the username has ever worked, as per the UI spec.
2251 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-tny-account-store.c: (get_password):
2254 * src/modest-ui-actions.c:
2255 (modest_ui_actions_on_password_requested):
2256 Allow the username to be changed too, though there is more work to
2257 be done on exactly how this behaves.
2259 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2261 * src/modest-account-mgr-helpers.h:
2262 * src/modest-account-mgr-helpers.c:
2263 Added modest_account_mgr_get_display_name(),
2264 modest_server_account_get_username(),
2265 modest_server_account_set_username(),
2266 modest_server_account_set_password(),
2267 modest_server_account_get_hostname() functions so we do not need to
2268 use the conf API directly.
2270 * src/maemo/modest-main-window.c: (connect_signals):
2271 Actually connect ot the ModestAccountStore::request-password signal,
2272 so that we show the dialog when the password is requested by Tinymail,
2273 for isntance if it is empty.
2275 * src/modest-marshal.list:
2276 * src/modest-tny-account-store.c:
2277 (modest_tny_account_store_class_init), (get_password),
2278 (modest_tny_account_store_alert):
2279 * src/modest-tny-account-store.h:
2280 * src/modest-ui-actions.h:
2281 * src/modest-ui-actions.c:
2282 (modest_ui_actions_on_password_requested):
2283 Change the signal parameters, so it is obvious that we are providing
2284 the non human-readable server name, and receiving both the username
2285 and password, though changing of the username is not yet implemented.
2286 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2287 for the GNOME version.
2289 This should fix the projects.maemo.org bug NB#56209, though it does not
2290 work on Bora, because the gconf_client_get() for the password fails
2291 immediately after we save it with gconf_client_set().
2293 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2296 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2297 caused an undefined symbol error:
2298 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2300 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2302 * src/modest-tny-account-store.c:
2303 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2304 using a GError instead of a string message, so we can translate it in
2307 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2309 * src/maemo/modest-address-book.c:
2310 (modest_address_book_check_names):
2311 * src/maemo/modest-msg-view-window.c:
2312 (modest_msg_view_window_clipboard_owner_change):
2313 * src/modest-init.c: (modest_init_init_ui):
2314 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2315 (update_folders_cb), (modest_mail_operation_update_account):
2316 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2317 (modest_ui_actions_on_msg_attachment_clicked),
2318 (modest_ui_actions_on_msg_recpt_activated):
2319 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2320 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2321 (modest_msg_view_search_next):
2322 * src/widgets/modest-recpt-editor.c:
2323 (modest_recpt_editor_on_button_release_event),
2324 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2325 g_message(). At this point we should only be seeing interesting errors on
2326 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2328 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2330 (modest_wizard_dialog_force_title_update):
2331 * src/maemo/easysetup/modest-wizard-dialog.h:
2332 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2333 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2334 can update the title when appropriate. Otherwise the title is wrong if the
2335 pages are added after adding the notebook to the dialog.
2336 This must be a problem in HildonWizardDialog too.
2337 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2339 * src/maemo/easysetup/modest-easysetup-wizard.c:
2340 (create_subsequent_customsetup_pages),
2341 (create_subsequent_easysetup_pages):
2342 Call modest_wizard_dialog_force_title_update() so that the title is
2343 correct even with GTK+ < 2.10.
2344 This fixes projects.maemo.org bug NB#56145 .
2346 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2348 * src/maemo/modest-platform.c:
2349 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2350 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2353 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2355 * src/widgets/modest-window.h:
2356 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2357 and modest_window_save_state(), which invokes it.
2359 * src/widgets/modest-window-mgr.h:
2360 * src/widgets/modest-window-mgr.c:
2361 Added modest_window_mgr_save_state_for_all_windows(), which calls
2362 the save_state vfunc on all registered windows, if implemented.
2364 * src/gnome/modest-msg-edit-window.c:
2365 * src/gnome/modest-msg-view-window.c:
2366 * src/maemo/modest-msg-edit-window.c:
2367 * src/maemo/modest-msg-view-window.c:
2368 * src/maemo/modest-main-window.c:
2369 Specify the existing save_settings functions as implementations of
2370 ModestWindow::save_state_func().
2372 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2373 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2374 enabling hibernation, for instance.
2376 We may need to do the same thing for restoring settings.
2379 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2381 * src/widgets/modest-window-mgr.c:
2382 * src/widgets/modest-window-mgr.h:
2383 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2384 modest_window_mgr_get_hibernation_is_prevented().
2386 * src/maemo/modest-main-window.c:
2387 (on_hildon_program_is_topmost_notify): Prevent hibernation
2388 (possible when the application goes to the background in the WM),
2389 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2391 * src/maemo/easysetup/modest-easysetup-wizard.c:
2392 (modest_easysetup_wizard_dialog_init):
2393 * src/maemo/modest-account-settings-dialog.c:
2394 (modest_account_settings_dialog_init):
2395 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2396 (modest_connection_specific_smtp_edit_window_init):
2397 * src/maemo/modest-connection-specific-smtp-window.c:
2398 (modest_connection_specific_smtp_window_init):
2399 * src/maemo/modest-signature-editor-dialog.c:
2400 (modest_signature_editor_dialog_init):
2401 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2402 prevent hibernation while any of these account settings dialogs are open.
2404 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2406 * src/maemo/Makefile.am:
2407 * src/maemo/modest-osso-state-saving.c:
2408 * src/maemo/modest-osso-state-saving.h: Added
2409 modest_osso_load_state() and modest_osso_save_state() though they do
2410 nothing now. They should iterate through all the open windows and load/save
2412 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2413 save state when closing.
2415 * src/maemo/modest-main-window.c:
2416 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2417 Add a notification handler for the HildonProgram::is-topmost property,
2418 so we can allow hibernation when the application goes into the background.
2419 But we still need to detect when the accounts setup windows are open so
2420 we can stop hibernation when they are open.
2421 To do this, I also added the main window the HildonProgram. This might have
2422 other side-effects/benefits, and should maybe be done for other windows.
2424 * src/maemo/modest-osso-autosave-callbacks.h:
2425 * src/maemo/modest-osso-autosave-callbacks.c:
2426 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2427 though it does not do anything yet, and we might never need this to do
2428 anything. For instance, we already save drafts.
2430 * src/maemo/modest-platform.c: (modest_platform_init):
2431 Specify the libosso auto-save callback.
2433 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2435 * src/maemo/modest-platform.c:
2436 (modest_platform_set_update_interval):
2437 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2438 aparently stays valid between application instances, so we can use this
2439 to remove and reset it later. According to a maemo-developers email from
2442 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2444 * configure.ac: Depend on libalarm for Maemo.
2446 * src/dbus_api/modest-dbus-api.h:
2447 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2448 (on_send_receive), (modest_dbus_req_handler):
2449 Handle a SEND_RECEIVE D-Bus method.
2451 * libmodest-dbus-client/libmodest-dbus-client.c:
2452 (libmodest_dbus_client_send_and_receive):
2453 * libmodest-dbus-client/libmodest-dbus-client.h:
2454 Add C convenience functions for calling the new D-Bus method.
2456 * src/modest-platform.h:
2457 * src/gnome/modest-platform.c:
2458 * src/maemo/modest-platform.c:
2459 Added modest_platform_set_update_interval(), which uses the
2460 alarmd API on Maemo.
2461 (modest_platform_init),
2462 Call modest_platform_set_update_interval(), using a hard-coded
2463 interval for now (until the global settings dialog is implemented),
2464 though I am not sure that this makes sense yet.
2466 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2468 * src/dbus_api/modest-dbus-callbacks.c:
2469 (modest_osso_cb_hw_state_handler):
2470 * src/dbus_api/modest-dbus-callbacks.h:
2471 * src/maemo/modest-platform.c: (modest_platform_init):
2472 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2473 in case this has some effect on the ability for Maemo to ping the
2476 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2478 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2479 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2480 warning. It is probably a logic error, but I need to fix the build.
2482 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-account-mgr.h:
2485 * src/modest-account-mgr.c:
2486 (modest_account_mgr_account_names): Add a gboolean enabled_only
2487 parameter, so we can get lists of onlt the enabled accounts.
2489 (modest_account_mgr_add_account),,
2490 (modest_account_mgr_account_with_display_name_exists):
2491 * src/maemo/modest-msg-edit-window.c: (get_transports):
2492 * src/modest-account-mgr-helpers.c:
2493 (modest_account_mgr_set_first_account_as_default):
2494 * src/modest-init.c: (init_default_account_maybe):
2495 * src/modest-tny-account-store.c: (get_accounts):
2496 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2497 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2498 * tests/check_account-mgr.c: (START_TEST):
2499 Provide the extra parameter, as appropriate.
2501 * src/widgets/modest-account-view.c: (update_account_view):
2502 Do not show disabled accounts (meaning that there is no way to
2503 enable/disable accounts in the UI (the feature is not in our UI
2504 specification), so we can use this internally only to mark unfinished
2505 or temporary account data.
2507 * src/maemo/easysetup/modest-easysetup-wizard.c:
2508 (create_account): Add boolean enable parameter, so we can specify FALSE
2509 to create the temporary account.
2510 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2511 (on_before_next): When finishing, when there is a temporary account, just
2513 Also, use a timeout to delay the showing of the dialog until gconf is likely
2514 to return correct information, due to a maemo gconf bug that is fixed in
2515 osso 1.1, but not yet in Bora.
2516 However, the dialog stays on screen after it is destroyed.
2518 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2519 for invalid data when cancelling. Use a hildon note instead of a dialog
2520 to complain about invalid data. Do not show the account-saved note if the
2521 account is disabled (a temporary account that will not really be saved for use
2524 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2526 * src/modest-account-mgr-helpers.h:
2527 * src/modest-account-mgr-helpers.c:
2528 Added modest_account_mgr_unset_default_account(),
2529 Added modest_account_mgr_set_first_account_as_default().
2531 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2532 If it was the default account, unset the default account name.
2534 * src/maemo/modest-account-view-window.c:
2535 (on_delete_button_clicked): If it was the default account,
2536 set the first remaining account as the default instead.
2538 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2539 a NULL account or a NULL default account, to prevent a crash. This should
2540 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2543 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2545 * src/widgets/modest-recpt-editor.c:
2546 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2547 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2548 TODO comment for this. This fixes the build.
2550 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2551 be the best place for it. This will in future update all auto-update accounts,
2552 rather than just the current/default account, when that gconf key exists.
2553 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2554 if there are no accounts, before calling do_send_receive().
2555 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2557 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2558 * src/maemo/modest-main-window-ui.h:
2559 * src/maemo/modest-main-window.c: (on_connection_changed),
2560 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2561 directly, becaue the signal handler does more.
2563 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2565 * src/modest-account-mgr-helpers.c:
2566 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2567 for the case that the account does not exist.
2569 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2570 (equivalent to the modest account name) rather than the tinymail account name
2571 (equivalent to the modest account title - human readable) to get the account data.
2572 Check for null account data to prevent the crash, and add a TODO comment saying that
2573 this needs fixing because it is using the server account name instead of the account name.
2575 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2577 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2578 * src/maemo/modest-account-settings-dialog.c: (show_error),
2580 Use hildon_note_new_information() for informative and error messages,
2581 which seems to be expected for Maemo applications (no documentation that I know of
2582 says this). I am surprised that there is no distinction between info and error
2585 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2587 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2588 it is easy to find where this is used.
2590 * src/maemo/easysetup/modest-easysetup-wizard.c:
2591 (create_page_welcome), (create_page_account_details),
2592 (create_page_user_details), (create_page_complete_easysetup),
2593 (create_page_custom_incoming), (create_page_custom_outgoing),
2594 (create_page_complete_custom):
2595 * src/maemo/modest-account-settings-dialog.c:
2596 (create_page_account_details), (create_page_user_details),
2597 (create_page_incoming), (create_page_outgoing):
2598 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2599 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2600 (modest_connection_specific_smtp_edit_window_init):
2601 * src/maemo/modest-connection-specific-smtp-window.c:
2602 (modest_connection_specific_smtp_window_init):
2603 * src/maemo/modest-signature-editor-dialog.c:
2604 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2605 and scrolling policy as per the Email Application Layout Guide, if I have
2608 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2610 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2611 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2612 which were empty, because these vfuncs have been removed from TnyAccountStore.
2613 This fixes the build.
2615 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2617 * src/maemo/modest-main-window.c:
2618 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2619 showing/hiding it. Added TODO because it probably should not be NULL.
2620 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2621 because unnecessary g_warnings() make degugging difficult.
2623 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2625 * src/maemo/modest-msg-edit-window.c:
2626 (modest_msg_edit_window_select_color),
2627 (modest_msg_edit_window_select_background_color): 2 const corrections and
2628 moving 2 #endifs before closing brackets, to fix the build.
2630 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2632 * src/maemo/easysetup/modest-easysetup-wizard.h:
2633 * src/maemo/easysetup/modest-easysetup-wizard.c:
2634 (modest_easysetup_wizard_dialog_finalize),
2635 (on_button_edit_advanced_settings), (create_page_complete_custom),
2636 (on_response), (create_account):
2637 Implement the Advanced Settings edit button, by saving the account information,
2638 for the Advanded Settings dialog to use directly from gconf, and removing it
2639 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2640 Bug #5533 in the projects.maemo.org bugzilla.
2642 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2644 * src/maemo/modest-msg-view-window.c:
2645 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2646 when opening a message window.
2648 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2650 * src/maemo/easysetup/modest-easysetup-wizard.c:
2651 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2654 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2655 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2656 gconf settings. I probably added more checks than necessary, but that is safer.
2658 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2659 variable to fix the build, but this seems to be used when it is still NULL.
2661 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2663 * src/modest-platform.h:
2664 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2665 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2666 * src/modest-main.c: Implement this function so we can avoid using
2667 maemo-specific API from cross-platform code.
2669 * src/modest-tny-account-store.c:
2670 (get_smtp_specific_transport_account_for_open_connection):
2671 * src/modest-ui-actions.c: (check_for_connection),
2672 (modest_ui_actions_on_item_not_found):
2673 Use modest_platform_connect_and_wait() and put #idefs around other
2674 maemo-specific code, because only maemo currently has a way to
2675 identify connection names.
2677 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2679 * src/modest-tny-account-store.h:
2680 * src/modest-tny-account-store.c:
2681 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2682 the connection-specific SMTP server settings in the configuration.
2684 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2686 * src/maemo/modest-main-window.c: (on_connection_changed),
2688 * src/modest-main.c: (main), (start_ui), (send_mail):
2689 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2690 that is what is intended.
2692 * src/modest-ui-actions.c: (action_send), (action_receive),
2693 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2694 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2695 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2696 SMTP server is used when it is specified.
2698 (modest_ui_actions_on_send_receive):
2699 Check that a connection is open before proceeding.
2700 Receive and then send, instead of vice-versa, as per the specification.
2702 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2704 * src/modest-mail-operation.c:
2705 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2706 though I guess it should be something other than NULL.
2708 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2710 * src/maemo/easysetup/modest-easysetup-wizard.c:
2711 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2712 combo twice, to avoid an g_warning and to make it visible again.
2713 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2714 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2715 (already intended) dereference when detaching, because we then recreate the menu.
2716 But I am not sure why the warning was happening, and it is possible that this is a memory
2719 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2721 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2722 and uri_parse_mailto() utility functions.
2723 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2725 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2727 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2729 * src/dbus_api/modest-dbus-api.h:
2730 * src/dbus_api/modest-dbus-callbacks.c:
2731 Use an idle callback to execute the modest code in the application's own thread.
2732 Remove the helloworld example method.
2733 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2734 parsed, and the open-message method is not implemented because this is not yet implemented in
2736 * libmodest-dbus-client/libmodest-dbus-client.c:
2737 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2738 (libmodest_dbus_client_open_message):
2739 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2741 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2742 body without crashing.
2744 * tests/dbus_api/Makefile.am:
2745 * tests/dbus_api/test_mail_to.c:
2746 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2748 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2750 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2751 Added file to fix the build. Sorry.
2753 * src/dbus_api/Makefile.am:
2754 * src/dbus_api/modest-dbus-api.h:
2755 * src/dbus_api/modest-dbus-callbacks.h:
2756 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2757 (modest_dbus_req_handler):
2758 Put constants in a separate header so it can be reused by the
2759 client library, without duplication
2761 * libmodest-dbus-client/Makefile.am:
2762 * libmodest-dbus-client/libmodest-dbus-client.c:
2763 (libmodest_dbus_client_call_helloworld),
2764 (libmodfest_dbus_client_send_mail),
2765 (libmodfest_dbus_client_mailto),
2766 (libmodfest_dbus_client_open_message):
2767 * libmodest-dbus-client/libmodest-dbus-client.h:
2768 (Partly) Implement a send_mail D-Bus method.
2770 * tests/dbus_api/Makefile.am:
2771 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2772 the send_email D-Bus method.
2774 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2778 * libmodest-dbus-client/Makefile.am:
2779 * libmodest-dbus-client/libmodest-dbus-client.c:
2780 * libmodest-dbus-client/libmodest-dbus-client.h:
2781 * tests/dbus_api/Makefile.am:
2782 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2783 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2785 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/easysetup/modest-easysetup-wizard.c:
2788 (create_page_account_details):
2789 * src/maemo/modest-account-settings-dialog.c:
2790 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2791 widgets, because this might not be the default in future versions of the Maemo GTK+.
2792 However, I can not not get capitalization to work even in a simple test case.
2794 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/easysetup/modest-easysetup-wizard.c:
2797 (create_page_custom_incoming), (create_page_custom_outgoing):
2798 * src/maemo/modest-account-settings-dialog.c:
2799 (create_page_account_details), (create_page_incoming),
2800 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2801 instead of using gtk_check_button_with_label(), so they are aligned like the other
2802 widgets, as per the UI spec.
2804 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2806 * src/maemo/easysetup/modest-easysetup-wizard.c:
2807 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2808 * src/widgets/modest-validating-entry.c:
2809 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2810 Modest prefix instead of an EasySetup prefix.
2812 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2814 * src/widgets/modest-validating-entry.h:
2815 * src/widgets/modest-validating-entry.c: (on_insert_text),
2816 Added easysetup_validating_entry_set_max_func(), used to set a callback
2817 to call when the max number of characters is reached. GtkEntry has a max-length
2818 already but is silent about it.
2820 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2821 (create_page_account_details), (create_page_user_details),
2823 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2824 (create_page_account_details), (create_page_user_details),
2825 (create_page_outgoing):
2826 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2827 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2828 the UI spec, when the user tries to enter more than the max number of characters.
2830 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2832 * src/maemo/easysetup/modest-easysetup-wizard.c:
2833 (create_page_user_details), (create_page_custom_incoming),
2834 (create_page_custom_outgoing):
2835 * src/maemo/modest-account-settings-dialog.c:
2836 (create_page_user_details), (create_page_incoming),
2837 (create_page_outgoing):
2838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2839 (modest_connection_specific_smtp_edit_window_init):
2840 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2841 not appropriate. Bad Maemo-specific defaults!.
2843 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2845 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2846 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2847 (modest_signature_editor_dialog_set_settings):
2848 Disable the label and textview when the checkbox is disabled, and use the
2849 specified (UI spec) default signature text.
2851 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2853 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2854 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2856 * src/modest-defs.h:
2857 * src/modest-account-mgr-helpers.h:
2858 * src/modest-account-mgr-helpers.c:
2859 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2861 * src/maemo/Makefile.am:
2862 * src/maemo/modest-signature-editor-dialog.c:
2863 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2866 * src/maemo/modest-account-settings-dialog.h:
2867 * src/maemo/modest-account-settings-dialog.c:
2868 (modest_account_settings_dialog_finalize), (on_button_signature),
2869 (save_configuration): Use the new dialog when the Edit button is pressed, and
2870 save the changes if necessary, as per the UI spec.
2872 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2874 * src/maemo/Makefile.am:
2875 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2876 based on maemo-develoers email from Dirk.
2878 * src/maemo/easysetup/modest-easysetup-wizard.c:
2879 (create_page_welcome), (create_page_account_details),
2880 (create_page_user_details), (create_page_complete_easysetup),
2881 (create_page_custom_incoming), (create_page_custom_outgoing),
2882 (create_page_complete_custom),
2883 (modest_easysetup_wizard_dialog_init):
2884 * src/maemo/modest-account-settings-dialog.c:
2885 (create_page_account_details), (create_page_user_details),
2886 (create_page_incoming), (create_page_outgoing),
2887 (modest_account_settings_dialog_init):
2888 * src/maemo/modest-connection-specific-smtp-window.c:
2889 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2891 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2893 * src/maemo/easysetup/modest-easysetup-wizard.c:
2894 (create_page_account_details), (create_page_custom_outgoing),
2895 (create_page_complete_custom):
2896 * src/maemo/modest-account-settings-dialog.c:
2897 (create_page_user_details), (create_page_incoming),
2898 (create_page_outgoing):
2899 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2900 (modest_connection_specific_smtp_edit_window_init):
2901 Use the correct (UI spec) port min/max, and use horizontal separators,
2904 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2906 * src/maemo/easysetup/modest-easysetup-wizard.c:
2907 (set_default_custom_servernames):
2908 * src/maemo/modest-account-settings-dialog.c:
2909 (create_page_incoming), (on_combo_outgoing_security_changed),
2910 (on_combo_incoming_security_changed), (create_page_outgoing),
2911 (modest_account_settings_dialog_set_account_name),
2912 (save_configuration):
2913 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2914 (on_combo_security_changed),
2915 (modest_connection_specific_smtp_edit_window_init),
2916 (modest_connection_specific_smtp_edit_window_set_connection),
2917 (modest_connection_specific_smtp_edit_window_get_settings):
2918 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2921 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2924 * src/maemo/easysetup/modest-easysetup-wizard.c:
2925 (create_page_custom_outgoing), (create_page_complete_custom):
2926 * src/maemo/modest-account-settings-dialog.c:
2927 (create_page_user_details), (create_page_outgoing):
2928 * src/maemo/modest-account-view-window.c: (button_box_new):
2929 Use changed logical IDs as per the most recent UI spec:
2930 mcen_bd_emailsetup_edit -> mcen_bd_edit
2931 mcen_bd_emailsetup_delete -> mcen_bd_delete
2932 mcen_bd_emailsetup_close -> mcen_bd_close
2934 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2938 * src/dbus_api/Makefile.am:
2939 * src/dbus_api/modest-dbus-callbacks.c:
2940 * src/dbus_api/modest-dbus-callbacks.h:
2941 * src/maemo/modest-platform.c: (modest_platform_init):
2942 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2944 * tests/Makefile.am:
2945 * tests/dbus_api/Makefile.am:
2946 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2948 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2950 * src/maemo/modest-account-settings-dialog.c:
2951 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2952 Removed unnecessary includes.
2954 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2956 * src/maemo/easysetup/modest-easysetup-wizard.c:
2957 * src/maemo/modest-account-settings-dialog.c:
2958 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2959 * src/widgets/Makefile.am:
2960 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2961 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2962 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2963 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2964 * src/widgets/modest-secureauth-combo-box.c:
2965 * src/widgets/modest-secureauth-combo-box.h:
2966 * src/widgets/modest-serversecurity-combo-box.c:
2967 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2968 made the GObject names more consistent with the rest of the Modest code.
2970 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2972 * src/maemo/easysetup/Makefile.am:
2973 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2974 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2975 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2976 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2977 * src/maemo/easysetup/modest-easysetup-wizard.c:
2978 * src/maemo/easysetup/modest-validating-entry.c:
2979 * src/maemo/easysetup/modest-validating-entry.h:
2980 * src/maemo/modest-account-settings-dialog.c:
2981 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2982 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2983 widgets/ because they are used outside of easysetup too. After checking in,
2984 svn will allow me to rename them too.
2986 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2988 * src/gnome/modest-msg-edit-window.c:
2989 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2990 linker error, to fix the build on the GNOME platform.
2991 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2992 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2993 ifdefed out to avoid a warning.
2995 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2997 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2998 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2999 some alternative for GTK+ 2.6.
3001 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3003 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3005 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3006 specified for EmailAccountsDialog in UI spec.
3008 * src/maemo/easysetup/modest-easysetup-wizard.c:
3009 * src/maemo/easysetup/modest-easysetup-wizard.h:
3010 * src/maemo/modest-account-settings-dialog.c:
3011 * src/maemo/modest-account-settings-dialog.h:
3012 Reuse a member window widget for the connection-specific SMTP server accounts,
3013 so we can tell it to create/save the accounts only if we actually save changes.
3015 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3016 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3017 (modest_connection_specific_smtp_edit_window_get_settings):
3018 Return a struct instance for temporarily remembering the entered data.
3020 * src/maemo/modest-connection-specific-smtp-window.h:
3021 * src/maemo/modest-connection-specific-smtp-window.c:
3022 (modest_connection_specific_smtp_window_finalize),
3023 (modest_connection_specific_smtp_window_fill_with_connections),
3025 (modest_connection_specific_smtp_window_save_server_accounts),
3026 (update_model_server_names): Do not actually save data until asked,
3027 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3029 (on_selection_changed),
3030 (modest_connection_specific_smtp_window_init): Disable the edit
3031 button when nothing is selected.
3033 * src/modest-account-mgr-helpers.c:
3034 * src/modest-account-mgr-helpers.h:
3035 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3038 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3040 * src/modest-account-mgr-helpers.h:
3041 * src/modest-account-mgr-helpers.c:
3042 (modest_account_mgr_get_unused_account_name),
3043 (modest_account_mgr_get_unused_account_display_name): Added these
3044 utility functions, to avoid code duplication.
3046 * src/maemo/easysetup/modest-easysetup-wizard.c:
3047 (create_page_account_details), (create_account):
3048 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3049 (on_combo_security_changed),
3050 (modest_connection_specific_smtp_edit_window_init),
3051 (modest_connection_specific_smtp_edit_window_save_settings):
3052 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3053 * src/maemo/modest-connection-specific-smtp-window.c:
3054 (modest_connection_specific_smtp_window_finalize),
3055 (modest_connection_specific_smtp_window_fill_with_connections),
3056 (on_button_edit), (modest_connection_specific_smtp_window_init):
3057 * src/maemo/modest-connection-specific-smtp-window.h:
3058 Implementing saving of connection-specific server accounts.
3060 But I need to refactor this so we can save the data for each
3061 possible connection-specific account and only actually create the server accounts
3062 when the easysetup finished, or the OK button is pressed on the account settings
3065 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3067 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3068 (on_combo_security_changed):
3069 (modest_connection_specific_smtp_edit_window_init):
3070 Auto-fill the port number as in the account settings.
3072 (modest_connection_specific_smtp_edit_window_set_connection):
3073 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3074 * src/maemo/modest-connection-specific-smtp-window.c:
3075 (fill_with_connections), (on_button_edit),
3076 (modest_connection_specific_smtp_window_init):
3077 Turn the edit window into a dialog to simplify the code, and
3078 set a WM hint as in a GtkDialog, because only a popup can be on top of
3079 another window in Maemo, and popups usually have no WM decoration.
3081 * src/modest-defs.h:
3082 * src/modest-account-mgr-helpers.c:
3083 (modest_account_mgr_set_connection_specific_smtp),
3084 (modest_account_mgr_remove_connection_specific_smtp),
3085 (modest_account_mgr_get_connection_specific_smtp):
3086 * src/modest-account-mgr-helpers.h: Some functions to write the
3087 connection-specific SMTP server information. Not yet used.
3090 * src/widgets/modest-folder-view.c: (text_cell_data):
3091 Fix a warning about an uninitialized variable.
3092 (on_configuration_key_changed): Put an #ifdef around the use
3093 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3095 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3097 * src/maemo/modest-account-settings-dialog.h:
3098 * src/maemo/modest-account-settings-dialog.c:
3099 Added connect_for_modified() utility function to mark the new modified boolean.
3101 (create_page_account_details), (create_page_user_details),
3102 (create_page_incoming), (create_page_outgoing), (on_response),
3103 (modest_account_settings_dialog_init),
3104 (modest_account_settings_dialog_set_account_name):
3105 Only warn about unsaved changes when there are actually unsaved changes.
3107 * src/modest-account-mgr-helpers.c:
3108 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3109 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3110 to get the data from there in future.
3112 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3114 * src/modest-defs.h:
3116 * src/modest-account-mgr-helpers.h:
3117 * src/modest-account-mgr-helpers.c:
3118 Store the security account setting in a single conf key instead of using
3119 the options list, so that the list is left for just the to-be-removed camel hack,
3120 and because gconf_client_set_list() is failing for some reason.
3122 * src/modest-account-mgr.c:
3123 (modest_account_mgr_add_server_account):
3124 * src/maemo/modest-account-settings-dialog.c:
3125 (modest_account_settings_dialog_set_account_name),
3126 (save_configuration): Use the renamed functions.
3129 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3131 * src/widgets/Makefile.am:
3132 * src/widgets/modest-limit-retrieve-combo-box.c:
3133 * src/widgets/modest-limit-retrieve-combo-box.h:
3134 * src/widgets/modest-retrieve-combo-box.c:
3135 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3136 the account settings dialog.
3138 * src/modest-defs.h:
3139 * src/modest-account-mgr-helpers.h:
3140 * src/modest-account-mgr-helpers.c:
3141 (modest_server_account_get_option_secure_auth),
3142 (modest_server_account_set_option_secure_auth):
3143 * src/modest-account-mgr.c:
3144 (modest_account_mgr_add_server_account):
3145 Use the existing AUTH_MECH conf key for the secure-auth setting,
3146 instead of putting it in the list options, because this was actually used already.
3148 * src/maemo/modest-account-settings-dialog.c:
3149 (create_page_account_details),
3150 (modest_account_settings_dialog_set_account_name),
3151 (save_configuration):
3152 * src/maemo/modest-account-settings-dialog.h:
3153 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3154 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3156 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3158 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3159 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3160 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3162 * src/modest-defs.h:
3163 * src/maemo/modest-account-settings-dialog.c:
3164 (create_page_incoming), (on_combo_outgoing_security_changed),
3165 (on_combo_incoming_security_changed), (create_page_outgoing),
3166 (modest_account_settings_dialog_set_account_name),
3167 (save_configuration): Load/Save the port number, and change it when the
3168 security combo changes, to suitable defaults.
3170 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3172 * src/modest-account-mgr.c:
3173 (modest_account_mgr_add_server_account): Set the security and secure-auth
3174 options, and add a comment saying that the other camel-specific options should be
3177 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3179 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3181 * src/modest-tny-account-store.c: (account_list_free),
3182 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3183 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3186 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3188 * src/modest-protocol-info.c:
3189 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3190 is required by our UI spec. Maybe something in our implementation will use this eventually.
3191 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3192 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3193 instead of the previous 0 placeholder.
3195 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3196 secure-auth settings.
3197 * src/modest-account-mgr-helpers.h:
3198 * src/modest-account-mgr-helpers.c:
3199 (modest_server_account_data_get_option_secure_auth),
3200 (modest_server_account_set_option_secure_auth),
3201 (modest_server_account_data_get_option_security),
3202 (modest_server_account_set_option_security): Added this API for getting and setting the security
3203 and secure-auth settings.
3205 * src/maemo/modest-account-settings-dialog.h:
3206 * src/maemo/modest-account-settings-dialog.c:
3207 (modest_account_settings_dialog_finalize), (check_data),
3208 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3209 about changing titles.
3210 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3211 (save_configuration): Save the security and secure-auth settings.
3213 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3214 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3216 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3218 * src/modest-defs.h:
3219 * src/modest-account-mgr.c:
3220 (modest_account_mgr_add_server_account):
3221 Added and used defines for the options key and value pair strings,
3222 that are used so far, though they do not seem to correspond to anything in our
3223 UI specs or ModestProtocol enum.
3225 * src/modest-account-mgr-helpers.h:
3226 * src/modest-account-mgr-helpers.c:
3227 (compare_option_strings_for_name),
3228 (modest_server_account_data_get_option_value),
3229 (modest_server_account_data_get_option_bool),
3230 (modest_account_mgr_get_server_account_option):
3231 Added helper functions for parsing the options GSList.
3233 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3235 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3236 display name is based on the supplied account name.
3237 * src/modest-account-mgr.c:
3238 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3239 with an inefficient, but good-enough, implementation.
3241 * src/maemo/easysetup/modest-easysetup-wizard.c:
3242 (create_page_account_details), (on_before_next), (create_account):
3243 Check for existing display names rather than (non-user-visible) account names, and just
3244 create and set a unique account name at the end.
3246 * src/maemo/modest-account-settings-dialog.c:
3247 (modest_account_settings_dialog_init),
3248 (modest_account_settings_dialog_set_account_name),
3249 (create_page_incoming): Show the display name, instead of the account name.
3250 (on_response): Do some (not all) extra checks, as in the UI spec.
3251 (save_configuration): Save the display name if it was changed.
3253 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3255 * po/en_GB.po: Added needed logical ID and translation.
3256 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3257 (init_view): Made the is-default column clicking work.
3259 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3262 * src/maemo/easysetup/Makefile.am:
3263 * src/maemo/easysetup/modest-easysetup-wizard.c:
3264 (modest_easysetup_wizard_dialog_init):
3265 * src/maemo/easysetup/provider-data-test.keyfile:
3266 * src/maemo/easysetup/provider-data.keyfile:
3267 Moved the provider data file to the new modest-providers-data package and used it from there.
3269 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3271 * src/modest-local-folder-info.c:
3272 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3273 N_() was already used on the static strings, but this just marks it for translation without
3274 using the translation.
3276 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3278 * src/maemo/modest-account-settings-dialog.c:
3279 (create_page_incoming),
3280 (modest_account_settings_dialog_set_account_name):
3281 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3282 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3283 I will do this if nobody else gets there first.
3285 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3287 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3288 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3289 save the security stuff.
3291 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3294 Set the email address and user fullname, which I now see must be
3297 * src/maemo/modest-account-settings-dialog.h:
3298 * src/maemo/modest-account-settings-dialog.c:
3300 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3301 leave-on-server and authentication.
3302 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3305 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/modest-account-settings-dialog.c:
3309 * src/maemo/modest-account-settings-dialog.h:
3310 Most (but not all) of the widgets are now present as specified by the UI spec.
3311 No changes are yet saved, and some details are not properly shown yet.
3313 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3315 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3317 * src/maemo/Makefile.am:
3318 * src/maemo/modest-account-settings-dialog.c:
3319 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3320 an existing account. Doesn't do much yet.
3322 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3323 Open the accounts settings dialog when Edit is clicked.
3325 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3327 * src/maemo/easysetup/Makefile.am:
3328 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3330 * src/maemo/easysetup/modest-easysetup-wizard.c:
3331 (modest_easysetup_wizard_dialog_init):
3332 Try to get the source directory from the build system,
3333 instead of hard-coding "./" into the source code, when opening our local
3334 copies of the configuration files.
3335 But this still fails when opening the wizard from the Accounts window,
3336 maybe because the working directory seems to change at runtime.
3337 So the wizard will fail the second time unless you copy the files into their
3338 proper locations - see the stdout warnings for the paths.
3340 (create_page_account_details),(on_before_next):
3341 Check for existing non-server accounts instead of server accounts,
3342 so the default account name is useful again, and to prevent trying to
3345 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3346 Show the wizard when New is clicked.
3348 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3349 (init_view): Show the column headers, and show the columns that are
3350 specified in the UI specs. However, something in Maemo's GTK+ prevents
3351 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3352 change the default account. This is despite unsetting the special properties.
3354 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3356 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3357 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3358 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3359 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3360 to make that clearer.
3361 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3363 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3365 * src/maemo/modest-account-view-window.c:
3366 (modest_account_view_window_init),
3367 (modest_account_view_window_new):
3368 Use the same buttons as specified in the
3369 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3370 the existing widgets, which never had a chance of working.
3371 Put the ModestAccountView treeview in a scrolled window.
3372 Do not repeat the initialization in both _init() and _new().
3374 * src/widgets/modest-account-view.c: (update_account_view):
3375 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3376 this widget and window shows no accounts.
3378 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3380 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3382 * src/maemo/easysetup/modest-easysetup-wizard.c:
3383 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3384 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3385 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3388 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3389 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3390 accounts exist yet, as in the UI spec.
3392 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3394 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3396 * src/maemo/Makefile.am:
3397 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3398 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3399 New window for editing connection-specific smtp details.
3400 Not fully implemented.
3402 * src/maemo/modest-connection-specific-smtp-window.c:
3403 (modest_connection_specific_smtp_window_finalize) :
3404 unref the tree model.
3405 (on_button_edit): Show the edit window.
3407 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3409 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3412 * src/maemo/Makefile.am:
3413 * src/maemo/modest-connection-specific-smtp-window.c:
3414 * src/maemo/modest-connection-specific-smtp-window.h:
3415 New window for showing the list of connections, for connection-specific
3416 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3417 * src/maemo/easysetup/modest-easysetup-wizard.c:
3418 (create_page_custom_outgoing): Show the new window when the button is clicked.
3420 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3422 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3423 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3424 * src/maemo/modest-msg-edit-window.c:
3425 (modest_msg_edit_window_insert_image):
3426 * src/modest-conf.c: (modest_conf_key_escape):
3427 * src/modest-mail-operation.c:
3428 (modest_mail_operation_send_new_mail):
3429 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3430 (modest_ui_actions_on_new_account):
3431 * src/widgets/modest-attachment-view.c: (update_filename_request):
3432 * src/widgets/modest-mail-header-view.c:
3433 Corrected warnings that were breaking the build, by commenting out unused variables,
3434 and a function, and by including a header.
3436 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3438 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3439 so we can #ifdef around platform-specific code when necessary.
3440 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3441 to allow this to build for the GNOME platform too.
3443 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3445 * src/maemo/easysetup/modest-easysetup-wizard.c:
3446 Added util_increment_name() and used it in create_page_account_details()
3447 to make sure that the default account name is always a new name.
3449 (modest_easysetup_wizard_dialog_init),
3450 (set_default_custom_servernames): Some minor memory management fixes.
3452 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3456 * src/modest-runtime.c: (init_i18n): Restored the translation
3457 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3458 are defined in config.h, and the translations are installed.
3460 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3461 is defined for translation.
3463 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3465 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3467 * src/maemo/easysetup/modest-easysetup-wizard.c:
3468 (modest_easysetup_wizard_dialog_init):
3469 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3470 Use realistic paths (though they should use $prefix generically) to the
3471 mcc_mapping and provider-data.keyfile files which might work when they
3472 are installed by the future version of the operator-wizard package,
3473 and then fallback to paths in our source code, with an explanatory
3476 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3480 * src/maemo/Makefile.am:
3481 * src/maemo/easysetup/: Added files from the previously-exernal
3482 osso-modest-easysetup.
3483 * src/maemo/modest-main-window-ui.h:
3484 * src/modest-ui-actions.c:
3485 * src/modest-ui-actions.h:
3486 Added modest_ui_actions_on_new_account() as a signal handler for the
3487 New Account menu item. It shows the easysetup wizard.
3488 * po/en_GB.po: Added additional needed logical IDs and translations.