1 2007-06-11 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
4 Free the changed_conf_keys string items. They are already freed in the
5 idle handler if that runs first.
7 2007-06-11 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-ui-actions.c:
10 (modest_ui_actions_on_password_requested): Check that the server name
11 is not NULL, because I just saw a password dialog with (null) as the
14 * src/modest-tny-folder.[h|c]: Added
15 modest_tny_folder_is_memory_card_folder().
16 * src/modest-ui-dimming-rules.c:
17 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
18 menu item for memory cards, as per the UI spec (section 7.4). This should
19 fix projects.maemo.org bug NB#59297.
21 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
23 * src/maemo/modest-main-window.c: (sync_accounts_cb):
24 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
25 is another problem with the code, see Murray's comment at line 772)
27 2007-06-08 Murray Cumming <murrayc@murrayc.com>
29 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
30 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
31 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
32 (load_from_file), (easysetup_country_combo_box_init),
33 (easysetup_country_combo_box_get_active_country_ids),
34 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
35 instead of just one ID, to avoid duplicate country names in the UI.
37 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
38 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
39 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
40 a single ID, avoiding duplicate providers.
41 * src/maemo/easysetup/modest-easysetup-wizard.c:
42 (on_combo_account_country): Adapt to use a list.
44 2007-06-08 Murray Cumming <murrayc@murrayc.com>
46 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
47 keys changed in the last X seconds.
49 * src/modest-account-mgr.h:
50 * src/modest-account-mgr.c: (on_timeout_notify_changes),
51 (on_key_change), (modest_account_mgr_class_init),
52 (modest_account_mgr_init), (modest_account_mgr_finalize):
53 As the keys are changed, save them in a GSList* and signal that GSList*
54 further every X seconds, to batch changes, to allow us to do just one
55 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
56 bug NB#56941 and other (UI-blocking) delays when changing account settings.
58 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
59 changed signal signature.
61 * src/modest-conf.c: (modest_conf_set_list),
62 (modest_conf_on_change): Reenable notification.
64 (modest_conf_maemo_fake_on_change): Comment out the hack that
65 notified immediately instead of asynchronously.
67 * src/widgets/modest-account-view.h:
68 * src/widgets/modest-account-view.c:
69 (update_account_view): Select the previously-selected account ID,
70 if possible. This fixes projects.maemo.org bug NB#56933.
72 (on_account_changed), (on_account_removed),
73 (modest_account_view_select_account):
75 Remove the block/unblock functions
76 because they were not useful.
78 * src/maemo/modest-account-view-window.c:
79 (on_delete_button_clicked), (on_edit_button_clicked),
80 (on_new_button_clicked): Remove the use of the non-working block/unblock.
82 2007-06-08 Murray Cumming <murrayc@murrayc.com>
84 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
85 Improve the error dialog to show Incorrect Account Settings, which seems
86 clearer, and say that the internal error message (to be removed from the
87 dialog later) is often misleading.
88 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
90 * src/modest-tny-account.c:
91 (modest_tny_account_new_from_server_account): Uncomment the printf of the
92 URL because this is so useful for debugging on the device.
94 * src/widgets/modest-serversecurity-combo-box.c:
95 (modest_serversecurity_combo_box_fill): Correct a logical ID.
97 2007-06-08 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-mail-operation.c:
100 (modest_mail_operation_send_new_mail):
101 Added a comment about a nasty but apparently harmless message. Details
102 added to the wiki g_warnings() page.
104 2007-06-08 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
107 (modest_tny_send_queue_class_init):
108 Do not use the priv struct because it is empty, to avoid g_warnings
109 about a non-existant priv struct.
111 * src/modest-tny-account-store.c:
112 (modest_tny_account_store_get_server_account),
113 (modest_tny_account_store_get_transport_account_for_open_connection
114 ): Do not try to get transport server accounts for local folders,
115 because they don't have any. This avoids a g_warning().
117 * src/maemo/modest-main-window.c:
118 (modest_main_window_notify_send_receive_initied),
119 (on_configuration_key_changed):
120 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
122 * src/modest-mail-operation.c:
123 (modest_mail_operation_update_account):
124 * src/modest-tny-account-store.h:
125 * src/modest-tny-account.c:
126 (modest_tny_account_get_special_folder),
127 (modest_tny_account_new_for_local_folders),
128 (modest_tny_account_new_for_per_account_local_outbox_folder):
129 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
130 * src/modest-tny-local-folders-account.c:
131 (add_account_folders_to_merged_folder):
132 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
133 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
134 (modest_ui_actions_on_send):
135 * src/widgets/modest-folder-view.c: (update_model):
136 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
137 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
138 modest_tny_account_store_get_tny_account_by_account() to
139 modest_tny_account_store_get_server_account() to make the code clearer.
141 2007-06-07 Marcus Bauer <marcusb@openismus.com>
143 * src/dbus_api/modest-dbus-api.h:
144 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
145 * src/maemo/modest-msg-edit-window.c:
146 (modest_msg_edit_window_attach_file_noninteractive):
147 added g_warning in case the file to be attached does not exist
148 * tests/dbus_api/test_compose_mail.c: (main):
149 removed obsolete comment, added generic files as test case
151 2007-06-07 Murray Cumming <murrayc@murrayc.com>
153 * src/modest-tny-account-store.c: (get_server_accounts):
154 Create the local folders account only once, not once for each outbox, and
155 not only when there are some outboxes.
157 2007-06-07 Murray Cumming <murrayc@murrayc.com>
159 * src/widgets/modest-folder-view.c: (update_model): Comment out some
160 code that is causing a crash at startup. Sergio says that he is fixing this.
162 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
164 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
165 * src/maemo/modest-account-settings-dialog.c:
166 (create_page_outgoing),
167 (modest_account_settings_dialog_set_account_name),
168 (save_configuration):
169 - Fixed handling of the "Use secure authentication" toggle to comply with
170 the ui specification. See also projects.maemo.org bug NB#58400
172 - Restore the Secure connection setting combo correctly when loading
175 * src/maemo/modest-maemo-utils.c:
176 (on_camel_account_get_supported_secure_authentication),
177 (modest_maemo_utils_get_supported_secure_authentication_methods):
178 Fixed a crasher if operation is canceled
180 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
181 (modest_protocol_info_auth_is_secure):
182 * src/modest-protocol-info.h:
184 Added two new methods to determine if a protocol/auth method is secure/encrypted in
185 the sense of the "Use secure authentication" toggle.
187 2007-06-07 Murray Cumming <murrayc@murrayc.com>
189 * src/modest-tny-account-store.h:
190 * src/modest-tny-account-store.c:
191 Added modest_tny_account_store_get_local_folders_account().
193 * src/modest-tny-folder.h:
194 * src/modest-tny-folder.c:
195 (modest_tny_folder_get_account):
196 Added this replacement for tny_folder_get_account() which returns
197 the local-folders account for TnyMergeFolders, to avoid the
198 warning about the unimplemented get_account_func() vfunc().
200 (modest_tny_folder_get_rules),
201 * src/modest-ui-actions.c:
202 (modest_ui_actions_on_folder_selection_changed):
203 * src/modest-mail-operation.c:
204 (modest_mail_operation_remove_folder),
205 (modest_mail_operation_xfer_folder),
206 (modest_mail_operation_rename_folder),
207 (modest_mail_operation_get_msg),
208 (modest_mail_operation_get_msgs_full),
209 (modest_mail_operation_remove_msg),
210 (modest_mail_operation_xfer_msgs),
211 (modest_mail_operation_refresh_folder):
212 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
214 2007-06-07 Murray Cumming <murrayc@murrayc.com>
216 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
217 (modest_server_account_set_security):
218 * src/modest-defs.h: Add comments explaining that our
219 UI spec means TLS when it says Normal, so these do not look like errors.
221 * src/modest-tny-account.c:
222 (modest_tny_account_new_from_server_account): Use the new tinymail
223 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
224 for TLS. This should fix projects.maemo.org bug NB#58460.
226 2007-06-06 Murray Cumming <murrayc@murrayc.com>
228 * src/maemo/easysetup/modest-easysetup-wizard.c:
229 (create_account): Correct the position of the gconf sanity check warning.
230 (on_button_edit_advanced_settings): Show the dialog immediately, instead
231 of using the g_idle_add() hack, because this does not seem to be necessary
232 on osso 1.1. It might even work on Maemo Bora if the problems were actually
233 caused by something other than maemo's gconf.
234 This fixes projects.maemo.org bug #59022.
236 2007-06-06 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-account-mgr-helpers.c:
239 (modest_account_mgr_get_default_account): Do not check that the account
240 exists if there is no default account (NULL), to fix a runtime warning.
242 2007-06-06 Murray Cumming <murrayc@murrayc.com>
244 * src/widgets/modest-folder-view.c: (update_model):
245 Do not unref the treemodel before we have finished with it.
246 This prevents a valgrind warning and an occasional crash at startup.
248 2007-06-06 Marcus Bauer <marcusb@openismus.com>
250 * libmodest-dbus-client/libmodest-dbus-client.h:
251 added libmodest_dbus_client_compose_mail()
252 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
254 added functions needed for SendAsMail() functionality
255 * src/maemo/modest-msg-edit-window.c:
256 (modest_msg_edit_window_attach_file_noninteractive):
257 non interactively attaching files to message edit window
258 * src/widgets/modest-msg-edit-window.h:
259 * tests/dbus_api/Makefile.am:
260 added test_compose_mail.c
261 * tests/dbus_api/test_compose_mail.c: (main):
263 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
265 * src/modest-account-view.c:
266 Fixed bug projects.maemo.org bug NB#59307
268 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
270 * src/maemo/easysetup/modest-easysetup-wizard.c:
271 (get_serverport_incoming), (on_before_next), (create_account):
272 * src/maemo/modest-account-settings-dialog.c:
273 (modest_account_settings_dialog_set_account_name):
274 * src/maemo/modest-maemo-utils.c:
275 (on_camel_account_get_supported_secure_authentication_status),
276 (on_camel_account_get_supported_secure_authentication),
277 (on_secure_auth_cancel),
278 (modest_maemo_utils_get_supported_secure_authentication_methods):
280 Implemented security authentication for settings and easysetup.
282 2007-06-05 Murray Cumming <murrayc@murrayc.com>
284 * src/maemo/modest-main-window.c: (create_details_widget):
285 Show the total size for memory card accounts too, instead of showing
286 the name again. Fixes bug projects.maemo.org bug NB#59307.
288 2007-06-05 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-tny-simple-folder-store.c:
292 * src/modest-tny-simple-folder-store.h: Removed.
294 * src/modest-tny-local-folders-account.h
295 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
296 for the local-folders maildir, with an extra TnyMergedFolder containing
297 the folders of the per-account outbox store accounts.
298 * src/modest-tny-account-store.c: (get_server_accounts):
299 Add the outboxes to the special local folders account after creating it.
301 * src/modest-tny-account.c:
302 (modest_tny_account_new_for_local_folders): Create the derived
303 account when creating the main local-folders account.
305 * src/maemo/modest-main-window.c: (create_details_widget),
306 (modest_main_window_set_contents_style):
307 Adapted to the use of the derived account instead of the folder store.
309 * src/modest-ui-actions.c:
310 (modest_ui_actions_on_folder_selection_changed):
311 * src/modest-ui-dimming-rules.c:
312 (modest_ui_dimming_rules_on_new_folder):
313 * src/widgets/modest-folder-view.c: (text_cell_data),
314 (icon_cell_data), (filter_row), (update_model),
315 (get_cmp_rows_type_pos):
318 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
319 Do not get the priv struct, because no priv struct has been set,
320 to avoid a runtime warning.
322 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
323 #ifelse with #else, to fix a warning, to fix the build.
326 2007-06-05 Christian Kellner <ckellner@openismus.com>
328 * libmodest-dbus-client/libmodest-dbus-client.c:
329 Fix small typo in doc (why do you always see them
330 AFTER committing stuff?)
333 2007-06-05 Christian Kellner <ckellner@openismus.com>
335 * libmodest-dbus-client/libmodest-dbus-client.c:
336 (libmodest_dbus_client_search):
337 Initialize hit list with NULL. Also set folder list
338 to "" if NULL was supplied.
341 2007-06-03 Christian Kellner <ckellner@openismus.com>
343 * libmodest-dbus-client/libmodest-dbus-client.c:
344 (modest_search_hit_list_free):
345 Make it save to call it with NULL.
347 * src/dbus_api/modest-dbus-callbacks.c:
348 * src/modest-search.c:
349 Return full ModestSearchHits as the search result list not TnyHeader
350 since can't be around withouth the correspoding TnyFolder.
352 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
354 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
355 Added currently commented code to check for secure auth
357 * src/maemo/modest-account-settings-dialog.c: (on_response),
358 (save_configuration), (show_ok):
359 Fixed projects.maemo.org bugs NB #59248 and #59251
361 * src/maemo/modest-maemo-utils.c:
362 (on_camel_account_get_supported_secure_authentication_status),
363 (on_camel_account_get_supported_secure_authentication),
364 (modest_maemo_utils_get_supported_secure_authentication_methods):
365 * src/maemo/modest-maemo-utils.h:
366 Moved get_supported_secure_authentication() method here to be able
367 to use it from easysetup wizard.
369 * src/modest-pair.c: (on_pair_compare_as_string):
370 Should compare string with first part of pair and not
371 strcmp pairs which will crash.
373 * src/modest-protocol-info.c:
374 (modest_protocol_info_protocol_is_store):
375 * src/modest-protocol-info.h:
376 Added modest_protocol_info_get_auth_protocol_name()
378 2007-06-03 Armin Burgmeier <armin@openismus.com>
380 * src/modest-mail-operation.c:
381 (modest_mail_operation_get_msgs_full): Set priv->account also when
382 only retrieving a single message. This avoids a crash when canceling
385 (modest_mail_operation_notify_end): Do not explicitely remove the
386 operation from the queue but only emit the progress_changed signal.
387 The queue itself listens to that signal to remove the operation when
388 it is finished. This reduces coupling and removes a potential deadlock
389 when modest_mail_operation_notify_end() is called from the queue
390 itself. If that is a problem performance-wise, I would suggest to
391 implement a status-changed signal or something.
393 * src/modest-mail-operation-queue.c: Make sure to never call a
394 function from another file while the queue is locked. This (hopefully)
395 fixes another deadlock when exiting the application while retrieving
398 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
400 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
401 Fixed build if libogs is not available
403 2007-06-03 Christian Kellner <ckellner@openismus.com>
405 * libmodest-dbus-client/libmodest-dbus-client.h:
406 * libmodest-dbus-client/libmodest-dbus-client.c:
407 (libmodest_dbus_client_delete_message):
408 Implement deletion of messages (Client side).
410 (modest_search_hit_free),
411 (modest_search_hit_list_free):
412 Utility functions to free the result hits.
414 * src/dbus_api/modest-dbus-api.h:
415 * src/dbus_api/modest-dbus-callbacks.c:
417 (modest_dbus_req_handler):
418 Implement deletion of messages (Server side).
420 * tests/dbus_api/test_search.c: (main):
423 * tests/dbus_api/Makefile.am:
424 * tests/dbus_api/test_delete_message:
425 Add little test for the message deletion logic
427 2007-06-03 Armin Burgmeier <armin@openismus.com>
429 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
430 when the operation queue was not empty. projects.maemo.org bug
433 2007-06-03 Armin Burgmeier <armin@openismus.com>
435 * src/widgets/modest-account-view.c
436 (on_account_default_toggled): Toggle default account column
437 explicitely instead of waiting for gconf notification (which is
438 currently ignored). This should fix projects.maemo.org bug NB#56910
439 for now. It should probably be removed when gconf notifications are
442 2007-06-03 Christian Kellner <ckellner@openismus.com>
444 * libmodest-dbus-client/libmodest-dbus-client.c:
445 Removed debugging spew.
447 * src/dbus_api/modest-dbus-callbacks.c:
448 Added debugging info.
450 * src/modest-search.c:
451 (modest_search_all_accounts):
452 Use tny_account_store_get_accounts () on the account store
453 to get all accounts which is the way to get all accounts.
455 * tests/dbus_api/test_search.c: (main):
456 Make it possible to supply the search term on the command line.
458 2007-06-03 Christian Kellner <ckellner@openismus.com>
460 * libmodest-dbus-client/libmodest-dbus-client.c:
461 * libmodest-dbus-client/libmodest-dbus-client.h:
462 Implement searching for mesages over raw dbus. (Client side)
464 * src/dbus_api/Makefile.am:
465 * src/dbus_api/modest-dbus-api.h:
466 * src/dbus_api/modest-dbus-callbacks.c:
467 * src/dbus_api/modest-dbus-callbacks.h:
468 Search framework (Server side). Also implement on_idle_open_message().
470 * src/maemo/modest-platform.c: (modest_platform_init):
471 Prepare for raw dbus/osso rpc interaction.
473 * src/modest-search.h:
474 Changed minsize from unspecific guint to guint32.
476 * src/modest-search.c:
478 Added strange hack which magically made tnymail work.
480 (modest_search_folder),
481 (modest_search_account),
482 (modest_search_all_accounts):
483 Implement helper functions to search all accounts, specific account
486 * tests/dbus_api/Makefile.am:
487 * tests/dbus_api/test_open_message.c:
488 Read url to open from commandline.
490 * tests/dbus_api/test_search.c:
491 Implement small test for dbus search stuff
493 2007-06-02 Armin Burgmeier <armin@openismus.com>
495 * src/maemo/modest-account-settings-dialog.c: Changed window title to
496 include account type and account title. This fixes projects.maemo.org
499 * src/maemo/modest-account-view-window.c: Set a title for the window.
501 2007-06-02 Armin Burgmeier <armin@openismus.com>
503 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
504 incoming and outgoing server name based on email address and server
505 types as long as the names have not been edited manually. This fixes
506 projects.maemo.org bug NB#58671.
508 2007-06-02 Armin Burgmeier <armin@openismus.com>
510 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
511 server type cannot be changed in future to the incoming details page
512 when creating an account. This fixes projects.maemo.org bug NB#59029.
514 2007-06-02 Armin Burgmeier <armin@openismus.com>
516 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
517 and assigned max width chars so that they wrap instead of being
518 truncated. Fixes projects.maemo.org bug NB#56126.
520 2007-06-02 Armin Burgmeier <armin@openismus.com>
522 * src/maemo/modest-connection-specific-smtp-window.c: Add an
523 introductory note to the connection specific smtp servers dialog, as
524 section 8.12 of the email UI specification requires. This fixes
525 projects.maemo.org bug NB#59212.
527 2007-06-01 Murray Cumming <murrayc@murrayc.com>
529 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
530 Check for running mail operations, and offer to cancel them, as per the UI
531 spec. This fixes projects.maemo.org bug NB#59041 .
532 However, I suspect that tinymail may still use the network connection
533 in ways that we cannot detect or cancel. But it should at least adapt to
536 2007-06-01 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-tny-account-store.c: (recreate_all_accounts),
539 (get_cached_accounts), (get_server_accounts): Do more sensible
540 ref-counting of the temporarily-cached outbox accounts list. This seems
541 to fix a crash when entering the password when the password was wrong.
543 2007-06-01 Murray Cumming <murrayc@murrayc.com>
545 * src/gnome/modest-main-window.c: (connect_signals):
546 * src/modest-tny-account-store.c: (get_password),
547 (modest_tny_account_store_alert): Added comments and clues and
548 commented-out code about how we currently fail to deal with connection
549 errors and wrong passwords, and how we should.
551 2007-06-01 Murray Cumming <murrayc@murrayc.com>
553 * src/widgets/modest-retrieve-combo-box.c:
554 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
555 This fixes projects.maemo.org bug NB#58472 .
557 2007-06-01 Murray Cumming <murrayc@murrayc.com>
559 * src/maemo/easysetup/modest-easysetup-wizard.c:
560 (create_page_complete_easysetup):
561 (create_page_complete_custom): Correct the last commit,
562 putting the correct sentences in the correct pages.
564 2007-06-01 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/easysetup/modest-easysetup-wizard.c:
567 (create_page_complete_custom): Show the second sentence of text
568 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
571 2007-06-01 Murray Cumming <murrayc@murrayc.com>
573 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
574 Set the leave-on-server conf key by default. This fixes
575 projects.maemo.org bug NB#59258 .
577 2007-06-01 Murray Cumming <murrayc@murrayc.com>
579 * src/maemo/modest-account-view-window.c:
580 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
581 logical ID for the confirmation messages. Fixed projects.maemo.org bug
584 2007-06-01 Murray Cumming <murrayc@murrayc.com>
586 * src/maemo/easysetup/modest-easysetup-wizard.c:
587 (create_caption_new_with_asterisk):
588 * src/maemo/modest-account-settings-dialog.c:
589 (create_caption_new_with_asterisk):
590 Uncomment the code to add the asterisk, because they are no longer in the
591 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
592 (update_incoming_server_title): Add an asterisk here too.
594 2007-06-01 Murray Cumming <murrayc@murrayc.com>
596 * src/maemo/modest-maemo-global-settings-dialog.c:
597 (current_connection): Check that we are even connected before trying to
598 get the current connection name, to prevent a warning.
600 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
601 Change the comments because tny_maemo_conic_device_connect() is now meant to
603 * src/modest-mail-operation.c:
604 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
605 make sure we have a connection and fail if we can't connect.
607 2007-05-31 Murray Cumming <murrayc@murrayc.com>
609 * src/maemo/modest-main-window.c:
610 (on_account_store_connecting_finished): Do not try to get the
611 connection ID if we are not really connected. I am surprised that
612 this signal handler is called when we are not connected.
614 2007-05-31 Murray Cumming <murrayc@murrayc.com>
616 * src/modest-error.h:
617 * src/modest-ui-actions.c:
618 (modest_ui_actions_get_msgs_full_error_handler):
619 Renamed an enum, added comments, added an enum
620 for retrieve-limit errors.
622 * src/modest-mail-operation.c: (foreach_add_item),
623 (internal_folder_observer_update), (update_account_thread),
624 (modest_mail_operation_get_msgs_full):
625 (modest_mail_operation_update_account),
626 Added comments about how this works, and some code that should
627 (but does not) check the retrieve-limit. See the TODO comment.
629 2007-05-31 Murray Cumming <murrayc@murrayc.com>
631 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
632 Initialize help_id to fix the build. Warnings are good.
634 2007-05-31 Murray Cumming <murrayc@murrayc.com>
636 * src/widgets/modest-hbox-cell-renderer.c:
637 (modest_hbox_cell_renderer_append):
638 * src/widgets/modest-vbox-cell-renderer.c:
639 (modest_vbox_cell_renderer_append):
640 Fix the last commit by doing an extra ref.
642 2007-05-31 Murray Cumming <murrayc@murrayc.com>
644 * src/widgets/modest-hbox-cell-renderer.c:
645 (modest_hbox_cell_renderer_append):
646 * src/widgets/modest-vbox-cell-renderer.c:
647 (modest_vbox_cell_renderer_append):
648 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
649 to fix the build with Maemo Bora.
650 However, there seems to be a remaining crash, probably due to reference
653 2007-05-30 Murray Cumming <murrayc@murrayc.com>
655 * src/modest-tny-account.c:
656 (modest_tny_account_new_for_local_folders):
657 Use hildon_file_system_info_async_new() to get a better name for
658 the memory card account, setting it as the account name.
659 The timing seems to work, but this is probably
660 not the best place to do this. See the TODO comment.
661 * src/maemo/modest-main-window.c: (create_details_widget):
662 * src/widgets/modest-folder-view.c: (text_cell_data):
663 Use the tny account name instead of hardcoding a name.
665 2007-05-30 Christian Kellner <ckellner@openismus.com>
667 * src/modest-search.c: (modest_search):
668 Correctly set part_search_func even if we have already parsed
669 the query and thus a valid OgsTextSearcher object.
671 2007-05-30 Christian Kellner <ckellner@openismus.com>
674 Search and check for libogs.
677 Incooparte the ogs build env.
679 * src/modest-mime-part-search-stream.c:
680 * src/modest-mime-part-search-stream.h:
681 Removed since we do the real searching now in modest-search.c.
683 * src/modest-search.c:
684 * src/modest-search.h:
685 Implement support for ogs. We use that if available and requested
686 and fall back to modest_text_utils_utf8_strcmp (). The search logic
687 should now handle the corner case when the search term is spread
688 across multiple reads.
689 Also the logic in modest_search () was corrected to search all
690 requested fields until one is found.
692 2007-05-30 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
697 * src/modest-init.c: Made modest_init_local_folders() take a
698 path and be public so we can iniitialize maildir folders on
701 * src/modest-local-folder-info.h:
702 * src/modest-local-folder-info.c:
703 (modest_local_folder_info_get_maildir_path): Add a path parameter.
705 * src/modest-tny-account.c:
706 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
707 still means the standard local-folders path on the local volume.
709 * src/modest-tny-account-store.c:
710 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
711 signal so we can detect mount/unmount of the MMC1 card, and do an update of
712 all accounts when that happens.
713 (get_server_accounts): If the MMC1 card is mounted, create a store account for
714 this too, so it shows up in the treeview.
716 2007-05-28 Murray Cumming <murrayc@murrayc.com>
718 * src/maemo/modest-maemo-global-settings-dialog.c:
719 (current_connection):
720 * src/widgets/modest-global-settings-dialog.c:
721 (current_connection_default):
722 Use the enum values instead of 0, 1 and -1,
723 to make the code clearer.
725 * src/modest-account-mgr-helpers.c:
726 (modest_account_mgr_get_connection_specific_smtp): Make this code
729 * src/modest-runtime.h:
730 * src/modest-runtime.c:
731 Added modest_runtime_remove_all_send_queues().
732 * src/maemo/modest-main-window.c:
733 (on_account_store_connecting_finished): Recreate the send queues,
734 using the appropriate transport accounts for this new connection.
735 Some futher adapting might be needed if the old send queues are not
736 automatically stopped at this point.
738 * src/modest-tny-account-store.c: (get_server_accounts):
739 Create the connection-specific transport accounts, so that they can
740 be found later by their ID.
742 * src/modest-tny-account.h:
743 * src/modest-tny-account.c:
744 Added modest_tny_account_new_from_server_account_name().
745 modest_tny_account_new_from_server_account(): Do not create the
746 send queues here, because they will be
747 recreated anyway when the connection changes for the first time.
749 2007-05-28 Murray Cumming <murrayc@murrayc.com>
751 * src/modest-local-folder-info.h:
752 * src/modest-local-folder-info.c:
753 (modest_per_account_local_outbox_folder_info_get_maildir_path),
754 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
755 tbox_folder): Take a modest account name instead of a server TnyAccount,
756 so we can have per-modest-account rather than per-transport-account
758 We must make sure that we change or recreate the exisitng send queues
759 when the connection changes for connection-specific transport accounts.
761 * src/modest-tny-account-store.c:
762 (create_per_account_local_outbox_folders): Create outboxed per modest
763 account, not per transport account.
765 * src/modest-tny-account.h:
766 * src/modest-tny-account.c:
767 (modest_tny_account_get_special_folder): For outboxes, get the
768 parent modest account name. The account is ignored for other folders.
769 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
770 modest account name rather than a server TnyAccount.
772 2007-05-25 Murray Cumming <murrayc@murrayc.com>
774 * src/modest-tny-account.c:
775 (modest_tny_account_new_from_server_account):
776 Call modest_runtime_get_send_queue() immediately after creating transport
777 accounts, so that they start trying to send email from the outbox as soon
778 as possible at startup. This is probably what we want.
780 * src/modest-mail-operation.c: (update_account_thread):
781 * src/modest-runtime.c: (modest_runtime_get_send_queue):
782 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
783 * src/modest-tny-send-queue.h:
784 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
785 (modest_ui_actions_on_send):
786 Added comments about how sending works, though it needs some more work.
788 2007-05-25 Murray Cumming <murrayc@murrayc.com>
790 * src/modest-tny-account.c:
791 (modest_tny_account_get_special_folder): Add TODO because this fails when
793 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
794 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
795 Do not try to show this window when there is no active account. The UI
796 specs does not tell us what to do in this case.
798 2007-05-24 Murray Cumming <murrayc@murrayc.com>
802 * src/maemo/Makefile.am:
803 * src/widgets/Makefile.am: Some dist fixes.
805 2007-05-24 Murray Cumming <murrayc@murrayc.com>
807 * src/maemo/modest-connection-specific-smtp-window.c:
808 (on_button_edit): Make the code clearer, to prevent a double free.
810 2007-05-24 Murray Cumming <murrayc@murrayc.com>
812 * src/maemo/modest-account-settings-dialog.c:
813 (modest_account_settings_dialog_set_account_name),
814 Check the connection-specific smtp servers checkbox if there are any.
816 * src/maemo/modest-connection-specific-smtp-edit-window.c:
817 (modest_connection_specific_smtp_edit_window_init):
818 Start with a suitable port number.
820 * src/modest-account-mgr-helpers.h:
821 * src/modest-account-mgr-helpers.c: Added
822 modest_account_mgr_get_has_connection_specific_smtp().
824 (modest_account_mgr_set_connection_specific_smtp),
825 (modest_account_mgr_remove_connection_specific_smtp),
826 (modest_account_mgr_get_has_connection_specific_smtp),
827 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
828 connection-specific smtp server accounts in the account, rather than
829 the server account conf dir.
831 This fixes bug projects.maemo.org bug NB#58263 .
833 * src/modest-tny-account-store.c:
834 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
835 if there are no server accounts yet, to prevent an infinite loop when there
836 are no accounts. Document that one must be called before the other.
838 2007-05-24 Murray Cumming <murrayc@murrayc.com>
840 * src/modest-account-mgr-helpers.c:
841 (modest_account_mgr_get_default_account): Make sure that at least
842 one account is always the default, if there are any enabled accounts.
843 This is just a sanity check that shouldn't be necessary.
845 * src/modest-account-mgr-priv.c:
846 (_modest_account_mgr_account_from_key): Unescape the conf key to
847 get the real account name. For instance, this is an issue if a space
848 was in the account name, which can happen because the account name
849 is generated from the display name.
850 (_modest_account_mgr_get_account_keyname): Always escape the
852 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
853 Unescape the conf keys to get the real account names.
855 For instance, previously the is-default radio button in the accounts
856 list was not checked for any accounts at first. This fixes that,
857 and might fix several similar bugs.
859 2007-05-23 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
862 Removed some debug printfs.
864 2007-05-23 Murray Cumming <murrayc@murrayc.com>
866 Modest on-disk outbox directories are now here, for instance:
867 $HOME/.modest/outboxes/<account-id-1>/outbox
868 $HOME/.modest/outboxes/<account-id-2>/outbox
870 $HOME/.modest/local-folders/outbox
871 so we can have a separate outbox for each account.
872 But they are shown as one outbox in the GtkTreeView, by using a
873 TnyMergeFolder in a ModestTnySimpleFolderStore.
876 * src/modest-tny-simple-folder-store.c:
877 * src/modest-tny-simple-folder-store.h:
878 Added ModestTnySimpleFolderStore, used to contain folders from
879 other folder stores, such as other accounts.
881 * src/modest-tny-outbox-account.h:
882 * src/modest-tny-outbox-account.c:
883 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
884 used for the per-account local outbox folders.
886 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
887 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
888 only use this (internally) now for the non-outbox local folders.
891 * src/modest-init.c: Added modest_init_one_local_folder(), for
892 setting up the directory structure for each local folder.
894 * src/modest-local-folder-info.c:
895 (modest_per_account_local_outbox_folder_info_get_maildir_path),
896 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
898 * src/modest-local-folder-info.h:
899 * src/modest-tny-account-store.c: (on_account_removed),
900 (on_account_changed), (create_per_account_local_outbox_folders),
901 (get_server_accounts), (modest_tny_account_store_get_accounts),
902 (modest_tny_account_store_get_tny_account_by_account),
903 (modest_tny_folder_store_is_virtual_local_folders):
905 * src/modest-tny-account.h:
906 * src/modest-tny-account.c:
907 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
908 to create an on-disk per-account local outbox folder for each
910 (create_per_account_local_outbox_folders): Create a local outbox folder
911 for each transport account.
912 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
913 for all local folders.
915 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
916 instead of using g_object_get/set() directly. It is clearer.
918 (modest_tny_folder_store_get_message_count),
919 (modest_tny_folder_store_get_local_size
920 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
921 because we now use these with non-acount folder stores.
923 (modest_tny_account_get_special_folder),
924 (modest_tny_account_new_from_server_account),
925 (modest_tny_account_new_from_account):
926 (recurse_folders): Adjust to the new outbox system.
928 * src/modest-tny-folder.h:
929 * src/modest-tny-folder.c:
930 (modest_tny_folder_is_local_folder),
931 (modest_tny_folder_get_local_folder_type),
932 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
934 * src/widgets/modest-main-window.h:
935 * src/maemo/modest-main-window.c: (create_details_widget),
936 (modest_main_window_set_contents_style): Show details for any folder store,
939 (modest_tny_folder_get_rules):
940 Remove the const. C does not support constness enough for this.
942 * src/modest-ui-actions.c:
943 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
944 make all outboxes appear as one, in the usual local-folders tree node.
946 (set_active_account_from_tny_account),
947 (modest_ui_actions_on_folder_selection_changed):
948 * src/widgets/modest-folder-view.c: (text_cell_data),
949 (icon_cell_data), (filter_row),
950 (add_account_folders_to_merged_folder),
951 (add_account_folders_to_simple_folder_store), (),
952 (get_cmp_rows_type_pos), (cmp_rows),
953 (modest_folder_view_set_account_id_of_visible_server_account):
954 Adjust to the new outbox system, using generic folder stores and folders
957 2007-05-23 Christian Kellner <ckellner@openismus.com>
959 * src/modest-mail-operation.c:
960 (modest_mail_operation_update_account):
961 Use info->max_size instead of unintialized local var [small
962 build fix]. (Added TODO to review that change since I don't
965 2007-05-23 Marcus Bauer <marcusb@openismus.com>
967 * libmodest-dbus-client/libmodest-dbus-client.c:
968 (libmodest_dbus_client_compose_mail): function added
969 * src/dbus_api/modest-dbus-api.h:
970 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
971 (on_compose_mail): Implementation of the SendAsMail functionality
973 2007-05-22 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-account-mgr.c:
976 (modest_account_mgr_add_server_account): Set the secure-connection
977 conf key for transport accounts as well as store accounts. I don't know
978 why the if was there. For instance, this makes sure that we use SSL
979 for the gmail preset from the easysetup wizard.
981 2007-05-22 Murray Cumming <murrayc@murrayc.com>
983 * src/gnome/modest-main-window.c:
984 (on_account_store_connecting_finished), (connect_signals):
985 * src/maemo/modest-main-window.c:
986 (on_account_store_connecting_finished), (connect_signals),
987 (modest_main_window_new):
988 Handle TnyAccountStore::connecting-finished instead of
989 TnyDevice::connection-changed, because we cannot actually perform
990 operations on accounts until TnyAccountStore has itself responded to
991 the TnyDevice::connection-changed signal. This prevents a GError from
993 Do not try to update at startup, because we (at least on scratchbox)
994 already do an update at startup when the device goes online.
995 This prevents a GError from tinymail.
996 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
997 Added TODO about stopping simultaneous operations.
999 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1001 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1002 * src/modest-mail-operation-queue.c:
1003 (modest_mail_operation_queue_remove):
1004 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1005 about where they happened.
1007 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-ui-actions.c:
1010 (modest_ui_actions_on_password_requested): Make sure that the remember
1011 output parameter is always TRUE.
1013 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1015 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1016 Show a OK/Cancel dialog if the error is a question, though we still do not
1017 know anything more about what we are asking the user.
1018 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1019 Fix an uninitialized variable (helper). This is a logic error, however.
1021 2007-05-21 Christian Kellner <ckellner@openismus.com>
1023 * src/modest-search.h:
1024 Correct bit shifting in the ModestSearchFlags enum.
1026 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1028 * src/modest-tny-account.c:
1029 (modest_tny_account_new_from_server_account): Do not use the lsub and
1030 check-all hard-coded IMAP options when using POP.
1032 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1034 * src/modest-tny-account.c:
1035 (modest_tny_account_new_from_server_account):
1036 Use NULL for the secure-auth method for POP when Password auth has been
1037 specified by the user, as we already do for IMAP. "auth=Login" causes
1038 an error from camel or the server.
1040 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1042 * src/maemo/modest-account-settings-dialog.c:
1043 (create_page_account_details),
1044 (modest_account_settings_dialog_set_account_name):
1045 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1046 for the leave-on-server checkbox, rathr than just the checkbox, when
1047 the protocol is not POP.
1049 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1051 * src/widgets/modest-account-view.c:
1052 * src/widgets/modest-account-view.h:
1053 Added modest_account_view_select_account() which will be useful later
1054 to asynchronously re-select the edited account.
1056 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1058 * src/maemo/modest-account-settings-dialog.c:
1059 (modest_account_settings_dialog_set_account_name):
1060 Automatically choose the port numbers based on the secure authentication
1061 methods, if they have not been chosen before.
1062 This fixes projects.maemo.org bug NB#56273 .
1064 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1066 * src/maemo/modest-main-window-ui.h:
1067 * src/modest-ui-actions.c:
1068 * src/modest-ui-actions.h:
1069 Connect the Tools/SMTP Servers menu item to
1070 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1071 SMTP servers dialog, as in the UI specification and saves changes when it
1072 is closed. This fixed projects.maemo.org bug NB#56305 .
1074 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1076 * src/maemo/modest-connection-specific-smtp-window.c:
1077 (modest_connection_specific_smtp_window_init):
1078 Use gtk_window_set_default_size() to make this window big enough, so
1079 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1081 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1083 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1084 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1085 (modest_connection_specific_smtp_edit_window_init),
1086 Do not try to connect to a combobox signal before the combobox exists.
1087 This fixes the cras in projects.maemo.org bug NB#56288 .
1088 (modest_connection_specific_smtp_edit_window_get_settings):
1089 Remove the server_account_name parameter which was being checked for NULL
1090 though it was not used.
1092 * src/maemo/modest-connection-specific-smtp-window.c:
1093 (modest_connection_specific_smtp_window_fill_with_connections),
1094 (on_button_edit), (modest_connection_specific_smtp_window_init):
1095 Correct the number of treemodel columns to prevent a warning.
1096 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1097 libconic does not work.
1099 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1101 * src/modest-tny-account.c:
1102 (modest_tny_account_new_from_server_account):
1103 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1104 SMTP when "None" was chosen by the user. However, with my SMTP server that
1105 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1108 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1110 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1111 to explain the memory management issue with the ID in the ModestPair.
1113 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1114 (add_sending_page), (modest_account_assistant_finalize):
1115 * src/gnome/modest-gnome-global-settings-dialog.c:
1116 (create_updating_page), (create_composing_page):
1117 * src/gnome/modest-msg-edit-window.c: (get_transports),
1118 (init_window), (modest_msg_edit_window_finalize),
1119 (modest_msg_edit_window_get_msg_data):
1120 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1121 * src/gnome/modest-transport-widget.c:
1122 (modest_transport_widget_finalize), (smtp_configuration):
1123 * src/maemo/modest-maemo-global-settings-dialog.c:
1124 (create_updating_page), (create_composing_page):
1125 * src/maemo/modest-msg-edit-window.c: (get_transports),
1126 (init_window), (modest_msg_edit_window_finalize),
1127 (modest_msg_edit_window_get_msg_data),
1128 (modest_msg_edit_window_free_msg_data):
1129 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1130 (modest_store_widget_finalize):
1131 * src/maemo/modest-transport-widget.c:
1132 (modest_transport_widget_finalize), (smtp_configuration):
1133 * src/modest-main.c: (send_mail):
1134 * src/widgets/modest-combo-box.h:
1135 * src/widgets/modest-global-settings-dialog-priv.h:
1136 * src/widgets/modest-global-settings-dialog.c:
1137 (modest_global_settings_dialog_finalize):
1138 * src/widgets/modest-msg-edit-window.h:
1139 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1140 as long as the combo box, to prevent use of freed memory for the ID.
1142 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1144 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1145 get_accounts(), to make this clearer. Do not check for the enabled gconf
1146 key, because we do not use this for server accounts (at least, not yet).
1147 This allows us to send email again.
1149 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1151 * src/maemo/modest-platform.c:
1152 (on_modest_conf_update_interval_changed), (modest_platform_init):
1153 Only respond to this particular key change. All these strcmp()s cannot be
1156 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1158 * src/maemo/modest-maemo-global-settings-dialog.c:
1159 (current_connection): Prevent a crash in scratchbox when
1160 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1161 * src/maemo/modest-platform.c:
1162 (on_modest_conf_update_interval_changed), (modest_platform_init):
1163 Get the update interval from gconf and reset it when the gconf key changes.
1165 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1167 * src/modest-protocol-info.c:
1168 * src/modest-protocol-info.h: Adde enum-specific get functions,
1169 instead of using a ModestProtocolType enum parameter.
1171 * src/gnome/modest-account-assistant.c:
1172 * src/gnome/modest-store-widget.c:
1173 * src/gnome/modest-store-widget.h:
1174 * src/gnome/modest-transport-widget.c:
1175 * src/gnome/modest-transport-widget.h:
1176 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1177 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1178 * src/maemo/easysetup/modest-easysetup-wizard.c:
1179 * src/maemo/modest-account-settings-dialog.c:
1180 * src/maemo/modest-account-settings-dialog.h:
1181 * src/maemo/modest-store-widget.c:
1182 * src/maemo/modest-store-widget.h:
1183 * src/maemo/modest-transport-widget.c:
1184 * src/maemo/modest-transport-widget.h:
1185 * src/modest-account-mgr-helpers.c:
1186 * src/modest-account-mgr-helpers.h:
1187 * src/modest-account-mgr.c:
1188 * src/modest-account-mgr.h:
1189 * src/modest-tny-account.c:
1190 * src/modest-tny-folder.c:
1191 * src/widgets/modest-account-view.c:
1192 * src/widgets/modest-retrieve-combo-box.c:
1193 * src/widgets/modest-retrieve-combo-box.h:
1194 * src/widgets/modest-secureauth-combo-box.c:
1195 * src/widgets/modest-serversecurity-combo-box.c:
1196 * src/widgets/modest-serversecurity-combo-box.h:
1197 * tests/check_account-mgr.c:
1198 Use the specific functions, and use the re-renamed enum values for GNOME too.
1200 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1202 * src/modest-pair.h:
1203 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1204 so we can get the second based on the first.
1206 * src/maemo/modest-account-settings-dialog.h:
1207 * src/maemo/modest-account-settings-dialog.c:
1208 Added get_supported_secure_authentication_methods(), though it is mostly
1209 commented-out for now until the necessary API is committed to tinymail.
1210 (modest_account_settings_dialog_set_account_name),
1211 (save_configuration): Request the supported authentication methods from the
1212 server, so we can choose a working method.
1214 * src/modest-tny-account-store.h:
1215 * src/modest-tny-account-store.c:
1216 (modest_tny_account_store_get_session): Rename from
1217 tny_account_store_get_session().
1219 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1221 * src/modest-protocol-info.h: Split the ModestProtocol enum
1222 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1223 There was no need to have these unrelated values in one enum.
1225 * src/: many files: Adapted to changed enum. This makes the code a bit
1226 clearer, and the compiler could catch some errors.
1228 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1230 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1231 Show the detailed internal camel error message when an error happens
1232 during the configuration, so that our testers can give us more clues.
1233 For instance, in projects.maemo.org bug NB#56910 .
1235 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1237 * src/modest-tny-account.c:
1238 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1239 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1241 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1243 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1244 * src/maemo/modest-account-settings-dialog.c:
1245 (modest_account_settings_dialog_set_account_name),
1246 (save_configuration): For the incoming secure authentication checkbox,
1247 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1248 the UI specification. PLAIN does not seem to be supported for most IMAP
1249 servers anyway, and I am not sure what it would mean.
1250 However, we probably need to discover which of the secure-authentication
1251 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1252 * src/modest-account-mgr-helpers.c:
1253 (modest_account_mgr_get_server_account_data):
1255 * src/modest-tny-account.c:
1256 (modest_tny_account_new_from_server_account):
1257 Use tny_account_set_mech() to set secure-authentication methods,
1258 with some special-casing for IMAP, based on my observations of how
1261 * src/modest-account-mgr-helpers.h:
1262 * src/modest-account-mgr.c:
1263 * src/modest-defs.h: Comment that the URI is only used for local folders.
1265 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1267 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1268 parameter const, just to be neat.
1269 * src/modest-text-utils.c: (modest_text_utils_inline):
1270 End g_strconcat() with NULL, as its documentation says. This is almost
1271 certainly the cause of my crash at startup on the device. Interestingly,
1272 valgrind doesn't tell us about these errors.
1274 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1276 * scripts/build-packages: Added more precise comments about how to use
1277 this script, though I still get this error:
1278 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1279 error building tinymail
1281 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1283 * src/maemo/modest-main-window.c: (on_account_update):
1284 Very slight cleanup, hoping to make it simpler to discover what causes
1285 a crash here sometimes.
1287 * src/modest-tny-account.c:
1288 (modest_tny_account_new_from_server_account): Set the port. Added
1289 comments about the options and a TODO comment because I need to find out
1290 how to specify the secure authentication method.
1292 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1294 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1295 changed CFlags paths form modest to libmodest
1297 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1299 * src/modest-account-mgr-helpers.c:
1300 (modest_account_mgr_get_server_account_data),
1301 (modest_account_mgr_free_server_account_data):
1302 * src/modest-account-mgr-helpers.h:
1303 * src/modest-account-mgr.c:
1304 (modest_account_mgr_add_server_account):
1305 * src/modest-defs.h:
1306 * src/modest-tny-account.c:
1307 (modest_tny_account_new_from_server_account):
1308 Determine the options for tny_camel_account_add_option() here,
1309 based on the settings, rather than storing them directly in gconf.
1311 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1314 Show a more friendly error dialog now that we expect (from the tinymail
1315 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1317 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1319 * src/maemo/modest-main-window.c: (on_account_update): Check that
1320 account_name is not NULL, to prevent a crash at startup that I am
1321 seeing on the N800. I do wonder why it is NULL.
1323 * src/maemo/easysetup/modest-easysetup-wizard.c:
1324 (create_page_user_details):
1325 * src/maemo/modest-account-settings-dialog.c:
1326 (create_page_user_details), (create_page_outgoing):
1327 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1328 (modest_connection_specific_smtp_edit_window_init):
1329 * src/modest-ui-actions.c:
1330 (modest_ui_actions_on_password_requested):
1331 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1332 might do something useful with the on-screen keyboard.
1334 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1336 * src/maemo/modest-main-window.c: (on_account_update):
1337 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1338 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1340 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1342 * src/modest-tny-account-store.c: (on_account_changed):
1343 Correct the signature of this signal handler.
1345 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1347 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1348 Show a HildonNote instead of a GtkDialog for Maemo.
1350 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1352 * src/widgets/modest-account-view.h:
1353 * src/widgets/modest-account-view.c: (on_account_changed),
1354 (on_account_removed). Added a boolean flag, set/unset by
1355 modest_account_view_block_conf_updates(),
1356 modest_account_view_unblock_conf_updates() to prevent unnecessary
1357 updates, but this is not very useful because the gconf notifications are
1358 so delays (maybe only on Maemo Bora).
1359 So auto-updating is turned off, and these functions do an explicit
1360 update when necessary.
1361 However, something else is still doing too much work when adding/removing
1362 accounts, probably in another part of the application.
1364 * src/maemo/modest-account-view-window.c:
1365 (on_delete_button_clicked), (on_edit_button_clicked),
1366 (on_new_button_clicked): Use the new functions.
1368 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1370 * src/modest-account-mgr-helpers.c:
1371 (modest_account_mgr_set_first_account_as_default):
1372 Sort the list of names alphabetically-by-title, so we choose the first one
1374 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1375 alphabetically by the title.
1377 This fixes projects.maemo.org bug NB#56418 .
1379 * src/modest-account-mgr-priv.c:
1380 (_modest_account_mgr_account_from_key):
1381 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1382 avoid a valgrind error, and possible random behaviour.
1384 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1386 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1387 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1388 tinymail documentation to say that this can be expected.
1389 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1390 pretty, and should not happen, but I would prefer to know when it does.
1392 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1394 * configure.ac: When using the older hildon version, probably on Bora,
1395 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1397 * src/widgets/modest-attachment-view.c:
1398 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1401 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1403 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1404 Implemented the prototype. Can be tested with
1405 tests/dbus_api/test_open_message:
1407 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1409 * src/modest-tny-account-store.c:
1410 (modest_tny_account_store_instance_init), (get_password):
1411 * src/modest-ui-actions.c:
1412 (modest_ui_actions_on_password_requested):
1413 Do not store the password in gconf, because this function is called
1414 for non-remembered passwords. Actually use the cached (in the hash map)
1415 password instead of releasing it.
1416 The password will now not be remembered if it is asked via the protected
1417 password dialog, as per the UI spec.
1419 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-defs.h:
1422 * src/modest-account-mgr-helpers.h:
1423 * src/modest-account-mgr-helpers.c:
1424 Added modest_server_account_get_username_has_succeeded(),
1425 modest_server_account_set_username_has_succeeded().
1426 (modest_server_account_set_username),
1427 Reset the has-succeeded flag if the username changes.
1429 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1430 * src/maemo/modest-connection-specific-smtp-window.c:
1431 (modest_connection_specific_smtp_window_save_server_accounts):
1432 Use modest_server_account_set_username() instead of using
1433 modest_conf_set_string() directly, so that the has-succeeded flag is always
1436 * src/modest-ui-actions.c:
1437 (modest_ui_actions_on_password_requested): Dim the username entry if
1438 the username has ever worked, as per the UI spec.
1440 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1442 * src/modest-tny-account-store.c: (get_password):
1443 * src/modest-ui-actions.c:
1444 (modest_ui_actions_on_password_requested):
1445 Allow the username to be changed too, though there is more work to
1446 be done on exactly how this behaves.
1448 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1450 * src/modest-account-mgr-helpers.h:
1451 * src/modest-account-mgr-helpers.c:
1452 Added modest_account_mgr_get_display_name(),
1453 modest_server_account_get_username(),
1454 modest_server_account_set_username(),
1455 modest_server_account_set_password(),
1456 modest_server_account_get_hostname() functions so we do not need to
1457 use the conf API directly.
1459 * src/maemo/modest-main-window.c: (connect_signals):
1460 Actually connect ot the ModestAccountStore::request-password signal,
1461 so that we show the dialog when the password is requested by Tinymail,
1462 for isntance if it is empty.
1464 * src/modest-marshal.list:
1465 * src/modest-tny-account-store.c:
1466 (modest_tny_account_store_class_init), (get_password),
1467 (modest_tny_account_store_alert):
1468 * src/modest-tny-account-store.h:
1469 * src/modest-ui-actions.h:
1470 * src/modest-ui-actions.c:
1471 (modest_ui_actions_on_password_requested):
1472 Change the signal parameters, so it is obvious that we are providing
1473 the non human-readable server name, and receiving both the username
1474 and password, though changing of the username is not yet implemented.
1475 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1476 for the GNOME version.
1478 This should fix the projects.maemo.org bug NB#56209, though it does not
1479 work on Bora, because the gconf_client_get() for the password fails
1480 immediately after we save it with gconf_client_set().
1482 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1485 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1486 caused an undefined symbol error:
1487 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1489 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1491 * src/modest-tny-account-store.c:
1492 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1493 using a GError instead of a string message, so we can translate it in
1496 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1498 * src/maemo/modest-address-book.c:
1499 (modest_address_book_check_names):
1500 * src/maemo/modest-msg-view-window.c:
1501 (modest_msg_view_window_clipboard_owner_change):
1502 * src/modest-init.c: (modest_init_init_ui):
1503 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1504 (update_folders_cb), (modest_mail_operation_update_account):
1505 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1506 (modest_ui_actions_on_msg_attachment_clicked),
1507 (modest_ui_actions_on_msg_recpt_activated):
1508 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1509 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1510 (modest_msg_view_search_next):
1511 * src/widgets/modest-recpt-editor.c:
1512 (modest_recpt_editor_on_button_release_event),
1513 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1514 g_message(). At this point we should only be seeing interesting errors on
1515 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1517 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1519 (modest_wizard_dialog_force_title_update):
1520 * src/maemo/easysetup/modest-wizard-dialog.h:
1521 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1522 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1523 can update the title when appropriate. Otherwise the title is wrong if the
1524 pages are added after adding the notebook to the dialog.
1525 This must be a problem in HildonWizardDialog too.
1526 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1528 * src/maemo/easysetup/modest-easysetup-wizard.c:
1529 (create_subsequent_customsetup_pages),
1530 (create_subsequent_easysetup_pages):
1531 Call modest_wizard_dialog_force_title_update() so that the title is
1532 correct even with GTK+ < 2.10.
1533 This fixes projects.maemo.org bug NB#56145 .
1535 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1537 * src/maemo/modest-platform.c:
1538 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1539 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1542 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1544 * src/widgets/modest-window.h:
1545 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1546 and modest_window_save_state(), which invokes it.
1548 * src/widgets/modest-window-mgr.h:
1549 * src/widgets/modest-window-mgr.c:
1550 Added modest_window_mgr_save_state_for_all_windows(), which calls
1551 the save_state vfunc on all registered windows, if implemented.
1553 * src/gnome/modest-msg-edit-window.c:
1554 * src/gnome/modest-msg-view-window.c:
1555 * src/maemo/modest-msg-edit-window.c:
1556 * src/maemo/modest-msg-view-window.c:
1557 * src/maemo/modest-main-window.c:
1558 Specify the existing save_settings functions as implementations of
1559 ModestWindow::save_state_func().
1561 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1562 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1563 enabling hibernation, for instance.
1565 We may need to do the same thing for restoring settings.
1568 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1570 * src/widgets/modest-window-mgr.c:
1571 * src/widgets/modest-window-mgr.h:
1572 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1573 modest_window_mgr_get_hibernation_is_prevented().
1575 * src/maemo/modest-main-window.c:
1576 (on_hildon_program_is_topmost_notify): Prevent hibernation
1577 (possible when the application goes to the background in the WM),
1578 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1580 * src/maemo/easysetup/modest-easysetup-wizard.c:
1581 (modest_easysetup_wizard_dialog_init):
1582 * src/maemo/modest-account-settings-dialog.c:
1583 (modest_account_settings_dialog_init):
1584 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1585 (modest_connection_specific_smtp_edit_window_init):
1586 * src/maemo/modest-connection-specific-smtp-window.c:
1587 (modest_connection_specific_smtp_window_init):
1588 * src/maemo/modest-signature-editor-dialog.c:
1589 (modest_signature_editor_dialog_init):
1590 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1591 prevent hibernation while any of these account settings dialogs are open.
1593 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1595 * src/maemo/Makefile.am:
1596 * src/maemo/modest-osso-state-saving.c:
1597 * src/maemo/modest-osso-state-saving.h: Added
1598 modest_osso_load_state() and modest_osso_save_state() though they do
1599 nothing now. They should iterate through all the open windows and load/save
1601 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1602 save state when closing.
1604 * src/maemo/modest-main-window.c:
1605 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1606 Add a notification handler for the HildonProgram::is-topmost property,
1607 so we can allow hibernation when the application goes into the background.
1608 But we still need to detect when the accounts setup windows are open so
1609 we can stop hibernation when they are open.
1610 To do this, I also added the main window the HildonProgram. This might have
1611 other side-effects/benefits, and should maybe be done for other windows.
1613 * src/maemo/modest-osso-autosave-callbacks.h:
1614 * src/maemo/modest-osso-autosave-callbacks.c:
1615 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1616 though it does not do anything yet, and we might never need this to do
1617 anything. For instance, we already save drafts.
1619 * src/maemo/modest-platform.c: (modest_platform_init):
1620 Specify the libosso auto-save callback.
1622 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1624 * src/maemo/modest-platform.c:
1625 (modest_platform_set_update_interval):
1626 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1627 aparently stays valid between application instances, so we can use this
1628 to remove and reset it later. According to a maemo-developers email from
1631 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1633 * configure.ac: Depend on libalarm for Maemo.
1635 * src/dbus_api/modest-dbus-api.h:
1636 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1637 (on_send_receive), (modest_dbus_req_handler):
1638 Handle a SEND_RECEIVE D-Bus method.
1640 * libmodest-dbus-client/libmodest-dbus-client.c:
1641 (libmodest_dbus_client_send_and_receive):
1642 * libmodest-dbus-client/libmodest-dbus-client.h:
1643 Add C convenience functions for calling the new D-Bus method.
1645 * src/modest-platform.h:
1646 * src/gnome/modest-platform.c:
1647 * src/maemo/modest-platform.c:
1648 Added modest_platform_set_update_interval(), which uses the
1649 alarmd API on Maemo.
1650 (modest_platform_init),
1651 Call modest_platform_set_update_interval(), using a hard-coded
1652 interval for now (until the global settings dialog is implemented),
1653 though I am not sure that this makes sense yet.
1655 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1657 * src/dbus_api/modest-dbus-callbacks.c:
1658 (modest_osso_cb_hw_state_handler):
1659 * src/dbus_api/modest-dbus-callbacks.h:
1660 * src/maemo/modest-platform.c: (modest_platform_init):
1661 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1662 in case this has some effect on the ability for Maemo to ping the
1665 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1667 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1668 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1669 warning. It is probably a logic error, but I need to fix the build.
1671 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1673 * src/modest-account-mgr.h:
1674 * src/modest-account-mgr.c:
1675 (modest_account_mgr_account_names): Add a gboolean enabled_only
1676 parameter, so we can get lists of onlt the enabled accounts.
1678 (modest_account_mgr_add_account),,
1679 (modest_account_mgr_account_with_display_name_exists):
1680 * src/maemo/modest-msg-edit-window.c: (get_transports):
1681 * src/modest-account-mgr-helpers.c:
1682 (modest_account_mgr_set_first_account_as_default):
1683 * src/modest-init.c: (init_default_account_maybe):
1684 * src/modest-tny-account-store.c: (get_accounts):
1685 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1686 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1687 * tests/check_account-mgr.c: (START_TEST):
1688 Provide the extra parameter, as appropriate.
1690 * src/widgets/modest-account-view.c: (update_account_view):
1691 Do not show disabled accounts (meaning that there is no way to
1692 enable/disable accounts in the UI (the feature is not in our UI
1693 specification), so we can use this internally only to mark unfinished
1694 or temporary account data.
1696 * src/maemo/easysetup/modest-easysetup-wizard.c:
1697 (create_account): Add boolean enable parameter, so we can specify FALSE
1698 to create the temporary account.
1699 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1700 (on_before_next): When finishing, when there is a temporary account, just
1702 Also, use a timeout to delay the showing of the dialog until gconf is likely
1703 to return correct information, due to a maemo gconf bug that is fixed in
1704 osso 1.1, but not yet in Bora.
1705 However, the dialog stays on screen after it is destroyed.
1707 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1708 for invalid data when cancelling. Use a hildon note instead of a dialog
1709 to complain about invalid data. Do not show the account-saved note if the
1710 account is disabled (a temporary account that will not really be saved for use
1713 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1715 * src/modest-account-mgr-helpers.h:
1716 * src/modest-account-mgr-helpers.c:
1717 Added modest_account_mgr_unset_default_account(),
1718 Added modest_account_mgr_set_first_account_as_default().
1720 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1721 If it was the default account, unset the default account name.
1723 * src/maemo/modest-account-view-window.c:
1724 (on_delete_button_clicked): If it was the default account,
1725 set the first remaining account as the default instead.
1727 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1728 a NULL account or a NULL default account, to prevent a crash. This should
1729 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1732 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1734 * src/widgets/modest-recpt-editor.c:
1735 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1736 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1737 TODO comment for this. This fixes the build.
1739 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1740 be the best place for it. This will in future update all auto-update accounts,
1741 rather than just the current/default account, when that gconf key exists.
1742 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1743 if there are no accounts, before calling do_send_receive().
1744 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1746 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1747 * src/maemo/modest-main-window-ui.h:
1748 * src/maemo/modest-main-window.c: (on_connection_changed),
1749 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1750 directly, becaue the signal handler does more.
1752 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1754 * src/modest-account-mgr-helpers.c:
1755 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1756 for the case that the account does not exist.
1758 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1759 (equivalent to the modest account name) rather than the tinymail account name
1760 (equivalent to the modest account title - human readable) to get the account data.
1761 Check for null account data to prevent the crash, and add a TODO comment saying that
1762 this needs fixing because it is using the server account name instead of the account name.
1764 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1766 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1767 * src/maemo/modest-account-settings-dialog.c: (show_error),
1769 Use hildon_note_new_information() for informative and error messages,
1770 which seems to be expected for Maemo applications (no documentation that I know of
1771 says this). I am surprised that there is no distinction between info and error
1774 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1776 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1777 it is easy to find where this is used.
1779 * src/maemo/easysetup/modest-easysetup-wizard.c:
1780 (create_page_welcome), (create_page_account_details),
1781 (create_page_user_details), (create_page_complete_easysetup),
1782 (create_page_custom_incoming), (create_page_custom_outgoing),
1783 (create_page_complete_custom):
1784 * src/maemo/modest-account-settings-dialog.c:
1785 (create_page_account_details), (create_page_user_details),
1786 (create_page_incoming), (create_page_outgoing):
1787 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1788 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1789 (modest_connection_specific_smtp_edit_window_init):
1790 * src/maemo/modest-connection-specific-smtp-window.c:
1791 (modest_connection_specific_smtp_window_init):
1792 * src/maemo/modest-signature-editor-dialog.c:
1793 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1794 and scrolling policy as per the Email Application Layout Guide, if I have
1797 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1799 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1800 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1801 which were empty, because these vfuncs have been removed from TnyAccountStore.
1802 This fixes the build.
1804 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1806 * src/maemo/modest-main-window.c:
1807 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1808 showing/hiding it. Added TODO because it probably should not be NULL.
1809 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1810 because unnecessary g_warnings() make degugging difficult.
1812 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1814 * src/maemo/modest-msg-edit-window.c:
1815 (modest_msg_edit_window_select_color),
1816 (modest_msg_edit_window_select_background_color): 2 const corrections and
1817 moving 2 #endifs before closing brackets, to fix the build.
1819 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/easysetup/modest-easysetup-wizard.h:
1822 * src/maemo/easysetup/modest-easysetup-wizard.c:
1823 (modest_easysetup_wizard_dialog_finalize),
1824 (on_button_edit_advanced_settings), (create_page_complete_custom),
1825 (on_response), (create_account):
1826 Implement the Advanced Settings edit button, by saving the account information,
1827 for the Advanded Settings dialog to use directly from gconf, and removing it
1828 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1829 Bug #5533 in the projects.maemo.org bugzilla.
1831 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1833 * src/maemo/modest-msg-view-window.c:
1834 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1835 when opening a message window.
1837 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1839 * src/maemo/easysetup/modest-easysetup-wizard.c:
1840 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1843 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1844 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1845 gconf settings. I probably added more checks than necessary, but that is safer.
1847 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1848 variable to fix the build, but this seems to be used when it is still NULL.
1850 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1852 * src/modest-platform.h:
1853 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1854 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1855 * src/modest-main.c: Implement this function so we can avoid using
1856 maemo-specific API from cross-platform code.
1858 * src/modest-tny-account-store.c:
1859 (get_smtp_specific_transport_account_for_open_connection):
1860 * src/modest-ui-actions.c: (check_for_connection),
1861 (modest_ui_actions_on_item_not_found):
1862 Use modest_platform_connect_and_wait() and put #idefs around other
1863 maemo-specific code, because only maemo currently has a way to
1864 identify connection names.
1866 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1868 * src/modest-tny-account-store.h:
1869 * src/modest-tny-account-store.c:
1870 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1871 the connection-specific SMTP server settings in the configuration.
1873 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1875 * src/maemo/modest-main-window.c: (on_connection_changed),
1877 * src/modest-main.c: (main), (start_ui), (send_mail):
1878 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1879 that is what is intended.
1881 * src/modest-ui-actions.c: (action_send), (action_receive),
1882 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1883 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1884 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1885 SMTP server is used when it is specified.
1887 (modest_ui_actions_on_send_receive):
1888 Check that a connection is open before proceeding.
1889 Receive and then send, instead of vice-versa, as per the specification.
1891 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1893 * src/modest-mail-operation.c:
1894 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1895 though I guess it should be something other than NULL.
1897 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/easysetup/modest-easysetup-wizard.c:
1900 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1901 combo twice, to avoid an g_warning and to make it visible again.
1902 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1903 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1904 (already intended) dereference when detaching, because we then recreate the menu.
1905 But I am not sure why the warning was happening, and it is possible that this is a memory
1908 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1910 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1911 and uri_parse_mailto() utility functions.
1912 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1914 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1916 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1918 * src/dbus_api/modest-dbus-api.h:
1919 * src/dbus_api/modest-dbus-callbacks.c:
1920 Use an idle callback to execute the modest code in the application's own thread.
1921 Remove the helloworld example method.
1922 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1923 parsed, and the open-message method is not implemented because this is not yet implemented in
1925 * libmodest-dbus-client/libmodest-dbus-client.c:
1926 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1927 (libmodest_dbus_client_open_message):
1928 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1930 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1931 body without crashing.
1933 * tests/dbus_api/Makefile.am:
1934 * tests/dbus_api/test_mail_to.c:
1935 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1937 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1939 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1940 Added file to fix the build. Sorry.
1942 * src/dbus_api/Makefile.am:
1943 * src/dbus_api/modest-dbus-api.h:
1944 * src/dbus_api/modest-dbus-callbacks.h:
1945 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1946 (modest_dbus_req_handler):
1947 Put constants in a separate header so it can be reused by the
1948 client library, without duplication
1950 * libmodest-dbus-client/Makefile.am:
1951 * libmodest-dbus-client/libmodest-dbus-client.c:
1952 (libmodest_dbus_client_call_helloworld),
1953 (libmodfest_dbus_client_send_mail),
1954 (libmodfest_dbus_client_mailto),
1955 (libmodfest_dbus_client_open_message):
1956 * libmodest-dbus-client/libmodest-dbus-client.h:
1957 (Partly) Implement a send_mail D-Bus method.
1959 * tests/dbus_api/Makefile.am:
1960 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1961 the send_email D-Bus method.
1963 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1967 * libmodest-dbus-client/Makefile.am:
1968 * libmodest-dbus-client/libmodest-dbus-client.c:
1969 * libmodest-dbus-client/libmodest-dbus-client.h:
1970 * tests/dbus_api/Makefile.am:
1971 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1972 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1974 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1976 * src/maemo/easysetup/modest-easysetup-wizard.c:
1977 (create_page_account_details):
1978 * src/maemo/modest-account-settings-dialog.c:
1979 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1980 widgets, because this might not be the default in future versions of the Maemo GTK+.
1981 However, I can not not get capitalization to work even in a simple test case.
1983 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1985 * src/maemo/easysetup/modest-easysetup-wizard.c:
1986 (create_page_custom_incoming), (create_page_custom_outgoing):
1987 * src/maemo/modest-account-settings-dialog.c:
1988 (create_page_account_details), (create_page_incoming),
1989 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1990 instead of using gtk_check_button_with_label(), so they are aligned like the other
1991 widgets, as per the UI spec.
1993 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1995 * src/maemo/easysetup/modest-easysetup-wizard.c:
1996 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1997 * src/widgets/modest-validating-entry.c:
1998 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1999 Modest prefix instead of an EasySetup prefix.
2001 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2003 * src/widgets/modest-validating-entry.h:
2004 * src/widgets/modest-validating-entry.c: (on_insert_text),
2005 Added easysetup_validating_entry_set_max_func(), used to set a callback
2006 to call when the max number of characters is reached. GtkEntry has a max-length
2007 already but is silent about it.
2009 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2010 (create_page_account_details), (create_page_user_details),
2012 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2013 (create_page_account_details), (create_page_user_details),
2014 (create_page_outgoing):
2015 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2016 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2017 the UI spec, when the user tries to enter more than the max number of characters.
2019 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/easysetup/modest-easysetup-wizard.c:
2022 (create_page_user_details), (create_page_custom_incoming),
2023 (create_page_custom_outgoing):
2024 * src/maemo/modest-account-settings-dialog.c:
2025 (create_page_user_details), (create_page_incoming),
2026 (create_page_outgoing):
2027 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2028 (modest_connection_specific_smtp_edit_window_init):
2029 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2030 not appropriate. Bad Maemo-specific defaults!.
2032 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2034 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2035 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2036 (modest_signature_editor_dialog_set_settings):
2037 Disable the label and textview when the checkbox is disabled, and use the
2038 specified (UI spec) default signature text.
2040 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2042 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2043 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2045 * src/modest-defs.h:
2046 * src/modest-account-mgr-helpers.h:
2047 * src/modest-account-mgr-helpers.c:
2048 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2050 * src/maemo/Makefile.am:
2051 * src/maemo/modest-signature-editor-dialog.c:
2052 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2055 * src/maemo/modest-account-settings-dialog.h:
2056 * src/maemo/modest-account-settings-dialog.c:
2057 (modest_account_settings_dialog_finalize), (on_button_signature),
2058 (save_configuration): Use the new dialog when the Edit button is pressed, and
2059 save the changes if necessary, as per the UI spec.
2061 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/Makefile.am:
2064 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2065 based on maemo-develoers email from Dirk.
2067 * src/maemo/easysetup/modest-easysetup-wizard.c:
2068 (create_page_welcome), (create_page_account_details),
2069 (create_page_user_details), (create_page_complete_easysetup),
2070 (create_page_custom_incoming), (create_page_custom_outgoing),
2071 (create_page_complete_custom),
2072 (modest_easysetup_wizard_dialog_init):
2073 * src/maemo/modest-account-settings-dialog.c:
2074 (create_page_account_details), (create_page_user_details),
2075 (create_page_incoming), (create_page_outgoing),
2076 (modest_account_settings_dialog_init):
2077 * src/maemo/modest-connection-specific-smtp-window.c:
2078 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2080 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2082 * src/maemo/easysetup/modest-easysetup-wizard.c:
2083 (create_page_account_details), (create_page_custom_outgoing),
2084 (create_page_complete_custom):
2085 * src/maemo/modest-account-settings-dialog.c:
2086 (create_page_user_details), (create_page_incoming),
2087 (create_page_outgoing):
2088 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2089 (modest_connection_specific_smtp_edit_window_init):
2090 Use the correct (UI spec) port min/max, and use horizontal separators,
2093 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2095 * src/maemo/easysetup/modest-easysetup-wizard.c:
2096 (set_default_custom_servernames):
2097 * src/maemo/modest-account-settings-dialog.c:
2098 (create_page_incoming), (on_combo_outgoing_security_changed),
2099 (on_combo_incoming_security_changed), (create_page_outgoing),
2100 (modest_account_settings_dialog_set_account_name),
2101 (save_configuration):
2102 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2103 (on_combo_security_changed),
2104 (modest_connection_specific_smtp_edit_window_init),
2105 (modest_connection_specific_smtp_edit_window_set_connection),
2106 (modest_connection_specific_smtp_edit_window_get_settings):
2107 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2110 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2113 * src/maemo/easysetup/modest-easysetup-wizard.c:
2114 (create_page_custom_outgoing), (create_page_complete_custom):
2115 * src/maemo/modest-account-settings-dialog.c:
2116 (create_page_user_details), (create_page_outgoing):
2117 * src/maemo/modest-account-view-window.c: (button_box_new):
2118 Use changed logical IDs as per the most recent UI spec:
2119 mcen_bd_emailsetup_edit -> mcen_bd_edit
2120 mcen_bd_emailsetup_delete -> mcen_bd_delete
2121 mcen_bd_emailsetup_close -> mcen_bd_close
2123 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2127 * src/dbus_api/Makefile.am:
2128 * src/dbus_api/modest-dbus-callbacks.c:
2129 * src/dbus_api/modest-dbus-callbacks.h:
2130 * src/maemo/modest-platform.c: (modest_platform_init):
2131 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2133 * tests/Makefile.am:
2134 * tests/dbus_api/Makefile.am:
2135 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2137 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/modest-account-settings-dialog.c:
2140 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2141 Removed unnecessary includes.
2143 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2145 * src/maemo/easysetup/modest-easysetup-wizard.c:
2146 * src/maemo/modest-account-settings-dialog.c:
2147 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2148 * src/widgets/Makefile.am:
2149 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2150 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2151 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2152 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2153 * src/widgets/modest-secureauth-combo-box.c:
2154 * src/widgets/modest-secureauth-combo-box.h:
2155 * src/widgets/modest-serversecurity-combo-box.c:
2156 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2157 made the GObject names more consistent with the rest of the Modest code.
2159 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2161 * src/maemo/easysetup/Makefile.am:
2162 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2163 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2164 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2165 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2166 * src/maemo/easysetup/modest-easysetup-wizard.c:
2167 * src/maemo/easysetup/modest-validating-entry.c:
2168 * src/maemo/easysetup/modest-validating-entry.h:
2169 * src/maemo/modest-account-settings-dialog.c:
2170 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2171 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2172 widgets/ because they are used outside of easysetup too. After checking in,
2173 svn will allow me to rename them too.
2175 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2177 * src/gnome/modest-msg-edit-window.c:
2178 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2179 linker error, to fix the build on the GNOME platform.
2180 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2181 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2182 ifdefed out to avoid a warning.
2184 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2186 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2187 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2188 some alternative for GTK+ 2.6.
2190 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2192 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2194 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2195 specified for EmailAccountsDialog in UI spec.
2197 * src/maemo/easysetup/modest-easysetup-wizard.c:
2198 * src/maemo/easysetup/modest-easysetup-wizard.h:
2199 * src/maemo/modest-account-settings-dialog.c:
2200 * src/maemo/modest-account-settings-dialog.h:
2201 Reuse a member window widget for the connection-specific SMTP server accounts,
2202 so we can tell it to create/save the accounts only if we actually save changes.
2204 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2205 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2206 (modest_connection_specific_smtp_edit_window_get_settings):
2207 Return a struct instance for temporarily remembering the entered data.
2209 * src/maemo/modest-connection-specific-smtp-window.h:
2210 * src/maemo/modest-connection-specific-smtp-window.c:
2211 (modest_connection_specific_smtp_window_finalize),
2212 (modest_connection_specific_smtp_window_fill_with_connections),
2214 (modest_connection_specific_smtp_window_save_server_accounts),
2215 (update_model_server_names): Do not actually save data until asked,
2216 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2218 (on_selection_changed),
2219 (modest_connection_specific_smtp_window_init): Disable the edit
2220 button when nothing is selected.
2222 * src/modest-account-mgr-helpers.c:
2223 * src/modest-account-mgr-helpers.h:
2224 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2227 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2229 * src/modest-account-mgr-helpers.h:
2230 * src/modest-account-mgr-helpers.c:
2231 (modest_account_mgr_get_unused_account_name),
2232 (modest_account_mgr_get_unused_account_display_name): Added these
2233 utility functions, to avoid code duplication.
2235 * src/maemo/easysetup/modest-easysetup-wizard.c:
2236 (create_page_account_details), (create_account):
2237 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2238 (on_combo_security_changed),
2239 (modest_connection_specific_smtp_edit_window_init),
2240 (modest_connection_specific_smtp_edit_window_save_settings):
2241 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2242 * src/maemo/modest-connection-specific-smtp-window.c:
2243 (modest_connection_specific_smtp_window_finalize),
2244 (modest_connection_specific_smtp_window_fill_with_connections),
2245 (on_button_edit), (modest_connection_specific_smtp_window_init):
2246 * src/maemo/modest-connection-specific-smtp-window.h:
2247 Implementing saving of connection-specific server accounts.
2249 But I need to refactor this so we can save the data for each
2250 possible connection-specific account and only actually create the server accounts
2251 when the easysetup finished, or the OK button is pressed on the account settings
2254 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2256 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2257 (on_combo_security_changed):
2258 (modest_connection_specific_smtp_edit_window_init):
2259 Auto-fill the port number as in the account settings.
2261 (modest_connection_specific_smtp_edit_window_set_connection):
2262 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2263 * src/maemo/modest-connection-specific-smtp-window.c:
2264 (fill_with_connections), (on_button_edit),
2265 (modest_connection_specific_smtp_window_init):
2266 Turn the edit window into a dialog to simplify the code, and
2267 set a WM hint as in a GtkDialog, because only a popup can be on top of
2268 another window in Maemo, and popups usually have no WM decoration.
2270 * src/modest-defs.h:
2271 * src/modest-account-mgr-helpers.c:
2272 (modest_account_mgr_set_connection_specific_smtp),
2273 (modest_account_mgr_remove_connection_specific_smtp),
2274 (modest_account_mgr_get_connection_specific_smtp):
2275 * src/modest-account-mgr-helpers.h: Some functions to write the
2276 connection-specific SMTP server information. Not yet used.
2279 * src/widgets/modest-folder-view.c: (text_cell_data):
2280 Fix a warning about an uninitialized variable.
2281 (on_configuration_key_changed): Put an #ifdef around the use
2282 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2284 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2286 * src/maemo/modest-account-settings-dialog.h:
2287 * src/maemo/modest-account-settings-dialog.c:
2288 Added connect_for_modified() utility function to mark the new modified boolean.
2290 (create_page_account_details), (create_page_user_details),
2291 (create_page_incoming), (create_page_outgoing), (on_response),
2292 (modest_account_settings_dialog_init),
2293 (modest_account_settings_dialog_set_account_name):
2294 Only warn about unsaved changes when there are actually unsaved changes.
2296 * src/modest-account-mgr-helpers.c:
2297 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2298 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2299 to get the data from there in future.
2301 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2303 * src/modest-defs.h:
2305 * src/modest-account-mgr-helpers.h:
2306 * src/modest-account-mgr-helpers.c:
2307 Store the security account setting in a single conf key instead of using
2308 the options list, so that the list is left for just the to-be-removed camel hack,
2309 and because gconf_client_set_list() is failing for some reason.
2311 * src/modest-account-mgr.c:
2312 (modest_account_mgr_add_server_account):
2313 * src/maemo/modest-account-settings-dialog.c:
2314 (modest_account_settings_dialog_set_account_name),
2315 (save_configuration): Use the renamed functions.
2318 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2320 * src/widgets/Makefile.am:
2321 * src/widgets/modest-limit-retrieve-combo-box.c:
2322 * src/widgets/modest-limit-retrieve-combo-box.h:
2323 * src/widgets/modest-retrieve-combo-box.c:
2324 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2325 the account settings dialog.
2327 * src/modest-defs.h:
2328 * src/modest-account-mgr-helpers.h:
2329 * src/modest-account-mgr-helpers.c:
2330 (modest_server_account_get_option_secure_auth),
2331 (modest_server_account_set_option_secure_auth):
2332 * src/modest-account-mgr.c:
2333 (modest_account_mgr_add_server_account):
2334 Use the existing AUTH_MECH conf key for the secure-auth setting,
2335 instead of putting it in the list options, because this was actually used already.
2337 * src/maemo/modest-account-settings-dialog.c:
2338 (create_page_account_details),
2339 (modest_account_settings_dialog_set_account_name),
2340 (save_configuration):
2341 * src/maemo/modest-account-settings-dialog.h:
2342 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2343 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2345 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2347 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2348 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2349 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2351 * src/modest-defs.h:
2352 * src/maemo/modest-account-settings-dialog.c:
2353 (create_page_incoming), (on_combo_outgoing_security_changed),
2354 (on_combo_incoming_security_changed), (create_page_outgoing),
2355 (modest_account_settings_dialog_set_account_name),
2356 (save_configuration): Load/Save the port number, and change it when the
2357 security combo changes, to suitable defaults.
2359 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2361 * src/modest-account-mgr.c:
2362 (modest_account_mgr_add_server_account): Set the security and secure-auth
2363 options, and add a comment saying that the other camel-specific options should be
2366 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2368 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2370 * src/modest-tny-account-store.c: (account_list_free),
2371 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2372 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2375 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2377 * src/modest-protocol-info.c:
2378 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2379 is required by our UI spec. Maybe something in our implementation will use this eventually.
2380 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2381 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2382 instead of the previous 0 placeholder.
2384 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2385 secure-auth settings.
2386 * src/modest-account-mgr-helpers.h:
2387 * src/modest-account-mgr-helpers.c:
2388 (modest_server_account_data_get_option_secure_auth),
2389 (modest_server_account_set_option_secure_auth),
2390 (modest_server_account_data_get_option_security),
2391 (modest_server_account_set_option_security): Added this API for getting and setting the security
2392 and secure-auth settings.
2394 * src/maemo/modest-account-settings-dialog.h:
2395 * src/maemo/modest-account-settings-dialog.c:
2396 (modest_account_settings_dialog_finalize), (check_data),
2397 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2398 about changing titles.
2399 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2400 (save_configuration): Save the security and secure-auth settings.
2402 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2403 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2405 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2407 * src/modest-defs.h:
2408 * src/modest-account-mgr.c:
2409 (modest_account_mgr_add_server_account):
2410 Added and used defines for the options key and value pair strings,
2411 that are used so far, though they do not seem to correspond to anything in our
2412 UI specs or ModestProtocol enum.
2414 * src/modest-account-mgr-helpers.h:
2415 * src/modest-account-mgr-helpers.c:
2416 (compare_option_strings_for_name),
2417 (modest_server_account_data_get_option_value),
2418 (modest_server_account_data_get_option_bool),
2419 (modest_account_mgr_get_server_account_option):
2420 Added helper functions for parsing the options GSList.
2422 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2424 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2425 display name is based on the supplied account name.
2426 * src/modest-account-mgr.c:
2427 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2428 with an inefficient, but good-enough, implementation.
2430 * src/maemo/easysetup/modest-easysetup-wizard.c:
2431 (create_page_account_details), (on_before_next), (create_account):
2432 Check for existing display names rather than (non-user-visible) account names, and just
2433 create and set a unique account name at the end.
2435 * src/maemo/modest-account-settings-dialog.c:
2436 (modest_account_settings_dialog_init),
2437 (modest_account_settings_dialog_set_account_name),
2438 (create_page_incoming): Show the display name, instead of the account name.
2439 (on_response): Do some (not all) extra checks, as in the UI spec.
2440 (save_configuration): Save the display name if it was changed.
2442 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2444 * po/en_GB.po: Added needed logical ID and translation.
2445 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2446 (init_view): Made the is-default column clicking work.
2448 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2451 * src/maemo/easysetup/Makefile.am:
2452 * src/maemo/easysetup/modest-easysetup-wizard.c:
2453 (modest_easysetup_wizard_dialog_init):
2454 * src/maemo/easysetup/provider-data-test.keyfile:
2455 * src/maemo/easysetup/provider-data.keyfile:
2456 Moved the provider data file to the new modest-providers-data package and used it from there.
2458 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2460 * src/modest-local-folder-info.c:
2461 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2462 N_() was already used on the static strings, but this just marks it for translation without
2463 using the translation.
2465 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2467 * src/maemo/modest-account-settings-dialog.c:
2468 (create_page_incoming),
2469 (modest_account_settings_dialog_set_account_name):
2470 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2471 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2472 I will do this if nobody else gets there first.
2474 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2476 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2477 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2478 save the security stuff.
2480 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2482 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2483 Set the email address and user fullname, which I now see must be
2486 * src/maemo/modest-account-settings-dialog.h:
2487 * src/maemo/modest-account-settings-dialog.c:
2489 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2490 leave-on-server and authentication.
2491 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2494 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2497 * src/maemo/modest-account-settings-dialog.c:
2498 * src/maemo/modest-account-settings-dialog.h:
2499 Most (but not all) of the widgets are now present as specified by the UI spec.
2500 No changes are yet saved, and some details are not properly shown yet.
2502 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2504 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2506 * src/maemo/Makefile.am:
2507 * src/maemo/modest-account-settings-dialog.c:
2508 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2509 an existing account. Doesn't do much yet.
2511 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2512 Open the accounts settings dialog when Edit is clicked.
2514 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2516 * src/maemo/easysetup/Makefile.am:
2517 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2519 * src/maemo/easysetup/modest-easysetup-wizard.c:
2520 (modest_easysetup_wizard_dialog_init):
2521 Try to get the source directory from the build system,
2522 instead of hard-coding "./" into the source code, when opening our local
2523 copies of the configuration files.
2524 But this still fails when opening the wizard from the Accounts window,
2525 maybe because the working directory seems to change at runtime.
2526 So the wizard will fail the second time unless you copy the files into their
2527 proper locations - see the stdout warnings for the paths.
2529 (create_page_account_details),(on_before_next):
2530 Check for existing non-server accounts instead of server accounts,
2531 so the default account name is useful again, and to prevent trying to
2534 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2535 Show the wizard when New is clicked.
2537 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2538 (init_view): Show the column headers, and show the columns that are
2539 specified in the UI specs. However, something in Maemo's GTK+ prevents
2540 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2541 change the default account. This is despite unsetting the special properties.
2543 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2545 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2546 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2547 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2548 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2549 to make that clearer.
2550 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2552 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2554 * src/maemo/modest-account-view-window.c:
2555 (modest_account_view_window_init),
2556 (modest_account_view_window_new):
2557 Use the same buttons as specified in the
2558 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2559 the existing widgets, which never had a chance of working.
2560 Put the ModestAccountView treeview in a scrolled window.
2561 Do not repeat the initialization in both _init() and _new().
2563 * src/widgets/modest-account-view.c: (update_account_view):
2564 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2565 this widget and window shows no accounts.
2567 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2569 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2571 * src/maemo/easysetup/modest-easysetup-wizard.c:
2572 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2573 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2574 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2577 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2578 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2579 accounts exist yet, as in the UI spec.
2581 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2583 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2585 * src/maemo/Makefile.am:
2586 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2587 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2588 New window for editing connection-specific smtp details.
2589 Not fully implemented.
2591 * src/maemo/modest-connection-specific-smtp-window.c:
2592 (modest_connection_specific_smtp_window_finalize) :
2593 unref the tree model.
2594 (on_button_edit): Show the edit window.
2596 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2598 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2601 * src/maemo/Makefile.am:
2602 * src/maemo/modest-connection-specific-smtp-window.c:
2603 * src/maemo/modest-connection-specific-smtp-window.h:
2604 New window for showing the list of connections, for connection-specific
2605 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2606 * src/maemo/easysetup/modest-easysetup-wizard.c:
2607 (create_page_custom_outgoing): Show the new window when the button is clicked.
2609 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2611 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2612 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2613 * src/maemo/modest-msg-edit-window.c:
2614 (modest_msg_edit_window_insert_image):
2615 * src/modest-conf.c: (modest_conf_key_escape):
2616 * src/modest-mail-operation.c:
2617 (modest_mail_operation_send_new_mail):
2618 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2619 (modest_ui_actions_on_new_account):
2620 * src/widgets/modest-attachment-view.c: (update_filename_request):
2621 * src/widgets/modest-mail-header-view.c:
2622 Corrected warnings that were breaking the build, by commenting out unused variables,
2623 and a function, and by including a header.
2625 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2627 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2628 so we can #ifdef around platform-specific code when necessary.
2629 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2630 to allow this to build for the GNOME platform too.
2632 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2634 * src/maemo/easysetup/modest-easysetup-wizard.c:
2635 Added util_increment_name() and used it in create_page_account_details()
2636 to make sure that the default account name is always a new name.
2638 (modest_easysetup_wizard_dialog_init),
2639 (set_default_custom_servernames): Some minor memory management fixes.
2641 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2645 * src/modest-runtime.c: (init_i18n): Restored the translation
2646 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2647 are defined in config.h, and the translations are installed.
2649 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2650 is defined for translation.
2652 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2654 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2656 * src/maemo/easysetup/modest-easysetup-wizard.c:
2657 (modest_easysetup_wizard_dialog_init):
2658 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2659 Use realistic paths (though they should use $prefix generically) to the
2660 mcc_mapping and provider-data.keyfile files which might work when they
2661 are installed by the future version of the operator-wizard package,
2662 and then fallback to paths in our source code, with an explanatory
2665 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2669 * src/maemo/Makefile.am:
2670 * src/maemo/easysetup/: Added files from the previously-exernal
2671 osso-modest-easysetup.
2672 * src/maemo/modest-main-window-ui.h:
2673 * src/modest-ui-actions.c:
2674 * src/modest-ui-actions.h:
2675 Added modest_ui_actions_on_new_account() as a signal handler for the
2676 New Account menu item. It shows the easysetup wizard.
2677 * po/en_GB.po: Added additional needed logical IDs and translations.
2679 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2680 Apparently ChangeLog is not used for some vague Nokia legal reasons.