1 2007-07-05 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 (create_page_complete_easysetup): Use
5 gtk_widget_set_size() request to ensure that the text wraps
8 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
10 * src/maemo/easysetup/modest-easysetup-wizard.c:
11 (on_entry_invalid_character), (create_page_account_details),
12 (create_page_user_details):
13 Use new API of ModestValidatingEntry. But for some reason the banner is
14 not shown. I will have to investigate that further.
16 * src/widgets/modest-validating-entry.c: (on_insert_text),
17 (modest_validating_entry_set_func):
18 * src/widgets/modest-validating-entry.h:
19 Added a new callback function to be able to react to prevented
20 characters whitespaces to e.g show a banner.
22 2007-07-05 Armin Burgmeier <armin@openismus.com>
24 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
25 notification of HildonNumberEditor instead of remembering the port
26 number. Thanks to Johannes for pointing this out.
28 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
30 * src/maemo/easysetup/modest-easysetup-wizard.c:
31 Check if there are any user changes before showing a confirmation
32 dialog (projects.maemo.org NB#60946)
34 2007-07-05 Armin Burgmeier <armin@openismus.com>
36 * src/maemo/modest-account-settings-dialog.c: Remember custom port
37 number at the beginning of the dialog and set the modified flag at the
38 end if the port number has changed. This is necessary because
39 HildonNumberEditor does not support notification when the value has
42 2007-07-05 Murray Cumming <murrayc@murrayc.com>
44 * src/modest-ui-actions.c:
45 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
46 a connection before asking anything else. Correct the check for the destination
47 folder so that it succeeds when online.
48 This fixed projects.maemo.org bug NB#61645.
50 2007-07-05 Murray Cumming <murrayc@murrayc.com>
52 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
53 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
54 to fix projects.maemo.org bug NB#62439.
56 2007-07-05 Murray Cumming <murrayc@murrayc.com>
58 * src/modest-tny-account.c: (on_connection_status_changed):
59 Really do not use tny_device_force_offline() here. See the previous comment.
61 2007-07-04 Murray Cumming <murrayc@murrayc.com>
63 * src/modest-tny-account.c: (on_connection_status_changed):
64 Do not use tny_device_force_offline() when tinymail says that something
65 went wrong with the connection. It seems to report this unnecessarily.
67 2007-07-04 Murray Cumming <murrayc@murrayc.com>
69 * src/maemo/modest-connection-specific-smtp-window.c:
70 (modest_connection_specific_smtp_window_init):
71 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
72 does not seem to have any effect in osso 1.1 (though it works in
73 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
75 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
77 * src/maemo/modest-connection-specific-smtp-window.c:
78 Fix UI specification problems with projects.meamo.org NB#60479
80 2007-07-04 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
83 clue when this has failed, because the error dialog is not always shown
84 (at least in earlier version).
86 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
87 GError message, because the generic error dialog is not helpful.
89 'This message is not currently available (can't let a new connection go online)'
90 when trying to open an IMAP message.
92 (_modest_ui_actions_open): Offer a connection when some messages would
93 have to be downloaded and we are offline.
95 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
97 * src/widgets/modest-folder-view.c:
98 Don't check for MERGE type anymore as we use the correct type
100 NOTE: For the last two changes you need to update your tinymail copy
101 because of API changes!
103 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
105 * src/modest-tny-local-folders-account.c:
106 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
107 (see projects.maemo.org NB#61580)
109 2007-07-04 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-tny-account.c: (on_connection_status_changed):
112 Commented out the call to modest_platform_connect_and_wait() because this
113 seems to always hang, and I would like to know if this is the only thing
114 that causes a hang when showing the connection dialog.
115 It is not very useful anyway.
117 2007-07-04 Murray Cumming <murrayc@murrayc.com>
119 * src/maemo/modest-msg-view-window.c:
120 (modest_msg_view_window_select_next_message):
122 * src/modest-platform.h:
123 * src/maemo/modest-platform.c:
124 Added modest_platform_connect_and_wait(), which calls
125 tny_maemo_conic_device_connect() always in the main thread, by calling it
126 in an idle handler and waiting for the idle handler to run. It should be
127 in the main thread because it uses GTK+ UI code. It just returns TRUE
128 if the device is already online.
130 There is some nasty code to ensure that subsequent calls to
131 modest_platform_connect_and_wait() just wait for the first one to finish,
132 by checking repeatedly in another idle handler. This is necessary,
133 because other threads (or even the main thread, via another idle handler)
134 can call modest_platform_connect_and_wait() while
135 modest_platform_connect_and_wait() is running.
137 (modest_platform_connect_and_wait_if_network_account),
138 (modest_platform_connect_and_wait_if_network_folderstore):
139 Convenience functions that calls modest_platform_connect_and_wait() if
140 the account or folder might want network access.
142 * src/modest-mail-operation.c:
143 (modest_mail_operation_update_account):
144 * src/modest-ui-actions.c: (download_uncached_messages),
145 (modest_ui_actions_on_rename_folder), (delete_folder),
146 (modest_ui_actions_on_main_window_move_to),
147 (modest_ui_actions_on_msg_view_window_move_to):
148 * src/widgets/modest-folder-view.c:
149 (drag_and_drop_from_folder_view):
150 Offer a connection if we are offline.
152 * src/modest-tny-account.c: (on_connection_status_changed):
153 Document this as only handling errors during network operations in progress,
154 and replace the idle code with a simple call to
155 modest_platform_connect_and_wait(), which does this instead.
157 2007-07-03 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-tny-account.c:
160 (modest_tny_account_get_special_folder): (util_on_idle),
161 Handle the GError so we can see when tny_folder_store_get_folders()
162 fails, as it currently does while something else is connecting.
164 Added util_run_in_main_thread_and_wait()
165 which uses an idlen handler and mainloop to ensure that the function
166 is called in the main thread.
167 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
168 to make sure that we call attempt the connection in the mainloop only,
169 which might solve some hangs.
171 2007-07-03 Murray Cumming <murrayc@murrayc.com>
173 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
174 be found by their display name. This is never useful.
175 * src/modest-tny-account-store.c: (on_account_removed): Find the account
176 by its ID, instead of trying to use its ID as its display name.
178 * src/modest-tny-account-store.h:
179 * src/modest-tny-account.c:
180 (modest_tny_account_get_special_folder): Add a g_warning() when
181 tny_folder_store_get_folders() returns an empty list for the maildir.
183 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
184 Add a g_warning() when this returns NULL, because that it not allowed
187 2007-07-02 Armin Burgmeier <armin@openismus.com>
189 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
190 note when trying to cancel the wizard. This fixes projects.maemo.org
193 2007-07-02 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-tny-account.h:
196 * src/modest-tny-account.c:
197 (modest_tny_account_new_from_server_account),
198 (modest_tny_account_new_from_server_account_name),
199 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
200 because this must now be set before setting the proto. This is usd in
201 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
202 warning in camel_session_get_service() caused by
203 tny_camel_transport_account_prepare().
205 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
208 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
210 * src/maemo/modest-connection-specific-smtp-edit-window.c:
212 (modest_connection_specific_smtp_edit_window_init):
214 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
217 2007-06-29 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-tny-account.c:
220 (modest_tny_account_new_from_server_account):
221 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
222 now uses to request a connection when it needs one, and which it uses
223 to tell us that something is wrong with the connection, so we can force
224 the accounts offline to prevent further problems.
227 * src/modest-init.c: (init_default_settings):
228 * src/modest-mail-operation.c:
229 (modest_mail_operation_update_account):
230 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
231 This should not be necessary anymore. Do not set the conf key that
232 determined this (it was always TRUE and not set anywhere else).
234 * src/modest-ui-actions.h: Remove unused and unimplemented
235 modest_ui_actions_on_online_toggle_toggled().
237 2007-06-29 Murray Cumming <murrayc@murrayc.com
239 * src/maemo/modest-main-window.c: (connect_signals):
240 Don't connect to delete_event twice. Maybe this was harmless.
242 2007-06-29 Murray Cumming <murrayc@murrayc.com
244 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
245 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
246 Debug output to give some more clue when a folder move is not allowed.
248 2007-06-28 Murray Cumming <murrayc@murrayc.com
250 * src/modest-tny-account.c: (on_modest_file_system_info),
251 (modest_tny_account_get_mmc_account_name):
252 Always call the callback, without checking whether the name has changed.
253 * src/widgets/modest-folder-view.c: (strings_are_equal),
254 (on_model_foreach_set_name), (on_get_mmc_account_name),
255 (text_cell_data): Compare the name here, and use the name from
256 the account rather than from the
257 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
258 if the name was changed after the account was added to the model.
259 That's a tinymail bug but not one that I want to fix now.
261 This finally fixes projects.maemo.org bug NB#59301.
263 2007-06-27 Armin Burgmeier <armin@openismus.com>
265 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
268 2007-06-27 Murray Cumming <murrayc@murrayc.com
270 * src/modest-tny-account.h:
271 * src/modest-tny-account.c:
272 Added modest_tny_account_get_mmc_account_name(), to set the memory
273 card name asynchronously for the given account and then notify.
274 (modest_tny_account_new_for_local_folders): Use this new function instead
275 of using hildon_file_system_info_async_new() directly.
277 * src/widgets/modest-folder-view.c: (text_cell_data):
278 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
279 gtk_tree_model_row_changed() when it is available.
281 This should fix projects.maemo.org bug NB#59301.
283 2007-06-27 Murray Cumming <murrayc@murrayc.com
285 * src/modest-mail-operation.c: (update_account_thread),
286 (get_msgs_full_thread): Fix typo failures in the revert
289 2007-06-27 Murray Cumming <murrayc@murrayc.com
291 * src/maemo/modest-maemo-global-settings-dialog.c:
292 (idle_select_default_focus):
293 * src/modest-mail-operation.c: (idle_notify_progress),
294 (idle_notify_progress_once), (set_last_updated_idle),
295 (update_account_thread), (get_msgs_full_thread):
296 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
297 * src/widgets/modest-header-view.c:
298 (idle_notify_headers_count_changed_destroy),
299 (idle_notify_headers_count_changed):
300 Reverted the additions of gdk_threads_enter/leave(), in case this
301 helps with a startup hang on the device.
303 2007-06-26 Armin Burgmeier <armin@openismus.com>
305 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
306 for supported secure authentication methods from server by
307 gtk_dialog_run(), saving CPU time and a potential race condition.
309 2007-06-26 Armin Burgmeier <armin@openismus.com>
311 * src/maemo/modest-maemo-utils.h:
312 * src/maemo/modest-maemo-utils.c: Added a
313 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
314 only error code to tell the calling code when the user canceled the
317 * src/maemo/modest-account-settings-dialog.h:
318 * src/maemo/modest-account-settings-dialog.c:
319 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
320 message if the retrieval of secure authentication methods was canceled
321 by the user. Perform the check before saving anything to configuration
322 to not end up with half-committed configuration changes, do not show
323 a "Saving to configuration failed" note when authentication methods
324 could not be retrieved.
326 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
329 2007-06-26 Murray Cumming <murrayc@murrayc.com>
331 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
332 Only return the first level of folders under accounts, because the
333 osso-global-search UI spec doesn't want the rest.
334 This fixed projects.maemo.org bug NB#61811.
336 2007-06-26 Murray Cumming <murrayc@murrayc.com>
338 * src/modest-tny-account-store.c:
339 * src/modest-tny-account-store.h:
340 Added modest_tny_account_is_memory_card_account().
341 * src/maemo/modest-main-window.c: (create_details_widget):
342 Show the same information items for the memory card as we show for the
343 local-folders, to fix projects.maemo.org bug NB#59307.
345 2007-06-26 Murray Cumming <murrayc@murrayc.com>
347 * src/modest-tny-account-store.c: (get_password):
348 Added some checks for NULL to maybe prevent crashes, though I think
349 it was Philip's last commit that actually prevented the crash here
350 when creating a first new account.
351 But the new account is still not usable (no messages are shown)
352 until a restart of the application.
354 2007-06-26 Murray Cumming <murrayc@murrayc.com>
356 * src/maemo/modest-maemo-global-settings-dialog.c:
357 (idle_select_default_focus):
358 * src/modest-mail-operation.c: (idle_notify_progress),
359 (idle_notify_progress_once), (idle_notify_update_account_queue),
360 (set_last_updated_idle), (update_account_thread),
361 (notify_get_msgs_full), (get_msgs_full_destroyer),
362 (get_msgs_full_thread):
363 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
364 * src/widgets/modest-header-view.c:
365 (idle_notify_headers_count_changed_destroy),
366 (idle_notify_headers_count_changed):
367 Use gdk_threads_enter() and gdk_threads_enter_leave() in
368 all idle handlers, because some other thread could be blocking
369 the GDK lock, so that it can do GUI stuff.
371 2007-06-26 Murray Cumming <murrayc@murrayc.com>
373 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
374 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
375 (on_idle_send_receive), (on_idle_open_default_inbox):
376 * src/maemo/modest-msg-edit-window.c:
377 (modest_msg_edit_window_attach_file_noninteractive):
378 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
379 to prevent a hang. I don't quite understand why these are necessary,
380 beause we should already be in the main loop. I guess something outside
381 of the main loop is taking the lock.
383 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
384 we are really using URIs, and use files that are more likely to exist.
386 2007-06-26 Murray Cumming <murrayc@murrayc.com>
388 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
389 necessary because configure.ac now defines different variables.
391 2007-06-26 Murray Cumming <murrayc@murrayc.com>
393 * libmodest-dbus-client/libmodest-dbus-client.c:
394 * libmodest-dbus-client/libmodest-dbus-client.h:
395 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
396 libmodest_dbus_client_compose_mail() is what things actually use.
398 * src/dbus_api/modest-dbus-api.h:
399 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
400 * tests/dbus_api/Makefile.am:
401 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
404 2007-06-26 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-init.c: (modest_init_local_folders):
407 For memory-card (or other non local-folders) maildir accounts,
408 always create an Archive folder, so that there is somewhere to put
409 messages. This should be less confusing, because the user does not need
410 to guess that the need to create a folder.
412 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
414 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
415 Fixed icon size by using (50, 50) which is the same as defined by
418 2007-06-25 Armin Burgmeier <armin@openismus.com>
420 * src/widgets/modest-window-mgr.c:
422 * configure.ac: Correctly recognize hildon-notify presence and fixed
423 the build without it being installed.
425 2007-06-25 Murray Cumming <murrayc@murrayc.com>
427 * libmodest-dbus-client/libmodest-dbus-client.c:
428 (libmodest_dbus_client_search): Fix the build. Sorry.
429 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
430 (reply_forward_cb): Initialize variables to fix the build.
432 * src/modest-tny-account-store.c:
433 (modest_tny_account_store_get_tny_account_by): Fix the account URI
434 comparison (a silly typo) so that email search results can be opened
435 when there are more than one account.
437 2007-06-25 Murray Cumming <murrayc@murrayc.com>
439 * libmodest-dbus-client/libmodest-dbus-client.c:
440 (libmodest_dbus_client_search),
441 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
442 instead of 1 second, because the search gets folders and messages from
443 the server, which can take a long time. When it times out,
444 osso-global-search will report no results.
446 We need to specify whether we should search only cached information
447 (maybe with a user preference), and the osso-email-search-plugin
448 API should really be improved to allow that option, and to allow results
449 to be delivered asynchronously in batches.
451 2007-06-25 Murray Cumming <murrayc@murrayc.com>
453 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
454 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
455 GTK_ICON_SIZE_DIALOG is probably the wrong size.
457 2007-06-25 Murray Cumming <murrayc@murrayc.com>
459 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
460 that is an empty string. D-Bus seems to give us these instead of NULL.
462 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
464 * src/dbus_api/modest-dbus-callbacks.c:
465 * src/maemo/easysetup/modest-easysetup-wizard.h:
466 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
467 * src/maemo/modest-connection-specific-smtp-edit-window.c:
468 (modest_connection_specific_smtp_edit_window_init):
469 * src/maemo/modest-maemo-global-settings-dialog.c:
471 * src/maemo/modest-maemo-utils.c:
472 (modest_maemo_utils_setup_images_filechooser):
473 * src/maemo/modest-main-window.c: (create_details_widget):
474 * src/maemo/modest-msg-edit-window.c:
475 (modest_msg_edit_window_attach_file_noninteractive),
476 (modest_msg_edit_window_color_button_change),
477 (modest_msg_edit_window_set_zoom):
478 * src/modest-mail-operation.c: (update_account_thread):
479 * src/modest-tny-account-store.c:
480 * src/modest-tny-account.c:
481 * src/widgets/modest-global-settings-dialog.c:
482 * src/widgets/modest-window.h:
486 2007-06-25 Murray Cumming <murrayc@murrayc.com>
488 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
489 * src/modest-search.c: (modest_search_folder),
490 (modest_search_all_accounts): Actually search only in the specified folder,
491 doing a simple match on the folder ID.
492 * src/modest-search.h: Added a folder field to the ModestSearch struct,
493 and added some documentation.
495 2007-06-22 Armin Burgmeier <armin@openismus.com>
497 * src/maemo/modest-maemo-utils.h:
498 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
499 modest_maemo_utils_get_supported_secure_authentication_methods.
501 * src/maemo/easysetup/modest-easysetup-wizard.c:
502 * src/maemo/modest-account-settings-dialog.c: Show correct error if
503 one occured, not just "Server does not support secure authentication".
505 2007-06-22 Murray Cumming <murrayc@murrayc.com>
507 * src/modest-tny-account-store.c: (get_password):
508 Restored the call to tny_account_set_user() because Philip seems to have
509 stopped this from crashing (by not using the freed string). It still does
510 not work, but now we can test it.
512 2007-06-22 Murray Cumming <murrayc@murrayc.com>
514 * src/maemo/modest-msg-edit-window.c: (init_window):
515 Comment out use of an uninitialzed GtkScrolledWindow variable,
516 to fix the build and stop a crash. Yet again.
518 2007-06-22 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-tny-account-store.c: (get_password):
521 Remove the call to tny_account_set_user() because this actually crashes.
522 As mentioned in the last commit, it is known to not work anyway.
524 2007-06-22 Murray Cumming <murrayc@murrayc.com>
526 * src/modest-tny-account-store.c: (get_password):
527 Use tny_account_set_username() to tell tinymail that the username might
528 have changed too. But tinymail ignores this: see projects.maemo.org
530 * src/modest-ui-actions.c:
531 (modest_ui_actions_on_password_requested): Remove the useless attempt to
532 reset the connection when changing the username, and improve the comments.
533 Save the changed username to gconf at least, so it is used when Modest is
536 2007-06-21 Murray Cumming <murrayc@murrayc.com>
538 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
539 Do not use a query, so that we get all folders, including for POP and
540 local-folders. They work as search criteria too.
541 This fixes projects.maemo.org bug NB#57740.
543 2007-06-21 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
546 Comment out the use of hildon_notification_set_sound() because it is
547 not declared, to fix the build. Warnings are serious, people.
549 2007-06-21 Armin Burgmeier <armin@openismus.com>
551 * src/maemo/modest-maemo-utils.h:
552 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
553 modest_maemo_utils_get_supported_secure_authentication_methods()
554 to query authentication methods for a specific user. This should fix
555 projects.maemo.org bug NB#61369.
557 * src/maemo/easysetup/modest-easysetup-wizard.c:
558 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
561 2007-06-21 Murray Cumming <murrayc@murrayc.com>
563 * libmodest-dbus-client/libmodest-dbus-client.h:
564 * libmodest-dbus-client/libmodest-dbus-client.c:
565 (modest_dbus_message_iter_get_search_hit),
566 (libmodest_dbus_client_search):
567 Reorganised and commented this.
568 Removed modest_search_hit_free() from the public API because it
571 Added libmodest_dbus_client_get_folders() and
572 modest_folder_result_list_free().
574 * src/dbus_api/modest-dbus-api.h:
575 * src/dbus_api/modest-dbus-callbacks.c:
576 (modest_dbus_req_filter): Commented. Moved most code to
577 on_dbus_method_search() and added on_dbus_method_get_folders().
579 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
580 of the extra D-Bus handler.
582 * tests/dbus_api/Makefile.am:
583 * tests/dbus_api/test_get_folders.c: New test for
584 libmodest_dbus_client_get_folders(). This seems to return an empty list
585 at the moment. That could be the same error that causes the message list
586 to be empty sometimes.
587 This should help with projects.maemo.org bug NB#57740.
589 2007-06-21 Armin Burgmeier <armin@openismus.com>
591 * src/modest-mail-operation.c: Do not call
592 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
593 notify the operation's end after having set the status to CANCELED for
594 the operation queue to listen on. This fixes a deadlock when there
595 were mail operations in the queue during its finalization.
597 * src/modest-singletons.c: Reordered uninitialization of the account
598 manager to happen after the mail operation queue was uninitialized
599 because the mail operation's in the queue might still try to access
600 the account manager (see modest_mail_operation_notify_end()). This
601 fixes a potential crash when terminating the application.
603 2007-06-21 Murray Cumming <murrayc@murrayc.com>
605 * src/modest-search.c:
606 (search_mime_part_and_child_parts): Moved some code here so we
607 can search recursively in child folders.
608 (modest_search_folder): Search in the message as a mime part, instead
609 of just its child mime parts.
610 (read_chunk), (search_mime_part_ogs):
611 Check how many bytes were read, to prevent an endless loop.
612 Searching in message bodies now works. This finishes the fix for
613 projects.maemo.org bug NB#61007.
615 2007-06-20 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
618 Add a g_warning when the item is not a folder.
620 * src/modest-ui-dimming-rules.c:
621 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
622 when selected item is not a folder (for instance, an account), because
623 the UI spec only talks about folders.
624 I am not sure what the UI spec wants, so this might not totally fix
625 projects.maemo.org bug NB#60794.
627 2007-06-20 Murray Cumming <murrayc@murrayc.com>
629 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
630 (load_from_file): Sort the list. The unsorted list would be more noticeable
631 in non-English locales.
633 * src/maemo/modest-msg-edit-window.c:
634 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
635 warning and fix the build.
637 * src/maemo/modest-progress-bar-widget.c:
638 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
639 avoid a g_warning, and probably to avoid a crash.
641 2007-06-20 Murray Cumming <murrayc@murrayc.com>
643 * src/modest-search.c: (modest_search_folder): Check for a GError
644 when calling tny_folder_get_headers(), to show that this is not the cause
647 2007-06-20 Murray Cumming <murrayc@murrayc.com>
649 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
650 Actually set the body query instead of the subject query.
652 * src/modest-search.c: (search_mime_part_ogs),
653 (search_mime_part_strcmp): Remove extra space from the text/* regex,
654 which would probably cause it to fail if we got this far.
656 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
657 to simplify the code.
658 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
659 be causing search-in-body to fail.
661 2007-06-20 Murray Cumming <murrayc@murrayc.com>
663 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
665 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
666 Better debug message when the folder cannot be found.
667 This should help with fixing projects.maemo.org bug #61287.
668 * src/modest-search.c: (add_hit): Do not leak the furl string.
670 2007-06-20 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-ui-actions.c:
673 (modest_ui_actions_on_folder_selection_changed):
674 Do not special-case TNY_MERGE_FOLDER here, because
675 modest_tny_folder_get_account() already does that. This fixes
676 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
677 shown when the Outbox was selected).
679 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
681 * libmodest-dbus-client/libmodest-dbus-client.c:
682 (_dbus_iter_get_string_or_null): Initialize the string variable in
683 case this helps with Dirk's crash.
685 2007-06-19 Murray Cumming <murrayc@murrayc.com>
687 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
688 though it is not implemented yet (this function is maybe not even used),
689 to avoid breaking ABI in future.
690 * libmodest-dbus-client/libmodest-dbus-client.c:
691 (get_attachments_string): Moved some code into this generic function.
692 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
693 sends email. It is maybe not used.
694 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
695 (on_send_mail): Use attachments.
697 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
698 * src/maemo/modest-msg-edit-window.c:
699 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
700 a filename before using it, to fix projects.maemo.org bug NB#58233.
702 2007-06-19 Murray Cumming <murrayc@murrayc.com>
704 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
705 Initialize the continue_download variable to fix the build, and probably
706 to fix randome behaviour.
708 2007-06-18 Armin Burgmeier <armin@openismus.com>
710 * src/modest-tny-send-queue.h:
711 * src/modest-tny-send-queue.c: Keep track of the status of messages in
712 the queue so we can later show it in the UI. Replaced
713 modest_tny_send_queue_msg_is_being_sent() by
714 modest_tny_send_queue_get_msg_status().
716 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
718 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
719 gpointer. This probably was not harmful, but just to be sure.
721 2007-06-18 Murray Cumming <murrayc@murrayc.com>
723 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
724 Fix the build, but leave the function broken on Bora, because
725 hildon_uri_action_get_service() does not exist.
726 osso_uri_action_get_service() does not exist either, it seems.
728 2007-06-18 Murray Cumming <murrayc@murrayc.com>
730 * src/modest-tny-account.c:
731 (modest_tny_account_new_from_server_account):
732 Uncommented the url debug output again, because it is useful for
733 debugging, as I said in the comment.
735 2007-06-18 Murray Cumming <murrayc@murrayc.com>
737 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
739 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
740 for Mameo Bora, to fix the build.
742 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
745 Fixed build with hildon < 0.99
747 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
748 Check if the selected account is busy instead of checking all accounts
750 * src/modest-account-mgr-priv.h:
751 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
752 (modest_account_mgr_init), (compare_account_name),
753 (modest_account_mgr_set_account_busy),
754 (modest_account_mgr_account_is_busy):
755 * src/modest-account-mgr.h:
756 Added busy information to the account manager. It possible to
757 set an account to busy or not busy now.
759 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
760 (modest_mail_operation_update_account),
761 (modest_mail_operation_notify_end):
762 Set the account to busy/not busy depending on the operation state.
764 * src/widgets/modest-account-view.c:
765 (modest_account_view_finalize), (get_last_updated_string),
766 (update_account_view), (on_account_busy_changed), (init_view):
767 Show string "Refreshing..." if the account is currently busy.
769 All this fixes projects.maemo.org bug NB#59711
771 2007-06-14 Armin Burgmeier <armin@openismus.com>
773 * src/widgets/modest-attachments-view.h:
774 * src/widgets/modest-attachments-view.c: Added
775 modest_attachments_view_has_attachments() and fixed coordinate
776 transformation in get_att_view_at_coords(). This fixes attachment
779 * src/widgets/modest-msg-view.c: Make use of
780 modest_attachments_view_has_attachments() to decide whether to show
781 attachments in the header.
783 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
785 * src/maemo/modest-connection-specific-smtp-edit-window.c:
786 (on_change), (on_combo_security_changed),
787 (modest_connection_specific_smtp_edit_window_init),
788 (modest_connection_specific_smtp_edit_window_set_connection),
789 (modest_connection_specific_smtp_edit_window_is_dirty):
790 * src/maemo/modest-connection-specific-smtp-edit-window.h:
791 * src/maemo/modest-connection-specific-smtp-window.c:
794 Show an comfirmation dialog for the smpt-edit-window if there are
795 unsaved changes and the user hits cancel.
796 (projects.maemo.org bug NB#60479)
798 2007-06-14 Armin Burgmeier <armin@openismus.com>
800 * src/maemo/easysetup/modest-easysetup-wizard.c:
801 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
802 address" info in banner instead of node, and select all the text as
803 per UI spec. This fixes projects.maemo.org bug NB#60550.
805 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
807 reviewed by: <delete if not using a buddy>
809 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
810 * src/modest-ui-actions.c: (folder_refreshed_cb):
812 2007-06-14 Murray Cumming <murrayc@murrayc.com>
814 * src/widgets/modest-folder-view.c: (filter_row):
815 Explictly filter out the per-account outbox accounts. I don't know why
816 these only sometimes show up, but now they should never show up in the UI.
817 This should fix projects.maemo.org bug NB#60160.
819 2007-06-14 Murray Cumming <murrayc@murrayc.com>
821 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
822 when the toolbar does not exist yet.
823 * src/modest-widget-memory.c: (save_settings_header_view):
824 Added g_warnings() to help us to discover when we are trying to set
825 an empty columns list in gconf.
827 2007-06-14 Murray Cumming <murrayc@murrayc.com>
831 Added modest_init_get_default_header_view_column_ids().
833 * src/modest-widget-memory.c: (restore_settings_header_view):
834 Use the new function to get defaults, if the gconf key is empty,
835 instead of not creating any columns. This seems to fix the
836 empty right-hand pane problems.
838 * src/widgets/modest-header-view.h: Improved documentation.
840 2007-06-13 Murray Cumming <murrayc@murrayc.com>
842 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
843 Revert the use of the display name as the account name, because this
844 is generally wrong and would break the code that follows.
846 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
848 * src/maemo/easysetup/modest-easysetup-wizard.c:
849 (check_for_supported_auth_methods), (on_before_next),
852 More correct fix for projects.maemo.org bug NB# 58991
853 Do not longer accept AUTH_PASSWORD as secure method and choose
854 correct method when creating the account.
856 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
858 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
859 Fixed projects.maemo.org bug NB# 58991
861 2007-06-13 Murray Cumming <murrayc@murrayc.com>
863 * src/modest-init.c: (modest_init_init_core),
864 (modest_init_local_folders): Fixed compilation errors.
866 2007-06-13 Murray Cumming <murrayc@murrayc.com>
868 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
869 Remove unnecessary lib/include, though it is good in principle when needed.
871 * src/modest-init.c: (modest_init_one_local_folder),
872 (modest_init_local_folders):
873 * src/modest-init.h: Initialize the .modest library for memory cards,
874 instead of just doing nothing for them. This should allow us to create
875 folders there, fixing projects.maemo.org bug NB#59297.
877 2007-06-13 Murray Cumming <murrayc@murrayc.com>
879 * libmodest-dbus-client/libmodest-dbus-client.c:
880 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
881 (libmodest_dbus_client_compose_mail),
882 (libmodest_dbus_client_open_message),
883 (libmodest_dbus_client_send_and_receive),
884 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
886 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
887 (on_idle_open_message), (modest_dbus_req_handler),
888 (search_result_to_message), (modest_dbus_req_filter):
889 * src/modest-search.c: (add_hit), (modest_search_folder),
890 (modest_search_all_accounts): Improved debug messages.
892 * tests/dbus_api/test_open_message.c: (main): Improved comments.
894 * src/modest-tny-account-store.c:
895 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
898 2007-06-13 Murray Cumming <murrayc@murrayc.com>
901 2007-06-12 Murray Cumming <murrayc@murrayc.com>
903 * src/modest-tny-account-store.c: (get_server_accounts):
904 Call modest_tny_local_folders_account_add_merged_outbox_folders()
905 even when there are no accounts, so that the Outbox folder is always
906 visible. This fixes projects.maemo.org bug NB#60158.
908 2007-06-12 Murray Cumming <murrayc@murrayc.com>
910 * src/maemo/modest-main-window.c: (create_details_widget):
911 Use the mcen_va_never logical ID.
913 2007-06-12 Murray Cumming <murrayc@murrayc.com>
915 * src/dbus_api/modest-dbus-api.h:
916 * src/dbus_api/modest-dbus-callbacks.c:
917 (on_idle_open_default_inbox), (on_open_default_inbox),
918 (modest_dbus_req_handler):
919 Added a new OpenDefaultInbox method.
921 * libmodest-dbus-client/libmodest-dbus-client.h:
922 * libmodest-dbus-client/libmodest-dbus-client.c:
923 Added libmodest_dbus_client_open_default_inbox() to call the new
924 dbus method. This should be useful to projects.maemo.org bug NB#57214,
925 though it should maybe be used by a new osso-email-interface function.
927 * tests/dbus_api/Makefile.am:
928 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
931 2007-06-12 Murray Cumming <murrayc@murrayc.com>
933 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
934 NULL, so that the signals get all the keys. This should not actually
935 change any behaviour because we currently update everything when anything
938 2007-06-12 Murray Cumming <murrayc@murrayc.com>
940 * src/widgets/modest-folder-view.c: (text_cell_data),
941 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
942 (find_inbox_iter): If tinymail tells us that the folder is
943 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
944 This causes the inbox to be selected at startup, fixing part of
945 projects.maemo.org bug NB#56305.
947 * src/modest-ui-dimming-rules.c:
948 (modest_ui_dimming_rules_on_tools_smtp_servers):
949 * src/modest-ui-dimming-rules.h: Added a callback function to dim
950 the SMTP servers menu item.
951 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
952 that the SMTP Servers menu item is dimmed when there are no accounts,
953 as a future version of the UI spec will require. This fixes
954 projects.maemo.org bug NB#56305.
956 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
958 * src/maemo/modest-maemo-utils.c:
959 (modest_maemo_utils_get_supported_secure_authentication_methods):
960 Added label to dialog instead of unreadable title
962 * src/maemo/modest-main-window.c: (sync_accounts_cb),
963 (modest_main_window_new):
964 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
967 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
968 * src/modest-account-mgr.h:
969 Added method to avoid code duplication
971 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
972 (modest_ui_actions_on_send_receive):
973 Use modest_account_mgr_has_accounts
975 2007-06-11 Murray Cumming <murrayc@murrayc.com>
977 * src/maemo/easysetup/modest-presets.c:
978 (modest_presets_get_info_server_security): Do not report secure auth
980 * src/modest-protocol-info.c: Use the defines for the gconf key names
981 for secure authentication. This was not working because we were writing
982 Password and reading password, and the check was case sensitive.
983 With this, gmail now works for receiving and sending when created via
986 2007-06-11 Murray Cumming <murrayc@murrayc.com>
988 * src/maemo/easysetup/modest-presets.c:
989 (modest_presets_get_info_server_security): Correct the key name for
990 SecureSmtp, because it seems to be case-sensitive.
991 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
992 Do not try to get the 0th notebook page if there are 0 pages, to
995 2007-06-11 Murray Cumming <murrayc@murrayc.com>
997 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
998 Prevent use of the new notification feature for now, because it currently
999 shows one dialog for each new email, which is annoying.
1001 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1003 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1004 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1005 when no country was selected, so that we show the global ones.
1006 * src/maemo/easysetup/modest-presets.c:
1007 (modest_presets_get_providers): Return only the global providers, not
1008 all providers when mmc=0 was requested.
1010 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1012 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1013 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1014 provider ID in the combo.
1016 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1017 Do not show the page numbers, because it would be confusing when we add
1018 the 2 extra pages for the custom setup, when the user chooses the "Other"
1019 provider. This fixes projects.maemo.org bug NB#59028
1021 * src/modest-init.c: (modest_init_init_core),
1022 (modest_init_local_folders):
1023 * src/modest-init.h:
1024 * src/modest-tny-account.c:
1025 (modest_tny_account_new_for_local_folders): Do not create default folders
1026 for the memory card. This should fix projects.maemo.org bug NB#59328.
1028 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1030 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1031 Free the changed_conf_keys string items. They are already freed in the
1032 idle handler if that runs first.
1034 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1036 * src/modest-ui-actions.c:
1037 (modest_ui_actions_on_password_requested): Check that the server name
1038 is not NULL, because I just saw a password dialog with (null) as the
1041 * src/modest-tny-folder.[h|c]: Added
1042 modest_tny_folder_is_memory_card_folder().
1043 * src/modest-ui-dimming-rules.c:
1044 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1045 menu item for memory cards, as per the UI spec (section 7.4). This should
1046 fix projects.maemo.org bug NB#59297.
1048 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1050 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1051 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1052 is another problem with the code, see Murray's comment at line 772)
1054 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1056 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1057 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1058 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1059 (load_from_file), (easysetup_country_combo_box_init),
1060 (easysetup_country_combo_box_get_active_country_ids),
1061 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1062 instead of just one ID, to avoid duplicate country names in the UI.
1064 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1065 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1066 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1067 a single ID, avoiding duplicate providers.
1068 * src/maemo/easysetup/modest-easysetup-wizard.c:
1069 (on_combo_account_country): Adapt to use a list.
1071 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1074 keys changed in the last X seconds.
1076 * src/modest-account-mgr.h:
1077 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1078 (on_key_change), (modest_account_mgr_class_init),
1079 (modest_account_mgr_init), (modest_account_mgr_finalize):
1080 As the keys are changed, save them in a GSList* and signal that GSList*
1081 further every X seconds, to batch changes, to allow us to do just one
1082 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1083 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1085 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1086 changed signal signature.
1088 * src/modest-conf.c: (modest_conf_set_list),
1089 (modest_conf_on_change): Reenable notification.
1091 (modest_conf_maemo_fake_on_change): Comment out the hack that
1092 notified immediately instead of asynchronously.
1094 * src/widgets/modest-account-view.h:
1095 * src/widgets/modest-account-view.c:
1096 (update_account_view): Select the previously-selected account ID,
1097 if possible. This fixes projects.maemo.org bug NB#56933.
1099 (on_account_changed), (on_account_removed),
1100 (modest_account_view_select_account):
1102 Remove the block/unblock functions
1103 because they were not useful.
1105 * src/maemo/modest-account-view-window.c:
1106 (on_delete_button_clicked), (on_edit_button_clicked),
1107 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1109 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1111 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1112 Improve the error dialog to show Incorrect Account Settings, which seems
1113 clearer, and say that the internal error message (to be removed from the
1114 dialog later) is often misleading.
1115 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1117 * src/modest-tny-account.c:
1118 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1119 URL because this is so useful for debugging on the device.
1121 * src/widgets/modest-serversecurity-combo-box.c:
1122 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1124 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1126 * src/modest-mail-operation.c:
1127 (modest_mail_operation_send_new_mail):
1128 Added a comment about a nasty but apparently harmless message. Details
1129 added to the wiki g_warnings() page.
1131 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1133 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1134 (modest_tny_send_queue_class_init):
1135 Do not use the priv struct because it is empty, to avoid g_warnings
1136 about a non-existant priv struct.
1138 * src/modest-tny-account-store.c:
1139 (modest_tny_account_store_get_server_account),
1140 (modest_tny_account_store_get_transport_account_for_open_connection
1141 ): Do not try to get transport server accounts for local folders,
1142 because they don't have any. This avoids a g_warning().
1144 * src/maemo/modest-main-window.c:
1145 (modest_main_window_notify_send_receive_initied),
1146 (on_configuration_key_changed):
1147 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1148 * src/modest-defs.h:
1149 * src/modest-mail-operation.c:
1150 (modest_mail_operation_update_account):
1151 * src/modest-tny-account-store.h:
1152 * src/modest-tny-account.c:
1153 (modest_tny_account_get_special_folder),
1154 (modest_tny_account_new_for_local_folders),
1155 (modest_tny_account_new_for_per_account_local_outbox_folder):
1156 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1157 * src/modest-tny-local-folders-account.c:
1158 (add_account_folders_to_merged_folder):
1159 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1160 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1161 (modest_ui_actions_on_send):
1162 * src/widgets/modest-folder-view.c: (update_model):
1163 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1164 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1165 modest_tny_account_store_get_tny_account_by_account() to
1166 modest_tny_account_store_get_server_account() to make the code clearer.
1168 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1170 * src/dbus_api/modest-dbus-api.h:
1171 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1172 * src/maemo/modest-msg-edit-window.c:
1173 (modest_msg_edit_window_attach_file_noninteractive):
1174 added g_warning in case the file to be attached does not exist
1175 * tests/dbus_api/test_compose_mail.c: (main):
1176 removed obsolete comment, added generic files as test case
1178 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1180 * src/modest-tny-account-store.c: (get_server_accounts):
1181 Create the local folders account only once, not once for each outbox, and
1182 not only when there are some outboxes.
1184 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1186 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1187 code that is causing a crash at startup. Sergio says that he is fixing this.
1189 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1191 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1192 * src/maemo/modest-account-settings-dialog.c:
1193 (create_page_outgoing),
1194 (modest_account_settings_dialog_set_account_name),
1195 (save_configuration):
1196 - Fixed handling of the "Use secure authentication" toggle to comply with
1197 the ui specification. See also projects.maemo.org bug NB#58400
1199 - Restore the Secure connection setting combo correctly when loading
1202 * src/maemo/modest-maemo-utils.c:
1203 (on_camel_account_get_supported_secure_authentication),
1204 (modest_maemo_utils_get_supported_secure_authentication_methods):
1205 Fixed a crasher if operation is canceled
1207 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1208 (modest_protocol_info_auth_is_secure):
1209 * src/modest-protocol-info.h:
1211 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1212 the sense of the "Use secure authentication" toggle.
1214 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-tny-account-store.h:
1217 * src/modest-tny-account-store.c:
1218 Added modest_tny_account_store_get_local_folders_account().
1220 * src/modest-tny-folder.h:
1221 * src/modest-tny-folder.c:
1222 (modest_tny_folder_get_account):
1223 Added this replacement for tny_folder_get_account() which returns
1224 the local-folders account for TnyMergeFolders, to avoid the
1225 warning about the unimplemented get_account_func() vfunc().
1227 (modest_tny_folder_get_rules),
1228 * src/modest-ui-actions.c:
1229 (modest_ui_actions_on_folder_selection_changed):
1230 * src/modest-mail-operation.c:
1231 (modest_mail_operation_remove_folder),
1232 (modest_mail_operation_xfer_folder),
1233 (modest_mail_operation_rename_folder),
1234 (modest_mail_operation_get_msg),
1235 (modest_mail_operation_get_msgs_full),
1236 (modest_mail_operation_remove_msg),
1237 (modest_mail_operation_xfer_msgs),
1238 (modest_mail_operation_refresh_folder):
1239 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1241 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1243 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1244 (modest_server_account_set_security):
1245 * src/modest-defs.h: Add comments explaining that our
1246 UI spec means TLS when it says Normal, so these do not look like errors.
1248 * src/modest-tny-account.c:
1249 (modest_tny_account_new_from_server_account): Use the new tinymail
1250 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1251 for TLS. This should fix projects.maemo.org bug NB#58460.
1253 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/easysetup/modest-easysetup-wizard.c:
1256 (create_account): Correct the position of the gconf sanity check warning.
1257 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1258 of using the g_idle_add() hack, because this does not seem to be necessary
1259 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1260 caused by something other than maemo's gconf.
1261 This fixes projects.maemo.org bug #59022.
1263 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-account-mgr-helpers.c:
1266 (modest_account_mgr_get_default_account): Do not check that the account
1267 exists if there is no default account (NULL), to fix a runtime warning.
1269 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1271 * src/widgets/modest-folder-view.c: (update_model):
1272 Do not unref the treemodel before we have finished with it.
1273 This prevents a valgrind warning and an occasional crash at startup.
1275 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1277 * libmodest-dbus-client/libmodest-dbus-client.h:
1278 added libmodest_dbus_client_compose_mail()
1279 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1281 added functions needed for SendAsMail() functionality
1282 * src/maemo/modest-msg-edit-window.c:
1283 (modest_msg_edit_window_attach_file_noninteractive):
1284 non interactively attaching files to message edit window
1285 * src/widgets/modest-msg-edit-window.h:
1286 * tests/dbus_api/Makefile.am:
1287 added test_compose_mail.c
1288 * tests/dbus_api/test_compose_mail.c: (main):
1290 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1292 * src/modest-account-view.c:
1293 Fixed bug projects.maemo.org bug NB#59307
1295 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1297 * src/maemo/easysetup/modest-easysetup-wizard.c:
1298 (get_serverport_incoming), (on_before_next), (create_account):
1299 * src/maemo/modest-account-settings-dialog.c:
1300 (modest_account_settings_dialog_set_account_name):
1301 * src/maemo/modest-maemo-utils.c:
1302 (on_camel_account_get_supported_secure_authentication_status),
1303 (on_camel_account_get_supported_secure_authentication),
1304 (on_secure_auth_cancel),
1305 (modest_maemo_utils_get_supported_secure_authentication_methods):
1307 Implemented security authentication for settings and easysetup.
1309 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1311 * src/maemo/modest-main-window.c: (create_details_widget):
1312 Show the total size for memory card accounts too, instead of showing
1313 the name again. Fixes bug projects.maemo.org bug NB#59307.
1315 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1318 * src/modest-tny-simple-folder-store.c:
1319 * src/modest-tny-simple-folder-store.h: Removed.
1321 * src/modest-tny-local-folders-account.h
1322 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1323 for the local-folders maildir, with an extra TnyMergedFolder containing
1324 the folders of the per-account outbox store accounts.
1325 * src/modest-tny-account-store.c: (get_server_accounts):
1326 Add the outboxes to the special local folders account after creating it.
1328 * src/modest-tny-account.c:
1329 (modest_tny_account_new_for_local_folders): Create the derived
1330 account when creating the main local-folders account.
1332 * src/maemo/modest-main-window.c: (create_details_widget),
1333 (modest_main_window_set_contents_style):
1334 Adapted to the use of the derived account instead of the folder store.
1336 * src/modest-ui-actions.c:
1337 (modest_ui_actions_on_folder_selection_changed):
1338 * src/modest-ui-dimming-rules.c:
1339 (modest_ui_dimming_rules_on_new_folder):
1340 * src/widgets/modest-folder-view.c: (text_cell_data),
1341 (icon_cell_data), (filter_row), (update_model),
1342 (get_cmp_rows_type_pos):
1345 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1346 Do not get the priv struct, because no priv struct has been set,
1347 to avoid a runtime warning.
1349 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1350 #ifelse with #else, to fix a warning, to fix the build.
1353 2007-06-05 Christian Kellner <ckellner@openismus.com>
1355 * libmodest-dbus-client/libmodest-dbus-client.c:
1356 Fix small typo in doc (why do you always see them
1357 AFTER committing stuff?)
1360 2007-06-05 Christian Kellner <ckellner@openismus.com>
1362 * libmodest-dbus-client/libmodest-dbus-client.c:
1363 (libmodest_dbus_client_search):
1364 Initialize hit list with NULL. Also set folder list
1365 to "" if NULL was supplied.
1368 2007-06-03 Christian Kellner <ckellner@openismus.com>
1370 * libmodest-dbus-client/libmodest-dbus-client.c:
1371 (modest_search_hit_list_free):
1372 Make it save to call it with NULL.
1374 * src/dbus_api/modest-dbus-callbacks.c:
1375 * src/modest-search.c:
1376 Return full ModestSearchHits as the search result list not TnyHeader
1377 since can't be around withouth the correspoding TnyFolder.
1379 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1381 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1382 Added currently commented code to check for secure auth
1384 * src/maemo/modest-account-settings-dialog.c: (on_response),
1385 (save_configuration), (show_ok):
1386 Fixed projects.maemo.org bugs NB #59248 and #59251
1388 * src/maemo/modest-maemo-utils.c:
1389 (on_camel_account_get_supported_secure_authentication_status),
1390 (on_camel_account_get_supported_secure_authentication),
1391 (modest_maemo_utils_get_supported_secure_authentication_methods):
1392 * src/maemo/modest-maemo-utils.h:
1393 Moved get_supported_secure_authentication() method here to be able
1394 to use it from easysetup wizard.
1396 * src/modest-pair.c: (on_pair_compare_as_string):
1397 Should compare string with first part of pair and not
1398 strcmp pairs which will crash.
1400 * src/modest-protocol-info.c:
1401 (modest_protocol_info_protocol_is_store):
1402 * src/modest-protocol-info.h:
1403 Added modest_protocol_info_get_auth_protocol_name()
1405 2007-06-03 Armin Burgmeier <armin@openismus.com>
1407 * src/modest-mail-operation.c:
1408 (modest_mail_operation_get_msgs_full): Set priv->account also when
1409 only retrieving a single message. This avoids a crash when canceling
1412 (modest_mail_operation_notify_end): Do not explicitely remove the
1413 operation from the queue but only emit the progress_changed signal.
1414 The queue itself listens to that signal to remove the operation when
1415 it is finished. This reduces coupling and removes a potential deadlock
1416 when modest_mail_operation_notify_end() is called from the queue
1417 itself. If that is a problem performance-wise, I would suggest to
1418 implement a status-changed signal or something.
1420 * src/modest-mail-operation-queue.c: Make sure to never call a
1421 function from another file while the queue is locked. This (hopefully)
1422 fixes another deadlock when exiting the application while retrieving
1425 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1427 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1428 Fixed build if libogs is not available
1430 2007-06-03 Christian Kellner <ckellner@openismus.com>
1432 * libmodest-dbus-client/libmodest-dbus-client.h:
1433 * libmodest-dbus-client/libmodest-dbus-client.c:
1434 (libmodest_dbus_client_delete_message):
1435 Implement deletion of messages (Client side).
1437 (modest_search_hit_free),
1438 (modest_search_hit_list_free):
1439 Utility functions to free the result hits.
1441 * src/dbus_api/modest-dbus-api.h:
1442 * src/dbus_api/modest-dbus-callbacks.c:
1443 (on_delete_message),
1444 (modest_dbus_req_handler):
1445 Implement deletion of messages (Server side).
1447 * tests/dbus_api/test_search.c: (main):
1450 * tests/dbus_api/Makefile.am:
1451 * tests/dbus_api/test_delete_message:
1452 Add little test for the message deletion logic
1454 2007-06-03 Armin Burgmeier <armin@openismus.com>
1456 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1457 when the operation queue was not empty. projects.maemo.org bug
1460 2007-06-03 Armin Burgmeier <armin@openismus.com>
1462 * src/widgets/modest-account-view.c
1463 (on_account_default_toggled): Toggle default account column
1464 explicitely instead of waiting for gconf notification (which is
1465 currently ignored). This should fix projects.maemo.org bug NB#56910
1466 for now. It should probably be removed when gconf notifications are
1469 2007-06-03 Christian Kellner <ckellner@openismus.com>
1471 * libmodest-dbus-client/libmodest-dbus-client.c:
1472 Removed debugging spew.
1474 * src/dbus_api/modest-dbus-callbacks.c:
1475 Added debugging info.
1477 * src/modest-search.c:
1478 (modest_search_all_accounts):
1479 Use tny_account_store_get_accounts () on the account store
1480 to get all accounts which is the way to get all accounts.
1482 * tests/dbus_api/test_search.c: (main):
1483 Make it possible to supply the search term on the command line.
1485 2007-06-03 Christian Kellner <ckellner@openismus.com>
1487 * libmodest-dbus-client/libmodest-dbus-client.c:
1488 * libmodest-dbus-client/libmodest-dbus-client.h:
1489 Implement searching for mesages over raw dbus. (Client side)
1491 * src/dbus_api/Makefile.am:
1492 * src/dbus_api/modest-dbus-api.h:
1493 * src/dbus_api/modest-dbus-callbacks.c:
1494 * src/dbus_api/modest-dbus-callbacks.h:
1495 Search framework (Server side). Also implement on_idle_open_message().
1497 * src/maemo/modest-platform.c: (modest_platform_init):
1498 Prepare for raw dbus/osso rpc interaction.
1500 * src/modest-search.h:
1501 Changed minsize from unspecific guint to guint32.
1503 * src/modest-search.c:
1505 Added strange hack which magically made tnymail work.
1507 (modest_search_folder),
1508 (modest_search_account),
1509 (modest_search_all_accounts):
1510 Implement helper functions to search all accounts, specific account
1513 * tests/dbus_api/Makefile.am:
1514 * tests/dbus_api/test_open_message.c:
1515 Read url to open from commandline.
1517 * tests/dbus_api/test_search.c:
1518 Implement small test for dbus search stuff
1520 2007-06-02 Armin Burgmeier <armin@openismus.com>
1522 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1523 include account type and account title. This fixes projects.maemo.org
1526 * src/maemo/modest-account-view-window.c: Set a title for the window.
1528 2007-06-02 Armin Burgmeier <armin@openismus.com>
1530 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1531 incoming and outgoing server name based on email address and server
1532 types as long as the names have not been edited manually. This fixes
1533 projects.maemo.org bug NB#58671.
1535 2007-06-02 Armin Burgmeier <armin@openismus.com>
1537 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1538 server type cannot be changed in future to the incoming details page
1539 when creating an account. This fixes projects.maemo.org bug NB#59029.
1541 2007-06-02 Armin Burgmeier <armin@openismus.com>
1543 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1544 and assigned max width chars so that they wrap instead of being
1545 truncated. Fixes projects.maemo.org bug NB#56126.
1547 2007-06-02 Armin Burgmeier <armin@openismus.com>
1549 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1550 introductory note to the connection specific smtp servers dialog, as
1551 section 8.12 of the email UI specification requires. This fixes
1552 projects.maemo.org bug NB#59212.
1554 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1556 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1557 Check for running mail operations, and offer to cancel them, as per the UI
1558 spec. This fixes projects.maemo.org bug NB#59041 .
1559 However, I suspect that tinymail may still use the network connection
1560 in ways that we cannot detect or cancel. But it should at least adapt to
1561 changes fairly well.
1563 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-tny-account-store.c: (recreate_all_accounts),
1566 (get_cached_accounts), (get_server_accounts): Do more sensible
1567 ref-counting of the temporarily-cached outbox accounts list. This seems
1568 to fix a crash when entering the password when the password was wrong.
1570 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1572 * src/gnome/modest-main-window.c: (connect_signals):
1573 * src/modest-tny-account-store.c: (get_password),
1574 (modest_tny_account_store_alert): Added comments and clues and
1575 commented-out code about how we currently fail to deal with connection
1576 errors and wrong passwords, and how we should.
1578 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1580 * src/widgets/modest-retrieve-combo-box.c:
1581 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1582 This fixes projects.maemo.org bug NB#58472 .
1584 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1586 * src/maemo/easysetup/modest-easysetup-wizard.c:
1587 (create_page_complete_easysetup):
1588 (create_page_complete_custom): Correct the last commit,
1589 putting the correct sentences in the correct pages.
1591 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/easysetup/modest-easysetup-wizard.c:
1594 (create_page_complete_custom): Show the second sentence of text
1595 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1598 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1600 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1601 Set the leave-on-server conf key by default. This fixes
1602 projects.maemo.org bug NB#59258 .
1604 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1606 * src/maemo/modest-account-view-window.c:
1607 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1608 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1611 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/easysetup/modest-easysetup-wizard.c:
1614 (create_caption_new_with_asterisk):
1615 * src/maemo/modest-account-settings-dialog.c:
1616 (create_caption_new_with_asterisk):
1617 Uncomment the code to add the asterisk, because they are no longer in the
1618 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1619 (update_incoming_server_title): Add an asterisk here too.
1621 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1623 * src/maemo/modest-maemo-global-settings-dialog.c:
1624 (current_connection): Check that we are even connected before trying to
1625 get the current connection name, to prevent a warning.
1627 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1628 Change the comments because tny_maemo_conic_device_connect() is now meant to
1630 * src/modest-mail-operation.c:
1631 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1632 make sure we have a connection and fail if we can't connect.
1634 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1636 * src/maemo/modest-main-window.c:
1637 (on_account_store_connecting_finished): Do not try to get the
1638 connection ID if we are not really connected. I am surprised that
1639 this signal handler is called when we are not connected.
1641 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1643 * src/modest-error.h:
1644 * src/modest-ui-actions.c:
1645 (modest_ui_actions_get_msgs_full_error_handler):
1646 Renamed an enum, added comments, added an enum
1647 for retrieve-limit errors.
1649 * src/modest-mail-operation.c: (foreach_add_item),
1650 (internal_folder_observer_update), (update_account_thread),
1651 (modest_mail_operation_get_msgs_full):
1652 (modest_mail_operation_update_account),
1653 Added comments about how this works, and some code that should
1654 (but does not) check the retrieve-limit. See the TODO comment.
1656 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1659 Initialize help_id to fix the build. Warnings are good.
1661 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1663 * src/widgets/modest-hbox-cell-renderer.c:
1664 (modest_hbox_cell_renderer_append):
1665 * src/widgets/modest-vbox-cell-renderer.c:
1666 (modest_vbox_cell_renderer_append):
1667 Fix the last commit by doing an extra ref.
1669 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1671 * src/widgets/modest-hbox-cell-renderer.c:
1672 (modest_hbox_cell_renderer_append):
1673 * src/widgets/modest-vbox-cell-renderer.c:
1674 (modest_vbox_cell_renderer_append):
1675 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1676 to fix the build with Maemo Bora.
1677 However, there seems to be a remaining crash, probably due to reference
1680 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1682 * src/modest-tny-account.c:
1683 (modest_tny_account_new_for_local_folders):
1684 Use hildon_file_system_info_async_new() to get a better name for
1685 the memory card account, setting it as the account name.
1686 The timing seems to work, but this is probably
1687 not the best place to do this. See the TODO comment.
1688 * src/maemo/modest-main-window.c: (create_details_widget):
1689 * src/widgets/modest-folder-view.c: (text_cell_data):
1690 Use the tny account name instead of hardcoding a name.
1692 2007-05-30 Christian Kellner <ckellner@openismus.com>
1694 * src/modest-search.c: (modest_search):
1695 Correctly set part_search_func even if we have already parsed
1696 the query and thus a valid OgsTextSearcher object.
1698 2007-05-30 Christian Kellner <ckellner@openismus.com>
1701 Search and check for libogs.
1704 Incooparte the ogs build env.
1706 * src/modest-mime-part-search-stream.c:
1707 * src/modest-mime-part-search-stream.h:
1708 Removed since we do the real searching now in modest-search.c.
1710 * src/modest-search.c:
1711 * src/modest-search.h:
1712 Implement support for ogs. We use that if available and requested
1713 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1714 should now handle the corner case when the search term is spread
1715 across multiple reads.
1716 Also the logic in modest_search () was corrected to search all
1717 requested fields until one is found.
1719 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1721 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1723 * src/modest-init.h:
1724 * src/modest-init.c: Made modest_init_local_folders() take a
1725 path and be public so we can iniitialize maildir folders on
1728 * src/modest-local-folder-info.h:
1729 * src/modest-local-folder-info.c:
1730 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1732 * src/modest-tny-account.c:
1733 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1734 still means the standard local-folders path on the local volume.
1736 * src/modest-tny-account-store.c:
1737 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1738 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1739 all accounts when that happens.
1740 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1741 this too, so it shows up in the treeview.
1743 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1745 * src/maemo/modest-maemo-global-settings-dialog.c:
1746 (current_connection):
1747 * src/widgets/modest-global-settings-dialog.c:
1748 (current_connection_default):
1749 Use the enum values instead of 0, 1 and -1,
1750 to make the code clearer.
1752 * src/modest-account-mgr-helpers.c:
1753 (modest_account_mgr_get_connection_specific_smtp): Make this code
1756 * src/modest-runtime.h:
1757 * src/modest-runtime.c:
1758 Added modest_runtime_remove_all_send_queues().
1759 * src/maemo/modest-main-window.c:
1760 (on_account_store_connecting_finished): Recreate the send queues,
1761 using the appropriate transport accounts for this new connection.
1762 Some futher adapting might be needed if the old send queues are not
1763 automatically stopped at this point.
1765 * src/modest-tny-account-store.c: (get_server_accounts):
1766 Create the connection-specific transport accounts, so that they can
1767 be found later by their ID.
1769 * src/modest-tny-account.h:
1770 * src/modest-tny-account.c:
1771 Added modest_tny_account_new_from_server_account_name().
1772 modest_tny_account_new_from_server_account(): Do not create the
1773 send queues here, because they will be
1774 recreated anyway when the connection changes for the first time.
1776 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1778 * src/modest-local-folder-info.h:
1779 * src/modest-local-folder-info.c:
1780 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1781 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1782 tbox_folder): Take a modest account name instead of a server TnyAccount,
1783 so we can have per-modest-account rather than per-transport-account
1785 We must make sure that we change or recreate the exisitng send queues
1786 when the connection changes for connection-specific transport accounts.
1788 * src/modest-tny-account-store.c:
1789 (create_per_account_local_outbox_folders): Create outboxed per modest
1790 account, not per transport account.
1792 * src/modest-tny-account.h:
1793 * src/modest-tny-account.c:
1794 (modest_tny_account_get_special_folder): For outboxes, get the
1795 parent modest account name. The account is ignored for other folders.
1796 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1797 modest account name rather than a server TnyAccount.
1799 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-tny-account.c:
1802 (modest_tny_account_new_from_server_account):
1803 Call modest_runtime_get_send_queue() immediately after creating transport
1804 accounts, so that they start trying to send email from the outbox as soon
1805 as possible at startup. This is probably what we want.
1807 * src/modest-mail-operation.c: (update_account_thread):
1808 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1809 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1810 * src/modest-tny-send-queue.h:
1811 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1812 (modest_ui_actions_on_send):
1813 Added comments about how sending works, though it needs some more work.
1815 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1817 * src/modest-tny-account.c:
1818 (modest_tny_account_get_special_folder): Add TODO because this fails when
1819 the network is busy.
1820 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1821 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1822 Do not try to show this window when there is no active account. The UI
1823 specs does not tell us what to do in this case.
1825 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1829 * src/maemo/Makefile.am:
1830 * src/widgets/Makefile.am: Some dist fixes.
1832 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1834 * src/maemo/modest-connection-specific-smtp-window.c:
1835 (on_button_edit): Make the code clearer, to prevent a double free.
1837 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1839 * src/maemo/modest-account-settings-dialog.c:
1840 (modest_account_settings_dialog_set_account_name),
1841 Check the connection-specific smtp servers checkbox if there are any.
1843 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1844 (modest_connection_specific_smtp_edit_window_init):
1845 Start with a suitable port number.
1847 * src/modest-account-mgr-helpers.h:
1848 * src/modest-account-mgr-helpers.c: Added
1849 modest_account_mgr_get_has_connection_specific_smtp().
1851 (modest_account_mgr_set_connection_specific_smtp),
1852 (modest_account_mgr_remove_connection_specific_smtp),
1853 (modest_account_mgr_get_has_connection_specific_smtp),
1854 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1855 connection-specific smtp server accounts in the account, rather than
1856 the server account conf dir.
1858 This fixes bug projects.maemo.org bug NB#58263 .
1860 * src/modest-tny-account-store.c:
1861 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1862 if there are no server accounts yet, to prevent an infinite loop when there
1863 are no accounts. Document that one must be called before the other.
1865 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1867 * src/modest-account-mgr-helpers.c:
1868 (modest_account_mgr_get_default_account): Make sure that at least
1869 one account is always the default, if there are any enabled accounts.
1870 This is just a sanity check that shouldn't be necessary.
1872 * src/modest-account-mgr-priv.c:
1873 (_modest_account_mgr_account_from_key): Unescape the conf key to
1874 get the real account name. For instance, this is an issue if a space
1875 was in the account name, which can happen because the account name
1876 is generated from the display name.
1877 (_modest_account_mgr_get_account_keyname): Always escape the
1879 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1880 Unescape the conf keys to get the real account names.
1882 For instance, previously the is-default radio button in the accounts
1883 list was not checked for any accounts at first. This fixes that,
1884 and might fix several similar bugs.
1886 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1888 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1889 Removed some debug printfs.
1891 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1893 Modest on-disk outbox directories are now here, for instance:
1894 $HOME/.modest/outboxes/<account-id-1>/outbox
1895 $HOME/.modest/outboxes/<account-id-2>/outbox
1897 $HOME/.modest/local-folders/outbox
1898 so we can have a separate outbox for each account.
1899 But they are shown as one outbox in the GtkTreeView, by using a
1900 TnyMergeFolder in a ModestTnySimpleFolderStore.
1903 * src/modest-tny-simple-folder-store.c:
1904 * src/modest-tny-simple-folder-store.h:
1905 Added ModestTnySimpleFolderStore, used to contain folders from
1906 other folder stores, such as other accounts.
1908 * src/modest-tny-outbox-account.h:
1909 * src/modest-tny-outbox-account.c:
1910 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1911 used for the per-account local outbox folders.
1913 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1914 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1915 only use this (internally) now for the non-outbox local folders.
1917 * src/modest-init.h:
1918 * src/modest-init.c: Added modest_init_one_local_folder(), for
1919 setting up the directory structure for each local folder.
1921 * src/modest-local-folder-info.c:
1922 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1923 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1925 * src/modest-local-folder-info.h:
1926 * src/modest-tny-account-store.c: (on_account_removed),
1927 (on_account_changed), (create_per_account_local_outbox_folders),
1928 (get_server_accounts), (modest_tny_account_store_get_accounts),
1929 (modest_tny_account_store_get_tny_account_by_account),
1930 (modest_tny_folder_store_is_virtual_local_folders):
1932 * src/modest-tny-account.h:
1933 * src/modest-tny-account.c:
1934 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1935 to create an on-disk per-account local outbox folder for each
1937 (create_per_account_local_outbox_folders): Create a local outbox folder
1938 for each transport account.
1939 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1940 for all local folders.
1942 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1943 instead of using g_object_get/set() directly. It is clearer.
1945 (modest_tny_folder_store_get_message_count),
1946 (modest_tny_folder_store_get_local_size
1947 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1948 because we now use these with non-acount folder stores.
1950 (modest_tny_account_get_special_folder),
1951 (modest_tny_account_new_from_server_account),
1952 (modest_tny_account_new_from_account):
1953 (recurse_folders): Adjust to the new outbox system.
1955 * src/modest-tny-folder.h:
1956 * src/modest-tny-folder.c:
1957 (modest_tny_folder_is_local_folder),
1958 (modest_tny_folder_get_local_folder_type),
1959 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1961 * src/widgets/modest-main-window.h:
1962 * src/maemo/modest-main-window.c: (create_details_widget),
1963 (modest_main_window_set_contents_style): Show details for any folder store,
1966 (modest_tny_folder_get_rules):
1967 Remove the const. C does not support constness enough for this.
1969 * src/modest-ui-actions.c:
1970 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1971 make all outboxes appear as one, in the usual local-folders tree node.
1973 (set_active_account_from_tny_account),
1974 (modest_ui_actions_on_folder_selection_changed):
1975 * src/widgets/modest-folder-view.c: (text_cell_data),
1976 (icon_cell_data), (filter_row),
1977 (add_account_folders_to_merged_folder),
1978 (add_account_folders_to_simple_folder_store), (),
1979 (get_cmp_rows_type_pos), (cmp_rows),
1980 (modest_folder_view_set_account_id_of_visible_server_account):
1981 Adjust to the new outbox system, using generic folder stores and folders
1982 in the GtkTreeModel.
1984 2007-05-23 Christian Kellner <ckellner@openismus.com>
1986 * src/modest-mail-operation.c:
1987 (modest_mail_operation_update_account):
1988 Use info->max_size instead of unintialized local var [small
1989 build fix]. (Added TODO to review that change since I don't
1992 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1994 * libmodest-dbus-client/libmodest-dbus-client.c:
1995 (libmodest_dbus_client_compose_mail): function added
1996 * src/dbus_api/modest-dbus-api.h:
1997 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1998 (on_compose_mail): Implementation of the SendAsMail functionality
2000 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2002 * src/modest-account-mgr.c:
2003 (modest_account_mgr_add_server_account): Set the secure-connection
2004 conf key for transport accounts as well as store accounts. I don't know
2005 why the if was there. For instance, this makes sure that we use SSL
2006 for the gmail preset from the easysetup wizard.
2008 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2010 * src/gnome/modest-main-window.c:
2011 (on_account_store_connecting_finished), (connect_signals):
2012 * src/maemo/modest-main-window.c:
2013 (on_account_store_connecting_finished), (connect_signals),
2014 (modest_main_window_new):
2015 Handle TnyAccountStore::connecting-finished instead of
2016 TnyDevice::connection-changed, because we cannot actually perform
2017 operations on accounts until TnyAccountStore has itself responded to
2018 the TnyDevice::connection-changed signal. This prevents a GError from
2020 Do not try to update at startup, because we (at least on scratchbox)
2021 already do an update at startup when the device goes online.
2022 This prevents a GError from tinymail.
2023 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2024 Added TODO about stopping simultaneous operations.
2026 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2028 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2029 * src/modest-mail-operation-queue.c:
2030 (modest_mail_operation_queue_remove):
2031 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2032 about where they happened.
2034 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2036 * src/modest-ui-actions.c:
2037 (modest_ui_actions_on_password_requested): Make sure that the remember
2038 output parameter is always TRUE.
2040 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2042 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2043 Show a OK/Cancel dialog if the error is a question, though we still do not
2044 know anything more about what we are asking the user.
2045 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2046 Fix an uninitialized variable (helper). This is a logic error, however.
2048 2007-05-21 Christian Kellner <ckellner@openismus.com>
2050 * src/modest-search.h:
2051 Correct bit shifting in the ModestSearchFlags enum.
2053 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2055 * src/modest-tny-account.c:
2056 (modest_tny_account_new_from_server_account): Do not use the lsub and
2057 check-all hard-coded IMAP options when using POP.
2059 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2061 * src/modest-tny-account.c:
2062 (modest_tny_account_new_from_server_account):
2063 Use NULL for the secure-auth method for POP when Password auth has been
2064 specified by the user, as we already do for IMAP. "auth=Login" causes
2065 an error from camel or the server.
2067 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/modest-account-settings-dialog.c:
2070 (create_page_account_details),
2071 (modest_account_settings_dialog_set_account_name):
2072 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2073 for the leave-on-server checkbox, rathr than just the checkbox, when
2074 the protocol is not POP.
2076 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2078 * src/widgets/modest-account-view.c:
2079 * src/widgets/modest-account-view.h:
2080 Added modest_account_view_select_account() which will be useful later
2081 to asynchronously re-select the edited account.
2083 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2085 * src/maemo/modest-account-settings-dialog.c:
2086 (modest_account_settings_dialog_set_account_name):
2087 Automatically choose the port numbers based on the secure authentication
2088 methods, if they have not been chosen before.
2089 This fixes projects.maemo.org bug NB#56273 .
2091 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2093 * src/maemo/modest-main-window-ui.h:
2094 * src/modest-ui-actions.c:
2095 * src/modest-ui-actions.h:
2096 Connect the Tools/SMTP Servers menu item to
2097 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2098 SMTP servers dialog, as in the UI specification and saves changes when it
2099 is closed. This fixed projects.maemo.org bug NB#56305 .
2101 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2103 * src/maemo/modest-connection-specific-smtp-window.c:
2104 (modest_connection_specific_smtp_window_init):
2105 Use gtk_window_set_default_size() to make this window big enough, so
2106 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2108 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2110 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2111 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2112 (modest_connection_specific_smtp_edit_window_init),
2113 Do not try to connect to a combobox signal before the combobox exists.
2114 This fixes the cras in projects.maemo.org bug NB#56288 .
2115 (modest_connection_specific_smtp_edit_window_get_settings):
2116 Remove the server_account_name parameter which was being checked for NULL
2117 though it was not used.
2119 * src/maemo/modest-connection-specific-smtp-window.c:
2120 (modest_connection_specific_smtp_window_fill_with_connections),
2121 (on_button_edit), (modest_connection_specific_smtp_window_init):
2122 Correct the number of treemodel columns to prevent a warning.
2123 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2124 libconic does not work.
2126 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-tny-account.c:
2129 (modest_tny_account_new_from_server_account):
2130 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2131 SMTP when "None" was chosen by the user. However, with my SMTP server that
2132 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2135 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2137 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2138 to explain the memory management issue with the ID in the ModestPair.
2140 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2141 (add_sending_page), (modest_account_assistant_finalize):
2142 * src/gnome/modest-gnome-global-settings-dialog.c:
2143 (create_updating_page), (create_composing_page):
2144 * src/gnome/modest-msg-edit-window.c: (get_transports),
2145 (init_window), (modest_msg_edit_window_finalize),
2146 (modest_msg_edit_window_get_msg_data):
2147 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2148 * src/gnome/modest-transport-widget.c:
2149 (modest_transport_widget_finalize), (smtp_configuration):
2150 * src/maemo/modest-maemo-global-settings-dialog.c:
2151 (create_updating_page), (create_composing_page):
2152 * src/maemo/modest-msg-edit-window.c: (get_transports),
2153 (init_window), (modest_msg_edit_window_finalize),
2154 (modest_msg_edit_window_get_msg_data),
2155 (modest_msg_edit_window_free_msg_data):
2156 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2157 (modest_store_widget_finalize):
2158 * src/maemo/modest-transport-widget.c:
2159 (modest_transport_widget_finalize), (smtp_configuration):
2160 * src/modest-main.c: (send_mail):
2161 * src/widgets/modest-combo-box.h:
2162 * src/widgets/modest-global-settings-dialog-priv.h:
2163 * src/widgets/modest-global-settings-dialog.c:
2164 (modest_global_settings_dialog_finalize):
2165 * src/widgets/modest-msg-edit-window.h:
2166 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2167 as long as the combo box, to prevent use of freed memory for the ID.
2169 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2171 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2172 get_accounts(), to make this clearer. Do not check for the enabled gconf
2173 key, because we do not use this for server accounts (at least, not yet).
2174 This allows us to send email again.
2176 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2178 * src/maemo/modest-platform.c:
2179 (on_modest_conf_update_interval_changed), (modest_platform_init):
2180 Only respond to this particular key change. All these strcmp()s cannot be
2183 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2185 * src/maemo/modest-maemo-global-settings-dialog.c:
2186 (current_connection): Prevent a crash in scratchbox when
2187 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2188 * src/maemo/modest-platform.c:
2189 (on_modest_conf_update_interval_changed), (modest_platform_init):
2190 Get the update interval from gconf and reset it when the gconf key changes.
2192 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2194 * src/modest-protocol-info.c:
2195 * src/modest-protocol-info.h: Adde enum-specific get functions,
2196 instead of using a ModestProtocolType enum parameter.
2198 * src/gnome/modest-account-assistant.c:
2199 * src/gnome/modest-store-widget.c:
2200 * src/gnome/modest-store-widget.h:
2201 * src/gnome/modest-transport-widget.c:
2202 * src/gnome/modest-transport-widget.h:
2203 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2204 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2205 * src/maemo/easysetup/modest-easysetup-wizard.c:
2206 * src/maemo/modest-account-settings-dialog.c:
2207 * src/maemo/modest-account-settings-dialog.h:
2208 * src/maemo/modest-store-widget.c:
2209 * src/maemo/modest-store-widget.h:
2210 * src/maemo/modest-transport-widget.c:
2211 * src/maemo/modest-transport-widget.h:
2212 * src/modest-account-mgr-helpers.c:
2213 * src/modest-account-mgr-helpers.h:
2214 * src/modest-account-mgr.c:
2215 * src/modest-account-mgr.h:
2216 * src/modest-tny-account.c:
2217 * src/modest-tny-folder.c:
2218 * src/widgets/modest-account-view.c:
2219 * src/widgets/modest-retrieve-combo-box.c:
2220 * src/widgets/modest-retrieve-combo-box.h:
2221 * src/widgets/modest-secureauth-combo-box.c:
2222 * src/widgets/modest-serversecurity-combo-box.c:
2223 * src/widgets/modest-serversecurity-combo-box.h:
2224 * tests/check_account-mgr.c:
2225 Use the specific functions, and use the re-renamed enum values for GNOME too.
2227 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2229 * src/modest-pair.h:
2230 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2231 so we can get the second based on the first.
2233 * src/maemo/modest-account-settings-dialog.h:
2234 * src/maemo/modest-account-settings-dialog.c:
2235 Added get_supported_secure_authentication_methods(), though it is mostly
2236 commented-out for now until the necessary API is committed to tinymail.
2237 (modest_account_settings_dialog_set_account_name),
2238 (save_configuration): Request the supported authentication methods from the
2239 server, so we can choose a working method.
2241 * src/modest-tny-account-store.h:
2242 * src/modest-tny-account-store.c:
2243 (modest_tny_account_store_get_session): Rename from
2244 tny_account_store_get_session().
2246 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2248 * src/modest-protocol-info.h: Split the ModestProtocol enum
2249 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2250 There was no need to have these unrelated values in one enum.
2252 * src/: many files: Adapted to changed enum. This makes the code a bit
2253 clearer, and the compiler could catch some errors.
2255 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2257 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2258 Show the detailed internal camel error message when an error happens
2259 during the configuration, so that our testers can give us more clues.
2260 For instance, in projects.maemo.org bug NB#56910 .
2262 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2264 * src/modest-tny-account.c:
2265 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2266 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2268 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2270 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2271 * src/maemo/modest-account-settings-dialog.c:
2272 (modest_account_settings_dialog_set_account_name),
2273 (save_configuration): For the incoming secure authentication checkbox,
2274 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2275 the UI specification. PLAIN does not seem to be supported for most IMAP
2276 servers anyway, and I am not sure what it would mean.
2277 However, we probably need to discover which of the secure-authentication
2278 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2279 * src/modest-account-mgr-helpers.c:
2280 (modest_account_mgr_get_server_account_data):
2282 * src/modest-tny-account.c:
2283 (modest_tny_account_new_from_server_account):
2284 Use tny_account_set_mech() to set secure-authentication methods,
2285 with some special-casing for IMAP, based on my observations of how
2288 * src/modest-account-mgr-helpers.h:
2289 * src/modest-account-mgr.c:
2290 * src/modest-defs.h: Comment that the URI is only used for local folders.
2292 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2294 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2295 parameter const, just to be neat.
2296 * src/modest-text-utils.c: (modest_text_utils_inline):
2297 End g_strconcat() with NULL, as its documentation says. This is almost
2298 certainly the cause of my crash at startup on the device. Interestingly,
2299 valgrind doesn't tell us about these errors.
2301 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2303 * scripts/build-packages: Added more precise comments about how to use
2304 this script, though I still get this error:
2305 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2306 error building tinymail
2308 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2310 * src/maemo/modest-main-window.c: (on_account_update):
2311 Very slight cleanup, hoping to make it simpler to discover what causes
2312 a crash here sometimes.
2314 * src/modest-tny-account.c:
2315 (modest_tny_account_new_from_server_account): Set the port. Added
2316 comments about the options and a TODO comment because I need to find out
2317 how to specify the secure authentication method.
2319 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2321 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2322 changed CFlags paths form modest to libmodest
2324 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2326 * src/modest-account-mgr-helpers.c:
2327 (modest_account_mgr_get_server_account_data),
2328 (modest_account_mgr_free_server_account_data):
2329 * src/modest-account-mgr-helpers.h:
2330 * src/modest-account-mgr.c:
2331 (modest_account_mgr_add_server_account):
2332 * src/modest-defs.h:
2333 * src/modest-tny-account.c:
2334 (modest_tny_account_new_from_server_account):
2335 Determine the options for tny_camel_account_add_option() here,
2336 based on the settings, rather than storing them directly in gconf.
2338 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2340 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2341 Show a more friendly error dialog now that we expect (from the tinymail
2342 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2344 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2346 * src/maemo/modest-main-window.c: (on_account_update): Check that
2347 account_name is not NULL, to prevent a crash at startup that I am
2348 seeing on the N800. I do wonder why it is NULL.
2350 * src/maemo/easysetup/modest-easysetup-wizard.c:
2351 (create_page_user_details):
2352 * src/maemo/modest-account-settings-dialog.c:
2353 (create_page_user_details), (create_page_outgoing):
2354 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2355 (modest_connection_specific_smtp_edit_window_init):
2356 * src/modest-ui-actions.c:
2357 (modest_ui_actions_on_password_requested):
2358 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2359 might do something useful with the on-screen keyboard.
2361 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2363 * src/maemo/modest-main-window.c: (on_account_update):
2364 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2365 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2367 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2369 * src/modest-tny-account-store.c: (on_account_changed):
2370 Correct the signature of this signal handler.
2372 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2374 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2375 Show a HildonNote instead of a GtkDialog for Maemo.
2377 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2379 * src/widgets/modest-account-view.h:
2380 * src/widgets/modest-account-view.c: (on_account_changed),
2381 (on_account_removed). Added a boolean flag, set/unset by
2382 modest_account_view_block_conf_updates(),
2383 modest_account_view_unblock_conf_updates() to prevent unnecessary
2384 updates, but this is not very useful because the gconf notifications are
2385 so delays (maybe only on Maemo Bora).
2386 So auto-updating is turned off, and these functions do an explicit
2387 update when necessary.
2388 However, something else is still doing too much work when adding/removing
2389 accounts, probably in another part of the application.
2391 * src/maemo/modest-account-view-window.c:
2392 (on_delete_button_clicked), (on_edit_button_clicked),
2393 (on_new_button_clicked): Use the new functions.
2395 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2397 * src/modest-account-mgr-helpers.c:
2398 (modest_account_mgr_set_first_account_as_default):
2399 Sort the list of names alphabetically-by-title, so we choose the first one
2401 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2402 alphabetically by the title.
2404 This fixes projects.maemo.org bug NB#56418 .
2406 * src/modest-account-mgr-priv.c:
2407 (_modest_account_mgr_account_from_key):
2408 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2409 avoid a valgrind error, and possible random behaviour.
2411 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2413 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2414 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2415 tinymail documentation to say that this can be expected.
2416 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2417 pretty, and should not happen, but I would prefer to know when it does.
2419 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2421 * configure.ac: When using the older hildon version, probably on Bora,
2422 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2424 * src/widgets/modest-attachment-view.c:
2425 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2428 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2430 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2431 Implemented the prototype. Can be tested with
2432 tests/dbus_api/test_open_message:
2434 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2436 * src/modest-tny-account-store.c:
2437 (modest_tny_account_store_instance_init), (get_password):
2438 * src/modest-ui-actions.c:
2439 (modest_ui_actions_on_password_requested):
2440 Do not store the password in gconf, because this function is called
2441 for non-remembered passwords. Actually use the cached (in the hash map)
2442 password instead of releasing it.
2443 The password will now not be remembered if it is asked via the protected
2444 password dialog, as per the UI spec.
2446 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2448 * src/modest-defs.h:
2449 * src/modest-account-mgr-helpers.h:
2450 * src/modest-account-mgr-helpers.c:
2451 Added modest_server_account_get_username_has_succeeded(),
2452 modest_server_account_set_username_has_succeeded().
2453 (modest_server_account_set_username),
2454 Reset the has-succeeded flag if the username changes.
2456 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2457 * src/maemo/modest-connection-specific-smtp-window.c:
2458 (modest_connection_specific_smtp_window_save_server_accounts):
2459 Use modest_server_account_set_username() instead of using
2460 modest_conf_set_string() directly, so that the has-succeeded flag is always
2463 * src/modest-ui-actions.c:
2464 (modest_ui_actions_on_password_requested): Dim the username entry if
2465 the username has ever worked, as per the UI spec.
2467 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2469 * src/modest-tny-account-store.c: (get_password):
2470 * src/modest-ui-actions.c:
2471 (modest_ui_actions_on_password_requested):
2472 Allow the username to be changed too, though there is more work to
2473 be done on exactly how this behaves.
2475 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2477 * src/modest-account-mgr-helpers.h:
2478 * src/modest-account-mgr-helpers.c:
2479 Added modest_account_mgr_get_display_name(),
2480 modest_server_account_get_username(),
2481 modest_server_account_set_username(),
2482 modest_server_account_set_password(),
2483 modest_server_account_get_hostname() functions so we do not need to
2484 use the conf API directly.
2486 * src/maemo/modest-main-window.c: (connect_signals):
2487 Actually connect ot the ModestAccountStore::request-password signal,
2488 so that we show the dialog when the password is requested by Tinymail,
2489 for isntance if it is empty.
2491 * src/modest-marshal.list:
2492 * src/modest-tny-account-store.c:
2493 (modest_tny_account_store_class_init), (get_password),
2494 (modest_tny_account_store_alert):
2495 * src/modest-tny-account-store.h:
2496 * src/modest-ui-actions.h:
2497 * src/modest-ui-actions.c:
2498 (modest_ui_actions_on_password_requested):
2499 Change the signal parameters, so it is obvious that we are providing
2500 the non human-readable server name, and receiving both the username
2501 and password, though changing of the username is not yet implemented.
2502 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2503 for the GNOME version.
2505 This should fix the projects.maemo.org bug NB#56209, though it does not
2506 work on Bora, because the gconf_client_get() for the password fails
2507 immediately after we save it with gconf_client_set().
2509 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2512 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2513 caused an undefined symbol error:
2514 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2516 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2518 * src/modest-tny-account-store.c:
2519 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2520 using a GError instead of a string message, so we can translate it in
2523 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2525 * src/maemo/modest-address-book.c:
2526 (modest_address_book_check_names):
2527 * src/maemo/modest-msg-view-window.c:
2528 (modest_msg_view_window_clipboard_owner_change):
2529 * src/modest-init.c: (modest_init_init_ui):
2530 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2531 (update_folders_cb), (modest_mail_operation_update_account):
2532 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2533 (modest_ui_actions_on_msg_attachment_clicked),
2534 (modest_ui_actions_on_msg_recpt_activated):
2535 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2536 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2537 (modest_msg_view_search_next):
2538 * src/widgets/modest-recpt-editor.c:
2539 (modest_recpt_editor_on_button_release_event),
2540 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2541 g_message(). At this point we should only be seeing interesting errors on
2542 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2544 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2546 (modest_wizard_dialog_force_title_update):
2547 * src/maemo/easysetup/modest-wizard-dialog.h:
2548 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2549 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2550 can update the title when appropriate. Otherwise the title is wrong if the
2551 pages are added after adding the notebook to the dialog.
2552 This must be a problem in HildonWizardDialog too.
2553 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2555 * src/maemo/easysetup/modest-easysetup-wizard.c:
2556 (create_subsequent_customsetup_pages),
2557 (create_subsequent_easysetup_pages):
2558 Call modest_wizard_dialog_force_title_update() so that the title is
2559 correct even with GTK+ < 2.10.
2560 This fixes projects.maemo.org bug NB#56145 .
2562 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2564 * src/maemo/modest-platform.c:
2565 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2566 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2569 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2571 * src/widgets/modest-window.h:
2572 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2573 and modest_window_save_state(), which invokes it.
2575 * src/widgets/modest-window-mgr.h:
2576 * src/widgets/modest-window-mgr.c:
2577 Added modest_window_mgr_save_state_for_all_windows(), which calls
2578 the save_state vfunc on all registered windows, if implemented.
2580 * src/gnome/modest-msg-edit-window.c:
2581 * src/gnome/modest-msg-view-window.c:
2582 * src/maemo/modest-msg-edit-window.c:
2583 * src/maemo/modest-msg-view-window.c:
2584 * src/maemo/modest-main-window.c:
2585 Specify the existing save_settings functions as implementations of
2586 ModestWindow::save_state_func().
2588 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2589 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2590 enabling hibernation, for instance.
2592 We may need to do the same thing for restoring settings.
2595 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2597 * src/widgets/modest-window-mgr.c:
2598 * src/widgets/modest-window-mgr.h:
2599 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2600 modest_window_mgr_get_hibernation_is_prevented().
2602 * src/maemo/modest-main-window.c:
2603 (on_hildon_program_is_topmost_notify): Prevent hibernation
2604 (possible when the application goes to the background in the WM),
2605 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2607 * src/maemo/easysetup/modest-easysetup-wizard.c:
2608 (modest_easysetup_wizard_dialog_init):
2609 * src/maemo/modest-account-settings-dialog.c:
2610 (modest_account_settings_dialog_init):
2611 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2612 (modest_connection_specific_smtp_edit_window_init):
2613 * src/maemo/modest-connection-specific-smtp-window.c:
2614 (modest_connection_specific_smtp_window_init):
2615 * src/maemo/modest-signature-editor-dialog.c:
2616 (modest_signature_editor_dialog_init):
2617 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2618 prevent hibernation while any of these account settings dialogs are open.
2620 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2622 * src/maemo/Makefile.am:
2623 * src/maemo/modest-osso-state-saving.c:
2624 * src/maemo/modest-osso-state-saving.h: Added
2625 modest_osso_load_state() and modest_osso_save_state() though they do
2626 nothing now. They should iterate through all the open windows and load/save
2628 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2629 save state when closing.
2631 * src/maemo/modest-main-window.c:
2632 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2633 Add a notification handler for the HildonProgram::is-topmost property,
2634 so we can allow hibernation when the application goes into the background.
2635 But we still need to detect when the accounts setup windows are open so
2636 we can stop hibernation when they are open.
2637 To do this, I also added the main window the HildonProgram. This might have
2638 other side-effects/benefits, and should maybe be done for other windows.
2640 * src/maemo/modest-osso-autosave-callbacks.h:
2641 * src/maemo/modest-osso-autosave-callbacks.c:
2642 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2643 though it does not do anything yet, and we might never need this to do
2644 anything. For instance, we already save drafts.
2646 * src/maemo/modest-platform.c: (modest_platform_init):
2647 Specify the libosso auto-save callback.
2649 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2651 * src/maemo/modest-platform.c:
2652 (modest_platform_set_update_interval):
2653 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2654 aparently stays valid between application instances, so we can use this
2655 to remove and reset it later. According to a maemo-developers email from
2658 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2660 * configure.ac: Depend on libalarm for Maemo.
2662 * src/dbus_api/modest-dbus-api.h:
2663 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2664 (on_send_receive), (modest_dbus_req_handler):
2665 Handle a SEND_RECEIVE D-Bus method.
2667 * libmodest-dbus-client/libmodest-dbus-client.c:
2668 (libmodest_dbus_client_send_and_receive):
2669 * libmodest-dbus-client/libmodest-dbus-client.h:
2670 Add C convenience functions for calling the new D-Bus method.
2672 * src/modest-platform.h:
2673 * src/gnome/modest-platform.c:
2674 * src/maemo/modest-platform.c:
2675 Added modest_platform_set_update_interval(), which uses the
2676 alarmd API on Maemo.
2677 (modest_platform_init),
2678 Call modest_platform_set_update_interval(), using a hard-coded
2679 interval for now (until the global settings dialog is implemented),
2680 though I am not sure that this makes sense yet.
2682 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2684 * src/dbus_api/modest-dbus-callbacks.c:
2685 (modest_osso_cb_hw_state_handler):
2686 * src/dbus_api/modest-dbus-callbacks.h:
2687 * src/maemo/modest-platform.c: (modest_platform_init):
2688 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2689 in case this has some effect on the ability for Maemo to ping the
2692 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2694 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2695 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2696 warning. It is probably a logic error, but I need to fix the build.
2698 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2700 * src/modest-account-mgr.h:
2701 * src/modest-account-mgr.c:
2702 (modest_account_mgr_account_names): Add a gboolean enabled_only
2703 parameter, so we can get lists of onlt the enabled accounts.
2705 (modest_account_mgr_add_account),,
2706 (modest_account_mgr_account_with_display_name_exists):
2707 * src/maemo/modest-msg-edit-window.c: (get_transports):
2708 * src/modest-account-mgr-helpers.c:
2709 (modest_account_mgr_set_first_account_as_default):
2710 * src/modest-init.c: (init_default_account_maybe):
2711 * src/modest-tny-account-store.c: (get_accounts):
2712 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2713 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2714 * tests/check_account-mgr.c: (START_TEST):
2715 Provide the extra parameter, as appropriate.
2717 * src/widgets/modest-account-view.c: (update_account_view):
2718 Do not show disabled accounts (meaning that there is no way to
2719 enable/disable accounts in the UI (the feature is not in our UI
2720 specification), so we can use this internally only to mark unfinished
2721 or temporary account data.
2723 * src/maemo/easysetup/modest-easysetup-wizard.c:
2724 (create_account): Add boolean enable parameter, so we can specify FALSE
2725 to create the temporary account.
2726 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2727 (on_before_next): When finishing, when there is a temporary account, just
2729 Also, use a timeout to delay the showing of the dialog until gconf is likely
2730 to return correct information, due to a maemo gconf bug that is fixed in
2731 osso 1.1, but not yet in Bora.
2732 However, the dialog stays on screen after it is destroyed.
2734 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2735 for invalid data when cancelling. Use a hildon note instead of a dialog
2736 to complain about invalid data. Do not show the account-saved note if the
2737 account is disabled (a temporary account that will not really be saved for use
2740 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2742 * src/modest-account-mgr-helpers.h:
2743 * src/modest-account-mgr-helpers.c:
2744 Added modest_account_mgr_unset_default_account(),
2745 Added modest_account_mgr_set_first_account_as_default().
2747 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2748 If it was the default account, unset the default account name.
2750 * src/maemo/modest-account-view-window.c:
2751 (on_delete_button_clicked): If it was the default account,
2752 set the first remaining account as the default instead.
2754 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2755 a NULL account or a NULL default account, to prevent a crash. This should
2756 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2759 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2761 * src/widgets/modest-recpt-editor.c:
2762 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2763 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2764 TODO comment for this. This fixes the build.
2766 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2767 be the best place for it. This will in future update all auto-update accounts,
2768 rather than just the current/default account, when that gconf key exists.
2769 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2770 if there are no accounts, before calling do_send_receive().
2771 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2773 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2774 * src/maemo/modest-main-window-ui.h:
2775 * src/maemo/modest-main-window.c: (on_connection_changed),
2776 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2777 directly, becaue the signal handler does more.
2779 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2781 * src/modest-account-mgr-helpers.c:
2782 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2783 for the case that the account does not exist.
2785 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2786 (equivalent to the modest account name) rather than the tinymail account name
2787 (equivalent to the modest account title - human readable) to get the account data.
2788 Check for null account data to prevent the crash, and add a TODO comment saying that
2789 this needs fixing because it is using the server account name instead of the account name.
2791 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2793 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2794 * src/maemo/modest-account-settings-dialog.c: (show_error),
2796 Use hildon_note_new_information() for informative and error messages,
2797 which seems to be expected for Maemo applications (no documentation that I know of
2798 says this). I am surprised that there is no distinction between info and error
2801 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2803 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2804 it is easy to find where this is used.
2806 * src/maemo/easysetup/modest-easysetup-wizard.c:
2807 (create_page_welcome), (create_page_account_details),
2808 (create_page_user_details), (create_page_complete_easysetup),
2809 (create_page_custom_incoming), (create_page_custom_outgoing),
2810 (create_page_complete_custom):
2811 * src/maemo/modest-account-settings-dialog.c:
2812 (create_page_account_details), (create_page_user_details),
2813 (create_page_incoming), (create_page_outgoing):
2814 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2816 (modest_connection_specific_smtp_edit_window_init):
2817 * src/maemo/modest-connection-specific-smtp-window.c:
2818 (modest_connection_specific_smtp_window_init):
2819 * src/maemo/modest-signature-editor-dialog.c:
2820 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2821 and scrolling policy as per the Email Application Layout Guide, if I have
2824 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2826 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2827 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2828 which were empty, because these vfuncs have been removed from TnyAccountStore.
2829 This fixes the build.
2831 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2833 * src/maemo/modest-main-window.c:
2834 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2835 showing/hiding it. Added TODO because it probably should not be NULL.
2836 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2837 because unnecessary g_warnings() make degugging difficult.
2839 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2841 * src/maemo/modest-msg-edit-window.c:
2842 (modest_msg_edit_window_select_color),
2843 (modest_msg_edit_window_select_background_color): 2 const corrections and
2844 moving 2 #endifs before closing brackets, to fix the build.
2846 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2848 * src/maemo/easysetup/modest-easysetup-wizard.h:
2849 * src/maemo/easysetup/modest-easysetup-wizard.c:
2850 (modest_easysetup_wizard_dialog_finalize),
2851 (on_button_edit_advanced_settings), (create_page_complete_custom),
2852 (on_response), (create_account):
2853 Implement the Advanced Settings edit button, by saving the account information,
2854 for the Advanded Settings dialog to use directly from gconf, and removing it
2855 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2856 Bug #5533 in the projects.maemo.org bugzilla.
2858 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2860 * src/maemo/modest-msg-view-window.c:
2861 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2862 when opening a message window.
2864 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2866 * src/maemo/easysetup/modest-easysetup-wizard.c:
2867 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2870 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2871 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2872 gconf settings. I probably added more checks than necessary, but that is safer.
2874 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2875 variable to fix the build, but this seems to be used when it is still NULL.
2877 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2879 * src/modest-platform.h:
2880 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2881 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2882 * src/modest-main.c: Implement this function so we can avoid using
2883 maemo-specific API from cross-platform code.
2885 * src/modest-tny-account-store.c:
2886 (get_smtp_specific_transport_account_for_open_connection):
2887 * src/modest-ui-actions.c: (check_for_connection),
2888 (modest_ui_actions_on_item_not_found):
2889 Use modest_platform_connect_and_wait() and put #idefs around other
2890 maemo-specific code, because only maemo currently has a way to
2891 identify connection names.
2893 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2895 * src/modest-tny-account-store.h:
2896 * src/modest-tny-account-store.c:
2897 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2898 the connection-specific SMTP server settings in the configuration.
2900 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2902 * src/maemo/modest-main-window.c: (on_connection_changed),
2904 * src/modest-main.c: (main), (start_ui), (send_mail):
2905 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2906 that is what is intended.
2908 * src/modest-ui-actions.c: (action_send), (action_receive),
2909 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2910 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2911 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2912 SMTP server is used when it is specified.
2914 (modest_ui_actions_on_send_receive):
2915 Check that a connection is open before proceeding.
2916 Receive and then send, instead of vice-versa, as per the specification.
2918 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2920 * src/modest-mail-operation.c:
2921 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2922 though I guess it should be something other than NULL.
2924 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2926 * src/maemo/easysetup/modest-easysetup-wizard.c:
2927 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2928 combo twice, to avoid an g_warning and to make it visible again.
2929 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2930 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2931 (already intended) dereference when detaching, because we then recreate the menu.
2932 But I am not sure why the warning was happening, and it is possible that this is a memory
2935 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2937 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2938 and uri_parse_mailto() utility functions.
2939 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2941 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2943 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2945 * src/dbus_api/modest-dbus-api.h:
2946 * src/dbus_api/modest-dbus-callbacks.c:
2947 Use an idle callback to execute the modest code in the application's own thread.
2948 Remove the helloworld example method.
2949 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2950 parsed, and the open-message method is not implemented because this is not yet implemented in
2952 * libmodest-dbus-client/libmodest-dbus-client.c:
2953 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2954 (libmodest_dbus_client_open_message):
2955 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2957 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2958 body without crashing.
2960 * tests/dbus_api/Makefile.am:
2961 * tests/dbus_api/test_mail_to.c:
2962 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2964 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2966 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2967 Added file to fix the build. Sorry.
2969 * src/dbus_api/Makefile.am:
2970 * src/dbus_api/modest-dbus-api.h:
2971 * src/dbus_api/modest-dbus-callbacks.h:
2972 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2973 (modest_dbus_req_handler):
2974 Put constants in a separate header so it can be reused by the
2975 client library, without duplication
2977 * libmodest-dbus-client/Makefile.am:
2978 * libmodest-dbus-client/libmodest-dbus-client.c:
2979 (libmodest_dbus_client_call_helloworld),
2980 (libmodfest_dbus_client_send_mail),
2981 (libmodfest_dbus_client_mailto),
2982 (libmodfest_dbus_client_open_message):
2983 * libmodest-dbus-client/libmodest-dbus-client.h:
2984 (Partly) Implement a send_mail D-Bus method.
2986 * tests/dbus_api/Makefile.am:
2987 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2988 the send_email D-Bus method.
2990 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2994 * libmodest-dbus-client/Makefile.am:
2995 * libmodest-dbus-client/libmodest-dbus-client.c:
2996 * libmodest-dbus-client/libmodest-dbus-client.h:
2997 * tests/dbus_api/Makefile.am:
2998 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2999 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3001 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3003 * src/maemo/easysetup/modest-easysetup-wizard.c:
3004 (create_page_account_details):
3005 * src/maemo/modest-account-settings-dialog.c:
3006 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3007 widgets, because this might not be the default in future versions of the Maemo GTK+.
3008 However, I can not not get capitalization to work even in a simple test case.
3010 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3012 * src/maemo/easysetup/modest-easysetup-wizard.c:
3013 (create_page_custom_incoming), (create_page_custom_outgoing):
3014 * src/maemo/modest-account-settings-dialog.c:
3015 (create_page_account_details), (create_page_incoming),
3016 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3017 instead of using gtk_check_button_with_label(), so they are aligned like the other
3018 widgets, as per the UI spec.
3020 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3022 * src/maemo/easysetup/modest-easysetup-wizard.c:
3023 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3024 * src/widgets/modest-validating-entry.c:
3025 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3026 Modest prefix instead of an EasySetup prefix.
3028 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3030 * src/widgets/modest-validating-entry.h:
3031 * src/widgets/modest-validating-entry.c: (on_insert_text),
3032 Added easysetup_validating_entry_set_max_func(), used to set a callback
3033 to call when the max number of characters is reached. GtkEntry has a max-length
3034 already but is silent about it.
3036 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3037 (create_page_account_details), (create_page_user_details),
3039 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3040 (create_page_account_details), (create_page_user_details),
3041 (create_page_outgoing):
3042 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3043 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3044 the UI spec, when the user tries to enter more than the max number of characters.
3046 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3048 * src/maemo/easysetup/modest-easysetup-wizard.c:
3049 (create_page_user_details), (create_page_custom_incoming),
3050 (create_page_custom_outgoing):
3051 * src/maemo/modest-account-settings-dialog.c:
3052 (create_page_user_details), (create_page_incoming),
3053 (create_page_outgoing):
3054 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3055 (modest_connection_specific_smtp_edit_window_init):
3056 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3057 not appropriate. Bad Maemo-specific defaults!.
3059 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3061 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3062 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3063 (modest_signature_editor_dialog_set_settings):
3064 Disable the label and textview when the checkbox is disabled, and use the
3065 specified (UI spec) default signature text.
3067 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3069 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3070 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3072 * src/modest-defs.h:
3073 * src/modest-account-mgr-helpers.h:
3074 * src/modest-account-mgr-helpers.c:
3075 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3077 * src/maemo/Makefile.am:
3078 * src/maemo/modest-signature-editor-dialog.c:
3079 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3082 * src/maemo/modest-account-settings-dialog.h:
3083 * src/maemo/modest-account-settings-dialog.c:
3084 (modest_account_settings_dialog_finalize), (on_button_signature),
3085 (save_configuration): Use the new dialog when the Edit button is pressed, and
3086 save the changes if necessary, as per the UI spec.
3088 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3090 * src/maemo/Makefile.am:
3091 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3092 based on maemo-develoers email from Dirk.
3094 * src/maemo/easysetup/modest-easysetup-wizard.c:
3095 (create_page_welcome), (create_page_account_details),
3096 (create_page_user_details), (create_page_complete_easysetup),
3097 (create_page_custom_incoming), (create_page_custom_outgoing),
3098 (create_page_complete_custom),
3099 (modest_easysetup_wizard_dialog_init):
3100 * src/maemo/modest-account-settings-dialog.c:
3101 (create_page_account_details), (create_page_user_details),
3102 (create_page_incoming), (create_page_outgoing),
3103 (modest_account_settings_dialog_init):
3104 * src/maemo/modest-connection-specific-smtp-window.c:
3105 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3107 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3109 * src/maemo/easysetup/modest-easysetup-wizard.c:
3110 (create_page_account_details), (create_page_custom_outgoing),
3111 (create_page_complete_custom):
3112 * src/maemo/modest-account-settings-dialog.c:
3113 (create_page_user_details), (create_page_incoming),
3114 (create_page_outgoing):
3115 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3116 (modest_connection_specific_smtp_edit_window_init):
3117 Use the correct (UI spec) port min/max, and use horizontal separators,
3120 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3122 * src/maemo/easysetup/modest-easysetup-wizard.c:
3123 (set_default_custom_servernames):
3124 * src/maemo/modest-account-settings-dialog.c:
3125 (create_page_incoming), (on_combo_outgoing_security_changed),
3126 (on_combo_incoming_security_changed), (create_page_outgoing),
3127 (modest_account_settings_dialog_set_account_name),
3128 (save_configuration):
3129 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3130 (on_combo_security_changed),
3131 (modest_connection_specific_smtp_edit_window_init),
3132 (modest_connection_specific_smtp_edit_window_set_connection),
3133 (modest_connection_specific_smtp_edit_window_get_settings):
3134 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3137 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3140 * src/maemo/easysetup/modest-easysetup-wizard.c:
3141 (create_page_custom_outgoing), (create_page_complete_custom):
3142 * src/maemo/modest-account-settings-dialog.c:
3143 (create_page_user_details), (create_page_outgoing):
3144 * src/maemo/modest-account-view-window.c: (button_box_new):
3145 Use changed logical IDs as per the most recent UI spec:
3146 mcen_bd_emailsetup_edit -> mcen_bd_edit
3147 mcen_bd_emailsetup_delete -> mcen_bd_delete
3148 mcen_bd_emailsetup_close -> mcen_bd_close
3150 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3154 * src/dbus_api/Makefile.am:
3155 * src/dbus_api/modest-dbus-callbacks.c:
3156 * src/dbus_api/modest-dbus-callbacks.h:
3157 * src/maemo/modest-platform.c: (modest_platform_init):
3158 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3160 * tests/Makefile.am:
3161 * tests/dbus_api/Makefile.am:
3162 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3164 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3166 * src/maemo/modest-account-settings-dialog.c:
3167 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3168 Removed unnecessary includes.
3170 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3172 * src/maemo/easysetup/modest-easysetup-wizard.c:
3173 * src/maemo/modest-account-settings-dialog.c:
3174 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3175 * src/widgets/Makefile.am:
3176 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3177 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3178 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3179 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3180 * src/widgets/modest-secureauth-combo-box.c:
3181 * src/widgets/modest-secureauth-combo-box.h:
3182 * src/widgets/modest-serversecurity-combo-box.c:
3183 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3184 made the GObject names more consistent with the rest of the Modest code.
3186 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3188 * src/maemo/easysetup/Makefile.am:
3189 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3190 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3191 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3192 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3193 * src/maemo/easysetup/modest-easysetup-wizard.c:
3194 * src/maemo/easysetup/modest-validating-entry.c:
3195 * src/maemo/easysetup/modest-validating-entry.h:
3196 * src/maemo/modest-account-settings-dialog.c:
3197 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3198 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3199 widgets/ because they are used outside of easysetup too. After checking in,
3200 svn will allow me to rename them too.
3202 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3204 * src/gnome/modest-msg-edit-window.c:
3205 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3206 linker error, to fix the build on the GNOME platform.
3207 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3208 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3209 ifdefed out to avoid a warning.
3211 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3213 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3214 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3215 some alternative for GTK+ 2.6.
3217 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3219 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3221 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3222 specified for EmailAccountsDialog in UI spec.
3224 * src/maemo/easysetup/modest-easysetup-wizard.c:
3225 * src/maemo/easysetup/modest-easysetup-wizard.h:
3226 * src/maemo/modest-account-settings-dialog.c:
3227 * src/maemo/modest-account-settings-dialog.h:
3228 Reuse a member window widget for the connection-specific SMTP server accounts,
3229 so we can tell it to create/save the accounts only if we actually save changes.
3231 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3232 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3233 (modest_connection_specific_smtp_edit_window_get_settings):
3234 Return a struct instance for temporarily remembering the entered data.
3236 * src/maemo/modest-connection-specific-smtp-window.h:
3237 * src/maemo/modest-connection-specific-smtp-window.c:
3238 (modest_connection_specific_smtp_window_finalize),
3239 (modest_connection_specific_smtp_window_fill_with_connections),
3241 (modest_connection_specific_smtp_window_save_server_accounts),
3242 (update_model_server_names): Do not actually save data until asked,
3243 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3245 (on_selection_changed),
3246 (modest_connection_specific_smtp_window_init): Disable the edit
3247 button when nothing is selected.
3249 * src/modest-account-mgr-helpers.c:
3250 * src/modest-account-mgr-helpers.h:
3251 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3254 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3256 * src/modest-account-mgr-helpers.h:
3257 * src/modest-account-mgr-helpers.c:
3258 (modest_account_mgr_get_unused_account_name),
3259 (modest_account_mgr_get_unused_account_display_name): Added these
3260 utility functions, to avoid code duplication.
3262 * src/maemo/easysetup/modest-easysetup-wizard.c:
3263 (create_page_account_details), (create_account):
3264 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3265 (on_combo_security_changed),
3266 (modest_connection_specific_smtp_edit_window_init),
3267 (modest_connection_specific_smtp_edit_window_save_settings):
3268 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3269 * src/maemo/modest-connection-specific-smtp-window.c:
3270 (modest_connection_specific_smtp_window_finalize),
3271 (modest_connection_specific_smtp_window_fill_with_connections),
3272 (on_button_edit), (modest_connection_specific_smtp_window_init):
3273 * src/maemo/modest-connection-specific-smtp-window.h:
3274 Implementing saving of connection-specific server accounts.
3276 But I need to refactor this so we can save the data for each
3277 possible connection-specific account and only actually create the server accounts
3278 when the easysetup finished, or the OK button is pressed on the account settings
3281 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3283 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3284 (on_combo_security_changed):
3285 (modest_connection_specific_smtp_edit_window_init):
3286 Auto-fill the port number as in the account settings.
3288 (modest_connection_specific_smtp_edit_window_set_connection):
3289 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3290 * src/maemo/modest-connection-specific-smtp-window.c:
3291 (fill_with_connections), (on_button_edit),
3292 (modest_connection_specific_smtp_window_init):
3293 Turn the edit window into a dialog to simplify the code, and
3294 set a WM hint as in a GtkDialog, because only a popup can be on top of
3295 another window in Maemo, and popups usually have no WM decoration.
3297 * src/modest-defs.h:
3298 * src/modest-account-mgr-helpers.c:
3299 (modest_account_mgr_set_connection_specific_smtp),
3300 (modest_account_mgr_remove_connection_specific_smtp),
3301 (modest_account_mgr_get_connection_specific_smtp):
3302 * src/modest-account-mgr-helpers.h: Some functions to write the
3303 connection-specific SMTP server information. Not yet used.
3306 * src/widgets/modest-folder-view.c: (text_cell_data):
3307 Fix a warning about an uninitialized variable.
3308 (on_configuration_key_changed): Put an #ifdef around the use
3309 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3311 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3313 * src/maemo/modest-account-settings-dialog.h:
3314 * src/maemo/modest-account-settings-dialog.c:
3315 Added connect_for_modified() utility function to mark the new modified boolean.
3317 (create_page_account_details), (create_page_user_details),
3318 (create_page_incoming), (create_page_outgoing), (on_response),
3319 (modest_account_settings_dialog_init),
3320 (modest_account_settings_dialog_set_account_name):
3321 Only warn about unsaved changes when there are actually unsaved changes.
3323 * src/modest-account-mgr-helpers.c:
3324 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3325 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3326 to get the data from there in future.
3328 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3330 * src/modest-defs.h:
3332 * src/modest-account-mgr-helpers.h:
3333 * src/modest-account-mgr-helpers.c:
3334 Store the security account setting in a single conf key instead of using
3335 the options list, so that the list is left for just the to-be-removed camel hack,
3336 and because gconf_client_set_list() is failing for some reason.
3338 * src/modest-account-mgr.c:
3339 (modest_account_mgr_add_server_account):
3340 * src/maemo/modest-account-settings-dialog.c:
3341 (modest_account_settings_dialog_set_account_name),
3342 (save_configuration): Use the renamed functions.
3345 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3347 * src/widgets/Makefile.am:
3348 * src/widgets/modest-limit-retrieve-combo-box.c:
3349 * src/widgets/modest-limit-retrieve-combo-box.h:
3350 * src/widgets/modest-retrieve-combo-box.c:
3351 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3352 the account settings dialog.
3354 * src/modest-defs.h:
3355 * src/modest-account-mgr-helpers.h:
3356 * src/modest-account-mgr-helpers.c:
3357 (modest_server_account_get_option_secure_auth),
3358 (modest_server_account_set_option_secure_auth):
3359 * src/modest-account-mgr.c:
3360 (modest_account_mgr_add_server_account):
3361 Use the existing AUTH_MECH conf key for the secure-auth setting,
3362 instead of putting it in the list options, because this was actually used already.
3364 * src/maemo/modest-account-settings-dialog.c:
3365 (create_page_account_details),
3366 (modest_account_settings_dialog_set_account_name),
3367 (save_configuration):
3368 * src/maemo/modest-account-settings-dialog.h:
3369 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3370 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3372 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3374 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3375 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3376 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3378 * src/modest-defs.h:
3379 * src/maemo/modest-account-settings-dialog.c:
3380 (create_page_incoming), (on_combo_outgoing_security_changed),
3381 (on_combo_incoming_security_changed), (create_page_outgoing),
3382 (modest_account_settings_dialog_set_account_name),
3383 (save_configuration): Load/Save the port number, and change it when the
3384 security combo changes, to suitable defaults.
3386 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3388 * src/modest-account-mgr.c:
3389 (modest_account_mgr_add_server_account): Set the security and secure-auth
3390 options, and add a comment saying that the other camel-specific options should be
3393 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3395 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3397 * src/modest-tny-account-store.c: (account_list_free),
3398 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3399 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3402 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3404 * src/modest-protocol-info.c:
3405 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3406 is required by our UI spec. Maybe something in our implementation will use this eventually.
3407 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3408 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3409 instead of the previous 0 placeholder.
3411 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3412 secure-auth settings.
3413 * src/modest-account-mgr-helpers.h:
3414 * src/modest-account-mgr-helpers.c:
3415 (modest_server_account_data_get_option_secure_auth),
3416 (modest_server_account_set_option_secure_auth),
3417 (modest_server_account_data_get_option_security),
3418 (modest_server_account_set_option_security): Added this API for getting and setting the security
3419 and secure-auth settings.
3421 * src/maemo/modest-account-settings-dialog.h:
3422 * src/maemo/modest-account-settings-dialog.c:
3423 (modest_account_settings_dialog_finalize), (check_data),
3424 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3425 about changing titles.
3426 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3427 (save_configuration): Save the security and secure-auth settings.
3429 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3430 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3432 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3434 * src/modest-defs.h:
3435 * src/modest-account-mgr.c:
3436 (modest_account_mgr_add_server_account):
3437 Added and used defines for the options key and value pair strings,
3438 that are used so far, though they do not seem to correspond to anything in our
3439 UI specs or ModestProtocol enum.
3441 * src/modest-account-mgr-helpers.h:
3442 * src/modest-account-mgr-helpers.c:
3443 (compare_option_strings_for_name),
3444 (modest_server_account_data_get_option_value),
3445 (modest_server_account_data_get_option_bool),
3446 (modest_account_mgr_get_server_account_option):
3447 Added helper functions for parsing the options GSList.
3449 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3451 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3452 display name is based on the supplied account name.
3453 * src/modest-account-mgr.c:
3454 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3455 with an inefficient, but good-enough, implementation.
3457 * src/maemo/easysetup/modest-easysetup-wizard.c:
3458 (create_page_account_details), (on_before_next), (create_account):
3459 Check for existing display names rather than (non-user-visible) account names, and just
3460 create and set a unique account name at the end.
3462 * src/maemo/modest-account-settings-dialog.c:
3463 (modest_account_settings_dialog_init),
3464 (modest_account_settings_dialog_set_account_name),
3465 (create_page_incoming): Show the display name, instead of the account name.
3466 (on_response): Do some (not all) extra checks, as in the UI spec.
3467 (save_configuration): Save the display name if it was changed.
3469 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3471 * po/en_GB.po: Added needed logical ID and translation.
3472 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3473 (init_view): Made the is-default column clicking work.
3475 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3478 * src/maemo/easysetup/Makefile.am:
3479 * src/maemo/easysetup/modest-easysetup-wizard.c:
3480 (modest_easysetup_wizard_dialog_init):
3481 * src/maemo/easysetup/provider-data-test.keyfile:
3482 * src/maemo/easysetup/provider-data.keyfile:
3483 Moved the provider data file to the new modest-providers-data package and used it from there.
3485 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3487 * src/modest-local-folder-info.c:
3488 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3489 N_() was already used on the static strings, but this just marks it for translation without
3490 using the translation.
3492 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3494 * src/maemo/modest-account-settings-dialog.c:
3495 (create_page_incoming),
3496 (modest_account_settings_dialog_set_account_name):
3497 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3498 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3499 I will do this if nobody else gets there first.
3501 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3503 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3504 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3505 save the security stuff.
3507 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3509 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3510 Set the email address and user fullname, which I now see must be
3513 * src/maemo/modest-account-settings-dialog.h:
3514 * src/maemo/modest-account-settings-dialog.c:
3516 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3517 leave-on-server and authentication.
3518 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3521 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3524 * src/maemo/modest-account-settings-dialog.c:
3525 * src/maemo/modest-account-settings-dialog.h:
3526 Most (but not all) of the widgets are now present as specified by the UI spec.
3527 No changes are yet saved, and some details are not properly shown yet.
3529 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3531 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3533 * src/maemo/Makefile.am:
3534 * src/maemo/modest-account-settings-dialog.c:
3535 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3536 an existing account. Doesn't do much yet.
3538 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3539 Open the accounts settings dialog when Edit is clicked.
3541 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3543 * src/maemo/easysetup/Makefile.am:
3544 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3546 * src/maemo/easysetup/modest-easysetup-wizard.c:
3547 (modest_easysetup_wizard_dialog_init):
3548 Try to get the source directory from the build system,
3549 instead of hard-coding "./" into the source code, when opening our local
3550 copies of the configuration files.
3551 But this still fails when opening the wizard from the Accounts window,
3552 maybe because the working directory seems to change at runtime.
3553 So the wizard will fail the second time unless you copy the files into their
3554 proper locations - see the stdout warnings for the paths.
3556 (create_page_account_details),(on_before_next):
3557 Check for existing non-server accounts instead of server accounts,
3558 so the default account name is useful again, and to prevent trying to
3561 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3562 Show the wizard when New is clicked.
3564 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3565 (init_view): Show the column headers, and show the columns that are
3566 specified in the UI specs. However, something in Maemo's GTK+ prevents
3567 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3568 change the default account. This is despite unsetting the special properties.
3570 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3572 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3573 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3574 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3575 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3576 to make that clearer.
3577 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3579 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3581 * src/maemo/modest-account-view-window.c:
3582 (modest_account_view_window_init),
3583 (modest_account_view_window_new):
3584 Use the same buttons as specified in the
3585 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3586 the existing widgets, which never had a chance of working.
3587 Put the ModestAccountView treeview in a scrolled window.
3588 Do not repeat the initialization in both _init() and _new().
3590 * src/widgets/modest-account-view.c: (update_account_view):
3591 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3592 this widget and window shows no accounts.
3594 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3596 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3598 * src/maemo/easysetup/modest-easysetup-wizard.c:
3599 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3600 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3601 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3604 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3605 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3606 accounts exist yet, as in the UI spec.
3608 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3610 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3612 * src/maemo/Makefile.am:
3613 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3614 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3615 New window for editing connection-specific smtp details.
3616 Not fully implemented.
3618 * src/maemo/modest-connection-specific-smtp-window.c:
3619 (modest_connection_specific_smtp_window_finalize) :
3620 unref the tree model.
3621 (on_button_edit): Show the edit window.
3623 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3625 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3628 * src/maemo/Makefile.am:
3629 * src/maemo/modest-connection-specific-smtp-window.c:
3630 * src/maemo/modest-connection-specific-smtp-window.h:
3631 New window for showing the list of connections, for connection-specific
3632 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3633 * src/maemo/easysetup/modest-easysetup-wizard.c:
3634 (create_page_custom_outgoing): Show the new window when the button is clicked.
3636 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3638 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3639 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3640 * src/maemo/modest-msg-edit-window.c:
3641 (modest_msg_edit_window_insert_image):
3642 * src/modest-conf.c: (modest_conf_key_escape):
3643 * src/modest-mail-operation.c:
3644 (modest_mail_operation_send_new_mail):
3645 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3646 (modest_ui_actions_on_new_account):
3647 * src/widgets/modest-attachment-view.c: (update_filename_request):
3648 * src/widgets/modest-mail-header-view.c:
3649 Corrected warnings that were breaking the build, by commenting out unused variables,
3650 and a function, and by including a header.
3652 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3654 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3655 so we can #ifdef around platform-specific code when necessary.
3656 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3657 to allow this to build for the GNOME platform too.
3659 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3661 * src/maemo/easysetup/modest-easysetup-wizard.c:
3662 Added util_increment_name() and used it in create_page_account_details()
3663 to make sure that the default account name is always a new name.
3665 (modest_easysetup_wizard_dialog_init),
3666 (set_default_custom_servernames): Some minor memory management fixes.
3668 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3672 * src/modest-runtime.c: (init_i18n): Restored the translation
3673 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3674 are defined in config.h, and the translations are installed.
3676 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3677 is defined for translation.
3679 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3681 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3683 * src/maemo/easysetup/modest-easysetup-wizard.c:
3684 (modest_easysetup_wizard_dialog_init):
3685 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3686 Use realistic paths (though they should use $prefix generically) to the
3687 mcc_mapping and provider-data.keyfile files which might work when they
3688 are installed by the future version of the operator-wizard package,
3689 and then fallback to paths in our source code, with an explanatory
3692 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3696 * src/maemo/Makefile.am:
3697 * src/maemo/easysetup/: Added files from the previously-exernal
3698 osso-modest-easysetup.
3699 * src/maemo/modest-main-window-ui.h:
3700 * src/modest-ui-actions.c:
3701 * src/modest-ui-actions.h:
3702 Added modest_ui_actions_on_new_account() as a signal handler for the
3703 New Account menu item. It shows the easysetup wizard.
3704 * po/en_GB.po: Added additional needed logical IDs and translations.