1 2007-07-09 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-utils.h:
4 * src/maemo/modest-maemo-utils.c:
5 Added modest_maemo_show_information_note_and_forget() for use instead of
6 gtk_dialog_run() when the response is not needed, to avoid an extra
7 mainloop which could cause a hang.
9 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
10 Use the logical IDs for the error message, though they are not
11 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
12 because gtk_dialog_run() caused a hang here (the window did not close).
13 This fixes projects.maemo.org bug NB#62646.
15 2007-07-09 Murray Cumming <murrayc@murrayc.com>
17 * src/modest-account-mgr-helpers.h:
18 * src/modest-account-mgr-helpers.c:
19 Added modest_account_mgr_get_store_protocol().
21 * src/maemo/modest-account-view-window.c:
22 (on_delete_button_clicked): Show different warning text depending on
23 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
24 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
27 2007-07-09 Murray Cumming <murrayc@murrayc.com>
29 * src/maemo/modest-msg-edit-window.c:
30 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
31 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
33 2007-07-07 Armin Burgmeier <armin@openismus.com>
35 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
36 ckdg_ib_maximum_characters_reached from correct package.
38 * src/modest-ui-actions.c: Show an error message when a folder could
39 not be created. Tinymail does not give us specific error codes about
40 what has gone wrong, so we assume that a folder with that name
41 already exists, though there might be other reasons.
43 2007-07-06 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
46 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
47 give a more exact error message that can be partly translated.
49 2007-07-05 Murray Cumming <murrayc@murrayc.com>
51 * src/maemo/modest-address-book.c:
52 (select_email_addrs_for_contact): Specify a default window size for the
53 select-email-address dialog, so that it is probably big enough for the
54 title. This should fix projects.maemo.org bug NB#62277.
56 2007-07-05 Murray Cumming <murrayc@murrayc.com>
58 * src/maemo/easysetup/modest-easysetup-wizard.c:
59 (create_page_complete_easysetup): Use
60 gtk_widget_set_size() request to ensure that the text wraps
63 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
65 * src/maemo/easysetup/modest-easysetup-wizard.c:
66 (on_entry_invalid_character), (create_page_account_details),
67 (create_page_user_details):
68 Use new API of ModestValidatingEntry. But for some reason the banner is
69 not shown. I will have to investigate that further.
71 * src/widgets/modest-validating-entry.c: (on_insert_text),
72 (modest_validating_entry_set_func):
73 * src/widgets/modest-validating-entry.h:
74 Added a new callback function to be able to react to prevented
75 characters whitespaces to e.g show a banner.
77 2007-07-05 Armin Burgmeier <armin@openismus.com>
79 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
80 notification of HildonNumberEditor instead of remembering the port
81 number. Thanks to Johannes for pointing this out.
83 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
85 * src/maemo/easysetup/modest-easysetup-wizard.c:
86 Check if there are any user changes before showing a confirmation
87 dialog (projects.maemo.org NB#60946)
89 2007-07-05 Armin Burgmeier <armin@openismus.com>
91 * src/maemo/modest-account-settings-dialog.c: Remember custom port
92 number at the beginning of the dialog and set the modified flag at the
93 end if the port number has changed. This is necessary because
94 HildonNumberEditor does not support notification when the value has
97 2007-07-05 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-ui-actions.c:
100 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
101 a connection before asking anything else. Correct the check for the destination
102 folder so that it succeeds when online.
103 This fixed projects.maemo.org bug NB#61645.
105 2007-07-05 Murray Cumming <murrayc@murrayc.com>
107 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
108 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
109 to fix projects.maemo.org bug NB#62439.
111 2007-07-05 Murray Cumming <murrayc@murrayc.com>
113 * src/modest-tny-account.c: (on_connection_status_changed):
114 Really do not use tny_device_force_offline() here. See the previous comment.
116 2007-07-04 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-tny-account.c: (on_connection_status_changed):
119 Do not use tny_device_force_offline() when tinymail says that something
120 went wrong with the connection. It seems to report this unnecessarily.
122 2007-07-04 Murray Cumming <murrayc@murrayc.com>
124 * src/maemo/modest-connection-specific-smtp-window.c:
125 (modest_connection_specific_smtp_window_init):
126 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
127 does not seem to have any effect in osso 1.1 (though it works in
128 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
130 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
132 * src/maemo/modest-connection-specific-smtp-window.c:
133 Fix UI specification problems with projects.meamo.org NB#60479
135 2007-07-04 Murray Cumming <murrayc@murrayc.com>
137 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
138 clue when this has failed, because the error dialog is not always shown
139 (at least in earlier version).
141 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
142 GError message, because the generic error dialog is not helpful.
144 'This message is not currently available (can't let a new connection go online)'
145 when trying to open an IMAP message.
147 (_modest_ui_actions_open): Offer a connection when some messages would
148 have to be downloaded and we are offline.
150 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
152 * src/widgets/modest-folder-view.c:
153 Don't check for MERGE type anymore as we use the correct type
155 NOTE: For the last two changes you need to update your tinymail copy
156 because of API changes!
158 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
160 * src/modest-tny-local-folders-account.c:
161 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
162 (see projects.maemo.org NB#61580)
164 2007-07-04 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-tny-account.c: (on_connection_status_changed):
167 Commented out the call to modest_platform_connect_and_wait() because this
168 seems to always hang, and I would like to know if this is the only thing
169 that causes a hang when showing the connection dialog.
170 It is not very useful anyway.
172 2007-07-04 Murray Cumming <murrayc@murrayc.com>
174 * src/maemo/modest-msg-view-window.c:
175 (modest_msg_view_window_select_next_message):
177 * src/modest-platform.h:
178 * src/maemo/modest-platform.c:
179 Added modest_platform_connect_and_wait(), which calls
180 tny_maemo_conic_device_connect() always in the main thread, by calling it
181 in an idle handler and waiting for the idle handler to run. It should be
182 in the main thread because it uses GTK+ UI code. It just returns TRUE
183 if the device is already online.
185 There is some nasty code to ensure that subsequent calls to
186 modest_platform_connect_and_wait() just wait for the first one to finish,
187 by checking repeatedly in another idle handler. This is necessary,
188 because other threads (or even the main thread, via another idle handler)
189 can call modest_platform_connect_and_wait() while
190 modest_platform_connect_and_wait() is running.
192 (modest_platform_connect_and_wait_if_network_account),
193 (modest_platform_connect_and_wait_if_network_folderstore):
194 Convenience functions that calls modest_platform_connect_and_wait() if
195 the account or folder might want network access.
197 * src/modest-mail-operation.c:
198 (modest_mail_operation_update_account):
199 * src/modest-ui-actions.c: (download_uncached_messages),
200 (modest_ui_actions_on_rename_folder), (delete_folder),
201 (modest_ui_actions_on_main_window_move_to),
202 (modest_ui_actions_on_msg_view_window_move_to):
203 * src/widgets/modest-folder-view.c:
204 (drag_and_drop_from_folder_view):
205 Offer a connection if we are offline.
207 * src/modest-tny-account.c: (on_connection_status_changed):
208 Document this as only handling errors during network operations in progress,
209 and replace the idle code with a simple call to
210 modest_platform_connect_and_wait(), which does this instead.
212 2007-07-03 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-tny-account.c:
215 (modest_tny_account_get_special_folder): (util_on_idle),
216 Handle the GError so we can see when tny_folder_store_get_folders()
217 fails, as it currently does while something else is connecting.
219 Added util_run_in_main_thread_and_wait()
220 which uses an idlen handler and mainloop to ensure that the function
221 is called in the main thread.
222 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
223 to make sure that we call attempt the connection in the mainloop only,
224 which might solve some hangs.
226 2007-07-03 Murray Cumming <murrayc@murrayc.com>
228 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
229 be found by their display name. This is never useful.
230 * src/modest-tny-account-store.c: (on_account_removed): Find the account
231 by its ID, instead of trying to use its ID as its display name.
233 * src/modest-tny-account-store.h:
234 * src/modest-tny-account.c:
235 (modest_tny_account_get_special_folder): Add a g_warning() when
236 tny_folder_store_get_folders() returns an empty list for the maildir.
238 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
239 Add a g_warning() when this returns NULL, because that it not allowed
242 2007-07-02 Armin Burgmeier <armin@openismus.com>
244 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
245 note when trying to cancel the wizard. This fixes projects.maemo.org
248 2007-07-02 Murray Cumming <murrayc@murrayc.com>
250 * src/modest-tny-account.h:
251 * src/modest-tny-account.c:
252 (modest_tny_account_new_from_server_account),
253 (modest_tny_account_new_from_server_account_name),
254 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
255 because this must now be set before setting the proto. This is usd in
256 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
257 warning in camel_session_get_service() caused by
258 tny_camel_transport_account_prepare().
260 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
263 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
265 * src/maemo/modest-connection-specific-smtp-edit-window.c:
267 (modest_connection_specific_smtp_edit_window_init):
269 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
272 2007-06-29 Murray Cumming <murrayc@murrayc.com>
274 * src/modest-tny-account.c:
275 (modest_tny_account_new_from_server_account):
276 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
277 now uses to request a connection when it needs one, and which it uses
278 to tell us that something is wrong with the connection, so we can force
279 the accounts offline to prevent further problems.
282 * src/modest-init.c: (init_default_settings):
283 * src/modest-mail-operation.c:
284 (modest_mail_operation_update_account):
285 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
286 This should not be necessary anymore. Do not set the conf key that
287 determined this (it was always TRUE and not set anywhere else).
289 * src/modest-ui-actions.h: Remove unused and unimplemented
290 modest_ui_actions_on_online_toggle_toggled().
292 2007-06-29 Murray Cumming <murrayc@murrayc.com
294 * src/maemo/modest-main-window.c: (connect_signals):
295 Don't connect to delete_event twice. Maybe this was harmless.
297 2007-06-29 Murray Cumming <murrayc@murrayc.com
299 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
300 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
301 Debug output to give some more clue when a folder move is not allowed.
303 2007-06-28 Murray Cumming <murrayc@murrayc.com
305 * src/modest-tny-account.c: (on_modest_file_system_info),
306 (modest_tny_account_get_mmc_account_name):
307 Always call the callback, without checking whether the name has changed.
308 * src/widgets/modest-folder-view.c: (strings_are_equal),
309 (on_model_foreach_set_name), (on_get_mmc_account_name),
310 (text_cell_data): Compare the name here, and use the name from
311 the account rather than from the
312 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
313 if the name was changed after the account was added to the model.
314 That's a tinymail bug but not one that I want to fix now.
316 This finally fixes projects.maemo.org bug NB#59301.
318 2007-06-27 Armin Burgmeier <armin@openismus.com>
320 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
323 2007-06-27 Murray Cumming <murrayc@murrayc.com
325 * src/modest-tny-account.h:
326 * src/modest-tny-account.c:
327 Added modest_tny_account_get_mmc_account_name(), to set the memory
328 card name asynchronously for the given account and then notify.
329 (modest_tny_account_new_for_local_folders): Use this new function instead
330 of using hildon_file_system_info_async_new() directly.
332 * src/widgets/modest-folder-view.c: (text_cell_data):
333 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
334 gtk_tree_model_row_changed() when it is available.
336 This should fix projects.maemo.org bug NB#59301.
338 2007-06-27 Murray Cumming <murrayc@murrayc.com
340 * src/modest-mail-operation.c: (update_account_thread),
341 (get_msgs_full_thread): Fix typo failures in the revert
344 2007-06-27 Murray Cumming <murrayc@murrayc.com
346 * src/maemo/modest-maemo-global-settings-dialog.c:
347 (idle_select_default_focus):
348 * src/modest-mail-operation.c: (idle_notify_progress),
349 (idle_notify_progress_once), (set_last_updated_idle),
350 (update_account_thread), (get_msgs_full_thread):
351 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
352 * src/widgets/modest-header-view.c:
353 (idle_notify_headers_count_changed_destroy),
354 (idle_notify_headers_count_changed):
355 Reverted the additions of gdk_threads_enter/leave(), in case this
356 helps with a startup hang on the device.
358 2007-06-26 Armin Burgmeier <armin@openismus.com>
360 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
361 for supported secure authentication methods from server by
362 gtk_dialog_run(), saving CPU time and a potential race condition.
364 2007-06-26 Armin Burgmeier <armin@openismus.com>
366 * src/maemo/modest-maemo-utils.h:
367 * src/maemo/modest-maemo-utils.c: Added a
368 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
369 only error code to tell the calling code when the user canceled the
372 * src/maemo/modest-account-settings-dialog.h:
373 * src/maemo/modest-account-settings-dialog.c:
374 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
375 message if the retrieval of secure authentication methods was canceled
376 by the user. Perform the check before saving anything to configuration
377 to not end up with half-committed configuration changes, do not show
378 a "Saving to configuration failed" note when authentication methods
379 could not be retrieved.
381 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
384 2007-06-26 Murray Cumming <murrayc@murrayc.com>
386 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
387 Only return the first level of folders under accounts, because the
388 osso-global-search UI spec doesn't want the rest.
389 This fixed projects.maemo.org bug NB#61811.
391 2007-06-26 Murray Cumming <murrayc@murrayc.com>
393 * src/modest-tny-account-store.c:
394 * src/modest-tny-account-store.h:
395 Added modest_tny_account_is_memory_card_account().
396 * src/maemo/modest-main-window.c: (create_details_widget):
397 Show the same information items for the memory card as we show for the
398 local-folders, to fix projects.maemo.org bug NB#59307.
400 2007-06-26 Murray Cumming <murrayc@murrayc.com>
402 * src/modest-tny-account-store.c: (get_password):
403 Added some checks for NULL to maybe prevent crashes, though I think
404 it was Philip's last commit that actually prevented the crash here
405 when creating a first new account.
406 But the new account is still not usable (no messages are shown)
407 until a restart of the application.
409 2007-06-26 Murray Cumming <murrayc@murrayc.com>
411 * src/maemo/modest-maemo-global-settings-dialog.c:
412 (idle_select_default_focus):
413 * src/modest-mail-operation.c: (idle_notify_progress),
414 (idle_notify_progress_once), (idle_notify_update_account_queue),
415 (set_last_updated_idle), (update_account_thread),
416 (notify_get_msgs_full), (get_msgs_full_destroyer),
417 (get_msgs_full_thread):
418 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
419 * src/widgets/modest-header-view.c:
420 (idle_notify_headers_count_changed_destroy),
421 (idle_notify_headers_count_changed):
422 Use gdk_threads_enter() and gdk_threads_enter_leave() in
423 all idle handlers, because some other thread could be blocking
424 the GDK lock, so that it can do GUI stuff.
426 2007-06-26 Murray Cumming <murrayc@murrayc.com>
428 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
429 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
430 (on_idle_send_receive), (on_idle_open_default_inbox):
431 * src/maemo/modest-msg-edit-window.c:
432 (modest_msg_edit_window_attach_file_noninteractive):
433 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
434 to prevent a hang. I don't quite understand why these are necessary,
435 beause we should already be in the main loop. I guess something outside
436 of the main loop is taking the lock.
438 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
439 we are really using URIs, and use files that are more likely to exist.
441 2007-06-26 Murray Cumming <murrayc@murrayc.com>
443 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
444 necessary because configure.ac now defines different variables.
446 2007-06-26 Murray Cumming <murrayc@murrayc.com>
448 * libmodest-dbus-client/libmodest-dbus-client.c:
449 * libmodest-dbus-client/libmodest-dbus-client.h:
450 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
451 libmodest_dbus_client_compose_mail() is what things actually use.
453 * src/dbus_api/modest-dbus-api.h:
454 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
455 * tests/dbus_api/Makefile.am:
456 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
459 2007-06-26 Murray Cumming <murrayc@murrayc.com>
461 * src/modest-init.c: (modest_init_local_folders):
462 For memory-card (or other non local-folders) maildir accounts,
463 always create an Archive folder, so that there is somewhere to put
464 messages. This should be less confusing, because the user does not need
465 to guess that the need to create a folder.
467 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
469 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
470 Fixed icon size by using (50, 50) which is the same as defined by
473 2007-06-25 Armin Burgmeier <armin@openismus.com>
475 * src/widgets/modest-window-mgr.c:
477 * configure.ac: Correctly recognize hildon-notify presence and fixed
478 the build without it being installed.
480 2007-06-25 Murray Cumming <murrayc@murrayc.com>
482 * libmodest-dbus-client/libmodest-dbus-client.c:
483 (libmodest_dbus_client_search): Fix the build. Sorry.
484 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
485 (reply_forward_cb): Initialize variables to fix the build.
487 * src/modest-tny-account-store.c:
488 (modest_tny_account_store_get_tny_account_by): Fix the account URI
489 comparison (a silly typo) so that email search results can be opened
490 when there are more than one account.
492 2007-06-25 Murray Cumming <murrayc@murrayc.com>
494 * libmodest-dbus-client/libmodest-dbus-client.c:
495 (libmodest_dbus_client_search),
496 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
497 instead of 1 second, because the search gets folders and messages from
498 the server, which can take a long time. When it times out,
499 osso-global-search will report no results.
501 We need to specify whether we should search only cached information
502 (maybe with a user preference), and the osso-email-search-plugin
503 API should really be improved to allow that option, and to allow results
504 to be delivered asynchronously in batches.
506 2007-06-25 Murray Cumming <murrayc@murrayc.com>
508 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
509 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
510 GTK_ICON_SIZE_DIALOG is probably the wrong size.
512 2007-06-25 Murray Cumming <murrayc@murrayc.com>
514 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
515 that is an empty string. D-Bus seems to give us these instead of NULL.
517 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
519 * src/dbus_api/modest-dbus-callbacks.c:
520 * src/maemo/easysetup/modest-easysetup-wizard.h:
521 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
522 * src/maemo/modest-connection-specific-smtp-edit-window.c:
523 (modest_connection_specific_smtp_edit_window_init):
524 * src/maemo/modest-maemo-global-settings-dialog.c:
526 * src/maemo/modest-maemo-utils.c:
527 (modest_maemo_utils_setup_images_filechooser):
528 * src/maemo/modest-main-window.c: (create_details_widget):
529 * src/maemo/modest-msg-edit-window.c:
530 (modest_msg_edit_window_attach_file_noninteractive),
531 (modest_msg_edit_window_color_button_change),
532 (modest_msg_edit_window_set_zoom):
533 * src/modest-mail-operation.c: (update_account_thread):
534 * src/modest-tny-account-store.c:
535 * src/modest-tny-account.c:
536 * src/widgets/modest-global-settings-dialog.c:
537 * src/widgets/modest-window.h:
541 2007-06-25 Murray Cumming <murrayc@murrayc.com>
543 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
544 * src/modest-search.c: (modest_search_folder),
545 (modest_search_all_accounts): Actually search only in the specified folder,
546 doing a simple match on the folder ID.
547 * src/modest-search.h: Added a folder field to the ModestSearch struct,
548 and added some documentation.
550 2007-06-22 Armin Burgmeier <armin@openismus.com>
552 * src/maemo/modest-maemo-utils.h:
553 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
554 modest_maemo_utils_get_supported_secure_authentication_methods.
556 * src/maemo/easysetup/modest-easysetup-wizard.c:
557 * src/maemo/modest-account-settings-dialog.c: Show correct error if
558 one occured, not just "Server does not support secure authentication".
560 2007-06-22 Murray Cumming <murrayc@murrayc.com>
562 * src/modest-tny-account-store.c: (get_password):
563 Restored the call to tny_account_set_user() because Philip seems to have
564 stopped this from crashing (by not using the freed string). It still does
565 not work, but now we can test it.
567 2007-06-22 Murray Cumming <murrayc@murrayc.com>
569 * src/maemo/modest-msg-edit-window.c: (init_window):
570 Comment out use of an uninitialzed GtkScrolledWindow variable,
571 to fix the build and stop a crash. Yet again.
573 2007-06-22 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-tny-account-store.c: (get_password):
576 Remove the call to tny_account_set_user() because this actually crashes.
577 As mentioned in the last commit, it is known to not work anyway.
579 2007-06-22 Murray Cumming <murrayc@murrayc.com>
581 * src/modest-tny-account-store.c: (get_password):
582 Use tny_account_set_username() to tell tinymail that the username might
583 have changed too. But tinymail ignores this: see projects.maemo.org
585 * src/modest-ui-actions.c:
586 (modest_ui_actions_on_password_requested): Remove the useless attempt to
587 reset the connection when changing the username, and improve the comments.
588 Save the changed username to gconf at least, so it is used when Modest is
591 2007-06-21 Murray Cumming <murrayc@murrayc.com>
593 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
594 Do not use a query, so that we get all folders, including for POP and
595 local-folders. They work as search criteria too.
596 This fixes projects.maemo.org bug NB#57740.
598 2007-06-21 Murray Cumming <murrayc@murrayc.com>
600 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
601 Comment out the use of hildon_notification_set_sound() because it is
602 not declared, to fix the build. Warnings are serious, people.
604 2007-06-21 Armin Burgmeier <armin@openismus.com>
606 * src/maemo/modest-maemo-utils.h:
607 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
608 modest_maemo_utils_get_supported_secure_authentication_methods()
609 to query authentication methods for a specific user. This should fix
610 projects.maemo.org bug NB#61369.
612 * src/maemo/easysetup/modest-easysetup-wizard.c:
613 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
616 2007-06-21 Murray Cumming <murrayc@murrayc.com>
618 * libmodest-dbus-client/libmodest-dbus-client.h:
619 * libmodest-dbus-client/libmodest-dbus-client.c:
620 (modest_dbus_message_iter_get_search_hit),
621 (libmodest_dbus_client_search):
622 Reorganised and commented this.
623 Removed modest_search_hit_free() from the public API because it
626 Added libmodest_dbus_client_get_folders() and
627 modest_folder_result_list_free().
629 * src/dbus_api/modest-dbus-api.h:
630 * src/dbus_api/modest-dbus-callbacks.c:
631 (modest_dbus_req_filter): Commented. Moved most code to
632 on_dbus_method_search() and added on_dbus_method_get_folders().
634 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
635 of the extra D-Bus handler.
637 * tests/dbus_api/Makefile.am:
638 * tests/dbus_api/test_get_folders.c: New test for
639 libmodest_dbus_client_get_folders(). This seems to return an empty list
640 at the moment. That could be the same error that causes the message list
641 to be empty sometimes.
642 This should help with projects.maemo.org bug NB#57740.
644 2007-06-21 Armin Burgmeier <armin@openismus.com>
646 * src/modest-mail-operation.c: Do not call
647 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
648 notify the operation's end after having set the status to CANCELED for
649 the operation queue to listen on. This fixes a deadlock when there
650 were mail operations in the queue during its finalization.
652 * src/modest-singletons.c: Reordered uninitialization of the account
653 manager to happen after the mail operation queue was uninitialized
654 because the mail operation's in the queue might still try to access
655 the account manager (see modest_mail_operation_notify_end()). This
656 fixes a potential crash when terminating the application.
658 2007-06-21 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-search.c:
661 (search_mime_part_and_child_parts): Moved some code here so we
662 can search recursively in child folders.
663 (modest_search_folder): Search in the message as a mime part, instead
664 of just its child mime parts.
665 (read_chunk), (search_mime_part_ogs):
666 Check how many bytes were read, to prevent an endless loop.
667 Searching in message bodies now works. This finishes the fix for
668 projects.maemo.org bug NB#61007.
670 2007-06-20 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
673 Add a g_warning when the item is not a folder.
675 * src/modest-ui-dimming-rules.c:
676 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
677 when selected item is not a folder (for instance, an account), because
678 the UI spec only talks about folders.
679 I am not sure what the UI spec wants, so this might not totally fix
680 projects.maemo.org bug NB#60794.
682 2007-06-20 Murray Cumming <murrayc@murrayc.com>
684 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
685 (load_from_file): Sort the list. The unsorted list would be more noticeable
686 in non-English locales.
688 * src/maemo/modest-msg-edit-window.c:
689 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
690 warning and fix the build.
692 * src/maemo/modest-progress-bar-widget.c:
693 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
694 avoid a g_warning, and probably to avoid a crash.
696 2007-06-20 Murray Cumming <murrayc@murrayc.com>
698 * src/modest-search.c: (modest_search_folder): Check for a GError
699 when calling tny_folder_get_headers(), to show that this is not the cause
702 2007-06-20 Murray Cumming <murrayc@murrayc.com>
704 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
705 Actually set the body query instead of the subject query.
707 * src/modest-search.c: (search_mime_part_ogs),
708 (search_mime_part_strcmp): Remove extra space from the text/* regex,
709 which would probably cause it to fail if we got this far.
711 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
712 to simplify the code.
713 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
714 be causing search-in-body to fail.
716 2007-06-20 Murray Cumming <murrayc@murrayc.com>
718 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
720 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
721 Better debug message when the folder cannot be found.
722 This should help with fixing projects.maemo.org bug #61287.
723 * src/modest-search.c: (add_hit): Do not leak the furl string.
725 2007-06-20 Murray Cumming <murrayc@murrayc.com>
727 * src/modest-ui-actions.c:
728 (modest_ui_actions_on_folder_selection_changed):
729 Do not special-case TNY_MERGE_FOLDER here, because
730 modest_tny_folder_get_account() already does that. This fixes
731 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
732 shown when the Outbox was selected).
734 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
736 * libmodest-dbus-client/libmodest-dbus-client.c:
737 (_dbus_iter_get_string_or_null): Initialize the string variable in
738 case this helps with Dirk's crash.
740 2007-06-19 Murray Cumming <murrayc@murrayc.com>
742 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
743 though it is not implemented yet (this function is maybe not even used),
744 to avoid breaking ABI in future.
745 * libmodest-dbus-client/libmodest-dbus-client.c:
746 (get_attachments_string): Moved some code into this generic function.
747 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
748 sends email. It is maybe not used.
749 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
750 (on_send_mail): Use attachments.
752 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
753 * src/maemo/modest-msg-edit-window.c:
754 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
755 a filename before using it, to fix projects.maemo.org bug NB#58233.
757 2007-06-19 Murray Cumming <murrayc@murrayc.com>
759 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
760 Initialize the continue_download variable to fix the build, and probably
761 to fix randome behaviour.
763 2007-06-18 Armin Burgmeier <armin@openismus.com>
765 * src/modest-tny-send-queue.h:
766 * src/modest-tny-send-queue.c: Keep track of the status of messages in
767 the queue so we can later show it in the UI. Replaced
768 modest_tny_send_queue_msg_is_being_sent() by
769 modest_tny_send_queue_get_msg_status().
771 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
773 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
774 gpointer. This probably was not harmful, but just to be sure.
776 2007-06-18 Murray Cumming <murrayc@murrayc.com>
778 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
779 Fix the build, but leave the function broken on Bora, because
780 hildon_uri_action_get_service() does not exist.
781 osso_uri_action_get_service() does not exist either, it seems.
783 2007-06-18 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-tny-account.c:
786 (modest_tny_account_new_from_server_account):
787 Uncommented the url debug output again, because it is useful for
788 debugging, as I said in the comment.
790 2007-06-18 Murray Cumming <murrayc@murrayc.com>
792 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
794 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
795 for Mameo Bora, to fix the build.
797 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
800 Fixed build with hildon < 0.99
802 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
803 Check if the selected account is busy instead of checking all accounts
805 * src/modest-account-mgr-priv.h:
806 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
807 (modest_account_mgr_init), (compare_account_name),
808 (modest_account_mgr_set_account_busy),
809 (modest_account_mgr_account_is_busy):
810 * src/modest-account-mgr.h:
811 Added busy information to the account manager. It possible to
812 set an account to busy or not busy now.
814 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
815 (modest_mail_operation_update_account),
816 (modest_mail_operation_notify_end):
817 Set the account to busy/not busy depending on the operation state.
819 * src/widgets/modest-account-view.c:
820 (modest_account_view_finalize), (get_last_updated_string),
821 (update_account_view), (on_account_busy_changed), (init_view):
822 Show string "Refreshing..." if the account is currently busy.
824 All this fixes projects.maemo.org bug NB#59711
826 2007-06-14 Armin Burgmeier <armin@openismus.com>
828 * src/widgets/modest-attachments-view.h:
829 * src/widgets/modest-attachments-view.c: Added
830 modest_attachments_view_has_attachments() and fixed coordinate
831 transformation in get_att_view_at_coords(). This fixes attachment
834 * src/widgets/modest-msg-view.c: Make use of
835 modest_attachments_view_has_attachments() to decide whether to show
836 attachments in the header.
838 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
840 * src/maemo/modest-connection-specific-smtp-edit-window.c:
841 (on_change), (on_combo_security_changed),
842 (modest_connection_specific_smtp_edit_window_init),
843 (modest_connection_specific_smtp_edit_window_set_connection),
844 (modest_connection_specific_smtp_edit_window_is_dirty):
845 * src/maemo/modest-connection-specific-smtp-edit-window.h:
846 * src/maemo/modest-connection-specific-smtp-window.c:
849 Show an comfirmation dialog for the smpt-edit-window if there are
850 unsaved changes and the user hits cancel.
851 (projects.maemo.org bug NB#60479)
853 2007-06-14 Armin Burgmeier <armin@openismus.com>
855 * src/maemo/easysetup/modest-easysetup-wizard.c:
856 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
857 address" info in banner instead of node, and select all the text as
858 per UI spec. This fixes projects.maemo.org bug NB#60550.
860 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
862 reviewed by: <delete if not using a buddy>
864 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
865 * src/modest-ui-actions.c: (folder_refreshed_cb):
867 2007-06-14 Murray Cumming <murrayc@murrayc.com>
869 * src/widgets/modest-folder-view.c: (filter_row):
870 Explictly filter out the per-account outbox accounts. I don't know why
871 these only sometimes show up, but now they should never show up in the UI.
872 This should fix projects.maemo.org bug NB#60160.
874 2007-06-14 Murray Cumming <murrayc@murrayc.com>
876 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
877 when the toolbar does not exist yet.
878 * src/modest-widget-memory.c: (save_settings_header_view):
879 Added g_warnings() to help us to discover when we are trying to set
880 an empty columns list in gconf.
882 2007-06-14 Murray Cumming <murrayc@murrayc.com>
886 Added modest_init_get_default_header_view_column_ids().
888 * src/modest-widget-memory.c: (restore_settings_header_view):
889 Use the new function to get defaults, if the gconf key is empty,
890 instead of not creating any columns. This seems to fix the
891 empty right-hand pane problems.
893 * src/widgets/modest-header-view.h: Improved documentation.
895 2007-06-13 Murray Cumming <murrayc@murrayc.com>
897 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
898 Revert the use of the display name as the account name, because this
899 is generally wrong and would break the code that follows.
901 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
903 * src/maemo/easysetup/modest-easysetup-wizard.c:
904 (check_for_supported_auth_methods), (on_before_next),
907 More correct fix for projects.maemo.org bug NB# 58991
908 Do not longer accept AUTH_PASSWORD as secure method and choose
909 correct method when creating the account.
911 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
913 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
914 Fixed projects.maemo.org bug NB# 58991
916 2007-06-13 Murray Cumming <murrayc@murrayc.com>
918 * src/modest-init.c: (modest_init_init_core),
919 (modest_init_local_folders): Fixed compilation errors.
921 2007-06-13 Murray Cumming <murrayc@murrayc.com>
923 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
924 Remove unnecessary lib/include, though it is good in principle when needed.
926 * src/modest-init.c: (modest_init_one_local_folder),
927 (modest_init_local_folders):
928 * src/modest-init.h: Initialize the .modest library for memory cards,
929 instead of just doing nothing for them. This should allow us to create
930 folders there, fixing projects.maemo.org bug NB#59297.
932 2007-06-13 Murray Cumming <murrayc@murrayc.com>
934 * libmodest-dbus-client/libmodest-dbus-client.c:
935 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
936 (libmodest_dbus_client_compose_mail),
937 (libmodest_dbus_client_open_message),
938 (libmodest_dbus_client_send_and_receive),
939 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
941 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
942 (on_idle_open_message), (modest_dbus_req_handler),
943 (search_result_to_message), (modest_dbus_req_filter):
944 * src/modest-search.c: (add_hit), (modest_search_folder),
945 (modest_search_all_accounts): Improved debug messages.
947 * tests/dbus_api/test_open_message.c: (main): Improved comments.
949 * src/modest-tny-account-store.c:
950 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
953 2007-06-13 Murray Cumming <murrayc@murrayc.com>
956 2007-06-12 Murray Cumming <murrayc@murrayc.com>
958 * src/modest-tny-account-store.c: (get_server_accounts):
959 Call modest_tny_local_folders_account_add_merged_outbox_folders()
960 even when there are no accounts, so that the Outbox folder is always
961 visible. This fixes projects.maemo.org bug NB#60158.
963 2007-06-12 Murray Cumming <murrayc@murrayc.com>
965 * src/maemo/modest-main-window.c: (create_details_widget):
966 Use the mcen_va_never logical ID.
968 2007-06-12 Murray Cumming <murrayc@murrayc.com>
970 * src/dbus_api/modest-dbus-api.h:
971 * src/dbus_api/modest-dbus-callbacks.c:
972 (on_idle_open_default_inbox), (on_open_default_inbox),
973 (modest_dbus_req_handler):
974 Added a new OpenDefaultInbox method.
976 * libmodest-dbus-client/libmodest-dbus-client.h:
977 * libmodest-dbus-client/libmodest-dbus-client.c:
978 Added libmodest_dbus_client_open_default_inbox() to call the new
979 dbus method. This should be useful to projects.maemo.org bug NB#57214,
980 though it should maybe be used by a new osso-email-interface function.
982 * tests/dbus_api/Makefile.am:
983 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
986 2007-06-12 Murray Cumming <murrayc@murrayc.com>
988 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
989 NULL, so that the signals get all the keys. This should not actually
990 change any behaviour because we currently update everything when anything
993 2007-06-12 Murray Cumming <murrayc@murrayc.com>
995 * src/widgets/modest-folder-view.c: (text_cell_data),
996 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
997 (find_inbox_iter): If tinymail tells us that the folder is
998 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
999 This causes the inbox to be selected at startup, fixing part of
1000 projects.maemo.org bug NB#56305.
1002 * src/modest-ui-dimming-rules.c:
1003 (modest_ui_dimming_rules_on_tools_smtp_servers):
1004 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1005 the SMTP servers menu item.
1006 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1007 that the SMTP Servers menu item is dimmed when there are no accounts,
1008 as a future version of the UI spec will require. This fixes
1009 projects.maemo.org bug NB#56305.
1011 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1013 * src/maemo/modest-maemo-utils.c:
1014 (modest_maemo_utils_get_supported_secure_authentication_methods):
1015 Added label to dialog instead of unreadable title
1017 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1018 (modest_main_window_new):
1019 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1022 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1023 * src/modest-account-mgr.h:
1024 Added method to avoid code duplication
1026 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1027 (modest_ui_actions_on_send_receive):
1028 Use modest_account_mgr_has_accounts
1030 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1032 * src/maemo/easysetup/modest-presets.c:
1033 (modest_presets_get_info_server_security): Do not report secure auth
1035 * src/modest-protocol-info.c: Use the defines for the gconf key names
1036 for secure authentication. This was not working because we were writing
1037 Password and reading password, and the check was case sensitive.
1038 With this, gmail now works for receiving and sending when created via
1041 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1043 * src/maemo/easysetup/modest-presets.c:
1044 (modest_presets_get_info_server_security): Correct the key name for
1045 SecureSmtp, because it seems to be case-sensitive.
1046 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1047 Do not try to get the 0th notebook page if there are 0 pages, to
1048 avoid a g_warning().
1050 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1052 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1053 Prevent use of the new notification feature for now, because it currently
1054 shows one dialog for each new email, which is annoying.
1056 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1058 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1059 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1060 when no country was selected, so that we show the global ones.
1061 * src/maemo/easysetup/modest-presets.c:
1062 (modest_presets_get_providers): Return only the global providers, not
1063 all providers when mmc=0 was requested.
1065 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1067 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1068 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1069 provider ID in the combo.
1071 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1072 Do not show the page numbers, because it would be confusing when we add
1073 the 2 extra pages for the custom setup, when the user chooses the "Other"
1074 provider. This fixes projects.maemo.org bug NB#59028
1076 * src/modest-init.c: (modest_init_init_core),
1077 (modest_init_local_folders):
1078 * src/modest-init.h:
1079 * src/modest-tny-account.c:
1080 (modest_tny_account_new_for_local_folders): Do not create default folders
1081 for the memory card. This should fix projects.maemo.org bug NB#59328.
1083 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1085 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1086 Free the changed_conf_keys string items. They are already freed in the
1087 idle handler if that runs first.
1089 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1091 * src/modest-ui-actions.c:
1092 (modest_ui_actions_on_password_requested): Check that the server name
1093 is not NULL, because I just saw a password dialog with (null) as the
1096 * src/modest-tny-folder.[h|c]: Added
1097 modest_tny_folder_is_memory_card_folder().
1098 * src/modest-ui-dimming-rules.c:
1099 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1100 menu item for memory cards, as per the UI spec (section 7.4). This should
1101 fix projects.maemo.org bug NB#59297.
1103 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1105 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1106 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1107 is another problem with the code, see Murray's comment at line 772)
1109 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1111 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1112 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1113 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1114 (load_from_file), (easysetup_country_combo_box_init),
1115 (easysetup_country_combo_box_get_active_country_ids),
1116 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1117 instead of just one ID, to avoid duplicate country names in the UI.
1119 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1120 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1121 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1122 a single ID, avoiding duplicate providers.
1123 * src/maemo/easysetup/modest-easysetup-wizard.c:
1124 (on_combo_account_country): Adapt to use a list.
1126 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1128 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1129 keys changed in the last X seconds.
1131 * src/modest-account-mgr.h:
1132 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1133 (on_key_change), (modest_account_mgr_class_init),
1134 (modest_account_mgr_init), (modest_account_mgr_finalize):
1135 As the keys are changed, save them in a GSList* and signal that GSList*
1136 further every X seconds, to batch changes, to allow us to do just one
1137 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1138 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1140 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1141 changed signal signature.
1143 * src/modest-conf.c: (modest_conf_set_list),
1144 (modest_conf_on_change): Reenable notification.
1146 (modest_conf_maemo_fake_on_change): Comment out the hack that
1147 notified immediately instead of asynchronously.
1149 * src/widgets/modest-account-view.h:
1150 * src/widgets/modest-account-view.c:
1151 (update_account_view): Select the previously-selected account ID,
1152 if possible. This fixes projects.maemo.org bug NB#56933.
1154 (on_account_changed), (on_account_removed),
1155 (modest_account_view_select_account):
1157 Remove the block/unblock functions
1158 because they were not useful.
1160 * src/maemo/modest-account-view-window.c:
1161 (on_delete_button_clicked), (on_edit_button_clicked),
1162 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1164 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1166 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1167 Improve the error dialog to show Incorrect Account Settings, which seems
1168 clearer, and say that the internal error message (to be removed from the
1169 dialog later) is often misleading.
1170 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1172 * src/modest-tny-account.c:
1173 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1174 URL because this is so useful for debugging on the device.
1176 * src/widgets/modest-serversecurity-combo-box.c:
1177 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1179 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1181 * src/modest-mail-operation.c:
1182 (modest_mail_operation_send_new_mail):
1183 Added a comment about a nasty but apparently harmless message. Details
1184 added to the wiki g_warnings() page.
1186 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1188 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1189 (modest_tny_send_queue_class_init):
1190 Do not use the priv struct because it is empty, to avoid g_warnings
1191 about a non-existant priv struct.
1193 * src/modest-tny-account-store.c:
1194 (modest_tny_account_store_get_server_account),
1195 (modest_tny_account_store_get_transport_account_for_open_connection
1196 ): Do not try to get transport server accounts for local folders,
1197 because they don't have any. This avoids a g_warning().
1199 * src/maemo/modest-main-window.c:
1200 (modest_main_window_notify_send_receive_initied),
1201 (on_configuration_key_changed):
1202 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1203 * src/modest-defs.h:
1204 * src/modest-mail-operation.c:
1205 (modest_mail_operation_update_account):
1206 * src/modest-tny-account-store.h:
1207 * src/modest-tny-account.c:
1208 (modest_tny_account_get_special_folder),
1209 (modest_tny_account_new_for_local_folders),
1210 (modest_tny_account_new_for_per_account_local_outbox_folder):
1211 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1212 * src/modest-tny-local-folders-account.c:
1213 (add_account_folders_to_merged_folder):
1214 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1215 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1216 (modest_ui_actions_on_send):
1217 * src/widgets/modest-folder-view.c: (update_model):
1218 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1219 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1220 modest_tny_account_store_get_tny_account_by_account() to
1221 modest_tny_account_store_get_server_account() to make the code clearer.
1223 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1225 * src/dbus_api/modest-dbus-api.h:
1226 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1227 * src/maemo/modest-msg-edit-window.c:
1228 (modest_msg_edit_window_attach_file_noninteractive):
1229 added g_warning in case the file to be attached does not exist
1230 * tests/dbus_api/test_compose_mail.c: (main):
1231 removed obsolete comment, added generic files as test case
1233 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-tny-account-store.c: (get_server_accounts):
1236 Create the local folders account only once, not once for each outbox, and
1237 not only when there are some outboxes.
1239 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1241 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1242 code that is causing a crash at startup. Sergio says that he is fixing this.
1244 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1246 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1247 * src/maemo/modest-account-settings-dialog.c:
1248 (create_page_outgoing),
1249 (modest_account_settings_dialog_set_account_name),
1250 (save_configuration):
1251 - Fixed handling of the "Use secure authentication" toggle to comply with
1252 the ui specification. See also projects.maemo.org bug NB#58400
1254 - Restore the Secure connection setting combo correctly when loading
1257 * src/maemo/modest-maemo-utils.c:
1258 (on_camel_account_get_supported_secure_authentication),
1259 (modest_maemo_utils_get_supported_secure_authentication_methods):
1260 Fixed a crasher if operation is canceled
1262 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1263 (modest_protocol_info_auth_is_secure):
1264 * src/modest-protocol-info.h:
1266 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1267 the sense of the "Use secure authentication" toggle.
1269 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1271 * src/modest-tny-account-store.h:
1272 * src/modest-tny-account-store.c:
1273 Added modest_tny_account_store_get_local_folders_account().
1275 * src/modest-tny-folder.h:
1276 * src/modest-tny-folder.c:
1277 (modest_tny_folder_get_account):
1278 Added this replacement for tny_folder_get_account() which returns
1279 the local-folders account for TnyMergeFolders, to avoid the
1280 warning about the unimplemented get_account_func() vfunc().
1282 (modest_tny_folder_get_rules),
1283 * src/modest-ui-actions.c:
1284 (modest_ui_actions_on_folder_selection_changed):
1285 * src/modest-mail-operation.c:
1286 (modest_mail_operation_remove_folder),
1287 (modest_mail_operation_xfer_folder),
1288 (modest_mail_operation_rename_folder),
1289 (modest_mail_operation_get_msg),
1290 (modest_mail_operation_get_msgs_full),
1291 (modest_mail_operation_remove_msg),
1292 (modest_mail_operation_xfer_msgs),
1293 (modest_mail_operation_refresh_folder):
1294 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1296 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1298 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1299 (modest_server_account_set_security):
1300 * src/modest-defs.h: Add comments explaining that our
1301 UI spec means TLS when it says Normal, so these do not look like errors.
1303 * src/modest-tny-account.c:
1304 (modest_tny_account_new_from_server_account): Use the new tinymail
1305 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1306 for TLS. This should fix projects.maemo.org bug NB#58460.
1308 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1310 * src/maemo/easysetup/modest-easysetup-wizard.c:
1311 (create_account): Correct the position of the gconf sanity check warning.
1312 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1313 of using the g_idle_add() hack, because this does not seem to be necessary
1314 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1315 caused by something other than maemo's gconf.
1316 This fixes projects.maemo.org bug #59022.
1318 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1320 * src/modest-account-mgr-helpers.c:
1321 (modest_account_mgr_get_default_account): Do not check that the account
1322 exists if there is no default account (NULL), to fix a runtime warning.
1324 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1326 * src/widgets/modest-folder-view.c: (update_model):
1327 Do not unref the treemodel before we have finished with it.
1328 This prevents a valgrind warning and an occasional crash at startup.
1330 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1332 * libmodest-dbus-client/libmodest-dbus-client.h:
1333 added libmodest_dbus_client_compose_mail()
1334 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1336 added functions needed for SendAsMail() functionality
1337 * src/maemo/modest-msg-edit-window.c:
1338 (modest_msg_edit_window_attach_file_noninteractive):
1339 non interactively attaching files to message edit window
1340 * src/widgets/modest-msg-edit-window.h:
1341 * tests/dbus_api/Makefile.am:
1342 added test_compose_mail.c
1343 * tests/dbus_api/test_compose_mail.c: (main):
1345 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1347 * src/modest-account-view.c:
1348 Fixed bug projects.maemo.org bug NB#59307
1350 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1352 * src/maemo/easysetup/modest-easysetup-wizard.c:
1353 (get_serverport_incoming), (on_before_next), (create_account):
1354 * src/maemo/modest-account-settings-dialog.c:
1355 (modest_account_settings_dialog_set_account_name):
1356 * src/maemo/modest-maemo-utils.c:
1357 (on_camel_account_get_supported_secure_authentication_status),
1358 (on_camel_account_get_supported_secure_authentication),
1359 (on_secure_auth_cancel),
1360 (modest_maemo_utils_get_supported_secure_authentication_methods):
1362 Implemented security authentication for settings and easysetup.
1364 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1366 * src/maemo/modest-main-window.c: (create_details_widget):
1367 Show the total size for memory card accounts too, instead of showing
1368 the name again. Fixes bug projects.maemo.org bug NB#59307.
1370 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1373 * src/modest-tny-simple-folder-store.c:
1374 * src/modest-tny-simple-folder-store.h: Removed.
1376 * src/modest-tny-local-folders-account.h
1377 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1378 for the local-folders maildir, with an extra TnyMergedFolder containing
1379 the folders of the per-account outbox store accounts.
1380 * src/modest-tny-account-store.c: (get_server_accounts):
1381 Add the outboxes to the special local folders account after creating it.
1383 * src/modest-tny-account.c:
1384 (modest_tny_account_new_for_local_folders): Create the derived
1385 account when creating the main local-folders account.
1387 * src/maemo/modest-main-window.c: (create_details_widget),
1388 (modest_main_window_set_contents_style):
1389 Adapted to the use of the derived account instead of the folder store.
1391 * src/modest-ui-actions.c:
1392 (modest_ui_actions_on_folder_selection_changed):
1393 * src/modest-ui-dimming-rules.c:
1394 (modest_ui_dimming_rules_on_new_folder):
1395 * src/widgets/modest-folder-view.c: (text_cell_data),
1396 (icon_cell_data), (filter_row), (update_model),
1397 (get_cmp_rows_type_pos):
1400 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1401 Do not get the priv struct, because no priv struct has been set,
1402 to avoid a runtime warning.
1404 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1405 #ifelse with #else, to fix a warning, to fix the build.
1408 2007-06-05 Christian Kellner <ckellner@openismus.com>
1410 * libmodest-dbus-client/libmodest-dbus-client.c:
1411 Fix small typo in doc (why do you always see them
1412 AFTER committing stuff?)
1415 2007-06-05 Christian Kellner <ckellner@openismus.com>
1417 * libmodest-dbus-client/libmodest-dbus-client.c:
1418 (libmodest_dbus_client_search):
1419 Initialize hit list with NULL. Also set folder list
1420 to "" if NULL was supplied.
1423 2007-06-03 Christian Kellner <ckellner@openismus.com>
1425 * libmodest-dbus-client/libmodest-dbus-client.c:
1426 (modest_search_hit_list_free):
1427 Make it save to call it with NULL.
1429 * src/dbus_api/modest-dbus-callbacks.c:
1430 * src/modest-search.c:
1431 Return full ModestSearchHits as the search result list not TnyHeader
1432 since can't be around withouth the correspoding TnyFolder.
1434 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1436 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1437 Added currently commented code to check for secure auth
1439 * src/maemo/modest-account-settings-dialog.c: (on_response),
1440 (save_configuration), (show_ok):
1441 Fixed projects.maemo.org bugs NB #59248 and #59251
1443 * src/maemo/modest-maemo-utils.c:
1444 (on_camel_account_get_supported_secure_authentication_status),
1445 (on_camel_account_get_supported_secure_authentication),
1446 (modest_maemo_utils_get_supported_secure_authentication_methods):
1447 * src/maemo/modest-maemo-utils.h:
1448 Moved get_supported_secure_authentication() method here to be able
1449 to use it from easysetup wizard.
1451 * src/modest-pair.c: (on_pair_compare_as_string):
1452 Should compare string with first part of pair and not
1453 strcmp pairs which will crash.
1455 * src/modest-protocol-info.c:
1456 (modest_protocol_info_protocol_is_store):
1457 * src/modest-protocol-info.h:
1458 Added modest_protocol_info_get_auth_protocol_name()
1460 2007-06-03 Armin Burgmeier <armin@openismus.com>
1462 * src/modest-mail-operation.c:
1463 (modest_mail_operation_get_msgs_full): Set priv->account also when
1464 only retrieving a single message. This avoids a crash when canceling
1467 (modest_mail_operation_notify_end): Do not explicitely remove the
1468 operation from the queue but only emit the progress_changed signal.
1469 The queue itself listens to that signal to remove the operation when
1470 it is finished. This reduces coupling and removes a potential deadlock
1471 when modest_mail_operation_notify_end() is called from the queue
1472 itself. If that is a problem performance-wise, I would suggest to
1473 implement a status-changed signal or something.
1475 * src/modest-mail-operation-queue.c: Make sure to never call a
1476 function from another file while the queue is locked. This (hopefully)
1477 fixes another deadlock when exiting the application while retrieving
1480 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1482 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1483 Fixed build if libogs is not available
1485 2007-06-03 Christian Kellner <ckellner@openismus.com>
1487 * libmodest-dbus-client/libmodest-dbus-client.h:
1488 * libmodest-dbus-client/libmodest-dbus-client.c:
1489 (libmodest_dbus_client_delete_message):
1490 Implement deletion of messages (Client side).
1492 (modest_search_hit_free),
1493 (modest_search_hit_list_free):
1494 Utility functions to free the result hits.
1496 * src/dbus_api/modest-dbus-api.h:
1497 * src/dbus_api/modest-dbus-callbacks.c:
1498 (on_delete_message),
1499 (modest_dbus_req_handler):
1500 Implement deletion of messages (Server side).
1502 * tests/dbus_api/test_search.c: (main):
1505 * tests/dbus_api/Makefile.am:
1506 * tests/dbus_api/test_delete_message:
1507 Add little test for the message deletion logic
1509 2007-06-03 Armin Burgmeier <armin@openismus.com>
1511 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1512 when the operation queue was not empty. projects.maemo.org bug
1515 2007-06-03 Armin Burgmeier <armin@openismus.com>
1517 * src/widgets/modest-account-view.c
1518 (on_account_default_toggled): Toggle default account column
1519 explicitely instead of waiting for gconf notification (which is
1520 currently ignored). This should fix projects.maemo.org bug NB#56910
1521 for now. It should probably be removed when gconf notifications are
1524 2007-06-03 Christian Kellner <ckellner@openismus.com>
1526 * libmodest-dbus-client/libmodest-dbus-client.c:
1527 Removed debugging spew.
1529 * src/dbus_api/modest-dbus-callbacks.c:
1530 Added debugging info.
1532 * src/modest-search.c:
1533 (modest_search_all_accounts):
1534 Use tny_account_store_get_accounts () on the account store
1535 to get all accounts which is the way to get all accounts.
1537 * tests/dbus_api/test_search.c: (main):
1538 Make it possible to supply the search term on the command line.
1540 2007-06-03 Christian Kellner <ckellner@openismus.com>
1542 * libmodest-dbus-client/libmodest-dbus-client.c:
1543 * libmodest-dbus-client/libmodest-dbus-client.h:
1544 Implement searching for mesages over raw dbus. (Client side)
1546 * src/dbus_api/Makefile.am:
1547 * src/dbus_api/modest-dbus-api.h:
1548 * src/dbus_api/modest-dbus-callbacks.c:
1549 * src/dbus_api/modest-dbus-callbacks.h:
1550 Search framework (Server side). Also implement on_idle_open_message().
1552 * src/maemo/modest-platform.c: (modest_platform_init):
1553 Prepare for raw dbus/osso rpc interaction.
1555 * src/modest-search.h:
1556 Changed minsize from unspecific guint to guint32.
1558 * src/modest-search.c:
1560 Added strange hack which magically made tnymail work.
1562 (modest_search_folder),
1563 (modest_search_account),
1564 (modest_search_all_accounts):
1565 Implement helper functions to search all accounts, specific account
1568 * tests/dbus_api/Makefile.am:
1569 * tests/dbus_api/test_open_message.c:
1570 Read url to open from commandline.
1572 * tests/dbus_api/test_search.c:
1573 Implement small test for dbus search stuff
1575 2007-06-02 Armin Burgmeier <armin@openismus.com>
1577 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1578 include account type and account title. This fixes projects.maemo.org
1581 * src/maemo/modest-account-view-window.c: Set a title for the window.
1583 2007-06-02 Armin Burgmeier <armin@openismus.com>
1585 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1586 incoming and outgoing server name based on email address and server
1587 types as long as the names have not been edited manually. This fixes
1588 projects.maemo.org bug NB#58671.
1590 2007-06-02 Armin Burgmeier <armin@openismus.com>
1592 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1593 server type cannot be changed in future to the incoming details page
1594 when creating an account. This fixes projects.maemo.org bug NB#59029.
1596 2007-06-02 Armin Burgmeier <armin@openismus.com>
1598 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1599 and assigned max width chars so that they wrap instead of being
1600 truncated. Fixes projects.maemo.org bug NB#56126.
1602 2007-06-02 Armin Burgmeier <armin@openismus.com>
1604 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1605 introductory note to the connection specific smtp servers dialog, as
1606 section 8.12 of the email UI specification requires. This fixes
1607 projects.maemo.org bug NB#59212.
1609 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1611 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1612 Check for running mail operations, and offer to cancel them, as per the UI
1613 spec. This fixes projects.maemo.org bug NB#59041 .
1614 However, I suspect that tinymail may still use the network connection
1615 in ways that we cannot detect or cancel. But it should at least adapt to
1616 changes fairly well.
1618 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1620 * src/modest-tny-account-store.c: (recreate_all_accounts),
1621 (get_cached_accounts), (get_server_accounts): Do more sensible
1622 ref-counting of the temporarily-cached outbox accounts list. This seems
1623 to fix a crash when entering the password when the password was wrong.
1625 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1627 * src/gnome/modest-main-window.c: (connect_signals):
1628 * src/modest-tny-account-store.c: (get_password),
1629 (modest_tny_account_store_alert): Added comments and clues and
1630 commented-out code about how we currently fail to deal with connection
1631 errors and wrong passwords, and how we should.
1633 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1635 * src/widgets/modest-retrieve-combo-box.c:
1636 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1637 This fixes projects.maemo.org bug NB#58472 .
1639 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1641 * src/maemo/easysetup/modest-easysetup-wizard.c:
1642 (create_page_complete_easysetup):
1643 (create_page_complete_custom): Correct the last commit,
1644 putting the correct sentences in the correct pages.
1646 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1648 * src/maemo/easysetup/modest-easysetup-wizard.c:
1649 (create_page_complete_custom): Show the second sentence of text
1650 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1653 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1655 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1656 Set the leave-on-server conf key by default. This fixes
1657 projects.maemo.org bug NB#59258 .
1659 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1661 * src/maemo/modest-account-view-window.c:
1662 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1663 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1666 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1668 * src/maemo/easysetup/modest-easysetup-wizard.c:
1669 (create_caption_new_with_asterisk):
1670 * src/maemo/modest-account-settings-dialog.c:
1671 (create_caption_new_with_asterisk):
1672 Uncomment the code to add the asterisk, because they are no longer in the
1673 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1674 (update_incoming_server_title): Add an asterisk here too.
1676 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1678 * src/maemo/modest-maemo-global-settings-dialog.c:
1679 (current_connection): Check that we are even connected before trying to
1680 get the current connection name, to prevent a warning.
1682 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1683 Change the comments because tny_maemo_conic_device_connect() is now meant to
1685 * src/modest-mail-operation.c:
1686 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1687 make sure we have a connection and fail if we can't connect.
1689 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1691 * src/maemo/modest-main-window.c:
1692 (on_account_store_connecting_finished): Do not try to get the
1693 connection ID if we are not really connected. I am surprised that
1694 this signal handler is called when we are not connected.
1696 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1698 * src/modest-error.h:
1699 * src/modest-ui-actions.c:
1700 (modest_ui_actions_get_msgs_full_error_handler):
1701 Renamed an enum, added comments, added an enum
1702 for retrieve-limit errors.
1704 * src/modest-mail-operation.c: (foreach_add_item),
1705 (internal_folder_observer_update), (update_account_thread),
1706 (modest_mail_operation_get_msgs_full):
1707 (modest_mail_operation_update_account),
1708 Added comments about how this works, and some code that should
1709 (but does not) check the retrieve-limit. See the TODO comment.
1711 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1713 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1714 Initialize help_id to fix the build. Warnings are good.
1716 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1718 * src/widgets/modest-hbox-cell-renderer.c:
1719 (modest_hbox_cell_renderer_append):
1720 * src/widgets/modest-vbox-cell-renderer.c:
1721 (modest_vbox_cell_renderer_append):
1722 Fix the last commit by doing an extra ref.
1724 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1726 * src/widgets/modest-hbox-cell-renderer.c:
1727 (modest_hbox_cell_renderer_append):
1728 * src/widgets/modest-vbox-cell-renderer.c:
1729 (modest_vbox_cell_renderer_append):
1730 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1731 to fix the build with Maemo Bora.
1732 However, there seems to be a remaining crash, probably due to reference
1735 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1737 * src/modest-tny-account.c:
1738 (modest_tny_account_new_for_local_folders):
1739 Use hildon_file_system_info_async_new() to get a better name for
1740 the memory card account, setting it as the account name.
1741 The timing seems to work, but this is probably
1742 not the best place to do this. See the TODO comment.
1743 * src/maemo/modest-main-window.c: (create_details_widget):
1744 * src/widgets/modest-folder-view.c: (text_cell_data):
1745 Use the tny account name instead of hardcoding a name.
1747 2007-05-30 Christian Kellner <ckellner@openismus.com>
1749 * src/modest-search.c: (modest_search):
1750 Correctly set part_search_func even if we have already parsed
1751 the query and thus a valid OgsTextSearcher object.
1753 2007-05-30 Christian Kellner <ckellner@openismus.com>
1756 Search and check for libogs.
1759 Incooparte the ogs build env.
1761 * src/modest-mime-part-search-stream.c:
1762 * src/modest-mime-part-search-stream.h:
1763 Removed since we do the real searching now in modest-search.c.
1765 * src/modest-search.c:
1766 * src/modest-search.h:
1767 Implement support for ogs. We use that if available and requested
1768 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1769 should now handle the corner case when the search term is spread
1770 across multiple reads.
1771 Also the logic in modest_search () was corrected to search all
1772 requested fields until one is found.
1774 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1776 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1778 * src/modest-init.h:
1779 * src/modest-init.c: Made modest_init_local_folders() take a
1780 path and be public so we can iniitialize maildir folders on
1783 * src/modest-local-folder-info.h:
1784 * src/modest-local-folder-info.c:
1785 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1787 * src/modest-tny-account.c:
1788 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1789 still means the standard local-folders path on the local volume.
1791 * src/modest-tny-account-store.c:
1792 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1793 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1794 all accounts when that happens.
1795 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1796 this too, so it shows up in the treeview.
1798 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1800 * src/maemo/modest-maemo-global-settings-dialog.c:
1801 (current_connection):
1802 * src/widgets/modest-global-settings-dialog.c:
1803 (current_connection_default):
1804 Use the enum values instead of 0, 1 and -1,
1805 to make the code clearer.
1807 * src/modest-account-mgr-helpers.c:
1808 (modest_account_mgr_get_connection_specific_smtp): Make this code
1811 * src/modest-runtime.h:
1812 * src/modest-runtime.c:
1813 Added modest_runtime_remove_all_send_queues().
1814 * src/maemo/modest-main-window.c:
1815 (on_account_store_connecting_finished): Recreate the send queues,
1816 using the appropriate transport accounts for this new connection.
1817 Some futher adapting might be needed if the old send queues are not
1818 automatically stopped at this point.
1820 * src/modest-tny-account-store.c: (get_server_accounts):
1821 Create the connection-specific transport accounts, so that they can
1822 be found later by their ID.
1824 * src/modest-tny-account.h:
1825 * src/modest-tny-account.c:
1826 Added modest_tny_account_new_from_server_account_name().
1827 modest_tny_account_new_from_server_account(): Do not create the
1828 send queues here, because they will be
1829 recreated anyway when the connection changes for the first time.
1831 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1833 * src/modest-local-folder-info.h:
1834 * src/modest-local-folder-info.c:
1835 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1836 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1837 tbox_folder): Take a modest account name instead of a server TnyAccount,
1838 so we can have per-modest-account rather than per-transport-account
1840 We must make sure that we change or recreate the exisitng send queues
1841 when the connection changes for connection-specific transport accounts.
1843 * src/modest-tny-account-store.c:
1844 (create_per_account_local_outbox_folders): Create outboxed per modest
1845 account, not per transport account.
1847 * src/modest-tny-account.h:
1848 * src/modest-tny-account.c:
1849 (modest_tny_account_get_special_folder): For outboxes, get the
1850 parent modest account name. The account is ignored for other folders.
1851 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1852 modest account name rather than a server TnyAccount.
1854 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1856 * src/modest-tny-account.c:
1857 (modest_tny_account_new_from_server_account):
1858 Call modest_runtime_get_send_queue() immediately after creating transport
1859 accounts, so that they start trying to send email from the outbox as soon
1860 as possible at startup. This is probably what we want.
1862 * src/modest-mail-operation.c: (update_account_thread):
1863 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1864 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1865 * src/modest-tny-send-queue.h:
1866 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1867 (modest_ui_actions_on_send):
1868 Added comments about how sending works, though it needs some more work.
1870 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1872 * src/modest-tny-account.c:
1873 (modest_tny_account_get_special_folder): Add TODO because this fails when
1874 the network is busy.
1875 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1876 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1877 Do not try to show this window when there is no active account. The UI
1878 specs does not tell us what to do in this case.
1880 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1884 * src/maemo/Makefile.am:
1885 * src/widgets/Makefile.am: Some dist fixes.
1887 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1889 * src/maemo/modest-connection-specific-smtp-window.c:
1890 (on_button_edit): Make the code clearer, to prevent a double free.
1892 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1894 * src/maemo/modest-account-settings-dialog.c:
1895 (modest_account_settings_dialog_set_account_name),
1896 Check the connection-specific smtp servers checkbox if there are any.
1898 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1899 (modest_connection_specific_smtp_edit_window_init):
1900 Start with a suitable port number.
1902 * src/modest-account-mgr-helpers.h:
1903 * src/modest-account-mgr-helpers.c: Added
1904 modest_account_mgr_get_has_connection_specific_smtp().
1906 (modest_account_mgr_set_connection_specific_smtp),
1907 (modest_account_mgr_remove_connection_specific_smtp),
1908 (modest_account_mgr_get_has_connection_specific_smtp),
1909 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1910 connection-specific smtp server accounts in the account, rather than
1911 the server account conf dir.
1913 This fixes bug projects.maemo.org bug NB#58263 .
1915 * src/modest-tny-account-store.c:
1916 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1917 if there are no server accounts yet, to prevent an infinite loop when there
1918 are no accounts. Document that one must be called before the other.
1920 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1922 * src/modest-account-mgr-helpers.c:
1923 (modest_account_mgr_get_default_account): Make sure that at least
1924 one account is always the default, if there are any enabled accounts.
1925 This is just a sanity check that shouldn't be necessary.
1927 * src/modest-account-mgr-priv.c:
1928 (_modest_account_mgr_account_from_key): Unescape the conf key to
1929 get the real account name. For instance, this is an issue if a space
1930 was in the account name, which can happen because the account name
1931 is generated from the display name.
1932 (_modest_account_mgr_get_account_keyname): Always escape the
1934 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1935 Unescape the conf keys to get the real account names.
1937 For instance, previously the is-default radio button in the accounts
1938 list was not checked for any accounts at first. This fixes that,
1939 and might fix several similar bugs.
1941 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1943 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1944 Removed some debug printfs.
1946 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1948 Modest on-disk outbox directories are now here, for instance:
1949 $HOME/.modest/outboxes/<account-id-1>/outbox
1950 $HOME/.modest/outboxes/<account-id-2>/outbox
1952 $HOME/.modest/local-folders/outbox
1953 so we can have a separate outbox for each account.
1954 But they are shown as one outbox in the GtkTreeView, by using a
1955 TnyMergeFolder in a ModestTnySimpleFolderStore.
1958 * src/modest-tny-simple-folder-store.c:
1959 * src/modest-tny-simple-folder-store.h:
1960 Added ModestTnySimpleFolderStore, used to contain folders from
1961 other folder stores, such as other accounts.
1963 * src/modest-tny-outbox-account.h:
1964 * src/modest-tny-outbox-account.c:
1965 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1966 used for the per-account local outbox folders.
1968 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1969 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1970 only use this (internally) now for the non-outbox local folders.
1972 * src/modest-init.h:
1973 * src/modest-init.c: Added modest_init_one_local_folder(), for
1974 setting up the directory structure for each local folder.
1976 * src/modest-local-folder-info.c:
1977 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1978 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1980 * src/modest-local-folder-info.h:
1981 * src/modest-tny-account-store.c: (on_account_removed),
1982 (on_account_changed), (create_per_account_local_outbox_folders),
1983 (get_server_accounts), (modest_tny_account_store_get_accounts),
1984 (modest_tny_account_store_get_tny_account_by_account),
1985 (modest_tny_folder_store_is_virtual_local_folders):
1987 * src/modest-tny-account.h:
1988 * src/modest-tny-account.c:
1989 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1990 to create an on-disk per-account local outbox folder for each
1992 (create_per_account_local_outbox_folders): Create a local outbox folder
1993 for each transport account.
1994 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1995 for all local folders.
1997 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1998 instead of using g_object_get/set() directly. It is clearer.
2000 (modest_tny_folder_store_get_message_count),
2001 (modest_tny_folder_store_get_local_size
2002 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2003 because we now use these with non-acount folder stores.
2005 (modest_tny_account_get_special_folder),
2006 (modest_tny_account_new_from_server_account),
2007 (modest_tny_account_new_from_account):
2008 (recurse_folders): Adjust to the new outbox system.
2010 * src/modest-tny-folder.h:
2011 * src/modest-tny-folder.c:
2012 (modest_tny_folder_is_local_folder),
2013 (modest_tny_folder_get_local_folder_type),
2014 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2016 * src/widgets/modest-main-window.h:
2017 * src/maemo/modest-main-window.c: (create_details_widget),
2018 (modest_main_window_set_contents_style): Show details for any folder store,
2021 (modest_tny_folder_get_rules):
2022 Remove the const. C does not support constness enough for this.
2024 * src/modest-ui-actions.c:
2025 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2026 make all outboxes appear as one, in the usual local-folders tree node.
2028 (set_active_account_from_tny_account),
2029 (modest_ui_actions_on_folder_selection_changed):
2030 * src/widgets/modest-folder-view.c: (text_cell_data),
2031 (icon_cell_data), (filter_row),
2032 (add_account_folders_to_merged_folder),
2033 (add_account_folders_to_simple_folder_store), (),
2034 (get_cmp_rows_type_pos), (cmp_rows),
2035 (modest_folder_view_set_account_id_of_visible_server_account):
2036 Adjust to the new outbox system, using generic folder stores and folders
2037 in the GtkTreeModel.
2039 2007-05-23 Christian Kellner <ckellner@openismus.com>
2041 * src/modest-mail-operation.c:
2042 (modest_mail_operation_update_account):
2043 Use info->max_size instead of unintialized local var [small
2044 build fix]. (Added TODO to review that change since I don't
2047 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2049 * libmodest-dbus-client/libmodest-dbus-client.c:
2050 (libmodest_dbus_client_compose_mail): function added
2051 * src/dbus_api/modest-dbus-api.h:
2052 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2053 (on_compose_mail): Implementation of the SendAsMail functionality
2055 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2057 * src/modest-account-mgr.c:
2058 (modest_account_mgr_add_server_account): Set the secure-connection
2059 conf key for transport accounts as well as store accounts. I don't know
2060 why the if was there. For instance, this makes sure that we use SSL
2061 for the gmail preset from the easysetup wizard.
2063 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2065 * src/gnome/modest-main-window.c:
2066 (on_account_store_connecting_finished), (connect_signals):
2067 * src/maemo/modest-main-window.c:
2068 (on_account_store_connecting_finished), (connect_signals),
2069 (modest_main_window_new):
2070 Handle TnyAccountStore::connecting-finished instead of
2071 TnyDevice::connection-changed, because we cannot actually perform
2072 operations on accounts until TnyAccountStore has itself responded to
2073 the TnyDevice::connection-changed signal. This prevents a GError from
2075 Do not try to update at startup, because we (at least on scratchbox)
2076 already do an update at startup when the device goes online.
2077 This prevents a GError from tinymail.
2078 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2079 Added TODO about stopping simultaneous operations.
2081 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2084 * src/modest-mail-operation-queue.c:
2085 (modest_mail_operation_queue_remove):
2086 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2087 about where they happened.
2089 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2091 * src/modest-ui-actions.c:
2092 (modest_ui_actions_on_password_requested): Make sure that the remember
2093 output parameter is always TRUE.
2095 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2097 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2098 Show a OK/Cancel dialog if the error is a question, though we still do not
2099 know anything more about what we are asking the user.
2100 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2101 Fix an uninitialized variable (helper). This is a logic error, however.
2103 2007-05-21 Christian Kellner <ckellner@openismus.com>
2105 * src/modest-search.h:
2106 Correct bit shifting in the ModestSearchFlags enum.
2108 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2110 * src/modest-tny-account.c:
2111 (modest_tny_account_new_from_server_account): Do not use the lsub and
2112 check-all hard-coded IMAP options when using POP.
2114 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-tny-account.c:
2117 (modest_tny_account_new_from_server_account):
2118 Use NULL for the secure-auth method for POP when Password auth has been
2119 specified by the user, as we already do for IMAP. "auth=Login" causes
2120 an error from camel or the server.
2122 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2124 * src/maemo/modest-account-settings-dialog.c:
2125 (create_page_account_details),
2126 (modest_account_settings_dialog_set_account_name):
2127 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2128 for the leave-on-server checkbox, rathr than just the checkbox, when
2129 the protocol is not POP.
2131 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2133 * src/widgets/modest-account-view.c:
2134 * src/widgets/modest-account-view.h:
2135 Added modest_account_view_select_account() which will be useful later
2136 to asynchronously re-select the edited account.
2138 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/modest-account-settings-dialog.c:
2141 (modest_account_settings_dialog_set_account_name):
2142 Automatically choose the port numbers based on the secure authentication
2143 methods, if they have not been chosen before.
2144 This fixes projects.maemo.org bug NB#56273 .
2146 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2148 * src/maemo/modest-main-window-ui.h:
2149 * src/modest-ui-actions.c:
2150 * src/modest-ui-actions.h:
2151 Connect the Tools/SMTP Servers menu item to
2152 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2153 SMTP servers dialog, as in the UI specification and saves changes when it
2154 is closed. This fixed projects.maemo.org bug NB#56305 .
2156 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2158 * src/maemo/modest-connection-specific-smtp-window.c:
2159 (modest_connection_specific_smtp_window_init):
2160 Use gtk_window_set_default_size() to make this window big enough, so
2161 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2163 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2165 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2166 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2167 (modest_connection_specific_smtp_edit_window_init),
2168 Do not try to connect to a combobox signal before the combobox exists.
2169 This fixes the cras in projects.maemo.org bug NB#56288 .
2170 (modest_connection_specific_smtp_edit_window_get_settings):
2171 Remove the server_account_name parameter which was being checked for NULL
2172 though it was not used.
2174 * src/maemo/modest-connection-specific-smtp-window.c:
2175 (modest_connection_specific_smtp_window_fill_with_connections),
2176 (on_button_edit), (modest_connection_specific_smtp_window_init):
2177 Correct the number of treemodel columns to prevent a warning.
2178 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2179 libconic does not work.
2181 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2183 * src/modest-tny-account.c:
2184 (modest_tny_account_new_from_server_account):
2185 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2186 SMTP when "None" was chosen by the user. However, with my SMTP server that
2187 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2190 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2192 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2193 to explain the memory management issue with the ID in the ModestPair.
2195 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2196 (add_sending_page), (modest_account_assistant_finalize):
2197 * src/gnome/modest-gnome-global-settings-dialog.c:
2198 (create_updating_page), (create_composing_page):
2199 * src/gnome/modest-msg-edit-window.c: (get_transports),
2200 (init_window), (modest_msg_edit_window_finalize),
2201 (modest_msg_edit_window_get_msg_data):
2202 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2203 * src/gnome/modest-transport-widget.c:
2204 (modest_transport_widget_finalize), (smtp_configuration):
2205 * src/maemo/modest-maemo-global-settings-dialog.c:
2206 (create_updating_page), (create_composing_page):
2207 * src/maemo/modest-msg-edit-window.c: (get_transports),
2208 (init_window), (modest_msg_edit_window_finalize),
2209 (modest_msg_edit_window_get_msg_data),
2210 (modest_msg_edit_window_free_msg_data):
2211 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2212 (modest_store_widget_finalize):
2213 * src/maemo/modest-transport-widget.c:
2214 (modest_transport_widget_finalize), (smtp_configuration):
2215 * src/modest-main.c: (send_mail):
2216 * src/widgets/modest-combo-box.h:
2217 * src/widgets/modest-global-settings-dialog-priv.h:
2218 * src/widgets/modest-global-settings-dialog.c:
2219 (modest_global_settings_dialog_finalize):
2220 * src/widgets/modest-msg-edit-window.h:
2221 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2222 as long as the combo box, to prevent use of freed memory for the ID.
2224 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2226 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2227 get_accounts(), to make this clearer. Do not check for the enabled gconf
2228 key, because we do not use this for server accounts (at least, not yet).
2229 This allows us to send email again.
2231 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2233 * src/maemo/modest-platform.c:
2234 (on_modest_conf_update_interval_changed), (modest_platform_init):
2235 Only respond to this particular key change. All these strcmp()s cannot be
2238 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2240 * src/maemo/modest-maemo-global-settings-dialog.c:
2241 (current_connection): Prevent a crash in scratchbox when
2242 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2243 * src/maemo/modest-platform.c:
2244 (on_modest_conf_update_interval_changed), (modest_platform_init):
2245 Get the update interval from gconf and reset it when the gconf key changes.
2247 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2249 * src/modest-protocol-info.c:
2250 * src/modest-protocol-info.h: Adde enum-specific get functions,
2251 instead of using a ModestProtocolType enum parameter.
2253 * src/gnome/modest-account-assistant.c:
2254 * src/gnome/modest-store-widget.c:
2255 * src/gnome/modest-store-widget.h:
2256 * src/gnome/modest-transport-widget.c:
2257 * src/gnome/modest-transport-widget.h:
2258 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2259 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2260 * src/maemo/easysetup/modest-easysetup-wizard.c:
2261 * src/maemo/modest-account-settings-dialog.c:
2262 * src/maemo/modest-account-settings-dialog.h:
2263 * src/maemo/modest-store-widget.c:
2264 * src/maemo/modest-store-widget.h:
2265 * src/maemo/modest-transport-widget.c:
2266 * src/maemo/modest-transport-widget.h:
2267 * src/modest-account-mgr-helpers.c:
2268 * src/modest-account-mgr-helpers.h:
2269 * src/modest-account-mgr.c:
2270 * src/modest-account-mgr.h:
2271 * src/modest-tny-account.c:
2272 * src/modest-tny-folder.c:
2273 * src/widgets/modest-account-view.c:
2274 * src/widgets/modest-retrieve-combo-box.c:
2275 * src/widgets/modest-retrieve-combo-box.h:
2276 * src/widgets/modest-secureauth-combo-box.c:
2277 * src/widgets/modest-serversecurity-combo-box.c:
2278 * src/widgets/modest-serversecurity-combo-box.h:
2279 * tests/check_account-mgr.c:
2280 Use the specific functions, and use the re-renamed enum values for GNOME too.
2282 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2284 * src/modest-pair.h:
2285 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2286 so we can get the second based on the first.
2288 * src/maemo/modest-account-settings-dialog.h:
2289 * src/maemo/modest-account-settings-dialog.c:
2290 Added get_supported_secure_authentication_methods(), though it is mostly
2291 commented-out for now until the necessary API is committed to tinymail.
2292 (modest_account_settings_dialog_set_account_name),
2293 (save_configuration): Request the supported authentication methods from the
2294 server, so we can choose a working method.
2296 * src/modest-tny-account-store.h:
2297 * src/modest-tny-account-store.c:
2298 (modest_tny_account_store_get_session): Rename from
2299 tny_account_store_get_session().
2301 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2303 * src/modest-protocol-info.h: Split the ModestProtocol enum
2304 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2305 There was no need to have these unrelated values in one enum.
2307 * src/: many files: Adapted to changed enum. This makes the code a bit
2308 clearer, and the compiler could catch some errors.
2310 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2312 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2313 Show the detailed internal camel error message when an error happens
2314 during the configuration, so that our testers can give us more clues.
2315 For instance, in projects.maemo.org bug NB#56910 .
2317 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2319 * src/modest-tny-account.c:
2320 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2321 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2323 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2326 * src/maemo/modest-account-settings-dialog.c:
2327 (modest_account_settings_dialog_set_account_name),
2328 (save_configuration): For the incoming secure authentication checkbox,
2329 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2330 the UI specification. PLAIN does not seem to be supported for most IMAP
2331 servers anyway, and I am not sure what it would mean.
2332 However, we probably need to discover which of the secure-authentication
2333 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2334 * src/modest-account-mgr-helpers.c:
2335 (modest_account_mgr_get_server_account_data):
2337 * src/modest-tny-account.c:
2338 (modest_tny_account_new_from_server_account):
2339 Use tny_account_set_mech() to set secure-authentication methods,
2340 with some special-casing for IMAP, based on my observations of how
2343 * src/modest-account-mgr-helpers.h:
2344 * src/modest-account-mgr.c:
2345 * src/modest-defs.h: Comment that the URI is only used for local folders.
2347 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2350 parameter const, just to be neat.
2351 * src/modest-text-utils.c: (modest_text_utils_inline):
2352 End g_strconcat() with NULL, as its documentation says. This is almost
2353 certainly the cause of my crash at startup on the device. Interestingly,
2354 valgrind doesn't tell us about these errors.
2356 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2358 * scripts/build-packages: Added more precise comments about how to use
2359 this script, though I still get this error:
2360 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2361 error building tinymail
2363 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2365 * src/maemo/modest-main-window.c: (on_account_update):
2366 Very slight cleanup, hoping to make it simpler to discover what causes
2367 a crash here sometimes.
2369 * src/modest-tny-account.c:
2370 (modest_tny_account_new_from_server_account): Set the port. Added
2371 comments about the options and a TODO comment because I need to find out
2372 how to specify the secure authentication method.
2374 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2376 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2377 changed CFlags paths form modest to libmodest
2379 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2381 * src/modest-account-mgr-helpers.c:
2382 (modest_account_mgr_get_server_account_data),
2383 (modest_account_mgr_free_server_account_data):
2384 * src/modest-account-mgr-helpers.h:
2385 * src/modest-account-mgr.c:
2386 (modest_account_mgr_add_server_account):
2387 * src/modest-defs.h:
2388 * src/modest-tny-account.c:
2389 (modest_tny_account_new_from_server_account):
2390 Determine the options for tny_camel_account_add_option() here,
2391 based on the settings, rather than storing them directly in gconf.
2393 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2395 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2396 Show a more friendly error dialog now that we expect (from the tinymail
2397 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2399 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2401 * src/maemo/modest-main-window.c: (on_account_update): Check that
2402 account_name is not NULL, to prevent a crash at startup that I am
2403 seeing on the N800. I do wonder why it is NULL.
2405 * src/maemo/easysetup/modest-easysetup-wizard.c:
2406 (create_page_user_details):
2407 * src/maemo/modest-account-settings-dialog.c:
2408 (create_page_user_details), (create_page_outgoing):
2409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2410 (modest_connection_specific_smtp_edit_window_init):
2411 * src/modest-ui-actions.c:
2412 (modest_ui_actions_on_password_requested):
2413 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2414 might do something useful with the on-screen keyboard.
2416 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2418 * src/maemo/modest-main-window.c: (on_account_update):
2419 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2420 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2422 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2424 * src/modest-tny-account-store.c: (on_account_changed):
2425 Correct the signature of this signal handler.
2427 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2429 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2430 Show a HildonNote instead of a GtkDialog for Maemo.
2432 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2434 * src/widgets/modest-account-view.h:
2435 * src/widgets/modest-account-view.c: (on_account_changed),
2436 (on_account_removed). Added a boolean flag, set/unset by
2437 modest_account_view_block_conf_updates(),
2438 modest_account_view_unblock_conf_updates() to prevent unnecessary
2439 updates, but this is not very useful because the gconf notifications are
2440 so delays (maybe only on Maemo Bora).
2441 So auto-updating is turned off, and these functions do an explicit
2442 update when necessary.
2443 However, something else is still doing too much work when adding/removing
2444 accounts, probably in another part of the application.
2446 * src/maemo/modest-account-view-window.c:
2447 (on_delete_button_clicked), (on_edit_button_clicked),
2448 (on_new_button_clicked): Use the new functions.
2450 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2452 * src/modest-account-mgr-helpers.c:
2453 (modest_account_mgr_set_first_account_as_default):
2454 Sort the list of names alphabetically-by-title, so we choose the first one
2456 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2457 alphabetically by the title.
2459 This fixes projects.maemo.org bug NB#56418 .
2461 * src/modest-account-mgr-priv.c:
2462 (_modest_account_mgr_account_from_key):
2463 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2464 avoid a valgrind error, and possible random behaviour.
2466 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2468 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2469 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2470 tinymail documentation to say that this can be expected.
2471 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2472 pretty, and should not happen, but I would prefer to know when it does.
2474 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2476 * configure.ac: When using the older hildon version, probably on Bora,
2477 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2479 * src/widgets/modest-attachment-view.c:
2480 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2483 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2485 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2486 Implemented the prototype. Can be tested with
2487 tests/dbus_api/test_open_message:
2489 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2491 * src/modest-tny-account-store.c:
2492 (modest_tny_account_store_instance_init), (get_password):
2493 * src/modest-ui-actions.c:
2494 (modest_ui_actions_on_password_requested):
2495 Do not store the password in gconf, because this function is called
2496 for non-remembered passwords. Actually use the cached (in the hash map)
2497 password instead of releasing it.
2498 The password will now not be remembered if it is asked via the protected
2499 password dialog, as per the UI spec.
2501 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2503 * src/modest-defs.h:
2504 * src/modest-account-mgr-helpers.h:
2505 * src/modest-account-mgr-helpers.c:
2506 Added modest_server_account_get_username_has_succeeded(),
2507 modest_server_account_set_username_has_succeeded().
2508 (modest_server_account_set_username),
2509 Reset the has-succeeded flag if the username changes.
2511 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2512 * src/maemo/modest-connection-specific-smtp-window.c:
2513 (modest_connection_specific_smtp_window_save_server_accounts):
2514 Use modest_server_account_set_username() instead of using
2515 modest_conf_set_string() directly, so that the has-succeeded flag is always
2518 * src/modest-ui-actions.c:
2519 (modest_ui_actions_on_password_requested): Dim the username entry if
2520 the username has ever worked, as per the UI spec.
2522 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2524 * src/modest-tny-account-store.c: (get_password):
2525 * src/modest-ui-actions.c:
2526 (modest_ui_actions_on_password_requested):
2527 Allow the username to be changed too, though there is more work to
2528 be done on exactly how this behaves.
2530 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2532 * src/modest-account-mgr-helpers.h:
2533 * src/modest-account-mgr-helpers.c:
2534 Added modest_account_mgr_get_display_name(),
2535 modest_server_account_get_username(),
2536 modest_server_account_set_username(),
2537 modest_server_account_set_password(),
2538 modest_server_account_get_hostname() functions so we do not need to
2539 use the conf API directly.
2541 * src/maemo/modest-main-window.c: (connect_signals):
2542 Actually connect ot the ModestAccountStore::request-password signal,
2543 so that we show the dialog when the password is requested by Tinymail,
2544 for isntance if it is empty.
2546 * src/modest-marshal.list:
2547 * src/modest-tny-account-store.c:
2548 (modest_tny_account_store_class_init), (get_password),
2549 (modest_tny_account_store_alert):
2550 * src/modest-tny-account-store.h:
2551 * src/modest-ui-actions.h:
2552 * src/modest-ui-actions.c:
2553 (modest_ui_actions_on_password_requested):
2554 Change the signal parameters, so it is obvious that we are providing
2555 the non human-readable server name, and receiving both the username
2556 and password, though changing of the username is not yet implemented.
2557 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2558 for the GNOME version.
2560 This should fix the projects.maemo.org bug NB#56209, though it does not
2561 work on Bora, because the gconf_client_get() for the password fails
2562 immediately after we save it with gconf_client_set().
2564 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2567 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2568 caused an undefined symbol error:
2569 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2571 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2573 * src/modest-tny-account-store.c:
2574 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2575 using a GError instead of a string message, so we can translate it in
2578 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2580 * src/maemo/modest-address-book.c:
2581 (modest_address_book_check_names):
2582 * src/maemo/modest-msg-view-window.c:
2583 (modest_msg_view_window_clipboard_owner_change):
2584 * src/modest-init.c: (modest_init_init_ui):
2585 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2586 (update_folders_cb), (modest_mail_operation_update_account):
2587 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2588 (modest_ui_actions_on_msg_attachment_clicked),
2589 (modest_ui_actions_on_msg_recpt_activated):
2590 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2591 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2592 (modest_msg_view_search_next):
2593 * src/widgets/modest-recpt-editor.c:
2594 (modest_recpt_editor_on_button_release_event),
2595 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2596 g_message(). At this point we should only be seeing interesting errors on
2597 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2599 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2601 (modest_wizard_dialog_force_title_update):
2602 * src/maemo/easysetup/modest-wizard-dialog.h:
2603 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2604 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2605 can update the title when appropriate. Otherwise the title is wrong if the
2606 pages are added after adding the notebook to the dialog.
2607 This must be a problem in HildonWizardDialog too.
2608 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2610 * src/maemo/easysetup/modest-easysetup-wizard.c:
2611 (create_subsequent_customsetup_pages),
2612 (create_subsequent_easysetup_pages):
2613 Call modest_wizard_dialog_force_title_update() so that the title is
2614 correct even with GTK+ < 2.10.
2615 This fixes projects.maemo.org bug NB#56145 .
2617 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2619 * src/maemo/modest-platform.c:
2620 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2621 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2624 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2626 * src/widgets/modest-window.h:
2627 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2628 and modest_window_save_state(), which invokes it.
2630 * src/widgets/modest-window-mgr.h:
2631 * src/widgets/modest-window-mgr.c:
2632 Added modest_window_mgr_save_state_for_all_windows(), which calls
2633 the save_state vfunc on all registered windows, if implemented.
2635 * src/gnome/modest-msg-edit-window.c:
2636 * src/gnome/modest-msg-view-window.c:
2637 * src/maemo/modest-msg-edit-window.c:
2638 * src/maemo/modest-msg-view-window.c:
2639 * src/maemo/modest-main-window.c:
2640 Specify the existing save_settings functions as implementations of
2641 ModestWindow::save_state_func().
2643 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2644 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2645 enabling hibernation, for instance.
2647 We may need to do the same thing for restoring settings.
2650 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2652 * src/widgets/modest-window-mgr.c:
2653 * src/widgets/modest-window-mgr.h:
2654 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2655 modest_window_mgr_get_hibernation_is_prevented().
2657 * src/maemo/modest-main-window.c:
2658 (on_hildon_program_is_topmost_notify): Prevent hibernation
2659 (possible when the application goes to the background in the WM),
2660 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2662 * src/maemo/easysetup/modest-easysetup-wizard.c:
2663 (modest_easysetup_wizard_dialog_init):
2664 * src/maemo/modest-account-settings-dialog.c:
2665 (modest_account_settings_dialog_init):
2666 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2667 (modest_connection_specific_smtp_edit_window_init):
2668 * src/maemo/modest-connection-specific-smtp-window.c:
2669 (modest_connection_specific_smtp_window_init):
2670 * src/maemo/modest-signature-editor-dialog.c:
2671 (modest_signature_editor_dialog_init):
2672 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2673 prevent hibernation while any of these account settings dialogs are open.
2675 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/Makefile.am:
2678 * src/maemo/modest-osso-state-saving.c:
2679 * src/maemo/modest-osso-state-saving.h: Added
2680 modest_osso_load_state() and modest_osso_save_state() though they do
2681 nothing now. They should iterate through all the open windows and load/save
2683 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2684 save state when closing.
2686 * src/maemo/modest-main-window.c:
2687 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2688 Add a notification handler for the HildonProgram::is-topmost property,
2689 so we can allow hibernation when the application goes into the background.
2690 But we still need to detect when the accounts setup windows are open so
2691 we can stop hibernation when they are open.
2692 To do this, I also added the main window the HildonProgram. This might have
2693 other side-effects/benefits, and should maybe be done for other windows.
2695 * src/maemo/modest-osso-autosave-callbacks.h:
2696 * src/maemo/modest-osso-autosave-callbacks.c:
2697 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2698 though it does not do anything yet, and we might never need this to do
2699 anything. For instance, we already save drafts.
2701 * src/maemo/modest-platform.c: (modest_platform_init):
2702 Specify the libosso auto-save callback.
2704 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2706 * src/maemo/modest-platform.c:
2707 (modest_platform_set_update_interval):
2708 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2709 aparently stays valid between application instances, so we can use this
2710 to remove and reset it later. According to a maemo-developers email from
2713 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2715 * configure.ac: Depend on libalarm for Maemo.
2717 * src/dbus_api/modest-dbus-api.h:
2718 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2719 (on_send_receive), (modest_dbus_req_handler):
2720 Handle a SEND_RECEIVE D-Bus method.
2722 * libmodest-dbus-client/libmodest-dbus-client.c:
2723 (libmodest_dbus_client_send_and_receive):
2724 * libmodest-dbus-client/libmodest-dbus-client.h:
2725 Add C convenience functions for calling the new D-Bus method.
2727 * src/modest-platform.h:
2728 * src/gnome/modest-platform.c:
2729 * src/maemo/modest-platform.c:
2730 Added modest_platform_set_update_interval(), which uses the
2731 alarmd API on Maemo.
2732 (modest_platform_init),
2733 Call modest_platform_set_update_interval(), using a hard-coded
2734 interval for now (until the global settings dialog is implemented),
2735 though I am not sure that this makes sense yet.
2737 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2739 * src/dbus_api/modest-dbus-callbacks.c:
2740 (modest_osso_cb_hw_state_handler):
2741 * src/dbus_api/modest-dbus-callbacks.h:
2742 * src/maemo/modest-platform.c: (modest_platform_init):
2743 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2744 in case this has some effect on the ability for Maemo to ping the
2747 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2749 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2750 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2751 warning. It is probably a logic error, but I need to fix the build.
2753 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2755 * src/modest-account-mgr.h:
2756 * src/modest-account-mgr.c:
2757 (modest_account_mgr_account_names): Add a gboolean enabled_only
2758 parameter, so we can get lists of onlt the enabled accounts.
2760 (modest_account_mgr_add_account),,
2761 (modest_account_mgr_account_with_display_name_exists):
2762 * src/maemo/modest-msg-edit-window.c: (get_transports):
2763 * src/modest-account-mgr-helpers.c:
2764 (modest_account_mgr_set_first_account_as_default):
2765 * src/modest-init.c: (init_default_account_maybe):
2766 * src/modest-tny-account-store.c: (get_accounts):
2767 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2768 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2769 * tests/check_account-mgr.c: (START_TEST):
2770 Provide the extra parameter, as appropriate.
2772 * src/widgets/modest-account-view.c: (update_account_view):
2773 Do not show disabled accounts (meaning that there is no way to
2774 enable/disable accounts in the UI (the feature is not in our UI
2775 specification), so we can use this internally only to mark unfinished
2776 or temporary account data.
2778 * src/maemo/easysetup/modest-easysetup-wizard.c:
2779 (create_account): Add boolean enable parameter, so we can specify FALSE
2780 to create the temporary account.
2781 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2782 (on_before_next): When finishing, when there is a temporary account, just
2784 Also, use a timeout to delay the showing of the dialog until gconf is likely
2785 to return correct information, due to a maemo gconf bug that is fixed in
2786 osso 1.1, but not yet in Bora.
2787 However, the dialog stays on screen after it is destroyed.
2789 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2790 for invalid data when cancelling. Use a hildon note instead of a dialog
2791 to complain about invalid data. Do not show the account-saved note if the
2792 account is disabled (a temporary account that will not really be saved for use
2795 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2797 * src/modest-account-mgr-helpers.h:
2798 * src/modest-account-mgr-helpers.c:
2799 Added modest_account_mgr_unset_default_account(),
2800 Added modest_account_mgr_set_first_account_as_default().
2802 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2803 If it was the default account, unset the default account name.
2805 * src/maemo/modest-account-view-window.c:
2806 (on_delete_button_clicked): If it was the default account,
2807 set the first remaining account as the default instead.
2809 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2810 a NULL account or a NULL default account, to prevent a crash. This should
2811 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2814 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2816 * src/widgets/modest-recpt-editor.c:
2817 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2818 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2819 TODO comment for this. This fixes the build.
2821 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2822 be the best place for it. This will in future update all auto-update accounts,
2823 rather than just the current/default account, when that gconf key exists.
2824 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2825 if there are no accounts, before calling do_send_receive().
2826 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2828 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2829 * src/maemo/modest-main-window-ui.h:
2830 * src/maemo/modest-main-window.c: (on_connection_changed),
2831 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2832 directly, becaue the signal handler does more.
2834 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2836 * src/modest-account-mgr-helpers.c:
2837 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2838 for the case that the account does not exist.
2840 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2841 (equivalent to the modest account name) rather than the tinymail account name
2842 (equivalent to the modest account title - human readable) to get the account data.
2843 Check for null account data to prevent the crash, and add a TODO comment saying that
2844 this needs fixing because it is using the server account name instead of the account name.
2846 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2848 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2849 * src/maemo/modest-account-settings-dialog.c: (show_error),
2851 Use hildon_note_new_information() for informative and error messages,
2852 which seems to be expected for Maemo applications (no documentation that I know of
2853 says this). I am surprised that there is no distinction between info and error
2856 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2858 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2859 it is easy to find where this is used.
2861 * src/maemo/easysetup/modest-easysetup-wizard.c:
2862 (create_page_welcome), (create_page_account_details),
2863 (create_page_user_details), (create_page_complete_easysetup),
2864 (create_page_custom_incoming), (create_page_custom_outgoing),
2865 (create_page_complete_custom):
2866 * src/maemo/modest-account-settings-dialog.c:
2867 (create_page_account_details), (create_page_user_details),
2868 (create_page_incoming), (create_page_outgoing):
2869 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2870 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2871 (modest_connection_specific_smtp_edit_window_init):
2872 * src/maemo/modest-connection-specific-smtp-window.c:
2873 (modest_connection_specific_smtp_window_init):
2874 * src/maemo/modest-signature-editor-dialog.c:
2875 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2876 and scrolling policy as per the Email Application Layout Guide, if I have
2879 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2881 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2882 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2883 which were empty, because these vfuncs have been removed from TnyAccountStore.
2884 This fixes the build.
2886 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2888 * src/maemo/modest-main-window.c:
2889 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2890 showing/hiding it. Added TODO because it probably should not be NULL.
2891 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2892 because unnecessary g_warnings() make degugging difficult.
2894 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2896 * src/maemo/modest-msg-edit-window.c:
2897 (modest_msg_edit_window_select_color),
2898 (modest_msg_edit_window_select_background_color): 2 const corrections and
2899 moving 2 #endifs before closing brackets, to fix the build.
2901 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2903 * src/maemo/easysetup/modest-easysetup-wizard.h:
2904 * src/maemo/easysetup/modest-easysetup-wizard.c:
2905 (modest_easysetup_wizard_dialog_finalize),
2906 (on_button_edit_advanced_settings), (create_page_complete_custom),
2907 (on_response), (create_account):
2908 Implement the Advanced Settings edit button, by saving the account information,
2909 for the Advanded Settings dialog to use directly from gconf, and removing it
2910 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2911 Bug #5533 in the projects.maemo.org bugzilla.
2913 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2915 * src/maemo/modest-msg-view-window.c:
2916 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2917 when opening a message window.
2919 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2921 * src/maemo/easysetup/modest-easysetup-wizard.c:
2922 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2925 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2926 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2927 gconf settings. I probably added more checks than necessary, but that is safer.
2929 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2930 variable to fix the build, but this seems to be used when it is still NULL.
2932 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2934 * src/modest-platform.h:
2935 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2936 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2937 * src/modest-main.c: Implement this function so we can avoid using
2938 maemo-specific API from cross-platform code.
2940 * src/modest-tny-account-store.c:
2941 (get_smtp_specific_transport_account_for_open_connection):
2942 * src/modest-ui-actions.c: (check_for_connection),
2943 (modest_ui_actions_on_item_not_found):
2944 Use modest_platform_connect_and_wait() and put #idefs around other
2945 maemo-specific code, because only maemo currently has a way to
2946 identify connection names.
2948 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2950 * src/modest-tny-account-store.h:
2951 * src/modest-tny-account-store.c:
2952 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2953 the connection-specific SMTP server settings in the configuration.
2955 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2957 * src/maemo/modest-main-window.c: (on_connection_changed),
2959 * src/modest-main.c: (main), (start_ui), (send_mail):
2960 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2961 that is what is intended.
2963 * src/modest-ui-actions.c: (action_send), (action_receive),
2964 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2965 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2966 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2967 SMTP server is used when it is specified.
2969 (modest_ui_actions_on_send_receive):
2970 Check that a connection is open before proceeding.
2971 Receive and then send, instead of vice-versa, as per the specification.
2973 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2975 * src/modest-mail-operation.c:
2976 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2977 though I guess it should be something other than NULL.
2979 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2981 * src/maemo/easysetup/modest-easysetup-wizard.c:
2982 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2983 combo twice, to avoid an g_warning and to make it visible again.
2984 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2985 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2986 (already intended) dereference when detaching, because we then recreate the menu.
2987 But I am not sure why the warning was happening, and it is possible that this is a memory
2990 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2992 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2993 and uri_parse_mailto() utility functions.
2994 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2996 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2998 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3000 * src/dbus_api/modest-dbus-api.h:
3001 * src/dbus_api/modest-dbus-callbacks.c:
3002 Use an idle callback to execute the modest code in the application's own thread.
3003 Remove the helloworld example method.
3004 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3005 parsed, and the open-message method is not implemented because this is not yet implemented in
3007 * libmodest-dbus-client/libmodest-dbus-client.c:
3008 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3009 (libmodest_dbus_client_open_message):
3010 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3012 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3013 body without crashing.
3015 * tests/dbus_api/Makefile.am:
3016 * tests/dbus_api/test_mail_to.c:
3017 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3019 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3021 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3022 Added file to fix the build. Sorry.
3024 * src/dbus_api/Makefile.am:
3025 * src/dbus_api/modest-dbus-api.h:
3026 * src/dbus_api/modest-dbus-callbacks.h:
3027 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3028 (modest_dbus_req_handler):
3029 Put constants in a separate header so it can be reused by the
3030 client library, without duplication
3032 * libmodest-dbus-client/Makefile.am:
3033 * libmodest-dbus-client/libmodest-dbus-client.c:
3034 (libmodest_dbus_client_call_helloworld),
3035 (libmodfest_dbus_client_send_mail),
3036 (libmodfest_dbus_client_mailto),
3037 (libmodfest_dbus_client_open_message):
3038 * libmodest-dbus-client/libmodest-dbus-client.h:
3039 (Partly) Implement a send_mail D-Bus method.
3041 * tests/dbus_api/Makefile.am:
3042 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3043 the send_email D-Bus method.
3045 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3049 * libmodest-dbus-client/Makefile.am:
3050 * libmodest-dbus-client/libmodest-dbus-client.c:
3051 * libmodest-dbus-client/libmodest-dbus-client.h:
3052 * tests/dbus_api/Makefile.am:
3053 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3054 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3056 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3058 * src/maemo/easysetup/modest-easysetup-wizard.c:
3059 (create_page_account_details):
3060 * src/maemo/modest-account-settings-dialog.c:
3061 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3062 widgets, because this might not be the default in future versions of the Maemo GTK+.
3063 However, I can not not get capitalization to work even in a simple test case.
3065 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3067 * src/maemo/easysetup/modest-easysetup-wizard.c:
3068 (create_page_custom_incoming), (create_page_custom_outgoing):
3069 * src/maemo/modest-account-settings-dialog.c:
3070 (create_page_account_details), (create_page_incoming),
3071 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3072 instead of using gtk_check_button_with_label(), so they are aligned like the other
3073 widgets, as per the UI spec.
3075 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3077 * src/maemo/easysetup/modest-easysetup-wizard.c:
3078 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3079 * src/widgets/modest-validating-entry.c:
3080 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3081 Modest prefix instead of an EasySetup prefix.
3083 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3085 * src/widgets/modest-validating-entry.h:
3086 * src/widgets/modest-validating-entry.c: (on_insert_text),
3087 Added easysetup_validating_entry_set_max_func(), used to set a callback
3088 to call when the max number of characters is reached. GtkEntry has a max-length
3089 already but is silent about it.
3091 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3092 (create_page_account_details), (create_page_user_details),
3094 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3095 (create_page_account_details), (create_page_user_details),
3096 (create_page_outgoing):
3097 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3098 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3099 the UI spec, when the user tries to enter more than the max number of characters.
3101 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3103 * src/maemo/easysetup/modest-easysetup-wizard.c:
3104 (create_page_user_details), (create_page_custom_incoming),
3105 (create_page_custom_outgoing):
3106 * src/maemo/modest-account-settings-dialog.c:
3107 (create_page_user_details), (create_page_incoming),
3108 (create_page_outgoing):
3109 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3110 (modest_connection_specific_smtp_edit_window_init):
3111 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3112 not appropriate. Bad Maemo-specific defaults!.
3114 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3116 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3117 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3118 (modest_signature_editor_dialog_set_settings):
3119 Disable the label and textview when the checkbox is disabled, and use the
3120 specified (UI spec) default signature text.
3122 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3124 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3125 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3127 * src/modest-defs.h:
3128 * src/modest-account-mgr-helpers.h:
3129 * src/modest-account-mgr-helpers.c:
3130 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3132 * src/maemo/Makefile.am:
3133 * src/maemo/modest-signature-editor-dialog.c:
3134 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3137 * src/maemo/modest-account-settings-dialog.h:
3138 * src/maemo/modest-account-settings-dialog.c:
3139 (modest_account_settings_dialog_finalize), (on_button_signature),
3140 (save_configuration): Use the new dialog when the Edit button is pressed, and
3141 save the changes if necessary, as per the UI spec.
3143 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3145 * src/maemo/Makefile.am:
3146 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3147 based on maemo-develoers email from Dirk.
3149 * src/maemo/easysetup/modest-easysetup-wizard.c:
3150 (create_page_welcome), (create_page_account_details),
3151 (create_page_user_details), (create_page_complete_easysetup),
3152 (create_page_custom_incoming), (create_page_custom_outgoing),
3153 (create_page_complete_custom),
3154 (modest_easysetup_wizard_dialog_init):
3155 * src/maemo/modest-account-settings-dialog.c:
3156 (create_page_account_details), (create_page_user_details),
3157 (create_page_incoming), (create_page_outgoing),
3158 (modest_account_settings_dialog_init):
3159 * src/maemo/modest-connection-specific-smtp-window.c:
3160 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3162 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3164 * src/maemo/easysetup/modest-easysetup-wizard.c:
3165 (create_page_account_details), (create_page_custom_outgoing),
3166 (create_page_complete_custom):
3167 * src/maemo/modest-account-settings-dialog.c:
3168 (create_page_user_details), (create_page_incoming),
3169 (create_page_outgoing):
3170 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3171 (modest_connection_specific_smtp_edit_window_init):
3172 Use the correct (UI spec) port min/max, and use horizontal separators,
3175 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3177 * src/maemo/easysetup/modest-easysetup-wizard.c:
3178 (set_default_custom_servernames):
3179 * src/maemo/modest-account-settings-dialog.c:
3180 (create_page_incoming), (on_combo_outgoing_security_changed),
3181 (on_combo_incoming_security_changed), (create_page_outgoing),
3182 (modest_account_settings_dialog_set_account_name),
3183 (save_configuration):
3184 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3185 (on_combo_security_changed),
3186 (modest_connection_specific_smtp_edit_window_init),
3187 (modest_connection_specific_smtp_edit_window_set_connection),
3188 (modest_connection_specific_smtp_edit_window_get_settings):
3189 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3192 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/easysetup/modest-easysetup-wizard.c:
3196 (create_page_custom_outgoing), (create_page_complete_custom):
3197 * src/maemo/modest-account-settings-dialog.c:
3198 (create_page_user_details), (create_page_outgoing):
3199 * src/maemo/modest-account-view-window.c: (button_box_new):
3200 Use changed logical IDs as per the most recent UI spec:
3201 mcen_bd_emailsetup_edit -> mcen_bd_edit
3202 mcen_bd_emailsetup_delete -> mcen_bd_delete
3203 mcen_bd_emailsetup_close -> mcen_bd_close
3205 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3209 * src/dbus_api/Makefile.am:
3210 * src/dbus_api/modest-dbus-callbacks.c:
3211 * src/dbus_api/modest-dbus-callbacks.h:
3212 * src/maemo/modest-platform.c: (modest_platform_init):
3213 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3215 * tests/Makefile.am:
3216 * tests/dbus_api/Makefile.am:
3217 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3219 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3221 * src/maemo/modest-account-settings-dialog.c:
3222 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3223 Removed unnecessary includes.
3225 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3227 * src/maemo/easysetup/modest-easysetup-wizard.c:
3228 * src/maemo/modest-account-settings-dialog.c:
3229 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3230 * src/widgets/Makefile.am:
3231 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3232 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3233 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3234 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3235 * src/widgets/modest-secureauth-combo-box.c:
3236 * src/widgets/modest-secureauth-combo-box.h:
3237 * src/widgets/modest-serversecurity-combo-box.c:
3238 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3239 made the GObject names more consistent with the rest of the Modest code.
3241 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3243 * src/maemo/easysetup/Makefile.am:
3244 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3245 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3246 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3247 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3248 * src/maemo/easysetup/modest-easysetup-wizard.c:
3249 * src/maemo/easysetup/modest-validating-entry.c:
3250 * src/maemo/easysetup/modest-validating-entry.h:
3251 * src/maemo/modest-account-settings-dialog.c:
3252 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3253 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3254 widgets/ because they are used outside of easysetup too. After checking in,
3255 svn will allow me to rename them too.
3257 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3259 * src/gnome/modest-msg-edit-window.c:
3260 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3261 linker error, to fix the build on the GNOME platform.
3262 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3263 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3264 ifdefed out to avoid a warning.
3266 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3268 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3269 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3270 some alternative for GTK+ 2.6.
3272 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3274 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3276 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3277 specified for EmailAccountsDialog in UI spec.
3279 * src/maemo/easysetup/modest-easysetup-wizard.c:
3280 * src/maemo/easysetup/modest-easysetup-wizard.h:
3281 * src/maemo/modest-account-settings-dialog.c:
3282 * src/maemo/modest-account-settings-dialog.h:
3283 Reuse a member window widget for the connection-specific SMTP server accounts,
3284 so we can tell it to create/save the accounts only if we actually save changes.
3286 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3287 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3288 (modest_connection_specific_smtp_edit_window_get_settings):
3289 Return a struct instance for temporarily remembering the entered data.
3291 * src/maemo/modest-connection-specific-smtp-window.h:
3292 * src/maemo/modest-connection-specific-smtp-window.c:
3293 (modest_connection_specific_smtp_window_finalize),
3294 (modest_connection_specific_smtp_window_fill_with_connections),
3296 (modest_connection_specific_smtp_window_save_server_accounts),
3297 (update_model_server_names): Do not actually save data until asked,
3298 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3300 (on_selection_changed),
3301 (modest_connection_specific_smtp_window_init): Disable the edit
3302 button when nothing is selected.
3304 * src/modest-account-mgr-helpers.c:
3305 * src/modest-account-mgr-helpers.h:
3306 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3309 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3311 * src/modest-account-mgr-helpers.h:
3312 * src/modest-account-mgr-helpers.c:
3313 (modest_account_mgr_get_unused_account_name),
3314 (modest_account_mgr_get_unused_account_display_name): Added these
3315 utility functions, to avoid code duplication.
3317 * src/maemo/easysetup/modest-easysetup-wizard.c:
3318 (create_page_account_details), (create_account):
3319 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3320 (on_combo_security_changed),
3321 (modest_connection_specific_smtp_edit_window_init),
3322 (modest_connection_specific_smtp_edit_window_save_settings):
3323 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3324 * src/maemo/modest-connection-specific-smtp-window.c:
3325 (modest_connection_specific_smtp_window_finalize),
3326 (modest_connection_specific_smtp_window_fill_with_connections),
3327 (on_button_edit), (modest_connection_specific_smtp_window_init):
3328 * src/maemo/modest-connection-specific-smtp-window.h:
3329 Implementing saving of connection-specific server accounts.
3331 But I need to refactor this so we can save the data for each
3332 possible connection-specific account and only actually create the server accounts
3333 when the easysetup finished, or the OK button is pressed on the account settings
3336 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3338 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3339 (on_combo_security_changed):
3340 (modest_connection_specific_smtp_edit_window_init):
3341 Auto-fill the port number as in the account settings.
3343 (modest_connection_specific_smtp_edit_window_set_connection):
3344 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3345 * src/maemo/modest-connection-specific-smtp-window.c:
3346 (fill_with_connections), (on_button_edit),
3347 (modest_connection_specific_smtp_window_init):
3348 Turn the edit window into a dialog to simplify the code, and
3349 set a WM hint as in a GtkDialog, because only a popup can be on top of
3350 another window in Maemo, and popups usually have no WM decoration.
3352 * src/modest-defs.h:
3353 * src/modest-account-mgr-helpers.c:
3354 (modest_account_mgr_set_connection_specific_smtp),
3355 (modest_account_mgr_remove_connection_specific_smtp),
3356 (modest_account_mgr_get_connection_specific_smtp):
3357 * src/modest-account-mgr-helpers.h: Some functions to write the
3358 connection-specific SMTP server information. Not yet used.
3361 * src/widgets/modest-folder-view.c: (text_cell_data):
3362 Fix a warning about an uninitialized variable.
3363 (on_configuration_key_changed): Put an #ifdef around the use
3364 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3366 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/modest-account-settings-dialog.h:
3369 * src/maemo/modest-account-settings-dialog.c:
3370 Added connect_for_modified() utility function to mark the new modified boolean.
3372 (create_page_account_details), (create_page_user_details),
3373 (create_page_incoming), (create_page_outgoing), (on_response),
3374 (modest_account_settings_dialog_init),
3375 (modest_account_settings_dialog_set_account_name):
3376 Only warn about unsaved changes when there are actually unsaved changes.
3378 * src/modest-account-mgr-helpers.c:
3379 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3380 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3381 to get the data from there in future.
3383 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-defs.h:
3387 * src/modest-account-mgr-helpers.h:
3388 * src/modest-account-mgr-helpers.c:
3389 Store the security account setting in a single conf key instead of using
3390 the options list, so that the list is left for just the to-be-removed camel hack,
3391 and because gconf_client_set_list() is failing for some reason.
3393 * src/modest-account-mgr.c:
3394 (modest_account_mgr_add_server_account):
3395 * src/maemo/modest-account-settings-dialog.c:
3396 (modest_account_settings_dialog_set_account_name),
3397 (save_configuration): Use the renamed functions.
3400 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3402 * src/widgets/Makefile.am:
3403 * src/widgets/modest-limit-retrieve-combo-box.c:
3404 * src/widgets/modest-limit-retrieve-combo-box.h:
3405 * src/widgets/modest-retrieve-combo-box.c:
3406 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3407 the account settings dialog.
3409 * src/modest-defs.h:
3410 * src/modest-account-mgr-helpers.h:
3411 * src/modest-account-mgr-helpers.c:
3412 (modest_server_account_get_option_secure_auth),
3413 (modest_server_account_set_option_secure_auth):
3414 * src/modest-account-mgr.c:
3415 (modest_account_mgr_add_server_account):
3416 Use the existing AUTH_MECH conf key for the secure-auth setting,
3417 instead of putting it in the list options, because this was actually used already.
3419 * src/maemo/modest-account-settings-dialog.c:
3420 (create_page_account_details),
3421 (modest_account_settings_dialog_set_account_name),
3422 (save_configuration):
3423 * src/maemo/modest-account-settings-dialog.h:
3424 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3425 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3427 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3429 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3430 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3431 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3433 * src/modest-defs.h:
3434 * src/maemo/modest-account-settings-dialog.c:
3435 (create_page_incoming), (on_combo_outgoing_security_changed),
3436 (on_combo_incoming_security_changed), (create_page_outgoing),
3437 (modest_account_settings_dialog_set_account_name),
3438 (save_configuration): Load/Save the port number, and change it when the
3439 security combo changes, to suitable defaults.
3441 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3443 * src/modest-account-mgr.c:
3444 (modest_account_mgr_add_server_account): Set the security and secure-auth
3445 options, and add a comment saying that the other camel-specific options should be
3448 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3450 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3452 * src/modest-tny-account-store.c: (account_list_free),
3453 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3454 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3457 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3459 * src/modest-protocol-info.c:
3460 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3461 is required by our UI spec. Maybe something in our implementation will use this eventually.
3462 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3463 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3464 instead of the previous 0 placeholder.
3466 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3467 secure-auth settings.
3468 * src/modest-account-mgr-helpers.h:
3469 * src/modest-account-mgr-helpers.c:
3470 (modest_server_account_data_get_option_secure_auth),
3471 (modest_server_account_set_option_secure_auth),
3472 (modest_server_account_data_get_option_security),
3473 (modest_server_account_set_option_security): Added this API for getting and setting the security
3474 and secure-auth settings.
3476 * src/maemo/modest-account-settings-dialog.h:
3477 * src/maemo/modest-account-settings-dialog.c:
3478 (modest_account_settings_dialog_finalize), (check_data),
3479 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3480 about changing titles.
3481 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3482 (save_configuration): Save the security and secure-auth settings.
3484 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3485 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3487 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3489 * src/modest-defs.h:
3490 * src/modest-account-mgr.c:
3491 (modest_account_mgr_add_server_account):
3492 Added and used defines for the options key and value pair strings,
3493 that are used so far, though they do not seem to correspond to anything in our
3494 UI specs or ModestProtocol enum.
3496 * src/modest-account-mgr-helpers.h:
3497 * src/modest-account-mgr-helpers.c:
3498 (compare_option_strings_for_name),
3499 (modest_server_account_data_get_option_value),
3500 (modest_server_account_data_get_option_bool),
3501 (modest_account_mgr_get_server_account_option):
3502 Added helper functions for parsing the options GSList.
3504 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3506 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3507 display name is based on the supplied account name.
3508 * src/modest-account-mgr.c:
3509 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3510 with an inefficient, but good-enough, implementation.
3512 * src/maemo/easysetup/modest-easysetup-wizard.c:
3513 (create_page_account_details), (on_before_next), (create_account):
3514 Check for existing display names rather than (non-user-visible) account names, and just
3515 create and set a unique account name at the end.
3517 * src/maemo/modest-account-settings-dialog.c:
3518 (modest_account_settings_dialog_init),
3519 (modest_account_settings_dialog_set_account_name),
3520 (create_page_incoming): Show the display name, instead of the account name.
3521 (on_response): Do some (not all) extra checks, as in the UI spec.
3522 (save_configuration): Save the display name if it was changed.
3524 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3526 * po/en_GB.po: Added needed logical ID and translation.
3527 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3528 (init_view): Made the is-default column clicking work.
3530 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3533 * src/maemo/easysetup/Makefile.am:
3534 * src/maemo/easysetup/modest-easysetup-wizard.c:
3535 (modest_easysetup_wizard_dialog_init):
3536 * src/maemo/easysetup/provider-data-test.keyfile:
3537 * src/maemo/easysetup/provider-data.keyfile:
3538 Moved the provider data file to the new modest-providers-data package and used it from there.
3540 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3542 * src/modest-local-folder-info.c:
3543 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3544 N_() was already used on the static strings, but this just marks it for translation without
3545 using the translation.
3547 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3549 * src/maemo/modest-account-settings-dialog.c:
3550 (create_page_incoming),
3551 (modest_account_settings_dialog_set_account_name):
3552 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3553 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3554 I will do this if nobody else gets there first.
3556 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3558 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3559 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3560 save the security stuff.
3562 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3564 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3565 Set the email address and user fullname, which I now see must be
3568 * src/maemo/modest-account-settings-dialog.h:
3569 * src/maemo/modest-account-settings-dialog.c:
3571 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3572 leave-on-server and authentication.
3573 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3576 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3579 * src/maemo/modest-account-settings-dialog.c:
3580 * src/maemo/modest-account-settings-dialog.h:
3581 Most (but not all) of the widgets are now present as specified by the UI spec.
3582 No changes are yet saved, and some details are not properly shown yet.
3584 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3586 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3588 * src/maemo/Makefile.am:
3589 * src/maemo/modest-account-settings-dialog.c:
3590 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3591 an existing account. Doesn't do much yet.
3593 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3594 Open the accounts settings dialog when Edit is clicked.
3596 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3598 * src/maemo/easysetup/Makefile.am:
3599 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3601 * src/maemo/easysetup/modest-easysetup-wizard.c:
3602 (modest_easysetup_wizard_dialog_init):
3603 Try to get the source directory from the build system,
3604 instead of hard-coding "./" into the source code, when opening our local
3605 copies of the configuration files.
3606 But this still fails when opening the wizard from the Accounts window,
3607 maybe because the working directory seems to change at runtime.
3608 So the wizard will fail the second time unless you copy the files into their
3609 proper locations - see the stdout warnings for the paths.
3611 (create_page_account_details),(on_before_next):
3612 Check for existing non-server accounts instead of server accounts,
3613 so the default account name is useful again, and to prevent trying to
3616 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3617 Show the wizard when New is clicked.
3619 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3620 (init_view): Show the column headers, and show the columns that are
3621 specified in the UI specs. However, something in Maemo's GTK+ prevents
3622 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3623 change the default account. This is despite unsetting the special properties.
3625 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3627 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3628 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3629 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3630 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3631 to make that clearer.
3632 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3634 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3636 * src/maemo/modest-account-view-window.c:
3637 (modest_account_view_window_init),
3638 (modest_account_view_window_new):
3639 Use the same buttons as specified in the
3640 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3641 the existing widgets, which never had a chance of working.
3642 Put the ModestAccountView treeview in a scrolled window.
3643 Do not repeat the initialization in both _init() and _new().
3645 * src/widgets/modest-account-view.c: (update_account_view):
3646 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3647 this widget and window shows no accounts.
3649 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3651 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3653 * src/maemo/easysetup/modest-easysetup-wizard.c:
3654 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3655 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3656 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3659 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3660 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3661 accounts exist yet, as in the UI spec.
3663 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3665 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3667 * src/maemo/Makefile.am:
3668 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3669 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3670 New window for editing connection-specific smtp details.
3671 Not fully implemented.
3673 * src/maemo/modest-connection-specific-smtp-window.c:
3674 (modest_connection_specific_smtp_window_finalize) :
3675 unref the tree model.
3676 (on_button_edit): Show the edit window.
3678 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3680 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3683 * src/maemo/Makefile.am:
3684 * src/maemo/modest-connection-specific-smtp-window.c:
3685 * src/maemo/modest-connection-specific-smtp-window.h:
3686 New window for showing the list of connections, for connection-specific
3687 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3688 * src/maemo/easysetup/modest-easysetup-wizard.c:
3689 (create_page_custom_outgoing): Show the new window when the button is clicked.
3691 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3693 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3694 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3695 * src/maemo/modest-msg-edit-window.c:
3696 (modest_msg_edit_window_insert_image):
3697 * src/modest-conf.c: (modest_conf_key_escape):
3698 * src/modest-mail-operation.c:
3699 (modest_mail_operation_send_new_mail):
3700 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3701 (modest_ui_actions_on_new_account):
3702 * src/widgets/modest-attachment-view.c: (update_filename_request):
3703 * src/widgets/modest-mail-header-view.c:
3704 Corrected warnings that were breaking the build, by commenting out unused variables,
3705 and a function, and by including a header.
3707 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3709 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3710 so we can #ifdef around platform-specific code when necessary.
3711 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3712 to allow this to build for the GNOME platform too.
3714 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3716 * src/maemo/easysetup/modest-easysetup-wizard.c:
3717 Added util_increment_name() and used it in create_page_account_details()
3718 to make sure that the default account name is always a new name.
3720 (modest_easysetup_wizard_dialog_init),
3721 (set_default_custom_servernames): Some minor memory management fixes.
3723 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3727 * src/modest-runtime.c: (init_i18n): Restored the translation
3728 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3729 are defined in config.h, and the translations are installed.
3731 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3732 is defined for translation.
3734 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3736 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3738 * src/maemo/easysetup/modest-easysetup-wizard.c:
3739 (modest_easysetup_wizard_dialog_init):
3740 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3741 Use realistic paths (though they should use $prefix generically) to the
3742 mcc_mapping and provider-data.keyfile files which might work when they
3743 are installed by the future version of the operator-wizard package,
3744 and then fallback to paths in our source code, with an explanatory
3747 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3751 * src/maemo/Makefile.am:
3752 * src/maemo/easysetup/: Added files from the previously-exernal
3753 osso-modest-easysetup.
3754 * src/maemo/modest-main-window-ui.h:
3755 * src/modest-ui-actions.c:
3756 * src/modest-ui-actions.h:
3757 Added modest_ui_actions_on_new_account() as a signal handler for the
3758 New Account menu item. It shows the easysetup wizard.
3759 * po/en_GB.po: Added additional needed logical IDs and translations.