1 2007-07-09 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-utils.h:
4 * src/maemo/modest-maemo-utils.c:
5 Added modest_maemo_show_information_note_and_forget() for use instead of
6 gtk_dialog_run() when the response is not needed, to avoid an extra
7 mainloop which could cause a hang.
9 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
10 Use the logical IDs for the error message, though they are not
11 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
12 because gtk_dialog_run() caused a hang here (the window did not close).
14 2007-07-09 Murray Cumming <murrayc@murrayc.com>
16 * src/modest-account-mgr-helpers.h:
17 * src/modest-account-mgr-helpers.c:
18 Added modest_account_mgr_get_store_protocol().
20 * src/maemo/modest-account-view-window.c:
21 (on_delete_button_clicked): Show different warning text depending on
22 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
23 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
26 2007-07-09 Murray Cumming <murrayc@murrayc.com>
28 * src/maemo/modest-msg-edit-window.c:
29 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
30 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
32 2007-07-07 Armin Burgmeier <armin@openismus.com>
34 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
35 ckdg_ib_maximum_characters_reached from correct package.
37 * src/modest-ui-actions.c: Show an error message when a folder could
38 not be created. Tinymail does not give us specific error codes about
39 what has gone wrong, so we assume that a folder with that name
40 already exists, though there might be other reasons.
42 2007-07-06 Murray Cumming <murrayc@murrayc.com>
44 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
45 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
46 give a more exact error message that can be partly translated.
48 2007-07-05 Murray Cumming <murrayc@murrayc.com>
50 * src/maemo/modest-address-book.c:
51 (select_email_addrs_for_contact): Specify a default window size for the
52 select-email-address dialog, so that it is probably big enough for the
53 title. This should fix projects.maemo.org bug NB#62277.
55 2007-07-05 Murray Cumming <murrayc@murrayc.com>
57 * src/maemo/easysetup/modest-easysetup-wizard.c:
58 (create_page_complete_easysetup): Use
59 gtk_widget_set_size() request to ensure that the text wraps
62 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
64 * src/maemo/easysetup/modest-easysetup-wizard.c:
65 (on_entry_invalid_character), (create_page_account_details),
66 (create_page_user_details):
67 Use new API of ModestValidatingEntry. But for some reason the banner is
68 not shown. I will have to investigate that further.
70 * src/widgets/modest-validating-entry.c: (on_insert_text),
71 (modest_validating_entry_set_func):
72 * src/widgets/modest-validating-entry.h:
73 Added a new callback function to be able to react to prevented
74 characters whitespaces to e.g show a banner.
76 2007-07-05 Armin Burgmeier <armin@openismus.com>
78 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
79 notification of HildonNumberEditor instead of remembering the port
80 number. Thanks to Johannes for pointing this out.
82 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
84 * src/maemo/easysetup/modest-easysetup-wizard.c:
85 Check if there are any user changes before showing a confirmation
86 dialog (projects.maemo.org NB#60946)
88 2007-07-05 Armin Burgmeier <armin@openismus.com>
90 * src/maemo/modest-account-settings-dialog.c: Remember custom port
91 number at the beginning of the dialog and set the modified flag at the
92 end if the port number has changed. This is necessary because
93 HildonNumberEditor does not support notification when the value has
96 2007-07-05 Murray Cumming <murrayc@murrayc.com>
98 * src/modest-ui-actions.c:
99 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
100 a connection before asking anything else. Correct the check for the destination
101 folder so that it succeeds when online.
102 This fixed projects.maemo.org bug NB#61645.
104 2007-07-05 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
107 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
108 to fix projects.maemo.org bug NB#62439.
110 2007-07-05 Murray Cumming <murrayc@murrayc.com>
112 * src/modest-tny-account.c: (on_connection_status_changed):
113 Really do not use tny_device_force_offline() here. See the previous comment.
115 2007-07-04 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-tny-account.c: (on_connection_status_changed):
118 Do not use tny_device_force_offline() when tinymail says that something
119 went wrong with the connection. It seems to report this unnecessarily.
121 2007-07-04 Murray Cumming <murrayc@murrayc.com>
123 * src/maemo/modest-connection-specific-smtp-window.c:
124 (modest_connection_specific_smtp_window_init):
125 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
126 does not seem to have any effect in osso 1.1 (though it works in
127 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
129 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
131 * src/maemo/modest-connection-specific-smtp-window.c:
132 Fix UI specification problems with projects.meamo.org NB#60479
134 2007-07-04 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
137 clue when this has failed, because the error dialog is not always shown
138 (at least in earlier version).
140 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
141 GError message, because the generic error dialog is not helpful.
143 'This message is not currently available (can't let a new connection go online)'
144 when trying to open an IMAP message.
146 (_modest_ui_actions_open): Offer a connection when some messages would
147 have to be downloaded and we are offline.
149 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
151 * src/widgets/modest-folder-view.c:
152 Don't check for MERGE type anymore as we use the correct type
154 NOTE: For the last two changes you need to update your tinymail copy
155 because of API changes!
157 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
159 * src/modest-tny-local-folders-account.c:
160 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
161 (see projects.maemo.org NB#61580)
163 2007-07-04 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-tny-account.c: (on_connection_status_changed):
166 Commented out the call to modest_platform_connect_and_wait() because this
167 seems to always hang, and I would like to know if this is the only thing
168 that causes a hang when showing the connection dialog.
169 It is not very useful anyway.
171 2007-07-04 Murray Cumming <murrayc@murrayc.com>
173 * src/maemo/modest-msg-view-window.c:
174 (modest_msg_view_window_select_next_message):
176 * src/modest-platform.h:
177 * src/maemo/modest-platform.c:
178 Added modest_platform_connect_and_wait(), which calls
179 tny_maemo_conic_device_connect() always in the main thread, by calling it
180 in an idle handler and waiting for the idle handler to run. It should be
181 in the main thread because it uses GTK+ UI code. It just returns TRUE
182 if the device is already online.
184 There is some nasty code to ensure that subsequent calls to
185 modest_platform_connect_and_wait() just wait for the first one to finish,
186 by checking repeatedly in another idle handler. This is necessary,
187 because other threads (or even the main thread, via another idle handler)
188 can call modest_platform_connect_and_wait() while
189 modest_platform_connect_and_wait() is running.
191 (modest_platform_connect_and_wait_if_network_account),
192 (modest_platform_connect_and_wait_if_network_folderstore):
193 Convenience functions that calls modest_platform_connect_and_wait() if
194 the account or folder might want network access.
196 * src/modest-mail-operation.c:
197 (modest_mail_operation_update_account):
198 * src/modest-ui-actions.c: (download_uncached_messages),
199 (modest_ui_actions_on_rename_folder), (delete_folder),
200 (modest_ui_actions_on_main_window_move_to),
201 (modest_ui_actions_on_msg_view_window_move_to):
202 * src/widgets/modest-folder-view.c:
203 (drag_and_drop_from_folder_view):
204 Offer a connection if we are offline.
206 * src/modest-tny-account.c: (on_connection_status_changed):
207 Document this as only handling errors during network operations in progress,
208 and replace the idle code with a simple call to
209 modest_platform_connect_and_wait(), which does this instead.
211 2007-07-03 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-tny-account.c:
214 (modest_tny_account_get_special_folder): (util_on_idle),
215 Handle the GError so we can see when tny_folder_store_get_folders()
216 fails, as it currently does while something else is connecting.
218 Added util_run_in_main_thread_and_wait()
219 which uses an idlen handler and mainloop to ensure that the function
220 is called in the main thread.
221 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
222 to make sure that we call attempt the connection in the mainloop only,
223 which might solve some hangs.
225 2007-07-03 Murray Cumming <murrayc@murrayc.com>
227 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
228 be found by their display name. This is never useful.
229 * src/modest-tny-account-store.c: (on_account_removed): Find the account
230 by its ID, instead of trying to use its ID as its display name.
232 * src/modest-tny-account-store.h:
233 * src/modest-tny-account.c:
234 (modest_tny_account_get_special_folder): Add a g_warning() when
235 tny_folder_store_get_folders() returns an empty list for the maildir.
237 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
238 Add a g_warning() when this returns NULL, because that it not allowed
241 2007-07-02 Armin Burgmeier <armin@openismus.com>
243 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
244 note when trying to cancel the wizard. This fixes projects.maemo.org
247 2007-07-02 Murray Cumming <murrayc@murrayc.com>
249 * src/modest-tny-account.h:
250 * src/modest-tny-account.c:
251 (modest_tny_account_new_from_server_account),
252 (modest_tny_account_new_from_server_account_name),
253 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
254 because this must now be set before setting the proto. This is usd in
255 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
256 warning in camel_session_get_service() caused by
257 tny_camel_transport_account_prepare().
259 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
262 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
264 * src/maemo/modest-connection-specific-smtp-edit-window.c:
266 (modest_connection_specific_smtp_edit_window_init):
268 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
271 2007-06-29 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-tny-account.c:
274 (modest_tny_account_new_from_server_account):
275 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
276 now uses to request a connection when it needs one, and which it uses
277 to tell us that something is wrong with the connection, so we can force
278 the accounts offline to prevent further problems.
281 * src/modest-init.c: (init_default_settings):
282 * src/modest-mail-operation.c:
283 (modest_mail_operation_update_account):
284 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
285 This should not be necessary anymore. Do not set the conf key that
286 determined this (it was always TRUE and not set anywhere else).
288 * src/modest-ui-actions.h: Remove unused and unimplemented
289 modest_ui_actions_on_online_toggle_toggled().
291 2007-06-29 Murray Cumming <murrayc@murrayc.com
293 * src/maemo/modest-main-window.c: (connect_signals):
294 Don't connect to delete_event twice. Maybe this was harmless.
296 2007-06-29 Murray Cumming <murrayc@murrayc.com
298 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
299 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
300 Debug output to give some more clue when a folder move is not allowed.
302 2007-06-28 Murray Cumming <murrayc@murrayc.com
304 * src/modest-tny-account.c: (on_modest_file_system_info),
305 (modest_tny_account_get_mmc_account_name):
306 Always call the callback, without checking whether the name has changed.
307 * src/widgets/modest-folder-view.c: (strings_are_equal),
308 (on_model_foreach_set_name), (on_get_mmc_account_name),
309 (text_cell_data): Compare the name here, and use the name from
310 the account rather than from the
311 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
312 if the name was changed after the account was added to the model.
313 That's a tinymail bug but not one that I want to fix now.
315 This finally fixes projects.maemo.org bug NB#59301.
317 2007-06-27 Armin Burgmeier <armin@openismus.com>
319 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
322 2007-06-27 Murray Cumming <murrayc@murrayc.com
324 * src/modest-tny-account.h:
325 * src/modest-tny-account.c:
326 Added modest_tny_account_get_mmc_account_name(), to set the memory
327 card name asynchronously for the given account and then notify.
328 (modest_tny_account_new_for_local_folders): Use this new function instead
329 of using hildon_file_system_info_async_new() directly.
331 * src/widgets/modest-folder-view.c: (text_cell_data):
332 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
333 gtk_tree_model_row_changed() when it is available.
335 This should fix projects.maemo.org bug NB#59301.
337 2007-06-27 Murray Cumming <murrayc@murrayc.com
339 * src/modest-mail-operation.c: (update_account_thread),
340 (get_msgs_full_thread): Fix typo failures in the revert
343 2007-06-27 Murray Cumming <murrayc@murrayc.com
345 * src/maemo/modest-maemo-global-settings-dialog.c:
346 (idle_select_default_focus):
347 * src/modest-mail-operation.c: (idle_notify_progress),
348 (idle_notify_progress_once), (set_last_updated_idle),
349 (update_account_thread), (get_msgs_full_thread):
350 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
351 * src/widgets/modest-header-view.c:
352 (idle_notify_headers_count_changed_destroy),
353 (idle_notify_headers_count_changed):
354 Reverted the additions of gdk_threads_enter/leave(), in case this
355 helps with a startup hang on the device.
357 2007-06-26 Armin Burgmeier <armin@openismus.com>
359 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
360 for supported secure authentication methods from server by
361 gtk_dialog_run(), saving CPU time and a potential race condition.
363 2007-06-26 Armin Burgmeier <armin@openismus.com>
365 * src/maemo/modest-maemo-utils.h:
366 * src/maemo/modest-maemo-utils.c: Added a
367 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
368 only error code to tell the calling code when the user canceled the
371 * src/maemo/modest-account-settings-dialog.h:
372 * src/maemo/modest-account-settings-dialog.c:
373 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
374 message if the retrieval of secure authentication methods was canceled
375 by the user. Perform the check before saving anything to configuration
376 to not end up with half-committed configuration changes, do not show
377 a "Saving to configuration failed" note when authentication methods
378 could not be retrieved.
380 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
383 2007-06-26 Murray Cumming <murrayc@murrayc.com>
385 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
386 Only return the first level of folders under accounts, because the
387 osso-global-search UI spec doesn't want the rest.
388 This fixed projects.maemo.org bug NB#61811.
390 2007-06-26 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-tny-account-store.c:
393 * src/modest-tny-account-store.h:
394 Added modest_tny_account_is_memory_card_account().
395 * src/maemo/modest-main-window.c: (create_details_widget):
396 Show the same information items for the memory card as we show for the
397 local-folders, to fix projects.maemo.org bug NB#59307.
399 2007-06-26 Murray Cumming <murrayc@murrayc.com>
401 * src/modest-tny-account-store.c: (get_password):
402 Added some checks for NULL to maybe prevent crashes, though I think
403 it was Philip's last commit that actually prevented the crash here
404 when creating a first new account.
405 But the new account is still not usable (no messages are shown)
406 until a restart of the application.
408 2007-06-26 Murray Cumming <murrayc@murrayc.com>
410 * src/maemo/modest-maemo-global-settings-dialog.c:
411 (idle_select_default_focus):
412 * src/modest-mail-operation.c: (idle_notify_progress),
413 (idle_notify_progress_once), (idle_notify_update_account_queue),
414 (set_last_updated_idle), (update_account_thread),
415 (notify_get_msgs_full), (get_msgs_full_destroyer),
416 (get_msgs_full_thread):
417 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
418 * src/widgets/modest-header-view.c:
419 (idle_notify_headers_count_changed_destroy),
420 (idle_notify_headers_count_changed):
421 Use gdk_threads_enter() and gdk_threads_enter_leave() in
422 all idle handlers, because some other thread could be blocking
423 the GDK lock, so that it can do GUI stuff.
425 2007-06-26 Murray Cumming <murrayc@murrayc.com>
427 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
428 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
429 (on_idle_send_receive), (on_idle_open_default_inbox):
430 * src/maemo/modest-msg-edit-window.c:
431 (modest_msg_edit_window_attach_file_noninteractive):
432 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
433 to prevent a hang. I don't quite understand why these are necessary,
434 beause we should already be in the main loop. I guess something outside
435 of the main loop is taking the lock.
437 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
438 we are really using URIs, and use files that are more likely to exist.
440 2007-06-26 Murray Cumming <murrayc@murrayc.com>
442 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
443 necessary because configure.ac now defines different variables.
445 2007-06-26 Murray Cumming <murrayc@murrayc.com>
447 * libmodest-dbus-client/libmodest-dbus-client.c:
448 * libmodest-dbus-client/libmodest-dbus-client.h:
449 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
450 libmodest_dbus_client_compose_mail() is what things actually use.
452 * src/dbus_api/modest-dbus-api.h:
453 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
454 * tests/dbus_api/Makefile.am:
455 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
458 2007-06-26 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-init.c: (modest_init_local_folders):
461 For memory-card (or other non local-folders) maildir accounts,
462 always create an Archive folder, so that there is somewhere to put
463 messages. This should be less confusing, because the user does not need
464 to guess that the need to create a folder.
466 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
468 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
469 Fixed icon size by using (50, 50) which is the same as defined by
472 2007-06-25 Armin Burgmeier <armin@openismus.com>
474 * src/widgets/modest-window-mgr.c:
476 * configure.ac: Correctly recognize hildon-notify presence and fixed
477 the build without it being installed.
479 2007-06-25 Murray Cumming <murrayc@murrayc.com>
481 * libmodest-dbus-client/libmodest-dbus-client.c:
482 (libmodest_dbus_client_search): Fix the build. Sorry.
483 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
484 (reply_forward_cb): Initialize variables to fix the build.
486 * src/modest-tny-account-store.c:
487 (modest_tny_account_store_get_tny_account_by): Fix the account URI
488 comparison (a silly typo) so that email search results can be opened
489 when there are more than one account.
491 2007-06-25 Murray Cumming <murrayc@murrayc.com>
493 * libmodest-dbus-client/libmodest-dbus-client.c:
494 (libmodest_dbus_client_search),
495 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
496 instead of 1 second, because the search gets folders and messages from
497 the server, which can take a long time. When it times out,
498 osso-global-search will report no results.
500 We need to specify whether we should search only cached information
501 (maybe with a user preference), and the osso-email-search-plugin
502 API should really be improved to allow that option, and to allow results
503 to be delivered asynchronously in batches.
505 2007-06-25 Murray Cumming <murrayc@murrayc.com>
507 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
508 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
509 GTK_ICON_SIZE_DIALOG is probably the wrong size.
511 2007-06-25 Murray Cumming <murrayc@murrayc.com>
513 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
514 that is an empty string. D-Bus seems to give us these instead of NULL.
516 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
518 * src/dbus_api/modest-dbus-callbacks.c:
519 * src/maemo/easysetup/modest-easysetup-wizard.h:
520 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
521 * src/maemo/modest-connection-specific-smtp-edit-window.c:
522 (modest_connection_specific_smtp_edit_window_init):
523 * src/maemo/modest-maemo-global-settings-dialog.c:
525 * src/maemo/modest-maemo-utils.c:
526 (modest_maemo_utils_setup_images_filechooser):
527 * src/maemo/modest-main-window.c: (create_details_widget):
528 * src/maemo/modest-msg-edit-window.c:
529 (modest_msg_edit_window_attach_file_noninteractive),
530 (modest_msg_edit_window_color_button_change),
531 (modest_msg_edit_window_set_zoom):
532 * src/modest-mail-operation.c: (update_account_thread):
533 * src/modest-tny-account-store.c:
534 * src/modest-tny-account.c:
535 * src/widgets/modest-global-settings-dialog.c:
536 * src/widgets/modest-window.h:
540 2007-06-25 Murray Cumming <murrayc@murrayc.com>
542 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
543 * src/modest-search.c: (modest_search_folder),
544 (modest_search_all_accounts): Actually search only in the specified folder,
545 doing a simple match on the folder ID.
546 * src/modest-search.h: Added a folder field to the ModestSearch struct,
547 and added some documentation.
549 2007-06-22 Armin Burgmeier <armin@openismus.com>
551 * src/maemo/modest-maemo-utils.h:
552 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
553 modest_maemo_utils_get_supported_secure_authentication_methods.
555 * src/maemo/easysetup/modest-easysetup-wizard.c:
556 * src/maemo/modest-account-settings-dialog.c: Show correct error if
557 one occured, not just "Server does not support secure authentication".
559 2007-06-22 Murray Cumming <murrayc@murrayc.com>
561 * src/modest-tny-account-store.c: (get_password):
562 Restored the call to tny_account_set_user() because Philip seems to have
563 stopped this from crashing (by not using the freed string). It still does
564 not work, but now we can test it.
566 2007-06-22 Murray Cumming <murrayc@murrayc.com>
568 * src/maemo/modest-msg-edit-window.c: (init_window):
569 Comment out use of an uninitialzed GtkScrolledWindow variable,
570 to fix the build and stop a crash. Yet again.
572 2007-06-22 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-tny-account-store.c: (get_password):
575 Remove the call to tny_account_set_user() because this actually crashes.
576 As mentioned in the last commit, it is known to not work anyway.
578 2007-06-22 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-tny-account-store.c: (get_password):
581 Use tny_account_set_username() to tell tinymail that the username might
582 have changed too. But tinymail ignores this: see projects.maemo.org
584 * src/modest-ui-actions.c:
585 (modest_ui_actions_on_password_requested): Remove the useless attempt to
586 reset the connection when changing the username, and improve the comments.
587 Save the changed username to gconf at least, so it is used when Modest is
590 2007-06-21 Murray Cumming <murrayc@murrayc.com>
592 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
593 Do not use a query, so that we get all folders, including for POP and
594 local-folders. They work as search criteria too.
595 This fixes projects.maemo.org bug NB#57740.
597 2007-06-21 Murray Cumming <murrayc@murrayc.com>
599 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
600 Comment out the use of hildon_notification_set_sound() because it is
601 not declared, to fix the build. Warnings are serious, people.
603 2007-06-21 Armin Burgmeier <armin@openismus.com>
605 * src/maemo/modest-maemo-utils.h:
606 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
607 modest_maemo_utils_get_supported_secure_authentication_methods()
608 to query authentication methods for a specific user. This should fix
609 projects.maemo.org bug NB#61369.
611 * src/maemo/easysetup/modest-easysetup-wizard.c:
612 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
615 2007-06-21 Murray Cumming <murrayc@murrayc.com>
617 * libmodest-dbus-client/libmodest-dbus-client.h:
618 * libmodest-dbus-client/libmodest-dbus-client.c:
619 (modest_dbus_message_iter_get_search_hit),
620 (libmodest_dbus_client_search):
621 Reorganised and commented this.
622 Removed modest_search_hit_free() from the public API because it
625 Added libmodest_dbus_client_get_folders() and
626 modest_folder_result_list_free().
628 * src/dbus_api/modest-dbus-api.h:
629 * src/dbus_api/modest-dbus-callbacks.c:
630 (modest_dbus_req_filter): Commented. Moved most code to
631 on_dbus_method_search() and added on_dbus_method_get_folders().
633 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
634 of the extra D-Bus handler.
636 * tests/dbus_api/Makefile.am:
637 * tests/dbus_api/test_get_folders.c: New test for
638 libmodest_dbus_client_get_folders(). This seems to return an empty list
639 at the moment. That could be the same error that causes the message list
640 to be empty sometimes.
641 This should help with projects.maemo.org bug NB#57740.
643 2007-06-21 Armin Burgmeier <armin@openismus.com>
645 * src/modest-mail-operation.c: Do not call
646 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
647 notify the operation's end after having set the status to CANCELED for
648 the operation queue to listen on. This fixes a deadlock when there
649 were mail operations in the queue during its finalization.
651 * src/modest-singletons.c: Reordered uninitialization of the account
652 manager to happen after the mail operation queue was uninitialized
653 because the mail operation's in the queue might still try to access
654 the account manager (see modest_mail_operation_notify_end()). This
655 fixes a potential crash when terminating the application.
657 2007-06-21 Murray Cumming <murrayc@murrayc.com>
659 * src/modest-search.c:
660 (search_mime_part_and_child_parts): Moved some code here so we
661 can search recursively in child folders.
662 (modest_search_folder): Search in the message as a mime part, instead
663 of just its child mime parts.
664 (read_chunk), (search_mime_part_ogs):
665 Check how many bytes were read, to prevent an endless loop.
666 Searching in message bodies now works. This finishes the fix for
667 projects.maemo.org bug NB#61007.
669 2007-06-20 Murray Cumming <murrayc@murrayc.com>
671 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
672 Add a g_warning when the item is not a folder.
674 * src/modest-ui-dimming-rules.c:
675 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
676 when selected item is not a folder (for instance, an account), because
677 the UI spec only talks about folders.
678 I am not sure what the UI spec wants, so this might not totally fix
679 projects.maemo.org bug NB#60794.
681 2007-06-20 Murray Cumming <murrayc@murrayc.com>
683 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
684 (load_from_file): Sort the list. The unsorted list would be more noticeable
685 in non-English locales.
687 * src/maemo/modest-msg-edit-window.c:
688 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
689 warning and fix the build.
691 * src/maemo/modest-progress-bar-widget.c:
692 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
693 avoid a g_warning, and probably to avoid a crash.
695 2007-06-20 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-search.c: (modest_search_folder): Check for a GError
698 when calling tny_folder_get_headers(), to show that this is not the cause
701 2007-06-20 Murray Cumming <murrayc@murrayc.com>
703 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
704 Actually set the body query instead of the subject query.
706 * src/modest-search.c: (search_mime_part_ogs),
707 (search_mime_part_strcmp): Remove extra space from the text/* regex,
708 which would probably cause it to fail if we got this far.
710 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
711 to simplify the code.
712 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
713 be causing search-in-body to fail.
715 2007-06-20 Murray Cumming <murrayc@murrayc.com>
717 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
719 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
720 Better debug message when the folder cannot be found.
721 This should help with fixing projects.maemo.org bug #61287.
722 * src/modest-search.c: (add_hit): Do not leak the furl string.
724 2007-06-20 Murray Cumming <murrayc@murrayc.com>
726 * src/modest-ui-actions.c:
727 (modest_ui_actions_on_folder_selection_changed):
728 Do not special-case TNY_MERGE_FOLDER here, because
729 modest_tny_folder_get_account() already does that. This fixes
730 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
731 shown when the Outbox was selected).
733 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
735 * libmodest-dbus-client/libmodest-dbus-client.c:
736 (_dbus_iter_get_string_or_null): Initialize the string variable in
737 case this helps with Dirk's crash.
739 2007-06-19 Murray Cumming <murrayc@murrayc.com>
741 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
742 though it is not implemented yet (this function is maybe not even used),
743 to avoid breaking ABI in future.
744 * libmodest-dbus-client/libmodest-dbus-client.c:
745 (get_attachments_string): Moved some code into this generic function.
746 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
747 sends email. It is maybe not used.
748 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
749 (on_send_mail): Use attachments.
751 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
752 * src/maemo/modest-msg-edit-window.c:
753 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
754 a filename before using it, to fix projects.maemo.org bug NB#58233.
756 2007-06-19 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
759 Initialize the continue_download variable to fix the build, and probably
760 to fix randome behaviour.
762 2007-06-18 Armin Burgmeier <armin@openismus.com>
764 * src/modest-tny-send-queue.h:
765 * src/modest-tny-send-queue.c: Keep track of the status of messages in
766 the queue so we can later show it in the UI. Replaced
767 modest_tny_send_queue_msg_is_being_sent() by
768 modest_tny_send_queue_get_msg_status().
770 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
772 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
773 gpointer. This probably was not harmful, but just to be sure.
775 2007-06-18 Murray Cumming <murrayc@murrayc.com>
777 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
778 Fix the build, but leave the function broken on Bora, because
779 hildon_uri_action_get_service() does not exist.
780 osso_uri_action_get_service() does not exist either, it seems.
782 2007-06-18 Murray Cumming <murrayc@murrayc.com>
784 * src/modest-tny-account.c:
785 (modest_tny_account_new_from_server_account):
786 Uncommented the url debug output again, because it is useful for
787 debugging, as I said in the comment.
789 2007-06-18 Murray Cumming <murrayc@murrayc.com>
791 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
793 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
794 for Mameo Bora, to fix the build.
796 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
799 Fixed build with hildon < 0.99
801 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
802 Check if the selected account is busy instead of checking all accounts
804 * src/modest-account-mgr-priv.h:
805 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
806 (modest_account_mgr_init), (compare_account_name),
807 (modest_account_mgr_set_account_busy),
808 (modest_account_mgr_account_is_busy):
809 * src/modest-account-mgr.h:
810 Added busy information to the account manager. It possible to
811 set an account to busy or not busy now.
813 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
814 (modest_mail_operation_update_account),
815 (modest_mail_operation_notify_end):
816 Set the account to busy/not busy depending on the operation state.
818 * src/widgets/modest-account-view.c:
819 (modest_account_view_finalize), (get_last_updated_string),
820 (update_account_view), (on_account_busy_changed), (init_view):
821 Show string "Refreshing..." if the account is currently busy.
823 All this fixes projects.maemo.org bug NB#59711
825 2007-06-14 Armin Burgmeier <armin@openismus.com>
827 * src/widgets/modest-attachments-view.h:
828 * src/widgets/modest-attachments-view.c: Added
829 modest_attachments_view_has_attachments() and fixed coordinate
830 transformation in get_att_view_at_coords(). This fixes attachment
833 * src/widgets/modest-msg-view.c: Make use of
834 modest_attachments_view_has_attachments() to decide whether to show
835 attachments in the header.
837 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
839 * src/maemo/modest-connection-specific-smtp-edit-window.c:
840 (on_change), (on_combo_security_changed),
841 (modest_connection_specific_smtp_edit_window_init),
842 (modest_connection_specific_smtp_edit_window_set_connection),
843 (modest_connection_specific_smtp_edit_window_is_dirty):
844 * src/maemo/modest-connection-specific-smtp-edit-window.h:
845 * src/maemo/modest-connection-specific-smtp-window.c:
848 Show an comfirmation dialog for the smpt-edit-window if there are
849 unsaved changes and the user hits cancel.
850 (projects.maemo.org bug NB#60479)
852 2007-06-14 Armin Burgmeier <armin@openismus.com>
854 * src/maemo/easysetup/modest-easysetup-wizard.c:
855 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
856 address" info in banner instead of node, and select all the text as
857 per UI spec. This fixes projects.maemo.org bug NB#60550.
859 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
861 reviewed by: <delete if not using a buddy>
863 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
864 * src/modest-ui-actions.c: (folder_refreshed_cb):
866 2007-06-14 Murray Cumming <murrayc@murrayc.com>
868 * src/widgets/modest-folder-view.c: (filter_row):
869 Explictly filter out the per-account outbox accounts. I don't know why
870 these only sometimes show up, but now they should never show up in the UI.
871 This should fix projects.maemo.org bug NB#60160.
873 2007-06-14 Murray Cumming <murrayc@murrayc.com>
875 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
876 when the toolbar does not exist yet.
877 * src/modest-widget-memory.c: (save_settings_header_view):
878 Added g_warnings() to help us to discover when we are trying to set
879 an empty columns list in gconf.
881 2007-06-14 Murray Cumming <murrayc@murrayc.com>
885 Added modest_init_get_default_header_view_column_ids().
887 * src/modest-widget-memory.c: (restore_settings_header_view):
888 Use the new function to get defaults, if the gconf key is empty,
889 instead of not creating any columns. This seems to fix the
890 empty right-hand pane problems.
892 * src/widgets/modest-header-view.h: Improved documentation.
894 2007-06-13 Murray Cumming <murrayc@murrayc.com>
896 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
897 Revert the use of the display name as the account name, because this
898 is generally wrong and would break the code that follows.
900 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
902 * src/maemo/easysetup/modest-easysetup-wizard.c:
903 (check_for_supported_auth_methods), (on_before_next),
906 More correct fix for projects.maemo.org bug NB# 58991
907 Do not longer accept AUTH_PASSWORD as secure method and choose
908 correct method when creating the account.
910 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
912 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
913 Fixed projects.maemo.org bug NB# 58991
915 2007-06-13 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-init.c: (modest_init_init_core),
918 (modest_init_local_folders): Fixed compilation errors.
920 2007-06-13 Murray Cumming <murrayc@murrayc.com>
922 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
923 Remove unnecessary lib/include, though it is good in principle when needed.
925 * src/modest-init.c: (modest_init_one_local_folder),
926 (modest_init_local_folders):
927 * src/modest-init.h: Initialize the .modest library for memory cards,
928 instead of just doing nothing for them. This should allow us to create
929 folders there, fixing projects.maemo.org bug NB#59297.
931 2007-06-13 Murray Cumming <murrayc@murrayc.com>
933 * libmodest-dbus-client/libmodest-dbus-client.c:
934 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
935 (libmodest_dbus_client_compose_mail),
936 (libmodest_dbus_client_open_message),
937 (libmodest_dbus_client_send_and_receive),
938 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
940 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
941 (on_idle_open_message), (modest_dbus_req_handler),
942 (search_result_to_message), (modest_dbus_req_filter):
943 * src/modest-search.c: (add_hit), (modest_search_folder),
944 (modest_search_all_accounts): Improved debug messages.
946 * tests/dbus_api/test_open_message.c: (main): Improved comments.
948 * src/modest-tny-account-store.c:
949 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
952 2007-06-13 Murray Cumming <murrayc@murrayc.com>
955 2007-06-12 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-tny-account-store.c: (get_server_accounts):
958 Call modest_tny_local_folders_account_add_merged_outbox_folders()
959 even when there are no accounts, so that the Outbox folder is always
960 visible. This fixes projects.maemo.org bug NB#60158.
962 2007-06-12 Murray Cumming <murrayc@murrayc.com>
964 * src/maemo/modest-main-window.c: (create_details_widget):
965 Use the mcen_va_never logical ID.
967 2007-06-12 Murray Cumming <murrayc@murrayc.com>
969 * src/dbus_api/modest-dbus-api.h:
970 * src/dbus_api/modest-dbus-callbacks.c:
971 (on_idle_open_default_inbox), (on_open_default_inbox),
972 (modest_dbus_req_handler):
973 Added a new OpenDefaultInbox method.
975 * libmodest-dbus-client/libmodest-dbus-client.h:
976 * libmodest-dbus-client/libmodest-dbus-client.c:
977 Added libmodest_dbus_client_open_default_inbox() to call the new
978 dbus method. This should be useful to projects.maemo.org bug NB#57214,
979 though it should maybe be used by a new osso-email-interface function.
981 * tests/dbus_api/Makefile.am:
982 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
985 2007-06-12 Murray Cumming <murrayc@murrayc.com>
987 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
988 NULL, so that the signals get all the keys. This should not actually
989 change any behaviour because we currently update everything when anything
992 2007-06-12 Murray Cumming <murrayc@murrayc.com>
994 * src/widgets/modest-folder-view.c: (text_cell_data),
995 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
996 (find_inbox_iter): If tinymail tells us that the folder is
997 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
998 This causes the inbox to be selected at startup, fixing part of
999 projects.maemo.org bug NB#56305.
1001 * src/modest-ui-dimming-rules.c:
1002 (modest_ui_dimming_rules_on_tools_smtp_servers):
1003 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1004 the SMTP servers menu item.
1005 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1006 that the SMTP Servers menu item is dimmed when there are no accounts,
1007 as a future version of the UI spec will require. This fixes
1008 projects.maemo.org bug NB#56305.
1010 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1012 * src/maemo/modest-maemo-utils.c:
1013 (modest_maemo_utils_get_supported_secure_authentication_methods):
1014 Added label to dialog instead of unreadable title
1016 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1017 (modest_main_window_new):
1018 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1021 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1022 * src/modest-account-mgr.h:
1023 Added method to avoid code duplication
1025 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1026 (modest_ui_actions_on_send_receive):
1027 Use modest_account_mgr_has_accounts
1029 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1031 * src/maemo/easysetup/modest-presets.c:
1032 (modest_presets_get_info_server_security): Do not report secure auth
1034 * src/modest-protocol-info.c: Use the defines for the gconf key names
1035 for secure authentication. This was not working because we were writing
1036 Password and reading password, and the check was case sensitive.
1037 With this, gmail now works for receiving and sending when created via
1040 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1042 * src/maemo/easysetup/modest-presets.c:
1043 (modest_presets_get_info_server_security): Correct the key name for
1044 SecureSmtp, because it seems to be case-sensitive.
1045 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1046 Do not try to get the 0th notebook page if there are 0 pages, to
1047 avoid a g_warning().
1049 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1051 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1052 Prevent use of the new notification feature for now, because it currently
1053 shows one dialog for each new email, which is annoying.
1055 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1057 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1058 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1059 when no country was selected, so that we show the global ones.
1060 * src/maemo/easysetup/modest-presets.c:
1061 (modest_presets_get_providers): Return only the global providers, not
1062 all providers when mmc=0 was requested.
1064 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1066 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1067 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1068 provider ID in the combo.
1070 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1071 Do not show the page numbers, because it would be confusing when we add
1072 the 2 extra pages for the custom setup, when the user chooses the "Other"
1073 provider. This fixes projects.maemo.org bug NB#59028
1075 * src/modest-init.c: (modest_init_init_core),
1076 (modest_init_local_folders):
1077 * src/modest-init.h:
1078 * src/modest-tny-account.c:
1079 (modest_tny_account_new_for_local_folders): Do not create default folders
1080 for the memory card. This should fix projects.maemo.org bug NB#59328.
1082 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1085 Free the changed_conf_keys string items. They are already freed in the
1086 idle handler if that runs first.
1088 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-ui-actions.c:
1091 (modest_ui_actions_on_password_requested): Check that the server name
1092 is not NULL, because I just saw a password dialog with (null) as the
1095 * src/modest-tny-folder.[h|c]: Added
1096 modest_tny_folder_is_memory_card_folder().
1097 * src/modest-ui-dimming-rules.c:
1098 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1099 menu item for memory cards, as per the UI spec (section 7.4). This should
1100 fix projects.maemo.org bug NB#59297.
1102 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1104 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1105 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1106 is another problem with the code, see Murray's comment at line 772)
1108 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1110 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1111 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1112 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1113 (load_from_file), (easysetup_country_combo_box_init),
1114 (easysetup_country_combo_box_get_active_country_ids),
1115 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1116 instead of just one ID, to avoid duplicate country names in the UI.
1118 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1119 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1120 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1121 a single ID, avoiding duplicate providers.
1122 * src/maemo/easysetup/modest-easysetup-wizard.c:
1123 (on_combo_account_country): Adapt to use a list.
1125 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1127 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1128 keys changed in the last X seconds.
1130 * src/modest-account-mgr.h:
1131 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1132 (on_key_change), (modest_account_mgr_class_init),
1133 (modest_account_mgr_init), (modest_account_mgr_finalize):
1134 As the keys are changed, save them in a GSList* and signal that GSList*
1135 further every X seconds, to batch changes, to allow us to do just one
1136 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1137 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1139 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1140 changed signal signature.
1142 * src/modest-conf.c: (modest_conf_set_list),
1143 (modest_conf_on_change): Reenable notification.
1145 (modest_conf_maemo_fake_on_change): Comment out the hack that
1146 notified immediately instead of asynchronously.
1148 * src/widgets/modest-account-view.h:
1149 * src/widgets/modest-account-view.c:
1150 (update_account_view): Select the previously-selected account ID,
1151 if possible. This fixes projects.maemo.org bug NB#56933.
1153 (on_account_changed), (on_account_removed),
1154 (modest_account_view_select_account):
1156 Remove the block/unblock functions
1157 because they were not useful.
1159 * src/maemo/modest-account-view-window.c:
1160 (on_delete_button_clicked), (on_edit_button_clicked),
1161 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1163 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1165 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1166 Improve the error dialog to show Incorrect Account Settings, which seems
1167 clearer, and say that the internal error message (to be removed from the
1168 dialog later) is often misleading.
1169 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1171 * src/modest-tny-account.c:
1172 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1173 URL because this is so useful for debugging on the device.
1175 * src/widgets/modest-serversecurity-combo-box.c:
1176 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1178 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1180 * src/modest-mail-operation.c:
1181 (modest_mail_operation_send_new_mail):
1182 Added a comment about a nasty but apparently harmless message. Details
1183 added to the wiki g_warnings() page.
1185 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1187 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1188 (modest_tny_send_queue_class_init):
1189 Do not use the priv struct because it is empty, to avoid g_warnings
1190 about a non-existant priv struct.
1192 * src/modest-tny-account-store.c:
1193 (modest_tny_account_store_get_server_account),
1194 (modest_tny_account_store_get_transport_account_for_open_connection
1195 ): Do not try to get transport server accounts for local folders,
1196 because they don't have any. This avoids a g_warning().
1198 * src/maemo/modest-main-window.c:
1199 (modest_main_window_notify_send_receive_initied),
1200 (on_configuration_key_changed):
1201 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1202 * src/modest-defs.h:
1203 * src/modest-mail-operation.c:
1204 (modest_mail_operation_update_account):
1205 * src/modest-tny-account-store.h:
1206 * src/modest-tny-account.c:
1207 (modest_tny_account_get_special_folder),
1208 (modest_tny_account_new_for_local_folders),
1209 (modest_tny_account_new_for_per_account_local_outbox_folder):
1210 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1211 * src/modest-tny-local-folders-account.c:
1212 (add_account_folders_to_merged_folder):
1213 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1214 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1215 (modest_ui_actions_on_send):
1216 * src/widgets/modest-folder-view.c: (update_model):
1217 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1218 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1219 modest_tny_account_store_get_tny_account_by_account() to
1220 modest_tny_account_store_get_server_account() to make the code clearer.
1222 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1224 * src/dbus_api/modest-dbus-api.h:
1225 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1226 * src/maemo/modest-msg-edit-window.c:
1227 (modest_msg_edit_window_attach_file_noninteractive):
1228 added g_warning in case the file to be attached does not exist
1229 * tests/dbus_api/test_compose_mail.c: (main):
1230 removed obsolete comment, added generic files as test case
1232 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1234 * src/modest-tny-account-store.c: (get_server_accounts):
1235 Create the local folders account only once, not once for each outbox, and
1236 not only when there are some outboxes.
1238 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1240 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1241 code that is causing a crash at startup. Sergio says that he is fixing this.
1243 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1245 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1246 * src/maemo/modest-account-settings-dialog.c:
1247 (create_page_outgoing),
1248 (modest_account_settings_dialog_set_account_name),
1249 (save_configuration):
1250 - Fixed handling of the "Use secure authentication" toggle to comply with
1251 the ui specification. See also projects.maemo.org bug NB#58400
1253 - Restore the Secure connection setting combo correctly when loading
1256 * src/maemo/modest-maemo-utils.c:
1257 (on_camel_account_get_supported_secure_authentication),
1258 (modest_maemo_utils_get_supported_secure_authentication_methods):
1259 Fixed a crasher if operation is canceled
1261 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1262 (modest_protocol_info_auth_is_secure):
1263 * src/modest-protocol-info.h:
1265 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1266 the sense of the "Use secure authentication" toggle.
1268 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1270 * src/modest-tny-account-store.h:
1271 * src/modest-tny-account-store.c:
1272 Added modest_tny_account_store_get_local_folders_account().
1274 * src/modest-tny-folder.h:
1275 * src/modest-tny-folder.c:
1276 (modest_tny_folder_get_account):
1277 Added this replacement for tny_folder_get_account() which returns
1278 the local-folders account for TnyMergeFolders, to avoid the
1279 warning about the unimplemented get_account_func() vfunc().
1281 (modest_tny_folder_get_rules),
1282 * src/modest-ui-actions.c:
1283 (modest_ui_actions_on_folder_selection_changed):
1284 * src/modest-mail-operation.c:
1285 (modest_mail_operation_remove_folder),
1286 (modest_mail_operation_xfer_folder),
1287 (modest_mail_operation_rename_folder),
1288 (modest_mail_operation_get_msg),
1289 (modest_mail_operation_get_msgs_full),
1290 (modest_mail_operation_remove_msg),
1291 (modest_mail_operation_xfer_msgs),
1292 (modest_mail_operation_refresh_folder):
1293 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1295 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1297 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1298 (modest_server_account_set_security):
1299 * src/modest-defs.h: Add comments explaining that our
1300 UI spec means TLS when it says Normal, so these do not look like errors.
1302 * src/modest-tny-account.c:
1303 (modest_tny_account_new_from_server_account): Use the new tinymail
1304 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1305 for TLS. This should fix projects.maemo.org bug NB#58460.
1307 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1309 * src/maemo/easysetup/modest-easysetup-wizard.c:
1310 (create_account): Correct the position of the gconf sanity check warning.
1311 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1312 of using the g_idle_add() hack, because this does not seem to be necessary
1313 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1314 caused by something other than maemo's gconf.
1315 This fixes projects.maemo.org bug #59022.
1317 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1319 * src/modest-account-mgr-helpers.c:
1320 (modest_account_mgr_get_default_account): Do not check that the account
1321 exists if there is no default account (NULL), to fix a runtime warning.
1323 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1325 * src/widgets/modest-folder-view.c: (update_model):
1326 Do not unref the treemodel before we have finished with it.
1327 This prevents a valgrind warning and an occasional crash at startup.
1329 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1331 * libmodest-dbus-client/libmodest-dbus-client.h:
1332 added libmodest_dbus_client_compose_mail()
1333 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1335 added functions needed for SendAsMail() functionality
1336 * src/maemo/modest-msg-edit-window.c:
1337 (modest_msg_edit_window_attach_file_noninteractive):
1338 non interactively attaching files to message edit window
1339 * src/widgets/modest-msg-edit-window.h:
1340 * tests/dbus_api/Makefile.am:
1341 added test_compose_mail.c
1342 * tests/dbus_api/test_compose_mail.c: (main):
1344 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1346 * src/modest-account-view.c:
1347 Fixed bug projects.maemo.org bug NB#59307
1349 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1351 * src/maemo/easysetup/modest-easysetup-wizard.c:
1352 (get_serverport_incoming), (on_before_next), (create_account):
1353 * src/maemo/modest-account-settings-dialog.c:
1354 (modest_account_settings_dialog_set_account_name):
1355 * src/maemo/modest-maemo-utils.c:
1356 (on_camel_account_get_supported_secure_authentication_status),
1357 (on_camel_account_get_supported_secure_authentication),
1358 (on_secure_auth_cancel),
1359 (modest_maemo_utils_get_supported_secure_authentication_methods):
1361 Implemented security authentication for settings and easysetup.
1363 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1365 * src/maemo/modest-main-window.c: (create_details_widget):
1366 Show the total size for memory card accounts too, instead of showing
1367 the name again. Fixes bug projects.maemo.org bug NB#59307.
1369 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1372 * src/modest-tny-simple-folder-store.c:
1373 * src/modest-tny-simple-folder-store.h: Removed.
1375 * src/modest-tny-local-folders-account.h
1376 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1377 for the local-folders maildir, with an extra TnyMergedFolder containing
1378 the folders of the per-account outbox store accounts.
1379 * src/modest-tny-account-store.c: (get_server_accounts):
1380 Add the outboxes to the special local folders account after creating it.
1382 * src/modest-tny-account.c:
1383 (modest_tny_account_new_for_local_folders): Create the derived
1384 account when creating the main local-folders account.
1386 * src/maemo/modest-main-window.c: (create_details_widget),
1387 (modest_main_window_set_contents_style):
1388 Adapted to the use of the derived account instead of the folder store.
1390 * src/modest-ui-actions.c:
1391 (modest_ui_actions_on_folder_selection_changed):
1392 * src/modest-ui-dimming-rules.c:
1393 (modest_ui_dimming_rules_on_new_folder):
1394 * src/widgets/modest-folder-view.c: (text_cell_data),
1395 (icon_cell_data), (filter_row), (update_model),
1396 (get_cmp_rows_type_pos):
1399 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1400 Do not get the priv struct, because no priv struct has been set,
1401 to avoid a runtime warning.
1403 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1404 #ifelse with #else, to fix a warning, to fix the build.
1407 2007-06-05 Christian Kellner <ckellner@openismus.com>
1409 * libmodest-dbus-client/libmodest-dbus-client.c:
1410 Fix small typo in doc (why do you always see them
1411 AFTER committing stuff?)
1414 2007-06-05 Christian Kellner <ckellner@openismus.com>
1416 * libmodest-dbus-client/libmodest-dbus-client.c:
1417 (libmodest_dbus_client_search):
1418 Initialize hit list with NULL. Also set folder list
1419 to "" if NULL was supplied.
1422 2007-06-03 Christian Kellner <ckellner@openismus.com>
1424 * libmodest-dbus-client/libmodest-dbus-client.c:
1425 (modest_search_hit_list_free):
1426 Make it save to call it with NULL.
1428 * src/dbus_api/modest-dbus-callbacks.c:
1429 * src/modest-search.c:
1430 Return full ModestSearchHits as the search result list not TnyHeader
1431 since can't be around withouth the correspoding TnyFolder.
1433 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1435 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1436 Added currently commented code to check for secure auth
1438 * src/maemo/modest-account-settings-dialog.c: (on_response),
1439 (save_configuration), (show_ok):
1440 Fixed projects.maemo.org bugs NB #59248 and #59251
1442 * src/maemo/modest-maemo-utils.c:
1443 (on_camel_account_get_supported_secure_authentication_status),
1444 (on_camel_account_get_supported_secure_authentication),
1445 (modest_maemo_utils_get_supported_secure_authentication_methods):
1446 * src/maemo/modest-maemo-utils.h:
1447 Moved get_supported_secure_authentication() method here to be able
1448 to use it from easysetup wizard.
1450 * src/modest-pair.c: (on_pair_compare_as_string):
1451 Should compare string with first part of pair and not
1452 strcmp pairs which will crash.
1454 * src/modest-protocol-info.c:
1455 (modest_protocol_info_protocol_is_store):
1456 * src/modest-protocol-info.h:
1457 Added modest_protocol_info_get_auth_protocol_name()
1459 2007-06-03 Armin Burgmeier <armin@openismus.com>
1461 * src/modest-mail-operation.c:
1462 (modest_mail_operation_get_msgs_full): Set priv->account also when
1463 only retrieving a single message. This avoids a crash when canceling
1466 (modest_mail_operation_notify_end): Do not explicitely remove the
1467 operation from the queue but only emit the progress_changed signal.
1468 The queue itself listens to that signal to remove the operation when
1469 it is finished. This reduces coupling and removes a potential deadlock
1470 when modest_mail_operation_notify_end() is called from the queue
1471 itself. If that is a problem performance-wise, I would suggest to
1472 implement a status-changed signal or something.
1474 * src/modest-mail-operation-queue.c: Make sure to never call a
1475 function from another file while the queue is locked. This (hopefully)
1476 fixes another deadlock when exiting the application while retrieving
1479 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1481 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1482 Fixed build if libogs is not available
1484 2007-06-03 Christian Kellner <ckellner@openismus.com>
1486 * libmodest-dbus-client/libmodest-dbus-client.h:
1487 * libmodest-dbus-client/libmodest-dbus-client.c:
1488 (libmodest_dbus_client_delete_message):
1489 Implement deletion of messages (Client side).
1491 (modest_search_hit_free),
1492 (modest_search_hit_list_free):
1493 Utility functions to free the result hits.
1495 * src/dbus_api/modest-dbus-api.h:
1496 * src/dbus_api/modest-dbus-callbacks.c:
1497 (on_delete_message),
1498 (modest_dbus_req_handler):
1499 Implement deletion of messages (Server side).
1501 * tests/dbus_api/test_search.c: (main):
1504 * tests/dbus_api/Makefile.am:
1505 * tests/dbus_api/test_delete_message:
1506 Add little test for the message deletion logic
1508 2007-06-03 Armin Burgmeier <armin@openismus.com>
1510 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1511 when the operation queue was not empty. projects.maemo.org bug
1514 2007-06-03 Armin Burgmeier <armin@openismus.com>
1516 * src/widgets/modest-account-view.c
1517 (on_account_default_toggled): Toggle default account column
1518 explicitely instead of waiting for gconf notification (which is
1519 currently ignored). This should fix projects.maemo.org bug NB#56910
1520 for now. It should probably be removed when gconf notifications are
1523 2007-06-03 Christian Kellner <ckellner@openismus.com>
1525 * libmodest-dbus-client/libmodest-dbus-client.c:
1526 Removed debugging spew.
1528 * src/dbus_api/modest-dbus-callbacks.c:
1529 Added debugging info.
1531 * src/modest-search.c:
1532 (modest_search_all_accounts):
1533 Use tny_account_store_get_accounts () on the account store
1534 to get all accounts which is the way to get all accounts.
1536 * tests/dbus_api/test_search.c: (main):
1537 Make it possible to supply the search term on the command line.
1539 2007-06-03 Christian Kellner <ckellner@openismus.com>
1541 * libmodest-dbus-client/libmodest-dbus-client.c:
1542 * libmodest-dbus-client/libmodest-dbus-client.h:
1543 Implement searching for mesages over raw dbus. (Client side)
1545 * src/dbus_api/Makefile.am:
1546 * src/dbus_api/modest-dbus-api.h:
1547 * src/dbus_api/modest-dbus-callbacks.c:
1548 * src/dbus_api/modest-dbus-callbacks.h:
1549 Search framework (Server side). Also implement on_idle_open_message().
1551 * src/maemo/modest-platform.c: (modest_platform_init):
1552 Prepare for raw dbus/osso rpc interaction.
1554 * src/modest-search.h:
1555 Changed minsize from unspecific guint to guint32.
1557 * src/modest-search.c:
1559 Added strange hack which magically made tnymail work.
1561 (modest_search_folder),
1562 (modest_search_account),
1563 (modest_search_all_accounts):
1564 Implement helper functions to search all accounts, specific account
1567 * tests/dbus_api/Makefile.am:
1568 * tests/dbus_api/test_open_message.c:
1569 Read url to open from commandline.
1571 * tests/dbus_api/test_search.c:
1572 Implement small test for dbus search stuff
1574 2007-06-02 Armin Burgmeier <armin@openismus.com>
1576 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1577 include account type and account title. This fixes projects.maemo.org
1580 * src/maemo/modest-account-view-window.c: Set a title for the window.
1582 2007-06-02 Armin Burgmeier <armin@openismus.com>
1584 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1585 incoming and outgoing server name based on email address and server
1586 types as long as the names have not been edited manually. This fixes
1587 projects.maemo.org bug NB#58671.
1589 2007-06-02 Armin Burgmeier <armin@openismus.com>
1591 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1592 server type cannot be changed in future to the incoming details page
1593 when creating an account. This fixes projects.maemo.org bug NB#59029.
1595 2007-06-02 Armin Burgmeier <armin@openismus.com>
1597 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1598 and assigned max width chars so that they wrap instead of being
1599 truncated. Fixes projects.maemo.org bug NB#56126.
1601 2007-06-02 Armin Burgmeier <armin@openismus.com>
1603 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1604 introductory note to the connection specific smtp servers dialog, as
1605 section 8.12 of the email UI specification requires. This fixes
1606 projects.maemo.org bug NB#59212.
1608 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1610 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1611 Check for running mail operations, and offer to cancel them, as per the UI
1612 spec. This fixes projects.maemo.org bug NB#59041 .
1613 However, I suspect that tinymail may still use the network connection
1614 in ways that we cannot detect or cancel. But it should at least adapt to
1615 changes fairly well.
1617 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-tny-account-store.c: (recreate_all_accounts),
1620 (get_cached_accounts), (get_server_accounts): Do more sensible
1621 ref-counting of the temporarily-cached outbox accounts list. This seems
1622 to fix a crash when entering the password when the password was wrong.
1624 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1626 * src/gnome/modest-main-window.c: (connect_signals):
1627 * src/modest-tny-account-store.c: (get_password),
1628 (modest_tny_account_store_alert): Added comments and clues and
1629 commented-out code about how we currently fail to deal with connection
1630 errors and wrong passwords, and how we should.
1632 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1634 * src/widgets/modest-retrieve-combo-box.c:
1635 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1636 This fixes projects.maemo.org bug NB#58472 .
1638 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1640 * src/maemo/easysetup/modest-easysetup-wizard.c:
1641 (create_page_complete_easysetup):
1642 (create_page_complete_custom): Correct the last commit,
1643 putting the correct sentences in the correct pages.
1645 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1647 * src/maemo/easysetup/modest-easysetup-wizard.c:
1648 (create_page_complete_custom): Show the second sentence of text
1649 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1652 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1654 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1655 Set the leave-on-server conf key by default. This fixes
1656 projects.maemo.org bug NB#59258 .
1658 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1660 * src/maemo/modest-account-view-window.c:
1661 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1662 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1665 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1667 * src/maemo/easysetup/modest-easysetup-wizard.c:
1668 (create_caption_new_with_asterisk):
1669 * src/maemo/modest-account-settings-dialog.c:
1670 (create_caption_new_with_asterisk):
1671 Uncomment the code to add the asterisk, because they are no longer in the
1672 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1673 (update_incoming_server_title): Add an asterisk here too.
1675 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1677 * src/maemo/modest-maemo-global-settings-dialog.c:
1678 (current_connection): Check that we are even connected before trying to
1679 get the current connection name, to prevent a warning.
1681 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1682 Change the comments because tny_maemo_conic_device_connect() is now meant to
1684 * src/modest-mail-operation.c:
1685 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1686 make sure we have a connection and fail if we can't connect.
1688 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1690 * src/maemo/modest-main-window.c:
1691 (on_account_store_connecting_finished): Do not try to get the
1692 connection ID if we are not really connected. I am surprised that
1693 this signal handler is called when we are not connected.
1695 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1697 * src/modest-error.h:
1698 * src/modest-ui-actions.c:
1699 (modest_ui_actions_get_msgs_full_error_handler):
1700 Renamed an enum, added comments, added an enum
1701 for retrieve-limit errors.
1703 * src/modest-mail-operation.c: (foreach_add_item),
1704 (internal_folder_observer_update), (update_account_thread),
1705 (modest_mail_operation_get_msgs_full):
1706 (modest_mail_operation_update_account),
1707 Added comments about how this works, and some code that should
1708 (but does not) check the retrieve-limit. See the TODO comment.
1710 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1712 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1713 Initialize help_id to fix the build. Warnings are good.
1715 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1717 * src/widgets/modest-hbox-cell-renderer.c:
1718 (modest_hbox_cell_renderer_append):
1719 * src/widgets/modest-vbox-cell-renderer.c:
1720 (modest_vbox_cell_renderer_append):
1721 Fix the last commit by doing an extra ref.
1723 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1725 * src/widgets/modest-hbox-cell-renderer.c:
1726 (modest_hbox_cell_renderer_append):
1727 * src/widgets/modest-vbox-cell-renderer.c:
1728 (modest_vbox_cell_renderer_append):
1729 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1730 to fix the build with Maemo Bora.
1731 However, there seems to be a remaining crash, probably due to reference
1734 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1736 * src/modest-tny-account.c:
1737 (modest_tny_account_new_for_local_folders):
1738 Use hildon_file_system_info_async_new() to get a better name for
1739 the memory card account, setting it as the account name.
1740 The timing seems to work, but this is probably
1741 not the best place to do this. See the TODO comment.
1742 * src/maemo/modest-main-window.c: (create_details_widget):
1743 * src/widgets/modest-folder-view.c: (text_cell_data):
1744 Use the tny account name instead of hardcoding a name.
1746 2007-05-30 Christian Kellner <ckellner@openismus.com>
1748 * src/modest-search.c: (modest_search):
1749 Correctly set part_search_func even if we have already parsed
1750 the query and thus a valid OgsTextSearcher object.
1752 2007-05-30 Christian Kellner <ckellner@openismus.com>
1755 Search and check for libogs.
1758 Incooparte the ogs build env.
1760 * src/modest-mime-part-search-stream.c:
1761 * src/modest-mime-part-search-stream.h:
1762 Removed since we do the real searching now in modest-search.c.
1764 * src/modest-search.c:
1765 * src/modest-search.h:
1766 Implement support for ogs. We use that if available and requested
1767 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1768 should now handle the corner case when the search term is spread
1769 across multiple reads.
1770 Also the logic in modest_search () was corrected to search all
1771 requested fields until one is found.
1773 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1775 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1777 * src/modest-init.h:
1778 * src/modest-init.c: Made modest_init_local_folders() take a
1779 path and be public so we can iniitialize maildir folders on
1782 * src/modest-local-folder-info.h:
1783 * src/modest-local-folder-info.c:
1784 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1786 * src/modest-tny-account.c:
1787 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1788 still means the standard local-folders path on the local volume.
1790 * src/modest-tny-account-store.c:
1791 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1792 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1793 all accounts when that happens.
1794 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1795 this too, so it shows up in the treeview.
1797 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1799 * src/maemo/modest-maemo-global-settings-dialog.c:
1800 (current_connection):
1801 * src/widgets/modest-global-settings-dialog.c:
1802 (current_connection_default):
1803 Use the enum values instead of 0, 1 and -1,
1804 to make the code clearer.
1806 * src/modest-account-mgr-helpers.c:
1807 (modest_account_mgr_get_connection_specific_smtp): Make this code
1810 * src/modest-runtime.h:
1811 * src/modest-runtime.c:
1812 Added modest_runtime_remove_all_send_queues().
1813 * src/maemo/modest-main-window.c:
1814 (on_account_store_connecting_finished): Recreate the send queues,
1815 using the appropriate transport accounts for this new connection.
1816 Some futher adapting might be needed if the old send queues are not
1817 automatically stopped at this point.
1819 * src/modest-tny-account-store.c: (get_server_accounts):
1820 Create the connection-specific transport accounts, so that they can
1821 be found later by their ID.
1823 * src/modest-tny-account.h:
1824 * src/modest-tny-account.c:
1825 Added modest_tny_account_new_from_server_account_name().
1826 modest_tny_account_new_from_server_account(): Do not create the
1827 send queues here, because they will be
1828 recreated anyway when the connection changes for the first time.
1830 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-local-folder-info.h:
1833 * src/modest-local-folder-info.c:
1834 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1835 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1836 tbox_folder): Take a modest account name instead of a server TnyAccount,
1837 so we can have per-modest-account rather than per-transport-account
1839 We must make sure that we change or recreate the exisitng send queues
1840 when the connection changes for connection-specific transport accounts.
1842 * src/modest-tny-account-store.c:
1843 (create_per_account_local_outbox_folders): Create outboxed per modest
1844 account, not per transport account.
1846 * src/modest-tny-account.h:
1847 * src/modest-tny-account.c:
1848 (modest_tny_account_get_special_folder): For outboxes, get the
1849 parent modest account name. The account is ignored for other folders.
1850 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1851 modest account name rather than a server TnyAccount.
1853 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-tny-account.c:
1856 (modest_tny_account_new_from_server_account):
1857 Call modest_runtime_get_send_queue() immediately after creating transport
1858 accounts, so that they start trying to send email from the outbox as soon
1859 as possible at startup. This is probably what we want.
1861 * src/modest-mail-operation.c: (update_account_thread):
1862 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1863 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1864 * src/modest-tny-send-queue.h:
1865 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1866 (modest_ui_actions_on_send):
1867 Added comments about how sending works, though it needs some more work.
1869 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1871 * src/modest-tny-account.c:
1872 (modest_tny_account_get_special_folder): Add TODO because this fails when
1873 the network is busy.
1874 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1875 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1876 Do not try to show this window when there is no active account. The UI
1877 specs does not tell us what to do in this case.
1879 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1883 * src/maemo/Makefile.am:
1884 * src/widgets/Makefile.am: Some dist fixes.
1886 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1888 * src/maemo/modest-connection-specific-smtp-window.c:
1889 (on_button_edit): Make the code clearer, to prevent a double free.
1891 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/modest-account-settings-dialog.c:
1894 (modest_account_settings_dialog_set_account_name),
1895 Check the connection-specific smtp servers checkbox if there are any.
1897 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1898 (modest_connection_specific_smtp_edit_window_init):
1899 Start with a suitable port number.
1901 * src/modest-account-mgr-helpers.h:
1902 * src/modest-account-mgr-helpers.c: Added
1903 modest_account_mgr_get_has_connection_specific_smtp().
1905 (modest_account_mgr_set_connection_specific_smtp),
1906 (modest_account_mgr_remove_connection_specific_smtp),
1907 (modest_account_mgr_get_has_connection_specific_smtp),
1908 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1909 connection-specific smtp server accounts in the account, rather than
1910 the server account conf dir.
1912 This fixes bug projects.maemo.org bug NB#58263 .
1914 * src/modest-tny-account-store.c:
1915 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1916 if there are no server accounts yet, to prevent an infinite loop when there
1917 are no accounts. Document that one must be called before the other.
1919 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1921 * src/modest-account-mgr-helpers.c:
1922 (modest_account_mgr_get_default_account): Make sure that at least
1923 one account is always the default, if there are any enabled accounts.
1924 This is just a sanity check that shouldn't be necessary.
1926 * src/modest-account-mgr-priv.c:
1927 (_modest_account_mgr_account_from_key): Unescape the conf key to
1928 get the real account name. For instance, this is an issue if a space
1929 was in the account name, which can happen because the account name
1930 is generated from the display name.
1931 (_modest_account_mgr_get_account_keyname): Always escape the
1933 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1934 Unescape the conf keys to get the real account names.
1936 For instance, previously the is-default radio button in the accounts
1937 list was not checked for any accounts at first. This fixes that,
1938 and might fix several similar bugs.
1940 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1943 Removed some debug printfs.
1945 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1947 Modest on-disk outbox directories are now here, for instance:
1948 $HOME/.modest/outboxes/<account-id-1>/outbox
1949 $HOME/.modest/outboxes/<account-id-2>/outbox
1951 $HOME/.modest/local-folders/outbox
1952 so we can have a separate outbox for each account.
1953 But they are shown as one outbox in the GtkTreeView, by using a
1954 TnyMergeFolder in a ModestTnySimpleFolderStore.
1957 * src/modest-tny-simple-folder-store.c:
1958 * src/modest-tny-simple-folder-store.h:
1959 Added ModestTnySimpleFolderStore, used to contain folders from
1960 other folder stores, such as other accounts.
1962 * src/modest-tny-outbox-account.h:
1963 * src/modest-tny-outbox-account.c:
1964 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1965 used for the per-account local outbox folders.
1967 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1968 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1969 only use this (internally) now for the non-outbox local folders.
1971 * src/modest-init.h:
1972 * src/modest-init.c: Added modest_init_one_local_folder(), for
1973 setting up the directory structure for each local folder.
1975 * src/modest-local-folder-info.c:
1976 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1977 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1979 * src/modest-local-folder-info.h:
1980 * src/modest-tny-account-store.c: (on_account_removed),
1981 (on_account_changed), (create_per_account_local_outbox_folders),
1982 (get_server_accounts), (modest_tny_account_store_get_accounts),
1983 (modest_tny_account_store_get_tny_account_by_account),
1984 (modest_tny_folder_store_is_virtual_local_folders):
1986 * src/modest-tny-account.h:
1987 * src/modest-tny-account.c:
1988 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1989 to create an on-disk per-account local outbox folder for each
1991 (create_per_account_local_outbox_folders): Create a local outbox folder
1992 for each transport account.
1993 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1994 for all local folders.
1996 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1997 instead of using g_object_get/set() directly. It is clearer.
1999 (modest_tny_folder_store_get_message_count),
2000 (modest_tny_folder_store_get_local_size
2001 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2002 because we now use these with non-acount folder stores.
2004 (modest_tny_account_get_special_folder),
2005 (modest_tny_account_new_from_server_account),
2006 (modest_tny_account_new_from_account):
2007 (recurse_folders): Adjust to the new outbox system.
2009 * src/modest-tny-folder.h:
2010 * src/modest-tny-folder.c:
2011 (modest_tny_folder_is_local_folder),
2012 (modest_tny_folder_get_local_folder_type),
2013 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2015 * src/widgets/modest-main-window.h:
2016 * src/maemo/modest-main-window.c: (create_details_widget),
2017 (modest_main_window_set_contents_style): Show details for any folder store,
2020 (modest_tny_folder_get_rules):
2021 Remove the const. C does not support constness enough for this.
2023 * src/modest-ui-actions.c:
2024 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2025 make all outboxes appear as one, in the usual local-folders tree node.
2027 (set_active_account_from_tny_account),
2028 (modest_ui_actions_on_folder_selection_changed):
2029 * src/widgets/modest-folder-view.c: (text_cell_data),
2030 (icon_cell_data), (filter_row),
2031 (add_account_folders_to_merged_folder),
2032 (add_account_folders_to_simple_folder_store), (),
2033 (get_cmp_rows_type_pos), (cmp_rows),
2034 (modest_folder_view_set_account_id_of_visible_server_account):
2035 Adjust to the new outbox system, using generic folder stores and folders
2036 in the GtkTreeModel.
2038 2007-05-23 Christian Kellner <ckellner@openismus.com>
2040 * src/modest-mail-operation.c:
2041 (modest_mail_operation_update_account):
2042 Use info->max_size instead of unintialized local var [small
2043 build fix]. (Added TODO to review that change since I don't
2046 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2048 * libmodest-dbus-client/libmodest-dbus-client.c:
2049 (libmodest_dbus_client_compose_mail): function added
2050 * src/dbus_api/modest-dbus-api.h:
2051 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2052 (on_compose_mail): Implementation of the SendAsMail functionality
2054 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2056 * src/modest-account-mgr.c:
2057 (modest_account_mgr_add_server_account): Set the secure-connection
2058 conf key for transport accounts as well as store accounts. I don't know
2059 why the if was there. For instance, this makes sure that we use SSL
2060 for the gmail preset from the easysetup wizard.
2062 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2064 * src/gnome/modest-main-window.c:
2065 (on_account_store_connecting_finished), (connect_signals):
2066 * src/maemo/modest-main-window.c:
2067 (on_account_store_connecting_finished), (connect_signals),
2068 (modest_main_window_new):
2069 Handle TnyAccountStore::connecting-finished instead of
2070 TnyDevice::connection-changed, because we cannot actually perform
2071 operations on accounts until TnyAccountStore has itself responded to
2072 the TnyDevice::connection-changed signal. This prevents a GError from
2074 Do not try to update at startup, because we (at least on scratchbox)
2075 already do an update at startup when the device goes online.
2076 This prevents a GError from tinymail.
2077 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2078 Added TODO about stopping simultaneous operations.
2080 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2082 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2083 * src/modest-mail-operation-queue.c:
2084 (modest_mail_operation_queue_remove):
2085 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2086 about where they happened.
2088 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2090 * src/modest-ui-actions.c:
2091 (modest_ui_actions_on_password_requested): Make sure that the remember
2092 output parameter is always TRUE.
2094 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2096 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2097 Show a OK/Cancel dialog if the error is a question, though we still do not
2098 know anything more about what we are asking the user.
2099 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2100 Fix an uninitialized variable (helper). This is a logic error, however.
2102 2007-05-21 Christian Kellner <ckellner@openismus.com>
2104 * src/modest-search.h:
2105 Correct bit shifting in the ModestSearchFlags enum.
2107 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2109 * src/modest-tny-account.c:
2110 (modest_tny_account_new_from_server_account): Do not use the lsub and
2111 check-all hard-coded IMAP options when using POP.
2113 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2115 * src/modest-tny-account.c:
2116 (modest_tny_account_new_from_server_account):
2117 Use NULL for the secure-auth method for POP when Password auth has been
2118 specified by the user, as we already do for IMAP. "auth=Login" causes
2119 an error from camel or the server.
2121 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2123 * src/maemo/modest-account-settings-dialog.c:
2124 (create_page_account_details),
2125 (modest_account_settings_dialog_set_account_name):
2126 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2127 for the leave-on-server checkbox, rathr than just the checkbox, when
2128 the protocol is not POP.
2130 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2132 * src/widgets/modest-account-view.c:
2133 * src/widgets/modest-account-view.h:
2134 Added modest_account_view_select_account() which will be useful later
2135 to asynchronously re-select the edited account.
2137 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/modest-account-settings-dialog.c:
2140 (modest_account_settings_dialog_set_account_name):
2141 Automatically choose the port numbers based on the secure authentication
2142 methods, if they have not been chosen before.
2143 This fixes projects.maemo.org bug NB#56273 .
2145 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2147 * src/maemo/modest-main-window-ui.h:
2148 * src/modest-ui-actions.c:
2149 * src/modest-ui-actions.h:
2150 Connect the Tools/SMTP Servers menu item to
2151 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2152 SMTP servers dialog, as in the UI specification and saves changes when it
2153 is closed. This fixed projects.maemo.org bug NB#56305 .
2155 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/modest-connection-specific-smtp-window.c:
2158 (modest_connection_specific_smtp_window_init):
2159 Use gtk_window_set_default_size() to make this window big enough, so
2160 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2162 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2164 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2165 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2166 (modest_connection_specific_smtp_edit_window_init),
2167 Do not try to connect to a combobox signal before the combobox exists.
2168 This fixes the cras in projects.maemo.org bug NB#56288 .
2169 (modest_connection_specific_smtp_edit_window_get_settings):
2170 Remove the server_account_name parameter which was being checked for NULL
2171 though it was not used.
2173 * src/maemo/modest-connection-specific-smtp-window.c:
2174 (modest_connection_specific_smtp_window_fill_with_connections),
2175 (on_button_edit), (modest_connection_specific_smtp_window_init):
2176 Correct the number of treemodel columns to prevent a warning.
2177 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2178 libconic does not work.
2180 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2182 * src/modest-tny-account.c:
2183 (modest_tny_account_new_from_server_account):
2184 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2185 SMTP when "None" was chosen by the user. However, with my SMTP server that
2186 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2189 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2191 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2192 to explain the memory management issue with the ID in the ModestPair.
2194 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2195 (add_sending_page), (modest_account_assistant_finalize):
2196 * src/gnome/modest-gnome-global-settings-dialog.c:
2197 (create_updating_page), (create_composing_page):
2198 * src/gnome/modest-msg-edit-window.c: (get_transports),
2199 (init_window), (modest_msg_edit_window_finalize),
2200 (modest_msg_edit_window_get_msg_data):
2201 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2202 * src/gnome/modest-transport-widget.c:
2203 (modest_transport_widget_finalize), (smtp_configuration):
2204 * src/maemo/modest-maemo-global-settings-dialog.c:
2205 (create_updating_page), (create_composing_page):
2206 * src/maemo/modest-msg-edit-window.c: (get_transports),
2207 (init_window), (modest_msg_edit_window_finalize),
2208 (modest_msg_edit_window_get_msg_data),
2209 (modest_msg_edit_window_free_msg_data):
2210 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2211 (modest_store_widget_finalize):
2212 * src/maemo/modest-transport-widget.c:
2213 (modest_transport_widget_finalize), (smtp_configuration):
2214 * src/modest-main.c: (send_mail):
2215 * src/widgets/modest-combo-box.h:
2216 * src/widgets/modest-global-settings-dialog-priv.h:
2217 * src/widgets/modest-global-settings-dialog.c:
2218 (modest_global_settings_dialog_finalize):
2219 * src/widgets/modest-msg-edit-window.h:
2220 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2221 as long as the combo box, to prevent use of freed memory for the ID.
2223 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2225 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2226 get_accounts(), to make this clearer. Do not check for the enabled gconf
2227 key, because we do not use this for server accounts (at least, not yet).
2228 This allows us to send email again.
2230 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2232 * src/maemo/modest-platform.c:
2233 (on_modest_conf_update_interval_changed), (modest_platform_init):
2234 Only respond to this particular key change. All these strcmp()s cannot be
2237 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2239 * src/maemo/modest-maemo-global-settings-dialog.c:
2240 (current_connection): Prevent a crash in scratchbox when
2241 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2242 * src/maemo/modest-platform.c:
2243 (on_modest_conf_update_interval_changed), (modest_platform_init):
2244 Get the update interval from gconf and reset it when the gconf key changes.
2246 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2248 * src/modest-protocol-info.c:
2249 * src/modest-protocol-info.h: Adde enum-specific get functions,
2250 instead of using a ModestProtocolType enum parameter.
2252 * src/gnome/modest-account-assistant.c:
2253 * src/gnome/modest-store-widget.c:
2254 * src/gnome/modest-store-widget.h:
2255 * src/gnome/modest-transport-widget.c:
2256 * src/gnome/modest-transport-widget.h:
2257 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2258 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2259 * src/maemo/easysetup/modest-easysetup-wizard.c:
2260 * src/maemo/modest-account-settings-dialog.c:
2261 * src/maemo/modest-account-settings-dialog.h:
2262 * src/maemo/modest-store-widget.c:
2263 * src/maemo/modest-store-widget.h:
2264 * src/maemo/modest-transport-widget.c:
2265 * src/maemo/modest-transport-widget.h:
2266 * src/modest-account-mgr-helpers.c:
2267 * src/modest-account-mgr-helpers.h:
2268 * src/modest-account-mgr.c:
2269 * src/modest-account-mgr.h:
2270 * src/modest-tny-account.c:
2271 * src/modest-tny-folder.c:
2272 * src/widgets/modest-account-view.c:
2273 * src/widgets/modest-retrieve-combo-box.c:
2274 * src/widgets/modest-retrieve-combo-box.h:
2275 * src/widgets/modest-secureauth-combo-box.c:
2276 * src/widgets/modest-serversecurity-combo-box.c:
2277 * src/widgets/modest-serversecurity-combo-box.h:
2278 * tests/check_account-mgr.c:
2279 Use the specific functions, and use the re-renamed enum values for GNOME too.
2281 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2283 * src/modest-pair.h:
2284 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2285 so we can get the second based on the first.
2287 * src/maemo/modest-account-settings-dialog.h:
2288 * src/maemo/modest-account-settings-dialog.c:
2289 Added get_supported_secure_authentication_methods(), though it is mostly
2290 commented-out for now until the necessary API is committed to tinymail.
2291 (modest_account_settings_dialog_set_account_name),
2292 (save_configuration): Request the supported authentication methods from the
2293 server, so we can choose a working method.
2295 * src/modest-tny-account-store.h:
2296 * src/modest-tny-account-store.c:
2297 (modest_tny_account_store_get_session): Rename from
2298 tny_account_store_get_session().
2300 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2302 * src/modest-protocol-info.h: Split the ModestProtocol enum
2303 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2304 There was no need to have these unrelated values in one enum.
2306 * src/: many files: Adapted to changed enum. This makes the code a bit
2307 clearer, and the compiler could catch some errors.
2309 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2311 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2312 Show the detailed internal camel error message when an error happens
2313 during the configuration, so that our testers can give us more clues.
2314 For instance, in projects.maemo.org bug NB#56910 .
2316 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2318 * src/modest-tny-account.c:
2319 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2320 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2322 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2324 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2325 * src/maemo/modest-account-settings-dialog.c:
2326 (modest_account_settings_dialog_set_account_name),
2327 (save_configuration): For the incoming secure authentication checkbox,
2328 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2329 the UI specification. PLAIN does not seem to be supported for most IMAP
2330 servers anyway, and I am not sure what it would mean.
2331 However, we probably need to discover which of the secure-authentication
2332 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2333 * src/modest-account-mgr-helpers.c:
2334 (modest_account_mgr_get_server_account_data):
2336 * src/modest-tny-account.c:
2337 (modest_tny_account_new_from_server_account):
2338 Use tny_account_set_mech() to set secure-authentication methods,
2339 with some special-casing for IMAP, based on my observations of how
2342 * src/modest-account-mgr-helpers.h:
2343 * src/modest-account-mgr.c:
2344 * src/modest-defs.h: Comment that the URI is only used for local folders.
2346 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2348 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2349 parameter const, just to be neat.
2350 * src/modest-text-utils.c: (modest_text_utils_inline):
2351 End g_strconcat() with NULL, as its documentation says. This is almost
2352 certainly the cause of my crash at startup on the device. Interestingly,
2353 valgrind doesn't tell us about these errors.
2355 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2357 * scripts/build-packages: Added more precise comments about how to use
2358 this script, though I still get this error:
2359 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2360 error building tinymail
2362 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2364 * src/maemo/modest-main-window.c: (on_account_update):
2365 Very slight cleanup, hoping to make it simpler to discover what causes
2366 a crash here sometimes.
2368 * src/modest-tny-account.c:
2369 (modest_tny_account_new_from_server_account): Set the port. Added
2370 comments about the options and a TODO comment because I need to find out
2371 how to specify the secure authentication method.
2373 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2375 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2376 changed CFlags paths form modest to libmodest
2378 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2380 * src/modest-account-mgr-helpers.c:
2381 (modest_account_mgr_get_server_account_data),
2382 (modest_account_mgr_free_server_account_data):
2383 * src/modest-account-mgr-helpers.h:
2384 * src/modest-account-mgr.c:
2385 (modest_account_mgr_add_server_account):
2386 * src/modest-defs.h:
2387 * src/modest-tny-account.c:
2388 (modest_tny_account_new_from_server_account):
2389 Determine the options for tny_camel_account_add_option() here,
2390 based on the settings, rather than storing them directly in gconf.
2392 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2394 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2395 Show a more friendly error dialog now that we expect (from the tinymail
2396 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2398 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2400 * src/maemo/modest-main-window.c: (on_account_update): Check that
2401 account_name is not NULL, to prevent a crash at startup that I am
2402 seeing on the N800. I do wonder why it is NULL.
2404 * src/maemo/easysetup/modest-easysetup-wizard.c:
2405 (create_page_user_details):
2406 * src/maemo/modest-account-settings-dialog.c:
2407 (create_page_user_details), (create_page_outgoing):
2408 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2409 (modest_connection_specific_smtp_edit_window_init):
2410 * src/modest-ui-actions.c:
2411 (modest_ui_actions_on_password_requested):
2412 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2413 might do something useful with the on-screen keyboard.
2415 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2417 * src/maemo/modest-main-window.c: (on_account_update):
2418 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2419 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2421 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2423 * src/modest-tny-account-store.c: (on_account_changed):
2424 Correct the signature of this signal handler.
2426 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2428 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2429 Show a HildonNote instead of a GtkDialog for Maemo.
2431 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2433 * src/widgets/modest-account-view.h:
2434 * src/widgets/modest-account-view.c: (on_account_changed),
2435 (on_account_removed). Added a boolean flag, set/unset by
2436 modest_account_view_block_conf_updates(),
2437 modest_account_view_unblock_conf_updates() to prevent unnecessary
2438 updates, but this is not very useful because the gconf notifications are
2439 so delays (maybe only on Maemo Bora).
2440 So auto-updating is turned off, and these functions do an explicit
2441 update when necessary.
2442 However, something else is still doing too much work when adding/removing
2443 accounts, probably in another part of the application.
2445 * src/maemo/modest-account-view-window.c:
2446 (on_delete_button_clicked), (on_edit_button_clicked),
2447 (on_new_button_clicked): Use the new functions.
2449 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2451 * src/modest-account-mgr-helpers.c:
2452 (modest_account_mgr_set_first_account_as_default):
2453 Sort the list of names alphabetically-by-title, so we choose the first one
2455 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2456 alphabetically by the title.
2458 This fixes projects.maemo.org bug NB#56418 .
2460 * src/modest-account-mgr-priv.c:
2461 (_modest_account_mgr_account_from_key):
2462 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2463 avoid a valgrind error, and possible random behaviour.
2465 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2467 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2468 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2469 tinymail documentation to say that this can be expected.
2470 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2471 pretty, and should not happen, but I would prefer to know when it does.
2473 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2475 * configure.ac: When using the older hildon version, probably on Bora,
2476 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2478 * src/widgets/modest-attachment-view.c:
2479 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2482 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2484 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2485 Implemented the prototype. Can be tested with
2486 tests/dbus_api/test_open_message:
2488 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2490 * src/modest-tny-account-store.c:
2491 (modest_tny_account_store_instance_init), (get_password):
2492 * src/modest-ui-actions.c:
2493 (modest_ui_actions_on_password_requested):
2494 Do not store the password in gconf, because this function is called
2495 for non-remembered passwords. Actually use the cached (in the hash map)
2496 password instead of releasing it.
2497 The password will now not be remembered if it is asked via the protected
2498 password dialog, as per the UI spec.
2500 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2502 * src/modest-defs.h:
2503 * src/modest-account-mgr-helpers.h:
2504 * src/modest-account-mgr-helpers.c:
2505 Added modest_server_account_get_username_has_succeeded(),
2506 modest_server_account_set_username_has_succeeded().
2507 (modest_server_account_set_username),
2508 Reset the has-succeeded flag if the username changes.
2510 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2511 * src/maemo/modest-connection-specific-smtp-window.c:
2512 (modest_connection_specific_smtp_window_save_server_accounts):
2513 Use modest_server_account_set_username() instead of using
2514 modest_conf_set_string() directly, so that the has-succeeded flag is always
2517 * src/modest-ui-actions.c:
2518 (modest_ui_actions_on_password_requested): Dim the username entry if
2519 the username has ever worked, as per the UI spec.
2521 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2523 * src/modest-tny-account-store.c: (get_password):
2524 * src/modest-ui-actions.c:
2525 (modest_ui_actions_on_password_requested):
2526 Allow the username to be changed too, though there is more work to
2527 be done on exactly how this behaves.
2529 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2531 * src/modest-account-mgr-helpers.h:
2532 * src/modest-account-mgr-helpers.c:
2533 Added modest_account_mgr_get_display_name(),
2534 modest_server_account_get_username(),
2535 modest_server_account_set_username(),
2536 modest_server_account_set_password(),
2537 modest_server_account_get_hostname() functions so we do not need to
2538 use the conf API directly.
2540 * src/maemo/modest-main-window.c: (connect_signals):
2541 Actually connect ot the ModestAccountStore::request-password signal,
2542 so that we show the dialog when the password is requested by Tinymail,
2543 for isntance if it is empty.
2545 * src/modest-marshal.list:
2546 * src/modest-tny-account-store.c:
2547 (modest_tny_account_store_class_init), (get_password),
2548 (modest_tny_account_store_alert):
2549 * src/modest-tny-account-store.h:
2550 * src/modest-ui-actions.h:
2551 * src/modest-ui-actions.c:
2552 (modest_ui_actions_on_password_requested):
2553 Change the signal parameters, so it is obvious that we are providing
2554 the non human-readable server name, and receiving both the username
2555 and password, though changing of the username is not yet implemented.
2556 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2557 for the GNOME version.
2559 This should fix the projects.maemo.org bug NB#56209, though it does not
2560 work on Bora, because the gconf_client_get() for the password fails
2561 immediately after we save it with gconf_client_set().
2563 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2566 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2567 caused an undefined symbol error:
2568 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2570 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2572 * src/modest-tny-account-store.c:
2573 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2574 using a GError instead of a string message, so we can translate it in
2577 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/modest-address-book.c:
2580 (modest_address_book_check_names):
2581 * src/maemo/modest-msg-view-window.c:
2582 (modest_msg_view_window_clipboard_owner_change):
2583 * src/modest-init.c: (modest_init_init_ui):
2584 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2585 (update_folders_cb), (modest_mail_operation_update_account):
2586 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2587 (modest_ui_actions_on_msg_attachment_clicked),
2588 (modest_ui_actions_on_msg_recpt_activated):
2589 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2590 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2591 (modest_msg_view_search_next):
2592 * src/widgets/modest-recpt-editor.c:
2593 (modest_recpt_editor_on_button_release_event),
2594 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2595 g_message(). At this point we should only be seeing interesting errors on
2596 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2598 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2600 (modest_wizard_dialog_force_title_update):
2601 * src/maemo/easysetup/modest-wizard-dialog.h:
2602 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2603 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2604 can update the title when appropriate. Otherwise the title is wrong if the
2605 pages are added after adding the notebook to the dialog.
2606 This must be a problem in HildonWizardDialog too.
2607 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2609 * src/maemo/easysetup/modest-easysetup-wizard.c:
2610 (create_subsequent_customsetup_pages),
2611 (create_subsequent_easysetup_pages):
2612 Call modest_wizard_dialog_force_title_update() so that the title is
2613 correct even with GTK+ < 2.10.
2614 This fixes projects.maemo.org bug NB#56145 .
2616 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/modest-platform.c:
2619 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2620 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2623 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2625 * src/widgets/modest-window.h:
2626 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2627 and modest_window_save_state(), which invokes it.
2629 * src/widgets/modest-window-mgr.h:
2630 * src/widgets/modest-window-mgr.c:
2631 Added modest_window_mgr_save_state_for_all_windows(), which calls
2632 the save_state vfunc on all registered windows, if implemented.
2634 * src/gnome/modest-msg-edit-window.c:
2635 * src/gnome/modest-msg-view-window.c:
2636 * src/maemo/modest-msg-edit-window.c:
2637 * src/maemo/modest-msg-view-window.c:
2638 * src/maemo/modest-main-window.c:
2639 Specify the existing save_settings functions as implementations of
2640 ModestWindow::save_state_func().
2642 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2643 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2644 enabling hibernation, for instance.
2646 We may need to do the same thing for restoring settings.
2649 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2651 * src/widgets/modest-window-mgr.c:
2652 * src/widgets/modest-window-mgr.h:
2653 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2654 modest_window_mgr_get_hibernation_is_prevented().
2656 * src/maemo/modest-main-window.c:
2657 (on_hildon_program_is_topmost_notify): Prevent hibernation
2658 (possible when the application goes to the background in the WM),
2659 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2661 * src/maemo/easysetup/modest-easysetup-wizard.c:
2662 (modest_easysetup_wizard_dialog_init):
2663 * src/maemo/modest-account-settings-dialog.c:
2664 (modest_account_settings_dialog_init):
2665 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2666 (modest_connection_specific_smtp_edit_window_init):
2667 * src/maemo/modest-connection-specific-smtp-window.c:
2668 (modest_connection_specific_smtp_window_init):
2669 * src/maemo/modest-signature-editor-dialog.c:
2670 (modest_signature_editor_dialog_init):
2671 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2672 prevent hibernation while any of these account settings dialogs are open.
2674 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2676 * src/maemo/Makefile.am:
2677 * src/maemo/modest-osso-state-saving.c:
2678 * src/maemo/modest-osso-state-saving.h: Added
2679 modest_osso_load_state() and modest_osso_save_state() though they do
2680 nothing now. They should iterate through all the open windows and load/save
2682 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2683 save state when closing.
2685 * src/maemo/modest-main-window.c:
2686 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2687 Add a notification handler for the HildonProgram::is-topmost property,
2688 so we can allow hibernation when the application goes into the background.
2689 But we still need to detect when the accounts setup windows are open so
2690 we can stop hibernation when they are open.
2691 To do this, I also added the main window the HildonProgram. This might have
2692 other side-effects/benefits, and should maybe be done for other windows.
2694 * src/maemo/modest-osso-autosave-callbacks.h:
2695 * src/maemo/modest-osso-autosave-callbacks.c:
2696 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2697 though it does not do anything yet, and we might never need this to do
2698 anything. For instance, we already save drafts.
2700 * src/maemo/modest-platform.c: (modest_platform_init):
2701 Specify the libosso auto-save callback.
2703 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2705 * src/maemo/modest-platform.c:
2706 (modest_platform_set_update_interval):
2707 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2708 aparently stays valid between application instances, so we can use this
2709 to remove and reset it later. According to a maemo-developers email from
2712 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2714 * configure.ac: Depend on libalarm for Maemo.
2716 * src/dbus_api/modest-dbus-api.h:
2717 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2718 (on_send_receive), (modest_dbus_req_handler):
2719 Handle a SEND_RECEIVE D-Bus method.
2721 * libmodest-dbus-client/libmodest-dbus-client.c:
2722 (libmodest_dbus_client_send_and_receive):
2723 * libmodest-dbus-client/libmodest-dbus-client.h:
2724 Add C convenience functions for calling the new D-Bus method.
2726 * src/modest-platform.h:
2727 * src/gnome/modest-platform.c:
2728 * src/maemo/modest-platform.c:
2729 Added modest_platform_set_update_interval(), which uses the
2730 alarmd API on Maemo.
2731 (modest_platform_init),
2732 Call modest_platform_set_update_interval(), using a hard-coded
2733 interval for now (until the global settings dialog is implemented),
2734 though I am not sure that this makes sense yet.
2736 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2738 * src/dbus_api/modest-dbus-callbacks.c:
2739 (modest_osso_cb_hw_state_handler):
2740 * src/dbus_api/modest-dbus-callbacks.h:
2741 * src/maemo/modest-platform.c: (modest_platform_init):
2742 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2743 in case this has some effect on the ability for Maemo to ping the
2746 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2748 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2749 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2750 warning. It is probably a logic error, but I need to fix the build.
2752 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2754 * src/modest-account-mgr.h:
2755 * src/modest-account-mgr.c:
2756 (modest_account_mgr_account_names): Add a gboolean enabled_only
2757 parameter, so we can get lists of onlt the enabled accounts.
2759 (modest_account_mgr_add_account),,
2760 (modest_account_mgr_account_with_display_name_exists):
2761 * src/maemo/modest-msg-edit-window.c: (get_transports):
2762 * src/modest-account-mgr-helpers.c:
2763 (modest_account_mgr_set_first_account_as_default):
2764 * src/modest-init.c: (init_default_account_maybe):
2765 * src/modest-tny-account-store.c: (get_accounts):
2766 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2767 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2768 * tests/check_account-mgr.c: (START_TEST):
2769 Provide the extra parameter, as appropriate.
2771 * src/widgets/modest-account-view.c: (update_account_view):
2772 Do not show disabled accounts (meaning that there is no way to
2773 enable/disable accounts in the UI (the feature is not in our UI
2774 specification), so we can use this internally only to mark unfinished
2775 or temporary account data.
2777 * src/maemo/easysetup/modest-easysetup-wizard.c:
2778 (create_account): Add boolean enable parameter, so we can specify FALSE
2779 to create the temporary account.
2780 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2781 (on_before_next): When finishing, when there is a temporary account, just
2783 Also, use a timeout to delay the showing of the dialog until gconf is likely
2784 to return correct information, due to a maemo gconf bug that is fixed in
2785 osso 1.1, but not yet in Bora.
2786 However, the dialog stays on screen after it is destroyed.
2788 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2789 for invalid data when cancelling. Use a hildon note instead of a dialog
2790 to complain about invalid data. Do not show the account-saved note if the
2791 account is disabled (a temporary account that will not really be saved for use
2794 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2796 * src/modest-account-mgr-helpers.h:
2797 * src/modest-account-mgr-helpers.c:
2798 Added modest_account_mgr_unset_default_account(),
2799 Added modest_account_mgr_set_first_account_as_default().
2801 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2802 If it was the default account, unset the default account name.
2804 * src/maemo/modest-account-view-window.c:
2805 (on_delete_button_clicked): If it was the default account,
2806 set the first remaining account as the default instead.
2808 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2809 a NULL account or a NULL default account, to prevent a crash. This should
2810 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2813 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2815 * src/widgets/modest-recpt-editor.c:
2816 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2817 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2818 TODO comment for this. This fixes the build.
2820 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2821 be the best place for it. This will in future update all auto-update accounts,
2822 rather than just the current/default account, when that gconf key exists.
2823 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2824 if there are no accounts, before calling do_send_receive().
2825 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2827 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2828 * src/maemo/modest-main-window-ui.h:
2829 * src/maemo/modest-main-window.c: (on_connection_changed),
2830 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2831 directly, becaue the signal handler does more.
2833 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2835 * src/modest-account-mgr-helpers.c:
2836 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2837 for the case that the account does not exist.
2839 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2840 (equivalent to the modest account name) rather than the tinymail account name
2841 (equivalent to the modest account title - human readable) to get the account data.
2842 Check for null account data to prevent the crash, and add a TODO comment saying that
2843 this needs fixing because it is using the server account name instead of the account name.
2845 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2847 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2848 * src/maemo/modest-account-settings-dialog.c: (show_error),
2850 Use hildon_note_new_information() for informative and error messages,
2851 which seems to be expected for Maemo applications (no documentation that I know of
2852 says this). I am surprised that there is no distinction between info and error
2855 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2857 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2858 it is easy to find where this is used.
2860 * src/maemo/easysetup/modest-easysetup-wizard.c:
2861 (create_page_welcome), (create_page_account_details),
2862 (create_page_user_details), (create_page_complete_easysetup),
2863 (create_page_custom_incoming), (create_page_custom_outgoing),
2864 (create_page_complete_custom):
2865 * src/maemo/modest-account-settings-dialog.c:
2866 (create_page_account_details), (create_page_user_details),
2867 (create_page_incoming), (create_page_outgoing):
2868 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2869 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2870 (modest_connection_specific_smtp_edit_window_init):
2871 * src/maemo/modest-connection-specific-smtp-window.c:
2872 (modest_connection_specific_smtp_window_init):
2873 * src/maemo/modest-signature-editor-dialog.c:
2874 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2875 and scrolling policy as per the Email Application Layout Guide, if I have
2878 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2880 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2881 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2882 which were empty, because these vfuncs have been removed from TnyAccountStore.
2883 This fixes the build.
2885 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2887 * src/maemo/modest-main-window.c:
2888 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2889 showing/hiding it. Added TODO because it probably should not be NULL.
2890 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2891 because unnecessary g_warnings() make degugging difficult.
2893 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2895 * src/maemo/modest-msg-edit-window.c:
2896 (modest_msg_edit_window_select_color),
2897 (modest_msg_edit_window_select_background_color): 2 const corrections and
2898 moving 2 #endifs before closing brackets, to fix the build.
2900 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2902 * src/maemo/easysetup/modest-easysetup-wizard.h:
2903 * src/maemo/easysetup/modest-easysetup-wizard.c:
2904 (modest_easysetup_wizard_dialog_finalize),
2905 (on_button_edit_advanced_settings), (create_page_complete_custom),
2906 (on_response), (create_account):
2907 Implement the Advanced Settings edit button, by saving the account information,
2908 for the Advanded Settings dialog to use directly from gconf, and removing it
2909 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2910 Bug #5533 in the projects.maemo.org bugzilla.
2912 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2914 * src/maemo/modest-msg-view-window.c:
2915 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2916 when opening a message window.
2918 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2920 * src/maemo/easysetup/modest-easysetup-wizard.c:
2921 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2924 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2925 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2926 gconf settings. I probably added more checks than necessary, but that is safer.
2928 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2929 variable to fix the build, but this seems to be used when it is still NULL.
2931 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2933 * src/modest-platform.h:
2934 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2935 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2936 * src/modest-main.c: Implement this function so we can avoid using
2937 maemo-specific API from cross-platform code.
2939 * src/modest-tny-account-store.c:
2940 (get_smtp_specific_transport_account_for_open_connection):
2941 * src/modest-ui-actions.c: (check_for_connection),
2942 (modest_ui_actions_on_item_not_found):
2943 Use modest_platform_connect_and_wait() and put #idefs around other
2944 maemo-specific code, because only maemo currently has a way to
2945 identify connection names.
2947 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2949 * src/modest-tny-account-store.h:
2950 * src/modest-tny-account-store.c:
2951 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2952 the connection-specific SMTP server settings in the configuration.
2954 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2956 * src/maemo/modest-main-window.c: (on_connection_changed),
2958 * src/modest-main.c: (main), (start_ui), (send_mail):
2959 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2960 that is what is intended.
2962 * src/modest-ui-actions.c: (action_send), (action_receive),
2963 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2964 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2965 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2966 SMTP server is used when it is specified.
2968 (modest_ui_actions_on_send_receive):
2969 Check that a connection is open before proceeding.
2970 Receive and then send, instead of vice-versa, as per the specification.
2972 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2974 * src/modest-mail-operation.c:
2975 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2976 though I guess it should be something other than NULL.
2978 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2980 * src/maemo/easysetup/modest-easysetup-wizard.c:
2981 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2982 combo twice, to avoid an g_warning and to make it visible again.
2983 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2984 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2985 (already intended) dereference when detaching, because we then recreate the menu.
2986 But I am not sure why the warning was happening, and it is possible that this is a memory
2989 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2991 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2992 and uri_parse_mailto() utility functions.
2993 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2995 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2997 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2999 * src/dbus_api/modest-dbus-api.h:
3000 * src/dbus_api/modest-dbus-callbacks.c:
3001 Use an idle callback to execute the modest code in the application's own thread.
3002 Remove the helloworld example method.
3003 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3004 parsed, and the open-message method is not implemented because this is not yet implemented in
3006 * libmodest-dbus-client/libmodest-dbus-client.c:
3007 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3008 (libmodest_dbus_client_open_message):
3009 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3011 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3012 body without crashing.
3014 * tests/dbus_api/Makefile.am:
3015 * tests/dbus_api/test_mail_to.c:
3016 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3018 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3020 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3021 Added file to fix the build. Sorry.
3023 * src/dbus_api/Makefile.am:
3024 * src/dbus_api/modest-dbus-api.h:
3025 * src/dbus_api/modest-dbus-callbacks.h:
3026 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3027 (modest_dbus_req_handler):
3028 Put constants in a separate header so it can be reused by the
3029 client library, without duplication
3031 * libmodest-dbus-client/Makefile.am:
3032 * libmodest-dbus-client/libmodest-dbus-client.c:
3033 (libmodest_dbus_client_call_helloworld),
3034 (libmodfest_dbus_client_send_mail),
3035 (libmodfest_dbus_client_mailto),
3036 (libmodfest_dbus_client_open_message):
3037 * libmodest-dbus-client/libmodest-dbus-client.h:
3038 (Partly) Implement a send_mail D-Bus method.
3040 * tests/dbus_api/Makefile.am:
3041 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3042 the send_email D-Bus method.
3044 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3048 * libmodest-dbus-client/Makefile.am:
3049 * libmodest-dbus-client/libmodest-dbus-client.c:
3050 * libmodest-dbus-client/libmodest-dbus-client.h:
3051 * tests/dbus_api/Makefile.am:
3052 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3053 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3055 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3057 * src/maemo/easysetup/modest-easysetup-wizard.c:
3058 (create_page_account_details):
3059 * src/maemo/modest-account-settings-dialog.c:
3060 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3061 widgets, because this might not be the default in future versions of the Maemo GTK+.
3062 However, I can not not get capitalization to work even in a simple test case.
3064 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3066 * src/maemo/easysetup/modest-easysetup-wizard.c:
3067 (create_page_custom_incoming), (create_page_custom_outgoing):
3068 * src/maemo/modest-account-settings-dialog.c:
3069 (create_page_account_details), (create_page_incoming),
3070 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3071 instead of using gtk_check_button_with_label(), so they are aligned like the other
3072 widgets, as per the UI spec.
3074 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3076 * src/maemo/easysetup/modest-easysetup-wizard.c:
3077 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3078 * src/widgets/modest-validating-entry.c:
3079 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3080 Modest prefix instead of an EasySetup prefix.
3082 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3084 * src/widgets/modest-validating-entry.h:
3085 * src/widgets/modest-validating-entry.c: (on_insert_text),
3086 Added easysetup_validating_entry_set_max_func(), used to set a callback
3087 to call when the max number of characters is reached. GtkEntry has a max-length
3088 already but is silent about it.
3090 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3091 (create_page_account_details), (create_page_user_details),
3093 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3094 (create_page_account_details), (create_page_user_details),
3095 (create_page_outgoing):
3096 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3097 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3098 the UI spec, when the user tries to enter more than the max number of characters.
3100 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3102 * src/maemo/easysetup/modest-easysetup-wizard.c:
3103 (create_page_user_details), (create_page_custom_incoming),
3104 (create_page_custom_outgoing):
3105 * src/maemo/modest-account-settings-dialog.c:
3106 (create_page_user_details), (create_page_incoming),
3107 (create_page_outgoing):
3108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3109 (modest_connection_specific_smtp_edit_window_init):
3110 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3111 not appropriate. Bad Maemo-specific defaults!.
3113 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3115 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3116 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3117 (modest_signature_editor_dialog_set_settings):
3118 Disable the label and textview when the checkbox is disabled, and use the
3119 specified (UI spec) default signature text.
3121 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3123 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3124 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3126 * src/modest-defs.h:
3127 * src/modest-account-mgr-helpers.h:
3128 * src/modest-account-mgr-helpers.c:
3129 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3131 * src/maemo/Makefile.am:
3132 * src/maemo/modest-signature-editor-dialog.c:
3133 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3136 * src/maemo/modest-account-settings-dialog.h:
3137 * src/maemo/modest-account-settings-dialog.c:
3138 (modest_account_settings_dialog_finalize), (on_button_signature),
3139 (save_configuration): Use the new dialog when the Edit button is pressed, and
3140 save the changes if necessary, as per the UI spec.
3142 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3144 * src/maemo/Makefile.am:
3145 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3146 based on maemo-develoers email from Dirk.
3148 * src/maemo/easysetup/modest-easysetup-wizard.c:
3149 (create_page_welcome), (create_page_account_details),
3150 (create_page_user_details), (create_page_complete_easysetup),
3151 (create_page_custom_incoming), (create_page_custom_outgoing),
3152 (create_page_complete_custom),
3153 (modest_easysetup_wizard_dialog_init):
3154 * src/maemo/modest-account-settings-dialog.c:
3155 (create_page_account_details), (create_page_user_details),
3156 (create_page_incoming), (create_page_outgoing),
3157 (modest_account_settings_dialog_init):
3158 * src/maemo/modest-connection-specific-smtp-window.c:
3159 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3161 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3163 * src/maemo/easysetup/modest-easysetup-wizard.c:
3164 (create_page_account_details), (create_page_custom_outgoing),
3165 (create_page_complete_custom):
3166 * src/maemo/modest-account-settings-dialog.c:
3167 (create_page_user_details), (create_page_incoming),
3168 (create_page_outgoing):
3169 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3170 (modest_connection_specific_smtp_edit_window_init):
3171 Use the correct (UI spec) port min/max, and use horizontal separators,
3174 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3176 * src/maemo/easysetup/modest-easysetup-wizard.c:
3177 (set_default_custom_servernames):
3178 * src/maemo/modest-account-settings-dialog.c:
3179 (create_page_incoming), (on_combo_outgoing_security_changed),
3180 (on_combo_incoming_security_changed), (create_page_outgoing),
3181 (modest_account_settings_dialog_set_account_name),
3182 (save_configuration):
3183 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3184 (on_combo_security_changed),
3185 (modest_connection_specific_smtp_edit_window_init),
3186 (modest_connection_specific_smtp_edit_window_set_connection),
3187 (modest_connection_specific_smtp_edit_window_get_settings):
3188 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3191 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3194 * src/maemo/easysetup/modest-easysetup-wizard.c:
3195 (create_page_custom_outgoing), (create_page_complete_custom):
3196 * src/maemo/modest-account-settings-dialog.c:
3197 (create_page_user_details), (create_page_outgoing):
3198 * src/maemo/modest-account-view-window.c: (button_box_new):
3199 Use changed logical IDs as per the most recent UI spec:
3200 mcen_bd_emailsetup_edit -> mcen_bd_edit
3201 mcen_bd_emailsetup_delete -> mcen_bd_delete
3202 mcen_bd_emailsetup_close -> mcen_bd_close
3204 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3208 * src/dbus_api/Makefile.am:
3209 * src/dbus_api/modest-dbus-callbacks.c:
3210 * src/dbus_api/modest-dbus-callbacks.h:
3211 * src/maemo/modest-platform.c: (modest_platform_init):
3212 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3214 * tests/Makefile.am:
3215 * tests/dbus_api/Makefile.am:
3216 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3218 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3220 * src/maemo/modest-account-settings-dialog.c:
3221 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3222 Removed unnecessary includes.
3224 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3226 * src/maemo/easysetup/modest-easysetup-wizard.c:
3227 * src/maemo/modest-account-settings-dialog.c:
3228 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3229 * src/widgets/Makefile.am:
3230 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3231 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3232 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3233 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3234 * src/widgets/modest-secureauth-combo-box.c:
3235 * src/widgets/modest-secureauth-combo-box.h:
3236 * src/widgets/modest-serversecurity-combo-box.c:
3237 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3238 made the GObject names more consistent with the rest of the Modest code.
3240 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/easysetup/Makefile.am:
3243 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3244 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3245 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3246 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3247 * src/maemo/easysetup/modest-easysetup-wizard.c:
3248 * src/maemo/easysetup/modest-validating-entry.c:
3249 * src/maemo/easysetup/modest-validating-entry.h:
3250 * src/maemo/modest-account-settings-dialog.c:
3251 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3252 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3253 widgets/ because they are used outside of easysetup too. After checking in,
3254 svn will allow me to rename them too.
3256 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3258 * src/gnome/modest-msg-edit-window.c:
3259 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3260 linker error, to fix the build on the GNOME platform.
3261 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3262 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3263 ifdefed out to avoid a warning.
3265 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3267 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3268 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3269 some alternative for GTK+ 2.6.
3271 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3273 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3275 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3276 specified for EmailAccountsDialog in UI spec.
3278 * src/maemo/easysetup/modest-easysetup-wizard.c:
3279 * src/maemo/easysetup/modest-easysetup-wizard.h:
3280 * src/maemo/modest-account-settings-dialog.c:
3281 * src/maemo/modest-account-settings-dialog.h:
3282 Reuse a member window widget for the connection-specific SMTP server accounts,
3283 so we can tell it to create/save the accounts only if we actually save changes.
3285 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3286 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3287 (modest_connection_specific_smtp_edit_window_get_settings):
3288 Return a struct instance for temporarily remembering the entered data.
3290 * src/maemo/modest-connection-specific-smtp-window.h:
3291 * src/maemo/modest-connection-specific-smtp-window.c:
3292 (modest_connection_specific_smtp_window_finalize),
3293 (modest_connection_specific_smtp_window_fill_with_connections),
3295 (modest_connection_specific_smtp_window_save_server_accounts),
3296 (update_model_server_names): Do not actually save data until asked,
3297 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3299 (on_selection_changed),
3300 (modest_connection_specific_smtp_window_init): Disable the edit
3301 button when nothing is selected.
3303 * src/modest-account-mgr-helpers.c:
3304 * src/modest-account-mgr-helpers.h:
3305 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3308 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3310 * src/modest-account-mgr-helpers.h:
3311 * src/modest-account-mgr-helpers.c:
3312 (modest_account_mgr_get_unused_account_name),
3313 (modest_account_mgr_get_unused_account_display_name): Added these
3314 utility functions, to avoid code duplication.
3316 * src/maemo/easysetup/modest-easysetup-wizard.c:
3317 (create_page_account_details), (create_account):
3318 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3319 (on_combo_security_changed),
3320 (modest_connection_specific_smtp_edit_window_init),
3321 (modest_connection_specific_smtp_edit_window_save_settings):
3322 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3323 * src/maemo/modest-connection-specific-smtp-window.c:
3324 (modest_connection_specific_smtp_window_finalize),
3325 (modest_connection_specific_smtp_window_fill_with_connections),
3326 (on_button_edit), (modest_connection_specific_smtp_window_init):
3327 * src/maemo/modest-connection-specific-smtp-window.h:
3328 Implementing saving of connection-specific server accounts.
3330 But I need to refactor this so we can save the data for each
3331 possible connection-specific account and only actually create the server accounts
3332 when the easysetup finished, or the OK button is pressed on the account settings
3335 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3337 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3338 (on_combo_security_changed):
3339 (modest_connection_specific_smtp_edit_window_init):
3340 Auto-fill the port number as in the account settings.
3342 (modest_connection_specific_smtp_edit_window_set_connection):
3343 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3344 * src/maemo/modest-connection-specific-smtp-window.c:
3345 (fill_with_connections), (on_button_edit),
3346 (modest_connection_specific_smtp_window_init):
3347 Turn the edit window into a dialog to simplify the code, and
3348 set a WM hint as in a GtkDialog, because only a popup can be on top of
3349 another window in Maemo, and popups usually have no WM decoration.
3351 * src/modest-defs.h:
3352 * src/modest-account-mgr-helpers.c:
3353 (modest_account_mgr_set_connection_specific_smtp),
3354 (modest_account_mgr_remove_connection_specific_smtp),
3355 (modest_account_mgr_get_connection_specific_smtp):
3356 * src/modest-account-mgr-helpers.h: Some functions to write the
3357 connection-specific SMTP server information. Not yet used.
3360 * src/widgets/modest-folder-view.c: (text_cell_data):
3361 Fix a warning about an uninitialized variable.
3362 (on_configuration_key_changed): Put an #ifdef around the use
3363 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3365 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3367 * src/maemo/modest-account-settings-dialog.h:
3368 * src/maemo/modest-account-settings-dialog.c:
3369 Added connect_for_modified() utility function to mark the new modified boolean.
3371 (create_page_account_details), (create_page_user_details),
3372 (create_page_incoming), (create_page_outgoing), (on_response),
3373 (modest_account_settings_dialog_init),
3374 (modest_account_settings_dialog_set_account_name):
3375 Only warn about unsaved changes when there are actually unsaved changes.
3377 * src/modest-account-mgr-helpers.c:
3378 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3379 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3380 to get the data from there in future.
3382 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3384 * src/modest-defs.h:
3386 * src/modest-account-mgr-helpers.h:
3387 * src/modest-account-mgr-helpers.c:
3388 Store the security account setting in a single conf key instead of using
3389 the options list, so that the list is left for just the to-be-removed camel hack,
3390 and because gconf_client_set_list() is failing for some reason.
3392 * src/modest-account-mgr.c:
3393 (modest_account_mgr_add_server_account):
3394 * src/maemo/modest-account-settings-dialog.c:
3395 (modest_account_settings_dialog_set_account_name),
3396 (save_configuration): Use the renamed functions.
3399 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3401 * src/widgets/Makefile.am:
3402 * src/widgets/modest-limit-retrieve-combo-box.c:
3403 * src/widgets/modest-limit-retrieve-combo-box.h:
3404 * src/widgets/modest-retrieve-combo-box.c:
3405 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3406 the account settings dialog.
3408 * src/modest-defs.h:
3409 * src/modest-account-mgr-helpers.h:
3410 * src/modest-account-mgr-helpers.c:
3411 (modest_server_account_get_option_secure_auth),
3412 (modest_server_account_set_option_secure_auth):
3413 * src/modest-account-mgr.c:
3414 (modest_account_mgr_add_server_account):
3415 Use the existing AUTH_MECH conf key for the secure-auth setting,
3416 instead of putting it in the list options, because this was actually used already.
3418 * src/maemo/modest-account-settings-dialog.c:
3419 (create_page_account_details),
3420 (modest_account_settings_dialog_set_account_name),
3421 (save_configuration):
3422 * src/maemo/modest-account-settings-dialog.h:
3423 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3424 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3426 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3428 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3429 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3430 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3432 * src/modest-defs.h:
3433 * src/maemo/modest-account-settings-dialog.c:
3434 (create_page_incoming), (on_combo_outgoing_security_changed),
3435 (on_combo_incoming_security_changed), (create_page_outgoing),
3436 (modest_account_settings_dialog_set_account_name),
3437 (save_configuration): Load/Save the port number, and change it when the
3438 security combo changes, to suitable defaults.
3440 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3442 * src/modest-account-mgr.c:
3443 (modest_account_mgr_add_server_account): Set the security and secure-auth
3444 options, and add a comment saying that the other camel-specific options should be
3447 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3449 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3451 * src/modest-tny-account-store.c: (account_list_free),
3452 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3453 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3456 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3458 * src/modest-protocol-info.c:
3459 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3460 is required by our UI spec. Maybe something in our implementation will use this eventually.
3461 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3462 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3463 instead of the previous 0 placeholder.
3465 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3466 secure-auth settings.
3467 * src/modest-account-mgr-helpers.h:
3468 * src/modest-account-mgr-helpers.c:
3469 (modest_server_account_data_get_option_secure_auth),
3470 (modest_server_account_set_option_secure_auth),
3471 (modest_server_account_data_get_option_security),
3472 (modest_server_account_set_option_security): Added this API for getting and setting the security
3473 and secure-auth settings.
3475 * src/maemo/modest-account-settings-dialog.h:
3476 * src/maemo/modest-account-settings-dialog.c:
3477 (modest_account_settings_dialog_finalize), (check_data),
3478 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3479 about changing titles.
3480 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3481 (save_configuration): Save the security and secure-auth settings.
3483 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3484 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3486 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3488 * src/modest-defs.h:
3489 * src/modest-account-mgr.c:
3490 (modest_account_mgr_add_server_account):
3491 Added and used defines for the options key and value pair strings,
3492 that are used so far, though they do not seem to correspond to anything in our
3493 UI specs or ModestProtocol enum.
3495 * src/modest-account-mgr-helpers.h:
3496 * src/modest-account-mgr-helpers.c:
3497 (compare_option_strings_for_name),
3498 (modest_server_account_data_get_option_value),
3499 (modest_server_account_data_get_option_bool),
3500 (modest_account_mgr_get_server_account_option):
3501 Added helper functions for parsing the options GSList.
3503 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3505 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3506 display name is based on the supplied account name.
3507 * src/modest-account-mgr.c:
3508 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3509 with an inefficient, but good-enough, implementation.
3511 * src/maemo/easysetup/modest-easysetup-wizard.c:
3512 (create_page_account_details), (on_before_next), (create_account):
3513 Check for existing display names rather than (non-user-visible) account names, and just
3514 create and set a unique account name at the end.
3516 * src/maemo/modest-account-settings-dialog.c:
3517 (modest_account_settings_dialog_init),
3518 (modest_account_settings_dialog_set_account_name),
3519 (create_page_incoming): Show the display name, instead of the account name.
3520 (on_response): Do some (not all) extra checks, as in the UI spec.
3521 (save_configuration): Save the display name if it was changed.
3523 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3525 * po/en_GB.po: Added needed logical ID and translation.
3526 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3527 (init_view): Made the is-default column clicking work.
3529 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3532 * src/maemo/easysetup/Makefile.am:
3533 * src/maemo/easysetup/modest-easysetup-wizard.c:
3534 (modest_easysetup_wizard_dialog_init):
3535 * src/maemo/easysetup/provider-data-test.keyfile:
3536 * src/maemo/easysetup/provider-data.keyfile:
3537 Moved the provider data file to the new modest-providers-data package and used it from there.
3539 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3541 * src/modest-local-folder-info.c:
3542 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3543 N_() was already used on the static strings, but this just marks it for translation without
3544 using the translation.
3546 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3548 * src/maemo/modest-account-settings-dialog.c:
3549 (create_page_incoming),
3550 (modest_account_settings_dialog_set_account_name):
3551 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3552 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3553 I will do this if nobody else gets there first.
3555 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3557 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3558 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3559 save the security stuff.
3561 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3563 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3564 Set the email address and user fullname, which I now see must be
3567 * src/maemo/modest-account-settings-dialog.h:
3568 * src/maemo/modest-account-settings-dialog.c:
3570 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3571 leave-on-server and authentication.
3572 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3575 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3578 * src/maemo/modest-account-settings-dialog.c:
3579 * src/maemo/modest-account-settings-dialog.h:
3580 Most (but not all) of the widgets are now present as specified by the UI spec.
3581 No changes are yet saved, and some details are not properly shown yet.
3583 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3585 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3587 * src/maemo/Makefile.am:
3588 * src/maemo/modest-account-settings-dialog.c:
3589 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3590 an existing account. Doesn't do much yet.
3592 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3593 Open the accounts settings dialog when Edit is clicked.
3595 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3597 * src/maemo/easysetup/Makefile.am:
3598 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3600 * src/maemo/easysetup/modest-easysetup-wizard.c:
3601 (modest_easysetup_wizard_dialog_init):
3602 Try to get the source directory from the build system,
3603 instead of hard-coding "./" into the source code, when opening our local
3604 copies of the configuration files.
3605 But this still fails when opening the wizard from the Accounts window,
3606 maybe because the working directory seems to change at runtime.
3607 So the wizard will fail the second time unless you copy the files into their
3608 proper locations - see the stdout warnings for the paths.
3610 (create_page_account_details),(on_before_next):
3611 Check for existing non-server accounts instead of server accounts,
3612 so the default account name is useful again, and to prevent trying to
3615 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3616 Show the wizard when New is clicked.
3618 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3619 (init_view): Show the column headers, and show the columns that are
3620 specified in the UI specs. However, something in Maemo's GTK+ prevents
3621 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3622 change the default account. This is despite unsetting the special properties.
3624 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3626 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3627 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3628 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3629 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3630 to make that clearer.
3631 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3633 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3635 * src/maemo/modest-account-view-window.c:
3636 (modest_account_view_window_init),
3637 (modest_account_view_window_new):
3638 Use the same buttons as specified in the
3639 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3640 the existing widgets, which never had a chance of working.
3641 Put the ModestAccountView treeview in a scrolled window.
3642 Do not repeat the initialization in both _init() and _new().
3644 * src/widgets/modest-account-view.c: (update_account_view):
3645 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3646 this widget and window shows no accounts.
3648 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3650 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3652 * src/maemo/easysetup/modest-easysetup-wizard.c:
3653 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3654 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3655 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3658 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3659 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3660 accounts exist yet, as in the UI spec.
3662 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3664 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3666 * src/maemo/Makefile.am:
3667 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3668 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3669 New window for editing connection-specific smtp details.
3670 Not fully implemented.
3672 * src/maemo/modest-connection-specific-smtp-window.c:
3673 (modest_connection_specific_smtp_window_finalize) :
3674 unref the tree model.
3675 (on_button_edit): Show the edit window.
3677 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3679 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3682 * src/maemo/Makefile.am:
3683 * src/maemo/modest-connection-specific-smtp-window.c:
3684 * src/maemo/modest-connection-specific-smtp-window.h:
3685 New window for showing the list of connections, for connection-specific
3686 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3687 * src/maemo/easysetup/modest-easysetup-wizard.c:
3688 (create_page_custom_outgoing): Show the new window when the button is clicked.
3690 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3692 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3693 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3694 * src/maemo/modest-msg-edit-window.c:
3695 (modest_msg_edit_window_insert_image):
3696 * src/modest-conf.c: (modest_conf_key_escape):
3697 * src/modest-mail-operation.c:
3698 (modest_mail_operation_send_new_mail):
3699 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3700 (modest_ui_actions_on_new_account):
3701 * src/widgets/modest-attachment-view.c: (update_filename_request):
3702 * src/widgets/modest-mail-header-view.c:
3703 Corrected warnings that were breaking the build, by commenting out unused variables,
3704 and a function, and by including a header.
3706 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3708 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3709 so we can #ifdef around platform-specific code when necessary.
3710 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3711 to allow this to build for the GNOME platform too.
3713 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3715 * src/maemo/easysetup/modest-easysetup-wizard.c:
3716 Added util_increment_name() and used it in create_page_account_details()
3717 to make sure that the default account name is always a new name.
3719 (modest_easysetup_wizard_dialog_init),
3720 (set_default_custom_servernames): Some minor memory management fixes.
3722 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3726 * src/modest-runtime.c: (init_i18n): Restored the translation
3727 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3728 are defined in config.h, and the translations are installed.
3730 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3731 is defined for translation.
3733 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3735 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3737 * src/maemo/easysetup/modest-easysetup-wizard.c:
3738 (modest_easysetup_wizard_dialog_init):
3739 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3740 Use realistic paths (though they should use $prefix generically) to the
3741 mcc_mapping and provider-data.keyfile files which might work when they
3742 are installed by the future version of the operator-wizard package,
3743 and then fallback to paths in our source code, with an explanatory
3746 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3750 * src/maemo/Makefile.am:
3751 * src/maemo/easysetup/: Added files from the previously-exernal
3752 osso-modest-easysetup.
3753 * src/maemo/modest-main-window-ui.h:
3754 * src/modest-ui-actions.c:
3755 * src/modest-ui-actions.h:
3756 Added modest_ui_actions_on_new_account() as a signal handler for the
3757 New Account menu item. It shows the easysetup wizard.
3758 * po/en_GB.po: Added additional needed logical IDs and translations.