1 2007-07-09 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c:
4 (modest_tny_account_store_instance_init),
5 (modest_tny_account_store_finalize),
6 (on_account_settings_hide), (on_idle_wrong_password):
7 Use a GHashTable to ensure that we only show one account settings
8 dialog per modest account. This avoids us having a dialog open for
9 both the store and transport accounts, or due to repeated get_password()
10 calls that shouldn't happen anyway.
12 2007-07-09 Murray Cumming <murrayc@murrayc.com>
14 * src/maemo/modest-maemo-utils.c: (on_hide),
15 (modest_maemo_show_dialog_and_forget): Handle the response, because
16 the window is not even hidden by default.
18 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
19 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
20 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
21 which seems to prevent some modality problems.
23 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
24 Ignore user cancellation errors.
26 * src/modest-account-mgr-helpers.h:
27 * src/modest-account-mgr-helpers.c:
28 Added modest_server_account_get_password() and
29 modest_server_account_get_has_password() to avoid direct use of
32 * src/maemo/modest-account-settings-dialog.h:
33 * src/maemo/modest-account-settings-dialog.c:
34 (modest_account_settings_dialog_init): Store the notebook so we can
36 Added modest_account_settings_dialog_switch_to_user_info().
38 * src/modest-tny-account-store.c:
39 (get_password): When the password in the account settings is wrong (we think),
40 show the relevant page of the account settings dialog, in the mainloop.
41 However, we currently get many of these at once because cancel does not
43 (forget_password): Do not forget the password
44 from the account settings, because this causes side-effects when
45 tinymail seems to call it at strange time, maybe because of how we
46 are cancelling get_password().
47 (modest_tny_account_store_alert): Ignore user cancellations.
49 2007-07-09 Murray Cumming <murrayc@murrayc.com>
51 * src/maemo/modest-maemo-utils.h:
52 * src/maemo/modest-maemo-utils.c:
53 Added modest_maemo_show_information_note_and_forget() for use instead of
54 gtk_dialog_run() when the response is not needed, to avoid an extra
55 mainloop which could cause a hang.
57 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
58 Use the logical IDs for the error message, though they are not
59 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
60 because gtk_dialog_run() caused a hang here (the window did not close).
61 This fixes projects.maemo.org bug NB#62646.
63 2007-07-09 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-account-mgr-helpers.h:
66 * src/modest-account-mgr-helpers.c:
67 Added modest_account_mgr_get_store_protocol().
69 * src/maemo/modest-account-view-window.c:
70 (on_delete_button_clicked): Show different warning text depending on
71 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
72 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
75 2007-07-09 Murray Cumming <murrayc@murrayc.com>
77 * src/maemo/modest-msg-edit-window.c:
78 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
79 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
81 2007-07-07 Armin Burgmeier <armin@openismus.com>
83 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
84 ckdg_ib_maximum_characters_reached from correct package.
86 * src/modest-ui-actions.c: Show an error message when a folder could
87 not be created. Tinymail does not give us specific error codes about
88 what has gone wrong, so we assume that a folder with that name
89 already exists, though there might be other reasons.
91 2007-07-06 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
94 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
95 give a more exact error message that can be partly translated.
97 2007-07-05 Murray Cumming <murrayc@murrayc.com>
99 * src/maemo/modest-address-book.c:
100 (select_email_addrs_for_contact): Specify a default window size for the
101 select-email-address dialog, so that it is probably big enough for the
102 title. This should fix projects.maemo.org bug NB#62277.
104 2007-07-05 Murray Cumming <murrayc@murrayc.com>
106 * src/maemo/easysetup/modest-easysetup-wizard.c:
107 (create_page_complete_easysetup): Use
108 gtk_widget_set_size() request to ensure that the text wraps
111 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
113 * src/maemo/easysetup/modest-easysetup-wizard.c:
114 (on_entry_invalid_character), (create_page_account_details),
115 (create_page_user_details):
116 Use new API of ModestValidatingEntry. But for some reason the banner is
117 not shown. I will have to investigate that further.
119 * src/widgets/modest-validating-entry.c: (on_insert_text),
120 (modest_validating_entry_set_func):
121 * src/widgets/modest-validating-entry.h:
122 Added a new callback function to be able to react to prevented
123 characters whitespaces to e.g show a banner.
125 2007-07-05 Armin Burgmeier <armin@openismus.com>
127 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
128 notification of HildonNumberEditor instead of remembering the port
129 number. Thanks to Johannes for pointing this out.
131 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
133 * src/maemo/easysetup/modest-easysetup-wizard.c:
134 Check if there are any user changes before showing a confirmation
135 dialog (projects.maemo.org NB#60946)
137 2007-07-05 Armin Burgmeier <armin@openismus.com>
139 * src/maemo/modest-account-settings-dialog.c: Remember custom port
140 number at the beginning of the dialog and set the modified flag at the
141 end if the port number has changed. This is necessary because
142 HildonNumberEditor does not support notification when the value has
145 2007-07-05 Murray Cumming <murrayc@murrayc.com>
147 * src/modest-ui-actions.c:
148 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
149 a connection before asking anything else. Correct the check for the destination
150 folder so that it succeeds when online.
151 This fixed projects.maemo.org bug NB#61645.
153 2007-07-05 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
156 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
157 to fix projects.maemo.org bug NB#62439.
159 2007-07-05 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-tny-account.c: (on_connection_status_changed):
162 Really do not use tny_device_force_offline() here. See the previous comment.
164 2007-07-04 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-tny-account.c: (on_connection_status_changed):
167 Do not use tny_device_force_offline() when tinymail says that something
168 went wrong with the connection. It seems to report this unnecessarily.
170 2007-07-04 Murray Cumming <murrayc@murrayc.com>
172 * src/maemo/modest-connection-specific-smtp-window.c:
173 (modest_connection_specific_smtp_window_init):
174 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
175 does not seem to have any effect in osso 1.1 (though it works in
176 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
178 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
180 * src/maemo/modest-connection-specific-smtp-window.c:
181 Fix UI specification problems with projects.meamo.org NB#60479
183 2007-07-04 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
186 clue when this has failed, because the error dialog is not always shown
187 (at least in earlier version).
189 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
190 GError message, because the generic error dialog is not helpful.
192 'This message is not currently available (can't let a new connection go online)'
193 when trying to open an IMAP message.
195 (_modest_ui_actions_open): Offer a connection when some messages would
196 have to be downloaded and we are offline.
198 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
200 * src/widgets/modest-folder-view.c:
201 Don't check for MERGE type anymore as we use the correct type
203 NOTE: For the last two changes you need to update your tinymail copy
204 because of API changes!
206 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
208 * src/modest-tny-local-folders-account.c:
209 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
210 (see projects.maemo.org NB#61580)
212 2007-07-04 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-tny-account.c: (on_connection_status_changed):
215 Commented out the call to modest_platform_connect_and_wait() because this
216 seems to always hang, and I would like to know if this is the only thing
217 that causes a hang when showing the connection dialog.
218 It is not very useful anyway.
220 2007-07-04 Murray Cumming <murrayc@murrayc.com>
222 * src/maemo/modest-msg-view-window.c:
223 (modest_msg_view_window_select_next_message):
225 * src/modest-platform.h:
226 * src/maemo/modest-platform.c:
227 Added modest_platform_connect_and_wait(), which calls
228 tny_maemo_conic_device_connect() always in the main thread, by calling it
229 in an idle handler and waiting for the idle handler to run. It should be
230 in the main thread because it uses GTK+ UI code. It just returns TRUE
231 if the device is already online.
233 There is some nasty code to ensure that subsequent calls to
234 modest_platform_connect_and_wait() just wait for the first one to finish,
235 by checking repeatedly in another idle handler. This is necessary,
236 because other threads (or even the main thread, via another idle handler)
237 can call modest_platform_connect_and_wait() while
238 modest_platform_connect_and_wait() is running.
240 (modest_platform_connect_and_wait_if_network_account),
241 (modest_platform_connect_and_wait_if_network_folderstore):
242 Convenience functions that calls modest_platform_connect_and_wait() if
243 the account or folder might want network access.
245 * src/modest-mail-operation.c:
246 (modest_mail_operation_update_account):
247 * src/modest-ui-actions.c: (download_uncached_messages),
248 (modest_ui_actions_on_rename_folder), (delete_folder),
249 (modest_ui_actions_on_main_window_move_to),
250 (modest_ui_actions_on_msg_view_window_move_to):
251 * src/widgets/modest-folder-view.c:
252 (drag_and_drop_from_folder_view):
253 Offer a connection if we are offline.
255 * src/modest-tny-account.c: (on_connection_status_changed):
256 Document this as only handling errors during network operations in progress,
257 and replace the idle code with a simple call to
258 modest_platform_connect_and_wait(), which does this instead.
260 2007-07-03 Murray Cumming <murrayc@murrayc.com>
262 * src/modest-tny-account.c:
263 (modest_tny_account_get_special_folder): (util_on_idle),
264 Handle the GError so we can see when tny_folder_store_get_folders()
265 fails, as it currently does while something else is connecting.
267 Added util_run_in_main_thread_and_wait()
268 which uses an idlen handler and mainloop to ensure that the function
269 is called in the main thread.
270 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
271 to make sure that we call attempt the connection in the mainloop only,
272 which might solve some hangs.
274 2007-07-03 Murray Cumming <murrayc@murrayc.com>
276 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
277 be found by their display name. This is never useful.
278 * src/modest-tny-account-store.c: (on_account_removed): Find the account
279 by its ID, instead of trying to use its ID as its display name.
281 * src/modest-tny-account-store.h:
282 * src/modest-tny-account.c:
283 (modest_tny_account_get_special_folder): Add a g_warning() when
284 tny_folder_store_get_folders() returns an empty list for the maildir.
286 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
287 Add a g_warning() when this returns NULL, because that it not allowed
290 2007-07-02 Armin Burgmeier <armin@openismus.com>
292 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
293 note when trying to cancel the wizard. This fixes projects.maemo.org
296 2007-07-02 Murray Cumming <murrayc@murrayc.com>
298 * src/modest-tny-account.h:
299 * src/modest-tny-account.c:
300 (modest_tny_account_new_from_server_account),
301 (modest_tny_account_new_from_server_account_name),
302 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
303 because this must now be set before setting the proto. This is usd in
304 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
305 warning in camel_session_get_service() caused by
306 tny_camel_transport_account_prepare().
308 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
311 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
313 * src/maemo/modest-connection-specific-smtp-edit-window.c:
315 (modest_connection_specific_smtp_edit_window_init):
317 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
320 2007-06-29 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-tny-account.c:
323 (modest_tny_account_new_from_server_account):
324 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
325 now uses to request a connection when it needs one, and which it uses
326 to tell us that something is wrong with the connection, so we can force
327 the accounts offline to prevent further problems.
330 * src/modest-init.c: (init_default_settings):
331 * src/modest-mail-operation.c:
332 (modest_mail_operation_update_account):
333 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
334 This should not be necessary anymore. Do not set the conf key that
335 determined this (it was always TRUE and not set anywhere else).
337 * src/modest-ui-actions.h: Remove unused and unimplemented
338 modest_ui_actions_on_online_toggle_toggled().
340 2007-06-29 Murray Cumming <murrayc@murrayc.com
342 * src/maemo/modest-main-window.c: (connect_signals):
343 Don't connect to delete_event twice. Maybe this was harmless.
345 2007-06-29 Murray Cumming <murrayc@murrayc.com
347 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
348 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
349 Debug output to give some more clue when a folder move is not allowed.
351 2007-06-28 Murray Cumming <murrayc@murrayc.com
353 * src/modest-tny-account.c: (on_modest_file_system_info),
354 (modest_tny_account_get_mmc_account_name):
355 Always call the callback, without checking whether the name has changed.
356 * src/widgets/modest-folder-view.c: (strings_are_equal),
357 (on_model_foreach_set_name), (on_get_mmc_account_name),
358 (text_cell_data): Compare the name here, and use the name from
359 the account rather than from the
360 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
361 if the name was changed after the account was added to the model.
362 That's a tinymail bug but not one that I want to fix now.
364 This finally fixes projects.maemo.org bug NB#59301.
366 2007-06-27 Armin Burgmeier <armin@openismus.com>
368 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
371 2007-06-27 Murray Cumming <murrayc@murrayc.com
373 * src/modest-tny-account.h:
374 * src/modest-tny-account.c:
375 Added modest_tny_account_get_mmc_account_name(), to set the memory
376 card name asynchronously for the given account and then notify.
377 (modest_tny_account_new_for_local_folders): Use this new function instead
378 of using hildon_file_system_info_async_new() directly.
380 * src/widgets/modest-folder-view.c: (text_cell_data):
381 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
382 gtk_tree_model_row_changed() when it is available.
384 This should fix projects.maemo.org bug NB#59301.
386 2007-06-27 Murray Cumming <murrayc@murrayc.com
388 * src/modest-mail-operation.c: (update_account_thread),
389 (get_msgs_full_thread): Fix typo failures in the revert
392 2007-06-27 Murray Cumming <murrayc@murrayc.com
394 * src/maemo/modest-maemo-global-settings-dialog.c:
395 (idle_select_default_focus):
396 * src/modest-mail-operation.c: (idle_notify_progress),
397 (idle_notify_progress_once), (set_last_updated_idle),
398 (update_account_thread), (get_msgs_full_thread):
399 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
400 * src/widgets/modest-header-view.c:
401 (idle_notify_headers_count_changed_destroy),
402 (idle_notify_headers_count_changed):
403 Reverted the additions of gdk_threads_enter/leave(), in case this
404 helps with a startup hang on the device.
406 2007-06-26 Armin Burgmeier <armin@openismus.com>
408 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
409 for supported secure authentication methods from server by
410 gtk_dialog_run(), saving CPU time and a potential race condition.
412 2007-06-26 Armin Burgmeier <armin@openismus.com>
414 * src/maemo/modest-maemo-utils.h:
415 * src/maemo/modest-maemo-utils.c: Added a
416 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
417 only error code to tell the calling code when the user canceled the
420 * src/maemo/modest-account-settings-dialog.h:
421 * src/maemo/modest-account-settings-dialog.c:
422 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
423 message if the retrieval of secure authentication methods was canceled
424 by the user. Perform the check before saving anything to configuration
425 to not end up with half-committed configuration changes, do not show
426 a "Saving to configuration failed" note when authentication methods
427 could not be retrieved.
429 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
432 2007-06-26 Murray Cumming <murrayc@murrayc.com>
434 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
435 Only return the first level of folders under accounts, because the
436 osso-global-search UI spec doesn't want the rest.
437 This fixed projects.maemo.org bug NB#61811.
439 2007-06-26 Murray Cumming <murrayc@murrayc.com>
441 * src/modest-tny-account-store.c:
442 * src/modest-tny-account-store.h:
443 Added modest_tny_account_is_memory_card_account().
444 * src/maemo/modest-main-window.c: (create_details_widget):
445 Show the same information items for the memory card as we show for the
446 local-folders, to fix projects.maemo.org bug NB#59307.
448 2007-06-26 Murray Cumming <murrayc@murrayc.com>
450 * src/modest-tny-account-store.c: (get_password):
451 Added some checks for NULL to maybe prevent crashes, though I think
452 it was Philip's last commit that actually prevented the crash here
453 when creating a first new account.
454 But the new account is still not usable (no messages are shown)
455 until a restart of the application.
457 2007-06-26 Murray Cumming <murrayc@murrayc.com>
459 * src/maemo/modest-maemo-global-settings-dialog.c:
460 (idle_select_default_focus):
461 * src/modest-mail-operation.c: (idle_notify_progress),
462 (idle_notify_progress_once), (idle_notify_update_account_queue),
463 (set_last_updated_idle), (update_account_thread),
464 (notify_get_msgs_full), (get_msgs_full_destroyer),
465 (get_msgs_full_thread):
466 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
467 * src/widgets/modest-header-view.c:
468 (idle_notify_headers_count_changed_destroy),
469 (idle_notify_headers_count_changed):
470 Use gdk_threads_enter() and gdk_threads_enter_leave() in
471 all idle handlers, because some other thread could be blocking
472 the GDK lock, so that it can do GUI stuff.
474 2007-06-26 Murray Cumming <murrayc@murrayc.com>
476 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
477 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
478 (on_idle_send_receive), (on_idle_open_default_inbox):
479 * src/maemo/modest-msg-edit-window.c:
480 (modest_msg_edit_window_attach_file_noninteractive):
481 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
482 to prevent a hang. I don't quite understand why these are necessary,
483 beause we should already be in the main loop. I guess something outside
484 of the main loop is taking the lock.
486 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
487 we are really using URIs, and use files that are more likely to exist.
489 2007-06-26 Murray Cumming <murrayc@murrayc.com>
491 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
492 necessary because configure.ac now defines different variables.
494 2007-06-26 Murray Cumming <murrayc@murrayc.com>
496 * libmodest-dbus-client/libmodest-dbus-client.c:
497 * libmodest-dbus-client/libmodest-dbus-client.h:
498 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
499 libmodest_dbus_client_compose_mail() is what things actually use.
501 * src/dbus_api/modest-dbus-api.h:
502 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
503 * tests/dbus_api/Makefile.am:
504 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
507 2007-06-26 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-init.c: (modest_init_local_folders):
510 For memory-card (or other non local-folders) maildir accounts,
511 always create an Archive folder, so that there is somewhere to put
512 messages. This should be less confusing, because the user does not need
513 to guess that the need to create a folder.
515 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
517 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
518 Fixed icon size by using (50, 50) which is the same as defined by
521 2007-06-25 Armin Burgmeier <armin@openismus.com>
523 * src/widgets/modest-window-mgr.c:
525 * configure.ac: Correctly recognize hildon-notify presence and fixed
526 the build without it being installed.
528 2007-06-25 Murray Cumming <murrayc@murrayc.com>
530 * libmodest-dbus-client/libmodest-dbus-client.c:
531 (libmodest_dbus_client_search): Fix the build. Sorry.
532 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
533 (reply_forward_cb): Initialize variables to fix the build.
535 * src/modest-tny-account-store.c:
536 (modest_tny_account_store_get_tny_account_by): Fix the account URI
537 comparison (a silly typo) so that email search results can be opened
538 when there are more than one account.
540 2007-06-25 Murray Cumming <murrayc@murrayc.com>
542 * libmodest-dbus-client/libmodest-dbus-client.c:
543 (libmodest_dbus_client_search),
544 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
545 instead of 1 second, because the search gets folders and messages from
546 the server, which can take a long time. When it times out,
547 osso-global-search will report no results.
549 We need to specify whether we should search only cached information
550 (maybe with a user preference), and the osso-email-search-plugin
551 API should really be improved to allow that option, and to allow results
552 to be delivered asynchronously in batches.
554 2007-06-25 Murray Cumming <murrayc@murrayc.com>
556 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
557 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
558 GTK_ICON_SIZE_DIALOG is probably the wrong size.
560 2007-06-25 Murray Cumming <murrayc@murrayc.com>
562 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
563 that is an empty string. D-Bus seems to give us these instead of NULL.
565 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
567 * src/dbus_api/modest-dbus-callbacks.c:
568 * src/maemo/easysetup/modest-easysetup-wizard.h:
569 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
570 * src/maemo/modest-connection-specific-smtp-edit-window.c:
571 (modest_connection_specific_smtp_edit_window_init):
572 * src/maemo/modest-maemo-global-settings-dialog.c:
574 * src/maemo/modest-maemo-utils.c:
575 (modest_maemo_utils_setup_images_filechooser):
576 * src/maemo/modest-main-window.c: (create_details_widget):
577 * src/maemo/modest-msg-edit-window.c:
578 (modest_msg_edit_window_attach_file_noninteractive),
579 (modest_msg_edit_window_color_button_change),
580 (modest_msg_edit_window_set_zoom):
581 * src/modest-mail-operation.c: (update_account_thread):
582 * src/modest-tny-account-store.c:
583 * src/modest-tny-account.c:
584 * src/widgets/modest-global-settings-dialog.c:
585 * src/widgets/modest-window.h:
589 2007-06-25 Murray Cumming <murrayc@murrayc.com>
591 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
592 * src/modest-search.c: (modest_search_folder),
593 (modest_search_all_accounts): Actually search only in the specified folder,
594 doing a simple match on the folder ID.
595 * src/modest-search.h: Added a folder field to the ModestSearch struct,
596 and added some documentation.
598 2007-06-22 Armin Burgmeier <armin@openismus.com>
600 * src/maemo/modest-maemo-utils.h:
601 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
602 modest_maemo_utils_get_supported_secure_authentication_methods.
604 * src/maemo/easysetup/modest-easysetup-wizard.c:
605 * src/maemo/modest-account-settings-dialog.c: Show correct error if
606 one occured, not just "Server does not support secure authentication".
608 2007-06-22 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-tny-account-store.c: (get_password):
611 Restored the call to tny_account_set_user() because Philip seems to have
612 stopped this from crashing (by not using the freed string). It still does
613 not work, but now we can test it.
615 2007-06-22 Murray Cumming <murrayc@murrayc.com>
617 * src/maemo/modest-msg-edit-window.c: (init_window):
618 Comment out use of an uninitialzed GtkScrolledWindow variable,
619 to fix the build and stop a crash. Yet again.
621 2007-06-22 Murray Cumming <murrayc@murrayc.com>
623 * src/modest-tny-account-store.c: (get_password):
624 Remove the call to tny_account_set_user() because this actually crashes.
625 As mentioned in the last commit, it is known to not work anyway.
627 2007-06-22 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-tny-account-store.c: (get_password):
630 Use tny_account_set_username() to tell tinymail that the username might
631 have changed too. But tinymail ignores this: see projects.maemo.org
633 * src/modest-ui-actions.c:
634 (modest_ui_actions_on_password_requested): Remove the useless attempt to
635 reset the connection when changing the username, and improve the comments.
636 Save the changed username to gconf at least, so it is used when Modest is
639 2007-06-21 Murray Cumming <murrayc@murrayc.com>
641 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
642 Do not use a query, so that we get all folders, including for POP and
643 local-folders. They work as search criteria too.
644 This fixes projects.maemo.org bug NB#57740.
646 2007-06-21 Murray Cumming <murrayc@murrayc.com>
648 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
649 Comment out the use of hildon_notification_set_sound() because it is
650 not declared, to fix the build. Warnings are serious, people.
652 2007-06-21 Armin Burgmeier <armin@openismus.com>
654 * src/maemo/modest-maemo-utils.h:
655 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
656 modest_maemo_utils_get_supported_secure_authentication_methods()
657 to query authentication methods for a specific user. This should fix
658 projects.maemo.org bug NB#61369.
660 * src/maemo/easysetup/modest-easysetup-wizard.c:
661 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
664 2007-06-21 Murray Cumming <murrayc@murrayc.com>
666 * libmodest-dbus-client/libmodest-dbus-client.h:
667 * libmodest-dbus-client/libmodest-dbus-client.c:
668 (modest_dbus_message_iter_get_search_hit),
669 (libmodest_dbus_client_search):
670 Reorganised and commented this.
671 Removed modest_search_hit_free() from the public API because it
674 Added libmodest_dbus_client_get_folders() and
675 modest_folder_result_list_free().
677 * src/dbus_api/modest-dbus-api.h:
678 * src/dbus_api/modest-dbus-callbacks.c:
679 (modest_dbus_req_filter): Commented. Moved most code to
680 on_dbus_method_search() and added on_dbus_method_get_folders().
682 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
683 of the extra D-Bus handler.
685 * tests/dbus_api/Makefile.am:
686 * tests/dbus_api/test_get_folders.c: New test for
687 libmodest_dbus_client_get_folders(). This seems to return an empty list
688 at the moment. That could be the same error that causes the message list
689 to be empty sometimes.
690 This should help with projects.maemo.org bug NB#57740.
692 2007-06-21 Armin Burgmeier <armin@openismus.com>
694 * src/modest-mail-operation.c: Do not call
695 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
696 notify the operation's end after having set the status to CANCELED for
697 the operation queue to listen on. This fixes a deadlock when there
698 were mail operations in the queue during its finalization.
700 * src/modest-singletons.c: Reordered uninitialization of the account
701 manager to happen after the mail operation queue was uninitialized
702 because the mail operation's in the queue might still try to access
703 the account manager (see modest_mail_operation_notify_end()). This
704 fixes a potential crash when terminating the application.
706 2007-06-21 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-search.c:
709 (search_mime_part_and_child_parts): Moved some code here so we
710 can search recursively in child folders.
711 (modest_search_folder): Search in the message as a mime part, instead
712 of just its child mime parts.
713 (read_chunk), (search_mime_part_ogs):
714 Check how many bytes were read, to prevent an endless loop.
715 Searching in message bodies now works. This finishes the fix for
716 projects.maemo.org bug NB#61007.
718 2007-06-20 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
721 Add a g_warning when the item is not a folder.
723 * src/modest-ui-dimming-rules.c:
724 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
725 when selected item is not a folder (for instance, an account), because
726 the UI spec only talks about folders.
727 I am not sure what the UI spec wants, so this might not totally fix
728 projects.maemo.org bug NB#60794.
730 2007-06-20 Murray Cumming <murrayc@murrayc.com>
732 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
733 (load_from_file): Sort the list. The unsorted list would be more noticeable
734 in non-English locales.
736 * src/maemo/modest-msg-edit-window.c:
737 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
738 warning and fix the build.
740 * src/maemo/modest-progress-bar-widget.c:
741 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
742 avoid a g_warning, and probably to avoid a crash.
744 2007-06-20 Murray Cumming <murrayc@murrayc.com>
746 * src/modest-search.c: (modest_search_folder): Check for a GError
747 when calling tny_folder_get_headers(), to show that this is not the cause
750 2007-06-20 Murray Cumming <murrayc@murrayc.com>
752 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
753 Actually set the body query instead of the subject query.
755 * src/modest-search.c: (search_mime_part_ogs),
756 (search_mime_part_strcmp): Remove extra space from the text/* regex,
757 which would probably cause it to fail if we got this far.
759 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
760 to simplify the code.
761 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
762 be causing search-in-body to fail.
764 2007-06-20 Murray Cumming <murrayc@murrayc.com>
766 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
768 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
769 Better debug message when the folder cannot be found.
770 This should help with fixing projects.maemo.org bug #61287.
771 * src/modest-search.c: (add_hit): Do not leak the furl string.
773 2007-06-20 Murray Cumming <murrayc@murrayc.com>
775 * src/modest-ui-actions.c:
776 (modest_ui_actions_on_folder_selection_changed):
777 Do not special-case TNY_MERGE_FOLDER here, because
778 modest_tny_folder_get_account() already does that. This fixes
779 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
780 shown when the Outbox was selected).
782 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
784 * libmodest-dbus-client/libmodest-dbus-client.c:
785 (_dbus_iter_get_string_or_null): Initialize the string variable in
786 case this helps with Dirk's crash.
788 2007-06-19 Murray Cumming <murrayc@murrayc.com>
790 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
791 though it is not implemented yet (this function is maybe not even used),
792 to avoid breaking ABI in future.
793 * libmodest-dbus-client/libmodest-dbus-client.c:
794 (get_attachments_string): Moved some code into this generic function.
795 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
796 sends email. It is maybe not used.
797 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
798 (on_send_mail): Use attachments.
800 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
801 * src/maemo/modest-msg-edit-window.c:
802 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
803 a filename before using it, to fix projects.maemo.org bug NB#58233.
805 2007-06-19 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
808 Initialize the continue_download variable to fix the build, and probably
809 to fix randome behaviour.
811 2007-06-18 Armin Burgmeier <armin@openismus.com>
813 * src/modest-tny-send-queue.h:
814 * src/modest-tny-send-queue.c: Keep track of the status of messages in
815 the queue so we can later show it in the UI. Replaced
816 modest_tny_send_queue_msg_is_being_sent() by
817 modest_tny_send_queue_get_msg_status().
819 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
821 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
822 gpointer. This probably was not harmful, but just to be sure.
824 2007-06-18 Murray Cumming <murrayc@murrayc.com>
826 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
827 Fix the build, but leave the function broken on Bora, because
828 hildon_uri_action_get_service() does not exist.
829 osso_uri_action_get_service() does not exist either, it seems.
831 2007-06-18 Murray Cumming <murrayc@murrayc.com>
833 * src/modest-tny-account.c:
834 (modest_tny_account_new_from_server_account):
835 Uncommented the url debug output again, because it is useful for
836 debugging, as I said in the comment.
838 2007-06-18 Murray Cumming <murrayc@murrayc.com>
840 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
842 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
843 for Mameo Bora, to fix the build.
845 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
848 Fixed build with hildon < 0.99
850 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
851 Check if the selected account is busy instead of checking all accounts
853 * src/modest-account-mgr-priv.h:
854 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
855 (modest_account_mgr_init), (compare_account_name),
856 (modest_account_mgr_set_account_busy),
857 (modest_account_mgr_account_is_busy):
858 * src/modest-account-mgr.h:
859 Added busy information to the account manager. It possible to
860 set an account to busy or not busy now.
862 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
863 (modest_mail_operation_update_account),
864 (modest_mail_operation_notify_end):
865 Set the account to busy/not busy depending on the operation state.
867 * src/widgets/modest-account-view.c:
868 (modest_account_view_finalize), (get_last_updated_string),
869 (update_account_view), (on_account_busy_changed), (init_view):
870 Show string "Refreshing..." if the account is currently busy.
872 All this fixes projects.maemo.org bug NB#59711
874 2007-06-14 Armin Burgmeier <armin@openismus.com>
876 * src/widgets/modest-attachments-view.h:
877 * src/widgets/modest-attachments-view.c: Added
878 modest_attachments_view_has_attachments() and fixed coordinate
879 transformation in get_att_view_at_coords(). This fixes attachment
882 * src/widgets/modest-msg-view.c: Make use of
883 modest_attachments_view_has_attachments() to decide whether to show
884 attachments in the header.
886 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
888 * src/maemo/modest-connection-specific-smtp-edit-window.c:
889 (on_change), (on_combo_security_changed),
890 (modest_connection_specific_smtp_edit_window_init),
891 (modest_connection_specific_smtp_edit_window_set_connection),
892 (modest_connection_specific_smtp_edit_window_is_dirty):
893 * src/maemo/modest-connection-specific-smtp-edit-window.h:
894 * src/maemo/modest-connection-specific-smtp-window.c:
897 Show an comfirmation dialog for the smpt-edit-window if there are
898 unsaved changes and the user hits cancel.
899 (projects.maemo.org bug NB#60479)
901 2007-06-14 Armin Burgmeier <armin@openismus.com>
903 * src/maemo/easysetup/modest-easysetup-wizard.c:
904 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
905 address" info in banner instead of node, and select all the text as
906 per UI spec. This fixes projects.maemo.org bug NB#60550.
908 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
910 reviewed by: <delete if not using a buddy>
912 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
913 * src/modest-ui-actions.c: (folder_refreshed_cb):
915 2007-06-14 Murray Cumming <murrayc@murrayc.com>
917 * src/widgets/modest-folder-view.c: (filter_row):
918 Explictly filter out the per-account outbox accounts. I don't know why
919 these only sometimes show up, but now they should never show up in the UI.
920 This should fix projects.maemo.org bug NB#60160.
922 2007-06-14 Murray Cumming <murrayc@murrayc.com>
924 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
925 when the toolbar does not exist yet.
926 * src/modest-widget-memory.c: (save_settings_header_view):
927 Added g_warnings() to help us to discover when we are trying to set
928 an empty columns list in gconf.
930 2007-06-14 Murray Cumming <murrayc@murrayc.com>
934 Added modest_init_get_default_header_view_column_ids().
936 * src/modest-widget-memory.c: (restore_settings_header_view):
937 Use the new function to get defaults, if the gconf key is empty,
938 instead of not creating any columns. This seems to fix the
939 empty right-hand pane problems.
941 * src/widgets/modest-header-view.h: Improved documentation.
943 2007-06-13 Murray Cumming <murrayc@murrayc.com>
945 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
946 Revert the use of the display name as the account name, because this
947 is generally wrong and would break the code that follows.
949 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
951 * src/maemo/easysetup/modest-easysetup-wizard.c:
952 (check_for_supported_auth_methods), (on_before_next),
955 More correct fix for projects.maemo.org bug NB# 58991
956 Do not longer accept AUTH_PASSWORD as secure method and choose
957 correct method when creating the account.
959 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
961 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
962 Fixed projects.maemo.org bug NB# 58991
964 2007-06-13 Murray Cumming <murrayc@murrayc.com>
966 * src/modest-init.c: (modest_init_init_core),
967 (modest_init_local_folders): Fixed compilation errors.
969 2007-06-13 Murray Cumming <murrayc@murrayc.com>
971 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
972 Remove unnecessary lib/include, though it is good in principle when needed.
974 * src/modest-init.c: (modest_init_one_local_folder),
975 (modest_init_local_folders):
976 * src/modest-init.h: Initialize the .modest library for memory cards,
977 instead of just doing nothing for them. This should allow us to create
978 folders there, fixing projects.maemo.org bug NB#59297.
980 2007-06-13 Murray Cumming <murrayc@murrayc.com>
982 * libmodest-dbus-client/libmodest-dbus-client.c:
983 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
984 (libmodest_dbus_client_compose_mail),
985 (libmodest_dbus_client_open_message),
986 (libmodest_dbus_client_send_and_receive),
987 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
989 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
990 (on_idle_open_message), (modest_dbus_req_handler),
991 (search_result_to_message), (modest_dbus_req_filter):
992 * src/modest-search.c: (add_hit), (modest_search_folder),
993 (modest_search_all_accounts): Improved debug messages.
995 * tests/dbus_api/test_open_message.c: (main): Improved comments.
997 * src/modest-tny-account-store.c:
998 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1001 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1004 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1006 * src/modest-tny-account-store.c: (get_server_accounts):
1007 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1008 even when there are no accounts, so that the Outbox folder is always
1009 visible. This fixes projects.maemo.org bug NB#60158.
1011 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1013 * src/maemo/modest-main-window.c: (create_details_widget):
1014 Use the mcen_va_never logical ID.
1016 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1018 * src/dbus_api/modest-dbus-api.h:
1019 * src/dbus_api/modest-dbus-callbacks.c:
1020 (on_idle_open_default_inbox), (on_open_default_inbox),
1021 (modest_dbus_req_handler):
1022 Added a new OpenDefaultInbox method.
1024 * libmodest-dbus-client/libmodest-dbus-client.h:
1025 * libmodest-dbus-client/libmodest-dbus-client.c:
1026 Added libmodest_dbus_client_open_default_inbox() to call the new
1027 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1028 though it should maybe be used by a new osso-email-interface function.
1030 * tests/dbus_api/Makefile.am:
1031 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1034 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1036 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1037 NULL, so that the signals get all the keys. This should not actually
1038 change any behaviour because we currently update everything when anything
1041 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1043 * src/widgets/modest-folder-view.c: (text_cell_data),
1044 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1045 (find_inbox_iter): If tinymail tells us that the folder is
1046 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1047 This causes the inbox to be selected at startup, fixing part of
1048 projects.maemo.org bug NB#56305.
1050 * src/modest-ui-dimming-rules.c:
1051 (modest_ui_dimming_rules_on_tools_smtp_servers):
1052 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1053 the SMTP servers menu item.
1054 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1055 that the SMTP Servers menu item is dimmed when there are no accounts,
1056 as a future version of the UI spec will require. This fixes
1057 projects.maemo.org bug NB#56305.
1059 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1061 * src/maemo/modest-maemo-utils.c:
1062 (modest_maemo_utils_get_supported_secure_authentication_methods):
1063 Added label to dialog instead of unreadable title
1065 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1066 (modest_main_window_new):
1067 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1070 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1071 * src/modest-account-mgr.h:
1072 Added method to avoid code duplication
1074 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1075 (modest_ui_actions_on_send_receive):
1076 Use modest_account_mgr_has_accounts
1078 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1080 * src/maemo/easysetup/modest-presets.c:
1081 (modest_presets_get_info_server_security): Do not report secure auth
1083 * src/modest-protocol-info.c: Use the defines for the gconf key names
1084 for secure authentication. This was not working because we were writing
1085 Password and reading password, and the check was case sensitive.
1086 With this, gmail now works for receiving and sending when created via
1089 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1091 * src/maemo/easysetup/modest-presets.c:
1092 (modest_presets_get_info_server_security): Correct the key name for
1093 SecureSmtp, because it seems to be case-sensitive.
1094 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1095 Do not try to get the 0th notebook page if there are 0 pages, to
1096 avoid a g_warning().
1098 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1100 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1101 Prevent use of the new notification feature for now, because it currently
1102 shows one dialog for each new email, which is annoying.
1104 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1107 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1108 when no country was selected, so that we show the global ones.
1109 * src/maemo/easysetup/modest-presets.c:
1110 (modest_presets_get_providers): Return only the global providers, not
1111 all providers when mmc=0 was requested.
1113 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1115 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1116 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1117 provider ID in the combo.
1119 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1120 Do not show the page numbers, because it would be confusing when we add
1121 the 2 extra pages for the custom setup, when the user chooses the "Other"
1122 provider. This fixes projects.maemo.org bug NB#59028
1124 * src/modest-init.c: (modest_init_init_core),
1125 (modest_init_local_folders):
1126 * src/modest-init.h:
1127 * src/modest-tny-account.c:
1128 (modest_tny_account_new_for_local_folders): Do not create default folders
1129 for the memory card. This should fix projects.maemo.org bug NB#59328.
1131 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1133 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1134 Free the changed_conf_keys string items. They are already freed in the
1135 idle handler if that runs first.
1137 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-ui-actions.c:
1140 (modest_ui_actions_on_password_requested): Check that the server name
1141 is not NULL, because I just saw a password dialog with (null) as the
1144 * src/modest-tny-folder.[h|c]: Added
1145 modest_tny_folder_is_memory_card_folder().
1146 * src/modest-ui-dimming-rules.c:
1147 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1148 menu item for memory cards, as per the UI spec (section 7.4). This should
1149 fix projects.maemo.org bug NB#59297.
1151 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1153 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1154 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1155 is another problem with the code, see Murray's comment at line 772)
1157 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1159 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1160 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1161 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1162 (load_from_file), (easysetup_country_combo_box_init),
1163 (easysetup_country_combo_box_get_active_country_ids),
1164 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1165 instead of just one ID, to avoid duplicate country names in the UI.
1167 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1168 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1169 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1170 a single ID, avoiding duplicate providers.
1171 * src/maemo/easysetup/modest-easysetup-wizard.c:
1172 (on_combo_account_country): Adapt to use a list.
1174 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1176 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1177 keys changed in the last X seconds.
1179 * src/modest-account-mgr.h:
1180 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1181 (on_key_change), (modest_account_mgr_class_init),
1182 (modest_account_mgr_init), (modest_account_mgr_finalize):
1183 As the keys are changed, save them in a GSList* and signal that GSList*
1184 further every X seconds, to batch changes, to allow us to do just one
1185 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1186 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1188 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1189 changed signal signature.
1191 * src/modest-conf.c: (modest_conf_set_list),
1192 (modest_conf_on_change): Reenable notification.
1194 (modest_conf_maemo_fake_on_change): Comment out the hack that
1195 notified immediately instead of asynchronously.
1197 * src/widgets/modest-account-view.h:
1198 * src/widgets/modest-account-view.c:
1199 (update_account_view): Select the previously-selected account ID,
1200 if possible. This fixes projects.maemo.org bug NB#56933.
1202 (on_account_changed), (on_account_removed),
1203 (modest_account_view_select_account):
1205 Remove the block/unblock functions
1206 because they were not useful.
1208 * src/maemo/modest-account-view-window.c:
1209 (on_delete_button_clicked), (on_edit_button_clicked),
1210 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1212 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1214 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1215 Improve the error dialog to show Incorrect Account Settings, which seems
1216 clearer, and say that the internal error message (to be removed from the
1217 dialog later) is often misleading.
1218 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1220 * src/modest-tny-account.c:
1221 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1222 URL because this is so useful for debugging on the device.
1224 * src/widgets/modest-serversecurity-combo-box.c:
1225 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1227 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-mail-operation.c:
1230 (modest_mail_operation_send_new_mail):
1231 Added a comment about a nasty but apparently harmless message. Details
1232 added to the wiki g_warnings() page.
1234 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1237 (modest_tny_send_queue_class_init):
1238 Do not use the priv struct because it is empty, to avoid g_warnings
1239 about a non-existant priv struct.
1241 * src/modest-tny-account-store.c:
1242 (modest_tny_account_store_get_server_account),
1243 (modest_tny_account_store_get_transport_account_for_open_connection
1244 ): Do not try to get transport server accounts for local folders,
1245 because they don't have any. This avoids a g_warning().
1247 * src/maemo/modest-main-window.c:
1248 (modest_main_window_notify_send_receive_initied),
1249 (on_configuration_key_changed):
1250 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1251 * src/modest-defs.h:
1252 * src/modest-mail-operation.c:
1253 (modest_mail_operation_update_account):
1254 * src/modest-tny-account-store.h:
1255 * src/modest-tny-account.c:
1256 (modest_tny_account_get_special_folder),
1257 (modest_tny_account_new_for_local_folders),
1258 (modest_tny_account_new_for_per_account_local_outbox_folder):
1259 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1260 * src/modest-tny-local-folders-account.c:
1261 (add_account_folders_to_merged_folder):
1262 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1263 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1264 (modest_ui_actions_on_send):
1265 * src/widgets/modest-folder-view.c: (update_model):
1266 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1267 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1268 modest_tny_account_store_get_tny_account_by_account() to
1269 modest_tny_account_store_get_server_account() to make the code clearer.
1271 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1273 * src/dbus_api/modest-dbus-api.h:
1274 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1275 * src/maemo/modest-msg-edit-window.c:
1276 (modest_msg_edit_window_attach_file_noninteractive):
1277 added g_warning in case the file to be attached does not exist
1278 * tests/dbus_api/test_compose_mail.c: (main):
1279 removed obsolete comment, added generic files as test case
1281 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1283 * src/modest-tny-account-store.c: (get_server_accounts):
1284 Create the local folders account only once, not once for each outbox, and
1285 not only when there are some outboxes.
1287 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1289 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1290 code that is causing a crash at startup. Sergio says that he is fixing this.
1292 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1294 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1295 * src/maemo/modest-account-settings-dialog.c:
1296 (create_page_outgoing),
1297 (modest_account_settings_dialog_set_account_name),
1298 (save_configuration):
1299 - Fixed handling of the "Use secure authentication" toggle to comply with
1300 the ui specification. See also projects.maemo.org bug NB#58400
1302 - Restore the Secure connection setting combo correctly when loading
1305 * src/maemo/modest-maemo-utils.c:
1306 (on_camel_account_get_supported_secure_authentication),
1307 (modest_maemo_utils_get_supported_secure_authentication_methods):
1308 Fixed a crasher if operation is canceled
1310 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1311 (modest_protocol_info_auth_is_secure):
1312 * src/modest-protocol-info.h:
1314 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1315 the sense of the "Use secure authentication" toggle.
1317 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1319 * src/modest-tny-account-store.h:
1320 * src/modest-tny-account-store.c:
1321 Added modest_tny_account_store_get_local_folders_account().
1323 * src/modest-tny-folder.h:
1324 * src/modest-tny-folder.c:
1325 (modest_tny_folder_get_account):
1326 Added this replacement for tny_folder_get_account() which returns
1327 the local-folders account for TnyMergeFolders, to avoid the
1328 warning about the unimplemented get_account_func() vfunc().
1330 (modest_tny_folder_get_rules),
1331 * src/modest-ui-actions.c:
1332 (modest_ui_actions_on_folder_selection_changed):
1333 * src/modest-mail-operation.c:
1334 (modest_mail_operation_remove_folder),
1335 (modest_mail_operation_xfer_folder),
1336 (modest_mail_operation_rename_folder),
1337 (modest_mail_operation_get_msg),
1338 (modest_mail_operation_get_msgs_full),
1339 (modest_mail_operation_remove_msg),
1340 (modest_mail_operation_xfer_msgs),
1341 (modest_mail_operation_refresh_folder):
1342 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1344 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1346 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1347 (modest_server_account_set_security):
1348 * src/modest-defs.h: Add comments explaining that our
1349 UI spec means TLS when it says Normal, so these do not look like errors.
1351 * src/modest-tny-account.c:
1352 (modest_tny_account_new_from_server_account): Use the new tinymail
1353 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1354 for TLS. This should fix projects.maemo.org bug NB#58460.
1356 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1358 * src/maemo/easysetup/modest-easysetup-wizard.c:
1359 (create_account): Correct the position of the gconf sanity check warning.
1360 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1361 of using the g_idle_add() hack, because this does not seem to be necessary
1362 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1363 caused by something other than maemo's gconf.
1364 This fixes projects.maemo.org bug #59022.
1366 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-account-mgr-helpers.c:
1369 (modest_account_mgr_get_default_account): Do not check that the account
1370 exists if there is no default account (NULL), to fix a runtime warning.
1372 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1374 * src/widgets/modest-folder-view.c: (update_model):
1375 Do not unref the treemodel before we have finished with it.
1376 This prevents a valgrind warning and an occasional crash at startup.
1378 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1380 * libmodest-dbus-client/libmodest-dbus-client.h:
1381 added libmodest_dbus_client_compose_mail()
1382 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1384 added functions needed for SendAsMail() functionality
1385 * src/maemo/modest-msg-edit-window.c:
1386 (modest_msg_edit_window_attach_file_noninteractive):
1387 non interactively attaching files to message edit window
1388 * src/widgets/modest-msg-edit-window.h:
1389 * tests/dbus_api/Makefile.am:
1390 added test_compose_mail.c
1391 * tests/dbus_api/test_compose_mail.c: (main):
1393 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1395 * src/modest-account-view.c:
1396 Fixed bug projects.maemo.org bug NB#59307
1398 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1400 * src/maemo/easysetup/modest-easysetup-wizard.c:
1401 (get_serverport_incoming), (on_before_next), (create_account):
1402 * src/maemo/modest-account-settings-dialog.c:
1403 (modest_account_settings_dialog_set_account_name):
1404 * src/maemo/modest-maemo-utils.c:
1405 (on_camel_account_get_supported_secure_authentication_status),
1406 (on_camel_account_get_supported_secure_authentication),
1407 (on_secure_auth_cancel),
1408 (modest_maemo_utils_get_supported_secure_authentication_methods):
1410 Implemented security authentication for settings and easysetup.
1412 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1414 * src/maemo/modest-main-window.c: (create_details_widget):
1415 Show the total size for memory card accounts too, instead of showing
1416 the name again. Fixes bug projects.maemo.org bug NB#59307.
1418 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-tny-simple-folder-store.c:
1422 * src/modest-tny-simple-folder-store.h: Removed.
1424 * src/modest-tny-local-folders-account.h
1425 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1426 for the local-folders maildir, with an extra TnyMergedFolder containing
1427 the folders of the per-account outbox store accounts.
1428 * src/modest-tny-account-store.c: (get_server_accounts):
1429 Add the outboxes to the special local folders account after creating it.
1431 * src/modest-tny-account.c:
1432 (modest_tny_account_new_for_local_folders): Create the derived
1433 account when creating the main local-folders account.
1435 * src/maemo/modest-main-window.c: (create_details_widget),
1436 (modest_main_window_set_contents_style):
1437 Adapted to the use of the derived account instead of the folder store.
1439 * src/modest-ui-actions.c:
1440 (modest_ui_actions_on_folder_selection_changed):
1441 * src/modest-ui-dimming-rules.c:
1442 (modest_ui_dimming_rules_on_new_folder):
1443 * src/widgets/modest-folder-view.c: (text_cell_data),
1444 (icon_cell_data), (filter_row), (update_model),
1445 (get_cmp_rows_type_pos):
1448 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1449 Do not get the priv struct, because no priv struct has been set,
1450 to avoid a runtime warning.
1452 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1453 #ifelse with #else, to fix a warning, to fix the build.
1456 2007-06-05 Christian Kellner <ckellner@openismus.com>
1458 * libmodest-dbus-client/libmodest-dbus-client.c:
1459 Fix small typo in doc (why do you always see them
1460 AFTER committing stuff?)
1463 2007-06-05 Christian Kellner <ckellner@openismus.com>
1465 * libmodest-dbus-client/libmodest-dbus-client.c:
1466 (libmodest_dbus_client_search):
1467 Initialize hit list with NULL. Also set folder list
1468 to "" if NULL was supplied.
1471 2007-06-03 Christian Kellner <ckellner@openismus.com>
1473 * libmodest-dbus-client/libmodest-dbus-client.c:
1474 (modest_search_hit_list_free):
1475 Make it save to call it with NULL.
1477 * src/dbus_api/modest-dbus-callbacks.c:
1478 * src/modest-search.c:
1479 Return full ModestSearchHits as the search result list not TnyHeader
1480 since can't be around withouth the correspoding TnyFolder.
1482 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1484 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1485 Added currently commented code to check for secure auth
1487 * src/maemo/modest-account-settings-dialog.c: (on_response),
1488 (save_configuration), (show_ok):
1489 Fixed projects.maemo.org bugs NB #59248 and #59251
1491 * src/maemo/modest-maemo-utils.c:
1492 (on_camel_account_get_supported_secure_authentication_status),
1493 (on_camel_account_get_supported_secure_authentication),
1494 (modest_maemo_utils_get_supported_secure_authentication_methods):
1495 * src/maemo/modest-maemo-utils.h:
1496 Moved get_supported_secure_authentication() method here to be able
1497 to use it from easysetup wizard.
1499 * src/modest-pair.c: (on_pair_compare_as_string):
1500 Should compare string with first part of pair and not
1501 strcmp pairs which will crash.
1503 * src/modest-protocol-info.c:
1504 (modest_protocol_info_protocol_is_store):
1505 * src/modest-protocol-info.h:
1506 Added modest_protocol_info_get_auth_protocol_name()
1508 2007-06-03 Armin Burgmeier <armin@openismus.com>
1510 * src/modest-mail-operation.c:
1511 (modest_mail_operation_get_msgs_full): Set priv->account also when
1512 only retrieving a single message. This avoids a crash when canceling
1515 (modest_mail_operation_notify_end): Do not explicitely remove the
1516 operation from the queue but only emit the progress_changed signal.
1517 The queue itself listens to that signal to remove the operation when
1518 it is finished. This reduces coupling and removes a potential deadlock
1519 when modest_mail_operation_notify_end() is called from the queue
1520 itself. If that is a problem performance-wise, I would suggest to
1521 implement a status-changed signal or something.
1523 * src/modest-mail-operation-queue.c: Make sure to never call a
1524 function from another file while the queue is locked. This (hopefully)
1525 fixes another deadlock when exiting the application while retrieving
1528 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1530 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1531 Fixed build if libogs is not available
1533 2007-06-03 Christian Kellner <ckellner@openismus.com>
1535 * libmodest-dbus-client/libmodest-dbus-client.h:
1536 * libmodest-dbus-client/libmodest-dbus-client.c:
1537 (libmodest_dbus_client_delete_message):
1538 Implement deletion of messages (Client side).
1540 (modest_search_hit_free),
1541 (modest_search_hit_list_free):
1542 Utility functions to free the result hits.
1544 * src/dbus_api/modest-dbus-api.h:
1545 * src/dbus_api/modest-dbus-callbacks.c:
1546 (on_delete_message),
1547 (modest_dbus_req_handler):
1548 Implement deletion of messages (Server side).
1550 * tests/dbus_api/test_search.c: (main):
1553 * tests/dbus_api/Makefile.am:
1554 * tests/dbus_api/test_delete_message:
1555 Add little test for the message deletion logic
1557 2007-06-03 Armin Burgmeier <armin@openismus.com>
1559 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1560 when the operation queue was not empty. projects.maemo.org bug
1563 2007-06-03 Armin Burgmeier <armin@openismus.com>
1565 * src/widgets/modest-account-view.c
1566 (on_account_default_toggled): Toggle default account column
1567 explicitely instead of waiting for gconf notification (which is
1568 currently ignored). This should fix projects.maemo.org bug NB#56910
1569 for now. It should probably be removed when gconf notifications are
1572 2007-06-03 Christian Kellner <ckellner@openismus.com>
1574 * libmodest-dbus-client/libmodest-dbus-client.c:
1575 Removed debugging spew.
1577 * src/dbus_api/modest-dbus-callbacks.c:
1578 Added debugging info.
1580 * src/modest-search.c:
1581 (modest_search_all_accounts):
1582 Use tny_account_store_get_accounts () on the account store
1583 to get all accounts which is the way to get all accounts.
1585 * tests/dbus_api/test_search.c: (main):
1586 Make it possible to supply the search term on the command line.
1588 2007-06-03 Christian Kellner <ckellner@openismus.com>
1590 * libmodest-dbus-client/libmodest-dbus-client.c:
1591 * libmodest-dbus-client/libmodest-dbus-client.h:
1592 Implement searching for mesages over raw dbus. (Client side)
1594 * src/dbus_api/Makefile.am:
1595 * src/dbus_api/modest-dbus-api.h:
1596 * src/dbus_api/modest-dbus-callbacks.c:
1597 * src/dbus_api/modest-dbus-callbacks.h:
1598 Search framework (Server side). Also implement on_idle_open_message().
1600 * src/maemo/modest-platform.c: (modest_platform_init):
1601 Prepare for raw dbus/osso rpc interaction.
1603 * src/modest-search.h:
1604 Changed minsize from unspecific guint to guint32.
1606 * src/modest-search.c:
1608 Added strange hack which magically made tnymail work.
1610 (modest_search_folder),
1611 (modest_search_account),
1612 (modest_search_all_accounts):
1613 Implement helper functions to search all accounts, specific account
1616 * tests/dbus_api/Makefile.am:
1617 * tests/dbus_api/test_open_message.c:
1618 Read url to open from commandline.
1620 * tests/dbus_api/test_search.c:
1621 Implement small test for dbus search stuff
1623 2007-06-02 Armin Burgmeier <armin@openismus.com>
1625 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1626 include account type and account title. This fixes projects.maemo.org
1629 * src/maemo/modest-account-view-window.c: Set a title for the window.
1631 2007-06-02 Armin Burgmeier <armin@openismus.com>
1633 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1634 incoming and outgoing server name based on email address and server
1635 types as long as the names have not been edited manually. This fixes
1636 projects.maemo.org bug NB#58671.
1638 2007-06-02 Armin Burgmeier <armin@openismus.com>
1640 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1641 server type cannot be changed in future to the incoming details page
1642 when creating an account. This fixes projects.maemo.org bug NB#59029.
1644 2007-06-02 Armin Burgmeier <armin@openismus.com>
1646 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1647 and assigned max width chars so that they wrap instead of being
1648 truncated. Fixes projects.maemo.org bug NB#56126.
1650 2007-06-02 Armin Burgmeier <armin@openismus.com>
1652 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1653 introductory note to the connection specific smtp servers dialog, as
1654 section 8.12 of the email UI specification requires. This fixes
1655 projects.maemo.org bug NB#59212.
1657 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1659 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1660 Check for running mail operations, and offer to cancel them, as per the UI
1661 spec. This fixes projects.maemo.org bug NB#59041 .
1662 However, I suspect that tinymail may still use the network connection
1663 in ways that we cannot detect or cancel. But it should at least adapt to
1664 changes fairly well.
1666 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1668 * src/modest-tny-account-store.c: (recreate_all_accounts),
1669 (get_cached_accounts), (get_server_accounts): Do more sensible
1670 ref-counting of the temporarily-cached outbox accounts list. This seems
1671 to fix a crash when entering the password when the password was wrong.
1673 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1675 * src/gnome/modest-main-window.c: (connect_signals):
1676 * src/modest-tny-account-store.c: (get_password),
1677 (modest_tny_account_store_alert): Added comments and clues and
1678 commented-out code about how we currently fail to deal with connection
1679 errors and wrong passwords, and how we should.
1681 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1683 * src/widgets/modest-retrieve-combo-box.c:
1684 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1685 This fixes projects.maemo.org bug NB#58472 .
1687 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1689 * src/maemo/easysetup/modest-easysetup-wizard.c:
1690 (create_page_complete_easysetup):
1691 (create_page_complete_custom): Correct the last commit,
1692 putting the correct sentences in the correct pages.
1694 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1696 * src/maemo/easysetup/modest-easysetup-wizard.c:
1697 (create_page_complete_custom): Show the second sentence of text
1698 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1701 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1703 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1704 Set the leave-on-server conf key by default. This fixes
1705 projects.maemo.org bug NB#59258 .
1707 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1709 * src/maemo/modest-account-view-window.c:
1710 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1711 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1714 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1716 * src/maemo/easysetup/modest-easysetup-wizard.c:
1717 (create_caption_new_with_asterisk):
1718 * src/maemo/modest-account-settings-dialog.c:
1719 (create_caption_new_with_asterisk):
1720 Uncomment the code to add the asterisk, because they are no longer in the
1721 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1722 (update_incoming_server_title): Add an asterisk here too.
1724 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1726 * src/maemo/modest-maemo-global-settings-dialog.c:
1727 (current_connection): Check that we are even connected before trying to
1728 get the current connection name, to prevent a warning.
1730 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1731 Change the comments because tny_maemo_conic_device_connect() is now meant to
1733 * src/modest-mail-operation.c:
1734 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1735 make sure we have a connection and fail if we can't connect.
1737 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1739 * src/maemo/modest-main-window.c:
1740 (on_account_store_connecting_finished): Do not try to get the
1741 connection ID if we are not really connected. I am surprised that
1742 this signal handler is called when we are not connected.
1744 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1746 * src/modest-error.h:
1747 * src/modest-ui-actions.c:
1748 (modest_ui_actions_get_msgs_full_error_handler):
1749 Renamed an enum, added comments, added an enum
1750 for retrieve-limit errors.
1752 * src/modest-mail-operation.c: (foreach_add_item),
1753 (internal_folder_observer_update), (update_account_thread),
1754 (modest_mail_operation_get_msgs_full):
1755 (modest_mail_operation_update_account),
1756 Added comments about how this works, and some code that should
1757 (but does not) check the retrieve-limit. See the TODO comment.
1759 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1761 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1762 Initialize help_id to fix the build. Warnings are good.
1764 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1766 * src/widgets/modest-hbox-cell-renderer.c:
1767 (modest_hbox_cell_renderer_append):
1768 * src/widgets/modest-vbox-cell-renderer.c:
1769 (modest_vbox_cell_renderer_append):
1770 Fix the last commit by doing an extra ref.
1772 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1774 * src/widgets/modest-hbox-cell-renderer.c:
1775 (modest_hbox_cell_renderer_append):
1776 * src/widgets/modest-vbox-cell-renderer.c:
1777 (modest_vbox_cell_renderer_append):
1778 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1779 to fix the build with Maemo Bora.
1780 However, there seems to be a remaining crash, probably due to reference
1783 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1785 * src/modest-tny-account.c:
1786 (modest_tny_account_new_for_local_folders):
1787 Use hildon_file_system_info_async_new() to get a better name for
1788 the memory card account, setting it as the account name.
1789 The timing seems to work, but this is probably
1790 not the best place to do this. See the TODO comment.
1791 * src/maemo/modest-main-window.c: (create_details_widget):
1792 * src/widgets/modest-folder-view.c: (text_cell_data):
1793 Use the tny account name instead of hardcoding a name.
1795 2007-05-30 Christian Kellner <ckellner@openismus.com>
1797 * src/modest-search.c: (modest_search):
1798 Correctly set part_search_func even if we have already parsed
1799 the query and thus a valid OgsTextSearcher object.
1801 2007-05-30 Christian Kellner <ckellner@openismus.com>
1804 Search and check for libogs.
1807 Incooparte the ogs build env.
1809 * src/modest-mime-part-search-stream.c:
1810 * src/modest-mime-part-search-stream.h:
1811 Removed since we do the real searching now in modest-search.c.
1813 * src/modest-search.c:
1814 * src/modest-search.h:
1815 Implement support for ogs. We use that if available and requested
1816 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1817 should now handle the corner case when the search term is spread
1818 across multiple reads.
1819 Also the logic in modest_search () was corrected to search all
1820 requested fields until one is found.
1822 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1826 * src/modest-init.h:
1827 * src/modest-init.c: Made modest_init_local_folders() take a
1828 path and be public so we can iniitialize maildir folders on
1831 * src/modest-local-folder-info.h:
1832 * src/modest-local-folder-info.c:
1833 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1835 * src/modest-tny-account.c:
1836 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1837 still means the standard local-folders path on the local volume.
1839 * src/modest-tny-account-store.c:
1840 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1841 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1842 all accounts when that happens.
1843 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1844 this too, so it shows up in the treeview.
1846 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1848 * src/maemo/modest-maemo-global-settings-dialog.c:
1849 (current_connection):
1850 * src/widgets/modest-global-settings-dialog.c:
1851 (current_connection_default):
1852 Use the enum values instead of 0, 1 and -1,
1853 to make the code clearer.
1855 * src/modest-account-mgr-helpers.c:
1856 (modest_account_mgr_get_connection_specific_smtp): Make this code
1859 * src/modest-runtime.h:
1860 * src/modest-runtime.c:
1861 Added modest_runtime_remove_all_send_queues().
1862 * src/maemo/modest-main-window.c:
1863 (on_account_store_connecting_finished): Recreate the send queues,
1864 using the appropriate transport accounts for this new connection.
1865 Some futher adapting might be needed if the old send queues are not
1866 automatically stopped at this point.
1868 * src/modest-tny-account-store.c: (get_server_accounts):
1869 Create the connection-specific transport accounts, so that they can
1870 be found later by their ID.
1872 * src/modest-tny-account.h:
1873 * src/modest-tny-account.c:
1874 Added modest_tny_account_new_from_server_account_name().
1875 modest_tny_account_new_from_server_account(): Do not create the
1876 send queues here, because they will be
1877 recreated anyway when the connection changes for the first time.
1879 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1881 * src/modest-local-folder-info.h:
1882 * src/modest-local-folder-info.c:
1883 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1884 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1885 tbox_folder): Take a modest account name instead of a server TnyAccount,
1886 so we can have per-modest-account rather than per-transport-account
1888 We must make sure that we change or recreate the exisitng send queues
1889 when the connection changes for connection-specific transport accounts.
1891 * src/modest-tny-account-store.c:
1892 (create_per_account_local_outbox_folders): Create outboxed per modest
1893 account, not per transport account.
1895 * src/modest-tny-account.h:
1896 * src/modest-tny-account.c:
1897 (modest_tny_account_get_special_folder): For outboxes, get the
1898 parent modest account name. The account is ignored for other folders.
1899 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1900 modest account name rather than a server TnyAccount.
1902 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1904 * src/modest-tny-account.c:
1905 (modest_tny_account_new_from_server_account):
1906 Call modest_runtime_get_send_queue() immediately after creating transport
1907 accounts, so that they start trying to send email from the outbox as soon
1908 as possible at startup. This is probably what we want.
1910 * src/modest-mail-operation.c: (update_account_thread):
1911 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1912 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1913 * src/modest-tny-send-queue.h:
1914 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1915 (modest_ui_actions_on_send):
1916 Added comments about how sending works, though it needs some more work.
1918 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1920 * src/modest-tny-account.c:
1921 (modest_tny_account_get_special_folder): Add TODO because this fails when
1922 the network is busy.
1923 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1924 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1925 Do not try to show this window when there is no active account. The UI
1926 specs does not tell us what to do in this case.
1928 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1932 * src/maemo/Makefile.am:
1933 * src/widgets/Makefile.am: Some dist fixes.
1935 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1937 * src/maemo/modest-connection-specific-smtp-window.c:
1938 (on_button_edit): Make the code clearer, to prevent a double free.
1940 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/modest-account-settings-dialog.c:
1943 (modest_account_settings_dialog_set_account_name),
1944 Check the connection-specific smtp servers checkbox if there are any.
1946 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1947 (modest_connection_specific_smtp_edit_window_init):
1948 Start with a suitable port number.
1950 * src/modest-account-mgr-helpers.h:
1951 * src/modest-account-mgr-helpers.c: Added
1952 modest_account_mgr_get_has_connection_specific_smtp().
1954 (modest_account_mgr_set_connection_specific_smtp),
1955 (modest_account_mgr_remove_connection_specific_smtp),
1956 (modest_account_mgr_get_has_connection_specific_smtp),
1957 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1958 connection-specific smtp server accounts in the account, rather than
1959 the server account conf dir.
1961 This fixes bug projects.maemo.org bug NB#58263 .
1963 * src/modest-tny-account-store.c:
1964 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1965 if there are no server accounts yet, to prevent an infinite loop when there
1966 are no accounts. Document that one must be called before the other.
1968 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1970 * src/modest-account-mgr-helpers.c:
1971 (modest_account_mgr_get_default_account): Make sure that at least
1972 one account is always the default, if there are any enabled accounts.
1973 This is just a sanity check that shouldn't be necessary.
1975 * src/modest-account-mgr-priv.c:
1976 (_modest_account_mgr_account_from_key): Unescape the conf key to
1977 get the real account name. For instance, this is an issue if a space
1978 was in the account name, which can happen because the account name
1979 is generated from the display name.
1980 (_modest_account_mgr_get_account_keyname): Always escape the
1982 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1983 Unescape the conf keys to get the real account names.
1985 For instance, previously the is-default radio button in the accounts
1986 list was not checked for any accounts at first. This fixes that,
1987 and might fix several similar bugs.
1989 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1991 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1992 Removed some debug printfs.
1994 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1996 Modest on-disk outbox directories are now here, for instance:
1997 $HOME/.modest/outboxes/<account-id-1>/outbox
1998 $HOME/.modest/outboxes/<account-id-2>/outbox
2000 $HOME/.modest/local-folders/outbox
2001 so we can have a separate outbox for each account.
2002 But they are shown as one outbox in the GtkTreeView, by using a
2003 TnyMergeFolder in a ModestTnySimpleFolderStore.
2006 * src/modest-tny-simple-folder-store.c:
2007 * src/modest-tny-simple-folder-store.h:
2008 Added ModestTnySimpleFolderStore, used to contain folders from
2009 other folder stores, such as other accounts.
2011 * src/modest-tny-outbox-account.h:
2012 * src/modest-tny-outbox-account.c:
2013 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2014 used for the per-account local outbox folders.
2016 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2017 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2018 only use this (internally) now for the non-outbox local folders.
2020 * src/modest-init.h:
2021 * src/modest-init.c: Added modest_init_one_local_folder(), for
2022 setting up the directory structure for each local folder.
2024 * src/modest-local-folder-info.c:
2025 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2026 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2028 * src/modest-local-folder-info.h:
2029 * src/modest-tny-account-store.c: (on_account_removed),
2030 (on_account_changed), (create_per_account_local_outbox_folders),
2031 (get_server_accounts), (modest_tny_account_store_get_accounts),
2032 (modest_tny_account_store_get_tny_account_by_account),
2033 (modest_tny_folder_store_is_virtual_local_folders):
2035 * src/modest-tny-account.h:
2036 * src/modest-tny-account.c:
2037 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2038 to create an on-disk per-account local outbox folder for each
2040 (create_per_account_local_outbox_folders): Create a local outbox folder
2041 for each transport account.
2042 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2043 for all local folders.
2045 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2046 instead of using g_object_get/set() directly. It is clearer.
2048 (modest_tny_folder_store_get_message_count),
2049 (modest_tny_folder_store_get_local_size
2050 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2051 because we now use these with non-acount folder stores.
2053 (modest_tny_account_get_special_folder),
2054 (modest_tny_account_new_from_server_account),
2055 (modest_tny_account_new_from_account):
2056 (recurse_folders): Adjust to the new outbox system.
2058 * src/modest-tny-folder.h:
2059 * src/modest-tny-folder.c:
2060 (modest_tny_folder_is_local_folder),
2061 (modest_tny_folder_get_local_folder_type),
2062 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2064 * src/widgets/modest-main-window.h:
2065 * src/maemo/modest-main-window.c: (create_details_widget),
2066 (modest_main_window_set_contents_style): Show details for any folder store,
2069 (modest_tny_folder_get_rules):
2070 Remove the const. C does not support constness enough for this.
2072 * src/modest-ui-actions.c:
2073 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2074 make all outboxes appear as one, in the usual local-folders tree node.
2076 (set_active_account_from_tny_account),
2077 (modest_ui_actions_on_folder_selection_changed):
2078 * src/widgets/modest-folder-view.c: (text_cell_data),
2079 (icon_cell_data), (filter_row),
2080 (add_account_folders_to_merged_folder),
2081 (add_account_folders_to_simple_folder_store), (),
2082 (get_cmp_rows_type_pos), (cmp_rows),
2083 (modest_folder_view_set_account_id_of_visible_server_account):
2084 Adjust to the new outbox system, using generic folder stores and folders
2085 in the GtkTreeModel.
2087 2007-05-23 Christian Kellner <ckellner@openismus.com>
2089 * src/modest-mail-operation.c:
2090 (modest_mail_operation_update_account):
2091 Use info->max_size instead of unintialized local var [small
2092 build fix]. (Added TODO to review that change since I don't
2095 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2097 * libmodest-dbus-client/libmodest-dbus-client.c:
2098 (libmodest_dbus_client_compose_mail): function added
2099 * src/dbus_api/modest-dbus-api.h:
2100 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2101 (on_compose_mail): Implementation of the SendAsMail functionality
2103 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2105 * src/modest-account-mgr.c:
2106 (modest_account_mgr_add_server_account): Set the secure-connection
2107 conf key for transport accounts as well as store accounts. I don't know
2108 why the if was there. For instance, this makes sure that we use SSL
2109 for the gmail preset from the easysetup wizard.
2111 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2113 * src/gnome/modest-main-window.c:
2114 (on_account_store_connecting_finished), (connect_signals):
2115 * src/maemo/modest-main-window.c:
2116 (on_account_store_connecting_finished), (connect_signals),
2117 (modest_main_window_new):
2118 Handle TnyAccountStore::connecting-finished instead of
2119 TnyDevice::connection-changed, because we cannot actually perform
2120 operations on accounts until TnyAccountStore has itself responded to
2121 the TnyDevice::connection-changed signal. This prevents a GError from
2123 Do not try to update at startup, because we (at least on scratchbox)
2124 already do an update at startup when the device goes online.
2125 This prevents a GError from tinymail.
2126 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2127 Added TODO about stopping simultaneous operations.
2129 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2131 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2132 * src/modest-mail-operation-queue.c:
2133 (modest_mail_operation_queue_remove):
2134 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2135 about where they happened.
2137 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2139 * src/modest-ui-actions.c:
2140 (modest_ui_actions_on_password_requested): Make sure that the remember
2141 output parameter is always TRUE.
2143 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2145 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2146 Show a OK/Cancel dialog if the error is a question, though we still do not
2147 know anything more about what we are asking the user.
2148 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2149 Fix an uninitialized variable (helper). This is a logic error, however.
2151 2007-05-21 Christian Kellner <ckellner@openismus.com>
2153 * src/modest-search.h:
2154 Correct bit shifting in the ModestSearchFlags enum.
2156 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2158 * src/modest-tny-account.c:
2159 (modest_tny_account_new_from_server_account): Do not use the lsub and
2160 check-all hard-coded IMAP options when using POP.
2162 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2164 * src/modest-tny-account.c:
2165 (modest_tny_account_new_from_server_account):
2166 Use NULL for the secure-auth method for POP when Password auth has been
2167 specified by the user, as we already do for IMAP. "auth=Login" causes
2168 an error from camel or the server.
2170 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/modest-account-settings-dialog.c:
2173 (create_page_account_details),
2174 (modest_account_settings_dialog_set_account_name):
2175 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2176 for the leave-on-server checkbox, rathr than just the checkbox, when
2177 the protocol is not POP.
2179 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2181 * src/widgets/modest-account-view.c:
2182 * src/widgets/modest-account-view.h:
2183 Added modest_account_view_select_account() which will be useful later
2184 to asynchronously re-select the edited account.
2186 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2188 * src/maemo/modest-account-settings-dialog.c:
2189 (modest_account_settings_dialog_set_account_name):
2190 Automatically choose the port numbers based on the secure authentication
2191 methods, if they have not been chosen before.
2192 This fixes projects.maemo.org bug NB#56273 .
2194 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2196 * src/maemo/modest-main-window-ui.h:
2197 * src/modest-ui-actions.c:
2198 * src/modest-ui-actions.h:
2199 Connect the Tools/SMTP Servers menu item to
2200 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2201 SMTP servers dialog, as in the UI specification and saves changes when it
2202 is closed. This fixed projects.maemo.org bug NB#56305 .
2204 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2206 * src/maemo/modest-connection-specific-smtp-window.c:
2207 (modest_connection_specific_smtp_window_init):
2208 Use gtk_window_set_default_size() to make this window big enough, so
2209 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2211 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2213 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2214 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2215 (modest_connection_specific_smtp_edit_window_init),
2216 Do not try to connect to a combobox signal before the combobox exists.
2217 This fixes the cras in projects.maemo.org bug NB#56288 .
2218 (modest_connection_specific_smtp_edit_window_get_settings):
2219 Remove the server_account_name parameter which was being checked for NULL
2220 though it was not used.
2222 * src/maemo/modest-connection-specific-smtp-window.c:
2223 (modest_connection_specific_smtp_window_fill_with_connections),
2224 (on_button_edit), (modest_connection_specific_smtp_window_init):
2225 Correct the number of treemodel columns to prevent a warning.
2226 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2227 libconic does not work.
2229 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2231 * src/modest-tny-account.c:
2232 (modest_tny_account_new_from_server_account):
2233 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2234 SMTP when "None" was chosen by the user. However, with my SMTP server that
2235 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2238 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2240 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2241 to explain the memory management issue with the ID in the ModestPair.
2243 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2244 (add_sending_page), (modest_account_assistant_finalize):
2245 * src/gnome/modest-gnome-global-settings-dialog.c:
2246 (create_updating_page), (create_composing_page):
2247 * src/gnome/modest-msg-edit-window.c: (get_transports),
2248 (init_window), (modest_msg_edit_window_finalize),
2249 (modest_msg_edit_window_get_msg_data):
2250 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2251 * src/gnome/modest-transport-widget.c:
2252 (modest_transport_widget_finalize), (smtp_configuration):
2253 * src/maemo/modest-maemo-global-settings-dialog.c:
2254 (create_updating_page), (create_composing_page):
2255 * src/maemo/modest-msg-edit-window.c: (get_transports),
2256 (init_window), (modest_msg_edit_window_finalize),
2257 (modest_msg_edit_window_get_msg_data),
2258 (modest_msg_edit_window_free_msg_data):
2259 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2260 (modest_store_widget_finalize):
2261 * src/maemo/modest-transport-widget.c:
2262 (modest_transport_widget_finalize), (smtp_configuration):
2263 * src/modest-main.c: (send_mail):
2264 * src/widgets/modest-combo-box.h:
2265 * src/widgets/modest-global-settings-dialog-priv.h:
2266 * src/widgets/modest-global-settings-dialog.c:
2267 (modest_global_settings_dialog_finalize):
2268 * src/widgets/modest-msg-edit-window.h:
2269 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2270 as long as the combo box, to prevent use of freed memory for the ID.
2272 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2274 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2275 get_accounts(), to make this clearer. Do not check for the enabled gconf
2276 key, because we do not use this for server accounts (at least, not yet).
2277 This allows us to send email again.
2279 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2281 * src/maemo/modest-platform.c:
2282 (on_modest_conf_update_interval_changed), (modest_platform_init):
2283 Only respond to this particular key change. All these strcmp()s cannot be
2286 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2288 * src/maemo/modest-maemo-global-settings-dialog.c:
2289 (current_connection): Prevent a crash in scratchbox when
2290 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2291 * src/maemo/modest-platform.c:
2292 (on_modest_conf_update_interval_changed), (modest_platform_init):
2293 Get the update interval from gconf and reset it when the gconf key changes.
2295 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2297 * src/modest-protocol-info.c:
2298 * src/modest-protocol-info.h: Adde enum-specific get functions,
2299 instead of using a ModestProtocolType enum parameter.
2301 * src/gnome/modest-account-assistant.c:
2302 * src/gnome/modest-store-widget.c:
2303 * src/gnome/modest-store-widget.h:
2304 * src/gnome/modest-transport-widget.c:
2305 * src/gnome/modest-transport-widget.h:
2306 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2307 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2308 * src/maemo/easysetup/modest-easysetup-wizard.c:
2309 * src/maemo/modest-account-settings-dialog.c:
2310 * src/maemo/modest-account-settings-dialog.h:
2311 * src/maemo/modest-store-widget.c:
2312 * src/maemo/modest-store-widget.h:
2313 * src/maemo/modest-transport-widget.c:
2314 * src/maemo/modest-transport-widget.h:
2315 * src/modest-account-mgr-helpers.c:
2316 * src/modest-account-mgr-helpers.h:
2317 * src/modest-account-mgr.c:
2318 * src/modest-account-mgr.h:
2319 * src/modest-tny-account.c:
2320 * src/modest-tny-folder.c:
2321 * src/widgets/modest-account-view.c:
2322 * src/widgets/modest-retrieve-combo-box.c:
2323 * src/widgets/modest-retrieve-combo-box.h:
2324 * src/widgets/modest-secureauth-combo-box.c:
2325 * src/widgets/modest-serversecurity-combo-box.c:
2326 * src/widgets/modest-serversecurity-combo-box.h:
2327 * tests/check_account-mgr.c:
2328 Use the specific functions, and use the re-renamed enum values for GNOME too.
2330 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2332 * src/modest-pair.h:
2333 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2334 so we can get the second based on the first.
2336 * src/maemo/modest-account-settings-dialog.h:
2337 * src/maemo/modest-account-settings-dialog.c:
2338 Added get_supported_secure_authentication_methods(), though it is mostly
2339 commented-out for now until the necessary API is committed to tinymail.
2340 (modest_account_settings_dialog_set_account_name),
2341 (save_configuration): Request the supported authentication methods from the
2342 server, so we can choose a working method.
2344 * src/modest-tny-account-store.h:
2345 * src/modest-tny-account-store.c:
2346 (modest_tny_account_store_get_session): Rename from
2347 tny_account_store_get_session().
2349 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2351 * src/modest-protocol-info.h: Split the ModestProtocol enum
2352 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2353 There was no need to have these unrelated values in one enum.
2355 * src/: many files: Adapted to changed enum. This makes the code a bit
2356 clearer, and the compiler could catch some errors.
2358 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2360 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2361 Show the detailed internal camel error message when an error happens
2362 during the configuration, so that our testers can give us more clues.
2363 For instance, in projects.maemo.org bug NB#56910 .
2365 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2367 * src/modest-tny-account.c:
2368 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2369 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2371 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2373 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2374 * src/maemo/modest-account-settings-dialog.c:
2375 (modest_account_settings_dialog_set_account_name),
2376 (save_configuration): For the incoming secure authentication checkbox,
2377 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2378 the UI specification. PLAIN does not seem to be supported for most IMAP
2379 servers anyway, and I am not sure what it would mean.
2380 However, we probably need to discover which of the secure-authentication
2381 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2382 * src/modest-account-mgr-helpers.c:
2383 (modest_account_mgr_get_server_account_data):
2385 * src/modest-tny-account.c:
2386 (modest_tny_account_new_from_server_account):
2387 Use tny_account_set_mech() to set secure-authentication methods,
2388 with some special-casing for IMAP, based on my observations of how
2391 * src/modest-account-mgr-helpers.h:
2392 * src/modest-account-mgr.c:
2393 * src/modest-defs.h: Comment that the URI is only used for local folders.
2395 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2397 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2398 parameter const, just to be neat.
2399 * src/modest-text-utils.c: (modest_text_utils_inline):
2400 End g_strconcat() with NULL, as its documentation says. This is almost
2401 certainly the cause of my crash at startup on the device. Interestingly,
2402 valgrind doesn't tell us about these errors.
2404 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2406 * scripts/build-packages: Added more precise comments about how to use
2407 this script, though I still get this error:
2408 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2409 error building tinymail
2411 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2413 * src/maemo/modest-main-window.c: (on_account_update):
2414 Very slight cleanup, hoping to make it simpler to discover what causes
2415 a crash here sometimes.
2417 * src/modest-tny-account.c:
2418 (modest_tny_account_new_from_server_account): Set the port. Added
2419 comments about the options and a TODO comment because I need to find out
2420 how to specify the secure authentication method.
2422 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2424 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2425 changed CFlags paths form modest to libmodest
2427 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2429 * src/modest-account-mgr-helpers.c:
2430 (modest_account_mgr_get_server_account_data),
2431 (modest_account_mgr_free_server_account_data):
2432 * src/modest-account-mgr-helpers.h:
2433 * src/modest-account-mgr.c:
2434 (modest_account_mgr_add_server_account):
2435 * src/modest-defs.h:
2436 * src/modest-tny-account.c:
2437 (modest_tny_account_new_from_server_account):
2438 Determine the options for tny_camel_account_add_option() here,
2439 based on the settings, rather than storing them directly in gconf.
2441 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2443 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2444 Show a more friendly error dialog now that we expect (from the tinymail
2445 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2447 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2449 * src/maemo/modest-main-window.c: (on_account_update): Check that
2450 account_name is not NULL, to prevent a crash at startup that I am
2451 seeing on the N800. I do wonder why it is NULL.
2453 * src/maemo/easysetup/modest-easysetup-wizard.c:
2454 (create_page_user_details):
2455 * src/maemo/modest-account-settings-dialog.c:
2456 (create_page_user_details), (create_page_outgoing):
2457 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2458 (modest_connection_specific_smtp_edit_window_init):
2459 * src/modest-ui-actions.c:
2460 (modest_ui_actions_on_password_requested):
2461 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2462 might do something useful with the on-screen keyboard.
2464 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2466 * src/maemo/modest-main-window.c: (on_account_update):
2467 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2468 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2470 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2472 * src/modest-tny-account-store.c: (on_account_changed):
2473 Correct the signature of this signal handler.
2475 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2477 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2478 Show a HildonNote instead of a GtkDialog for Maemo.
2480 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2482 * src/widgets/modest-account-view.h:
2483 * src/widgets/modest-account-view.c: (on_account_changed),
2484 (on_account_removed). Added a boolean flag, set/unset by
2485 modest_account_view_block_conf_updates(),
2486 modest_account_view_unblock_conf_updates() to prevent unnecessary
2487 updates, but this is not very useful because the gconf notifications are
2488 so delays (maybe only on Maemo Bora).
2489 So auto-updating is turned off, and these functions do an explicit
2490 update when necessary.
2491 However, something else is still doing too much work when adding/removing
2492 accounts, probably in another part of the application.
2494 * src/maemo/modest-account-view-window.c:
2495 (on_delete_button_clicked), (on_edit_button_clicked),
2496 (on_new_button_clicked): Use the new functions.
2498 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2500 * src/modest-account-mgr-helpers.c:
2501 (modest_account_mgr_set_first_account_as_default):
2502 Sort the list of names alphabetically-by-title, so we choose the first one
2504 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2505 alphabetically by the title.
2507 This fixes projects.maemo.org bug NB#56418 .
2509 * src/modest-account-mgr-priv.c:
2510 (_modest_account_mgr_account_from_key):
2511 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2512 avoid a valgrind error, and possible random behaviour.
2514 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2516 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2517 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2518 tinymail documentation to say that this can be expected.
2519 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2520 pretty, and should not happen, but I would prefer to know when it does.
2522 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2524 * configure.ac: When using the older hildon version, probably on Bora,
2525 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2527 * src/widgets/modest-attachment-view.c:
2528 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2531 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2533 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2534 Implemented the prototype. Can be tested with
2535 tests/dbus_api/test_open_message:
2537 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2539 * src/modest-tny-account-store.c:
2540 (modest_tny_account_store_instance_init), (get_password):
2541 * src/modest-ui-actions.c:
2542 (modest_ui_actions_on_password_requested):
2543 Do not store the password in gconf, because this function is called
2544 for non-remembered passwords. Actually use the cached (in the hash map)
2545 password instead of releasing it.
2546 The password will now not be remembered if it is asked via the protected
2547 password dialog, as per the UI spec.
2549 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2551 * src/modest-defs.h:
2552 * src/modest-account-mgr-helpers.h:
2553 * src/modest-account-mgr-helpers.c:
2554 Added modest_server_account_get_username_has_succeeded(),
2555 modest_server_account_set_username_has_succeeded().
2556 (modest_server_account_set_username),
2557 Reset the has-succeeded flag if the username changes.
2559 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2560 * src/maemo/modest-connection-specific-smtp-window.c:
2561 (modest_connection_specific_smtp_window_save_server_accounts):
2562 Use modest_server_account_set_username() instead of using
2563 modest_conf_set_string() directly, so that the has-succeeded flag is always
2566 * src/modest-ui-actions.c:
2567 (modest_ui_actions_on_password_requested): Dim the username entry if
2568 the username has ever worked, as per the UI spec.
2570 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2572 * src/modest-tny-account-store.c: (get_password):
2573 * src/modest-ui-actions.c:
2574 (modest_ui_actions_on_password_requested):
2575 Allow the username to be changed too, though there is more work to
2576 be done on exactly how this behaves.
2578 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2580 * src/modest-account-mgr-helpers.h:
2581 * src/modest-account-mgr-helpers.c:
2582 Added modest_account_mgr_get_display_name(),
2583 modest_server_account_get_username(),
2584 modest_server_account_set_username(),
2585 modest_server_account_set_password(),
2586 modest_server_account_get_hostname() functions so we do not need to
2587 use the conf API directly.
2589 * src/maemo/modest-main-window.c: (connect_signals):
2590 Actually connect ot the ModestAccountStore::request-password signal,
2591 so that we show the dialog when the password is requested by Tinymail,
2592 for isntance if it is empty.
2594 * src/modest-marshal.list:
2595 * src/modest-tny-account-store.c:
2596 (modest_tny_account_store_class_init), (get_password),
2597 (modest_tny_account_store_alert):
2598 * src/modest-tny-account-store.h:
2599 * src/modest-ui-actions.h:
2600 * src/modest-ui-actions.c:
2601 (modest_ui_actions_on_password_requested):
2602 Change the signal parameters, so it is obvious that we are providing
2603 the non human-readable server name, and receiving both the username
2604 and password, though changing of the username is not yet implemented.
2605 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2606 for the GNOME version.
2608 This should fix the projects.maemo.org bug NB#56209, though it does not
2609 work on Bora, because the gconf_client_get() for the password fails
2610 immediately after we save it with gconf_client_set().
2612 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2615 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2616 caused an undefined symbol error:
2617 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2619 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2621 * src/modest-tny-account-store.c:
2622 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2623 using a GError instead of a string message, so we can translate it in
2626 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2628 * src/maemo/modest-address-book.c:
2629 (modest_address_book_check_names):
2630 * src/maemo/modest-msg-view-window.c:
2631 (modest_msg_view_window_clipboard_owner_change):
2632 * src/modest-init.c: (modest_init_init_ui):
2633 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2634 (update_folders_cb), (modest_mail_operation_update_account):
2635 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2636 (modest_ui_actions_on_msg_attachment_clicked),
2637 (modest_ui_actions_on_msg_recpt_activated):
2638 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2639 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2640 (modest_msg_view_search_next):
2641 * src/widgets/modest-recpt-editor.c:
2642 (modest_recpt_editor_on_button_release_event),
2643 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2644 g_message(). At this point we should only be seeing interesting errors on
2645 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2647 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2649 (modest_wizard_dialog_force_title_update):
2650 * src/maemo/easysetup/modest-wizard-dialog.h:
2651 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2652 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2653 can update the title when appropriate. Otherwise the title is wrong if the
2654 pages are added after adding the notebook to the dialog.
2655 This must be a problem in HildonWizardDialog too.
2656 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2658 * src/maemo/easysetup/modest-easysetup-wizard.c:
2659 (create_subsequent_customsetup_pages),
2660 (create_subsequent_easysetup_pages):
2661 Call modest_wizard_dialog_force_title_update() so that the title is
2662 correct even with GTK+ < 2.10.
2663 This fixes projects.maemo.org bug NB#56145 .
2665 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2667 * src/maemo/modest-platform.c:
2668 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2669 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2672 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2674 * src/widgets/modest-window.h:
2675 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2676 and modest_window_save_state(), which invokes it.
2678 * src/widgets/modest-window-mgr.h:
2679 * src/widgets/modest-window-mgr.c:
2680 Added modest_window_mgr_save_state_for_all_windows(), which calls
2681 the save_state vfunc on all registered windows, if implemented.
2683 * src/gnome/modest-msg-edit-window.c:
2684 * src/gnome/modest-msg-view-window.c:
2685 * src/maemo/modest-msg-edit-window.c:
2686 * src/maemo/modest-msg-view-window.c:
2687 * src/maemo/modest-main-window.c:
2688 Specify the existing save_settings functions as implementations of
2689 ModestWindow::save_state_func().
2691 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2692 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2693 enabling hibernation, for instance.
2695 We may need to do the same thing for restoring settings.
2698 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2700 * src/widgets/modest-window-mgr.c:
2701 * src/widgets/modest-window-mgr.h:
2702 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2703 modest_window_mgr_get_hibernation_is_prevented().
2705 * src/maemo/modest-main-window.c:
2706 (on_hildon_program_is_topmost_notify): Prevent hibernation
2707 (possible when the application goes to the background in the WM),
2708 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2710 * src/maemo/easysetup/modest-easysetup-wizard.c:
2711 (modest_easysetup_wizard_dialog_init):
2712 * src/maemo/modest-account-settings-dialog.c:
2713 (modest_account_settings_dialog_init):
2714 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2715 (modest_connection_specific_smtp_edit_window_init):
2716 * src/maemo/modest-connection-specific-smtp-window.c:
2717 (modest_connection_specific_smtp_window_init):
2718 * src/maemo/modest-signature-editor-dialog.c:
2719 (modest_signature_editor_dialog_init):
2720 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2721 prevent hibernation while any of these account settings dialogs are open.
2723 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2725 * src/maemo/Makefile.am:
2726 * src/maemo/modest-osso-state-saving.c:
2727 * src/maemo/modest-osso-state-saving.h: Added
2728 modest_osso_load_state() and modest_osso_save_state() though they do
2729 nothing now. They should iterate through all the open windows and load/save
2731 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2732 save state when closing.
2734 * src/maemo/modest-main-window.c:
2735 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2736 Add a notification handler for the HildonProgram::is-topmost property,
2737 so we can allow hibernation when the application goes into the background.
2738 But we still need to detect when the accounts setup windows are open so
2739 we can stop hibernation when they are open.
2740 To do this, I also added the main window the HildonProgram. This might have
2741 other side-effects/benefits, and should maybe be done for other windows.
2743 * src/maemo/modest-osso-autosave-callbacks.h:
2744 * src/maemo/modest-osso-autosave-callbacks.c:
2745 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2746 though it does not do anything yet, and we might never need this to do
2747 anything. For instance, we already save drafts.
2749 * src/maemo/modest-platform.c: (modest_platform_init):
2750 Specify the libosso auto-save callback.
2752 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2754 * src/maemo/modest-platform.c:
2755 (modest_platform_set_update_interval):
2756 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2757 aparently stays valid between application instances, so we can use this
2758 to remove and reset it later. According to a maemo-developers email from
2761 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2763 * configure.ac: Depend on libalarm for Maemo.
2765 * src/dbus_api/modest-dbus-api.h:
2766 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2767 (on_send_receive), (modest_dbus_req_handler):
2768 Handle a SEND_RECEIVE D-Bus method.
2770 * libmodest-dbus-client/libmodest-dbus-client.c:
2771 (libmodest_dbus_client_send_and_receive):
2772 * libmodest-dbus-client/libmodest-dbus-client.h:
2773 Add C convenience functions for calling the new D-Bus method.
2775 * src/modest-platform.h:
2776 * src/gnome/modest-platform.c:
2777 * src/maemo/modest-platform.c:
2778 Added modest_platform_set_update_interval(), which uses the
2779 alarmd API on Maemo.
2780 (modest_platform_init),
2781 Call modest_platform_set_update_interval(), using a hard-coded
2782 interval for now (until the global settings dialog is implemented),
2783 though I am not sure that this makes sense yet.
2785 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2787 * src/dbus_api/modest-dbus-callbacks.c:
2788 (modest_osso_cb_hw_state_handler):
2789 * src/dbus_api/modest-dbus-callbacks.h:
2790 * src/maemo/modest-platform.c: (modest_platform_init):
2791 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2792 in case this has some effect on the ability for Maemo to ping the
2795 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2797 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2798 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2799 warning. It is probably a logic error, but I need to fix the build.
2801 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2803 * src/modest-account-mgr.h:
2804 * src/modest-account-mgr.c:
2805 (modest_account_mgr_account_names): Add a gboolean enabled_only
2806 parameter, so we can get lists of onlt the enabled accounts.
2808 (modest_account_mgr_add_account),,
2809 (modest_account_mgr_account_with_display_name_exists):
2810 * src/maemo/modest-msg-edit-window.c: (get_transports):
2811 * src/modest-account-mgr-helpers.c:
2812 (modest_account_mgr_set_first_account_as_default):
2813 * src/modest-init.c: (init_default_account_maybe):
2814 * src/modest-tny-account-store.c: (get_accounts):
2815 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2816 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2817 * tests/check_account-mgr.c: (START_TEST):
2818 Provide the extra parameter, as appropriate.
2820 * src/widgets/modest-account-view.c: (update_account_view):
2821 Do not show disabled accounts (meaning that there is no way to
2822 enable/disable accounts in the UI (the feature is not in our UI
2823 specification), so we can use this internally only to mark unfinished
2824 or temporary account data.
2826 * src/maemo/easysetup/modest-easysetup-wizard.c:
2827 (create_account): Add boolean enable parameter, so we can specify FALSE
2828 to create the temporary account.
2829 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2830 (on_before_next): When finishing, when there is a temporary account, just
2832 Also, use a timeout to delay the showing of the dialog until gconf is likely
2833 to return correct information, due to a maemo gconf bug that is fixed in
2834 osso 1.1, but not yet in Bora.
2835 However, the dialog stays on screen after it is destroyed.
2837 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2838 for invalid data when cancelling. Use a hildon note instead of a dialog
2839 to complain about invalid data. Do not show the account-saved note if the
2840 account is disabled (a temporary account that will not really be saved for use
2843 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2845 * src/modest-account-mgr-helpers.h:
2846 * src/modest-account-mgr-helpers.c:
2847 Added modest_account_mgr_unset_default_account(),
2848 Added modest_account_mgr_set_first_account_as_default().
2850 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2851 If it was the default account, unset the default account name.
2853 * src/maemo/modest-account-view-window.c:
2854 (on_delete_button_clicked): If it was the default account,
2855 set the first remaining account as the default instead.
2857 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2858 a NULL account or a NULL default account, to prevent a crash. This should
2859 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2862 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2864 * src/widgets/modest-recpt-editor.c:
2865 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2866 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2867 TODO comment for this. This fixes the build.
2869 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2870 be the best place for it. This will in future update all auto-update accounts,
2871 rather than just the current/default account, when that gconf key exists.
2872 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2873 if there are no accounts, before calling do_send_receive().
2874 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2876 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2877 * src/maemo/modest-main-window-ui.h:
2878 * src/maemo/modest-main-window.c: (on_connection_changed),
2879 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2880 directly, becaue the signal handler does more.
2882 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2884 * src/modest-account-mgr-helpers.c:
2885 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2886 for the case that the account does not exist.
2888 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2889 (equivalent to the modest account name) rather than the tinymail account name
2890 (equivalent to the modest account title - human readable) to get the account data.
2891 Check for null account data to prevent the crash, and add a TODO comment saying that
2892 this needs fixing because it is using the server account name instead of the account name.
2894 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2896 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2897 * src/maemo/modest-account-settings-dialog.c: (show_error),
2899 Use hildon_note_new_information() for informative and error messages,
2900 which seems to be expected for Maemo applications (no documentation that I know of
2901 says this). I am surprised that there is no distinction between info and error
2904 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2906 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2907 it is easy to find where this is used.
2909 * src/maemo/easysetup/modest-easysetup-wizard.c:
2910 (create_page_welcome), (create_page_account_details),
2911 (create_page_user_details), (create_page_complete_easysetup),
2912 (create_page_custom_incoming), (create_page_custom_outgoing),
2913 (create_page_complete_custom):
2914 * src/maemo/modest-account-settings-dialog.c:
2915 (create_page_account_details), (create_page_user_details),
2916 (create_page_incoming), (create_page_outgoing):
2917 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2918 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2919 (modest_connection_specific_smtp_edit_window_init):
2920 * src/maemo/modest-connection-specific-smtp-window.c:
2921 (modest_connection_specific_smtp_window_init):
2922 * src/maemo/modest-signature-editor-dialog.c:
2923 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2924 and scrolling policy as per the Email Application Layout Guide, if I have
2927 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2929 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2930 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2931 which were empty, because these vfuncs have been removed from TnyAccountStore.
2932 This fixes the build.
2934 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/modest-main-window.c:
2937 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2938 showing/hiding it. Added TODO because it probably should not be NULL.
2939 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2940 because unnecessary g_warnings() make degugging difficult.
2942 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2944 * src/maemo/modest-msg-edit-window.c:
2945 (modest_msg_edit_window_select_color),
2946 (modest_msg_edit_window_select_background_color): 2 const corrections and
2947 moving 2 #endifs before closing brackets, to fix the build.
2949 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2951 * src/maemo/easysetup/modest-easysetup-wizard.h:
2952 * src/maemo/easysetup/modest-easysetup-wizard.c:
2953 (modest_easysetup_wizard_dialog_finalize),
2954 (on_button_edit_advanced_settings), (create_page_complete_custom),
2955 (on_response), (create_account):
2956 Implement the Advanced Settings edit button, by saving the account information,
2957 for the Advanded Settings dialog to use directly from gconf, and removing it
2958 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2959 Bug #5533 in the projects.maemo.org bugzilla.
2961 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2963 * src/maemo/modest-msg-view-window.c:
2964 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2965 when opening a message window.
2967 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2969 * src/maemo/easysetup/modest-easysetup-wizard.c:
2970 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2973 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2974 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2975 gconf settings. I probably added more checks than necessary, but that is safer.
2977 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2978 variable to fix the build, but this seems to be used when it is still NULL.
2980 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2982 * src/modest-platform.h:
2983 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2984 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2985 * src/modest-main.c: Implement this function so we can avoid using
2986 maemo-specific API from cross-platform code.
2988 * src/modest-tny-account-store.c:
2989 (get_smtp_specific_transport_account_for_open_connection):
2990 * src/modest-ui-actions.c: (check_for_connection),
2991 (modest_ui_actions_on_item_not_found):
2992 Use modest_platform_connect_and_wait() and put #idefs around other
2993 maemo-specific code, because only maemo currently has a way to
2994 identify connection names.
2996 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2998 * src/modest-tny-account-store.h:
2999 * src/modest-tny-account-store.c:
3000 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3001 the connection-specific SMTP server settings in the configuration.
3003 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3005 * src/maemo/modest-main-window.c: (on_connection_changed),
3007 * src/modest-main.c: (main), (start_ui), (send_mail):
3008 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3009 that is what is intended.
3011 * src/modest-ui-actions.c: (action_send), (action_receive),
3012 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3013 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3014 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3015 SMTP server is used when it is specified.
3017 (modest_ui_actions_on_send_receive):
3018 Check that a connection is open before proceeding.
3019 Receive and then send, instead of vice-versa, as per the specification.
3021 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3023 * src/modest-mail-operation.c:
3024 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3025 though I guess it should be something other than NULL.
3027 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3029 * src/maemo/easysetup/modest-easysetup-wizard.c:
3030 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3031 combo twice, to avoid an g_warning and to make it visible again.
3032 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3033 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3034 (already intended) dereference when detaching, because we then recreate the menu.
3035 But I am not sure why the warning was happening, and it is possible that this is a memory
3038 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3040 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3041 and uri_parse_mailto() utility functions.
3042 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3044 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3046 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3048 * src/dbus_api/modest-dbus-api.h:
3049 * src/dbus_api/modest-dbus-callbacks.c:
3050 Use an idle callback to execute the modest code in the application's own thread.
3051 Remove the helloworld example method.
3052 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3053 parsed, and the open-message method is not implemented because this is not yet implemented in
3055 * libmodest-dbus-client/libmodest-dbus-client.c:
3056 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3057 (libmodest_dbus_client_open_message):
3058 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3060 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3061 body without crashing.
3063 * tests/dbus_api/Makefile.am:
3064 * tests/dbus_api/test_mail_to.c:
3065 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3067 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3069 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3070 Added file to fix the build. Sorry.
3072 * src/dbus_api/Makefile.am:
3073 * src/dbus_api/modest-dbus-api.h:
3074 * src/dbus_api/modest-dbus-callbacks.h:
3075 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3076 (modest_dbus_req_handler):
3077 Put constants in a separate header so it can be reused by the
3078 client library, without duplication
3080 * libmodest-dbus-client/Makefile.am:
3081 * libmodest-dbus-client/libmodest-dbus-client.c:
3082 (libmodest_dbus_client_call_helloworld),
3083 (libmodfest_dbus_client_send_mail),
3084 (libmodfest_dbus_client_mailto),
3085 (libmodfest_dbus_client_open_message):
3086 * libmodest-dbus-client/libmodest-dbus-client.h:
3087 (Partly) Implement a send_mail D-Bus method.
3089 * tests/dbus_api/Makefile.am:
3090 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3091 the send_email D-Bus method.
3093 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3097 * libmodest-dbus-client/Makefile.am:
3098 * libmodest-dbus-client/libmodest-dbus-client.c:
3099 * libmodest-dbus-client/libmodest-dbus-client.h:
3100 * tests/dbus_api/Makefile.am:
3101 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3102 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3104 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3106 * src/maemo/easysetup/modest-easysetup-wizard.c:
3107 (create_page_account_details):
3108 * src/maemo/modest-account-settings-dialog.c:
3109 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3110 widgets, because this might not be the default in future versions of the Maemo GTK+.
3111 However, I can not not get capitalization to work even in a simple test case.
3113 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3115 * src/maemo/easysetup/modest-easysetup-wizard.c:
3116 (create_page_custom_incoming), (create_page_custom_outgoing):
3117 * src/maemo/modest-account-settings-dialog.c:
3118 (create_page_account_details), (create_page_incoming),
3119 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3120 instead of using gtk_check_button_with_label(), so they are aligned like the other
3121 widgets, as per the UI spec.
3123 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3125 * src/maemo/easysetup/modest-easysetup-wizard.c:
3126 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3127 * src/widgets/modest-validating-entry.c:
3128 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3129 Modest prefix instead of an EasySetup prefix.
3131 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3133 * src/widgets/modest-validating-entry.h:
3134 * src/widgets/modest-validating-entry.c: (on_insert_text),
3135 Added easysetup_validating_entry_set_max_func(), used to set a callback
3136 to call when the max number of characters is reached. GtkEntry has a max-length
3137 already but is silent about it.
3139 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3140 (create_page_account_details), (create_page_user_details),
3142 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3143 (create_page_account_details), (create_page_user_details),
3144 (create_page_outgoing):
3145 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3146 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3147 the UI spec, when the user tries to enter more than the max number of characters.
3149 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3151 * src/maemo/easysetup/modest-easysetup-wizard.c:
3152 (create_page_user_details), (create_page_custom_incoming),
3153 (create_page_custom_outgoing):
3154 * src/maemo/modest-account-settings-dialog.c:
3155 (create_page_user_details), (create_page_incoming),
3156 (create_page_outgoing):
3157 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3158 (modest_connection_specific_smtp_edit_window_init):
3159 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3160 not appropriate. Bad Maemo-specific defaults!.
3162 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3164 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3165 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3166 (modest_signature_editor_dialog_set_settings):
3167 Disable the label and textview when the checkbox is disabled, and use the
3168 specified (UI spec) default signature text.
3170 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3172 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3173 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3175 * src/modest-defs.h:
3176 * src/modest-account-mgr-helpers.h:
3177 * src/modest-account-mgr-helpers.c:
3178 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3180 * src/maemo/Makefile.am:
3181 * src/maemo/modest-signature-editor-dialog.c:
3182 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3185 * src/maemo/modest-account-settings-dialog.h:
3186 * src/maemo/modest-account-settings-dialog.c:
3187 (modest_account_settings_dialog_finalize), (on_button_signature),
3188 (save_configuration): Use the new dialog when the Edit button is pressed, and
3189 save the changes if necessary, as per the UI spec.
3191 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3193 * src/maemo/Makefile.am:
3194 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3195 based on maemo-develoers email from Dirk.
3197 * src/maemo/easysetup/modest-easysetup-wizard.c:
3198 (create_page_welcome), (create_page_account_details),
3199 (create_page_user_details), (create_page_complete_easysetup),
3200 (create_page_custom_incoming), (create_page_custom_outgoing),
3201 (create_page_complete_custom),
3202 (modest_easysetup_wizard_dialog_init):
3203 * src/maemo/modest-account-settings-dialog.c:
3204 (create_page_account_details), (create_page_user_details),
3205 (create_page_incoming), (create_page_outgoing),
3206 (modest_account_settings_dialog_init):
3207 * src/maemo/modest-connection-specific-smtp-window.c:
3208 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3210 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3212 * src/maemo/easysetup/modest-easysetup-wizard.c:
3213 (create_page_account_details), (create_page_custom_outgoing),
3214 (create_page_complete_custom):
3215 * src/maemo/modest-account-settings-dialog.c:
3216 (create_page_user_details), (create_page_incoming),
3217 (create_page_outgoing):
3218 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3219 (modest_connection_specific_smtp_edit_window_init):
3220 Use the correct (UI spec) port min/max, and use horizontal separators,
3223 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3225 * src/maemo/easysetup/modest-easysetup-wizard.c:
3226 (set_default_custom_servernames):
3227 * src/maemo/modest-account-settings-dialog.c:
3228 (create_page_incoming), (on_combo_outgoing_security_changed),
3229 (on_combo_incoming_security_changed), (create_page_outgoing),
3230 (modest_account_settings_dialog_set_account_name),
3231 (save_configuration):
3232 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3233 (on_combo_security_changed),
3234 (modest_connection_specific_smtp_edit_window_init),
3235 (modest_connection_specific_smtp_edit_window_set_connection),
3236 (modest_connection_specific_smtp_edit_window_get_settings):
3237 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3240 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3243 * src/maemo/easysetup/modest-easysetup-wizard.c:
3244 (create_page_custom_outgoing), (create_page_complete_custom):
3245 * src/maemo/modest-account-settings-dialog.c:
3246 (create_page_user_details), (create_page_outgoing):
3247 * src/maemo/modest-account-view-window.c: (button_box_new):
3248 Use changed logical IDs as per the most recent UI spec:
3249 mcen_bd_emailsetup_edit -> mcen_bd_edit
3250 mcen_bd_emailsetup_delete -> mcen_bd_delete
3251 mcen_bd_emailsetup_close -> mcen_bd_close
3253 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3257 * src/dbus_api/Makefile.am:
3258 * src/dbus_api/modest-dbus-callbacks.c:
3259 * src/dbus_api/modest-dbus-callbacks.h:
3260 * src/maemo/modest-platform.c: (modest_platform_init):
3261 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3263 * tests/Makefile.am:
3264 * tests/dbus_api/Makefile.am:
3265 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3267 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3269 * src/maemo/modest-account-settings-dialog.c:
3270 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3271 Removed unnecessary includes.
3273 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3275 * src/maemo/easysetup/modest-easysetup-wizard.c:
3276 * src/maemo/modest-account-settings-dialog.c:
3277 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3278 * src/widgets/Makefile.am:
3279 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3280 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3281 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3282 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3283 * src/widgets/modest-secureauth-combo-box.c:
3284 * src/widgets/modest-secureauth-combo-box.h:
3285 * src/widgets/modest-serversecurity-combo-box.c:
3286 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3287 made the GObject names more consistent with the rest of the Modest code.
3289 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3291 * src/maemo/easysetup/Makefile.am:
3292 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3293 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3294 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3295 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3296 * src/maemo/easysetup/modest-easysetup-wizard.c:
3297 * src/maemo/easysetup/modest-validating-entry.c:
3298 * src/maemo/easysetup/modest-validating-entry.h:
3299 * src/maemo/modest-account-settings-dialog.c:
3300 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3301 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3302 widgets/ because they are used outside of easysetup too. After checking in,
3303 svn will allow me to rename them too.
3305 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3307 * src/gnome/modest-msg-edit-window.c:
3308 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3309 linker error, to fix the build on the GNOME platform.
3310 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3311 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3312 ifdefed out to avoid a warning.
3314 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3316 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3317 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3318 some alternative for GTK+ 2.6.
3320 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3322 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3324 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3325 specified for EmailAccountsDialog in UI spec.
3327 * src/maemo/easysetup/modest-easysetup-wizard.c:
3328 * src/maemo/easysetup/modest-easysetup-wizard.h:
3329 * src/maemo/modest-account-settings-dialog.c:
3330 * src/maemo/modest-account-settings-dialog.h:
3331 Reuse a member window widget for the connection-specific SMTP server accounts,
3332 so we can tell it to create/save the accounts only if we actually save changes.
3334 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3335 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3336 (modest_connection_specific_smtp_edit_window_get_settings):
3337 Return a struct instance for temporarily remembering the entered data.
3339 * src/maemo/modest-connection-specific-smtp-window.h:
3340 * src/maemo/modest-connection-specific-smtp-window.c:
3341 (modest_connection_specific_smtp_window_finalize),
3342 (modest_connection_specific_smtp_window_fill_with_connections),
3344 (modest_connection_specific_smtp_window_save_server_accounts),
3345 (update_model_server_names): Do not actually save data until asked,
3346 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3348 (on_selection_changed),
3349 (modest_connection_specific_smtp_window_init): Disable the edit
3350 button when nothing is selected.
3352 * src/modest-account-mgr-helpers.c:
3353 * src/modest-account-mgr-helpers.h:
3354 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3357 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3359 * src/modest-account-mgr-helpers.h:
3360 * src/modest-account-mgr-helpers.c:
3361 (modest_account_mgr_get_unused_account_name),
3362 (modest_account_mgr_get_unused_account_display_name): Added these
3363 utility functions, to avoid code duplication.
3365 * src/maemo/easysetup/modest-easysetup-wizard.c:
3366 (create_page_account_details), (create_account):
3367 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3368 (on_combo_security_changed),
3369 (modest_connection_specific_smtp_edit_window_init),
3370 (modest_connection_specific_smtp_edit_window_save_settings):
3371 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3372 * src/maemo/modest-connection-specific-smtp-window.c:
3373 (modest_connection_specific_smtp_window_finalize),
3374 (modest_connection_specific_smtp_window_fill_with_connections),
3375 (on_button_edit), (modest_connection_specific_smtp_window_init):
3376 * src/maemo/modest-connection-specific-smtp-window.h:
3377 Implementing saving of connection-specific server accounts.
3379 But I need to refactor this so we can save the data for each
3380 possible connection-specific account and only actually create the server accounts
3381 when the easysetup finished, or the OK button is pressed on the account settings
3384 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3387 (on_combo_security_changed):
3388 (modest_connection_specific_smtp_edit_window_init):
3389 Auto-fill the port number as in the account settings.
3391 (modest_connection_specific_smtp_edit_window_set_connection):
3392 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3393 * src/maemo/modest-connection-specific-smtp-window.c:
3394 (fill_with_connections), (on_button_edit),
3395 (modest_connection_specific_smtp_window_init):
3396 Turn the edit window into a dialog to simplify the code, and
3397 set a WM hint as in a GtkDialog, because only a popup can be on top of
3398 another window in Maemo, and popups usually have no WM decoration.
3400 * src/modest-defs.h:
3401 * src/modest-account-mgr-helpers.c:
3402 (modest_account_mgr_set_connection_specific_smtp),
3403 (modest_account_mgr_remove_connection_specific_smtp),
3404 (modest_account_mgr_get_connection_specific_smtp):
3405 * src/modest-account-mgr-helpers.h: Some functions to write the
3406 connection-specific SMTP server information. Not yet used.
3409 * src/widgets/modest-folder-view.c: (text_cell_data):
3410 Fix a warning about an uninitialized variable.
3411 (on_configuration_key_changed): Put an #ifdef around the use
3412 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3414 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3416 * src/maemo/modest-account-settings-dialog.h:
3417 * src/maemo/modest-account-settings-dialog.c:
3418 Added connect_for_modified() utility function to mark the new modified boolean.
3420 (create_page_account_details), (create_page_user_details),
3421 (create_page_incoming), (create_page_outgoing), (on_response),
3422 (modest_account_settings_dialog_init),
3423 (modest_account_settings_dialog_set_account_name):
3424 Only warn about unsaved changes when there are actually unsaved changes.
3426 * src/modest-account-mgr-helpers.c:
3427 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3428 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3429 to get the data from there in future.
3431 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3433 * src/modest-defs.h:
3435 * src/modest-account-mgr-helpers.h:
3436 * src/modest-account-mgr-helpers.c:
3437 Store the security account setting in a single conf key instead of using
3438 the options list, so that the list is left for just the to-be-removed camel hack,
3439 and because gconf_client_set_list() is failing for some reason.
3441 * src/modest-account-mgr.c:
3442 (modest_account_mgr_add_server_account):
3443 * src/maemo/modest-account-settings-dialog.c:
3444 (modest_account_settings_dialog_set_account_name),
3445 (save_configuration): Use the renamed functions.
3448 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3450 * src/widgets/Makefile.am:
3451 * src/widgets/modest-limit-retrieve-combo-box.c:
3452 * src/widgets/modest-limit-retrieve-combo-box.h:
3453 * src/widgets/modest-retrieve-combo-box.c:
3454 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3455 the account settings dialog.
3457 * src/modest-defs.h:
3458 * src/modest-account-mgr-helpers.h:
3459 * src/modest-account-mgr-helpers.c:
3460 (modest_server_account_get_option_secure_auth),
3461 (modest_server_account_set_option_secure_auth):
3462 * src/modest-account-mgr.c:
3463 (modest_account_mgr_add_server_account):
3464 Use the existing AUTH_MECH conf key for the secure-auth setting,
3465 instead of putting it in the list options, because this was actually used already.
3467 * src/maemo/modest-account-settings-dialog.c:
3468 (create_page_account_details),
3469 (modest_account_settings_dialog_set_account_name),
3470 (save_configuration):
3471 * src/maemo/modest-account-settings-dialog.h:
3472 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3473 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3475 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3477 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3478 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3479 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3481 * src/modest-defs.h:
3482 * src/maemo/modest-account-settings-dialog.c:
3483 (create_page_incoming), (on_combo_outgoing_security_changed),
3484 (on_combo_incoming_security_changed), (create_page_outgoing),
3485 (modest_account_settings_dialog_set_account_name),
3486 (save_configuration): Load/Save the port number, and change it when the
3487 security combo changes, to suitable defaults.
3489 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3491 * src/modest-account-mgr.c:
3492 (modest_account_mgr_add_server_account): Set the security and secure-auth
3493 options, and add a comment saying that the other camel-specific options should be
3496 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3498 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3500 * src/modest-tny-account-store.c: (account_list_free),
3501 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3502 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3505 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3507 * src/modest-protocol-info.c:
3508 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3509 is required by our UI spec. Maybe something in our implementation will use this eventually.
3510 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3511 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3512 instead of the previous 0 placeholder.
3514 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3515 secure-auth settings.
3516 * src/modest-account-mgr-helpers.h:
3517 * src/modest-account-mgr-helpers.c:
3518 (modest_server_account_data_get_option_secure_auth),
3519 (modest_server_account_set_option_secure_auth),
3520 (modest_server_account_data_get_option_security),
3521 (modest_server_account_set_option_security): Added this API for getting and setting the security
3522 and secure-auth settings.
3524 * src/maemo/modest-account-settings-dialog.h:
3525 * src/maemo/modest-account-settings-dialog.c:
3526 (modest_account_settings_dialog_finalize), (check_data),
3527 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3528 about changing titles.
3529 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3530 (save_configuration): Save the security and secure-auth settings.
3532 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3533 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3535 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3537 * src/modest-defs.h:
3538 * src/modest-account-mgr.c:
3539 (modest_account_mgr_add_server_account):
3540 Added and used defines for the options key and value pair strings,
3541 that are used so far, though they do not seem to correspond to anything in our
3542 UI specs or ModestProtocol enum.
3544 * src/modest-account-mgr-helpers.h:
3545 * src/modest-account-mgr-helpers.c:
3546 (compare_option_strings_for_name),
3547 (modest_server_account_data_get_option_value),
3548 (modest_server_account_data_get_option_bool),
3549 (modest_account_mgr_get_server_account_option):
3550 Added helper functions for parsing the options GSList.
3552 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3554 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3555 display name is based on the supplied account name.
3556 * src/modest-account-mgr.c:
3557 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3558 with an inefficient, but good-enough, implementation.
3560 * src/maemo/easysetup/modest-easysetup-wizard.c:
3561 (create_page_account_details), (on_before_next), (create_account):
3562 Check for existing display names rather than (non-user-visible) account names, and just
3563 create and set a unique account name at the end.
3565 * src/maemo/modest-account-settings-dialog.c:
3566 (modest_account_settings_dialog_init),
3567 (modest_account_settings_dialog_set_account_name),
3568 (create_page_incoming): Show the display name, instead of the account name.
3569 (on_response): Do some (not all) extra checks, as in the UI spec.
3570 (save_configuration): Save the display name if it was changed.
3572 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3574 * po/en_GB.po: Added needed logical ID and translation.
3575 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3576 (init_view): Made the is-default column clicking work.
3578 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3581 * src/maemo/easysetup/Makefile.am:
3582 * src/maemo/easysetup/modest-easysetup-wizard.c:
3583 (modest_easysetup_wizard_dialog_init):
3584 * src/maemo/easysetup/provider-data-test.keyfile:
3585 * src/maemo/easysetup/provider-data.keyfile:
3586 Moved the provider data file to the new modest-providers-data package and used it from there.
3588 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3590 * src/modest-local-folder-info.c:
3591 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3592 N_() was already used on the static strings, but this just marks it for translation without
3593 using the translation.
3595 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3597 * src/maemo/modest-account-settings-dialog.c:
3598 (create_page_incoming),
3599 (modest_account_settings_dialog_set_account_name):
3600 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3601 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3602 I will do this if nobody else gets there first.
3604 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3606 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3607 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3608 save the security stuff.
3610 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3612 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3613 Set the email address and user fullname, which I now see must be
3616 * src/maemo/modest-account-settings-dialog.h:
3617 * src/maemo/modest-account-settings-dialog.c:
3619 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3620 leave-on-server and authentication.
3621 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3624 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3627 * src/maemo/modest-account-settings-dialog.c:
3628 * src/maemo/modest-account-settings-dialog.h:
3629 Most (but not all) of the widgets are now present as specified by the UI spec.
3630 No changes are yet saved, and some details are not properly shown yet.
3632 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3634 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3636 * src/maemo/Makefile.am:
3637 * src/maemo/modest-account-settings-dialog.c:
3638 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3639 an existing account. Doesn't do much yet.
3641 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3642 Open the accounts settings dialog when Edit is clicked.
3644 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3646 * src/maemo/easysetup/Makefile.am:
3647 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3649 * src/maemo/easysetup/modest-easysetup-wizard.c:
3650 (modest_easysetup_wizard_dialog_init):
3651 Try to get the source directory from the build system,
3652 instead of hard-coding "./" into the source code, when opening our local
3653 copies of the configuration files.
3654 But this still fails when opening the wizard from the Accounts window,
3655 maybe because the working directory seems to change at runtime.
3656 So the wizard will fail the second time unless you copy the files into their
3657 proper locations - see the stdout warnings for the paths.
3659 (create_page_account_details),(on_before_next):
3660 Check for existing non-server accounts instead of server accounts,
3661 so the default account name is useful again, and to prevent trying to
3664 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3665 Show the wizard when New is clicked.
3667 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3668 (init_view): Show the column headers, and show the columns that are
3669 specified in the UI specs. However, something in Maemo's GTK+ prevents
3670 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3671 change the default account. This is despite unsetting the special properties.
3673 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3675 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3676 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3677 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3678 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3679 to make that clearer.
3680 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3682 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3684 * src/maemo/modest-account-view-window.c:
3685 (modest_account_view_window_init),
3686 (modest_account_view_window_new):
3687 Use the same buttons as specified in the
3688 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3689 the existing widgets, which never had a chance of working.
3690 Put the ModestAccountView treeview in a scrolled window.
3691 Do not repeat the initialization in both _init() and _new().
3693 * src/widgets/modest-account-view.c: (update_account_view):
3694 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3695 this widget and window shows no accounts.
3697 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3699 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3701 * src/maemo/easysetup/modest-easysetup-wizard.c:
3702 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3703 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3704 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3707 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3708 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3709 accounts exist yet, as in the UI spec.
3711 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3713 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3715 * src/maemo/Makefile.am:
3716 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3717 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3718 New window for editing connection-specific smtp details.
3719 Not fully implemented.
3721 * src/maemo/modest-connection-specific-smtp-window.c:
3722 (modest_connection_specific_smtp_window_finalize) :
3723 unref the tree model.
3724 (on_button_edit): Show the edit window.
3726 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3728 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3731 * src/maemo/Makefile.am:
3732 * src/maemo/modest-connection-specific-smtp-window.c:
3733 * src/maemo/modest-connection-specific-smtp-window.h:
3734 New window for showing the list of connections, for connection-specific
3735 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3736 * src/maemo/easysetup/modest-easysetup-wizard.c:
3737 (create_page_custom_outgoing): Show the new window when the button is clicked.
3739 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3741 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3742 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3743 * src/maemo/modest-msg-edit-window.c:
3744 (modest_msg_edit_window_insert_image):
3745 * src/modest-conf.c: (modest_conf_key_escape):
3746 * src/modest-mail-operation.c:
3747 (modest_mail_operation_send_new_mail):
3748 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3749 (modest_ui_actions_on_new_account):
3750 * src/widgets/modest-attachment-view.c: (update_filename_request):
3751 * src/widgets/modest-mail-header-view.c:
3752 Corrected warnings that were breaking the build, by commenting out unused variables,
3753 and a function, and by including a header.
3755 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3757 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3758 so we can #ifdef around platform-specific code when necessary.
3759 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3760 to allow this to build for the GNOME platform too.
3762 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3764 * src/maemo/easysetup/modest-easysetup-wizard.c:
3765 Added util_increment_name() and used it in create_page_account_details()
3766 to make sure that the default account name is always a new name.
3768 (modest_easysetup_wizard_dialog_init),
3769 (set_default_custom_servernames): Some minor memory management fixes.
3771 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3775 * src/modest-runtime.c: (init_i18n): Restored the translation
3776 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3777 are defined in config.h, and the translations are installed.
3779 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3780 is defined for translation.
3782 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3784 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3786 * src/maemo/easysetup/modest-easysetup-wizard.c:
3787 (modest_easysetup_wizard_dialog_init):
3788 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3789 Use realistic paths (though they should use $prefix generically) to the
3790 mcc_mapping and provider-data.keyfile files which might work when they
3791 are installed by the future version of the operator-wizard package,
3792 and then fallback to paths in our source code, with an explanatory
3795 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3799 * src/maemo/Makefile.am:
3800 * src/maemo/easysetup/: Added files from the previously-exernal
3801 osso-modest-easysetup.
3802 * src/maemo/modest-main-window-ui.h:
3803 * src/modest-ui-actions.c:
3804 * src/modest-ui-actions.h:
3805 Added modest_ui_actions_on_new_account() as a signal handler for the
3806 New Account menu item. It shows the easysetup wizard.
3807 * po/en_GB.po: Added additional needed logical IDs and translations.