1 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/dbus_api/modest-dbus-callbacks.c:
4 * src/maemo/easysetup/modest-easysetup-wizard.h:
5 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
6 * src/maemo/modest-connection-specific-smtp-edit-window.c:
7 (modest_connection_specific_smtp_edit_window_init):
8 * src/maemo/modest-maemo-global-settings-dialog.c:
10 * src/maemo/modest-maemo-utils.c:
11 (modest_maemo_utils_setup_images_filechooser):
12 * src/maemo/modest-main-window.c: (create_details_widget):
13 * src/maemo/modest-msg-edit-window.c:
14 (modest_msg_edit_window_attach_file_noninteractive),
15 (modest_msg_edit_window_color_button_change),
16 (modest_msg_edit_window_set_zoom):
17 * src/modest-mail-operation.c: (update_account_thread):
18 * src/modest-tny-account-store.c:
19 * src/modest-tny-account.c:
20 * src/widgets/modest-global-settings-dialog.c:
21 * src/widgets/modest-window.h:
25 2007-06-25 Murray Cumming <murrayc@murrayc.com>
27 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
28 * src/modest-search.c: (modest_search_folder),
29 (modest_search_all_accounts): Actually search only in the specified folder,
30 doing a simple match on the folder ID.
31 * src/modest-search.h: Added a folder field to the ModestSearch struct,
32 and added some documentation.
34 2007-06-22 Armin Burgmeier <armin@openismus.com>
36 * src/maemo/modest-maemo-utils.h:
37 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
38 modest_maemo_utils_get_supported_secure_authentication_methods.
40 * src/maemo/easysetup/modest-easysetup-wizard.c:
41 * src/maemo/modest-account-settings-dialog.c: Show correct error if
42 one occured, not just "Server does not support secure authentication".
44 2007-06-22 Murray Cumming <murrayc@murrayc.com>
46 * src/modest-tny-account-store.c: (get_password):
47 Restored the call to tny_account_set_user() because Philip seems to have
48 stopped this from crashing (by not using the freed string). It still does
49 not work, but now we can test it.
51 2007-06-22 Murray Cumming <murrayc@murrayc.com>
53 * src/maemo/modest-msg-edit-window.c: (init_window):
54 Comment out use of an uninitialzed GtkScrolledWindow variable,
55 to fix the build and stop a crash. Yet again.
57 2007-06-22 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-tny-account-store.c: (get_password):
60 Remove the call to tny_account_set_user() because this actually crashes.
61 As mentioned in the last commit, it is known to not work anyway.
63 2007-06-22 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-tny-account-store.c: (get_password):
66 Use tny_account_set_username() to tell tinymail that the username might
67 have changed too. But tinymail ignores this: see projects.maemo.org
69 * src/modest-ui-actions.c:
70 (modest_ui_actions_on_password_requested): Remove the useless attempt to
71 reset the connection when changing the username, and improve the comments.
72 Save the changed username to gconf at least, so it is used when Modest is
75 2007-06-21 Murray Cumming <murrayc@murrayc.com>
77 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
78 Do not use a query, so that we get all folders, including for POP and
79 local-folders. They work as search criteria too.
80 This fixes projects.maemo.org bug NB#57740.
82 2007-06-21 Murray Cumming <murrayc@murrayc.com>
84 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
85 Comment out the use of hildon_notification_set_sound() because it is
86 not declared, to fix the build. Warnings are serious, people.
88 2007-06-21 Armin Burgmeier <armin@openismus.com>
90 * src/maemo/modest-maemo-utils.h:
91 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
92 modest_maemo_utils_get_supported_secure_authentication_methods()
93 to query authentication methods for a specific user. This should fix
94 projects.maemo.org bug NB#61369.
96 * src/maemo/easysetup/modest-easysetup-wizard.c:
97 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
100 2007-06-21 Murray Cumming <murrayc@murrayc.com>
102 * libmodest-dbus-client/libmodest-dbus-client.h:
103 * libmodest-dbus-client/libmodest-dbus-client.c:
104 (modest_dbus_message_iter_get_search_hit),
105 (libmodest_dbus_client_search):
106 Reorganised and commented this.
107 Removed modest_search_hit_free() from the public API because it
110 Added libmodest_dbus_client_get_folders() and
111 modest_folder_result_list_free().
113 * src/dbus_api/modest-dbus-api.h:
114 * src/dbus_api/modest-dbus-callbacks.c:
115 (modest_dbus_req_filter): Commented. Moved most code to
116 on_dbus_method_search() and added on_dbus_method_get_folders().
118 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
119 of the extra D-Bus handler.
121 * tests/dbus_api/Makefile.am:
122 * tests/dbus_api/test_get_folders.c: New test for
123 libmodest_dbus_client_get_folders(). This seems to return an empty list
124 at the moment. That could be the same error that causes the message list
125 to be empty sometimes.
126 This should help with projects.maemo.org bug NB#57740.
128 2007-06-21 Armin Burgmeier <armin@openismus.com>
130 * src/modest-mail-operation.c: Do not call
131 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
132 notify the operation's end after having set the status to CANCELED for
133 the operation queue to listen on. This fixes a deadlock when there
134 were mail operations in the queue during its finalization.
136 * src/modest-singletons.c: Reordered uninitialization of the account
137 manager to happen after the mail operation queue was uninitialized
138 because the mail operation's in the queue might still try to access
139 the account manager (see modest_mail_operation_notify_end()). This
140 fixes a potential crash when terminating the application.
142 2007-06-21 Murray Cumming <murrayc@murrayc.com>
144 * src/modest-search.c:
145 (search_mime_part_and_child_parts): Moved some code here so we
146 can search recursively in child folders.
147 (modest_search_folder): Search in the message as a mime part, instead
148 of just its child mime parts.
149 (read_chunk), (search_mime_part_ogs):
150 Check how many bytes were read, to prevent an endless loop.
151 Searching in message bodies now works. This finishes the fix for
152 projects.maemo.org bug NB#61007.
154 2007-06-20 Murray Cumming <murrayc@murrayc.com>
156 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
157 Add a g_warning when the item is not a folder.
159 * src/modest-ui-dimming-rules.c:
160 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
161 when selected item is not a folder (for instance, an account), because
162 the UI spec only talks about folders.
163 I am not sure what the UI spec wants, so this might not totally fix
164 projects.maemo.org bug NB#60794.
166 2007-06-20 Murray Cumming <murrayc@murrayc.com>
168 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
169 (load_from_file): Sort the list. The unsorted list would be more noticeable
170 in non-English locales.
172 * src/maemo/modest-msg-edit-window.c:
173 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
174 warning and fix the build.
176 * src/maemo/modest-progress-bar-widget.c:
177 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
178 avoid a g_warning, and probably to avoid a crash.
180 2007-06-20 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-search.c: (modest_search_folder): Check for a GError
183 when calling tny_folder_get_headers(), to show that this is not the cause
186 2007-06-20 Murray Cumming <murrayc@murrayc.com>
188 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
189 Actually set the body query instead of the subject query.
191 * src/modest-search.c: (search_mime_part_ogs),
192 (search_mime_part_strcmp): Remove extra space from the text/* regex,
193 which would probably cause it to fail if we got this far.
195 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
196 to simplify the code.
197 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
198 be causing search-in-body to fail.
200 2007-06-20 Murray Cumming <murrayc@murrayc.com>
202 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
204 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
205 Better debug message when the folder cannot be found.
206 This should help with fixing projects.maemo.org bug #61287.
207 * src/modest-search.c: (add_hit): Do not leak the furl string.
209 2007-06-20 Murray Cumming <murrayc@murrayc.com>
211 * src/modest-ui-actions.c:
212 (modest_ui_actions_on_folder_selection_changed):
213 Do not special-case TNY_MERGE_FOLDER here, because
214 modest_tny_folder_get_account() already does that. This fixes
215 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
216 shown when the Outbox was selected).
218 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
220 * libmodest-dbus-client/libmodest-dbus-client.c:
221 (_dbus_iter_get_string_or_null): Initialize the string variable in
222 case this helps with Dirk's crash.
224 2007-06-19 Murray Cumming <murrayc@murrayc.com>
226 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
227 though it is not implemented yet (this function is maybe not even used),
228 to avoid breaking ABI in future.
229 * libmodest-dbus-client/libmodest-dbus-client.c:
230 (get_attachments_string): Moved some code into this generic function.
231 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
232 sends email. It is maybe not used.
233 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
234 (on_send_mail): Use attachments.
236 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
237 * src/maemo/modest-msg-edit-window.c:
238 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
239 a filename before using it, to fix projects.maemo.org bug NB#58233.
241 2007-06-19 Murray Cumming <murrayc@murrayc.com>
243 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
244 Initialize the continue_download variable to fix the build, and probably
245 to fix randome behaviour.
247 2007-06-18 Armin Burgmeier <armin@openismus.com>
249 * src/modest-tny-send-queue.h:
250 * src/modest-tny-send-queue.c: Keep track of the status of messages in
251 the queue so we can later show it in the UI. Replaced
252 modest_tny_send_queue_msg_is_being_sent() by
253 modest_tny_send_queue_get_msg_status().
255 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
257 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
258 gpointer. This probably was not harmful, but just to be sure.
260 2007-06-18 Murray Cumming <murrayc@murrayc.com>
262 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
263 Fix the build, but leave the function broken on Bora, because
264 hildon_uri_action_get_service() does not exist.
265 osso_uri_action_get_service() does not exist either, it seems.
267 2007-06-18 Murray Cumming <murrayc@murrayc.com>
269 * src/modest-tny-account.c:
270 (modest_tny_account_new_from_server_account):
271 Uncommented the url debug output again, because it is useful for
272 debugging, as I said in the comment.
274 2007-06-18 Murray Cumming <murrayc@murrayc.com>
276 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
278 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
279 for Mameo Bora, to fix the build.
281 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
284 Fixed build with hildon < 0.99
286 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
287 Check if the selected account is busy instead of checking all accounts
289 * src/modest-account-mgr-priv.h:
290 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
291 (modest_account_mgr_init), (compare_account_name),
292 (modest_account_mgr_set_account_busy),
293 (modest_account_mgr_account_is_busy):
294 * src/modest-account-mgr.h:
295 Added busy information to the account manager. It possible to
296 set an account to busy or not busy now.
298 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
299 (modest_mail_operation_update_account),
300 (modest_mail_operation_notify_end):
301 Set the account to busy/not busy depending on the operation state.
303 * src/widgets/modest-account-view.c:
304 (modest_account_view_finalize), (get_last_updated_string),
305 (update_account_view), (on_account_busy_changed), (init_view):
306 Show string "Refreshing..." if the account is currently busy.
308 All this fixes projects.maemo.org bug NB#59711
310 2007-06-14 Armin Burgmeier <armin@openismus.com>
312 * src/widgets/modest-attachments-view.h:
313 * src/widgets/modest-attachments-view.c: Added
314 modest_attachments_view_has_attachments() and fixed coordinate
315 transformation in get_att_view_at_coords(). This fixes attachment
318 * src/widgets/modest-msg-view.c: Make use of
319 modest_attachments_view_has_attachments() to decide whether to show
320 attachments in the header.
322 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
324 * src/maemo/modest-connection-specific-smtp-edit-window.c:
325 (on_change), (on_combo_security_changed),
326 (modest_connection_specific_smtp_edit_window_init),
327 (modest_connection_specific_smtp_edit_window_set_connection),
328 (modest_connection_specific_smtp_edit_window_is_dirty):
329 * src/maemo/modest-connection-specific-smtp-edit-window.h:
330 * src/maemo/modest-connection-specific-smtp-window.c:
333 Show an comfirmation dialog for the smpt-edit-window if there are
334 unsaved changes and the user hits cancel.
335 (projects.maemo.org bug NB#60479)
337 2007-06-14 Armin Burgmeier <armin@openismus.com>
339 * src/maemo/easysetup/modest-easysetup-wizard.c:
340 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
341 address" info in banner instead of node, and select all the text as
342 per UI spec. This fixes projects.maemo.org bug NB#60550.
344 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
346 reviewed by: <delete if not using a buddy>
348 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
349 * src/modest-ui-actions.c: (folder_refreshed_cb):
351 2007-06-14 Murray Cumming <murrayc@murrayc.com>
353 * src/widgets/modest-folder-view.c: (filter_row):
354 Explictly filter out the per-account outbox accounts. I don't know why
355 these only sometimes show up, but now they should never show up in the UI.
356 This should fix projects.maemo.org bug NB#60160.
358 2007-06-14 Murray Cumming <murrayc@murrayc.com>
360 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
361 when the toolbar does not exist yet.
362 * src/modest-widget-memory.c: (save_settings_header_view):
363 Added g_warnings() to help us to discover when we are trying to set
364 an empty columns list in gconf.
366 2007-06-14 Murray Cumming <murrayc@murrayc.com>
370 Added modest_init_get_default_header_view_column_ids().
372 * src/modest-widget-memory.c: (restore_settings_header_view):
373 Use the new function to get defaults, if the gconf key is empty,
374 instead of not creating any columns. This seems to fix the
375 empty right-hand pane problems.
377 * src/widgets/modest-header-view.h: Improved documentation.
379 2007-06-13 Murray Cumming <murrayc@murrayc.com>
381 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
382 Revert the use of the display name as the account name, because this
383 is generally wrong and would break the code that follows.
385 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
387 * src/maemo/easysetup/modest-easysetup-wizard.c:
388 (check_for_supported_auth_methods), (on_before_next),
391 More correct fix for projects.maemo.org bug NB# 58991
392 Do not longer accept AUTH_PASSWORD as secure method and choose
393 correct method when creating the account.
395 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
397 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
398 Fixed projects.maemo.org bug NB# 58991
400 2007-06-13 Murray Cumming <murrayc@murrayc.com>
402 * src/modest-init.c: (modest_init_init_core),
403 (modest_init_local_folders): Fixed compilation errors.
405 2007-06-13 Murray Cumming <murrayc@murrayc.com>
407 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
408 Remove unnecessary lib/include, though it is good in principle when needed.
410 * src/modest-init.c: (modest_init_one_local_folder),
411 (modest_init_local_folders):
412 * src/modest-init.h: Initialize the .modest library for memory cards,
413 instead of just doing nothing for them. This should allow us to create
414 folders there, fixing projects.maemo.org bug NB#59297.
416 2007-06-13 Murray Cumming <murrayc@murrayc.com>
418 * libmodest-dbus-client/libmodest-dbus-client.c:
419 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
420 (libmodest_dbus_client_compose_mail),
421 (libmodest_dbus_client_open_message),
422 (libmodest_dbus_client_send_and_receive),
423 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
425 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
426 (on_idle_open_message), (modest_dbus_req_handler),
427 (search_result_to_message), (modest_dbus_req_filter):
428 * src/modest-search.c: (add_hit), (modest_search_folder),
429 (modest_search_all_accounts): Improved debug messages.
431 * tests/dbus_api/test_open_message.c: (main): Improved comments.
433 * src/modest-tny-account-store.c:
434 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
437 2007-06-13 Murray Cumming <murrayc@murrayc.com>
440 2007-06-12 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-tny-account-store.c: (get_server_accounts):
443 Call modest_tny_local_folders_account_add_merged_outbox_folders()
444 even when there are no accounts, so that the Outbox folder is always
445 visible. This fixes projects.maemo.org bug NB#60158.
447 2007-06-12 Murray Cumming <murrayc@murrayc.com>
449 * src/maemo/modest-main-window.c: (create_details_widget):
450 Use the mcen_va_never logical ID.
452 2007-06-12 Murray Cumming <murrayc@murrayc.com>
454 * src/dbus_api/modest-dbus-api.h:
455 * src/dbus_api/modest-dbus-callbacks.c:
456 (on_idle_open_default_inbox), (on_open_default_inbox),
457 (modest_dbus_req_handler):
458 Added a new OpenDefaultInbox method.
460 * libmodest-dbus-client/libmodest-dbus-client.h:
461 * libmodest-dbus-client/libmodest-dbus-client.c:
462 Added libmodest_dbus_client_open_default_inbox() to call the new
463 dbus method. This should be useful to projects.maemo.org bug NB#57214,
464 though it should maybe be used by a new osso-email-interface function.
466 * tests/dbus_api/Makefile.am:
467 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
470 2007-06-12 Murray Cumming <murrayc@murrayc.com>
472 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
473 NULL, so that the signals get all the keys. This should not actually
474 change any behaviour because we currently update everything when anything
477 2007-06-12 Murray Cumming <murrayc@murrayc.com>
479 * src/widgets/modest-folder-view.c: (text_cell_data),
480 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
481 (find_inbox_iter): If tinymail tells us that the folder is
482 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
483 This causes the inbox to be selected at startup, fixing part of
484 projects.maemo.org bug NB#56305.
486 * src/modest-ui-dimming-rules.c:
487 (modest_ui_dimming_rules_on_tools_smtp_servers):
488 * src/modest-ui-dimming-rules.h: Added a callback function to dim
489 the SMTP servers menu item.
490 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
491 that the SMTP Servers menu item is dimmed when there are no accounts,
492 as a future version of the UI spec will require. This fixes
493 projects.maemo.org bug NB#56305.
495 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
497 * src/maemo/modest-maemo-utils.c:
498 (modest_maemo_utils_get_supported_secure_authentication_methods):
499 Added label to dialog instead of unreadable title
501 * src/maemo/modest-main-window.c: (sync_accounts_cb),
502 (modest_main_window_new):
503 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
506 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
507 * src/modest-account-mgr.h:
508 Added method to avoid code duplication
510 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
511 (modest_ui_actions_on_send_receive):
512 Use modest_account_mgr_has_accounts
514 2007-06-11 Murray Cumming <murrayc@murrayc.com>
516 * src/maemo/easysetup/modest-presets.c:
517 (modest_presets_get_info_server_security): Do not report secure auth
519 * src/modest-protocol-info.c: Use the defines for the gconf key names
520 for secure authentication. This was not working because we were writing
521 Password and reading password, and the check was case sensitive.
522 With this, gmail now works for receiving and sending when created via
525 2007-06-11 Murray Cumming <murrayc@murrayc.com>
527 * src/maemo/easysetup/modest-presets.c:
528 (modest_presets_get_info_server_security): Correct the key name for
529 SecureSmtp, because it seems to be case-sensitive.
530 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
531 Do not try to get the 0th notebook page if there are 0 pages, to
534 2007-06-11 Murray Cumming <murrayc@murrayc.com>
536 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
537 Prevent use of the new notification feature for now, because it currently
538 shows one dialog for each new email, which is annoying.
540 2007-06-11 Murray Cumming <murrayc@murrayc.com>
542 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
543 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
544 when no country was selected, so that we show the global ones.
545 * src/maemo/easysetup/modest-presets.c:
546 (modest_presets_get_providers): Return only the global providers, not
547 all providers when mmc=0 was requested.
549 2007-06-11 Murray Cumming <murrayc@murrayc.com>
551 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
552 (easysetup_provider_combo_box_fill): Remove debug code that showed the
553 provider ID in the combo.
555 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
556 Do not show the page numbers, because it would be confusing when we add
557 the 2 extra pages for the custom setup, when the user chooses the "Other"
558 provider. This fixes projects.maemo.org bug NB#59028
560 * src/modest-init.c: (modest_init_init_core),
561 (modest_init_local_folders):
563 * src/modest-tny-account.c:
564 (modest_tny_account_new_for_local_folders): Do not create default folders
565 for the memory card. This should fix projects.maemo.org bug NB#59328.
567 2007-06-11 Murray Cumming <murrayc@murrayc.com>
569 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
570 Free the changed_conf_keys string items. They are already freed in the
571 idle handler if that runs first.
573 2007-06-11 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-ui-actions.c:
576 (modest_ui_actions_on_password_requested): Check that the server name
577 is not NULL, because I just saw a password dialog with (null) as the
580 * src/modest-tny-folder.[h|c]: Added
581 modest_tny_folder_is_memory_card_folder().
582 * src/modest-ui-dimming-rules.c:
583 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
584 menu item for memory cards, as per the UI spec (section 7.4). This should
585 fix projects.maemo.org bug NB#59297.
587 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
589 * src/maemo/modest-main-window.c: (sync_accounts_cb):
590 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
591 is another problem with the code, see Murray's comment at line 772)
593 2007-06-08 Murray Cumming <murrayc@murrayc.com>
595 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
596 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
597 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
598 (load_from_file), (easysetup_country_combo_box_init),
599 (easysetup_country_combo_box_get_active_country_ids),
600 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
601 instead of just one ID, to avoid duplicate country names in the UI.
603 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
604 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
605 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
606 a single ID, avoiding duplicate providers.
607 * src/maemo/easysetup/modest-easysetup-wizard.c:
608 (on_combo_account_country): Adapt to use a list.
610 2007-06-08 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
613 keys changed in the last X seconds.
615 * src/modest-account-mgr.h:
616 * src/modest-account-mgr.c: (on_timeout_notify_changes),
617 (on_key_change), (modest_account_mgr_class_init),
618 (modest_account_mgr_init), (modest_account_mgr_finalize):
619 As the keys are changed, save them in a GSList* and signal that GSList*
620 further every X seconds, to batch changes, to allow us to do just one
621 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
622 bug NB#56941 and other (UI-blocking) delays when changing account settings.
624 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
625 changed signal signature.
627 * src/modest-conf.c: (modest_conf_set_list),
628 (modest_conf_on_change): Reenable notification.
630 (modest_conf_maemo_fake_on_change): Comment out the hack that
631 notified immediately instead of asynchronously.
633 * src/widgets/modest-account-view.h:
634 * src/widgets/modest-account-view.c:
635 (update_account_view): Select the previously-selected account ID,
636 if possible. This fixes projects.maemo.org bug NB#56933.
638 (on_account_changed), (on_account_removed),
639 (modest_account_view_select_account):
641 Remove the block/unblock functions
642 because they were not useful.
644 * src/maemo/modest-account-view-window.c:
645 (on_delete_button_clicked), (on_edit_button_clicked),
646 (on_new_button_clicked): Remove the use of the non-working block/unblock.
648 2007-06-08 Murray Cumming <murrayc@murrayc.com>
650 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
651 Improve the error dialog to show Incorrect Account Settings, which seems
652 clearer, and say that the internal error message (to be removed from the
653 dialog later) is often misleading.
654 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
656 * src/modest-tny-account.c:
657 (modest_tny_account_new_from_server_account): Uncomment the printf of the
658 URL because this is so useful for debugging on the device.
660 * src/widgets/modest-serversecurity-combo-box.c:
661 (modest_serversecurity_combo_box_fill): Correct a logical ID.
663 2007-06-08 Murray Cumming <murrayc@murrayc.com>
665 * src/modest-mail-operation.c:
666 (modest_mail_operation_send_new_mail):
667 Added a comment about a nasty but apparently harmless message. Details
668 added to the wiki g_warnings() page.
670 2007-06-08 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
673 (modest_tny_send_queue_class_init):
674 Do not use the priv struct because it is empty, to avoid g_warnings
675 about a non-existant priv struct.
677 * src/modest-tny-account-store.c:
678 (modest_tny_account_store_get_server_account),
679 (modest_tny_account_store_get_transport_account_for_open_connection
680 ): Do not try to get transport server accounts for local folders,
681 because they don't have any. This avoids a g_warning().
683 * src/maemo/modest-main-window.c:
684 (modest_main_window_notify_send_receive_initied),
685 (on_configuration_key_changed):
686 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
688 * src/modest-mail-operation.c:
689 (modest_mail_operation_update_account):
690 * src/modest-tny-account-store.h:
691 * src/modest-tny-account.c:
692 (modest_tny_account_get_special_folder),
693 (modest_tny_account_new_for_local_folders),
694 (modest_tny_account_new_for_per_account_local_outbox_folder):
695 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
696 * src/modest-tny-local-folders-account.c:
697 (add_account_folders_to_merged_folder):
698 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
699 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
700 (modest_ui_actions_on_send):
701 * src/widgets/modest-folder-view.c: (update_model):
702 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
703 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
704 modest_tny_account_store_get_tny_account_by_account() to
705 modest_tny_account_store_get_server_account() to make the code clearer.
707 2007-06-07 Marcus Bauer <marcusb@openismus.com>
709 * src/dbus_api/modest-dbus-api.h:
710 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
711 * src/maemo/modest-msg-edit-window.c:
712 (modest_msg_edit_window_attach_file_noninteractive):
713 added g_warning in case the file to be attached does not exist
714 * tests/dbus_api/test_compose_mail.c: (main):
715 removed obsolete comment, added generic files as test case
717 2007-06-07 Murray Cumming <murrayc@murrayc.com>
719 * src/modest-tny-account-store.c: (get_server_accounts):
720 Create the local folders account only once, not once for each outbox, and
721 not only when there are some outboxes.
723 2007-06-07 Murray Cumming <murrayc@murrayc.com>
725 * src/widgets/modest-folder-view.c: (update_model): Comment out some
726 code that is causing a crash at startup. Sergio says that he is fixing this.
728 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
730 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
731 * src/maemo/modest-account-settings-dialog.c:
732 (create_page_outgoing),
733 (modest_account_settings_dialog_set_account_name),
734 (save_configuration):
735 - Fixed handling of the "Use secure authentication" toggle to comply with
736 the ui specification. See also projects.maemo.org bug NB#58400
738 - Restore the Secure connection setting combo correctly when loading
741 * src/maemo/modest-maemo-utils.c:
742 (on_camel_account_get_supported_secure_authentication),
743 (modest_maemo_utils_get_supported_secure_authentication_methods):
744 Fixed a crasher if operation is canceled
746 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
747 (modest_protocol_info_auth_is_secure):
748 * src/modest-protocol-info.h:
750 Added two new methods to determine if a protocol/auth method is secure/encrypted in
751 the sense of the "Use secure authentication" toggle.
753 2007-06-07 Murray Cumming <murrayc@murrayc.com>
755 * src/modest-tny-account-store.h:
756 * src/modest-tny-account-store.c:
757 Added modest_tny_account_store_get_local_folders_account().
759 * src/modest-tny-folder.h:
760 * src/modest-tny-folder.c:
761 (modest_tny_folder_get_account):
762 Added this replacement for tny_folder_get_account() which returns
763 the local-folders account for TnyMergeFolders, to avoid the
764 warning about the unimplemented get_account_func() vfunc().
766 (modest_tny_folder_get_rules),
767 * src/modest-ui-actions.c:
768 (modest_ui_actions_on_folder_selection_changed):
769 * src/modest-mail-operation.c:
770 (modest_mail_operation_remove_folder),
771 (modest_mail_operation_xfer_folder),
772 (modest_mail_operation_rename_folder),
773 (modest_mail_operation_get_msg),
774 (modest_mail_operation_get_msgs_full),
775 (modest_mail_operation_remove_msg),
776 (modest_mail_operation_xfer_msgs),
777 (modest_mail_operation_refresh_folder):
778 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
780 2007-06-07 Murray Cumming <murrayc@murrayc.com>
782 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
783 (modest_server_account_set_security):
784 * src/modest-defs.h: Add comments explaining that our
785 UI spec means TLS when it says Normal, so these do not look like errors.
787 * src/modest-tny-account.c:
788 (modest_tny_account_new_from_server_account): Use the new tinymail
789 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
790 for TLS. This should fix projects.maemo.org bug NB#58460.
792 2007-06-06 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/easysetup/modest-easysetup-wizard.c:
795 (create_account): Correct the position of the gconf sanity check warning.
796 (on_button_edit_advanced_settings): Show the dialog immediately, instead
797 of using the g_idle_add() hack, because this does not seem to be necessary
798 on osso 1.1. It might even work on Maemo Bora if the problems were actually
799 caused by something other than maemo's gconf.
800 This fixes projects.maemo.org bug #59022.
802 2007-06-06 Murray Cumming <murrayc@murrayc.com>
804 * src/modest-account-mgr-helpers.c:
805 (modest_account_mgr_get_default_account): Do not check that the account
806 exists if there is no default account (NULL), to fix a runtime warning.
808 2007-06-06 Murray Cumming <murrayc@murrayc.com>
810 * src/widgets/modest-folder-view.c: (update_model):
811 Do not unref the treemodel before we have finished with it.
812 This prevents a valgrind warning and an occasional crash at startup.
814 2007-06-06 Marcus Bauer <marcusb@openismus.com>
816 * libmodest-dbus-client/libmodest-dbus-client.h:
817 added libmodest_dbus_client_compose_mail()
818 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
820 added functions needed for SendAsMail() functionality
821 * src/maemo/modest-msg-edit-window.c:
822 (modest_msg_edit_window_attach_file_noninteractive):
823 non interactively attaching files to message edit window
824 * src/widgets/modest-msg-edit-window.h:
825 * tests/dbus_api/Makefile.am:
826 added test_compose_mail.c
827 * tests/dbus_api/test_compose_mail.c: (main):
829 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
831 * src/modest-account-view.c:
832 Fixed bug projects.maemo.org bug NB#59307
834 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
836 * src/maemo/easysetup/modest-easysetup-wizard.c:
837 (get_serverport_incoming), (on_before_next), (create_account):
838 * src/maemo/modest-account-settings-dialog.c:
839 (modest_account_settings_dialog_set_account_name):
840 * src/maemo/modest-maemo-utils.c:
841 (on_camel_account_get_supported_secure_authentication_status),
842 (on_camel_account_get_supported_secure_authentication),
843 (on_secure_auth_cancel),
844 (modest_maemo_utils_get_supported_secure_authentication_methods):
846 Implemented security authentication for settings and easysetup.
848 2007-06-05 Murray Cumming <murrayc@murrayc.com>
850 * src/maemo/modest-main-window.c: (create_details_widget):
851 Show the total size for memory card accounts too, instead of showing
852 the name again. Fixes bug projects.maemo.org bug NB#59307.
854 2007-06-05 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-tny-simple-folder-store.c:
858 * src/modest-tny-simple-folder-store.h: Removed.
860 * src/modest-tny-local-folders-account.h
861 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
862 for the local-folders maildir, with an extra TnyMergedFolder containing
863 the folders of the per-account outbox store accounts.
864 * src/modest-tny-account-store.c: (get_server_accounts):
865 Add the outboxes to the special local folders account after creating it.
867 * src/modest-tny-account.c:
868 (modest_tny_account_new_for_local_folders): Create the derived
869 account when creating the main local-folders account.
871 * src/maemo/modest-main-window.c: (create_details_widget),
872 (modest_main_window_set_contents_style):
873 Adapted to the use of the derived account instead of the folder store.
875 * src/modest-ui-actions.c:
876 (modest_ui_actions_on_folder_selection_changed):
877 * src/modest-ui-dimming-rules.c:
878 (modest_ui_dimming_rules_on_new_folder):
879 * src/widgets/modest-folder-view.c: (text_cell_data),
880 (icon_cell_data), (filter_row), (update_model),
881 (get_cmp_rows_type_pos):
884 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
885 Do not get the priv struct, because no priv struct has been set,
886 to avoid a runtime warning.
888 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
889 #ifelse with #else, to fix a warning, to fix the build.
892 2007-06-05 Christian Kellner <ckellner@openismus.com>
894 * libmodest-dbus-client/libmodest-dbus-client.c:
895 Fix small typo in doc (why do you always see them
896 AFTER committing stuff?)
899 2007-06-05 Christian Kellner <ckellner@openismus.com>
901 * libmodest-dbus-client/libmodest-dbus-client.c:
902 (libmodest_dbus_client_search):
903 Initialize hit list with NULL. Also set folder list
904 to "" if NULL was supplied.
907 2007-06-03 Christian Kellner <ckellner@openismus.com>
909 * libmodest-dbus-client/libmodest-dbus-client.c:
910 (modest_search_hit_list_free):
911 Make it save to call it with NULL.
913 * src/dbus_api/modest-dbus-callbacks.c:
914 * src/modest-search.c:
915 Return full ModestSearchHits as the search result list not TnyHeader
916 since can't be around withouth the correspoding TnyFolder.
918 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
920 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
921 Added currently commented code to check for secure auth
923 * src/maemo/modest-account-settings-dialog.c: (on_response),
924 (save_configuration), (show_ok):
925 Fixed projects.maemo.org bugs NB #59248 and #59251
927 * src/maemo/modest-maemo-utils.c:
928 (on_camel_account_get_supported_secure_authentication_status),
929 (on_camel_account_get_supported_secure_authentication),
930 (modest_maemo_utils_get_supported_secure_authentication_methods):
931 * src/maemo/modest-maemo-utils.h:
932 Moved get_supported_secure_authentication() method here to be able
933 to use it from easysetup wizard.
935 * src/modest-pair.c: (on_pair_compare_as_string):
936 Should compare string with first part of pair and not
937 strcmp pairs which will crash.
939 * src/modest-protocol-info.c:
940 (modest_protocol_info_protocol_is_store):
941 * src/modest-protocol-info.h:
942 Added modest_protocol_info_get_auth_protocol_name()
944 2007-06-03 Armin Burgmeier <armin@openismus.com>
946 * src/modest-mail-operation.c:
947 (modest_mail_operation_get_msgs_full): Set priv->account also when
948 only retrieving a single message. This avoids a crash when canceling
951 (modest_mail_operation_notify_end): Do not explicitely remove the
952 operation from the queue but only emit the progress_changed signal.
953 The queue itself listens to that signal to remove the operation when
954 it is finished. This reduces coupling and removes a potential deadlock
955 when modest_mail_operation_notify_end() is called from the queue
956 itself. If that is a problem performance-wise, I would suggest to
957 implement a status-changed signal or something.
959 * src/modest-mail-operation-queue.c: Make sure to never call a
960 function from another file while the queue is locked. This (hopefully)
961 fixes another deadlock when exiting the application while retrieving
964 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
966 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
967 Fixed build if libogs is not available
969 2007-06-03 Christian Kellner <ckellner@openismus.com>
971 * libmodest-dbus-client/libmodest-dbus-client.h:
972 * libmodest-dbus-client/libmodest-dbus-client.c:
973 (libmodest_dbus_client_delete_message):
974 Implement deletion of messages (Client side).
976 (modest_search_hit_free),
977 (modest_search_hit_list_free):
978 Utility functions to free the result hits.
980 * src/dbus_api/modest-dbus-api.h:
981 * src/dbus_api/modest-dbus-callbacks.c:
983 (modest_dbus_req_handler):
984 Implement deletion of messages (Server side).
986 * tests/dbus_api/test_search.c: (main):
989 * tests/dbus_api/Makefile.am:
990 * tests/dbus_api/test_delete_message:
991 Add little test for the message deletion logic
993 2007-06-03 Armin Burgmeier <armin@openismus.com>
995 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
996 when the operation queue was not empty. projects.maemo.org bug
999 2007-06-03 Armin Burgmeier <armin@openismus.com>
1001 * src/widgets/modest-account-view.c
1002 (on_account_default_toggled): Toggle default account column
1003 explicitely instead of waiting for gconf notification (which is
1004 currently ignored). This should fix projects.maemo.org bug NB#56910
1005 for now. It should probably be removed when gconf notifications are
1008 2007-06-03 Christian Kellner <ckellner@openismus.com>
1010 * libmodest-dbus-client/libmodest-dbus-client.c:
1011 Removed debugging spew.
1013 * src/dbus_api/modest-dbus-callbacks.c:
1014 Added debugging info.
1016 * src/modest-search.c:
1017 (modest_search_all_accounts):
1018 Use tny_account_store_get_accounts () on the account store
1019 to get all accounts which is the way to get all accounts.
1021 * tests/dbus_api/test_search.c: (main):
1022 Make it possible to supply the search term on the command line.
1024 2007-06-03 Christian Kellner <ckellner@openismus.com>
1026 * libmodest-dbus-client/libmodest-dbus-client.c:
1027 * libmodest-dbus-client/libmodest-dbus-client.h:
1028 Implement searching for mesages over raw dbus. (Client side)
1030 * src/dbus_api/Makefile.am:
1031 * src/dbus_api/modest-dbus-api.h:
1032 * src/dbus_api/modest-dbus-callbacks.c:
1033 * src/dbus_api/modest-dbus-callbacks.h:
1034 Search framework (Server side). Also implement on_idle_open_message().
1036 * src/maemo/modest-platform.c: (modest_platform_init):
1037 Prepare for raw dbus/osso rpc interaction.
1039 * src/modest-search.h:
1040 Changed minsize from unspecific guint to guint32.
1042 * src/modest-search.c:
1044 Added strange hack which magically made tnymail work.
1046 (modest_search_folder),
1047 (modest_search_account),
1048 (modest_search_all_accounts):
1049 Implement helper functions to search all accounts, specific account
1052 * tests/dbus_api/Makefile.am:
1053 * tests/dbus_api/test_open_message.c:
1054 Read url to open from commandline.
1056 * tests/dbus_api/test_search.c:
1057 Implement small test for dbus search stuff
1059 2007-06-02 Armin Burgmeier <armin@openismus.com>
1061 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1062 include account type and account title. This fixes projects.maemo.org
1065 * src/maemo/modest-account-view-window.c: Set a title for the window.
1067 2007-06-02 Armin Burgmeier <armin@openismus.com>
1069 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1070 incoming and outgoing server name based on email address and server
1071 types as long as the names have not been edited manually. This fixes
1072 projects.maemo.org bug NB#58671.
1074 2007-06-02 Armin Burgmeier <armin@openismus.com>
1076 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1077 server type cannot be changed in future to the incoming details page
1078 when creating an account. This fixes projects.maemo.org bug NB#59029.
1080 2007-06-02 Armin Burgmeier <armin@openismus.com>
1082 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1083 and assigned max width chars so that they wrap instead of being
1084 truncated. Fixes projects.maemo.org bug NB#56126.
1086 2007-06-02 Armin Burgmeier <armin@openismus.com>
1088 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1089 introductory note to the connection specific smtp servers dialog, as
1090 section 8.12 of the email UI specification requires. This fixes
1091 projects.maemo.org bug NB#59212.
1093 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1096 Check for running mail operations, and offer to cancel them, as per the UI
1097 spec. This fixes projects.maemo.org bug NB#59041 .
1098 However, I suspect that tinymail may still use the network connection
1099 in ways that we cannot detect or cancel. But it should at least adapt to
1100 changes fairly well.
1102 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1104 * src/modest-tny-account-store.c: (recreate_all_accounts),
1105 (get_cached_accounts), (get_server_accounts): Do more sensible
1106 ref-counting of the temporarily-cached outbox accounts list. This seems
1107 to fix a crash when entering the password when the password was wrong.
1109 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1111 * src/gnome/modest-main-window.c: (connect_signals):
1112 * src/modest-tny-account-store.c: (get_password),
1113 (modest_tny_account_store_alert): Added comments and clues and
1114 commented-out code about how we currently fail to deal with connection
1115 errors and wrong passwords, and how we should.
1117 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1119 * src/widgets/modest-retrieve-combo-box.c:
1120 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1121 This fixes projects.maemo.org bug NB#58472 .
1123 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1125 * src/maemo/easysetup/modest-easysetup-wizard.c:
1126 (create_page_complete_easysetup):
1127 (create_page_complete_custom): Correct the last commit,
1128 putting the correct sentences in the correct pages.
1130 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/easysetup/modest-easysetup-wizard.c:
1133 (create_page_complete_custom): Show the second sentence of text
1134 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1137 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1140 Set the leave-on-server conf key by default. This fixes
1141 projects.maemo.org bug NB#59258 .
1143 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1145 * src/maemo/modest-account-view-window.c:
1146 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1147 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1150 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1152 * src/maemo/easysetup/modest-easysetup-wizard.c:
1153 (create_caption_new_with_asterisk):
1154 * src/maemo/modest-account-settings-dialog.c:
1155 (create_caption_new_with_asterisk):
1156 Uncomment the code to add the asterisk, because they are no longer in the
1157 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1158 (update_incoming_server_title): Add an asterisk here too.
1160 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1162 * src/maemo/modest-maemo-global-settings-dialog.c:
1163 (current_connection): Check that we are even connected before trying to
1164 get the current connection name, to prevent a warning.
1166 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1167 Change the comments because tny_maemo_conic_device_connect() is now meant to
1169 * src/modest-mail-operation.c:
1170 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1171 make sure we have a connection and fail if we can't connect.
1173 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1175 * src/maemo/modest-main-window.c:
1176 (on_account_store_connecting_finished): Do not try to get the
1177 connection ID if we are not really connected. I am surprised that
1178 this signal handler is called when we are not connected.
1180 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-error.h:
1183 * src/modest-ui-actions.c:
1184 (modest_ui_actions_get_msgs_full_error_handler):
1185 Renamed an enum, added comments, added an enum
1186 for retrieve-limit errors.
1188 * src/modest-mail-operation.c: (foreach_add_item),
1189 (internal_folder_observer_update), (update_account_thread),
1190 (modest_mail_operation_get_msgs_full):
1191 (modest_mail_operation_update_account),
1192 Added comments about how this works, and some code that should
1193 (but does not) check the retrieve-limit. See the TODO comment.
1195 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1198 Initialize help_id to fix the build. Warnings are good.
1200 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1202 * src/widgets/modest-hbox-cell-renderer.c:
1203 (modest_hbox_cell_renderer_append):
1204 * src/widgets/modest-vbox-cell-renderer.c:
1205 (modest_vbox_cell_renderer_append):
1206 Fix the last commit by doing an extra ref.
1208 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1210 * src/widgets/modest-hbox-cell-renderer.c:
1211 (modest_hbox_cell_renderer_append):
1212 * src/widgets/modest-vbox-cell-renderer.c:
1213 (modest_vbox_cell_renderer_append):
1214 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1215 to fix the build with Maemo Bora.
1216 However, there seems to be a remaining crash, probably due to reference
1219 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1221 * src/modest-tny-account.c:
1222 (modest_tny_account_new_for_local_folders):
1223 Use hildon_file_system_info_async_new() to get a better name for
1224 the memory card account, setting it as the account name.
1225 The timing seems to work, but this is probably
1226 not the best place to do this. See the TODO comment.
1227 * src/maemo/modest-main-window.c: (create_details_widget):
1228 * src/widgets/modest-folder-view.c: (text_cell_data):
1229 Use the tny account name instead of hardcoding a name.
1231 2007-05-30 Christian Kellner <ckellner@openismus.com>
1233 * src/modest-search.c: (modest_search):
1234 Correctly set part_search_func even if we have already parsed
1235 the query and thus a valid OgsTextSearcher object.
1237 2007-05-30 Christian Kellner <ckellner@openismus.com>
1240 Search and check for libogs.
1243 Incooparte the ogs build env.
1245 * src/modest-mime-part-search-stream.c:
1246 * src/modest-mime-part-search-stream.h:
1247 Removed since we do the real searching now in modest-search.c.
1249 * src/modest-search.c:
1250 * src/modest-search.h:
1251 Implement support for ogs. We use that if available and requested
1252 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1253 should now handle the corner case when the search term is spread
1254 across multiple reads.
1255 Also the logic in modest_search () was corrected to search all
1256 requested fields until one is found.
1258 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1260 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1262 * src/modest-init.h:
1263 * src/modest-init.c: Made modest_init_local_folders() take a
1264 path and be public so we can iniitialize maildir folders on
1267 * src/modest-local-folder-info.h:
1268 * src/modest-local-folder-info.c:
1269 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1271 * src/modest-tny-account.c:
1272 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1273 still means the standard local-folders path on the local volume.
1275 * src/modest-tny-account-store.c:
1276 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1277 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1278 all accounts when that happens.
1279 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1280 this too, so it shows up in the treeview.
1282 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/modest-maemo-global-settings-dialog.c:
1285 (current_connection):
1286 * src/widgets/modest-global-settings-dialog.c:
1287 (current_connection_default):
1288 Use the enum values instead of 0, 1 and -1,
1289 to make the code clearer.
1291 * src/modest-account-mgr-helpers.c:
1292 (modest_account_mgr_get_connection_specific_smtp): Make this code
1295 * src/modest-runtime.h:
1296 * src/modest-runtime.c:
1297 Added modest_runtime_remove_all_send_queues().
1298 * src/maemo/modest-main-window.c:
1299 (on_account_store_connecting_finished): Recreate the send queues,
1300 using the appropriate transport accounts for this new connection.
1301 Some futher adapting might be needed if the old send queues are not
1302 automatically stopped at this point.
1304 * src/modest-tny-account-store.c: (get_server_accounts):
1305 Create the connection-specific transport accounts, so that they can
1306 be found later by their ID.
1308 * src/modest-tny-account.h:
1309 * src/modest-tny-account.c:
1310 Added modest_tny_account_new_from_server_account_name().
1311 modest_tny_account_new_from_server_account(): Do not create the
1312 send queues here, because they will be
1313 recreated anyway when the connection changes for the first time.
1315 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1317 * src/modest-local-folder-info.h:
1318 * src/modest-local-folder-info.c:
1319 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1320 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1321 tbox_folder): Take a modest account name instead of a server TnyAccount,
1322 so we can have per-modest-account rather than per-transport-account
1324 We must make sure that we change or recreate the exisitng send queues
1325 when the connection changes for connection-specific transport accounts.
1327 * src/modest-tny-account-store.c:
1328 (create_per_account_local_outbox_folders): Create outboxed per modest
1329 account, not per transport account.
1331 * src/modest-tny-account.h:
1332 * src/modest-tny-account.c:
1333 (modest_tny_account_get_special_folder): For outboxes, get the
1334 parent modest account name. The account is ignored for other folders.
1335 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1336 modest account name rather than a server TnyAccount.
1338 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1340 * src/modest-tny-account.c:
1341 (modest_tny_account_new_from_server_account):
1342 Call modest_runtime_get_send_queue() immediately after creating transport
1343 accounts, so that they start trying to send email from the outbox as soon
1344 as possible at startup. This is probably what we want.
1346 * src/modest-mail-operation.c: (update_account_thread):
1347 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1348 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1349 * src/modest-tny-send-queue.h:
1350 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1351 (modest_ui_actions_on_send):
1352 Added comments about how sending works, though it needs some more work.
1354 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1356 * src/modest-tny-account.c:
1357 (modest_tny_account_get_special_folder): Add TODO because this fails when
1358 the network is busy.
1359 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1360 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1361 Do not try to show this window when there is no active account. The UI
1362 specs does not tell us what to do in this case.
1364 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1368 * src/maemo/Makefile.am:
1369 * src/widgets/Makefile.am: Some dist fixes.
1371 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1373 * src/maemo/modest-connection-specific-smtp-window.c:
1374 (on_button_edit): Make the code clearer, to prevent a double free.
1376 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1378 * src/maemo/modest-account-settings-dialog.c:
1379 (modest_account_settings_dialog_set_account_name),
1380 Check the connection-specific smtp servers checkbox if there are any.
1382 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1383 (modest_connection_specific_smtp_edit_window_init):
1384 Start with a suitable port number.
1386 * src/modest-account-mgr-helpers.h:
1387 * src/modest-account-mgr-helpers.c: Added
1388 modest_account_mgr_get_has_connection_specific_smtp().
1390 (modest_account_mgr_set_connection_specific_smtp),
1391 (modest_account_mgr_remove_connection_specific_smtp),
1392 (modest_account_mgr_get_has_connection_specific_smtp),
1393 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1394 connection-specific smtp server accounts in the account, rather than
1395 the server account conf dir.
1397 This fixes bug projects.maemo.org bug NB#58263 .
1399 * src/modest-tny-account-store.c:
1400 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1401 if there are no server accounts yet, to prevent an infinite loop when there
1402 are no accounts. Document that one must be called before the other.
1404 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1406 * src/modest-account-mgr-helpers.c:
1407 (modest_account_mgr_get_default_account): Make sure that at least
1408 one account is always the default, if there are any enabled accounts.
1409 This is just a sanity check that shouldn't be necessary.
1411 * src/modest-account-mgr-priv.c:
1412 (_modest_account_mgr_account_from_key): Unescape the conf key to
1413 get the real account name. For instance, this is an issue if a space
1414 was in the account name, which can happen because the account name
1415 is generated from the display name.
1416 (_modest_account_mgr_get_account_keyname): Always escape the
1418 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1419 Unescape the conf keys to get the real account names.
1421 For instance, previously the is-default radio button in the accounts
1422 list was not checked for any accounts at first. This fixes that,
1423 and might fix several similar bugs.
1425 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1428 Removed some debug printfs.
1430 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1432 Modest on-disk outbox directories are now here, for instance:
1433 $HOME/.modest/outboxes/<account-id-1>/outbox
1434 $HOME/.modest/outboxes/<account-id-2>/outbox
1436 $HOME/.modest/local-folders/outbox
1437 so we can have a separate outbox for each account.
1438 But they are shown as one outbox in the GtkTreeView, by using a
1439 TnyMergeFolder in a ModestTnySimpleFolderStore.
1442 * src/modest-tny-simple-folder-store.c:
1443 * src/modest-tny-simple-folder-store.h:
1444 Added ModestTnySimpleFolderStore, used to contain folders from
1445 other folder stores, such as other accounts.
1447 * src/modest-tny-outbox-account.h:
1448 * src/modest-tny-outbox-account.c:
1449 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1450 used for the per-account local outbox folders.
1452 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1453 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1454 only use this (internally) now for the non-outbox local folders.
1456 * src/modest-init.h:
1457 * src/modest-init.c: Added modest_init_one_local_folder(), for
1458 setting up the directory structure for each local folder.
1460 * src/modest-local-folder-info.c:
1461 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1462 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1464 * src/modest-local-folder-info.h:
1465 * src/modest-tny-account-store.c: (on_account_removed),
1466 (on_account_changed), (create_per_account_local_outbox_folders),
1467 (get_server_accounts), (modest_tny_account_store_get_accounts),
1468 (modest_tny_account_store_get_tny_account_by_account),
1469 (modest_tny_folder_store_is_virtual_local_folders):
1471 * src/modest-tny-account.h:
1472 * src/modest-tny-account.c:
1473 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1474 to create an on-disk per-account local outbox folder for each
1476 (create_per_account_local_outbox_folders): Create a local outbox folder
1477 for each transport account.
1478 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1479 for all local folders.
1481 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1482 instead of using g_object_get/set() directly. It is clearer.
1484 (modest_tny_folder_store_get_message_count),
1485 (modest_tny_folder_store_get_local_size
1486 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1487 because we now use these with non-acount folder stores.
1489 (modest_tny_account_get_special_folder),
1490 (modest_tny_account_new_from_server_account),
1491 (modest_tny_account_new_from_account):
1492 (recurse_folders): Adjust to the new outbox system.
1494 * src/modest-tny-folder.h:
1495 * src/modest-tny-folder.c:
1496 (modest_tny_folder_is_local_folder),
1497 (modest_tny_folder_get_local_folder_type),
1498 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1500 * src/widgets/modest-main-window.h:
1501 * src/maemo/modest-main-window.c: (create_details_widget),
1502 (modest_main_window_set_contents_style): Show details for any folder store,
1505 (modest_tny_folder_get_rules):
1506 Remove the const. C does not support constness enough for this.
1508 * src/modest-ui-actions.c:
1509 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1510 make all outboxes appear as one, in the usual local-folders tree node.
1512 (set_active_account_from_tny_account),
1513 (modest_ui_actions_on_folder_selection_changed):
1514 * src/widgets/modest-folder-view.c: (text_cell_data),
1515 (icon_cell_data), (filter_row),
1516 (add_account_folders_to_merged_folder),
1517 (add_account_folders_to_simple_folder_store), (),
1518 (get_cmp_rows_type_pos), (cmp_rows),
1519 (modest_folder_view_set_account_id_of_visible_server_account):
1520 Adjust to the new outbox system, using generic folder stores and folders
1521 in the GtkTreeModel.
1523 2007-05-23 Christian Kellner <ckellner@openismus.com>
1525 * src/modest-mail-operation.c:
1526 (modest_mail_operation_update_account):
1527 Use info->max_size instead of unintialized local var [small
1528 build fix]. (Added TODO to review that change since I don't
1531 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1533 * libmodest-dbus-client/libmodest-dbus-client.c:
1534 (libmodest_dbus_client_compose_mail): function added
1535 * src/dbus_api/modest-dbus-api.h:
1536 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1537 (on_compose_mail): Implementation of the SendAsMail functionality
1539 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1541 * src/modest-account-mgr.c:
1542 (modest_account_mgr_add_server_account): Set the secure-connection
1543 conf key for transport accounts as well as store accounts. I don't know
1544 why the if was there. For instance, this makes sure that we use SSL
1545 for the gmail preset from the easysetup wizard.
1547 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1549 * src/gnome/modest-main-window.c:
1550 (on_account_store_connecting_finished), (connect_signals):
1551 * src/maemo/modest-main-window.c:
1552 (on_account_store_connecting_finished), (connect_signals),
1553 (modest_main_window_new):
1554 Handle TnyAccountStore::connecting-finished instead of
1555 TnyDevice::connection-changed, because we cannot actually perform
1556 operations on accounts until TnyAccountStore has itself responded to
1557 the TnyDevice::connection-changed signal. This prevents a GError from
1559 Do not try to update at startup, because we (at least on scratchbox)
1560 already do an update at startup when the device goes online.
1561 This prevents a GError from tinymail.
1562 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1563 Added TODO about stopping simultaneous operations.
1565 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1567 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1568 * src/modest-mail-operation-queue.c:
1569 (modest_mail_operation_queue_remove):
1570 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1571 about where they happened.
1573 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1575 * src/modest-ui-actions.c:
1576 (modest_ui_actions_on_password_requested): Make sure that the remember
1577 output parameter is always TRUE.
1579 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1581 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1582 Show a OK/Cancel dialog if the error is a question, though we still do not
1583 know anything more about what we are asking the user.
1584 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1585 Fix an uninitialized variable (helper). This is a logic error, however.
1587 2007-05-21 Christian Kellner <ckellner@openismus.com>
1589 * src/modest-search.h:
1590 Correct bit shifting in the ModestSearchFlags enum.
1592 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1594 * src/modest-tny-account.c:
1595 (modest_tny_account_new_from_server_account): Do not use the lsub and
1596 check-all hard-coded IMAP options when using POP.
1598 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1600 * src/modest-tny-account.c:
1601 (modest_tny_account_new_from_server_account):
1602 Use NULL for the secure-auth method for POP when Password auth has been
1603 specified by the user, as we already do for IMAP. "auth=Login" causes
1604 an error from camel or the server.
1606 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1608 * src/maemo/modest-account-settings-dialog.c:
1609 (create_page_account_details),
1610 (modest_account_settings_dialog_set_account_name):
1611 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1612 for the leave-on-server checkbox, rathr than just the checkbox, when
1613 the protocol is not POP.
1615 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1617 * src/widgets/modest-account-view.c:
1618 * src/widgets/modest-account-view.h:
1619 Added modest_account_view_select_account() which will be useful later
1620 to asynchronously re-select the edited account.
1622 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1624 * src/maemo/modest-account-settings-dialog.c:
1625 (modest_account_settings_dialog_set_account_name):
1626 Automatically choose the port numbers based on the secure authentication
1627 methods, if they have not been chosen before.
1628 This fixes projects.maemo.org bug NB#56273 .
1630 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1632 * src/maemo/modest-main-window-ui.h:
1633 * src/modest-ui-actions.c:
1634 * src/modest-ui-actions.h:
1635 Connect the Tools/SMTP Servers menu item to
1636 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1637 SMTP servers dialog, as in the UI specification and saves changes when it
1638 is closed. This fixed projects.maemo.org bug NB#56305 .
1640 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1642 * src/maemo/modest-connection-specific-smtp-window.c:
1643 (modest_connection_specific_smtp_window_init):
1644 Use gtk_window_set_default_size() to make this window big enough, so
1645 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1647 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1649 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1650 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1651 (modest_connection_specific_smtp_edit_window_init),
1652 Do not try to connect to a combobox signal before the combobox exists.
1653 This fixes the cras in projects.maemo.org bug NB#56288 .
1654 (modest_connection_specific_smtp_edit_window_get_settings):
1655 Remove the server_account_name parameter which was being checked for NULL
1656 though it was not used.
1658 * src/maemo/modest-connection-specific-smtp-window.c:
1659 (modest_connection_specific_smtp_window_fill_with_connections),
1660 (on_button_edit), (modest_connection_specific_smtp_window_init):
1661 Correct the number of treemodel columns to prevent a warning.
1662 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1663 libconic does not work.
1665 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1667 * src/modest-tny-account.c:
1668 (modest_tny_account_new_from_server_account):
1669 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1670 SMTP when "None" was chosen by the user. However, with my SMTP server that
1671 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1674 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1676 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1677 to explain the memory management issue with the ID in the ModestPair.
1679 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1680 (add_sending_page), (modest_account_assistant_finalize):
1681 * src/gnome/modest-gnome-global-settings-dialog.c:
1682 (create_updating_page), (create_composing_page):
1683 * src/gnome/modest-msg-edit-window.c: (get_transports),
1684 (init_window), (modest_msg_edit_window_finalize),
1685 (modest_msg_edit_window_get_msg_data):
1686 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1687 * src/gnome/modest-transport-widget.c:
1688 (modest_transport_widget_finalize), (smtp_configuration):
1689 * src/maemo/modest-maemo-global-settings-dialog.c:
1690 (create_updating_page), (create_composing_page):
1691 * src/maemo/modest-msg-edit-window.c: (get_transports),
1692 (init_window), (modest_msg_edit_window_finalize),
1693 (modest_msg_edit_window_get_msg_data),
1694 (modest_msg_edit_window_free_msg_data):
1695 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1696 (modest_store_widget_finalize):
1697 * src/maemo/modest-transport-widget.c:
1698 (modest_transport_widget_finalize), (smtp_configuration):
1699 * src/modest-main.c: (send_mail):
1700 * src/widgets/modest-combo-box.h:
1701 * src/widgets/modest-global-settings-dialog-priv.h:
1702 * src/widgets/modest-global-settings-dialog.c:
1703 (modest_global_settings_dialog_finalize):
1704 * src/widgets/modest-msg-edit-window.h:
1705 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1706 as long as the combo box, to prevent use of freed memory for the ID.
1708 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1710 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1711 get_accounts(), to make this clearer. Do not check for the enabled gconf
1712 key, because we do not use this for server accounts (at least, not yet).
1713 This allows us to send email again.
1715 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1717 * src/maemo/modest-platform.c:
1718 (on_modest_conf_update_interval_changed), (modest_platform_init):
1719 Only respond to this particular key change. All these strcmp()s cannot be
1722 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1724 * src/maemo/modest-maemo-global-settings-dialog.c:
1725 (current_connection): Prevent a crash in scratchbox when
1726 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1727 * src/maemo/modest-platform.c:
1728 (on_modest_conf_update_interval_changed), (modest_platform_init):
1729 Get the update interval from gconf and reset it when the gconf key changes.
1731 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1733 * src/modest-protocol-info.c:
1734 * src/modest-protocol-info.h: Adde enum-specific get functions,
1735 instead of using a ModestProtocolType enum parameter.
1737 * src/gnome/modest-account-assistant.c:
1738 * src/gnome/modest-store-widget.c:
1739 * src/gnome/modest-store-widget.h:
1740 * src/gnome/modest-transport-widget.c:
1741 * src/gnome/modest-transport-widget.h:
1742 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1743 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1744 * src/maemo/easysetup/modest-easysetup-wizard.c:
1745 * src/maemo/modest-account-settings-dialog.c:
1746 * src/maemo/modest-account-settings-dialog.h:
1747 * src/maemo/modest-store-widget.c:
1748 * src/maemo/modest-store-widget.h:
1749 * src/maemo/modest-transport-widget.c:
1750 * src/maemo/modest-transport-widget.h:
1751 * src/modest-account-mgr-helpers.c:
1752 * src/modest-account-mgr-helpers.h:
1753 * src/modest-account-mgr.c:
1754 * src/modest-account-mgr.h:
1755 * src/modest-tny-account.c:
1756 * src/modest-tny-folder.c:
1757 * src/widgets/modest-account-view.c:
1758 * src/widgets/modest-retrieve-combo-box.c:
1759 * src/widgets/modest-retrieve-combo-box.h:
1760 * src/widgets/modest-secureauth-combo-box.c:
1761 * src/widgets/modest-serversecurity-combo-box.c:
1762 * src/widgets/modest-serversecurity-combo-box.h:
1763 * tests/check_account-mgr.c:
1764 Use the specific functions, and use the re-renamed enum values for GNOME too.
1766 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-pair.h:
1769 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1770 so we can get the second based on the first.
1772 * src/maemo/modest-account-settings-dialog.h:
1773 * src/maemo/modest-account-settings-dialog.c:
1774 Added get_supported_secure_authentication_methods(), though it is mostly
1775 commented-out for now until the necessary API is committed to tinymail.
1776 (modest_account_settings_dialog_set_account_name),
1777 (save_configuration): Request the supported authentication methods from the
1778 server, so we can choose a working method.
1780 * src/modest-tny-account-store.h:
1781 * src/modest-tny-account-store.c:
1782 (modest_tny_account_store_get_session): Rename from
1783 tny_account_store_get_session().
1785 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1787 * src/modest-protocol-info.h: Split the ModestProtocol enum
1788 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1789 There was no need to have these unrelated values in one enum.
1791 * src/: many files: Adapted to changed enum. This makes the code a bit
1792 clearer, and the compiler could catch some errors.
1794 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1796 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1797 Show the detailed internal camel error message when an error happens
1798 during the configuration, so that our testers can give us more clues.
1799 For instance, in projects.maemo.org bug NB#56910 .
1801 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1803 * src/modest-tny-account.c:
1804 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1805 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1807 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1809 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1810 * src/maemo/modest-account-settings-dialog.c:
1811 (modest_account_settings_dialog_set_account_name),
1812 (save_configuration): For the incoming secure authentication checkbox,
1813 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1814 the UI specification. PLAIN does not seem to be supported for most IMAP
1815 servers anyway, and I am not sure what it would mean.
1816 However, we probably need to discover which of the secure-authentication
1817 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1818 * src/modest-account-mgr-helpers.c:
1819 (modest_account_mgr_get_server_account_data):
1821 * src/modest-tny-account.c:
1822 (modest_tny_account_new_from_server_account):
1823 Use tny_account_set_mech() to set secure-authentication methods,
1824 with some special-casing for IMAP, based on my observations of how
1827 * src/modest-account-mgr-helpers.h:
1828 * src/modest-account-mgr.c:
1829 * src/modest-defs.h: Comment that the URI is only used for local folders.
1831 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1833 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1834 parameter const, just to be neat.
1835 * src/modest-text-utils.c: (modest_text_utils_inline):
1836 End g_strconcat() with NULL, as its documentation says. This is almost
1837 certainly the cause of my crash at startup on the device. Interestingly,
1838 valgrind doesn't tell us about these errors.
1840 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1842 * scripts/build-packages: Added more precise comments about how to use
1843 this script, though I still get this error:
1844 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1845 error building tinymail
1847 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1849 * src/maemo/modest-main-window.c: (on_account_update):
1850 Very slight cleanup, hoping to make it simpler to discover what causes
1851 a crash here sometimes.
1853 * src/modest-tny-account.c:
1854 (modest_tny_account_new_from_server_account): Set the port. Added
1855 comments about the options and a TODO comment because I need to find out
1856 how to specify the secure authentication method.
1858 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1860 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1861 changed CFlags paths form modest to libmodest
1863 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1865 * src/modest-account-mgr-helpers.c:
1866 (modest_account_mgr_get_server_account_data),
1867 (modest_account_mgr_free_server_account_data):
1868 * src/modest-account-mgr-helpers.h:
1869 * src/modest-account-mgr.c:
1870 (modest_account_mgr_add_server_account):
1871 * src/modest-defs.h:
1872 * src/modest-tny-account.c:
1873 (modest_tny_account_new_from_server_account):
1874 Determine the options for tny_camel_account_add_option() here,
1875 based on the settings, rather than storing them directly in gconf.
1877 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1879 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1880 Show a more friendly error dialog now that we expect (from the tinymail
1881 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1883 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1885 * src/maemo/modest-main-window.c: (on_account_update): Check that
1886 account_name is not NULL, to prevent a crash at startup that I am
1887 seeing on the N800. I do wonder why it is NULL.
1889 * src/maemo/easysetup/modest-easysetup-wizard.c:
1890 (create_page_user_details):
1891 * src/maemo/modest-account-settings-dialog.c:
1892 (create_page_user_details), (create_page_outgoing):
1893 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1894 (modest_connection_specific_smtp_edit_window_init):
1895 * src/modest-ui-actions.c:
1896 (modest_ui_actions_on_password_requested):
1897 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1898 might do something useful with the on-screen keyboard.
1900 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1902 * src/maemo/modest-main-window.c: (on_account_update):
1903 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1904 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1906 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1908 * src/modest-tny-account-store.c: (on_account_changed):
1909 Correct the signature of this signal handler.
1911 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1913 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1914 Show a HildonNote instead of a GtkDialog for Maemo.
1916 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1918 * src/widgets/modest-account-view.h:
1919 * src/widgets/modest-account-view.c: (on_account_changed),
1920 (on_account_removed). Added a boolean flag, set/unset by
1921 modest_account_view_block_conf_updates(),
1922 modest_account_view_unblock_conf_updates() to prevent unnecessary
1923 updates, but this is not very useful because the gconf notifications are
1924 so delays (maybe only on Maemo Bora).
1925 So auto-updating is turned off, and these functions do an explicit
1926 update when necessary.
1927 However, something else is still doing too much work when adding/removing
1928 accounts, probably in another part of the application.
1930 * src/maemo/modest-account-view-window.c:
1931 (on_delete_button_clicked), (on_edit_button_clicked),
1932 (on_new_button_clicked): Use the new functions.
1934 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-account-mgr-helpers.c:
1937 (modest_account_mgr_set_first_account_as_default):
1938 Sort the list of names alphabetically-by-title, so we choose the first one
1940 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1941 alphabetically by the title.
1943 This fixes projects.maemo.org bug NB#56418 .
1945 * src/modest-account-mgr-priv.c:
1946 (_modest_account_mgr_account_from_key):
1947 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1948 avoid a valgrind error, and possible random behaviour.
1950 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1952 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1953 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1954 tinymail documentation to say that this can be expected.
1955 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1956 pretty, and should not happen, but I would prefer to know when it does.
1958 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1960 * configure.ac: When using the older hildon version, probably on Bora,
1961 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1963 * src/widgets/modest-attachment-view.c:
1964 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1967 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1969 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1970 Implemented the prototype. Can be tested with
1971 tests/dbus_api/test_open_message:
1973 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1975 * src/modest-tny-account-store.c:
1976 (modest_tny_account_store_instance_init), (get_password):
1977 * src/modest-ui-actions.c:
1978 (modest_ui_actions_on_password_requested):
1979 Do not store the password in gconf, because this function is called
1980 for non-remembered passwords. Actually use the cached (in the hash map)
1981 password instead of releasing it.
1982 The password will now not be remembered if it is asked via the protected
1983 password dialog, as per the UI spec.
1985 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-defs.h:
1988 * src/modest-account-mgr-helpers.h:
1989 * src/modest-account-mgr-helpers.c:
1990 Added modest_server_account_get_username_has_succeeded(),
1991 modest_server_account_set_username_has_succeeded().
1992 (modest_server_account_set_username),
1993 Reset the has-succeeded flag if the username changes.
1995 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1996 * src/maemo/modest-connection-specific-smtp-window.c:
1997 (modest_connection_specific_smtp_window_save_server_accounts):
1998 Use modest_server_account_set_username() instead of using
1999 modest_conf_set_string() directly, so that the has-succeeded flag is always
2002 * src/modest-ui-actions.c:
2003 (modest_ui_actions_on_password_requested): Dim the username entry if
2004 the username has ever worked, as per the UI spec.
2006 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-tny-account-store.c: (get_password):
2009 * src/modest-ui-actions.c:
2010 (modest_ui_actions_on_password_requested):
2011 Allow the username to be changed too, though there is more work to
2012 be done on exactly how this behaves.
2014 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2016 * src/modest-account-mgr-helpers.h:
2017 * src/modest-account-mgr-helpers.c:
2018 Added modest_account_mgr_get_display_name(),
2019 modest_server_account_get_username(),
2020 modest_server_account_set_username(),
2021 modest_server_account_set_password(),
2022 modest_server_account_get_hostname() functions so we do not need to
2023 use the conf API directly.
2025 * src/maemo/modest-main-window.c: (connect_signals):
2026 Actually connect ot the ModestAccountStore::request-password signal,
2027 so that we show the dialog when the password is requested by Tinymail,
2028 for isntance if it is empty.
2030 * src/modest-marshal.list:
2031 * src/modest-tny-account-store.c:
2032 (modest_tny_account_store_class_init), (get_password),
2033 (modest_tny_account_store_alert):
2034 * src/modest-tny-account-store.h:
2035 * src/modest-ui-actions.h:
2036 * src/modest-ui-actions.c:
2037 (modest_ui_actions_on_password_requested):
2038 Change the signal parameters, so it is obvious that we are providing
2039 the non human-readable server name, and receiving both the username
2040 and password, though changing of the username is not yet implemented.
2041 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2042 for the GNOME version.
2044 This should fix the projects.maemo.org bug NB#56209, though it does not
2045 work on Bora, because the gconf_client_get() for the password fails
2046 immediately after we save it with gconf_client_set().
2048 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2051 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2052 caused an undefined symbol error:
2053 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2055 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2057 * src/modest-tny-account-store.c:
2058 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2059 using a GError instead of a string message, so we can translate it in
2062 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2064 * src/maemo/modest-address-book.c:
2065 (modest_address_book_check_names):
2066 * src/maemo/modest-msg-view-window.c:
2067 (modest_msg_view_window_clipboard_owner_change):
2068 * src/modest-init.c: (modest_init_init_ui):
2069 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2070 (update_folders_cb), (modest_mail_operation_update_account):
2071 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2072 (modest_ui_actions_on_msg_attachment_clicked),
2073 (modest_ui_actions_on_msg_recpt_activated):
2074 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2075 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2076 (modest_msg_view_search_next):
2077 * src/widgets/modest-recpt-editor.c:
2078 (modest_recpt_editor_on_button_release_event),
2079 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2080 g_message(). At this point we should only be seeing interesting errors on
2081 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2083 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2085 (modest_wizard_dialog_force_title_update):
2086 * src/maemo/easysetup/modest-wizard-dialog.h:
2087 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2088 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2089 can update the title when appropriate. Otherwise the title is wrong if the
2090 pages are added after adding the notebook to the dialog.
2091 This must be a problem in HildonWizardDialog too.
2092 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2094 * src/maemo/easysetup/modest-easysetup-wizard.c:
2095 (create_subsequent_customsetup_pages),
2096 (create_subsequent_easysetup_pages):
2097 Call modest_wizard_dialog_force_title_update() so that the title is
2098 correct even with GTK+ < 2.10.
2099 This fixes projects.maemo.org bug NB#56145 .
2101 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2103 * src/maemo/modest-platform.c:
2104 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2105 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2108 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2110 * src/widgets/modest-window.h:
2111 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2112 and modest_window_save_state(), which invokes it.
2114 * src/widgets/modest-window-mgr.h:
2115 * src/widgets/modest-window-mgr.c:
2116 Added modest_window_mgr_save_state_for_all_windows(), which calls
2117 the save_state vfunc on all registered windows, if implemented.
2119 * src/gnome/modest-msg-edit-window.c:
2120 * src/gnome/modest-msg-view-window.c:
2121 * src/maemo/modest-msg-edit-window.c:
2122 * src/maemo/modest-msg-view-window.c:
2123 * src/maemo/modest-main-window.c:
2124 Specify the existing save_settings functions as implementations of
2125 ModestWindow::save_state_func().
2127 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2128 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2129 enabling hibernation, for instance.
2131 We may need to do the same thing for restoring settings.
2134 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2136 * src/widgets/modest-window-mgr.c:
2137 * src/widgets/modest-window-mgr.h:
2138 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2139 modest_window_mgr_get_hibernation_is_prevented().
2141 * src/maemo/modest-main-window.c:
2142 (on_hildon_program_is_topmost_notify): Prevent hibernation
2143 (possible when the application goes to the background in the WM),
2144 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2146 * src/maemo/easysetup/modest-easysetup-wizard.c:
2147 (modest_easysetup_wizard_dialog_init):
2148 * src/maemo/modest-account-settings-dialog.c:
2149 (modest_account_settings_dialog_init):
2150 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2151 (modest_connection_specific_smtp_edit_window_init):
2152 * src/maemo/modest-connection-specific-smtp-window.c:
2153 (modest_connection_specific_smtp_window_init):
2154 * src/maemo/modest-signature-editor-dialog.c:
2155 (modest_signature_editor_dialog_init):
2156 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2157 prevent hibernation while any of these account settings dialogs are open.
2159 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2161 * src/maemo/Makefile.am:
2162 * src/maemo/modest-osso-state-saving.c:
2163 * src/maemo/modest-osso-state-saving.h: Added
2164 modest_osso_load_state() and modest_osso_save_state() though they do
2165 nothing now. They should iterate through all the open windows and load/save
2167 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2168 save state when closing.
2170 * src/maemo/modest-main-window.c:
2171 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2172 Add a notification handler for the HildonProgram::is-topmost property,
2173 so we can allow hibernation when the application goes into the background.
2174 But we still need to detect when the accounts setup windows are open so
2175 we can stop hibernation when they are open.
2176 To do this, I also added the main window the HildonProgram. This might have
2177 other side-effects/benefits, and should maybe be done for other windows.
2179 * src/maemo/modest-osso-autosave-callbacks.h:
2180 * src/maemo/modest-osso-autosave-callbacks.c:
2181 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2182 though it does not do anything yet, and we might never need this to do
2183 anything. For instance, we already save drafts.
2185 * src/maemo/modest-platform.c: (modest_platform_init):
2186 Specify the libosso auto-save callback.
2188 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2190 * src/maemo/modest-platform.c:
2191 (modest_platform_set_update_interval):
2192 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2193 aparently stays valid between application instances, so we can use this
2194 to remove and reset it later. According to a maemo-developers email from
2197 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2199 * configure.ac: Depend on libalarm for Maemo.
2201 * src/dbus_api/modest-dbus-api.h:
2202 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2203 (on_send_receive), (modest_dbus_req_handler):
2204 Handle a SEND_RECEIVE D-Bus method.
2206 * libmodest-dbus-client/libmodest-dbus-client.c:
2207 (libmodest_dbus_client_send_and_receive):
2208 * libmodest-dbus-client/libmodest-dbus-client.h:
2209 Add C convenience functions for calling the new D-Bus method.
2211 * src/modest-platform.h:
2212 * src/gnome/modest-platform.c:
2213 * src/maemo/modest-platform.c:
2214 Added modest_platform_set_update_interval(), which uses the
2215 alarmd API on Maemo.
2216 (modest_platform_init),
2217 Call modest_platform_set_update_interval(), using a hard-coded
2218 interval for now (until the global settings dialog is implemented),
2219 though I am not sure that this makes sense yet.
2221 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2223 * src/dbus_api/modest-dbus-callbacks.c:
2224 (modest_osso_cb_hw_state_handler):
2225 * src/dbus_api/modest-dbus-callbacks.h:
2226 * src/maemo/modest-platform.c: (modest_platform_init):
2227 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2228 in case this has some effect on the ability for Maemo to ping the
2231 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2233 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2234 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2235 warning. It is probably a logic error, but I need to fix the build.
2237 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2239 * src/modest-account-mgr.h:
2240 * src/modest-account-mgr.c:
2241 (modest_account_mgr_account_names): Add a gboolean enabled_only
2242 parameter, so we can get lists of onlt the enabled accounts.
2244 (modest_account_mgr_add_account),,
2245 (modest_account_mgr_account_with_display_name_exists):
2246 * src/maemo/modest-msg-edit-window.c: (get_transports):
2247 * src/modest-account-mgr-helpers.c:
2248 (modest_account_mgr_set_first_account_as_default):
2249 * src/modest-init.c: (init_default_account_maybe):
2250 * src/modest-tny-account-store.c: (get_accounts):
2251 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2252 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2253 * tests/check_account-mgr.c: (START_TEST):
2254 Provide the extra parameter, as appropriate.
2256 * src/widgets/modest-account-view.c: (update_account_view):
2257 Do not show disabled accounts (meaning that there is no way to
2258 enable/disable accounts in the UI (the feature is not in our UI
2259 specification), so we can use this internally only to mark unfinished
2260 or temporary account data.
2262 * src/maemo/easysetup/modest-easysetup-wizard.c:
2263 (create_account): Add boolean enable parameter, so we can specify FALSE
2264 to create the temporary account.
2265 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2266 (on_before_next): When finishing, when there is a temporary account, just
2268 Also, use a timeout to delay the showing of the dialog until gconf is likely
2269 to return correct information, due to a maemo gconf bug that is fixed in
2270 osso 1.1, but not yet in Bora.
2271 However, the dialog stays on screen after it is destroyed.
2273 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2274 for invalid data when cancelling. Use a hildon note instead of a dialog
2275 to complain about invalid data. Do not show the account-saved note if the
2276 account is disabled (a temporary account that will not really be saved for use
2279 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2281 * src/modest-account-mgr-helpers.h:
2282 * src/modest-account-mgr-helpers.c:
2283 Added modest_account_mgr_unset_default_account(),
2284 Added modest_account_mgr_set_first_account_as_default().
2286 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2287 If it was the default account, unset the default account name.
2289 * src/maemo/modest-account-view-window.c:
2290 (on_delete_button_clicked): If it was the default account,
2291 set the first remaining account as the default instead.
2293 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2294 a NULL account or a NULL default account, to prevent a crash. This should
2295 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2298 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2300 * src/widgets/modest-recpt-editor.c:
2301 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2302 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2303 TODO comment for this. This fixes the build.
2305 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2306 be the best place for it. This will in future update all auto-update accounts,
2307 rather than just the current/default account, when that gconf key exists.
2308 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2309 if there are no accounts, before calling do_send_receive().
2310 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2312 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2313 * src/maemo/modest-main-window-ui.h:
2314 * src/maemo/modest-main-window.c: (on_connection_changed),
2315 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2316 directly, becaue the signal handler does more.
2318 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2320 * src/modest-account-mgr-helpers.c:
2321 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2322 for the case that the account does not exist.
2324 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2325 (equivalent to the modest account name) rather than the tinymail account name
2326 (equivalent to the modest account title - human readable) to get the account data.
2327 Check for null account data to prevent the crash, and add a TODO comment saying that
2328 this needs fixing because it is using the server account name instead of the account name.
2330 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2332 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2333 * src/maemo/modest-account-settings-dialog.c: (show_error),
2335 Use hildon_note_new_information() for informative and error messages,
2336 which seems to be expected for Maemo applications (no documentation that I know of
2337 says this). I am surprised that there is no distinction between info and error
2340 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2342 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2343 it is easy to find where this is used.
2345 * src/maemo/easysetup/modest-easysetup-wizard.c:
2346 (create_page_welcome), (create_page_account_details),
2347 (create_page_user_details), (create_page_complete_easysetup),
2348 (create_page_custom_incoming), (create_page_custom_outgoing),
2349 (create_page_complete_custom):
2350 * src/maemo/modest-account-settings-dialog.c:
2351 (create_page_account_details), (create_page_user_details),
2352 (create_page_incoming), (create_page_outgoing):
2353 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2354 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2355 (modest_connection_specific_smtp_edit_window_init):
2356 * src/maemo/modest-connection-specific-smtp-window.c:
2357 (modest_connection_specific_smtp_window_init):
2358 * src/maemo/modest-signature-editor-dialog.c:
2359 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2360 and scrolling policy as per the Email Application Layout Guide, if I have
2363 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2365 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2366 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2367 which were empty, because these vfuncs have been removed from TnyAccountStore.
2368 This fixes the build.
2370 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2372 * src/maemo/modest-main-window.c:
2373 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2374 showing/hiding it. Added TODO because it probably should not be NULL.
2375 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2376 because unnecessary g_warnings() make degugging difficult.
2378 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2380 * src/maemo/modest-msg-edit-window.c:
2381 (modest_msg_edit_window_select_color),
2382 (modest_msg_edit_window_select_background_color): 2 const corrections and
2383 moving 2 #endifs before closing brackets, to fix the build.
2385 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2387 * src/maemo/easysetup/modest-easysetup-wizard.h:
2388 * src/maemo/easysetup/modest-easysetup-wizard.c:
2389 (modest_easysetup_wizard_dialog_finalize),
2390 (on_button_edit_advanced_settings), (create_page_complete_custom),
2391 (on_response), (create_account):
2392 Implement the Advanced Settings edit button, by saving the account information,
2393 for the Advanded Settings dialog to use directly from gconf, and removing it
2394 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2395 Bug #5533 in the projects.maemo.org bugzilla.
2397 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2399 * src/maemo/modest-msg-view-window.c:
2400 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2401 when opening a message window.
2403 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2405 * src/maemo/easysetup/modest-easysetup-wizard.c:
2406 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2409 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2410 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2411 gconf settings. I probably added more checks than necessary, but that is safer.
2413 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2414 variable to fix the build, but this seems to be used when it is still NULL.
2416 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2418 * src/modest-platform.h:
2419 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2420 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2421 * src/modest-main.c: Implement this function so we can avoid using
2422 maemo-specific API from cross-platform code.
2424 * src/modest-tny-account-store.c:
2425 (get_smtp_specific_transport_account_for_open_connection):
2426 * src/modest-ui-actions.c: (check_for_connection),
2427 (modest_ui_actions_on_item_not_found):
2428 Use modest_platform_connect_and_wait() and put #idefs around other
2429 maemo-specific code, because only maemo currently has a way to
2430 identify connection names.
2432 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2434 * src/modest-tny-account-store.h:
2435 * src/modest-tny-account-store.c:
2436 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2437 the connection-specific SMTP server settings in the configuration.
2439 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2441 * src/maemo/modest-main-window.c: (on_connection_changed),
2443 * src/modest-main.c: (main), (start_ui), (send_mail):
2444 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2445 that is what is intended.
2447 * src/modest-ui-actions.c: (action_send), (action_receive),
2448 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2449 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2450 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2451 SMTP server is used when it is specified.
2453 (modest_ui_actions_on_send_receive):
2454 Check that a connection is open before proceeding.
2455 Receive and then send, instead of vice-versa, as per the specification.
2457 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2459 * src/modest-mail-operation.c:
2460 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2461 though I guess it should be something other than NULL.
2463 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/easysetup/modest-easysetup-wizard.c:
2466 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2467 combo twice, to avoid an g_warning and to make it visible again.
2468 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2469 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2470 (already intended) dereference when detaching, because we then recreate the menu.
2471 But I am not sure why the warning was happening, and it is possible that this is a memory
2474 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2476 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2477 and uri_parse_mailto() utility functions.
2478 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2480 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2482 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2484 * src/dbus_api/modest-dbus-api.h:
2485 * src/dbus_api/modest-dbus-callbacks.c:
2486 Use an idle callback to execute the modest code in the application's own thread.
2487 Remove the helloworld example method.
2488 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2489 parsed, and the open-message method is not implemented because this is not yet implemented in
2491 * libmodest-dbus-client/libmodest-dbus-client.c:
2492 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2493 (libmodest_dbus_client_open_message):
2494 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2496 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2497 body without crashing.
2499 * tests/dbus_api/Makefile.am:
2500 * tests/dbus_api/test_mail_to.c:
2501 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2503 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2505 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2506 Added file to fix the build. Sorry.
2508 * src/dbus_api/Makefile.am:
2509 * src/dbus_api/modest-dbus-api.h:
2510 * src/dbus_api/modest-dbus-callbacks.h:
2511 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2512 (modest_dbus_req_handler):
2513 Put constants in a separate header so it can be reused by the
2514 client library, without duplication
2516 * libmodest-dbus-client/Makefile.am:
2517 * libmodest-dbus-client/libmodest-dbus-client.c:
2518 (libmodest_dbus_client_call_helloworld),
2519 (libmodfest_dbus_client_send_mail),
2520 (libmodfest_dbus_client_mailto),
2521 (libmodfest_dbus_client_open_message):
2522 * libmodest-dbus-client/libmodest-dbus-client.h:
2523 (Partly) Implement a send_mail D-Bus method.
2525 * tests/dbus_api/Makefile.am:
2526 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2527 the send_email D-Bus method.
2529 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2533 * libmodest-dbus-client/Makefile.am:
2534 * libmodest-dbus-client/libmodest-dbus-client.c:
2535 * libmodest-dbus-client/libmodest-dbus-client.h:
2536 * tests/dbus_api/Makefile.am:
2537 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2538 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2540 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2542 * src/maemo/easysetup/modest-easysetup-wizard.c:
2543 (create_page_account_details):
2544 * src/maemo/modest-account-settings-dialog.c:
2545 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2546 widgets, because this might not be the default in future versions of the Maemo GTK+.
2547 However, I can not not get capitalization to work even in a simple test case.
2549 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2551 * src/maemo/easysetup/modest-easysetup-wizard.c:
2552 (create_page_custom_incoming), (create_page_custom_outgoing):
2553 * src/maemo/modest-account-settings-dialog.c:
2554 (create_page_account_details), (create_page_incoming),
2555 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2556 instead of using gtk_check_button_with_label(), so they are aligned like the other
2557 widgets, as per the UI spec.
2559 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2561 * src/maemo/easysetup/modest-easysetup-wizard.c:
2562 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2563 * src/widgets/modest-validating-entry.c:
2564 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2565 Modest prefix instead of an EasySetup prefix.
2567 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2569 * src/widgets/modest-validating-entry.h:
2570 * src/widgets/modest-validating-entry.c: (on_insert_text),
2571 Added easysetup_validating_entry_set_max_func(), used to set a callback
2572 to call when the max number of characters is reached. GtkEntry has a max-length
2573 already but is silent about it.
2575 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2576 (create_page_account_details), (create_page_user_details),
2578 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2579 (create_page_account_details), (create_page_user_details),
2580 (create_page_outgoing):
2581 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2582 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2583 the UI spec, when the user tries to enter more than the max number of characters.
2585 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2587 * src/maemo/easysetup/modest-easysetup-wizard.c:
2588 (create_page_user_details), (create_page_custom_incoming),
2589 (create_page_custom_outgoing):
2590 * src/maemo/modest-account-settings-dialog.c:
2591 (create_page_user_details), (create_page_incoming),
2592 (create_page_outgoing):
2593 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2594 (modest_connection_specific_smtp_edit_window_init):
2595 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2596 not appropriate. Bad Maemo-specific defaults!.
2598 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2600 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2601 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2602 (modest_signature_editor_dialog_set_settings):
2603 Disable the label and textview when the checkbox is disabled, and use the
2604 specified (UI spec) default signature text.
2606 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2608 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2609 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2611 * src/modest-defs.h:
2612 * src/modest-account-mgr-helpers.h:
2613 * src/modest-account-mgr-helpers.c:
2614 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2616 * src/maemo/Makefile.am:
2617 * src/maemo/modest-signature-editor-dialog.c:
2618 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2621 * src/maemo/modest-account-settings-dialog.h:
2622 * src/maemo/modest-account-settings-dialog.c:
2623 (modest_account_settings_dialog_finalize), (on_button_signature),
2624 (save_configuration): Use the new dialog when the Edit button is pressed, and
2625 save the changes if necessary, as per the UI spec.
2627 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2629 * src/maemo/Makefile.am:
2630 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2631 based on maemo-develoers email from Dirk.
2633 * src/maemo/easysetup/modest-easysetup-wizard.c:
2634 (create_page_welcome), (create_page_account_details),
2635 (create_page_user_details), (create_page_complete_easysetup),
2636 (create_page_custom_incoming), (create_page_custom_outgoing),
2637 (create_page_complete_custom),
2638 (modest_easysetup_wizard_dialog_init):
2639 * src/maemo/modest-account-settings-dialog.c:
2640 (create_page_account_details), (create_page_user_details),
2641 (create_page_incoming), (create_page_outgoing),
2642 (modest_account_settings_dialog_init):
2643 * src/maemo/modest-connection-specific-smtp-window.c:
2644 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2646 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2648 * src/maemo/easysetup/modest-easysetup-wizard.c:
2649 (create_page_account_details), (create_page_custom_outgoing),
2650 (create_page_complete_custom):
2651 * src/maemo/modest-account-settings-dialog.c:
2652 (create_page_user_details), (create_page_incoming),
2653 (create_page_outgoing):
2654 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2655 (modest_connection_specific_smtp_edit_window_init):
2656 Use the correct (UI spec) port min/max, and use horizontal separators,
2659 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2661 * src/maemo/easysetup/modest-easysetup-wizard.c:
2662 (set_default_custom_servernames):
2663 * src/maemo/modest-account-settings-dialog.c:
2664 (create_page_incoming), (on_combo_outgoing_security_changed),
2665 (on_combo_incoming_security_changed), (create_page_outgoing),
2666 (modest_account_settings_dialog_set_account_name),
2667 (save_configuration):
2668 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2669 (on_combo_security_changed),
2670 (modest_connection_specific_smtp_edit_window_init),
2671 (modest_connection_specific_smtp_edit_window_set_connection),
2672 (modest_connection_specific_smtp_edit_window_get_settings):
2673 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2676 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2679 * src/maemo/easysetup/modest-easysetup-wizard.c:
2680 (create_page_custom_outgoing), (create_page_complete_custom):
2681 * src/maemo/modest-account-settings-dialog.c:
2682 (create_page_user_details), (create_page_outgoing):
2683 * src/maemo/modest-account-view-window.c: (button_box_new):
2684 Use changed logical IDs as per the most recent UI spec:
2685 mcen_bd_emailsetup_edit -> mcen_bd_edit
2686 mcen_bd_emailsetup_delete -> mcen_bd_delete
2687 mcen_bd_emailsetup_close -> mcen_bd_close
2689 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2693 * src/dbus_api/Makefile.am:
2694 * src/dbus_api/modest-dbus-callbacks.c:
2695 * src/dbus_api/modest-dbus-callbacks.h:
2696 * src/maemo/modest-platform.c: (modest_platform_init):
2697 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2699 * tests/Makefile.am:
2700 * tests/dbus_api/Makefile.am:
2701 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2703 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2705 * src/maemo/modest-account-settings-dialog.c:
2706 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2707 Removed unnecessary includes.
2709 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2711 * src/maemo/easysetup/modest-easysetup-wizard.c:
2712 * src/maemo/modest-account-settings-dialog.c:
2713 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2714 * src/widgets/Makefile.am:
2715 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2716 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2717 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2718 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2719 * src/widgets/modest-secureauth-combo-box.c:
2720 * src/widgets/modest-secureauth-combo-box.h:
2721 * src/widgets/modest-serversecurity-combo-box.c:
2722 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2723 made the GObject names more consistent with the rest of the Modest code.
2725 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2727 * src/maemo/easysetup/Makefile.am:
2728 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2729 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2730 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2731 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2732 * src/maemo/easysetup/modest-easysetup-wizard.c:
2733 * src/maemo/easysetup/modest-validating-entry.c:
2734 * src/maemo/easysetup/modest-validating-entry.h:
2735 * src/maemo/modest-account-settings-dialog.c:
2736 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2737 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2738 widgets/ because they are used outside of easysetup too. After checking in,
2739 svn will allow me to rename them too.
2741 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2743 * src/gnome/modest-msg-edit-window.c:
2744 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2745 linker error, to fix the build on the GNOME platform.
2746 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2747 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2748 ifdefed out to avoid a warning.
2750 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2752 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2753 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2754 some alternative for GTK+ 2.6.
2756 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2758 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2760 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2761 specified for EmailAccountsDialog in UI spec.
2763 * src/maemo/easysetup/modest-easysetup-wizard.c:
2764 * src/maemo/easysetup/modest-easysetup-wizard.h:
2765 * src/maemo/modest-account-settings-dialog.c:
2766 * src/maemo/modest-account-settings-dialog.h:
2767 Reuse a member window widget for the connection-specific SMTP server accounts,
2768 so we can tell it to create/save the accounts only if we actually save changes.
2770 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2772 (modest_connection_specific_smtp_edit_window_get_settings):
2773 Return a struct instance for temporarily remembering the entered data.
2775 * src/maemo/modest-connection-specific-smtp-window.h:
2776 * src/maemo/modest-connection-specific-smtp-window.c:
2777 (modest_connection_specific_smtp_window_finalize),
2778 (modest_connection_specific_smtp_window_fill_with_connections),
2780 (modest_connection_specific_smtp_window_save_server_accounts),
2781 (update_model_server_names): Do not actually save data until asked,
2782 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2784 (on_selection_changed),
2785 (modest_connection_specific_smtp_window_init): Disable the edit
2786 button when nothing is selected.
2788 * src/modest-account-mgr-helpers.c:
2789 * src/modest-account-mgr-helpers.h:
2790 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2793 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2795 * src/modest-account-mgr-helpers.h:
2796 * src/modest-account-mgr-helpers.c:
2797 (modest_account_mgr_get_unused_account_name),
2798 (modest_account_mgr_get_unused_account_display_name): Added these
2799 utility functions, to avoid code duplication.
2801 * src/maemo/easysetup/modest-easysetup-wizard.c:
2802 (create_page_account_details), (create_account):
2803 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2804 (on_combo_security_changed),
2805 (modest_connection_specific_smtp_edit_window_init),
2806 (modest_connection_specific_smtp_edit_window_save_settings):
2807 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2808 * src/maemo/modest-connection-specific-smtp-window.c:
2809 (modest_connection_specific_smtp_window_finalize),
2810 (modest_connection_specific_smtp_window_fill_with_connections),
2811 (on_button_edit), (modest_connection_specific_smtp_window_init):
2812 * src/maemo/modest-connection-specific-smtp-window.h:
2813 Implementing saving of connection-specific server accounts.
2815 But I need to refactor this so we can save the data for each
2816 possible connection-specific account and only actually create the server accounts
2817 when the easysetup finished, or the OK button is pressed on the account settings
2820 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2822 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2823 (on_combo_security_changed):
2824 (modest_connection_specific_smtp_edit_window_init):
2825 Auto-fill the port number as in the account settings.
2827 (modest_connection_specific_smtp_edit_window_set_connection):
2828 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2829 * src/maemo/modest-connection-specific-smtp-window.c:
2830 (fill_with_connections), (on_button_edit),
2831 (modest_connection_specific_smtp_window_init):
2832 Turn the edit window into a dialog to simplify the code, and
2833 set a WM hint as in a GtkDialog, because only a popup can be on top of
2834 another window in Maemo, and popups usually have no WM decoration.
2836 * src/modest-defs.h:
2837 * src/modest-account-mgr-helpers.c:
2838 (modest_account_mgr_set_connection_specific_smtp),
2839 (modest_account_mgr_remove_connection_specific_smtp),
2840 (modest_account_mgr_get_connection_specific_smtp):
2841 * src/modest-account-mgr-helpers.h: Some functions to write the
2842 connection-specific SMTP server information. Not yet used.
2845 * src/widgets/modest-folder-view.c: (text_cell_data):
2846 Fix a warning about an uninitialized variable.
2847 (on_configuration_key_changed): Put an #ifdef around the use
2848 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2850 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2852 * src/maemo/modest-account-settings-dialog.h:
2853 * src/maemo/modest-account-settings-dialog.c:
2854 Added connect_for_modified() utility function to mark the new modified boolean.
2856 (create_page_account_details), (create_page_user_details),
2857 (create_page_incoming), (create_page_outgoing), (on_response),
2858 (modest_account_settings_dialog_init),
2859 (modest_account_settings_dialog_set_account_name):
2860 Only warn about unsaved changes when there are actually unsaved changes.
2862 * src/modest-account-mgr-helpers.c:
2863 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2864 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2865 to get the data from there in future.
2867 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2869 * src/modest-defs.h:
2871 * src/modest-account-mgr-helpers.h:
2872 * src/modest-account-mgr-helpers.c:
2873 Store the security account setting in a single conf key instead of using
2874 the options list, so that the list is left for just the to-be-removed camel hack,
2875 and because gconf_client_set_list() is failing for some reason.
2877 * src/modest-account-mgr.c:
2878 (modest_account_mgr_add_server_account):
2879 * src/maemo/modest-account-settings-dialog.c:
2880 (modest_account_settings_dialog_set_account_name),
2881 (save_configuration): Use the renamed functions.
2884 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2886 * src/widgets/Makefile.am:
2887 * src/widgets/modest-limit-retrieve-combo-box.c:
2888 * src/widgets/modest-limit-retrieve-combo-box.h:
2889 * src/widgets/modest-retrieve-combo-box.c:
2890 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2891 the account settings dialog.
2893 * src/modest-defs.h:
2894 * src/modest-account-mgr-helpers.h:
2895 * src/modest-account-mgr-helpers.c:
2896 (modest_server_account_get_option_secure_auth),
2897 (modest_server_account_set_option_secure_auth):
2898 * src/modest-account-mgr.c:
2899 (modest_account_mgr_add_server_account):
2900 Use the existing AUTH_MECH conf key for the secure-auth setting,
2901 instead of putting it in the list options, because this was actually used already.
2903 * src/maemo/modest-account-settings-dialog.c:
2904 (create_page_account_details),
2905 (modest_account_settings_dialog_set_account_name),
2906 (save_configuration):
2907 * src/maemo/modest-account-settings-dialog.h:
2908 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2909 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2911 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2913 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2914 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2915 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2917 * src/modest-defs.h:
2918 * src/maemo/modest-account-settings-dialog.c:
2919 (create_page_incoming), (on_combo_outgoing_security_changed),
2920 (on_combo_incoming_security_changed), (create_page_outgoing),
2921 (modest_account_settings_dialog_set_account_name),
2922 (save_configuration): Load/Save the port number, and change it when the
2923 security combo changes, to suitable defaults.
2925 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2927 * src/modest-account-mgr.c:
2928 (modest_account_mgr_add_server_account): Set the security and secure-auth
2929 options, and add a comment saying that the other camel-specific options should be
2932 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2934 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2936 * src/modest-tny-account-store.c: (account_list_free),
2937 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2938 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2941 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2943 * src/modest-protocol-info.c:
2944 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2945 is required by our UI spec. Maybe something in our implementation will use this eventually.
2946 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2947 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2948 instead of the previous 0 placeholder.
2950 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2951 secure-auth settings.
2952 * src/modest-account-mgr-helpers.h:
2953 * src/modest-account-mgr-helpers.c:
2954 (modest_server_account_data_get_option_secure_auth),
2955 (modest_server_account_set_option_secure_auth),
2956 (modest_server_account_data_get_option_security),
2957 (modest_server_account_set_option_security): Added this API for getting and setting the security
2958 and secure-auth settings.
2960 * src/maemo/modest-account-settings-dialog.h:
2961 * src/maemo/modest-account-settings-dialog.c:
2962 (modest_account_settings_dialog_finalize), (check_data),
2963 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2964 about changing titles.
2965 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2966 (save_configuration): Save the security and secure-auth settings.
2968 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2969 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2971 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2973 * src/modest-defs.h:
2974 * src/modest-account-mgr.c:
2975 (modest_account_mgr_add_server_account):
2976 Added and used defines for the options key and value pair strings,
2977 that are used so far, though they do not seem to correspond to anything in our
2978 UI specs or ModestProtocol enum.
2980 * src/modest-account-mgr-helpers.h:
2981 * src/modest-account-mgr-helpers.c:
2982 (compare_option_strings_for_name),
2983 (modest_server_account_data_get_option_value),
2984 (modest_server_account_data_get_option_bool),
2985 (modest_account_mgr_get_server_account_option):
2986 Added helper functions for parsing the options GSList.
2988 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2990 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2991 display name is based on the supplied account name.
2992 * src/modest-account-mgr.c:
2993 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2994 with an inefficient, but good-enough, implementation.
2996 * src/maemo/easysetup/modest-easysetup-wizard.c:
2997 (create_page_account_details), (on_before_next), (create_account):
2998 Check for existing display names rather than (non-user-visible) account names, and just
2999 create and set a unique account name at the end.
3001 * src/maemo/modest-account-settings-dialog.c:
3002 (modest_account_settings_dialog_init),
3003 (modest_account_settings_dialog_set_account_name),
3004 (create_page_incoming): Show the display name, instead of the account name.
3005 (on_response): Do some (not all) extra checks, as in the UI spec.
3006 (save_configuration): Save the display name if it was changed.
3008 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3010 * po/en_GB.po: Added needed logical ID and translation.
3011 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3012 (init_view): Made the is-default column clicking work.
3014 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3017 * src/maemo/easysetup/Makefile.am:
3018 * src/maemo/easysetup/modest-easysetup-wizard.c:
3019 (modest_easysetup_wizard_dialog_init):
3020 * src/maemo/easysetup/provider-data-test.keyfile:
3021 * src/maemo/easysetup/provider-data.keyfile:
3022 Moved the provider data file to the new modest-providers-data package and used it from there.
3024 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3026 * src/modest-local-folder-info.c:
3027 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3028 N_() was already used on the static strings, but this just marks it for translation without
3029 using the translation.
3031 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3033 * src/maemo/modest-account-settings-dialog.c:
3034 (create_page_incoming),
3035 (modest_account_settings_dialog_set_account_name):
3036 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3037 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3038 I will do this if nobody else gets there first.
3040 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3042 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3043 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3044 save the security stuff.
3046 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3048 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3049 Set the email address and user fullname, which I now see must be
3052 * src/maemo/modest-account-settings-dialog.h:
3053 * src/maemo/modest-account-settings-dialog.c:
3055 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3056 leave-on-server and authentication.
3057 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3060 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3063 * src/maemo/modest-account-settings-dialog.c:
3064 * src/maemo/modest-account-settings-dialog.h:
3065 Most (but not all) of the widgets are now present as specified by the UI spec.
3066 No changes are yet saved, and some details are not properly shown yet.
3068 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3070 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3072 * src/maemo/Makefile.am:
3073 * src/maemo/modest-account-settings-dialog.c:
3074 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3075 an existing account. Doesn't do much yet.
3077 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3078 Open the accounts settings dialog when Edit is clicked.
3080 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3082 * src/maemo/easysetup/Makefile.am:
3083 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3085 * src/maemo/easysetup/modest-easysetup-wizard.c:
3086 (modest_easysetup_wizard_dialog_init):
3087 Try to get the source directory from the build system,
3088 instead of hard-coding "./" into the source code, when opening our local
3089 copies of the configuration files.
3090 But this still fails when opening the wizard from the Accounts window,
3091 maybe because the working directory seems to change at runtime.
3092 So the wizard will fail the second time unless you copy the files into their
3093 proper locations - see the stdout warnings for the paths.
3095 (create_page_account_details),(on_before_next):
3096 Check for existing non-server accounts instead of server accounts,
3097 so the default account name is useful again, and to prevent trying to
3100 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3101 Show the wizard when New is clicked.
3103 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3104 (init_view): Show the column headers, and show the columns that are
3105 specified in the UI specs. However, something in Maemo's GTK+ prevents
3106 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3107 change the default account. This is despite unsetting the special properties.
3109 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3111 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3112 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3113 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3114 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3115 to make that clearer.
3116 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3118 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3120 * src/maemo/modest-account-view-window.c:
3121 (modest_account_view_window_init),
3122 (modest_account_view_window_new):
3123 Use the same buttons as specified in the
3124 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3125 the existing widgets, which never had a chance of working.
3126 Put the ModestAccountView treeview in a scrolled window.
3127 Do not repeat the initialization in both _init() and _new().
3129 * src/widgets/modest-account-view.c: (update_account_view):
3130 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3131 this widget and window shows no accounts.
3133 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3135 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3137 * src/maemo/easysetup/modest-easysetup-wizard.c:
3138 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3139 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3140 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3143 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3144 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3145 accounts exist yet, as in the UI spec.
3147 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3149 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3151 * src/maemo/Makefile.am:
3152 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3153 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3154 New window for editing connection-specific smtp details.
3155 Not fully implemented.
3157 * src/maemo/modest-connection-specific-smtp-window.c:
3158 (modest_connection_specific_smtp_window_finalize) :
3159 unref the tree model.
3160 (on_button_edit): Show the edit window.
3162 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3164 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3167 * src/maemo/Makefile.am:
3168 * src/maemo/modest-connection-specific-smtp-window.c:
3169 * src/maemo/modest-connection-specific-smtp-window.h:
3170 New window for showing the list of connections, for connection-specific
3171 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3172 * src/maemo/easysetup/modest-easysetup-wizard.c:
3173 (create_page_custom_outgoing): Show the new window when the button is clicked.
3175 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3177 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3178 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3179 * src/maemo/modest-msg-edit-window.c:
3180 (modest_msg_edit_window_insert_image):
3181 * src/modest-conf.c: (modest_conf_key_escape):
3182 * src/modest-mail-operation.c:
3183 (modest_mail_operation_send_new_mail):
3184 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3185 (modest_ui_actions_on_new_account):
3186 * src/widgets/modest-attachment-view.c: (update_filename_request):
3187 * src/widgets/modest-mail-header-view.c:
3188 Corrected warnings that were breaking the build, by commenting out unused variables,
3189 and a function, and by including a header.
3191 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3193 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3194 so we can #ifdef around platform-specific code when necessary.
3195 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3196 to allow this to build for the GNOME platform too.
3198 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3200 * src/maemo/easysetup/modest-easysetup-wizard.c:
3201 Added util_increment_name() and used it in create_page_account_details()
3202 to make sure that the default account name is always a new name.
3204 (modest_easysetup_wizard_dialog_init),
3205 (set_default_custom_servernames): Some minor memory management fixes.
3207 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3211 * src/modest-runtime.c: (init_i18n): Restored the translation
3212 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3213 are defined in config.h, and the translations are installed.
3215 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3216 is defined for translation.
3218 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3220 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3222 * src/maemo/easysetup/modest-easysetup-wizard.c:
3223 (modest_easysetup_wizard_dialog_init):
3224 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3225 Use realistic paths (though they should use $prefix generically) to the
3226 mcc_mapping and provider-data.keyfile files which might work when they
3227 are installed by the future version of the operator-wizard package,
3228 and then fallback to paths in our source code, with an explanatory
3231 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3235 * src/maemo/Makefile.am:
3236 * src/maemo/easysetup/: Added files from the previously-exernal
3237 osso-modest-easysetup.
3238 * src/maemo/modest-main-window-ui.h:
3239 * src/modest-ui-actions.c:
3240 * src/modest-ui-actions.h:
3241 Added modest_ui_actions_on_new_account() as a signal handler for the
3242 New Account menu item. It shows the easysetup wizard.
3243 * po/en_GB.po: Added additional needed logical IDs and translations.