1 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
4 parameter const, just to be neat.
5 * src/modest-text-utils.c: (modest_text_utils_inline):
6 End g_strconcat() with NULL, as its documentation says. This is almost
7 certainly the cause of my crash at startup on the device. Interestingly,
8 valgrind doesn't tell us about these errors.
10 2007-05-11 Murray Cumming <murrayc@murrayc.com>
12 * scripts/build-packages: Added more precise comments about how to use
13 this script, though I still get this error:
14 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
15 error building tinymail
17 2007-05-11 Murray Cumming <murrayc@murrayc.com>
19 * src/maemo/modest-main-window.c: (on_account_update):
20 Very slight cleanup, hoping to make it simpler to discover what causes
21 a crash here sometimes.
23 * src/modest-tny-account.c:
24 (modest_tny_account_new_from_server_account): Set the port. Added
25 comments about the options and a TODO comment because I need to find out
26 how to specify the secure authentication method.
28 2007-05-11 Marcus Bauer <marcusb@openismus.com>
30 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
31 changed CFlags paths form modest to libmodest
33 2007-05-10 Murray Cumming <murrayc@murrayc.com>
35 * src/modest-account-mgr-helpers.c:
36 (modest_account_mgr_get_server_account_data),
37 (modest_account_mgr_free_server_account_data):
38 * src/modest-account-mgr-helpers.h:
39 * src/modest-account-mgr.c:
40 (modest_account_mgr_add_server_account):
42 * src/modest-tny-account.c:
43 (modest_tny_account_new_from_server_account):
44 Determine the options for tny_camel_account_add_option() here,
45 based on the settings, rather than storing them directly in gconf.
47 2007-05-10 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
50 Show a more friendly error dialog now that we expect (from the tinymail
51 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
53 2007-05-10 Murray Cumming <murrayc@murrayc.com>
55 * src/maemo/modest-main-window.c: (on_account_update): Check that
56 account_name is not NULL, to prevent a crash at startup that I am
57 seeing on the N800. I do wonder why it is NULL.
59 * src/maemo/easysetup/modest-easysetup-wizard.c:
60 (create_page_user_details):
61 * src/maemo/modest-account-settings-dialog.c:
62 (create_page_user_details), (create_page_outgoing):
63 * src/maemo/modest-connection-specific-smtp-edit-window.c:
64 (modest_connection_specific_smtp_edit_window_init):
65 * src/modest-ui-actions.c:
66 (modest_ui_actions_on_password_requested):
67 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
68 might do something useful with the on-screen keyboard.
70 2007-05-10 Murray Cumming <murrayc@murrayc.com>
72 * src/maemo/modest-main-window.c: (on_account_update):
73 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
74 NULL, to avoid lots of warnings. However, it probably should not be NULL.
76 2007-05-09 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-tny-account-store.c: (on_account_changed):
79 Correct the signature of this signal handler.
81 2007-05-09 Murray Cumming <murrayc@murrayc.com>
83 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
84 Show a HildonNote instead of a GtkDialog for Maemo.
86 2007-05-09 Murray Cumming <murrayc@murrayc.com>
88 * src/widgets/modest-account-view.h:
89 * src/widgets/modest-account-view.c: (on_account_changed),
90 (on_account_removed). Added a boolean flag, set/unset by
91 modest_account_view_block_conf_updates(),
92 modest_account_view_unblock_conf_updates() to prevent unnecessary
93 updates, but this is not very useful because the gconf notifications are
94 so delays (maybe only on Maemo Bora).
95 So auto-updating is turned off, and these functions do an explicit
96 update when necessary.
97 However, something else is still doing too much work when adding/removing
98 accounts, probably in another part of the application.
100 * src/maemo/modest-account-view-window.c:
101 (on_delete_button_clicked), (on_edit_button_clicked),
102 (on_new_button_clicked): Use the new functions.
104 2007-05-09 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-account-mgr-helpers.c:
107 (modest_account_mgr_set_first_account_as_default):
108 Sort the list of names alphabetically-by-title, so we choose the first one
110 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
111 alphabetically by the title.
113 This fixes projects.maemo.org bug NB#56418 .
115 * src/modest-account-mgr-priv.c:
116 (_modest_account_mgr_account_from_key):
117 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
118 avoid a valgrind error, and possible random behaviour.
120 2007-05-09 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
123 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
124 tinymail documentation to say that this can be expected.
125 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
126 pretty, and should not happen, but I would prefer to know when it does.
128 2007-05-09 Murray Cumming <murrayc@murrayc.com>
130 * configure.ac: When using the older hildon version, probably on Bora,
131 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
133 * src/widgets/modest-attachment-view.c:
134 (modest_attachment_view_set_part_default): Initialize variables, to fix the
137 2007-05-09 Marcus Bauer <marcusb@openismus.com>
139 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
140 Implemented the prototype. Can be tested with
141 tests/dbus_api/test_open_message:
143 2007-05-08 Murray Cumming <murrayc@murrayc.com>
145 * src/modest-tny-account-store.c:
146 (modest_tny_account_store_instance_init), (get_password):
147 * src/modest-ui-actions.c:
148 (modest_ui_actions_on_password_requested):
149 Do not store the password in gconf, because this function is called
150 for non-remembered passwords. Actually use the cached (in the hash map)
151 password instead of releasing it.
152 The password will now not be remembered if it is asked via the protected
153 password dialog, as per the UI spec.
155 2007-05-08 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-account-mgr-helpers.h:
159 * src/modest-account-mgr-helpers.c:
160 Added modest_server_account_get_username_has_succeeded(),
161 modest_server_account_set_username_has_succeeded().
162 (modest_server_account_set_username),
163 Reset the has-succeeded flag if the username changes.
165 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
166 * src/maemo/modest-connection-specific-smtp-window.c:
167 (modest_connection_specific_smtp_window_save_server_accounts):
168 Use modest_server_account_set_username() instead of using
169 modest_conf_set_string() directly, so that the has-succeeded flag is always
172 * src/modest-ui-actions.c:
173 (modest_ui_actions_on_password_requested): Dim the username entry if
174 the username has ever worked, as per the UI spec.
176 2007-05-08 Murray Cumming <murrayc@murrayc.com>
178 * src/modest-tny-account-store.c: (get_password):
179 * src/modest-ui-actions.c:
180 (modest_ui_actions_on_password_requested):
181 Allow the username to be changed too, though there is more work to
182 be done on exactly how this behaves.
184 2007-05-08 Murray Cumming <murrayc@murrayc.com>
186 * src/modest-account-mgr-helpers.h:
187 * src/modest-account-mgr-helpers.c:
188 Added modest_account_mgr_get_display_name(),
189 modest_server_account_get_username(),
190 modest_server_account_set_username(),
191 modest_server_account_set_password(),
192 modest_server_account_get_hostname() functions so we do not need to
193 use the conf API directly.
195 * src/maemo/modest-main-window.c: (connect_signals):
196 Actually connect ot the ModestAccountStore::request-password signal,
197 so that we show the dialog when the password is requested by Tinymail,
198 for isntance if it is empty.
200 * src/modest-marshal.list:
201 * src/modest-tny-account-store.c:
202 (modest_tny_account_store_class_init), (get_password),
203 (modest_tny_account_store_alert):
204 * src/modest-tny-account-store.h:
205 * src/modest-ui-actions.h:
206 * src/modest-ui-actions.c:
207 (modest_ui_actions_on_password_requested):
208 Change the signal parameters, so it is obvious that we are providing
209 the non human-readable server name, and receiving both the username
210 and password, though changing of the username is not yet implemented.
211 Change the dialog UI to match the Maemo UI specifications, with #idfefing
212 for the GNOME version.
214 This should fix the projects.maemo.org bug NB#56209, though it does not
215 work on Bora, because the gconf_client_get() for the password fails
216 immediately after we save it with gconf_client_set().
218 2007-05-08 Murray Cumming <murrayc@murrayc.com>
221 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
222 caused an undefined symbol error:
223 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
225 2007-05-08 Murray Cumming <murrayc@murrayc.com>
227 * src/modest-tny-account-store.c:
228 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
229 using a GError instead of a string message, so we can translate it in
232 2007-05-08 Murray Cumming <murrayc@murrayc.com>
234 * src/maemo/modest-address-book.c:
235 (modest_address_book_check_names):
236 * src/maemo/modest-msg-view-window.c:
237 (modest_msg_view_window_clipboard_owner_change):
238 * src/modest-init.c: (modest_init_init_ui):
239 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
240 (update_folders_cb), (modest_mail_operation_update_account):
241 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
242 (modest_ui_actions_on_msg_attachment_clicked),
243 (modest_ui_actions_on_msg_recpt_activated):
244 * src/widgets/modest-header-view.c: (drag_data_get_cb):
245 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
246 (modest_msg_view_search_next):
247 * src/widgets/modest-recpt-editor.c:
248 (modest_recpt_editor_on_button_release_event),
249 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
250 g_message(). At this point we should only be seeing interesting errors on
251 stdout. Debugging messages could be #ifdefed-out if they are still useful.
253 2007-05-07 Murray Cumming <murrayc@murrayc.com>
255 (modest_wizard_dialog_force_title_update):
256 * src/maemo/easysetup/modest-wizard-dialog.h:
257 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
258 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
259 can update the title when appropriate. Otherwise the title is wrong if the
260 pages are added after adding the notebook to the dialog.
261 This must be a problem in HildonWizardDialog too.
262 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
264 * src/maemo/easysetup/modest-easysetup-wizard.c:
265 (create_subsequent_customsetup_pages),
266 (create_subsequent_easysetup_pages):
267 Call modest_wizard_dialog_force_title_update() so that the title is
268 correct even with GTK+ < 2.10.
269 This fixes projects.maemo.org bug NB#56145 .
271 2007-05-07 Murray Cumming <murrayc@murrayc.com>
273 * src/maemo/modest-platform.c:
274 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
275 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
278 2007-05-07 Murray Cumming <murrayc@murrayc.com>
280 * src/widgets/modest-window.h:
281 * src/widgets/modest-window.c: Added a save_state_func vfunc,
282 and modest_window_save_state(), which invokes it.
284 * src/widgets/modest-window-mgr.h:
285 * src/widgets/modest-window-mgr.c:
286 Added modest_window_mgr_save_state_for_all_windows(), which calls
287 the save_state vfunc on all registered windows, if implemented.
289 * src/gnome/modest-msg-edit-window.c:
290 * src/gnome/modest-msg-view-window.c:
291 * src/maemo/modest-msg-edit-window.c:
292 * src/maemo/modest-msg-view-window.c:
293 * src/maemo/modest-main-window.c:
294 Specify the existing save_settings functions as implementations of
295 ModestWindow::save_state_func().
297 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
298 Call modest_window_mgr_save_state_for_all_windows(). This happens before
299 enabling hibernation, for instance.
301 We may need to do the same thing for restoring settings.
304 2007-05-07 Murray Cumming <murrayc@murrayc.com>
306 * src/widgets/modest-window-mgr.c:
307 * src/widgets/modest-window-mgr.h:
308 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
309 modest_window_mgr_get_hibernation_is_prevented().
311 * src/maemo/modest-main-window.c:
312 (on_hildon_program_is_topmost_notify): Prevent hibernation
313 (possible when the application goes to the background in the WM),
314 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
316 * src/maemo/easysetup/modest-easysetup-wizard.c:
317 (modest_easysetup_wizard_dialog_init):
318 * src/maemo/modest-account-settings-dialog.c:
319 (modest_account_settings_dialog_init):
320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
321 (modest_connection_specific_smtp_edit_window_init):
322 * src/maemo/modest-connection-specific-smtp-window.c:
323 (modest_connection_specific_smtp_window_init):
324 * src/maemo/modest-signature-editor-dialog.c:
325 (modest_signature_editor_dialog_init):
326 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
327 prevent hibernation while any of these account settings dialogs are open.
329 2007-05-04 Murray Cumming <murrayc@murrayc.com>
331 * src/maemo/Makefile.am:
332 * src/maemo/modest-osso-state-saving.c:
333 * src/maemo/modest-osso-state-saving.h: Added
334 modest_osso_load_state() and modest_osso_save_state() though they do
335 nothing now. They should iterate through all the open windows and load/save
337 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
338 save state when closing.
340 * src/maemo/modest-main-window.c:
341 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
342 Add a notification handler for the HildonProgram::is-topmost property,
343 so we can allow hibernation when the application goes into the background.
344 But we still need to detect when the accounts setup windows are open so
345 we can stop hibernation when they are open.
346 To do this, I also added the main window the HildonProgram. This might have
347 other side-effects/benefits, and should maybe be done for other windows.
349 * src/maemo/modest-osso-autosave-callbacks.h:
350 * src/maemo/modest-osso-autosave-callbacks.c:
351 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
352 though it does not do anything yet, and we might never need this to do
353 anything. For instance, we already save drafts.
355 * src/maemo/modest-platform.c: (modest_platform_init):
356 Specify the libosso auto-save callback.
358 2007-05-03 Murray Cumming <murrayc@murrayc.com>
360 * src/maemo/modest-platform.c:
361 (modest_platform_set_update_interval):
362 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
363 aparently stays valid between application instances, so we can use this
364 to remove and reset it later. According to a maemo-developers email from
367 2007-05-03 Murray Cumming <murrayc@murrayc.com>
369 * configure.ac: Depend on libalarm for Maemo.
371 * src/dbus_api/modest-dbus-api.h:
372 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
373 (on_send_receive), (modest_dbus_req_handler):
374 Handle a SEND_RECEIVE D-Bus method.
376 * libmodest-dbus-client/libmodest-dbus-client.c:
377 (libmodest_dbus_client_send_and_receive):
378 * libmodest-dbus-client/libmodest-dbus-client.h:
379 Add C convenience functions for calling the new D-Bus method.
381 * src/modest-platform.h:
382 * src/gnome/modest-platform.c:
383 * src/maemo/modest-platform.c:
384 Added modest_platform_set_update_interval(), which uses the
386 (modest_platform_init),
387 Call modest_platform_set_update_interval(), using a hard-coded
388 interval for now (until the global settings dialog is implemented),
389 though I am not sure that this makes sense yet.
391 2007-05-02 Murray Cumming <murrayc@murrayc.com>
393 * src/dbus_api/modest-dbus-callbacks.c:
394 (modest_osso_cb_hw_state_handler):
395 * src/dbus_api/modest-dbus-callbacks.h:
396 * src/maemo/modest-platform.c: (modest_platform_init):
397 Registered (empty) callbacks for the osso hardware state D-Bus signals,
398 in case this has some effect on the ability for Maemo to ping the
401 2007-05-02 Murray Cumming <murrayc@murrayc.com>
403 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
404 Comment out an if() that checks a gchar for < 0, causing a build-breaking
405 warning. It is probably a logic error, but I need to fix the build.
407 2007-05-02 Murray Cumming <murrayc@murrayc.com>
409 * src/modest-account-mgr.h:
410 * src/modest-account-mgr.c:
411 (modest_account_mgr_account_names): Add a gboolean enabled_only
412 parameter, so we can get lists of onlt the enabled accounts.
414 (modest_account_mgr_add_account),,
415 (modest_account_mgr_account_with_display_name_exists):
416 * src/maemo/modest-msg-edit-window.c: (get_transports):
417 * src/modest-account-mgr-helpers.c:
418 (modest_account_mgr_set_first_account_as_default):
419 * src/modest-init.c: (init_default_account_maybe):
420 * src/modest-tny-account-store.c: (get_accounts):
421 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
422 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
423 * tests/check_account-mgr.c: (START_TEST):
424 Provide the extra parameter, as appropriate.
426 * src/widgets/modest-account-view.c: (update_account_view):
427 Do not show disabled accounts (meaning that there is no way to
428 enable/disable accounts in the UI (the feature is not in our UI
429 specification), so we can use this internally only to mark unfinished
430 or temporary account data.
432 * src/maemo/easysetup/modest-easysetup-wizard.c:
433 (create_account): Add boolean enable parameter, so we can specify FALSE
434 to create the temporary account.
435 (on_button_edit_advanced_settings): Create the temporary account as disabled.
436 (on_before_next): When finishing, when there is a temporary account, just
438 Also, use a timeout to delay the showing of the dialog until gconf is likely
439 to return correct information, due to a maemo gconf bug that is fixed in
440 osso 1.1, but not yet in Bora.
441 However, the dialog stays on screen after it is destroyed.
443 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
444 for invalid data when cancelling. Use a hildon note instead of a dialog
445 to complain about invalid data. Do not show the account-saved note if the
446 account is disabled (a temporary account that will not really be saved for use
449 2007-04-30 Murray Cumming <murrayc@murrayc.com>
451 * src/modest-account-mgr-helpers.h:
452 * src/modest-account-mgr-helpers.c:
453 Added modest_account_mgr_unset_default_account(),
454 Added modest_account_mgr_set_first_account_as_default().
456 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
457 If it was the default account, unset the default account name.
459 * src/maemo/modest-account-view-window.c:
460 (on_delete_button_clicked): If it was the default account,
461 set the first remaining account as the default instead.
463 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
464 a NULL account or a NULL default account, to prevent a crash. This should
465 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
468 2007-04-30 Murray Cumming <murrayc@murrayc.com>
470 * src/widgets/modest-recpt-editor.c:
471 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
472 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
473 TODO comment for this. This fixes the build.
475 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
476 be the best place for it. This will in future update all auto-update accounts,
477 rather than just the current/default account, when that gconf key exists.
478 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
479 if there are no accounts, before calling do_send_receive().
480 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
482 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
483 * src/maemo/modest-main-window-ui.h:
484 * src/maemo/modest-main-window.c: (on_connection_changed),
485 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
486 directly, becaue the signal handler does more.
488 2007-04-30 Murray Cumming <murrayc@murrayc.com>
490 * src/modest-account-mgr-helpers.c:
491 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
492 for the case that the account does not exist.
494 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
495 (equivalent to the modest account name) rather than the tinymail account name
496 (equivalent to the modest account title - human readable) to get the account data.
497 Check for null account data to prevent the crash, and add a TODO comment saying that
498 this needs fixing because it is using the server account name instead of the account name.
500 2007-04-29 Murray Cumming <murrayc@murrayc.com>
502 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
503 * src/maemo/modest-account-settings-dialog.c: (show_error),
505 Use hildon_note_new_information() for informative and error messages,
506 which seems to be expected for Maemo applications (no documentation that I know of
507 says this). I am surprised that there is no distinction between info and error
510 2007-04-29 Murray Cumming <murrayc@murrayc.com>
512 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
513 it is easy to find where this is used.
515 * src/maemo/easysetup/modest-easysetup-wizard.c:
516 (create_page_welcome), (create_page_account_details),
517 (create_page_user_details), (create_page_complete_easysetup),
518 (create_page_custom_incoming), (create_page_custom_outgoing),
519 (create_page_complete_custom):
520 * src/maemo/modest-account-settings-dialog.c:
521 (create_page_account_details), (create_page_user_details),
522 (create_page_incoming), (create_page_outgoing):
523 * src/maemo/modest-account-view-window.c: (window_vbox_new):
524 * src/maemo/modest-connection-specific-smtp-edit-window.c:
525 (modest_connection_specific_smtp_edit_window_init):
526 * src/maemo/modest-connection-specific-smtp-window.c:
527 (modest_connection_specific_smtp_window_init):
528 * src/maemo/modest-signature-editor-dialog.c:
529 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
530 and scrolling policy as per the Email Application Layout Guide, if I have
533 2007-04-27 Murray Cumming <murrayc@murrayc.com>
535 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
536 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
537 which were empty, because these vfuncs have been removed from TnyAccountStore.
538 This fixes the build.
540 2007-04-27 Murray Cumming <murrayc@murrayc.com>
542 * src/maemo/modest-main-window.c:
543 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
544 showing/hiding it. Added TODO because it probably should not be NULL.
545 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
546 because unnecessary g_warnings() make degugging difficult.
548 2007-04-27 Murray Cumming <murrayc@murrayc.com>
550 * src/maemo/modest-msg-edit-window.c:
551 (modest_msg_edit_window_select_color),
552 (modest_msg_edit_window_select_background_color): 2 const corrections and
553 moving 2 #endifs before closing brackets, to fix the build.
555 2007-04-27 Murray Cumming <murrayc@murrayc.com>
557 * src/maemo/easysetup/modest-easysetup-wizard.h:
558 * src/maemo/easysetup/modest-easysetup-wizard.c:
559 (modest_easysetup_wizard_dialog_finalize),
560 (on_button_edit_advanced_settings), (create_page_complete_custom),
561 (on_response), (create_account):
562 Implement the Advanced Settings edit button, by saving the account information,
563 for the Advanded Settings dialog to use directly from gconf, and removing it
564 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
565 Bug #5533 in the projects.maemo.org bugzilla.
567 2007-04-27 Murray Cumming <murrayc@murrayc.com>
569 * src/maemo/modest-msg-view-window.c:
570 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
571 when opening a message window.
573 2007-04-27 Murray Cumming <murrayc@murrayc.com>
575 * src/maemo/easysetup/modest-easysetup-wizard.c:
576 (create_page_custom_outgoing): Correct the position of the horizontal separator to
579 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
580 before showing/hiding them, to avoid a crash when clicking on folders when there are no
581 gconf settings. I probably added more checks than necessary, but that is safer.
583 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
584 variable to fix the build, but this seems to be used when it is still NULL.
586 2007-04-27 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-platform.h:
589 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
590 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
591 * src/modest-main.c: Implement this function so we can avoid using
592 maemo-specific API from cross-platform code.
594 * src/modest-tny-account-store.c:
595 (get_smtp_specific_transport_account_for_open_connection):
596 * src/modest-ui-actions.c: (check_for_connection),
597 (modest_ui_actions_on_item_not_found):
598 Use modest_platform_connect_and_wait() and put #idefs around other
599 maemo-specific code, because only maemo currently has a way to
600 identify connection names.
602 2007-04-27 Murray Cumming <murrayc@murrayc.com>
604 * src/modest-tny-account-store.h:
605 * src/modest-tny-account-store.c:
606 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
607 the connection-specific SMTP server settings in the configuration.
609 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
611 * src/maemo/modest-main-window.c: (on_connection_changed),
613 * src/modest-main.c: (main), (start_ui), (send_mail):
614 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
615 that is what is intended.
617 * src/modest-ui-actions.c: (action_send), (action_receive),
618 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
619 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
620 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
621 SMTP server is used when it is specified.
623 (modest_ui_actions_on_send_receive):
624 Check that a connection is open before proceeding.
625 Receive and then send, instead of vice-versa, as per the specification.
627 2007-04-26 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-mail-operation.c:
630 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
631 though I guess it should be something other than NULL.
633 2007-04-26 Murray Cumming <murrayc@murrayc.com>
635 * src/maemo/easysetup/modest-easysetup-wizard.c:
636 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
637 combo twice, to avoid an g_warning and to make it visible again.
638 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
639 attached before detaching it, to avoid a g_warning, and add comment about the implicit
640 (already intended) dereference when detaching, because we then recreate the menu.
641 But I am not sure why the warning was happening, and it is possible that this is a memory
644 2007-04-25 Murray Cumming <murrayc@murrayc.com>
646 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
647 and uri_parse_mailto() utility functions.
648 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
650 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
652 2007-04-24 Murray Cumming <murrayc@murrayc.com>
654 * src/dbus_api/modest-dbus-api.h:
655 * src/dbus_api/modest-dbus-callbacks.c:
656 Use an idle callback to execute the modest code in the application's own thread.
657 Remove the helloworld example method.
658 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
659 parsed, and the open-message method is not implemented because this is not yet implemented in
661 * libmodest-dbus-client/libmodest-dbus-client.c:
662 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
663 (libmodest_dbus_client_open_message):
664 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
666 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
667 body without crashing.
669 * tests/dbus_api/Makefile.am:
670 * tests/dbus_api/test_mail_to.c:
671 * tests/dbus_api/test_open_message.c: New tests for the new methods.
673 2007-04-24 Murray Cumming <murrayc@murrayc.com>
675 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
676 Added file to fix the build. Sorry.
678 * src/dbus_api/Makefile.am:
679 * src/dbus_api/modest-dbus-api.h:
680 * src/dbus_api/modest-dbus-callbacks.h:
681 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
682 (modest_dbus_req_handler):
683 Put constants in a separate header so it can be reused by the
684 client library, without duplication
686 * libmodest-dbus-client/Makefile.am:
687 * libmodest-dbus-client/libmodest-dbus-client.c:
688 (libmodest_dbus_client_call_helloworld),
689 (libmodfest_dbus_client_send_mail),
690 (libmodfest_dbus_client_mailto),
691 (libmodfest_dbus_client_open_message):
692 * libmodest-dbus-client/libmodest-dbus-client.h:
693 (Partly) Implement a send_mail D-Bus method.
695 * tests/dbus_api/Makefile.am:
696 * tests/dbus_api/test_send_mail.c: (main): Added a test for
697 the send_email D-Bus method.
699 2007-04-24 Murray Cumming <murrayc@murrayc.com>
703 * libmodest-dbus-client/Makefile.am:
704 * libmodest-dbus-client/libmodest-dbus-client.c:
705 * libmodest-dbus-client/libmodest-dbus-client.h:
706 * tests/dbus_api/Makefile.am:
707 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
708 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
710 2007-04-24 Murray Cumming <murrayc@murrayc.com>
712 * src/maemo/easysetup/modest-easysetup-wizard.c:
713 (create_page_account_details):
714 * src/maemo/modest-account-settings-dialog.c:
715 (create_page_account_details): Explicitly set auto-capitalization mode for the title
716 widgets, because this might not be the default in future versions of the Maemo GTK+.
717 However, I can not not get capitalization to work even in a simple test case.
719 2007-04-24 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/easysetup/modest-easysetup-wizard.c:
722 (create_page_custom_incoming), (create_page_custom_outgoing):
723 * src/maemo/modest-account-settings-dialog.c:
724 (create_page_account_details), (create_page_incoming),
725 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
726 instead of using gtk_check_button_with_label(), so they are aligned like the other
727 widgets, as per the UI spec.
729 2007-04-24 Murray Cumming <murrayc@murrayc.com>
731 * src/maemo/easysetup/modest-easysetup-wizard.c:
732 * src/maemo/modest-connection-specific-smtp-edit-window.c:
733 * src/widgets/modest-validating-entry.c:
734 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
735 Modest prefix instead of an EasySetup prefix.
737 2007-04-23 Murray Cumming <murrayc@murrayc.com>
739 * src/widgets/modest-validating-entry.h:
740 * src/widgets/modest-validating-entry.c: (on_insert_text),
741 Added easysetup_validating_entry_set_max_func(), used to set a callback
742 to call when the max number of characters is reached. GtkEntry has a max-length
743 already but is silent about it.
745 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
746 (create_page_account_details), (create_page_user_details),
748 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
749 (create_page_account_details), (create_page_user_details),
750 (create_page_outgoing):
751 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
752 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
753 the UI spec, when the user tries to enter more than the max number of characters.
755 2007-04-23 Murray Cumming <murrayc@murrayc.com>
757 * src/maemo/easysetup/modest-easysetup-wizard.c:
758 (create_page_user_details), (create_page_custom_incoming),
759 (create_page_custom_outgoing):
760 * src/maemo/modest-account-settings-dialog.c:
761 (create_page_user_details), (create_page_incoming),
762 (create_page_outgoing):
763 * src/maemo/modest-connection-specific-smtp-edit-window.c:
764 (modest_connection_specific_smtp_edit_window_init):
765 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
766 not appropriate. Bad Maemo-specific defaults!.
768 2007-04-23 Murray Cumming <murrayc@murrayc.com>
770 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
771 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
772 (modest_signature_editor_dialog_set_settings):
773 Disable the label and textview when the checkbox is disabled, and use the
774 specified (UI spec) default signature text.
776 2007-04-23 Murray Cumming <murrayc@murrayc.com>
778 * src/maemo/modest-connection-specific-smtp-edit-window.c:
779 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
782 * src/modest-account-mgr-helpers.h:
783 * src/modest-account-mgr-helpers.c:
784 Added modest_account_mgr_get/set_signature(), using new gconf keys.
786 * src/maemo/Makefile.am:
787 * src/maemo/modest-signature-editor-dialog.c:
788 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
791 * src/maemo/modest-account-settings-dialog.h:
792 * src/maemo/modest-account-settings-dialog.c:
793 (modest_account_settings_dialog_finalize), (on_button_signature),
794 (save_configuration): Use the new dialog when the Edit button is pressed, and
795 save the changes if necessary, as per the UI spec.
797 2007-04-23 Murray Cumming <murrayc@murrayc.com>
799 * src/maemo/Makefile.am:
800 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
801 based on maemo-develoers email from Dirk.
803 * src/maemo/easysetup/modest-easysetup-wizard.c:
804 (create_page_welcome), (create_page_account_details),
805 (create_page_user_details), (create_page_complete_easysetup),
806 (create_page_custom_incoming), (create_page_custom_outgoing),
807 (create_page_complete_custom),
808 (modest_easysetup_wizard_dialog_init):
809 * src/maemo/modest-account-settings-dialog.c:
810 (create_page_account_details), (create_page_user_details),
811 (create_page_incoming), (create_page_outgoing),
812 (modest_account_settings_dialog_init):
813 * src/maemo/modest-connection-specific-smtp-window.c:
814 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
816 2007-04-23 Murray Cumming <murrayc@murrayc.com>
818 * src/maemo/easysetup/modest-easysetup-wizard.c:
819 (create_page_account_details), (create_page_custom_outgoing),
820 (create_page_complete_custom):
821 * src/maemo/modest-account-settings-dialog.c:
822 (create_page_user_details), (create_page_incoming),
823 (create_page_outgoing):
824 * src/maemo/modest-connection-specific-smtp-edit-window.c:
825 (modest_connection_specific_smtp_edit_window_init):
826 Use the correct (UI spec) port min/max, and use horizontal separators,
829 2007-04-23 Murray Cumming <murrayc@murrayc.com>
831 * src/maemo/easysetup/modest-easysetup-wizard.c:
832 (set_default_custom_servernames):
833 * src/maemo/modest-account-settings-dialog.c:
834 (create_page_incoming), (on_combo_outgoing_security_changed),
835 (on_combo_incoming_security_changed), (create_page_outgoing),
836 (modest_account_settings_dialog_set_account_name),
837 (save_configuration):
838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
839 (on_combo_security_changed),
840 (modest_connection_specific_smtp_edit_window_init),
841 (modest_connection_specific_smtp_edit_window_set_connection),
842 (modest_connection_specific_smtp_edit_window_get_settings):
843 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
846 2007-04-20 Murray Cumming <murrayc@murrayc.com>
849 * src/maemo/easysetup/modest-easysetup-wizard.c:
850 (create_page_custom_outgoing), (create_page_complete_custom):
851 * src/maemo/modest-account-settings-dialog.c:
852 (create_page_user_details), (create_page_outgoing):
853 * src/maemo/modest-account-view-window.c: (button_box_new):
854 Use changed logical IDs as per the most recent UI spec:
855 mcen_bd_emailsetup_edit -> mcen_bd_edit
856 mcen_bd_emailsetup_delete -> mcen_bd_delete
857 mcen_bd_emailsetup_close -> mcen_bd_close
859 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
863 * src/dbus_api/Makefile.am:
864 * src/dbus_api/modest-dbus-callbacks.c:
865 * src/dbus_api/modest-dbus-callbacks.h:
866 * src/maemo/modest-platform.c: (modest_platform_init):
867 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
870 * tests/dbus_api/Makefile.am:
871 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
873 2007-04-20 Murray Cumming <murrayc@murrayc.com>
875 * src/maemo/modest-account-settings-dialog.c:
876 * src/maemo/modest-connection-specific-smtp-edit-window.c:
877 Removed unnecessary includes.
879 2007-04-20 Murray Cumming <murrayc@murrayc.com>
881 * src/maemo/easysetup/modest-easysetup-wizard.c:
882 * src/maemo/modest-account-settings-dialog.c:
883 * src/maemo/modest-connection-specific-smtp-edit-window.c:
884 * src/widgets/Makefile.am:
885 * src/widgets/modest-easysetup-secureauth-combo-box.c:
886 * src/widgets/modest-easysetup-secureauth-combo-box.h:
887 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
888 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
889 * src/widgets/modest-secureauth-combo-box.c:
890 * src/widgets/modest-secureauth-combo-box.h:
891 * src/widgets/modest-serversecurity-combo-box.c:
892 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
893 made the GObject names more consistent with the rest of the Modest code.
895 2007-04-20 Murray Cumming <murrayc@murrayc.com>
897 * src/maemo/easysetup/Makefile.am:
898 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
899 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
900 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
901 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
902 * src/maemo/easysetup/modest-easysetup-wizard.c:
903 * src/maemo/easysetup/modest-validating-entry.c:
904 * src/maemo/easysetup/modest-validating-entry.h:
905 * src/maemo/modest-account-settings-dialog.c:
906 * src/maemo/modest-connection-specific-smtp-edit-window.c:
907 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
908 widgets/ because they are used outside of easysetup too. After checking in,
909 svn will allow me to rename them too.
911 2007-04-20 Murray Cumming <murrayc@murrayc.com>
913 * src/gnome/modest-msg-edit-window.c:
914 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
915 linker error, to fix the build on the GNOME platform.
916 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
917 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
918 ifdefed out to avoid a warning.
920 2007-04-20 Murray Cumming <murrayc@murrayc.com>
922 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
923 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
924 some alternative for GTK+ 2.6.
926 2007-04-19 Murray Cumming <murrayc@murrayc.com>
928 * src/maemo/modest-address-book.c: Added include to avoid a warning.
930 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
931 specified for EmailAccountsDialog in UI spec.
933 * src/maemo/easysetup/modest-easysetup-wizard.c:
934 * src/maemo/easysetup/modest-easysetup-wizard.h:
935 * src/maemo/modest-account-settings-dialog.c:
936 * src/maemo/modest-account-settings-dialog.h:
937 Reuse a member window widget for the connection-specific SMTP server accounts,
938 so we can tell it to create/save the accounts only if we actually save changes.
940 * src/maemo/modest-connection-specific-smtp-edit-window.h:
941 * src/maemo/modest-connection-specific-smtp-edit-window.c:
942 (modest_connection_specific_smtp_edit_window_get_settings):
943 Return a struct instance for temporarily remembering the entered data.
945 * src/maemo/modest-connection-specific-smtp-window.h:
946 * src/maemo/modest-connection-specific-smtp-window.c:
947 (modest_connection_specific_smtp_window_finalize),
948 (modest_connection_specific_smtp_window_fill_with_connections),
950 (modest_connection_specific_smtp_window_save_server_accounts),
951 (update_model_server_names): Do not actually save data until asked,
952 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
954 (on_selection_changed),
955 (modest_connection_specific_smtp_window_init): Disable the edit
956 button when nothing is selected.
958 * src/modest-account-mgr-helpers.c:
959 * src/modest-account-mgr-helpers.h:
960 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
963 2007-04-19 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-account-mgr-helpers.h:
966 * src/modest-account-mgr-helpers.c:
967 (modest_account_mgr_get_unused_account_name),
968 (modest_account_mgr_get_unused_account_display_name): Added these
969 utility functions, to avoid code duplication.
971 * src/maemo/easysetup/modest-easysetup-wizard.c:
972 (create_page_account_details), (create_account):
973 * src/maemo/modest-connection-specific-smtp-edit-window.c:
974 (on_combo_security_changed),
975 (modest_connection_specific_smtp_edit_window_init),
976 (modest_connection_specific_smtp_edit_window_save_settings):
977 * src/maemo/modest-connection-specific-smtp-edit-window.h:
978 * src/maemo/modest-connection-specific-smtp-window.c:
979 (modest_connection_specific_smtp_window_finalize),
980 (modest_connection_specific_smtp_window_fill_with_connections),
981 (on_button_edit), (modest_connection_specific_smtp_window_init):
982 * src/maemo/modest-connection-specific-smtp-window.h:
983 Implementing saving of connection-specific server accounts.
985 But I need to refactor this so we can save the data for each
986 possible connection-specific account and only actually create the server accounts
987 when the easysetup finished, or the OK button is pressed on the account settings
990 2007-04-18 Murray Cumming <murrayc@murrayc.com>
992 * src/maemo/modest-connection-specific-smtp-edit-window.c:
993 (on_combo_security_changed):
994 (modest_connection_specific_smtp_edit_window_init):
995 Auto-fill the port number as in the account settings.
997 (modest_connection_specific_smtp_edit_window_set_connection):
998 * src/maemo/modest-connection-specific-smtp-edit-window.h:
999 * src/maemo/modest-connection-specific-smtp-window.c:
1000 (fill_with_connections), (on_button_edit),
1001 (modest_connection_specific_smtp_window_init):
1002 Turn the edit window into a dialog to simplify the code, and
1003 set a WM hint as in a GtkDialog, because only a popup can be on top of
1004 another window in Maemo, and popups usually have no WM decoration.
1006 * src/modest-defs.h:
1007 * src/modest-account-mgr-helpers.c:
1008 (modest_account_mgr_set_connection_specific_smtp),
1009 (modest_account_mgr_remove_connection_specific_smtp),
1010 (modest_account_mgr_get_connection_specific_smtp):
1011 * src/modest-account-mgr-helpers.h: Some functions to write the
1012 connection-specific SMTP server information. Not yet used.
1015 * src/widgets/modest-folder-view.c: (text_cell_data):
1016 Fix a warning about an uninitialized variable.
1017 (on_configuration_key_changed): Put an #ifdef around the use
1018 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1020 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1022 * src/maemo/modest-account-settings-dialog.h:
1023 * src/maemo/modest-account-settings-dialog.c:
1024 Added connect_for_modified() utility function to mark the new modified boolean.
1026 (create_page_account_details), (create_page_user_details),
1027 (create_page_incoming), (create_page_outgoing), (on_response),
1028 (modest_account_settings_dialog_init),
1029 (modest_account_settings_dialog_set_account_name):
1030 Only warn about unsaved changes when there are actually unsaved changes.
1032 * src/modest-account-mgr-helpers.c:
1033 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1034 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1035 to get the data from there in future.
1037 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1039 * src/modest-defs.h:
1041 * src/modest-account-mgr-helpers.h:
1042 * src/modest-account-mgr-helpers.c:
1043 Store the security account setting in a single conf key instead of using
1044 the options list, so that the list is left for just the to-be-removed camel hack,
1045 and because gconf_client_set_list() is failing for some reason.
1047 * src/modest-account-mgr.c:
1048 (modest_account_mgr_add_server_account):
1049 * src/maemo/modest-account-settings-dialog.c:
1050 (modest_account_settings_dialog_set_account_name),
1051 (save_configuration): Use the renamed functions.
1054 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1056 * src/widgets/Makefile.am:
1057 * src/widgets/modest-limit-retrieve-combo-box.c:
1058 * src/widgets/modest-limit-retrieve-combo-box.h:
1059 * src/widgets/modest-retrieve-combo-box.c:
1060 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1061 the account settings dialog.
1063 * src/modest-defs.h:
1064 * src/modest-account-mgr-helpers.h:
1065 * src/modest-account-mgr-helpers.c:
1066 (modest_server_account_get_option_secure_auth),
1067 (modest_server_account_set_option_secure_auth):
1068 * src/modest-account-mgr.c:
1069 (modest_account_mgr_add_server_account):
1070 Use the existing AUTH_MECH conf key for the secure-auth setting,
1071 instead of putting it in the list options, because this was actually used already.
1073 * src/maemo/modest-account-settings-dialog.c:
1074 (create_page_account_details),
1075 (modest_account_settings_dialog_set_account_name),
1076 (save_configuration):
1077 * src/maemo/modest-account-settings-dialog.h:
1078 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1079 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1081 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1083 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1084 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1085 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1087 * src/modest-defs.h:
1088 * src/maemo/modest-account-settings-dialog.c:
1089 (create_page_incoming), (on_combo_outgoing_security_changed),
1090 (on_combo_incoming_security_changed), (create_page_outgoing),
1091 (modest_account_settings_dialog_set_account_name),
1092 (save_configuration): Load/Save the port number, and change it when the
1093 security combo changes, to suitable defaults.
1095 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1097 * src/modest-account-mgr.c:
1098 (modest_account_mgr_add_server_account): Set the security and secure-auth
1099 options, and add a comment saying that the other camel-specific options should be
1102 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1104 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1106 * src/modest-tny-account-store.c: (account_list_free),
1107 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1108 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1111 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1113 * src/modest-protocol-info.c:
1114 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1115 is required by our UI spec. Maybe something in our implementation will use this eventually.
1116 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1117 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1118 instead of the previous 0 placeholder.
1120 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1121 secure-auth settings.
1122 * src/modest-account-mgr-helpers.h:
1123 * src/modest-account-mgr-helpers.c:
1124 (modest_server_account_data_get_option_secure_auth),
1125 (modest_server_account_set_option_secure_auth),
1126 (modest_server_account_data_get_option_security),
1127 (modest_server_account_set_option_security): Added this API for getting and setting the security
1128 and secure-auth settings.
1130 * src/maemo/modest-account-settings-dialog.h:
1131 * src/maemo/modest-account-settings-dialog.c:
1132 (modest_account_settings_dialog_finalize), (check_data),
1133 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1134 about changing titles.
1135 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1136 (save_configuration): Save the security and secure-auth settings.
1138 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1139 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1141 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1143 * src/modest-defs.h:
1144 * src/modest-account-mgr.c:
1145 (modest_account_mgr_add_server_account):
1146 Added and used defines for the options key and value pair strings,
1147 that are used so far, though they do not seem to correspond to anything in our
1148 UI specs or ModestProtocol enum.
1150 * src/modest-account-mgr-helpers.h:
1151 * src/modest-account-mgr-helpers.c:
1152 (compare_option_strings_for_name),
1153 (modest_server_account_data_get_option_value),
1154 (modest_server_account_data_get_option_bool),
1155 (modest_account_mgr_get_server_account_option):
1156 Added helper functions for parsing the options GSList.
1158 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1160 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1161 display name is based on the supplied account name.
1162 * src/modest-account-mgr.c:
1163 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1164 with an inefficient, but good-enough, implementation.
1166 * src/maemo/easysetup/modest-easysetup-wizard.c:
1167 (create_page_account_details), (on_before_next), (create_account):
1168 Check for existing display names rather than (non-user-visible) account names, and just
1169 create and set a unique account name at the end.
1171 * src/maemo/modest-account-settings-dialog.c:
1172 (modest_account_settings_dialog_init),
1173 (modest_account_settings_dialog_set_account_name),
1174 (create_page_incoming): Show the display name, instead of the account name.
1175 (on_response): Do some (not all) extra checks, as in the UI spec.
1176 (save_configuration): Save the display name if it was changed.
1178 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1180 * po/en_GB.po: Added needed logical ID and translation.
1181 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1182 (init_view): Made the is-default column clicking work.
1184 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1187 * src/maemo/easysetup/Makefile.am:
1188 * src/maemo/easysetup/modest-easysetup-wizard.c:
1189 (modest_easysetup_wizard_dialog_init):
1190 * src/maemo/easysetup/provider-data-test.keyfile:
1191 * src/maemo/easysetup/provider-data.keyfile:
1192 Moved the provider data file to the new modest-providers-data package and used it from there.
1194 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-local-folder-info.c:
1197 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1198 N_() was already used on the static strings, but this just marks it for translation without
1199 using the translation.
1201 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/modest-account-settings-dialog.c:
1204 (create_page_incoming),
1205 (modest_account_settings_dialog_set_account_name):
1206 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1207 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1208 I will do this if nobody else gets there first.
1210 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1213 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1214 save the security stuff.
1216 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1218 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1219 Set the email address and user fullname, which I now see must be
1222 * src/maemo/modest-account-settings-dialog.h:
1223 * src/maemo/modest-account-settings-dialog.c:
1225 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1226 leave-on-server and authentication.
1227 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1230 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/modest-account-settings-dialog.c:
1234 * src/maemo/modest-account-settings-dialog.h:
1235 Most (but not all) of the widgets are now present as specified by the UI spec.
1236 No changes are yet saved, and some details are not properly shown yet.
1238 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1240 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1242 * src/maemo/Makefile.am:
1243 * src/maemo/modest-account-settings-dialog.c:
1244 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1245 an existing account. Doesn't do much yet.
1247 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1248 Open the accounts settings dialog when Edit is clicked.
1250 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1252 * src/maemo/easysetup/Makefile.am:
1253 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1255 * src/maemo/easysetup/modest-easysetup-wizard.c:
1256 (modest_easysetup_wizard_dialog_init):
1257 Try to get the source directory from the build system,
1258 instead of hard-coding "./" into the source code, when opening our local
1259 copies of the configuration files.
1260 But this still fails when opening the wizard from the Accounts window,
1261 maybe because the working directory seems to change at runtime.
1262 So the wizard will fail the second time unless you copy the files into their
1263 proper locations - see the stdout warnings for the paths.
1265 (create_page_account_details),(on_before_next):
1266 Check for existing non-server accounts instead of server accounts,
1267 so the default account name is useful again, and to prevent trying to
1270 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1271 Show the wizard when New is clicked.
1273 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1274 (init_view): Show the column headers, and show the columns that are
1275 specified in the UI specs. However, something in Maemo's GTK+ prevents
1276 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1277 change the default account. This is despite unsetting the special properties.
1279 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1281 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1282 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1283 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1284 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1285 to make that clearer.
1286 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1288 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1290 * src/maemo/modest-account-view-window.c:
1291 (modest_account_view_window_init),
1292 (modest_account_view_window_new):
1293 Use the same buttons as specified in the
1294 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1295 the existing widgets, which never had a chance of working.
1296 Put the ModestAccountView treeview in a scrolled window.
1297 Do not repeat the initialization in both _init() and _new().
1299 * src/widgets/modest-account-view.c: (update_account_view):
1300 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1301 this widget and window shows no accounts.
1303 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1305 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1307 * src/maemo/easysetup/modest-easysetup-wizard.c:
1308 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1309 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1310 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1313 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1314 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1315 accounts exist yet, as in the UI spec.
1317 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1319 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1321 * src/maemo/Makefile.am:
1322 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1323 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1324 New window for editing connection-specific smtp details.
1325 Not fully implemented.
1327 * src/maemo/modest-connection-specific-smtp-window.c:
1328 (modest_connection_specific_smtp_window_finalize) :
1329 unref the tree model.
1330 (on_button_edit): Show the edit window.
1332 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1334 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1337 * src/maemo/Makefile.am:
1338 * src/maemo/modest-connection-specific-smtp-window.c:
1339 * src/maemo/modest-connection-specific-smtp-window.h:
1340 New window for showing the list of connections, for connection-specific
1341 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1342 * src/maemo/easysetup/modest-easysetup-wizard.c:
1343 (create_page_custom_outgoing): Show the new window when the button is clicked.
1345 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1347 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1348 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1349 * src/maemo/modest-msg-edit-window.c:
1350 (modest_msg_edit_window_insert_image):
1351 * src/modest-conf.c: (modest_conf_key_escape):
1352 * src/modest-mail-operation.c:
1353 (modest_mail_operation_send_new_mail):
1354 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1355 (modest_ui_actions_on_new_account):
1356 * src/widgets/modest-attachment-view.c: (update_filename_request):
1357 * src/widgets/modest-mail-header-view.c:
1358 Corrected warnings that were breaking the build, by commenting out unused variables,
1359 and a function, and by including a header.
1361 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1363 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1364 so we can #ifdef around platform-specific code when necessary.
1365 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1366 to allow this to build for the GNOME platform too.
1368 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/easysetup/modest-easysetup-wizard.c:
1371 Added util_increment_name() and used it in create_page_account_details()
1372 to make sure that the default account name is always a new name.
1374 (modest_easysetup_wizard_dialog_init),
1375 (set_default_custom_servernames): Some minor memory management fixes.
1377 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1381 * src/modest-runtime.c: (init_i18n): Restored the translation
1382 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1383 are defined in config.h, and the translations are installed.
1385 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1386 is defined for translation.
1388 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1390 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1392 * src/maemo/easysetup/modest-easysetup-wizard.c:
1393 (modest_easysetup_wizard_dialog_init):
1394 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1395 Use realistic paths (though they should use $prefix generically) to the
1396 mcc_mapping and provider-data.keyfile files which might work when they
1397 are installed by the future version of the operator-wizard package,
1398 and then fallback to paths in our source code, with an explanatory
1401 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1405 * src/maemo/Makefile.am:
1406 * src/maemo/easysetup/: Added files from the previously-exernal
1407 osso-modest-easysetup.
1408 * src/maemo/modest-main-window-ui.h:
1409 * src/modest-ui-actions.c:
1410 * src/modest-ui-actions.h:
1411 Added modest_ui_actions_on_new_account() as a signal handler for the
1412 New Account menu item. It shows the easysetup wizard.
1413 * po/en_GB.po: Added additional needed logical IDs and translations.
1415 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1416 Apparently ChangeLog is not used for some vague Nokia legal reasons.