1 2007-07-27 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-utils.c:
4 (modest_maemo_utils_get_supported_secure_authentication_methods):
5 Make sure that we have a connection, asking the user for one
7 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
8 Check for a connection before showing the wizard, because
9 the wizard needs a connection to check for server capabilities.
11 2007-07-27 Murray Cumming <murrayc@murrayc.com>
13 * src/maemo/modest-account-view-window.c:
14 (on_new_button_clicked): Remember the wizard dialog instance,
15 so we can just present it again if necessary. This prevents
16 multiple windows from appearing if you click again quickly on the
17 New button before the dialog appears, fixing projects.maemo.org
20 2007-07-27 Murray Cumming <murrayc@murrayc.com>
22 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
23 Offer a connection dialog if there is no connection when
24 starting modest. This should fix projects.maemo.org bug NB#61134.
26 2007-07-27 Murray Cumming <murrayc@murrayc.com>
28 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
29 Reverted my last commit. I was able to fix the build by doing
30 apt-get install wpeditor0 (replacing other wpeditor packages) and
31 an explicit apt-get install wpeditor-dev to upgrade the -dev
34 2007-07-27 Murray Cumming <murrayc@murrayc.com>
36 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
37 Commented out the use of wp_text_buffer_replace_image()
38 because it does not exist, to break the build. Added a TODO for it.
40 2007-07-26 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-tny-account-store.c: (recreate_all_accounts):
43 Recreate them even if they were NULL before. I guess something
44 else was already creating them before, or this would never
46 (modest_tny_account_store_get_server_account): Make sure that
47 the tny accounts have been created before trying to find one.
48 This allows libmodest_dbus_client_compose_mail() to work
49 when the UI is not yet visible.
50 This is probably useful in other cases too.
52 (get_password): When the password is wrong after it is entered
53 in the protected password dialog, show an info banner (in an
54 idle handler) before showing the protected password dialog
57 2007-07-26 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-ui-actions.h:
60 * src/modest-ui-actions.c: Added
61 modest_do_refresh_current_folder() containing some code from
62 modest_ui_actions_on_send_receive().
63 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
64 Call modest_do_refresh_current_folder() before refreshing the
65 requested account, as in modest_ui_actions_on_send_receive().
66 This is strange, but seems to be necessary to show new mails.
67 Now new emails are finally visible in the UI when downloaded
68 via the automatic update interval, fixing bug NB#57458.
69 This also works because bug NB#57458 has been fixed somehow.
71 2007-07-26 Murray Cumming <murrayc@murrayc.com>
73 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
74 printf more details when we get unhandled D-Bus methods, because
77 * src/modest-mail-operation.c: (update_account_thread):
78 Comment out the tny_camel_pop_store_account_reconnect(), because this
79 is apparently no longer needed, and it did not work before anyway.
80 See the comment in the code.
82 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
83 by checking the header flags. This fixes projects.maemo.org bug
86 2007-07-25 Murray Cumming <murrayc@murrayc.com>
88 * src/maemo/modest-maemo-utils.h:
89 * src/maemo/modest-maemo-utils.c: Added
90 modest_maemo_show_information_note_in_main_context_and_forget().
91 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
92 Use the new function to show simple error dialogs in the main
93 context, though question dialogs are still in the current context,
94 which is unfortunately usually not the main context. This should
97 2007-07-25 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-tny-account-store.c: (get_password):
100 Never save the entered username and password in gconf,
101 because the UI spec says we should not. This helps
102 slightly with projects.maemo.org bug NB#63671.
104 2007-07-25 Murray Cumming <murrayc@murrayc.com>
106 * src/widgets/modest-msg-edit-window.h:
107 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
108 Moved some code here to make it simpler.
109 (modest_msg_edit_window_attach_file_one): Renamed from
110 modest_msg_edit_window_attach_file_interactive().
111 (modest_msg_edit_window_offer_attach_file): Renamed from
112 modest_msg_edit_window_attach_file() and used
113 modest_msg_edit_window_attach_file_one() instead of
114 copy/pasting the code. The old code for one was not using
115 GnomeVFS. This allows use of smb:// URLs when using send-as
116 from external applications, fixing bug NB#63741.
118 (modest_msg_edit_window_insert_image),
119 (modest_msg_edit_window_add_attachment_clicked):
120 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
121 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
122 Adapted to the new function names.
124 2007-07-25 Murray Cumming <murrayc@murrayc.com>
126 (modest_platform_set_update_interval): Set the alarm recurrence
127 fields so that auto-update does not just happen the first time.
128 This should have fixed projects.maemo.org bug NB#63938.
130 When this happens you can see a printf when the D-Bus method is
132 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
134 However, I do not actually seem to get new POP messages even when
135 clicking the refresh button manually. A restart gets them.
136 This might be a problem in today's tinymail only.
138 2007-07-24 Murray Cumming <murrayc@murrayc.com>
140 * src/maemo/modest-maemo-global-settings-dialog.c:
141 (current_connection):
142 Avoid a crash (probably only in scratchbox) when strcmp()ing a
143 NULL when closing the dialog.
145 2007-07-24 Murray Cumming <murrayc@murrayc.com>
147 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
148 Remove the hacky send/receive that didn't work, and instead
149 refilter the treemodel to make the deleted email really vanish from
150 the UI (though the delete-from-menu code does has commented out
151 the code that does that). This fixes projects.maemo.org bug
154 2007-07-24 Murray Cumming <murrayc@murrayc.com>
156 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
157 Try a couple of tricks to force the treeview to update (
158 poke the folder, and do a send/receive refresh), but the deleted
159 email still appears with a strike-through instead of really being
162 2007-07-23 Murray Cumming <murrayc@murrayc.com>
164 * src/dbus_api/modest-dbus-callbacks.c:
165 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
166 because their ID is not human-readable (see the comment about
167 improvements needed to the osso-email-interface API) and
168 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
170 2007-07-23 Murray Cumming <murrayc@murrayc.com>
172 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
173 (add_folders_to_list), (on_dbus_method_get_folders),
174 (modest_dbus_req_filter):
175 * src/maemo/modest-maemo-utils.c:
176 (on_camel_account_get_supported_secure_authentication):
177 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
178 (on_header_view_focus_in):
179 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
180 * src/modest-formatter.c: (modest_formatter_create_body_part):
181 * src/modest-mail-operation.c: (recurse_folders),
182 (update_account_thread), (get_msgs_full_thread),
183 (modest_mail_operation_get_msgs_full),
184 (modest_mail_operation_xfer_msgs):
185 * src/modest-search.c: (search_mime_part_and_child_parts),
186 (modest_search_account), (modest_search_all_accounts):
187 * src/modest-tny-account.c:
188 (modest_tny_account_get_special_folder), (recurse_folders):
189 * src/modest-tny-local-folders-account.c:
190 (modest_tny_local_folders_account_query_passes):
191 * src/modest-tny-msg.c: (copy_mime_part),
192 (modest_tny_msg_find_body_part_from_mime_part):
193 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
194 (modest_tny_send_queue_try_to_send):
195 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
196 (_modest_ui_actions_open), (download_uncached_messages),
197 (reply_forward), (modest_ui_actions_on_copy),
198 (modest_ui_actions_on_details), (has_retrieved_msgs),
199 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
201 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
202 (_selected_msg_marked_as), (_msg_download_completed),
203 (_selected_msg_sent_in_progress):
204 * src/widgets/modest-attachments-view.c:
205 (modest_attachments_view_set_message):
206 * src/widgets/modest-msg-view.c: (find_cid_image):
207 * tests/check_folder-transfer.c: (find_folders):
208 * tests/check_update-account.c: (func):
209 * tests/dbus_api/test_get_folders.c: (main):
210 Checked all uses of tny_iterator_get_current(), making sure
211 that the object is unreferenced (3 or 4 places did not),
212 and adding checks for NULL.
214 2007-07-23 Murray Cumming <murrayc@murrayc.com>
216 * src/dbus_api/modest-dbus-callbacks.c:
217 (on_idle_open_default_inbox): Make sure that the application UI is
219 * src/maemo/easysetup/modest-easysetup-wizard.c:
220 (on_entry_invalid_character): Show the word whitespace instead
221 of (null) in the banner when whitespace was entered.
222 (show_error): Add a comment that this does not work in
223 Maemo Bora, though we do not know why.
225 2007-07-23 Murray Cumming <murrayc@murrayc.com>
227 * src/modest-tny-account.c:
228 (modest_tny_account_get_special_folder): Use an if instead of
229 an assert for when the parent account name is NULL, because this
230 might be causing a crash in projects.maemo.org bug 63192.
231 * src/modest-mail-operation.c:
232 (modest_mail_operation_send_new_mail_cb),
233 (modest_mail_operation_remove_folder): unref the folder that is
234 returned from modest_tny_account_get_special_folder().
236 2007-07-23 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-ui-actions.c:
239 (modest_ui_actions_on_password_requested):
240 Show mail_ib_login_cancelled info banner when the user cancels
241 the protected password dialog, to fix projects.maemo.org
244 2007-07-23 Murray Cumming <murrayc@murrayc.com>
246 * src/maemo/modest-account-settings-dialog.c:
247 (create_page_outgoing): Put this page in a GtkScrolledWindow,
248 matching the UI mock-up in the UI spec, and allowing access
249 to all widgets even when the on-screen keyboard is active.
251 2007-07-23 Murray Cumming <murrayc@murrayc.com>
253 Reverted this previous commit from Johannes,
254 because the scrollbars are always visible and because
255 I think we only need it on onepage of the account
256 settings, not the account wizard.
257 (I wrote the wrong instructions in the bug.)
259 * src/maemo/easysetup/modest-easysetup-wizard.c:
260 Added scrollbars to account wizard dialog.
261 Fixed projects.maemo.org NB #62744
263 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
265 * src/maemo/easysetup/modest-easysetup-wizard.c:
266 (create_page_user_details):
267 Use auto-cap for name (projects.maemo.org NB#63716)
268 * src/widgets/modest-account-view.c: (on_account_busy_changed):
270 2007-07-22 Armin Burgmeier <armin@openismus.com>
272 * src/maemo/modest-ui-actions.c: Use current account instead of
273 default account for creating viewer windows, so that the viewer
274 window knows to which account the viewed message belongs.
276 * src/maemo/modest-msg-view-window.c: Destroy the window when the
277 corresponding account is deleted. This fixes projects.maemo.org bug
280 2007-07-18 Armin Burgmeier <armin@openismus.com>
282 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
283 the dialog close after entering an invalid port number and clicking
284 OK. This fixes projects.maemo.org bug NB#63602.
286 2007-07-18 Armin Burgmeier <armin@openismus.com>
288 * src/modest-tny-account-store.c:
289 (get_server_accounts): Set parent modest account name for each
290 connection-specific transport account so that special folders of such
291 an account can be looked up. This fixes a crash when changing account
292 settings. This might also be related to projects.maemo.org bug
295 2007-07-16 Armin Burgmeier <armin@openismus.com>
297 * src/modest-ui-actions.c: Added a button to create a folder to the
298 move-to dialog. This fixes projects.maemo.org bug NB#.
300 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
302 * src/maemo/easysetup/modest-easysetup-wizard.c:
303 Added scrollbars to account wizard dialog.
304 Fixed projects.maemo.org NB #62744
306 2007-07-16 Murray Cumming <murrayc@murrayc.com>
308 * src/widgets/modest-msg-view.h:
309 * src/widgets/modest-msg-view.c:
310 Added modest_msg_view_get_message_is_empty() but this needs
312 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
313 Check if there is any text in the message yet.
314 But this needs to be implemented properly.
315 (modest_msg_edit_window_toggle_find_toolbar):
316 * src/maemo/modest-msg-view-window.c:
317 (modest_msg_view_window_toggle_find_toolbar):
318 Show a banner warning if there is no text to search, when
319 trying to start a search. This partially fixes
320 projects.maemo.org bug NB#62350.
322 2007-07-13 Murray Cumming <murrayc@murrayc.com>
324 * src/modest-mail-operation.c: (update_account_thread):
325 Initialized num_new_headers to fix the build.
327 2007-07-13 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
330 Ignore modest accounts whose server accounts don't exist in gconf.
331 This prevents us trying to create TnyAccount instances for those
332 server accounts when the server account has been removed from gconf,
333 but the parent modest account has not yet been removed from modest.
334 I don't know why this is only noticeable now. It was probably just
335 a harmeless g_warning() anyway.
337 2007-07-13 Murray Cumming <murrayc@murrayc.com>
339 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
340 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
342 2007-07-12 Armin Burgmeier <armin@openismus.com>
344 * src/maemo/modest-main-window.c: Make default account appear bold
345 in view, tools/send & receive and toolbar/send & receive SCM menus.
346 This fixes projects.maemo.org bug NB#59010.
348 2007-07-12 Murray Cumming <murrayc@murrayc.com>
350 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
351 Add a short-cut, by checking if the folder store is an account.
352 This ensures that the Sort menu item and toolbar is dimmed for
353 the local-folders account root item, fixing
354 projects.maemo.org bug NB#62545.
356 2007-07-12 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-tny-account-store.c: (get_password):
359 Show the password dialog (via the signal) only in the mainloop, via
360 an idle handler that we wait for. This could theoretically prevent
361 hangs, though I worry that it could introduce some too.
363 2007-07-12 Murray Cumming <murrayc@murrayc.com>
365 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
366 * src/maemo/modest-platform.c:
367 (modest_platform_connect_and_wait):
368 Take a TnyAccount* parameter and try to set it to online
369 (a TnyCamel-only API), because tinymail sets accounts to offline
370 when the user cancels a password dialog, and doesn't ask again until
371 it has been set to online.
372 However, this is commented out because it causes a hang now.
374 (modest_platform_connect_and_wait_if_network_account):
375 * src/modest-mail-operation.c:
376 (modest_mail_operation_update_account):
377 * src/modest-platform.h:
378 * src/modest-ui-actions.c: (_modest_ui_actions_open),
379 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
381 2007-07-12 Armin Burgmeier <armin@openismus.com>
383 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
385 * src/modest-mail-operation.c:
386 * src/modest-ui-actions.c: Check for already existing folder before
387 querying the server, show error message from camel if the request
388 still fails. This fixes projects.maemo.org bug NB#58701.
390 2007-07-12 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-tny-account-store.h:
393 * src/modest-tny-account-store.c:
394 Added modest_tny_account_store_forget_password_in_memory(),
395 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
396 when creating a new account, so that new passwords will be used, instead of
397 us thinking that it's a second request as a result of a failed password again.
399 2007-07-12 Murray Cumming <murrayc@murrayc.com>
401 * src/dbus_api/modest-dbus-callbacks.c:
402 (on_idle_open_message): If the message is in drafts then open it
403 in an edit window instead of a view window. This fixes
404 projects.maemo.org bug NB#63005.
406 2007-07-12 Murray Cumming <murrayc@murrayc.com>
408 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
409 Avoided a harmless g_warning().
411 2007-07-12 Murray Cumming <murrayc@murrayc.com>
413 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
414 Pass the modest account name, not the TnyAccount display name to
415 modest_msg_view_window_new() so that the reply feature works,
416 fixing projects.maemo.org bug NB#62892.
418 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
419 (modest_msg_view_window_new_with_header_model):
420 * src/maemo/modest-msg-view-window.c:
421 (modest_msg_view_window_new_with_header_model),
422 (modest_msg_view_window_new):
423 * src/modest-ui-actions.c: (reply_forward):
424 * src/widgets/modest-msg-view-window.h:
425 * src/widgets/modest-window.c: (modest_window_set_active_account):
426 Rename an account parameter to modest_account_name to make this clearer.
428 2007-07-11 Murray Cumming <murrayc@murrayc.com>
430 * src/modest-ui-actions.h:
431 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
432 modest_do_message_delete().
433 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
434 Call modest_do_message_delete(), hoping that this would cause messages
435 to be really deleted from search instead of just marked with strike through.
436 Does not seem to help.
438 2007-07-11 Armin Burgmeier <armin@openismus.com>
440 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
441 priv->reselect to FALSE prior to calling
442 modest_folder_view_select_first_inbox_or_local() to prevent endless
443 recursion and thus a crash on startup.
445 2007-07-11 Armin Burgmeier <armin@openismus.com>
447 * src/maemo/modest-account-settings-dialog.h: Include
448 <gtk/gtknotebook.h> to fix the build (at least for me).
450 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
451 Use "New FolderN" as default suggested name if "New folder" already
452 exists, with N being the first free number, though never exceed "New
453 folder99" in which case we just fall back to "New Folder" even though
454 it already exists. This fixes projects.maemo.org bug NB#58663.
456 2007-07-11 Murray Cumming <murrayc@murrayc.com>
458 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
459 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
460 projects.maemo.org bug NB#62778.
462 2007-07-11 Murray Cumming <murrayc@murrayc.com>
464 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
465 Ignore the wrong (for now) secure-smtp setting in the presets -
466 just default to requiring secure authentication for SMTP, because
469 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
471 * src/widgets/modest-folder-view.c: (filter_row)
472 Do not show drafts folder (see UI specs)
474 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
476 * src/modest-ui-actions.c:
477 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
478 place and also not necessary.
480 * src/widgets/modest-folder-view.c: (filter_row)
481 Guess folder type and hide Sent & Outbox if necessary.
482 Fixed project.maemo.org NB#57328
484 2007-07-11 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-ui-actions.h:
487 * src/modest-ui-actions.c:
488 (modest_ui_actions_on_delete_message):
489 Move some code into a new
490 modest_ui_actions_refresh_message_window_after_delete()
491 function so we can use it from elsewhere.
493 * src/dbus_api/modest-dbus-callbacks.c:
494 (on_idle_delete_message), (on_delete_message): Used an idle
495 handler, as we do for the other D-Bus method handlers.
496 Call modest_ui_actions_refresh_message_window_after_delete()
497 if the deleted message was open in a window. This fixed
498 projects.maemo.org bug NB#62862.
500 2007-07-11 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-main.c: (main): Only show the UI at the start if
503 the showui command line option was given. For instance,
504 run-standalone src/modest showui
505 Otherwise, we wait for the top_application D-Bus method to
506 be sent by hildon-desktop when the application is selected
508 This allows us to run without a UI when osso-global-search
509 uses our D-Bus methods.
511 2007-07-11 Murray Cumming <murrayc@murrayc.com>
513 * src/dbus_api/modest-dbus-api.h: Added a define for a
514 top-application D-Bus method.
515 * src/dbus_api/modest-dbus-callbacks.c:
516 (on_top_application),
517 (modest_dbus_req_handler): Handle the top-application D-Bus
518 method, which might be an undocumented D-Bus signal sent by
519 hildon-desktop when it starts the application from the menu.
520 But I am not sure and I need to test it on the device, because
521 my scratchbox does not have the application in the menu now.
522 This method shows the main window, so that it can be invisible
523 when started, for instance, just for email searching from
526 * src/maemo/modest-main-window.c: (restore_settings),
527 (modest_main_window_new): Do not show the window immediately
528 upon creation. We show it later.
529 * src/modest-widget-memory.c: (save_settings_paned):
530 Try (unsuccessfully) to avoid saving the paned position when
531 it is not even visible.
532 (restore_settings_paned): Do not allow a silly paned position.
533 This seems necessary when not showing the window at first.
535 * tests/dbus_api/Makefile.am:
536 * tests/dbus_api/test_top_application.c: (main): Test for the
539 2007-07-10 Murray Cumming <murrayc@murrayc.com>
541 * src/modest-ui-dimming-rules.c:
542 (modest_ui_dimming_rules_on_new_msg),
543 (modest_ui_dimming_rules_on_reply_msg),
544 (modest_ui_dimming_rules_on_delete_msg),
545 (modest_ui_dimming_rules_on_details),
546 (modest_ui_dimming_rules_on_view_window_move_to),
547 (modest_ui_dimming_rules_on_view_previous),
548 (modest_ui_dimming_rules_on_view_next),
549 (_invalid_folder_for_purge): Added checks before
550 casting the window. This looks like an actual
551 logic error in _invalid_folder_for_purge(), because it
552 tries to use a ModestMainWindow as a message window.
554 2007-07-10 Murray Cumming <murrayc@murrayc.com>
556 * src/maemo/modest-account-settings-dialog.c:
557 (show_error): Use the same implementation as in
558 modest-easysetup-wizard.c:
559 (on_entry_invalid_character): The logical ID contains a %s.
560 Guessed what it should be.
561 (on_entry_max), (check_data), (on_response): Adapt to
562 changed show_error().
563 (create_page_account_details): Really call
564 modest_validating_entry_set_func() on the correct widgets.
565 * src/maemo/easysetup/modest-easysetup-wizard.c:
566 (on_entry_invalid_character): Fix the logical ID here too.
567 (create_page_account_details),
568 (create_page_user_details):
570 modest_validating_entry_set_func() on the correct widgets.
572 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
573 Do not try to use the account if it is NULL.
575 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
577 * src/modest-ui-actions.c: (create_move_to_dialog),
578 (modest_ui_actions_on_main_window_move_to),
579 (modest_ui_actions_on_msg_view_window_move_to):
580 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
581 (filter_row), (modest_folder_view_show_non_move_folders):
582 * src/widgets/modest-folder-view.h:
584 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
585 the Sent folder yet as it does not report the correct folder type.
587 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
589 * src/maemo/modest-msg-edit-window.c: (init_window):
592 2007-07-10 Murray Cumming <murrayc@murrayc.com>
594 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
595 Take a parent widget instead of a parent window, and
596 implement this with hildon_banner_show_information() instead.
597 Non-Maemo builds can just ifdef that there.
598 This fixed projects.maemo.org bug NB#62766.
600 (on_entry_invalid_character): Use show_error() again instead
601 of using hildon directly, and use the _CS() macro to use the correct
603 (create_account), (check_for_supported_auth_methods), (on_entry_max):
604 Pass a widget instead od a window to show_error().
606 2007-07-10 Murray Cumming <murrayc@murrayc.com>
608 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
609 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
610 This allows us to show the server name in the error message, fixing
611 projects.maemo.org bug NB#62904.
612 Also, use the appropriate logical ID message for the account protocol.
614 2007-07-10 Murray Cumming <murrayc@murrayc.com>
616 * src/modest-tny-account-store.c: (on_idle_wrong_password):
617 A compilation fix, though the build wasn't broken for me.
619 2007-07-09 Murray Cumming <murrayc@murrayc.com>
621 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
622 Do not try to unref a NULL folder store, to avoid a runtime warning.
623 This seems to happen sometimes when changing accounts settings.
625 2007-07-09 Murray Cumming <murrayc@murrayc.com>
627 * src/modest-tny-account-store.c:
628 (modest_tny_account_store_instance_init),
629 (modest_tny_account_store_finalize),
630 (on_account_settings_hide), (on_idle_wrong_password):
631 Use a GHashTable to ensure that we only show one account settings
632 dialog per modest account. This avoids us having a dialog open for
633 both the store and transport accounts, or due to repeated get_password()
634 calls that shouldn't happen anyway.
636 2007-07-09 Murray Cumming <murrayc@murrayc.com>
638 * src/maemo/modest-maemo-utils.c: (on_hide),
639 (modest_maemo_show_dialog_and_forget): Handle the response, because
640 the window is not even hidden by default.
642 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
643 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
644 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
645 which seems to prevent some modality problems.
647 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
648 Ignore user cancellation errors.
650 * src/modest-account-mgr-helpers.h:
651 * src/modest-account-mgr-helpers.c:
652 Added modest_server_account_get_password() and
653 modest_server_account_get_has_password() to avoid direct use of
656 * src/maemo/modest-account-settings-dialog.h:
657 * src/maemo/modest-account-settings-dialog.c:
658 (modest_account_settings_dialog_init): Store the notebook so we can
660 Added modest_account_settings_dialog_switch_to_user_info().
662 * src/modest-tny-account-store.c:
663 (get_password): When the password in the account settings is wrong (we think),
664 show the relevant page of the account settings dialog, in the mainloop.
665 However, we currently get many of these at once because cancel does not
667 (forget_password): Do not forget the password
668 from the account settings, because this causes side-effects when
669 tinymail seems to call it at strange time, maybe because of how we
670 are cancelling get_password().
671 (modest_tny_account_store_alert): Ignore user cancellations.
673 2007-07-09 Murray Cumming <murrayc@murrayc.com>
675 * src/maemo/modest-maemo-utils.h:
676 * src/maemo/modest-maemo-utils.c:
677 Added modest_maemo_show_information_note_and_forget() for use instead of
678 gtk_dialog_run() when the response is not needed, to avoid an extra
679 mainloop which could cause a hang.
681 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
682 Use the logical IDs for the error message, though they are not
683 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
684 because gtk_dialog_run() caused a hang here (the window did not close).
685 This fixes projects.maemo.org bug NB#62646.
687 2007-07-09 Murray Cumming <murrayc@murrayc.com>
689 * src/modest-account-mgr-helpers.h:
690 * src/modest-account-mgr-helpers.c:
691 Added modest_account_mgr_get_store_protocol().
693 * src/maemo/modest-account-view-window.c:
694 (on_delete_button_clicked): Show different warning text depending on
695 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
696 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
699 2007-07-09 Murray Cumming <murrayc@murrayc.com>
701 * src/maemo/modest-msg-edit-window.c:
702 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
703 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
705 2007-07-07 Armin Burgmeier <armin@openismus.com>
707 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
708 ckdg_ib_maximum_characters_reached from correct package.
710 * src/modest-ui-actions.c: Show an error message when a folder could
711 not be created. Tinymail does not give us specific error codes about
712 what has gone wrong, so we assume that a folder with that name
713 already exists, though there might be other reasons.
715 2007-07-06 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
718 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
719 give a more exact error message that can be partly translated.
721 2007-07-05 Murray Cumming <murrayc@murrayc.com>
723 * src/maemo/modest-address-book.c:
724 (select_email_addrs_for_contact): Specify a default window size for the
725 select-email-address dialog, so that it is probably big enough for the
726 title. This should fix projects.maemo.org bug NB#62277.
728 2007-07-05 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/easysetup/modest-easysetup-wizard.c:
731 (create_page_complete_easysetup): Use
732 gtk_widget_set_size() request to ensure that the text wraps
735 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
737 * src/maemo/easysetup/modest-easysetup-wizard.c:
738 (on_entry_invalid_character), (create_page_account_details),
739 (create_page_user_details):
740 Use new API of ModestValidatingEntry. But for some reason the banner is
741 not shown. I will have to investigate that further.
743 * src/widgets/modest-validating-entry.c: (on_insert_text),
744 (modest_validating_entry_set_func):
745 * src/widgets/modest-validating-entry.h:
746 Added a new callback function to be able to react to prevented
747 characters whitespaces to e.g show a banner.
749 2007-07-05 Armin Burgmeier <armin@openismus.com>
751 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
752 notification of HildonNumberEditor instead of remembering the port
753 number. Thanks to Johannes for pointing this out.
755 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
757 * src/maemo/easysetup/modest-easysetup-wizard.c:
758 Check if there are any user changes before showing a confirmation
759 dialog (projects.maemo.org NB#60946)
761 2007-07-05 Armin Burgmeier <armin@openismus.com>
763 * src/maemo/modest-account-settings-dialog.c: Remember custom port
764 number at the beginning of the dialog and set the modified flag at the
765 end if the port number has changed. This is necessary because
766 HildonNumberEditor does not support notification when the value has
769 2007-07-05 Murray Cumming <murrayc@murrayc.com>
771 * src/modest-ui-actions.c:
772 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
773 a connection before asking anything else. Correct the check for the destination
774 folder so that it succeeds when online.
775 This fixed projects.maemo.org bug NB#61645.
777 2007-07-05 Murray Cumming <murrayc@murrayc.com>
779 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
780 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
781 to fix projects.maemo.org bug NB#62439.
783 2007-07-05 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-tny-account.c: (on_connection_status_changed):
786 Really do not use tny_device_force_offline() here. See the previous comment.
788 2007-07-04 Murray Cumming <murrayc@murrayc.com>
790 * src/modest-tny-account.c: (on_connection_status_changed):
791 Do not use tny_device_force_offline() when tinymail says that something
792 went wrong with the connection. It seems to report this unnecessarily.
794 2007-07-04 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/modest-connection-specific-smtp-window.c:
797 (modest_connection_specific_smtp_window_init):
798 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
799 does not seem to have any effect in osso 1.1 (though it works in
800 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
802 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
804 * src/maemo/modest-connection-specific-smtp-window.c:
805 Fix UI specification problems with projects.meamo.org NB#60479
807 2007-07-04 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
810 clue when this has failed, because the error dialog is not always shown
811 (at least in earlier version).
813 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
814 GError message, because the generic error dialog is not helpful.
816 'This message is not currently available (can't let a new connection go online)'
817 when trying to open an IMAP message.
819 (_modest_ui_actions_open): Offer a connection when some messages would
820 have to be downloaded and we are offline.
822 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
824 * src/widgets/modest-folder-view.c:
825 Don't check for MERGE type anymore as we use the correct type
827 NOTE: For the last two changes you need to update your tinymail copy
828 because of API changes!
830 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
832 * src/modest-tny-local-folders-account.c:
833 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
834 (see projects.maemo.org NB#61580)
836 2007-07-04 Murray Cumming <murrayc@murrayc.com>
838 * src/modest-tny-account.c: (on_connection_status_changed):
839 Commented out the call to modest_platform_connect_and_wait() because this
840 seems to always hang, and I would like to know if this is the only thing
841 that causes a hang when showing the connection dialog.
842 It is not very useful anyway.
844 2007-07-04 Murray Cumming <murrayc@murrayc.com>
846 * src/maemo/modest-msg-view-window.c:
847 (modest_msg_view_window_select_next_message):
849 * src/modest-platform.h:
850 * src/maemo/modest-platform.c:
851 Added modest_platform_connect_and_wait(), which calls
852 tny_maemo_conic_device_connect() always in the main thread, by calling it
853 in an idle handler and waiting for the idle handler to run. It should be
854 in the main thread because it uses GTK+ UI code. It just returns TRUE
855 if the device is already online.
857 There is some nasty code to ensure that subsequent calls to
858 modest_platform_connect_and_wait() just wait for the first one to finish,
859 by checking repeatedly in another idle handler. This is necessary,
860 because other threads (or even the main thread, via another idle handler)
861 can call modest_platform_connect_and_wait() while
862 modest_platform_connect_and_wait() is running.
864 (modest_platform_connect_and_wait_if_network_account),
865 (modest_platform_connect_and_wait_if_network_folderstore):
866 Convenience functions that calls modest_platform_connect_and_wait() if
867 the account or folder might want network access.
869 * src/modest-mail-operation.c:
870 (modest_mail_operation_update_account):
871 * src/modest-ui-actions.c: (download_uncached_messages),
872 (modest_ui_actions_on_rename_folder), (delete_folder),
873 (modest_ui_actions_on_main_window_move_to),
874 (modest_ui_actions_on_msg_view_window_move_to):
875 * src/widgets/modest-folder-view.c:
876 (drag_and_drop_from_folder_view):
877 Offer a connection if we are offline.
879 * src/modest-tny-account.c: (on_connection_status_changed):
880 Document this as only handling errors during network operations in progress,
881 and replace the idle code with a simple call to
882 modest_platform_connect_and_wait(), which does this instead.
884 2007-07-03 Murray Cumming <murrayc@murrayc.com>
886 * src/modest-tny-account.c:
887 (modest_tny_account_get_special_folder): (util_on_idle),
888 Handle the GError so we can see when tny_folder_store_get_folders()
889 fails, as it currently does while something else is connecting.
891 Added util_run_in_main_thread_and_wait()
892 which uses an idlen handler and mainloop to ensure that the function
893 is called in the main thread.
894 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
895 to make sure that we call attempt the connection in the mainloop only,
896 which might solve some hangs.
898 2007-07-03 Murray Cumming <murrayc@murrayc.com>
900 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
901 be found by their display name. This is never useful.
902 * src/modest-tny-account-store.c: (on_account_removed): Find the account
903 by its ID, instead of trying to use its ID as its display name.
905 * src/modest-tny-account-store.h:
906 * src/modest-tny-account.c:
907 (modest_tny_account_get_special_folder): Add a g_warning() when
908 tny_folder_store_get_folders() returns an empty list for the maildir.
910 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
911 Add a g_warning() when this returns NULL, because that it not allowed
914 2007-07-02 Armin Burgmeier <armin@openismus.com>
916 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
917 note when trying to cancel the wizard. This fixes projects.maemo.org
920 2007-07-02 Murray Cumming <murrayc@murrayc.com>
922 * src/modest-tny-account.h:
923 * src/modest-tny-account.c:
924 (modest_tny_account_new_from_server_account),
925 (modest_tny_account_new_from_server_account_name),
926 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
927 because this must now be set before setting the proto. This is usd in
928 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
929 warning in camel_session_get_service() caused by
930 tny_camel_transport_account_prepare().
932 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
935 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
937 * src/maemo/modest-connection-specific-smtp-edit-window.c:
939 (modest_connection_specific_smtp_edit_window_init):
941 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
944 2007-06-29 Murray Cumming <murrayc@murrayc.com>
946 * src/modest-tny-account.c:
947 (modest_tny_account_new_from_server_account):
948 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
949 now uses to request a connection when it needs one, and which it uses
950 to tell us that something is wrong with the connection, so we can force
951 the accounts offline to prevent further problems.
954 * src/modest-init.c: (init_default_settings):
955 * src/modest-mail-operation.c:
956 (modest_mail_operation_update_account):
957 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
958 This should not be necessary anymore. Do not set the conf key that
959 determined this (it was always TRUE and not set anywhere else).
961 * src/modest-ui-actions.h: Remove unused and unimplemented
962 modest_ui_actions_on_online_toggle_toggled().
964 2007-06-29 Murray Cumming <murrayc@murrayc.com
966 * src/maemo/modest-main-window.c: (connect_signals):
967 Don't connect to delete_event twice. Maybe this was harmless.
969 2007-06-29 Murray Cumming <murrayc@murrayc.com
971 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
972 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
973 Debug output to give some more clue when a folder move is not allowed.
975 2007-06-28 Murray Cumming <murrayc@murrayc.com
977 * src/modest-tny-account.c: (on_modest_file_system_info),
978 (modest_tny_account_get_mmc_account_name):
979 Always call the callback, without checking whether the name has changed.
980 * src/widgets/modest-folder-view.c: (strings_are_equal),
981 (on_model_foreach_set_name), (on_get_mmc_account_name),
982 (text_cell_data): Compare the name here, and use the name from
983 the account rather than from the
984 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
985 if the name was changed after the account was added to the model.
986 That's a tinymail bug but not one that I want to fix now.
988 This finally fixes projects.maemo.org bug NB#59301.
990 2007-06-27 Armin Burgmeier <armin@openismus.com>
992 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
995 2007-06-27 Murray Cumming <murrayc@murrayc.com
997 * src/modest-tny-account.h:
998 * src/modest-tny-account.c:
999 Added modest_tny_account_get_mmc_account_name(), to set the memory
1000 card name asynchronously for the given account and then notify.
1001 (modest_tny_account_new_for_local_folders): Use this new function instead
1002 of using hildon_file_system_info_async_new() directly.
1004 * src/widgets/modest-folder-view.c: (text_cell_data):
1005 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1006 gtk_tree_model_row_changed() when it is available.
1008 This should fix projects.maemo.org bug NB#59301.
1010 2007-06-27 Murray Cumming <murrayc@murrayc.com
1012 * src/modest-mail-operation.c: (update_account_thread),
1013 (get_msgs_full_thread): Fix typo failures in the revert
1016 2007-06-27 Murray Cumming <murrayc@murrayc.com
1018 * src/maemo/modest-maemo-global-settings-dialog.c:
1019 (idle_select_default_focus):
1020 * src/modest-mail-operation.c: (idle_notify_progress),
1021 (idle_notify_progress_once), (set_last_updated_idle),
1022 (update_account_thread), (get_msgs_full_thread):
1023 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1024 * src/widgets/modest-header-view.c:
1025 (idle_notify_headers_count_changed_destroy),
1026 (idle_notify_headers_count_changed):
1027 Reverted the additions of gdk_threads_enter/leave(), in case this
1028 helps with a startup hang on the device.
1030 2007-06-26 Armin Burgmeier <armin@openismus.com>
1032 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1033 for supported secure authentication methods from server by
1034 gtk_dialog_run(), saving CPU time and a potential race condition.
1036 2007-06-26 Armin Burgmeier <armin@openismus.com>
1038 * src/maemo/modest-maemo-utils.h:
1039 * src/maemo/modest-maemo-utils.c: Added a
1040 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1041 only error code to tell the calling code when the user canceled the
1044 * src/maemo/modest-account-settings-dialog.h:
1045 * src/maemo/modest-account-settings-dialog.c:
1046 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1047 message if the retrieval of secure authentication methods was canceled
1048 by the user. Perform the check before saving anything to configuration
1049 to not end up with half-committed configuration changes, do not show
1050 a "Saving to configuration failed" note when authentication methods
1051 could not be retrieved.
1053 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1056 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1058 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1059 Only return the first level of folders under accounts, because the
1060 osso-global-search UI spec doesn't want the rest.
1061 This fixed projects.maemo.org bug NB#61811.
1063 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-tny-account-store.c:
1066 * src/modest-tny-account-store.h:
1067 Added modest_tny_account_is_memory_card_account().
1068 * src/maemo/modest-main-window.c: (create_details_widget):
1069 Show the same information items for the memory card as we show for the
1070 local-folders, to fix projects.maemo.org bug NB#59307.
1072 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1074 * src/modest-tny-account-store.c: (get_password):
1075 Added some checks for NULL to maybe prevent crashes, though I think
1076 it was Philip's last commit that actually prevented the crash here
1077 when creating a first new account.
1078 But the new account is still not usable (no messages are shown)
1079 until a restart of the application.
1081 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1083 * src/maemo/modest-maemo-global-settings-dialog.c:
1084 (idle_select_default_focus):
1085 * src/modest-mail-operation.c: (idle_notify_progress),
1086 (idle_notify_progress_once), (idle_notify_update_account_queue),
1087 (set_last_updated_idle), (update_account_thread),
1088 (notify_get_msgs_full), (get_msgs_full_destroyer),
1089 (get_msgs_full_thread):
1090 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1091 * src/widgets/modest-header-view.c:
1092 (idle_notify_headers_count_changed_destroy),
1093 (idle_notify_headers_count_changed):
1094 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1095 all idle handlers, because some other thread could be blocking
1096 the GDK lock, so that it can do GUI stuff.
1098 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1100 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1101 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1102 (on_idle_send_receive), (on_idle_open_default_inbox):
1103 * src/maemo/modest-msg-edit-window.c:
1104 (modest_msg_edit_window_attach_file_noninteractive):
1105 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1106 to prevent a hang. I don't quite understand why these are necessary,
1107 beause we should already be in the main loop. I guess something outside
1108 of the main loop is taking the lock.
1110 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1111 we are really using URIs, and use files that are more likely to exist.
1113 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1115 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1116 necessary because configure.ac now defines different variables.
1118 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1120 * libmodest-dbus-client/libmodest-dbus-client.c:
1121 * libmodest-dbus-client/libmodest-dbus-client.h:
1122 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1123 libmodest_dbus_client_compose_mail() is what things actually use.
1125 * src/dbus_api/modest-dbus-api.h:
1126 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1127 * tests/dbus_api/Makefile.am:
1128 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1131 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1133 * src/modest-init.c: (modest_init_local_folders):
1134 For memory-card (or other non local-folders) maildir accounts,
1135 always create an Archive folder, so that there is somewhere to put
1136 messages. This should be less confusing, because the user does not need
1137 to guess that the need to create a folder.
1139 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1141 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1142 Fixed icon size by using (50, 50) which is the same as defined by
1145 2007-06-25 Armin Burgmeier <armin@openismus.com>
1147 * src/widgets/modest-window-mgr.c:
1148 * src/modest-init.c:
1149 * configure.ac: Correctly recognize hildon-notify presence and fixed
1150 the build without it being installed.
1152 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1154 * libmodest-dbus-client/libmodest-dbus-client.c:
1155 (libmodest_dbus_client_search): Fix the build. Sorry.
1156 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1157 (reply_forward_cb): Initialize variables to fix the build.
1159 * src/modest-tny-account-store.c:
1160 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1161 comparison (a silly typo) so that email search results can be opened
1162 when there are more than one account.
1164 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1166 * libmodest-dbus-client/libmodest-dbus-client.c:
1167 (libmodest_dbus_client_search),
1168 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1169 instead of 1 second, because the search gets folders and messages from
1170 the server, which can take a long time. When it times out,
1171 osso-global-search will report no results.
1173 We need to specify whether we should search only cached information
1174 (maybe with a user preference), and the osso-email-search-plugin
1175 API should really be improved to allow that option, and to allow results
1176 to be delivered asynchronously in batches.
1178 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1180 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1181 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1182 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1184 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1186 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1187 that is an empty string. D-Bus seems to give us these instead of NULL.
1189 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1191 * src/dbus_api/modest-dbus-callbacks.c:
1192 * src/maemo/easysetup/modest-easysetup-wizard.h:
1193 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1194 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1195 (modest_connection_specific_smtp_edit_window_init):
1196 * src/maemo/modest-maemo-global-settings-dialog.c:
1198 * src/maemo/modest-maemo-utils.c:
1199 (modest_maemo_utils_setup_images_filechooser):
1200 * src/maemo/modest-main-window.c: (create_details_widget):
1201 * src/maemo/modest-msg-edit-window.c:
1202 (modest_msg_edit_window_attach_file_noninteractive),
1203 (modest_msg_edit_window_color_button_change),
1204 (modest_msg_edit_window_set_zoom):
1205 * src/modest-mail-operation.c: (update_account_thread):
1206 * src/modest-tny-account-store.c:
1207 * src/modest-tny-account.c:
1208 * src/widgets/modest-global-settings-dialog.c:
1209 * src/widgets/modest-window.h:
1211 Fixed build on bora!
1213 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1215 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1216 * src/modest-search.c: (modest_search_folder),
1217 (modest_search_all_accounts): Actually search only in the specified folder,
1218 doing a simple match on the folder ID.
1219 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1220 and added some documentation.
1222 2007-06-22 Armin Burgmeier <armin@openismus.com>
1224 * src/maemo/modest-maemo-utils.h:
1225 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1226 modest_maemo_utils_get_supported_secure_authentication_methods.
1228 * src/maemo/easysetup/modest-easysetup-wizard.c:
1229 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1230 one occured, not just "Server does not support secure authentication".
1232 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1234 * src/modest-tny-account-store.c: (get_password):
1235 Restored the call to tny_account_set_user() because Philip seems to have
1236 stopped this from crashing (by not using the freed string). It still does
1237 not work, but now we can test it.
1239 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1241 * src/maemo/modest-msg-edit-window.c: (init_window):
1242 Comment out use of an uninitialzed GtkScrolledWindow variable,
1243 to fix the build and stop a crash. Yet again.
1245 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-tny-account-store.c: (get_password):
1248 Remove the call to tny_account_set_user() because this actually crashes.
1249 As mentioned in the last commit, it is known to not work anyway.
1251 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1253 * src/modest-tny-account-store.c: (get_password):
1254 Use tny_account_set_username() to tell tinymail that the username might
1255 have changed too. But tinymail ignores this: see projects.maemo.org
1257 * src/modest-ui-actions.c:
1258 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1259 reset the connection when changing the username, and improve the comments.
1260 Save the changed username to gconf at least, so it is used when Modest is
1263 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1265 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1266 Do not use a query, so that we get all folders, including for POP and
1267 local-folders. They work as search criteria too.
1268 This fixes projects.maemo.org bug NB#57740.
1270 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1272 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1273 Comment out the use of hildon_notification_set_sound() because it is
1274 not declared, to fix the build. Warnings are serious, people.
1276 2007-06-21 Armin Burgmeier <armin@openismus.com>
1278 * src/maemo/modest-maemo-utils.h:
1279 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1280 modest_maemo_utils_get_supported_secure_authentication_methods()
1281 to query authentication methods for a specific user. This should fix
1282 projects.maemo.org bug NB#61369.
1284 * src/maemo/easysetup/modest-easysetup-wizard.c:
1285 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1288 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1290 * libmodest-dbus-client/libmodest-dbus-client.h:
1291 * libmodest-dbus-client/libmodest-dbus-client.c:
1292 (modest_dbus_message_iter_get_search_hit),
1293 (libmodest_dbus_client_search):
1294 Reorganised and commented this.
1295 Removed modest_search_hit_free() from the public API because it
1298 Added libmodest_dbus_client_get_folders() and
1299 modest_folder_result_list_free().
1301 * src/dbus_api/modest-dbus-api.h:
1302 * src/dbus_api/modest-dbus-callbacks.c:
1303 (modest_dbus_req_filter): Commented. Moved most code to
1304 on_dbus_method_search() and added on_dbus_method_get_folders().
1306 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1307 of the extra D-Bus handler.
1309 * tests/dbus_api/Makefile.am:
1310 * tests/dbus_api/test_get_folders.c: New test for
1311 libmodest_dbus_client_get_folders(). This seems to return an empty list
1312 at the moment. That could be the same error that causes the message list
1313 to be empty sometimes.
1314 This should help with projects.maemo.org bug NB#57740.
1316 2007-06-21 Armin Burgmeier <armin@openismus.com>
1318 * src/modest-mail-operation.c: Do not call
1319 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1320 notify the operation's end after having set the status to CANCELED for
1321 the operation queue to listen on. This fixes a deadlock when there
1322 were mail operations in the queue during its finalization.
1324 * src/modest-singletons.c: Reordered uninitialization of the account
1325 manager to happen after the mail operation queue was uninitialized
1326 because the mail operation's in the queue might still try to access
1327 the account manager (see modest_mail_operation_notify_end()). This
1328 fixes a potential crash when terminating the application.
1330 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1332 * src/modest-search.c:
1333 (search_mime_part_and_child_parts): Moved some code here so we
1334 can search recursively in child folders.
1335 (modest_search_folder): Search in the message as a mime part, instead
1336 of just its child mime parts.
1337 (read_chunk), (search_mime_part_ogs):
1338 Check how many bytes were read, to prevent an endless loop.
1339 Searching in message bodies now works. This finishes the fix for
1340 projects.maemo.org bug NB#61007.
1342 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1344 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1345 Add a g_warning when the item is not a folder.
1347 * src/modest-ui-dimming-rules.c:
1348 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1349 when selected item is not a folder (for instance, an account), because
1350 the UI spec only talks about folders.
1351 I am not sure what the UI spec wants, so this might not totally fix
1352 projects.maemo.org bug NB#60794.
1354 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1356 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1357 (load_from_file): Sort the list. The unsorted list would be more noticeable
1358 in non-English locales.
1360 * src/maemo/modest-msg-edit-window.c:
1361 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1362 warning and fix the build.
1364 * src/maemo/modest-progress-bar-widget.c:
1365 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1366 avoid a g_warning, and probably to avoid a crash.
1368 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1370 * src/modest-search.c: (modest_search_folder): Check for a GError
1371 when calling tny_folder_get_headers(), to show that this is not the cause
1374 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1376 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1377 Actually set the body query instead of the subject query.
1379 * src/modest-search.c: (search_mime_part_ogs),
1380 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1381 which would probably cause it to fail if we got this far.
1383 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1384 to simplify the code.
1385 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1386 be causing search-in-body to fail.
1388 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1390 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1392 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1393 Better debug message when the folder cannot be found.
1394 This should help with fixing projects.maemo.org bug #61287.
1395 * src/modest-search.c: (add_hit): Do not leak the furl string.
1397 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1399 * src/modest-ui-actions.c:
1400 (modest_ui_actions_on_folder_selection_changed):
1401 Do not special-case TNY_MERGE_FOLDER here, because
1402 modest_tny_folder_get_account() already does that. This fixes
1403 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1404 shown when the Outbox was selected).
1406 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1408 * libmodest-dbus-client/libmodest-dbus-client.c:
1409 (_dbus_iter_get_string_or_null): Initialize the string variable in
1410 case this helps with Dirk's crash.
1412 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1414 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1415 though it is not implemented yet (this function is maybe not even used),
1416 to avoid breaking ABI in future.
1417 * libmodest-dbus-client/libmodest-dbus-client.c:
1418 (get_attachments_string): Moved some code into this generic function.
1419 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1420 sends email. It is maybe not used.
1421 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1422 (on_send_mail): Use attachments.
1424 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1425 * src/maemo/modest-msg-edit-window.c:
1426 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1427 a filename before using it, to fix projects.maemo.org bug NB#58233.
1429 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1431 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1432 Initialize the continue_download variable to fix the build, and probably
1433 to fix randome behaviour.
1435 2007-06-18 Armin Burgmeier <armin@openismus.com>
1437 * src/modest-tny-send-queue.h:
1438 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1439 the queue so we can later show it in the UI. Replaced
1440 modest_tny_send_queue_msg_is_being_sent() by
1441 modest_tny_send_queue_get_msg_status().
1443 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1445 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1446 gpointer. This probably was not harmful, but just to be sure.
1448 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1450 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1451 Fix the build, but leave the function broken on Bora, because
1452 hildon_uri_action_get_service() does not exist.
1453 osso_uri_action_get_service() does not exist either, it seems.
1455 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1457 * src/modest-tny-account.c:
1458 (modest_tny_account_new_from_server_account):
1459 Uncommented the url debug output again, because it is useful for
1460 debugging, as I said in the comment.
1462 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1464 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1466 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1467 for Mameo Bora, to fix the build.
1469 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1472 Fixed build with hildon < 0.99
1474 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1475 Check if the selected account is busy instead of checking all accounts
1477 * src/modest-account-mgr-priv.h:
1478 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1479 (modest_account_mgr_init), (compare_account_name),
1480 (modest_account_mgr_set_account_busy),
1481 (modest_account_mgr_account_is_busy):
1482 * src/modest-account-mgr.h:
1483 Added busy information to the account manager. It possible to
1484 set an account to busy or not busy now.
1486 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1487 (modest_mail_operation_update_account),
1488 (modest_mail_operation_notify_end):
1489 Set the account to busy/not busy depending on the operation state.
1491 * src/widgets/modest-account-view.c:
1492 (modest_account_view_finalize), (get_last_updated_string),
1493 (update_account_view), (on_account_busy_changed), (init_view):
1494 Show string "Refreshing..." if the account is currently busy.
1496 All this fixes projects.maemo.org bug NB#59711
1498 2007-06-14 Armin Burgmeier <armin@openismus.com>
1500 * src/widgets/modest-attachments-view.h:
1501 * src/widgets/modest-attachments-view.c: Added
1502 modest_attachments_view_has_attachments() and fixed coordinate
1503 transformation in get_att_view_at_coords(). This fixes attachment
1506 * src/widgets/modest-msg-view.c: Make use of
1507 modest_attachments_view_has_attachments() to decide whether to show
1508 attachments in the header.
1510 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1512 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1513 (on_change), (on_combo_security_changed),
1514 (modest_connection_specific_smtp_edit_window_init),
1515 (modest_connection_specific_smtp_edit_window_set_connection),
1516 (modest_connection_specific_smtp_edit_window_is_dirty):
1517 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1518 * src/maemo/modest-connection-specific-smtp-window.c:
1521 Show an comfirmation dialog for the smpt-edit-window if there are
1522 unsaved changes and the user hits cancel.
1523 (projects.maemo.org bug NB#60479)
1525 2007-06-14 Armin Burgmeier <armin@openismus.com>
1527 * src/maemo/easysetup/modest-easysetup-wizard.c:
1528 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1529 address" info in banner instead of node, and select all the text as
1530 per UI spec. This fixes projects.maemo.org bug NB#60550.
1532 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1534 reviewed by: <delete if not using a buddy>
1536 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1537 * src/modest-ui-actions.c: (folder_refreshed_cb):
1539 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1541 * src/widgets/modest-folder-view.c: (filter_row):
1542 Explictly filter out the per-account outbox accounts. I don't know why
1543 these only sometimes show up, but now they should never show up in the UI.
1544 This should fix projects.maemo.org bug NB#60160.
1546 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1548 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1549 when the toolbar does not exist yet.
1550 * src/modest-widget-memory.c: (save_settings_header_view):
1551 Added g_warnings() to help us to discover when we are trying to set
1552 an empty columns list in gconf.
1554 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1556 * src/modest-init.h:
1557 * src/modest-init.c:
1558 Added modest_init_get_default_header_view_column_ids().
1560 * src/modest-widget-memory.c: (restore_settings_header_view):
1561 Use the new function to get defaults, if the gconf key is empty,
1562 instead of not creating any columns. This seems to fix the
1563 empty right-hand pane problems.
1565 * src/widgets/modest-header-view.h: Improved documentation.
1567 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1570 Revert the use of the display name as the account name, because this
1571 is generally wrong and would break the code that follows.
1573 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1575 * src/maemo/easysetup/modest-easysetup-wizard.c:
1576 (check_for_supported_auth_methods), (on_before_next),
1579 More correct fix for projects.maemo.org bug NB# 58991
1580 Do not longer accept AUTH_PASSWORD as secure method and choose
1581 correct method when creating the account.
1583 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1585 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1586 Fixed projects.maemo.org bug NB# 58991
1588 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1590 * src/modest-init.c: (modest_init_init_core),
1591 (modest_init_local_folders): Fixed compilation errors.
1593 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1595 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1596 Remove unnecessary lib/include, though it is good in principle when needed.
1598 * src/modest-init.c: (modest_init_one_local_folder),
1599 (modest_init_local_folders):
1600 * src/modest-init.h: Initialize the .modest library for memory cards,
1601 instead of just doing nothing for them. This should allow us to create
1602 folders there, fixing projects.maemo.org bug NB#59297.
1604 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1606 * libmodest-dbus-client/libmodest-dbus-client.c:
1607 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1608 (libmodest_dbus_client_compose_mail),
1609 (libmodest_dbus_client_open_message),
1610 (libmodest_dbus_client_send_and_receive),
1611 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1613 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1614 (on_idle_open_message), (modest_dbus_req_handler),
1615 (search_result_to_message), (modest_dbus_req_filter):
1616 * src/modest-search.c: (add_hit), (modest_search_folder),
1617 (modest_search_all_accounts): Improved debug messages.
1619 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1621 * src/modest-tny-account-store.c:
1622 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1625 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1628 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1630 * src/modest-tny-account-store.c: (get_server_accounts):
1631 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1632 even when there are no accounts, so that the Outbox folder is always
1633 visible. This fixes projects.maemo.org bug NB#60158.
1635 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/modest-main-window.c: (create_details_widget):
1638 Use the mcen_va_never logical ID.
1640 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1642 * src/dbus_api/modest-dbus-api.h:
1643 * src/dbus_api/modest-dbus-callbacks.c:
1644 (on_idle_open_default_inbox), (on_open_default_inbox),
1645 (modest_dbus_req_handler):
1646 Added a new OpenDefaultInbox method.
1648 * libmodest-dbus-client/libmodest-dbus-client.h:
1649 * libmodest-dbus-client/libmodest-dbus-client.c:
1650 Added libmodest_dbus_client_open_default_inbox() to call the new
1651 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1652 though it should maybe be used by a new osso-email-interface function.
1654 * tests/dbus_api/Makefile.am:
1655 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1658 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1660 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1661 NULL, so that the signals get all the keys. This should not actually
1662 change any behaviour because we currently update everything when anything
1665 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1667 * src/widgets/modest-folder-view.c: (text_cell_data),
1668 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1669 (find_inbox_iter): If tinymail tells us that the folder is
1670 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1671 This causes the inbox to be selected at startup, fixing part of
1672 projects.maemo.org bug NB#56305.
1674 * src/modest-ui-dimming-rules.c:
1675 (modest_ui_dimming_rules_on_tools_smtp_servers):
1676 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1677 the SMTP servers menu item.
1678 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1679 that the SMTP Servers menu item is dimmed when there are no accounts,
1680 as a future version of the UI spec will require. This fixes
1681 projects.maemo.org bug NB#56305.
1683 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1685 * src/maemo/modest-maemo-utils.c:
1686 (modest_maemo_utils_get_supported_secure_authentication_methods):
1687 Added label to dialog instead of unreadable title
1689 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1690 (modest_main_window_new):
1691 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1694 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1695 * src/modest-account-mgr.h:
1696 Added method to avoid code duplication
1698 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1699 (modest_ui_actions_on_send_receive):
1700 Use modest_account_mgr_has_accounts
1702 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1704 * src/maemo/easysetup/modest-presets.c:
1705 (modest_presets_get_info_server_security): Do not report secure auth
1707 * src/modest-protocol-info.c: Use the defines for the gconf key names
1708 for secure authentication. This was not working because we were writing
1709 Password and reading password, and the check was case sensitive.
1710 With this, gmail now works for receiving and sending when created via
1713 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1715 * src/maemo/easysetup/modest-presets.c:
1716 (modest_presets_get_info_server_security): Correct the key name for
1717 SecureSmtp, because it seems to be case-sensitive.
1718 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1719 Do not try to get the 0th notebook page if there are 0 pages, to
1720 avoid a g_warning().
1722 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1724 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1725 Prevent use of the new notification feature for now, because it currently
1726 shows one dialog for each new email, which is annoying.
1728 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1730 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1731 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1732 when no country was selected, so that we show the global ones.
1733 * src/maemo/easysetup/modest-presets.c:
1734 (modest_presets_get_providers): Return only the global providers, not
1735 all providers when mmc=0 was requested.
1737 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1739 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1740 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1741 provider ID in the combo.
1743 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1744 Do not show the page numbers, because it would be confusing when we add
1745 the 2 extra pages for the custom setup, when the user chooses the "Other"
1746 provider. This fixes projects.maemo.org bug NB#59028
1748 * src/modest-init.c: (modest_init_init_core),
1749 (modest_init_local_folders):
1750 * src/modest-init.h:
1751 * src/modest-tny-account.c:
1752 (modest_tny_account_new_for_local_folders): Do not create default folders
1753 for the memory card. This should fix projects.maemo.org bug NB#59328.
1755 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1758 Free the changed_conf_keys string items. They are already freed in the
1759 idle handler if that runs first.
1761 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1763 * src/modest-ui-actions.c:
1764 (modest_ui_actions_on_password_requested): Check that the server name
1765 is not NULL, because I just saw a password dialog with (null) as the
1768 * src/modest-tny-folder.[h|c]: Added
1769 modest_tny_folder_is_memory_card_folder().
1770 * src/modest-ui-dimming-rules.c:
1771 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1772 menu item for memory cards, as per the UI spec (section 7.4). This should
1773 fix projects.maemo.org bug NB#59297.
1775 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1777 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1778 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1779 is another problem with the code, see Murray's comment at line 772)
1781 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1783 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1784 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1785 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1786 (load_from_file), (easysetup_country_combo_box_init),
1787 (easysetup_country_combo_box_get_active_country_ids),
1788 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1789 instead of just one ID, to avoid duplicate country names in the UI.
1791 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1792 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1793 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1794 a single ID, avoiding duplicate providers.
1795 * src/maemo/easysetup/modest-easysetup-wizard.c:
1796 (on_combo_account_country): Adapt to use a list.
1798 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1800 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1801 keys changed in the last X seconds.
1803 * src/modest-account-mgr.h:
1804 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1805 (on_key_change), (modest_account_mgr_class_init),
1806 (modest_account_mgr_init), (modest_account_mgr_finalize):
1807 As the keys are changed, save them in a GSList* and signal that GSList*
1808 further every X seconds, to batch changes, to allow us to do just one
1809 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1810 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1812 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1813 changed signal signature.
1815 * src/modest-conf.c: (modest_conf_set_list),
1816 (modest_conf_on_change): Reenable notification.
1818 (modest_conf_maemo_fake_on_change): Comment out the hack that
1819 notified immediately instead of asynchronously.
1821 * src/widgets/modest-account-view.h:
1822 * src/widgets/modest-account-view.c:
1823 (update_account_view): Select the previously-selected account ID,
1824 if possible. This fixes projects.maemo.org bug NB#56933.
1826 (on_account_changed), (on_account_removed),
1827 (modest_account_view_select_account):
1829 Remove the block/unblock functions
1830 because they were not useful.
1832 * src/maemo/modest-account-view-window.c:
1833 (on_delete_button_clicked), (on_edit_button_clicked),
1834 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1836 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1838 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1839 Improve the error dialog to show Incorrect Account Settings, which seems
1840 clearer, and say that the internal error message (to be removed from the
1841 dialog later) is often misleading.
1842 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1844 * src/modest-tny-account.c:
1845 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1846 URL because this is so useful for debugging on the device.
1848 * src/widgets/modest-serversecurity-combo-box.c:
1849 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1851 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1853 * src/modest-mail-operation.c:
1854 (modest_mail_operation_send_new_mail):
1855 Added a comment about a nasty but apparently harmless message. Details
1856 added to the wiki g_warnings() page.
1858 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1860 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1861 (modest_tny_send_queue_class_init):
1862 Do not use the priv struct because it is empty, to avoid g_warnings
1863 about a non-existant priv struct.
1865 * src/modest-tny-account-store.c:
1866 (modest_tny_account_store_get_server_account),
1867 (modest_tny_account_store_get_transport_account_for_open_connection
1868 ): Do not try to get transport server accounts for local folders,
1869 because they don't have any. This avoids a g_warning().
1871 * src/maemo/modest-main-window.c:
1872 (modest_main_window_notify_send_receive_initied),
1873 (on_configuration_key_changed):
1874 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1875 * src/modest-defs.h:
1876 * src/modest-mail-operation.c:
1877 (modest_mail_operation_update_account):
1878 * src/modest-tny-account-store.h:
1879 * src/modest-tny-account.c:
1880 (modest_tny_account_get_special_folder),
1881 (modest_tny_account_new_for_local_folders),
1882 (modest_tny_account_new_for_per_account_local_outbox_folder):
1883 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1884 * src/modest-tny-local-folders-account.c:
1885 (add_account_folders_to_merged_folder):
1886 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1887 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1888 (modest_ui_actions_on_send):
1889 * src/widgets/modest-folder-view.c: (update_model):
1890 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1891 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1892 modest_tny_account_store_get_tny_account_by_account() to
1893 modest_tny_account_store_get_server_account() to make the code clearer.
1895 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1897 * src/dbus_api/modest-dbus-api.h:
1898 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1899 * src/maemo/modest-msg-edit-window.c:
1900 (modest_msg_edit_window_attach_file_noninteractive):
1901 added g_warning in case the file to be attached does not exist
1902 * tests/dbus_api/test_compose_mail.c: (main):
1903 removed obsolete comment, added generic files as test case
1905 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1907 * src/modest-tny-account-store.c: (get_server_accounts):
1908 Create the local folders account only once, not once for each outbox, and
1909 not only when there are some outboxes.
1911 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1913 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1914 code that is causing a crash at startup. Sergio says that he is fixing this.
1916 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1918 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1919 * src/maemo/modest-account-settings-dialog.c:
1920 (create_page_outgoing),
1921 (modest_account_settings_dialog_set_account_name),
1922 (save_configuration):
1923 - Fixed handling of the "Use secure authentication" toggle to comply with
1924 the ui specification. See also projects.maemo.org bug NB#58400
1926 - Restore the Secure connection setting combo correctly when loading
1929 * src/maemo/modest-maemo-utils.c:
1930 (on_camel_account_get_supported_secure_authentication),
1931 (modest_maemo_utils_get_supported_secure_authentication_methods):
1932 Fixed a crasher if operation is canceled
1934 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1935 (modest_protocol_info_auth_is_secure):
1936 * src/modest-protocol-info.h:
1938 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1939 the sense of the "Use secure authentication" toggle.
1941 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1943 * src/modest-tny-account-store.h:
1944 * src/modest-tny-account-store.c:
1945 Added modest_tny_account_store_get_local_folders_account().
1947 * src/modest-tny-folder.h:
1948 * src/modest-tny-folder.c:
1949 (modest_tny_folder_get_account):
1950 Added this replacement for tny_folder_get_account() which returns
1951 the local-folders account for TnyMergeFolders, to avoid the
1952 warning about the unimplemented get_account_func() vfunc().
1954 (modest_tny_folder_get_rules),
1955 * src/modest-ui-actions.c:
1956 (modest_ui_actions_on_folder_selection_changed):
1957 * src/modest-mail-operation.c:
1958 (modest_mail_operation_remove_folder),
1959 (modest_mail_operation_xfer_folder),
1960 (modest_mail_operation_rename_folder),
1961 (modest_mail_operation_get_msg),
1962 (modest_mail_operation_get_msgs_full),
1963 (modest_mail_operation_remove_msg),
1964 (modest_mail_operation_xfer_msgs),
1965 (modest_mail_operation_refresh_folder):
1966 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1968 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1970 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1971 (modest_server_account_set_security):
1972 * src/modest-defs.h: Add comments explaining that our
1973 UI spec means TLS when it says Normal, so these do not look like errors.
1975 * src/modest-tny-account.c:
1976 (modest_tny_account_new_from_server_account): Use the new tinymail
1977 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1978 for TLS. This should fix projects.maemo.org bug NB#58460.
1980 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/easysetup/modest-easysetup-wizard.c:
1983 (create_account): Correct the position of the gconf sanity check warning.
1984 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1985 of using the g_idle_add() hack, because this does not seem to be necessary
1986 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1987 caused by something other than maemo's gconf.
1988 This fixes projects.maemo.org bug #59022.
1990 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1992 * src/modest-account-mgr-helpers.c:
1993 (modest_account_mgr_get_default_account): Do not check that the account
1994 exists if there is no default account (NULL), to fix a runtime warning.
1996 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1998 * src/widgets/modest-folder-view.c: (update_model):
1999 Do not unref the treemodel before we have finished with it.
2000 This prevents a valgrind warning and an occasional crash at startup.
2002 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2004 * libmodest-dbus-client/libmodest-dbus-client.h:
2005 added libmodest_dbus_client_compose_mail()
2006 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2008 added functions needed for SendAsMail() functionality
2009 * src/maemo/modest-msg-edit-window.c:
2010 (modest_msg_edit_window_attach_file_noninteractive):
2011 non interactively attaching files to message edit window
2012 * src/widgets/modest-msg-edit-window.h:
2013 * tests/dbus_api/Makefile.am:
2014 added test_compose_mail.c
2015 * tests/dbus_api/test_compose_mail.c: (main):
2017 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2019 * src/modest-account-view.c:
2020 Fixed bug projects.maemo.org bug NB#59307
2022 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2024 * src/maemo/easysetup/modest-easysetup-wizard.c:
2025 (get_serverport_incoming), (on_before_next), (create_account):
2026 * src/maemo/modest-account-settings-dialog.c:
2027 (modest_account_settings_dialog_set_account_name):
2028 * src/maemo/modest-maemo-utils.c:
2029 (on_camel_account_get_supported_secure_authentication_status),
2030 (on_camel_account_get_supported_secure_authentication),
2031 (on_secure_auth_cancel),
2032 (modest_maemo_utils_get_supported_secure_authentication_methods):
2034 Implemented security authentication for settings and easysetup.
2036 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2038 * src/maemo/modest-main-window.c: (create_details_widget):
2039 Show the total size for memory card accounts too, instead of showing
2040 the name again. Fixes bug projects.maemo.org bug NB#59307.
2042 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2045 * src/modest-tny-simple-folder-store.c:
2046 * src/modest-tny-simple-folder-store.h: Removed.
2048 * src/modest-tny-local-folders-account.h
2049 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2050 for the local-folders maildir, with an extra TnyMergedFolder containing
2051 the folders of the per-account outbox store accounts.
2052 * src/modest-tny-account-store.c: (get_server_accounts):
2053 Add the outboxes to the special local folders account after creating it.
2055 * src/modest-tny-account.c:
2056 (modest_tny_account_new_for_local_folders): Create the derived
2057 account when creating the main local-folders account.
2059 * src/maemo/modest-main-window.c: (create_details_widget),
2060 (modest_main_window_set_contents_style):
2061 Adapted to the use of the derived account instead of the folder store.
2063 * src/modest-ui-actions.c:
2064 (modest_ui_actions_on_folder_selection_changed):
2065 * src/modest-ui-dimming-rules.c:
2066 (modest_ui_dimming_rules_on_new_folder):
2067 * src/widgets/modest-folder-view.c: (text_cell_data),
2068 (icon_cell_data), (filter_row), (update_model),
2069 (get_cmp_rows_type_pos):
2072 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2073 Do not get the priv struct, because no priv struct has been set,
2074 to avoid a runtime warning.
2076 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2077 #ifelse with #else, to fix a warning, to fix the build.
2080 2007-06-05 Christian Kellner <ckellner@openismus.com>
2082 * libmodest-dbus-client/libmodest-dbus-client.c:
2083 Fix small typo in doc (why do you always see them
2084 AFTER committing stuff?)
2087 2007-06-05 Christian Kellner <ckellner@openismus.com>
2089 * libmodest-dbus-client/libmodest-dbus-client.c:
2090 (libmodest_dbus_client_search):
2091 Initialize hit list with NULL. Also set folder list
2092 to "" if NULL was supplied.
2095 2007-06-03 Christian Kellner <ckellner@openismus.com>
2097 * libmodest-dbus-client/libmodest-dbus-client.c:
2098 (modest_search_hit_list_free):
2099 Make it save to call it with NULL.
2101 * src/dbus_api/modest-dbus-callbacks.c:
2102 * src/modest-search.c:
2103 Return full ModestSearchHits as the search result list not TnyHeader
2104 since can't be around withouth the correspoding TnyFolder.
2106 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2108 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2109 Added currently commented code to check for secure auth
2111 * src/maemo/modest-account-settings-dialog.c: (on_response),
2112 (save_configuration), (show_ok):
2113 Fixed projects.maemo.org bugs NB #59248 and #59251
2115 * src/maemo/modest-maemo-utils.c:
2116 (on_camel_account_get_supported_secure_authentication_status),
2117 (on_camel_account_get_supported_secure_authentication),
2118 (modest_maemo_utils_get_supported_secure_authentication_methods):
2119 * src/maemo/modest-maemo-utils.h:
2120 Moved get_supported_secure_authentication() method here to be able
2121 to use it from easysetup wizard.
2123 * src/modest-pair.c: (on_pair_compare_as_string):
2124 Should compare string with first part of pair and not
2125 strcmp pairs which will crash.
2127 * src/modest-protocol-info.c:
2128 (modest_protocol_info_protocol_is_store):
2129 * src/modest-protocol-info.h:
2130 Added modest_protocol_info_get_auth_protocol_name()
2132 2007-06-03 Armin Burgmeier <armin@openismus.com>
2134 * src/modest-mail-operation.c:
2135 (modest_mail_operation_get_msgs_full): Set priv->account also when
2136 only retrieving a single message. This avoids a crash when canceling
2139 (modest_mail_operation_notify_end): Do not explicitely remove the
2140 operation from the queue but only emit the progress_changed signal.
2141 The queue itself listens to that signal to remove the operation when
2142 it is finished. This reduces coupling and removes a potential deadlock
2143 when modest_mail_operation_notify_end() is called from the queue
2144 itself. If that is a problem performance-wise, I would suggest to
2145 implement a status-changed signal or something.
2147 * src/modest-mail-operation-queue.c: Make sure to never call a
2148 function from another file while the queue is locked. This (hopefully)
2149 fixes another deadlock when exiting the application while retrieving
2152 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2154 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2155 Fixed build if libogs is not available
2157 2007-06-03 Christian Kellner <ckellner@openismus.com>
2159 * libmodest-dbus-client/libmodest-dbus-client.h:
2160 * libmodest-dbus-client/libmodest-dbus-client.c:
2161 (libmodest_dbus_client_delete_message):
2162 Implement deletion of messages (Client side).
2164 (modest_search_hit_free),
2165 (modest_search_hit_list_free):
2166 Utility functions to free the result hits.
2168 * src/dbus_api/modest-dbus-api.h:
2169 * src/dbus_api/modest-dbus-callbacks.c:
2170 (on_delete_message),
2171 (modest_dbus_req_handler):
2172 Implement deletion of messages (Server side).
2174 * tests/dbus_api/test_search.c: (main):
2177 * tests/dbus_api/Makefile.am:
2178 * tests/dbus_api/test_delete_message:
2179 Add little test for the message deletion logic
2181 2007-06-03 Armin Burgmeier <armin@openismus.com>
2183 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2184 when the operation queue was not empty. projects.maemo.org bug
2187 2007-06-03 Armin Burgmeier <armin@openismus.com>
2189 * src/widgets/modest-account-view.c
2190 (on_account_default_toggled): Toggle default account column
2191 explicitely instead of waiting for gconf notification (which is
2192 currently ignored). This should fix projects.maemo.org bug NB#56910
2193 for now. It should probably be removed when gconf notifications are
2196 2007-06-03 Christian Kellner <ckellner@openismus.com>
2198 * libmodest-dbus-client/libmodest-dbus-client.c:
2199 Removed debugging spew.
2201 * src/dbus_api/modest-dbus-callbacks.c:
2202 Added debugging info.
2204 * src/modest-search.c:
2205 (modest_search_all_accounts):
2206 Use tny_account_store_get_accounts () on the account store
2207 to get all accounts which is the way to get all accounts.
2209 * tests/dbus_api/test_search.c: (main):
2210 Make it possible to supply the search term on the command line.
2212 2007-06-03 Christian Kellner <ckellner@openismus.com>
2214 * libmodest-dbus-client/libmodest-dbus-client.c:
2215 * libmodest-dbus-client/libmodest-dbus-client.h:
2216 Implement searching for mesages over raw dbus. (Client side)
2218 * src/dbus_api/Makefile.am:
2219 * src/dbus_api/modest-dbus-api.h:
2220 * src/dbus_api/modest-dbus-callbacks.c:
2221 * src/dbus_api/modest-dbus-callbacks.h:
2222 Search framework (Server side). Also implement on_idle_open_message().
2224 * src/maemo/modest-platform.c: (modest_platform_init):
2225 Prepare for raw dbus/osso rpc interaction.
2227 * src/modest-search.h:
2228 Changed minsize from unspecific guint to guint32.
2230 * src/modest-search.c:
2232 Added strange hack which magically made tnymail work.
2234 (modest_search_folder),
2235 (modest_search_account),
2236 (modest_search_all_accounts):
2237 Implement helper functions to search all accounts, specific account
2240 * tests/dbus_api/Makefile.am:
2241 * tests/dbus_api/test_open_message.c:
2242 Read url to open from commandline.
2244 * tests/dbus_api/test_search.c:
2245 Implement small test for dbus search stuff
2247 2007-06-02 Armin Burgmeier <armin@openismus.com>
2249 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2250 include account type and account title. This fixes projects.maemo.org
2253 * src/maemo/modest-account-view-window.c: Set a title for the window.
2255 2007-06-02 Armin Burgmeier <armin@openismus.com>
2257 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2258 incoming and outgoing server name based on email address and server
2259 types as long as the names have not been edited manually. This fixes
2260 projects.maemo.org bug NB#58671.
2262 2007-06-02 Armin Burgmeier <armin@openismus.com>
2264 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2265 server type cannot be changed in future to the incoming details page
2266 when creating an account. This fixes projects.maemo.org bug NB#59029.
2268 2007-06-02 Armin Burgmeier <armin@openismus.com>
2270 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2271 and assigned max width chars so that they wrap instead of being
2272 truncated. Fixes projects.maemo.org bug NB#56126.
2274 2007-06-02 Armin Burgmeier <armin@openismus.com>
2276 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2277 introductory note to the connection specific smtp servers dialog, as
2278 section 8.12 of the email UI specification requires. This fixes
2279 projects.maemo.org bug NB#59212.
2281 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2283 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2284 Check for running mail operations, and offer to cancel them, as per the UI
2285 spec. This fixes projects.maemo.org bug NB#59041 .
2286 However, I suspect that tinymail may still use the network connection
2287 in ways that we cannot detect or cancel. But it should at least adapt to
2288 changes fairly well.
2290 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2292 * src/modest-tny-account-store.c: (recreate_all_accounts),
2293 (get_cached_accounts), (get_server_accounts): Do more sensible
2294 ref-counting of the temporarily-cached outbox accounts list. This seems
2295 to fix a crash when entering the password when the password was wrong.
2297 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2299 * src/gnome/modest-main-window.c: (connect_signals):
2300 * src/modest-tny-account-store.c: (get_password),
2301 (modest_tny_account_store_alert): Added comments and clues and
2302 commented-out code about how we currently fail to deal with connection
2303 errors and wrong passwords, and how we should.
2305 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2307 * src/widgets/modest-retrieve-combo-box.c:
2308 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2309 This fixes projects.maemo.org bug NB#58472 .
2311 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2313 * src/maemo/easysetup/modest-easysetup-wizard.c:
2314 (create_page_complete_easysetup):
2315 (create_page_complete_custom): Correct the last commit,
2316 putting the correct sentences in the correct pages.
2318 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2320 * src/maemo/easysetup/modest-easysetup-wizard.c:
2321 (create_page_complete_custom): Show the second sentence of text
2322 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2325 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2327 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2328 Set the leave-on-server conf key by default. This fixes
2329 projects.maemo.org bug NB#59258 .
2331 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2333 * src/maemo/modest-account-view-window.c:
2334 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2335 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2338 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2340 * src/maemo/easysetup/modest-easysetup-wizard.c:
2341 (create_caption_new_with_asterisk):
2342 * src/maemo/modest-account-settings-dialog.c:
2343 (create_caption_new_with_asterisk):
2344 Uncomment the code to add the asterisk, because they are no longer in the
2345 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2346 (update_incoming_server_title): Add an asterisk here too.
2348 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2350 * src/maemo/modest-maemo-global-settings-dialog.c:
2351 (current_connection): Check that we are even connected before trying to
2352 get the current connection name, to prevent a warning.
2354 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2355 Change the comments because tny_maemo_conic_device_connect() is now meant to
2357 * src/modest-mail-operation.c:
2358 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2359 make sure we have a connection and fail if we can't connect.
2361 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2363 * src/maemo/modest-main-window.c:
2364 (on_account_store_connecting_finished): Do not try to get the
2365 connection ID if we are not really connected. I am surprised that
2366 this signal handler is called when we are not connected.
2368 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2370 * src/modest-error.h:
2371 * src/modest-ui-actions.c:
2372 (modest_ui_actions_get_msgs_full_error_handler):
2373 Renamed an enum, added comments, added an enum
2374 for retrieve-limit errors.
2376 * src/modest-mail-operation.c: (foreach_add_item),
2377 (internal_folder_observer_update), (update_account_thread),
2378 (modest_mail_operation_get_msgs_full):
2379 (modest_mail_operation_update_account),
2380 Added comments about how this works, and some code that should
2381 (but does not) check the retrieve-limit. See the TODO comment.
2383 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2385 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2386 Initialize help_id to fix the build. Warnings are good.
2388 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2390 * src/widgets/modest-hbox-cell-renderer.c:
2391 (modest_hbox_cell_renderer_append):
2392 * src/widgets/modest-vbox-cell-renderer.c:
2393 (modest_vbox_cell_renderer_append):
2394 Fix the last commit by doing an extra ref.
2396 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2398 * src/widgets/modest-hbox-cell-renderer.c:
2399 (modest_hbox_cell_renderer_append):
2400 * src/widgets/modest-vbox-cell-renderer.c:
2401 (modest_vbox_cell_renderer_append):
2402 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2403 to fix the build with Maemo Bora.
2404 However, there seems to be a remaining crash, probably due to reference
2407 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2409 * src/modest-tny-account.c:
2410 (modest_tny_account_new_for_local_folders):
2411 Use hildon_file_system_info_async_new() to get a better name for
2412 the memory card account, setting it as the account name.
2413 The timing seems to work, but this is probably
2414 not the best place to do this. See the TODO comment.
2415 * src/maemo/modest-main-window.c: (create_details_widget):
2416 * src/widgets/modest-folder-view.c: (text_cell_data):
2417 Use the tny account name instead of hardcoding a name.
2419 2007-05-30 Christian Kellner <ckellner@openismus.com>
2421 * src/modest-search.c: (modest_search):
2422 Correctly set part_search_func even if we have already parsed
2423 the query and thus a valid OgsTextSearcher object.
2425 2007-05-30 Christian Kellner <ckellner@openismus.com>
2428 Search and check for libogs.
2431 Incooparte the ogs build env.
2433 * src/modest-mime-part-search-stream.c:
2434 * src/modest-mime-part-search-stream.h:
2435 Removed since we do the real searching now in modest-search.c.
2437 * src/modest-search.c:
2438 * src/modest-search.h:
2439 Implement support for ogs. We use that if available and requested
2440 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2441 should now handle the corner case when the search term is spread
2442 across multiple reads.
2443 Also the logic in modest_search () was corrected to search all
2444 requested fields until one is found.
2446 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2448 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2450 * src/modest-init.h:
2451 * src/modest-init.c: Made modest_init_local_folders() take a
2452 path and be public so we can iniitialize maildir folders on
2455 * src/modest-local-folder-info.h:
2456 * src/modest-local-folder-info.c:
2457 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2459 * src/modest-tny-account.c:
2460 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2461 still means the standard local-folders path on the local volume.
2463 * src/modest-tny-account-store.c:
2464 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2465 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2466 all accounts when that happens.
2467 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2468 this too, so it shows up in the treeview.
2470 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2472 * src/maemo/modest-maemo-global-settings-dialog.c:
2473 (current_connection):
2474 * src/widgets/modest-global-settings-dialog.c:
2475 (current_connection_default):
2476 Use the enum values instead of 0, 1 and -1,
2477 to make the code clearer.
2479 * src/modest-account-mgr-helpers.c:
2480 (modest_account_mgr_get_connection_specific_smtp): Make this code
2483 * src/modest-runtime.h:
2484 * src/modest-runtime.c:
2485 Added modest_runtime_remove_all_send_queues().
2486 * src/maemo/modest-main-window.c:
2487 (on_account_store_connecting_finished): Recreate the send queues,
2488 using the appropriate transport accounts for this new connection.
2489 Some futher adapting might be needed if the old send queues are not
2490 automatically stopped at this point.
2492 * src/modest-tny-account-store.c: (get_server_accounts):
2493 Create the connection-specific transport accounts, so that they can
2494 be found later by their ID.
2496 * src/modest-tny-account.h:
2497 * src/modest-tny-account.c:
2498 Added modest_tny_account_new_from_server_account_name().
2499 modest_tny_account_new_from_server_account(): Do not create the
2500 send queues here, because they will be
2501 recreated anyway when the connection changes for the first time.
2503 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2505 * src/modest-local-folder-info.h:
2506 * src/modest-local-folder-info.c:
2507 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2508 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2509 tbox_folder): Take a modest account name instead of a server TnyAccount,
2510 so we can have per-modest-account rather than per-transport-account
2512 We must make sure that we change or recreate the exisitng send queues
2513 when the connection changes for connection-specific transport accounts.
2515 * src/modest-tny-account-store.c:
2516 (create_per_account_local_outbox_folders): Create outboxed per modest
2517 account, not per transport account.
2519 * src/modest-tny-account.h:
2520 * src/modest-tny-account.c:
2521 (modest_tny_account_get_special_folder): For outboxes, get the
2522 parent modest account name. The account is ignored for other folders.
2523 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2524 modest account name rather than a server TnyAccount.
2526 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2528 * src/modest-tny-account.c:
2529 (modest_tny_account_new_from_server_account):
2530 Call modest_runtime_get_send_queue() immediately after creating transport
2531 accounts, so that they start trying to send email from the outbox as soon
2532 as possible at startup. This is probably what we want.
2534 * src/modest-mail-operation.c: (update_account_thread):
2535 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2536 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2537 * src/modest-tny-send-queue.h:
2538 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2539 (modest_ui_actions_on_send):
2540 Added comments about how sending works, though it needs some more work.
2542 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2544 * src/modest-tny-account.c:
2545 (modest_tny_account_get_special_folder): Add TODO because this fails when
2546 the network is busy.
2547 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2548 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2549 Do not try to show this window when there is no active account. The UI
2550 specs does not tell us what to do in this case.
2552 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2556 * src/maemo/Makefile.am:
2557 * src/widgets/Makefile.am: Some dist fixes.
2559 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2561 * src/maemo/modest-connection-specific-smtp-window.c:
2562 (on_button_edit): Make the code clearer, to prevent a double free.
2564 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2566 * src/maemo/modest-account-settings-dialog.c:
2567 (modest_account_settings_dialog_set_account_name),
2568 Check the connection-specific smtp servers checkbox if there are any.
2570 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2571 (modest_connection_specific_smtp_edit_window_init):
2572 Start with a suitable port number.
2574 * src/modest-account-mgr-helpers.h:
2575 * src/modest-account-mgr-helpers.c: Added
2576 modest_account_mgr_get_has_connection_specific_smtp().
2578 (modest_account_mgr_set_connection_specific_smtp),
2579 (modest_account_mgr_remove_connection_specific_smtp),
2580 (modest_account_mgr_get_has_connection_specific_smtp),
2581 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2582 connection-specific smtp server accounts in the account, rather than
2583 the server account conf dir.
2585 This fixes bug projects.maemo.org bug NB#58263 .
2587 * src/modest-tny-account-store.c:
2588 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2589 if there are no server accounts yet, to prevent an infinite loop when there
2590 are no accounts. Document that one must be called before the other.
2592 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2594 * src/modest-account-mgr-helpers.c:
2595 (modest_account_mgr_get_default_account): Make sure that at least
2596 one account is always the default, if there are any enabled accounts.
2597 This is just a sanity check that shouldn't be necessary.
2599 * src/modest-account-mgr-priv.c:
2600 (_modest_account_mgr_account_from_key): Unescape the conf key to
2601 get the real account name. For instance, this is an issue if a space
2602 was in the account name, which can happen because the account name
2603 is generated from the display name.
2604 (_modest_account_mgr_get_account_keyname): Always escape the
2606 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2607 Unescape the conf keys to get the real account names.
2609 For instance, previously the is-default radio button in the accounts
2610 list was not checked for any accounts at first. This fixes that,
2611 and might fix several similar bugs.
2613 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2615 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2616 Removed some debug printfs.
2618 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2620 Modest on-disk outbox directories are now here, for instance:
2621 $HOME/.modest/outboxes/<account-id-1>/outbox
2622 $HOME/.modest/outboxes/<account-id-2>/outbox
2624 $HOME/.modest/local-folders/outbox
2625 so we can have a separate outbox for each account.
2626 But they are shown as one outbox in the GtkTreeView, by using a
2627 TnyMergeFolder in a ModestTnySimpleFolderStore.
2630 * src/modest-tny-simple-folder-store.c:
2631 * src/modest-tny-simple-folder-store.h:
2632 Added ModestTnySimpleFolderStore, used to contain folders from
2633 other folder stores, such as other accounts.
2635 * src/modest-tny-outbox-account.h:
2636 * src/modest-tny-outbox-account.c:
2637 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2638 used for the per-account local outbox folders.
2640 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2641 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2642 only use this (internally) now for the non-outbox local folders.
2644 * src/modest-init.h:
2645 * src/modest-init.c: Added modest_init_one_local_folder(), for
2646 setting up the directory structure for each local folder.
2648 * src/modest-local-folder-info.c:
2649 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2650 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2652 * src/modest-local-folder-info.h:
2653 * src/modest-tny-account-store.c: (on_account_removed),
2654 (on_account_changed), (create_per_account_local_outbox_folders),
2655 (get_server_accounts), (modest_tny_account_store_get_accounts),
2656 (modest_tny_account_store_get_tny_account_by_account),
2657 (modest_tny_folder_store_is_virtual_local_folders):
2659 * src/modest-tny-account.h:
2660 * src/modest-tny-account.c:
2661 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2662 to create an on-disk per-account local outbox folder for each
2664 (create_per_account_local_outbox_folders): Create a local outbox folder
2665 for each transport account.
2666 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2667 for all local folders.
2669 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2670 instead of using g_object_get/set() directly. It is clearer.
2672 (modest_tny_folder_store_get_message_count),
2673 (modest_tny_folder_store_get_local_size
2674 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2675 because we now use these with non-acount folder stores.
2677 (modest_tny_account_get_special_folder),
2678 (modest_tny_account_new_from_server_account),
2679 (modest_tny_account_new_from_account):
2680 (recurse_folders): Adjust to the new outbox system.
2682 * src/modest-tny-folder.h:
2683 * src/modest-tny-folder.c:
2684 (modest_tny_folder_is_local_folder),
2685 (modest_tny_folder_get_local_folder_type),
2686 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2688 * src/widgets/modest-main-window.h:
2689 * src/maemo/modest-main-window.c: (create_details_widget),
2690 (modest_main_window_set_contents_style): Show details for any folder store,
2693 (modest_tny_folder_get_rules):
2694 Remove the const. C does not support constness enough for this.
2696 * src/modest-ui-actions.c:
2697 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2698 make all outboxes appear as one, in the usual local-folders tree node.
2700 (set_active_account_from_tny_account),
2701 (modest_ui_actions_on_folder_selection_changed):
2702 * src/widgets/modest-folder-view.c: (text_cell_data),
2703 (icon_cell_data), (filter_row),
2704 (add_account_folders_to_merged_folder),
2705 (add_account_folders_to_simple_folder_store), (),
2706 (get_cmp_rows_type_pos), (cmp_rows),
2707 (modest_folder_view_set_account_id_of_visible_server_account):
2708 Adjust to the new outbox system, using generic folder stores and folders
2709 in the GtkTreeModel.
2711 2007-05-23 Christian Kellner <ckellner@openismus.com>
2713 * src/modest-mail-operation.c:
2714 (modest_mail_operation_update_account):
2715 Use info->max_size instead of unintialized local var [small
2716 build fix]. (Added TODO to review that change since I don't
2719 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2721 * libmodest-dbus-client/libmodest-dbus-client.c:
2722 (libmodest_dbus_client_compose_mail): function added
2723 * src/dbus_api/modest-dbus-api.h:
2724 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2725 (on_compose_mail): Implementation of the SendAsMail functionality
2727 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2729 * src/modest-account-mgr.c:
2730 (modest_account_mgr_add_server_account): Set the secure-connection
2731 conf key for transport accounts as well as store accounts. I don't know
2732 why the if was there. For instance, this makes sure that we use SSL
2733 for the gmail preset from the easysetup wizard.
2735 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2737 * src/gnome/modest-main-window.c:
2738 (on_account_store_connecting_finished), (connect_signals):
2739 * src/maemo/modest-main-window.c:
2740 (on_account_store_connecting_finished), (connect_signals),
2741 (modest_main_window_new):
2742 Handle TnyAccountStore::connecting-finished instead of
2743 TnyDevice::connection-changed, because we cannot actually perform
2744 operations on accounts until TnyAccountStore has itself responded to
2745 the TnyDevice::connection-changed signal. This prevents a GError from
2747 Do not try to update at startup, because we (at least on scratchbox)
2748 already do an update at startup when the device goes online.
2749 This prevents a GError from tinymail.
2750 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2751 Added TODO about stopping simultaneous operations.
2753 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2755 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2756 * src/modest-mail-operation-queue.c:
2757 (modest_mail_operation_queue_remove):
2758 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2759 about where they happened.
2761 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2763 * src/modest-ui-actions.c:
2764 (modest_ui_actions_on_password_requested): Make sure that the remember
2765 output parameter is always TRUE.
2767 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2769 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2770 Show a OK/Cancel dialog if the error is a question, though we still do not
2771 know anything more about what we are asking the user.
2772 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2773 Fix an uninitialized variable (helper). This is a logic error, however.
2775 2007-05-21 Christian Kellner <ckellner@openismus.com>
2777 * src/modest-search.h:
2778 Correct bit shifting in the ModestSearchFlags enum.
2780 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2782 * src/modest-tny-account.c:
2783 (modest_tny_account_new_from_server_account): Do not use the lsub and
2784 check-all hard-coded IMAP options when using POP.
2786 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2788 * src/modest-tny-account.c:
2789 (modest_tny_account_new_from_server_account):
2790 Use NULL for the secure-auth method for POP when Password auth has been
2791 specified by the user, as we already do for IMAP. "auth=Login" causes
2792 an error from camel or the server.
2794 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/modest-account-settings-dialog.c:
2797 (create_page_account_details),
2798 (modest_account_settings_dialog_set_account_name):
2799 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2800 for the leave-on-server checkbox, rathr than just the checkbox, when
2801 the protocol is not POP.
2803 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2805 * src/widgets/modest-account-view.c:
2806 * src/widgets/modest-account-view.h:
2807 Added modest_account_view_select_account() which will be useful later
2808 to asynchronously re-select the edited account.
2810 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2812 * src/maemo/modest-account-settings-dialog.c:
2813 (modest_account_settings_dialog_set_account_name):
2814 Automatically choose the port numbers based on the secure authentication
2815 methods, if they have not been chosen before.
2816 This fixes projects.maemo.org bug NB#56273 .
2818 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/modest-main-window-ui.h:
2821 * src/modest-ui-actions.c:
2822 * src/modest-ui-actions.h:
2823 Connect the Tools/SMTP Servers menu item to
2824 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2825 SMTP servers dialog, as in the UI specification and saves changes when it
2826 is closed. This fixed projects.maemo.org bug NB#56305 .
2828 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2830 * src/maemo/modest-connection-specific-smtp-window.c:
2831 (modest_connection_specific_smtp_window_init):
2832 Use gtk_window_set_default_size() to make this window big enough, so
2833 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2835 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2837 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2839 (modest_connection_specific_smtp_edit_window_init),
2840 Do not try to connect to a combobox signal before the combobox exists.
2841 This fixes the cras in projects.maemo.org bug NB#56288 .
2842 (modest_connection_specific_smtp_edit_window_get_settings):
2843 Remove the server_account_name parameter which was being checked for NULL
2844 though it was not used.
2846 * src/maemo/modest-connection-specific-smtp-window.c:
2847 (modest_connection_specific_smtp_window_fill_with_connections),
2848 (on_button_edit), (modest_connection_specific_smtp_window_init):
2849 Correct the number of treemodel columns to prevent a warning.
2850 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2851 libconic does not work.
2853 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2855 * src/modest-tny-account.c:
2856 (modest_tny_account_new_from_server_account):
2857 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2858 SMTP when "None" was chosen by the user. However, with my SMTP server that
2859 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2862 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2864 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2865 to explain the memory management issue with the ID in the ModestPair.
2867 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2868 (add_sending_page), (modest_account_assistant_finalize):
2869 * src/gnome/modest-gnome-global-settings-dialog.c:
2870 (create_updating_page), (create_composing_page):
2871 * src/gnome/modest-msg-edit-window.c: (get_transports),
2872 (init_window), (modest_msg_edit_window_finalize),
2873 (modest_msg_edit_window_get_msg_data):
2874 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2875 * src/gnome/modest-transport-widget.c:
2876 (modest_transport_widget_finalize), (smtp_configuration):
2877 * src/maemo/modest-maemo-global-settings-dialog.c:
2878 (create_updating_page), (create_composing_page):
2879 * src/maemo/modest-msg-edit-window.c: (get_transports),
2880 (init_window), (modest_msg_edit_window_finalize),
2881 (modest_msg_edit_window_get_msg_data),
2882 (modest_msg_edit_window_free_msg_data):
2883 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2884 (modest_store_widget_finalize):
2885 * src/maemo/modest-transport-widget.c:
2886 (modest_transport_widget_finalize), (smtp_configuration):
2887 * src/modest-main.c: (send_mail):
2888 * src/widgets/modest-combo-box.h:
2889 * src/widgets/modest-global-settings-dialog-priv.h:
2890 * src/widgets/modest-global-settings-dialog.c:
2891 (modest_global_settings_dialog_finalize):
2892 * src/widgets/modest-msg-edit-window.h:
2893 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2894 as long as the combo box, to prevent use of freed memory for the ID.
2896 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2898 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2899 get_accounts(), to make this clearer. Do not check for the enabled gconf
2900 key, because we do not use this for server accounts (at least, not yet).
2901 This allows us to send email again.
2903 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2905 * src/maemo/modest-platform.c:
2906 (on_modest_conf_update_interval_changed), (modest_platform_init):
2907 Only respond to this particular key change. All these strcmp()s cannot be
2910 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2912 * src/maemo/modest-maemo-global-settings-dialog.c:
2913 (current_connection): Prevent a crash in scratchbox when
2914 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2915 * src/maemo/modest-platform.c:
2916 (on_modest_conf_update_interval_changed), (modest_platform_init):
2917 Get the update interval from gconf and reset it when the gconf key changes.
2919 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2921 * src/modest-protocol-info.c:
2922 * src/modest-protocol-info.h: Adde enum-specific get functions,
2923 instead of using a ModestProtocolType enum parameter.
2925 * src/gnome/modest-account-assistant.c:
2926 * src/gnome/modest-store-widget.c:
2927 * src/gnome/modest-store-widget.h:
2928 * src/gnome/modest-transport-widget.c:
2929 * src/gnome/modest-transport-widget.h:
2930 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2931 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2932 * src/maemo/easysetup/modest-easysetup-wizard.c:
2933 * src/maemo/modest-account-settings-dialog.c:
2934 * src/maemo/modest-account-settings-dialog.h:
2935 * src/maemo/modest-store-widget.c:
2936 * src/maemo/modest-store-widget.h:
2937 * src/maemo/modest-transport-widget.c:
2938 * src/maemo/modest-transport-widget.h:
2939 * src/modest-account-mgr-helpers.c:
2940 * src/modest-account-mgr-helpers.h:
2941 * src/modest-account-mgr.c:
2942 * src/modest-account-mgr.h:
2943 * src/modest-tny-account.c:
2944 * src/modest-tny-folder.c:
2945 * src/widgets/modest-account-view.c:
2946 * src/widgets/modest-retrieve-combo-box.c:
2947 * src/widgets/modest-retrieve-combo-box.h:
2948 * src/widgets/modest-secureauth-combo-box.c:
2949 * src/widgets/modest-serversecurity-combo-box.c:
2950 * src/widgets/modest-serversecurity-combo-box.h:
2951 * tests/check_account-mgr.c:
2952 Use the specific functions, and use the re-renamed enum values for GNOME too.
2954 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2956 * src/modest-pair.h:
2957 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2958 so we can get the second based on the first.
2960 * src/maemo/modest-account-settings-dialog.h:
2961 * src/maemo/modest-account-settings-dialog.c:
2962 Added get_supported_secure_authentication_methods(), though it is mostly
2963 commented-out for now until the necessary API is committed to tinymail.
2964 (modest_account_settings_dialog_set_account_name),
2965 (save_configuration): Request the supported authentication methods from the
2966 server, so we can choose a working method.
2968 * src/modest-tny-account-store.h:
2969 * src/modest-tny-account-store.c:
2970 (modest_tny_account_store_get_session): Rename from
2971 tny_account_store_get_session().
2973 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2975 * src/modest-protocol-info.h: Split the ModestProtocol enum
2976 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2977 There was no need to have these unrelated values in one enum.
2979 * src/: many files: Adapted to changed enum. This makes the code a bit
2980 clearer, and the compiler could catch some errors.
2982 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2984 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2985 Show the detailed internal camel error message when an error happens
2986 during the configuration, so that our testers can give us more clues.
2987 For instance, in projects.maemo.org bug NB#56910 .
2989 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2991 * src/modest-tny-account.c:
2992 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2993 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2995 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2997 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2998 * src/maemo/modest-account-settings-dialog.c:
2999 (modest_account_settings_dialog_set_account_name),
3000 (save_configuration): For the incoming secure authentication checkbox,
3001 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3002 the UI specification. PLAIN does not seem to be supported for most IMAP
3003 servers anyway, and I am not sure what it would mean.
3004 However, we probably need to discover which of the secure-authentication
3005 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3006 * src/modest-account-mgr-helpers.c:
3007 (modest_account_mgr_get_server_account_data):
3009 * src/modest-tny-account.c:
3010 (modest_tny_account_new_from_server_account):
3011 Use tny_account_set_mech() to set secure-authentication methods,
3012 with some special-casing for IMAP, based on my observations of how
3015 * src/modest-account-mgr-helpers.h:
3016 * src/modest-account-mgr.c:
3017 * src/modest-defs.h: Comment that the URI is only used for local folders.
3019 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3021 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3022 parameter const, just to be neat.
3023 * src/modest-text-utils.c: (modest_text_utils_inline):
3024 End g_strconcat() with NULL, as its documentation says. This is almost
3025 certainly the cause of my crash at startup on the device. Interestingly,
3026 valgrind doesn't tell us about these errors.
3028 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3030 * scripts/build-packages: Added more precise comments about how to use
3031 this script, though I still get this error:
3032 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3033 error building tinymail
3035 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3037 * src/maemo/modest-main-window.c: (on_account_update):
3038 Very slight cleanup, hoping to make it simpler to discover what causes
3039 a crash here sometimes.
3041 * src/modest-tny-account.c:
3042 (modest_tny_account_new_from_server_account): Set the port. Added
3043 comments about the options and a TODO comment because I need to find out
3044 how to specify the secure authentication method.
3046 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3048 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3049 changed CFlags paths form modest to libmodest
3051 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3053 * src/modest-account-mgr-helpers.c:
3054 (modest_account_mgr_get_server_account_data),
3055 (modest_account_mgr_free_server_account_data):
3056 * src/modest-account-mgr-helpers.h:
3057 * src/modest-account-mgr.c:
3058 (modest_account_mgr_add_server_account):
3059 * src/modest-defs.h:
3060 * src/modest-tny-account.c:
3061 (modest_tny_account_new_from_server_account):
3062 Determine the options for tny_camel_account_add_option() here,
3063 based on the settings, rather than storing them directly in gconf.
3065 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3067 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3068 Show a more friendly error dialog now that we expect (from the tinymail
3069 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3071 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3073 * src/maemo/modest-main-window.c: (on_account_update): Check that
3074 account_name is not NULL, to prevent a crash at startup that I am
3075 seeing on the N800. I do wonder why it is NULL.
3077 * src/maemo/easysetup/modest-easysetup-wizard.c:
3078 (create_page_user_details):
3079 * src/maemo/modest-account-settings-dialog.c:
3080 (create_page_user_details), (create_page_outgoing):
3081 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3082 (modest_connection_specific_smtp_edit_window_init):
3083 * src/modest-ui-actions.c:
3084 (modest_ui_actions_on_password_requested):
3085 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3086 might do something useful with the on-screen keyboard.
3088 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3090 * src/maemo/modest-main-window.c: (on_account_update):
3091 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3092 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3094 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3096 * src/modest-tny-account-store.c: (on_account_changed):
3097 Correct the signature of this signal handler.
3099 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3101 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3102 Show a HildonNote instead of a GtkDialog for Maemo.
3104 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3106 * src/widgets/modest-account-view.h:
3107 * src/widgets/modest-account-view.c: (on_account_changed),
3108 (on_account_removed). Added a boolean flag, set/unset by
3109 modest_account_view_block_conf_updates(),
3110 modest_account_view_unblock_conf_updates() to prevent unnecessary
3111 updates, but this is not very useful because the gconf notifications are
3112 so delays (maybe only on Maemo Bora).
3113 So auto-updating is turned off, and these functions do an explicit
3114 update when necessary.
3115 However, something else is still doing too much work when adding/removing
3116 accounts, probably in another part of the application.
3118 * src/maemo/modest-account-view-window.c:
3119 (on_delete_button_clicked), (on_edit_button_clicked),
3120 (on_new_button_clicked): Use the new functions.
3122 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3124 * src/modest-account-mgr-helpers.c:
3125 (modest_account_mgr_set_first_account_as_default):
3126 Sort the list of names alphabetically-by-title, so we choose the first one
3128 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3129 alphabetically by the title.
3131 This fixes projects.maemo.org bug NB#56418 .
3133 * src/modest-account-mgr-priv.c:
3134 (_modest_account_mgr_account_from_key):
3135 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3136 avoid a valgrind error, and possible random behaviour.
3138 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3140 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3141 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3142 tinymail documentation to say that this can be expected.
3143 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3144 pretty, and should not happen, but I would prefer to know when it does.
3146 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3148 * configure.ac: When using the older hildon version, probably on Bora,
3149 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3151 * src/widgets/modest-attachment-view.c:
3152 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3155 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3157 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3158 Implemented the prototype. Can be tested with
3159 tests/dbus_api/test_open_message:
3161 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3163 * src/modest-tny-account-store.c:
3164 (modest_tny_account_store_instance_init), (get_password):
3165 * src/modest-ui-actions.c:
3166 (modest_ui_actions_on_password_requested):
3167 Do not store the password in gconf, because this function is called
3168 for non-remembered passwords. Actually use the cached (in the hash map)
3169 password instead of releasing it.
3170 The password will now not be remembered if it is asked via the protected
3171 password dialog, as per the UI spec.
3173 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3175 * src/modest-defs.h:
3176 * src/modest-account-mgr-helpers.h:
3177 * src/modest-account-mgr-helpers.c:
3178 Added modest_server_account_get_username_has_succeeded(),
3179 modest_server_account_set_username_has_succeeded().
3180 (modest_server_account_set_username),
3181 Reset the has-succeeded flag if the username changes.
3183 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3184 * src/maemo/modest-connection-specific-smtp-window.c:
3185 (modest_connection_specific_smtp_window_save_server_accounts):
3186 Use modest_server_account_set_username() instead of using
3187 modest_conf_set_string() directly, so that the has-succeeded flag is always
3190 * src/modest-ui-actions.c:
3191 (modest_ui_actions_on_password_requested): Dim the username entry if
3192 the username has ever worked, as per the UI spec.
3194 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3196 * src/modest-tny-account-store.c: (get_password):
3197 * src/modest-ui-actions.c:
3198 (modest_ui_actions_on_password_requested):
3199 Allow the username to be changed too, though there is more work to
3200 be done on exactly how this behaves.
3202 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3204 * src/modest-account-mgr-helpers.h:
3205 * src/modest-account-mgr-helpers.c:
3206 Added modest_account_mgr_get_display_name(),
3207 modest_server_account_get_username(),
3208 modest_server_account_set_username(),
3209 modest_server_account_set_password(),
3210 modest_server_account_get_hostname() functions so we do not need to
3211 use the conf API directly.
3213 * src/maemo/modest-main-window.c: (connect_signals):
3214 Actually connect ot the ModestAccountStore::request-password signal,
3215 so that we show the dialog when the password is requested by Tinymail,
3216 for isntance if it is empty.
3218 * src/modest-marshal.list:
3219 * src/modest-tny-account-store.c:
3220 (modest_tny_account_store_class_init), (get_password),
3221 (modest_tny_account_store_alert):
3222 * src/modest-tny-account-store.h:
3223 * src/modest-ui-actions.h:
3224 * src/modest-ui-actions.c:
3225 (modest_ui_actions_on_password_requested):
3226 Change the signal parameters, so it is obvious that we are providing
3227 the non human-readable server name, and receiving both the username
3228 and password, though changing of the username is not yet implemented.
3229 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3230 for the GNOME version.
3232 This should fix the projects.maemo.org bug NB#56209, though it does not
3233 work on Bora, because the gconf_client_get() for the password fails
3234 immediately after we save it with gconf_client_set().
3236 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3239 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3240 caused an undefined symbol error:
3241 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3243 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3245 * src/modest-tny-account-store.c:
3246 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3247 using a GError instead of a string message, so we can translate it in
3250 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3252 * src/maemo/modest-address-book.c:
3253 (modest_address_book_check_names):
3254 * src/maemo/modest-msg-view-window.c:
3255 (modest_msg_view_window_clipboard_owner_change):
3256 * src/modest-init.c: (modest_init_init_ui):
3257 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3258 (update_folders_cb), (modest_mail_operation_update_account):
3259 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3260 (modest_ui_actions_on_msg_attachment_clicked),
3261 (modest_ui_actions_on_msg_recpt_activated):
3262 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3263 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3264 (modest_msg_view_search_next):
3265 * src/widgets/modest-recpt-editor.c:
3266 (modest_recpt_editor_on_button_release_event),
3267 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3268 g_message(). At this point we should only be seeing interesting errors on
3269 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3271 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3273 (modest_wizard_dialog_force_title_update):
3274 * src/maemo/easysetup/modest-wizard-dialog.h:
3275 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3276 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3277 can update the title when appropriate. Otherwise the title is wrong if the
3278 pages are added after adding the notebook to the dialog.
3279 This must be a problem in HildonWizardDialog too.
3280 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3282 * src/maemo/easysetup/modest-easysetup-wizard.c:
3283 (create_subsequent_customsetup_pages),
3284 (create_subsequent_easysetup_pages):
3285 Call modest_wizard_dialog_force_title_update() so that the title is
3286 correct even with GTK+ < 2.10.
3287 This fixes projects.maemo.org bug NB#56145 .
3289 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3291 * src/maemo/modest-platform.c:
3292 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3293 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3296 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3298 * src/widgets/modest-window.h:
3299 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3300 and modest_window_save_state(), which invokes it.
3302 * src/widgets/modest-window-mgr.h:
3303 * src/widgets/modest-window-mgr.c:
3304 Added modest_window_mgr_save_state_for_all_windows(), which calls
3305 the save_state vfunc on all registered windows, if implemented.
3307 * src/gnome/modest-msg-edit-window.c:
3308 * src/gnome/modest-msg-view-window.c:
3309 * src/maemo/modest-msg-edit-window.c:
3310 * src/maemo/modest-msg-view-window.c:
3311 * src/maemo/modest-main-window.c:
3312 Specify the existing save_settings functions as implementations of
3313 ModestWindow::save_state_func().
3315 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3316 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3317 enabling hibernation, for instance.
3319 We may need to do the same thing for restoring settings.
3322 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3324 * src/widgets/modest-window-mgr.c:
3325 * src/widgets/modest-window-mgr.h:
3326 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3327 modest_window_mgr_get_hibernation_is_prevented().
3329 * src/maemo/modest-main-window.c:
3330 (on_hildon_program_is_topmost_notify): Prevent hibernation
3331 (possible when the application goes to the background in the WM),
3332 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3334 * src/maemo/easysetup/modest-easysetup-wizard.c:
3335 (modest_easysetup_wizard_dialog_init):
3336 * src/maemo/modest-account-settings-dialog.c:
3337 (modest_account_settings_dialog_init):
3338 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3339 (modest_connection_specific_smtp_edit_window_init):
3340 * src/maemo/modest-connection-specific-smtp-window.c:
3341 (modest_connection_specific_smtp_window_init):
3342 * src/maemo/modest-signature-editor-dialog.c:
3343 (modest_signature_editor_dialog_init):
3344 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3345 prevent hibernation while any of these account settings dialogs are open.
3347 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3349 * src/maemo/Makefile.am:
3350 * src/maemo/modest-osso-state-saving.c:
3351 * src/maemo/modest-osso-state-saving.h: Added
3352 modest_osso_load_state() and modest_osso_save_state() though they do
3353 nothing now. They should iterate through all the open windows and load/save
3355 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3356 save state when closing.
3358 * src/maemo/modest-main-window.c:
3359 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3360 Add a notification handler for the HildonProgram::is-topmost property,
3361 so we can allow hibernation when the application goes into the background.
3362 But we still need to detect when the accounts setup windows are open so
3363 we can stop hibernation when they are open.
3364 To do this, I also added the main window the HildonProgram. This might have
3365 other side-effects/benefits, and should maybe be done for other windows.
3367 * src/maemo/modest-osso-autosave-callbacks.h:
3368 * src/maemo/modest-osso-autosave-callbacks.c:
3369 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3370 though it does not do anything yet, and we might never need this to do
3371 anything. For instance, we already save drafts.
3373 * src/maemo/modest-platform.c: (modest_platform_init):
3374 Specify the libosso auto-save callback.
3376 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3378 * src/maemo/modest-platform.c:
3379 (modest_platform_set_update_interval):
3380 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3381 aparently stays valid between application instances, so we can use this
3382 to remove and reset it later. According to a maemo-developers email from
3385 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3387 * configure.ac: Depend on libalarm for Maemo.
3389 * src/dbus_api/modest-dbus-api.h:
3390 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3391 (on_send_receive), (modest_dbus_req_handler):
3392 Handle a SEND_RECEIVE D-Bus method.
3394 * libmodest-dbus-client/libmodest-dbus-client.c:
3395 (libmodest_dbus_client_send_and_receive):
3396 * libmodest-dbus-client/libmodest-dbus-client.h:
3397 Add C convenience functions for calling the new D-Bus method.
3399 * src/modest-platform.h:
3400 * src/gnome/modest-platform.c:
3401 * src/maemo/modest-platform.c:
3402 Added modest_platform_set_update_interval(), which uses the
3403 alarmd API on Maemo.
3404 (modest_platform_init),
3405 Call modest_platform_set_update_interval(), using a hard-coded
3406 interval for now (until the global settings dialog is implemented),
3407 though I am not sure that this makes sense yet.
3409 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3411 * src/dbus_api/modest-dbus-callbacks.c:
3412 (modest_osso_cb_hw_state_handler):
3413 * src/dbus_api/modest-dbus-callbacks.h:
3414 * src/maemo/modest-platform.c: (modest_platform_init):
3415 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3416 in case this has some effect on the ability for Maemo to ping the
3419 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3421 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3422 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3423 warning. It is probably a logic error, but I need to fix the build.
3425 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3427 * src/modest-account-mgr.h:
3428 * src/modest-account-mgr.c:
3429 (modest_account_mgr_account_names): Add a gboolean enabled_only
3430 parameter, so we can get lists of onlt the enabled accounts.
3432 (modest_account_mgr_add_account),,
3433 (modest_account_mgr_account_with_display_name_exists):
3434 * src/maemo/modest-msg-edit-window.c: (get_transports):
3435 * src/modest-account-mgr-helpers.c:
3436 (modest_account_mgr_set_first_account_as_default):
3437 * src/modest-init.c: (init_default_account_maybe):
3438 * src/modest-tny-account-store.c: (get_accounts):
3439 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3440 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3441 * tests/check_account-mgr.c: (START_TEST):
3442 Provide the extra parameter, as appropriate.
3444 * src/widgets/modest-account-view.c: (update_account_view):
3445 Do not show disabled accounts (meaning that there is no way to
3446 enable/disable accounts in the UI (the feature is not in our UI
3447 specification), so we can use this internally only to mark unfinished
3448 or temporary account data.
3450 * src/maemo/easysetup/modest-easysetup-wizard.c:
3451 (create_account): Add boolean enable parameter, so we can specify FALSE
3452 to create the temporary account.
3453 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3454 (on_before_next): When finishing, when there is a temporary account, just
3456 Also, use a timeout to delay the showing of the dialog until gconf is likely
3457 to return correct information, due to a maemo gconf bug that is fixed in
3458 osso 1.1, but not yet in Bora.
3459 However, the dialog stays on screen after it is destroyed.
3461 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3462 for invalid data when cancelling. Use a hildon note instead of a dialog
3463 to complain about invalid data. Do not show the account-saved note if the
3464 account is disabled (a temporary account that will not really be saved for use
3467 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3469 * src/modest-account-mgr-helpers.h:
3470 * src/modest-account-mgr-helpers.c:
3471 Added modest_account_mgr_unset_default_account(),
3472 Added modest_account_mgr_set_first_account_as_default().
3474 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3475 If it was the default account, unset the default account name.
3477 * src/maemo/modest-account-view-window.c:
3478 (on_delete_button_clicked): If it was the default account,
3479 set the first remaining account as the default instead.
3481 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3482 a NULL account or a NULL default account, to prevent a crash. This should
3483 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3486 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3488 * src/widgets/modest-recpt-editor.c:
3489 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3490 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3491 TODO comment for this. This fixes the build.
3493 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3494 be the best place for it. This will in future update all auto-update accounts,
3495 rather than just the current/default account, when that gconf key exists.
3496 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3497 if there are no accounts, before calling do_send_receive().
3498 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3500 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3501 * src/maemo/modest-main-window-ui.h:
3502 * src/maemo/modest-main-window.c: (on_connection_changed),
3503 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3504 directly, becaue the signal handler does more.
3506 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3508 * src/modest-account-mgr-helpers.c:
3509 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3510 for the case that the account does not exist.
3512 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3513 (equivalent to the modest account name) rather than the tinymail account name
3514 (equivalent to the modest account title - human readable) to get the account data.
3515 Check for null account data to prevent the crash, and add a TODO comment saying that
3516 this needs fixing because it is using the server account name instead of the account name.
3518 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3520 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3521 * src/maemo/modest-account-settings-dialog.c: (show_error),
3523 Use hildon_note_new_information() for informative and error messages,
3524 which seems to be expected for Maemo applications (no documentation that I know of
3525 says this). I am surprised that there is no distinction between info and error
3528 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3530 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3531 it is easy to find where this is used.
3533 * src/maemo/easysetup/modest-easysetup-wizard.c:
3534 (create_page_welcome), (create_page_account_details),
3535 (create_page_user_details), (create_page_complete_easysetup),
3536 (create_page_custom_incoming), (create_page_custom_outgoing),
3537 (create_page_complete_custom):
3538 * src/maemo/modest-account-settings-dialog.c:
3539 (create_page_account_details), (create_page_user_details),
3540 (create_page_incoming), (create_page_outgoing):
3541 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3542 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3543 (modest_connection_specific_smtp_edit_window_init):
3544 * src/maemo/modest-connection-specific-smtp-window.c:
3545 (modest_connection_specific_smtp_window_init):
3546 * src/maemo/modest-signature-editor-dialog.c:
3547 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3548 and scrolling policy as per the Email Application Layout Guide, if I have
3551 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3553 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3554 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3555 which were empty, because these vfuncs have been removed from TnyAccountStore.
3556 This fixes the build.
3558 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3560 * src/maemo/modest-main-window.c:
3561 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3562 showing/hiding it. Added TODO because it probably should not be NULL.
3563 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3564 because unnecessary g_warnings() make degugging difficult.
3566 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3568 * src/maemo/modest-msg-edit-window.c:
3569 (modest_msg_edit_window_select_color),
3570 (modest_msg_edit_window_select_background_color): 2 const corrections and
3571 moving 2 #endifs before closing brackets, to fix the build.
3573 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3575 * src/maemo/easysetup/modest-easysetup-wizard.h:
3576 * src/maemo/easysetup/modest-easysetup-wizard.c:
3577 (modest_easysetup_wizard_dialog_finalize),
3578 (on_button_edit_advanced_settings), (create_page_complete_custom),
3579 (on_response), (create_account):
3580 Implement the Advanced Settings edit button, by saving the account information,
3581 for the Advanded Settings dialog to use directly from gconf, and removing it
3582 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3583 Bug #5533 in the projects.maemo.org bugzilla.
3585 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3587 * src/maemo/modest-msg-view-window.c:
3588 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3589 when opening a message window.
3591 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3593 * src/maemo/easysetup/modest-easysetup-wizard.c:
3594 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3597 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3598 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3599 gconf settings. I probably added more checks than necessary, but that is safer.
3601 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3602 variable to fix the build, but this seems to be used when it is still NULL.
3604 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3606 * src/modest-platform.h:
3607 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3608 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3609 * src/modest-main.c: Implement this function so we can avoid using
3610 maemo-specific API from cross-platform code.
3612 * src/modest-tny-account-store.c:
3613 (get_smtp_specific_transport_account_for_open_connection):
3614 * src/modest-ui-actions.c: (check_for_connection),
3615 (modest_ui_actions_on_item_not_found):
3616 Use modest_platform_connect_and_wait() and put #idefs around other
3617 maemo-specific code, because only maemo currently has a way to
3618 identify connection names.
3620 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3622 * src/modest-tny-account-store.h:
3623 * src/modest-tny-account-store.c:
3624 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3625 the connection-specific SMTP server settings in the configuration.
3627 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3629 * src/maemo/modest-main-window.c: (on_connection_changed),
3631 * src/modest-main.c: (main), (start_ui), (send_mail):
3632 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3633 that is what is intended.
3635 * src/modest-ui-actions.c: (action_send), (action_receive),
3636 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3637 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3638 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3639 SMTP server is used when it is specified.
3641 (modest_ui_actions_on_send_receive):
3642 Check that a connection is open before proceeding.
3643 Receive and then send, instead of vice-versa, as per the specification.
3645 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3647 * src/modest-mail-operation.c:
3648 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3649 though I guess it should be something other than NULL.
3651 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3653 * src/maemo/easysetup/modest-easysetup-wizard.c:
3654 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3655 combo twice, to avoid an g_warning and to make it visible again.
3656 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3657 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3658 (already intended) dereference when detaching, because we then recreate the menu.
3659 But I am not sure why the warning was happening, and it is possible that this is a memory
3662 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3664 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3665 and uri_parse_mailto() utility functions.
3666 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3668 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3670 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3672 * src/dbus_api/modest-dbus-api.h:
3673 * src/dbus_api/modest-dbus-callbacks.c:
3674 Use an idle callback to execute the modest code in the application's own thread.
3675 Remove the helloworld example method.
3676 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3677 parsed, and the open-message method is not implemented because this is not yet implemented in
3679 * libmodest-dbus-client/libmodest-dbus-client.c:
3680 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3681 (libmodest_dbus_client_open_message):
3682 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3684 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3685 body without crashing.
3687 * tests/dbus_api/Makefile.am:
3688 * tests/dbus_api/test_mail_to.c:
3689 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3691 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3693 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3694 Added file to fix the build. Sorry.
3696 * src/dbus_api/Makefile.am:
3697 * src/dbus_api/modest-dbus-api.h:
3698 * src/dbus_api/modest-dbus-callbacks.h:
3699 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3700 (modest_dbus_req_handler):
3701 Put constants in a separate header so it can be reused by the
3702 client library, without duplication
3704 * libmodest-dbus-client/Makefile.am:
3705 * libmodest-dbus-client/libmodest-dbus-client.c:
3706 (libmodest_dbus_client_call_helloworld),
3707 (libmodfest_dbus_client_send_mail),
3708 (libmodfest_dbus_client_mailto),
3709 (libmodfest_dbus_client_open_message):
3710 * libmodest-dbus-client/libmodest-dbus-client.h:
3711 (Partly) Implement a send_mail D-Bus method.
3713 * tests/dbus_api/Makefile.am:
3714 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3715 the send_email D-Bus method.
3717 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3721 * libmodest-dbus-client/Makefile.am:
3722 * libmodest-dbus-client/libmodest-dbus-client.c:
3723 * libmodest-dbus-client/libmodest-dbus-client.h:
3724 * tests/dbus_api/Makefile.am:
3725 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3726 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3728 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3730 * src/maemo/easysetup/modest-easysetup-wizard.c:
3731 (create_page_account_details):
3732 * src/maemo/modest-account-settings-dialog.c:
3733 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3734 widgets, because this might not be the default in future versions of the Maemo GTK+.
3735 However, I can not not get capitalization to work even in a simple test case.
3737 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3739 * src/maemo/easysetup/modest-easysetup-wizard.c:
3740 (create_page_custom_incoming), (create_page_custom_outgoing):
3741 * src/maemo/modest-account-settings-dialog.c:
3742 (create_page_account_details), (create_page_incoming),
3743 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3744 instead of using gtk_check_button_with_label(), so they are aligned like the other
3745 widgets, as per the UI spec.
3747 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3749 * src/maemo/easysetup/modest-easysetup-wizard.c:
3750 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3751 * src/widgets/modest-validating-entry.c:
3752 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3753 Modest prefix instead of an EasySetup prefix.
3755 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3757 * src/widgets/modest-validating-entry.h:
3758 * src/widgets/modest-validating-entry.c: (on_insert_text),
3759 Added easysetup_validating_entry_set_max_func(), used to set a callback
3760 to call when the max number of characters is reached. GtkEntry has a max-length
3761 already but is silent about it.
3763 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3764 (create_page_account_details), (create_page_user_details),
3766 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3767 (create_page_account_details), (create_page_user_details),
3768 (create_page_outgoing):
3769 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3770 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3771 the UI spec, when the user tries to enter more than the max number of characters.
3773 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3775 * src/maemo/easysetup/modest-easysetup-wizard.c:
3776 (create_page_user_details), (create_page_custom_incoming),
3777 (create_page_custom_outgoing):
3778 * src/maemo/modest-account-settings-dialog.c:
3779 (create_page_user_details), (create_page_incoming),
3780 (create_page_outgoing):
3781 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3782 (modest_connection_specific_smtp_edit_window_init):
3783 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3784 not appropriate. Bad Maemo-specific defaults!.
3786 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3788 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3789 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3790 (modest_signature_editor_dialog_set_settings):
3791 Disable the label and textview when the checkbox is disabled, and use the
3792 specified (UI spec) default signature text.
3794 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3796 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3797 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3799 * src/modest-defs.h:
3800 * src/modest-account-mgr-helpers.h:
3801 * src/modest-account-mgr-helpers.c:
3802 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3804 * src/maemo/Makefile.am:
3805 * src/maemo/modest-signature-editor-dialog.c:
3806 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3809 * src/maemo/modest-account-settings-dialog.h:
3810 * src/maemo/modest-account-settings-dialog.c:
3811 (modest_account_settings_dialog_finalize), (on_button_signature),
3812 (save_configuration): Use the new dialog when the Edit button is pressed, and
3813 save the changes if necessary, as per the UI spec.
3815 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3817 * src/maemo/Makefile.am:
3818 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3819 based on maemo-develoers email from Dirk.
3821 * src/maemo/easysetup/modest-easysetup-wizard.c:
3822 (create_page_welcome), (create_page_account_details),
3823 (create_page_user_details), (create_page_complete_easysetup),
3824 (create_page_custom_incoming), (create_page_custom_outgoing),
3825 (create_page_complete_custom),
3826 (modest_easysetup_wizard_dialog_init):
3827 * src/maemo/modest-account-settings-dialog.c:
3828 (create_page_account_details), (create_page_user_details),
3829 (create_page_incoming), (create_page_outgoing),
3830 (modest_account_settings_dialog_init):
3831 * src/maemo/modest-connection-specific-smtp-window.c:
3832 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3834 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3836 * src/maemo/easysetup/modest-easysetup-wizard.c:
3837 (create_page_account_details), (create_page_custom_outgoing),
3838 (create_page_complete_custom):
3839 * src/maemo/modest-account-settings-dialog.c:
3840 (create_page_user_details), (create_page_incoming),
3841 (create_page_outgoing):
3842 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3843 (modest_connection_specific_smtp_edit_window_init):
3844 Use the correct (UI spec) port min/max, and use horizontal separators,
3847 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3849 * src/maemo/easysetup/modest-easysetup-wizard.c:
3850 (set_default_custom_servernames):
3851 * src/maemo/modest-account-settings-dialog.c:
3852 (create_page_incoming), (on_combo_outgoing_security_changed),
3853 (on_combo_incoming_security_changed), (create_page_outgoing),
3854 (modest_account_settings_dialog_set_account_name),
3855 (save_configuration):
3856 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3857 (on_combo_security_changed),
3858 (modest_connection_specific_smtp_edit_window_init),
3859 (modest_connection_specific_smtp_edit_window_set_connection),
3860 (modest_connection_specific_smtp_edit_window_get_settings):
3861 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3864 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3867 * src/maemo/easysetup/modest-easysetup-wizard.c:
3868 (create_page_custom_outgoing), (create_page_complete_custom):
3869 * src/maemo/modest-account-settings-dialog.c:
3870 (create_page_user_details), (create_page_outgoing):
3871 * src/maemo/modest-account-view-window.c: (button_box_new):
3872 Use changed logical IDs as per the most recent UI spec:
3873 mcen_bd_emailsetup_edit -> mcen_bd_edit
3874 mcen_bd_emailsetup_delete -> mcen_bd_delete
3875 mcen_bd_emailsetup_close -> mcen_bd_close
3877 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3881 * src/dbus_api/Makefile.am:
3882 * src/dbus_api/modest-dbus-callbacks.c:
3883 * src/dbus_api/modest-dbus-callbacks.h:
3884 * src/maemo/modest-platform.c: (modest_platform_init):
3885 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3887 * tests/Makefile.am:
3888 * tests/dbus_api/Makefile.am:
3889 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3891 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3893 * src/maemo/modest-account-settings-dialog.c:
3894 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3895 Removed unnecessary includes.
3897 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3899 * src/maemo/easysetup/modest-easysetup-wizard.c:
3900 * src/maemo/modest-account-settings-dialog.c:
3901 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3902 * src/widgets/Makefile.am:
3903 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3904 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3905 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3906 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3907 * src/widgets/modest-secureauth-combo-box.c:
3908 * src/widgets/modest-secureauth-combo-box.h:
3909 * src/widgets/modest-serversecurity-combo-box.c:
3910 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3911 made the GObject names more consistent with the rest of the Modest code.
3913 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3915 * src/maemo/easysetup/Makefile.am:
3916 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3917 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3918 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3919 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3920 * src/maemo/easysetup/modest-easysetup-wizard.c:
3921 * src/maemo/easysetup/modest-validating-entry.c:
3922 * src/maemo/easysetup/modest-validating-entry.h:
3923 * src/maemo/modest-account-settings-dialog.c:
3924 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3925 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3926 widgets/ because they are used outside of easysetup too. After checking in,
3927 svn will allow me to rename them too.
3929 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3931 * src/gnome/modest-msg-edit-window.c:
3932 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3933 linker error, to fix the build on the GNOME platform.
3934 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3935 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3936 ifdefed out to avoid a warning.
3938 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3940 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3941 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3942 some alternative for GTK+ 2.6.
3944 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3946 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3948 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3949 specified for EmailAccountsDialog in UI spec.
3951 * src/maemo/easysetup/modest-easysetup-wizard.c:
3952 * src/maemo/easysetup/modest-easysetup-wizard.h:
3953 * src/maemo/modest-account-settings-dialog.c:
3954 * src/maemo/modest-account-settings-dialog.h:
3955 Reuse a member window widget for the connection-specific SMTP server accounts,
3956 so we can tell it to create/save the accounts only if we actually save changes.
3958 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3959 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3960 (modest_connection_specific_smtp_edit_window_get_settings):
3961 Return a struct instance for temporarily remembering the entered data.
3963 * src/maemo/modest-connection-specific-smtp-window.h:
3964 * src/maemo/modest-connection-specific-smtp-window.c:
3965 (modest_connection_specific_smtp_window_finalize),
3966 (modest_connection_specific_smtp_window_fill_with_connections),
3968 (modest_connection_specific_smtp_window_save_server_accounts),
3969 (update_model_server_names): Do not actually save data until asked,
3970 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3972 (on_selection_changed),
3973 (modest_connection_specific_smtp_window_init): Disable the edit
3974 button when nothing is selected.
3976 * src/modest-account-mgr-helpers.c:
3977 * src/modest-account-mgr-helpers.h:
3978 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3981 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3983 * src/modest-account-mgr-helpers.h:
3984 * src/modest-account-mgr-helpers.c:
3985 (modest_account_mgr_get_unused_account_name),
3986 (modest_account_mgr_get_unused_account_display_name): Added these
3987 utility functions, to avoid code duplication.
3989 * src/maemo/easysetup/modest-easysetup-wizard.c:
3990 (create_page_account_details), (create_account):
3991 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3992 (on_combo_security_changed),
3993 (modest_connection_specific_smtp_edit_window_init),
3994 (modest_connection_specific_smtp_edit_window_save_settings):
3995 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3996 * src/maemo/modest-connection-specific-smtp-window.c:
3997 (modest_connection_specific_smtp_window_finalize),
3998 (modest_connection_specific_smtp_window_fill_with_connections),
3999 (on_button_edit), (modest_connection_specific_smtp_window_init):
4000 * src/maemo/modest-connection-specific-smtp-window.h:
4001 Implementing saving of connection-specific server accounts.
4003 But I need to refactor this so we can save the data for each
4004 possible connection-specific account and only actually create the server accounts
4005 when the easysetup finished, or the OK button is pressed on the account settings
4008 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4010 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4011 (on_combo_security_changed):
4012 (modest_connection_specific_smtp_edit_window_init):
4013 Auto-fill the port number as in the account settings.
4015 (modest_connection_specific_smtp_edit_window_set_connection):
4016 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4017 * src/maemo/modest-connection-specific-smtp-window.c:
4018 (fill_with_connections), (on_button_edit),
4019 (modest_connection_specific_smtp_window_init):
4020 Turn the edit window into a dialog to simplify the code, and
4021 set a WM hint as in a GtkDialog, because only a popup can be on top of
4022 another window in Maemo, and popups usually have no WM decoration.
4024 * src/modest-defs.h:
4025 * src/modest-account-mgr-helpers.c:
4026 (modest_account_mgr_set_connection_specific_smtp),
4027 (modest_account_mgr_remove_connection_specific_smtp),
4028 (modest_account_mgr_get_connection_specific_smtp):
4029 * src/modest-account-mgr-helpers.h: Some functions to write the
4030 connection-specific SMTP server information. Not yet used.
4033 * src/widgets/modest-folder-view.c: (text_cell_data):
4034 Fix a warning about an uninitialized variable.
4035 (on_configuration_key_changed): Put an #ifdef around the use
4036 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4038 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4040 * src/maemo/modest-account-settings-dialog.h:
4041 * src/maemo/modest-account-settings-dialog.c:
4042 Added connect_for_modified() utility function to mark the new modified boolean.
4044 (create_page_account_details), (create_page_user_details),
4045 (create_page_incoming), (create_page_outgoing), (on_response),
4046 (modest_account_settings_dialog_init),
4047 (modest_account_settings_dialog_set_account_name):
4048 Only warn about unsaved changes when there are actually unsaved changes.
4050 * src/modest-account-mgr-helpers.c:
4051 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4052 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4053 to get the data from there in future.
4055 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4057 * src/modest-defs.h:
4059 * src/modest-account-mgr-helpers.h:
4060 * src/modest-account-mgr-helpers.c:
4061 Store the security account setting in a single conf key instead of using
4062 the options list, so that the list is left for just the to-be-removed camel hack,
4063 and because gconf_client_set_list() is failing for some reason.
4065 * src/modest-account-mgr.c:
4066 (modest_account_mgr_add_server_account):
4067 * src/maemo/modest-account-settings-dialog.c:
4068 (modest_account_settings_dialog_set_account_name),
4069 (save_configuration): Use the renamed functions.
4072 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4074 * src/widgets/Makefile.am:
4075 * src/widgets/modest-limit-retrieve-combo-box.c:
4076 * src/widgets/modest-limit-retrieve-combo-box.h:
4077 * src/widgets/modest-retrieve-combo-box.c:
4078 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4079 the account settings dialog.
4081 * src/modest-defs.h:
4082 * src/modest-account-mgr-helpers.h:
4083 * src/modest-account-mgr-helpers.c:
4084 (modest_server_account_get_option_secure_auth),
4085 (modest_server_account_set_option_secure_auth):
4086 * src/modest-account-mgr.c:
4087 (modest_account_mgr_add_server_account):
4088 Use the existing AUTH_MECH conf key for the secure-auth setting,
4089 instead of putting it in the list options, because this was actually used already.
4091 * src/maemo/modest-account-settings-dialog.c:
4092 (create_page_account_details),
4093 (modest_account_settings_dialog_set_account_name),
4094 (save_configuration):
4095 * src/maemo/modest-account-settings-dialog.h:
4096 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4097 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4099 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4101 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4102 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4103 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4105 * src/modest-defs.h:
4106 * src/maemo/modest-account-settings-dialog.c:
4107 (create_page_incoming), (on_combo_outgoing_security_changed),
4108 (on_combo_incoming_security_changed), (create_page_outgoing),
4109 (modest_account_settings_dialog_set_account_name),
4110 (save_configuration): Load/Save the port number, and change it when the
4111 security combo changes, to suitable defaults.
4113 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4115 * src/modest-account-mgr.c:
4116 (modest_account_mgr_add_server_account): Set the security and secure-auth
4117 options, and add a comment saying that the other camel-specific options should be
4120 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4122 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4124 * src/modest-tny-account-store.c: (account_list_free),
4125 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4126 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4129 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4131 * src/modest-protocol-info.c:
4132 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4133 is required by our UI spec. Maybe something in our implementation will use this eventually.
4134 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4135 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4136 instead of the previous 0 placeholder.
4138 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4139 secure-auth settings.
4140 * src/modest-account-mgr-helpers.h:
4141 * src/modest-account-mgr-helpers.c:
4142 (modest_server_account_data_get_option_secure_auth),
4143 (modest_server_account_set_option_secure_auth),
4144 (modest_server_account_data_get_option_security),
4145 (modest_server_account_set_option_security): Added this API for getting and setting the security
4146 and secure-auth settings.
4148 * src/maemo/modest-account-settings-dialog.h:
4149 * src/maemo/modest-account-settings-dialog.c:
4150 (modest_account_settings_dialog_finalize), (check_data),
4151 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4152 about changing titles.
4153 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4154 (save_configuration): Save the security and secure-auth settings.
4156 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4157 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4159 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4161 * src/modest-defs.h:
4162 * src/modest-account-mgr.c:
4163 (modest_account_mgr_add_server_account):
4164 Added and used defines for the options key and value pair strings,
4165 that are used so far, though they do not seem to correspond to anything in our
4166 UI specs or ModestProtocol enum.
4168 * src/modest-account-mgr-helpers.h:
4169 * src/modest-account-mgr-helpers.c:
4170 (compare_option_strings_for_name),
4171 (modest_server_account_data_get_option_value),
4172 (modest_server_account_data_get_option_bool),
4173 (modest_account_mgr_get_server_account_option):
4174 Added helper functions for parsing the options GSList.
4176 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4178 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4179 display name is based on the supplied account name.
4180 * src/modest-account-mgr.c:
4181 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4182 with an inefficient, but good-enough, implementation.
4184 * src/maemo/easysetup/modest-easysetup-wizard.c:
4185 (create_page_account_details), (on_before_next), (create_account):
4186 Check for existing display names rather than (non-user-visible) account names, and just
4187 create and set a unique account name at the end.
4189 * src/maemo/modest-account-settings-dialog.c:
4190 (modest_account_settings_dialog_init),
4191 (modest_account_settings_dialog_set_account_name),
4192 (create_page_incoming): Show the display name, instead of the account name.
4193 (on_response): Do some (not all) extra checks, as in the UI spec.
4194 (save_configuration): Save the display name if it was changed.
4196 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4198 * po/en_GB.po: Added needed logical ID and translation.
4199 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4200 (init_view): Made the is-default column clicking work.
4202 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4205 * src/maemo/easysetup/Makefile.am:
4206 * src/maemo/easysetup/modest-easysetup-wizard.c:
4207 (modest_easysetup_wizard_dialog_init):
4208 * src/maemo/easysetup/provider-data-test.keyfile:
4209 * src/maemo/easysetup/provider-data.keyfile:
4210 Moved the provider data file to the new modest-providers-data package and used it from there.
4212 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4214 * src/modest-local-folder-info.c:
4215 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4216 N_() was already used on the static strings, but this just marks it for translation without
4217 using the translation.
4219 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4221 * src/maemo/modest-account-settings-dialog.c:
4222 (create_page_incoming),
4223 (modest_account_settings_dialog_set_account_name):
4224 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4225 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4226 I will do this if nobody else gets there first.
4228 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4230 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4231 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4232 save the security stuff.
4234 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4236 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4237 Set the email address and user fullname, which I now see must be
4240 * src/maemo/modest-account-settings-dialog.h:
4241 * src/maemo/modest-account-settings-dialog.c:
4243 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4244 leave-on-server and authentication.
4245 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4248 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4251 * src/maemo/modest-account-settings-dialog.c:
4252 * src/maemo/modest-account-settings-dialog.h:
4253 Most (but not all) of the widgets are now present as specified by the UI spec.
4254 No changes are yet saved, and some details are not properly shown yet.
4256 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4258 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4260 * src/maemo/Makefile.am:
4261 * src/maemo/modest-account-settings-dialog.c:
4262 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4263 an existing account. Doesn't do much yet.
4265 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4266 Open the accounts settings dialog when Edit is clicked.
4268 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4270 * src/maemo/easysetup/Makefile.am:
4271 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4273 * src/maemo/easysetup/modest-easysetup-wizard.c:
4274 (modest_easysetup_wizard_dialog_init):
4275 Try to get the source directory from the build system,
4276 instead of hard-coding "./" into the source code, when opening our local
4277 copies of the configuration files.
4278 But this still fails when opening the wizard from the Accounts window,
4279 maybe because the working directory seems to change at runtime.
4280 So the wizard will fail the second time unless you copy the files into their
4281 proper locations - see the stdout warnings for the paths.
4283 (create_page_account_details),(on_before_next):
4284 Check for existing non-server accounts instead of server accounts,
4285 so the default account name is useful again, and to prevent trying to
4288 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4289 Show the wizard when New is clicked.
4291 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4292 (init_view): Show the column headers, and show the columns that are
4293 specified in the UI specs. However, something in Maemo's GTK+ prevents
4294 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4295 change the default account. This is despite unsetting the special properties.
4297 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4299 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4300 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4301 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4302 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4303 to make that clearer.
4304 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4306 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4308 * src/maemo/modest-account-view-window.c:
4309 (modest_account_view_window_init),
4310 (modest_account_view_window_new):
4311 Use the same buttons as specified in the
4312 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4313 the existing widgets, which never had a chance of working.
4314 Put the ModestAccountView treeview in a scrolled window.
4315 Do not repeat the initialization in both _init() and _new().
4317 * src/widgets/modest-account-view.c: (update_account_view):
4318 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4319 this widget and window shows no accounts.
4321 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4323 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4325 * src/maemo/easysetup/modest-easysetup-wizard.c:
4326 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4327 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4328 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4331 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4332 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4333 accounts exist yet, as in the UI spec.
4335 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4337 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4339 * src/maemo/Makefile.am:
4340 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4341 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4342 New window for editing connection-specific smtp details.
4343 Not fully implemented.
4345 * src/maemo/modest-connection-specific-smtp-window.c:
4346 (modest_connection_specific_smtp_window_finalize) :
4347 unref the tree model.
4348 (on_button_edit): Show the edit window.
4350 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4352 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4355 * src/maemo/Makefile.am:
4356 * src/maemo/modest-connection-specific-smtp-window.c:
4357 * src/maemo/modest-connection-specific-smtp-window.h:
4358 New window for showing the list of connections, for connection-specific
4359 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4360 * src/maemo/easysetup/modest-easysetup-wizard.c:
4361 (create_page_custom_outgoing): Show the new window when the button is clicked.
4363 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4365 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4366 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4367 * src/maemo/modest-msg-edit-window.c:
4368 (modest_msg_edit_window_insert_image):
4369 * src/modest-conf.c: (modest_conf_key_escape):
4370 * src/modest-mail-operation.c:
4371 (modest_mail_operation_send_new_mail):
4372 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4373 (modest_ui_actions_on_new_account):
4374 * src/widgets/modest-attachment-view.c: (update_filename_request):
4375 * src/widgets/modest-mail-header-view.c:
4376 Corrected warnings that were breaking the build, by commenting out unused variables,
4377 and a function, and by including a header.
4379 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4381 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4382 so we can #ifdef around platform-specific code when necessary.
4383 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4384 to allow this to build for the GNOME platform too.
4386 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4388 * src/maemo/easysetup/modest-easysetup-wizard.c:
4389 Added util_increment_name() and used it in create_page_account_details()
4390 to make sure that the default account name is always a new name.
4392 (modest_easysetup_wizard_dialog_init),
4393 (set_default_custom_servernames): Some minor memory management fixes.
4395 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4399 * src/modest-runtime.c: (init_i18n): Restored the translation
4400 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4401 are defined in config.h, and the translations are installed.
4403 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4404 is defined for translation.
4406 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4408 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4410 * src/maemo/easysetup/modest-easysetup-wizard.c:
4411 (modest_easysetup_wizard_dialog_init):
4412 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4413 Use realistic paths (though they should use $prefix generically) to the
4414 mcc_mapping and provider-data.keyfile files which might work when they
4415 are installed by the future version of the operator-wizard package,
4416 and then fallback to paths in our source code, with an explanatory
4419 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4423 * src/maemo/Makefile.am:
4424 * src/maemo/easysetup/: Added files from the previously-exernal
4425 osso-modest-easysetup.
4426 * src/maemo/modest-main-window-ui.h:
4427 * src/modest-ui-actions.c:
4428 * src/modest-ui-actions.h:
4429 Added modest_ui_actions_on_new_account() as a signal handler for the
4430 New Account menu item. It shows the easysetup wizard.
4431 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob