1 2007-07-18 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
4 the dialog close after entering an invalid port number and clicking
5 OK. This fixes projects.maemo.org bug NB#63602.
7 2007-07-18 Armin Burgmeier <armin@openismus.com>
9 * src/modest-tny-account-store.c:
10 (get_server_accounts): Set parent modest account name for each
11 connection-specific transport account so that special folders of such
12 an account can be looked up. This fixes a crash when changing account
13 settings. This might also be related to projects.maemo.org bug
16 2007-07-16 Armin Burgmeier <armin@openismus.com>
18 * src/modest-ui-actions.c: Added a button to create a folder to the
19 move-to dialog. This fixes projects.maemo.org bug NB#.
21 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
23 * src/maemo/easysetup/modest-easysetup-wizard.c:
24 Added scrollbars to account wizard dialog.
25 Fixed projects.maemo.org NB #62744
27 2007-07-16 Murray Cumming <murrayc@murrayc.com>
29 * src/widgets/modest-msg-view.h:
30 * src/widgets/modest-msg-view.c:
31 Added modest_msg_view_get_message_is_empty() but this needs
33 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
34 Check if there is any text in the message yet.
35 But this needs to be implemented properly.
36 (modest_msg_edit_window_toggle_find_toolbar):
37 * src/maemo/modest-msg-view-window.c:
38 (modest_msg_view_window_toggle_find_toolbar):
39 Show a banner warning if there is no text to search, when
40 trying to start a search. This partially fixes
41 projects.maemo.org bug NB#62350.
43 2007-07-13 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-mail-operation.c: (update_account_thread):
46 Initialized num_new_headers to fix the build.
48 2007-07-13 Murray Cumming <murrayc@murrayc.com>
50 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
51 Ignore modest accounts whose server accounts don't exist in gconf.
52 This prevents us trying to create TnyAccount instances for those
53 server accounts when the server account has been removed from gconf,
54 but the parent modest account has not yet been removed from modest.
55 I don't know why this is only noticeable now. It was probably just
56 a harmeless g_warning() anyway.
58 2007-07-13 Murray Cumming <murrayc@murrayc.com>
60 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
61 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
63 2007-07-12 Armin Burgmeier <armin@openismus.com>
65 * src/maemo/modest-main-window.c: Make default account appear bold
66 in view, tools/send & receive and toolbar/send & receive SCM menus.
67 This fixes projects.maemo.org bug NB#59010.
69 2007-07-12 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
72 Add a short-cut, by checking if the folder store is an account.
73 This ensures that the Sort menu item and toolbar is dimmed for
74 the local-folders account root item, fixing
75 projects.maemo.org bug NB#62545.
77 2007-07-12 Murray Cumming <murrayc@murrayc.com>
79 * src/modest-tny-account-store.c: (get_password):
80 Show the password dialog (via the signal) only in the mainloop, via
81 an idle handler that we wait for. This could theoretically prevent
82 hangs, though I worry that it could introduce some too.
84 2007-07-12 Murray Cumming <murrayc@murrayc.com>
86 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
87 * src/maemo/modest-platform.c:
88 (modest_platform_connect_and_wait):
89 Take a TnyAccount* parameter and try to set it to online
90 (a TnyCamel-only API), because tinymail sets accounts to offline
91 when the user cancels a password dialog, and doesn't ask again until
92 it has been set to online.
93 However, this is commented out because it causes a hang now.
95 (modest_platform_connect_and_wait_if_network_account):
96 * src/modest-mail-operation.c:
97 (modest_mail_operation_update_account):
98 * src/modest-platform.h:
99 * src/modest-ui-actions.c: (_modest_ui_actions_open),
100 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
102 2007-07-12 Armin Burgmeier <armin@openismus.com>
104 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
106 * src/modest-mail-operation.c:
107 * src/modest-ui-actions.c: Check for already existing folder before
108 querying the server, show error message from camel if the request
109 still fails. This fixes projects.maemo.org bug NB#58701.
111 2007-07-12 Murray Cumming <murrayc@murrayc.com>
113 * src/modest-tny-account-store.h:
114 * src/modest-tny-account-store.c:
115 Added modest_tny_account_store_forget_password_in_memory(),
116 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
117 when creating a new account, so that new passwords will be used, instead of
118 us thinking that it's a second request as a result of a failed password again.
120 2007-07-12 Murray Cumming <murrayc@murrayc.com>
122 * src/dbus_api/modest-dbus-callbacks.c:
123 (on_idle_open_message): If the message is in drafts then open it
124 in an edit window instead of a view window. This fixes
125 projects.maemo.org bug NB#63005.
127 2007-07-12 Murray Cumming <murrayc@murrayc.com>
129 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
130 Avoided a harmless g_warning().
132 2007-07-12 Murray Cumming <murrayc@murrayc.com>
134 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
135 Pass the modest account name, not the TnyAccount display name to
136 modest_msg_view_window_new() so that the reply feature works,
137 fixing projects.maemo.org bug NB#62892.
139 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
140 (modest_msg_view_window_new_with_header_model):
141 * src/maemo/modest-msg-view-window.c:
142 (modest_msg_view_window_new_with_header_model),
143 (modest_msg_view_window_new):
144 * src/modest-ui-actions.c: (reply_forward):
145 * src/widgets/modest-msg-view-window.h:
146 * src/widgets/modest-window.c: (modest_window_set_active_account):
147 Rename an account parameter to modest_account_name to make this clearer.
149 2007-07-11 Murray Cumming <murrayc@murrayc.com>
151 * src/modest-ui-actions.h:
152 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
153 modest_do_message_delete().
154 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
155 Call modest_do_message_delete(), hoping that this would cause messages
156 to be really deleted from search instead of just marked with strike through.
157 Does not seem to help.
159 2007-07-11 Armin Burgmeier <armin@openismus.com>
161 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
162 priv->reselect to FALSE prior to calling
163 modest_folder_view_select_first_inbox_or_local() to prevent endless
164 recursion and thus a crash on startup.
166 2007-07-11 Armin Burgmeier <armin@openismus.com>
168 * src/maemo/modest-account-settings-dialog.h: Include
169 <gtk/gtknotebook.h> to fix the build (at least for me).
171 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
172 Use "New FolderN" as default suggested name if "New folder" already
173 exists, with N being the first free number, though never exceed "New
174 folder99" in which case we just fall back to "New Folder" even though
175 it already exists. This fixes projects.maemo.org bug NB#58663.
177 2007-07-11 Murray Cumming <murrayc@murrayc.com>
179 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
180 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
181 projects.maemo.org bug NB#62778.
183 2007-07-11 Murray Cumming <murrayc@murrayc.com>
185 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
186 Ignore the wrong (for now) secure-smtp setting in the presets -
187 just default to requiring secure authentication for SMTP, because
190 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
192 * src/widgets/modest-folder-view.c: (filter_row)
193 Do not show drafts folder (see UI specs)
195 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
197 * src/modest-ui-actions.c:
198 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
199 place and also not necessary.
201 * src/widgets/modest-folder-view.c: (filter_row)
202 Guess folder type and hide Sent & Outbox if necessary.
203 Fixed project.maemo.org NB#57328
205 2007-07-11 Murray Cumming <murrayc@murrayc.com>
207 * src/modest-ui-actions.h:
208 * src/modest-ui-actions.c:
209 (modest_ui_actions_on_delete_message):
210 Move some code into a new
211 modest_ui_actions_refresh_message_window_after_delete()
212 function so we can use it from elsewhere.
214 * src/dbus_api/modest-dbus-callbacks.c:
215 (on_idle_delete_message), (on_delete_message): Used an idle
216 handler, as we do for the other D-Bus method handlers.
217 Call modest_ui_actions_refresh_message_window_after_delete()
218 if the deleted message was open in a window. This fixed
219 projects.maemo.org bug NB#62862.
221 2007-07-11 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-main.c: (main): Only show the UI at the start if
224 the showui command line option was given. For instance,
225 run-standalone src/modest showui
226 Otherwise, we wait for the top_application D-Bus method to
227 be sent by hildon-desktop when the application is selected
229 This allows us to run without a UI when osso-global-search
230 uses our D-Bus methods.
232 2007-07-11 Murray Cumming <murrayc@murrayc.com>
234 * src/dbus_api/modest-dbus-api.h: Added a define for a
235 top-application D-Bus method.
236 * src/dbus_api/modest-dbus-callbacks.c:
237 (on_top_application),
238 (modest_dbus_req_handler): Handle the top-application D-Bus
239 method, which might be an undocumented D-Bus signal sent by
240 hildon-desktop when it starts the application from the menu.
241 But I am not sure and I need to test it on the device, because
242 my scratchbox does not have the application in the menu now.
243 This method shows the main window, so that it can be invisible
244 when started, for instance, just for email searching from
247 * src/maemo/modest-main-window.c: (restore_settings),
248 (modest_main_window_new): Do not show the window immediately
249 upon creation. We show it later.
250 * src/modest-widget-memory.c: (save_settings_paned):
251 Try (unsuccessfully) to avoid saving the paned position when
252 it is not even visible.
253 (restore_settings_paned): Do not allow a silly paned position.
254 This seems necessary when not showing the window at first.
256 * tests/dbus_api/Makefile.am:
257 * tests/dbus_api/test_top_application.c: (main): Test for the
260 2007-07-10 Murray Cumming <murrayc@murrayc.com>
262 * src/modest-ui-dimming-rules.c:
263 (modest_ui_dimming_rules_on_new_msg),
264 (modest_ui_dimming_rules_on_reply_msg),
265 (modest_ui_dimming_rules_on_delete_msg),
266 (modest_ui_dimming_rules_on_details),
267 (modest_ui_dimming_rules_on_view_window_move_to),
268 (modest_ui_dimming_rules_on_view_previous),
269 (modest_ui_dimming_rules_on_view_next),
270 (_invalid_folder_for_purge): Added checks before
271 casting the window. This looks like an actual
272 logic error in _invalid_folder_for_purge(), because it
273 tries to use a ModestMainWindow as a message window.
275 2007-07-10 Murray Cumming <murrayc@murrayc.com>
277 * src/maemo/modest-account-settings-dialog.c:
278 (show_error): Use the same implementation as in
279 modest-easysetup-wizard.c:
280 (on_entry_invalid_character): The logical ID contains a %s.
281 Guessed what it should be.
282 (on_entry_max), (check_data), (on_response): Adapt to
283 changed show_error().
284 (create_page_account_details): Really call
285 modest_validating_entry_set_func() on the correct widgets.
286 * src/maemo/easysetup/modest-easysetup-wizard.c:
287 (on_entry_invalid_character): Fix the logical ID here too.
288 (create_page_account_details),
289 (create_page_user_details):
291 modest_validating_entry_set_func() on the correct widgets.
293 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
294 Do not try to use the account if it is NULL.
296 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
298 * src/modest-ui-actions.c: (create_move_to_dialog),
299 (modest_ui_actions_on_main_window_move_to),
300 (modest_ui_actions_on_msg_view_window_move_to):
301 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
302 (filter_row), (modest_folder_view_show_non_move_folders):
303 * src/widgets/modest-folder-view.h:
305 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
306 the Sent folder yet as it does not report the correct folder type.
308 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
310 * src/maemo/modest-msg-edit-window.c: (init_window):
313 2007-07-10 Murray Cumming <murrayc@murrayc.com>
315 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
316 Take a parent widget instead of a parent window, and
317 implement this with hildon_banner_show_information() instead.
318 Non-Maemo builds can just ifdef that there.
319 This fixed projects.maemo.org bug NB#62766.
321 (on_entry_invalid_character): Use show_error() again instead
322 of using hildon directly, and use the _CS() macro to use the correct
324 (create_account), (check_for_supported_auth_methods), (on_entry_max):
325 Pass a widget instead od a window to show_error().
327 2007-07-10 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
330 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
331 This allows us to show the server name in the error message, fixing
332 projects.maemo.org bug NB#62904.
333 Also, use the appropriate logical ID message for the account protocol.
335 2007-07-10 Murray Cumming <murrayc@murrayc.com>
337 * src/modest-tny-account-store.c: (on_idle_wrong_password):
338 A compilation fix, though the build wasn't broken for me.
340 2007-07-09 Murray Cumming <murrayc@murrayc.com>
342 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
343 Do not try to unref a NULL folder store, to avoid a runtime warning.
344 This seems to happen sometimes when changing accounts settings.
346 2007-07-09 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-tny-account-store.c:
349 (modest_tny_account_store_instance_init),
350 (modest_tny_account_store_finalize),
351 (on_account_settings_hide), (on_idle_wrong_password):
352 Use a GHashTable to ensure that we only show one account settings
353 dialog per modest account. This avoids us having a dialog open for
354 both the store and transport accounts, or due to repeated get_password()
355 calls that shouldn't happen anyway.
357 2007-07-09 Murray Cumming <murrayc@murrayc.com>
359 * src/maemo/modest-maemo-utils.c: (on_hide),
360 (modest_maemo_show_dialog_and_forget): Handle the response, because
361 the window is not even hidden by default.
363 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
364 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
365 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
366 which seems to prevent some modality problems.
368 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
369 Ignore user cancellation errors.
371 * src/modest-account-mgr-helpers.h:
372 * src/modest-account-mgr-helpers.c:
373 Added modest_server_account_get_password() and
374 modest_server_account_get_has_password() to avoid direct use of
377 * src/maemo/modest-account-settings-dialog.h:
378 * src/maemo/modest-account-settings-dialog.c:
379 (modest_account_settings_dialog_init): Store the notebook so we can
381 Added modest_account_settings_dialog_switch_to_user_info().
383 * src/modest-tny-account-store.c:
384 (get_password): When the password in the account settings is wrong (we think),
385 show the relevant page of the account settings dialog, in the mainloop.
386 However, we currently get many of these at once because cancel does not
388 (forget_password): Do not forget the password
389 from the account settings, because this causes side-effects when
390 tinymail seems to call it at strange time, maybe because of how we
391 are cancelling get_password().
392 (modest_tny_account_store_alert): Ignore user cancellations.
394 2007-07-09 Murray Cumming <murrayc@murrayc.com>
396 * src/maemo/modest-maemo-utils.h:
397 * src/maemo/modest-maemo-utils.c:
398 Added modest_maemo_show_information_note_and_forget() for use instead of
399 gtk_dialog_run() when the response is not needed, to avoid an extra
400 mainloop which could cause a hang.
402 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
403 Use the logical IDs for the error message, though they are not
404 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
405 because gtk_dialog_run() caused a hang here (the window did not close).
406 This fixes projects.maemo.org bug NB#62646.
408 2007-07-09 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-account-mgr-helpers.h:
411 * src/modest-account-mgr-helpers.c:
412 Added modest_account_mgr_get_store_protocol().
414 * src/maemo/modest-account-view-window.c:
415 (on_delete_button_clicked): Show different warning text depending on
416 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
417 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
420 2007-07-09 Murray Cumming <murrayc@murrayc.com>
422 * src/maemo/modest-msg-edit-window.c:
423 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
424 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
426 2007-07-07 Armin Burgmeier <armin@openismus.com>
428 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
429 ckdg_ib_maximum_characters_reached from correct package.
431 * src/modest-ui-actions.c: Show an error message when a folder could
432 not be created. Tinymail does not give us specific error codes about
433 what has gone wrong, so we assume that a folder with that name
434 already exists, though there might be other reasons.
436 2007-07-06 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
439 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
440 give a more exact error message that can be partly translated.
442 2007-07-05 Murray Cumming <murrayc@murrayc.com>
444 * src/maemo/modest-address-book.c:
445 (select_email_addrs_for_contact): Specify a default window size for the
446 select-email-address dialog, so that it is probably big enough for the
447 title. This should fix projects.maemo.org bug NB#62277.
449 2007-07-05 Murray Cumming <murrayc@murrayc.com>
451 * src/maemo/easysetup/modest-easysetup-wizard.c:
452 (create_page_complete_easysetup): Use
453 gtk_widget_set_size() request to ensure that the text wraps
456 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
458 * src/maemo/easysetup/modest-easysetup-wizard.c:
459 (on_entry_invalid_character), (create_page_account_details),
460 (create_page_user_details):
461 Use new API of ModestValidatingEntry. But for some reason the banner is
462 not shown. I will have to investigate that further.
464 * src/widgets/modest-validating-entry.c: (on_insert_text),
465 (modest_validating_entry_set_func):
466 * src/widgets/modest-validating-entry.h:
467 Added a new callback function to be able to react to prevented
468 characters whitespaces to e.g show a banner.
470 2007-07-05 Armin Burgmeier <armin@openismus.com>
472 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
473 notification of HildonNumberEditor instead of remembering the port
474 number. Thanks to Johannes for pointing this out.
476 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
478 * src/maemo/easysetup/modest-easysetup-wizard.c:
479 Check if there are any user changes before showing a confirmation
480 dialog (projects.maemo.org NB#60946)
482 2007-07-05 Armin Burgmeier <armin@openismus.com>
484 * src/maemo/modest-account-settings-dialog.c: Remember custom port
485 number at the beginning of the dialog and set the modified flag at the
486 end if the port number has changed. This is necessary because
487 HildonNumberEditor does not support notification when the value has
490 2007-07-05 Murray Cumming <murrayc@murrayc.com>
492 * src/modest-ui-actions.c:
493 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
494 a connection before asking anything else. Correct the check for the destination
495 folder so that it succeeds when online.
496 This fixed projects.maemo.org bug NB#61645.
498 2007-07-05 Murray Cumming <murrayc@murrayc.com>
500 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
501 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
502 to fix projects.maemo.org bug NB#62439.
504 2007-07-05 Murray Cumming <murrayc@murrayc.com>
506 * src/modest-tny-account.c: (on_connection_status_changed):
507 Really do not use tny_device_force_offline() here. See the previous comment.
509 2007-07-04 Murray Cumming <murrayc@murrayc.com>
511 * src/modest-tny-account.c: (on_connection_status_changed):
512 Do not use tny_device_force_offline() when tinymail says that something
513 went wrong with the connection. It seems to report this unnecessarily.
515 2007-07-04 Murray Cumming <murrayc@murrayc.com>
517 * src/maemo/modest-connection-specific-smtp-window.c:
518 (modest_connection_specific_smtp_window_init):
519 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
520 does not seem to have any effect in osso 1.1 (though it works in
521 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
523 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
525 * src/maemo/modest-connection-specific-smtp-window.c:
526 Fix UI specification problems with projects.meamo.org NB#60479
528 2007-07-04 Murray Cumming <murrayc@murrayc.com>
530 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
531 clue when this has failed, because the error dialog is not always shown
532 (at least in earlier version).
534 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
535 GError message, because the generic error dialog is not helpful.
537 'This message is not currently available (can't let a new connection go online)'
538 when trying to open an IMAP message.
540 (_modest_ui_actions_open): Offer a connection when some messages would
541 have to be downloaded and we are offline.
543 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
545 * src/widgets/modest-folder-view.c:
546 Don't check for MERGE type anymore as we use the correct type
548 NOTE: For the last two changes you need to update your tinymail copy
549 because of API changes!
551 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
553 * src/modest-tny-local-folders-account.c:
554 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
555 (see projects.maemo.org NB#61580)
557 2007-07-04 Murray Cumming <murrayc@murrayc.com>
559 * src/modest-tny-account.c: (on_connection_status_changed):
560 Commented out the call to modest_platform_connect_and_wait() because this
561 seems to always hang, and I would like to know if this is the only thing
562 that causes a hang when showing the connection dialog.
563 It is not very useful anyway.
565 2007-07-04 Murray Cumming <murrayc@murrayc.com>
567 * src/maemo/modest-msg-view-window.c:
568 (modest_msg_view_window_select_next_message):
570 * src/modest-platform.h:
571 * src/maemo/modest-platform.c:
572 Added modest_platform_connect_and_wait(), which calls
573 tny_maemo_conic_device_connect() always in the main thread, by calling it
574 in an idle handler and waiting for the idle handler to run. It should be
575 in the main thread because it uses GTK+ UI code. It just returns TRUE
576 if the device is already online.
578 There is some nasty code to ensure that subsequent calls to
579 modest_platform_connect_and_wait() just wait for the first one to finish,
580 by checking repeatedly in another idle handler. This is necessary,
581 because other threads (or even the main thread, via another idle handler)
582 can call modest_platform_connect_and_wait() while
583 modest_platform_connect_and_wait() is running.
585 (modest_platform_connect_and_wait_if_network_account),
586 (modest_platform_connect_and_wait_if_network_folderstore):
587 Convenience functions that calls modest_platform_connect_and_wait() if
588 the account or folder might want network access.
590 * src/modest-mail-operation.c:
591 (modest_mail_operation_update_account):
592 * src/modest-ui-actions.c: (download_uncached_messages),
593 (modest_ui_actions_on_rename_folder), (delete_folder),
594 (modest_ui_actions_on_main_window_move_to),
595 (modest_ui_actions_on_msg_view_window_move_to):
596 * src/widgets/modest-folder-view.c:
597 (drag_and_drop_from_folder_view):
598 Offer a connection if we are offline.
600 * src/modest-tny-account.c: (on_connection_status_changed):
601 Document this as only handling errors during network operations in progress,
602 and replace the idle code with a simple call to
603 modest_platform_connect_and_wait(), which does this instead.
605 2007-07-03 Murray Cumming <murrayc@murrayc.com>
607 * src/modest-tny-account.c:
608 (modest_tny_account_get_special_folder): (util_on_idle),
609 Handle the GError so we can see when tny_folder_store_get_folders()
610 fails, as it currently does while something else is connecting.
612 Added util_run_in_main_thread_and_wait()
613 which uses an idlen handler and mainloop to ensure that the function
614 is called in the main thread.
615 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
616 to make sure that we call attempt the connection in the mainloop only,
617 which might solve some hangs.
619 2007-07-03 Murray Cumming <murrayc@murrayc.com>
621 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
622 be found by their display name. This is never useful.
623 * src/modest-tny-account-store.c: (on_account_removed): Find the account
624 by its ID, instead of trying to use its ID as its display name.
626 * src/modest-tny-account-store.h:
627 * src/modest-tny-account.c:
628 (modest_tny_account_get_special_folder): Add a g_warning() when
629 tny_folder_store_get_folders() returns an empty list for the maildir.
631 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
632 Add a g_warning() when this returns NULL, because that it not allowed
635 2007-07-02 Armin Burgmeier <armin@openismus.com>
637 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
638 note when trying to cancel the wizard. This fixes projects.maemo.org
641 2007-07-02 Murray Cumming <murrayc@murrayc.com>
643 * src/modest-tny-account.h:
644 * src/modest-tny-account.c:
645 (modest_tny_account_new_from_server_account),
646 (modest_tny_account_new_from_server_account_name),
647 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
648 because this must now be set before setting the proto. This is usd in
649 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
650 warning in camel_session_get_service() caused by
651 tny_camel_transport_account_prepare().
653 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
656 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
658 * src/maemo/modest-connection-specific-smtp-edit-window.c:
660 (modest_connection_specific_smtp_edit_window_init):
662 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
665 2007-06-29 Murray Cumming <murrayc@murrayc.com>
667 * src/modest-tny-account.c:
668 (modest_tny_account_new_from_server_account):
669 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
670 now uses to request a connection when it needs one, and which it uses
671 to tell us that something is wrong with the connection, so we can force
672 the accounts offline to prevent further problems.
675 * src/modest-init.c: (init_default_settings):
676 * src/modest-mail-operation.c:
677 (modest_mail_operation_update_account):
678 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
679 This should not be necessary anymore. Do not set the conf key that
680 determined this (it was always TRUE and not set anywhere else).
682 * src/modest-ui-actions.h: Remove unused and unimplemented
683 modest_ui_actions_on_online_toggle_toggled().
685 2007-06-29 Murray Cumming <murrayc@murrayc.com
687 * src/maemo/modest-main-window.c: (connect_signals):
688 Don't connect to delete_event twice. Maybe this was harmless.
690 2007-06-29 Murray Cumming <murrayc@murrayc.com
692 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
693 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
694 Debug output to give some more clue when a folder move is not allowed.
696 2007-06-28 Murray Cumming <murrayc@murrayc.com
698 * src/modest-tny-account.c: (on_modest_file_system_info),
699 (modest_tny_account_get_mmc_account_name):
700 Always call the callback, without checking whether the name has changed.
701 * src/widgets/modest-folder-view.c: (strings_are_equal),
702 (on_model_foreach_set_name), (on_get_mmc_account_name),
703 (text_cell_data): Compare the name here, and use the name from
704 the account rather than from the
705 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
706 if the name was changed after the account was added to the model.
707 That's a tinymail bug but not one that I want to fix now.
709 This finally fixes projects.maemo.org bug NB#59301.
711 2007-06-27 Armin Burgmeier <armin@openismus.com>
713 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
716 2007-06-27 Murray Cumming <murrayc@murrayc.com
718 * src/modest-tny-account.h:
719 * src/modest-tny-account.c:
720 Added modest_tny_account_get_mmc_account_name(), to set the memory
721 card name asynchronously for the given account and then notify.
722 (modest_tny_account_new_for_local_folders): Use this new function instead
723 of using hildon_file_system_info_async_new() directly.
725 * src/widgets/modest-folder-view.c: (text_cell_data):
726 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
727 gtk_tree_model_row_changed() when it is available.
729 This should fix projects.maemo.org bug NB#59301.
731 2007-06-27 Murray Cumming <murrayc@murrayc.com
733 * src/modest-mail-operation.c: (update_account_thread),
734 (get_msgs_full_thread): Fix typo failures in the revert
737 2007-06-27 Murray Cumming <murrayc@murrayc.com
739 * src/maemo/modest-maemo-global-settings-dialog.c:
740 (idle_select_default_focus):
741 * src/modest-mail-operation.c: (idle_notify_progress),
742 (idle_notify_progress_once), (set_last_updated_idle),
743 (update_account_thread), (get_msgs_full_thread):
744 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
745 * src/widgets/modest-header-view.c:
746 (idle_notify_headers_count_changed_destroy),
747 (idle_notify_headers_count_changed):
748 Reverted the additions of gdk_threads_enter/leave(), in case this
749 helps with a startup hang on the device.
751 2007-06-26 Armin Burgmeier <armin@openismus.com>
753 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
754 for supported secure authentication methods from server by
755 gtk_dialog_run(), saving CPU time and a potential race condition.
757 2007-06-26 Armin Burgmeier <armin@openismus.com>
759 * src/maemo/modest-maemo-utils.h:
760 * src/maemo/modest-maemo-utils.c: Added a
761 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
762 only error code to tell the calling code when the user canceled the
765 * src/maemo/modest-account-settings-dialog.h:
766 * src/maemo/modest-account-settings-dialog.c:
767 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
768 message if the retrieval of secure authentication methods was canceled
769 by the user. Perform the check before saving anything to configuration
770 to not end up with half-committed configuration changes, do not show
771 a "Saving to configuration failed" note when authentication methods
772 could not be retrieved.
774 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
777 2007-06-26 Murray Cumming <murrayc@murrayc.com>
779 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
780 Only return the first level of folders under accounts, because the
781 osso-global-search UI spec doesn't want the rest.
782 This fixed projects.maemo.org bug NB#61811.
784 2007-06-26 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-tny-account-store.c:
787 * src/modest-tny-account-store.h:
788 Added modest_tny_account_is_memory_card_account().
789 * src/maemo/modest-main-window.c: (create_details_widget):
790 Show the same information items for the memory card as we show for the
791 local-folders, to fix projects.maemo.org bug NB#59307.
793 2007-06-26 Murray Cumming <murrayc@murrayc.com>
795 * src/modest-tny-account-store.c: (get_password):
796 Added some checks for NULL to maybe prevent crashes, though I think
797 it was Philip's last commit that actually prevented the crash here
798 when creating a first new account.
799 But the new account is still not usable (no messages are shown)
800 until a restart of the application.
802 2007-06-26 Murray Cumming <murrayc@murrayc.com>
804 * src/maemo/modest-maemo-global-settings-dialog.c:
805 (idle_select_default_focus):
806 * src/modest-mail-operation.c: (idle_notify_progress),
807 (idle_notify_progress_once), (idle_notify_update_account_queue),
808 (set_last_updated_idle), (update_account_thread),
809 (notify_get_msgs_full), (get_msgs_full_destroyer),
810 (get_msgs_full_thread):
811 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
812 * src/widgets/modest-header-view.c:
813 (idle_notify_headers_count_changed_destroy),
814 (idle_notify_headers_count_changed):
815 Use gdk_threads_enter() and gdk_threads_enter_leave() in
816 all idle handlers, because some other thread could be blocking
817 the GDK lock, so that it can do GUI stuff.
819 2007-06-26 Murray Cumming <murrayc@murrayc.com>
821 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
822 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
823 (on_idle_send_receive), (on_idle_open_default_inbox):
824 * src/maemo/modest-msg-edit-window.c:
825 (modest_msg_edit_window_attach_file_noninteractive):
826 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
827 to prevent a hang. I don't quite understand why these are necessary,
828 beause we should already be in the main loop. I guess something outside
829 of the main loop is taking the lock.
831 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
832 we are really using URIs, and use files that are more likely to exist.
834 2007-06-26 Murray Cumming <murrayc@murrayc.com>
836 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
837 necessary because configure.ac now defines different variables.
839 2007-06-26 Murray Cumming <murrayc@murrayc.com>
841 * libmodest-dbus-client/libmodest-dbus-client.c:
842 * libmodest-dbus-client/libmodest-dbus-client.h:
843 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
844 libmodest_dbus_client_compose_mail() is what things actually use.
846 * src/dbus_api/modest-dbus-api.h:
847 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
848 * tests/dbus_api/Makefile.am:
849 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
852 2007-06-26 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-init.c: (modest_init_local_folders):
855 For memory-card (or other non local-folders) maildir accounts,
856 always create an Archive folder, so that there is somewhere to put
857 messages. This should be less confusing, because the user does not need
858 to guess that the need to create a folder.
860 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
862 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
863 Fixed icon size by using (50, 50) which is the same as defined by
866 2007-06-25 Armin Burgmeier <armin@openismus.com>
868 * src/widgets/modest-window-mgr.c:
870 * configure.ac: Correctly recognize hildon-notify presence and fixed
871 the build without it being installed.
873 2007-06-25 Murray Cumming <murrayc@murrayc.com>
875 * libmodest-dbus-client/libmodest-dbus-client.c:
876 (libmodest_dbus_client_search): Fix the build. Sorry.
877 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
878 (reply_forward_cb): Initialize variables to fix the build.
880 * src/modest-tny-account-store.c:
881 (modest_tny_account_store_get_tny_account_by): Fix the account URI
882 comparison (a silly typo) so that email search results can be opened
883 when there are more than one account.
885 2007-06-25 Murray Cumming <murrayc@murrayc.com>
887 * libmodest-dbus-client/libmodest-dbus-client.c:
888 (libmodest_dbus_client_search),
889 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
890 instead of 1 second, because the search gets folders and messages from
891 the server, which can take a long time. When it times out,
892 osso-global-search will report no results.
894 We need to specify whether we should search only cached information
895 (maybe with a user preference), and the osso-email-search-plugin
896 API should really be improved to allow that option, and to allow results
897 to be delivered asynchronously in batches.
899 2007-06-25 Murray Cumming <murrayc@murrayc.com>
901 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
902 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
903 GTK_ICON_SIZE_DIALOG is probably the wrong size.
905 2007-06-25 Murray Cumming <murrayc@murrayc.com>
907 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
908 that is an empty string. D-Bus seems to give us these instead of NULL.
910 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
912 * src/dbus_api/modest-dbus-callbacks.c:
913 * src/maemo/easysetup/modest-easysetup-wizard.h:
914 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
915 * src/maemo/modest-connection-specific-smtp-edit-window.c:
916 (modest_connection_specific_smtp_edit_window_init):
917 * src/maemo/modest-maemo-global-settings-dialog.c:
919 * src/maemo/modest-maemo-utils.c:
920 (modest_maemo_utils_setup_images_filechooser):
921 * src/maemo/modest-main-window.c: (create_details_widget):
922 * src/maemo/modest-msg-edit-window.c:
923 (modest_msg_edit_window_attach_file_noninteractive),
924 (modest_msg_edit_window_color_button_change),
925 (modest_msg_edit_window_set_zoom):
926 * src/modest-mail-operation.c: (update_account_thread):
927 * src/modest-tny-account-store.c:
928 * src/modest-tny-account.c:
929 * src/widgets/modest-global-settings-dialog.c:
930 * src/widgets/modest-window.h:
934 2007-06-25 Murray Cumming <murrayc@murrayc.com>
936 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
937 * src/modest-search.c: (modest_search_folder),
938 (modest_search_all_accounts): Actually search only in the specified folder,
939 doing a simple match on the folder ID.
940 * src/modest-search.h: Added a folder field to the ModestSearch struct,
941 and added some documentation.
943 2007-06-22 Armin Burgmeier <armin@openismus.com>
945 * src/maemo/modest-maemo-utils.h:
946 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
947 modest_maemo_utils_get_supported_secure_authentication_methods.
949 * src/maemo/easysetup/modest-easysetup-wizard.c:
950 * src/maemo/modest-account-settings-dialog.c: Show correct error if
951 one occured, not just "Server does not support secure authentication".
953 2007-06-22 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-tny-account-store.c: (get_password):
956 Restored the call to tny_account_set_user() because Philip seems to have
957 stopped this from crashing (by not using the freed string). It still does
958 not work, but now we can test it.
960 2007-06-22 Murray Cumming <murrayc@murrayc.com>
962 * src/maemo/modest-msg-edit-window.c: (init_window):
963 Comment out use of an uninitialzed GtkScrolledWindow variable,
964 to fix the build and stop a crash. Yet again.
966 2007-06-22 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-tny-account-store.c: (get_password):
969 Remove the call to tny_account_set_user() because this actually crashes.
970 As mentioned in the last commit, it is known to not work anyway.
972 2007-06-22 Murray Cumming <murrayc@murrayc.com>
974 * src/modest-tny-account-store.c: (get_password):
975 Use tny_account_set_username() to tell tinymail that the username might
976 have changed too. But tinymail ignores this: see projects.maemo.org
978 * src/modest-ui-actions.c:
979 (modest_ui_actions_on_password_requested): Remove the useless attempt to
980 reset the connection when changing the username, and improve the comments.
981 Save the changed username to gconf at least, so it is used when Modest is
984 2007-06-21 Murray Cumming <murrayc@murrayc.com>
986 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
987 Do not use a query, so that we get all folders, including for POP and
988 local-folders. They work as search criteria too.
989 This fixes projects.maemo.org bug NB#57740.
991 2007-06-21 Murray Cumming <murrayc@murrayc.com>
993 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
994 Comment out the use of hildon_notification_set_sound() because it is
995 not declared, to fix the build. Warnings are serious, people.
997 2007-06-21 Armin Burgmeier <armin@openismus.com>
999 * src/maemo/modest-maemo-utils.h:
1000 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1001 modest_maemo_utils_get_supported_secure_authentication_methods()
1002 to query authentication methods for a specific user. This should fix
1003 projects.maemo.org bug NB#61369.
1005 * src/maemo/easysetup/modest-easysetup-wizard.c:
1006 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1009 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1011 * libmodest-dbus-client/libmodest-dbus-client.h:
1012 * libmodest-dbus-client/libmodest-dbus-client.c:
1013 (modest_dbus_message_iter_get_search_hit),
1014 (libmodest_dbus_client_search):
1015 Reorganised and commented this.
1016 Removed modest_search_hit_free() from the public API because it
1019 Added libmodest_dbus_client_get_folders() and
1020 modest_folder_result_list_free().
1022 * src/dbus_api/modest-dbus-api.h:
1023 * src/dbus_api/modest-dbus-callbacks.c:
1024 (modest_dbus_req_filter): Commented. Moved most code to
1025 on_dbus_method_search() and added on_dbus_method_get_folders().
1027 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1028 of the extra D-Bus handler.
1030 * tests/dbus_api/Makefile.am:
1031 * tests/dbus_api/test_get_folders.c: New test for
1032 libmodest_dbus_client_get_folders(). This seems to return an empty list
1033 at the moment. That could be the same error that causes the message list
1034 to be empty sometimes.
1035 This should help with projects.maemo.org bug NB#57740.
1037 2007-06-21 Armin Burgmeier <armin@openismus.com>
1039 * src/modest-mail-operation.c: Do not call
1040 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1041 notify the operation's end after having set the status to CANCELED for
1042 the operation queue to listen on. This fixes a deadlock when there
1043 were mail operations in the queue during its finalization.
1045 * src/modest-singletons.c: Reordered uninitialization of the account
1046 manager to happen after the mail operation queue was uninitialized
1047 because the mail operation's in the queue might still try to access
1048 the account manager (see modest_mail_operation_notify_end()). This
1049 fixes a potential crash when terminating the application.
1051 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1053 * src/modest-search.c:
1054 (search_mime_part_and_child_parts): Moved some code here so we
1055 can search recursively in child folders.
1056 (modest_search_folder): Search in the message as a mime part, instead
1057 of just its child mime parts.
1058 (read_chunk), (search_mime_part_ogs):
1059 Check how many bytes were read, to prevent an endless loop.
1060 Searching in message bodies now works. This finishes the fix for
1061 projects.maemo.org bug NB#61007.
1063 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1066 Add a g_warning when the item is not a folder.
1068 * src/modest-ui-dimming-rules.c:
1069 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1070 when selected item is not a folder (for instance, an account), because
1071 the UI spec only talks about folders.
1072 I am not sure what the UI spec wants, so this might not totally fix
1073 projects.maemo.org bug NB#60794.
1075 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1077 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1078 (load_from_file): Sort the list. The unsorted list would be more noticeable
1079 in non-English locales.
1081 * src/maemo/modest-msg-edit-window.c:
1082 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1083 warning and fix the build.
1085 * src/maemo/modest-progress-bar-widget.c:
1086 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1087 avoid a g_warning, and probably to avoid a crash.
1089 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1091 * src/modest-search.c: (modest_search_folder): Check for a GError
1092 when calling tny_folder_get_headers(), to show that this is not the cause
1095 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1097 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1098 Actually set the body query instead of the subject query.
1100 * src/modest-search.c: (search_mime_part_ogs),
1101 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1102 which would probably cause it to fail if we got this far.
1104 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1105 to simplify the code.
1106 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1107 be causing search-in-body to fail.
1109 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1111 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1113 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1114 Better debug message when the folder cannot be found.
1115 This should help with fixing projects.maemo.org bug #61287.
1116 * src/modest-search.c: (add_hit): Do not leak the furl string.
1118 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1120 * src/modest-ui-actions.c:
1121 (modest_ui_actions_on_folder_selection_changed):
1122 Do not special-case TNY_MERGE_FOLDER here, because
1123 modest_tny_folder_get_account() already does that. This fixes
1124 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1125 shown when the Outbox was selected).
1127 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1129 * libmodest-dbus-client/libmodest-dbus-client.c:
1130 (_dbus_iter_get_string_or_null): Initialize the string variable in
1131 case this helps with Dirk's crash.
1133 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1135 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1136 though it is not implemented yet (this function is maybe not even used),
1137 to avoid breaking ABI in future.
1138 * libmodest-dbus-client/libmodest-dbus-client.c:
1139 (get_attachments_string): Moved some code into this generic function.
1140 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1141 sends email. It is maybe not used.
1142 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1143 (on_send_mail): Use attachments.
1145 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1146 * src/maemo/modest-msg-edit-window.c:
1147 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1148 a filename before using it, to fix projects.maemo.org bug NB#58233.
1150 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1152 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1153 Initialize the continue_download variable to fix the build, and probably
1154 to fix randome behaviour.
1156 2007-06-18 Armin Burgmeier <armin@openismus.com>
1158 * src/modest-tny-send-queue.h:
1159 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1160 the queue so we can later show it in the UI. Replaced
1161 modest_tny_send_queue_msg_is_being_sent() by
1162 modest_tny_send_queue_get_msg_status().
1164 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1166 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1167 gpointer. This probably was not harmful, but just to be sure.
1169 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1171 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1172 Fix the build, but leave the function broken on Bora, because
1173 hildon_uri_action_get_service() does not exist.
1174 osso_uri_action_get_service() does not exist either, it seems.
1176 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1178 * src/modest-tny-account.c:
1179 (modest_tny_account_new_from_server_account):
1180 Uncommented the url debug output again, because it is useful for
1181 debugging, as I said in the comment.
1183 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1185 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1187 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1188 for Mameo Bora, to fix the build.
1190 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1193 Fixed build with hildon < 0.99
1195 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1196 Check if the selected account is busy instead of checking all accounts
1198 * src/modest-account-mgr-priv.h:
1199 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1200 (modest_account_mgr_init), (compare_account_name),
1201 (modest_account_mgr_set_account_busy),
1202 (modest_account_mgr_account_is_busy):
1203 * src/modest-account-mgr.h:
1204 Added busy information to the account manager. It possible to
1205 set an account to busy or not busy now.
1207 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1208 (modest_mail_operation_update_account),
1209 (modest_mail_operation_notify_end):
1210 Set the account to busy/not busy depending on the operation state.
1212 * src/widgets/modest-account-view.c:
1213 (modest_account_view_finalize), (get_last_updated_string),
1214 (update_account_view), (on_account_busy_changed), (init_view):
1215 Show string "Refreshing..." if the account is currently busy.
1217 All this fixes projects.maemo.org bug NB#59711
1219 2007-06-14 Armin Burgmeier <armin@openismus.com>
1221 * src/widgets/modest-attachments-view.h:
1222 * src/widgets/modest-attachments-view.c: Added
1223 modest_attachments_view_has_attachments() and fixed coordinate
1224 transformation in get_att_view_at_coords(). This fixes attachment
1227 * src/widgets/modest-msg-view.c: Make use of
1228 modest_attachments_view_has_attachments() to decide whether to show
1229 attachments in the header.
1231 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1233 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1234 (on_change), (on_combo_security_changed),
1235 (modest_connection_specific_smtp_edit_window_init),
1236 (modest_connection_specific_smtp_edit_window_set_connection),
1237 (modest_connection_specific_smtp_edit_window_is_dirty):
1238 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1239 * src/maemo/modest-connection-specific-smtp-window.c:
1242 Show an comfirmation dialog for the smpt-edit-window if there are
1243 unsaved changes and the user hits cancel.
1244 (projects.maemo.org bug NB#60479)
1246 2007-06-14 Armin Burgmeier <armin@openismus.com>
1248 * src/maemo/easysetup/modest-easysetup-wizard.c:
1249 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1250 address" info in banner instead of node, and select all the text as
1251 per UI spec. This fixes projects.maemo.org bug NB#60550.
1253 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1255 reviewed by: <delete if not using a buddy>
1257 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1258 * src/modest-ui-actions.c: (folder_refreshed_cb):
1260 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1262 * src/widgets/modest-folder-view.c: (filter_row):
1263 Explictly filter out the per-account outbox accounts. I don't know why
1264 these only sometimes show up, but now they should never show up in the UI.
1265 This should fix projects.maemo.org bug NB#60160.
1267 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1269 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1270 when the toolbar does not exist yet.
1271 * src/modest-widget-memory.c: (save_settings_header_view):
1272 Added g_warnings() to help us to discover when we are trying to set
1273 an empty columns list in gconf.
1275 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1277 * src/modest-init.h:
1278 * src/modest-init.c:
1279 Added modest_init_get_default_header_view_column_ids().
1281 * src/modest-widget-memory.c: (restore_settings_header_view):
1282 Use the new function to get defaults, if the gconf key is empty,
1283 instead of not creating any columns. This seems to fix the
1284 empty right-hand pane problems.
1286 * src/widgets/modest-header-view.h: Improved documentation.
1288 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1290 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1291 Revert the use of the display name as the account name, because this
1292 is generally wrong and would break the code that follows.
1294 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1296 * src/maemo/easysetup/modest-easysetup-wizard.c:
1297 (check_for_supported_auth_methods), (on_before_next),
1300 More correct fix for projects.maemo.org bug NB# 58991
1301 Do not longer accept AUTH_PASSWORD as secure method and choose
1302 correct method when creating the account.
1304 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1306 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1307 Fixed projects.maemo.org bug NB# 58991
1309 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1311 * src/modest-init.c: (modest_init_init_core),
1312 (modest_init_local_folders): Fixed compilation errors.
1314 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1316 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1317 Remove unnecessary lib/include, though it is good in principle when needed.
1319 * src/modest-init.c: (modest_init_one_local_folder),
1320 (modest_init_local_folders):
1321 * src/modest-init.h: Initialize the .modest library for memory cards,
1322 instead of just doing nothing for them. This should allow us to create
1323 folders there, fixing projects.maemo.org bug NB#59297.
1325 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1327 * libmodest-dbus-client/libmodest-dbus-client.c:
1328 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1329 (libmodest_dbus_client_compose_mail),
1330 (libmodest_dbus_client_open_message),
1331 (libmodest_dbus_client_send_and_receive),
1332 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1334 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1335 (on_idle_open_message), (modest_dbus_req_handler),
1336 (search_result_to_message), (modest_dbus_req_filter):
1337 * src/modest-search.c: (add_hit), (modest_search_folder),
1338 (modest_search_all_accounts): Improved debug messages.
1340 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1342 * src/modest-tny-account-store.c:
1343 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1346 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1349 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1351 * src/modest-tny-account-store.c: (get_server_accounts):
1352 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1353 even when there are no accounts, so that the Outbox folder is always
1354 visible. This fixes projects.maemo.org bug NB#60158.
1356 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1358 * src/maemo/modest-main-window.c: (create_details_widget):
1359 Use the mcen_va_never logical ID.
1361 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1363 * src/dbus_api/modest-dbus-api.h:
1364 * src/dbus_api/modest-dbus-callbacks.c:
1365 (on_idle_open_default_inbox), (on_open_default_inbox),
1366 (modest_dbus_req_handler):
1367 Added a new OpenDefaultInbox method.
1369 * libmodest-dbus-client/libmodest-dbus-client.h:
1370 * libmodest-dbus-client/libmodest-dbus-client.c:
1371 Added libmodest_dbus_client_open_default_inbox() to call the new
1372 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1373 though it should maybe be used by a new osso-email-interface function.
1375 * tests/dbus_api/Makefile.am:
1376 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1379 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1381 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1382 NULL, so that the signals get all the keys. This should not actually
1383 change any behaviour because we currently update everything when anything
1386 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1388 * src/widgets/modest-folder-view.c: (text_cell_data),
1389 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1390 (find_inbox_iter): If tinymail tells us that the folder is
1391 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1392 This causes the inbox to be selected at startup, fixing part of
1393 projects.maemo.org bug NB#56305.
1395 * src/modest-ui-dimming-rules.c:
1396 (modest_ui_dimming_rules_on_tools_smtp_servers):
1397 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1398 the SMTP servers menu item.
1399 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1400 that the SMTP Servers menu item is dimmed when there are no accounts,
1401 as a future version of the UI spec will require. This fixes
1402 projects.maemo.org bug NB#56305.
1404 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1406 * src/maemo/modest-maemo-utils.c:
1407 (modest_maemo_utils_get_supported_secure_authentication_methods):
1408 Added label to dialog instead of unreadable title
1410 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1411 (modest_main_window_new):
1412 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1415 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1416 * src/modest-account-mgr.h:
1417 Added method to avoid code duplication
1419 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1420 (modest_ui_actions_on_send_receive):
1421 Use modest_account_mgr_has_accounts
1423 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/easysetup/modest-presets.c:
1426 (modest_presets_get_info_server_security): Do not report secure auth
1428 * src/modest-protocol-info.c: Use the defines for the gconf key names
1429 for secure authentication. This was not working because we were writing
1430 Password and reading password, and the check was case sensitive.
1431 With this, gmail now works for receiving and sending when created via
1434 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1436 * src/maemo/easysetup/modest-presets.c:
1437 (modest_presets_get_info_server_security): Correct the key name for
1438 SecureSmtp, because it seems to be case-sensitive.
1439 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1440 Do not try to get the 0th notebook page if there are 0 pages, to
1441 avoid a g_warning().
1443 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1446 Prevent use of the new notification feature for now, because it currently
1447 shows one dialog for each new email, which is annoying.
1449 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1451 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1452 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1453 when no country was selected, so that we show the global ones.
1454 * src/maemo/easysetup/modest-presets.c:
1455 (modest_presets_get_providers): Return only the global providers, not
1456 all providers when mmc=0 was requested.
1458 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1460 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1461 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1462 provider ID in the combo.
1464 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1465 Do not show the page numbers, because it would be confusing when we add
1466 the 2 extra pages for the custom setup, when the user chooses the "Other"
1467 provider. This fixes projects.maemo.org bug NB#59028
1469 * src/modest-init.c: (modest_init_init_core),
1470 (modest_init_local_folders):
1471 * src/modest-init.h:
1472 * src/modest-tny-account.c:
1473 (modest_tny_account_new_for_local_folders): Do not create default folders
1474 for the memory card. This should fix projects.maemo.org bug NB#59328.
1476 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1478 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1479 Free the changed_conf_keys string items. They are already freed in the
1480 idle handler if that runs first.
1482 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1484 * src/modest-ui-actions.c:
1485 (modest_ui_actions_on_password_requested): Check that the server name
1486 is not NULL, because I just saw a password dialog with (null) as the
1489 * src/modest-tny-folder.[h|c]: Added
1490 modest_tny_folder_is_memory_card_folder().
1491 * src/modest-ui-dimming-rules.c:
1492 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1493 menu item for memory cards, as per the UI spec (section 7.4). This should
1494 fix projects.maemo.org bug NB#59297.
1496 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1498 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1499 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1500 is another problem with the code, see Murray's comment at line 772)
1502 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1504 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1505 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1506 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1507 (load_from_file), (easysetup_country_combo_box_init),
1508 (easysetup_country_combo_box_get_active_country_ids),
1509 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1510 instead of just one ID, to avoid duplicate country names in the UI.
1512 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1513 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1514 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1515 a single ID, avoiding duplicate providers.
1516 * src/maemo/easysetup/modest-easysetup-wizard.c:
1517 (on_combo_account_country): Adapt to use a list.
1519 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1521 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1522 keys changed in the last X seconds.
1524 * src/modest-account-mgr.h:
1525 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1526 (on_key_change), (modest_account_mgr_class_init),
1527 (modest_account_mgr_init), (modest_account_mgr_finalize):
1528 As the keys are changed, save them in a GSList* and signal that GSList*
1529 further every X seconds, to batch changes, to allow us to do just one
1530 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1531 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1533 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1534 changed signal signature.
1536 * src/modest-conf.c: (modest_conf_set_list),
1537 (modest_conf_on_change): Reenable notification.
1539 (modest_conf_maemo_fake_on_change): Comment out the hack that
1540 notified immediately instead of asynchronously.
1542 * src/widgets/modest-account-view.h:
1543 * src/widgets/modest-account-view.c:
1544 (update_account_view): Select the previously-selected account ID,
1545 if possible. This fixes projects.maemo.org bug NB#56933.
1547 (on_account_changed), (on_account_removed),
1548 (modest_account_view_select_account):
1550 Remove the block/unblock functions
1551 because they were not useful.
1553 * src/maemo/modest-account-view-window.c:
1554 (on_delete_button_clicked), (on_edit_button_clicked),
1555 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1557 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1559 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1560 Improve the error dialog to show Incorrect Account Settings, which seems
1561 clearer, and say that the internal error message (to be removed from the
1562 dialog later) is often misleading.
1563 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1565 * src/modest-tny-account.c:
1566 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1567 URL because this is so useful for debugging on the device.
1569 * src/widgets/modest-serversecurity-combo-box.c:
1570 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1572 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1574 * src/modest-mail-operation.c:
1575 (modest_mail_operation_send_new_mail):
1576 Added a comment about a nasty but apparently harmless message. Details
1577 added to the wiki g_warnings() page.
1579 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1581 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1582 (modest_tny_send_queue_class_init):
1583 Do not use the priv struct because it is empty, to avoid g_warnings
1584 about a non-existant priv struct.
1586 * src/modest-tny-account-store.c:
1587 (modest_tny_account_store_get_server_account),
1588 (modest_tny_account_store_get_transport_account_for_open_connection
1589 ): Do not try to get transport server accounts for local folders,
1590 because they don't have any. This avoids a g_warning().
1592 * src/maemo/modest-main-window.c:
1593 (modest_main_window_notify_send_receive_initied),
1594 (on_configuration_key_changed):
1595 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1596 * src/modest-defs.h:
1597 * src/modest-mail-operation.c:
1598 (modest_mail_operation_update_account):
1599 * src/modest-tny-account-store.h:
1600 * src/modest-tny-account.c:
1601 (modest_tny_account_get_special_folder),
1602 (modest_tny_account_new_for_local_folders),
1603 (modest_tny_account_new_for_per_account_local_outbox_folder):
1604 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1605 * src/modest-tny-local-folders-account.c:
1606 (add_account_folders_to_merged_folder):
1607 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1608 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1609 (modest_ui_actions_on_send):
1610 * src/widgets/modest-folder-view.c: (update_model):
1611 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1612 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1613 modest_tny_account_store_get_tny_account_by_account() to
1614 modest_tny_account_store_get_server_account() to make the code clearer.
1616 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1618 * src/dbus_api/modest-dbus-api.h:
1619 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1620 * src/maemo/modest-msg-edit-window.c:
1621 (modest_msg_edit_window_attach_file_noninteractive):
1622 added g_warning in case the file to be attached does not exist
1623 * tests/dbus_api/test_compose_mail.c: (main):
1624 removed obsolete comment, added generic files as test case
1626 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1628 * src/modest-tny-account-store.c: (get_server_accounts):
1629 Create the local folders account only once, not once for each outbox, and
1630 not only when there are some outboxes.
1632 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1634 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1635 code that is causing a crash at startup. Sergio says that he is fixing this.
1637 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1639 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1640 * src/maemo/modest-account-settings-dialog.c:
1641 (create_page_outgoing),
1642 (modest_account_settings_dialog_set_account_name),
1643 (save_configuration):
1644 - Fixed handling of the "Use secure authentication" toggle to comply with
1645 the ui specification. See also projects.maemo.org bug NB#58400
1647 - Restore the Secure connection setting combo correctly when loading
1650 * src/maemo/modest-maemo-utils.c:
1651 (on_camel_account_get_supported_secure_authentication),
1652 (modest_maemo_utils_get_supported_secure_authentication_methods):
1653 Fixed a crasher if operation is canceled
1655 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1656 (modest_protocol_info_auth_is_secure):
1657 * src/modest-protocol-info.h:
1659 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1660 the sense of the "Use secure authentication" toggle.
1662 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1664 * src/modest-tny-account-store.h:
1665 * src/modest-tny-account-store.c:
1666 Added modest_tny_account_store_get_local_folders_account().
1668 * src/modest-tny-folder.h:
1669 * src/modest-tny-folder.c:
1670 (modest_tny_folder_get_account):
1671 Added this replacement for tny_folder_get_account() which returns
1672 the local-folders account for TnyMergeFolders, to avoid the
1673 warning about the unimplemented get_account_func() vfunc().
1675 (modest_tny_folder_get_rules),
1676 * src/modest-ui-actions.c:
1677 (modest_ui_actions_on_folder_selection_changed):
1678 * src/modest-mail-operation.c:
1679 (modest_mail_operation_remove_folder),
1680 (modest_mail_operation_xfer_folder),
1681 (modest_mail_operation_rename_folder),
1682 (modest_mail_operation_get_msg),
1683 (modest_mail_operation_get_msgs_full),
1684 (modest_mail_operation_remove_msg),
1685 (modest_mail_operation_xfer_msgs),
1686 (modest_mail_operation_refresh_folder):
1687 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1689 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1691 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1692 (modest_server_account_set_security):
1693 * src/modest-defs.h: Add comments explaining that our
1694 UI spec means TLS when it says Normal, so these do not look like errors.
1696 * src/modest-tny-account.c:
1697 (modest_tny_account_new_from_server_account): Use the new tinymail
1698 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1699 for TLS. This should fix projects.maemo.org bug NB#58460.
1701 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1703 * src/maemo/easysetup/modest-easysetup-wizard.c:
1704 (create_account): Correct the position of the gconf sanity check warning.
1705 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1706 of using the g_idle_add() hack, because this does not seem to be necessary
1707 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1708 caused by something other than maemo's gconf.
1709 This fixes projects.maemo.org bug #59022.
1711 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1713 * src/modest-account-mgr-helpers.c:
1714 (modest_account_mgr_get_default_account): Do not check that the account
1715 exists if there is no default account (NULL), to fix a runtime warning.
1717 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1719 * src/widgets/modest-folder-view.c: (update_model):
1720 Do not unref the treemodel before we have finished with it.
1721 This prevents a valgrind warning and an occasional crash at startup.
1723 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1725 * libmodest-dbus-client/libmodest-dbus-client.h:
1726 added libmodest_dbus_client_compose_mail()
1727 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1729 added functions needed for SendAsMail() functionality
1730 * src/maemo/modest-msg-edit-window.c:
1731 (modest_msg_edit_window_attach_file_noninteractive):
1732 non interactively attaching files to message edit window
1733 * src/widgets/modest-msg-edit-window.h:
1734 * tests/dbus_api/Makefile.am:
1735 added test_compose_mail.c
1736 * tests/dbus_api/test_compose_mail.c: (main):
1738 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1740 * src/modest-account-view.c:
1741 Fixed bug projects.maemo.org bug NB#59307
1743 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1745 * src/maemo/easysetup/modest-easysetup-wizard.c:
1746 (get_serverport_incoming), (on_before_next), (create_account):
1747 * src/maemo/modest-account-settings-dialog.c:
1748 (modest_account_settings_dialog_set_account_name):
1749 * src/maemo/modest-maemo-utils.c:
1750 (on_camel_account_get_supported_secure_authentication_status),
1751 (on_camel_account_get_supported_secure_authentication),
1752 (on_secure_auth_cancel),
1753 (modest_maemo_utils_get_supported_secure_authentication_methods):
1755 Implemented security authentication for settings and easysetup.
1757 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1759 * src/maemo/modest-main-window.c: (create_details_widget):
1760 Show the total size for memory card accounts too, instead of showing
1761 the name again. Fixes bug projects.maemo.org bug NB#59307.
1763 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1766 * src/modest-tny-simple-folder-store.c:
1767 * src/modest-tny-simple-folder-store.h: Removed.
1769 * src/modest-tny-local-folders-account.h
1770 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1771 for the local-folders maildir, with an extra TnyMergedFolder containing
1772 the folders of the per-account outbox store accounts.
1773 * src/modest-tny-account-store.c: (get_server_accounts):
1774 Add the outboxes to the special local folders account after creating it.
1776 * src/modest-tny-account.c:
1777 (modest_tny_account_new_for_local_folders): Create the derived
1778 account when creating the main local-folders account.
1780 * src/maemo/modest-main-window.c: (create_details_widget),
1781 (modest_main_window_set_contents_style):
1782 Adapted to the use of the derived account instead of the folder store.
1784 * src/modest-ui-actions.c:
1785 (modest_ui_actions_on_folder_selection_changed):
1786 * src/modest-ui-dimming-rules.c:
1787 (modest_ui_dimming_rules_on_new_folder):
1788 * src/widgets/modest-folder-view.c: (text_cell_data),
1789 (icon_cell_data), (filter_row), (update_model),
1790 (get_cmp_rows_type_pos):
1793 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1794 Do not get the priv struct, because no priv struct has been set,
1795 to avoid a runtime warning.
1797 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1798 #ifelse with #else, to fix a warning, to fix the build.
1801 2007-06-05 Christian Kellner <ckellner@openismus.com>
1803 * libmodest-dbus-client/libmodest-dbus-client.c:
1804 Fix small typo in doc (why do you always see them
1805 AFTER committing stuff?)
1808 2007-06-05 Christian Kellner <ckellner@openismus.com>
1810 * libmodest-dbus-client/libmodest-dbus-client.c:
1811 (libmodest_dbus_client_search):
1812 Initialize hit list with NULL. Also set folder list
1813 to "" if NULL was supplied.
1816 2007-06-03 Christian Kellner <ckellner@openismus.com>
1818 * libmodest-dbus-client/libmodest-dbus-client.c:
1819 (modest_search_hit_list_free):
1820 Make it save to call it with NULL.
1822 * src/dbus_api/modest-dbus-callbacks.c:
1823 * src/modest-search.c:
1824 Return full ModestSearchHits as the search result list not TnyHeader
1825 since can't be around withouth the correspoding TnyFolder.
1827 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1829 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1830 Added currently commented code to check for secure auth
1832 * src/maemo/modest-account-settings-dialog.c: (on_response),
1833 (save_configuration), (show_ok):
1834 Fixed projects.maemo.org bugs NB #59248 and #59251
1836 * src/maemo/modest-maemo-utils.c:
1837 (on_camel_account_get_supported_secure_authentication_status),
1838 (on_camel_account_get_supported_secure_authentication),
1839 (modest_maemo_utils_get_supported_secure_authentication_methods):
1840 * src/maemo/modest-maemo-utils.h:
1841 Moved get_supported_secure_authentication() method here to be able
1842 to use it from easysetup wizard.
1844 * src/modest-pair.c: (on_pair_compare_as_string):
1845 Should compare string with first part of pair and not
1846 strcmp pairs which will crash.
1848 * src/modest-protocol-info.c:
1849 (modest_protocol_info_protocol_is_store):
1850 * src/modest-protocol-info.h:
1851 Added modest_protocol_info_get_auth_protocol_name()
1853 2007-06-03 Armin Burgmeier <armin@openismus.com>
1855 * src/modest-mail-operation.c:
1856 (modest_mail_operation_get_msgs_full): Set priv->account also when
1857 only retrieving a single message. This avoids a crash when canceling
1860 (modest_mail_operation_notify_end): Do not explicitely remove the
1861 operation from the queue but only emit the progress_changed signal.
1862 The queue itself listens to that signal to remove the operation when
1863 it is finished. This reduces coupling and removes a potential deadlock
1864 when modest_mail_operation_notify_end() is called from the queue
1865 itself. If that is a problem performance-wise, I would suggest to
1866 implement a status-changed signal or something.
1868 * src/modest-mail-operation-queue.c: Make sure to never call a
1869 function from another file while the queue is locked. This (hopefully)
1870 fixes another deadlock when exiting the application while retrieving
1873 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1875 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1876 Fixed build if libogs is not available
1878 2007-06-03 Christian Kellner <ckellner@openismus.com>
1880 * libmodest-dbus-client/libmodest-dbus-client.h:
1881 * libmodest-dbus-client/libmodest-dbus-client.c:
1882 (libmodest_dbus_client_delete_message):
1883 Implement deletion of messages (Client side).
1885 (modest_search_hit_free),
1886 (modest_search_hit_list_free):
1887 Utility functions to free the result hits.
1889 * src/dbus_api/modest-dbus-api.h:
1890 * src/dbus_api/modest-dbus-callbacks.c:
1891 (on_delete_message),
1892 (modest_dbus_req_handler):
1893 Implement deletion of messages (Server side).
1895 * tests/dbus_api/test_search.c: (main):
1898 * tests/dbus_api/Makefile.am:
1899 * tests/dbus_api/test_delete_message:
1900 Add little test for the message deletion logic
1902 2007-06-03 Armin Burgmeier <armin@openismus.com>
1904 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1905 when the operation queue was not empty. projects.maemo.org bug
1908 2007-06-03 Armin Burgmeier <armin@openismus.com>
1910 * src/widgets/modest-account-view.c
1911 (on_account_default_toggled): Toggle default account column
1912 explicitely instead of waiting for gconf notification (which is
1913 currently ignored). This should fix projects.maemo.org bug NB#56910
1914 for now. It should probably be removed when gconf notifications are
1917 2007-06-03 Christian Kellner <ckellner@openismus.com>
1919 * libmodest-dbus-client/libmodest-dbus-client.c:
1920 Removed debugging spew.
1922 * src/dbus_api/modest-dbus-callbacks.c:
1923 Added debugging info.
1925 * src/modest-search.c:
1926 (modest_search_all_accounts):
1927 Use tny_account_store_get_accounts () on the account store
1928 to get all accounts which is the way to get all accounts.
1930 * tests/dbus_api/test_search.c: (main):
1931 Make it possible to supply the search term on the command line.
1933 2007-06-03 Christian Kellner <ckellner@openismus.com>
1935 * libmodest-dbus-client/libmodest-dbus-client.c:
1936 * libmodest-dbus-client/libmodest-dbus-client.h:
1937 Implement searching for mesages over raw dbus. (Client side)
1939 * src/dbus_api/Makefile.am:
1940 * src/dbus_api/modest-dbus-api.h:
1941 * src/dbus_api/modest-dbus-callbacks.c:
1942 * src/dbus_api/modest-dbus-callbacks.h:
1943 Search framework (Server side). Also implement on_idle_open_message().
1945 * src/maemo/modest-platform.c: (modest_platform_init):
1946 Prepare for raw dbus/osso rpc interaction.
1948 * src/modest-search.h:
1949 Changed minsize from unspecific guint to guint32.
1951 * src/modest-search.c:
1953 Added strange hack which magically made tnymail work.
1955 (modest_search_folder),
1956 (modest_search_account),
1957 (modest_search_all_accounts):
1958 Implement helper functions to search all accounts, specific account
1961 * tests/dbus_api/Makefile.am:
1962 * tests/dbus_api/test_open_message.c:
1963 Read url to open from commandline.
1965 * tests/dbus_api/test_search.c:
1966 Implement small test for dbus search stuff
1968 2007-06-02 Armin Burgmeier <armin@openismus.com>
1970 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1971 include account type and account title. This fixes projects.maemo.org
1974 * src/maemo/modest-account-view-window.c: Set a title for the window.
1976 2007-06-02 Armin Burgmeier <armin@openismus.com>
1978 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1979 incoming and outgoing server name based on email address and server
1980 types as long as the names have not been edited manually. This fixes
1981 projects.maemo.org bug NB#58671.
1983 2007-06-02 Armin Burgmeier <armin@openismus.com>
1985 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1986 server type cannot be changed in future to the incoming details page
1987 when creating an account. This fixes projects.maemo.org bug NB#59029.
1989 2007-06-02 Armin Burgmeier <armin@openismus.com>
1991 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1992 and assigned max width chars so that they wrap instead of being
1993 truncated. Fixes projects.maemo.org bug NB#56126.
1995 2007-06-02 Armin Burgmeier <armin@openismus.com>
1997 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1998 introductory note to the connection specific smtp servers dialog, as
1999 section 8.12 of the email UI specification requires. This fixes
2000 projects.maemo.org bug NB#59212.
2002 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2004 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2005 Check for running mail operations, and offer to cancel them, as per the UI
2006 spec. This fixes projects.maemo.org bug NB#59041 .
2007 However, I suspect that tinymail may still use the network connection
2008 in ways that we cannot detect or cancel. But it should at least adapt to
2009 changes fairly well.
2011 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2013 * src/modest-tny-account-store.c: (recreate_all_accounts),
2014 (get_cached_accounts), (get_server_accounts): Do more sensible
2015 ref-counting of the temporarily-cached outbox accounts list. This seems
2016 to fix a crash when entering the password when the password was wrong.
2018 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2020 * src/gnome/modest-main-window.c: (connect_signals):
2021 * src/modest-tny-account-store.c: (get_password),
2022 (modest_tny_account_store_alert): Added comments and clues and
2023 commented-out code about how we currently fail to deal with connection
2024 errors and wrong passwords, and how we should.
2026 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2028 * src/widgets/modest-retrieve-combo-box.c:
2029 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2030 This fixes projects.maemo.org bug NB#58472 .
2032 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2034 * src/maemo/easysetup/modest-easysetup-wizard.c:
2035 (create_page_complete_easysetup):
2036 (create_page_complete_custom): Correct the last commit,
2037 putting the correct sentences in the correct pages.
2039 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/easysetup/modest-easysetup-wizard.c:
2042 (create_page_complete_custom): Show the second sentence of text
2043 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2046 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2048 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2049 Set the leave-on-server conf key by default. This fixes
2050 projects.maemo.org bug NB#59258 .
2052 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2054 * src/maemo/modest-account-view-window.c:
2055 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2056 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2059 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2061 * src/maemo/easysetup/modest-easysetup-wizard.c:
2062 (create_caption_new_with_asterisk):
2063 * src/maemo/modest-account-settings-dialog.c:
2064 (create_caption_new_with_asterisk):
2065 Uncomment the code to add the asterisk, because they are no longer in the
2066 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2067 (update_incoming_server_title): Add an asterisk here too.
2069 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2071 * src/maemo/modest-maemo-global-settings-dialog.c:
2072 (current_connection): Check that we are even connected before trying to
2073 get the current connection name, to prevent a warning.
2075 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2076 Change the comments because tny_maemo_conic_device_connect() is now meant to
2078 * src/modest-mail-operation.c:
2079 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2080 make sure we have a connection and fail if we can't connect.
2082 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2084 * src/maemo/modest-main-window.c:
2085 (on_account_store_connecting_finished): Do not try to get the
2086 connection ID if we are not really connected. I am surprised that
2087 this signal handler is called when we are not connected.
2089 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2091 * src/modest-error.h:
2092 * src/modest-ui-actions.c:
2093 (modest_ui_actions_get_msgs_full_error_handler):
2094 Renamed an enum, added comments, added an enum
2095 for retrieve-limit errors.
2097 * src/modest-mail-operation.c: (foreach_add_item),
2098 (internal_folder_observer_update), (update_account_thread),
2099 (modest_mail_operation_get_msgs_full):
2100 (modest_mail_operation_update_account),
2101 Added comments about how this works, and some code that should
2102 (but does not) check the retrieve-limit. See the TODO comment.
2104 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2106 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2107 Initialize help_id to fix the build. Warnings are good.
2109 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2111 * src/widgets/modest-hbox-cell-renderer.c:
2112 (modest_hbox_cell_renderer_append):
2113 * src/widgets/modest-vbox-cell-renderer.c:
2114 (modest_vbox_cell_renderer_append):
2115 Fix the last commit by doing an extra ref.
2117 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2119 * src/widgets/modest-hbox-cell-renderer.c:
2120 (modest_hbox_cell_renderer_append):
2121 * src/widgets/modest-vbox-cell-renderer.c:
2122 (modest_vbox_cell_renderer_append):
2123 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2124 to fix the build with Maemo Bora.
2125 However, there seems to be a remaining crash, probably due to reference
2128 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2130 * src/modest-tny-account.c:
2131 (modest_tny_account_new_for_local_folders):
2132 Use hildon_file_system_info_async_new() to get a better name for
2133 the memory card account, setting it as the account name.
2134 The timing seems to work, but this is probably
2135 not the best place to do this. See the TODO comment.
2136 * src/maemo/modest-main-window.c: (create_details_widget):
2137 * src/widgets/modest-folder-view.c: (text_cell_data):
2138 Use the tny account name instead of hardcoding a name.
2140 2007-05-30 Christian Kellner <ckellner@openismus.com>
2142 * src/modest-search.c: (modest_search):
2143 Correctly set part_search_func even if we have already parsed
2144 the query and thus a valid OgsTextSearcher object.
2146 2007-05-30 Christian Kellner <ckellner@openismus.com>
2149 Search and check for libogs.
2152 Incooparte the ogs build env.
2154 * src/modest-mime-part-search-stream.c:
2155 * src/modest-mime-part-search-stream.h:
2156 Removed since we do the real searching now in modest-search.c.
2158 * src/modest-search.c:
2159 * src/modest-search.h:
2160 Implement support for ogs. We use that if available and requested
2161 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2162 should now handle the corner case when the search term is spread
2163 across multiple reads.
2164 Also the logic in modest_search () was corrected to search all
2165 requested fields until one is found.
2167 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2171 * src/modest-init.h:
2172 * src/modest-init.c: Made modest_init_local_folders() take a
2173 path and be public so we can iniitialize maildir folders on
2176 * src/modest-local-folder-info.h:
2177 * src/modest-local-folder-info.c:
2178 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2180 * src/modest-tny-account.c:
2181 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2182 still means the standard local-folders path on the local volume.
2184 * src/modest-tny-account-store.c:
2185 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2186 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2187 all accounts when that happens.
2188 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2189 this too, so it shows up in the treeview.
2191 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2193 * src/maemo/modest-maemo-global-settings-dialog.c:
2194 (current_connection):
2195 * src/widgets/modest-global-settings-dialog.c:
2196 (current_connection_default):
2197 Use the enum values instead of 0, 1 and -1,
2198 to make the code clearer.
2200 * src/modest-account-mgr-helpers.c:
2201 (modest_account_mgr_get_connection_specific_smtp): Make this code
2204 * src/modest-runtime.h:
2205 * src/modest-runtime.c:
2206 Added modest_runtime_remove_all_send_queues().
2207 * src/maemo/modest-main-window.c:
2208 (on_account_store_connecting_finished): Recreate the send queues,
2209 using the appropriate transport accounts for this new connection.
2210 Some futher adapting might be needed if the old send queues are not
2211 automatically stopped at this point.
2213 * src/modest-tny-account-store.c: (get_server_accounts):
2214 Create the connection-specific transport accounts, so that they can
2215 be found later by their ID.
2217 * src/modest-tny-account.h:
2218 * src/modest-tny-account.c:
2219 Added modest_tny_account_new_from_server_account_name().
2220 modest_tny_account_new_from_server_account(): Do not create the
2221 send queues here, because they will be
2222 recreated anyway when the connection changes for the first time.
2224 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2226 * src/modest-local-folder-info.h:
2227 * src/modest-local-folder-info.c:
2228 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2229 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2230 tbox_folder): Take a modest account name instead of a server TnyAccount,
2231 so we can have per-modest-account rather than per-transport-account
2233 We must make sure that we change or recreate the exisitng send queues
2234 when the connection changes for connection-specific transport accounts.
2236 * src/modest-tny-account-store.c:
2237 (create_per_account_local_outbox_folders): Create outboxed per modest
2238 account, not per transport account.
2240 * src/modest-tny-account.h:
2241 * src/modest-tny-account.c:
2242 (modest_tny_account_get_special_folder): For outboxes, get the
2243 parent modest account name. The account is ignored for other folders.
2244 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2245 modest account name rather than a server TnyAccount.
2247 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2249 * src/modest-tny-account.c:
2250 (modest_tny_account_new_from_server_account):
2251 Call modest_runtime_get_send_queue() immediately after creating transport
2252 accounts, so that they start trying to send email from the outbox as soon
2253 as possible at startup. This is probably what we want.
2255 * src/modest-mail-operation.c: (update_account_thread):
2256 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2257 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2258 * src/modest-tny-send-queue.h:
2259 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2260 (modest_ui_actions_on_send):
2261 Added comments about how sending works, though it needs some more work.
2263 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2265 * src/modest-tny-account.c:
2266 (modest_tny_account_get_special_folder): Add TODO because this fails when
2267 the network is busy.
2268 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2269 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2270 Do not try to show this window when there is no active account. The UI
2271 specs does not tell us what to do in this case.
2273 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2277 * src/maemo/Makefile.am:
2278 * src/widgets/Makefile.am: Some dist fixes.
2280 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2282 * src/maemo/modest-connection-specific-smtp-window.c:
2283 (on_button_edit): Make the code clearer, to prevent a double free.
2285 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2287 * src/maemo/modest-account-settings-dialog.c:
2288 (modest_account_settings_dialog_set_account_name),
2289 Check the connection-specific smtp servers checkbox if there are any.
2291 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2292 (modest_connection_specific_smtp_edit_window_init):
2293 Start with a suitable port number.
2295 * src/modest-account-mgr-helpers.h:
2296 * src/modest-account-mgr-helpers.c: Added
2297 modest_account_mgr_get_has_connection_specific_smtp().
2299 (modest_account_mgr_set_connection_specific_smtp),
2300 (modest_account_mgr_remove_connection_specific_smtp),
2301 (modest_account_mgr_get_has_connection_specific_smtp),
2302 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2303 connection-specific smtp server accounts in the account, rather than
2304 the server account conf dir.
2306 This fixes bug projects.maemo.org bug NB#58263 .
2308 * src/modest-tny-account-store.c:
2309 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2310 if there are no server accounts yet, to prevent an infinite loop when there
2311 are no accounts. Document that one must be called before the other.
2313 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2315 * src/modest-account-mgr-helpers.c:
2316 (modest_account_mgr_get_default_account): Make sure that at least
2317 one account is always the default, if there are any enabled accounts.
2318 This is just a sanity check that shouldn't be necessary.
2320 * src/modest-account-mgr-priv.c:
2321 (_modest_account_mgr_account_from_key): Unescape the conf key to
2322 get the real account name. For instance, this is an issue if a space
2323 was in the account name, which can happen because the account name
2324 is generated from the display name.
2325 (_modest_account_mgr_get_account_keyname): Always escape the
2327 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2328 Unescape the conf keys to get the real account names.
2330 For instance, previously the is-default radio button in the accounts
2331 list was not checked for any accounts at first. This fixes that,
2332 and might fix several similar bugs.
2334 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2336 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2337 Removed some debug printfs.
2339 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2341 Modest on-disk outbox directories are now here, for instance:
2342 $HOME/.modest/outboxes/<account-id-1>/outbox
2343 $HOME/.modest/outboxes/<account-id-2>/outbox
2345 $HOME/.modest/local-folders/outbox
2346 so we can have a separate outbox for each account.
2347 But they are shown as one outbox in the GtkTreeView, by using a
2348 TnyMergeFolder in a ModestTnySimpleFolderStore.
2351 * src/modest-tny-simple-folder-store.c:
2352 * src/modest-tny-simple-folder-store.h:
2353 Added ModestTnySimpleFolderStore, used to contain folders from
2354 other folder stores, such as other accounts.
2356 * src/modest-tny-outbox-account.h:
2357 * src/modest-tny-outbox-account.c:
2358 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2359 used for the per-account local outbox folders.
2361 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2362 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2363 only use this (internally) now for the non-outbox local folders.
2365 * src/modest-init.h:
2366 * src/modest-init.c: Added modest_init_one_local_folder(), for
2367 setting up the directory structure for each local folder.
2369 * src/modest-local-folder-info.c:
2370 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2371 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2373 * src/modest-local-folder-info.h:
2374 * src/modest-tny-account-store.c: (on_account_removed),
2375 (on_account_changed), (create_per_account_local_outbox_folders),
2376 (get_server_accounts), (modest_tny_account_store_get_accounts),
2377 (modest_tny_account_store_get_tny_account_by_account),
2378 (modest_tny_folder_store_is_virtual_local_folders):
2380 * src/modest-tny-account.h:
2381 * src/modest-tny-account.c:
2382 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2383 to create an on-disk per-account local outbox folder for each
2385 (create_per_account_local_outbox_folders): Create a local outbox folder
2386 for each transport account.
2387 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2388 for all local folders.
2390 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2391 instead of using g_object_get/set() directly. It is clearer.
2393 (modest_tny_folder_store_get_message_count),
2394 (modest_tny_folder_store_get_local_size
2395 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2396 because we now use these with non-acount folder stores.
2398 (modest_tny_account_get_special_folder),
2399 (modest_tny_account_new_from_server_account),
2400 (modest_tny_account_new_from_account):
2401 (recurse_folders): Adjust to the new outbox system.
2403 * src/modest-tny-folder.h:
2404 * src/modest-tny-folder.c:
2405 (modest_tny_folder_is_local_folder),
2406 (modest_tny_folder_get_local_folder_type),
2407 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2409 * src/widgets/modest-main-window.h:
2410 * src/maemo/modest-main-window.c: (create_details_widget),
2411 (modest_main_window_set_contents_style): Show details for any folder store,
2414 (modest_tny_folder_get_rules):
2415 Remove the const. C does not support constness enough for this.
2417 * src/modest-ui-actions.c:
2418 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2419 make all outboxes appear as one, in the usual local-folders tree node.
2421 (set_active_account_from_tny_account),
2422 (modest_ui_actions_on_folder_selection_changed):
2423 * src/widgets/modest-folder-view.c: (text_cell_data),
2424 (icon_cell_data), (filter_row),
2425 (add_account_folders_to_merged_folder),
2426 (add_account_folders_to_simple_folder_store), (),
2427 (get_cmp_rows_type_pos), (cmp_rows),
2428 (modest_folder_view_set_account_id_of_visible_server_account):
2429 Adjust to the new outbox system, using generic folder stores and folders
2430 in the GtkTreeModel.
2432 2007-05-23 Christian Kellner <ckellner@openismus.com>
2434 * src/modest-mail-operation.c:
2435 (modest_mail_operation_update_account):
2436 Use info->max_size instead of unintialized local var [small
2437 build fix]. (Added TODO to review that change since I don't
2440 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2442 * libmodest-dbus-client/libmodest-dbus-client.c:
2443 (libmodest_dbus_client_compose_mail): function added
2444 * src/dbus_api/modest-dbus-api.h:
2445 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2446 (on_compose_mail): Implementation of the SendAsMail functionality
2448 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2450 * src/modest-account-mgr.c:
2451 (modest_account_mgr_add_server_account): Set the secure-connection
2452 conf key for transport accounts as well as store accounts. I don't know
2453 why the if was there. For instance, this makes sure that we use SSL
2454 for the gmail preset from the easysetup wizard.
2456 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2458 * src/gnome/modest-main-window.c:
2459 (on_account_store_connecting_finished), (connect_signals):
2460 * src/maemo/modest-main-window.c:
2461 (on_account_store_connecting_finished), (connect_signals),
2462 (modest_main_window_new):
2463 Handle TnyAccountStore::connecting-finished instead of
2464 TnyDevice::connection-changed, because we cannot actually perform
2465 operations on accounts until TnyAccountStore has itself responded to
2466 the TnyDevice::connection-changed signal. This prevents a GError from
2468 Do not try to update at startup, because we (at least on scratchbox)
2469 already do an update at startup when the device goes online.
2470 This prevents a GError from tinymail.
2471 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2472 Added TODO about stopping simultaneous operations.
2474 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2476 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2477 * src/modest-mail-operation-queue.c:
2478 (modest_mail_operation_queue_remove):
2479 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2480 about where they happened.
2482 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-ui-actions.c:
2485 (modest_ui_actions_on_password_requested): Make sure that the remember
2486 output parameter is always TRUE.
2488 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2490 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2491 Show a OK/Cancel dialog if the error is a question, though we still do not
2492 know anything more about what we are asking the user.
2493 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2494 Fix an uninitialized variable (helper). This is a logic error, however.
2496 2007-05-21 Christian Kellner <ckellner@openismus.com>
2498 * src/modest-search.h:
2499 Correct bit shifting in the ModestSearchFlags enum.
2501 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2503 * src/modest-tny-account.c:
2504 (modest_tny_account_new_from_server_account): Do not use the lsub and
2505 check-all hard-coded IMAP options when using POP.
2507 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2509 * src/modest-tny-account.c:
2510 (modest_tny_account_new_from_server_account):
2511 Use NULL for the secure-auth method for POP when Password auth has been
2512 specified by the user, as we already do for IMAP. "auth=Login" causes
2513 an error from camel or the server.
2515 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2517 * src/maemo/modest-account-settings-dialog.c:
2518 (create_page_account_details),
2519 (modest_account_settings_dialog_set_account_name):
2520 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2521 for the leave-on-server checkbox, rathr than just the checkbox, when
2522 the protocol is not POP.
2524 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2526 * src/widgets/modest-account-view.c:
2527 * src/widgets/modest-account-view.h:
2528 Added modest_account_view_select_account() which will be useful later
2529 to asynchronously re-select the edited account.
2531 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2533 * src/maemo/modest-account-settings-dialog.c:
2534 (modest_account_settings_dialog_set_account_name):
2535 Automatically choose the port numbers based on the secure authentication
2536 methods, if they have not been chosen before.
2537 This fixes projects.maemo.org bug NB#56273 .
2539 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2541 * src/maemo/modest-main-window-ui.h:
2542 * src/modest-ui-actions.c:
2543 * src/modest-ui-actions.h:
2544 Connect the Tools/SMTP Servers menu item to
2545 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2546 SMTP servers dialog, as in the UI specification and saves changes when it
2547 is closed. This fixed projects.maemo.org bug NB#56305 .
2549 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2551 * src/maemo/modest-connection-specific-smtp-window.c:
2552 (modest_connection_specific_smtp_window_init):
2553 Use gtk_window_set_default_size() to make this window big enough, so
2554 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2556 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2558 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2559 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2560 (modest_connection_specific_smtp_edit_window_init),
2561 Do not try to connect to a combobox signal before the combobox exists.
2562 This fixes the cras in projects.maemo.org bug NB#56288 .
2563 (modest_connection_specific_smtp_edit_window_get_settings):
2564 Remove the server_account_name parameter which was being checked for NULL
2565 though it was not used.
2567 * src/maemo/modest-connection-specific-smtp-window.c:
2568 (modest_connection_specific_smtp_window_fill_with_connections),
2569 (on_button_edit), (modest_connection_specific_smtp_window_init):
2570 Correct the number of treemodel columns to prevent a warning.
2571 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2572 libconic does not work.
2574 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2576 * src/modest-tny-account.c:
2577 (modest_tny_account_new_from_server_account):
2578 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2579 SMTP when "None" was chosen by the user. However, with my SMTP server that
2580 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2583 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2585 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2586 to explain the memory management issue with the ID in the ModestPair.
2588 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2589 (add_sending_page), (modest_account_assistant_finalize):
2590 * src/gnome/modest-gnome-global-settings-dialog.c:
2591 (create_updating_page), (create_composing_page):
2592 * src/gnome/modest-msg-edit-window.c: (get_transports),
2593 (init_window), (modest_msg_edit_window_finalize),
2594 (modest_msg_edit_window_get_msg_data):
2595 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2596 * src/gnome/modest-transport-widget.c:
2597 (modest_transport_widget_finalize), (smtp_configuration):
2598 * src/maemo/modest-maemo-global-settings-dialog.c:
2599 (create_updating_page), (create_composing_page):
2600 * src/maemo/modest-msg-edit-window.c: (get_transports),
2601 (init_window), (modest_msg_edit_window_finalize),
2602 (modest_msg_edit_window_get_msg_data),
2603 (modest_msg_edit_window_free_msg_data):
2604 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2605 (modest_store_widget_finalize):
2606 * src/maemo/modest-transport-widget.c:
2607 (modest_transport_widget_finalize), (smtp_configuration):
2608 * src/modest-main.c: (send_mail):
2609 * src/widgets/modest-combo-box.h:
2610 * src/widgets/modest-global-settings-dialog-priv.h:
2611 * src/widgets/modest-global-settings-dialog.c:
2612 (modest_global_settings_dialog_finalize):
2613 * src/widgets/modest-msg-edit-window.h:
2614 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2615 as long as the combo box, to prevent use of freed memory for the ID.
2617 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2619 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2620 get_accounts(), to make this clearer. Do not check for the enabled gconf
2621 key, because we do not use this for server accounts (at least, not yet).
2622 This allows us to send email again.
2624 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2626 * src/maemo/modest-platform.c:
2627 (on_modest_conf_update_interval_changed), (modest_platform_init):
2628 Only respond to this particular key change. All these strcmp()s cannot be
2631 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2633 * src/maemo/modest-maemo-global-settings-dialog.c:
2634 (current_connection): Prevent a crash in scratchbox when
2635 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2636 * src/maemo/modest-platform.c:
2637 (on_modest_conf_update_interval_changed), (modest_platform_init):
2638 Get the update interval from gconf and reset it when the gconf key changes.
2640 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2642 * src/modest-protocol-info.c:
2643 * src/modest-protocol-info.h: Adde enum-specific get functions,
2644 instead of using a ModestProtocolType enum parameter.
2646 * src/gnome/modest-account-assistant.c:
2647 * src/gnome/modest-store-widget.c:
2648 * src/gnome/modest-store-widget.h:
2649 * src/gnome/modest-transport-widget.c:
2650 * src/gnome/modest-transport-widget.h:
2651 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2652 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2653 * src/maemo/easysetup/modest-easysetup-wizard.c:
2654 * src/maemo/modest-account-settings-dialog.c:
2655 * src/maemo/modest-account-settings-dialog.h:
2656 * src/maemo/modest-store-widget.c:
2657 * src/maemo/modest-store-widget.h:
2658 * src/maemo/modest-transport-widget.c:
2659 * src/maemo/modest-transport-widget.h:
2660 * src/modest-account-mgr-helpers.c:
2661 * src/modest-account-mgr-helpers.h:
2662 * src/modest-account-mgr.c:
2663 * src/modest-account-mgr.h:
2664 * src/modest-tny-account.c:
2665 * src/modest-tny-folder.c:
2666 * src/widgets/modest-account-view.c:
2667 * src/widgets/modest-retrieve-combo-box.c:
2668 * src/widgets/modest-retrieve-combo-box.h:
2669 * src/widgets/modest-secureauth-combo-box.c:
2670 * src/widgets/modest-serversecurity-combo-box.c:
2671 * src/widgets/modest-serversecurity-combo-box.h:
2672 * tests/check_account-mgr.c:
2673 Use the specific functions, and use the re-renamed enum values for GNOME too.
2675 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2677 * src/modest-pair.h:
2678 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2679 so we can get the second based on the first.
2681 * src/maemo/modest-account-settings-dialog.h:
2682 * src/maemo/modest-account-settings-dialog.c:
2683 Added get_supported_secure_authentication_methods(), though it is mostly
2684 commented-out for now until the necessary API is committed to tinymail.
2685 (modest_account_settings_dialog_set_account_name),
2686 (save_configuration): Request the supported authentication methods from the
2687 server, so we can choose a working method.
2689 * src/modest-tny-account-store.h:
2690 * src/modest-tny-account-store.c:
2691 (modest_tny_account_store_get_session): Rename from
2692 tny_account_store_get_session().
2694 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2696 * src/modest-protocol-info.h: Split the ModestProtocol enum
2697 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2698 There was no need to have these unrelated values in one enum.
2700 * src/: many files: Adapted to changed enum. This makes the code a bit
2701 clearer, and the compiler could catch some errors.
2703 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2705 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2706 Show the detailed internal camel error message when an error happens
2707 during the configuration, so that our testers can give us more clues.
2708 For instance, in projects.maemo.org bug NB#56910 .
2710 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2712 * src/modest-tny-account.c:
2713 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2714 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2716 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2718 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2719 * src/maemo/modest-account-settings-dialog.c:
2720 (modest_account_settings_dialog_set_account_name),
2721 (save_configuration): For the incoming secure authentication checkbox,
2722 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2723 the UI specification. PLAIN does not seem to be supported for most IMAP
2724 servers anyway, and I am not sure what it would mean.
2725 However, we probably need to discover which of the secure-authentication
2726 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2727 * src/modest-account-mgr-helpers.c:
2728 (modest_account_mgr_get_server_account_data):
2730 * src/modest-tny-account.c:
2731 (modest_tny_account_new_from_server_account):
2732 Use tny_account_set_mech() to set secure-authentication methods,
2733 with some special-casing for IMAP, based on my observations of how
2736 * src/modest-account-mgr-helpers.h:
2737 * src/modest-account-mgr.c:
2738 * src/modest-defs.h: Comment that the URI is only used for local folders.
2740 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2742 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2743 parameter const, just to be neat.
2744 * src/modest-text-utils.c: (modest_text_utils_inline):
2745 End g_strconcat() with NULL, as its documentation says. This is almost
2746 certainly the cause of my crash at startup on the device. Interestingly,
2747 valgrind doesn't tell us about these errors.
2749 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2751 * scripts/build-packages: Added more precise comments about how to use
2752 this script, though I still get this error:
2753 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2754 error building tinymail
2756 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2758 * src/maemo/modest-main-window.c: (on_account_update):
2759 Very slight cleanup, hoping to make it simpler to discover what causes
2760 a crash here sometimes.
2762 * src/modest-tny-account.c:
2763 (modest_tny_account_new_from_server_account): Set the port. Added
2764 comments about the options and a TODO comment because I need to find out
2765 how to specify the secure authentication method.
2767 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2769 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2770 changed CFlags paths form modest to libmodest
2772 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2774 * src/modest-account-mgr-helpers.c:
2775 (modest_account_mgr_get_server_account_data),
2776 (modest_account_mgr_free_server_account_data):
2777 * src/modest-account-mgr-helpers.h:
2778 * src/modest-account-mgr.c:
2779 (modest_account_mgr_add_server_account):
2780 * src/modest-defs.h:
2781 * src/modest-tny-account.c:
2782 (modest_tny_account_new_from_server_account):
2783 Determine the options for tny_camel_account_add_option() here,
2784 based on the settings, rather than storing them directly in gconf.
2786 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2788 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2789 Show a more friendly error dialog now that we expect (from the tinymail
2790 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2792 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2794 * src/maemo/modest-main-window.c: (on_account_update): Check that
2795 account_name is not NULL, to prevent a crash at startup that I am
2796 seeing on the N800. I do wonder why it is NULL.
2798 * src/maemo/easysetup/modest-easysetup-wizard.c:
2799 (create_page_user_details):
2800 * src/maemo/modest-account-settings-dialog.c:
2801 (create_page_user_details), (create_page_outgoing):
2802 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2803 (modest_connection_specific_smtp_edit_window_init):
2804 * src/modest-ui-actions.c:
2805 (modest_ui_actions_on_password_requested):
2806 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2807 might do something useful with the on-screen keyboard.
2809 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/modest-main-window.c: (on_account_update):
2812 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2813 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2815 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2817 * src/modest-tny-account-store.c: (on_account_changed):
2818 Correct the signature of this signal handler.
2820 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2822 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2823 Show a HildonNote instead of a GtkDialog for Maemo.
2825 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2827 * src/widgets/modest-account-view.h:
2828 * src/widgets/modest-account-view.c: (on_account_changed),
2829 (on_account_removed). Added a boolean flag, set/unset by
2830 modest_account_view_block_conf_updates(),
2831 modest_account_view_unblock_conf_updates() to prevent unnecessary
2832 updates, but this is not very useful because the gconf notifications are
2833 so delays (maybe only on Maemo Bora).
2834 So auto-updating is turned off, and these functions do an explicit
2835 update when necessary.
2836 However, something else is still doing too much work when adding/removing
2837 accounts, probably in another part of the application.
2839 * src/maemo/modest-account-view-window.c:
2840 (on_delete_button_clicked), (on_edit_button_clicked),
2841 (on_new_button_clicked): Use the new functions.
2843 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2845 * src/modest-account-mgr-helpers.c:
2846 (modest_account_mgr_set_first_account_as_default):
2847 Sort the list of names alphabetically-by-title, so we choose the first one
2849 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2850 alphabetically by the title.
2852 This fixes projects.maemo.org bug NB#56418 .
2854 * src/modest-account-mgr-priv.c:
2855 (_modest_account_mgr_account_from_key):
2856 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2857 avoid a valgrind error, and possible random behaviour.
2859 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2861 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2862 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2863 tinymail documentation to say that this can be expected.
2864 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2865 pretty, and should not happen, but I would prefer to know when it does.
2867 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2869 * configure.ac: When using the older hildon version, probably on Bora,
2870 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2872 * src/widgets/modest-attachment-view.c:
2873 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2876 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2878 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2879 Implemented the prototype. Can be tested with
2880 tests/dbus_api/test_open_message:
2882 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2884 * src/modest-tny-account-store.c:
2885 (modest_tny_account_store_instance_init), (get_password):
2886 * src/modest-ui-actions.c:
2887 (modest_ui_actions_on_password_requested):
2888 Do not store the password in gconf, because this function is called
2889 for non-remembered passwords. Actually use the cached (in the hash map)
2890 password instead of releasing it.
2891 The password will now not be remembered if it is asked via the protected
2892 password dialog, as per the UI spec.
2894 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2896 * src/modest-defs.h:
2897 * src/modest-account-mgr-helpers.h:
2898 * src/modest-account-mgr-helpers.c:
2899 Added modest_server_account_get_username_has_succeeded(),
2900 modest_server_account_set_username_has_succeeded().
2901 (modest_server_account_set_username),
2902 Reset the has-succeeded flag if the username changes.
2904 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2905 * src/maemo/modest-connection-specific-smtp-window.c:
2906 (modest_connection_specific_smtp_window_save_server_accounts):
2907 Use modest_server_account_set_username() instead of using
2908 modest_conf_set_string() directly, so that the has-succeeded flag is always
2911 * src/modest-ui-actions.c:
2912 (modest_ui_actions_on_password_requested): Dim the username entry if
2913 the username has ever worked, as per the UI spec.
2915 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2917 * src/modest-tny-account-store.c: (get_password):
2918 * src/modest-ui-actions.c:
2919 (modest_ui_actions_on_password_requested):
2920 Allow the username to be changed too, though there is more work to
2921 be done on exactly how this behaves.
2923 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2925 * src/modest-account-mgr-helpers.h:
2926 * src/modest-account-mgr-helpers.c:
2927 Added modest_account_mgr_get_display_name(),
2928 modest_server_account_get_username(),
2929 modest_server_account_set_username(),
2930 modest_server_account_set_password(),
2931 modest_server_account_get_hostname() functions so we do not need to
2932 use the conf API directly.
2934 * src/maemo/modest-main-window.c: (connect_signals):
2935 Actually connect ot the ModestAccountStore::request-password signal,
2936 so that we show the dialog when the password is requested by Tinymail,
2937 for isntance if it is empty.
2939 * src/modest-marshal.list:
2940 * src/modest-tny-account-store.c:
2941 (modest_tny_account_store_class_init), (get_password),
2942 (modest_tny_account_store_alert):
2943 * src/modest-tny-account-store.h:
2944 * src/modest-ui-actions.h:
2945 * src/modest-ui-actions.c:
2946 (modest_ui_actions_on_password_requested):
2947 Change the signal parameters, so it is obvious that we are providing
2948 the non human-readable server name, and receiving both the username
2949 and password, though changing of the username is not yet implemented.
2950 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2951 for the GNOME version.
2953 This should fix the projects.maemo.org bug NB#56209, though it does not
2954 work on Bora, because the gconf_client_get() for the password fails
2955 immediately after we save it with gconf_client_set().
2957 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2960 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2961 caused an undefined symbol error:
2962 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2964 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2966 * src/modest-tny-account-store.c:
2967 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2968 using a GError instead of a string message, so we can translate it in
2971 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2973 * src/maemo/modest-address-book.c:
2974 (modest_address_book_check_names):
2975 * src/maemo/modest-msg-view-window.c:
2976 (modest_msg_view_window_clipboard_owner_change):
2977 * src/modest-init.c: (modest_init_init_ui):
2978 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2979 (update_folders_cb), (modest_mail_operation_update_account):
2980 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2981 (modest_ui_actions_on_msg_attachment_clicked),
2982 (modest_ui_actions_on_msg_recpt_activated):
2983 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2984 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2985 (modest_msg_view_search_next):
2986 * src/widgets/modest-recpt-editor.c:
2987 (modest_recpt_editor_on_button_release_event),
2988 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2989 g_message(). At this point we should only be seeing interesting errors on
2990 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2992 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2994 (modest_wizard_dialog_force_title_update):
2995 * src/maemo/easysetup/modest-wizard-dialog.h:
2996 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2997 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2998 can update the title when appropriate. Otherwise the title is wrong if the
2999 pages are added after adding the notebook to the dialog.
3000 This must be a problem in HildonWizardDialog too.
3001 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3003 * src/maemo/easysetup/modest-easysetup-wizard.c:
3004 (create_subsequent_customsetup_pages),
3005 (create_subsequent_easysetup_pages):
3006 Call modest_wizard_dialog_force_title_update() so that the title is
3007 correct even with GTK+ < 2.10.
3008 This fixes projects.maemo.org bug NB#56145 .
3010 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3012 * src/maemo/modest-platform.c:
3013 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3014 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3017 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3019 * src/widgets/modest-window.h:
3020 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3021 and modest_window_save_state(), which invokes it.
3023 * src/widgets/modest-window-mgr.h:
3024 * src/widgets/modest-window-mgr.c:
3025 Added modest_window_mgr_save_state_for_all_windows(), which calls
3026 the save_state vfunc on all registered windows, if implemented.
3028 * src/gnome/modest-msg-edit-window.c:
3029 * src/gnome/modest-msg-view-window.c:
3030 * src/maemo/modest-msg-edit-window.c:
3031 * src/maemo/modest-msg-view-window.c:
3032 * src/maemo/modest-main-window.c:
3033 Specify the existing save_settings functions as implementations of
3034 ModestWindow::save_state_func().
3036 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3037 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3038 enabling hibernation, for instance.
3040 We may need to do the same thing for restoring settings.
3043 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3045 * src/widgets/modest-window-mgr.c:
3046 * src/widgets/modest-window-mgr.h:
3047 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3048 modest_window_mgr_get_hibernation_is_prevented().
3050 * src/maemo/modest-main-window.c:
3051 (on_hildon_program_is_topmost_notify): Prevent hibernation
3052 (possible when the application goes to the background in the WM),
3053 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3055 * src/maemo/easysetup/modest-easysetup-wizard.c:
3056 (modest_easysetup_wizard_dialog_init):
3057 * src/maemo/modest-account-settings-dialog.c:
3058 (modest_account_settings_dialog_init):
3059 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3060 (modest_connection_specific_smtp_edit_window_init):
3061 * src/maemo/modest-connection-specific-smtp-window.c:
3062 (modest_connection_specific_smtp_window_init):
3063 * src/maemo/modest-signature-editor-dialog.c:
3064 (modest_signature_editor_dialog_init):
3065 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3066 prevent hibernation while any of these account settings dialogs are open.
3068 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3070 * src/maemo/Makefile.am:
3071 * src/maemo/modest-osso-state-saving.c:
3072 * src/maemo/modest-osso-state-saving.h: Added
3073 modest_osso_load_state() and modest_osso_save_state() though they do
3074 nothing now. They should iterate through all the open windows and load/save
3076 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3077 save state when closing.
3079 * src/maemo/modest-main-window.c:
3080 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3081 Add a notification handler for the HildonProgram::is-topmost property,
3082 so we can allow hibernation when the application goes into the background.
3083 But we still need to detect when the accounts setup windows are open so
3084 we can stop hibernation when they are open.
3085 To do this, I also added the main window the HildonProgram. This might have
3086 other side-effects/benefits, and should maybe be done for other windows.
3088 * src/maemo/modest-osso-autosave-callbacks.h:
3089 * src/maemo/modest-osso-autosave-callbacks.c:
3090 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3091 though it does not do anything yet, and we might never need this to do
3092 anything. For instance, we already save drafts.
3094 * src/maemo/modest-platform.c: (modest_platform_init):
3095 Specify the libosso auto-save callback.
3097 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3099 * src/maemo/modest-platform.c:
3100 (modest_platform_set_update_interval):
3101 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3102 aparently stays valid between application instances, so we can use this
3103 to remove and reset it later. According to a maemo-developers email from
3106 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3108 * configure.ac: Depend on libalarm for Maemo.
3110 * src/dbus_api/modest-dbus-api.h:
3111 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3112 (on_send_receive), (modest_dbus_req_handler):
3113 Handle a SEND_RECEIVE D-Bus method.
3115 * libmodest-dbus-client/libmodest-dbus-client.c:
3116 (libmodest_dbus_client_send_and_receive):
3117 * libmodest-dbus-client/libmodest-dbus-client.h:
3118 Add C convenience functions for calling the new D-Bus method.
3120 * src/modest-platform.h:
3121 * src/gnome/modest-platform.c:
3122 * src/maemo/modest-platform.c:
3123 Added modest_platform_set_update_interval(), which uses the
3124 alarmd API on Maemo.
3125 (modest_platform_init),
3126 Call modest_platform_set_update_interval(), using a hard-coded
3127 interval for now (until the global settings dialog is implemented),
3128 though I am not sure that this makes sense yet.
3130 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3132 * src/dbus_api/modest-dbus-callbacks.c:
3133 (modest_osso_cb_hw_state_handler):
3134 * src/dbus_api/modest-dbus-callbacks.h:
3135 * src/maemo/modest-platform.c: (modest_platform_init):
3136 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3137 in case this has some effect on the ability for Maemo to ping the
3140 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3142 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3143 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3144 warning. It is probably a logic error, but I need to fix the build.
3146 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3148 * src/modest-account-mgr.h:
3149 * src/modest-account-mgr.c:
3150 (modest_account_mgr_account_names): Add a gboolean enabled_only
3151 parameter, so we can get lists of onlt the enabled accounts.
3153 (modest_account_mgr_add_account),,
3154 (modest_account_mgr_account_with_display_name_exists):
3155 * src/maemo/modest-msg-edit-window.c: (get_transports):
3156 * src/modest-account-mgr-helpers.c:
3157 (modest_account_mgr_set_first_account_as_default):
3158 * src/modest-init.c: (init_default_account_maybe):
3159 * src/modest-tny-account-store.c: (get_accounts):
3160 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3161 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3162 * tests/check_account-mgr.c: (START_TEST):
3163 Provide the extra parameter, as appropriate.
3165 * src/widgets/modest-account-view.c: (update_account_view):
3166 Do not show disabled accounts (meaning that there is no way to
3167 enable/disable accounts in the UI (the feature is not in our UI
3168 specification), so we can use this internally only to mark unfinished
3169 or temporary account data.
3171 * src/maemo/easysetup/modest-easysetup-wizard.c:
3172 (create_account): Add boolean enable parameter, so we can specify FALSE
3173 to create the temporary account.
3174 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3175 (on_before_next): When finishing, when there is a temporary account, just
3177 Also, use a timeout to delay the showing of the dialog until gconf is likely
3178 to return correct information, due to a maemo gconf bug that is fixed in
3179 osso 1.1, but not yet in Bora.
3180 However, the dialog stays on screen after it is destroyed.
3182 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3183 for invalid data when cancelling. Use a hildon note instead of a dialog
3184 to complain about invalid data. Do not show the account-saved note if the
3185 account is disabled (a temporary account that will not really be saved for use
3188 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3190 * src/modest-account-mgr-helpers.h:
3191 * src/modest-account-mgr-helpers.c:
3192 Added modest_account_mgr_unset_default_account(),
3193 Added modest_account_mgr_set_first_account_as_default().
3195 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3196 If it was the default account, unset the default account name.
3198 * src/maemo/modest-account-view-window.c:
3199 (on_delete_button_clicked): If it was the default account,
3200 set the first remaining account as the default instead.
3202 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3203 a NULL account or a NULL default account, to prevent a crash. This should
3204 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3207 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3209 * src/widgets/modest-recpt-editor.c:
3210 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3211 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3212 TODO comment for this. This fixes the build.
3214 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3215 be the best place for it. This will in future update all auto-update accounts,
3216 rather than just the current/default account, when that gconf key exists.
3217 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3218 if there are no accounts, before calling do_send_receive().
3219 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3221 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3222 * src/maemo/modest-main-window-ui.h:
3223 * src/maemo/modest-main-window.c: (on_connection_changed),
3224 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3225 directly, becaue the signal handler does more.
3227 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3229 * src/modest-account-mgr-helpers.c:
3230 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3231 for the case that the account does not exist.
3233 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3234 (equivalent to the modest account name) rather than the tinymail account name
3235 (equivalent to the modest account title - human readable) to get the account data.
3236 Check for null account data to prevent the crash, and add a TODO comment saying that
3237 this needs fixing because it is using the server account name instead of the account name.
3239 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3241 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3242 * src/maemo/modest-account-settings-dialog.c: (show_error),
3244 Use hildon_note_new_information() for informative and error messages,
3245 which seems to be expected for Maemo applications (no documentation that I know of
3246 says this). I am surprised that there is no distinction between info and error
3249 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3251 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3252 it is easy to find where this is used.
3254 * src/maemo/easysetup/modest-easysetup-wizard.c:
3255 (create_page_welcome), (create_page_account_details),
3256 (create_page_user_details), (create_page_complete_easysetup),
3257 (create_page_custom_incoming), (create_page_custom_outgoing),
3258 (create_page_complete_custom):
3259 * src/maemo/modest-account-settings-dialog.c:
3260 (create_page_account_details), (create_page_user_details),
3261 (create_page_incoming), (create_page_outgoing):
3262 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3263 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3264 (modest_connection_specific_smtp_edit_window_init):
3265 * src/maemo/modest-connection-specific-smtp-window.c:
3266 (modest_connection_specific_smtp_window_init):
3267 * src/maemo/modest-signature-editor-dialog.c:
3268 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3269 and scrolling policy as per the Email Application Layout Guide, if I have
3272 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3274 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3275 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3276 which were empty, because these vfuncs have been removed from TnyAccountStore.
3277 This fixes the build.
3279 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3281 * src/maemo/modest-main-window.c:
3282 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3283 showing/hiding it. Added TODO because it probably should not be NULL.
3284 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3285 because unnecessary g_warnings() make degugging difficult.
3287 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3289 * src/maemo/modest-msg-edit-window.c:
3290 (modest_msg_edit_window_select_color),
3291 (modest_msg_edit_window_select_background_color): 2 const corrections and
3292 moving 2 #endifs before closing brackets, to fix the build.
3294 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3296 * src/maemo/easysetup/modest-easysetup-wizard.h:
3297 * src/maemo/easysetup/modest-easysetup-wizard.c:
3298 (modest_easysetup_wizard_dialog_finalize),
3299 (on_button_edit_advanced_settings), (create_page_complete_custom),
3300 (on_response), (create_account):
3301 Implement the Advanced Settings edit button, by saving the account information,
3302 for the Advanded Settings dialog to use directly from gconf, and removing it
3303 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3304 Bug #5533 in the projects.maemo.org bugzilla.
3306 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/modest-msg-view-window.c:
3309 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3310 when opening a message window.
3312 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3314 * src/maemo/easysetup/modest-easysetup-wizard.c:
3315 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3318 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3319 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3320 gconf settings. I probably added more checks than necessary, but that is safer.
3322 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3323 variable to fix the build, but this seems to be used when it is still NULL.
3325 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3327 * src/modest-platform.h:
3328 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3329 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3330 * src/modest-main.c: Implement this function so we can avoid using
3331 maemo-specific API from cross-platform code.
3333 * src/modest-tny-account-store.c:
3334 (get_smtp_specific_transport_account_for_open_connection):
3335 * src/modest-ui-actions.c: (check_for_connection),
3336 (modest_ui_actions_on_item_not_found):
3337 Use modest_platform_connect_and_wait() and put #idefs around other
3338 maemo-specific code, because only maemo currently has a way to
3339 identify connection names.
3341 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3343 * src/modest-tny-account-store.h:
3344 * src/modest-tny-account-store.c:
3345 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3346 the connection-specific SMTP server settings in the configuration.
3348 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3350 * src/maemo/modest-main-window.c: (on_connection_changed),
3352 * src/modest-main.c: (main), (start_ui), (send_mail):
3353 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3354 that is what is intended.
3356 * src/modest-ui-actions.c: (action_send), (action_receive),
3357 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3358 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3359 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3360 SMTP server is used when it is specified.
3362 (modest_ui_actions_on_send_receive):
3363 Check that a connection is open before proceeding.
3364 Receive and then send, instead of vice-versa, as per the specification.
3366 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3368 * src/modest-mail-operation.c:
3369 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3370 though I guess it should be something other than NULL.
3372 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3374 * src/maemo/easysetup/modest-easysetup-wizard.c:
3375 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3376 combo twice, to avoid an g_warning and to make it visible again.
3377 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3378 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3379 (already intended) dereference when detaching, because we then recreate the menu.
3380 But I am not sure why the warning was happening, and it is possible that this is a memory
3383 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3385 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3386 and uri_parse_mailto() utility functions.
3387 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3389 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3391 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3393 * src/dbus_api/modest-dbus-api.h:
3394 * src/dbus_api/modest-dbus-callbacks.c:
3395 Use an idle callback to execute the modest code in the application's own thread.
3396 Remove the helloworld example method.
3397 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3398 parsed, and the open-message method is not implemented because this is not yet implemented in
3400 * libmodest-dbus-client/libmodest-dbus-client.c:
3401 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3402 (libmodest_dbus_client_open_message):
3403 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3405 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3406 body without crashing.
3408 * tests/dbus_api/Makefile.am:
3409 * tests/dbus_api/test_mail_to.c:
3410 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3412 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3414 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3415 Added file to fix the build. Sorry.
3417 * src/dbus_api/Makefile.am:
3418 * src/dbus_api/modest-dbus-api.h:
3419 * src/dbus_api/modest-dbus-callbacks.h:
3420 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3421 (modest_dbus_req_handler):
3422 Put constants in a separate header so it can be reused by the
3423 client library, without duplication
3425 * libmodest-dbus-client/Makefile.am:
3426 * libmodest-dbus-client/libmodest-dbus-client.c:
3427 (libmodest_dbus_client_call_helloworld),
3428 (libmodfest_dbus_client_send_mail),
3429 (libmodfest_dbus_client_mailto),
3430 (libmodfest_dbus_client_open_message):
3431 * libmodest-dbus-client/libmodest-dbus-client.h:
3432 (Partly) Implement a send_mail D-Bus method.
3434 * tests/dbus_api/Makefile.am:
3435 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3436 the send_email D-Bus method.
3438 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3442 * libmodest-dbus-client/Makefile.am:
3443 * libmodest-dbus-client/libmodest-dbus-client.c:
3444 * libmodest-dbus-client/libmodest-dbus-client.h:
3445 * tests/dbus_api/Makefile.am:
3446 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3447 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3449 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3451 * src/maemo/easysetup/modest-easysetup-wizard.c:
3452 (create_page_account_details):
3453 * src/maemo/modest-account-settings-dialog.c:
3454 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3455 widgets, because this might not be the default in future versions of the Maemo GTK+.
3456 However, I can not not get capitalization to work even in a simple test case.
3458 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3460 * src/maemo/easysetup/modest-easysetup-wizard.c:
3461 (create_page_custom_incoming), (create_page_custom_outgoing):
3462 * src/maemo/modest-account-settings-dialog.c:
3463 (create_page_account_details), (create_page_incoming),
3464 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3465 instead of using gtk_check_button_with_label(), so they are aligned like the other
3466 widgets, as per the UI spec.
3468 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3470 * src/maemo/easysetup/modest-easysetup-wizard.c:
3471 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3472 * src/widgets/modest-validating-entry.c:
3473 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3474 Modest prefix instead of an EasySetup prefix.
3476 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3478 * src/widgets/modest-validating-entry.h:
3479 * src/widgets/modest-validating-entry.c: (on_insert_text),
3480 Added easysetup_validating_entry_set_max_func(), used to set a callback
3481 to call when the max number of characters is reached. GtkEntry has a max-length
3482 already but is silent about it.
3484 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3485 (create_page_account_details), (create_page_user_details),
3487 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3488 (create_page_account_details), (create_page_user_details),
3489 (create_page_outgoing):
3490 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3491 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3492 the UI spec, when the user tries to enter more than the max number of characters.
3494 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3496 * src/maemo/easysetup/modest-easysetup-wizard.c:
3497 (create_page_user_details), (create_page_custom_incoming),
3498 (create_page_custom_outgoing):
3499 * src/maemo/modest-account-settings-dialog.c:
3500 (create_page_user_details), (create_page_incoming),
3501 (create_page_outgoing):
3502 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3503 (modest_connection_specific_smtp_edit_window_init):
3504 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3505 not appropriate. Bad Maemo-specific defaults!.
3507 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3509 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3510 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3511 (modest_signature_editor_dialog_set_settings):
3512 Disable the label and textview when the checkbox is disabled, and use the
3513 specified (UI spec) default signature text.
3515 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3517 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3518 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3520 * src/modest-defs.h:
3521 * src/modest-account-mgr-helpers.h:
3522 * src/modest-account-mgr-helpers.c:
3523 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3525 * src/maemo/Makefile.am:
3526 * src/maemo/modest-signature-editor-dialog.c:
3527 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3530 * src/maemo/modest-account-settings-dialog.h:
3531 * src/maemo/modest-account-settings-dialog.c:
3532 (modest_account_settings_dialog_finalize), (on_button_signature),
3533 (save_configuration): Use the new dialog when the Edit button is pressed, and
3534 save the changes if necessary, as per the UI spec.
3536 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3538 * src/maemo/Makefile.am:
3539 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3540 based on maemo-develoers email from Dirk.
3542 * src/maemo/easysetup/modest-easysetup-wizard.c:
3543 (create_page_welcome), (create_page_account_details),
3544 (create_page_user_details), (create_page_complete_easysetup),
3545 (create_page_custom_incoming), (create_page_custom_outgoing),
3546 (create_page_complete_custom),
3547 (modest_easysetup_wizard_dialog_init):
3548 * src/maemo/modest-account-settings-dialog.c:
3549 (create_page_account_details), (create_page_user_details),
3550 (create_page_incoming), (create_page_outgoing),
3551 (modest_account_settings_dialog_init):
3552 * src/maemo/modest-connection-specific-smtp-window.c:
3553 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3555 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3557 * src/maemo/easysetup/modest-easysetup-wizard.c:
3558 (create_page_account_details), (create_page_custom_outgoing),
3559 (create_page_complete_custom):
3560 * src/maemo/modest-account-settings-dialog.c:
3561 (create_page_user_details), (create_page_incoming),
3562 (create_page_outgoing):
3563 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3564 (modest_connection_specific_smtp_edit_window_init):
3565 Use the correct (UI spec) port min/max, and use horizontal separators,
3568 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3570 * src/maemo/easysetup/modest-easysetup-wizard.c:
3571 (set_default_custom_servernames):
3572 * src/maemo/modest-account-settings-dialog.c:
3573 (create_page_incoming), (on_combo_outgoing_security_changed),
3574 (on_combo_incoming_security_changed), (create_page_outgoing),
3575 (modest_account_settings_dialog_set_account_name),
3576 (save_configuration):
3577 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3578 (on_combo_security_changed),
3579 (modest_connection_specific_smtp_edit_window_init),
3580 (modest_connection_specific_smtp_edit_window_set_connection),
3581 (modest_connection_specific_smtp_edit_window_get_settings):
3582 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3585 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3588 * src/maemo/easysetup/modest-easysetup-wizard.c:
3589 (create_page_custom_outgoing), (create_page_complete_custom):
3590 * src/maemo/modest-account-settings-dialog.c:
3591 (create_page_user_details), (create_page_outgoing):
3592 * src/maemo/modest-account-view-window.c: (button_box_new):
3593 Use changed logical IDs as per the most recent UI spec:
3594 mcen_bd_emailsetup_edit -> mcen_bd_edit
3595 mcen_bd_emailsetup_delete -> mcen_bd_delete
3596 mcen_bd_emailsetup_close -> mcen_bd_close
3598 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3602 * src/dbus_api/Makefile.am:
3603 * src/dbus_api/modest-dbus-callbacks.c:
3604 * src/dbus_api/modest-dbus-callbacks.h:
3605 * src/maemo/modest-platform.c: (modest_platform_init):
3606 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3608 * tests/Makefile.am:
3609 * tests/dbus_api/Makefile.am:
3610 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3612 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3614 * src/maemo/modest-account-settings-dialog.c:
3615 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3616 Removed unnecessary includes.
3618 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3620 * src/maemo/easysetup/modest-easysetup-wizard.c:
3621 * src/maemo/modest-account-settings-dialog.c:
3622 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3623 * src/widgets/Makefile.am:
3624 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3625 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3626 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3627 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3628 * src/widgets/modest-secureauth-combo-box.c:
3629 * src/widgets/modest-secureauth-combo-box.h:
3630 * src/widgets/modest-serversecurity-combo-box.c:
3631 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3632 made the GObject names more consistent with the rest of the Modest code.
3634 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3636 * src/maemo/easysetup/Makefile.am:
3637 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3638 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3639 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3640 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3641 * src/maemo/easysetup/modest-easysetup-wizard.c:
3642 * src/maemo/easysetup/modest-validating-entry.c:
3643 * src/maemo/easysetup/modest-validating-entry.h:
3644 * src/maemo/modest-account-settings-dialog.c:
3645 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3646 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3647 widgets/ because they are used outside of easysetup too. After checking in,
3648 svn will allow me to rename them too.
3650 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3652 * src/gnome/modest-msg-edit-window.c:
3653 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3654 linker error, to fix the build on the GNOME platform.
3655 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3656 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3657 ifdefed out to avoid a warning.
3659 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3661 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3662 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3663 some alternative for GTK+ 2.6.
3665 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3667 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3669 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3670 specified for EmailAccountsDialog in UI spec.
3672 * src/maemo/easysetup/modest-easysetup-wizard.c:
3673 * src/maemo/easysetup/modest-easysetup-wizard.h:
3674 * src/maemo/modest-account-settings-dialog.c:
3675 * src/maemo/modest-account-settings-dialog.h:
3676 Reuse a member window widget for the connection-specific SMTP server accounts,
3677 so we can tell it to create/save the accounts only if we actually save changes.
3679 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3680 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3681 (modest_connection_specific_smtp_edit_window_get_settings):
3682 Return a struct instance for temporarily remembering the entered data.
3684 * src/maemo/modest-connection-specific-smtp-window.h:
3685 * src/maemo/modest-connection-specific-smtp-window.c:
3686 (modest_connection_specific_smtp_window_finalize),
3687 (modest_connection_specific_smtp_window_fill_with_connections),
3689 (modest_connection_specific_smtp_window_save_server_accounts),
3690 (update_model_server_names): Do not actually save data until asked,
3691 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3693 (on_selection_changed),
3694 (modest_connection_specific_smtp_window_init): Disable the edit
3695 button when nothing is selected.
3697 * src/modest-account-mgr-helpers.c:
3698 * src/modest-account-mgr-helpers.h:
3699 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3702 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3704 * src/modest-account-mgr-helpers.h:
3705 * src/modest-account-mgr-helpers.c:
3706 (modest_account_mgr_get_unused_account_name),
3707 (modest_account_mgr_get_unused_account_display_name): Added these
3708 utility functions, to avoid code duplication.
3710 * src/maemo/easysetup/modest-easysetup-wizard.c:
3711 (create_page_account_details), (create_account):
3712 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3713 (on_combo_security_changed),
3714 (modest_connection_specific_smtp_edit_window_init),
3715 (modest_connection_specific_smtp_edit_window_save_settings):
3716 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3717 * src/maemo/modest-connection-specific-smtp-window.c:
3718 (modest_connection_specific_smtp_window_finalize),
3719 (modest_connection_specific_smtp_window_fill_with_connections),
3720 (on_button_edit), (modest_connection_specific_smtp_window_init):
3721 * src/maemo/modest-connection-specific-smtp-window.h:
3722 Implementing saving of connection-specific server accounts.
3724 But I need to refactor this so we can save the data for each
3725 possible connection-specific account and only actually create the server accounts
3726 when the easysetup finished, or the OK button is pressed on the account settings
3729 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3731 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3732 (on_combo_security_changed):
3733 (modest_connection_specific_smtp_edit_window_init):
3734 Auto-fill the port number as in the account settings.
3736 (modest_connection_specific_smtp_edit_window_set_connection):
3737 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3738 * src/maemo/modest-connection-specific-smtp-window.c:
3739 (fill_with_connections), (on_button_edit),
3740 (modest_connection_specific_smtp_window_init):
3741 Turn the edit window into a dialog to simplify the code, and
3742 set a WM hint as in a GtkDialog, because only a popup can be on top of
3743 another window in Maemo, and popups usually have no WM decoration.
3745 * src/modest-defs.h:
3746 * src/modest-account-mgr-helpers.c:
3747 (modest_account_mgr_set_connection_specific_smtp),
3748 (modest_account_mgr_remove_connection_specific_smtp),
3749 (modest_account_mgr_get_connection_specific_smtp):
3750 * src/modest-account-mgr-helpers.h: Some functions to write the
3751 connection-specific SMTP server information. Not yet used.
3754 * src/widgets/modest-folder-view.c: (text_cell_data):
3755 Fix a warning about an uninitialized variable.
3756 (on_configuration_key_changed): Put an #ifdef around the use
3757 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3759 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3761 * src/maemo/modest-account-settings-dialog.h:
3762 * src/maemo/modest-account-settings-dialog.c:
3763 Added connect_for_modified() utility function to mark the new modified boolean.
3765 (create_page_account_details), (create_page_user_details),
3766 (create_page_incoming), (create_page_outgoing), (on_response),
3767 (modest_account_settings_dialog_init),
3768 (modest_account_settings_dialog_set_account_name):
3769 Only warn about unsaved changes when there are actually unsaved changes.
3771 * src/modest-account-mgr-helpers.c:
3772 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3773 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3774 to get the data from there in future.
3776 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3778 * src/modest-defs.h:
3780 * src/modest-account-mgr-helpers.h:
3781 * src/modest-account-mgr-helpers.c:
3782 Store the security account setting in a single conf key instead of using
3783 the options list, so that the list is left for just the to-be-removed camel hack,
3784 and because gconf_client_set_list() is failing for some reason.
3786 * src/modest-account-mgr.c:
3787 (modest_account_mgr_add_server_account):
3788 * src/maemo/modest-account-settings-dialog.c:
3789 (modest_account_settings_dialog_set_account_name),
3790 (save_configuration): Use the renamed functions.
3793 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3795 * src/widgets/Makefile.am:
3796 * src/widgets/modest-limit-retrieve-combo-box.c:
3797 * src/widgets/modest-limit-retrieve-combo-box.h:
3798 * src/widgets/modest-retrieve-combo-box.c:
3799 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3800 the account settings dialog.
3802 * src/modest-defs.h:
3803 * src/modest-account-mgr-helpers.h:
3804 * src/modest-account-mgr-helpers.c:
3805 (modest_server_account_get_option_secure_auth),
3806 (modest_server_account_set_option_secure_auth):
3807 * src/modest-account-mgr.c:
3808 (modest_account_mgr_add_server_account):
3809 Use the existing AUTH_MECH conf key for the secure-auth setting,
3810 instead of putting it in the list options, because this was actually used already.
3812 * src/maemo/modest-account-settings-dialog.c:
3813 (create_page_account_details),
3814 (modest_account_settings_dialog_set_account_name),
3815 (save_configuration):
3816 * src/maemo/modest-account-settings-dialog.h:
3817 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3818 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3820 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3822 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3823 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3824 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3826 * src/modest-defs.h:
3827 * src/maemo/modest-account-settings-dialog.c:
3828 (create_page_incoming), (on_combo_outgoing_security_changed),
3829 (on_combo_incoming_security_changed), (create_page_outgoing),
3830 (modest_account_settings_dialog_set_account_name),
3831 (save_configuration): Load/Save the port number, and change it when the
3832 security combo changes, to suitable defaults.
3834 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3836 * src/modest-account-mgr.c:
3837 (modest_account_mgr_add_server_account): Set the security and secure-auth
3838 options, and add a comment saying that the other camel-specific options should be
3841 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3843 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3845 * src/modest-tny-account-store.c: (account_list_free),
3846 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3847 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3850 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3852 * src/modest-protocol-info.c:
3853 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3854 is required by our UI spec. Maybe something in our implementation will use this eventually.
3855 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3856 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3857 instead of the previous 0 placeholder.
3859 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3860 secure-auth settings.
3861 * src/modest-account-mgr-helpers.h:
3862 * src/modest-account-mgr-helpers.c:
3863 (modest_server_account_data_get_option_secure_auth),
3864 (modest_server_account_set_option_secure_auth),
3865 (modest_server_account_data_get_option_security),
3866 (modest_server_account_set_option_security): Added this API for getting and setting the security
3867 and secure-auth settings.
3869 * src/maemo/modest-account-settings-dialog.h:
3870 * src/maemo/modest-account-settings-dialog.c:
3871 (modest_account_settings_dialog_finalize), (check_data),
3872 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3873 about changing titles.
3874 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3875 (save_configuration): Save the security and secure-auth settings.
3877 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3878 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3880 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3882 * src/modest-defs.h:
3883 * src/modest-account-mgr.c:
3884 (modest_account_mgr_add_server_account):
3885 Added and used defines for the options key and value pair strings,
3886 that are used so far, though they do not seem to correspond to anything in our
3887 UI specs or ModestProtocol enum.
3889 * src/modest-account-mgr-helpers.h:
3890 * src/modest-account-mgr-helpers.c:
3891 (compare_option_strings_for_name),
3892 (modest_server_account_data_get_option_value),
3893 (modest_server_account_data_get_option_bool),
3894 (modest_account_mgr_get_server_account_option):
3895 Added helper functions for parsing the options GSList.
3897 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3899 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3900 display name is based on the supplied account name.
3901 * src/modest-account-mgr.c:
3902 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3903 with an inefficient, but good-enough, implementation.
3905 * src/maemo/easysetup/modest-easysetup-wizard.c:
3906 (create_page_account_details), (on_before_next), (create_account):
3907 Check for existing display names rather than (non-user-visible) account names, and just
3908 create and set a unique account name at the end.
3910 * src/maemo/modest-account-settings-dialog.c:
3911 (modest_account_settings_dialog_init),
3912 (modest_account_settings_dialog_set_account_name),
3913 (create_page_incoming): Show the display name, instead of the account name.
3914 (on_response): Do some (not all) extra checks, as in the UI spec.
3915 (save_configuration): Save the display name if it was changed.
3917 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3919 * po/en_GB.po: Added needed logical ID and translation.
3920 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3921 (init_view): Made the is-default column clicking work.
3923 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3926 * src/maemo/easysetup/Makefile.am:
3927 * src/maemo/easysetup/modest-easysetup-wizard.c:
3928 (modest_easysetup_wizard_dialog_init):
3929 * src/maemo/easysetup/provider-data-test.keyfile:
3930 * src/maemo/easysetup/provider-data.keyfile:
3931 Moved the provider data file to the new modest-providers-data package and used it from there.
3933 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3935 * src/modest-local-folder-info.c:
3936 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3937 N_() was already used on the static strings, but this just marks it for translation without
3938 using the translation.
3940 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3942 * src/maemo/modest-account-settings-dialog.c:
3943 (create_page_incoming),
3944 (modest_account_settings_dialog_set_account_name):
3945 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3946 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3947 I will do this if nobody else gets there first.
3949 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3951 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3952 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3953 save the security stuff.
3955 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3957 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3958 Set the email address and user fullname, which I now see must be
3961 * src/maemo/modest-account-settings-dialog.h:
3962 * src/maemo/modest-account-settings-dialog.c:
3964 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3965 leave-on-server and authentication.
3966 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3969 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3972 * src/maemo/modest-account-settings-dialog.c:
3973 * src/maemo/modest-account-settings-dialog.h:
3974 Most (but not all) of the widgets are now present as specified by the UI spec.
3975 No changes are yet saved, and some details are not properly shown yet.
3977 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3979 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3981 * src/maemo/Makefile.am:
3982 * src/maemo/modest-account-settings-dialog.c:
3983 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3984 an existing account. Doesn't do much yet.
3986 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3987 Open the accounts settings dialog when Edit is clicked.
3989 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3991 * src/maemo/easysetup/Makefile.am:
3992 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3994 * src/maemo/easysetup/modest-easysetup-wizard.c:
3995 (modest_easysetup_wizard_dialog_init):
3996 Try to get the source directory from the build system,
3997 instead of hard-coding "./" into the source code, when opening our local
3998 copies of the configuration files.
3999 But this still fails when opening the wizard from the Accounts window,
4000 maybe because the working directory seems to change at runtime.
4001 So the wizard will fail the second time unless you copy the files into their
4002 proper locations - see the stdout warnings for the paths.
4004 (create_page_account_details),(on_before_next):
4005 Check for existing non-server accounts instead of server accounts,
4006 so the default account name is useful again, and to prevent trying to
4009 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4010 Show the wizard when New is clicked.
4012 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4013 (init_view): Show the column headers, and show the columns that are
4014 specified in the UI specs. However, something in Maemo's GTK+ prevents
4015 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4016 change the default account. This is despite unsetting the special properties.
4018 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4020 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4021 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4022 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4023 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4024 to make that clearer.
4025 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4027 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4029 * src/maemo/modest-account-view-window.c:
4030 (modest_account_view_window_init),
4031 (modest_account_view_window_new):
4032 Use the same buttons as specified in the
4033 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4034 the existing widgets, which never had a chance of working.
4035 Put the ModestAccountView treeview in a scrolled window.
4036 Do not repeat the initialization in both _init() and _new().
4038 * src/widgets/modest-account-view.c: (update_account_view):
4039 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4040 this widget and window shows no accounts.
4042 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4044 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4046 * src/maemo/easysetup/modest-easysetup-wizard.c:
4047 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4048 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4049 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4052 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4053 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4054 accounts exist yet, as in the UI spec.
4056 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4058 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4060 * src/maemo/Makefile.am:
4061 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4062 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4063 New window for editing connection-specific smtp details.
4064 Not fully implemented.
4066 * src/maemo/modest-connection-specific-smtp-window.c:
4067 (modest_connection_specific_smtp_window_finalize) :
4068 unref the tree model.
4069 (on_button_edit): Show the edit window.
4071 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4073 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4076 * src/maemo/Makefile.am:
4077 * src/maemo/modest-connection-specific-smtp-window.c:
4078 * src/maemo/modest-connection-specific-smtp-window.h:
4079 New window for showing the list of connections, for connection-specific
4080 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4081 * src/maemo/easysetup/modest-easysetup-wizard.c:
4082 (create_page_custom_outgoing): Show the new window when the button is clicked.
4084 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4086 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4087 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4088 * src/maemo/modest-msg-edit-window.c:
4089 (modest_msg_edit_window_insert_image):
4090 * src/modest-conf.c: (modest_conf_key_escape):
4091 * src/modest-mail-operation.c:
4092 (modest_mail_operation_send_new_mail):
4093 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4094 (modest_ui_actions_on_new_account):
4095 * src/widgets/modest-attachment-view.c: (update_filename_request):
4096 * src/widgets/modest-mail-header-view.c:
4097 Corrected warnings that were breaking the build, by commenting out unused variables,
4098 and a function, and by including a header.
4100 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4102 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4103 so we can #ifdef around platform-specific code when necessary.
4104 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4105 to allow this to build for the GNOME platform too.
4107 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4109 * src/maemo/easysetup/modest-easysetup-wizard.c:
4110 Added util_increment_name() and used it in create_page_account_details()
4111 to make sure that the default account name is always a new name.
4113 (modest_easysetup_wizard_dialog_init),
4114 (set_default_custom_servernames): Some minor memory management fixes.
4116 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4120 * src/modest-runtime.c: (init_i18n): Restored the translation
4121 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4122 are defined in config.h, and the translations are installed.
4124 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4125 is defined for translation.
4127 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4129 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4131 * src/maemo/easysetup/modest-easysetup-wizard.c:
4132 (modest_easysetup_wizard_dialog_init):
4133 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4134 Use realistic paths (though they should use $prefix generically) to the
4135 mcc_mapping and provider-data.keyfile files which might work when they
4136 are installed by the future version of the operator-wizard package,
4137 and then fallback to paths in our source code, with an explanatory
4140 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4144 * src/maemo/Makefile.am:
4145 * src/maemo/easysetup/: Added files from the previously-exernal
4146 osso-modest-easysetup.
4147 * src/maemo/modest-main-window-ui.h:
4148 * src/modest-ui-actions.c:
4149 * src/modest-ui-actions.h:
4150 Added modest_ui_actions_on_new_account() as a signal handler for the
4151 New Account menu item. It shows the easysetup wizard.
4152 * po/en_GB.po: Added additional needed logical IDs and translations.