2007-04-20 Murray Cumming <murrayc@murrayc.com>
[modest] / ChangeLog2
1 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
2
3         * po/en_GB.po:
4         * src/maemo/easysetup/modest-easysetup-wizard.c:
5         (create_page_custom_outgoing), (create_page_complete_custom):
6         * src/maemo/modest-account-settings-dialog.c:
7         (create_page_user_details), (create_page_outgoing):
8         * src/maemo/modest-account-view-window.c: (button_box_new):
9         Use changed logical IDs as per the most recent UI spec:
10         mcen_bd_emailsetup_edit -> mcen_bd_edit
11         mcen_bd_emailsetup_delete -> mcen_bd_delete
12         mcen_bd_emailsetup_close -> mcen_bd_close
13
14 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
15
16         * configure.ac:
17         * src/Makefile.am:
18         * src/dbus_api/Makefile.am:
19         * src/dbus_api/modest-dbus-callbacks.c:
20         * src/dbus_api/modest-dbus-callbacks.h:
21         * src/maemo/modest-platform.c: (modest_platform_init):
22         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld 
23         method.
24         * tests/Makefile.am:
25         * tests/dbus_api/Makefile.am:
26         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
27
28 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
29
30         * src/maemo/modest-account-settings-dialog.c:
31         * src/maemo/modest-connection-specific-smtp-edit-window.c:
32         Removed unnecessary includes.
33
34 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
35
36         * src/maemo/easysetup/modest-easysetup-wizard.c:
37         * src/maemo/modest-account-settings-dialog.c:
38         * src/maemo/modest-connection-specific-smtp-edit-window.c:
39         * src/widgets/Makefile.am:
40         * src/widgets/modest-easysetup-secureauth-combo-box.c:
41         * src/widgets/modest-easysetup-secureauth-combo-box.h:
42         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
43         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
44         * src/widgets/modest-secureauth-combo-box.c:
45         * src/widgets/modest-secureauth-combo-box.h:
46         * src/widgets/modest-serversecurity-combo-box.c:
47         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and 
48         made the GObject names more consistent with the rest of the Modest code.
49
50 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
51
52         * src/maemo/easysetup/Makefile.am:
53         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
54         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
55         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
56         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
57         * src/maemo/easysetup/modest-easysetup-wizard.c:
58         * src/maemo/easysetup/modest-validating-entry.c:
59         * src/maemo/easysetup/modest-validating-entry.h:
60         * src/maemo/modest-account-settings-dialog.c:
61         * src/maemo/modest-connection-specific-smtp-edit-window.c:
62         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into 
63         widgets/ because they are used outside of easysetup too. After checking in, 
64         svn will allow me to rename them too.
65
66 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
67
68         * src/gnome/modest-msg-edit-window.c:
69         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a 
70         linker error, to fix the build on the GNOME platform.
71         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(), 
72         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
73         ifdefed out to avoid a warning.
74
75 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
76
77         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the 
78         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs 
79         some alternative for GTK+ 2.6.
80
81 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
82
83         * src/maemo/modest-address-book.c: Added include to avoid a warning.
84
85         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string, 
86         specified for EmailAccountsDialog in UI spec.
87         
88         * src/maemo/easysetup/modest-easysetup-wizard.c:
89         * src/maemo/easysetup/modest-easysetup-wizard.h:
90         * src/maemo/modest-account-settings-dialog.c:
91         * src/maemo/modest-account-settings-dialog.h:
92         Reuse a member window widget for the connection-specific SMTP server accounts, 
93         so we can tell it to create/save the accounts only if we actually save changes.
94
95         * src/maemo/modest-connection-specific-smtp-edit-window.h:      
96         * src/maemo/modest-connection-specific-smtp-edit-window.c:
97         (modest_connection_specific_smtp_edit_window_get_settings): 
98         Return a struct instance for temporarily remembering the entered data.
99
100         * src/maemo/modest-connection-specific-smtp-window.h:
101         * src/maemo/modest-connection-specific-smtp-window.c:
102         (modest_connection_specific_smtp_window_finalize),
103         (modest_connection_specific_smtp_window_fill_with_connections),
104         (on_button_edit),
105         (modest_connection_specific_smtp_window_save_server_accounts),
106         (update_model_server_names): Do not actually save data until asked, 
107         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
108         
109         (on_selection_changed),
110         (modest_connection_specific_smtp_window_init): Disable the edit 
111         button when nothing is selected.
112         
113         * src/modest-account-mgr-helpers.c:
114         * src/modest-account-mgr-helpers.h: 
115         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct 
116         elsewhere.
117
118 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
119
120         * src/modest-account-mgr-helpers.h:
121         * src/modest-account-mgr-helpers.c:
122         (modest_account_mgr_get_unused_account_name),
123         (modest_account_mgr_get_unused_account_display_name): Added these 
124         utility functions, to avoid code duplication.
125
126         * src/maemo/easysetup/modest-easysetup-wizard.c:
127         (create_page_account_details), (create_account):
128         * src/maemo/modest-connection-specific-smtp-edit-window.c:
129         (on_combo_security_changed),
130         (modest_connection_specific_smtp_edit_window_init),
131         (modest_connection_specific_smtp_edit_window_save_settings):
132         * src/maemo/modest-connection-specific-smtp-edit-window.h:
133         * src/maemo/modest-connection-specific-smtp-window.c:
134         (modest_connection_specific_smtp_window_finalize),
135         (modest_connection_specific_smtp_window_fill_with_connections),
136         (on_button_edit), (modest_connection_specific_smtp_window_init):
137         * src/maemo/modest-connection-specific-smtp-window.h:
138         Implementing saving of connection-specific server accounts.
139         
140         But I need to refactor this so we can save the data for each 
141         possible connection-specific account and only actually create the server accounts 
142         when the easysetup finished, or the OK button is pressed on the account settings 
143         dialog.
144
145 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
146
147         * src/maemo/modest-connection-specific-smtp-edit-window.c:
148         (on_combo_security_changed): 
149         (modest_connection_specific_smtp_edit_window_init):
150         Auto-fill the port number as in the account settings.
151         
152         (modest_connection_specific_smtp_edit_window_set_connection):
153         * src/maemo/modest-connection-specific-smtp-edit-window.h:
154         * src/maemo/modest-connection-specific-smtp-window.c:
155         (fill_with_connections), (on_button_edit),
156         (modest_connection_specific_smtp_window_init): 
157         Turn the edit window into a dialog to simplify the code, and 
158         set a WM hint as in a GtkDialog, because only a popup can be on top of 
159         another window in Maemo, and popups usually have no WM decoration.
160         
161         * src/modest-defs.h:
162         * src/modest-account-mgr-helpers.c:
163         (modest_account_mgr_set_connection_specific_smtp),
164         (modest_account_mgr_remove_connection_specific_smtp),
165         (modest_account_mgr_get_connection_specific_smtp):
166         * src/modest-account-mgr-helpers.h: Some functions to write the 
167         connection-specific SMTP server information. Not yet used.
168
169         
170         * src/widgets/modest-folder-view.c: (text_cell_data):
171         Fix a warning about an uninitialized variable.
172         (on_configuration_key_changed): Put an #ifdef around the use 
173         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
174
175 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
176
177         * src/maemo/modest-account-settings-dialog.h:
178         * src/maemo/modest-account-settings-dialog.c:
179         Added connect_for_modified() utility function to mark the new modified boolean.
180         
181         (create_page_account_details), (create_page_user_details),
182         (create_page_incoming), (create_page_outgoing), (on_response),
183         (modest_account_settings_dialog_init),
184         (modest_account_settings_dialog_set_account_name):
185         Only warn about unsaved changes when there are actually unsaved changes.
186         
187         * src/modest-account-mgr-helpers.c:
188         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information 
189         into the ModestServerAccountData struct. I do not use it yet, but someone might expect 
190         to get the data from there in future.
191
192 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
193
194         * src/modest-defs.h:
195
196         * src/modest-account-mgr-helpers.h:
197         * src/modest-account-mgr-helpers.c:
198         Store the security account setting in a single conf key instead of using 
199         the options list, so that the list is left for just the to-be-removed camel hack, 
200         and because gconf_client_set_list() is failing for some reason.
201
202         * src/modest-account-mgr.c:
203         (modest_account_mgr_add_server_account):
204         * src/maemo/modest-account-settings-dialog.c:
205         (modest_account_settings_dialog_set_account_name),
206         (save_configuration): Use the renamed functions.
207
208
209 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
210
211         * src/widgets/Makefile.am:
212         * src/widgets/modest-limit-retrieve-combo-box.c:
213         * src/widgets/modest-limit-retrieve-combo-box.h:
214         * src/widgets/modest-retrieve-combo-box.c:
215         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in 
216         the account settings dialog.
217         
218         * src/modest-defs.h:
219         * src/modest-account-mgr-helpers.h:
220         * src/modest-account-mgr-helpers.c:
221         (modest_server_account_get_option_secure_auth),
222         (modest_server_account_set_option_secure_auth):
223         * src/modest-account-mgr.c:
224         (modest_account_mgr_add_server_account):
225         Use the existing AUTH_MECH conf key for the secure-auth setting, 
226         instead of putting it in the list options, because this was actually used already.
227         
228         * src/maemo/modest-account-settings-dialog.c:
229         (create_page_account_details),
230         (modest_account_settings_dialog_set_account_name),
231         (save_configuration):
232         * src/maemo/modest-account-settings-dialog.h:
233         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
234         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
235
236 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
237
238         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
239         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
240         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
241
242         * src/modest-defs.h:
243         * src/maemo/modest-account-settings-dialog.c:
244         (create_page_incoming), (on_combo_outgoing_security_changed),
245         (on_combo_incoming_security_changed), (create_page_outgoing),
246         (modest_account_settings_dialog_set_account_name),
247         (save_configuration): Load/Save the port number, and change it when the 
248         security combo changes, to suitable defaults.
249
250 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
251
252         * src/modest-account-mgr.c:
253         (modest_account_mgr_add_server_account): Set the security and secure-auth 
254         options, and add a comment saying that the other camel-specific options should be 
255         removed in future.
256
257 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
258
259         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something, 
260         found by valgrind.
261         * src/modest-tny-account-store.c: (account_list_free),
262         (on_account_changed): Add a TODO comment about a valgrind error, caused by using 
263         cursor->data after unreffing it. But there is some strange stuff there so it might not be 
264         easy to fix.
265
266 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
267
268         * src/modest-protocol-info.c:
269         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it 
270         is required by our UI spec. Maybe something in our implementation will use this eventually.
271         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c: 
272         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value 
273         instead of the previous 0 placeholder.
274         
275         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and 
276         secure-auth settings.
277         * src/modest-account-mgr-helpers.h:
278         * src/modest-account-mgr-helpers.c:
279         (modest_server_account_data_get_option_secure_auth),
280         (modest_server_account_set_option_secure_auth),
281         (modest_server_account_data_get_option_security),
282         (modest_server_account_set_option_security): Added this API for getting and setting the security 
283         and secure-auth settings.
284         
285         * src/maemo/modest-account-settings-dialog.h:
286         * src/maemo/modest-account-settings-dialog.c:
287         (modest_account_settings_dialog_finalize), (check_data),
288         (on_response): Store the original title as well as the name, to avoid unnececessary warnings 
289         about changing titles.
290         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
291         (save_configuration): Save the security and secure-auth settings.
292
293         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this 
294         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
295
296 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
297
298         * src/modest-defs.h: 
299         * src/modest-account-mgr.c:
300         (modest_account_mgr_add_server_account):
301         Added and used defines for the options key and value pair strings, 
302         that are used so far, though they do not seem to correspond to anything in our 
303         UI specs or ModestProtocol enum.
304         
305         * src/modest-account-mgr-helpers.h:
306         * src/modest-account-mgr-helpers.c:
307         (compare_option_strings_for_name),
308         (modest_server_account_data_get_option_value),
309         (modest_server_account_data_get_option_bool),
310         (modest_account_mgr_get_server_account_option):
311         Added helper functions for parsing the options GSList.
312
313 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
314
315         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial 
316         display name is based on the supplied account name.
317         * src/modest-account-mgr.c:
318         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(), 
319         with an inefficient, but good-enough, implementation.
320         
321         * src/maemo/easysetup/modest-easysetup-wizard.c:
322         (create_page_account_details), (on_before_next), (create_account): 
323         Check for existing display names rather than (non-user-visible) account names, and just 
324         create and set a unique account name at the end.
325         
326         * src/maemo/modest-account-settings-dialog.c:
327         (modest_account_settings_dialog_init),
328         (modest_account_settings_dialog_set_account_name),
329         (create_page_incoming): Show the display name, instead of the account name.
330         (on_response): Do some (not all) extra checks, as in the UI spec.
331         (save_configuration): Save the display name if it was changed.
332
333 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
334
335         * po/en_GB.po: Added needed logical ID and translation.
336         * src/widgets/modest-account-view.c: (on_account_default_toggled),
337         (init_view): Made the is-default column clicking work.
338
339 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
340
341         * configure.ac:
342         * src/maemo/easysetup/Makefile.am:
343         * src/maemo/easysetup/modest-easysetup-wizard.c:
344         (modest_easysetup_wizard_dialog_init):
345         * src/maemo/easysetup/provider-data-test.keyfile:
346         * src/maemo/easysetup/provider-data.keyfile: 
347         Moved the provider data file to the new modest-providers-data package and used it from there.
348
349 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
350
351         * src/modest-local-folder-info.c:
352         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string. 
353         N_() was already used on the static strings, but this just marks it for translation without 
354         using the translation.
355
356 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
357
358         * src/maemo/modest-account-settings-dialog.c:
359         (create_page_incoming),
360         (modest_account_settings_dialog_set_account_name): 
361         Added comments about the need for new API in ModestAccountMgr to handle the authentication 
362         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
363         I will do this if nobody else gets there first.
364
365 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
366
367         * src/maemo/modest-account-settings-dialog.c: (save_configuration): 
368         Saved much of the incoming and outgoing data too, though I cannot yet see how to 
369         save the security stuff.
370
371 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
372
373         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): 
374         Set the email address and user fullname, which I now see must be 
375         done separately.
376         
377         * src/maemo/modest-account-settings-dialog.h:
378         * src/maemo/modest-account-settings-dialog.c:
379          (on_response),
380         (modest_account_settings_dialog_set_account_name): Show the email address, fullname, 
381         leave-on-server and authentication.
382         (save_configuration): Save most of the non-server-account specific stuff, but I don't see 
383         how to do the rest.
384
385 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
386
387
388         * src/maemo/modest-account-settings-dialog.c:
389         * src/maemo/modest-account-settings-dialog.h:
390         Most (but not all) of the widgets are now present as specified by the UI spec.
391         No changes are yet saved, and some details are not properly shown yet.
392         
393         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
394
395 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
396
397         * src/maemo/Makefile.am:
398         * src/maemo/modest-account-settings-dialog.c:
399         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit 
400         an existing account. Doesn't do much yet.
401         
402         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): 
403         Open the accounts settings dialog when Edit is clicked.
404
405 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
406
407         * src/maemo/easysetup/Makefile.am:
408         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
409         (load_from_file): 
410         * src/maemo/easysetup/modest-easysetup-wizard.c:
411         (modest_easysetup_wizard_dialog_init):
412         Try to get the source directory from the build system,
413         instead of hard-coding "./" into the source code, when opening our local 
414         copies of the configuration files.
415         But this still fails when opening the wizard from the Accounts window, 
416         maybe because the working directory seems to change at runtime.
417         So the wizard will fail the second time unless you copy the files into their 
418         proper locations - see the stdout warnings for the paths.
419         
420         (create_page_account_details),(on_before_next): 
421         Check for existing non-server accounts instead of server accounts, 
422         so the default account name is useful again, and to prevent trying to 
423         recreate accounts.
424         
425         * src/maemo/modest-account-view-window.c: (on_new_button_clicked): 
426         Show the wizard when New is clicked.
427         
428         * src/widgets/modest-account-view.c: (on_account_default_toggled),
429         (init_view): Show the column headers, and show the columns that are 
430         specified in the UI specs. However, something in Maemo's GTK+ prevents 
431         us from handling the GtkCellRendererToggle::toggled signal, so we cannot 
432         change the default account. This is despite unsetting the special properties.
433
434 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
435
436         * docs/reference/modest-design.sgml: Corrected spelling mistake.
437         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): 
438         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
439         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation 
440         to make that clearer.
441         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
442
443 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
444
445         * src/maemo/modest-account-view-window.c:
446         (modest_account_view_window_init),
447         (modest_account_view_window_new):
448         Use the same buttons as specified in the 
449         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to 
450         the existing widgets, which never had a chance of working.
451         Put the ModestAccountView treeview in a scrolled window.
452         Do not repeat the initialization in both _init() and _new().
453         
454         * src/widgets/modest-account-view.c: (update_account_view):
455         Add a warning about modest_account_mgr_account_names() returning NULL, which is why 
456         this widget and window shows no accounts.
457         
458         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
459         
460 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
461
462         * src/maemo/easysetup/modest-easysetup-wizard.c:
463         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
464         (create_account): Do a sanity check, showing that modest_account_mgr_account_names() 
465         returns NULL after modest_account_mgr_add_server_account() returned TRUE, 
466         which seems wrong.
467         
468         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
469         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no 
470         accounts exist yet, as in the UI spec.
471         
472         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
473
474 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
475
476         * src/maemo/Makefile.am:
477         * src/maemo/modest-connection-specific-smtp-edit-window.c:
478         * src/maemo/modest-connection-specific-smtp-edit-window.h: 
479         New window for editing connection-specific smtp details.
480         Not fully implemented.
481
482         * src/maemo/modest-connection-specific-smtp-window.c:
483         (modest_connection_specific_smtp_window_finalize) :
484         unref the tree model.
485         (on_button_edit): Show the edit window.
486
487 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
488
489         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol 
490         error for me.
491         
492         * src/maemo/Makefile.am:
493         * src/maemo/modest-connection-specific-smtp-window.c:
494         * src/maemo/modest-connection-specific-smtp-window.h:
495         New window for showing the list of connections, for connection-specific 
496         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
497         * src/maemo/easysetup/modest-easysetup-wizard.c:
498         (create_page_custom_outgoing): Show the new window when the button is clicked.
499
500 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
501
502         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
503         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
504         * src/maemo/modest-msg-edit-window.c:
505         (modest_msg_edit_window_insert_image):
506         * src/modest-conf.c: (modest_conf_key_escape):
507         * src/modest-mail-operation.c:
508         (modest_mail_operation_send_new_mail):
509         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
510         (modest_ui_actions_on_new_account):
511         * src/widgets/modest-attachment-view.c: (update_filename_request):
512         * src/widgets/modest-mail-header-view.c: 
513         Corrected warnings that were breaking the build, by commenting out unused variables, 
514         and a function, and by including a header.
515
516 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
517
518         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h, 
519         so we can #ifdef around platform-specific code when necessary.
520         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO 
521         to allow this to build for the GNOME platform too.
522
523 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
524
525         * src/maemo/easysetup/modest-easysetup-wizard.c:
526         Added util_increment_name() and used it in create_page_account_details() 
527         to make sure that the default account name is always a new name.
528         
529         (modest_easysetup_wizard_dialog_init), 
530         (set_default_custom_servernames): Some minor memory management fixes.
531
532 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
533
534         * Makefile.am:
535         * configure.ac:
536         * src/modest-runtime.c: (init_i18n): Restored the translation 
537         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR 
538         are defined in config.h, and the translations are installed.
539         
540         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE 
541         is defined for translation.
542
543 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
544
545         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
546         (load_from_file):
547         * src/maemo/easysetup/modest-easysetup-wizard.c:
548         (modest_easysetup_wizard_dialog_init):
549         * src/maemo/easysetup/modest-presets.c: (modest_presets_new): 
550         Use realistic paths (though they should use $prefix generically) to the 
551         mcc_mapping and provider-data.keyfile files which might work when they 
552         are installed by the future version of the operator-wizard package, 
553         and then fallback to paths in our source code, with an explanatory 
554         warning.
555
556 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
557
558         * configure.ac:
559         * src/Makefile.am:
560         * src/maemo/Makefile.am:
561         * src/maemo/easysetup/: Added files from the previously-exernal 
562         osso-modest-easysetup.
563         * src/maemo/modest-main-window-ui.h:
564         * src/modest-ui-actions.c: 
565         * src/modest-ui-actions.h:
566         Added modest_ui_actions_on_new_account() as a signal handler for the 
567         New Account menu item. It shows the easysetup wizard.
568         * po/en_GB.po: Added additional needed logical IDs and translations.
569         
570 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
571 Apparently ChangeLog is not used for some vague Nokia legal reasons.
572