1 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 (get_serverport_incoming), (on_before_next), (create_account):
5 * src/maemo/modest-account-settings-dialog.c:
6 (modest_account_settings_dialog_set_account_name):
7 * src/maemo/modest-maemo-utils.c:
8 (on_camel_account_get_supported_secure_authentication_status),
9 (on_camel_account_get_supported_secure_authentication),
10 (on_secure_auth_cancel),
11 (modest_maemo_utils_get_supported_secure_authentication_methods):
13 Implemented security authentication for settings and easysetup.
15 2007-06-05 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/modest-main-window.c: (create_details_widget):
18 Show the total size for memory card accounts too, instead of showing
19 the name again. Fixes bug projects.maemo.org bug NB#59307.
21 2007-06-05 Murray Cumming <murrayc@murrayc.com>
24 * src/modest-tny-simple-folder-store.c:
25 * src/modest-tny-simple-folder-store.h: Removed.
27 * src/modest-tny-local-folders-account.h
28 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
29 for the local-folders maildir, with an extra TnyMergedFolder containing
30 the folders of the per-account outbox store accounts.
31 * src/modest-tny-account-store.c: (get_server_accounts):
32 Add the outboxes to the special local folders account after creating it.
34 * src/modest-tny-account.c:
35 (modest_tny_account_new_for_local_folders): Create the derived
36 account when creating the main local-folders account.
38 * src/maemo/modest-main-window.c: (create_details_widget),
39 (modest_main_window_set_contents_style):
40 Adapted to the use of the derived account instead of the folder store.
42 * src/modest-ui-actions.c:
43 (modest_ui_actions_on_folder_selection_changed):
44 * src/modest-ui-dimming-rules.c:
45 (modest_ui_dimming_rules_on_new_folder):
46 * src/widgets/modest-folder-view.c: (text_cell_data),
47 (icon_cell_data), (filter_row), (update_model),
48 (get_cmp_rows_type_pos):
51 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
52 Do not get the priv struct, because no priv struct has been set,
53 to avoid a runtime warning.
55 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
56 #ifelse with #else, to fix a warning, to fix the build.
59 2007-06-05 Christian Kellner <ckellner@openismus.com>
61 * libmodest-dbus-client/libmodest-dbus-client.c:
62 Fix small typo in doc (why do you always see them
63 AFTER committing stuff?)
66 2007-06-05 Christian Kellner <ckellner@openismus.com>
68 * libmodest-dbus-client/libmodest-dbus-client.c:
69 (libmodest_dbus_client_search):
70 Initialize hit list with NULL. Also set folder list
71 to "" if NULL was supplied.
74 2007-06-03 Christian Kellner <ckellner@openismus.com>
76 * libmodest-dbus-client/libmodest-dbus-client.c:
77 (modest_search_hit_list_free):
78 Make it save to call it with NULL.
80 * src/dbus_api/modest-dbus-callbacks.c:
81 * src/modest-search.c:
82 Return full ModestSearchHits as the search result list not TnyHeader
83 since can't be around withouth the correspoding TnyFolder.
85 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
87 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
88 Added currently commented code to check for secure auth
90 * src/maemo/modest-account-settings-dialog.c: (on_response),
91 (save_configuration), (show_ok):
92 Fixed projects.maemo.org bugs NB #59248 and #59251
94 * src/maemo/modest-maemo-utils.c:
95 (on_camel_account_get_supported_secure_authentication_status),
96 (on_camel_account_get_supported_secure_authentication),
97 (modest_maemo_utils_get_supported_secure_authentication_methods):
98 * src/maemo/modest-maemo-utils.h:
99 Moved get_supported_secure_authentication() method here to be able
100 to use it from easysetup wizard.
102 * src/modest-pair.c: (on_pair_compare_as_string):
103 Should compare string with first part of pair and not
104 strcmp pairs which will crash.
106 * src/modest-protocol-info.c:
107 (modest_protocol_info_protocol_is_store):
108 * src/modest-protocol-info.h:
109 Added modest_protocol_info_get_auth_protocol_name()
111 2007-06-03 Armin Burgmeier <armin@openismus.com>
113 * src/modest-mail-operation.c:
114 (modest_mail_operation_get_msgs_full): Set priv->account also when
115 only retrieving a single message. This avoids a crash when canceling
118 (modest_mail_operation_notify_end): Do not explicitely remove the
119 operation from the queue but only emit the progress_changed signal.
120 The queue itself listens to that signal to remove the operation when
121 it is finished. This reduces coupling and removes a potential deadlock
122 when modest_mail_operation_notify_end() is called from the queue
123 itself. If that is a problem performance-wise, I would suggest to
124 implement a status-changed signal or something.
126 * src/modest-mail-operation-queue.c: Make sure to never call a
127 function from another file while the queue is locked. This (hopefully)
128 fixes another deadlock when exiting the application while retrieving
131 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
133 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
134 Fixed build if libogs is not available
136 2007-06-03 Christian Kellner <ckellner@openismus.com>
138 * libmodest-dbus-client/libmodest-dbus-client.h:
139 * libmodest-dbus-client/libmodest-dbus-client.c:
140 (libmodest_dbus_client_delete_message):
141 Implement deletion of messages (Client side).
143 (modest_search_hit_free),
144 (modest_search_hit_list_free):
145 Utility functions to free the result hits.
147 * src/dbus_api/modest-dbus-api.h:
148 * src/dbus_api/modest-dbus-callbacks.c:
150 (modest_dbus_req_handler):
151 Implement deletion of messages (Server side).
153 * tests/dbus_api/test_search.c: (main):
156 * tests/dbus_api/Makefile.am:
157 * tests/dbus_api/test_delete_message:
158 Add little test for the message deletion logic
160 2007-06-03 Armin Burgmeier <armin@openismus.com>
162 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
163 when the operation queue was not empty. projects.maemo.org bug
166 2007-06-03 Armin Burgmeier <armin@openismus.com>
168 * src/widgets/modest-account-view.c
169 (on_account_default_toggled): Toggle default account column
170 explicitely instead of waiting for gconf notification (which is
171 currently ignored). This should fix projects.maemo.org bug NB#56910
172 for now. It should probably be removed when gconf notifications are
175 2007-06-03 Christian Kellner <ckellner@openismus.com>
177 * libmodest-dbus-client/libmodest-dbus-client.c:
178 Removed debugging spew.
180 * src/dbus_api/modest-dbus-callbacks.c:
181 Added debugging info.
183 * src/modest-search.c:
184 (modest_search_all_accounts):
185 Use tny_account_store_get_accounts () on the account store
186 to get all accounts which is the way to get all accounts.
188 * tests/dbus_api/test_search.c: (main):
189 Make it possible to supply the search term on the command line.
191 2007-06-03 Christian Kellner <ckellner@openismus.com>
193 * libmodest-dbus-client/libmodest-dbus-client.c:
194 * libmodest-dbus-client/libmodest-dbus-client.h:
195 Implement searching for mesages over raw dbus. (Client side)
197 * src/dbus_api/Makefile.am:
198 * src/dbus_api/modest-dbus-api.h:
199 * src/dbus_api/modest-dbus-callbacks.c:
200 * src/dbus_api/modest-dbus-callbacks.h:
201 Search framework (Server side). Also implement on_idle_open_message().
203 * src/maemo/modest-platform.c: (modest_platform_init):
204 Prepare for raw dbus/osso rpc interaction.
206 * src/modest-search.h:
207 Changed minsize from unspecific guint to guint32.
209 * src/modest-search.c:
211 Added strange hack which magically made tnymail work.
213 (modest_search_folder),
214 (modest_search_account),
215 (modest_search_all_accounts):
216 Implement helper functions to search all accounts, specific account
219 * tests/dbus_api/Makefile.am:
220 * tests/dbus_api/test_open_message.c:
221 Read url to open from commandline.
223 * tests/dbus_api/test_search.c:
224 Implement small test for dbus search stuff
226 2007-06-02 Armin Burgmeier <armin@openismus.com>
228 * src/maemo/modest-account-settings-dialog.c: Changed window title to
229 include account type and account title. This fixes projects.maemo.org
232 * src/maemo/modest-account-view-window.c: Set a title for the window.
234 2007-06-02 Armin Burgmeier <armin@openismus.com>
236 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
237 incoming and outgoing server name based on email address and server
238 types as long as the names have not been edited manually. This fixes
239 projects.maemo.org bug NB#58671.
241 2007-06-02 Armin Burgmeier <armin@openismus.com>
243 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
244 server type cannot be changed in future to the incoming details page
245 when creating an account. This fixes projects.maemo.org bug NB#59029.
247 2007-06-02 Armin Burgmeier <armin@openismus.com>
249 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
250 and assigned max width chars so that they wrap instead of being
251 truncated. Fixes projects.maemo.org bug NB#56126.
253 2007-06-02 Armin Burgmeier <armin@openismus.com>
255 * src/maemo/modest-connection-specific-smtp-window.c: Add an
256 introductory note to the connection specific smtp servers dialog, as
257 section 8.12 of the email UI specification requires. This fixes
258 projects.maemo.org bug NB#59212.
260 2007-06-01 Murray Cumming <murrayc@murrayc.com>
262 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
263 Check for running mail operations, and offer to cancel them, as per the UI
264 spec. This fixes projects.maemo.org bug NB#59041 .
265 However, I suspect that tinymail may still use the network connection
266 in ways that we cannot detect or cancel. But it should at least adapt to
269 2007-06-01 Murray Cumming <murrayc@murrayc.com>
271 * src/modest-tny-account-store.c: (recreate_all_accounts),
272 (get_cached_accounts), (get_server_accounts): Do more sensible
273 ref-counting of the temporarily-cached outbox accounts list. This seems
274 to fix a crash when entering the password when the password was wrong.
276 2007-06-01 Murray Cumming <murrayc@murrayc.com>
278 * src/gnome/modest-main-window.c: (connect_signals):
279 * src/modest-tny-account-store.c: (get_password),
280 (modest_tny_account_store_alert): Added comments and clues and
281 commented-out code about how we currently fail to deal with connection
282 errors and wrong passwords, and how we should.
284 2007-06-01 Murray Cumming <murrayc@murrayc.com>
286 * src/widgets/modest-retrieve-combo-box.c:
287 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
288 This fixes projects.maemo.org bug NB#58472 .
290 2007-06-01 Murray Cumming <murrayc@murrayc.com>
292 * src/maemo/easysetup/modest-easysetup-wizard.c:
293 (create_page_complete_easysetup):
294 (create_page_complete_custom): Correct the last commit,
295 putting the correct sentences in the correct pages.
297 2007-06-01 Murray Cumming <murrayc@murrayc.com>
299 * src/maemo/easysetup/modest-easysetup-wizard.c:
300 (create_page_complete_custom): Show the second sentence of text
301 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
304 2007-06-01 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
307 Set the leave-on-server conf key by default. This fixes
308 projects.maemo.org bug NB#59258 .
310 2007-06-01 Murray Cumming <murrayc@murrayc.com>
312 * src/maemo/modest-account-view-window.c:
313 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
314 logical ID for the confirmation messages. Fixed projects.maemo.org bug
317 2007-06-01 Murray Cumming <murrayc@murrayc.com>
319 * src/maemo/easysetup/modest-easysetup-wizard.c:
320 (create_caption_new_with_asterisk):
321 * src/maemo/modest-account-settings-dialog.c:
322 (create_caption_new_with_asterisk):
323 Uncomment the code to add the asterisk, because they are no longer in the
324 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
325 (update_incoming_server_title): Add an asterisk here too.
327 2007-06-01 Murray Cumming <murrayc@murrayc.com>
329 * src/maemo/modest-maemo-global-settings-dialog.c:
330 (current_connection): Check that we are even connected before trying to
331 get the current connection name, to prevent a warning.
333 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
334 Change the comments because tny_maemo_conic_device_connect() is now meant to
336 * src/modest-mail-operation.c:
337 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
338 make sure we have a connection and fail if we can't connect.
340 2007-05-31 Murray Cumming <murrayc@murrayc.com>
342 * src/maemo/modest-main-window.c:
343 (on_account_store_connecting_finished): Do not try to get the
344 connection ID if we are not really connected. I am surprised that
345 this signal handler is called when we are not connected.
347 2007-05-31 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-error.h:
350 * src/modest-ui-actions.c:
351 (modest_ui_actions_get_msgs_full_error_handler):
352 Renamed an enum, added comments, added an enum
353 for retrieve-limit errors.
355 * src/modest-mail-operation.c: (foreach_add_item),
356 (internal_folder_observer_update), (update_account_thread),
357 (modest_mail_operation_get_msgs_full):
358 (modest_mail_operation_update_account),
359 Added comments about how this works, and some code that should
360 (but does not) check the retrieve-limit. See the TODO comment.
362 2007-05-31 Murray Cumming <murrayc@murrayc.com>
364 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
365 Initialize help_id to fix the build. Warnings are good.
367 2007-05-31 Murray Cumming <murrayc@murrayc.com>
369 * src/widgets/modest-hbox-cell-renderer.c:
370 (modest_hbox_cell_renderer_append):
371 * src/widgets/modest-vbox-cell-renderer.c:
372 (modest_vbox_cell_renderer_append):
373 Fix the last commit by doing an extra ref.
375 2007-05-31 Murray Cumming <murrayc@murrayc.com>
377 * src/widgets/modest-hbox-cell-renderer.c:
378 (modest_hbox_cell_renderer_append):
379 * src/widgets/modest-vbox-cell-renderer.c:
380 (modest_vbox_cell_renderer_append):
381 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
382 to fix the build with Maemo Bora.
383 However, there seems to be a remaining crash, probably due to reference
386 2007-05-30 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-tny-account.c:
389 (modest_tny_account_new_for_local_folders):
390 Use hildon_file_system_info_async_new() to get a better name for
391 the memory card account, setting it as the account name.
392 The timing seems to work, but this is probably
393 not the best place to do this. See the TODO comment.
394 * src/maemo/modest-main-window.c: (create_details_widget):
395 * src/widgets/modest-folder-view.c: (text_cell_data):
396 Use the tny account name instead of hardcoding a name.
398 2007-05-30 Christian Kellner <ckellner@openismus.com>
400 * src/modest-search.c: (modest_search):
401 Correctly set part_search_func even if we have already parsed
402 the query and thus a valid OgsTextSearcher object.
404 2007-05-30 Christian Kellner <ckellner@openismus.com>
407 Search and check for libogs.
410 Incooparte the ogs build env.
412 * src/modest-mime-part-search-stream.c:
413 * src/modest-mime-part-search-stream.h:
414 Removed since we do the real searching now in modest-search.c.
416 * src/modest-search.c:
417 * src/modest-search.h:
418 Implement support for ogs. We use that if available and requested
419 and fall back to modest_text_utils_utf8_strcmp (). The search logic
420 should now handle the corner case when the search term is spread
421 across multiple reads.
422 Also the logic in modest_search () was corrected to search all
423 requested fields until one is found.
425 2007-05-30 Murray Cumming <murrayc@murrayc.com>
427 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
430 * src/modest-init.c: Made modest_init_local_folders() take a
431 path and be public so we can iniitialize maildir folders on
434 * src/modest-local-folder-info.h:
435 * src/modest-local-folder-info.c:
436 (modest_local_folder_info_get_maildir_path): Add a path parameter.
438 * src/modest-tny-account.c:
439 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
440 still means the standard local-folders path on the local volume.
442 * src/modest-tny-account-store.c:
443 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
444 signal so we can detect mount/unmount of the MMC1 card, and do an update of
445 all accounts when that happens.
446 (get_server_accounts): If the MMC1 card is mounted, create a store account for
447 this too, so it shows up in the treeview.
449 2007-05-28 Murray Cumming <murrayc@murrayc.com>
451 * src/maemo/modest-maemo-global-settings-dialog.c:
452 (current_connection):
453 * src/widgets/modest-global-settings-dialog.c:
454 (current_connection_default):
455 Use the enum values instead of 0, 1 and -1,
456 to make the code clearer.
458 * src/modest-account-mgr-helpers.c:
459 (modest_account_mgr_get_connection_specific_smtp): Make this code
462 * src/modest-runtime.h:
463 * src/modest-runtime.c:
464 Added modest_runtime_remove_all_send_queues().
465 * src/maemo/modest-main-window.c:
466 (on_account_store_connecting_finished): Recreate the send queues,
467 using the appropriate transport accounts for this new connection.
468 Some futher adapting might be needed if the old send queues are not
469 automatically stopped at this point.
471 * src/modest-tny-account-store.c: (get_server_accounts):
472 Create the connection-specific transport accounts, so that they can
473 be found later by their ID.
475 * src/modest-tny-account.h:
476 * src/modest-tny-account.c:
477 Added modest_tny_account_new_from_server_account_name().
478 modest_tny_account_new_from_server_account(): Do not create the
479 send queues here, because they will be
480 recreated anyway when the connection changes for the first time.
482 2007-05-28 Murray Cumming <murrayc@murrayc.com>
484 * src/modest-local-folder-info.h:
485 * src/modest-local-folder-info.c:
486 (modest_per_account_local_outbox_folder_info_get_maildir_path),
487 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
488 tbox_folder): Take a modest account name instead of a server TnyAccount,
489 so we can have per-modest-account rather than per-transport-account
491 We must make sure that we change or recreate the exisitng send queues
492 when the connection changes for connection-specific transport accounts.
494 * src/modest-tny-account-store.c:
495 (create_per_account_local_outbox_folders): Create outboxed per modest
496 account, not per transport account.
498 * src/modest-tny-account.h:
499 * src/modest-tny-account.c:
500 (modest_tny_account_get_special_folder): For outboxes, get the
501 parent modest account name. The account is ignored for other folders.
502 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
503 modest account name rather than a server TnyAccount.
505 2007-05-25 Murray Cumming <murrayc@murrayc.com>
507 * src/modest-tny-account.c:
508 (modest_tny_account_new_from_server_account):
509 Call modest_runtime_get_send_queue() immediately after creating transport
510 accounts, so that they start trying to send email from the outbox as soon
511 as possible at startup. This is probably what we want.
513 * src/modest-mail-operation.c: (update_account_thread):
514 * src/modest-runtime.c: (modest_runtime_get_send_queue):
515 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
516 * src/modest-tny-send-queue.h:
517 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
518 (modest_ui_actions_on_send):
519 Added comments about how sending works, though it needs some more work.
521 2007-05-25 Murray Cumming <murrayc@murrayc.com>
523 * src/modest-tny-account.c:
524 (modest_tny_account_get_special_folder): Add TODO because this fails when
526 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
527 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
528 Do not try to show this window when there is no active account. The UI
529 specs does not tell us what to do in this case.
531 2007-05-24 Murray Cumming <murrayc@murrayc.com>
535 * src/maemo/Makefile.am:
536 * src/widgets/Makefile.am: Some dist fixes.
538 2007-05-24 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/modest-connection-specific-smtp-window.c:
541 (on_button_edit): Make the code clearer, to prevent a double free.
543 2007-05-24 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/modest-account-settings-dialog.c:
546 (modest_account_settings_dialog_set_account_name),
547 Check the connection-specific smtp servers checkbox if there are any.
549 * src/maemo/modest-connection-specific-smtp-edit-window.c:
550 (modest_connection_specific_smtp_edit_window_init):
551 Start with a suitable port number.
553 * src/modest-account-mgr-helpers.h:
554 * src/modest-account-mgr-helpers.c: Added
555 modest_account_mgr_get_has_connection_specific_smtp().
557 (modest_account_mgr_set_connection_specific_smtp),
558 (modest_account_mgr_remove_connection_specific_smtp),
559 (modest_account_mgr_get_has_connection_specific_smtp),
560 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
561 connection-specific smtp server accounts in the account, rather than
562 the server account conf dir.
564 This fixes bug projects.maemo.org bug NB#58263 .
566 * src/modest-tny-account-store.c:
567 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
568 if there are no server accounts yet, to prevent an infinite loop when there
569 are no accounts. Document that one must be called before the other.
571 2007-05-24 Murray Cumming <murrayc@murrayc.com>
573 * src/modest-account-mgr-helpers.c:
574 (modest_account_mgr_get_default_account): Make sure that at least
575 one account is always the default, if there are any enabled accounts.
576 This is just a sanity check that shouldn't be necessary.
578 * src/modest-account-mgr-priv.c:
579 (_modest_account_mgr_account_from_key): Unescape the conf key to
580 get the real account name. For instance, this is an issue if a space
581 was in the account name, which can happen because the account name
582 is generated from the display name.
583 (_modest_account_mgr_get_account_keyname): Always escape the
585 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
586 Unescape the conf keys to get the real account names.
588 For instance, previously the is-default radio button in the accounts
589 list was not checked for any accounts at first. This fixes that,
590 and might fix several similar bugs.
592 2007-05-23 Murray Cumming <murrayc@murrayc.com>
594 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
595 Removed some debug printfs.
597 2007-05-23 Murray Cumming <murrayc@murrayc.com>
599 Modest on-disk outbox directories are now here, for instance:
600 $HOME/.modest/outboxes/<account-id-1>/outbox
601 $HOME/.modest/outboxes/<account-id-2>/outbox
603 $HOME/.modest/local-folders/outbox
604 so we can have a separate outbox for each account.
605 But they are shown as one outbox in the GtkTreeView, by using a
606 TnyMergeFolder in a ModestTnySimpleFolderStore.
609 * src/modest-tny-simple-folder-store.c:
610 * src/modest-tny-simple-folder-store.h:
611 Added ModestTnySimpleFolderStore, used to contain folders from
612 other folder stores, such as other accounts.
614 * src/modest-tny-outbox-account.h:
615 * src/modest-tny-outbox-account.c:
616 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
617 used for the per-account local outbox folders.
619 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
620 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
621 only use this (internally) now for the non-outbox local folders.
624 * src/modest-init.c: Added modest_init_one_local_folder(), for
625 setting up the directory structure for each local folder.
627 * src/modest-local-folder-info.c:
628 (modest_per_account_local_outbox_folder_info_get_maildir_path),
629 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
631 * src/modest-local-folder-info.h:
632 * src/modest-tny-account-store.c: (on_account_removed),
633 (on_account_changed), (create_per_account_local_outbox_folders),
634 (get_server_accounts), (modest_tny_account_store_get_accounts),
635 (modest_tny_account_store_get_tny_account_by_account),
636 (modest_tny_folder_store_is_virtual_local_folders):
638 * src/modest-tny-account.h:
639 * src/modest-tny-account.c:
640 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
641 to create an on-disk per-account local outbox folder for each
643 (create_per_account_local_outbox_folders): Create a local outbox folder
644 for each transport account.
645 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
646 for all local folders.
648 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
649 instead of using g_object_get/set() directly. It is clearer.
651 (modest_tny_folder_store_get_message_count),
652 (modest_tny_folder_store_get_local_size
653 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
654 because we now use these with non-acount folder stores.
656 (modest_tny_account_get_special_folder),
657 (modest_tny_account_new_from_server_account),
658 (modest_tny_account_new_from_account):
659 (recurse_folders): Adjust to the new outbox system.
661 * src/modest-tny-folder.h:
662 * src/modest-tny-folder.c:
663 (modest_tny_folder_is_local_folder),
664 (modest_tny_folder_get_local_folder_type),
665 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
667 * src/widgets/modest-main-window.h:
668 * src/maemo/modest-main-window.c: (create_details_widget),
669 (modest_main_window_set_contents_style): Show details for any folder store,
672 (modest_tny_folder_get_rules):
673 Remove the const. C does not support constness enough for this.
675 * src/modest-ui-actions.c:
676 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
677 make all outboxes appear as one, in the usual local-folders tree node.
679 (set_active_account_from_tny_account),
680 (modest_ui_actions_on_folder_selection_changed):
681 * src/widgets/modest-folder-view.c: (text_cell_data),
682 (icon_cell_data), (filter_row),
683 (add_account_folders_to_merged_folder),
684 (add_account_folders_to_simple_folder_store), (),
685 (get_cmp_rows_type_pos), (cmp_rows),
686 (modest_folder_view_set_account_id_of_visible_server_account):
687 Adjust to the new outbox system, using generic folder stores and folders
690 2007-05-23 Christian Kellner <ckellner@openismus.com>
692 * src/modest-mail-operation.c:
693 (modest_mail_operation_update_account):
694 Use info->max_size instead of unintialized local var [small
695 build fix]. (Added TODO to review that change since I don't
698 2007-05-23 Marcus Bauer <marcusb@openismus.com>
700 * libmodest-dbus-client/libmodest-dbus-client.c:
701 (libmodest_dbus_client_compose_mail): function added
702 * src/dbus_api/modest-dbus-api.h:
703 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
704 (on_compose_mail): Implementation of the SendAsMail functionality
706 2007-05-22 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-account-mgr.c:
709 (modest_account_mgr_add_server_account): Set the secure-connection
710 conf key for transport accounts as well as store accounts. I don't know
711 why the if was there. For instance, this makes sure that we use SSL
712 for the gmail preset from the easysetup wizard.
714 2007-05-22 Murray Cumming <murrayc@murrayc.com>
716 * src/gnome/modest-main-window.c:
717 (on_account_store_connecting_finished), (connect_signals):
718 * src/maemo/modest-main-window.c:
719 (on_account_store_connecting_finished), (connect_signals),
720 (modest_main_window_new):
721 Handle TnyAccountStore::connecting-finished instead of
722 TnyDevice::connection-changed, because we cannot actually perform
723 operations on accounts until TnyAccountStore has itself responded to
724 the TnyDevice::connection-changed signal. This prevents a GError from
726 Do not try to update at startup, because we (at least on scratchbox)
727 already do an update at startup when the device goes online.
728 This prevents a GError from tinymail.
729 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
730 Added TODO about stopping simultaneous operations.
732 2007-05-21 Murray Cumming <murrayc@murrayc.com>
734 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
735 * src/modest-mail-operation-queue.c:
736 (modest_mail_operation_queue_remove):
737 * src/modest-tny-account-store.c: When GErrors happen, give more clues
738 about where they happened.
740 2007-05-21 Murray Cumming <murrayc@murrayc.com>
742 * src/modest-ui-actions.c:
743 (modest_ui_actions_on_password_requested): Make sure that the remember
744 output parameter is always TRUE.
746 2007-05-21 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
749 Show a OK/Cancel dialog if the error is a question, though we still do not
750 know anything more about what we are asking the user.
751 * src/widgets/modest-folder-view.c: (on_drag_data_received):
752 Fix an uninitialized variable (helper). This is a logic error, however.
754 2007-05-21 Christian Kellner <ckellner@openismus.com>
756 * src/modest-search.h:
757 Correct bit shifting in the ModestSearchFlags enum.
759 2007-05-21 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-tny-account.c:
762 (modest_tny_account_new_from_server_account): Do not use the lsub and
763 check-all hard-coded IMAP options when using POP.
765 2007-05-21 Murray Cumming <murrayc@murrayc.com>
767 * src/modest-tny-account.c:
768 (modest_tny_account_new_from_server_account):
769 Use NULL for the secure-auth method for POP when Password auth has been
770 specified by the user, as we already do for IMAP. "auth=Login" causes
771 an error from camel or the server.
773 2007-05-17 Murray Cumming <murrayc@murrayc.com>
775 * src/maemo/modest-account-settings-dialog.c:
776 (create_page_account_details),
777 (modest_account_settings_dialog_set_account_name):
778 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
779 for the leave-on-server checkbox, rathr than just the checkbox, when
780 the protocol is not POP.
782 2007-05-17 Murray Cumming <murrayc@murrayc.com>
784 * src/widgets/modest-account-view.c:
785 * src/widgets/modest-account-view.h:
786 Added modest_account_view_select_account() which will be useful later
787 to asynchronously re-select the edited account.
789 2007-05-17 Murray Cumming <murrayc@murrayc.com>
791 * src/maemo/modest-account-settings-dialog.c:
792 (modest_account_settings_dialog_set_account_name):
793 Automatically choose the port numbers based on the secure authentication
794 methods, if they have not been chosen before.
795 This fixes projects.maemo.org bug NB#56273 .
797 2007-05-17 Murray Cumming <murrayc@murrayc.com>
799 * src/maemo/modest-main-window-ui.h:
800 * src/modest-ui-actions.c:
801 * src/modest-ui-actions.h:
802 Connect the Tools/SMTP Servers menu item to
803 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
804 SMTP servers dialog, as in the UI specification and saves changes when it
805 is closed. This fixed projects.maemo.org bug NB#56305 .
807 2007-05-17 Murray Cumming <murrayc@murrayc.com>
809 * src/maemo/modest-connection-specific-smtp-window.c:
810 (modest_connection_specific_smtp_window_init):
811 Use gtk_window_set_default_size() to make this window big enough, so
812 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
814 2007-05-17 Murray Cumming <murrayc@murrayc.com>
816 * src/maemo/modest-connection-specific-smtp-edit-window.h:
817 * src/maemo/modest-connection-specific-smtp-edit-window.c:
818 (modest_connection_specific_smtp_edit_window_init),
819 Do not try to connect to a combobox signal before the combobox exists.
820 This fixes the cras in projects.maemo.org bug NB#56288 .
821 (modest_connection_specific_smtp_edit_window_get_settings):
822 Remove the server_account_name parameter which was being checked for NULL
823 though it was not used.
825 * src/maemo/modest-connection-specific-smtp-window.c:
826 (modest_connection_specific_smtp_window_fill_with_connections),
827 (on_button_edit), (modest_connection_specific_smtp_window_init):
828 Correct the number of treemodel columns to prevent a warning.
829 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
830 libconic does not work.
832 2007-05-16 Murray Cumming <murrayc@murrayc.com>
834 * src/modest-tny-account.c:
835 (modest_tny_account_new_from_server_account):
836 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
837 SMTP when "None" was chosen by the user. However, with my SMTP server that
838 does not support ANONYMOUS, the emails do not leave the Outbox and I see
841 2007-05-16 Murray Cumming <murrayc@murrayc.com>
843 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
844 to explain the memory management issue with the ID in the ModestPair.
846 * src/gnome/modest-account-assistant.c: (add_receiving_page),
847 (add_sending_page), (modest_account_assistant_finalize):
848 * src/gnome/modest-gnome-global-settings-dialog.c:
849 (create_updating_page), (create_composing_page):
850 * src/gnome/modest-msg-edit-window.c: (get_transports),
851 (init_window), (modest_msg_edit_window_finalize),
852 (modest_msg_edit_window_get_msg_data):
853 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
854 * src/gnome/modest-transport-widget.c:
855 (modest_transport_widget_finalize), (smtp_configuration):
856 * src/maemo/modest-maemo-global-settings-dialog.c:
857 (create_updating_page), (create_composing_page):
858 * src/maemo/modest-msg-edit-window.c: (get_transports),
859 (init_window), (modest_msg_edit_window_finalize),
860 (modest_msg_edit_window_get_msg_data),
861 (modest_msg_edit_window_free_msg_data):
862 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
863 (modest_store_widget_finalize):
864 * src/maemo/modest-transport-widget.c:
865 (modest_transport_widget_finalize), (smtp_configuration):
866 * src/modest-main.c: (send_mail):
867 * src/widgets/modest-combo-box.h:
868 * src/widgets/modest-global-settings-dialog-priv.h:
869 * src/widgets/modest-global-settings-dialog.c:
870 (modest_global_settings_dialog_finalize):
871 * src/widgets/modest-msg-edit-window.h:
872 Whenever using modest_combo_box_new(), keep the ModestPairList alive
873 as long as the combo box, to prevent use of freed memory for the ID.
875 2007-05-15 Murray Cumming <murrayc@murrayc.com>
877 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
878 get_accounts(), to make this clearer. Do not check for the enabled gconf
879 key, because we do not use this for server accounts (at least, not yet).
880 This allows us to send email again.
882 2007-05-15 Murray Cumming <murrayc@murrayc.com>
884 * src/maemo/modest-platform.c:
885 (on_modest_conf_update_interval_changed), (modest_platform_init):
886 Only respond to this particular key change. All these strcmp()s cannot be
889 2007-05-15 Murray Cumming <murrayc@murrayc.com>
891 * src/maemo/modest-maemo-global-settings-dialog.c:
892 (current_connection): Prevent a crash in scratchbox when
893 ny_maemo_conic_device_get_current_iap_id() returns NULL.
894 * src/maemo/modest-platform.c:
895 (on_modest_conf_update_interval_changed), (modest_platform_init):
896 Get the update interval from gconf and reset it when the gconf key changes.
898 2007-05-15 Murray Cumming <murrayc@murrayc.com>
900 * src/modest-protocol-info.c:
901 * src/modest-protocol-info.h: Adde enum-specific get functions,
902 instead of using a ModestProtocolType enum parameter.
904 * src/gnome/modest-account-assistant.c:
905 * src/gnome/modest-store-widget.c:
906 * src/gnome/modest-store-widget.h:
907 * src/gnome/modest-transport-widget.c:
908 * src/gnome/modest-transport-widget.h:
909 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
910 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
911 * src/maemo/easysetup/modest-easysetup-wizard.c:
912 * src/maemo/modest-account-settings-dialog.c:
913 * src/maemo/modest-account-settings-dialog.h:
914 * src/maemo/modest-store-widget.c:
915 * src/maemo/modest-store-widget.h:
916 * src/maemo/modest-transport-widget.c:
917 * src/maemo/modest-transport-widget.h:
918 * src/modest-account-mgr-helpers.c:
919 * src/modest-account-mgr-helpers.h:
920 * src/modest-account-mgr.c:
921 * src/modest-account-mgr.h:
922 * src/modest-tny-account.c:
923 * src/modest-tny-folder.c:
924 * src/widgets/modest-account-view.c:
925 * src/widgets/modest-retrieve-combo-box.c:
926 * src/widgets/modest-retrieve-combo-box.h:
927 * src/widgets/modest-secureauth-combo-box.c:
928 * src/widgets/modest-serversecurity-combo-box.c:
929 * src/widgets/modest-serversecurity-combo-box.h:
930 * tests/check_account-mgr.c:
931 Use the specific functions, and use the re-renamed enum values for GNOME too.
933 2007-05-15 Murray Cumming <murrayc@murrayc.com>
936 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
937 so we can get the second based on the first.
939 * src/maemo/modest-account-settings-dialog.h:
940 * src/maemo/modest-account-settings-dialog.c:
941 Added get_supported_secure_authentication_methods(), though it is mostly
942 commented-out for now until the necessary API is committed to tinymail.
943 (modest_account_settings_dialog_set_account_name),
944 (save_configuration): Request the supported authentication methods from the
945 server, so we can choose a working method.
947 * src/modest-tny-account-store.h:
948 * src/modest-tny-account-store.c:
949 (modest_tny_account_store_get_session): Rename from
950 tny_account_store_get_session().
952 2007-05-14 Murray Cumming <murrayc@murrayc.com>
954 * src/modest-protocol-info.h: Split the ModestProtocol enum
955 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
956 There was no need to have these unrelated values in one enum.
958 * src/: many files: Adapted to changed enum. This makes the code a bit
959 clearer, and the compiler could catch some errors.
961 2007-05-14 Murray Cumming <murrayc@murrayc.com>
963 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
964 Show the detailed internal camel error message when an error happens
965 during the configuration, so that our testers can give us more clues.
966 For instance, in projects.maemo.org bug NB#56910 .
968 2007-05-14 Murray Cumming <murrayc@murrayc.com>
970 * src/modest-tny-account.c:
971 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
972 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
974 2007-05-14 Murray Cumming <murrayc@murrayc.com>
976 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
977 * src/maemo/modest-account-settings-dialog.c:
978 (modest_account_settings_dialog_set_account_name),
979 (save_configuration): For the incoming secure authentication checkbox,
980 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
981 the UI specification. PLAIN does not seem to be supported for most IMAP
982 servers anyway, and I am not sure what it would mean.
983 However, we probably need to discover which of the secure-authentication
984 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
985 * src/modest-account-mgr-helpers.c:
986 (modest_account_mgr_get_server_account_data):
988 * src/modest-tny-account.c:
989 (modest_tny_account_new_from_server_account):
990 Use tny_account_set_mech() to set secure-authentication methods,
991 with some special-casing for IMAP, based on my observations of how
994 * src/modest-account-mgr-helpers.h:
995 * src/modest-account-mgr.c:
996 * src/modest-defs.h: Comment that the URI is only used for local folders.
998 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1000 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1001 parameter const, just to be neat.
1002 * src/modest-text-utils.c: (modest_text_utils_inline):
1003 End g_strconcat() with NULL, as its documentation says. This is almost
1004 certainly the cause of my crash at startup on the device. Interestingly,
1005 valgrind doesn't tell us about these errors.
1007 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1009 * scripts/build-packages: Added more precise comments about how to use
1010 this script, though I still get this error:
1011 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1012 error building tinymail
1014 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1016 * src/maemo/modest-main-window.c: (on_account_update):
1017 Very slight cleanup, hoping to make it simpler to discover what causes
1018 a crash here sometimes.
1020 * src/modest-tny-account.c:
1021 (modest_tny_account_new_from_server_account): Set the port. Added
1022 comments about the options and a TODO comment because I need to find out
1023 how to specify the secure authentication method.
1025 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1027 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1028 changed CFlags paths form modest to libmodest
1030 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-account-mgr-helpers.c:
1033 (modest_account_mgr_get_server_account_data),
1034 (modest_account_mgr_free_server_account_data):
1035 * src/modest-account-mgr-helpers.h:
1036 * src/modest-account-mgr.c:
1037 (modest_account_mgr_add_server_account):
1038 * src/modest-defs.h:
1039 * src/modest-tny-account.c:
1040 (modest_tny_account_new_from_server_account):
1041 Determine the options for tny_camel_account_add_option() here,
1042 based on the settings, rather than storing them directly in gconf.
1044 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1046 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1047 Show a more friendly error dialog now that we expect (from the tinymail
1048 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1050 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1052 * src/maemo/modest-main-window.c: (on_account_update): Check that
1053 account_name is not NULL, to prevent a crash at startup that I am
1054 seeing on the N800. I do wonder why it is NULL.
1056 * src/maemo/easysetup/modest-easysetup-wizard.c:
1057 (create_page_user_details):
1058 * src/maemo/modest-account-settings-dialog.c:
1059 (create_page_user_details), (create_page_outgoing):
1060 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1061 (modest_connection_specific_smtp_edit_window_init):
1062 * src/modest-ui-actions.c:
1063 (modest_ui_actions_on_password_requested):
1064 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1065 might do something useful with the on-screen keyboard.
1067 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/modest-main-window.c: (on_account_update):
1070 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1071 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1073 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1075 * src/modest-tny-account-store.c: (on_account_changed):
1076 Correct the signature of this signal handler.
1078 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1080 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1081 Show a HildonNote instead of a GtkDialog for Maemo.
1083 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1085 * src/widgets/modest-account-view.h:
1086 * src/widgets/modest-account-view.c: (on_account_changed),
1087 (on_account_removed). Added a boolean flag, set/unset by
1088 modest_account_view_block_conf_updates(),
1089 modest_account_view_unblock_conf_updates() to prevent unnecessary
1090 updates, but this is not very useful because the gconf notifications are
1091 so delays (maybe only on Maemo Bora).
1092 So auto-updating is turned off, and these functions do an explicit
1093 update when necessary.
1094 However, something else is still doing too much work when adding/removing
1095 accounts, probably in another part of the application.
1097 * src/maemo/modest-account-view-window.c:
1098 (on_delete_button_clicked), (on_edit_button_clicked),
1099 (on_new_button_clicked): Use the new functions.
1101 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1103 * src/modest-account-mgr-helpers.c:
1104 (modest_account_mgr_set_first_account_as_default):
1105 Sort the list of names alphabetically-by-title, so we choose the first one
1107 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1108 alphabetically by the title.
1110 This fixes projects.maemo.org bug NB#56418 .
1112 * src/modest-account-mgr-priv.c:
1113 (_modest_account_mgr_account_from_key):
1114 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1115 avoid a valgrind error, and possible random behaviour.
1117 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1119 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1120 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1121 tinymail documentation to say that this can be expected.
1122 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1123 pretty, and should not happen, but I would prefer to know when it does.
1125 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1127 * configure.ac: When using the older hildon version, probably on Bora,
1128 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1130 * src/widgets/modest-attachment-view.c:
1131 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1134 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1136 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1137 Implemented the prototype. Can be tested with
1138 tests/dbus_api/test_open_message:
1140 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1142 * src/modest-tny-account-store.c:
1143 (modest_tny_account_store_instance_init), (get_password):
1144 * src/modest-ui-actions.c:
1145 (modest_ui_actions_on_password_requested):
1146 Do not store the password in gconf, because this function is called
1147 for non-remembered passwords. Actually use the cached (in the hash map)
1148 password instead of releasing it.
1149 The password will now not be remembered if it is asked via the protected
1150 password dialog, as per the UI spec.
1152 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-defs.h:
1155 * src/modest-account-mgr-helpers.h:
1156 * src/modest-account-mgr-helpers.c:
1157 Added modest_server_account_get_username_has_succeeded(),
1158 modest_server_account_set_username_has_succeeded().
1159 (modest_server_account_set_username),
1160 Reset the has-succeeded flag if the username changes.
1162 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1163 * src/maemo/modest-connection-specific-smtp-window.c:
1164 (modest_connection_specific_smtp_window_save_server_accounts):
1165 Use modest_server_account_set_username() instead of using
1166 modest_conf_set_string() directly, so that the has-succeeded flag is always
1169 * src/modest-ui-actions.c:
1170 (modest_ui_actions_on_password_requested): Dim the username entry if
1171 the username has ever worked, as per the UI spec.
1173 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-tny-account-store.c: (get_password):
1176 * src/modest-ui-actions.c:
1177 (modest_ui_actions_on_password_requested):
1178 Allow the username to be changed too, though there is more work to
1179 be done on exactly how this behaves.
1181 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1183 * src/modest-account-mgr-helpers.h:
1184 * src/modest-account-mgr-helpers.c:
1185 Added modest_account_mgr_get_display_name(),
1186 modest_server_account_get_username(),
1187 modest_server_account_set_username(),
1188 modest_server_account_set_password(),
1189 modest_server_account_get_hostname() functions so we do not need to
1190 use the conf API directly.
1192 * src/maemo/modest-main-window.c: (connect_signals):
1193 Actually connect ot the ModestAccountStore::request-password signal,
1194 so that we show the dialog when the password is requested by Tinymail,
1195 for isntance if it is empty.
1197 * src/modest-marshal.list:
1198 * src/modest-tny-account-store.c:
1199 (modest_tny_account_store_class_init), (get_password),
1200 (modest_tny_account_store_alert):
1201 * src/modest-tny-account-store.h:
1202 * src/modest-ui-actions.h:
1203 * src/modest-ui-actions.c:
1204 (modest_ui_actions_on_password_requested):
1205 Change the signal parameters, so it is obvious that we are providing
1206 the non human-readable server name, and receiving both the username
1207 and password, though changing of the username is not yet implemented.
1208 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1209 for the GNOME version.
1211 This should fix the projects.maemo.org bug NB#56209, though it does not
1212 work on Bora, because the gconf_client_get() for the password fails
1213 immediately after we save it with gconf_client_set().
1215 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1218 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1219 caused an undefined symbol error:
1220 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1222 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1224 * src/modest-tny-account-store.c:
1225 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1226 using a GError instead of a string message, so we can translate it in
1229 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1231 * src/maemo/modest-address-book.c:
1232 (modest_address_book_check_names):
1233 * src/maemo/modest-msg-view-window.c:
1234 (modest_msg_view_window_clipboard_owner_change):
1235 * src/modest-init.c: (modest_init_init_ui):
1236 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1237 (update_folders_cb), (modest_mail_operation_update_account):
1238 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1239 (modest_ui_actions_on_msg_attachment_clicked),
1240 (modest_ui_actions_on_msg_recpt_activated):
1241 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1242 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1243 (modest_msg_view_search_next):
1244 * src/widgets/modest-recpt-editor.c:
1245 (modest_recpt_editor_on_button_release_event),
1246 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1247 g_message(). At this point we should only be seeing interesting errors on
1248 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1250 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1252 (modest_wizard_dialog_force_title_update):
1253 * src/maemo/easysetup/modest-wizard-dialog.h:
1254 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1255 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1256 can update the title when appropriate. Otherwise the title is wrong if the
1257 pages are added after adding the notebook to the dialog.
1258 This must be a problem in HildonWizardDialog too.
1259 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1261 * src/maemo/easysetup/modest-easysetup-wizard.c:
1262 (create_subsequent_customsetup_pages),
1263 (create_subsequent_easysetup_pages):
1264 Call modest_wizard_dialog_force_title_update() so that the title is
1265 correct even with GTK+ < 2.10.
1266 This fixes projects.maemo.org bug NB#56145 .
1268 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/modest-platform.c:
1271 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1272 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1275 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1277 * src/widgets/modest-window.h:
1278 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1279 and modest_window_save_state(), which invokes it.
1281 * src/widgets/modest-window-mgr.h:
1282 * src/widgets/modest-window-mgr.c:
1283 Added modest_window_mgr_save_state_for_all_windows(), which calls
1284 the save_state vfunc on all registered windows, if implemented.
1286 * src/gnome/modest-msg-edit-window.c:
1287 * src/gnome/modest-msg-view-window.c:
1288 * src/maemo/modest-msg-edit-window.c:
1289 * src/maemo/modest-msg-view-window.c:
1290 * src/maemo/modest-main-window.c:
1291 Specify the existing save_settings functions as implementations of
1292 ModestWindow::save_state_func().
1294 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1295 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1296 enabling hibernation, for instance.
1298 We may need to do the same thing for restoring settings.
1301 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1303 * src/widgets/modest-window-mgr.c:
1304 * src/widgets/modest-window-mgr.h:
1305 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1306 modest_window_mgr_get_hibernation_is_prevented().
1308 * src/maemo/modest-main-window.c:
1309 (on_hildon_program_is_topmost_notify): Prevent hibernation
1310 (possible when the application goes to the background in the WM),
1311 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1313 * src/maemo/easysetup/modest-easysetup-wizard.c:
1314 (modest_easysetup_wizard_dialog_init):
1315 * src/maemo/modest-account-settings-dialog.c:
1316 (modest_account_settings_dialog_init):
1317 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1318 (modest_connection_specific_smtp_edit_window_init):
1319 * src/maemo/modest-connection-specific-smtp-window.c:
1320 (modest_connection_specific_smtp_window_init):
1321 * src/maemo/modest-signature-editor-dialog.c:
1322 (modest_signature_editor_dialog_init):
1323 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1324 prevent hibernation while any of these account settings dialogs are open.
1326 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/Makefile.am:
1329 * src/maemo/modest-osso-state-saving.c:
1330 * src/maemo/modest-osso-state-saving.h: Added
1331 modest_osso_load_state() and modest_osso_save_state() though they do
1332 nothing now. They should iterate through all the open windows and load/save
1334 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1335 save state when closing.
1337 * src/maemo/modest-main-window.c:
1338 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1339 Add a notification handler for the HildonProgram::is-topmost property,
1340 so we can allow hibernation when the application goes into the background.
1341 But we still need to detect when the accounts setup windows are open so
1342 we can stop hibernation when they are open.
1343 To do this, I also added the main window the HildonProgram. This might have
1344 other side-effects/benefits, and should maybe be done for other windows.
1346 * src/maemo/modest-osso-autosave-callbacks.h:
1347 * src/maemo/modest-osso-autosave-callbacks.c:
1348 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1349 though it does not do anything yet, and we might never need this to do
1350 anything. For instance, we already save drafts.
1352 * src/maemo/modest-platform.c: (modest_platform_init):
1353 Specify the libosso auto-save callback.
1355 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1357 * src/maemo/modest-platform.c:
1358 (modest_platform_set_update_interval):
1359 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1360 aparently stays valid between application instances, so we can use this
1361 to remove and reset it later. According to a maemo-developers email from
1364 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1366 * configure.ac: Depend on libalarm for Maemo.
1368 * src/dbus_api/modest-dbus-api.h:
1369 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1370 (on_send_receive), (modest_dbus_req_handler):
1371 Handle a SEND_RECEIVE D-Bus method.
1373 * libmodest-dbus-client/libmodest-dbus-client.c:
1374 (libmodest_dbus_client_send_and_receive):
1375 * libmodest-dbus-client/libmodest-dbus-client.h:
1376 Add C convenience functions for calling the new D-Bus method.
1378 * src/modest-platform.h:
1379 * src/gnome/modest-platform.c:
1380 * src/maemo/modest-platform.c:
1381 Added modest_platform_set_update_interval(), which uses the
1382 alarmd API on Maemo.
1383 (modest_platform_init),
1384 Call modest_platform_set_update_interval(), using a hard-coded
1385 interval for now (until the global settings dialog is implemented),
1386 though I am not sure that this makes sense yet.
1388 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1390 * src/dbus_api/modest-dbus-callbacks.c:
1391 (modest_osso_cb_hw_state_handler):
1392 * src/dbus_api/modest-dbus-callbacks.h:
1393 * src/maemo/modest-platform.c: (modest_platform_init):
1394 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1395 in case this has some effect on the ability for Maemo to ping the
1398 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1400 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1401 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1402 warning. It is probably a logic error, but I need to fix the build.
1404 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1406 * src/modest-account-mgr.h:
1407 * src/modest-account-mgr.c:
1408 (modest_account_mgr_account_names): Add a gboolean enabled_only
1409 parameter, so we can get lists of onlt the enabled accounts.
1411 (modest_account_mgr_add_account),,
1412 (modest_account_mgr_account_with_display_name_exists):
1413 * src/maemo/modest-msg-edit-window.c: (get_transports):
1414 * src/modest-account-mgr-helpers.c:
1415 (modest_account_mgr_set_first_account_as_default):
1416 * src/modest-init.c: (init_default_account_maybe):
1417 * src/modest-tny-account-store.c: (get_accounts):
1418 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1419 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1420 * tests/check_account-mgr.c: (START_TEST):
1421 Provide the extra parameter, as appropriate.
1423 * src/widgets/modest-account-view.c: (update_account_view):
1424 Do not show disabled accounts (meaning that there is no way to
1425 enable/disable accounts in the UI (the feature is not in our UI
1426 specification), so we can use this internally only to mark unfinished
1427 or temporary account data.
1429 * src/maemo/easysetup/modest-easysetup-wizard.c:
1430 (create_account): Add boolean enable parameter, so we can specify FALSE
1431 to create the temporary account.
1432 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1433 (on_before_next): When finishing, when there is a temporary account, just
1435 Also, use a timeout to delay the showing of the dialog until gconf is likely
1436 to return correct information, due to a maemo gconf bug that is fixed in
1437 osso 1.1, but not yet in Bora.
1438 However, the dialog stays on screen after it is destroyed.
1440 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1441 for invalid data when cancelling. Use a hildon note instead of a dialog
1442 to complain about invalid data. Do not show the account-saved note if the
1443 account is disabled (a temporary account that will not really be saved for use
1446 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1448 * src/modest-account-mgr-helpers.h:
1449 * src/modest-account-mgr-helpers.c:
1450 Added modest_account_mgr_unset_default_account(),
1451 Added modest_account_mgr_set_first_account_as_default().
1453 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1454 If it was the default account, unset the default account name.
1456 * src/maemo/modest-account-view-window.c:
1457 (on_delete_button_clicked): If it was the default account,
1458 set the first remaining account as the default instead.
1460 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1461 a NULL account or a NULL default account, to prevent a crash. This should
1462 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1465 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1467 * src/widgets/modest-recpt-editor.c:
1468 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1469 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1470 TODO comment for this. This fixes the build.
1472 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1473 be the best place for it. This will in future update all auto-update accounts,
1474 rather than just the current/default account, when that gconf key exists.
1475 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1476 if there are no accounts, before calling do_send_receive().
1477 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1479 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1480 * src/maemo/modest-main-window-ui.h:
1481 * src/maemo/modest-main-window.c: (on_connection_changed),
1482 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1483 directly, becaue the signal handler does more.
1485 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1487 * src/modest-account-mgr-helpers.c:
1488 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1489 for the case that the account does not exist.
1491 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1492 (equivalent to the modest account name) rather than the tinymail account name
1493 (equivalent to the modest account title - human readable) to get the account data.
1494 Check for null account data to prevent the crash, and add a TODO comment saying that
1495 this needs fixing because it is using the server account name instead of the account name.
1497 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1500 * src/maemo/modest-account-settings-dialog.c: (show_error),
1502 Use hildon_note_new_information() for informative and error messages,
1503 which seems to be expected for Maemo applications (no documentation that I know of
1504 says this). I am surprised that there is no distinction between info and error
1507 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1509 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1510 it is easy to find where this is used.
1512 * src/maemo/easysetup/modest-easysetup-wizard.c:
1513 (create_page_welcome), (create_page_account_details),
1514 (create_page_user_details), (create_page_complete_easysetup),
1515 (create_page_custom_incoming), (create_page_custom_outgoing),
1516 (create_page_complete_custom):
1517 * src/maemo/modest-account-settings-dialog.c:
1518 (create_page_account_details), (create_page_user_details),
1519 (create_page_incoming), (create_page_outgoing):
1520 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1521 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1522 (modest_connection_specific_smtp_edit_window_init):
1523 * src/maemo/modest-connection-specific-smtp-window.c:
1524 (modest_connection_specific_smtp_window_init):
1525 * src/maemo/modest-signature-editor-dialog.c:
1526 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1527 and scrolling policy as per the Email Application Layout Guide, if I have
1530 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1532 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1533 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1534 which were empty, because these vfuncs have been removed from TnyAccountStore.
1535 This fixes the build.
1537 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1539 * src/maemo/modest-main-window.c:
1540 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1541 showing/hiding it. Added TODO because it probably should not be NULL.
1542 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1543 because unnecessary g_warnings() make degugging difficult.
1545 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1547 * src/maemo/modest-msg-edit-window.c:
1548 (modest_msg_edit_window_select_color),
1549 (modest_msg_edit_window_select_background_color): 2 const corrections and
1550 moving 2 #endifs before closing brackets, to fix the build.
1552 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1554 * src/maemo/easysetup/modest-easysetup-wizard.h:
1555 * src/maemo/easysetup/modest-easysetup-wizard.c:
1556 (modest_easysetup_wizard_dialog_finalize),
1557 (on_button_edit_advanced_settings), (create_page_complete_custom),
1558 (on_response), (create_account):
1559 Implement the Advanced Settings edit button, by saving the account information,
1560 for the Advanded Settings dialog to use directly from gconf, and removing it
1561 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1562 Bug #5533 in the projects.maemo.org bugzilla.
1564 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1566 * src/maemo/modest-msg-view-window.c:
1567 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1568 when opening a message window.
1570 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1572 * src/maemo/easysetup/modest-easysetup-wizard.c:
1573 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1576 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1577 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1578 gconf settings. I probably added more checks than necessary, but that is safer.
1580 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1581 variable to fix the build, but this seems to be used when it is still NULL.
1583 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1585 * src/modest-platform.h:
1586 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1587 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1588 * src/modest-main.c: Implement this function so we can avoid using
1589 maemo-specific API from cross-platform code.
1591 * src/modest-tny-account-store.c:
1592 (get_smtp_specific_transport_account_for_open_connection):
1593 * src/modest-ui-actions.c: (check_for_connection),
1594 (modest_ui_actions_on_item_not_found):
1595 Use modest_platform_connect_and_wait() and put #idefs around other
1596 maemo-specific code, because only maemo currently has a way to
1597 identify connection names.
1599 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1601 * src/modest-tny-account-store.h:
1602 * src/modest-tny-account-store.c:
1603 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1604 the connection-specific SMTP server settings in the configuration.
1606 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1608 * src/maemo/modest-main-window.c: (on_connection_changed),
1610 * src/modest-main.c: (main), (start_ui), (send_mail):
1611 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1612 that is what is intended.
1614 * src/modest-ui-actions.c: (action_send), (action_receive),
1615 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1616 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1617 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1618 SMTP server is used when it is specified.
1620 (modest_ui_actions_on_send_receive):
1621 Check that a connection is open before proceeding.
1622 Receive and then send, instead of vice-versa, as per the specification.
1624 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1626 * src/modest-mail-operation.c:
1627 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1628 though I guess it should be something other than NULL.
1630 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1632 * src/maemo/easysetup/modest-easysetup-wizard.c:
1633 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1634 combo twice, to avoid an g_warning and to make it visible again.
1635 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1636 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1637 (already intended) dereference when detaching, because we then recreate the menu.
1638 But I am not sure why the warning was happening, and it is possible that this is a memory
1641 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1643 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1644 and uri_parse_mailto() utility functions.
1645 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1647 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1649 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1651 * src/dbus_api/modest-dbus-api.h:
1652 * src/dbus_api/modest-dbus-callbacks.c:
1653 Use an idle callback to execute the modest code in the application's own thread.
1654 Remove the helloworld example method.
1655 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1656 parsed, and the open-message method is not implemented because this is not yet implemented in
1658 * libmodest-dbus-client/libmodest-dbus-client.c:
1659 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1660 (libmodest_dbus_client_open_message):
1661 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1663 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1664 body without crashing.
1666 * tests/dbus_api/Makefile.am:
1667 * tests/dbus_api/test_mail_to.c:
1668 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1670 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1672 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1673 Added file to fix the build. Sorry.
1675 * src/dbus_api/Makefile.am:
1676 * src/dbus_api/modest-dbus-api.h:
1677 * src/dbus_api/modest-dbus-callbacks.h:
1678 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1679 (modest_dbus_req_handler):
1680 Put constants in a separate header so it can be reused by the
1681 client library, without duplication
1683 * libmodest-dbus-client/Makefile.am:
1684 * libmodest-dbus-client/libmodest-dbus-client.c:
1685 (libmodest_dbus_client_call_helloworld),
1686 (libmodfest_dbus_client_send_mail),
1687 (libmodfest_dbus_client_mailto),
1688 (libmodfest_dbus_client_open_message):
1689 * libmodest-dbus-client/libmodest-dbus-client.h:
1690 (Partly) Implement a send_mail D-Bus method.
1692 * tests/dbus_api/Makefile.am:
1693 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1694 the send_email D-Bus method.
1696 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1700 * libmodest-dbus-client/Makefile.am:
1701 * libmodest-dbus-client/libmodest-dbus-client.c:
1702 * libmodest-dbus-client/libmodest-dbus-client.h:
1703 * tests/dbus_api/Makefile.am:
1704 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1705 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1707 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1709 * src/maemo/easysetup/modest-easysetup-wizard.c:
1710 (create_page_account_details):
1711 * src/maemo/modest-account-settings-dialog.c:
1712 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1713 widgets, because this might not be the default in future versions of the Maemo GTK+.
1714 However, I can not not get capitalization to work even in a simple test case.
1716 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1718 * src/maemo/easysetup/modest-easysetup-wizard.c:
1719 (create_page_custom_incoming), (create_page_custom_outgoing):
1720 * src/maemo/modest-account-settings-dialog.c:
1721 (create_page_account_details), (create_page_incoming),
1722 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1723 instead of using gtk_check_button_with_label(), so they are aligned like the other
1724 widgets, as per the UI spec.
1726 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1728 * src/maemo/easysetup/modest-easysetup-wizard.c:
1729 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1730 * src/widgets/modest-validating-entry.c:
1731 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1732 Modest prefix instead of an EasySetup prefix.
1734 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1736 * src/widgets/modest-validating-entry.h:
1737 * src/widgets/modest-validating-entry.c: (on_insert_text),
1738 Added easysetup_validating_entry_set_max_func(), used to set a callback
1739 to call when the max number of characters is reached. GtkEntry has a max-length
1740 already but is silent about it.
1742 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1743 (create_page_account_details), (create_page_user_details),
1745 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1746 (create_page_account_details), (create_page_user_details),
1747 (create_page_outgoing):
1748 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1749 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1750 the UI spec, when the user tries to enter more than the max number of characters.
1752 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1754 * src/maemo/easysetup/modest-easysetup-wizard.c:
1755 (create_page_user_details), (create_page_custom_incoming),
1756 (create_page_custom_outgoing):
1757 * src/maemo/modest-account-settings-dialog.c:
1758 (create_page_user_details), (create_page_incoming),
1759 (create_page_outgoing):
1760 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1761 (modest_connection_specific_smtp_edit_window_init):
1762 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1763 not appropriate. Bad Maemo-specific defaults!.
1765 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1767 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1768 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1769 (modest_signature_editor_dialog_set_settings):
1770 Disable the label and textview when the checkbox is disabled, and use the
1771 specified (UI spec) default signature text.
1773 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1776 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1778 * src/modest-defs.h:
1779 * src/modest-account-mgr-helpers.h:
1780 * src/modest-account-mgr-helpers.c:
1781 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1783 * src/maemo/Makefile.am:
1784 * src/maemo/modest-signature-editor-dialog.c:
1785 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1788 * src/maemo/modest-account-settings-dialog.h:
1789 * src/maemo/modest-account-settings-dialog.c:
1790 (modest_account_settings_dialog_finalize), (on_button_signature),
1791 (save_configuration): Use the new dialog when the Edit button is pressed, and
1792 save the changes if necessary, as per the UI spec.
1794 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1796 * src/maemo/Makefile.am:
1797 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1798 based on maemo-develoers email from Dirk.
1800 * src/maemo/easysetup/modest-easysetup-wizard.c:
1801 (create_page_welcome), (create_page_account_details),
1802 (create_page_user_details), (create_page_complete_easysetup),
1803 (create_page_custom_incoming), (create_page_custom_outgoing),
1804 (create_page_complete_custom),
1805 (modest_easysetup_wizard_dialog_init):
1806 * src/maemo/modest-account-settings-dialog.c:
1807 (create_page_account_details), (create_page_user_details),
1808 (create_page_incoming), (create_page_outgoing),
1809 (modest_account_settings_dialog_init):
1810 * src/maemo/modest-connection-specific-smtp-window.c:
1811 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1813 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/easysetup/modest-easysetup-wizard.c:
1816 (create_page_account_details), (create_page_custom_outgoing),
1817 (create_page_complete_custom):
1818 * src/maemo/modest-account-settings-dialog.c:
1819 (create_page_user_details), (create_page_incoming),
1820 (create_page_outgoing):
1821 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1822 (modest_connection_specific_smtp_edit_window_init):
1823 Use the correct (UI spec) port min/max, and use horizontal separators,
1826 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1828 * src/maemo/easysetup/modest-easysetup-wizard.c:
1829 (set_default_custom_servernames):
1830 * src/maemo/modest-account-settings-dialog.c:
1831 (create_page_incoming), (on_combo_outgoing_security_changed),
1832 (on_combo_incoming_security_changed), (create_page_outgoing),
1833 (modest_account_settings_dialog_set_account_name),
1834 (save_configuration):
1835 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1836 (on_combo_security_changed),
1837 (modest_connection_specific_smtp_edit_window_init),
1838 (modest_connection_specific_smtp_edit_window_set_connection),
1839 (modest_connection_specific_smtp_edit_window_get_settings):
1840 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1843 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1846 * src/maemo/easysetup/modest-easysetup-wizard.c:
1847 (create_page_custom_outgoing), (create_page_complete_custom):
1848 * src/maemo/modest-account-settings-dialog.c:
1849 (create_page_user_details), (create_page_outgoing):
1850 * src/maemo/modest-account-view-window.c: (button_box_new):
1851 Use changed logical IDs as per the most recent UI spec:
1852 mcen_bd_emailsetup_edit -> mcen_bd_edit
1853 mcen_bd_emailsetup_delete -> mcen_bd_delete
1854 mcen_bd_emailsetup_close -> mcen_bd_close
1856 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1860 * src/dbus_api/Makefile.am:
1861 * src/dbus_api/modest-dbus-callbacks.c:
1862 * src/dbus_api/modest-dbus-callbacks.h:
1863 * src/maemo/modest-platform.c: (modest_platform_init):
1864 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1866 * tests/Makefile.am:
1867 * tests/dbus_api/Makefile.am:
1868 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1870 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1872 * src/maemo/modest-account-settings-dialog.c:
1873 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1874 Removed unnecessary includes.
1876 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1878 * src/maemo/easysetup/modest-easysetup-wizard.c:
1879 * src/maemo/modest-account-settings-dialog.c:
1880 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1881 * src/widgets/Makefile.am:
1882 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1883 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1884 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1885 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1886 * src/widgets/modest-secureauth-combo-box.c:
1887 * src/widgets/modest-secureauth-combo-box.h:
1888 * src/widgets/modest-serversecurity-combo-box.c:
1889 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1890 made the GObject names more consistent with the rest of the Modest code.
1892 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1894 * src/maemo/easysetup/Makefile.am:
1895 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1896 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1897 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1898 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1899 * src/maemo/easysetup/modest-easysetup-wizard.c:
1900 * src/maemo/easysetup/modest-validating-entry.c:
1901 * src/maemo/easysetup/modest-validating-entry.h:
1902 * src/maemo/modest-account-settings-dialog.c:
1903 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1904 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1905 widgets/ because they are used outside of easysetup too. After checking in,
1906 svn will allow me to rename them too.
1908 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1910 * src/gnome/modest-msg-edit-window.c:
1911 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1912 linker error, to fix the build on the GNOME platform.
1913 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1914 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1915 ifdefed out to avoid a warning.
1917 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1919 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1920 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1921 some alternative for GTK+ 2.6.
1923 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1925 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1927 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1928 specified for EmailAccountsDialog in UI spec.
1930 * src/maemo/easysetup/modest-easysetup-wizard.c:
1931 * src/maemo/easysetup/modest-easysetup-wizard.h:
1932 * src/maemo/modest-account-settings-dialog.c:
1933 * src/maemo/modest-account-settings-dialog.h:
1934 Reuse a member window widget for the connection-specific SMTP server accounts,
1935 so we can tell it to create/save the accounts only if we actually save changes.
1937 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1938 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1939 (modest_connection_specific_smtp_edit_window_get_settings):
1940 Return a struct instance for temporarily remembering the entered data.
1942 * src/maemo/modest-connection-specific-smtp-window.h:
1943 * src/maemo/modest-connection-specific-smtp-window.c:
1944 (modest_connection_specific_smtp_window_finalize),
1945 (modest_connection_specific_smtp_window_fill_with_connections),
1947 (modest_connection_specific_smtp_window_save_server_accounts),
1948 (update_model_server_names): Do not actually save data until asked,
1949 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1951 (on_selection_changed),
1952 (modest_connection_specific_smtp_window_init): Disable the edit
1953 button when nothing is selected.
1955 * src/modest-account-mgr-helpers.c:
1956 * src/modest-account-mgr-helpers.h:
1957 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1960 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1962 * src/modest-account-mgr-helpers.h:
1963 * src/modest-account-mgr-helpers.c:
1964 (modest_account_mgr_get_unused_account_name),
1965 (modest_account_mgr_get_unused_account_display_name): Added these
1966 utility functions, to avoid code duplication.
1968 * src/maemo/easysetup/modest-easysetup-wizard.c:
1969 (create_page_account_details), (create_account):
1970 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1971 (on_combo_security_changed),
1972 (modest_connection_specific_smtp_edit_window_init),
1973 (modest_connection_specific_smtp_edit_window_save_settings):
1974 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1975 * src/maemo/modest-connection-specific-smtp-window.c:
1976 (modest_connection_specific_smtp_window_finalize),
1977 (modest_connection_specific_smtp_window_fill_with_connections),
1978 (on_button_edit), (modest_connection_specific_smtp_window_init):
1979 * src/maemo/modest-connection-specific-smtp-window.h:
1980 Implementing saving of connection-specific server accounts.
1982 But I need to refactor this so we can save the data for each
1983 possible connection-specific account and only actually create the server accounts
1984 when the easysetup finished, or the OK button is pressed on the account settings
1987 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1989 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1990 (on_combo_security_changed):
1991 (modest_connection_specific_smtp_edit_window_init):
1992 Auto-fill the port number as in the account settings.
1994 (modest_connection_specific_smtp_edit_window_set_connection):
1995 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1996 * src/maemo/modest-connection-specific-smtp-window.c:
1997 (fill_with_connections), (on_button_edit),
1998 (modest_connection_specific_smtp_window_init):
1999 Turn the edit window into a dialog to simplify the code, and
2000 set a WM hint as in a GtkDialog, because only a popup can be on top of
2001 another window in Maemo, and popups usually have no WM decoration.
2003 * src/modest-defs.h:
2004 * src/modest-account-mgr-helpers.c:
2005 (modest_account_mgr_set_connection_specific_smtp),
2006 (modest_account_mgr_remove_connection_specific_smtp),
2007 (modest_account_mgr_get_connection_specific_smtp):
2008 * src/modest-account-mgr-helpers.h: Some functions to write the
2009 connection-specific SMTP server information. Not yet used.
2012 * src/widgets/modest-folder-view.c: (text_cell_data):
2013 Fix a warning about an uninitialized variable.
2014 (on_configuration_key_changed): Put an #ifdef around the use
2015 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2017 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/modest-account-settings-dialog.h:
2020 * src/maemo/modest-account-settings-dialog.c:
2021 Added connect_for_modified() utility function to mark the new modified boolean.
2023 (create_page_account_details), (create_page_user_details),
2024 (create_page_incoming), (create_page_outgoing), (on_response),
2025 (modest_account_settings_dialog_init),
2026 (modest_account_settings_dialog_set_account_name):
2027 Only warn about unsaved changes when there are actually unsaved changes.
2029 * src/modest-account-mgr-helpers.c:
2030 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2031 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2032 to get the data from there in future.
2034 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2036 * src/modest-defs.h:
2038 * src/modest-account-mgr-helpers.h:
2039 * src/modest-account-mgr-helpers.c:
2040 Store the security account setting in a single conf key instead of using
2041 the options list, so that the list is left for just the to-be-removed camel hack,
2042 and because gconf_client_set_list() is failing for some reason.
2044 * src/modest-account-mgr.c:
2045 (modest_account_mgr_add_server_account):
2046 * src/maemo/modest-account-settings-dialog.c:
2047 (modest_account_settings_dialog_set_account_name),
2048 (save_configuration): Use the renamed functions.
2051 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2053 * src/widgets/Makefile.am:
2054 * src/widgets/modest-limit-retrieve-combo-box.c:
2055 * src/widgets/modest-limit-retrieve-combo-box.h:
2056 * src/widgets/modest-retrieve-combo-box.c:
2057 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2058 the account settings dialog.
2060 * src/modest-defs.h:
2061 * src/modest-account-mgr-helpers.h:
2062 * src/modest-account-mgr-helpers.c:
2063 (modest_server_account_get_option_secure_auth),
2064 (modest_server_account_set_option_secure_auth):
2065 * src/modest-account-mgr.c:
2066 (modest_account_mgr_add_server_account):
2067 Use the existing AUTH_MECH conf key for the secure-auth setting,
2068 instead of putting it in the list options, because this was actually used already.
2070 * src/maemo/modest-account-settings-dialog.c:
2071 (create_page_account_details),
2072 (modest_account_settings_dialog_set_account_name),
2073 (save_configuration):
2074 * src/maemo/modest-account-settings-dialog.h:
2075 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2076 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2078 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2080 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2081 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2082 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2084 * src/modest-defs.h:
2085 * src/maemo/modest-account-settings-dialog.c:
2086 (create_page_incoming), (on_combo_outgoing_security_changed),
2087 (on_combo_incoming_security_changed), (create_page_outgoing),
2088 (modest_account_settings_dialog_set_account_name),
2089 (save_configuration): Load/Save the port number, and change it when the
2090 security combo changes, to suitable defaults.
2092 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2094 * src/modest-account-mgr.c:
2095 (modest_account_mgr_add_server_account): Set the security and secure-auth
2096 options, and add a comment saying that the other camel-specific options should be
2099 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2101 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2103 * src/modest-tny-account-store.c: (account_list_free),
2104 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2105 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2108 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2110 * src/modest-protocol-info.c:
2111 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2112 is required by our UI spec. Maybe something in our implementation will use this eventually.
2113 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2114 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2115 instead of the previous 0 placeholder.
2117 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2118 secure-auth settings.
2119 * src/modest-account-mgr-helpers.h:
2120 * src/modest-account-mgr-helpers.c:
2121 (modest_server_account_data_get_option_secure_auth),
2122 (modest_server_account_set_option_secure_auth),
2123 (modest_server_account_data_get_option_security),
2124 (modest_server_account_set_option_security): Added this API for getting and setting the security
2125 and secure-auth settings.
2127 * src/maemo/modest-account-settings-dialog.h:
2128 * src/maemo/modest-account-settings-dialog.c:
2129 (modest_account_settings_dialog_finalize), (check_data),
2130 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2131 about changing titles.
2132 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2133 (save_configuration): Save the security and secure-auth settings.
2135 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2136 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2138 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2140 * src/modest-defs.h:
2141 * src/modest-account-mgr.c:
2142 (modest_account_mgr_add_server_account):
2143 Added and used defines for the options key and value pair strings,
2144 that are used so far, though they do not seem to correspond to anything in our
2145 UI specs or ModestProtocol enum.
2147 * src/modest-account-mgr-helpers.h:
2148 * src/modest-account-mgr-helpers.c:
2149 (compare_option_strings_for_name),
2150 (modest_server_account_data_get_option_value),
2151 (modest_server_account_data_get_option_bool),
2152 (modest_account_mgr_get_server_account_option):
2153 Added helper functions for parsing the options GSList.
2155 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2157 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2158 display name is based on the supplied account name.
2159 * src/modest-account-mgr.c:
2160 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2161 with an inefficient, but good-enough, implementation.
2163 * src/maemo/easysetup/modest-easysetup-wizard.c:
2164 (create_page_account_details), (on_before_next), (create_account):
2165 Check for existing display names rather than (non-user-visible) account names, and just
2166 create and set a unique account name at the end.
2168 * src/maemo/modest-account-settings-dialog.c:
2169 (modest_account_settings_dialog_init),
2170 (modest_account_settings_dialog_set_account_name),
2171 (create_page_incoming): Show the display name, instead of the account name.
2172 (on_response): Do some (not all) extra checks, as in the UI spec.
2173 (save_configuration): Save the display name if it was changed.
2175 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2177 * po/en_GB.po: Added needed logical ID and translation.
2178 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2179 (init_view): Made the is-default column clicking work.
2181 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2184 * src/maemo/easysetup/Makefile.am:
2185 * src/maemo/easysetup/modest-easysetup-wizard.c:
2186 (modest_easysetup_wizard_dialog_init):
2187 * src/maemo/easysetup/provider-data-test.keyfile:
2188 * src/maemo/easysetup/provider-data.keyfile:
2189 Moved the provider data file to the new modest-providers-data package and used it from there.
2191 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2193 * src/modest-local-folder-info.c:
2194 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2195 N_() was already used on the static strings, but this just marks it for translation without
2196 using the translation.
2198 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2200 * src/maemo/modest-account-settings-dialog.c:
2201 (create_page_incoming),
2202 (modest_account_settings_dialog_set_account_name):
2203 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2204 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2205 I will do this if nobody else gets there first.
2207 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2209 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2210 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2211 save the security stuff.
2213 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2216 Set the email address and user fullname, which I now see must be
2219 * src/maemo/modest-account-settings-dialog.h:
2220 * src/maemo/modest-account-settings-dialog.c:
2222 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2223 leave-on-server and authentication.
2224 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2227 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/modest-account-settings-dialog.c:
2231 * src/maemo/modest-account-settings-dialog.h:
2232 Most (but not all) of the widgets are now present as specified by the UI spec.
2233 No changes are yet saved, and some details are not properly shown yet.
2235 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2237 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2239 * src/maemo/Makefile.am:
2240 * src/maemo/modest-account-settings-dialog.c:
2241 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2242 an existing account. Doesn't do much yet.
2244 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2245 Open the accounts settings dialog when Edit is clicked.
2247 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2249 * src/maemo/easysetup/Makefile.am:
2250 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2252 * src/maemo/easysetup/modest-easysetup-wizard.c:
2253 (modest_easysetup_wizard_dialog_init):
2254 Try to get the source directory from the build system,
2255 instead of hard-coding "./" into the source code, when opening our local
2256 copies of the configuration files.
2257 But this still fails when opening the wizard from the Accounts window,
2258 maybe because the working directory seems to change at runtime.
2259 So the wizard will fail the second time unless you copy the files into their
2260 proper locations - see the stdout warnings for the paths.
2262 (create_page_account_details),(on_before_next):
2263 Check for existing non-server accounts instead of server accounts,
2264 so the default account name is useful again, and to prevent trying to
2267 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2268 Show the wizard when New is clicked.
2270 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2271 (init_view): Show the column headers, and show the columns that are
2272 specified in the UI specs. However, something in Maemo's GTK+ prevents
2273 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2274 change the default account. This is despite unsetting the special properties.
2276 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2278 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2279 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2280 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2281 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2282 to make that clearer.
2283 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2285 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2287 * src/maemo/modest-account-view-window.c:
2288 (modest_account_view_window_init),
2289 (modest_account_view_window_new):
2290 Use the same buttons as specified in the
2291 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2292 the existing widgets, which never had a chance of working.
2293 Put the ModestAccountView treeview in a scrolled window.
2294 Do not repeat the initialization in both _init() and _new().
2296 * src/widgets/modest-account-view.c: (update_account_view):
2297 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2298 this widget and window shows no accounts.
2300 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2302 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2304 * src/maemo/easysetup/modest-easysetup-wizard.c:
2305 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2306 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2307 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2310 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2311 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2312 accounts exist yet, as in the UI spec.
2314 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2316 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2318 * src/maemo/Makefile.am:
2319 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2320 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2321 New window for editing connection-specific smtp details.
2322 Not fully implemented.
2324 * src/maemo/modest-connection-specific-smtp-window.c:
2325 (modest_connection_specific_smtp_window_finalize) :
2326 unref the tree model.
2327 (on_button_edit): Show the edit window.
2329 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2331 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2334 * src/maemo/Makefile.am:
2335 * src/maemo/modest-connection-specific-smtp-window.c:
2336 * src/maemo/modest-connection-specific-smtp-window.h:
2337 New window for showing the list of connections, for connection-specific
2338 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2339 * src/maemo/easysetup/modest-easysetup-wizard.c:
2340 (create_page_custom_outgoing): Show the new window when the button is clicked.
2342 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2344 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2345 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2346 * src/maemo/modest-msg-edit-window.c:
2347 (modest_msg_edit_window_insert_image):
2348 * src/modest-conf.c: (modest_conf_key_escape):
2349 * src/modest-mail-operation.c:
2350 (modest_mail_operation_send_new_mail):
2351 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2352 (modest_ui_actions_on_new_account):
2353 * src/widgets/modest-attachment-view.c: (update_filename_request):
2354 * src/widgets/modest-mail-header-view.c:
2355 Corrected warnings that were breaking the build, by commenting out unused variables,
2356 and a function, and by including a header.
2358 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2360 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2361 so we can #ifdef around platform-specific code when necessary.
2362 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2363 to allow this to build for the GNOME platform too.
2365 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2367 * src/maemo/easysetup/modest-easysetup-wizard.c:
2368 Added util_increment_name() and used it in create_page_account_details()
2369 to make sure that the default account name is always a new name.
2371 (modest_easysetup_wizard_dialog_init),
2372 (set_default_custom_servernames): Some minor memory management fixes.
2374 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2378 * src/modest-runtime.c: (init_i18n): Restored the translation
2379 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2380 are defined in config.h, and the translations are installed.
2382 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2383 is defined for translation.
2385 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2387 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2389 * src/maemo/easysetup/modest-easysetup-wizard.c:
2390 (modest_easysetup_wizard_dialog_init):
2391 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2392 Use realistic paths (though they should use $prefix generically) to the
2393 mcc_mapping and provider-data.keyfile files which might work when they
2394 are installed by the future version of the operator-wizard package,
2395 and then fallback to paths in our source code, with an explanatory
2398 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2402 * src/maemo/Makefile.am:
2403 * src/maemo/easysetup/: Added files from the previously-exernal
2404 osso-modest-easysetup.
2405 * src/maemo/modest-main-window-ui.h:
2406 * src/modest-ui-actions.c:
2407 * src/modest-ui-actions.h:
2408 Added modest_ui_actions_on_new_account() as a signal handler for the
2409 New Account menu item. It shows the easysetup wizard.
2410 * po/en_GB.po: Added additional needed logical IDs and translations.
2412 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2413 Apparently ChangeLog is not used for some vague Nokia legal reasons.