1 2007-07-05 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-address-book.c:
4 (select_email_addrs_for_contact): Specify a default window size for the
5 select-email-address dialog, so that it is probably big enough for the
6 title. This should fix projects.maemo.org bug NB#62277.
8 2007-07-05 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/easysetup/modest-easysetup-wizard.c:
11 (create_page_complete_easysetup): Use
12 gtk_widget_set_size() request to ensure that the text wraps
15 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
17 * src/maemo/easysetup/modest-easysetup-wizard.c:
18 (on_entry_invalid_character), (create_page_account_details),
19 (create_page_user_details):
20 Use new API of ModestValidatingEntry. But for some reason the banner is
21 not shown. I will have to investigate that further.
23 * src/widgets/modest-validating-entry.c: (on_insert_text),
24 (modest_validating_entry_set_func):
25 * src/widgets/modest-validating-entry.h:
26 Added a new callback function to be able to react to prevented
27 characters whitespaces to e.g show a banner.
29 2007-07-05 Armin Burgmeier <armin@openismus.com>
31 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
32 notification of HildonNumberEditor instead of remembering the port
33 number. Thanks to Johannes for pointing this out.
35 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
37 * src/maemo/easysetup/modest-easysetup-wizard.c:
38 Check if there are any user changes before showing a confirmation
39 dialog (projects.maemo.org NB#60946)
41 2007-07-05 Armin Burgmeier <armin@openismus.com>
43 * src/maemo/modest-account-settings-dialog.c: Remember custom port
44 number at the beginning of the dialog and set the modified flag at the
45 end if the port number has changed. This is necessary because
46 HildonNumberEditor does not support notification when the value has
49 2007-07-05 Murray Cumming <murrayc@murrayc.com>
51 * src/modest-ui-actions.c:
52 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
53 a connection before asking anything else. Correct the check for the destination
54 folder so that it succeeds when online.
55 This fixed projects.maemo.org bug NB#61645.
57 2007-07-05 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
60 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
61 to fix projects.maemo.org bug NB#62439.
63 2007-07-05 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-tny-account.c: (on_connection_status_changed):
66 Really do not use tny_device_force_offline() here. See the previous comment.
68 2007-07-04 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account.c: (on_connection_status_changed):
71 Do not use tny_device_force_offline() when tinymail says that something
72 went wrong with the connection. It seems to report this unnecessarily.
74 2007-07-04 Murray Cumming <murrayc@murrayc.com>
76 * src/maemo/modest-connection-specific-smtp-window.c:
77 (modest_connection_specific_smtp_window_init):
78 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
79 does not seem to have any effect in osso 1.1 (though it works in
80 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
82 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
84 * src/maemo/modest-connection-specific-smtp-window.c:
85 Fix UI specification problems with projects.meamo.org NB#60479
87 2007-07-04 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
90 clue when this has failed, because the error dialog is not always shown
91 (at least in earlier version).
93 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
94 GError message, because the generic error dialog is not helpful.
96 'This message is not currently available (can't let a new connection go online)'
97 when trying to open an IMAP message.
99 (_modest_ui_actions_open): Offer a connection when some messages would
100 have to be downloaded and we are offline.
102 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
104 * src/widgets/modest-folder-view.c:
105 Don't check for MERGE type anymore as we use the correct type
107 NOTE: For the last two changes you need to update your tinymail copy
108 because of API changes!
110 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
112 * src/modest-tny-local-folders-account.c:
113 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
114 (see projects.maemo.org NB#61580)
116 2007-07-04 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-tny-account.c: (on_connection_status_changed):
119 Commented out the call to modest_platform_connect_and_wait() because this
120 seems to always hang, and I would like to know if this is the only thing
121 that causes a hang when showing the connection dialog.
122 It is not very useful anyway.
124 2007-07-04 Murray Cumming <murrayc@murrayc.com>
126 * src/maemo/modest-msg-view-window.c:
127 (modest_msg_view_window_select_next_message):
129 * src/modest-platform.h:
130 * src/maemo/modest-platform.c:
131 Added modest_platform_connect_and_wait(), which calls
132 tny_maemo_conic_device_connect() always in the main thread, by calling it
133 in an idle handler and waiting for the idle handler to run. It should be
134 in the main thread because it uses GTK+ UI code. It just returns TRUE
135 if the device is already online.
137 There is some nasty code to ensure that subsequent calls to
138 modest_platform_connect_and_wait() just wait for the first one to finish,
139 by checking repeatedly in another idle handler. This is necessary,
140 because other threads (or even the main thread, via another idle handler)
141 can call modest_platform_connect_and_wait() while
142 modest_platform_connect_and_wait() is running.
144 (modest_platform_connect_and_wait_if_network_account),
145 (modest_platform_connect_and_wait_if_network_folderstore):
146 Convenience functions that calls modest_platform_connect_and_wait() if
147 the account or folder might want network access.
149 * src/modest-mail-operation.c:
150 (modest_mail_operation_update_account):
151 * src/modest-ui-actions.c: (download_uncached_messages),
152 (modest_ui_actions_on_rename_folder), (delete_folder),
153 (modest_ui_actions_on_main_window_move_to),
154 (modest_ui_actions_on_msg_view_window_move_to):
155 * src/widgets/modest-folder-view.c:
156 (drag_and_drop_from_folder_view):
157 Offer a connection if we are offline.
159 * src/modest-tny-account.c: (on_connection_status_changed):
160 Document this as only handling errors during network operations in progress,
161 and replace the idle code with a simple call to
162 modest_platform_connect_and_wait(), which does this instead.
164 2007-07-03 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-tny-account.c:
167 (modest_tny_account_get_special_folder): (util_on_idle),
168 Handle the GError so we can see when tny_folder_store_get_folders()
169 fails, as it currently does while something else is connecting.
171 Added util_run_in_main_thread_and_wait()
172 which uses an idlen handler and mainloop to ensure that the function
173 is called in the main thread.
174 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
175 to make sure that we call attempt the connection in the mainloop only,
176 which might solve some hangs.
178 2007-07-03 Murray Cumming <murrayc@murrayc.com>
180 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
181 be found by their display name. This is never useful.
182 * src/modest-tny-account-store.c: (on_account_removed): Find the account
183 by its ID, instead of trying to use its ID as its display name.
185 * src/modest-tny-account-store.h:
186 * src/modest-tny-account.c:
187 (modest_tny_account_get_special_folder): Add a g_warning() when
188 tny_folder_store_get_folders() returns an empty list for the maildir.
190 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
191 Add a g_warning() when this returns NULL, because that it not allowed
194 2007-07-02 Armin Burgmeier <armin@openismus.com>
196 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
197 note when trying to cancel the wizard. This fixes projects.maemo.org
200 2007-07-02 Murray Cumming <murrayc@murrayc.com>
202 * src/modest-tny-account.h:
203 * src/modest-tny-account.c:
204 (modest_tny_account_new_from_server_account),
205 (modest_tny_account_new_from_server_account_name),
206 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
207 because this must now be set before setting the proto. This is usd in
208 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
209 warning in camel_session_get_service() caused by
210 tny_camel_transport_account_prepare().
212 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
215 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
217 * src/maemo/modest-connection-specific-smtp-edit-window.c:
219 (modest_connection_specific_smtp_edit_window_init):
221 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
224 2007-06-29 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-tny-account.c:
227 (modest_tny_account_new_from_server_account):
228 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
229 now uses to request a connection when it needs one, and which it uses
230 to tell us that something is wrong with the connection, so we can force
231 the accounts offline to prevent further problems.
234 * src/modest-init.c: (init_default_settings):
235 * src/modest-mail-operation.c:
236 (modest_mail_operation_update_account):
237 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
238 This should not be necessary anymore. Do not set the conf key that
239 determined this (it was always TRUE and not set anywhere else).
241 * src/modest-ui-actions.h: Remove unused and unimplemented
242 modest_ui_actions_on_online_toggle_toggled().
244 2007-06-29 Murray Cumming <murrayc@murrayc.com
246 * src/maemo/modest-main-window.c: (connect_signals):
247 Don't connect to delete_event twice. Maybe this was harmless.
249 2007-06-29 Murray Cumming <murrayc@murrayc.com
251 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
252 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
253 Debug output to give some more clue when a folder move is not allowed.
255 2007-06-28 Murray Cumming <murrayc@murrayc.com
257 * src/modest-tny-account.c: (on_modest_file_system_info),
258 (modest_tny_account_get_mmc_account_name):
259 Always call the callback, without checking whether the name has changed.
260 * src/widgets/modest-folder-view.c: (strings_are_equal),
261 (on_model_foreach_set_name), (on_get_mmc_account_name),
262 (text_cell_data): Compare the name here, and use the name from
263 the account rather than from the
264 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
265 if the name was changed after the account was added to the model.
266 That's a tinymail bug but not one that I want to fix now.
268 This finally fixes projects.maemo.org bug NB#59301.
270 2007-06-27 Armin Burgmeier <armin@openismus.com>
272 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
275 2007-06-27 Murray Cumming <murrayc@murrayc.com
277 * src/modest-tny-account.h:
278 * src/modest-tny-account.c:
279 Added modest_tny_account_get_mmc_account_name(), to set the memory
280 card name asynchronously for the given account and then notify.
281 (modest_tny_account_new_for_local_folders): Use this new function instead
282 of using hildon_file_system_info_async_new() directly.
284 * src/widgets/modest-folder-view.c: (text_cell_data):
285 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
286 gtk_tree_model_row_changed() when it is available.
288 This should fix projects.maemo.org bug NB#59301.
290 2007-06-27 Murray Cumming <murrayc@murrayc.com
292 * src/modest-mail-operation.c: (update_account_thread),
293 (get_msgs_full_thread): Fix typo failures in the revert
296 2007-06-27 Murray Cumming <murrayc@murrayc.com
298 * src/maemo/modest-maemo-global-settings-dialog.c:
299 (idle_select_default_focus):
300 * src/modest-mail-operation.c: (idle_notify_progress),
301 (idle_notify_progress_once), (set_last_updated_idle),
302 (update_account_thread), (get_msgs_full_thread):
303 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
304 * src/widgets/modest-header-view.c:
305 (idle_notify_headers_count_changed_destroy),
306 (idle_notify_headers_count_changed):
307 Reverted the additions of gdk_threads_enter/leave(), in case this
308 helps with a startup hang on the device.
310 2007-06-26 Armin Burgmeier <armin@openismus.com>
312 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
313 for supported secure authentication methods from server by
314 gtk_dialog_run(), saving CPU time and a potential race condition.
316 2007-06-26 Armin Burgmeier <armin@openismus.com>
318 * src/maemo/modest-maemo-utils.h:
319 * src/maemo/modest-maemo-utils.c: Added a
320 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
321 only error code to tell the calling code when the user canceled the
324 * src/maemo/modest-account-settings-dialog.h:
325 * src/maemo/modest-account-settings-dialog.c:
326 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
327 message if the retrieval of secure authentication methods was canceled
328 by the user. Perform the check before saving anything to configuration
329 to not end up with half-committed configuration changes, do not show
330 a "Saving to configuration failed" note when authentication methods
331 could not be retrieved.
333 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
336 2007-06-26 Murray Cumming <murrayc@murrayc.com>
338 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
339 Only return the first level of folders under accounts, because the
340 osso-global-search UI spec doesn't want the rest.
341 This fixed projects.maemo.org bug NB#61811.
343 2007-06-26 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-tny-account-store.c:
346 * src/modest-tny-account-store.h:
347 Added modest_tny_account_is_memory_card_account().
348 * src/maemo/modest-main-window.c: (create_details_widget):
349 Show the same information items for the memory card as we show for the
350 local-folders, to fix projects.maemo.org bug NB#59307.
352 2007-06-26 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-tny-account-store.c: (get_password):
355 Added some checks for NULL to maybe prevent crashes, though I think
356 it was Philip's last commit that actually prevented the crash here
357 when creating a first new account.
358 But the new account is still not usable (no messages are shown)
359 until a restart of the application.
361 2007-06-26 Murray Cumming <murrayc@murrayc.com>
363 * src/maemo/modest-maemo-global-settings-dialog.c:
364 (idle_select_default_focus):
365 * src/modest-mail-operation.c: (idle_notify_progress),
366 (idle_notify_progress_once), (idle_notify_update_account_queue),
367 (set_last_updated_idle), (update_account_thread),
368 (notify_get_msgs_full), (get_msgs_full_destroyer),
369 (get_msgs_full_thread):
370 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
371 * src/widgets/modest-header-view.c:
372 (idle_notify_headers_count_changed_destroy),
373 (idle_notify_headers_count_changed):
374 Use gdk_threads_enter() and gdk_threads_enter_leave() in
375 all idle handlers, because some other thread could be blocking
376 the GDK lock, so that it can do GUI stuff.
378 2007-06-26 Murray Cumming <murrayc@murrayc.com>
380 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
381 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
382 (on_idle_send_receive), (on_idle_open_default_inbox):
383 * src/maemo/modest-msg-edit-window.c:
384 (modest_msg_edit_window_attach_file_noninteractive):
385 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
386 to prevent a hang. I don't quite understand why these are necessary,
387 beause we should already be in the main loop. I guess something outside
388 of the main loop is taking the lock.
390 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
391 we are really using URIs, and use files that are more likely to exist.
393 2007-06-26 Murray Cumming <murrayc@murrayc.com>
395 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
396 necessary because configure.ac now defines different variables.
398 2007-06-26 Murray Cumming <murrayc@murrayc.com>
400 * libmodest-dbus-client/libmodest-dbus-client.c:
401 * libmodest-dbus-client/libmodest-dbus-client.h:
402 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
403 libmodest_dbus_client_compose_mail() is what things actually use.
405 * src/dbus_api/modest-dbus-api.h:
406 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
407 * tests/dbus_api/Makefile.am:
408 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
411 2007-06-26 Murray Cumming <murrayc@murrayc.com>
413 * src/modest-init.c: (modest_init_local_folders):
414 For memory-card (or other non local-folders) maildir accounts,
415 always create an Archive folder, so that there is somewhere to put
416 messages. This should be less confusing, because the user does not need
417 to guess that the need to create a folder.
419 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
421 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
422 Fixed icon size by using (50, 50) which is the same as defined by
425 2007-06-25 Armin Burgmeier <armin@openismus.com>
427 * src/widgets/modest-window-mgr.c:
429 * configure.ac: Correctly recognize hildon-notify presence and fixed
430 the build without it being installed.
432 2007-06-25 Murray Cumming <murrayc@murrayc.com>
434 * libmodest-dbus-client/libmodest-dbus-client.c:
435 (libmodest_dbus_client_search): Fix the build. Sorry.
436 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
437 (reply_forward_cb): Initialize variables to fix the build.
439 * src/modest-tny-account-store.c:
440 (modest_tny_account_store_get_tny_account_by): Fix the account URI
441 comparison (a silly typo) so that email search results can be opened
442 when there are more than one account.
444 2007-06-25 Murray Cumming <murrayc@murrayc.com>
446 * libmodest-dbus-client/libmodest-dbus-client.c:
447 (libmodest_dbus_client_search),
448 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
449 instead of 1 second, because the search gets folders and messages from
450 the server, which can take a long time. When it times out,
451 osso-global-search will report no results.
453 We need to specify whether we should search only cached information
454 (maybe with a user preference), and the osso-email-search-plugin
455 API should really be improved to allow that option, and to allow results
456 to be delivered asynchronously in batches.
458 2007-06-25 Murray Cumming <murrayc@murrayc.com>
460 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
461 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
462 GTK_ICON_SIZE_DIALOG is probably the wrong size.
464 2007-06-25 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
467 that is an empty string. D-Bus seems to give us these instead of NULL.
469 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
471 * src/dbus_api/modest-dbus-callbacks.c:
472 * src/maemo/easysetup/modest-easysetup-wizard.h:
473 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
474 * src/maemo/modest-connection-specific-smtp-edit-window.c:
475 (modest_connection_specific_smtp_edit_window_init):
476 * src/maemo/modest-maemo-global-settings-dialog.c:
478 * src/maemo/modest-maemo-utils.c:
479 (modest_maemo_utils_setup_images_filechooser):
480 * src/maemo/modest-main-window.c: (create_details_widget):
481 * src/maemo/modest-msg-edit-window.c:
482 (modest_msg_edit_window_attach_file_noninteractive),
483 (modest_msg_edit_window_color_button_change),
484 (modest_msg_edit_window_set_zoom):
485 * src/modest-mail-operation.c: (update_account_thread):
486 * src/modest-tny-account-store.c:
487 * src/modest-tny-account.c:
488 * src/widgets/modest-global-settings-dialog.c:
489 * src/widgets/modest-window.h:
493 2007-06-25 Murray Cumming <murrayc@murrayc.com>
495 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
496 * src/modest-search.c: (modest_search_folder),
497 (modest_search_all_accounts): Actually search only in the specified folder,
498 doing a simple match on the folder ID.
499 * src/modest-search.h: Added a folder field to the ModestSearch struct,
500 and added some documentation.
502 2007-06-22 Armin Burgmeier <armin@openismus.com>
504 * src/maemo/modest-maemo-utils.h:
505 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
506 modest_maemo_utils_get_supported_secure_authentication_methods.
508 * src/maemo/easysetup/modest-easysetup-wizard.c:
509 * src/maemo/modest-account-settings-dialog.c: Show correct error if
510 one occured, not just "Server does not support secure authentication".
512 2007-06-22 Murray Cumming <murrayc@murrayc.com>
514 * src/modest-tny-account-store.c: (get_password):
515 Restored the call to tny_account_set_user() because Philip seems to have
516 stopped this from crashing (by not using the freed string). It still does
517 not work, but now we can test it.
519 2007-06-22 Murray Cumming <murrayc@murrayc.com>
521 * src/maemo/modest-msg-edit-window.c: (init_window):
522 Comment out use of an uninitialzed GtkScrolledWindow variable,
523 to fix the build and stop a crash. Yet again.
525 2007-06-22 Murray Cumming <murrayc@murrayc.com>
527 * src/modest-tny-account-store.c: (get_password):
528 Remove the call to tny_account_set_user() because this actually crashes.
529 As mentioned in the last commit, it is known to not work anyway.
531 2007-06-22 Murray Cumming <murrayc@murrayc.com>
533 * src/modest-tny-account-store.c: (get_password):
534 Use tny_account_set_username() to tell tinymail that the username might
535 have changed too. But tinymail ignores this: see projects.maemo.org
537 * src/modest-ui-actions.c:
538 (modest_ui_actions_on_password_requested): Remove the useless attempt to
539 reset the connection when changing the username, and improve the comments.
540 Save the changed username to gconf at least, so it is used when Modest is
543 2007-06-21 Murray Cumming <murrayc@murrayc.com>
545 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
546 Do not use a query, so that we get all folders, including for POP and
547 local-folders. They work as search criteria too.
548 This fixes projects.maemo.org bug NB#57740.
550 2007-06-21 Murray Cumming <murrayc@murrayc.com>
552 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
553 Comment out the use of hildon_notification_set_sound() because it is
554 not declared, to fix the build. Warnings are serious, people.
556 2007-06-21 Armin Burgmeier <armin@openismus.com>
558 * src/maemo/modest-maemo-utils.h:
559 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
560 modest_maemo_utils_get_supported_secure_authentication_methods()
561 to query authentication methods for a specific user. This should fix
562 projects.maemo.org bug NB#61369.
564 * src/maemo/easysetup/modest-easysetup-wizard.c:
565 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
568 2007-06-21 Murray Cumming <murrayc@murrayc.com>
570 * libmodest-dbus-client/libmodest-dbus-client.h:
571 * libmodest-dbus-client/libmodest-dbus-client.c:
572 (modest_dbus_message_iter_get_search_hit),
573 (libmodest_dbus_client_search):
574 Reorganised and commented this.
575 Removed modest_search_hit_free() from the public API because it
578 Added libmodest_dbus_client_get_folders() and
579 modest_folder_result_list_free().
581 * src/dbus_api/modest-dbus-api.h:
582 * src/dbus_api/modest-dbus-callbacks.c:
583 (modest_dbus_req_filter): Commented. Moved most code to
584 on_dbus_method_search() and added on_dbus_method_get_folders().
586 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
587 of the extra D-Bus handler.
589 * tests/dbus_api/Makefile.am:
590 * tests/dbus_api/test_get_folders.c: New test for
591 libmodest_dbus_client_get_folders(). This seems to return an empty list
592 at the moment. That could be the same error that causes the message list
593 to be empty sometimes.
594 This should help with projects.maemo.org bug NB#57740.
596 2007-06-21 Armin Burgmeier <armin@openismus.com>
598 * src/modest-mail-operation.c: Do not call
599 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
600 notify the operation's end after having set the status to CANCELED for
601 the operation queue to listen on. This fixes a deadlock when there
602 were mail operations in the queue during its finalization.
604 * src/modest-singletons.c: Reordered uninitialization of the account
605 manager to happen after the mail operation queue was uninitialized
606 because the mail operation's in the queue might still try to access
607 the account manager (see modest_mail_operation_notify_end()). This
608 fixes a potential crash when terminating the application.
610 2007-06-21 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-search.c:
613 (search_mime_part_and_child_parts): Moved some code here so we
614 can search recursively in child folders.
615 (modest_search_folder): Search in the message as a mime part, instead
616 of just its child mime parts.
617 (read_chunk), (search_mime_part_ogs):
618 Check how many bytes were read, to prevent an endless loop.
619 Searching in message bodies now works. This finishes the fix for
620 projects.maemo.org bug NB#61007.
622 2007-06-20 Murray Cumming <murrayc@murrayc.com>
624 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
625 Add a g_warning when the item is not a folder.
627 * src/modest-ui-dimming-rules.c:
628 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
629 when selected item is not a folder (for instance, an account), because
630 the UI spec only talks about folders.
631 I am not sure what the UI spec wants, so this might not totally fix
632 projects.maemo.org bug NB#60794.
634 2007-06-20 Murray Cumming <murrayc@murrayc.com>
636 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
637 (load_from_file): Sort the list. The unsorted list would be more noticeable
638 in non-English locales.
640 * src/maemo/modest-msg-edit-window.c:
641 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
642 warning and fix the build.
644 * src/maemo/modest-progress-bar-widget.c:
645 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
646 avoid a g_warning, and probably to avoid a crash.
648 2007-06-20 Murray Cumming <murrayc@murrayc.com>
650 * src/modest-search.c: (modest_search_folder): Check for a GError
651 when calling tny_folder_get_headers(), to show that this is not the cause
654 2007-06-20 Murray Cumming <murrayc@murrayc.com>
656 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
657 Actually set the body query instead of the subject query.
659 * src/modest-search.c: (search_mime_part_ogs),
660 (search_mime_part_strcmp): Remove extra space from the text/* regex,
661 which would probably cause it to fail if we got this far.
663 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
664 to simplify the code.
665 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
666 be causing search-in-body to fail.
668 2007-06-20 Murray Cumming <murrayc@murrayc.com>
670 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
672 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
673 Better debug message when the folder cannot be found.
674 This should help with fixing projects.maemo.org bug #61287.
675 * src/modest-search.c: (add_hit): Do not leak the furl string.
677 2007-06-20 Murray Cumming <murrayc@murrayc.com>
679 * src/modest-ui-actions.c:
680 (modest_ui_actions_on_folder_selection_changed):
681 Do not special-case TNY_MERGE_FOLDER here, because
682 modest_tny_folder_get_account() already does that. This fixes
683 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
684 shown when the Outbox was selected).
686 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
688 * libmodest-dbus-client/libmodest-dbus-client.c:
689 (_dbus_iter_get_string_or_null): Initialize the string variable in
690 case this helps with Dirk's crash.
692 2007-06-19 Murray Cumming <murrayc@murrayc.com>
694 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
695 though it is not implemented yet (this function is maybe not even used),
696 to avoid breaking ABI in future.
697 * libmodest-dbus-client/libmodest-dbus-client.c:
698 (get_attachments_string): Moved some code into this generic function.
699 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
700 sends email. It is maybe not used.
701 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
702 (on_send_mail): Use attachments.
704 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
705 * src/maemo/modest-msg-edit-window.c:
706 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
707 a filename before using it, to fix projects.maemo.org bug NB#58233.
709 2007-06-19 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
712 Initialize the continue_download variable to fix the build, and probably
713 to fix randome behaviour.
715 2007-06-18 Armin Burgmeier <armin@openismus.com>
717 * src/modest-tny-send-queue.h:
718 * src/modest-tny-send-queue.c: Keep track of the status of messages in
719 the queue so we can later show it in the UI. Replaced
720 modest_tny_send_queue_msg_is_being_sent() by
721 modest_tny_send_queue_get_msg_status().
723 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
725 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
726 gpointer. This probably was not harmful, but just to be sure.
728 2007-06-18 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
731 Fix the build, but leave the function broken on Bora, because
732 hildon_uri_action_get_service() does not exist.
733 osso_uri_action_get_service() does not exist either, it seems.
735 2007-06-18 Murray Cumming <murrayc@murrayc.com>
737 * src/modest-tny-account.c:
738 (modest_tny_account_new_from_server_account):
739 Uncommented the url debug output again, because it is useful for
740 debugging, as I said in the comment.
742 2007-06-18 Murray Cumming <murrayc@murrayc.com>
744 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
746 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
747 for Mameo Bora, to fix the build.
749 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
752 Fixed build with hildon < 0.99
754 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
755 Check if the selected account is busy instead of checking all accounts
757 * src/modest-account-mgr-priv.h:
758 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
759 (modest_account_mgr_init), (compare_account_name),
760 (modest_account_mgr_set_account_busy),
761 (modest_account_mgr_account_is_busy):
762 * src/modest-account-mgr.h:
763 Added busy information to the account manager. It possible to
764 set an account to busy or not busy now.
766 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
767 (modest_mail_operation_update_account),
768 (modest_mail_operation_notify_end):
769 Set the account to busy/not busy depending on the operation state.
771 * src/widgets/modest-account-view.c:
772 (modest_account_view_finalize), (get_last_updated_string),
773 (update_account_view), (on_account_busy_changed), (init_view):
774 Show string "Refreshing..." if the account is currently busy.
776 All this fixes projects.maemo.org bug NB#59711
778 2007-06-14 Armin Burgmeier <armin@openismus.com>
780 * src/widgets/modest-attachments-view.h:
781 * src/widgets/modest-attachments-view.c: Added
782 modest_attachments_view_has_attachments() and fixed coordinate
783 transformation in get_att_view_at_coords(). This fixes attachment
786 * src/widgets/modest-msg-view.c: Make use of
787 modest_attachments_view_has_attachments() to decide whether to show
788 attachments in the header.
790 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
792 * src/maemo/modest-connection-specific-smtp-edit-window.c:
793 (on_change), (on_combo_security_changed),
794 (modest_connection_specific_smtp_edit_window_init),
795 (modest_connection_specific_smtp_edit_window_set_connection),
796 (modest_connection_specific_smtp_edit_window_is_dirty):
797 * src/maemo/modest-connection-specific-smtp-edit-window.h:
798 * src/maemo/modest-connection-specific-smtp-window.c:
801 Show an comfirmation dialog for the smpt-edit-window if there are
802 unsaved changes and the user hits cancel.
803 (projects.maemo.org bug NB#60479)
805 2007-06-14 Armin Burgmeier <armin@openismus.com>
807 * src/maemo/easysetup/modest-easysetup-wizard.c:
808 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
809 address" info in banner instead of node, and select all the text as
810 per UI spec. This fixes projects.maemo.org bug NB#60550.
812 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
814 reviewed by: <delete if not using a buddy>
816 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
817 * src/modest-ui-actions.c: (folder_refreshed_cb):
819 2007-06-14 Murray Cumming <murrayc@murrayc.com>
821 * src/widgets/modest-folder-view.c: (filter_row):
822 Explictly filter out the per-account outbox accounts. I don't know why
823 these only sometimes show up, but now they should never show up in the UI.
824 This should fix projects.maemo.org bug NB#60160.
826 2007-06-14 Murray Cumming <murrayc@murrayc.com>
828 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
829 when the toolbar does not exist yet.
830 * src/modest-widget-memory.c: (save_settings_header_view):
831 Added g_warnings() to help us to discover when we are trying to set
832 an empty columns list in gconf.
834 2007-06-14 Murray Cumming <murrayc@murrayc.com>
838 Added modest_init_get_default_header_view_column_ids().
840 * src/modest-widget-memory.c: (restore_settings_header_view):
841 Use the new function to get defaults, if the gconf key is empty,
842 instead of not creating any columns. This seems to fix the
843 empty right-hand pane problems.
845 * src/widgets/modest-header-view.h: Improved documentation.
847 2007-06-13 Murray Cumming <murrayc@murrayc.com>
849 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
850 Revert the use of the display name as the account name, because this
851 is generally wrong and would break the code that follows.
853 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
855 * src/maemo/easysetup/modest-easysetup-wizard.c:
856 (check_for_supported_auth_methods), (on_before_next),
859 More correct fix for projects.maemo.org bug NB# 58991
860 Do not longer accept AUTH_PASSWORD as secure method and choose
861 correct method when creating the account.
863 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
865 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
866 Fixed projects.maemo.org bug NB# 58991
868 2007-06-13 Murray Cumming <murrayc@murrayc.com>
870 * src/modest-init.c: (modest_init_init_core),
871 (modest_init_local_folders): Fixed compilation errors.
873 2007-06-13 Murray Cumming <murrayc@murrayc.com>
875 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
876 Remove unnecessary lib/include, though it is good in principle when needed.
878 * src/modest-init.c: (modest_init_one_local_folder),
879 (modest_init_local_folders):
880 * src/modest-init.h: Initialize the .modest library for memory cards,
881 instead of just doing nothing for them. This should allow us to create
882 folders there, fixing projects.maemo.org bug NB#59297.
884 2007-06-13 Murray Cumming <murrayc@murrayc.com>
886 * libmodest-dbus-client/libmodest-dbus-client.c:
887 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
888 (libmodest_dbus_client_compose_mail),
889 (libmodest_dbus_client_open_message),
890 (libmodest_dbus_client_send_and_receive),
891 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
893 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
894 (on_idle_open_message), (modest_dbus_req_handler),
895 (search_result_to_message), (modest_dbus_req_filter):
896 * src/modest-search.c: (add_hit), (modest_search_folder),
897 (modest_search_all_accounts): Improved debug messages.
899 * tests/dbus_api/test_open_message.c: (main): Improved comments.
901 * src/modest-tny-account-store.c:
902 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
905 2007-06-13 Murray Cumming <murrayc@murrayc.com>
908 2007-06-12 Murray Cumming <murrayc@murrayc.com>
910 * src/modest-tny-account-store.c: (get_server_accounts):
911 Call modest_tny_local_folders_account_add_merged_outbox_folders()
912 even when there are no accounts, so that the Outbox folder is always
913 visible. This fixes projects.maemo.org bug NB#60158.
915 2007-06-12 Murray Cumming <murrayc@murrayc.com>
917 * src/maemo/modest-main-window.c: (create_details_widget):
918 Use the mcen_va_never logical ID.
920 2007-06-12 Murray Cumming <murrayc@murrayc.com>
922 * src/dbus_api/modest-dbus-api.h:
923 * src/dbus_api/modest-dbus-callbacks.c:
924 (on_idle_open_default_inbox), (on_open_default_inbox),
925 (modest_dbus_req_handler):
926 Added a new OpenDefaultInbox method.
928 * libmodest-dbus-client/libmodest-dbus-client.h:
929 * libmodest-dbus-client/libmodest-dbus-client.c:
930 Added libmodest_dbus_client_open_default_inbox() to call the new
931 dbus method. This should be useful to projects.maemo.org bug NB#57214,
932 though it should maybe be used by a new osso-email-interface function.
934 * tests/dbus_api/Makefile.am:
935 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
938 2007-06-12 Murray Cumming <murrayc@murrayc.com>
940 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
941 NULL, so that the signals get all the keys. This should not actually
942 change any behaviour because we currently update everything when anything
945 2007-06-12 Murray Cumming <murrayc@murrayc.com>
947 * src/widgets/modest-folder-view.c: (text_cell_data),
948 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
949 (find_inbox_iter): If tinymail tells us that the folder is
950 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
951 This causes the inbox to be selected at startup, fixing part of
952 projects.maemo.org bug NB#56305.
954 * src/modest-ui-dimming-rules.c:
955 (modest_ui_dimming_rules_on_tools_smtp_servers):
956 * src/modest-ui-dimming-rules.h: Added a callback function to dim
957 the SMTP servers menu item.
958 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
959 that the SMTP Servers menu item is dimmed when there are no accounts,
960 as a future version of the UI spec will require. This fixes
961 projects.maemo.org bug NB#56305.
963 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
965 * src/maemo/modest-maemo-utils.c:
966 (modest_maemo_utils_get_supported_secure_authentication_methods):
967 Added label to dialog instead of unreadable title
969 * src/maemo/modest-main-window.c: (sync_accounts_cb),
970 (modest_main_window_new):
971 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
974 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
975 * src/modest-account-mgr.h:
976 Added method to avoid code duplication
978 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
979 (modest_ui_actions_on_send_receive):
980 Use modest_account_mgr_has_accounts
982 2007-06-11 Murray Cumming <murrayc@murrayc.com>
984 * src/maemo/easysetup/modest-presets.c:
985 (modest_presets_get_info_server_security): Do not report secure auth
987 * src/modest-protocol-info.c: Use the defines for the gconf key names
988 for secure authentication. This was not working because we were writing
989 Password and reading password, and the check was case sensitive.
990 With this, gmail now works for receiving and sending when created via
993 2007-06-11 Murray Cumming <murrayc@murrayc.com>
995 * src/maemo/easysetup/modest-presets.c:
996 (modest_presets_get_info_server_security): Correct the key name for
997 SecureSmtp, because it seems to be case-sensitive.
998 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
999 Do not try to get the 0th notebook page if there are 0 pages, to
1000 avoid a g_warning().
1002 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1004 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1005 Prevent use of the new notification feature for now, because it currently
1006 shows one dialog for each new email, which is annoying.
1008 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1010 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1011 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1012 when no country was selected, so that we show the global ones.
1013 * src/maemo/easysetup/modest-presets.c:
1014 (modest_presets_get_providers): Return only the global providers, not
1015 all providers when mmc=0 was requested.
1017 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1019 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1020 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1021 provider ID in the combo.
1023 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1024 Do not show the page numbers, because it would be confusing when we add
1025 the 2 extra pages for the custom setup, when the user chooses the "Other"
1026 provider. This fixes projects.maemo.org bug NB#59028
1028 * src/modest-init.c: (modest_init_init_core),
1029 (modest_init_local_folders):
1030 * src/modest-init.h:
1031 * src/modest-tny-account.c:
1032 (modest_tny_account_new_for_local_folders): Do not create default folders
1033 for the memory card. This should fix projects.maemo.org bug NB#59328.
1035 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1037 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1038 Free the changed_conf_keys string items. They are already freed in the
1039 idle handler if that runs first.
1041 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1043 * src/modest-ui-actions.c:
1044 (modest_ui_actions_on_password_requested): Check that the server name
1045 is not NULL, because I just saw a password dialog with (null) as the
1048 * src/modest-tny-folder.[h|c]: Added
1049 modest_tny_folder_is_memory_card_folder().
1050 * src/modest-ui-dimming-rules.c:
1051 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1052 menu item for memory cards, as per the UI spec (section 7.4). This should
1053 fix projects.maemo.org bug NB#59297.
1055 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1057 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1058 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1059 is another problem with the code, see Murray's comment at line 772)
1061 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1063 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1064 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1065 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1066 (load_from_file), (easysetup_country_combo_box_init),
1067 (easysetup_country_combo_box_get_active_country_ids),
1068 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1069 instead of just one ID, to avoid duplicate country names in the UI.
1071 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1072 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1073 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1074 a single ID, avoiding duplicate providers.
1075 * src/maemo/easysetup/modest-easysetup-wizard.c:
1076 (on_combo_account_country): Adapt to use a list.
1078 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1080 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1081 keys changed in the last X seconds.
1083 * src/modest-account-mgr.h:
1084 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1085 (on_key_change), (modest_account_mgr_class_init),
1086 (modest_account_mgr_init), (modest_account_mgr_finalize):
1087 As the keys are changed, save them in a GSList* and signal that GSList*
1088 further every X seconds, to batch changes, to allow us to do just one
1089 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1090 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1092 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1093 changed signal signature.
1095 * src/modest-conf.c: (modest_conf_set_list),
1096 (modest_conf_on_change): Reenable notification.
1098 (modest_conf_maemo_fake_on_change): Comment out the hack that
1099 notified immediately instead of asynchronously.
1101 * src/widgets/modest-account-view.h:
1102 * src/widgets/modest-account-view.c:
1103 (update_account_view): Select the previously-selected account ID,
1104 if possible. This fixes projects.maemo.org bug NB#56933.
1106 (on_account_changed), (on_account_removed),
1107 (modest_account_view_select_account):
1109 Remove the block/unblock functions
1110 because they were not useful.
1112 * src/maemo/modest-account-view-window.c:
1113 (on_delete_button_clicked), (on_edit_button_clicked),
1114 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1116 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1118 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1119 Improve the error dialog to show Incorrect Account Settings, which seems
1120 clearer, and say that the internal error message (to be removed from the
1121 dialog later) is often misleading.
1122 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1124 * src/modest-tny-account.c:
1125 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1126 URL because this is so useful for debugging on the device.
1128 * src/widgets/modest-serversecurity-combo-box.c:
1129 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1131 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1133 * src/modest-mail-operation.c:
1134 (modest_mail_operation_send_new_mail):
1135 Added a comment about a nasty but apparently harmless message. Details
1136 added to the wiki g_warnings() page.
1138 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1141 (modest_tny_send_queue_class_init):
1142 Do not use the priv struct because it is empty, to avoid g_warnings
1143 about a non-existant priv struct.
1145 * src/modest-tny-account-store.c:
1146 (modest_tny_account_store_get_server_account),
1147 (modest_tny_account_store_get_transport_account_for_open_connection
1148 ): Do not try to get transport server accounts for local folders,
1149 because they don't have any. This avoids a g_warning().
1151 * src/maemo/modest-main-window.c:
1152 (modest_main_window_notify_send_receive_initied),
1153 (on_configuration_key_changed):
1154 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1155 * src/modest-defs.h:
1156 * src/modest-mail-operation.c:
1157 (modest_mail_operation_update_account):
1158 * src/modest-tny-account-store.h:
1159 * src/modest-tny-account.c:
1160 (modest_tny_account_get_special_folder),
1161 (modest_tny_account_new_for_local_folders),
1162 (modest_tny_account_new_for_per_account_local_outbox_folder):
1163 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1164 * src/modest-tny-local-folders-account.c:
1165 (add_account_folders_to_merged_folder):
1166 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1167 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1168 (modest_ui_actions_on_send):
1169 * src/widgets/modest-folder-view.c: (update_model):
1170 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1171 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1172 modest_tny_account_store_get_tny_account_by_account() to
1173 modest_tny_account_store_get_server_account() to make the code clearer.
1175 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1177 * src/dbus_api/modest-dbus-api.h:
1178 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1179 * src/maemo/modest-msg-edit-window.c:
1180 (modest_msg_edit_window_attach_file_noninteractive):
1181 added g_warning in case the file to be attached does not exist
1182 * tests/dbus_api/test_compose_mail.c: (main):
1183 removed obsolete comment, added generic files as test case
1185 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1187 * src/modest-tny-account-store.c: (get_server_accounts):
1188 Create the local folders account only once, not once for each outbox, and
1189 not only when there are some outboxes.
1191 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1193 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1194 code that is causing a crash at startup. Sergio says that he is fixing this.
1196 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1198 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1199 * src/maemo/modest-account-settings-dialog.c:
1200 (create_page_outgoing),
1201 (modest_account_settings_dialog_set_account_name),
1202 (save_configuration):
1203 - Fixed handling of the "Use secure authentication" toggle to comply with
1204 the ui specification. See also projects.maemo.org bug NB#58400
1206 - Restore the Secure connection setting combo correctly when loading
1209 * src/maemo/modest-maemo-utils.c:
1210 (on_camel_account_get_supported_secure_authentication),
1211 (modest_maemo_utils_get_supported_secure_authentication_methods):
1212 Fixed a crasher if operation is canceled
1214 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1215 (modest_protocol_info_auth_is_secure):
1216 * src/modest-protocol-info.h:
1218 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1219 the sense of the "Use secure authentication" toggle.
1221 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1223 * src/modest-tny-account-store.h:
1224 * src/modest-tny-account-store.c:
1225 Added modest_tny_account_store_get_local_folders_account().
1227 * src/modest-tny-folder.h:
1228 * src/modest-tny-folder.c:
1229 (modest_tny_folder_get_account):
1230 Added this replacement for tny_folder_get_account() which returns
1231 the local-folders account for TnyMergeFolders, to avoid the
1232 warning about the unimplemented get_account_func() vfunc().
1234 (modest_tny_folder_get_rules),
1235 * src/modest-ui-actions.c:
1236 (modest_ui_actions_on_folder_selection_changed):
1237 * src/modest-mail-operation.c:
1238 (modest_mail_operation_remove_folder),
1239 (modest_mail_operation_xfer_folder),
1240 (modest_mail_operation_rename_folder),
1241 (modest_mail_operation_get_msg),
1242 (modest_mail_operation_get_msgs_full),
1243 (modest_mail_operation_remove_msg),
1244 (modest_mail_operation_xfer_msgs),
1245 (modest_mail_operation_refresh_folder):
1246 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1248 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1250 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1251 (modest_server_account_set_security):
1252 * src/modest-defs.h: Add comments explaining that our
1253 UI spec means TLS when it says Normal, so these do not look like errors.
1255 * src/modest-tny-account.c:
1256 (modest_tny_account_new_from_server_account): Use the new tinymail
1257 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1258 for TLS. This should fix projects.maemo.org bug NB#58460.
1260 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1262 * src/maemo/easysetup/modest-easysetup-wizard.c:
1263 (create_account): Correct the position of the gconf sanity check warning.
1264 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1265 of using the g_idle_add() hack, because this does not seem to be necessary
1266 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1267 caused by something other than maemo's gconf.
1268 This fixes projects.maemo.org bug #59022.
1270 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-account-mgr-helpers.c:
1273 (modest_account_mgr_get_default_account): Do not check that the account
1274 exists if there is no default account (NULL), to fix a runtime warning.
1276 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1278 * src/widgets/modest-folder-view.c: (update_model):
1279 Do not unref the treemodel before we have finished with it.
1280 This prevents a valgrind warning and an occasional crash at startup.
1282 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1284 * libmodest-dbus-client/libmodest-dbus-client.h:
1285 added libmodest_dbus_client_compose_mail()
1286 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1288 added functions needed for SendAsMail() functionality
1289 * src/maemo/modest-msg-edit-window.c:
1290 (modest_msg_edit_window_attach_file_noninteractive):
1291 non interactively attaching files to message edit window
1292 * src/widgets/modest-msg-edit-window.h:
1293 * tests/dbus_api/Makefile.am:
1294 added test_compose_mail.c
1295 * tests/dbus_api/test_compose_mail.c: (main):
1297 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1299 * src/modest-account-view.c:
1300 Fixed bug projects.maemo.org bug NB#59307
1302 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1304 * src/maemo/easysetup/modest-easysetup-wizard.c:
1305 (get_serverport_incoming), (on_before_next), (create_account):
1306 * src/maemo/modest-account-settings-dialog.c:
1307 (modest_account_settings_dialog_set_account_name):
1308 * src/maemo/modest-maemo-utils.c:
1309 (on_camel_account_get_supported_secure_authentication_status),
1310 (on_camel_account_get_supported_secure_authentication),
1311 (on_secure_auth_cancel),
1312 (modest_maemo_utils_get_supported_secure_authentication_methods):
1314 Implemented security authentication for settings and easysetup.
1316 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1318 * src/maemo/modest-main-window.c: (create_details_widget):
1319 Show the total size for memory card accounts too, instead of showing
1320 the name again. Fixes bug projects.maemo.org bug NB#59307.
1322 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1325 * src/modest-tny-simple-folder-store.c:
1326 * src/modest-tny-simple-folder-store.h: Removed.
1328 * src/modest-tny-local-folders-account.h
1329 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1330 for the local-folders maildir, with an extra TnyMergedFolder containing
1331 the folders of the per-account outbox store accounts.
1332 * src/modest-tny-account-store.c: (get_server_accounts):
1333 Add the outboxes to the special local folders account after creating it.
1335 * src/modest-tny-account.c:
1336 (modest_tny_account_new_for_local_folders): Create the derived
1337 account when creating the main local-folders account.
1339 * src/maemo/modest-main-window.c: (create_details_widget),
1340 (modest_main_window_set_contents_style):
1341 Adapted to the use of the derived account instead of the folder store.
1343 * src/modest-ui-actions.c:
1344 (modest_ui_actions_on_folder_selection_changed):
1345 * src/modest-ui-dimming-rules.c:
1346 (modest_ui_dimming_rules_on_new_folder):
1347 * src/widgets/modest-folder-view.c: (text_cell_data),
1348 (icon_cell_data), (filter_row), (update_model),
1349 (get_cmp_rows_type_pos):
1352 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1353 Do not get the priv struct, because no priv struct has been set,
1354 to avoid a runtime warning.
1356 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1357 #ifelse with #else, to fix a warning, to fix the build.
1360 2007-06-05 Christian Kellner <ckellner@openismus.com>
1362 * libmodest-dbus-client/libmodest-dbus-client.c:
1363 Fix small typo in doc (why do you always see them
1364 AFTER committing stuff?)
1367 2007-06-05 Christian Kellner <ckellner@openismus.com>
1369 * libmodest-dbus-client/libmodest-dbus-client.c:
1370 (libmodest_dbus_client_search):
1371 Initialize hit list with NULL. Also set folder list
1372 to "" if NULL was supplied.
1375 2007-06-03 Christian Kellner <ckellner@openismus.com>
1377 * libmodest-dbus-client/libmodest-dbus-client.c:
1378 (modest_search_hit_list_free):
1379 Make it save to call it with NULL.
1381 * src/dbus_api/modest-dbus-callbacks.c:
1382 * src/modest-search.c:
1383 Return full ModestSearchHits as the search result list not TnyHeader
1384 since can't be around withouth the correspoding TnyFolder.
1386 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1388 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1389 Added currently commented code to check for secure auth
1391 * src/maemo/modest-account-settings-dialog.c: (on_response),
1392 (save_configuration), (show_ok):
1393 Fixed projects.maemo.org bugs NB #59248 and #59251
1395 * src/maemo/modest-maemo-utils.c:
1396 (on_camel_account_get_supported_secure_authentication_status),
1397 (on_camel_account_get_supported_secure_authentication),
1398 (modest_maemo_utils_get_supported_secure_authentication_methods):
1399 * src/maemo/modest-maemo-utils.h:
1400 Moved get_supported_secure_authentication() method here to be able
1401 to use it from easysetup wizard.
1403 * src/modest-pair.c: (on_pair_compare_as_string):
1404 Should compare string with first part of pair and not
1405 strcmp pairs which will crash.
1407 * src/modest-protocol-info.c:
1408 (modest_protocol_info_protocol_is_store):
1409 * src/modest-protocol-info.h:
1410 Added modest_protocol_info_get_auth_protocol_name()
1412 2007-06-03 Armin Burgmeier <armin@openismus.com>
1414 * src/modest-mail-operation.c:
1415 (modest_mail_operation_get_msgs_full): Set priv->account also when
1416 only retrieving a single message. This avoids a crash when canceling
1419 (modest_mail_operation_notify_end): Do not explicitely remove the
1420 operation from the queue but only emit the progress_changed signal.
1421 The queue itself listens to that signal to remove the operation when
1422 it is finished. This reduces coupling and removes a potential deadlock
1423 when modest_mail_operation_notify_end() is called from the queue
1424 itself. If that is a problem performance-wise, I would suggest to
1425 implement a status-changed signal or something.
1427 * src/modest-mail-operation-queue.c: Make sure to never call a
1428 function from another file while the queue is locked. This (hopefully)
1429 fixes another deadlock when exiting the application while retrieving
1432 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1434 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1435 Fixed build if libogs is not available
1437 2007-06-03 Christian Kellner <ckellner@openismus.com>
1439 * libmodest-dbus-client/libmodest-dbus-client.h:
1440 * libmodest-dbus-client/libmodest-dbus-client.c:
1441 (libmodest_dbus_client_delete_message):
1442 Implement deletion of messages (Client side).
1444 (modest_search_hit_free),
1445 (modest_search_hit_list_free):
1446 Utility functions to free the result hits.
1448 * src/dbus_api/modest-dbus-api.h:
1449 * src/dbus_api/modest-dbus-callbacks.c:
1450 (on_delete_message),
1451 (modest_dbus_req_handler):
1452 Implement deletion of messages (Server side).
1454 * tests/dbus_api/test_search.c: (main):
1457 * tests/dbus_api/Makefile.am:
1458 * tests/dbus_api/test_delete_message:
1459 Add little test for the message deletion logic
1461 2007-06-03 Armin Burgmeier <armin@openismus.com>
1463 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1464 when the operation queue was not empty. projects.maemo.org bug
1467 2007-06-03 Armin Burgmeier <armin@openismus.com>
1469 * src/widgets/modest-account-view.c
1470 (on_account_default_toggled): Toggle default account column
1471 explicitely instead of waiting for gconf notification (which is
1472 currently ignored). This should fix projects.maemo.org bug NB#56910
1473 for now. It should probably be removed when gconf notifications are
1476 2007-06-03 Christian Kellner <ckellner@openismus.com>
1478 * libmodest-dbus-client/libmodest-dbus-client.c:
1479 Removed debugging spew.
1481 * src/dbus_api/modest-dbus-callbacks.c:
1482 Added debugging info.
1484 * src/modest-search.c:
1485 (modest_search_all_accounts):
1486 Use tny_account_store_get_accounts () on the account store
1487 to get all accounts which is the way to get all accounts.
1489 * tests/dbus_api/test_search.c: (main):
1490 Make it possible to supply the search term on the command line.
1492 2007-06-03 Christian Kellner <ckellner@openismus.com>
1494 * libmodest-dbus-client/libmodest-dbus-client.c:
1495 * libmodest-dbus-client/libmodest-dbus-client.h:
1496 Implement searching for mesages over raw dbus. (Client side)
1498 * src/dbus_api/Makefile.am:
1499 * src/dbus_api/modest-dbus-api.h:
1500 * src/dbus_api/modest-dbus-callbacks.c:
1501 * src/dbus_api/modest-dbus-callbacks.h:
1502 Search framework (Server side). Also implement on_idle_open_message().
1504 * src/maemo/modest-platform.c: (modest_platform_init):
1505 Prepare for raw dbus/osso rpc interaction.
1507 * src/modest-search.h:
1508 Changed minsize from unspecific guint to guint32.
1510 * src/modest-search.c:
1512 Added strange hack which magically made tnymail work.
1514 (modest_search_folder),
1515 (modest_search_account),
1516 (modest_search_all_accounts):
1517 Implement helper functions to search all accounts, specific account
1520 * tests/dbus_api/Makefile.am:
1521 * tests/dbus_api/test_open_message.c:
1522 Read url to open from commandline.
1524 * tests/dbus_api/test_search.c:
1525 Implement small test for dbus search stuff
1527 2007-06-02 Armin Burgmeier <armin@openismus.com>
1529 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1530 include account type and account title. This fixes projects.maemo.org
1533 * src/maemo/modest-account-view-window.c: Set a title for the window.
1535 2007-06-02 Armin Burgmeier <armin@openismus.com>
1537 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1538 incoming and outgoing server name based on email address and server
1539 types as long as the names have not been edited manually. This fixes
1540 projects.maemo.org bug NB#58671.
1542 2007-06-02 Armin Burgmeier <armin@openismus.com>
1544 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1545 server type cannot be changed in future to the incoming details page
1546 when creating an account. This fixes projects.maemo.org bug NB#59029.
1548 2007-06-02 Armin Burgmeier <armin@openismus.com>
1550 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1551 and assigned max width chars so that they wrap instead of being
1552 truncated. Fixes projects.maemo.org bug NB#56126.
1554 2007-06-02 Armin Burgmeier <armin@openismus.com>
1556 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1557 introductory note to the connection specific smtp servers dialog, as
1558 section 8.12 of the email UI specification requires. This fixes
1559 projects.maemo.org bug NB#59212.
1561 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1564 Check for running mail operations, and offer to cancel them, as per the UI
1565 spec. This fixes projects.maemo.org bug NB#59041 .
1566 However, I suspect that tinymail may still use the network connection
1567 in ways that we cannot detect or cancel. But it should at least adapt to
1568 changes fairly well.
1570 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1572 * src/modest-tny-account-store.c: (recreate_all_accounts),
1573 (get_cached_accounts), (get_server_accounts): Do more sensible
1574 ref-counting of the temporarily-cached outbox accounts list. This seems
1575 to fix a crash when entering the password when the password was wrong.
1577 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1579 * src/gnome/modest-main-window.c: (connect_signals):
1580 * src/modest-tny-account-store.c: (get_password),
1581 (modest_tny_account_store_alert): Added comments and clues and
1582 commented-out code about how we currently fail to deal with connection
1583 errors and wrong passwords, and how we should.
1585 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1587 * src/widgets/modest-retrieve-combo-box.c:
1588 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1589 This fixes projects.maemo.org bug NB#58472 .
1591 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/easysetup/modest-easysetup-wizard.c:
1594 (create_page_complete_easysetup):
1595 (create_page_complete_custom): Correct the last commit,
1596 putting the correct sentences in the correct pages.
1598 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1600 * src/maemo/easysetup/modest-easysetup-wizard.c:
1601 (create_page_complete_custom): Show the second sentence of text
1602 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1605 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1607 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1608 Set the leave-on-server conf key by default. This fixes
1609 projects.maemo.org bug NB#59258 .
1611 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/modest-account-view-window.c:
1614 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1615 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1618 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1620 * src/maemo/easysetup/modest-easysetup-wizard.c:
1621 (create_caption_new_with_asterisk):
1622 * src/maemo/modest-account-settings-dialog.c:
1623 (create_caption_new_with_asterisk):
1624 Uncomment the code to add the asterisk, because they are no longer in the
1625 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1626 (update_incoming_server_title): Add an asterisk here too.
1628 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1630 * src/maemo/modest-maemo-global-settings-dialog.c:
1631 (current_connection): Check that we are even connected before trying to
1632 get the current connection name, to prevent a warning.
1634 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1635 Change the comments because tny_maemo_conic_device_connect() is now meant to
1637 * src/modest-mail-operation.c:
1638 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1639 make sure we have a connection and fail if we can't connect.
1641 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/modest-main-window.c:
1644 (on_account_store_connecting_finished): Do not try to get the
1645 connection ID if we are not really connected. I am surprised that
1646 this signal handler is called when we are not connected.
1648 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1650 * src/modest-error.h:
1651 * src/modest-ui-actions.c:
1652 (modest_ui_actions_get_msgs_full_error_handler):
1653 Renamed an enum, added comments, added an enum
1654 for retrieve-limit errors.
1656 * src/modest-mail-operation.c: (foreach_add_item),
1657 (internal_folder_observer_update), (update_account_thread),
1658 (modest_mail_operation_get_msgs_full):
1659 (modest_mail_operation_update_account),
1660 Added comments about how this works, and some code that should
1661 (but does not) check the retrieve-limit. See the TODO comment.
1663 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1665 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1666 Initialize help_id to fix the build. Warnings are good.
1668 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1670 * src/widgets/modest-hbox-cell-renderer.c:
1671 (modest_hbox_cell_renderer_append):
1672 * src/widgets/modest-vbox-cell-renderer.c:
1673 (modest_vbox_cell_renderer_append):
1674 Fix the last commit by doing an extra ref.
1676 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1678 * src/widgets/modest-hbox-cell-renderer.c:
1679 (modest_hbox_cell_renderer_append):
1680 * src/widgets/modest-vbox-cell-renderer.c:
1681 (modest_vbox_cell_renderer_append):
1682 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1683 to fix the build with Maemo Bora.
1684 However, there seems to be a remaining crash, probably due to reference
1687 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1689 * src/modest-tny-account.c:
1690 (modest_tny_account_new_for_local_folders):
1691 Use hildon_file_system_info_async_new() to get a better name for
1692 the memory card account, setting it as the account name.
1693 The timing seems to work, but this is probably
1694 not the best place to do this. See the TODO comment.
1695 * src/maemo/modest-main-window.c: (create_details_widget):
1696 * src/widgets/modest-folder-view.c: (text_cell_data):
1697 Use the tny account name instead of hardcoding a name.
1699 2007-05-30 Christian Kellner <ckellner@openismus.com>
1701 * src/modest-search.c: (modest_search):
1702 Correctly set part_search_func even if we have already parsed
1703 the query and thus a valid OgsTextSearcher object.
1705 2007-05-30 Christian Kellner <ckellner@openismus.com>
1708 Search and check for libogs.
1711 Incooparte the ogs build env.
1713 * src/modest-mime-part-search-stream.c:
1714 * src/modest-mime-part-search-stream.h:
1715 Removed since we do the real searching now in modest-search.c.
1717 * src/modest-search.c:
1718 * src/modest-search.h:
1719 Implement support for ogs. We use that if available and requested
1720 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1721 should now handle the corner case when the search term is spread
1722 across multiple reads.
1723 Also the logic in modest_search () was corrected to search all
1724 requested fields until one is found.
1726 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1728 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1730 * src/modest-init.h:
1731 * src/modest-init.c: Made modest_init_local_folders() take a
1732 path and be public so we can iniitialize maildir folders on
1735 * src/modest-local-folder-info.h:
1736 * src/modest-local-folder-info.c:
1737 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1739 * src/modest-tny-account.c:
1740 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1741 still means the standard local-folders path on the local volume.
1743 * src/modest-tny-account-store.c:
1744 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1745 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1746 all accounts when that happens.
1747 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1748 this too, so it shows up in the treeview.
1750 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1752 * src/maemo/modest-maemo-global-settings-dialog.c:
1753 (current_connection):
1754 * src/widgets/modest-global-settings-dialog.c:
1755 (current_connection_default):
1756 Use the enum values instead of 0, 1 and -1,
1757 to make the code clearer.
1759 * src/modest-account-mgr-helpers.c:
1760 (modest_account_mgr_get_connection_specific_smtp): Make this code
1763 * src/modest-runtime.h:
1764 * src/modest-runtime.c:
1765 Added modest_runtime_remove_all_send_queues().
1766 * src/maemo/modest-main-window.c:
1767 (on_account_store_connecting_finished): Recreate the send queues,
1768 using the appropriate transport accounts for this new connection.
1769 Some futher adapting might be needed if the old send queues are not
1770 automatically stopped at this point.
1772 * src/modest-tny-account-store.c: (get_server_accounts):
1773 Create the connection-specific transport accounts, so that they can
1774 be found later by their ID.
1776 * src/modest-tny-account.h:
1777 * src/modest-tny-account.c:
1778 Added modest_tny_account_new_from_server_account_name().
1779 modest_tny_account_new_from_server_account(): Do not create the
1780 send queues here, because they will be
1781 recreated anyway when the connection changes for the first time.
1783 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1785 * src/modest-local-folder-info.h:
1786 * src/modest-local-folder-info.c:
1787 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1788 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1789 tbox_folder): Take a modest account name instead of a server TnyAccount,
1790 so we can have per-modest-account rather than per-transport-account
1792 We must make sure that we change or recreate the exisitng send queues
1793 when the connection changes for connection-specific transport accounts.
1795 * src/modest-tny-account-store.c:
1796 (create_per_account_local_outbox_folders): Create outboxed per modest
1797 account, not per transport account.
1799 * src/modest-tny-account.h:
1800 * src/modest-tny-account.c:
1801 (modest_tny_account_get_special_folder): For outboxes, get the
1802 parent modest account name. The account is ignored for other folders.
1803 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1804 modest account name rather than a server TnyAccount.
1806 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1808 * src/modest-tny-account.c:
1809 (modest_tny_account_new_from_server_account):
1810 Call modest_runtime_get_send_queue() immediately after creating transport
1811 accounts, so that they start trying to send email from the outbox as soon
1812 as possible at startup. This is probably what we want.
1814 * src/modest-mail-operation.c: (update_account_thread):
1815 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1816 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1817 * src/modest-tny-send-queue.h:
1818 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1819 (modest_ui_actions_on_send):
1820 Added comments about how sending works, though it needs some more work.
1822 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-tny-account.c:
1825 (modest_tny_account_get_special_folder): Add TODO because this fails when
1826 the network is busy.
1827 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1828 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1829 Do not try to show this window when there is no active account. The UI
1830 specs does not tell us what to do in this case.
1832 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1836 * src/maemo/Makefile.am:
1837 * src/widgets/Makefile.am: Some dist fixes.
1839 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1841 * src/maemo/modest-connection-specific-smtp-window.c:
1842 (on_button_edit): Make the code clearer, to prevent a double free.
1844 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1846 * src/maemo/modest-account-settings-dialog.c:
1847 (modest_account_settings_dialog_set_account_name),
1848 Check the connection-specific smtp servers checkbox if there are any.
1850 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1851 (modest_connection_specific_smtp_edit_window_init):
1852 Start with a suitable port number.
1854 * src/modest-account-mgr-helpers.h:
1855 * src/modest-account-mgr-helpers.c: Added
1856 modest_account_mgr_get_has_connection_specific_smtp().
1858 (modest_account_mgr_set_connection_specific_smtp),
1859 (modest_account_mgr_remove_connection_specific_smtp),
1860 (modest_account_mgr_get_has_connection_specific_smtp),
1861 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1862 connection-specific smtp server accounts in the account, rather than
1863 the server account conf dir.
1865 This fixes bug projects.maemo.org bug NB#58263 .
1867 * src/modest-tny-account-store.c:
1868 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1869 if there are no server accounts yet, to prevent an infinite loop when there
1870 are no accounts. Document that one must be called before the other.
1872 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-account-mgr-helpers.c:
1875 (modest_account_mgr_get_default_account): Make sure that at least
1876 one account is always the default, if there are any enabled accounts.
1877 This is just a sanity check that shouldn't be necessary.
1879 * src/modest-account-mgr-priv.c:
1880 (_modest_account_mgr_account_from_key): Unescape the conf key to
1881 get the real account name. For instance, this is an issue if a space
1882 was in the account name, which can happen because the account name
1883 is generated from the display name.
1884 (_modest_account_mgr_get_account_keyname): Always escape the
1886 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1887 Unescape the conf keys to get the real account names.
1889 For instance, previously the is-default radio button in the accounts
1890 list was not checked for any accounts at first. This fixes that,
1891 and might fix several similar bugs.
1893 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1895 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1896 Removed some debug printfs.
1898 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1900 Modest on-disk outbox directories are now here, for instance:
1901 $HOME/.modest/outboxes/<account-id-1>/outbox
1902 $HOME/.modest/outboxes/<account-id-2>/outbox
1904 $HOME/.modest/local-folders/outbox
1905 so we can have a separate outbox for each account.
1906 But they are shown as one outbox in the GtkTreeView, by using a
1907 TnyMergeFolder in a ModestTnySimpleFolderStore.
1910 * src/modest-tny-simple-folder-store.c:
1911 * src/modest-tny-simple-folder-store.h:
1912 Added ModestTnySimpleFolderStore, used to contain folders from
1913 other folder stores, such as other accounts.
1915 * src/modest-tny-outbox-account.h:
1916 * src/modest-tny-outbox-account.c:
1917 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1918 used for the per-account local outbox folders.
1920 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1921 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1922 only use this (internally) now for the non-outbox local folders.
1924 * src/modest-init.h:
1925 * src/modest-init.c: Added modest_init_one_local_folder(), for
1926 setting up the directory structure for each local folder.
1928 * src/modest-local-folder-info.c:
1929 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1930 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1932 * src/modest-local-folder-info.h:
1933 * src/modest-tny-account-store.c: (on_account_removed),
1934 (on_account_changed), (create_per_account_local_outbox_folders),
1935 (get_server_accounts), (modest_tny_account_store_get_accounts),
1936 (modest_tny_account_store_get_tny_account_by_account),
1937 (modest_tny_folder_store_is_virtual_local_folders):
1939 * src/modest-tny-account.h:
1940 * src/modest-tny-account.c:
1941 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1942 to create an on-disk per-account local outbox folder for each
1944 (create_per_account_local_outbox_folders): Create a local outbox folder
1945 for each transport account.
1946 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1947 for all local folders.
1949 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1950 instead of using g_object_get/set() directly. It is clearer.
1952 (modest_tny_folder_store_get_message_count),
1953 (modest_tny_folder_store_get_local_size
1954 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1955 because we now use these with non-acount folder stores.
1957 (modest_tny_account_get_special_folder),
1958 (modest_tny_account_new_from_server_account),
1959 (modest_tny_account_new_from_account):
1960 (recurse_folders): Adjust to the new outbox system.
1962 * src/modest-tny-folder.h:
1963 * src/modest-tny-folder.c:
1964 (modest_tny_folder_is_local_folder),
1965 (modest_tny_folder_get_local_folder_type),
1966 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1968 * src/widgets/modest-main-window.h:
1969 * src/maemo/modest-main-window.c: (create_details_widget),
1970 (modest_main_window_set_contents_style): Show details for any folder store,
1973 (modest_tny_folder_get_rules):
1974 Remove the const. C does not support constness enough for this.
1976 * src/modest-ui-actions.c:
1977 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1978 make all outboxes appear as one, in the usual local-folders tree node.
1980 (set_active_account_from_tny_account),
1981 (modest_ui_actions_on_folder_selection_changed):
1982 * src/widgets/modest-folder-view.c: (text_cell_data),
1983 (icon_cell_data), (filter_row),
1984 (add_account_folders_to_merged_folder),
1985 (add_account_folders_to_simple_folder_store), (),
1986 (get_cmp_rows_type_pos), (cmp_rows),
1987 (modest_folder_view_set_account_id_of_visible_server_account):
1988 Adjust to the new outbox system, using generic folder stores and folders
1989 in the GtkTreeModel.
1991 2007-05-23 Christian Kellner <ckellner@openismus.com>
1993 * src/modest-mail-operation.c:
1994 (modest_mail_operation_update_account):
1995 Use info->max_size instead of unintialized local var [small
1996 build fix]. (Added TODO to review that change since I don't
1999 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2001 * libmodest-dbus-client/libmodest-dbus-client.c:
2002 (libmodest_dbus_client_compose_mail): function added
2003 * src/dbus_api/modest-dbus-api.h:
2004 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2005 (on_compose_mail): Implementation of the SendAsMail functionality
2007 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2009 * src/modest-account-mgr.c:
2010 (modest_account_mgr_add_server_account): Set the secure-connection
2011 conf key for transport accounts as well as store accounts. I don't know
2012 why the if was there. For instance, this makes sure that we use SSL
2013 for the gmail preset from the easysetup wizard.
2015 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2017 * src/gnome/modest-main-window.c:
2018 (on_account_store_connecting_finished), (connect_signals):
2019 * src/maemo/modest-main-window.c:
2020 (on_account_store_connecting_finished), (connect_signals),
2021 (modest_main_window_new):
2022 Handle TnyAccountStore::connecting-finished instead of
2023 TnyDevice::connection-changed, because we cannot actually perform
2024 operations on accounts until TnyAccountStore has itself responded to
2025 the TnyDevice::connection-changed signal. This prevents a GError from
2027 Do not try to update at startup, because we (at least on scratchbox)
2028 already do an update at startup when the device goes online.
2029 This prevents a GError from tinymail.
2030 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2031 Added TODO about stopping simultaneous operations.
2033 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2035 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2036 * src/modest-mail-operation-queue.c:
2037 (modest_mail_operation_queue_remove):
2038 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2039 about where they happened.
2041 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2043 * src/modest-ui-actions.c:
2044 (modest_ui_actions_on_password_requested): Make sure that the remember
2045 output parameter is always TRUE.
2047 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2049 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2050 Show a OK/Cancel dialog if the error is a question, though we still do not
2051 know anything more about what we are asking the user.
2052 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2053 Fix an uninitialized variable (helper). This is a logic error, however.
2055 2007-05-21 Christian Kellner <ckellner@openismus.com>
2057 * src/modest-search.h:
2058 Correct bit shifting in the ModestSearchFlags enum.
2060 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2062 * src/modest-tny-account.c:
2063 (modest_tny_account_new_from_server_account): Do not use the lsub and
2064 check-all hard-coded IMAP options when using POP.
2066 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-tny-account.c:
2069 (modest_tny_account_new_from_server_account):
2070 Use NULL for the secure-auth method for POP when Password auth has been
2071 specified by the user, as we already do for IMAP. "auth=Login" causes
2072 an error from camel or the server.
2074 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/modest-account-settings-dialog.c:
2077 (create_page_account_details),
2078 (modest_account_settings_dialog_set_account_name):
2079 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2080 for the leave-on-server checkbox, rathr than just the checkbox, when
2081 the protocol is not POP.
2083 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2085 * src/widgets/modest-account-view.c:
2086 * src/widgets/modest-account-view.h:
2087 Added modest_account_view_select_account() which will be useful later
2088 to asynchronously re-select the edited account.
2090 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2092 * src/maemo/modest-account-settings-dialog.c:
2093 (modest_account_settings_dialog_set_account_name):
2094 Automatically choose the port numbers based on the secure authentication
2095 methods, if they have not been chosen before.
2096 This fixes projects.maemo.org bug NB#56273 .
2098 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/modest-main-window-ui.h:
2101 * src/modest-ui-actions.c:
2102 * src/modest-ui-actions.h:
2103 Connect the Tools/SMTP Servers menu item to
2104 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2105 SMTP servers dialog, as in the UI specification and saves changes when it
2106 is closed. This fixed projects.maemo.org bug NB#56305 .
2108 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2110 * src/maemo/modest-connection-specific-smtp-window.c:
2111 (modest_connection_specific_smtp_window_init):
2112 Use gtk_window_set_default_size() to make this window big enough, so
2113 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2115 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2117 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2118 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2119 (modest_connection_specific_smtp_edit_window_init),
2120 Do not try to connect to a combobox signal before the combobox exists.
2121 This fixes the cras in projects.maemo.org bug NB#56288 .
2122 (modest_connection_specific_smtp_edit_window_get_settings):
2123 Remove the server_account_name parameter which was being checked for NULL
2124 though it was not used.
2126 * src/maemo/modest-connection-specific-smtp-window.c:
2127 (modest_connection_specific_smtp_window_fill_with_connections),
2128 (on_button_edit), (modest_connection_specific_smtp_window_init):
2129 Correct the number of treemodel columns to prevent a warning.
2130 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2131 libconic does not work.
2133 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2135 * src/modest-tny-account.c:
2136 (modest_tny_account_new_from_server_account):
2137 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2138 SMTP when "None" was chosen by the user. However, with my SMTP server that
2139 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2142 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2144 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2145 to explain the memory management issue with the ID in the ModestPair.
2147 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2148 (add_sending_page), (modest_account_assistant_finalize):
2149 * src/gnome/modest-gnome-global-settings-dialog.c:
2150 (create_updating_page), (create_composing_page):
2151 * src/gnome/modest-msg-edit-window.c: (get_transports),
2152 (init_window), (modest_msg_edit_window_finalize),
2153 (modest_msg_edit_window_get_msg_data):
2154 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2155 * src/gnome/modest-transport-widget.c:
2156 (modest_transport_widget_finalize), (smtp_configuration):
2157 * src/maemo/modest-maemo-global-settings-dialog.c:
2158 (create_updating_page), (create_composing_page):
2159 * src/maemo/modest-msg-edit-window.c: (get_transports),
2160 (init_window), (modest_msg_edit_window_finalize),
2161 (modest_msg_edit_window_get_msg_data),
2162 (modest_msg_edit_window_free_msg_data):
2163 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2164 (modest_store_widget_finalize):
2165 * src/maemo/modest-transport-widget.c:
2166 (modest_transport_widget_finalize), (smtp_configuration):
2167 * src/modest-main.c: (send_mail):
2168 * src/widgets/modest-combo-box.h:
2169 * src/widgets/modest-global-settings-dialog-priv.h:
2170 * src/widgets/modest-global-settings-dialog.c:
2171 (modest_global_settings_dialog_finalize):
2172 * src/widgets/modest-msg-edit-window.h:
2173 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2174 as long as the combo box, to prevent use of freed memory for the ID.
2176 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2178 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2179 get_accounts(), to make this clearer. Do not check for the enabled gconf
2180 key, because we do not use this for server accounts (at least, not yet).
2181 This allows us to send email again.
2183 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2185 * src/maemo/modest-platform.c:
2186 (on_modest_conf_update_interval_changed), (modest_platform_init):
2187 Only respond to this particular key change. All these strcmp()s cannot be
2190 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2192 * src/maemo/modest-maemo-global-settings-dialog.c:
2193 (current_connection): Prevent a crash in scratchbox when
2194 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2195 * src/maemo/modest-platform.c:
2196 (on_modest_conf_update_interval_changed), (modest_platform_init):
2197 Get the update interval from gconf and reset it when the gconf key changes.
2199 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2201 * src/modest-protocol-info.c:
2202 * src/modest-protocol-info.h: Adde enum-specific get functions,
2203 instead of using a ModestProtocolType enum parameter.
2205 * src/gnome/modest-account-assistant.c:
2206 * src/gnome/modest-store-widget.c:
2207 * src/gnome/modest-store-widget.h:
2208 * src/gnome/modest-transport-widget.c:
2209 * src/gnome/modest-transport-widget.h:
2210 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2211 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2212 * src/maemo/easysetup/modest-easysetup-wizard.c:
2213 * src/maemo/modest-account-settings-dialog.c:
2214 * src/maemo/modest-account-settings-dialog.h:
2215 * src/maemo/modest-store-widget.c:
2216 * src/maemo/modest-store-widget.h:
2217 * src/maemo/modest-transport-widget.c:
2218 * src/maemo/modest-transport-widget.h:
2219 * src/modest-account-mgr-helpers.c:
2220 * src/modest-account-mgr-helpers.h:
2221 * src/modest-account-mgr.c:
2222 * src/modest-account-mgr.h:
2223 * src/modest-tny-account.c:
2224 * src/modest-tny-folder.c:
2225 * src/widgets/modest-account-view.c:
2226 * src/widgets/modest-retrieve-combo-box.c:
2227 * src/widgets/modest-retrieve-combo-box.h:
2228 * src/widgets/modest-secureauth-combo-box.c:
2229 * src/widgets/modest-serversecurity-combo-box.c:
2230 * src/widgets/modest-serversecurity-combo-box.h:
2231 * tests/check_account-mgr.c:
2232 Use the specific functions, and use the re-renamed enum values for GNOME too.
2234 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2236 * src/modest-pair.h:
2237 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2238 so we can get the second based on the first.
2240 * src/maemo/modest-account-settings-dialog.h:
2241 * src/maemo/modest-account-settings-dialog.c:
2242 Added get_supported_secure_authentication_methods(), though it is mostly
2243 commented-out for now until the necessary API is committed to tinymail.
2244 (modest_account_settings_dialog_set_account_name),
2245 (save_configuration): Request the supported authentication methods from the
2246 server, so we can choose a working method.
2248 * src/modest-tny-account-store.h:
2249 * src/modest-tny-account-store.c:
2250 (modest_tny_account_store_get_session): Rename from
2251 tny_account_store_get_session().
2253 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2255 * src/modest-protocol-info.h: Split the ModestProtocol enum
2256 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2257 There was no need to have these unrelated values in one enum.
2259 * src/: many files: Adapted to changed enum. This makes the code a bit
2260 clearer, and the compiler could catch some errors.
2262 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2264 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2265 Show the detailed internal camel error message when an error happens
2266 during the configuration, so that our testers can give us more clues.
2267 For instance, in projects.maemo.org bug NB#56910 .
2269 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2271 * src/modest-tny-account.c:
2272 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2273 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2275 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2277 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2278 * src/maemo/modest-account-settings-dialog.c:
2279 (modest_account_settings_dialog_set_account_name),
2280 (save_configuration): For the incoming secure authentication checkbox,
2281 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2282 the UI specification. PLAIN does not seem to be supported for most IMAP
2283 servers anyway, and I am not sure what it would mean.
2284 However, we probably need to discover which of the secure-authentication
2285 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2286 * src/modest-account-mgr-helpers.c:
2287 (modest_account_mgr_get_server_account_data):
2289 * src/modest-tny-account.c:
2290 (modest_tny_account_new_from_server_account):
2291 Use tny_account_set_mech() to set secure-authentication methods,
2292 with some special-casing for IMAP, based on my observations of how
2295 * src/modest-account-mgr-helpers.h:
2296 * src/modest-account-mgr.c:
2297 * src/modest-defs.h: Comment that the URI is only used for local folders.
2299 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2301 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2302 parameter const, just to be neat.
2303 * src/modest-text-utils.c: (modest_text_utils_inline):
2304 End g_strconcat() with NULL, as its documentation says. This is almost
2305 certainly the cause of my crash at startup on the device. Interestingly,
2306 valgrind doesn't tell us about these errors.
2308 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2310 * scripts/build-packages: Added more precise comments about how to use
2311 this script, though I still get this error:
2312 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2313 error building tinymail
2315 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2317 * src/maemo/modest-main-window.c: (on_account_update):
2318 Very slight cleanup, hoping to make it simpler to discover what causes
2319 a crash here sometimes.
2321 * src/modest-tny-account.c:
2322 (modest_tny_account_new_from_server_account): Set the port. Added
2323 comments about the options and a TODO comment because I need to find out
2324 how to specify the secure authentication method.
2326 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2328 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2329 changed CFlags paths form modest to libmodest
2331 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2333 * src/modest-account-mgr-helpers.c:
2334 (modest_account_mgr_get_server_account_data),
2335 (modest_account_mgr_free_server_account_data):
2336 * src/modest-account-mgr-helpers.h:
2337 * src/modest-account-mgr.c:
2338 (modest_account_mgr_add_server_account):
2339 * src/modest-defs.h:
2340 * src/modest-tny-account.c:
2341 (modest_tny_account_new_from_server_account):
2342 Determine the options for tny_camel_account_add_option() here,
2343 based on the settings, rather than storing them directly in gconf.
2345 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2347 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2348 Show a more friendly error dialog now that we expect (from the tinymail
2349 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2351 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2353 * src/maemo/modest-main-window.c: (on_account_update): Check that
2354 account_name is not NULL, to prevent a crash at startup that I am
2355 seeing on the N800. I do wonder why it is NULL.
2357 * src/maemo/easysetup/modest-easysetup-wizard.c:
2358 (create_page_user_details):
2359 * src/maemo/modest-account-settings-dialog.c:
2360 (create_page_user_details), (create_page_outgoing):
2361 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2362 (modest_connection_specific_smtp_edit_window_init):
2363 * src/modest-ui-actions.c:
2364 (modest_ui_actions_on_password_requested):
2365 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2366 might do something useful with the on-screen keyboard.
2368 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2370 * src/maemo/modest-main-window.c: (on_account_update):
2371 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2372 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2374 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2376 * src/modest-tny-account-store.c: (on_account_changed):
2377 Correct the signature of this signal handler.
2379 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2381 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2382 Show a HildonNote instead of a GtkDialog for Maemo.
2384 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2386 * src/widgets/modest-account-view.h:
2387 * src/widgets/modest-account-view.c: (on_account_changed),
2388 (on_account_removed). Added a boolean flag, set/unset by
2389 modest_account_view_block_conf_updates(),
2390 modest_account_view_unblock_conf_updates() to prevent unnecessary
2391 updates, but this is not very useful because the gconf notifications are
2392 so delays (maybe only on Maemo Bora).
2393 So auto-updating is turned off, and these functions do an explicit
2394 update when necessary.
2395 However, something else is still doing too much work when adding/removing
2396 accounts, probably in another part of the application.
2398 * src/maemo/modest-account-view-window.c:
2399 (on_delete_button_clicked), (on_edit_button_clicked),
2400 (on_new_button_clicked): Use the new functions.
2402 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2404 * src/modest-account-mgr-helpers.c:
2405 (modest_account_mgr_set_first_account_as_default):
2406 Sort the list of names alphabetically-by-title, so we choose the first one
2408 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2409 alphabetically by the title.
2411 This fixes projects.maemo.org bug NB#56418 .
2413 * src/modest-account-mgr-priv.c:
2414 (_modest_account_mgr_account_from_key):
2415 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2416 avoid a valgrind error, and possible random behaviour.
2418 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2420 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2421 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2422 tinymail documentation to say that this can be expected.
2423 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2424 pretty, and should not happen, but I would prefer to know when it does.
2426 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2428 * configure.ac: When using the older hildon version, probably on Bora,
2429 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2431 * src/widgets/modest-attachment-view.c:
2432 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2435 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2437 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2438 Implemented the prototype. Can be tested with
2439 tests/dbus_api/test_open_message:
2441 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2443 * src/modest-tny-account-store.c:
2444 (modest_tny_account_store_instance_init), (get_password):
2445 * src/modest-ui-actions.c:
2446 (modest_ui_actions_on_password_requested):
2447 Do not store the password in gconf, because this function is called
2448 for non-remembered passwords. Actually use the cached (in the hash map)
2449 password instead of releasing it.
2450 The password will now not be remembered if it is asked via the protected
2451 password dialog, as per the UI spec.
2453 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2455 * src/modest-defs.h:
2456 * src/modest-account-mgr-helpers.h:
2457 * src/modest-account-mgr-helpers.c:
2458 Added modest_server_account_get_username_has_succeeded(),
2459 modest_server_account_set_username_has_succeeded().
2460 (modest_server_account_set_username),
2461 Reset the has-succeeded flag if the username changes.
2463 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2464 * src/maemo/modest-connection-specific-smtp-window.c:
2465 (modest_connection_specific_smtp_window_save_server_accounts):
2466 Use modest_server_account_set_username() instead of using
2467 modest_conf_set_string() directly, so that the has-succeeded flag is always
2470 * src/modest-ui-actions.c:
2471 (modest_ui_actions_on_password_requested): Dim the username entry if
2472 the username has ever worked, as per the UI spec.
2474 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2476 * src/modest-tny-account-store.c: (get_password):
2477 * src/modest-ui-actions.c:
2478 (modest_ui_actions_on_password_requested):
2479 Allow the username to be changed too, though there is more work to
2480 be done on exactly how this behaves.
2482 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-account-mgr-helpers.h:
2485 * src/modest-account-mgr-helpers.c:
2486 Added modest_account_mgr_get_display_name(),
2487 modest_server_account_get_username(),
2488 modest_server_account_set_username(),
2489 modest_server_account_set_password(),
2490 modest_server_account_get_hostname() functions so we do not need to
2491 use the conf API directly.
2493 * src/maemo/modest-main-window.c: (connect_signals):
2494 Actually connect ot the ModestAccountStore::request-password signal,
2495 so that we show the dialog when the password is requested by Tinymail,
2496 for isntance if it is empty.
2498 * src/modest-marshal.list:
2499 * src/modest-tny-account-store.c:
2500 (modest_tny_account_store_class_init), (get_password),
2501 (modest_tny_account_store_alert):
2502 * src/modest-tny-account-store.h:
2503 * src/modest-ui-actions.h:
2504 * src/modest-ui-actions.c:
2505 (modest_ui_actions_on_password_requested):
2506 Change the signal parameters, so it is obvious that we are providing
2507 the non human-readable server name, and receiving both the username
2508 and password, though changing of the username is not yet implemented.
2509 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2510 for the GNOME version.
2512 This should fix the projects.maemo.org bug NB#56209, though it does not
2513 work on Bora, because the gconf_client_get() for the password fails
2514 immediately after we save it with gconf_client_set().
2516 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2519 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2520 caused an undefined symbol error:
2521 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2523 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2525 * src/modest-tny-account-store.c:
2526 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2527 using a GError instead of a string message, so we can translate it in
2530 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2532 * src/maemo/modest-address-book.c:
2533 (modest_address_book_check_names):
2534 * src/maemo/modest-msg-view-window.c:
2535 (modest_msg_view_window_clipboard_owner_change):
2536 * src/modest-init.c: (modest_init_init_ui):
2537 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2538 (update_folders_cb), (modest_mail_operation_update_account):
2539 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2540 (modest_ui_actions_on_msg_attachment_clicked),
2541 (modest_ui_actions_on_msg_recpt_activated):
2542 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2543 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2544 (modest_msg_view_search_next):
2545 * src/widgets/modest-recpt-editor.c:
2546 (modest_recpt_editor_on_button_release_event),
2547 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2548 g_message(). At this point we should only be seeing interesting errors on
2549 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2551 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2553 (modest_wizard_dialog_force_title_update):
2554 * src/maemo/easysetup/modest-wizard-dialog.h:
2555 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2556 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2557 can update the title when appropriate. Otherwise the title is wrong if the
2558 pages are added after adding the notebook to the dialog.
2559 This must be a problem in HildonWizardDialog too.
2560 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2562 * src/maemo/easysetup/modest-easysetup-wizard.c:
2563 (create_subsequent_customsetup_pages),
2564 (create_subsequent_easysetup_pages):
2565 Call modest_wizard_dialog_force_title_update() so that the title is
2566 correct even with GTK+ < 2.10.
2567 This fixes projects.maemo.org bug NB#56145 .
2569 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2571 * src/maemo/modest-platform.c:
2572 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2573 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2576 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2578 * src/widgets/modest-window.h:
2579 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2580 and modest_window_save_state(), which invokes it.
2582 * src/widgets/modest-window-mgr.h:
2583 * src/widgets/modest-window-mgr.c:
2584 Added modest_window_mgr_save_state_for_all_windows(), which calls
2585 the save_state vfunc on all registered windows, if implemented.
2587 * src/gnome/modest-msg-edit-window.c:
2588 * src/gnome/modest-msg-view-window.c:
2589 * src/maemo/modest-msg-edit-window.c:
2590 * src/maemo/modest-msg-view-window.c:
2591 * src/maemo/modest-main-window.c:
2592 Specify the existing save_settings functions as implementations of
2593 ModestWindow::save_state_func().
2595 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2596 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2597 enabling hibernation, for instance.
2599 We may need to do the same thing for restoring settings.
2602 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2604 * src/widgets/modest-window-mgr.c:
2605 * src/widgets/modest-window-mgr.h:
2606 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2607 modest_window_mgr_get_hibernation_is_prevented().
2609 * src/maemo/modest-main-window.c:
2610 (on_hildon_program_is_topmost_notify): Prevent hibernation
2611 (possible when the application goes to the background in the WM),
2612 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2614 * src/maemo/easysetup/modest-easysetup-wizard.c:
2615 (modest_easysetup_wizard_dialog_init):
2616 * src/maemo/modest-account-settings-dialog.c:
2617 (modest_account_settings_dialog_init):
2618 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2619 (modest_connection_specific_smtp_edit_window_init):
2620 * src/maemo/modest-connection-specific-smtp-window.c:
2621 (modest_connection_specific_smtp_window_init):
2622 * src/maemo/modest-signature-editor-dialog.c:
2623 (modest_signature_editor_dialog_init):
2624 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2625 prevent hibernation while any of these account settings dialogs are open.
2627 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2629 * src/maemo/Makefile.am:
2630 * src/maemo/modest-osso-state-saving.c:
2631 * src/maemo/modest-osso-state-saving.h: Added
2632 modest_osso_load_state() and modest_osso_save_state() though they do
2633 nothing now. They should iterate through all the open windows and load/save
2635 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2636 save state when closing.
2638 * src/maemo/modest-main-window.c:
2639 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2640 Add a notification handler for the HildonProgram::is-topmost property,
2641 so we can allow hibernation when the application goes into the background.
2642 But we still need to detect when the accounts setup windows are open so
2643 we can stop hibernation when they are open.
2644 To do this, I also added the main window the HildonProgram. This might have
2645 other side-effects/benefits, and should maybe be done for other windows.
2647 * src/maemo/modest-osso-autosave-callbacks.h:
2648 * src/maemo/modest-osso-autosave-callbacks.c:
2649 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2650 though it does not do anything yet, and we might never need this to do
2651 anything. For instance, we already save drafts.
2653 * src/maemo/modest-platform.c: (modest_platform_init):
2654 Specify the libosso auto-save callback.
2656 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2658 * src/maemo/modest-platform.c:
2659 (modest_platform_set_update_interval):
2660 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2661 aparently stays valid between application instances, so we can use this
2662 to remove and reset it later. According to a maemo-developers email from
2665 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2667 * configure.ac: Depend on libalarm for Maemo.
2669 * src/dbus_api/modest-dbus-api.h:
2670 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2671 (on_send_receive), (modest_dbus_req_handler):
2672 Handle a SEND_RECEIVE D-Bus method.
2674 * libmodest-dbus-client/libmodest-dbus-client.c:
2675 (libmodest_dbus_client_send_and_receive):
2676 * libmodest-dbus-client/libmodest-dbus-client.h:
2677 Add C convenience functions for calling the new D-Bus method.
2679 * src/modest-platform.h:
2680 * src/gnome/modest-platform.c:
2681 * src/maemo/modest-platform.c:
2682 Added modest_platform_set_update_interval(), which uses the
2683 alarmd API on Maemo.
2684 (modest_platform_init),
2685 Call modest_platform_set_update_interval(), using a hard-coded
2686 interval for now (until the global settings dialog is implemented),
2687 though I am not sure that this makes sense yet.
2689 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2691 * src/dbus_api/modest-dbus-callbacks.c:
2692 (modest_osso_cb_hw_state_handler):
2693 * src/dbus_api/modest-dbus-callbacks.h:
2694 * src/maemo/modest-platform.c: (modest_platform_init):
2695 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2696 in case this has some effect on the ability for Maemo to ping the
2699 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2701 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2702 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2703 warning. It is probably a logic error, but I need to fix the build.
2705 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2707 * src/modest-account-mgr.h:
2708 * src/modest-account-mgr.c:
2709 (modest_account_mgr_account_names): Add a gboolean enabled_only
2710 parameter, so we can get lists of onlt the enabled accounts.
2712 (modest_account_mgr_add_account),,
2713 (modest_account_mgr_account_with_display_name_exists):
2714 * src/maemo/modest-msg-edit-window.c: (get_transports):
2715 * src/modest-account-mgr-helpers.c:
2716 (modest_account_mgr_set_first_account_as_default):
2717 * src/modest-init.c: (init_default_account_maybe):
2718 * src/modest-tny-account-store.c: (get_accounts):
2719 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2720 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2721 * tests/check_account-mgr.c: (START_TEST):
2722 Provide the extra parameter, as appropriate.
2724 * src/widgets/modest-account-view.c: (update_account_view):
2725 Do not show disabled accounts (meaning that there is no way to
2726 enable/disable accounts in the UI (the feature is not in our UI
2727 specification), so we can use this internally only to mark unfinished
2728 or temporary account data.
2730 * src/maemo/easysetup/modest-easysetup-wizard.c:
2731 (create_account): Add boolean enable parameter, so we can specify FALSE
2732 to create the temporary account.
2733 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2734 (on_before_next): When finishing, when there is a temporary account, just
2736 Also, use a timeout to delay the showing of the dialog until gconf is likely
2737 to return correct information, due to a maemo gconf bug that is fixed in
2738 osso 1.1, but not yet in Bora.
2739 However, the dialog stays on screen after it is destroyed.
2741 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2742 for invalid data when cancelling. Use a hildon note instead of a dialog
2743 to complain about invalid data. Do not show the account-saved note if the
2744 account is disabled (a temporary account that will not really be saved for use
2747 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2749 * src/modest-account-mgr-helpers.h:
2750 * src/modest-account-mgr-helpers.c:
2751 Added modest_account_mgr_unset_default_account(),
2752 Added modest_account_mgr_set_first_account_as_default().
2754 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2755 If it was the default account, unset the default account name.
2757 * src/maemo/modest-account-view-window.c:
2758 (on_delete_button_clicked): If it was the default account,
2759 set the first remaining account as the default instead.
2761 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2762 a NULL account or a NULL default account, to prevent a crash. This should
2763 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2766 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2768 * src/widgets/modest-recpt-editor.c:
2769 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2770 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2771 TODO comment for this. This fixes the build.
2773 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2774 be the best place for it. This will in future update all auto-update accounts,
2775 rather than just the current/default account, when that gconf key exists.
2776 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2777 if there are no accounts, before calling do_send_receive().
2778 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2780 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2781 * src/maemo/modest-main-window-ui.h:
2782 * src/maemo/modest-main-window.c: (on_connection_changed),
2783 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2784 directly, becaue the signal handler does more.
2786 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2788 * src/modest-account-mgr-helpers.c:
2789 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2790 for the case that the account does not exist.
2792 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2793 (equivalent to the modest account name) rather than the tinymail account name
2794 (equivalent to the modest account title - human readable) to get the account data.
2795 Check for null account data to prevent the crash, and add a TODO comment saying that
2796 this needs fixing because it is using the server account name instead of the account name.
2798 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2800 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2801 * src/maemo/modest-account-settings-dialog.c: (show_error),
2803 Use hildon_note_new_information() for informative and error messages,
2804 which seems to be expected for Maemo applications (no documentation that I know of
2805 says this). I am surprised that there is no distinction between info and error
2808 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2810 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2811 it is easy to find where this is used.
2813 * src/maemo/easysetup/modest-easysetup-wizard.c:
2814 (create_page_welcome), (create_page_account_details),
2815 (create_page_user_details), (create_page_complete_easysetup),
2816 (create_page_custom_incoming), (create_page_custom_outgoing),
2817 (create_page_complete_custom):
2818 * src/maemo/modest-account-settings-dialog.c:
2819 (create_page_account_details), (create_page_user_details),
2820 (create_page_incoming), (create_page_outgoing):
2821 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2822 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2823 (modest_connection_specific_smtp_edit_window_init):
2824 * src/maemo/modest-connection-specific-smtp-window.c:
2825 (modest_connection_specific_smtp_window_init):
2826 * src/maemo/modest-signature-editor-dialog.c:
2827 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2828 and scrolling policy as per the Email Application Layout Guide, if I have
2831 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2833 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2834 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2835 which were empty, because these vfuncs have been removed from TnyAccountStore.
2836 This fixes the build.
2838 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2840 * src/maemo/modest-main-window.c:
2841 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2842 showing/hiding it. Added TODO because it probably should not be NULL.
2843 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2844 because unnecessary g_warnings() make degugging difficult.
2846 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2848 * src/maemo/modest-msg-edit-window.c:
2849 (modest_msg_edit_window_select_color),
2850 (modest_msg_edit_window_select_background_color): 2 const corrections and
2851 moving 2 #endifs before closing brackets, to fix the build.
2853 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2855 * src/maemo/easysetup/modest-easysetup-wizard.h:
2856 * src/maemo/easysetup/modest-easysetup-wizard.c:
2857 (modest_easysetup_wizard_dialog_finalize),
2858 (on_button_edit_advanced_settings), (create_page_complete_custom),
2859 (on_response), (create_account):
2860 Implement the Advanced Settings edit button, by saving the account information,
2861 for the Advanded Settings dialog to use directly from gconf, and removing it
2862 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2863 Bug #5533 in the projects.maemo.org bugzilla.
2865 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2867 * src/maemo/modest-msg-view-window.c:
2868 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2869 when opening a message window.
2871 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2873 * src/maemo/easysetup/modest-easysetup-wizard.c:
2874 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2877 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2878 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2879 gconf settings. I probably added more checks than necessary, but that is safer.
2881 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2882 variable to fix the build, but this seems to be used when it is still NULL.
2884 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2886 * src/modest-platform.h:
2887 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2888 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2889 * src/modest-main.c: Implement this function so we can avoid using
2890 maemo-specific API from cross-platform code.
2892 * src/modest-tny-account-store.c:
2893 (get_smtp_specific_transport_account_for_open_connection):
2894 * src/modest-ui-actions.c: (check_for_connection),
2895 (modest_ui_actions_on_item_not_found):
2896 Use modest_platform_connect_and_wait() and put #idefs around other
2897 maemo-specific code, because only maemo currently has a way to
2898 identify connection names.
2900 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2902 * src/modest-tny-account-store.h:
2903 * src/modest-tny-account-store.c:
2904 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2905 the connection-specific SMTP server settings in the configuration.
2907 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2909 * src/maemo/modest-main-window.c: (on_connection_changed),
2911 * src/modest-main.c: (main), (start_ui), (send_mail):
2912 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2913 that is what is intended.
2915 * src/modest-ui-actions.c: (action_send), (action_receive),
2916 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2917 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2918 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2919 SMTP server is used when it is specified.
2921 (modest_ui_actions_on_send_receive):
2922 Check that a connection is open before proceeding.
2923 Receive and then send, instead of vice-versa, as per the specification.
2925 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2927 * src/modest-mail-operation.c:
2928 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2929 though I guess it should be something other than NULL.
2931 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2933 * src/maemo/easysetup/modest-easysetup-wizard.c:
2934 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2935 combo twice, to avoid an g_warning and to make it visible again.
2936 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2937 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2938 (already intended) dereference when detaching, because we then recreate the menu.
2939 But I am not sure why the warning was happening, and it is possible that this is a memory
2942 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2944 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2945 and uri_parse_mailto() utility functions.
2946 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2948 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2950 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2952 * src/dbus_api/modest-dbus-api.h:
2953 * src/dbus_api/modest-dbus-callbacks.c:
2954 Use an idle callback to execute the modest code in the application's own thread.
2955 Remove the helloworld example method.
2956 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2957 parsed, and the open-message method is not implemented because this is not yet implemented in
2959 * libmodest-dbus-client/libmodest-dbus-client.c:
2960 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2961 (libmodest_dbus_client_open_message):
2962 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2964 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2965 body without crashing.
2967 * tests/dbus_api/Makefile.am:
2968 * tests/dbus_api/test_mail_to.c:
2969 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2971 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2973 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2974 Added file to fix the build. Sorry.
2976 * src/dbus_api/Makefile.am:
2977 * src/dbus_api/modest-dbus-api.h:
2978 * src/dbus_api/modest-dbus-callbacks.h:
2979 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2980 (modest_dbus_req_handler):
2981 Put constants in a separate header so it can be reused by the
2982 client library, without duplication
2984 * libmodest-dbus-client/Makefile.am:
2985 * libmodest-dbus-client/libmodest-dbus-client.c:
2986 (libmodest_dbus_client_call_helloworld),
2987 (libmodfest_dbus_client_send_mail),
2988 (libmodfest_dbus_client_mailto),
2989 (libmodfest_dbus_client_open_message):
2990 * libmodest-dbus-client/libmodest-dbus-client.h:
2991 (Partly) Implement a send_mail D-Bus method.
2993 * tests/dbus_api/Makefile.am:
2994 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2995 the send_email D-Bus method.
2997 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3001 * libmodest-dbus-client/Makefile.am:
3002 * libmodest-dbus-client/libmodest-dbus-client.c:
3003 * libmodest-dbus-client/libmodest-dbus-client.h:
3004 * tests/dbus_api/Makefile.am:
3005 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3006 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3008 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3010 * src/maemo/easysetup/modest-easysetup-wizard.c:
3011 (create_page_account_details):
3012 * src/maemo/modest-account-settings-dialog.c:
3013 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3014 widgets, because this might not be the default in future versions of the Maemo GTK+.
3015 However, I can not not get capitalization to work even in a simple test case.
3017 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3019 * src/maemo/easysetup/modest-easysetup-wizard.c:
3020 (create_page_custom_incoming), (create_page_custom_outgoing):
3021 * src/maemo/modest-account-settings-dialog.c:
3022 (create_page_account_details), (create_page_incoming),
3023 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3024 instead of using gtk_check_button_with_label(), so they are aligned like the other
3025 widgets, as per the UI spec.
3027 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3029 * src/maemo/easysetup/modest-easysetup-wizard.c:
3030 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3031 * src/widgets/modest-validating-entry.c:
3032 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3033 Modest prefix instead of an EasySetup prefix.
3035 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3037 * src/widgets/modest-validating-entry.h:
3038 * src/widgets/modest-validating-entry.c: (on_insert_text),
3039 Added easysetup_validating_entry_set_max_func(), used to set a callback
3040 to call when the max number of characters is reached. GtkEntry has a max-length
3041 already but is silent about it.
3043 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3044 (create_page_account_details), (create_page_user_details),
3046 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3047 (create_page_account_details), (create_page_user_details),
3048 (create_page_outgoing):
3049 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3050 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3051 the UI spec, when the user tries to enter more than the max number of characters.
3053 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3055 * src/maemo/easysetup/modest-easysetup-wizard.c:
3056 (create_page_user_details), (create_page_custom_incoming),
3057 (create_page_custom_outgoing):
3058 * src/maemo/modest-account-settings-dialog.c:
3059 (create_page_user_details), (create_page_incoming),
3060 (create_page_outgoing):
3061 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3062 (modest_connection_specific_smtp_edit_window_init):
3063 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3064 not appropriate. Bad Maemo-specific defaults!.
3066 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3068 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3069 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3070 (modest_signature_editor_dialog_set_settings):
3071 Disable the label and textview when the checkbox is disabled, and use the
3072 specified (UI spec) default signature text.
3074 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3076 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3077 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3079 * src/modest-defs.h:
3080 * src/modest-account-mgr-helpers.h:
3081 * src/modest-account-mgr-helpers.c:
3082 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3084 * src/maemo/Makefile.am:
3085 * src/maemo/modest-signature-editor-dialog.c:
3086 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3089 * src/maemo/modest-account-settings-dialog.h:
3090 * src/maemo/modest-account-settings-dialog.c:
3091 (modest_account_settings_dialog_finalize), (on_button_signature),
3092 (save_configuration): Use the new dialog when the Edit button is pressed, and
3093 save the changes if necessary, as per the UI spec.
3095 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3097 * src/maemo/Makefile.am:
3098 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3099 based on maemo-develoers email from Dirk.
3101 * src/maemo/easysetup/modest-easysetup-wizard.c:
3102 (create_page_welcome), (create_page_account_details),
3103 (create_page_user_details), (create_page_complete_easysetup),
3104 (create_page_custom_incoming), (create_page_custom_outgoing),
3105 (create_page_complete_custom),
3106 (modest_easysetup_wizard_dialog_init):
3107 * src/maemo/modest-account-settings-dialog.c:
3108 (create_page_account_details), (create_page_user_details),
3109 (create_page_incoming), (create_page_outgoing),
3110 (modest_account_settings_dialog_init):
3111 * src/maemo/modest-connection-specific-smtp-window.c:
3112 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3114 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3116 * src/maemo/easysetup/modest-easysetup-wizard.c:
3117 (create_page_account_details), (create_page_custom_outgoing),
3118 (create_page_complete_custom):
3119 * src/maemo/modest-account-settings-dialog.c:
3120 (create_page_user_details), (create_page_incoming),
3121 (create_page_outgoing):
3122 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3123 (modest_connection_specific_smtp_edit_window_init):
3124 Use the correct (UI spec) port min/max, and use horizontal separators,
3127 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3129 * src/maemo/easysetup/modest-easysetup-wizard.c:
3130 (set_default_custom_servernames):
3131 * src/maemo/modest-account-settings-dialog.c:
3132 (create_page_incoming), (on_combo_outgoing_security_changed),
3133 (on_combo_incoming_security_changed), (create_page_outgoing),
3134 (modest_account_settings_dialog_set_account_name),
3135 (save_configuration):
3136 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3137 (on_combo_security_changed),
3138 (modest_connection_specific_smtp_edit_window_init),
3139 (modest_connection_specific_smtp_edit_window_set_connection),
3140 (modest_connection_specific_smtp_edit_window_get_settings):
3141 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3144 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3147 * src/maemo/easysetup/modest-easysetup-wizard.c:
3148 (create_page_custom_outgoing), (create_page_complete_custom):
3149 * src/maemo/modest-account-settings-dialog.c:
3150 (create_page_user_details), (create_page_outgoing):
3151 * src/maemo/modest-account-view-window.c: (button_box_new):
3152 Use changed logical IDs as per the most recent UI spec:
3153 mcen_bd_emailsetup_edit -> mcen_bd_edit
3154 mcen_bd_emailsetup_delete -> mcen_bd_delete
3155 mcen_bd_emailsetup_close -> mcen_bd_close
3157 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3161 * src/dbus_api/Makefile.am:
3162 * src/dbus_api/modest-dbus-callbacks.c:
3163 * src/dbus_api/modest-dbus-callbacks.h:
3164 * src/maemo/modest-platform.c: (modest_platform_init):
3165 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3167 * tests/Makefile.am:
3168 * tests/dbus_api/Makefile.am:
3169 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3171 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3173 * src/maemo/modest-account-settings-dialog.c:
3174 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3175 Removed unnecessary includes.
3177 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3179 * src/maemo/easysetup/modest-easysetup-wizard.c:
3180 * src/maemo/modest-account-settings-dialog.c:
3181 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3182 * src/widgets/Makefile.am:
3183 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3184 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3185 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3186 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3187 * src/widgets/modest-secureauth-combo-box.c:
3188 * src/widgets/modest-secureauth-combo-box.h:
3189 * src/widgets/modest-serversecurity-combo-box.c:
3190 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3191 made the GObject names more consistent with the rest of the Modest code.
3193 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/easysetup/Makefile.am:
3196 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3197 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3198 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3199 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3200 * src/maemo/easysetup/modest-easysetup-wizard.c:
3201 * src/maemo/easysetup/modest-validating-entry.c:
3202 * src/maemo/easysetup/modest-validating-entry.h:
3203 * src/maemo/modest-account-settings-dialog.c:
3204 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3205 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3206 widgets/ because they are used outside of easysetup too. After checking in,
3207 svn will allow me to rename them too.
3209 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3211 * src/gnome/modest-msg-edit-window.c:
3212 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3213 linker error, to fix the build on the GNOME platform.
3214 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3215 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3216 ifdefed out to avoid a warning.
3218 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3220 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3221 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3222 some alternative for GTK+ 2.6.
3224 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3226 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3228 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3229 specified for EmailAccountsDialog in UI spec.
3231 * src/maemo/easysetup/modest-easysetup-wizard.c:
3232 * src/maemo/easysetup/modest-easysetup-wizard.h:
3233 * src/maemo/modest-account-settings-dialog.c:
3234 * src/maemo/modest-account-settings-dialog.h:
3235 Reuse a member window widget for the connection-specific SMTP server accounts,
3236 so we can tell it to create/save the accounts only if we actually save changes.
3238 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3239 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3240 (modest_connection_specific_smtp_edit_window_get_settings):
3241 Return a struct instance for temporarily remembering the entered data.
3243 * src/maemo/modest-connection-specific-smtp-window.h:
3244 * src/maemo/modest-connection-specific-smtp-window.c:
3245 (modest_connection_specific_smtp_window_finalize),
3246 (modest_connection_specific_smtp_window_fill_with_connections),
3248 (modest_connection_specific_smtp_window_save_server_accounts),
3249 (update_model_server_names): Do not actually save data until asked,
3250 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3252 (on_selection_changed),
3253 (modest_connection_specific_smtp_window_init): Disable the edit
3254 button when nothing is selected.
3256 * src/modest-account-mgr-helpers.c:
3257 * src/modest-account-mgr-helpers.h:
3258 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3261 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3263 * src/modest-account-mgr-helpers.h:
3264 * src/modest-account-mgr-helpers.c:
3265 (modest_account_mgr_get_unused_account_name),
3266 (modest_account_mgr_get_unused_account_display_name): Added these
3267 utility functions, to avoid code duplication.
3269 * src/maemo/easysetup/modest-easysetup-wizard.c:
3270 (create_page_account_details), (create_account):
3271 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3272 (on_combo_security_changed),
3273 (modest_connection_specific_smtp_edit_window_init),
3274 (modest_connection_specific_smtp_edit_window_save_settings):
3275 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3276 * src/maemo/modest-connection-specific-smtp-window.c:
3277 (modest_connection_specific_smtp_window_finalize),
3278 (modest_connection_specific_smtp_window_fill_with_connections),
3279 (on_button_edit), (modest_connection_specific_smtp_window_init):
3280 * src/maemo/modest-connection-specific-smtp-window.h:
3281 Implementing saving of connection-specific server accounts.
3283 But I need to refactor this so we can save the data for each
3284 possible connection-specific account and only actually create the server accounts
3285 when the easysetup finished, or the OK button is pressed on the account settings
3288 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3290 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3291 (on_combo_security_changed):
3292 (modest_connection_specific_smtp_edit_window_init):
3293 Auto-fill the port number as in the account settings.
3295 (modest_connection_specific_smtp_edit_window_set_connection):
3296 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3297 * src/maemo/modest-connection-specific-smtp-window.c:
3298 (fill_with_connections), (on_button_edit),
3299 (modest_connection_specific_smtp_window_init):
3300 Turn the edit window into a dialog to simplify the code, and
3301 set a WM hint as in a GtkDialog, because only a popup can be on top of
3302 another window in Maemo, and popups usually have no WM decoration.
3304 * src/modest-defs.h:
3305 * src/modest-account-mgr-helpers.c:
3306 (modest_account_mgr_set_connection_specific_smtp),
3307 (modest_account_mgr_remove_connection_specific_smtp),
3308 (modest_account_mgr_get_connection_specific_smtp):
3309 * src/modest-account-mgr-helpers.h: Some functions to write the
3310 connection-specific SMTP server information. Not yet used.
3313 * src/widgets/modest-folder-view.c: (text_cell_data):
3314 Fix a warning about an uninitialized variable.
3315 (on_configuration_key_changed): Put an #ifdef around the use
3316 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3318 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3320 * src/maemo/modest-account-settings-dialog.h:
3321 * src/maemo/modest-account-settings-dialog.c:
3322 Added connect_for_modified() utility function to mark the new modified boolean.
3324 (create_page_account_details), (create_page_user_details),
3325 (create_page_incoming), (create_page_outgoing), (on_response),
3326 (modest_account_settings_dialog_init),
3327 (modest_account_settings_dialog_set_account_name):
3328 Only warn about unsaved changes when there are actually unsaved changes.
3330 * src/modest-account-mgr-helpers.c:
3331 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3332 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3333 to get the data from there in future.
3335 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3337 * src/modest-defs.h:
3339 * src/modest-account-mgr-helpers.h:
3340 * src/modest-account-mgr-helpers.c:
3341 Store the security account setting in a single conf key instead of using
3342 the options list, so that the list is left for just the to-be-removed camel hack,
3343 and because gconf_client_set_list() is failing for some reason.
3345 * src/modest-account-mgr.c:
3346 (modest_account_mgr_add_server_account):
3347 * src/maemo/modest-account-settings-dialog.c:
3348 (modest_account_settings_dialog_set_account_name),
3349 (save_configuration): Use the renamed functions.
3352 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3354 * src/widgets/Makefile.am:
3355 * src/widgets/modest-limit-retrieve-combo-box.c:
3356 * src/widgets/modest-limit-retrieve-combo-box.h:
3357 * src/widgets/modest-retrieve-combo-box.c:
3358 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3359 the account settings dialog.
3361 * src/modest-defs.h:
3362 * src/modest-account-mgr-helpers.h:
3363 * src/modest-account-mgr-helpers.c:
3364 (modest_server_account_get_option_secure_auth),
3365 (modest_server_account_set_option_secure_auth):
3366 * src/modest-account-mgr.c:
3367 (modest_account_mgr_add_server_account):
3368 Use the existing AUTH_MECH conf key for the secure-auth setting,
3369 instead of putting it in the list options, because this was actually used already.
3371 * src/maemo/modest-account-settings-dialog.c:
3372 (create_page_account_details),
3373 (modest_account_settings_dialog_set_account_name),
3374 (save_configuration):
3375 * src/maemo/modest-account-settings-dialog.h:
3376 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3377 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3379 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3381 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3382 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3383 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3385 * src/modest-defs.h:
3386 * src/maemo/modest-account-settings-dialog.c:
3387 (create_page_incoming), (on_combo_outgoing_security_changed),
3388 (on_combo_incoming_security_changed), (create_page_outgoing),
3389 (modest_account_settings_dialog_set_account_name),
3390 (save_configuration): Load/Save the port number, and change it when the
3391 security combo changes, to suitable defaults.
3393 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3395 * src/modest-account-mgr.c:
3396 (modest_account_mgr_add_server_account): Set the security and secure-auth
3397 options, and add a comment saying that the other camel-specific options should be
3400 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3402 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3404 * src/modest-tny-account-store.c: (account_list_free),
3405 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3406 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3409 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3411 * src/modest-protocol-info.c:
3412 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3413 is required by our UI spec. Maybe something in our implementation will use this eventually.
3414 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3415 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3416 instead of the previous 0 placeholder.
3418 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3419 secure-auth settings.
3420 * src/modest-account-mgr-helpers.h:
3421 * src/modest-account-mgr-helpers.c:
3422 (modest_server_account_data_get_option_secure_auth),
3423 (modest_server_account_set_option_secure_auth),
3424 (modest_server_account_data_get_option_security),
3425 (modest_server_account_set_option_security): Added this API for getting and setting the security
3426 and secure-auth settings.
3428 * src/maemo/modest-account-settings-dialog.h:
3429 * src/maemo/modest-account-settings-dialog.c:
3430 (modest_account_settings_dialog_finalize), (check_data),
3431 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3432 about changing titles.
3433 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3434 (save_configuration): Save the security and secure-auth settings.
3436 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3437 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3439 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3441 * src/modest-defs.h:
3442 * src/modest-account-mgr.c:
3443 (modest_account_mgr_add_server_account):
3444 Added and used defines for the options key and value pair strings,
3445 that are used so far, though they do not seem to correspond to anything in our
3446 UI specs or ModestProtocol enum.
3448 * src/modest-account-mgr-helpers.h:
3449 * src/modest-account-mgr-helpers.c:
3450 (compare_option_strings_for_name),
3451 (modest_server_account_data_get_option_value),
3452 (modest_server_account_data_get_option_bool),
3453 (modest_account_mgr_get_server_account_option):
3454 Added helper functions for parsing the options GSList.
3456 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3458 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3459 display name is based on the supplied account name.
3460 * src/modest-account-mgr.c:
3461 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3462 with an inefficient, but good-enough, implementation.
3464 * src/maemo/easysetup/modest-easysetup-wizard.c:
3465 (create_page_account_details), (on_before_next), (create_account):
3466 Check for existing display names rather than (non-user-visible) account names, and just
3467 create and set a unique account name at the end.
3469 * src/maemo/modest-account-settings-dialog.c:
3470 (modest_account_settings_dialog_init),
3471 (modest_account_settings_dialog_set_account_name),
3472 (create_page_incoming): Show the display name, instead of the account name.
3473 (on_response): Do some (not all) extra checks, as in the UI spec.
3474 (save_configuration): Save the display name if it was changed.
3476 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3478 * po/en_GB.po: Added needed logical ID and translation.
3479 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3480 (init_view): Made the is-default column clicking work.
3482 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3485 * src/maemo/easysetup/Makefile.am:
3486 * src/maemo/easysetup/modest-easysetup-wizard.c:
3487 (modest_easysetup_wizard_dialog_init):
3488 * src/maemo/easysetup/provider-data-test.keyfile:
3489 * src/maemo/easysetup/provider-data.keyfile:
3490 Moved the provider data file to the new modest-providers-data package and used it from there.
3492 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3494 * src/modest-local-folder-info.c:
3495 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3496 N_() was already used on the static strings, but this just marks it for translation without
3497 using the translation.
3499 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3501 * src/maemo/modest-account-settings-dialog.c:
3502 (create_page_incoming),
3503 (modest_account_settings_dialog_set_account_name):
3504 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3505 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3506 I will do this if nobody else gets there first.
3508 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3510 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3511 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3512 save the security stuff.
3514 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3516 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3517 Set the email address and user fullname, which I now see must be
3520 * src/maemo/modest-account-settings-dialog.h:
3521 * src/maemo/modest-account-settings-dialog.c:
3523 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3524 leave-on-server and authentication.
3525 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3528 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3531 * src/maemo/modest-account-settings-dialog.c:
3532 * src/maemo/modest-account-settings-dialog.h:
3533 Most (but not all) of the widgets are now present as specified by the UI spec.
3534 No changes are yet saved, and some details are not properly shown yet.
3536 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3538 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3540 * src/maemo/Makefile.am:
3541 * src/maemo/modest-account-settings-dialog.c:
3542 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3543 an existing account. Doesn't do much yet.
3545 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3546 Open the accounts settings dialog when Edit is clicked.
3548 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3550 * src/maemo/easysetup/Makefile.am:
3551 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3553 * src/maemo/easysetup/modest-easysetup-wizard.c:
3554 (modest_easysetup_wizard_dialog_init):
3555 Try to get the source directory from the build system,
3556 instead of hard-coding "./" into the source code, when opening our local
3557 copies of the configuration files.
3558 But this still fails when opening the wizard from the Accounts window,
3559 maybe because the working directory seems to change at runtime.
3560 So the wizard will fail the second time unless you copy the files into their
3561 proper locations - see the stdout warnings for the paths.
3563 (create_page_account_details),(on_before_next):
3564 Check for existing non-server accounts instead of server accounts,
3565 so the default account name is useful again, and to prevent trying to
3568 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3569 Show the wizard when New is clicked.
3571 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3572 (init_view): Show the column headers, and show the columns that are
3573 specified in the UI specs. However, something in Maemo's GTK+ prevents
3574 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3575 change the default account. This is despite unsetting the special properties.
3577 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3579 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3580 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3581 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3582 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3583 to make that clearer.
3584 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3586 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3588 * src/maemo/modest-account-view-window.c:
3589 (modest_account_view_window_init),
3590 (modest_account_view_window_new):
3591 Use the same buttons as specified in the
3592 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3593 the existing widgets, which never had a chance of working.
3594 Put the ModestAccountView treeview in a scrolled window.
3595 Do not repeat the initialization in both _init() and _new().
3597 * src/widgets/modest-account-view.c: (update_account_view):
3598 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3599 this widget and window shows no accounts.
3601 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3603 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3605 * src/maemo/easysetup/modest-easysetup-wizard.c:
3606 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3607 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3608 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3611 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3612 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3613 accounts exist yet, as in the UI spec.
3615 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3617 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3619 * src/maemo/Makefile.am:
3620 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3621 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3622 New window for editing connection-specific smtp details.
3623 Not fully implemented.
3625 * src/maemo/modest-connection-specific-smtp-window.c:
3626 (modest_connection_specific_smtp_window_finalize) :
3627 unref the tree model.
3628 (on_button_edit): Show the edit window.
3630 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3632 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3635 * src/maemo/Makefile.am:
3636 * src/maemo/modest-connection-specific-smtp-window.c:
3637 * src/maemo/modest-connection-specific-smtp-window.h:
3638 New window for showing the list of connections, for connection-specific
3639 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3640 * src/maemo/easysetup/modest-easysetup-wizard.c:
3641 (create_page_custom_outgoing): Show the new window when the button is clicked.
3643 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3645 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3646 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3647 * src/maemo/modest-msg-edit-window.c:
3648 (modest_msg_edit_window_insert_image):
3649 * src/modest-conf.c: (modest_conf_key_escape):
3650 * src/modest-mail-operation.c:
3651 (modest_mail_operation_send_new_mail):
3652 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3653 (modest_ui_actions_on_new_account):
3654 * src/widgets/modest-attachment-view.c: (update_filename_request):
3655 * src/widgets/modest-mail-header-view.c:
3656 Corrected warnings that were breaking the build, by commenting out unused variables,
3657 and a function, and by including a header.
3659 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3661 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3662 so we can #ifdef around platform-specific code when necessary.
3663 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3664 to allow this to build for the GNOME platform too.
3666 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3668 * src/maemo/easysetup/modest-easysetup-wizard.c:
3669 Added util_increment_name() and used it in create_page_account_details()
3670 to make sure that the default account name is always a new name.
3672 (modest_easysetup_wizard_dialog_init),
3673 (set_default_custom_servernames): Some minor memory management fixes.
3675 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3679 * src/modest-runtime.c: (init_i18n): Restored the translation
3680 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3681 are defined in config.h, and the translations are installed.
3683 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3684 is defined for translation.
3686 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3688 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3690 * src/maemo/easysetup/modest-easysetup-wizard.c:
3691 (modest_easysetup_wizard_dialog_init):
3692 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3693 Use realistic paths (though they should use $prefix generically) to the
3694 mcc_mapping and provider-data.keyfile files which might work when they
3695 are installed by the future version of the operator-wizard package,
3696 and then fallback to paths in our source code, with an explanatory
3699 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3703 * src/maemo/Makefile.am:
3704 * src/maemo/easysetup/: Added files from the previously-exernal
3705 osso-modest-easysetup.
3706 * src/maemo/modest-main-window-ui.h:
3707 * src/modest-ui-actions.c:
3708 * src/modest-ui-actions.h:
3709 Added modest_ui_actions_on_new_account() as a signal handler for the
3710 New Account menu item. It shows the easysetup wizard.
3711 * po/en_GB.po: Added additional needed logical IDs and translations.