1 2007-04-18 Murray Cumming <murrayc@murrayc.com>
5 * src/modest-account-mgr-helpers.h:
6 * src/modest-account-mgr-helpers.c:
7 Store the security account setting in a single conf key instead of using
8 the options list, so that the list is left for just the to-be-removed camel hack,
9 and because gconf_client_set_list() is failing for some reason.
11 * src/modest-account-mgr.c:
12 (modest_account_mgr_add_server_account):
13 * src/maemo/modest-account-settings-dialog.c:
14 (modest_account_settings_dialog_set_account_name),
15 (save_configuration): Use the renamed functions.
18 2007-04-18 Murray Cumming <murrayc@murrayc.com>
20 * src/widgets/Makefile.am:
21 * src/widgets/modest-limit-retrieve-combo-box.c:
22 * src/widgets/modest-limit-retrieve-combo-box.h:
23 * src/widgets/modest-retrieve-combo-box.c:
24 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
25 the account settings dialog.
28 * src/modest-account-mgr-helpers.h:
29 * src/modest-account-mgr-helpers.c:
30 (modest_server_account_get_option_secure_auth),
31 (modest_server_account_set_option_secure_auth):
32 * src/modest-account-mgr.c:
33 (modest_account_mgr_add_server_account):
34 Use the existing AUTH_MECH conf key for the secure-auth setting,
35 instead of putting it in the list options, because this was actually used already.
37 * src/maemo/modest-account-settings-dialog.c:
38 (create_page_account_details),
39 (modest_account_settings_dialog_set_account_name),
41 * src/maemo/modest-account-settings-dialog.h:
42 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
43 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
45 2007-04-18 Murray Cumming <murrayc@murrayc.com>
47 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
48 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
49 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
52 * src/maemo/modest-account-settings-dialog.c:
53 (create_page_incoming), (on_combo_outgoing_security_changed),
54 (on_combo_incoming_security_changed), (create_page_outgoing),
55 (modest_account_settings_dialog_set_account_name),
56 (save_configuration): Load/Save the port number, and change it when the
57 security combo changes, to suitable defaults.
59 2007-04-17 Murray Cumming <murrayc@murrayc.com>
61 * src/modest-account-mgr.c:
62 (modest_account_mgr_add_server_account): Set the security and secure-auth
63 options, and add a comment saying that the other camel-specific options should be
66 2007-04-17 Murray Cumming <murrayc@murrayc.com>
68 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
70 * src/modest-tny-account-store.c: (account_list_free),
71 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
72 cursor->data after unreffing it. But there is some strange stuff there so it might not be
75 2007-04-17 Murray Cumming <murrayc@murrayc.com>
77 * src/modest-protocol-info.c:
78 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
79 is required by our UI spec. Maybe something in our implementation will use this eventually.
80 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
81 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
82 instead of the previous 0 placeholder.
84 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
86 * src/modest-account-mgr-helpers.h:
87 * src/modest-account-mgr-helpers.c:
88 (modest_server_account_data_get_option_secure_auth),
89 (modest_server_account_set_option_secure_auth),
90 (modest_server_account_data_get_option_security),
91 (modest_server_account_set_option_security): Added this API for getting and setting the security
92 and secure-auth settings.
94 * src/maemo/modest-account-settings-dialog.h:
95 * src/maemo/modest-account-settings-dialog.c:
96 (modest_account_settings_dialog_finalize), (check_data),
97 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
98 about changing titles.
99 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
100 (save_configuration): Save the security and secure-auth settings.
102 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
103 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
105 2007-04-17 Murray Cumming <murrayc@murrayc.com>
108 * src/modest-account-mgr.c:
109 (modest_account_mgr_add_server_account):
110 Added and used defines for the options key and value pair strings,
111 that are used so far, though they do not seem to correspond to anything in our
112 UI specs or ModestProtocol enum.
114 * src/modest-account-mgr-helpers.h:
115 * src/modest-account-mgr-helpers.c:
116 (compare_option_strings_for_name),
117 (modest_server_account_data_get_option_value),
118 (modest_server_account_data_get_option_bool),
119 (modest_account_mgr_get_server_account_option):
120 Added helper functions for parsing the options GSList.
122 2007-04-16 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
125 display name is based on the supplied account name.
126 * src/modest-account-mgr.c:
127 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
128 with an inefficient, but good-enough, implementation.
130 * src/maemo/easysetup/modest-easysetup-wizard.c:
131 (create_page_account_details), (on_before_next), (create_account):
132 Check for existing display names rather than (non-user-visible) account names, and just
133 create and set a unique account name at the end.
135 * src/maemo/modest-account-settings-dialog.c:
136 (modest_account_settings_dialog_init),
137 (modest_account_settings_dialog_set_account_name),
138 (create_page_incoming): Show the display name, instead of the account name.
139 (on_response): Do some (not all) extra checks, as in the UI spec.
140 (save_configuration): Save the display name if it was changed.
142 2007-04-16 Murray Cumming <murrayc@murrayc.com>
144 * po/en_GB.po: Added needed logical ID and translation.
145 * src/widgets/modest-account-view.c: (on_account_default_toggled),
146 (init_view): Made the is-default column clicking work.
148 2007-04-16 Murray Cumming <murrayc@murrayc.com>
151 * src/maemo/easysetup/Makefile.am:
152 * src/maemo/easysetup/modest-easysetup-wizard.c:
153 (modest_easysetup_wizard_dialog_init):
154 * src/maemo/easysetup/provider-data-test.keyfile:
155 * src/maemo/easysetup/provider-data.keyfile:
156 Moved the provider data file to the new modest-providers-data package and used it from there.
158 2007-04-16 Murray Cumming <murrayc@murrayc.com>
160 * src/modest-local-folder-info.c:
161 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
162 N_() was already used on the static strings, but this just marks it for translation without
163 using the translation.
165 2007-04-06 Murray Cumming <murrayc@murrayc.com>
167 * src/maemo/modest-account-settings-dialog.c:
168 (create_page_incoming),
169 (modest_account_settings_dialog_set_account_name):
170 Added comments about the need for new API in ModestAccountMgr to handle the authentication
171 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
172 I will do this if nobody else gets there first.
174 2007-04-06 Murray Cumming <murrayc@murrayc.com>
176 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
177 Saved much of the incoming and outgoing data too, though I cannot yet see how to
178 save the security stuff.
180 2007-04-06 Murray Cumming <murrayc@murrayc.com>
182 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
183 Set the email address and user fullname, which I now see must be
186 * src/maemo/modest-account-settings-dialog.h:
187 * src/maemo/modest-account-settings-dialog.c:
189 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
190 leave-on-server and authentication.
191 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
194 2007-04-06 Murray Cumming <murrayc@murrayc.com>
197 * src/maemo/modest-account-settings-dialog.c:
198 * src/maemo/modest-account-settings-dialog.h:
199 Most (but not all) of the widgets are now present as specified by the UI spec.
200 No changes are yet saved, and some details are not properly shown yet.
202 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
204 2007-04-06 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/Makefile.am:
207 * src/maemo/modest-account-settings-dialog.c:
208 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
209 an existing account. Doesn't do much yet.
211 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
212 Open the accounts settings dialog when Edit is clicked.
214 2007-04-05 Murray Cumming <murrayc@murrayc.com>
216 * src/maemo/easysetup/Makefile.am:
217 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
219 * src/maemo/easysetup/modest-easysetup-wizard.c:
220 (modest_easysetup_wizard_dialog_init):
221 Try to get the source directory from the build system,
222 instead of hard-coding "./" into the source code, when opening our local
223 copies of the configuration files.
224 But this still fails when opening the wizard from the Accounts window,
225 maybe because the working directory seems to change at runtime.
226 So the wizard will fail the second time unless you copy the files into their
227 proper locations - see the stdout warnings for the paths.
229 (create_page_account_details),(on_before_next):
230 Check for existing non-server accounts instead of server accounts,
231 so the default account name is useful again, and to prevent trying to
234 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
235 Show the wizard when New is clicked.
237 * src/widgets/modest-account-view.c: (on_account_default_toggled),
238 (init_view): Show the column headers, and show the columns that are
239 specified in the UI specs. However, something in Maemo's GTK+ prevents
240 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
241 change the default account. This is despite unsetting the special properties.
243 2007-04-05 Murray Cumming <murrayc@murrayc.com>
245 * docs/reference/modest-design.sgml: Corrected spelling mistake.
246 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
247 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
248 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
249 to make that clearer.
250 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
252 2007-04-05 Murray Cumming <murrayc@murrayc.com>
254 * src/maemo/modest-account-view-window.c:
255 (modest_account_view_window_init),
256 (modest_account_view_window_new):
257 Use the same buttons as specified in the
258 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
259 the existing widgets, which never had a chance of working.
260 Put the ModestAccountView treeview in a scrolled window.
261 Do not repeat the initialization in both _init() and _new().
263 * src/widgets/modest-account-view.c: (update_account_view):
264 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
265 this widget and window shows no accounts.
267 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
269 2007-04-05 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/easysetup/modest-easysetup-wizard.c:
272 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
273 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
274 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
277 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
278 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
279 accounts exist yet, as in the UI spec.
281 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
283 2007-04-05 Murray Cumming <murrayc@murrayc.com>
285 * src/maemo/Makefile.am:
286 * src/maemo/modest-connection-specific-smtp-edit-window.c:
287 * src/maemo/modest-connection-specific-smtp-edit-window.h:
288 New window for editing connection-specific smtp details.
289 Not fully implemented.
291 * src/maemo/modest-connection-specific-smtp-window.c:
292 (modest_connection_specific_smtp_window_finalize) :
293 unref the tree model.
294 (on_button_edit): Show the edit window.
296 2007-04-05 Murray Cumming <murrayc@murrayc.com>
298 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
301 * src/maemo/Makefile.am:
302 * src/maemo/modest-connection-specific-smtp-window.c:
303 * src/maemo/modest-connection-specific-smtp-window.h:
304 New window for showing the list of connections, for connection-specific
305 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
306 * src/maemo/easysetup/modest-easysetup-wizard.c:
307 (create_page_custom_outgoing): Show the new window when the button is clicked.
309 2007-04-04 Murray Cumming <murrayc@murrayc.com>
311 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
312 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
313 * src/maemo/modest-msg-edit-window.c:
314 (modest_msg_edit_window_insert_image):
315 * src/modest-conf.c: (modest_conf_key_escape):
316 * src/modest-mail-operation.c:
317 (modest_mail_operation_send_new_mail):
318 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
319 (modest_ui_actions_on_new_account):
320 * src/widgets/modest-attachment-view.c: (update_filename_request):
321 * src/widgets/modest-mail-header-view.c:
322 Corrected warnings that were breaking the build, by commenting out unused variables,
323 and a function, and by including a header.
325 2007-04-04 Murray Cumming <murrayc@murrayc.com>
327 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
328 so we can #ifdef around platform-specific code when necessary.
329 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
330 to allow this to build for the GNOME platform too.
332 2007-04-04 Murray Cumming <murrayc@murrayc.com>
334 * src/maemo/easysetup/modest-easysetup-wizard.c:
335 Added util_increment_name() and used it in create_page_account_details()
336 to make sure that the default account name is always a new name.
338 (modest_easysetup_wizard_dialog_init),
339 (set_default_custom_servernames): Some minor memory management fixes.
341 2007-04-04 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-runtime.c: (init_i18n): Restored the translation
346 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
347 are defined in config.h, and the translations are installed.
349 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
350 is defined for translation.
352 2007-04-03 Murray Cumming <murrayc@murrayc.com>
354 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
356 * src/maemo/easysetup/modest-easysetup-wizard.c:
357 (modest_easysetup_wizard_dialog_init):
358 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
359 Use realistic paths (though they should use $prefix generically) to the
360 mcc_mapping and provider-data.keyfile files which might work when they
361 are installed by the future version of the operator-wizard package,
362 and then fallback to paths in our source code, with an explanatory
365 2007-04-03 Murray Cumming <murrayc@murrayc.com>
369 * src/maemo/Makefile.am:
370 * src/maemo/easysetup/: Added files from the previously-exernal
371 osso-modest-easysetup.
372 * src/maemo/modest-main-window-ui.h:
373 * src/modest-ui-actions.c:
374 * src/modest-ui-actions.h:
375 Added modest_ui_actions_on_new_account() as a signal handler for the
376 New Account menu item. It shows the easysetup wizard.
377 * po/en_GB.po: Added additional needed logical IDs and translations.
379 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
380 Apparently ChangeLog is not used for some vague Nokia legal reasons.