1 2007-06-21 Murray Cumming <murrayc@murrayc.com>
3 * libmodest-dbus-client/libmodest-dbus-client.h:
4 * libmodest-dbus-client/libmodest-dbus-client.c:
5 (modest_dbus_message_iter_get_search_hit),
6 (libmodest_dbus_client_search):
7 Reorganised and commented this.
8 Removed modest_search_hit_free() from the public API because it
11 Added libmodest_dbus_client_get_folders() and
12 modest_folder_result_list_free().
14 * src/dbus_api/modest-dbus-api.h:
15 * src/dbus_api/modest-dbus-callbacks.c:
16 (modest_dbus_req_filter): Commented. Moved most code to
17 on_dbus_method_search() and added on_dbus_method_get_folders().
19 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
20 of the extra D-Bus handler.
22 * tests/dbus_api/Makefile.am:
23 * tests/dbus_api/test_get_folders.c: New test for
24 libmodest_dbus_client_get_folders(). This seems to return an empty list
25 at the moment. That could be the same error that causes the message list
26 to be empty sometimes.
27 This should help with projects.maemo.org bug NB#57740.
29 2007-06-21 Armin Burgmeier <armin@openismus.com>
31 * src/modest-mail-operation.c: Do not call
32 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
33 notify the operation's end after having set the status to CANCELED for
34 the operation queue to listen on. This fixes a deadlock when there
35 were mail operations in the queue during its finalization.
37 * src/modest-singletons.c: Reordered uninitialization of the account
38 manager to happen after the mail operation queue was uninitialized
39 because the mail operation's in the queue might still try to access
40 the account manager (see modest_mail_operation_notify_end()). This
41 fixes a potential crash when terminating the application.
43 2007-06-21 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-search.c:
46 (search_mime_part_and_child_parts): Moved some code here so we
47 can search recursively in child folders.
48 (modest_search_folder): Search in the message as a mime part, instead
49 of just its child mime parts.
50 (read_chunk), (search_mime_part_ogs):
51 Check how many bytes were read, to prevent an endless loop.
52 Searching in message bodies now works. This finishes the fix for
53 projects.maemo.org bug NB#61007.
55 2007-06-20 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
58 Add a g_warning when the item is not a folder.
60 * src/modest-ui-dimming-rules.c:
61 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
62 when selected item is not a folder (for instance, an account), because
63 the UI spec only talks about folders.
64 I am not sure what the UI spec wants, so this might not totally fix
65 projects.maemo.org bug NB#60794.
67 2007-06-20 Murray Cumming <murrayc@murrayc.com>
69 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
70 (load_from_file): Sort the list. The unsorted list would be more noticeable
71 in non-English locales.
73 * src/maemo/modest-msg-edit-window.c:
74 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
75 warning and fix the build.
77 * src/maemo/modest-progress-bar-widget.c:
78 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
79 avoid a g_warning, and probably to avoid a crash.
81 2007-06-20 Murray Cumming <murrayc@murrayc.com>
83 * src/modest-search.c: (modest_search_folder): Check for a GError
84 when calling tny_folder_get_headers(), to show that this is not the cause
87 2007-06-20 Murray Cumming <murrayc@murrayc.com>
89 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
90 Actually set the body query instead of the subject query.
92 * src/modest-search.c: (search_mime_part_ogs),
93 (search_mime_part_strcmp): Remove extra space from the text/* regex,
94 which would probably cause it to fail if we got this far.
96 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
98 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
99 be causing search-in-body to fail.
101 2007-06-20 Murray Cumming <murrayc@murrayc.com>
103 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
105 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
106 Better debug message when the folder cannot be found.
107 This should help with fixing projects.maemo.org bug #61287.
108 * src/modest-search.c: (add_hit): Do not leak the furl string.
110 2007-06-20 Murray Cumming <murrayc@murrayc.com>
112 * src/modest-ui-actions.c:
113 (modest_ui_actions_on_folder_selection_changed):
114 Do not special-case TNY_MERGE_FOLDER here, because
115 modest_tny_folder_get_account() already does that. This fixes
116 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
117 shown when the Outbox was selected).
119 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
121 * libmodest-dbus-client/libmodest-dbus-client.c:
122 (_dbus_iter_get_string_or_null): Initialize the string variable in
123 case this helps with Dirk's crash.
125 2007-06-19 Murray Cumming <murrayc@murrayc.com>
127 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
128 though it is not implemented yet (this function is maybe not even used),
129 to avoid breaking ABI in future.
130 * libmodest-dbus-client/libmodest-dbus-client.c:
131 (get_attachments_string): Moved some code into this generic function.
132 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
133 sends email. It is maybe not used.
134 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
135 (on_send_mail): Use attachments.
137 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
138 * src/maemo/modest-msg-edit-window.c:
139 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
140 a filename before using it, to fix projects.maemo.org bug NB#58233.
142 2007-06-19 Murray Cumming <murrayc@murrayc.com>
144 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
145 Initialize the continue_download variable to fix the build, and probably
146 to fix randome behaviour.
148 2007-06-18 Armin Burgmeier <armin@openismus.com>
150 * src/modest-tny-send-queue.h:
151 * src/modest-tny-send-queue.c: Keep track of the status of messages in
152 the queue so we can later show it in the UI. Replaced
153 modest_tny_send_queue_msg_is_being_sent() by
154 modest_tny_send_queue_get_msg_status().
156 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
158 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
159 gpointer. This probably was not harmful, but just to be sure.
161 2007-06-18 Murray Cumming <murrayc@murrayc.com>
163 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
164 Fix the build, but leave the function broken on Bora, because
165 hildon_uri_action_get_service() does not exist.
166 osso_uri_action_get_service() does not exist either, it seems.
168 2007-06-18 Murray Cumming <murrayc@murrayc.com>
170 * src/modest-tny-account.c:
171 (modest_tny_account_new_from_server_account):
172 Uncommented the url debug output again, because it is useful for
173 debugging, as I said in the comment.
175 2007-06-18 Murray Cumming <murrayc@murrayc.com>
177 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
179 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
180 for Mameo Bora, to fix the build.
182 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
185 Fixed build with hildon < 0.99
187 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
188 Check if the selected account is busy instead of checking all accounts
190 * src/modest-account-mgr-priv.h:
191 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
192 (modest_account_mgr_init), (compare_account_name),
193 (modest_account_mgr_set_account_busy),
194 (modest_account_mgr_account_is_busy):
195 * src/modest-account-mgr.h:
196 Added busy information to the account manager. It possible to
197 set an account to busy or not busy now.
199 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
200 (modest_mail_operation_update_account),
201 (modest_mail_operation_notify_end):
202 Set the account to busy/not busy depending on the operation state.
204 * src/widgets/modest-account-view.c:
205 (modest_account_view_finalize), (get_last_updated_string),
206 (update_account_view), (on_account_busy_changed), (init_view):
207 Show string "Refreshing..." if the account is currently busy.
209 All this fixes projects.maemo.org bug NB#59711
211 2007-06-14 Armin Burgmeier <armin@openismus.com>
213 * src/widgets/modest-attachments-view.h:
214 * src/widgets/modest-attachments-view.c: Added
215 modest_attachments_view_has_attachments() and fixed coordinate
216 transformation in get_att_view_at_coords(). This fixes attachment
219 * src/widgets/modest-msg-view.c: Make use of
220 modest_attachments_view_has_attachments() to decide whether to show
221 attachments in the header.
223 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
225 * src/maemo/modest-connection-specific-smtp-edit-window.c:
226 (on_change), (on_combo_security_changed),
227 (modest_connection_specific_smtp_edit_window_init),
228 (modest_connection_specific_smtp_edit_window_set_connection),
229 (modest_connection_specific_smtp_edit_window_is_dirty):
230 * src/maemo/modest-connection-specific-smtp-edit-window.h:
231 * src/maemo/modest-connection-specific-smtp-window.c:
234 Show an comfirmation dialog for the smpt-edit-window if there are
235 unsaved changes and the user hits cancel.
236 (projects.maemo.org bug NB#60479)
238 2007-06-14 Armin Burgmeier <armin@openismus.com>
240 * src/maemo/easysetup/modest-easysetup-wizard.c:
241 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
242 address" info in banner instead of node, and select all the text as
243 per UI spec. This fixes projects.maemo.org bug NB#60550.
245 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
247 reviewed by: <delete if not using a buddy>
249 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
250 * src/modest-ui-actions.c: (folder_refreshed_cb):
252 2007-06-14 Murray Cumming <murrayc@murrayc.com>
254 * src/widgets/modest-folder-view.c: (filter_row):
255 Explictly filter out the per-account outbox accounts. I don't know why
256 these only sometimes show up, but now they should never show up in the UI.
257 This should fix projects.maemo.org bug NB#60160.
259 2007-06-14 Murray Cumming <murrayc@murrayc.com>
261 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
262 when the toolbar does not exist yet.
263 * src/modest-widget-memory.c: (save_settings_header_view):
264 Added g_warnings() to help us to discover when we are trying to set
265 an empty columns list in gconf.
267 2007-06-14 Murray Cumming <murrayc@murrayc.com>
271 Added modest_init_get_default_header_view_column_ids().
273 * src/modest-widget-memory.c: (restore_settings_header_view):
274 Use the new function to get defaults, if the gconf key is empty,
275 instead of not creating any columns. This seems to fix the
276 empty right-hand pane problems.
278 * src/widgets/modest-header-view.h: Improved documentation.
280 2007-06-13 Murray Cumming <murrayc@murrayc.com>
282 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
283 Revert the use of the display name as the account name, because this
284 is generally wrong and would break the code that follows.
286 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
288 * src/maemo/easysetup/modest-easysetup-wizard.c:
289 (check_for_supported_auth_methods), (on_before_next),
292 More correct fix for projects.maemo.org bug NB# 58991
293 Do not longer accept AUTH_PASSWORD as secure method and choose
294 correct method when creating the account.
296 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
298 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
299 Fixed projects.maemo.org bug NB# 58991
301 2007-06-13 Murray Cumming <murrayc@murrayc.com>
303 * src/modest-init.c: (modest_init_init_core),
304 (modest_init_local_folders): Fixed compilation errors.
306 2007-06-13 Murray Cumming <murrayc@murrayc.com>
308 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
309 Remove unnecessary lib/include, though it is good in principle when needed.
311 * src/modest-init.c: (modest_init_one_local_folder),
312 (modest_init_local_folders):
313 * src/modest-init.h: Initialize the .modest library for memory cards,
314 instead of just doing nothing for them. This should allow us to create
315 folders there, fixing projects.maemo.org bug NB#59297.
317 2007-06-13 Murray Cumming <murrayc@murrayc.com>
319 * libmodest-dbus-client/libmodest-dbus-client.c:
320 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
321 (libmodest_dbus_client_compose_mail),
322 (libmodest_dbus_client_open_message),
323 (libmodest_dbus_client_send_and_receive),
324 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
326 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
327 (on_idle_open_message), (modest_dbus_req_handler),
328 (search_result_to_message), (modest_dbus_req_filter):
329 * src/modest-search.c: (add_hit), (modest_search_folder),
330 (modest_search_all_accounts): Improved debug messages.
332 * tests/dbus_api/test_open_message.c: (main): Improved comments.
334 * src/modest-tny-account-store.c:
335 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
338 2007-06-13 Murray Cumming <murrayc@murrayc.com>
341 2007-06-12 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-tny-account-store.c: (get_server_accounts):
344 Call modest_tny_local_folders_account_add_merged_outbox_folders()
345 even when there are no accounts, so that the Outbox folder is always
346 visible. This fixes projects.maemo.org bug NB#60158.
348 2007-06-12 Murray Cumming <murrayc@murrayc.com>
350 * src/maemo/modest-main-window.c: (create_details_widget):
351 Use the mcen_va_never logical ID.
353 2007-06-12 Murray Cumming <murrayc@murrayc.com>
355 * src/dbus_api/modest-dbus-api.h:
356 * src/dbus_api/modest-dbus-callbacks.c:
357 (on_idle_open_default_inbox), (on_open_default_inbox),
358 (modest_dbus_req_handler):
359 Added a new OpenDefaultInbox method.
361 * libmodest-dbus-client/libmodest-dbus-client.h:
362 * libmodest-dbus-client/libmodest-dbus-client.c:
363 Added libmodest_dbus_client_open_default_inbox() to call the new
364 dbus method. This should be useful to projects.maemo.org bug NB#57214,
365 though it should maybe be used by a new osso-email-interface function.
367 * tests/dbus_api/Makefile.am:
368 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
371 2007-06-12 Murray Cumming <murrayc@murrayc.com>
373 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
374 NULL, so that the signals get all the keys. This should not actually
375 change any behaviour because we currently update everything when anything
378 2007-06-12 Murray Cumming <murrayc@murrayc.com>
380 * src/widgets/modest-folder-view.c: (text_cell_data),
381 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
382 (find_inbox_iter): If tinymail tells us that the folder is
383 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
384 This causes the inbox to be selected at startup, fixing part of
385 projects.maemo.org bug NB#56305.
387 * src/modest-ui-dimming-rules.c:
388 (modest_ui_dimming_rules_on_tools_smtp_servers):
389 * src/modest-ui-dimming-rules.h: Added a callback function to dim
390 the SMTP servers menu item.
391 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
392 that the SMTP Servers menu item is dimmed when there are no accounts,
393 as a future version of the UI spec will require. This fixes
394 projects.maemo.org bug NB#56305.
396 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
398 * src/maemo/modest-maemo-utils.c:
399 (modest_maemo_utils_get_supported_secure_authentication_methods):
400 Added label to dialog instead of unreadable title
402 * src/maemo/modest-main-window.c: (sync_accounts_cb),
403 (modest_main_window_new):
404 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
407 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
408 * src/modest-account-mgr.h:
409 Added method to avoid code duplication
411 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
412 (modest_ui_actions_on_send_receive):
413 Use modest_account_mgr_has_accounts
415 2007-06-11 Murray Cumming <murrayc@murrayc.com>
417 * src/maemo/easysetup/modest-presets.c:
418 (modest_presets_get_info_server_security): Do not report secure auth
420 * src/modest-protocol-info.c: Use the defines for the gconf key names
421 for secure authentication. This was not working because we were writing
422 Password and reading password, and the check was case sensitive.
423 With this, gmail now works for receiving and sending when created via
426 2007-06-11 Murray Cumming <murrayc@murrayc.com>
428 * src/maemo/easysetup/modest-presets.c:
429 (modest_presets_get_info_server_security): Correct the key name for
430 SecureSmtp, because it seems to be case-sensitive.
431 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
432 Do not try to get the 0th notebook page if there are 0 pages, to
435 2007-06-11 Murray Cumming <murrayc@murrayc.com>
437 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
438 Prevent use of the new notification feature for now, because it currently
439 shows one dialog for each new email, which is annoying.
441 2007-06-11 Murray Cumming <murrayc@murrayc.com>
443 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
444 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
445 when no country was selected, so that we show the global ones.
446 * src/maemo/easysetup/modest-presets.c:
447 (modest_presets_get_providers): Return only the global providers, not
448 all providers when mmc=0 was requested.
450 2007-06-11 Murray Cumming <murrayc@murrayc.com>
452 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
453 (easysetup_provider_combo_box_fill): Remove debug code that showed the
454 provider ID in the combo.
456 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
457 Do not show the page numbers, because it would be confusing when we add
458 the 2 extra pages for the custom setup, when the user chooses the "Other"
459 provider. This fixes projects.maemo.org bug NB#59028
461 * src/modest-init.c: (modest_init_init_core),
462 (modest_init_local_folders):
464 * src/modest-tny-account.c:
465 (modest_tny_account_new_for_local_folders): Do not create default folders
466 for the memory card. This should fix projects.maemo.org bug NB#59328.
468 2007-06-11 Murray Cumming <murrayc@murrayc.com>
470 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
471 Free the changed_conf_keys string items. They are already freed in the
472 idle handler if that runs first.
474 2007-06-11 Murray Cumming <murrayc@murrayc.com>
476 * src/modest-ui-actions.c:
477 (modest_ui_actions_on_password_requested): Check that the server name
478 is not NULL, because I just saw a password dialog with (null) as the
481 * src/modest-tny-folder.[h|c]: Added
482 modest_tny_folder_is_memory_card_folder().
483 * src/modest-ui-dimming-rules.c:
484 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
485 menu item for memory cards, as per the UI spec (section 7.4). This should
486 fix projects.maemo.org bug NB#59297.
488 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
490 * src/maemo/modest-main-window.c: (sync_accounts_cb):
491 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
492 is another problem with the code, see Murray's comment at line 772)
494 2007-06-08 Murray Cumming <murrayc@murrayc.com>
496 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
497 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
498 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
499 (load_from_file), (easysetup_country_combo_box_init),
500 (easysetup_country_combo_box_get_active_country_ids),
501 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
502 instead of just one ID, to avoid duplicate country names in the UI.
504 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
505 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
506 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
507 a single ID, avoiding duplicate providers.
508 * src/maemo/easysetup/modest-easysetup-wizard.c:
509 (on_combo_account_country): Adapt to use a list.
511 2007-06-08 Murray Cumming <murrayc@murrayc.com>
513 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
514 keys changed in the last X seconds.
516 * src/modest-account-mgr.h:
517 * src/modest-account-mgr.c: (on_timeout_notify_changes),
518 (on_key_change), (modest_account_mgr_class_init),
519 (modest_account_mgr_init), (modest_account_mgr_finalize):
520 As the keys are changed, save them in a GSList* and signal that GSList*
521 further every X seconds, to batch changes, to allow us to do just one
522 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
523 bug NB#56941 and other (UI-blocking) delays when changing account settings.
525 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
526 changed signal signature.
528 * src/modest-conf.c: (modest_conf_set_list),
529 (modest_conf_on_change): Reenable notification.
531 (modest_conf_maemo_fake_on_change): Comment out the hack that
532 notified immediately instead of asynchronously.
534 * src/widgets/modest-account-view.h:
535 * src/widgets/modest-account-view.c:
536 (update_account_view): Select the previously-selected account ID,
537 if possible. This fixes projects.maemo.org bug NB#56933.
539 (on_account_changed), (on_account_removed),
540 (modest_account_view_select_account):
542 Remove the block/unblock functions
543 because they were not useful.
545 * src/maemo/modest-account-view-window.c:
546 (on_delete_button_clicked), (on_edit_button_clicked),
547 (on_new_button_clicked): Remove the use of the non-working block/unblock.
549 2007-06-08 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
552 Improve the error dialog to show Incorrect Account Settings, which seems
553 clearer, and say that the internal error message (to be removed from the
554 dialog later) is often misleading.
555 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
557 * src/modest-tny-account.c:
558 (modest_tny_account_new_from_server_account): Uncomment the printf of the
559 URL because this is so useful for debugging on the device.
561 * src/widgets/modest-serversecurity-combo-box.c:
562 (modest_serversecurity_combo_box_fill): Correct a logical ID.
564 2007-06-08 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-mail-operation.c:
567 (modest_mail_operation_send_new_mail):
568 Added a comment about a nasty but apparently harmless message. Details
569 added to the wiki g_warnings() page.
571 2007-06-08 Murray Cumming <murrayc@murrayc.com>
573 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
574 (modest_tny_send_queue_class_init):
575 Do not use the priv struct because it is empty, to avoid g_warnings
576 about a non-existant priv struct.
578 * src/modest-tny-account-store.c:
579 (modest_tny_account_store_get_server_account),
580 (modest_tny_account_store_get_transport_account_for_open_connection
581 ): Do not try to get transport server accounts for local folders,
582 because they don't have any. This avoids a g_warning().
584 * src/maemo/modest-main-window.c:
585 (modest_main_window_notify_send_receive_initied),
586 (on_configuration_key_changed):
587 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
589 * src/modest-mail-operation.c:
590 (modest_mail_operation_update_account):
591 * src/modest-tny-account-store.h:
592 * src/modest-tny-account.c:
593 (modest_tny_account_get_special_folder),
594 (modest_tny_account_new_for_local_folders),
595 (modest_tny_account_new_for_per_account_local_outbox_folder):
596 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
597 * src/modest-tny-local-folders-account.c:
598 (add_account_folders_to_merged_folder):
599 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
600 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
601 (modest_ui_actions_on_send):
602 * src/widgets/modest-folder-view.c: (update_model):
603 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
604 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
605 modest_tny_account_store_get_tny_account_by_account() to
606 modest_tny_account_store_get_server_account() to make the code clearer.
608 2007-06-07 Marcus Bauer <marcusb@openismus.com>
610 * src/dbus_api/modest-dbus-api.h:
611 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
612 * src/maemo/modest-msg-edit-window.c:
613 (modest_msg_edit_window_attach_file_noninteractive):
614 added g_warning in case the file to be attached does not exist
615 * tests/dbus_api/test_compose_mail.c: (main):
616 removed obsolete comment, added generic files as test case
618 2007-06-07 Murray Cumming <murrayc@murrayc.com>
620 * src/modest-tny-account-store.c: (get_server_accounts):
621 Create the local folders account only once, not once for each outbox, and
622 not only when there are some outboxes.
624 2007-06-07 Murray Cumming <murrayc@murrayc.com>
626 * src/widgets/modest-folder-view.c: (update_model): Comment out some
627 code that is causing a crash at startup. Sergio says that he is fixing this.
629 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
631 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
632 * src/maemo/modest-account-settings-dialog.c:
633 (create_page_outgoing),
634 (modest_account_settings_dialog_set_account_name),
635 (save_configuration):
636 - Fixed handling of the "Use secure authentication" toggle to comply with
637 the ui specification. See also projects.maemo.org bug NB#58400
639 - Restore the Secure connection setting combo correctly when loading
642 * src/maemo/modest-maemo-utils.c:
643 (on_camel_account_get_supported_secure_authentication),
644 (modest_maemo_utils_get_supported_secure_authentication_methods):
645 Fixed a crasher if operation is canceled
647 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
648 (modest_protocol_info_auth_is_secure):
649 * src/modest-protocol-info.h:
651 Added two new methods to determine if a protocol/auth method is secure/encrypted in
652 the sense of the "Use secure authentication" toggle.
654 2007-06-07 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-tny-account-store.h:
657 * src/modest-tny-account-store.c:
658 Added modest_tny_account_store_get_local_folders_account().
660 * src/modest-tny-folder.h:
661 * src/modest-tny-folder.c:
662 (modest_tny_folder_get_account):
663 Added this replacement for tny_folder_get_account() which returns
664 the local-folders account for TnyMergeFolders, to avoid the
665 warning about the unimplemented get_account_func() vfunc().
667 (modest_tny_folder_get_rules),
668 * src/modest-ui-actions.c:
669 (modest_ui_actions_on_folder_selection_changed):
670 * src/modest-mail-operation.c:
671 (modest_mail_operation_remove_folder),
672 (modest_mail_operation_xfer_folder),
673 (modest_mail_operation_rename_folder),
674 (modest_mail_operation_get_msg),
675 (modest_mail_operation_get_msgs_full),
676 (modest_mail_operation_remove_msg),
677 (modest_mail_operation_xfer_msgs),
678 (modest_mail_operation_refresh_folder):
679 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
681 2007-06-07 Murray Cumming <murrayc@murrayc.com>
683 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
684 (modest_server_account_set_security):
685 * src/modest-defs.h: Add comments explaining that our
686 UI spec means TLS when it says Normal, so these do not look like errors.
688 * src/modest-tny-account.c:
689 (modest_tny_account_new_from_server_account): Use the new tinymail
690 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
691 for TLS. This should fix projects.maemo.org bug NB#58460.
693 2007-06-06 Murray Cumming <murrayc@murrayc.com>
695 * src/maemo/easysetup/modest-easysetup-wizard.c:
696 (create_account): Correct the position of the gconf sanity check warning.
697 (on_button_edit_advanced_settings): Show the dialog immediately, instead
698 of using the g_idle_add() hack, because this does not seem to be necessary
699 on osso 1.1. It might even work on Maemo Bora if the problems were actually
700 caused by something other than maemo's gconf.
701 This fixes projects.maemo.org bug #59022.
703 2007-06-06 Murray Cumming <murrayc@murrayc.com>
705 * src/modest-account-mgr-helpers.c:
706 (modest_account_mgr_get_default_account): Do not check that the account
707 exists if there is no default account (NULL), to fix a runtime warning.
709 2007-06-06 Murray Cumming <murrayc@murrayc.com>
711 * src/widgets/modest-folder-view.c: (update_model):
712 Do not unref the treemodel before we have finished with it.
713 This prevents a valgrind warning and an occasional crash at startup.
715 2007-06-06 Marcus Bauer <marcusb@openismus.com>
717 * libmodest-dbus-client/libmodest-dbus-client.h:
718 added libmodest_dbus_client_compose_mail()
719 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
721 added functions needed for SendAsMail() functionality
722 * src/maemo/modest-msg-edit-window.c:
723 (modest_msg_edit_window_attach_file_noninteractive):
724 non interactively attaching files to message edit window
725 * src/widgets/modest-msg-edit-window.h:
726 * tests/dbus_api/Makefile.am:
727 added test_compose_mail.c
728 * tests/dbus_api/test_compose_mail.c: (main):
730 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
732 * src/modest-account-view.c:
733 Fixed bug projects.maemo.org bug NB#59307
735 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
737 * src/maemo/easysetup/modest-easysetup-wizard.c:
738 (get_serverport_incoming), (on_before_next), (create_account):
739 * src/maemo/modest-account-settings-dialog.c:
740 (modest_account_settings_dialog_set_account_name):
741 * src/maemo/modest-maemo-utils.c:
742 (on_camel_account_get_supported_secure_authentication_status),
743 (on_camel_account_get_supported_secure_authentication),
744 (on_secure_auth_cancel),
745 (modest_maemo_utils_get_supported_secure_authentication_methods):
747 Implemented security authentication for settings and easysetup.
749 2007-06-05 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/modest-main-window.c: (create_details_widget):
752 Show the total size for memory card accounts too, instead of showing
753 the name again. Fixes bug projects.maemo.org bug NB#59307.
755 2007-06-05 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-tny-simple-folder-store.c:
759 * src/modest-tny-simple-folder-store.h: Removed.
761 * src/modest-tny-local-folders-account.h
762 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
763 for the local-folders maildir, with an extra TnyMergedFolder containing
764 the folders of the per-account outbox store accounts.
765 * src/modest-tny-account-store.c: (get_server_accounts):
766 Add the outboxes to the special local folders account after creating it.
768 * src/modest-tny-account.c:
769 (modest_tny_account_new_for_local_folders): Create the derived
770 account when creating the main local-folders account.
772 * src/maemo/modest-main-window.c: (create_details_widget),
773 (modest_main_window_set_contents_style):
774 Adapted to the use of the derived account instead of the folder store.
776 * src/modest-ui-actions.c:
777 (modest_ui_actions_on_folder_selection_changed):
778 * src/modest-ui-dimming-rules.c:
779 (modest_ui_dimming_rules_on_new_folder):
780 * src/widgets/modest-folder-view.c: (text_cell_data),
781 (icon_cell_data), (filter_row), (update_model),
782 (get_cmp_rows_type_pos):
785 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
786 Do not get the priv struct, because no priv struct has been set,
787 to avoid a runtime warning.
789 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
790 #ifelse with #else, to fix a warning, to fix the build.
793 2007-06-05 Christian Kellner <ckellner@openismus.com>
795 * libmodest-dbus-client/libmodest-dbus-client.c:
796 Fix small typo in doc (why do you always see them
797 AFTER committing stuff?)
800 2007-06-05 Christian Kellner <ckellner@openismus.com>
802 * libmodest-dbus-client/libmodest-dbus-client.c:
803 (libmodest_dbus_client_search):
804 Initialize hit list with NULL. Also set folder list
805 to "" if NULL was supplied.
808 2007-06-03 Christian Kellner <ckellner@openismus.com>
810 * libmodest-dbus-client/libmodest-dbus-client.c:
811 (modest_search_hit_list_free):
812 Make it save to call it with NULL.
814 * src/dbus_api/modest-dbus-callbacks.c:
815 * src/modest-search.c:
816 Return full ModestSearchHits as the search result list not TnyHeader
817 since can't be around withouth the correspoding TnyFolder.
819 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
821 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
822 Added currently commented code to check for secure auth
824 * src/maemo/modest-account-settings-dialog.c: (on_response),
825 (save_configuration), (show_ok):
826 Fixed projects.maemo.org bugs NB #59248 and #59251
828 * src/maemo/modest-maemo-utils.c:
829 (on_camel_account_get_supported_secure_authentication_status),
830 (on_camel_account_get_supported_secure_authentication),
831 (modest_maemo_utils_get_supported_secure_authentication_methods):
832 * src/maemo/modest-maemo-utils.h:
833 Moved get_supported_secure_authentication() method here to be able
834 to use it from easysetup wizard.
836 * src/modest-pair.c: (on_pair_compare_as_string):
837 Should compare string with first part of pair and not
838 strcmp pairs which will crash.
840 * src/modest-protocol-info.c:
841 (modest_protocol_info_protocol_is_store):
842 * src/modest-protocol-info.h:
843 Added modest_protocol_info_get_auth_protocol_name()
845 2007-06-03 Armin Burgmeier <armin@openismus.com>
847 * src/modest-mail-operation.c:
848 (modest_mail_operation_get_msgs_full): Set priv->account also when
849 only retrieving a single message. This avoids a crash when canceling
852 (modest_mail_operation_notify_end): Do not explicitely remove the
853 operation from the queue but only emit the progress_changed signal.
854 The queue itself listens to that signal to remove the operation when
855 it is finished. This reduces coupling and removes a potential deadlock
856 when modest_mail_operation_notify_end() is called from the queue
857 itself. If that is a problem performance-wise, I would suggest to
858 implement a status-changed signal or something.
860 * src/modest-mail-operation-queue.c: Make sure to never call a
861 function from another file while the queue is locked. This (hopefully)
862 fixes another deadlock when exiting the application while retrieving
865 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
867 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
868 Fixed build if libogs is not available
870 2007-06-03 Christian Kellner <ckellner@openismus.com>
872 * libmodest-dbus-client/libmodest-dbus-client.h:
873 * libmodest-dbus-client/libmodest-dbus-client.c:
874 (libmodest_dbus_client_delete_message):
875 Implement deletion of messages (Client side).
877 (modest_search_hit_free),
878 (modest_search_hit_list_free):
879 Utility functions to free the result hits.
881 * src/dbus_api/modest-dbus-api.h:
882 * src/dbus_api/modest-dbus-callbacks.c:
884 (modest_dbus_req_handler):
885 Implement deletion of messages (Server side).
887 * tests/dbus_api/test_search.c: (main):
890 * tests/dbus_api/Makefile.am:
891 * tests/dbus_api/test_delete_message:
892 Add little test for the message deletion logic
894 2007-06-03 Armin Burgmeier <armin@openismus.com>
896 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
897 when the operation queue was not empty. projects.maemo.org bug
900 2007-06-03 Armin Burgmeier <armin@openismus.com>
902 * src/widgets/modest-account-view.c
903 (on_account_default_toggled): Toggle default account column
904 explicitely instead of waiting for gconf notification (which is
905 currently ignored). This should fix projects.maemo.org bug NB#56910
906 for now. It should probably be removed when gconf notifications are
909 2007-06-03 Christian Kellner <ckellner@openismus.com>
911 * libmodest-dbus-client/libmodest-dbus-client.c:
912 Removed debugging spew.
914 * src/dbus_api/modest-dbus-callbacks.c:
915 Added debugging info.
917 * src/modest-search.c:
918 (modest_search_all_accounts):
919 Use tny_account_store_get_accounts () on the account store
920 to get all accounts which is the way to get all accounts.
922 * tests/dbus_api/test_search.c: (main):
923 Make it possible to supply the search term on the command line.
925 2007-06-03 Christian Kellner <ckellner@openismus.com>
927 * libmodest-dbus-client/libmodest-dbus-client.c:
928 * libmodest-dbus-client/libmodest-dbus-client.h:
929 Implement searching for mesages over raw dbus. (Client side)
931 * src/dbus_api/Makefile.am:
932 * src/dbus_api/modest-dbus-api.h:
933 * src/dbus_api/modest-dbus-callbacks.c:
934 * src/dbus_api/modest-dbus-callbacks.h:
935 Search framework (Server side). Also implement on_idle_open_message().
937 * src/maemo/modest-platform.c: (modest_platform_init):
938 Prepare for raw dbus/osso rpc interaction.
940 * src/modest-search.h:
941 Changed minsize from unspecific guint to guint32.
943 * src/modest-search.c:
945 Added strange hack which magically made tnymail work.
947 (modest_search_folder),
948 (modest_search_account),
949 (modest_search_all_accounts):
950 Implement helper functions to search all accounts, specific account
953 * tests/dbus_api/Makefile.am:
954 * tests/dbus_api/test_open_message.c:
955 Read url to open from commandline.
957 * tests/dbus_api/test_search.c:
958 Implement small test for dbus search stuff
960 2007-06-02 Armin Burgmeier <armin@openismus.com>
962 * src/maemo/modest-account-settings-dialog.c: Changed window title to
963 include account type and account title. This fixes projects.maemo.org
966 * src/maemo/modest-account-view-window.c: Set a title for the window.
968 2007-06-02 Armin Burgmeier <armin@openismus.com>
970 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
971 incoming and outgoing server name based on email address and server
972 types as long as the names have not been edited manually. This fixes
973 projects.maemo.org bug NB#58671.
975 2007-06-02 Armin Burgmeier <armin@openismus.com>
977 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
978 server type cannot be changed in future to the incoming details page
979 when creating an account. This fixes projects.maemo.org bug NB#59029.
981 2007-06-02 Armin Burgmeier <armin@openismus.com>
983 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
984 and assigned max width chars so that they wrap instead of being
985 truncated. Fixes projects.maemo.org bug NB#56126.
987 2007-06-02 Armin Burgmeier <armin@openismus.com>
989 * src/maemo/modest-connection-specific-smtp-window.c: Add an
990 introductory note to the connection specific smtp servers dialog, as
991 section 8.12 of the email UI specification requires. This fixes
992 projects.maemo.org bug NB#59212.
994 2007-06-01 Murray Cumming <murrayc@murrayc.com>
996 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
997 Check for running mail operations, and offer to cancel them, as per the UI
998 spec. This fixes projects.maemo.org bug NB#59041 .
999 However, I suspect that tinymail may still use the network connection
1000 in ways that we cannot detect or cancel. But it should at least adapt to
1001 changes fairly well.
1003 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1005 * src/modest-tny-account-store.c: (recreate_all_accounts),
1006 (get_cached_accounts), (get_server_accounts): Do more sensible
1007 ref-counting of the temporarily-cached outbox accounts list. This seems
1008 to fix a crash when entering the password when the password was wrong.
1010 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1012 * src/gnome/modest-main-window.c: (connect_signals):
1013 * src/modest-tny-account-store.c: (get_password),
1014 (modest_tny_account_store_alert): Added comments and clues and
1015 commented-out code about how we currently fail to deal with connection
1016 errors and wrong passwords, and how we should.
1018 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1020 * src/widgets/modest-retrieve-combo-box.c:
1021 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1022 This fixes projects.maemo.org bug NB#58472 .
1024 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1026 * src/maemo/easysetup/modest-easysetup-wizard.c:
1027 (create_page_complete_easysetup):
1028 (create_page_complete_custom): Correct the last commit,
1029 putting the correct sentences in the correct pages.
1031 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1033 * src/maemo/easysetup/modest-easysetup-wizard.c:
1034 (create_page_complete_custom): Show the second sentence of text
1035 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1038 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1040 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1041 Set the leave-on-server conf key by default. This fixes
1042 projects.maemo.org bug NB#59258 .
1044 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1046 * src/maemo/modest-account-view-window.c:
1047 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1048 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1051 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1053 * src/maemo/easysetup/modest-easysetup-wizard.c:
1054 (create_caption_new_with_asterisk):
1055 * src/maemo/modest-account-settings-dialog.c:
1056 (create_caption_new_with_asterisk):
1057 Uncomment the code to add the asterisk, because they are no longer in the
1058 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1059 (update_incoming_server_title): Add an asterisk here too.
1061 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1063 * src/maemo/modest-maemo-global-settings-dialog.c:
1064 (current_connection): Check that we are even connected before trying to
1065 get the current connection name, to prevent a warning.
1067 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1068 Change the comments because tny_maemo_conic_device_connect() is now meant to
1070 * src/modest-mail-operation.c:
1071 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1072 make sure we have a connection and fail if we can't connect.
1074 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1076 * src/maemo/modest-main-window.c:
1077 (on_account_store_connecting_finished): Do not try to get the
1078 connection ID if we are not really connected. I am surprised that
1079 this signal handler is called when we are not connected.
1081 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1083 * src/modest-error.h:
1084 * src/modest-ui-actions.c:
1085 (modest_ui_actions_get_msgs_full_error_handler):
1086 Renamed an enum, added comments, added an enum
1087 for retrieve-limit errors.
1089 * src/modest-mail-operation.c: (foreach_add_item),
1090 (internal_folder_observer_update), (update_account_thread),
1091 (modest_mail_operation_get_msgs_full):
1092 (modest_mail_operation_update_account),
1093 Added comments about how this works, and some code that should
1094 (but does not) check the retrieve-limit. See the TODO comment.
1096 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1098 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1099 Initialize help_id to fix the build. Warnings are good.
1101 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1103 * src/widgets/modest-hbox-cell-renderer.c:
1104 (modest_hbox_cell_renderer_append):
1105 * src/widgets/modest-vbox-cell-renderer.c:
1106 (modest_vbox_cell_renderer_append):
1107 Fix the last commit by doing an extra ref.
1109 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1111 * src/widgets/modest-hbox-cell-renderer.c:
1112 (modest_hbox_cell_renderer_append):
1113 * src/widgets/modest-vbox-cell-renderer.c:
1114 (modest_vbox_cell_renderer_append):
1115 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1116 to fix the build with Maemo Bora.
1117 However, there seems to be a remaining crash, probably due to reference
1120 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1122 * src/modest-tny-account.c:
1123 (modest_tny_account_new_for_local_folders):
1124 Use hildon_file_system_info_async_new() to get a better name for
1125 the memory card account, setting it as the account name.
1126 The timing seems to work, but this is probably
1127 not the best place to do this. See the TODO comment.
1128 * src/maemo/modest-main-window.c: (create_details_widget):
1129 * src/widgets/modest-folder-view.c: (text_cell_data):
1130 Use the tny account name instead of hardcoding a name.
1132 2007-05-30 Christian Kellner <ckellner@openismus.com>
1134 * src/modest-search.c: (modest_search):
1135 Correctly set part_search_func even if we have already parsed
1136 the query and thus a valid OgsTextSearcher object.
1138 2007-05-30 Christian Kellner <ckellner@openismus.com>
1141 Search and check for libogs.
1144 Incooparte the ogs build env.
1146 * src/modest-mime-part-search-stream.c:
1147 * src/modest-mime-part-search-stream.h:
1148 Removed since we do the real searching now in modest-search.c.
1150 * src/modest-search.c:
1151 * src/modest-search.h:
1152 Implement support for ogs. We use that if available and requested
1153 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1154 should now handle the corner case when the search term is spread
1155 across multiple reads.
1156 Also the logic in modest_search () was corrected to search all
1157 requested fields until one is found.
1159 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1163 * src/modest-init.h:
1164 * src/modest-init.c: Made modest_init_local_folders() take a
1165 path and be public so we can iniitialize maildir folders on
1168 * src/modest-local-folder-info.h:
1169 * src/modest-local-folder-info.c:
1170 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1172 * src/modest-tny-account.c:
1173 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1174 still means the standard local-folders path on the local volume.
1176 * src/modest-tny-account-store.c:
1177 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1178 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1179 all accounts when that happens.
1180 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1181 this too, so it shows up in the treeview.
1183 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1185 * src/maemo/modest-maemo-global-settings-dialog.c:
1186 (current_connection):
1187 * src/widgets/modest-global-settings-dialog.c:
1188 (current_connection_default):
1189 Use the enum values instead of 0, 1 and -1,
1190 to make the code clearer.
1192 * src/modest-account-mgr-helpers.c:
1193 (modest_account_mgr_get_connection_specific_smtp): Make this code
1196 * src/modest-runtime.h:
1197 * src/modest-runtime.c:
1198 Added modest_runtime_remove_all_send_queues().
1199 * src/maemo/modest-main-window.c:
1200 (on_account_store_connecting_finished): Recreate the send queues,
1201 using the appropriate transport accounts for this new connection.
1202 Some futher adapting might be needed if the old send queues are not
1203 automatically stopped at this point.
1205 * src/modest-tny-account-store.c: (get_server_accounts):
1206 Create the connection-specific transport accounts, so that they can
1207 be found later by their ID.
1209 * src/modest-tny-account.h:
1210 * src/modest-tny-account.c:
1211 Added modest_tny_account_new_from_server_account_name().
1212 modest_tny_account_new_from_server_account(): Do not create the
1213 send queues here, because they will be
1214 recreated anyway when the connection changes for the first time.
1216 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1218 * src/modest-local-folder-info.h:
1219 * src/modest-local-folder-info.c:
1220 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1221 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1222 tbox_folder): Take a modest account name instead of a server TnyAccount,
1223 so we can have per-modest-account rather than per-transport-account
1225 We must make sure that we change or recreate the exisitng send queues
1226 when the connection changes for connection-specific transport accounts.
1228 * src/modest-tny-account-store.c:
1229 (create_per_account_local_outbox_folders): Create outboxed per modest
1230 account, not per transport account.
1232 * src/modest-tny-account.h:
1233 * src/modest-tny-account.c:
1234 (modest_tny_account_get_special_folder): For outboxes, get the
1235 parent modest account name. The account is ignored for other folders.
1236 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1237 modest account name rather than a server TnyAccount.
1239 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-tny-account.c:
1242 (modest_tny_account_new_from_server_account):
1243 Call modest_runtime_get_send_queue() immediately after creating transport
1244 accounts, so that they start trying to send email from the outbox as soon
1245 as possible at startup. This is probably what we want.
1247 * src/modest-mail-operation.c: (update_account_thread):
1248 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1249 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1250 * src/modest-tny-send-queue.h:
1251 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1252 (modest_ui_actions_on_send):
1253 Added comments about how sending works, though it needs some more work.
1255 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1257 * src/modest-tny-account.c:
1258 (modest_tny_account_get_special_folder): Add TODO because this fails when
1259 the network is busy.
1260 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1261 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1262 Do not try to show this window when there is no active account. The UI
1263 specs does not tell us what to do in this case.
1265 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1269 * src/maemo/Makefile.am:
1270 * src/widgets/Makefile.am: Some dist fixes.
1272 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1274 * src/maemo/modest-connection-specific-smtp-window.c:
1275 (on_button_edit): Make the code clearer, to prevent a double free.
1277 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1279 * src/maemo/modest-account-settings-dialog.c:
1280 (modest_account_settings_dialog_set_account_name),
1281 Check the connection-specific smtp servers checkbox if there are any.
1283 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1284 (modest_connection_specific_smtp_edit_window_init):
1285 Start with a suitable port number.
1287 * src/modest-account-mgr-helpers.h:
1288 * src/modest-account-mgr-helpers.c: Added
1289 modest_account_mgr_get_has_connection_specific_smtp().
1291 (modest_account_mgr_set_connection_specific_smtp),
1292 (modest_account_mgr_remove_connection_specific_smtp),
1293 (modest_account_mgr_get_has_connection_specific_smtp),
1294 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1295 connection-specific smtp server accounts in the account, rather than
1296 the server account conf dir.
1298 This fixes bug projects.maemo.org bug NB#58263 .
1300 * src/modest-tny-account-store.c:
1301 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1302 if there are no server accounts yet, to prevent an infinite loop when there
1303 are no accounts. Document that one must be called before the other.
1305 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1307 * src/modest-account-mgr-helpers.c:
1308 (modest_account_mgr_get_default_account): Make sure that at least
1309 one account is always the default, if there are any enabled accounts.
1310 This is just a sanity check that shouldn't be necessary.
1312 * src/modest-account-mgr-priv.c:
1313 (_modest_account_mgr_account_from_key): Unescape the conf key to
1314 get the real account name. For instance, this is an issue if a space
1315 was in the account name, which can happen because the account name
1316 is generated from the display name.
1317 (_modest_account_mgr_get_account_keyname): Always escape the
1319 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1320 Unescape the conf keys to get the real account names.
1322 For instance, previously the is-default radio button in the accounts
1323 list was not checked for any accounts at first. This fixes that,
1324 and might fix several similar bugs.
1326 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1328 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1329 Removed some debug printfs.
1331 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1333 Modest on-disk outbox directories are now here, for instance:
1334 $HOME/.modest/outboxes/<account-id-1>/outbox
1335 $HOME/.modest/outboxes/<account-id-2>/outbox
1337 $HOME/.modest/local-folders/outbox
1338 so we can have a separate outbox for each account.
1339 But they are shown as one outbox in the GtkTreeView, by using a
1340 TnyMergeFolder in a ModestTnySimpleFolderStore.
1343 * src/modest-tny-simple-folder-store.c:
1344 * src/modest-tny-simple-folder-store.h:
1345 Added ModestTnySimpleFolderStore, used to contain folders from
1346 other folder stores, such as other accounts.
1348 * src/modest-tny-outbox-account.h:
1349 * src/modest-tny-outbox-account.c:
1350 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1351 used for the per-account local outbox folders.
1353 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1354 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1355 only use this (internally) now for the non-outbox local folders.
1357 * src/modest-init.h:
1358 * src/modest-init.c: Added modest_init_one_local_folder(), for
1359 setting up the directory structure for each local folder.
1361 * src/modest-local-folder-info.c:
1362 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1363 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1365 * src/modest-local-folder-info.h:
1366 * src/modest-tny-account-store.c: (on_account_removed),
1367 (on_account_changed), (create_per_account_local_outbox_folders),
1368 (get_server_accounts), (modest_tny_account_store_get_accounts),
1369 (modest_tny_account_store_get_tny_account_by_account),
1370 (modest_tny_folder_store_is_virtual_local_folders):
1372 * src/modest-tny-account.h:
1373 * src/modest-tny-account.c:
1374 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1375 to create an on-disk per-account local outbox folder for each
1377 (create_per_account_local_outbox_folders): Create a local outbox folder
1378 for each transport account.
1379 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1380 for all local folders.
1382 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1383 instead of using g_object_get/set() directly. It is clearer.
1385 (modest_tny_folder_store_get_message_count),
1386 (modest_tny_folder_store_get_local_size
1387 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1388 because we now use these with non-acount folder stores.
1390 (modest_tny_account_get_special_folder),
1391 (modest_tny_account_new_from_server_account),
1392 (modest_tny_account_new_from_account):
1393 (recurse_folders): Adjust to the new outbox system.
1395 * src/modest-tny-folder.h:
1396 * src/modest-tny-folder.c:
1397 (modest_tny_folder_is_local_folder),
1398 (modest_tny_folder_get_local_folder_type),
1399 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1401 * src/widgets/modest-main-window.h:
1402 * src/maemo/modest-main-window.c: (create_details_widget),
1403 (modest_main_window_set_contents_style): Show details for any folder store,
1406 (modest_tny_folder_get_rules):
1407 Remove the const. C does not support constness enough for this.
1409 * src/modest-ui-actions.c:
1410 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1411 make all outboxes appear as one, in the usual local-folders tree node.
1413 (set_active_account_from_tny_account),
1414 (modest_ui_actions_on_folder_selection_changed):
1415 * src/widgets/modest-folder-view.c: (text_cell_data),
1416 (icon_cell_data), (filter_row),
1417 (add_account_folders_to_merged_folder),
1418 (add_account_folders_to_simple_folder_store), (),
1419 (get_cmp_rows_type_pos), (cmp_rows),
1420 (modest_folder_view_set_account_id_of_visible_server_account):
1421 Adjust to the new outbox system, using generic folder stores and folders
1422 in the GtkTreeModel.
1424 2007-05-23 Christian Kellner <ckellner@openismus.com>
1426 * src/modest-mail-operation.c:
1427 (modest_mail_operation_update_account):
1428 Use info->max_size instead of unintialized local var [small
1429 build fix]. (Added TODO to review that change since I don't
1432 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1434 * libmodest-dbus-client/libmodest-dbus-client.c:
1435 (libmodest_dbus_client_compose_mail): function added
1436 * src/dbus_api/modest-dbus-api.h:
1437 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1438 (on_compose_mail): Implementation of the SendAsMail functionality
1440 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1442 * src/modest-account-mgr.c:
1443 (modest_account_mgr_add_server_account): Set the secure-connection
1444 conf key for transport accounts as well as store accounts. I don't know
1445 why the if was there. For instance, this makes sure that we use SSL
1446 for the gmail preset from the easysetup wizard.
1448 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1450 * src/gnome/modest-main-window.c:
1451 (on_account_store_connecting_finished), (connect_signals):
1452 * src/maemo/modest-main-window.c:
1453 (on_account_store_connecting_finished), (connect_signals),
1454 (modest_main_window_new):
1455 Handle TnyAccountStore::connecting-finished instead of
1456 TnyDevice::connection-changed, because we cannot actually perform
1457 operations on accounts until TnyAccountStore has itself responded to
1458 the TnyDevice::connection-changed signal. This prevents a GError from
1460 Do not try to update at startup, because we (at least on scratchbox)
1461 already do an update at startup when the device goes online.
1462 This prevents a GError from tinymail.
1463 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1464 Added TODO about stopping simultaneous operations.
1466 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1468 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1469 * src/modest-mail-operation-queue.c:
1470 (modest_mail_operation_queue_remove):
1471 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1472 about where they happened.
1474 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1476 * src/modest-ui-actions.c:
1477 (modest_ui_actions_on_password_requested): Make sure that the remember
1478 output parameter is always TRUE.
1480 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1482 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1483 Show a OK/Cancel dialog if the error is a question, though we still do not
1484 know anything more about what we are asking the user.
1485 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1486 Fix an uninitialized variable (helper). This is a logic error, however.
1488 2007-05-21 Christian Kellner <ckellner@openismus.com>
1490 * src/modest-search.h:
1491 Correct bit shifting in the ModestSearchFlags enum.
1493 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1495 * src/modest-tny-account.c:
1496 (modest_tny_account_new_from_server_account): Do not use the lsub and
1497 check-all hard-coded IMAP options when using POP.
1499 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1501 * src/modest-tny-account.c:
1502 (modest_tny_account_new_from_server_account):
1503 Use NULL for the secure-auth method for POP when Password auth has been
1504 specified by the user, as we already do for IMAP. "auth=Login" causes
1505 an error from camel or the server.
1507 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1509 * src/maemo/modest-account-settings-dialog.c:
1510 (create_page_account_details),
1511 (modest_account_settings_dialog_set_account_name):
1512 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1513 for the leave-on-server checkbox, rathr than just the checkbox, when
1514 the protocol is not POP.
1516 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1518 * src/widgets/modest-account-view.c:
1519 * src/widgets/modest-account-view.h:
1520 Added modest_account_view_select_account() which will be useful later
1521 to asynchronously re-select the edited account.
1523 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1525 * src/maemo/modest-account-settings-dialog.c:
1526 (modest_account_settings_dialog_set_account_name):
1527 Automatically choose the port numbers based on the secure authentication
1528 methods, if they have not been chosen before.
1529 This fixes projects.maemo.org bug NB#56273 .
1531 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1533 * src/maemo/modest-main-window-ui.h:
1534 * src/modest-ui-actions.c:
1535 * src/modest-ui-actions.h:
1536 Connect the Tools/SMTP Servers menu item to
1537 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1538 SMTP servers dialog, as in the UI specification and saves changes when it
1539 is closed. This fixed projects.maemo.org bug NB#56305 .
1541 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1543 * src/maemo/modest-connection-specific-smtp-window.c:
1544 (modest_connection_specific_smtp_window_init):
1545 Use gtk_window_set_default_size() to make this window big enough, so
1546 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1548 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1551 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1552 (modest_connection_specific_smtp_edit_window_init),
1553 Do not try to connect to a combobox signal before the combobox exists.
1554 This fixes the cras in projects.maemo.org bug NB#56288 .
1555 (modest_connection_specific_smtp_edit_window_get_settings):
1556 Remove the server_account_name parameter which was being checked for NULL
1557 though it was not used.
1559 * src/maemo/modest-connection-specific-smtp-window.c:
1560 (modest_connection_specific_smtp_window_fill_with_connections),
1561 (on_button_edit), (modest_connection_specific_smtp_window_init):
1562 Correct the number of treemodel columns to prevent a warning.
1563 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1564 libconic does not work.
1566 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1568 * src/modest-tny-account.c:
1569 (modest_tny_account_new_from_server_account):
1570 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1571 SMTP when "None" was chosen by the user. However, with my SMTP server that
1572 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1575 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1578 to explain the memory management issue with the ID in the ModestPair.
1580 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1581 (add_sending_page), (modest_account_assistant_finalize):
1582 * src/gnome/modest-gnome-global-settings-dialog.c:
1583 (create_updating_page), (create_composing_page):
1584 * src/gnome/modest-msg-edit-window.c: (get_transports),
1585 (init_window), (modest_msg_edit_window_finalize),
1586 (modest_msg_edit_window_get_msg_data):
1587 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1588 * src/gnome/modest-transport-widget.c:
1589 (modest_transport_widget_finalize), (smtp_configuration):
1590 * src/maemo/modest-maemo-global-settings-dialog.c:
1591 (create_updating_page), (create_composing_page):
1592 * src/maemo/modest-msg-edit-window.c: (get_transports),
1593 (init_window), (modest_msg_edit_window_finalize),
1594 (modest_msg_edit_window_get_msg_data),
1595 (modest_msg_edit_window_free_msg_data):
1596 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1597 (modest_store_widget_finalize):
1598 * src/maemo/modest-transport-widget.c:
1599 (modest_transport_widget_finalize), (smtp_configuration):
1600 * src/modest-main.c: (send_mail):
1601 * src/widgets/modest-combo-box.h:
1602 * src/widgets/modest-global-settings-dialog-priv.h:
1603 * src/widgets/modest-global-settings-dialog.c:
1604 (modest_global_settings_dialog_finalize):
1605 * src/widgets/modest-msg-edit-window.h:
1606 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1607 as long as the combo box, to prevent use of freed memory for the ID.
1609 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1611 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1612 get_accounts(), to make this clearer. Do not check for the enabled gconf
1613 key, because we do not use this for server accounts (at least, not yet).
1614 This allows us to send email again.
1616 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/modest-platform.c:
1619 (on_modest_conf_update_interval_changed), (modest_platform_init):
1620 Only respond to this particular key change. All these strcmp()s cannot be
1623 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1625 * src/maemo/modest-maemo-global-settings-dialog.c:
1626 (current_connection): Prevent a crash in scratchbox when
1627 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1628 * src/maemo/modest-platform.c:
1629 (on_modest_conf_update_interval_changed), (modest_platform_init):
1630 Get the update interval from gconf and reset it when the gconf key changes.
1632 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1634 * src/modest-protocol-info.c:
1635 * src/modest-protocol-info.h: Adde enum-specific get functions,
1636 instead of using a ModestProtocolType enum parameter.
1638 * src/gnome/modest-account-assistant.c:
1639 * src/gnome/modest-store-widget.c:
1640 * src/gnome/modest-store-widget.h:
1641 * src/gnome/modest-transport-widget.c:
1642 * src/gnome/modest-transport-widget.h:
1643 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1644 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1645 * src/maemo/easysetup/modest-easysetup-wizard.c:
1646 * src/maemo/modest-account-settings-dialog.c:
1647 * src/maemo/modest-account-settings-dialog.h:
1648 * src/maemo/modest-store-widget.c:
1649 * src/maemo/modest-store-widget.h:
1650 * src/maemo/modest-transport-widget.c:
1651 * src/maemo/modest-transport-widget.h:
1652 * src/modest-account-mgr-helpers.c:
1653 * src/modest-account-mgr-helpers.h:
1654 * src/modest-account-mgr.c:
1655 * src/modest-account-mgr.h:
1656 * src/modest-tny-account.c:
1657 * src/modest-tny-folder.c:
1658 * src/widgets/modest-account-view.c:
1659 * src/widgets/modest-retrieve-combo-box.c:
1660 * src/widgets/modest-retrieve-combo-box.h:
1661 * src/widgets/modest-secureauth-combo-box.c:
1662 * src/widgets/modest-serversecurity-combo-box.c:
1663 * src/widgets/modest-serversecurity-combo-box.h:
1664 * tests/check_account-mgr.c:
1665 Use the specific functions, and use the re-renamed enum values for GNOME too.
1667 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1669 * src/modest-pair.h:
1670 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1671 so we can get the second based on the first.
1673 * src/maemo/modest-account-settings-dialog.h:
1674 * src/maemo/modest-account-settings-dialog.c:
1675 Added get_supported_secure_authentication_methods(), though it is mostly
1676 commented-out for now until the necessary API is committed to tinymail.
1677 (modest_account_settings_dialog_set_account_name),
1678 (save_configuration): Request the supported authentication methods from the
1679 server, so we can choose a working method.
1681 * src/modest-tny-account-store.h:
1682 * src/modest-tny-account-store.c:
1683 (modest_tny_account_store_get_session): Rename from
1684 tny_account_store_get_session().
1686 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1688 * src/modest-protocol-info.h: Split the ModestProtocol enum
1689 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1690 There was no need to have these unrelated values in one enum.
1692 * src/: many files: Adapted to changed enum. This makes the code a bit
1693 clearer, and the compiler could catch some errors.
1695 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1697 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1698 Show the detailed internal camel error message when an error happens
1699 during the configuration, so that our testers can give us more clues.
1700 For instance, in projects.maemo.org bug NB#56910 .
1702 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1704 * src/modest-tny-account.c:
1705 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1706 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1708 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1710 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1711 * src/maemo/modest-account-settings-dialog.c:
1712 (modest_account_settings_dialog_set_account_name),
1713 (save_configuration): For the incoming secure authentication checkbox,
1714 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1715 the UI specification. PLAIN does not seem to be supported for most IMAP
1716 servers anyway, and I am not sure what it would mean.
1717 However, we probably need to discover which of the secure-authentication
1718 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1719 * src/modest-account-mgr-helpers.c:
1720 (modest_account_mgr_get_server_account_data):
1722 * src/modest-tny-account.c:
1723 (modest_tny_account_new_from_server_account):
1724 Use tny_account_set_mech() to set secure-authentication methods,
1725 with some special-casing for IMAP, based on my observations of how
1728 * src/modest-account-mgr-helpers.h:
1729 * src/modest-account-mgr.c:
1730 * src/modest-defs.h: Comment that the URI is only used for local folders.
1732 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1734 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1735 parameter const, just to be neat.
1736 * src/modest-text-utils.c: (modest_text_utils_inline):
1737 End g_strconcat() with NULL, as its documentation says. This is almost
1738 certainly the cause of my crash at startup on the device. Interestingly,
1739 valgrind doesn't tell us about these errors.
1741 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1743 * scripts/build-packages: Added more precise comments about how to use
1744 this script, though I still get this error:
1745 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1746 error building tinymail
1748 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1750 * src/maemo/modest-main-window.c: (on_account_update):
1751 Very slight cleanup, hoping to make it simpler to discover what causes
1752 a crash here sometimes.
1754 * src/modest-tny-account.c:
1755 (modest_tny_account_new_from_server_account): Set the port. Added
1756 comments about the options and a TODO comment because I need to find out
1757 how to specify the secure authentication method.
1759 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1761 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1762 changed CFlags paths form modest to libmodest
1764 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1766 * src/modest-account-mgr-helpers.c:
1767 (modest_account_mgr_get_server_account_data),
1768 (modest_account_mgr_free_server_account_data):
1769 * src/modest-account-mgr-helpers.h:
1770 * src/modest-account-mgr.c:
1771 (modest_account_mgr_add_server_account):
1772 * src/modest-defs.h:
1773 * src/modest-tny-account.c:
1774 (modest_tny_account_new_from_server_account):
1775 Determine the options for tny_camel_account_add_option() here,
1776 based on the settings, rather than storing them directly in gconf.
1778 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1780 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1781 Show a more friendly error dialog now that we expect (from the tinymail
1782 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1784 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1786 * src/maemo/modest-main-window.c: (on_account_update): Check that
1787 account_name is not NULL, to prevent a crash at startup that I am
1788 seeing on the N800. I do wonder why it is NULL.
1790 * src/maemo/easysetup/modest-easysetup-wizard.c:
1791 (create_page_user_details):
1792 * src/maemo/modest-account-settings-dialog.c:
1793 (create_page_user_details), (create_page_outgoing):
1794 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1795 (modest_connection_specific_smtp_edit_window_init):
1796 * src/modest-ui-actions.c:
1797 (modest_ui_actions_on_password_requested):
1798 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1799 might do something useful with the on-screen keyboard.
1801 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1803 * src/maemo/modest-main-window.c: (on_account_update):
1804 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1805 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1807 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-tny-account-store.c: (on_account_changed):
1810 Correct the signature of this signal handler.
1812 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1815 Show a HildonNote instead of a GtkDialog for Maemo.
1817 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1819 * src/widgets/modest-account-view.h:
1820 * src/widgets/modest-account-view.c: (on_account_changed),
1821 (on_account_removed). Added a boolean flag, set/unset by
1822 modest_account_view_block_conf_updates(),
1823 modest_account_view_unblock_conf_updates() to prevent unnecessary
1824 updates, but this is not very useful because the gconf notifications are
1825 so delays (maybe only on Maemo Bora).
1826 So auto-updating is turned off, and these functions do an explicit
1827 update when necessary.
1828 However, something else is still doing too much work when adding/removing
1829 accounts, probably in another part of the application.
1831 * src/maemo/modest-account-view-window.c:
1832 (on_delete_button_clicked), (on_edit_button_clicked),
1833 (on_new_button_clicked): Use the new functions.
1835 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1837 * src/modest-account-mgr-helpers.c:
1838 (modest_account_mgr_set_first_account_as_default):
1839 Sort the list of names alphabetically-by-title, so we choose the first one
1841 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1842 alphabetically by the title.
1844 This fixes projects.maemo.org bug NB#56418 .
1846 * src/modest-account-mgr-priv.c:
1847 (_modest_account_mgr_account_from_key):
1848 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1849 avoid a valgrind error, and possible random behaviour.
1851 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1853 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1854 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1855 tinymail documentation to say that this can be expected.
1856 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1857 pretty, and should not happen, but I would prefer to know when it does.
1859 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1861 * configure.ac: When using the older hildon version, probably on Bora,
1862 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1864 * src/widgets/modest-attachment-view.c:
1865 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1868 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1870 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1871 Implemented the prototype. Can be tested with
1872 tests/dbus_api/test_open_message:
1874 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1876 * src/modest-tny-account-store.c:
1877 (modest_tny_account_store_instance_init), (get_password):
1878 * src/modest-ui-actions.c:
1879 (modest_ui_actions_on_password_requested):
1880 Do not store the password in gconf, because this function is called
1881 for non-remembered passwords. Actually use the cached (in the hash map)
1882 password instead of releasing it.
1883 The password will now not be remembered if it is asked via the protected
1884 password dialog, as per the UI spec.
1886 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1888 * src/modest-defs.h:
1889 * src/modest-account-mgr-helpers.h:
1890 * src/modest-account-mgr-helpers.c:
1891 Added modest_server_account_get_username_has_succeeded(),
1892 modest_server_account_set_username_has_succeeded().
1893 (modest_server_account_set_username),
1894 Reset the has-succeeded flag if the username changes.
1896 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1897 * src/maemo/modest-connection-specific-smtp-window.c:
1898 (modest_connection_specific_smtp_window_save_server_accounts):
1899 Use modest_server_account_set_username() instead of using
1900 modest_conf_set_string() directly, so that the has-succeeded flag is always
1903 * src/modest-ui-actions.c:
1904 (modest_ui_actions_on_password_requested): Dim the username entry if
1905 the username has ever worked, as per the UI spec.
1907 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1909 * src/modest-tny-account-store.c: (get_password):
1910 * src/modest-ui-actions.c:
1911 (modest_ui_actions_on_password_requested):
1912 Allow the username to be changed too, though there is more work to
1913 be done on exactly how this behaves.
1915 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1917 * src/modest-account-mgr-helpers.h:
1918 * src/modest-account-mgr-helpers.c:
1919 Added modest_account_mgr_get_display_name(),
1920 modest_server_account_get_username(),
1921 modest_server_account_set_username(),
1922 modest_server_account_set_password(),
1923 modest_server_account_get_hostname() functions so we do not need to
1924 use the conf API directly.
1926 * src/maemo/modest-main-window.c: (connect_signals):
1927 Actually connect ot the ModestAccountStore::request-password signal,
1928 so that we show the dialog when the password is requested by Tinymail,
1929 for isntance if it is empty.
1931 * src/modest-marshal.list:
1932 * src/modest-tny-account-store.c:
1933 (modest_tny_account_store_class_init), (get_password),
1934 (modest_tny_account_store_alert):
1935 * src/modest-tny-account-store.h:
1936 * src/modest-ui-actions.h:
1937 * src/modest-ui-actions.c:
1938 (modest_ui_actions_on_password_requested):
1939 Change the signal parameters, so it is obvious that we are providing
1940 the non human-readable server name, and receiving both the username
1941 and password, though changing of the username is not yet implemented.
1942 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1943 for the GNOME version.
1945 This should fix the projects.maemo.org bug NB#56209, though it does not
1946 work on Bora, because the gconf_client_get() for the password fails
1947 immediately after we save it with gconf_client_set().
1949 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1952 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1953 caused an undefined symbol error:
1954 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1956 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1958 * src/modest-tny-account-store.c:
1959 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1960 using a GError instead of a string message, so we can translate it in
1963 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1965 * src/maemo/modest-address-book.c:
1966 (modest_address_book_check_names):
1967 * src/maemo/modest-msg-view-window.c:
1968 (modest_msg_view_window_clipboard_owner_change):
1969 * src/modest-init.c: (modest_init_init_ui):
1970 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1971 (update_folders_cb), (modest_mail_operation_update_account):
1972 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1973 (modest_ui_actions_on_msg_attachment_clicked),
1974 (modest_ui_actions_on_msg_recpt_activated):
1975 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1976 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1977 (modest_msg_view_search_next):
1978 * src/widgets/modest-recpt-editor.c:
1979 (modest_recpt_editor_on_button_release_event),
1980 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1981 g_message(). At this point we should only be seeing interesting errors on
1982 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1984 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1986 (modest_wizard_dialog_force_title_update):
1987 * src/maemo/easysetup/modest-wizard-dialog.h:
1988 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1989 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1990 can update the title when appropriate. Otherwise the title is wrong if the
1991 pages are added after adding the notebook to the dialog.
1992 This must be a problem in HildonWizardDialog too.
1993 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1995 * src/maemo/easysetup/modest-easysetup-wizard.c:
1996 (create_subsequent_customsetup_pages),
1997 (create_subsequent_easysetup_pages):
1998 Call modest_wizard_dialog_force_title_update() so that the title is
1999 correct even with GTK+ < 2.10.
2000 This fixes projects.maemo.org bug NB#56145 .
2002 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2004 * src/maemo/modest-platform.c:
2005 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2006 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2009 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2011 * src/widgets/modest-window.h:
2012 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2013 and modest_window_save_state(), which invokes it.
2015 * src/widgets/modest-window-mgr.h:
2016 * src/widgets/modest-window-mgr.c:
2017 Added modest_window_mgr_save_state_for_all_windows(), which calls
2018 the save_state vfunc on all registered windows, if implemented.
2020 * src/gnome/modest-msg-edit-window.c:
2021 * src/gnome/modest-msg-view-window.c:
2022 * src/maemo/modest-msg-edit-window.c:
2023 * src/maemo/modest-msg-view-window.c:
2024 * src/maemo/modest-main-window.c:
2025 Specify the existing save_settings functions as implementations of
2026 ModestWindow::save_state_func().
2028 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2029 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2030 enabling hibernation, for instance.
2032 We may need to do the same thing for restoring settings.
2035 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2037 * src/widgets/modest-window-mgr.c:
2038 * src/widgets/modest-window-mgr.h:
2039 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2040 modest_window_mgr_get_hibernation_is_prevented().
2042 * src/maemo/modest-main-window.c:
2043 (on_hildon_program_is_topmost_notify): Prevent hibernation
2044 (possible when the application goes to the background in the WM),
2045 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2047 * src/maemo/easysetup/modest-easysetup-wizard.c:
2048 (modest_easysetup_wizard_dialog_init):
2049 * src/maemo/modest-account-settings-dialog.c:
2050 (modest_account_settings_dialog_init):
2051 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2052 (modest_connection_specific_smtp_edit_window_init):
2053 * src/maemo/modest-connection-specific-smtp-window.c:
2054 (modest_connection_specific_smtp_window_init):
2055 * src/maemo/modest-signature-editor-dialog.c:
2056 (modest_signature_editor_dialog_init):
2057 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2058 prevent hibernation while any of these account settings dialogs are open.
2060 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2062 * src/maemo/Makefile.am:
2063 * src/maemo/modest-osso-state-saving.c:
2064 * src/maemo/modest-osso-state-saving.h: Added
2065 modest_osso_load_state() and modest_osso_save_state() though they do
2066 nothing now. They should iterate through all the open windows and load/save
2068 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2069 save state when closing.
2071 * src/maemo/modest-main-window.c:
2072 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2073 Add a notification handler for the HildonProgram::is-topmost property,
2074 so we can allow hibernation when the application goes into the background.
2075 But we still need to detect when the accounts setup windows are open so
2076 we can stop hibernation when they are open.
2077 To do this, I also added the main window the HildonProgram. This might have
2078 other side-effects/benefits, and should maybe be done for other windows.
2080 * src/maemo/modest-osso-autosave-callbacks.h:
2081 * src/maemo/modest-osso-autosave-callbacks.c:
2082 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2083 though it does not do anything yet, and we might never need this to do
2084 anything. For instance, we already save drafts.
2086 * src/maemo/modest-platform.c: (modest_platform_init):
2087 Specify the libosso auto-save callback.
2089 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2091 * src/maemo/modest-platform.c:
2092 (modest_platform_set_update_interval):
2093 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2094 aparently stays valid between application instances, so we can use this
2095 to remove and reset it later. According to a maemo-developers email from
2098 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2100 * configure.ac: Depend on libalarm for Maemo.
2102 * src/dbus_api/modest-dbus-api.h:
2103 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2104 (on_send_receive), (modest_dbus_req_handler):
2105 Handle a SEND_RECEIVE D-Bus method.
2107 * libmodest-dbus-client/libmodest-dbus-client.c:
2108 (libmodest_dbus_client_send_and_receive):
2109 * libmodest-dbus-client/libmodest-dbus-client.h:
2110 Add C convenience functions for calling the new D-Bus method.
2112 * src/modest-platform.h:
2113 * src/gnome/modest-platform.c:
2114 * src/maemo/modest-platform.c:
2115 Added modest_platform_set_update_interval(), which uses the
2116 alarmd API on Maemo.
2117 (modest_platform_init),
2118 Call modest_platform_set_update_interval(), using a hard-coded
2119 interval for now (until the global settings dialog is implemented),
2120 though I am not sure that this makes sense yet.
2122 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2124 * src/dbus_api/modest-dbus-callbacks.c:
2125 (modest_osso_cb_hw_state_handler):
2126 * src/dbus_api/modest-dbus-callbacks.h:
2127 * src/maemo/modest-platform.c: (modest_platform_init):
2128 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2129 in case this has some effect on the ability for Maemo to ping the
2132 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2134 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2135 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2136 warning. It is probably a logic error, but I need to fix the build.
2138 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2140 * src/modest-account-mgr.h:
2141 * src/modest-account-mgr.c:
2142 (modest_account_mgr_account_names): Add a gboolean enabled_only
2143 parameter, so we can get lists of onlt the enabled accounts.
2145 (modest_account_mgr_add_account),,
2146 (modest_account_mgr_account_with_display_name_exists):
2147 * src/maemo/modest-msg-edit-window.c: (get_transports):
2148 * src/modest-account-mgr-helpers.c:
2149 (modest_account_mgr_set_first_account_as_default):
2150 * src/modest-init.c: (init_default_account_maybe):
2151 * src/modest-tny-account-store.c: (get_accounts):
2152 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2153 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2154 * tests/check_account-mgr.c: (START_TEST):
2155 Provide the extra parameter, as appropriate.
2157 * src/widgets/modest-account-view.c: (update_account_view):
2158 Do not show disabled accounts (meaning that there is no way to
2159 enable/disable accounts in the UI (the feature is not in our UI
2160 specification), so we can use this internally only to mark unfinished
2161 or temporary account data.
2163 * src/maemo/easysetup/modest-easysetup-wizard.c:
2164 (create_account): Add boolean enable parameter, so we can specify FALSE
2165 to create the temporary account.
2166 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2167 (on_before_next): When finishing, when there is a temporary account, just
2169 Also, use a timeout to delay the showing of the dialog until gconf is likely
2170 to return correct information, due to a maemo gconf bug that is fixed in
2171 osso 1.1, but not yet in Bora.
2172 However, the dialog stays on screen after it is destroyed.
2174 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2175 for invalid data when cancelling. Use a hildon note instead of a dialog
2176 to complain about invalid data. Do not show the account-saved note if the
2177 account is disabled (a temporary account that will not really be saved for use
2180 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2182 * src/modest-account-mgr-helpers.h:
2183 * src/modest-account-mgr-helpers.c:
2184 Added modest_account_mgr_unset_default_account(),
2185 Added modest_account_mgr_set_first_account_as_default().
2187 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2188 If it was the default account, unset the default account name.
2190 * src/maemo/modest-account-view-window.c:
2191 (on_delete_button_clicked): If it was the default account,
2192 set the first remaining account as the default instead.
2194 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2195 a NULL account or a NULL default account, to prevent a crash. This should
2196 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2199 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2201 * src/widgets/modest-recpt-editor.c:
2202 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2203 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2204 TODO comment for this. This fixes the build.
2206 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2207 be the best place for it. This will in future update all auto-update accounts,
2208 rather than just the current/default account, when that gconf key exists.
2209 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2210 if there are no accounts, before calling do_send_receive().
2211 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2213 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2214 * src/maemo/modest-main-window-ui.h:
2215 * src/maemo/modest-main-window.c: (on_connection_changed),
2216 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2217 directly, becaue the signal handler does more.
2219 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2221 * src/modest-account-mgr-helpers.c:
2222 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2223 for the case that the account does not exist.
2225 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2226 (equivalent to the modest account name) rather than the tinymail account name
2227 (equivalent to the modest account title - human readable) to get the account data.
2228 Check for null account data to prevent the crash, and add a TODO comment saying that
2229 this needs fixing because it is using the server account name instead of the account name.
2231 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2233 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2234 * src/maemo/modest-account-settings-dialog.c: (show_error),
2236 Use hildon_note_new_information() for informative and error messages,
2237 which seems to be expected for Maemo applications (no documentation that I know of
2238 says this). I am surprised that there is no distinction between info and error
2241 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2243 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2244 it is easy to find where this is used.
2246 * src/maemo/easysetup/modest-easysetup-wizard.c:
2247 (create_page_welcome), (create_page_account_details),
2248 (create_page_user_details), (create_page_complete_easysetup),
2249 (create_page_custom_incoming), (create_page_custom_outgoing),
2250 (create_page_complete_custom):
2251 * src/maemo/modest-account-settings-dialog.c:
2252 (create_page_account_details), (create_page_user_details),
2253 (create_page_incoming), (create_page_outgoing):
2254 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2256 (modest_connection_specific_smtp_edit_window_init):
2257 * src/maemo/modest-connection-specific-smtp-window.c:
2258 (modest_connection_specific_smtp_window_init):
2259 * src/maemo/modest-signature-editor-dialog.c:
2260 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2261 and scrolling policy as per the Email Application Layout Guide, if I have
2264 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2266 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2267 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2268 which were empty, because these vfuncs have been removed from TnyAccountStore.
2269 This fixes the build.
2271 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2273 * src/maemo/modest-main-window.c:
2274 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2275 showing/hiding it. Added TODO because it probably should not be NULL.
2276 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2277 because unnecessary g_warnings() make degugging difficult.
2279 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2281 * src/maemo/modest-msg-edit-window.c:
2282 (modest_msg_edit_window_select_color),
2283 (modest_msg_edit_window_select_background_color): 2 const corrections and
2284 moving 2 #endifs before closing brackets, to fix the build.
2286 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2288 * src/maemo/easysetup/modest-easysetup-wizard.h:
2289 * src/maemo/easysetup/modest-easysetup-wizard.c:
2290 (modest_easysetup_wizard_dialog_finalize),
2291 (on_button_edit_advanced_settings), (create_page_complete_custom),
2292 (on_response), (create_account):
2293 Implement the Advanced Settings edit button, by saving the account information,
2294 for the Advanded Settings dialog to use directly from gconf, and removing it
2295 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2296 Bug #5533 in the projects.maemo.org bugzilla.
2298 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2300 * src/maemo/modest-msg-view-window.c:
2301 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2302 when opening a message window.
2304 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2306 * src/maemo/easysetup/modest-easysetup-wizard.c:
2307 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2310 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2311 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2312 gconf settings. I probably added more checks than necessary, but that is safer.
2314 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2315 variable to fix the build, but this seems to be used when it is still NULL.
2317 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2319 * src/modest-platform.h:
2320 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2321 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2322 * src/modest-main.c: Implement this function so we can avoid using
2323 maemo-specific API from cross-platform code.
2325 * src/modest-tny-account-store.c:
2326 (get_smtp_specific_transport_account_for_open_connection):
2327 * src/modest-ui-actions.c: (check_for_connection),
2328 (modest_ui_actions_on_item_not_found):
2329 Use modest_platform_connect_and_wait() and put #idefs around other
2330 maemo-specific code, because only maemo currently has a way to
2331 identify connection names.
2333 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2335 * src/modest-tny-account-store.h:
2336 * src/modest-tny-account-store.c:
2337 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2338 the connection-specific SMTP server settings in the configuration.
2340 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2342 * src/maemo/modest-main-window.c: (on_connection_changed),
2344 * src/modest-main.c: (main), (start_ui), (send_mail):
2345 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2346 that is what is intended.
2348 * src/modest-ui-actions.c: (action_send), (action_receive),
2349 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2350 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2351 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2352 SMTP server is used when it is specified.
2354 (modest_ui_actions_on_send_receive):
2355 Check that a connection is open before proceeding.
2356 Receive and then send, instead of vice-versa, as per the specification.
2358 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2360 * src/modest-mail-operation.c:
2361 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2362 though I guess it should be something other than NULL.
2364 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2366 * src/maemo/easysetup/modest-easysetup-wizard.c:
2367 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2368 combo twice, to avoid an g_warning and to make it visible again.
2369 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2370 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2371 (already intended) dereference when detaching, because we then recreate the menu.
2372 But I am not sure why the warning was happening, and it is possible that this is a memory
2375 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2377 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2378 and uri_parse_mailto() utility functions.
2379 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2381 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2383 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2385 * src/dbus_api/modest-dbus-api.h:
2386 * src/dbus_api/modest-dbus-callbacks.c:
2387 Use an idle callback to execute the modest code in the application's own thread.
2388 Remove the helloworld example method.
2389 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2390 parsed, and the open-message method is not implemented because this is not yet implemented in
2392 * libmodest-dbus-client/libmodest-dbus-client.c:
2393 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2394 (libmodest_dbus_client_open_message):
2395 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2397 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2398 body without crashing.
2400 * tests/dbus_api/Makefile.am:
2401 * tests/dbus_api/test_mail_to.c:
2402 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2404 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2406 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2407 Added file to fix the build. Sorry.
2409 * src/dbus_api/Makefile.am:
2410 * src/dbus_api/modest-dbus-api.h:
2411 * src/dbus_api/modest-dbus-callbacks.h:
2412 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2413 (modest_dbus_req_handler):
2414 Put constants in a separate header so it can be reused by the
2415 client library, without duplication
2417 * libmodest-dbus-client/Makefile.am:
2418 * libmodest-dbus-client/libmodest-dbus-client.c:
2419 (libmodest_dbus_client_call_helloworld),
2420 (libmodfest_dbus_client_send_mail),
2421 (libmodfest_dbus_client_mailto),
2422 (libmodfest_dbus_client_open_message):
2423 * libmodest-dbus-client/libmodest-dbus-client.h:
2424 (Partly) Implement a send_mail D-Bus method.
2426 * tests/dbus_api/Makefile.am:
2427 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2428 the send_email D-Bus method.
2430 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2434 * libmodest-dbus-client/Makefile.am:
2435 * libmodest-dbus-client/libmodest-dbus-client.c:
2436 * libmodest-dbus-client/libmodest-dbus-client.h:
2437 * tests/dbus_api/Makefile.am:
2438 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2439 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2441 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2443 * src/maemo/easysetup/modest-easysetup-wizard.c:
2444 (create_page_account_details):
2445 * src/maemo/modest-account-settings-dialog.c:
2446 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2447 widgets, because this might not be the default in future versions of the Maemo GTK+.
2448 However, I can not not get capitalization to work even in a simple test case.
2450 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2452 * src/maemo/easysetup/modest-easysetup-wizard.c:
2453 (create_page_custom_incoming), (create_page_custom_outgoing):
2454 * src/maemo/modest-account-settings-dialog.c:
2455 (create_page_account_details), (create_page_incoming),
2456 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2457 instead of using gtk_check_button_with_label(), so they are aligned like the other
2458 widgets, as per the UI spec.
2460 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2462 * src/maemo/easysetup/modest-easysetup-wizard.c:
2463 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2464 * src/widgets/modest-validating-entry.c:
2465 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2466 Modest prefix instead of an EasySetup prefix.
2468 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2470 * src/widgets/modest-validating-entry.h:
2471 * src/widgets/modest-validating-entry.c: (on_insert_text),
2472 Added easysetup_validating_entry_set_max_func(), used to set a callback
2473 to call when the max number of characters is reached. GtkEntry has a max-length
2474 already but is silent about it.
2476 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2477 (create_page_account_details), (create_page_user_details),
2479 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2480 (create_page_account_details), (create_page_user_details),
2481 (create_page_outgoing):
2482 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2483 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2484 the UI spec, when the user tries to enter more than the max number of characters.
2486 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2488 * src/maemo/easysetup/modest-easysetup-wizard.c:
2489 (create_page_user_details), (create_page_custom_incoming),
2490 (create_page_custom_outgoing):
2491 * src/maemo/modest-account-settings-dialog.c:
2492 (create_page_user_details), (create_page_incoming),
2493 (create_page_outgoing):
2494 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2495 (modest_connection_specific_smtp_edit_window_init):
2496 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2497 not appropriate. Bad Maemo-specific defaults!.
2499 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2501 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2502 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2503 (modest_signature_editor_dialog_set_settings):
2504 Disable the label and textview when the checkbox is disabled, and use the
2505 specified (UI spec) default signature text.
2507 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2510 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2512 * src/modest-defs.h:
2513 * src/modest-account-mgr-helpers.h:
2514 * src/modest-account-mgr-helpers.c:
2515 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2517 * src/maemo/Makefile.am:
2518 * src/maemo/modest-signature-editor-dialog.c:
2519 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2522 * src/maemo/modest-account-settings-dialog.h:
2523 * src/maemo/modest-account-settings-dialog.c:
2524 (modest_account_settings_dialog_finalize), (on_button_signature),
2525 (save_configuration): Use the new dialog when the Edit button is pressed, and
2526 save the changes if necessary, as per the UI spec.
2528 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2530 * src/maemo/Makefile.am:
2531 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2532 based on maemo-develoers email from Dirk.
2534 * src/maemo/easysetup/modest-easysetup-wizard.c:
2535 (create_page_welcome), (create_page_account_details),
2536 (create_page_user_details), (create_page_complete_easysetup),
2537 (create_page_custom_incoming), (create_page_custom_outgoing),
2538 (create_page_complete_custom),
2539 (modest_easysetup_wizard_dialog_init):
2540 * src/maemo/modest-account-settings-dialog.c:
2541 (create_page_account_details), (create_page_user_details),
2542 (create_page_incoming), (create_page_outgoing),
2543 (modest_account_settings_dialog_init):
2544 * src/maemo/modest-connection-specific-smtp-window.c:
2545 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2547 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2549 * src/maemo/easysetup/modest-easysetup-wizard.c:
2550 (create_page_account_details), (create_page_custom_outgoing),
2551 (create_page_complete_custom):
2552 * src/maemo/modest-account-settings-dialog.c:
2553 (create_page_user_details), (create_page_incoming),
2554 (create_page_outgoing):
2555 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2556 (modest_connection_specific_smtp_edit_window_init):
2557 Use the correct (UI spec) port min/max, and use horizontal separators,
2560 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2562 * src/maemo/easysetup/modest-easysetup-wizard.c:
2563 (set_default_custom_servernames):
2564 * src/maemo/modest-account-settings-dialog.c:
2565 (create_page_incoming), (on_combo_outgoing_security_changed),
2566 (on_combo_incoming_security_changed), (create_page_outgoing),
2567 (modest_account_settings_dialog_set_account_name),
2568 (save_configuration):
2569 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2570 (on_combo_security_changed),
2571 (modest_connection_specific_smtp_edit_window_init),
2572 (modest_connection_specific_smtp_edit_window_set_connection),
2573 (modest_connection_specific_smtp_edit_window_get_settings):
2574 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2577 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2580 * src/maemo/easysetup/modest-easysetup-wizard.c:
2581 (create_page_custom_outgoing), (create_page_complete_custom):
2582 * src/maemo/modest-account-settings-dialog.c:
2583 (create_page_user_details), (create_page_outgoing):
2584 * src/maemo/modest-account-view-window.c: (button_box_new):
2585 Use changed logical IDs as per the most recent UI spec:
2586 mcen_bd_emailsetup_edit -> mcen_bd_edit
2587 mcen_bd_emailsetup_delete -> mcen_bd_delete
2588 mcen_bd_emailsetup_close -> mcen_bd_close
2590 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2594 * src/dbus_api/Makefile.am:
2595 * src/dbus_api/modest-dbus-callbacks.c:
2596 * src/dbus_api/modest-dbus-callbacks.h:
2597 * src/maemo/modest-platform.c: (modest_platform_init):
2598 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2600 * tests/Makefile.am:
2601 * tests/dbus_api/Makefile.am:
2602 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2604 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2606 * src/maemo/modest-account-settings-dialog.c:
2607 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2608 Removed unnecessary includes.
2610 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2612 * src/maemo/easysetup/modest-easysetup-wizard.c:
2613 * src/maemo/modest-account-settings-dialog.c:
2614 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2615 * src/widgets/Makefile.am:
2616 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2617 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2618 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2619 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2620 * src/widgets/modest-secureauth-combo-box.c:
2621 * src/widgets/modest-secureauth-combo-box.h:
2622 * src/widgets/modest-serversecurity-combo-box.c:
2623 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2624 made the GObject names more consistent with the rest of the Modest code.
2626 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2628 * src/maemo/easysetup/Makefile.am:
2629 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2630 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2631 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2632 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2633 * src/maemo/easysetup/modest-easysetup-wizard.c:
2634 * src/maemo/easysetup/modest-validating-entry.c:
2635 * src/maemo/easysetup/modest-validating-entry.h:
2636 * src/maemo/modest-account-settings-dialog.c:
2637 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2638 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2639 widgets/ because they are used outside of easysetup too. After checking in,
2640 svn will allow me to rename them too.
2642 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2644 * src/gnome/modest-msg-edit-window.c:
2645 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2646 linker error, to fix the build on the GNOME platform.
2647 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2648 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2649 ifdefed out to avoid a warning.
2651 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2653 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2654 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2655 some alternative for GTK+ 2.6.
2657 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2661 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2662 specified for EmailAccountsDialog in UI spec.
2664 * src/maemo/easysetup/modest-easysetup-wizard.c:
2665 * src/maemo/easysetup/modest-easysetup-wizard.h:
2666 * src/maemo/modest-account-settings-dialog.c:
2667 * src/maemo/modest-account-settings-dialog.h:
2668 Reuse a member window widget for the connection-specific SMTP server accounts,
2669 so we can tell it to create/save the accounts only if we actually save changes.
2671 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2672 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2673 (modest_connection_specific_smtp_edit_window_get_settings):
2674 Return a struct instance for temporarily remembering the entered data.
2676 * src/maemo/modest-connection-specific-smtp-window.h:
2677 * src/maemo/modest-connection-specific-smtp-window.c:
2678 (modest_connection_specific_smtp_window_finalize),
2679 (modest_connection_specific_smtp_window_fill_with_connections),
2681 (modest_connection_specific_smtp_window_save_server_accounts),
2682 (update_model_server_names): Do not actually save data until asked,
2683 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2685 (on_selection_changed),
2686 (modest_connection_specific_smtp_window_init): Disable the edit
2687 button when nothing is selected.
2689 * src/modest-account-mgr-helpers.c:
2690 * src/modest-account-mgr-helpers.h:
2691 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2694 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2696 * src/modest-account-mgr-helpers.h:
2697 * src/modest-account-mgr-helpers.c:
2698 (modest_account_mgr_get_unused_account_name),
2699 (modest_account_mgr_get_unused_account_display_name): Added these
2700 utility functions, to avoid code duplication.
2702 * src/maemo/easysetup/modest-easysetup-wizard.c:
2703 (create_page_account_details), (create_account):
2704 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2705 (on_combo_security_changed),
2706 (modest_connection_specific_smtp_edit_window_init),
2707 (modest_connection_specific_smtp_edit_window_save_settings):
2708 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2709 * src/maemo/modest-connection-specific-smtp-window.c:
2710 (modest_connection_specific_smtp_window_finalize),
2711 (modest_connection_specific_smtp_window_fill_with_connections),
2712 (on_button_edit), (modest_connection_specific_smtp_window_init):
2713 * src/maemo/modest-connection-specific-smtp-window.h:
2714 Implementing saving of connection-specific server accounts.
2716 But I need to refactor this so we can save the data for each
2717 possible connection-specific account and only actually create the server accounts
2718 when the easysetup finished, or the OK button is pressed on the account settings
2721 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2723 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2724 (on_combo_security_changed):
2725 (modest_connection_specific_smtp_edit_window_init):
2726 Auto-fill the port number as in the account settings.
2728 (modest_connection_specific_smtp_edit_window_set_connection):
2729 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2730 * src/maemo/modest-connection-specific-smtp-window.c:
2731 (fill_with_connections), (on_button_edit),
2732 (modest_connection_specific_smtp_window_init):
2733 Turn the edit window into a dialog to simplify the code, and
2734 set a WM hint as in a GtkDialog, because only a popup can be on top of
2735 another window in Maemo, and popups usually have no WM decoration.
2737 * src/modest-defs.h:
2738 * src/modest-account-mgr-helpers.c:
2739 (modest_account_mgr_set_connection_specific_smtp),
2740 (modest_account_mgr_remove_connection_specific_smtp),
2741 (modest_account_mgr_get_connection_specific_smtp):
2742 * src/modest-account-mgr-helpers.h: Some functions to write the
2743 connection-specific SMTP server information. Not yet used.
2746 * src/widgets/modest-folder-view.c: (text_cell_data):
2747 Fix a warning about an uninitialized variable.
2748 (on_configuration_key_changed): Put an #ifdef around the use
2749 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2751 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2753 * src/maemo/modest-account-settings-dialog.h:
2754 * src/maemo/modest-account-settings-dialog.c:
2755 Added connect_for_modified() utility function to mark the new modified boolean.
2757 (create_page_account_details), (create_page_user_details),
2758 (create_page_incoming), (create_page_outgoing), (on_response),
2759 (modest_account_settings_dialog_init),
2760 (modest_account_settings_dialog_set_account_name):
2761 Only warn about unsaved changes when there are actually unsaved changes.
2763 * src/modest-account-mgr-helpers.c:
2764 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2765 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2766 to get the data from there in future.
2768 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2770 * src/modest-defs.h:
2772 * src/modest-account-mgr-helpers.h:
2773 * src/modest-account-mgr-helpers.c:
2774 Store the security account setting in a single conf key instead of using
2775 the options list, so that the list is left for just the to-be-removed camel hack,
2776 and because gconf_client_set_list() is failing for some reason.
2778 * src/modest-account-mgr.c:
2779 (modest_account_mgr_add_server_account):
2780 * src/maemo/modest-account-settings-dialog.c:
2781 (modest_account_settings_dialog_set_account_name),
2782 (save_configuration): Use the renamed functions.
2785 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2787 * src/widgets/Makefile.am:
2788 * src/widgets/modest-limit-retrieve-combo-box.c:
2789 * src/widgets/modest-limit-retrieve-combo-box.h:
2790 * src/widgets/modest-retrieve-combo-box.c:
2791 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2792 the account settings dialog.
2794 * src/modest-defs.h:
2795 * src/modest-account-mgr-helpers.h:
2796 * src/modest-account-mgr-helpers.c:
2797 (modest_server_account_get_option_secure_auth),
2798 (modest_server_account_set_option_secure_auth):
2799 * src/modest-account-mgr.c:
2800 (modest_account_mgr_add_server_account):
2801 Use the existing AUTH_MECH conf key for the secure-auth setting,
2802 instead of putting it in the list options, because this was actually used already.
2804 * src/maemo/modest-account-settings-dialog.c:
2805 (create_page_account_details),
2806 (modest_account_settings_dialog_set_account_name),
2807 (save_configuration):
2808 * src/maemo/modest-account-settings-dialog.h:
2809 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2810 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2812 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2814 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2815 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2816 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2818 * src/modest-defs.h:
2819 * src/maemo/modest-account-settings-dialog.c:
2820 (create_page_incoming), (on_combo_outgoing_security_changed),
2821 (on_combo_incoming_security_changed), (create_page_outgoing),
2822 (modest_account_settings_dialog_set_account_name),
2823 (save_configuration): Load/Save the port number, and change it when the
2824 security combo changes, to suitable defaults.
2826 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2828 * src/modest-account-mgr.c:
2829 (modest_account_mgr_add_server_account): Set the security and secure-auth
2830 options, and add a comment saying that the other camel-specific options should be
2833 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2835 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2837 * src/modest-tny-account-store.c: (account_list_free),
2838 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2839 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2842 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2844 * src/modest-protocol-info.c:
2845 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2846 is required by our UI spec. Maybe something in our implementation will use this eventually.
2847 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2848 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2849 instead of the previous 0 placeholder.
2851 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2852 secure-auth settings.
2853 * src/modest-account-mgr-helpers.h:
2854 * src/modest-account-mgr-helpers.c:
2855 (modest_server_account_data_get_option_secure_auth),
2856 (modest_server_account_set_option_secure_auth),
2857 (modest_server_account_data_get_option_security),
2858 (modest_server_account_set_option_security): Added this API for getting and setting the security
2859 and secure-auth settings.
2861 * src/maemo/modest-account-settings-dialog.h:
2862 * src/maemo/modest-account-settings-dialog.c:
2863 (modest_account_settings_dialog_finalize), (check_data),
2864 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2865 about changing titles.
2866 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2867 (save_configuration): Save the security and secure-auth settings.
2869 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2870 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2872 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2874 * src/modest-defs.h:
2875 * src/modest-account-mgr.c:
2876 (modest_account_mgr_add_server_account):
2877 Added and used defines for the options key and value pair strings,
2878 that are used so far, though they do not seem to correspond to anything in our
2879 UI specs or ModestProtocol enum.
2881 * src/modest-account-mgr-helpers.h:
2882 * src/modest-account-mgr-helpers.c:
2883 (compare_option_strings_for_name),
2884 (modest_server_account_data_get_option_value),
2885 (modest_server_account_data_get_option_bool),
2886 (modest_account_mgr_get_server_account_option):
2887 Added helper functions for parsing the options GSList.
2889 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2891 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2892 display name is based on the supplied account name.
2893 * src/modest-account-mgr.c:
2894 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2895 with an inefficient, but good-enough, implementation.
2897 * src/maemo/easysetup/modest-easysetup-wizard.c:
2898 (create_page_account_details), (on_before_next), (create_account):
2899 Check for existing display names rather than (non-user-visible) account names, and just
2900 create and set a unique account name at the end.
2902 * src/maemo/modest-account-settings-dialog.c:
2903 (modest_account_settings_dialog_init),
2904 (modest_account_settings_dialog_set_account_name),
2905 (create_page_incoming): Show the display name, instead of the account name.
2906 (on_response): Do some (not all) extra checks, as in the UI spec.
2907 (save_configuration): Save the display name if it was changed.
2909 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2911 * po/en_GB.po: Added needed logical ID and translation.
2912 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2913 (init_view): Made the is-default column clicking work.
2915 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2918 * src/maemo/easysetup/Makefile.am:
2919 * src/maemo/easysetup/modest-easysetup-wizard.c:
2920 (modest_easysetup_wizard_dialog_init):
2921 * src/maemo/easysetup/provider-data-test.keyfile:
2922 * src/maemo/easysetup/provider-data.keyfile:
2923 Moved the provider data file to the new modest-providers-data package and used it from there.
2925 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2927 * src/modest-local-folder-info.c:
2928 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2929 N_() was already used on the static strings, but this just marks it for translation without
2930 using the translation.
2932 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2934 * src/maemo/modest-account-settings-dialog.c:
2935 (create_page_incoming),
2936 (modest_account_settings_dialog_set_account_name):
2937 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2938 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2939 I will do this if nobody else gets there first.
2941 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2943 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2944 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2945 save the security stuff.
2947 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2949 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2950 Set the email address and user fullname, which I now see must be
2953 * src/maemo/modest-account-settings-dialog.h:
2954 * src/maemo/modest-account-settings-dialog.c:
2956 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2957 leave-on-server and authentication.
2958 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2961 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2964 * src/maemo/modest-account-settings-dialog.c:
2965 * src/maemo/modest-account-settings-dialog.h:
2966 Most (but not all) of the widgets are now present as specified by the UI spec.
2967 No changes are yet saved, and some details are not properly shown yet.
2969 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2971 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2973 * src/maemo/Makefile.am:
2974 * src/maemo/modest-account-settings-dialog.c:
2975 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2976 an existing account. Doesn't do much yet.
2978 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2979 Open the accounts settings dialog when Edit is clicked.
2981 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2983 * src/maemo/easysetup/Makefile.am:
2984 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2986 * src/maemo/easysetup/modest-easysetup-wizard.c:
2987 (modest_easysetup_wizard_dialog_init):
2988 Try to get the source directory from the build system,
2989 instead of hard-coding "./" into the source code, when opening our local
2990 copies of the configuration files.
2991 But this still fails when opening the wizard from the Accounts window,
2992 maybe because the working directory seems to change at runtime.
2993 So the wizard will fail the second time unless you copy the files into their
2994 proper locations - see the stdout warnings for the paths.
2996 (create_page_account_details),(on_before_next):
2997 Check for existing non-server accounts instead of server accounts,
2998 so the default account name is useful again, and to prevent trying to
3001 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3002 Show the wizard when New is clicked.
3004 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3005 (init_view): Show the column headers, and show the columns that are
3006 specified in the UI specs. However, something in Maemo's GTK+ prevents
3007 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3008 change the default account. This is despite unsetting the special properties.
3010 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3012 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3013 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3014 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3015 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3016 to make that clearer.
3017 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3019 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3021 * src/maemo/modest-account-view-window.c:
3022 (modest_account_view_window_init),
3023 (modest_account_view_window_new):
3024 Use the same buttons as specified in the
3025 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3026 the existing widgets, which never had a chance of working.
3027 Put the ModestAccountView treeview in a scrolled window.
3028 Do not repeat the initialization in both _init() and _new().
3030 * src/widgets/modest-account-view.c: (update_account_view):
3031 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3032 this widget and window shows no accounts.
3034 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3036 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3038 * src/maemo/easysetup/modest-easysetup-wizard.c:
3039 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3040 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3041 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3044 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3045 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3046 accounts exist yet, as in the UI spec.
3048 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3050 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3052 * src/maemo/Makefile.am:
3053 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3054 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3055 New window for editing connection-specific smtp details.
3056 Not fully implemented.
3058 * src/maemo/modest-connection-specific-smtp-window.c:
3059 (modest_connection_specific_smtp_window_finalize) :
3060 unref the tree model.
3061 (on_button_edit): Show the edit window.
3063 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3065 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3068 * src/maemo/Makefile.am:
3069 * src/maemo/modest-connection-specific-smtp-window.c:
3070 * src/maemo/modest-connection-specific-smtp-window.h:
3071 New window for showing the list of connections, for connection-specific
3072 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3073 * src/maemo/easysetup/modest-easysetup-wizard.c:
3074 (create_page_custom_outgoing): Show the new window when the button is clicked.
3076 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3078 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3079 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3080 * src/maemo/modest-msg-edit-window.c:
3081 (modest_msg_edit_window_insert_image):
3082 * src/modest-conf.c: (modest_conf_key_escape):
3083 * src/modest-mail-operation.c:
3084 (modest_mail_operation_send_new_mail):
3085 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3086 (modest_ui_actions_on_new_account):
3087 * src/widgets/modest-attachment-view.c: (update_filename_request):
3088 * src/widgets/modest-mail-header-view.c:
3089 Corrected warnings that were breaking the build, by commenting out unused variables,
3090 and a function, and by including a header.
3092 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3094 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3095 so we can #ifdef around platform-specific code when necessary.
3096 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3097 to allow this to build for the GNOME platform too.
3099 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3101 * src/maemo/easysetup/modest-easysetup-wizard.c:
3102 Added util_increment_name() and used it in create_page_account_details()
3103 to make sure that the default account name is always a new name.
3105 (modest_easysetup_wizard_dialog_init),
3106 (set_default_custom_servernames): Some minor memory management fixes.
3108 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3112 * src/modest-runtime.c: (init_i18n): Restored the translation
3113 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3114 are defined in config.h, and the translations are installed.
3116 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3117 is defined for translation.
3119 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3121 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3123 * src/maemo/easysetup/modest-easysetup-wizard.c:
3124 (modest_easysetup_wizard_dialog_init):
3125 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3126 Use realistic paths (though they should use $prefix generically) to the
3127 mcc_mapping and provider-data.keyfile files which might work when they
3128 are installed by the future version of the operator-wizard package,
3129 and then fallback to paths in our source code, with an explanatory
3132 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3136 * src/maemo/Makefile.am:
3137 * src/maemo/easysetup/: Added files from the previously-exernal
3138 osso-modest-easysetup.
3139 * src/maemo/modest-main-window-ui.h:
3140 * src/modest-ui-actions.c:
3141 * src/modest-ui-actions.h:
3142 Added modest_ui_actions_on_new_account() as a signal handler for the
3143 New Account menu item. It shows the easysetup wizard.
3144 * po/en_GB.po: Added additional needed logical IDs and translations.