1 2007-07-10 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
4 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
5 This allows us to show the server name in the error message, fixing
6 projects.maemo.org bug NB#62904.
7 Also, use the appropriate logical ID message for the account protocol.
9 2007-07-10 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-tny-account-store.c: (on_idle_wrong_password):
12 A compilation fix, though the build wasn't broken for me.
14 2007-07-09 Murray Cumming <murrayc@murrayc.com>
16 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
17 Do not try to unref a NULL folder store, to avoid a runtime warning.
18 This seems to happen sometimes when changing accounts settings.
20 2007-07-09 Murray Cumming <murrayc@murrayc.com>
22 * src/modest-tny-account-store.c:
23 (modest_tny_account_store_instance_init),
24 (modest_tny_account_store_finalize),
25 (on_account_settings_hide), (on_idle_wrong_password):
26 Use a GHashTable to ensure that we only show one account settings
27 dialog per modest account. This avoids us having a dialog open for
28 both the store and transport accounts, or due to repeated get_password()
29 calls that shouldn't happen anyway.
31 2007-07-09 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/modest-maemo-utils.c: (on_hide),
34 (modest_maemo_show_dialog_and_forget): Handle the response, because
35 the window is not even hidden by default.
37 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
38 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
39 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
40 which seems to prevent some modality problems.
42 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
43 Ignore user cancellation errors.
45 * src/modest-account-mgr-helpers.h:
46 * src/modest-account-mgr-helpers.c:
47 Added modest_server_account_get_password() and
48 modest_server_account_get_has_password() to avoid direct use of
51 * src/maemo/modest-account-settings-dialog.h:
52 * src/maemo/modest-account-settings-dialog.c:
53 (modest_account_settings_dialog_init): Store the notebook so we can
55 Added modest_account_settings_dialog_switch_to_user_info().
57 * src/modest-tny-account-store.c:
58 (get_password): When the password in the account settings is wrong (we think),
59 show the relevant page of the account settings dialog, in the mainloop.
60 However, we currently get many of these at once because cancel does not
62 (forget_password): Do not forget the password
63 from the account settings, because this causes side-effects when
64 tinymail seems to call it at strange time, maybe because of how we
65 are cancelling get_password().
66 (modest_tny_account_store_alert): Ignore user cancellations.
68 2007-07-09 Murray Cumming <murrayc@murrayc.com>
70 * src/maemo/modest-maemo-utils.h:
71 * src/maemo/modest-maemo-utils.c:
72 Added modest_maemo_show_information_note_and_forget() for use instead of
73 gtk_dialog_run() when the response is not needed, to avoid an extra
74 mainloop which could cause a hang.
76 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
77 Use the logical IDs for the error message, though they are not
78 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
79 because gtk_dialog_run() caused a hang here (the window did not close).
80 This fixes projects.maemo.org bug NB#62646.
82 2007-07-09 Murray Cumming <murrayc@murrayc.com>
84 * src/modest-account-mgr-helpers.h:
85 * src/modest-account-mgr-helpers.c:
86 Added modest_account_mgr_get_store_protocol().
88 * src/maemo/modest-account-view-window.c:
89 (on_delete_button_clicked): Show different warning text depending on
90 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
91 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
94 2007-07-09 Murray Cumming <murrayc@murrayc.com>
96 * src/maemo/modest-msg-edit-window.c:
97 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
98 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
100 2007-07-07 Armin Burgmeier <armin@openismus.com>
102 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
103 ckdg_ib_maximum_characters_reached from correct package.
105 * src/modest-ui-actions.c: Show an error message when a folder could
106 not be created. Tinymail does not give us specific error codes about
107 what has gone wrong, so we assume that a folder with that name
108 already exists, though there might be other reasons.
110 2007-07-06 Murray Cumming <murrayc@murrayc.com>
112 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
113 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
114 give a more exact error message that can be partly translated.
116 2007-07-05 Murray Cumming <murrayc@murrayc.com>
118 * src/maemo/modest-address-book.c:
119 (select_email_addrs_for_contact): Specify a default window size for the
120 select-email-address dialog, so that it is probably big enough for the
121 title. This should fix projects.maemo.org bug NB#62277.
123 2007-07-05 Murray Cumming <murrayc@murrayc.com>
125 * src/maemo/easysetup/modest-easysetup-wizard.c:
126 (create_page_complete_easysetup): Use
127 gtk_widget_set_size() request to ensure that the text wraps
130 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
132 * src/maemo/easysetup/modest-easysetup-wizard.c:
133 (on_entry_invalid_character), (create_page_account_details),
134 (create_page_user_details):
135 Use new API of ModestValidatingEntry. But for some reason the banner is
136 not shown. I will have to investigate that further.
138 * src/widgets/modest-validating-entry.c: (on_insert_text),
139 (modest_validating_entry_set_func):
140 * src/widgets/modest-validating-entry.h:
141 Added a new callback function to be able to react to prevented
142 characters whitespaces to e.g show a banner.
144 2007-07-05 Armin Burgmeier <armin@openismus.com>
146 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
147 notification of HildonNumberEditor instead of remembering the port
148 number. Thanks to Johannes for pointing this out.
150 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
152 * src/maemo/easysetup/modest-easysetup-wizard.c:
153 Check if there are any user changes before showing a confirmation
154 dialog (projects.maemo.org NB#60946)
156 2007-07-05 Armin Burgmeier <armin@openismus.com>
158 * src/maemo/modest-account-settings-dialog.c: Remember custom port
159 number at the beginning of the dialog and set the modified flag at the
160 end if the port number has changed. This is necessary because
161 HildonNumberEditor does not support notification when the value has
164 2007-07-05 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-ui-actions.c:
167 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
168 a connection before asking anything else. Correct the check for the destination
169 folder so that it succeeds when online.
170 This fixed projects.maemo.org bug NB#61645.
172 2007-07-05 Murray Cumming <murrayc@murrayc.com>
174 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
175 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
176 to fix projects.maemo.org bug NB#62439.
178 2007-07-05 Murray Cumming <murrayc@murrayc.com>
180 * src/modest-tny-account.c: (on_connection_status_changed):
181 Really do not use tny_device_force_offline() here. See the previous comment.
183 2007-07-04 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-tny-account.c: (on_connection_status_changed):
186 Do not use tny_device_force_offline() when tinymail says that something
187 went wrong with the connection. It seems to report this unnecessarily.
189 2007-07-04 Murray Cumming <murrayc@murrayc.com>
191 * src/maemo/modest-connection-specific-smtp-window.c:
192 (modest_connection_specific_smtp_window_init):
193 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
194 does not seem to have any effect in osso 1.1 (though it works in
195 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
197 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
199 * src/maemo/modest-connection-specific-smtp-window.c:
200 Fix UI specification problems with projects.meamo.org NB#60479
202 2007-07-04 Murray Cumming <murrayc@murrayc.com>
204 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
205 clue when this has failed, because the error dialog is not always shown
206 (at least in earlier version).
208 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
209 GError message, because the generic error dialog is not helpful.
211 'This message is not currently available (can't let a new connection go online)'
212 when trying to open an IMAP message.
214 (_modest_ui_actions_open): Offer a connection when some messages would
215 have to be downloaded and we are offline.
217 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
219 * src/widgets/modest-folder-view.c:
220 Don't check for MERGE type anymore as we use the correct type
222 NOTE: For the last two changes you need to update your tinymail copy
223 because of API changes!
225 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
227 * src/modest-tny-local-folders-account.c:
228 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
229 (see projects.maemo.org NB#61580)
231 2007-07-04 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-tny-account.c: (on_connection_status_changed):
234 Commented out the call to modest_platform_connect_and_wait() because this
235 seems to always hang, and I would like to know if this is the only thing
236 that causes a hang when showing the connection dialog.
237 It is not very useful anyway.
239 2007-07-04 Murray Cumming <murrayc@murrayc.com>
241 * src/maemo/modest-msg-view-window.c:
242 (modest_msg_view_window_select_next_message):
244 * src/modest-platform.h:
245 * src/maemo/modest-platform.c:
246 Added modest_platform_connect_and_wait(), which calls
247 tny_maemo_conic_device_connect() always in the main thread, by calling it
248 in an idle handler and waiting for the idle handler to run. It should be
249 in the main thread because it uses GTK+ UI code. It just returns TRUE
250 if the device is already online.
252 There is some nasty code to ensure that subsequent calls to
253 modest_platform_connect_and_wait() just wait for the first one to finish,
254 by checking repeatedly in another idle handler. This is necessary,
255 because other threads (or even the main thread, via another idle handler)
256 can call modest_platform_connect_and_wait() while
257 modest_platform_connect_and_wait() is running.
259 (modest_platform_connect_and_wait_if_network_account),
260 (modest_platform_connect_and_wait_if_network_folderstore):
261 Convenience functions that calls modest_platform_connect_and_wait() if
262 the account or folder might want network access.
264 * src/modest-mail-operation.c:
265 (modest_mail_operation_update_account):
266 * src/modest-ui-actions.c: (download_uncached_messages),
267 (modest_ui_actions_on_rename_folder), (delete_folder),
268 (modest_ui_actions_on_main_window_move_to),
269 (modest_ui_actions_on_msg_view_window_move_to):
270 * src/widgets/modest-folder-view.c:
271 (drag_and_drop_from_folder_view):
272 Offer a connection if we are offline.
274 * src/modest-tny-account.c: (on_connection_status_changed):
275 Document this as only handling errors during network operations in progress,
276 and replace the idle code with a simple call to
277 modest_platform_connect_and_wait(), which does this instead.
279 2007-07-03 Murray Cumming <murrayc@murrayc.com>
281 * src/modest-tny-account.c:
282 (modest_tny_account_get_special_folder): (util_on_idle),
283 Handle the GError so we can see when tny_folder_store_get_folders()
284 fails, as it currently does while something else is connecting.
286 Added util_run_in_main_thread_and_wait()
287 which uses an idlen handler and mainloop to ensure that the function
288 is called in the main thread.
289 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
290 to make sure that we call attempt the connection in the mainloop only,
291 which might solve some hangs.
293 2007-07-03 Murray Cumming <murrayc@murrayc.com>
295 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
296 be found by their display name. This is never useful.
297 * src/modest-tny-account-store.c: (on_account_removed): Find the account
298 by its ID, instead of trying to use its ID as its display name.
300 * src/modest-tny-account-store.h:
301 * src/modest-tny-account.c:
302 (modest_tny_account_get_special_folder): Add a g_warning() when
303 tny_folder_store_get_folders() returns an empty list for the maildir.
305 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
306 Add a g_warning() when this returns NULL, because that it not allowed
309 2007-07-02 Armin Burgmeier <armin@openismus.com>
311 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
312 note when trying to cancel the wizard. This fixes projects.maemo.org
315 2007-07-02 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-tny-account.h:
318 * src/modest-tny-account.c:
319 (modest_tny_account_new_from_server_account),
320 (modest_tny_account_new_from_server_account_name),
321 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
322 because this must now be set before setting the proto. This is usd in
323 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
324 warning in camel_session_get_service() caused by
325 tny_camel_transport_account_prepare().
327 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
330 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
332 * src/maemo/modest-connection-specific-smtp-edit-window.c:
334 (modest_connection_specific_smtp_edit_window_init):
336 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
339 2007-06-29 Murray Cumming <murrayc@murrayc.com>
341 * src/modest-tny-account.c:
342 (modest_tny_account_new_from_server_account):
343 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
344 now uses to request a connection when it needs one, and which it uses
345 to tell us that something is wrong with the connection, so we can force
346 the accounts offline to prevent further problems.
349 * src/modest-init.c: (init_default_settings):
350 * src/modest-mail-operation.c:
351 (modest_mail_operation_update_account):
352 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
353 This should not be necessary anymore. Do not set the conf key that
354 determined this (it was always TRUE and not set anywhere else).
356 * src/modest-ui-actions.h: Remove unused and unimplemented
357 modest_ui_actions_on_online_toggle_toggled().
359 2007-06-29 Murray Cumming <murrayc@murrayc.com
361 * src/maemo/modest-main-window.c: (connect_signals):
362 Don't connect to delete_event twice. Maybe this was harmless.
364 2007-06-29 Murray Cumming <murrayc@murrayc.com
366 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
367 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
368 Debug output to give some more clue when a folder move is not allowed.
370 2007-06-28 Murray Cumming <murrayc@murrayc.com
372 * src/modest-tny-account.c: (on_modest_file_system_info),
373 (modest_tny_account_get_mmc_account_name):
374 Always call the callback, without checking whether the name has changed.
375 * src/widgets/modest-folder-view.c: (strings_are_equal),
376 (on_model_foreach_set_name), (on_get_mmc_account_name),
377 (text_cell_data): Compare the name here, and use the name from
378 the account rather than from the
379 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
380 if the name was changed after the account was added to the model.
381 That's a tinymail bug but not one that I want to fix now.
383 This finally fixes projects.maemo.org bug NB#59301.
385 2007-06-27 Armin Burgmeier <armin@openismus.com>
387 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
390 2007-06-27 Murray Cumming <murrayc@murrayc.com
392 * src/modest-tny-account.h:
393 * src/modest-tny-account.c:
394 Added modest_tny_account_get_mmc_account_name(), to set the memory
395 card name asynchronously for the given account and then notify.
396 (modest_tny_account_new_for_local_folders): Use this new function instead
397 of using hildon_file_system_info_async_new() directly.
399 * src/widgets/modest-folder-view.c: (text_cell_data):
400 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
401 gtk_tree_model_row_changed() when it is available.
403 This should fix projects.maemo.org bug NB#59301.
405 2007-06-27 Murray Cumming <murrayc@murrayc.com
407 * src/modest-mail-operation.c: (update_account_thread),
408 (get_msgs_full_thread): Fix typo failures in the revert
411 2007-06-27 Murray Cumming <murrayc@murrayc.com
413 * src/maemo/modest-maemo-global-settings-dialog.c:
414 (idle_select_default_focus):
415 * src/modest-mail-operation.c: (idle_notify_progress),
416 (idle_notify_progress_once), (set_last_updated_idle),
417 (update_account_thread), (get_msgs_full_thread):
418 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
419 * src/widgets/modest-header-view.c:
420 (idle_notify_headers_count_changed_destroy),
421 (idle_notify_headers_count_changed):
422 Reverted the additions of gdk_threads_enter/leave(), in case this
423 helps with a startup hang on the device.
425 2007-06-26 Armin Burgmeier <armin@openismus.com>
427 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
428 for supported secure authentication methods from server by
429 gtk_dialog_run(), saving CPU time and a potential race condition.
431 2007-06-26 Armin Burgmeier <armin@openismus.com>
433 * src/maemo/modest-maemo-utils.h:
434 * src/maemo/modest-maemo-utils.c: Added a
435 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
436 only error code to tell the calling code when the user canceled the
439 * src/maemo/modest-account-settings-dialog.h:
440 * src/maemo/modest-account-settings-dialog.c:
441 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
442 message if the retrieval of secure authentication methods was canceled
443 by the user. Perform the check before saving anything to configuration
444 to not end up with half-committed configuration changes, do not show
445 a "Saving to configuration failed" note when authentication methods
446 could not be retrieved.
448 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
451 2007-06-26 Murray Cumming <murrayc@murrayc.com>
453 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
454 Only return the first level of folders under accounts, because the
455 osso-global-search UI spec doesn't want the rest.
456 This fixed projects.maemo.org bug NB#61811.
458 2007-06-26 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-tny-account-store.c:
461 * src/modest-tny-account-store.h:
462 Added modest_tny_account_is_memory_card_account().
463 * src/maemo/modest-main-window.c: (create_details_widget):
464 Show the same information items for the memory card as we show for the
465 local-folders, to fix projects.maemo.org bug NB#59307.
467 2007-06-26 Murray Cumming <murrayc@murrayc.com>
469 * src/modest-tny-account-store.c: (get_password):
470 Added some checks for NULL to maybe prevent crashes, though I think
471 it was Philip's last commit that actually prevented the crash here
472 when creating a first new account.
473 But the new account is still not usable (no messages are shown)
474 until a restart of the application.
476 2007-06-26 Murray Cumming <murrayc@murrayc.com>
478 * src/maemo/modest-maemo-global-settings-dialog.c:
479 (idle_select_default_focus):
480 * src/modest-mail-operation.c: (idle_notify_progress),
481 (idle_notify_progress_once), (idle_notify_update_account_queue),
482 (set_last_updated_idle), (update_account_thread),
483 (notify_get_msgs_full), (get_msgs_full_destroyer),
484 (get_msgs_full_thread):
485 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
486 * src/widgets/modest-header-view.c:
487 (idle_notify_headers_count_changed_destroy),
488 (idle_notify_headers_count_changed):
489 Use gdk_threads_enter() and gdk_threads_enter_leave() in
490 all idle handlers, because some other thread could be blocking
491 the GDK lock, so that it can do GUI stuff.
493 2007-06-26 Murray Cumming <murrayc@murrayc.com>
495 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
496 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
497 (on_idle_send_receive), (on_idle_open_default_inbox):
498 * src/maemo/modest-msg-edit-window.c:
499 (modest_msg_edit_window_attach_file_noninteractive):
500 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
501 to prevent a hang. I don't quite understand why these are necessary,
502 beause we should already be in the main loop. I guess something outside
503 of the main loop is taking the lock.
505 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
506 we are really using URIs, and use files that are more likely to exist.
508 2007-06-26 Murray Cumming <murrayc@murrayc.com>
510 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
511 necessary because configure.ac now defines different variables.
513 2007-06-26 Murray Cumming <murrayc@murrayc.com>
515 * libmodest-dbus-client/libmodest-dbus-client.c:
516 * libmodest-dbus-client/libmodest-dbus-client.h:
517 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
518 libmodest_dbus_client_compose_mail() is what things actually use.
520 * src/dbus_api/modest-dbus-api.h:
521 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
522 * tests/dbus_api/Makefile.am:
523 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
526 2007-06-26 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-init.c: (modest_init_local_folders):
529 For memory-card (or other non local-folders) maildir accounts,
530 always create an Archive folder, so that there is somewhere to put
531 messages. This should be less confusing, because the user does not need
532 to guess that the need to create a folder.
534 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
536 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
537 Fixed icon size by using (50, 50) which is the same as defined by
540 2007-06-25 Armin Burgmeier <armin@openismus.com>
542 * src/widgets/modest-window-mgr.c:
544 * configure.ac: Correctly recognize hildon-notify presence and fixed
545 the build without it being installed.
547 2007-06-25 Murray Cumming <murrayc@murrayc.com>
549 * libmodest-dbus-client/libmodest-dbus-client.c:
550 (libmodest_dbus_client_search): Fix the build. Sorry.
551 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
552 (reply_forward_cb): Initialize variables to fix the build.
554 * src/modest-tny-account-store.c:
555 (modest_tny_account_store_get_tny_account_by): Fix the account URI
556 comparison (a silly typo) so that email search results can be opened
557 when there are more than one account.
559 2007-06-25 Murray Cumming <murrayc@murrayc.com>
561 * libmodest-dbus-client/libmodest-dbus-client.c:
562 (libmodest_dbus_client_search),
563 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
564 instead of 1 second, because the search gets folders and messages from
565 the server, which can take a long time. When it times out,
566 osso-global-search will report no results.
568 We need to specify whether we should search only cached information
569 (maybe with a user preference), and the osso-email-search-plugin
570 API should really be improved to allow that option, and to allow results
571 to be delivered asynchronously in batches.
573 2007-06-25 Murray Cumming <murrayc@murrayc.com>
575 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
576 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
577 GTK_ICON_SIZE_DIALOG is probably the wrong size.
579 2007-06-25 Murray Cumming <murrayc@murrayc.com>
581 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
582 that is an empty string. D-Bus seems to give us these instead of NULL.
584 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
586 * src/dbus_api/modest-dbus-callbacks.c:
587 * src/maemo/easysetup/modest-easysetup-wizard.h:
588 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
589 * src/maemo/modest-connection-specific-smtp-edit-window.c:
590 (modest_connection_specific_smtp_edit_window_init):
591 * src/maemo/modest-maemo-global-settings-dialog.c:
593 * src/maemo/modest-maemo-utils.c:
594 (modest_maemo_utils_setup_images_filechooser):
595 * src/maemo/modest-main-window.c: (create_details_widget):
596 * src/maemo/modest-msg-edit-window.c:
597 (modest_msg_edit_window_attach_file_noninteractive),
598 (modest_msg_edit_window_color_button_change),
599 (modest_msg_edit_window_set_zoom):
600 * src/modest-mail-operation.c: (update_account_thread):
601 * src/modest-tny-account-store.c:
602 * src/modest-tny-account.c:
603 * src/widgets/modest-global-settings-dialog.c:
604 * src/widgets/modest-window.h:
608 2007-06-25 Murray Cumming <murrayc@murrayc.com>
610 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
611 * src/modest-search.c: (modest_search_folder),
612 (modest_search_all_accounts): Actually search only in the specified folder,
613 doing a simple match on the folder ID.
614 * src/modest-search.h: Added a folder field to the ModestSearch struct,
615 and added some documentation.
617 2007-06-22 Armin Burgmeier <armin@openismus.com>
619 * src/maemo/modest-maemo-utils.h:
620 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
621 modest_maemo_utils_get_supported_secure_authentication_methods.
623 * src/maemo/easysetup/modest-easysetup-wizard.c:
624 * src/maemo/modest-account-settings-dialog.c: Show correct error if
625 one occured, not just "Server does not support secure authentication".
627 2007-06-22 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-tny-account-store.c: (get_password):
630 Restored the call to tny_account_set_user() because Philip seems to have
631 stopped this from crashing (by not using the freed string). It still does
632 not work, but now we can test it.
634 2007-06-22 Murray Cumming <murrayc@murrayc.com>
636 * src/maemo/modest-msg-edit-window.c: (init_window):
637 Comment out use of an uninitialzed GtkScrolledWindow variable,
638 to fix the build and stop a crash. Yet again.
640 2007-06-22 Murray Cumming <murrayc@murrayc.com>
642 * src/modest-tny-account-store.c: (get_password):
643 Remove the call to tny_account_set_user() because this actually crashes.
644 As mentioned in the last commit, it is known to not work anyway.
646 2007-06-22 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-tny-account-store.c: (get_password):
649 Use tny_account_set_username() to tell tinymail that the username might
650 have changed too. But tinymail ignores this: see projects.maemo.org
652 * src/modest-ui-actions.c:
653 (modest_ui_actions_on_password_requested): Remove the useless attempt to
654 reset the connection when changing the username, and improve the comments.
655 Save the changed username to gconf at least, so it is used when Modest is
658 2007-06-21 Murray Cumming <murrayc@murrayc.com>
660 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
661 Do not use a query, so that we get all folders, including for POP and
662 local-folders. They work as search criteria too.
663 This fixes projects.maemo.org bug NB#57740.
665 2007-06-21 Murray Cumming <murrayc@murrayc.com>
667 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
668 Comment out the use of hildon_notification_set_sound() because it is
669 not declared, to fix the build. Warnings are serious, people.
671 2007-06-21 Armin Burgmeier <armin@openismus.com>
673 * src/maemo/modest-maemo-utils.h:
674 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
675 modest_maemo_utils_get_supported_secure_authentication_methods()
676 to query authentication methods for a specific user. This should fix
677 projects.maemo.org bug NB#61369.
679 * src/maemo/easysetup/modest-easysetup-wizard.c:
680 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
683 2007-06-21 Murray Cumming <murrayc@murrayc.com>
685 * libmodest-dbus-client/libmodest-dbus-client.h:
686 * libmodest-dbus-client/libmodest-dbus-client.c:
687 (modest_dbus_message_iter_get_search_hit),
688 (libmodest_dbus_client_search):
689 Reorganised and commented this.
690 Removed modest_search_hit_free() from the public API because it
693 Added libmodest_dbus_client_get_folders() and
694 modest_folder_result_list_free().
696 * src/dbus_api/modest-dbus-api.h:
697 * src/dbus_api/modest-dbus-callbacks.c:
698 (modest_dbus_req_filter): Commented. Moved most code to
699 on_dbus_method_search() and added on_dbus_method_get_folders().
701 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
702 of the extra D-Bus handler.
704 * tests/dbus_api/Makefile.am:
705 * tests/dbus_api/test_get_folders.c: New test for
706 libmodest_dbus_client_get_folders(). This seems to return an empty list
707 at the moment. That could be the same error that causes the message list
708 to be empty sometimes.
709 This should help with projects.maemo.org bug NB#57740.
711 2007-06-21 Armin Burgmeier <armin@openismus.com>
713 * src/modest-mail-operation.c: Do not call
714 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
715 notify the operation's end after having set the status to CANCELED for
716 the operation queue to listen on. This fixes a deadlock when there
717 were mail operations in the queue during its finalization.
719 * src/modest-singletons.c: Reordered uninitialization of the account
720 manager to happen after the mail operation queue was uninitialized
721 because the mail operation's in the queue might still try to access
722 the account manager (see modest_mail_operation_notify_end()). This
723 fixes a potential crash when terminating the application.
725 2007-06-21 Murray Cumming <murrayc@murrayc.com>
727 * src/modest-search.c:
728 (search_mime_part_and_child_parts): Moved some code here so we
729 can search recursively in child folders.
730 (modest_search_folder): Search in the message as a mime part, instead
731 of just its child mime parts.
732 (read_chunk), (search_mime_part_ogs):
733 Check how many bytes were read, to prevent an endless loop.
734 Searching in message bodies now works. This finishes the fix for
735 projects.maemo.org bug NB#61007.
737 2007-06-20 Murray Cumming <murrayc@murrayc.com>
739 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
740 Add a g_warning when the item is not a folder.
742 * src/modest-ui-dimming-rules.c:
743 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
744 when selected item is not a folder (for instance, an account), because
745 the UI spec only talks about folders.
746 I am not sure what the UI spec wants, so this might not totally fix
747 projects.maemo.org bug NB#60794.
749 2007-06-20 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
752 (load_from_file): Sort the list. The unsorted list would be more noticeable
753 in non-English locales.
755 * src/maemo/modest-msg-edit-window.c:
756 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
757 warning and fix the build.
759 * src/maemo/modest-progress-bar-widget.c:
760 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
761 avoid a g_warning, and probably to avoid a crash.
763 2007-06-20 Murray Cumming <murrayc@murrayc.com>
765 * src/modest-search.c: (modest_search_folder): Check for a GError
766 when calling tny_folder_get_headers(), to show that this is not the cause
769 2007-06-20 Murray Cumming <murrayc@murrayc.com>
771 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
772 Actually set the body query instead of the subject query.
774 * src/modest-search.c: (search_mime_part_ogs),
775 (search_mime_part_strcmp): Remove extra space from the text/* regex,
776 which would probably cause it to fail if we got this far.
778 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
779 to simplify the code.
780 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
781 be causing search-in-body to fail.
783 2007-06-20 Murray Cumming <murrayc@murrayc.com>
785 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
787 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
788 Better debug message when the folder cannot be found.
789 This should help with fixing projects.maemo.org bug #61287.
790 * src/modest-search.c: (add_hit): Do not leak the furl string.
792 2007-06-20 Murray Cumming <murrayc@murrayc.com>
794 * src/modest-ui-actions.c:
795 (modest_ui_actions_on_folder_selection_changed):
796 Do not special-case TNY_MERGE_FOLDER here, because
797 modest_tny_folder_get_account() already does that. This fixes
798 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
799 shown when the Outbox was selected).
801 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
803 * libmodest-dbus-client/libmodest-dbus-client.c:
804 (_dbus_iter_get_string_or_null): Initialize the string variable in
805 case this helps with Dirk's crash.
807 2007-06-19 Murray Cumming <murrayc@murrayc.com>
809 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
810 though it is not implemented yet (this function is maybe not even used),
811 to avoid breaking ABI in future.
812 * libmodest-dbus-client/libmodest-dbus-client.c:
813 (get_attachments_string): Moved some code into this generic function.
814 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
815 sends email. It is maybe not used.
816 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
817 (on_send_mail): Use attachments.
819 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
820 * src/maemo/modest-msg-edit-window.c:
821 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
822 a filename before using it, to fix projects.maemo.org bug NB#58233.
824 2007-06-19 Murray Cumming <murrayc@murrayc.com>
826 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
827 Initialize the continue_download variable to fix the build, and probably
828 to fix randome behaviour.
830 2007-06-18 Armin Burgmeier <armin@openismus.com>
832 * src/modest-tny-send-queue.h:
833 * src/modest-tny-send-queue.c: Keep track of the status of messages in
834 the queue so we can later show it in the UI. Replaced
835 modest_tny_send_queue_msg_is_being_sent() by
836 modest_tny_send_queue_get_msg_status().
838 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
840 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
841 gpointer. This probably was not harmful, but just to be sure.
843 2007-06-18 Murray Cumming <murrayc@murrayc.com>
845 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
846 Fix the build, but leave the function broken on Bora, because
847 hildon_uri_action_get_service() does not exist.
848 osso_uri_action_get_service() does not exist either, it seems.
850 2007-06-18 Murray Cumming <murrayc@murrayc.com>
852 * src/modest-tny-account.c:
853 (modest_tny_account_new_from_server_account):
854 Uncommented the url debug output again, because it is useful for
855 debugging, as I said in the comment.
857 2007-06-18 Murray Cumming <murrayc@murrayc.com>
859 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
861 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
862 for Mameo Bora, to fix the build.
864 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
867 Fixed build with hildon < 0.99
869 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
870 Check if the selected account is busy instead of checking all accounts
872 * src/modest-account-mgr-priv.h:
873 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
874 (modest_account_mgr_init), (compare_account_name),
875 (modest_account_mgr_set_account_busy),
876 (modest_account_mgr_account_is_busy):
877 * src/modest-account-mgr.h:
878 Added busy information to the account manager. It possible to
879 set an account to busy or not busy now.
881 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
882 (modest_mail_operation_update_account),
883 (modest_mail_operation_notify_end):
884 Set the account to busy/not busy depending on the operation state.
886 * src/widgets/modest-account-view.c:
887 (modest_account_view_finalize), (get_last_updated_string),
888 (update_account_view), (on_account_busy_changed), (init_view):
889 Show string "Refreshing..." if the account is currently busy.
891 All this fixes projects.maemo.org bug NB#59711
893 2007-06-14 Armin Burgmeier <armin@openismus.com>
895 * src/widgets/modest-attachments-view.h:
896 * src/widgets/modest-attachments-view.c: Added
897 modest_attachments_view_has_attachments() and fixed coordinate
898 transformation in get_att_view_at_coords(). This fixes attachment
901 * src/widgets/modest-msg-view.c: Make use of
902 modest_attachments_view_has_attachments() to decide whether to show
903 attachments in the header.
905 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
907 * src/maemo/modest-connection-specific-smtp-edit-window.c:
908 (on_change), (on_combo_security_changed),
909 (modest_connection_specific_smtp_edit_window_init),
910 (modest_connection_specific_smtp_edit_window_set_connection),
911 (modest_connection_specific_smtp_edit_window_is_dirty):
912 * src/maemo/modest-connection-specific-smtp-edit-window.h:
913 * src/maemo/modest-connection-specific-smtp-window.c:
916 Show an comfirmation dialog for the smpt-edit-window if there are
917 unsaved changes and the user hits cancel.
918 (projects.maemo.org bug NB#60479)
920 2007-06-14 Armin Burgmeier <armin@openismus.com>
922 * src/maemo/easysetup/modest-easysetup-wizard.c:
923 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
924 address" info in banner instead of node, and select all the text as
925 per UI spec. This fixes projects.maemo.org bug NB#60550.
927 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
929 reviewed by: <delete if not using a buddy>
931 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
932 * src/modest-ui-actions.c: (folder_refreshed_cb):
934 2007-06-14 Murray Cumming <murrayc@murrayc.com>
936 * src/widgets/modest-folder-view.c: (filter_row):
937 Explictly filter out the per-account outbox accounts. I don't know why
938 these only sometimes show up, but now they should never show up in the UI.
939 This should fix projects.maemo.org bug NB#60160.
941 2007-06-14 Murray Cumming <murrayc@murrayc.com>
943 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
944 when the toolbar does not exist yet.
945 * src/modest-widget-memory.c: (save_settings_header_view):
946 Added g_warnings() to help us to discover when we are trying to set
947 an empty columns list in gconf.
949 2007-06-14 Murray Cumming <murrayc@murrayc.com>
953 Added modest_init_get_default_header_view_column_ids().
955 * src/modest-widget-memory.c: (restore_settings_header_view):
956 Use the new function to get defaults, if the gconf key is empty,
957 instead of not creating any columns. This seems to fix the
958 empty right-hand pane problems.
960 * src/widgets/modest-header-view.h: Improved documentation.
962 2007-06-13 Murray Cumming <murrayc@murrayc.com>
964 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
965 Revert the use of the display name as the account name, because this
966 is generally wrong and would break the code that follows.
968 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
970 * src/maemo/easysetup/modest-easysetup-wizard.c:
971 (check_for_supported_auth_methods), (on_before_next),
974 More correct fix for projects.maemo.org bug NB# 58991
975 Do not longer accept AUTH_PASSWORD as secure method and choose
976 correct method when creating the account.
978 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
980 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
981 Fixed projects.maemo.org bug NB# 58991
983 2007-06-13 Murray Cumming <murrayc@murrayc.com>
985 * src/modest-init.c: (modest_init_init_core),
986 (modest_init_local_folders): Fixed compilation errors.
988 2007-06-13 Murray Cumming <murrayc@murrayc.com>
990 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
991 Remove unnecessary lib/include, though it is good in principle when needed.
993 * src/modest-init.c: (modest_init_one_local_folder),
994 (modest_init_local_folders):
995 * src/modest-init.h: Initialize the .modest library for memory cards,
996 instead of just doing nothing for them. This should allow us to create
997 folders there, fixing projects.maemo.org bug NB#59297.
999 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1001 * libmodest-dbus-client/libmodest-dbus-client.c:
1002 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1003 (libmodest_dbus_client_compose_mail),
1004 (libmodest_dbus_client_open_message),
1005 (libmodest_dbus_client_send_and_receive),
1006 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1008 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1009 (on_idle_open_message), (modest_dbus_req_handler),
1010 (search_result_to_message), (modest_dbus_req_filter):
1011 * src/modest-search.c: (add_hit), (modest_search_folder),
1012 (modest_search_all_accounts): Improved debug messages.
1014 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1016 * src/modest-tny-account-store.c:
1017 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1020 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1023 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1025 * src/modest-tny-account-store.c: (get_server_accounts):
1026 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1027 even when there are no accounts, so that the Outbox folder is always
1028 visible. This fixes projects.maemo.org bug NB#60158.
1030 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1032 * src/maemo/modest-main-window.c: (create_details_widget):
1033 Use the mcen_va_never logical ID.
1035 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1037 * src/dbus_api/modest-dbus-api.h:
1038 * src/dbus_api/modest-dbus-callbacks.c:
1039 (on_idle_open_default_inbox), (on_open_default_inbox),
1040 (modest_dbus_req_handler):
1041 Added a new OpenDefaultInbox method.
1043 * libmodest-dbus-client/libmodest-dbus-client.h:
1044 * libmodest-dbus-client/libmodest-dbus-client.c:
1045 Added libmodest_dbus_client_open_default_inbox() to call the new
1046 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1047 though it should maybe be used by a new osso-email-interface function.
1049 * tests/dbus_api/Makefile.am:
1050 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1053 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1055 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1056 NULL, so that the signals get all the keys. This should not actually
1057 change any behaviour because we currently update everything when anything
1060 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1062 * src/widgets/modest-folder-view.c: (text_cell_data),
1063 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1064 (find_inbox_iter): If tinymail tells us that the folder is
1065 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1066 This causes the inbox to be selected at startup, fixing part of
1067 projects.maemo.org bug NB#56305.
1069 * src/modest-ui-dimming-rules.c:
1070 (modest_ui_dimming_rules_on_tools_smtp_servers):
1071 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1072 the SMTP servers menu item.
1073 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1074 that the SMTP Servers menu item is dimmed when there are no accounts,
1075 as a future version of the UI spec will require. This fixes
1076 projects.maemo.org bug NB#56305.
1078 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1080 * src/maemo/modest-maemo-utils.c:
1081 (modest_maemo_utils_get_supported_secure_authentication_methods):
1082 Added label to dialog instead of unreadable title
1084 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1085 (modest_main_window_new):
1086 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1089 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1090 * src/modest-account-mgr.h:
1091 Added method to avoid code duplication
1093 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1094 (modest_ui_actions_on_send_receive):
1095 Use modest_account_mgr_has_accounts
1097 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1099 * src/maemo/easysetup/modest-presets.c:
1100 (modest_presets_get_info_server_security): Do not report secure auth
1102 * src/modest-protocol-info.c: Use the defines for the gconf key names
1103 for secure authentication. This was not working because we were writing
1104 Password and reading password, and the check was case sensitive.
1105 With this, gmail now works for receiving and sending when created via
1108 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1110 * src/maemo/easysetup/modest-presets.c:
1111 (modest_presets_get_info_server_security): Correct the key name for
1112 SecureSmtp, because it seems to be case-sensitive.
1113 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1114 Do not try to get the 0th notebook page if there are 0 pages, to
1115 avoid a g_warning().
1117 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1120 Prevent use of the new notification feature for now, because it currently
1121 shows one dialog for each new email, which is annoying.
1123 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1125 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1126 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1127 when no country was selected, so that we show the global ones.
1128 * src/maemo/easysetup/modest-presets.c:
1129 (modest_presets_get_providers): Return only the global providers, not
1130 all providers when mmc=0 was requested.
1132 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1134 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1135 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1136 provider ID in the combo.
1138 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1139 Do not show the page numbers, because it would be confusing when we add
1140 the 2 extra pages for the custom setup, when the user chooses the "Other"
1141 provider. This fixes projects.maemo.org bug NB#59028
1143 * src/modest-init.c: (modest_init_init_core),
1144 (modest_init_local_folders):
1145 * src/modest-init.h:
1146 * src/modest-tny-account.c:
1147 (modest_tny_account_new_for_local_folders): Do not create default folders
1148 for the memory card. This should fix projects.maemo.org bug NB#59328.
1150 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1152 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1153 Free the changed_conf_keys string items. They are already freed in the
1154 idle handler if that runs first.
1156 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1158 * src/modest-ui-actions.c:
1159 (modest_ui_actions_on_password_requested): Check that the server name
1160 is not NULL, because I just saw a password dialog with (null) as the
1163 * src/modest-tny-folder.[h|c]: Added
1164 modest_tny_folder_is_memory_card_folder().
1165 * src/modest-ui-dimming-rules.c:
1166 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1167 menu item for memory cards, as per the UI spec (section 7.4). This should
1168 fix projects.maemo.org bug NB#59297.
1170 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1172 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1173 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1174 is another problem with the code, see Murray's comment at line 772)
1176 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1178 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1179 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1180 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1181 (load_from_file), (easysetup_country_combo_box_init),
1182 (easysetup_country_combo_box_get_active_country_ids),
1183 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1184 instead of just one ID, to avoid duplicate country names in the UI.
1186 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1187 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1188 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1189 a single ID, avoiding duplicate providers.
1190 * src/maemo/easysetup/modest-easysetup-wizard.c:
1191 (on_combo_account_country): Adapt to use a list.
1193 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1196 keys changed in the last X seconds.
1198 * src/modest-account-mgr.h:
1199 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1200 (on_key_change), (modest_account_mgr_class_init),
1201 (modest_account_mgr_init), (modest_account_mgr_finalize):
1202 As the keys are changed, save them in a GSList* and signal that GSList*
1203 further every X seconds, to batch changes, to allow us to do just one
1204 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1205 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1207 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1208 changed signal signature.
1210 * src/modest-conf.c: (modest_conf_set_list),
1211 (modest_conf_on_change): Reenable notification.
1213 (modest_conf_maemo_fake_on_change): Comment out the hack that
1214 notified immediately instead of asynchronously.
1216 * src/widgets/modest-account-view.h:
1217 * src/widgets/modest-account-view.c:
1218 (update_account_view): Select the previously-selected account ID,
1219 if possible. This fixes projects.maemo.org bug NB#56933.
1221 (on_account_changed), (on_account_removed),
1222 (modest_account_view_select_account):
1224 Remove the block/unblock functions
1225 because they were not useful.
1227 * src/maemo/modest-account-view-window.c:
1228 (on_delete_button_clicked), (on_edit_button_clicked),
1229 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1231 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1233 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1234 Improve the error dialog to show Incorrect Account Settings, which seems
1235 clearer, and say that the internal error message (to be removed from the
1236 dialog later) is often misleading.
1237 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1239 * src/modest-tny-account.c:
1240 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1241 URL because this is so useful for debugging on the device.
1243 * src/widgets/modest-serversecurity-combo-box.c:
1244 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1246 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1248 * src/modest-mail-operation.c:
1249 (modest_mail_operation_send_new_mail):
1250 Added a comment about a nasty but apparently harmless message. Details
1251 added to the wiki g_warnings() page.
1253 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1256 (modest_tny_send_queue_class_init):
1257 Do not use the priv struct because it is empty, to avoid g_warnings
1258 about a non-existant priv struct.
1260 * src/modest-tny-account-store.c:
1261 (modest_tny_account_store_get_server_account),
1262 (modest_tny_account_store_get_transport_account_for_open_connection
1263 ): Do not try to get transport server accounts for local folders,
1264 because they don't have any. This avoids a g_warning().
1266 * src/maemo/modest-main-window.c:
1267 (modest_main_window_notify_send_receive_initied),
1268 (on_configuration_key_changed):
1269 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1270 * src/modest-defs.h:
1271 * src/modest-mail-operation.c:
1272 (modest_mail_operation_update_account):
1273 * src/modest-tny-account-store.h:
1274 * src/modest-tny-account.c:
1275 (modest_tny_account_get_special_folder),
1276 (modest_tny_account_new_for_local_folders),
1277 (modest_tny_account_new_for_per_account_local_outbox_folder):
1278 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1279 * src/modest-tny-local-folders-account.c:
1280 (add_account_folders_to_merged_folder):
1281 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1282 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1283 (modest_ui_actions_on_send):
1284 * src/widgets/modest-folder-view.c: (update_model):
1285 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1286 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1287 modest_tny_account_store_get_tny_account_by_account() to
1288 modest_tny_account_store_get_server_account() to make the code clearer.
1290 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1292 * src/dbus_api/modest-dbus-api.h:
1293 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1294 * src/maemo/modest-msg-edit-window.c:
1295 (modest_msg_edit_window_attach_file_noninteractive):
1296 added g_warning in case the file to be attached does not exist
1297 * tests/dbus_api/test_compose_mail.c: (main):
1298 removed obsolete comment, added generic files as test case
1300 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-tny-account-store.c: (get_server_accounts):
1303 Create the local folders account only once, not once for each outbox, and
1304 not only when there are some outboxes.
1306 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1308 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1309 code that is causing a crash at startup. Sergio says that he is fixing this.
1311 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1313 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1314 * src/maemo/modest-account-settings-dialog.c:
1315 (create_page_outgoing),
1316 (modest_account_settings_dialog_set_account_name),
1317 (save_configuration):
1318 - Fixed handling of the "Use secure authentication" toggle to comply with
1319 the ui specification. See also projects.maemo.org bug NB#58400
1321 - Restore the Secure connection setting combo correctly when loading
1324 * src/maemo/modest-maemo-utils.c:
1325 (on_camel_account_get_supported_secure_authentication),
1326 (modest_maemo_utils_get_supported_secure_authentication_methods):
1327 Fixed a crasher if operation is canceled
1329 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1330 (modest_protocol_info_auth_is_secure):
1331 * src/modest-protocol-info.h:
1333 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1334 the sense of the "Use secure authentication" toggle.
1336 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1338 * src/modest-tny-account-store.h:
1339 * src/modest-tny-account-store.c:
1340 Added modest_tny_account_store_get_local_folders_account().
1342 * src/modest-tny-folder.h:
1343 * src/modest-tny-folder.c:
1344 (modest_tny_folder_get_account):
1345 Added this replacement for tny_folder_get_account() which returns
1346 the local-folders account for TnyMergeFolders, to avoid the
1347 warning about the unimplemented get_account_func() vfunc().
1349 (modest_tny_folder_get_rules),
1350 * src/modest-ui-actions.c:
1351 (modest_ui_actions_on_folder_selection_changed):
1352 * src/modest-mail-operation.c:
1353 (modest_mail_operation_remove_folder),
1354 (modest_mail_operation_xfer_folder),
1355 (modest_mail_operation_rename_folder),
1356 (modest_mail_operation_get_msg),
1357 (modest_mail_operation_get_msgs_full),
1358 (modest_mail_operation_remove_msg),
1359 (modest_mail_operation_xfer_msgs),
1360 (modest_mail_operation_refresh_folder):
1361 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1363 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1365 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1366 (modest_server_account_set_security):
1367 * src/modest-defs.h: Add comments explaining that our
1368 UI spec means TLS when it says Normal, so these do not look like errors.
1370 * src/modest-tny-account.c:
1371 (modest_tny_account_new_from_server_account): Use the new tinymail
1372 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1373 for TLS. This should fix projects.maemo.org bug NB#58460.
1375 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1377 * src/maemo/easysetup/modest-easysetup-wizard.c:
1378 (create_account): Correct the position of the gconf sanity check warning.
1379 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1380 of using the g_idle_add() hack, because this does not seem to be necessary
1381 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1382 caused by something other than maemo's gconf.
1383 This fixes projects.maemo.org bug #59022.
1385 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1387 * src/modest-account-mgr-helpers.c:
1388 (modest_account_mgr_get_default_account): Do not check that the account
1389 exists if there is no default account (NULL), to fix a runtime warning.
1391 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1393 * src/widgets/modest-folder-view.c: (update_model):
1394 Do not unref the treemodel before we have finished with it.
1395 This prevents a valgrind warning and an occasional crash at startup.
1397 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1399 * libmodest-dbus-client/libmodest-dbus-client.h:
1400 added libmodest_dbus_client_compose_mail()
1401 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1403 added functions needed for SendAsMail() functionality
1404 * src/maemo/modest-msg-edit-window.c:
1405 (modest_msg_edit_window_attach_file_noninteractive):
1406 non interactively attaching files to message edit window
1407 * src/widgets/modest-msg-edit-window.h:
1408 * tests/dbus_api/Makefile.am:
1409 added test_compose_mail.c
1410 * tests/dbus_api/test_compose_mail.c: (main):
1412 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1414 * src/modest-account-view.c:
1415 Fixed bug projects.maemo.org bug NB#59307
1417 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1419 * src/maemo/easysetup/modest-easysetup-wizard.c:
1420 (get_serverport_incoming), (on_before_next), (create_account):
1421 * src/maemo/modest-account-settings-dialog.c:
1422 (modest_account_settings_dialog_set_account_name):
1423 * src/maemo/modest-maemo-utils.c:
1424 (on_camel_account_get_supported_secure_authentication_status),
1425 (on_camel_account_get_supported_secure_authentication),
1426 (on_secure_auth_cancel),
1427 (modest_maemo_utils_get_supported_secure_authentication_methods):
1429 Implemented security authentication for settings and easysetup.
1431 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1433 * src/maemo/modest-main-window.c: (create_details_widget):
1434 Show the total size for memory card accounts too, instead of showing
1435 the name again. Fixes bug projects.maemo.org bug NB#59307.
1437 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1440 * src/modest-tny-simple-folder-store.c:
1441 * src/modest-tny-simple-folder-store.h: Removed.
1443 * src/modest-tny-local-folders-account.h
1444 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1445 for the local-folders maildir, with an extra TnyMergedFolder containing
1446 the folders of the per-account outbox store accounts.
1447 * src/modest-tny-account-store.c: (get_server_accounts):
1448 Add the outboxes to the special local folders account after creating it.
1450 * src/modest-tny-account.c:
1451 (modest_tny_account_new_for_local_folders): Create the derived
1452 account when creating the main local-folders account.
1454 * src/maemo/modest-main-window.c: (create_details_widget),
1455 (modest_main_window_set_contents_style):
1456 Adapted to the use of the derived account instead of the folder store.
1458 * src/modest-ui-actions.c:
1459 (modest_ui_actions_on_folder_selection_changed):
1460 * src/modest-ui-dimming-rules.c:
1461 (modest_ui_dimming_rules_on_new_folder):
1462 * src/widgets/modest-folder-view.c: (text_cell_data),
1463 (icon_cell_data), (filter_row), (update_model),
1464 (get_cmp_rows_type_pos):
1467 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1468 Do not get the priv struct, because no priv struct has been set,
1469 to avoid a runtime warning.
1471 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1472 #ifelse with #else, to fix a warning, to fix the build.
1475 2007-06-05 Christian Kellner <ckellner@openismus.com>
1477 * libmodest-dbus-client/libmodest-dbus-client.c:
1478 Fix small typo in doc (why do you always see them
1479 AFTER committing stuff?)
1482 2007-06-05 Christian Kellner <ckellner@openismus.com>
1484 * libmodest-dbus-client/libmodest-dbus-client.c:
1485 (libmodest_dbus_client_search):
1486 Initialize hit list with NULL. Also set folder list
1487 to "" if NULL was supplied.
1490 2007-06-03 Christian Kellner <ckellner@openismus.com>
1492 * libmodest-dbus-client/libmodest-dbus-client.c:
1493 (modest_search_hit_list_free):
1494 Make it save to call it with NULL.
1496 * src/dbus_api/modest-dbus-callbacks.c:
1497 * src/modest-search.c:
1498 Return full ModestSearchHits as the search result list not TnyHeader
1499 since can't be around withouth the correspoding TnyFolder.
1501 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1503 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1504 Added currently commented code to check for secure auth
1506 * src/maemo/modest-account-settings-dialog.c: (on_response),
1507 (save_configuration), (show_ok):
1508 Fixed projects.maemo.org bugs NB #59248 and #59251
1510 * src/maemo/modest-maemo-utils.c:
1511 (on_camel_account_get_supported_secure_authentication_status),
1512 (on_camel_account_get_supported_secure_authentication),
1513 (modest_maemo_utils_get_supported_secure_authentication_methods):
1514 * src/maemo/modest-maemo-utils.h:
1515 Moved get_supported_secure_authentication() method here to be able
1516 to use it from easysetup wizard.
1518 * src/modest-pair.c: (on_pair_compare_as_string):
1519 Should compare string with first part of pair and not
1520 strcmp pairs which will crash.
1522 * src/modest-protocol-info.c:
1523 (modest_protocol_info_protocol_is_store):
1524 * src/modest-protocol-info.h:
1525 Added modest_protocol_info_get_auth_protocol_name()
1527 2007-06-03 Armin Burgmeier <armin@openismus.com>
1529 * src/modest-mail-operation.c:
1530 (modest_mail_operation_get_msgs_full): Set priv->account also when
1531 only retrieving a single message. This avoids a crash when canceling
1534 (modest_mail_operation_notify_end): Do not explicitely remove the
1535 operation from the queue but only emit the progress_changed signal.
1536 The queue itself listens to that signal to remove the operation when
1537 it is finished. This reduces coupling and removes a potential deadlock
1538 when modest_mail_operation_notify_end() is called from the queue
1539 itself. If that is a problem performance-wise, I would suggest to
1540 implement a status-changed signal or something.
1542 * src/modest-mail-operation-queue.c: Make sure to never call a
1543 function from another file while the queue is locked. This (hopefully)
1544 fixes another deadlock when exiting the application while retrieving
1547 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1549 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1550 Fixed build if libogs is not available
1552 2007-06-03 Christian Kellner <ckellner@openismus.com>
1554 * libmodest-dbus-client/libmodest-dbus-client.h:
1555 * libmodest-dbus-client/libmodest-dbus-client.c:
1556 (libmodest_dbus_client_delete_message):
1557 Implement deletion of messages (Client side).
1559 (modest_search_hit_free),
1560 (modest_search_hit_list_free):
1561 Utility functions to free the result hits.
1563 * src/dbus_api/modest-dbus-api.h:
1564 * src/dbus_api/modest-dbus-callbacks.c:
1565 (on_delete_message),
1566 (modest_dbus_req_handler):
1567 Implement deletion of messages (Server side).
1569 * tests/dbus_api/test_search.c: (main):
1572 * tests/dbus_api/Makefile.am:
1573 * tests/dbus_api/test_delete_message:
1574 Add little test for the message deletion logic
1576 2007-06-03 Armin Burgmeier <armin@openismus.com>
1578 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1579 when the operation queue was not empty. projects.maemo.org bug
1582 2007-06-03 Armin Burgmeier <armin@openismus.com>
1584 * src/widgets/modest-account-view.c
1585 (on_account_default_toggled): Toggle default account column
1586 explicitely instead of waiting for gconf notification (which is
1587 currently ignored). This should fix projects.maemo.org bug NB#56910
1588 for now. It should probably be removed when gconf notifications are
1591 2007-06-03 Christian Kellner <ckellner@openismus.com>
1593 * libmodest-dbus-client/libmodest-dbus-client.c:
1594 Removed debugging spew.
1596 * src/dbus_api/modest-dbus-callbacks.c:
1597 Added debugging info.
1599 * src/modest-search.c:
1600 (modest_search_all_accounts):
1601 Use tny_account_store_get_accounts () on the account store
1602 to get all accounts which is the way to get all accounts.
1604 * tests/dbus_api/test_search.c: (main):
1605 Make it possible to supply the search term on the command line.
1607 2007-06-03 Christian Kellner <ckellner@openismus.com>
1609 * libmodest-dbus-client/libmodest-dbus-client.c:
1610 * libmodest-dbus-client/libmodest-dbus-client.h:
1611 Implement searching for mesages over raw dbus. (Client side)
1613 * src/dbus_api/Makefile.am:
1614 * src/dbus_api/modest-dbus-api.h:
1615 * src/dbus_api/modest-dbus-callbacks.c:
1616 * src/dbus_api/modest-dbus-callbacks.h:
1617 Search framework (Server side). Also implement on_idle_open_message().
1619 * src/maemo/modest-platform.c: (modest_platform_init):
1620 Prepare for raw dbus/osso rpc interaction.
1622 * src/modest-search.h:
1623 Changed minsize from unspecific guint to guint32.
1625 * src/modest-search.c:
1627 Added strange hack which magically made tnymail work.
1629 (modest_search_folder),
1630 (modest_search_account),
1631 (modest_search_all_accounts):
1632 Implement helper functions to search all accounts, specific account
1635 * tests/dbus_api/Makefile.am:
1636 * tests/dbus_api/test_open_message.c:
1637 Read url to open from commandline.
1639 * tests/dbus_api/test_search.c:
1640 Implement small test for dbus search stuff
1642 2007-06-02 Armin Burgmeier <armin@openismus.com>
1644 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1645 include account type and account title. This fixes projects.maemo.org
1648 * src/maemo/modest-account-view-window.c: Set a title for the window.
1650 2007-06-02 Armin Burgmeier <armin@openismus.com>
1652 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1653 incoming and outgoing server name based on email address and server
1654 types as long as the names have not been edited manually. This fixes
1655 projects.maemo.org bug NB#58671.
1657 2007-06-02 Armin Burgmeier <armin@openismus.com>
1659 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1660 server type cannot be changed in future to the incoming details page
1661 when creating an account. This fixes projects.maemo.org bug NB#59029.
1663 2007-06-02 Armin Burgmeier <armin@openismus.com>
1665 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1666 and assigned max width chars so that they wrap instead of being
1667 truncated. Fixes projects.maemo.org bug NB#56126.
1669 2007-06-02 Armin Burgmeier <armin@openismus.com>
1671 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1672 introductory note to the connection specific smtp servers dialog, as
1673 section 8.12 of the email UI specification requires. This fixes
1674 projects.maemo.org bug NB#59212.
1676 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1678 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1679 Check for running mail operations, and offer to cancel them, as per the UI
1680 spec. This fixes projects.maemo.org bug NB#59041 .
1681 However, I suspect that tinymail may still use the network connection
1682 in ways that we cannot detect or cancel. But it should at least adapt to
1683 changes fairly well.
1685 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1687 * src/modest-tny-account-store.c: (recreate_all_accounts),
1688 (get_cached_accounts), (get_server_accounts): Do more sensible
1689 ref-counting of the temporarily-cached outbox accounts list. This seems
1690 to fix a crash when entering the password when the password was wrong.
1692 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1694 * src/gnome/modest-main-window.c: (connect_signals):
1695 * src/modest-tny-account-store.c: (get_password),
1696 (modest_tny_account_store_alert): Added comments and clues and
1697 commented-out code about how we currently fail to deal with connection
1698 errors and wrong passwords, and how we should.
1700 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1702 * src/widgets/modest-retrieve-combo-box.c:
1703 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1704 This fixes projects.maemo.org bug NB#58472 .
1706 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1708 * src/maemo/easysetup/modest-easysetup-wizard.c:
1709 (create_page_complete_easysetup):
1710 (create_page_complete_custom): Correct the last commit,
1711 putting the correct sentences in the correct pages.
1713 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1715 * src/maemo/easysetup/modest-easysetup-wizard.c:
1716 (create_page_complete_custom): Show the second sentence of text
1717 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1720 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1722 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1723 Set the leave-on-server conf key by default. This fixes
1724 projects.maemo.org bug NB#59258 .
1726 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1728 * src/maemo/modest-account-view-window.c:
1729 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1730 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1733 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1735 * src/maemo/easysetup/modest-easysetup-wizard.c:
1736 (create_caption_new_with_asterisk):
1737 * src/maemo/modest-account-settings-dialog.c:
1738 (create_caption_new_with_asterisk):
1739 Uncomment the code to add the asterisk, because they are no longer in the
1740 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1741 (update_incoming_server_title): Add an asterisk here too.
1743 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1745 * src/maemo/modest-maemo-global-settings-dialog.c:
1746 (current_connection): Check that we are even connected before trying to
1747 get the current connection name, to prevent a warning.
1749 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1750 Change the comments because tny_maemo_conic_device_connect() is now meant to
1752 * src/modest-mail-operation.c:
1753 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1754 make sure we have a connection and fail if we can't connect.
1756 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1758 * src/maemo/modest-main-window.c:
1759 (on_account_store_connecting_finished): Do not try to get the
1760 connection ID if we are not really connected. I am surprised that
1761 this signal handler is called when we are not connected.
1763 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1765 * src/modest-error.h:
1766 * src/modest-ui-actions.c:
1767 (modest_ui_actions_get_msgs_full_error_handler):
1768 Renamed an enum, added comments, added an enum
1769 for retrieve-limit errors.
1771 * src/modest-mail-operation.c: (foreach_add_item),
1772 (internal_folder_observer_update), (update_account_thread),
1773 (modest_mail_operation_get_msgs_full):
1774 (modest_mail_operation_update_account),
1775 Added comments about how this works, and some code that should
1776 (but does not) check the retrieve-limit. See the TODO comment.
1778 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1780 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1781 Initialize help_id to fix the build. Warnings are good.
1783 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1785 * src/widgets/modest-hbox-cell-renderer.c:
1786 (modest_hbox_cell_renderer_append):
1787 * src/widgets/modest-vbox-cell-renderer.c:
1788 (modest_vbox_cell_renderer_append):
1789 Fix the last commit by doing an extra ref.
1791 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1793 * src/widgets/modest-hbox-cell-renderer.c:
1794 (modest_hbox_cell_renderer_append):
1795 * src/widgets/modest-vbox-cell-renderer.c:
1796 (modest_vbox_cell_renderer_append):
1797 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1798 to fix the build with Maemo Bora.
1799 However, there seems to be a remaining crash, probably due to reference
1802 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1804 * src/modest-tny-account.c:
1805 (modest_tny_account_new_for_local_folders):
1806 Use hildon_file_system_info_async_new() to get a better name for
1807 the memory card account, setting it as the account name.
1808 The timing seems to work, but this is probably
1809 not the best place to do this. See the TODO comment.
1810 * src/maemo/modest-main-window.c: (create_details_widget):
1811 * src/widgets/modest-folder-view.c: (text_cell_data):
1812 Use the tny account name instead of hardcoding a name.
1814 2007-05-30 Christian Kellner <ckellner@openismus.com>
1816 * src/modest-search.c: (modest_search):
1817 Correctly set part_search_func even if we have already parsed
1818 the query and thus a valid OgsTextSearcher object.
1820 2007-05-30 Christian Kellner <ckellner@openismus.com>
1823 Search and check for libogs.
1826 Incooparte the ogs build env.
1828 * src/modest-mime-part-search-stream.c:
1829 * src/modest-mime-part-search-stream.h:
1830 Removed since we do the real searching now in modest-search.c.
1832 * src/modest-search.c:
1833 * src/modest-search.h:
1834 Implement support for ogs. We use that if available and requested
1835 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1836 should now handle the corner case when the search term is spread
1837 across multiple reads.
1838 Also the logic in modest_search () was corrected to search all
1839 requested fields until one is found.
1841 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1843 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1845 * src/modest-init.h:
1846 * src/modest-init.c: Made modest_init_local_folders() take a
1847 path and be public so we can iniitialize maildir folders on
1850 * src/modest-local-folder-info.h:
1851 * src/modest-local-folder-info.c:
1852 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1854 * src/modest-tny-account.c:
1855 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1856 still means the standard local-folders path on the local volume.
1858 * src/modest-tny-account-store.c:
1859 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1860 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1861 all accounts when that happens.
1862 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1863 this too, so it shows up in the treeview.
1865 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1867 * src/maemo/modest-maemo-global-settings-dialog.c:
1868 (current_connection):
1869 * src/widgets/modest-global-settings-dialog.c:
1870 (current_connection_default):
1871 Use the enum values instead of 0, 1 and -1,
1872 to make the code clearer.
1874 * src/modest-account-mgr-helpers.c:
1875 (modest_account_mgr_get_connection_specific_smtp): Make this code
1878 * src/modest-runtime.h:
1879 * src/modest-runtime.c:
1880 Added modest_runtime_remove_all_send_queues().
1881 * src/maemo/modest-main-window.c:
1882 (on_account_store_connecting_finished): Recreate the send queues,
1883 using the appropriate transport accounts for this new connection.
1884 Some futher adapting might be needed if the old send queues are not
1885 automatically stopped at this point.
1887 * src/modest-tny-account-store.c: (get_server_accounts):
1888 Create the connection-specific transport accounts, so that they can
1889 be found later by their ID.
1891 * src/modest-tny-account.h:
1892 * src/modest-tny-account.c:
1893 Added modest_tny_account_new_from_server_account_name().
1894 modest_tny_account_new_from_server_account(): Do not create the
1895 send queues here, because they will be
1896 recreated anyway when the connection changes for the first time.
1898 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1900 * src/modest-local-folder-info.h:
1901 * src/modest-local-folder-info.c:
1902 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1903 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1904 tbox_folder): Take a modest account name instead of a server TnyAccount,
1905 so we can have per-modest-account rather than per-transport-account
1907 We must make sure that we change or recreate the exisitng send queues
1908 when the connection changes for connection-specific transport accounts.
1910 * src/modest-tny-account-store.c:
1911 (create_per_account_local_outbox_folders): Create outboxed per modest
1912 account, not per transport account.
1914 * src/modest-tny-account.h:
1915 * src/modest-tny-account.c:
1916 (modest_tny_account_get_special_folder): For outboxes, get the
1917 parent modest account name. The account is ignored for other folders.
1918 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1919 modest account name rather than a server TnyAccount.
1921 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1923 * src/modest-tny-account.c:
1924 (modest_tny_account_new_from_server_account):
1925 Call modest_runtime_get_send_queue() immediately after creating transport
1926 accounts, so that they start trying to send email from the outbox as soon
1927 as possible at startup. This is probably what we want.
1929 * src/modest-mail-operation.c: (update_account_thread):
1930 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1931 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1932 * src/modest-tny-send-queue.h:
1933 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1934 (modest_ui_actions_on_send):
1935 Added comments about how sending works, though it needs some more work.
1937 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1939 * src/modest-tny-account.c:
1940 (modest_tny_account_get_special_folder): Add TODO because this fails when
1941 the network is busy.
1942 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1943 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1944 Do not try to show this window when there is no active account. The UI
1945 specs does not tell us what to do in this case.
1947 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1951 * src/maemo/Makefile.am:
1952 * src/widgets/Makefile.am: Some dist fixes.
1954 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1956 * src/maemo/modest-connection-specific-smtp-window.c:
1957 (on_button_edit): Make the code clearer, to prevent a double free.
1959 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1961 * src/maemo/modest-account-settings-dialog.c:
1962 (modest_account_settings_dialog_set_account_name),
1963 Check the connection-specific smtp servers checkbox if there are any.
1965 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1966 (modest_connection_specific_smtp_edit_window_init):
1967 Start with a suitable port number.
1969 * src/modest-account-mgr-helpers.h:
1970 * src/modest-account-mgr-helpers.c: Added
1971 modest_account_mgr_get_has_connection_specific_smtp().
1973 (modest_account_mgr_set_connection_specific_smtp),
1974 (modest_account_mgr_remove_connection_specific_smtp),
1975 (modest_account_mgr_get_has_connection_specific_smtp),
1976 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1977 connection-specific smtp server accounts in the account, rather than
1978 the server account conf dir.
1980 This fixes bug projects.maemo.org bug NB#58263 .
1982 * src/modest-tny-account-store.c:
1983 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1984 if there are no server accounts yet, to prevent an infinite loop when there
1985 are no accounts. Document that one must be called before the other.
1987 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1989 * src/modest-account-mgr-helpers.c:
1990 (modest_account_mgr_get_default_account): Make sure that at least
1991 one account is always the default, if there are any enabled accounts.
1992 This is just a sanity check that shouldn't be necessary.
1994 * src/modest-account-mgr-priv.c:
1995 (_modest_account_mgr_account_from_key): Unescape the conf key to
1996 get the real account name. For instance, this is an issue if a space
1997 was in the account name, which can happen because the account name
1998 is generated from the display name.
1999 (_modest_account_mgr_get_account_keyname): Always escape the
2001 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2002 Unescape the conf keys to get the real account names.
2004 For instance, previously the is-default radio button in the accounts
2005 list was not checked for any accounts at first. This fixes that,
2006 and might fix several similar bugs.
2008 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2010 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2011 Removed some debug printfs.
2013 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2015 Modest on-disk outbox directories are now here, for instance:
2016 $HOME/.modest/outboxes/<account-id-1>/outbox
2017 $HOME/.modest/outboxes/<account-id-2>/outbox
2019 $HOME/.modest/local-folders/outbox
2020 so we can have a separate outbox for each account.
2021 But they are shown as one outbox in the GtkTreeView, by using a
2022 TnyMergeFolder in a ModestTnySimpleFolderStore.
2025 * src/modest-tny-simple-folder-store.c:
2026 * src/modest-tny-simple-folder-store.h:
2027 Added ModestTnySimpleFolderStore, used to contain folders from
2028 other folder stores, such as other accounts.
2030 * src/modest-tny-outbox-account.h:
2031 * src/modest-tny-outbox-account.c:
2032 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2033 used for the per-account local outbox folders.
2035 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2036 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2037 only use this (internally) now for the non-outbox local folders.
2039 * src/modest-init.h:
2040 * src/modest-init.c: Added modest_init_one_local_folder(), for
2041 setting up the directory structure for each local folder.
2043 * src/modest-local-folder-info.c:
2044 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2045 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2047 * src/modest-local-folder-info.h:
2048 * src/modest-tny-account-store.c: (on_account_removed),
2049 (on_account_changed), (create_per_account_local_outbox_folders),
2050 (get_server_accounts), (modest_tny_account_store_get_accounts),
2051 (modest_tny_account_store_get_tny_account_by_account),
2052 (modest_tny_folder_store_is_virtual_local_folders):
2054 * src/modest-tny-account.h:
2055 * src/modest-tny-account.c:
2056 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2057 to create an on-disk per-account local outbox folder for each
2059 (create_per_account_local_outbox_folders): Create a local outbox folder
2060 for each transport account.
2061 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2062 for all local folders.
2064 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2065 instead of using g_object_get/set() directly. It is clearer.
2067 (modest_tny_folder_store_get_message_count),
2068 (modest_tny_folder_store_get_local_size
2069 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2070 because we now use these with non-acount folder stores.
2072 (modest_tny_account_get_special_folder),
2073 (modest_tny_account_new_from_server_account),
2074 (modest_tny_account_new_from_account):
2075 (recurse_folders): Adjust to the new outbox system.
2077 * src/modest-tny-folder.h:
2078 * src/modest-tny-folder.c:
2079 (modest_tny_folder_is_local_folder),
2080 (modest_tny_folder_get_local_folder_type),
2081 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2083 * src/widgets/modest-main-window.h:
2084 * src/maemo/modest-main-window.c: (create_details_widget),
2085 (modest_main_window_set_contents_style): Show details for any folder store,
2088 (modest_tny_folder_get_rules):
2089 Remove the const. C does not support constness enough for this.
2091 * src/modest-ui-actions.c:
2092 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2093 make all outboxes appear as one, in the usual local-folders tree node.
2095 (set_active_account_from_tny_account),
2096 (modest_ui_actions_on_folder_selection_changed):
2097 * src/widgets/modest-folder-view.c: (text_cell_data),
2098 (icon_cell_data), (filter_row),
2099 (add_account_folders_to_merged_folder),
2100 (add_account_folders_to_simple_folder_store), (),
2101 (get_cmp_rows_type_pos), (cmp_rows),
2102 (modest_folder_view_set_account_id_of_visible_server_account):
2103 Adjust to the new outbox system, using generic folder stores and folders
2104 in the GtkTreeModel.
2106 2007-05-23 Christian Kellner <ckellner@openismus.com>
2108 * src/modest-mail-operation.c:
2109 (modest_mail_operation_update_account):
2110 Use info->max_size instead of unintialized local var [small
2111 build fix]. (Added TODO to review that change since I don't
2114 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2116 * libmodest-dbus-client/libmodest-dbus-client.c:
2117 (libmodest_dbus_client_compose_mail): function added
2118 * src/dbus_api/modest-dbus-api.h:
2119 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2120 (on_compose_mail): Implementation of the SendAsMail functionality
2122 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2124 * src/modest-account-mgr.c:
2125 (modest_account_mgr_add_server_account): Set the secure-connection
2126 conf key for transport accounts as well as store accounts. I don't know
2127 why the if was there. For instance, this makes sure that we use SSL
2128 for the gmail preset from the easysetup wizard.
2130 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2132 * src/gnome/modest-main-window.c:
2133 (on_account_store_connecting_finished), (connect_signals):
2134 * src/maemo/modest-main-window.c:
2135 (on_account_store_connecting_finished), (connect_signals),
2136 (modest_main_window_new):
2137 Handle TnyAccountStore::connecting-finished instead of
2138 TnyDevice::connection-changed, because we cannot actually perform
2139 operations on accounts until TnyAccountStore has itself responded to
2140 the TnyDevice::connection-changed signal. This prevents a GError from
2142 Do not try to update at startup, because we (at least on scratchbox)
2143 already do an update at startup when the device goes online.
2144 This prevents a GError from tinymail.
2145 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2146 Added TODO about stopping simultaneous operations.
2148 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2151 * src/modest-mail-operation-queue.c:
2152 (modest_mail_operation_queue_remove):
2153 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2154 about where they happened.
2156 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2158 * src/modest-ui-actions.c:
2159 (modest_ui_actions_on_password_requested): Make sure that the remember
2160 output parameter is always TRUE.
2162 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2164 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2165 Show a OK/Cancel dialog if the error is a question, though we still do not
2166 know anything more about what we are asking the user.
2167 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2168 Fix an uninitialized variable (helper). This is a logic error, however.
2170 2007-05-21 Christian Kellner <ckellner@openismus.com>
2172 * src/modest-search.h:
2173 Correct bit shifting in the ModestSearchFlags enum.
2175 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2177 * src/modest-tny-account.c:
2178 (modest_tny_account_new_from_server_account): Do not use the lsub and
2179 check-all hard-coded IMAP options when using POP.
2181 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2183 * src/modest-tny-account.c:
2184 (modest_tny_account_new_from_server_account):
2185 Use NULL for the secure-auth method for POP when Password auth has been
2186 specified by the user, as we already do for IMAP. "auth=Login" causes
2187 an error from camel or the server.
2189 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2191 * src/maemo/modest-account-settings-dialog.c:
2192 (create_page_account_details),
2193 (modest_account_settings_dialog_set_account_name):
2194 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2195 for the leave-on-server checkbox, rathr than just the checkbox, when
2196 the protocol is not POP.
2198 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2200 * src/widgets/modest-account-view.c:
2201 * src/widgets/modest-account-view.h:
2202 Added modest_account_view_select_account() which will be useful later
2203 to asynchronously re-select the edited account.
2205 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2207 * src/maemo/modest-account-settings-dialog.c:
2208 (modest_account_settings_dialog_set_account_name):
2209 Automatically choose the port numbers based on the secure authentication
2210 methods, if they have not been chosen before.
2211 This fixes projects.maemo.org bug NB#56273 .
2213 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/modest-main-window-ui.h:
2216 * src/modest-ui-actions.c:
2217 * src/modest-ui-actions.h:
2218 Connect the Tools/SMTP Servers menu item to
2219 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2220 SMTP servers dialog, as in the UI specification and saves changes when it
2221 is closed. This fixed projects.maemo.org bug NB#56305 .
2223 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2225 * src/maemo/modest-connection-specific-smtp-window.c:
2226 (modest_connection_specific_smtp_window_init):
2227 Use gtk_window_set_default_size() to make this window big enough, so
2228 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2230 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2232 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2233 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2234 (modest_connection_specific_smtp_edit_window_init),
2235 Do not try to connect to a combobox signal before the combobox exists.
2236 This fixes the cras in projects.maemo.org bug NB#56288 .
2237 (modest_connection_specific_smtp_edit_window_get_settings):
2238 Remove the server_account_name parameter which was being checked for NULL
2239 though it was not used.
2241 * src/maemo/modest-connection-specific-smtp-window.c:
2242 (modest_connection_specific_smtp_window_fill_with_connections),
2243 (on_button_edit), (modest_connection_specific_smtp_window_init):
2244 Correct the number of treemodel columns to prevent a warning.
2245 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2246 libconic does not work.
2248 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2250 * src/modest-tny-account.c:
2251 (modest_tny_account_new_from_server_account):
2252 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2253 SMTP when "None" was chosen by the user. However, with my SMTP server that
2254 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2257 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2259 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2260 to explain the memory management issue with the ID in the ModestPair.
2262 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2263 (add_sending_page), (modest_account_assistant_finalize):
2264 * src/gnome/modest-gnome-global-settings-dialog.c:
2265 (create_updating_page), (create_composing_page):
2266 * src/gnome/modest-msg-edit-window.c: (get_transports),
2267 (init_window), (modest_msg_edit_window_finalize),
2268 (modest_msg_edit_window_get_msg_data):
2269 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2270 * src/gnome/modest-transport-widget.c:
2271 (modest_transport_widget_finalize), (smtp_configuration):
2272 * src/maemo/modest-maemo-global-settings-dialog.c:
2273 (create_updating_page), (create_composing_page):
2274 * src/maemo/modest-msg-edit-window.c: (get_transports),
2275 (init_window), (modest_msg_edit_window_finalize),
2276 (modest_msg_edit_window_get_msg_data),
2277 (modest_msg_edit_window_free_msg_data):
2278 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2279 (modest_store_widget_finalize):
2280 * src/maemo/modest-transport-widget.c:
2281 (modest_transport_widget_finalize), (smtp_configuration):
2282 * src/modest-main.c: (send_mail):
2283 * src/widgets/modest-combo-box.h:
2284 * src/widgets/modest-global-settings-dialog-priv.h:
2285 * src/widgets/modest-global-settings-dialog.c:
2286 (modest_global_settings_dialog_finalize):
2287 * src/widgets/modest-msg-edit-window.h:
2288 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2289 as long as the combo box, to prevent use of freed memory for the ID.
2291 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2293 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2294 get_accounts(), to make this clearer. Do not check for the enabled gconf
2295 key, because we do not use this for server accounts (at least, not yet).
2296 This allows us to send email again.
2298 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2300 * src/maemo/modest-platform.c:
2301 (on_modest_conf_update_interval_changed), (modest_platform_init):
2302 Only respond to this particular key change. All these strcmp()s cannot be
2305 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/modest-maemo-global-settings-dialog.c:
2308 (current_connection): Prevent a crash in scratchbox when
2309 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2310 * src/maemo/modest-platform.c:
2311 (on_modest_conf_update_interval_changed), (modest_platform_init):
2312 Get the update interval from gconf and reset it when the gconf key changes.
2314 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2316 * src/modest-protocol-info.c:
2317 * src/modest-protocol-info.h: Adde enum-specific get functions,
2318 instead of using a ModestProtocolType enum parameter.
2320 * src/gnome/modest-account-assistant.c:
2321 * src/gnome/modest-store-widget.c:
2322 * src/gnome/modest-store-widget.h:
2323 * src/gnome/modest-transport-widget.c:
2324 * src/gnome/modest-transport-widget.h:
2325 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2326 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2327 * src/maemo/easysetup/modest-easysetup-wizard.c:
2328 * src/maemo/modest-account-settings-dialog.c:
2329 * src/maemo/modest-account-settings-dialog.h:
2330 * src/maemo/modest-store-widget.c:
2331 * src/maemo/modest-store-widget.h:
2332 * src/maemo/modest-transport-widget.c:
2333 * src/maemo/modest-transport-widget.h:
2334 * src/modest-account-mgr-helpers.c:
2335 * src/modest-account-mgr-helpers.h:
2336 * src/modest-account-mgr.c:
2337 * src/modest-account-mgr.h:
2338 * src/modest-tny-account.c:
2339 * src/modest-tny-folder.c:
2340 * src/widgets/modest-account-view.c:
2341 * src/widgets/modest-retrieve-combo-box.c:
2342 * src/widgets/modest-retrieve-combo-box.h:
2343 * src/widgets/modest-secureauth-combo-box.c:
2344 * src/widgets/modest-serversecurity-combo-box.c:
2345 * src/widgets/modest-serversecurity-combo-box.h:
2346 * tests/check_account-mgr.c:
2347 Use the specific functions, and use the re-renamed enum values for GNOME too.
2349 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2351 * src/modest-pair.h:
2352 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2353 so we can get the second based on the first.
2355 * src/maemo/modest-account-settings-dialog.h:
2356 * src/maemo/modest-account-settings-dialog.c:
2357 Added get_supported_secure_authentication_methods(), though it is mostly
2358 commented-out for now until the necessary API is committed to tinymail.
2359 (modest_account_settings_dialog_set_account_name),
2360 (save_configuration): Request the supported authentication methods from the
2361 server, so we can choose a working method.
2363 * src/modest-tny-account-store.h:
2364 * src/modest-tny-account-store.c:
2365 (modest_tny_account_store_get_session): Rename from
2366 tny_account_store_get_session().
2368 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2370 * src/modest-protocol-info.h: Split the ModestProtocol enum
2371 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2372 There was no need to have these unrelated values in one enum.
2374 * src/: many files: Adapted to changed enum. This makes the code a bit
2375 clearer, and the compiler could catch some errors.
2377 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2379 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2380 Show the detailed internal camel error message when an error happens
2381 during the configuration, so that our testers can give us more clues.
2382 For instance, in projects.maemo.org bug NB#56910 .
2384 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2386 * src/modest-tny-account.c:
2387 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2388 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2390 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2392 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2393 * src/maemo/modest-account-settings-dialog.c:
2394 (modest_account_settings_dialog_set_account_name),
2395 (save_configuration): For the incoming secure authentication checkbox,
2396 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2397 the UI specification. PLAIN does not seem to be supported for most IMAP
2398 servers anyway, and I am not sure what it would mean.
2399 However, we probably need to discover which of the secure-authentication
2400 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2401 * src/modest-account-mgr-helpers.c:
2402 (modest_account_mgr_get_server_account_data):
2404 * src/modest-tny-account.c:
2405 (modest_tny_account_new_from_server_account):
2406 Use tny_account_set_mech() to set secure-authentication methods,
2407 with some special-casing for IMAP, based on my observations of how
2410 * src/modest-account-mgr-helpers.h:
2411 * src/modest-account-mgr.c:
2412 * src/modest-defs.h: Comment that the URI is only used for local folders.
2414 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2416 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2417 parameter const, just to be neat.
2418 * src/modest-text-utils.c: (modest_text_utils_inline):
2419 End g_strconcat() with NULL, as its documentation says. This is almost
2420 certainly the cause of my crash at startup on the device. Interestingly,
2421 valgrind doesn't tell us about these errors.
2423 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2425 * scripts/build-packages: Added more precise comments about how to use
2426 this script, though I still get this error:
2427 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2428 error building tinymail
2430 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2432 * src/maemo/modest-main-window.c: (on_account_update):
2433 Very slight cleanup, hoping to make it simpler to discover what causes
2434 a crash here sometimes.
2436 * src/modest-tny-account.c:
2437 (modest_tny_account_new_from_server_account): Set the port. Added
2438 comments about the options and a TODO comment because I need to find out
2439 how to specify the secure authentication method.
2441 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2443 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2444 changed CFlags paths form modest to libmodest
2446 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2448 * src/modest-account-mgr-helpers.c:
2449 (modest_account_mgr_get_server_account_data),
2450 (modest_account_mgr_free_server_account_data):
2451 * src/modest-account-mgr-helpers.h:
2452 * src/modest-account-mgr.c:
2453 (modest_account_mgr_add_server_account):
2454 * src/modest-defs.h:
2455 * src/modest-tny-account.c:
2456 (modest_tny_account_new_from_server_account):
2457 Determine the options for tny_camel_account_add_option() here,
2458 based on the settings, rather than storing them directly in gconf.
2460 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2462 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2463 Show a more friendly error dialog now that we expect (from the tinymail
2464 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2466 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/modest-main-window.c: (on_account_update): Check that
2469 account_name is not NULL, to prevent a crash at startup that I am
2470 seeing on the N800. I do wonder why it is NULL.
2472 * src/maemo/easysetup/modest-easysetup-wizard.c:
2473 (create_page_user_details):
2474 * src/maemo/modest-account-settings-dialog.c:
2475 (create_page_user_details), (create_page_outgoing):
2476 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2477 (modest_connection_specific_smtp_edit_window_init):
2478 * src/modest-ui-actions.c:
2479 (modest_ui_actions_on_password_requested):
2480 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2481 might do something useful with the on-screen keyboard.
2483 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2485 * src/maemo/modest-main-window.c: (on_account_update):
2486 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2487 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2489 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2491 * src/modest-tny-account-store.c: (on_account_changed):
2492 Correct the signature of this signal handler.
2494 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2496 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2497 Show a HildonNote instead of a GtkDialog for Maemo.
2499 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2501 * src/widgets/modest-account-view.h:
2502 * src/widgets/modest-account-view.c: (on_account_changed),
2503 (on_account_removed). Added a boolean flag, set/unset by
2504 modest_account_view_block_conf_updates(),
2505 modest_account_view_unblock_conf_updates() to prevent unnecessary
2506 updates, but this is not very useful because the gconf notifications are
2507 so delays (maybe only on Maemo Bora).
2508 So auto-updating is turned off, and these functions do an explicit
2509 update when necessary.
2510 However, something else is still doing too much work when adding/removing
2511 accounts, probably in another part of the application.
2513 * src/maemo/modest-account-view-window.c:
2514 (on_delete_button_clicked), (on_edit_button_clicked),
2515 (on_new_button_clicked): Use the new functions.
2517 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-account-mgr-helpers.c:
2520 (modest_account_mgr_set_first_account_as_default):
2521 Sort the list of names alphabetically-by-title, so we choose the first one
2523 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2524 alphabetically by the title.
2526 This fixes projects.maemo.org bug NB#56418 .
2528 * src/modest-account-mgr-priv.c:
2529 (_modest_account_mgr_account_from_key):
2530 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2531 avoid a valgrind error, and possible random behaviour.
2533 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2535 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2536 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2537 tinymail documentation to say that this can be expected.
2538 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2539 pretty, and should not happen, but I would prefer to know when it does.
2541 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2543 * configure.ac: When using the older hildon version, probably on Bora,
2544 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2546 * src/widgets/modest-attachment-view.c:
2547 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2550 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2552 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2553 Implemented the prototype. Can be tested with
2554 tests/dbus_api/test_open_message:
2556 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2558 * src/modest-tny-account-store.c:
2559 (modest_tny_account_store_instance_init), (get_password):
2560 * src/modest-ui-actions.c:
2561 (modest_ui_actions_on_password_requested):
2562 Do not store the password in gconf, because this function is called
2563 for non-remembered passwords. Actually use the cached (in the hash map)
2564 password instead of releasing it.
2565 The password will now not be remembered if it is asked via the protected
2566 password dialog, as per the UI spec.
2568 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2570 * src/modest-defs.h:
2571 * src/modest-account-mgr-helpers.h:
2572 * src/modest-account-mgr-helpers.c:
2573 Added modest_server_account_get_username_has_succeeded(),
2574 modest_server_account_set_username_has_succeeded().
2575 (modest_server_account_set_username),
2576 Reset the has-succeeded flag if the username changes.
2578 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2579 * src/maemo/modest-connection-specific-smtp-window.c:
2580 (modest_connection_specific_smtp_window_save_server_accounts):
2581 Use modest_server_account_set_username() instead of using
2582 modest_conf_set_string() directly, so that the has-succeeded flag is always
2585 * src/modest-ui-actions.c:
2586 (modest_ui_actions_on_password_requested): Dim the username entry if
2587 the username has ever worked, as per the UI spec.
2589 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2591 * src/modest-tny-account-store.c: (get_password):
2592 * src/modest-ui-actions.c:
2593 (modest_ui_actions_on_password_requested):
2594 Allow the username to be changed too, though there is more work to
2595 be done on exactly how this behaves.
2597 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2599 * src/modest-account-mgr-helpers.h:
2600 * src/modest-account-mgr-helpers.c:
2601 Added modest_account_mgr_get_display_name(),
2602 modest_server_account_get_username(),
2603 modest_server_account_set_username(),
2604 modest_server_account_set_password(),
2605 modest_server_account_get_hostname() functions so we do not need to
2606 use the conf API directly.
2608 * src/maemo/modest-main-window.c: (connect_signals):
2609 Actually connect ot the ModestAccountStore::request-password signal,
2610 so that we show the dialog when the password is requested by Tinymail,
2611 for isntance if it is empty.
2613 * src/modest-marshal.list:
2614 * src/modest-tny-account-store.c:
2615 (modest_tny_account_store_class_init), (get_password),
2616 (modest_tny_account_store_alert):
2617 * src/modest-tny-account-store.h:
2618 * src/modest-ui-actions.h:
2619 * src/modest-ui-actions.c:
2620 (modest_ui_actions_on_password_requested):
2621 Change the signal parameters, so it is obvious that we are providing
2622 the non human-readable server name, and receiving both the username
2623 and password, though changing of the username is not yet implemented.
2624 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2625 for the GNOME version.
2627 This should fix the projects.maemo.org bug NB#56209, though it does not
2628 work on Bora, because the gconf_client_get() for the password fails
2629 immediately after we save it with gconf_client_set().
2631 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2634 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2635 caused an undefined symbol error:
2636 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2638 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2640 * src/modest-tny-account-store.c:
2641 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2642 using a GError instead of a string message, so we can translate it in
2645 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2647 * src/maemo/modest-address-book.c:
2648 (modest_address_book_check_names):
2649 * src/maemo/modest-msg-view-window.c:
2650 (modest_msg_view_window_clipboard_owner_change):
2651 * src/modest-init.c: (modest_init_init_ui):
2652 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2653 (update_folders_cb), (modest_mail_operation_update_account):
2654 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2655 (modest_ui_actions_on_msg_attachment_clicked),
2656 (modest_ui_actions_on_msg_recpt_activated):
2657 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2658 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2659 (modest_msg_view_search_next):
2660 * src/widgets/modest-recpt-editor.c:
2661 (modest_recpt_editor_on_button_release_event),
2662 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2663 g_message(). At this point we should only be seeing interesting errors on
2664 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2666 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2668 (modest_wizard_dialog_force_title_update):
2669 * src/maemo/easysetup/modest-wizard-dialog.h:
2670 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2671 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2672 can update the title when appropriate. Otherwise the title is wrong if the
2673 pages are added after adding the notebook to the dialog.
2674 This must be a problem in HildonWizardDialog too.
2675 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2677 * src/maemo/easysetup/modest-easysetup-wizard.c:
2678 (create_subsequent_customsetup_pages),
2679 (create_subsequent_easysetup_pages):
2680 Call modest_wizard_dialog_force_title_update() so that the title is
2681 correct even with GTK+ < 2.10.
2682 This fixes projects.maemo.org bug NB#56145 .
2684 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2686 * src/maemo/modest-platform.c:
2687 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2688 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2691 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2693 * src/widgets/modest-window.h:
2694 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2695 and modest_window_save_state(), which invokes it.
2697 * src/widgets/modest-window-mgr.h:
2698 * src/widgets/modest-window-mgr.c:
2699 Added modest_window_mgr_save_state_for_all_windows(), which calls
2700 the save_state vfunc on all registered windows, if implemented.
2702 * src/gnome/modest-msg-edit-window.c:
2703 * src/gnome/modest-msg-view-window.c:
2704 * src/maemo/modest-msg-edit-window.c:
2705 * src/maemo/modest-msg-view-window.c:
2706 * src/maemo/modest-main-window.c:
2707 Specify the existing save_settings functions as implementations of
2708 ModestWindow::save_state_func().
2710 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2711 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2712 enabling hibernation, for instance.
2714 We may need to do the same thing for restoring settings.
2717 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2719 * src/widgets/modest-window-mgr.c:
2720 * src/widgets/modest-window-mgr.h:
2721 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2722 modest_window_mgr_get_hibernation_is_prevented().
2724 * src/maemo/modest-main-window.c:
2725 (on_hildon_program_is_topmost_notify): Prevent hibernation
2726 (possible when the application goes to the background in the WM),
2727 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2729 * src/maemo/easysetup/modest-easysetup-wizard.c:
2730 (modest_easysetup_wizard_dialog_init):
2731 * src/maemo/modest-account-settings-dialog.c:
2732 (modest_account_settings_dialog_init):
2733 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2734 (modest_connection_specific_smtp_edit_window_init):
2735 * src/maemo/modest-connection-specific-smtp-window.c:
2736 (modest_connection_specific_smtp_window_init):
2737 * src/maemo/modest-signature-editor-dialog.c:
2738 (modest_signature_editor_dialog_init):
2739 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2740 prevent hibernation while any of these account settings dialogs are open.
2742 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2744 * src/maemo/Makefile.am:
2745 * src/maemo/modest-osso-state-saving.c:
2746 * src/maemo/modest-osso-state-saving.h: Added
2747 modest_osso_load_state() and modest_osso_save_state() though they do
2748 nothing now. They should iterate through all the open windows and load/save
2750 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2751 save state when closing.
2753 * src/maemo/modest-main-window.c:
2754 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2755 Add a notification handler for the HildonProgram::is-topmost property,
2756 so we can allow hibernation when the application goes into the background.
2757 But we still need to detect when the accounts setup windows are open so
2758 we can stop hibernation when they are open.
2759 To do this, I also added the main window the HildonProgram. This might have
2760 other side-effects/benefits, and should maybe be done for other windows.
2762 * src/maemo/modest-osso-autosave-callbacks.h:
2763 * src/maemo/modest-osso-autosave-callbacks.c:
2764 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2765 though it does not do anything yet, and we might never need this to do
2766 anything. For instance, we already save drafts.
2768 * src/maemo/modest-platform.c: (modest_platform_init):
2769 Specify the libosso auto-save callback.
2771 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2773 * src/maemo/modest-platform.c:
2774 (modest_platform_set_update_interval):
2775 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2776 aparently stays valid between application instances, so we can use this
2777 to remove and reset it later. According to a maemo-developers email from
2780 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2782 * configure.ac: Depend on libalarm for Maemo.
2784 * src/dbus_api/modest-dbus-api.h:
2785 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2786 (on_send_receive), (modest_dbus_req_handler):
2787 Handle a SEND_RECEIVE D-Bus method.
2789 * libmodest-dbus-client/libmodest-dbus-client.c:
2790 (libmodest_dbus_client_send_and_receive):
2791 * libmodest-dbus-client/libmodest-dbus-client.h:
2792 Add C convenience functions for calling the new D-Bus method.
2794 * src/modest-platform.h:
2795 * src/gnome/modest-platform.c:
2796 * src/maemo/modest-platform.c:
2797 Added modest_platform_set_update_interval(), which uses the
2798 alarmd API on Maemo.
2799 (modest_platform_init),
2800 Call modest_platform_set_update_interval(), using a hard-coded
2801 interval for now (until the global settings dialog is implemented),
2802 though I am not sure that this makes sense yet.
2804 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2806 * src/dbus_api/modest-dbus-callbacks.c:
2807 (modest_osso_cb_hw_state_handler):
2808 * src/dbus_api/modest-dbus-callbacks.h:
2809 * src/maemo/modest-platform.c: (modest_platform_init):
2810 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2811 in case this has some effect on the ability for Maemo to ping the
2814 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2816 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2817 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2818 warning. It is probably a logic error, but I need to fix the build.
2820 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2822 * src/modest-account-mgr.h:
2823 * src/modest-account-mgr.c:
2824 (modest_account_mgr_account_names): Add a gboolean enabled_only
2825 parameter, so we can get lists of onlt the enabled accounts.
2827 (modest_account_mgr_add_account),,
2828 (modest_account_mgr_account_with_display_name_exists):
2829 * src/maemo/modest-msg-edit-window.c: (get_transports):
2830 * src/modest-account-mgr-helpers.c:
2831 (modest_account_mgr_set_first_account_as_default):
2832 * src/modest-init.c: (init_default_account_maybe):
2833 * src/modest-tny-account-store.c: (get_accounts):
2834 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2835 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2836 * tests/check_account-mgr.c: (START_TEST):
2837 Provide the extra parameter, as appropriate.
2839 * src/widgets/modest-account-view.c: (update_account_view):
2840 Do not show disabled accounts (meaning that there is no way to
2841 enable/disable accounts in the UI (the feature is not in our UI
2842 specification), so we can use this internally only to mark unfinished
2843 or temporary account data.
2845 * src/maemo/easysetup/modest-easysetup-wizard.c:
2846 (create_account): Add boolean enable parameter, so we can specify FALSE
2847 to create the temporary account.
2848 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2849 (on_before_next): When finishing, when there is a temporary account, just
2851 Also, use a timeout to delay the showing of the dialog until gconf is likely
2852 to return correct information, due to a maemo gconf bug that is fixed in
2853 osso 1.1, but not yet in Bora.
2854 However, the dialog stays on screen after it is destroyed.
2856 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2857 for invalid data when cancelling. Use a hildon note instead of a dialog
2858 to complain about invalid data. Do not show the account-saved note if the
2859 account is disabled (a temporary account that will not really be saved for use
2862 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2864 * src/modest-account-mgr-helpers.h:
2865 * src/modest-account-mgr-helpers.c:
2866 Added modest_account_mgr_unset_default_account(),
2867 Added modest_account_mgr_set_first_account_as_default().
2869 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2870 If it was the default account, unset the default account name.
2872 * src/maemo/modest-account-view-window.c:
2873 (on_delete_button_clicked): If it was the default account,
2874 set the first remaining account as the default instead.
2876 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2877 a NULL account or a NULL default account, to prevent a crash. This should
2878 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2881 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2883 * src/widgets/modest-recpt-editor.c:
2884 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2885 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2886 TODO comment for this. This fixes the build.
2888 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2889 be the best place for it. This will in future update all auto-update accounts,
2890 rather than just the current/default account, when that gconf key exists.
2891 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2892 if there are no accounts, before calling do_send_receive().
2893 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2895 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2896 * src/maemo/modest-main-window-ui.h:
2897 * src/maemo/modest-main-window.c: (on_connection_changed),
2898 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2899 directly, becaue the signal handler does more.
2901 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2903 * src/modest-account-mgr-helpers.c:
2904 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2905 for the case that the account does not exist.
2907 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2908 (equivalent to the modest account name) rather than the tinymail account name
2909 (equivalent to the modest account title - human readable) to get the account data.
2910 Check for null account data to prevent the crash, and add a TODO comment saying that
2911 this needs fixing because it is using the server account name instead of the account name.
2913 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2915 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2916 * src/maemo/modest-account-settings-dialog.c: (show_error),
2918 Use hildon_note_new_information() for informative and error messages,
2919 which seems to be expected for Maemo applications (no documentation that I know of
2920 says this). I am surprised that there is no distinction between info and error
2923 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2925 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2926 it is easy to find where this is used.
2928 * src/maemo/easysetup/modest-easysetup-wizard.c:
2929 (create_page_welcome), (create_page_account_details),
2930 (create_page_user_details), (create_page_complete_easysetup),
2931 (create_page_custom_incoming), (create_page_custom_outgoing),
2932 (create_page_complete_custom):
2933 * src/maemo/modest-account-settings-dialog.c:
2934 (create_page_account_details), (create_page_user_details),
2935 (create_page_incoming), (create_page_outgoing):
2936 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2937 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2938 (modest_connection_specific_smtp_edit_window_init):
2939 * src/maemo/modest-connection-specific-smtp-window.c:
2940 (modest_connection_specific_smtp_window_init):
2941 * src/maemo/modest-signature-editor-dialog.c:
2942 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2943 and scrolling policy as per the Email Application Layout Guide, if I have
2946 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2948 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2949 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2950 which were empty, because these vfuncs have been removed from TnyAccountStore.
2951 This fixes the build.
2953 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2955 * src/maemo/modest-main-window.c:
2956 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2957 showing/hiding it. Added TODO because it probably should not be NULL.
2958 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2959 because unnecessary g_warnings() make degugging difficult.
2961 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2963 * src/maemo/modest-msg-edit-window.c:
2964 (modest_msg_edit_window_select_color),
2965 (modest_msg_edit_window_select_background_color): 2 const corrections and
2966 moving 2 #endifs before closing brackets, to fix the build.
2968 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2970 * src/maemo/easysetup/modest-easysetup-wizard.h:
2971 * src/maemo/easysetup/modest-easysetup-wizard.c:
2972 (modest_easysetup_wizard_dialog_finalize),
2973 (on_button_edit_advanced_settings), (create_page_complete_custom),
2974 (on_response), (create_account):
2975 Implement the Advanced Settings edit button, by saving the account information,
2976 for the Advanded Settings dialog to use directly from gconf, and removing it
2977 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2978 Bug #5533 in the projects.maemo.org bugzilla.
2980 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/modest-msg-view-window.c:
2983 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2984 when opening a message window.
2986 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2988 * src/maemo/easysetup/modest-easysetup-wizard.c:
2989 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2992 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2993 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2994 gconf settings. I probably added more checks than necessary, but that is safer.
2996 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2997 variable to fix the build, but this seems to be used when it is still NULL.
2999 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3001 * src/modest-platform.h:
3002 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3003 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3004 * src/modest-main.c: Implement this function so we can avoid using
3005 maemo-specific API from cross-platform code.
3007 * src/modest-tny-account-store.c:
3008 (get_smtp_specific_transport_account_for_open_connection):
3009 * src/modest-ui-actions.c: (check_for_connection),
3010 (modest_ui_actions_on_item_not_found):
3011 Use modest_platform_connect_and_wait() and put #idefs around other
3012 maemo-specific code, because only maemo currently has a way to
3013 identify connection names.
3015 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3017 * src/modest-tny-account-store.h:
3018 * src/modest-tny-account-store.c:
3019 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3020 the connection-specific SMTP server settings in the configuration.
3022 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3024 * src/maemo/modest-main-window.c: (on_connection_changed),
3026 * src/modest-main.c: (main), (start_ui), (send_mail):
3027 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3028 that is what is intended.
3030 * src/modest-ui-actions.c: (action_send), (action_receive),
3031 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3032 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3033 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3034 SMTP server is used when it is specified.
3036 (modest_ui_actions_on_send_receive):
3037 Check that a connection is open before proceeding.
3038 Receive and then send, instead of vice-versa, as per the specification.
3040 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3042 * src/modest-mail-operation.c:
3043 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3044 though I guess it should be something other than NULL.
3046 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3048 * src/maemo/easysetup/modest-easysetup-wizard.c:
3049 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3050 combo twice, to avoid an g_warning and to make it visible again.
3051 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3052 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3053 (already intended) dereference when detaching, because we then recreate the menu.
3054 But I am not sure why the warning was happening, and it is possible that this is a memory
3057 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3059 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3060 and uri_parse_mailto() utility functions.
3061 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3063 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3065 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3067 * src/dbus_api/modest-dbus-api.h:
3068 * src/dbus_api/modest-dbus-callbacks.c:
3069 Use an idle callback to execute the modest code in the application's own thread.
3070 Remove the helloworld example method.
3071 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3072 parsed, and the open-message method is not implemented because this is not yet implemented in
3074 * libmodest-dbus-client/libmodest-dbus-client.c:
3075 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3076 (libmodest_dbus_client_open_message):
3077 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3079 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3080 body without crashing.
3082 * tests/dbus_api/Makefile.am:
3083 * tests/dbus_api/test_mail_to.c:
3084 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3086 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3088 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3089 Added file to fix the build. Sorry.
3091 * src/dbus_api/Makefile.am:
3092 * src/dbus_api/modest-dbus-api.h:
3093 * src/dbus_api/modest-dbus-callbacks.h:
3094 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3095 (modest_dbus_req_handler):
3096 Put constants in a separate header so it can be reused by the
3097 client library, without duplication
3099 * libmodest-dbus-client/Makefile.am:
3100 * libmodest-dbus-client/libmodest-dbus-client.c:
3101 (libmodest_dbus_client_call_helloworld),
3102 (libmodfest_dbus_client_send_mail),
3103 (libmodfest_dbus_client_mailto),
3104 (libmodfest_dbus_client_open_message):
3105 * libmodest-dbus-client/libmodest-dbus-client.h:
3106 (Partly) Implement a send_mail D-Bus method.
3108 * tests/dbus_api/Makefile.am:
3109 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3110 the send_email D-Bus method.
3112 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3116 * libmodest-dbus-client/Makefile.am:
3117 * libmodest-dbus-client/libmodest-dbus-client.c:
3118 * libmodest-dbus-client/libmodest-dbus-client.h:
3119 * tests/dbus_api/Makefile.am:
3120 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3121 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3123 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3125 * src/maemo/easysetup/modest-easysetup-wizard.c:
3126 (create_page_account_details):
3127 * src/maemo/modest-account-settings-dialog.c:
3128 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3129 widgets, because this might not be the default in future versions of the Maemo GTK+.
3130 However, I can not not get capitalization to work even in a simple test case.
3132 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3134 * src/maemo/easysetup/modest-easysetup-wizard.c:
3135 (create_page_custom_incoming), (create_page_custom_outgoing):
3136 * src/maemo/modest-account-settings-dialog.c:
3137 (create_page_account_details), (create_page_incoming),
3138 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3139 instead of using gtk_check_button_with_label(), so they are aligned like the other
3140 widgets, as per the UI spec.
3142 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3144 * src/maemo/easysetup/modest-easysetup-wizard.c:
3145 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3146 * src/widgets/modest-validating-entry.c:
3147 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3148 Modest prefix instead of an EasySetup prefix.
3150 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3152 * src/widgets/modest-validating-entry.h:
3153 * src/widgets/modest-validating-entry.c: (on_insert_text),
3154 Added easysetup_validating_entry_set_max_func(), used to set a callback
3155 to call when the max number of characters is reached. GtkEntry has a max-length
3156 already but is silent about it.
3158 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3159 (create_page_account_details), (create_page_user_details),
3161 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3162 (create_page_account_details), (create_page_user_details),
3163 (create_page_outgoing):
3164 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3165 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3166 the UI spec, when the user tries to enter more than the max number of characters.
3168 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3170 * src/maemo/easysetup/modest-easysetup-wizard.c:
3171 (create_page_user_details), (create_page_custom_incoming),
3172 (create_page_custom_outgoing):
3173 * src/maemo/modest-account-settings-dialog.c:
3174 (create_page_user_details), (create_page_incoming),
3175 (create_page_outgoing):
3176 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3177 (modest_connection_specific_smtp_edit_window_init):
3178 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3179 not appropriate. Bad Maemo-specific defaults!.
3181 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3183 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3184 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3185 (modest_signature_editor_dialog_set_settings):
3186 Disable the label and textview when the checkbox is disabled, and use the
3187 specified (UI spec) default signature text.
3189 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3191 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3192 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3194 * src/modest-defs.h:
3195 * src/modest-account-mgr-helpers.h:
3196 * src/modest-account-mgr-helpers.c:
3197 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3199 * src/maemo/Makefile.am:
3200 * src/maemo/modest-signature-editor-dialog.c:
3201 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3204 * src/maemo/modest-account-settings-dialog.h:
3205 * src/maemo/modest-account-settings-dialog.c:
3206 (modest_account_settings_dialog_finalize), (on_button_signature),
3207 (save_configuration): Use the new dialog when the Edit button is pressed, and
3208 save the changes if necessary, as per the UI spec.
3210 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3212 * src/maemo/Makefile.am:
3213 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3214 based on maemo-develoers email from Dirk.
3216 * src/maemo/easysetup/modest-easysetup-wizard.c:
3217 (create_page_welcome), (create_page_account_details),
3218 (create_page_user_details), (create_page_complete_easysetup),
3219 (create_page_custom_incoming), (create_page_custom_outgoing),
3220 (create_page_complete_custom),
3221 (modest_easysetup_wizard_dialog_init):
3222 * src/maemo/modest-account-settings-dialog.c:
3223 (create_page_account_details), (create_page_user_details),
3224 (create_page_incoming), (create_page_outgoing),
3225 (modest_account_settings_dialog_init):
3226 * src/maemo/modest-connection-specific-smtp-window.c:
3227 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3229 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/easysetup/modest-easysetup-wizard.c:
3232 (create_page_account_details), (create_page_custom_outgoing),
3233 (create_page_complete_custom):
3234 * src/maemo/modest-account-settings-dialog.c:
3235 (create_page_user_details), (create_page_incoming),
3236 (create_page_outgoing):
3237 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3238 (modest_connection_specific_smtp_edit_window_init):
3239 Use the correct (UI spec) port min/max, and use horizontal separators,
3242 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3244 * src/maemo/easysetup/modest-easysetup-wizard.c:
3245 (set_default_custom_servernames):
3246 * src/maemo/modest-account-settings-dialog.c:
3247 (create_page_incoming), (on_combo_outgoing_security_changed),
3248 (on_combo_incoming_security_changed), (create_page_outgoing),
3249 (modest_account_settings_dialog_set_account_name),
3250 (save_configuration):
3251 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3252 (on_combo_security_changed),
3253 (modest_connection_specific_smtp_edit_window_init),
3254 (modest_connection_specific_smtp_edit_window_set_connection),
3255 (modest_connection_specific_smtp_edit_window_get_settings):
3256 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3259 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3262 * src/maemo/easysetup/modest-easysetup-wizard.c:
3263 (create_page_custom_outgoing), (create_page_complete_custom):
3264 * src/maemo/modest-account-settings-dialog.c:
3265 (create_page_user_details), (create_page_outgoing):
3266 * src/maemo/modest-account-view-window.c: (button_box_new):
3267 Use changed logical IDs as per the most recent UI spec:
3268 mcen_bd_emailsetup_edit -> mcen_bd_edit
3269 mcen_bd_emailsetup_delete -> mcen_bd_delete
3270 mcen_bd_emailsetup_close -> mcen_bd_close
3272 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3276 * src/dbus_api/Makefile.am:
3277 * src/dbus_api/modest-dbus-callbacks.c:
3278 * src/dbus_api/modest-dbus-callbacks.h:
3279 * src/maemo/modest-platform.c: (modest_platform_init):
3280 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3282 * tests/Makefile.am:
3283 * tests/dbus_api/Makefile.am:
3284 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3286 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3288 * src/maemo/modest-account-settings-dialog.c:
3289 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3290 Removed unnecessary includes.
3292 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3294 * src/maemo/easysetup/modest-easysetup-wizard.c:
3295 * src/maemo/modest-account-settings-dialog.c:
3296 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3297 * src/widgets/Makefile.am:
3298 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3299 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3300 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3301 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3302 * src/widgets/modest-secureauth-combo-box.c:
3303 * src/widgets/modest-secureauth-combo-box.h:
3304 * src/widgets/modest-serversecurity-combo-box.c:
3305 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3306 made the GObject names more consistent with the rest of the Modest code.
3308 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3310 * src/maemo/easysetup/Makefile.am:
3311 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3312 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3313 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3314 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3315 * src/maemo/easysetup/modest-easysetup-wizard.c:
3316 * src/maemo/easysetup/modest-validating-entry.c:
3317 * src/maemo/easysetup/modest-validating-entry.h:
3318 * src/maemo/modest-account-settings-dialog.c:
3319 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3320 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3321 widgets/ because they are used outside of easysetup too. After checking in,
3322 svn will allow me to rename them too.
3324 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3326 * src/gnome/modest-msg-edit-window.c:
3327 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3328 linker error, to fix the build on the GNOME platform.
3329 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3330 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3331 ifdefed out to avoid a warning.
3333 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3335 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3336 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3337 some alternative for GTK+ 2.6.
3339 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3341 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3343 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3344 specified for EmailAccountsDialog in UI spec.
3346 * src/maemo/easysetup/modest-easysetup-wizard.c:
3347 * src/maemo/easysetup/modest-easysetup-wizard.h:
3348 * src/maemo/modest-account-settings-dialog.c:
3349 * src/maemo/modest-account-settings-dialog.h:
3350 Reuse a member window widget for the connection-specific SMTP server accounts,
3351 so we can tell it to create/save the accounts only if we actually save changes.
3353 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3354 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3355 (modest_connection_specific_smtp_edit_window_get_settings):
3356 Return a struct instance for temporarily remembering the entered data.
3358 * src/maemo/modest-connection-specific-smtp-window.h:
3359 * src/maemo/modest-connection-specific-smtp-window.c:
3360 (modest_connection_specific_smtp_window_finalize),
3361 (modest_connection_specific_smtp_window_fill_with_connections),
3363 (modest_connection_specific_smtp_window_save_server_accounts),
3364 (update_model_server_names): Do not actually save data until asked,
3365 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3367 (on_selection_changed),
3368 (modest_connection_specific_smtp_window_init): Disable the edit
3369 button when nothing is selected.
3371 * src/modest-account-mgr-helpers.c:
3372 * src/modest-account-mgr-helpers.h:
3373 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3376 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3378 * src/modest-account-mgr-helpers.h:
3379 * src/modest-account-mgr-helpers.c:
3380 (modest_account_mgr_get_unused_account_name),
3381 (modest_account_mgr_get_unused_account_display_name): Added these
3382 utility functions, to avoid code duplication.
3384 * src/maemo/easysetup/modest-easysetup-wizard.c:
3385 (create_page_account_details), (create_account):
3386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3387 (on_combo_security_changed),
3388 (modest_connection_specific_smtp_edit_window_init),
3389 (modest_connection_specific_smtp_edit_window_save_settings):
3390 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3391 * src/maemo/modest-connection-specific-smtp-window.c:
3392 (modest_connection_specific_smtp_window_finalize),
3393 (modest_connection_specific_smtp_window_fill_with_connections),
3394 (on_button_edit), (modest_connection_specific_smtp_window_init):
3395 * src/maemo/modest-connection-specific-smtp-window.h:
3396 Implementing saving of connection-specific server accounts.
3398 But I need to refactor this so we can save the data for each
3399 possible connection-specific account and only actually create the server accounts
3400 when the easysetup finished, or the OK button is pressed on the account settings
3403 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3405 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3406 (on_combo_security_changed):
3407 (modest_connection_specific_smtp_edit_window_init):
3408 Auto-fill the port number as in the account settings.
3410 (modest_connection_specific_smtp_edit_window_set_connection):
3411 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3412 * src/maemo/modest-connection-specific-smtp-window.c:
3413 (fill_with_connections), (on_button_edit),
3414 (modest_connection_specific_smtp_window_init):
3415 Turn the edit window into a dialog to simplify the code, and
3416 set a WM hint as in a GtkDialog, because only a popup can be on top of
3417 another window in Maemo, and popups usually have no WM decoration.
3419 * src/modest-defs.h:
3420 * src/modest-account-mgr-helpers.c:
3421 (modest_account_mgr_set_connection_specific_smtp),
3422 (modest_account_mgr_remove_connection_specific_smtp),
3423 (modest_account_mgr_get_connection_specific_smtp):
3424 * src/modest-account-mgr-helpers.h: Some functions to write the
3425 connection-specific SMTP server information. Not yet used.
3428 * src/widgets/modest-folder-view.c: (text_cell_data):
3429 Fix a warning about an uninitialized variable.
3430 (on_configuration_key_changed): Put an #ifdef around the use
3431 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3433 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3435 * src/maemo/modest-account-settings-dialog.h:
3436 * src/maemo/modest-account-settings-dialog.c:
3437 Added connect_for_modified() utility function to mark the new modified boolean.
3439 (create_page_account_details), (create_page_user_details),
3440 (create_page_incoming), (create_page_outgoing), (on_response),
3441 (modest_account_settings_dialog_init),
3442 (modest_account_settings_dialog_set_account_name):
3443 Only warn about unsaved changes when there are actually unsaved changes.
3445 * src/modest-account-mgr-helpers.c:
3446 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3447 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3448 to get the data from there in future.
3450 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3452 * src/modest-defs.h:
3454 * src/modest-account-mgr-helpers.h:
3455 * src/modest-account-mgr-helpers.c:
3456 Store the security account setting in a single conf key instead of using
3457 the options list, so that the list is left for just the to-be-removed camel hack,
3458 and because gconf_client_set_list() is failing for some reason.
3460 * src/modest-account-mgr.c:
3461 (modest_account_mgr_add_server_account):
3462 * src/maemo/modest-account-settings-dialog.c:
3463 (modest_account_settings_dialog_set_account_name),
3464 (save_configuration): Use the renamed functions.
3467 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3469 * src/widgets/Makefile.am:
3470 * src/widgets/modest-limit-retrieve-combo-box.c:
3471 * src/widgets/modest-limit-retrieve-combo-box.h:
3472 * src/widgets/modest-retrieve-combo-box.c:
3473 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3474 the account settings dialog.
3476 * src/modest-defs.h:
3477 * src/modest-account-mgr-helpers.h:
3478 * src/modest-account-mgr-helpers.c:
3479 (modest_server_account_get_option_secure_auth),
3480 (modest_server_account_set_option_secure_auth):
3481 * src/modest-account-mgr.c:
3482 (modest_account_mgr_add_server_account):
3483 Use the existing AUTH_MECH conf key for the secure-auth setting,
3484 instead of putting it in the list options, because this was actually used already.
3486 * src/maemo/modest-account-settings-dialog.c:
3487 (create_page_account_details),
3488 (modest_account_settings_dialog_set_account_name),
3489 (save_configuration):
3490 * src/maemo/modest-account-settings-dialog.h:
3491 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3492 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3494 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3496 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3497 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3498 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3500 * src/modest-defs.h:
3501 * src/maemo/modest-account-settings-dialog.c:
3502 (create_page_incoming), (on_combo_outgoing_security_changed),
3503 (on_combo_incoming_security_changed), (create_page_outgoing),
3504 (modest_account_settings_dialog_set_account_name),
3505 (save_configuration): Load/Save the port number, and change it when the
3506 security combo changes, to suitable defaults.
3508 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3510 * src/modest-account-mgr.c:
3511 (modest_account_mgr_add_server_account): Set the security and secure-auth
3512 options, and add a comment saying that the other camel-specific options should be
3515 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3517 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3519 * src/modest-tny-account-store.c: (account_list_free),
3520 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3521 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3524 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3526 * src/modest-protocol-info.c:
3527 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3528 is required by our UI spec. Maybe something in our implementation will use this eventually.
3529 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3530 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3531 instead of the previous 0 placeholder.
3533 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3534 secure-auth settings.
3535 * src/modest-account-mgr-helpers.h:
3536 * src/modest-account-mgr-helpers.c:
3537 (modest_server_account_data_get_option_secure_auth),
3538 (modest_server_account_set_option_secure_auth),
3539 (modest_server_account_data_get_option_security),
3540 (modest_server_account_set_option_security): Added this API for getting and setting the security
3541 and secure-auth settings.
3543 * src/maemo/modest-account-settings-dialog.h:
3544 * src/maemo/modest-account-settings-dialog.c:
3545 (modest_account_settings_dialog_finalize), (check_data),
3546 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3547 about changing titles.
3548 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3549 (save_configuration): Save the security and secure-auth settings.
3551 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3552 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3554 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3556 * src/modest-defs.h:
3557 * src/modest-account-mgr.c:
3558 (modest_account_mgr_add_server_account):
3559 Added and used defines for the options key and value pair strings,
3560 that are used so far, though they do not seem to correspond to anything in our
3561 UI specs or ModestProtocol enum.
3563 * src/modest-account-mgr-helpers.h:
3564 * src/modest-account-mgr-helpers.c:
3565 (compare_option_strings_for_name),
3566 (modest_server_account_data_get_option_value),
3567 (modest_server_account_data_get_option_bool),
3568 (modest_account_mgr_get_server_account_option):
3569 Added helper functions for parsing the options GSList.
3571 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3573 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3574 display name is based on the supplied account name.
3575 * src/modest-account-mgr.c:
3576 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3577 with an inefficient, but good-enough, implementation.
3579 * src/maemo/easysetup/modest-easysetup-wizard.c:
3580 (create_page_account_details), (on_before_next), (create_account):
3581 Check for existing display names rather than (non-user-visible) account names, and just
3582 create and set a unique account name at the end.
3584 * src/maemo/modest-account-settings-dialog.c:
3585 (modest_account_settings_dialog_init),
3586 (modest_account_settings_dialog_set_account_name),
3587 (create_page_incoming): Show the display name, instead of the account name.
3588 (on_response): Do some (not all) extra checks, as in the UI spec.
3589 (save_configuration): Save the display name if it was changed.
3591 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3593 * po/en_GB.po: Added needed logical ID and translation.
3594 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3595 (init_view): Made the is-default column clicking work.
3597 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3600 * src/maemo/easysetup/Makefile.am:
3601 * src/maemo/easysetup/modest-easysetup-wizard.c:
3602 (modest_easysetup_wizard_dialog_init):
3603 * src/maemo/easysetup/provider-data-test.keyfile:
3604 * src/maemo/easysetup/provider-data.keyfile:
3605 Moved the provider data file to the new modest-providers-data package and used it from there.
3607 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3609 * src/modest-local-folder-info.c:
3610 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3611 N_() was already used on the static strings, but this just marks it for translation without
3612 using the translation.
3614 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3616 * src/maemo/modest-account-settings-dialog.c:
3617 (create_page_incoming),
3618 (modest_account_settings_dialog_set_account_name):
3619 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3620 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3621 I will do this if nobody else gets there first.
3623 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3625 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3626 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3627 save the security stuff.
3629 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3631 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3632 Set the email address and user fullname, which I now see must be
3635 * src/maemo/modest-account-settings-dialog.h:
3636 * src/maemo/modest-account-settings-dialog.c:
3638 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3639 leave-on-server and authentication.
3640 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3643 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3646 * src/maemo/modest-account-settings-dialog.c:
3647 * src/maemo/modest-account-settings-dialog.h:
3648 Most (but not all) of the widgets are now present as specified by the UI spec.
3649 No changes are yet saved, and some details are not properly shown yet.
3651 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3653 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3655 * src/maemo/Makefile.am:
3656 * src/maemo/modest-account-settings-dialog.c:
3657 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3658 an existing account. Doesn't do much yet.
3660 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3661 Open the accounts settings dialog when Edit is clicked.
3663 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3665 * src/maemo/easysetup/Makefile.am:
3666 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3668 * src/maemo/easysetup/modest-easysetup-wizard.c:
3669 (modest_easysetup_wizard_dialog_init):
3670 Try to get the source directory from the build system,
3671 instead of hard-coding "./" into the source code, when opening our local
3672 copies of the configuration files.
3673 But this still fails when opening the wizard from the Accounts window,
3674 maybe because the working directory seems to change at runtime.
3675 So the wizard will fail the second time unless you copy the files into their
3676 proper locations - see the stdout warnings for the paths.
3678 (create_page_account_details),(on_before_next):
3679 Check for existing non-server accounts instead of server accounts,
3680 so the default account name is useful again, and to prevent trying to
3683 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3684 Show the wizard when New is clicked.
3686 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3687 (init_view): Show the column headers, and show the columns that are
3688 specified in the UI specs. However, something in Maemo's GTK+ prevents
3689 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3690 change the default account. This is despite unsetting the special properties.
3692 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3694 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3695 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3696 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3697 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3698 to make that clearer.
3699 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3701 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3703 * src/maemo/modest-account-view-window.c:
3704 (modest_account_view_window_init),
3705 (modest_account_view_window_new):
3706 Use the same buttons as specified in the
3707 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3708 the existing widgets, which never had a chance of working.
3709 Put the ModestAccountView treeview in a scrolled window.
3710 Do not repeat the initialization in both _init() and _new().
3712 * src/widgets/modest-account-view.c: (update_account_view):
3713 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3714 this widget and window shows no accounts.
3716 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3718 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3720 * src/maemo/easysetup/modest-easysetup-wizard.c:
3721 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3722 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3723 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3726 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3727 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3728 accounts exist yet, as in the UI spec.
3730 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3732 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3734 * src/maemo/Makefile.am:
3735 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3736 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3737 New window for editing connection-specific smtp details.
3738 Not fully implemented.
3740 * src/maemo/modest-connection-specific-smtp-window.c:
3741 (modest_connection_specific_smtp_window_finalize) :
3742 unref the tree model.
3743 (on_button_edit): Show the edit window.
3745 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3747 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3750 * src/maemo/Makefile.am:
3751 * src/maemo/modest-connection-specific-smtp-window.c:
3752 * src/maemo/modest-connection-specific-smtp-window.h:
3753 New window for showing the list of connections, for connection-specific
3754 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3755 * src/maemo/easysetup/modest-easysetup-wizard.c:
3756 (create_page_custom_outgoing): Show the new window when the button is clicked.
3758 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3760 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3761 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3762 * src/maemo/modest-msg-edit-window.c:
3763 (modest_msg_edit_window_insert_image):
3764 * src/modest-conf.c: (modest_conf_key_escape):
3765 * src/modest-mail-operation.c:
3766 (modest_mail_operation_send_new_mail):
3767 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3768 (modest_ui_actions_on_new_account):
3769 * src/widgets/modest-attachment-view.c: (update_filename_request):
3770 * src/widgets/modest-mail-header-view.c:
3771 Corrected warnings that were breaking the build, by commenting out unused variables,
3772 and a function, and by including a header.
3774 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3776 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3777 so we can #ifdef around platform-specific code when necessary.
3778 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3779 to allow this to build for the GNOME platform too.
3781 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3783 * src/maemo/easysetup/modest-easysetup-wizard.c:
3784 Added util_increment_name() and used it in create_page_account_details()
3785 to make sure that the default account name is always a new name.
3787 (modest_easysetup_wizard_dialog_init),
3788 (set_default_custom_servernames): Some minor memory management fixes.
3790 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3794 * src/modest-runtime.c: (init_i18n): Restored the translation
3795 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3796 are defined in config.h, and the translations are installed.
3798 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3799 is defined for translation.
3801 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3803 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3805 * src/maemo/easysetup/modest-easysetup-wizard.c:
3806 (modest_easysetup_wizard_dialog_init):
3807 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3808 Use realistic paths (though they should use $prefix generically) to the
3809 mcc_mapping and provider-data.keyfile files which might work when they
3810 are installed by the future version of the operator-wizard package,
3811 and then fallback to paths in our source code, with an explanatory
3814 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3818 * src/maemo/Makefile.am:
3819 * src/maemo/easysetup/: Added files from the previously-exernal
3820 osso-modest-easysetup.
3821 * src/maemo/modest-main-window-ui.h:
3822 * src/modest-ui-actions.c:
3823 * src/modest-ui-actions.h:
3824 Added modest_ui_actions_on_new_account() as a signal handler for the
3825 New Account menu item. It shows the easysetup wizard.
3826 * po/en_GB.po: Added additional needed logical IDs and translations.