1 2007-07-23 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
4 (add_folders_to_list), (on_dbus_method_get_folders),
5 (modest_dbus_req_filter):
6 * src/maemo/modest-maemo-utils.c:
7 (on_camel_account_get_supported_secure_authentication):
8 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
9 (on_header_view_focus_in):
10 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
11 * src/modest-formatter.c: (modest_formatter_create_body_part):
12 * src/modest-mail-operation.c: (recurse_folders),
13 (update_account_thread), (get_msgs_full_thread),
14 (modest_mail_operation_get_msgs_full),
15 (modest_mail_operation_xfer_msgs):
16 * src/modest-search.c: (search_mime_part_and_child_parts),
17 (modest_search_account), (modest_search_all_accounts):
18 * src/modest-tny-account.c:
19 (modest_tny_account_get_special_folder), (recurse_folders):
20 * src/modest-tny-local-folders-account.c:
21 (modest_tny_local_folders_account_query_passes):
22 * src/modest-tny-msg.c: (copy_mime_part),
23 (modest_tny_msg_find_body_part_from_mime_part):
24 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
25 (modest_tny_send_queue_try_to_send):
26 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
27 (_modest_ui_actions_open), (download_uncached_messages),
28 (reply_forward), (modest_ui_actions_on_copy),
29 (modest_ui_actions_on_details), (has_retrieved_msgs),
30 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
32 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
33 (_selected_msg_marked_as), (_msg_download_completed),
34 (_selected_msg_sent_in_progress):
35 * src/widgets/modest-attachments-view.c:
36 (modest_attachments_view_set_message):
37 * src/widgets/modest-msg-view.c: (find_cid_image):
38 * tests/check_folder-transfer.c: (find_folders):
39 * tests/check_update-account.c: (func):
40 * tests/dbus_api/test_get_folders.c: (main):
41 Checked all uses of tny_iterator_get_current(), making sure
42 that the object is unreferenced (3 or 4 places did not),
43 and adding checks for NULL.
45 2007-07-23 Murray Cumming <murrayc@murrayc.com>
47 * src/dbus_api/modest-dbus-callbacks.c:
48 (on_idle_open_default_inbox): Make sure that the application UI is
50 * src/maemo/easysetup/modest-easysetup-wizard.c:
51 (on_entry_invalid_character): Show the word whitespace instead
52 of (null) in the banner when whitespace was entered.
53 (show_error): Add a comment that this does not work in
54 Maemo Bora, though we do not know why.
56 2007-07-23 Murray Cumming <murrayc@murrayc.com>
58 * src/modest-tny-account.c:
59 (modest_tny_account_get_special_folder): Use an if instead of
60 an assert for when the parent account name is NULL, because this
61 might be causing a crash in projects.maemo.org bug 63192.
62 * src/modest-mail-operation.c:
63 (modest_mail_operation_send_new_mail_cb),
64 (modest_mail_operation_remove_folder): unref the folder that is
65 returned from modest_tny_account_get_special_folder().
67 2007-07-23 Murray Cumming <murrayc@murrayc.com>
69 * src/modest-ui-actions.c:
70 (modest_ui_actions_on_password_requested):
71 Show mail_ib_login_cancelled info banner when the user cancels
72 the protected password dialog, to fix projects.maemo.org
75 2007-07-23 Murray Cumming <murrayc@murrayc.com>
77 * src/maemo/modest-account-settings-dialog.c:
78 (create_page_outgoing): Put this page in a GtkScrolledWindow,
79 matching the UI mock-up in the UI spec, and allowing access
80 to all widgets even when the on-screen keyboard is active.
82 2007-07-23 Murray Cumming <murrayc@murrayc.com>
84 Reverted this previous commit from Johannes,
85 because the scrollbars are always visible and because
86 I think we only need it on onepage of the account
87 settings, not the account wizard.
88 (I wrote the wrong instructions in the bug.)
90 * src/maemo/easysetup/modest-easysetup-wizard.c:
91 Added scrollbars to account wizard dialog.
92 Fixed projects.maemo.org NB #62744
94 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
96 * src/maemo/easysetup/modest-easysetup-wizard.c:
97 (create_page_user_details):
98 Use auto-cap for name (projects.maemo.org NB#63716)
99 * src/widgets/modest-account-view.c: (on_account_busy_changed):
101 2007-07-22 Armin Burgmeier <armin@openismus.com>
103 * src/maemo/modest-ui-actions.c: Use current account instead of
104 default account for creating viewer windows, so that the viewer
105 window knows to which account the viewed message belongs.
107 * src/maemo/modest-msg-view-window.c: Destroy the window when the
108 corresponding account is deleted. This fixes projects.maemo.org bug
111 2007-07-18 Armin Burgmeier <armin@openismus.com>
113 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
114 the dialog close after entering an invalid port number and clicking
115 OK. This fixes projects.maemo.org bug NB#63602.
117 2007-07-18 Armin Burgmeier <armin@openismus.com>
119 * src/modest-tny-account-store.c:
120 (get_server_accounts): Set parent modest account name for each
121 connection-specific transport account so that special folders of such
122 an account can be looked up. This fixes a crash when changing account
123 settings. This might also be related to projects.maemo.org bug
126 2007-07-16 Armin Burgmeier <armin@openismus.com>
128 * src/modest-ui-actions.c: Added a button to create a folder to the
129 move-to dialog. This fixes projects.maemo.org bug NB#.
131 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
133 * src/maemo/easysetup/modest-easysetup-wizard.c:
134 Added scrollbars to account wizard dialog.
135 Fixed projects.maemo.org NB #62744
137 2007-07-16 Murray Cumming <murrayc@murrayc.com>
139 * src/widgets/modest-msg-view.h:
140 * src/widgets/modest-msg-view.c:
141 Added modest_msg_view_get_message_is_empty() but this needs
143 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
144 Check if there is any text in the message yet.
145 But this needs to be implemented properly.
146 (modest_msg_edit_window_toggle_find_toolbar):
147 * src/maemo/modest-msg-view-window.c:
148 (modest_msg_view_window_toggle_find_toolbar):
149 Show a banner warning if there is no text to search, when
150 trying to start a search. This partially fixes
151 projects.maemo.org bug NB#62350.
153 2007-07-13 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-mail-operation.c: (update_account_thread):
156 Initialized num_new_headers to fix the build.
158 2007-07-13 Murray Cumming <murrayc@murrayc.com>
160 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
161 Ignore modest accounts whose server accounts don't exist in gconf.
162 This prevents us trying to create TnyAccount instances for those
163 server accounts when the server account has been removed from gconf,
164 but the parent modest account has not yet been removed from modest.
165 I don't know why this is only noticeable now. It was probably just
166 a harmeless g_warning() anyway.
168 2007-07-13 Murray Cumming <murrayc@murrayc.com>
170 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
171 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
173 2007-07-12 Armin Burgmeier <armin@openismus.com>
175 * src/maemo/modest-main-window.c: Make default account appear bold
176 in view, tools/send & receive and toolbar/send & receive SCM menus.
177 This fixes projects.maemo.org bug NB#59010.
179 2007-07-12 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
182 Add a short-cut, by checking if the folder store is an account.
183 This ensures that the Sort menu item and toolbar is dimmed for
184 the local-folders account root item, fixing
185 projects.maemo.org bug NB#62545.
187 2007-07-12 Murray Cumming <murrayc@murrayc.com>
189 * src/modest-tny-account-store.c: (get_password):
190 Show the password dialog (via the signal) only in the mainloop, via
191 an idle handler that we wait for. This could theoretically prevent
192 hangs, though I worry that it could introduce some too.
194 2007-07-12 Murray Cumming <murrayc@murrayc.com>
196 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
197 * src/maemo/modest-platform.c:
198 (modest_platform_connect_and_wait):
199 Take a TnyAccount* parameter and try to set it to online
200 (a TnyCamel-only API), because tinymail sets accounts to offline
201 when the user cancels a password dialog, and doesn't ask again until
202 it has been set to online.
203 However, this is commented out because it causes a hang now.
205 (modest_platform_connect_and_wait_if_network_account):
206 * src/modest-mail-operation.c:
207 (modest_mail_operation_update_account):
208 * src/modest-platform.h:
209 * src/modest-ui-actions.c: (_modest_ui_actions_open),
210 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
212 2007-07-12 Armin Burgmeier <armin@openismus.com>
214 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
216 * src/modest-mail-operation.c:
217 * src/modest-ui-actions.c: Check for already existing folder before
218 querying the server, show error message from camel if the request
219 still fails. This fixes projects.maemo.org bug NB#58701.
221 2007-07-12 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-tny-account-store.h:
224 * src/modest-tny-account-store.c:
225 Added modest_tny_account_store_forget_password_in_memory(),
226 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
227 when creating a new account, so that new passwords will be used, instead of
228 us thinking that it's a second request as a result of a failed password again.
230 2007-07-12 Murray Cumming <murrayc@murrayc.com>
232 * src/dbus_api/modest-dbus-callbacks.c:
233 (on_idle_open_message): If the message is in drafts then open it
234 in an edit window instead of a view window. This fixes
235 projects.maemo.org bug NB#63005.
237 2007-07-12 Murray Cumming <murrayc@murrayc.com>
239 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
240 Avoided a harmless g_warning().
242 2007-07-12 Murray Cumming <murrayc@murrayc.com>
244 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
245 Pass the modest account name, not the TnyAccount display name to
246 modest_msg_view_window_new() so that the reply feature works,
247 fixing projects.maemo.org bug NB#62892.
249 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
250 (modest_msg_view_window_new_with_header_model):
251 * src/maemo/modest-msg-view-window.c:
252 (modest_msg_view_window_new_with_header_model),
253 (modest_msg_view_window_new):
254 * src/modest-ui-actions.c: (reply_forward):
255 * src/widgets/modest-msg-view-window.h:
256 * src/widgets/modest-window.c: (modest_window_set_active_account):
257 Rename an account parameter to modest_account_name to make this clearer.
259 2007-07-11 Murray Cumming <murrayc@murrayc.com>
261 * src/modest-ui-actions.h:
262 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
263 modest_do_message_delete().
264 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
265 Call modest_do_message_delete(), hoping that this would cause messages
266 to be really deleted from search instead of just marked with strike through.
267 Does not seem to help.
269 2007-07-11 Armin Burgmeier <armin@openismus.com>
271 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
272 priv->reselect to FALSE prior to calling
273 modest_folder_view_select_first_inbox_or_local() to prevent endless
274 recursion and thus a crash on startup.
276 2007-07-11 Armin Burgmeier <armin@openismus.com>
278 * src/maemo/modest-account-settings-dialog.h: Include
279 <gtk/gtknotebook.h> to fix the build (at least for me).
281 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
282 Use "New FolderN" as default suggested name if "New folder" already
283 exists, with N being the first free number, though never exceed "New
284 folder99" in which case we just fall back to "New Folder" even though
285 it already exists. This fixes projects.maemo.org bug NB#58663.
287 2007-07-11 Murray Cumming <murrayc@murrayc.com>
289 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
290 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
291 projects.maemo.org bug NB#62778.
293 2007-07-11 Murray Cumming <murrayc@murrayc.com>
295 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
296 Ignore the wrong (for now) secure-smtp setting in the presets -
297 just default to requiring secure authentication for SMTP, because
300 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
302 * src/widgets/modest-folder-view.c: (filter_row)
303 Do not show drafts folder (see UI specs)
305 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
307 * src/modest-ui-actions.c:
308 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
309 place and also not necessary.
311 * src/widgets/modest-folder-view.c: (filter_row)
312 Guess folder type and hide Sent & Outbox if necessary.
313 Fixed project.maemo.org NB#57328
315 2007-07-11 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-ui-actions.h:
318 * src/modest-ui-actions.c:
319 (modest_ui_actions_on_delete_message):
320 Move some code into a new
321 modest_ui_actions_refresh_message_window_after_delete()
322 function so we can use it from elsewhere.
324 * src/dbus_api/modest-dbus-callbacks.c:
325 (on_idle_delete_message), (on_delete_message): Used an idle
326 handler, as we do for the other D-Bus method handlers.
327 Call modest_ui_actions_refresh_message_window_after_delete()
328 if the deleted message was open in a window. This fixed
329 projects.maemo.org bug NB#62862.
331 2007-07-11 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-main.c: (main): Only show the UI at the start if
334 the showui command line option was given. For instance,
335 run-standalone src/modest showui
336 Otherwise, we wait for the top_application D-Bus method to
337 be sent by hildon-desktop when the application is selected
339 This allows us to run without a UI when osso-global-search
340 uses our D-Bus methods.
342 2007-07-11 Murray Cumming <murrayc@murrayc.com>
344 * src/dbus_api/modest-dbus-api.h: Added a define for a
345 top-application D-Bus method.
346 * src/dbus_api/modest-dbus-callbacks.c:
347 (on_top_application),
348 (modest_dbus_req_handler): Handle the top-application D-Bus
349 method, which might be an undocumented D-Bus signal sent by
350 hildon-desktop when it starts the application from the menu.
351 But I am not sure and I need to test it on the device, because
352 my scratchbox does not have the application in the menu now.
353 This method shows the main window, so that it can be invisible
354 when started, for instance, just for email searching from
357 * src/maemo/modest-main-window.c: (restore_settings),
358 (modest_main_window_new): Do not show the window immediately
359 upon creation. We show it later.
360 * src/modest-widget-memory.c: (save_settings_paned):
361 Try (unsuccessfully) to avoid saving the paned position when
362 it is not even visible.
363 (restore_settings_paned): Do not allow a silly paned position.
364 This seems necessary when not showing the window at first.
366 * tests/dbus_api/Makefile.am:
367 * tests/dbus_api/test_top_application.c: (main): Test for the
370 2007-07-10 Murray Cumming <murrayc@murrayc.com>
372 * src/modest-ui-dimming-rules.c:
373 (modest_ui_dimming_rules_on_new_msg),
374 (modest_ui_dimming_rules_on_reply_msg),
375 (modest_ui_dimming_rules_on_delete_msg),
376 (modest_ui_dimming_rules_on_details),
377 (modest_ui_dimming_rules_on_view_window_move_to),
378 (modest_ui_dimming_rules_on_view_previous),
379 (modest_ui_dimming_rules_on_view_next),
380 (_invalid_folder_for_purge): Added checks before
381 casting the window. This looks like an actual
382 logic error in _invalid_folder_for_purge(), because it
383 tries to use a ModestMainWindow as a message window.
385 2007-07-10 Murray Cumming <murrayc@murrayc.com>
387 * src/maemo/modest-account-settings-dialog.c:
388 (show_error): Use the same implementation as in
389 modest-easysetup-wizard.c:
390 (on_entry_invalid_character): The logical ID contains a %s.
391 Guessed what it should be.
392 (on_entry_max), (check_data), (on_response): Adapt to
393 changed show_error().
394 (create_page_account_details): Really call
395 modest_validating_entry_set_func() on the correct widgets.
396 * src/maemo/easysetup/modest-easysetup-wizard.c:
397 (on_entry_invalid_character): Fix the logical ID here too.
398 (create_page_account_details),
399 (create_page_user_details):
401 modest_validating_entry_set_func() on the correct widgets.
403 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
404 Do not try to use the account if it is NULL.
406 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
408 * src/modest-ui-actions.c: (create_move_to_dialog),
409 (modest_ui_actions_on_main_window_move_to),
410 (modest_ui_actions_on_msg_view_window_move_to):
411 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
412 (filter_row), (modest_folder_view_show_non_move_folders):
413 * src/widgets/modest-folder-view.h:
415 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
416 the Sent folder yet as it does not report the correct folder type.
418 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
420 * src/maemo/modest-msg-edit-window.c: (init_window):
423 2007-07-10 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
426 Take a parent widget instead of a parent window, and
427 implement this with hildon_banner_show_information() instead.
428 Non-Maemo builds can just ifdef that there.
429 This fixed projects.maemo.org bug NB#62766.
431 (on_entry_invalid_character): Use show_error() again instead
432 of using hildon directly, and use the _CS() macro to use the correct
434 (create_account), (check_for_supported_auth_methods), (on_entry_max):
435 Pass a widget instead od a window to show_error().
437 2007-07-10 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
440 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
441 This allows us to show the server name in the error message, fixing
442 projects.maemo.org bug NB#62904.
443 Also, use the appropriate logical ID message for the account protocol.
445 2007-07-10 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-tny-account-store.c: (on_idle_wrong_password):
448 A compilation fix, though the build wasn't broken for me.
450 2007-07-09 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
453 Do not try to unref a NULL folder store, to avoid a runtime warning.
454 This seems to happen sometimes when changing accounts settings.
456 2007-07-09 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-tny-account-store.c:
459 (modest_tny_account_store_instance_init),
460 (modest_tny_account_store_finalize),
461 (on_account_settings_hide), (on_idle_wrong_password):
462 Use a GHashTable to ensure that we only show one account settings
463 dialog per modest account. This avoids us having a dialog open for
464 both the store and transport accounts, or due to repeated get_password()
465 calls that shouldn't happen anyway.
467 2007-07-09 Murray Cumming <murrayc@murrayc.com>
469 * src/maemo/modest-maemo-utils.c: (on_hide),
470 (modest_maemo_show_dialog_and_forget): Handle the response, because
471 the window is not even hidden by default.
473 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
474 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
475 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
476 which seems to prevent some modality problems.
478 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
479 Ignore user cancellation errors.
481 * src/modest-account-mgr-helpers.h:
482 * src/modest-account-mgr-helpers.c:
483 Added modest_server_account_get_password() and
484 modest_server_account_get_has_password() to avoid direct use of
487 * src/maemo/modest-account-settings-dialog.h:
488 * src/maemo/modest-account-settings-dialog.c:
489 (modest_account_settings_dialog_init): Store the notebook so we can
491 Added modest_account_settings_dialog_switch_to_user_info().
493 * src/modest-tny-account-store.c:
494 (get_password): When the password in the account settings is wrong (we think),
495 show the relevant page of the account settings dialog, in the mainloop.
496 However, we currently get many of these at once because cancel does not
498 (forget_password): Do not forget the password
499 from the account settings, because this causes side-effects when
500 tinymail seems to call it at strange time, maybe because of how we
501 are cancelling get_password().
502 (modest_tny_account_store_alert): Ignore user cancellations.
504 2007-07-09 Murray Cumming <murrayc@murrayc.com>
506 * src/maemo/modest-maemo-utils.h:
507 * src/maemo/modest-maemo-utils.c:
508 Added modest_maemo_show_information_note_and_forget() for use instead of
509 gtk_dialog_run() when the response is not needed, to avoid an extra
510 mainloop which could cause a hang.
512 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
513 Use the logical IDs for the error message, though they are not
514 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
515 because gtk_dialog_run() caused a hang here (the window did not close).
516 This fixes projects.maemo.org bug NB#62646.
518 2007-07-09 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-account-mgr-helpers.h:
521 * src/modest-account-mgr-helpers.c:
522 Added modest_account_mgr_get_store_protocol().
524 * src/maemo/modest-account-view-window.c:
525 (on_delete_button_clicked): Show different warning text depending on
526 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
527 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
530 2007-07-09 Murray Cumming <murrayc@murrayc.com>
532 * src/maemo/modest-msg-edit-window.c:
533 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
534 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
536 2007-07-07 Armin Burgmeier <armin@openismus.com>
538 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
539 ckdg_ib_maximum_characters_reached from correct package.
541 * src/modest-ui-actions.c: Show an error message when a folder could
542 not be created. Tinymail does not give us specific error codes about
543 what has gone wrong, so we assume that a folder with that name
544 already exists, though there might be other reasons.
546 2007-07-06 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
549 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
550 give a more exact error message that can be partly translated.
552 2007-07-05 Murray Cumming <murrayc@murrayc.com>
554 * src/maemo/modest-address-book.c:
555 (select_email_addrs_for_contact): Specify a default window size for the
556 select-email-address dialog, so that it is probably big enough for the
557 title. This should fix projects.maemo.org bug NB#62277.
559 2007-07-05 Murray Cumming <murrayc@murrayc.com>
561 * src/maemo/easysetup/modest-easysetup-wizard.c:
562 (create_page_complete_easysetup): Use
563 gtk_widget_set_size() request to ensure that the text wraps
566 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
568 * src/maemo/easysetup/modest-easysetup-wizard.c:
569 (on_entry_invalid_character), (create_page_account_details),
570 (create_page_user_details):
571 Use new API of ModestValidatingEntry. But for some reason the banner is
572 not shown. I will have to investigate that further.
574 * src/widgets/modest-validating-entry.c: (on_insert_text),
575 (modest_validating_entry_set_func):
576 * src/widgets/modest-validating-entry.h:
577 Added a new callback function to be able to react to prevented
578 characters whitespaces to e.g show a banner.
580 2007-07-05 Armin Burgmeier <armin@openismus.com>
582 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
583 notification of HildonNumberEditor instead of remembering the port
584 number. Thanks to Johannes for pointing this out.
586 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
588 * src/maemo/easysetup/modest-easysetup-wizard.c:
589 Check if there are any user changes before showing a confirmation
590 dialog (projects.maemo.org NB#60946)
592 2007-07-05 Armin Burgmeier <armin@openismus.com>
594 * src/maemo/modest-account-settings-dialog.c: Remember custom port
595 number at the beginning of the dialog and set the modified flag at the
596 end if the port number has changed. This is necessary because
597 HildonNumberEditor does not support notification when the value has
600 2007-07-05 Murray Cumming <murrayc@murrayc.com>
602 * src/modest-ui-actions.c:
603 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
604 a connection before asking anything else. Correct the check for the destination
605 folder so that it succeeds when online.
606 This fixed projects.maemo.org bug NB#61645.
608 2007-07-05 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
611 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
612 to fix projects.maemo.org bug NB#62439.
614 2007-07-05 Murray Cumming <murrayc@murrayc.com>
616 * src/modest-tny-account.c: (on_connection_status_changed):
617 Really do not use tny_device_force_offline() here. See the previous comment.
619 2007-07-04 Murray Cumming <murrayc@murrayc.com>
621 * src/modest-tny-account.c: (on_connection_status_changed):
622 Do not use tny_device_force_offline() when tinymail says that something
623 went wrong with the connection. It seems to report this unnecessarily.
625 2007-07-04 Murray Cumming <murrayc@murrayc.com>
627 * src/maemo/modest-connection-specific-smtp-window.c:
628 (modest_connection_specific_smtp_window_init):
629 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
630 does not seem to have any effect in osso 1.1 (though it works in
631 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
633 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
635 * src/maemo/modest-connection-specific-smtp-window.c:
636 Fix UI specification problems with projects.meamo.org NB#60479
638 2007-07-04 Murray Cumming <murrayc@murrayc.com>
640 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
641 clue when this has failed, because the error dialog is not always shown
642 (at least in earlier version).
644 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
645 GError message, because the generic error dialog is not helpful.
647 'This message is not currently available (can't let a new connection go online)'
648 when trying to open an IMAP message.
650 (_modest_ui_actions_open): Offer a connection when some messages would
651 have to be downloaded and we are offline.
653 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
655 * src/widgets/modest-folder-view.c:
656 Don't check for MERGE type anymore as we use the correct type
658 NOTE: For the last two changes you need to update your tinymail copy
659 because of API changes!
661 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
663 * src/modest-tny-local-folders-account.c:
664 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
665 (see projects.maemo.org NB#61580)
667 2007-07-04 Murray Cumming <murrayc@murrayc.com>
669 * src/modest-tny-account.c: (on_connection_status_changed):
670 Commented out the call to modest_platform_connect_and_wait() because this
671 seems to always hang, and I would like to know if this is the only thing
672 that causes a hang when showing the connection dialog.
673 It is not very useful anyway.
675 2007-07-04 Murray Cumming <murrayc@murrayc.com>
677 * src/maemo/modest-msg-view-window.c:
678 (modest_msg_view_window_select_next_message):
680 * src/modest-platform.h:
681 * src/maemo/modest-platform.c:
682 Added modest_platform_connect_and_wait(), which calls
683 tny_maemo_conic_device_connect() always in the main thread, by calling it
684 in an idle handler and waiting for the idle handler to run. It should be
685 in the main thread because it uses GTK+ UI code. It just returns TRUE
686 if the device is already online.
688 There is some nasty code to ensure that subsequent calls to
689 modest_platform_connect_and_wait() just wait for the first one to finish,
690 by checking repeatedly in another idle handler. This is necessary,
691 because other threads (or even the main thread, via another idle handler)
692 can call modest_platform_connect_and_wait() while
693 modest_platform_connect_and_wait() is running.
695 (modest_platform_connect_and_wait_if_network_account),
696 (modest_platform_connect_and_wait_if_network_folderstore):
697 Convenience functions that calls modest_platform_connect_and_wait() if
698 the account or folder might want network access.
700 * src/modest-mail-operation.c:
701 (modest_mail_operation_update_account):
702 * src/modest-ui-actions.c: (download_uncached_messages),
703 (modest_ui_actions_on_rename_folder), (delete_folder),
704 (modest_ui_actions_on_main_window_move_to),
705 (modest_ui_actions_on_msg_view_window_move_to):
706 * src/widgets/modest-folder-view.c:
707 (drag_and_drop_from_folder_view):
708 Offer a connection if we are offline.
710 * src/modest-tny-account.c: (on_connection_status_changed):
711 Document this as only handling errors during network operations in progress,
712 and replace the idle code with a simple call to
713 modest_platform_connect_and_wait(), which does this instead.
715 2007-07-03 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-tny-account.c:
718 (modest_tny_account_get_special_folder): (util_on_idle),
719 Handle the GError so we can see when tny_folder_store_get_folders()
720 fails, as it currently does while something else is connecting.
722 Added util_run_in_main_thread_and_wait()
723 which uses an idlen handler and mainloop to ensure that the function
724 is called in the main thread.
725 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
726 to make sure that we call attempt the connection in the mainloop only,
727 which might solve some hangs.
729 2007-07-03 Murray Cumming <murrayc@murrayc.com>
731 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
732 be found by their display name. This is never useful.
733 * src/modest-tny-account-store.c: (on_account_removed): Find the account
734 by its ID, instead of trying to use its ID as its display name.
736 * src/modest-tny-account-store.h:
737 * src/modest-tny-account.c:
738 (modest_tny_account_get_special_folder): Add a g_warning() when
739 tny_folder_store_get_folders() returns an empty list for the maildir.
741 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
742 Add a g_warning() when this returns NULL, because that it not allowed
745 2007-07-02 Armin Burgmeier <armin@openismus.com>
747 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
748 note when trying to cancel the wizard. This fixes projects.maemo.org
751 2007-07-02 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-tny-account.h:
754 * src/modest-tny-account.c:
755 (modest_tny_account_new_from_server_account),
756 (modest_tny_account_new_from_server_account_name),
757 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
758 because this must now be set before setting the proto. This is usd in
759 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
760 warning in camel_session_get_service() caused by
761 tny_camel_transport_account_prepare().
763 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
766 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
768 * src/maemo/modest-connection-specific-smtp-edit-window.c:
770 (modest_connection_specific_smtp_edit_window_init):
772 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
775 2007-06-29 Murray Cumming <murrayc@murrayc.com>
777 * src/modest-tny-account.c:
778 (modest_tny_account_new_from_server_account):
779 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
780 now uses to request a connection when it needs one, and which it uses
781 to tell us that something is wrong with the connection, so we can force
782 the accounts offline to prevent further problems.
785 * src/modest-init.c: (init_default_settings):
786 * src/modest-mail-operation.c:
787 (modest_mail_operation_update_account):
788 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
789 This should not be necessary anymore. Do not set the conf key that
790 determined this (it was always TRUE and not set anywhere else).
792 * src/modest-ui-actions.h: Remove unused and unimplemented
793 modest_ui_actions_on_online_toggle_toggled().
795 2007-06-29 Murray Cumming <murrayc@murrayc.com
797 * src/maemo/modest-main-window.c: (connect_signals):
798 Don't connect to delete_event twice. Maybe this was harmless.
800 2007-06-29 Murray Cumming <murrayc@murrayc.com
802 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
803 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
804 Debug output to give some more clue when a folder move is not allowed.
806 2007-06-28 Murray Cumming <murrayc@murrayc.com
808 * src/modest-tny-account.c: (on_modest_file_system_info),
809 (modest_tny_account_get_mmc_account_name):
810 Always call the callback, without checking whether the name has changed.
811 * src/widgets/modest-folder-view.c: (strings_are_equal),
812 (on_model_foreach_set_name), (on_get_mmc_account_name),
813 (text_cell_data): Compare the name here, and use the name from
814 the account rather than from the
815 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
816 if the name was changed after the account was added to the model.
817 That's a tinymail bug but not one that I want to fix now.
819 This finally fixes projects.maemo.org bug NB#59301.
821 2007-06-27 Armin Burgmeier <armin@openismus.com>
823 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
826 2007-06-27 Murray Cumming <murrayc@murrayc.com
828 * src/modest-tny-account.h:
829 * src/modest-tny-account.c:
830 Added modest_tny_account_get_mmc_account_name(), to set the memory
831 card name asynchronously for the given account and then notify.
832 (modest_tny_account_new_for_local_folders): Use this new function instead
833 of using hildon_file_system_info_async_new() directly.
835 * src/widgets/modest-folder-view.c: (text_cell_data):
836 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
837 gtk_tree_model_row_changed() when it is available.
839 This should fix projects.maemo.org bug NB#59301.
841 2007-06-27 Murray Cumming <murrayc@murrayc.com
843 * src/modest-mail-operation.c: (update_account_thread),
844 (get_msgs_full_thread): Fix typo failures in the revert
847 2007-06-27 Murray Cumming <murrayc@murrayc.com
849 * src/maemo/modest-maemo-global-settings-dialog.c:
850 (idle_select_default_focus):
851 * src/modest-mail-operation.c: (idle_notify_progress),
852 (idle_notify_progress_once), (set_last_updated_idle),
853 (update_account_thread), (get_msgs_full_thread):
854 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
855 * src/widgets/modest-header-view.c:
856 (idle_notify_headers_count_changed_destroy),
857 (idle_notify_headers_count_changed):
858 Reverted the additions of gdk_threads_enter/leave(), in case this
859 helps with a startup hang on the device.
861 2007-06-26 Armin Burgmeier <armin@openismus.com>
863 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
864 for supported secure authentication methods from server by
865 gtk_dialog_run(), saving CPU time and a potential race condition.
867 2007-06-26 Armin Burgmeier <armin@openismus.com>
869 * src/maemo/modest-maemo-utils.h:
870 * src/maemo/modest-maemo-utils.c: Added a
871 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
872 only error code to tell the calling code when the user canceled the
875 * src/maemo/modest-account-settings-dialog.h:
876 * src/maemo/modest-account-settings-dialog.c:
877 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
878 message if the retrieval of secure authentication methods was canceled
879 by the user. Perform the check before saving anything to configuration
880 to not end up with half-committed configuration changes, do not show
881 a "Saving to configuration failed" note when authentication methods
882 could not be retrieved.
884 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
887 2007-06-26 Murray Cumming <murrayc@murrayc.com>
889 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
890 Only return the first level of folders under accounts, because the
891 osso-global-search UI spec doesn't want the rest.
892 This fixed projects.maemo.org bug NB#61811.
894 2007-06-26 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-tny-account-store.c:
897 * src/modest-tny-account-store.h:
898 Added modest_tny_account_is_memory_card_account().
899 * src/maemo/modest-main-window.c: (create_details_widget):
900 Show the same information items for the memory card as we show for the
901 local-folders, to fix projects.maemo.org bug NB#59307.
903 2007-06-26 Murray Cumming <murrayc@murrayc.com>
905 * src/modest-tny-account-store.c: (get_password):
906 Added some checks for NULL to maybe prevent crashes, though I think
907 it was Philip's last commit that actually prevented the crash here
908 when creating a first new account.
909 But the new account is still not usable (no messages are shown)
910 until a restart of the application.
912 2007-06-26 Murray Cumming <murrayc@murrayc.com>
914 * src/maemo/modest-maemo-global-settings-dialog.c:
915 (idle_select_default_focus):
916 * src/modest-mail-operation.c: (idle_notify_progress),
917 (idle_notify_progress_once), (idle_notify_update_account_queue),
918 (set_last_updated_idle), (update_account_thread),
919 (notify_get_msgs_full), (get_msgs_full_destroyer),
920 (get_msgs_full_thread):
921 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
922 * src/widgets/modest-header-view.c:
923 (idle_notify_headers_count_changed_destroy),
924 (idle_notify_headers_count_changed):
925 Use gdk_threads_enter() and gdk_threads_enter_leave() in
926 all idle handlers, because some other thread could be blocking
927 the GDK lock, so that it can do GUI stuff.
929 2007-06-26 Murray Cumming <murrayc@murrayc.com>
931 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
932 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
933 (on_idle_send_receive), (on_idle_open_default_inbox):
934 * src/maemo/modest-msg-edit-window.c:
935 (modest_msg_edit_window_attach_file_noninteractive):
936 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
937 to prevent a hang. I don't quite understand why these are necessary,
938 beause we should already be in the main loop. I guess something outside
939 of the main loop is taking the lock.
941 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
942 we are really using URIs, and use files that are more likely to exist.
944 2007-06-26 Murray Cumming <murrayc@murrayc.com>
946 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
947 necessary because configure.ac now defines different variables.
949 2007-06-26 Murray Cumming <murrayc@murrayc.com>
951 * libmodest-dbus-client/libmodest-dbus-client.c:
952 * libmodest-dbus-client/libmodest-dbus-client.h:
953 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
954 libmodest_dbus_client_compose_mail() is what things actually use.
956 * src/dbus_api/modest-dbus-api.h:
957 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
958 * tests/dbus_api/Makefile.am:
959 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
962 2007-06-26 Murray Cumming <murrayc@murrayc.com>
964 * src/modest-init.c: (modest_init_local_folders):
965 For memory-card (or other non local-folders) maildir accounts,
966 always create an Archive folder, so that there is somewhere to put
967 messages. This should be less confusing, because the user does not need
968 to guess that the need to create a folder.
970 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
972 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
973 Fixed icon size by using (50, 50) which is the same as defined by
976 2007-06-25 Armin Burgmeier <armin@openismus.com>
978 * src/widgets/modest-window-mgr.c:
980 * configure.ac: Correctly recognize hildon-notify presence and fixed
981 the build without it being installed.
983 2007-06-25 Murray Cumming <murrayc@murrayc.com>
985 * libmodest-dbus-client/libmodest-dbus-client.c:
986 (libmodest_dbus_client_search): Fix the build. Sorry.
987 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
988 (reply_forward_cb): Initialize variables to fix the build.
990 * src/modest-tny-account-store.c:
991 (modest_tny_account_store_get_tny_account_by): Fix the account URI
992 comparison (a silly typo) so that email search results can be opened
993 when there are more than one account.
995 2007-06-25 Murray Cumming <murrayc@murrayc.com>
997 * libmodest-dbus-client/libmodest-dbus-client.c:
998 (libmodest_dbus_client_search),
999 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1000 instead of 1 second, because the search gets folders and messages from
1001 the server, which can take a long time. When it times out,
1002 osso-global-search will report no results.
1004 We need to specify whether we should search only cached information
1005 (maybe with a user preference), and the osso-email-search-plugin
1006 API should really be improved to allow that option, and to allow results
1007 to be delivered asynchronously in batches.
1009 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1011 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1012 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1013 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1015 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1018 that is an empty string. D-Bus seems to give us these instead of NULL.
1020 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1022 * src/dbus_api/modest-dbus-callbacks.c:
1023 * src/maemo/easysetup/modest-easysetup-wizard.h:
1024 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1025 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1026 (modest_connection_specific_smtp_edit_window_init):
1027 * src/maemo/modest-maemo-global-settings-dialog.c:
1029 * src/maemo/modest-maemo-utils.c:
1030 (modest_maemo_utils_setup_images_filechooser):
1031 * src/maemo/modest-main-window.c: (create_details_widget):
1032 * src/maemo/modest-msg-edit-window.c:
1033 (modest_msg_edit_window_attach_file_noninteractive),
1034 (modest_msg_edit_window_color_button_change),
1035 (modest_msg_edit_window_set_zoom):
1036 * src/modest-mail-operation.c: (update_account_thread):
1037 * src/modest-tny-account-store.c:
1038 * src/modest-tny-account.c:
1039 * src/widgets/modest-global-settings-dialog.c:
1040 * src/widgets/modest-window.h:
1042 Fixed build on bora!
1044 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1046 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1047 * src/modest-search.c: (modest_search_folder),
1048 (modest_search_all_accounts): Actually search only in the specified folder,
1049 doing a simple match on the folder ID.
1050 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1051 and added some documentation.
1053 2007-06-22 Armin Burgmeier <armin@openismus.com>
1055 * src/maemo/modest-maemo-utils.h:
1056 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1057 modest_maemo_utils_get_supported_secure_authentication_methods.
1059 * src/maemo/easysetup/modest-easysetup-wizard.c:
1060 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1061 one occured, not just "Server does not support secure authentication".
1063 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-tny-account-store.c: (get_password):
1066 Restored the call to tny_account_set_user() because Philip seems to have
1067 stopped this from crashing (by not using the freed string). It still does
1068 not work, but now we can test it.
1070 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1072 * src/maemo/modest-msg-edit-window.c: (init_window):
1073 Comment out use of an uninitialzed GtkScrolledWindow variable,
1074 to fix the build and stop a crash. Yet again.
1076 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1078 * src/modest-tny-account-store.c: (get_password):
1079 Remove the call to tny_account_set_user() because this actually crashes.
1080 As mentioned in the last commit, it is known to not work anyway.
1082 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-tny-account-store.c: (get_password):
1085 Use tny_account_set_username() to tell tinymail that the username might
1086 have changed too. But tinymail ignores this: see projects.maemo.org
1088 * src/modest-ui-actions.c:
1089 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1090 reset the connection when changing the username, and improve the comments.
1091 Save the changed username to gconf at least, so it is used when Modest is
1094 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1096 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1097 Do not use a query, so that we get all folders, including for POP and
1098 local-folders. They work as search criteria too.
1099 This fixes projects.maemo.org bug NB#57740.
1101 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1103 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1104 Comment out the use of hildon_notification_set_sound() because it is
1105 not declared, to fix the build. Warnings are serious, people.
1107 2007-06-21 Armin Burgmeier <armin@openismus.com>
1109 * src/maemo/modest-maemo-utils.h:
1110 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1111 modest_maemo_utils_get_supported_secure_authentication_methods()
1112 to query authentication methods for a specific user. This should fix
1113 projects.maemo.org bug NB#61369.
1115 * src/maemo/easysetup/modest-easysetup-wizard.c:
1116 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1119 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1121 * libmodest-dbus-client/libmodest-dbus-client.h:
1122 * libmodest-dbus-client/libmodest-dbus-client.c:
1123 (modest_dbus_message_iter_get_search_hit),
1124 (libmodest_dbus_client_search):
1125 Reorganised and commented this.
1126 Removed modest_search_hit_free() from the public API because it
1129 Added libmodest_dbus_client_get_folders() and
1130 modest_folder_result_list_free().
1132 * src/dbus_api/modest-dbus-api.h:
1133 * src/dbus_api/modest-dbus-callbacks.c:
1134 (modest_dbus_req_filter): Commented. Moved most code to
1135 on_dbus_method_search() and added on_dbus_method_get_folders().
1137 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1138 of the extra D-Bus handler.
1140 * tests/dbus_api/Makefile.am:
1141 * tests/dbus_api/test_get_folders.c: New test for
1142 libmodest_dbus_client_get_folders(). This seems to return an empty list
1143 at the moment. That could be the same error that causes the message list
1144 to be empty sometimes.
1145 This should help with projects.maemo.org bug NB#57740.
1147 2007-06-21 Armin Burgmeier <armin@openismus.com>
1149 * src/modest-mail-operation.c: Do not call
1150 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1151 notify the operation's end after having set the status to CANCELED for
1152 the operation queue to listen on. This fixes a deadlock when there
1153 were mail operations in the queue during its finalization.
1155 * src/modest-singletons.c: Reordered uninitialization of the account
1156 manager to happen after the mail operation queue was uninitialized
1157 because the mail operation's in the queue might still try to access
1158 the account manager (see modest_mail_operation_notify_end()). This
1159 fixes a potential crash when terminating the application.
1161 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-search.c:
1164 (search_mime_part_and_child_parts): Moved some code here so we
1165 can search recursively in child folders.
1166 (modest_search_folder): Search in the message as a mime part, instead
1167 of just its child mime parts.
1168 (read_chunk), (search_mime_part_ogs):
1169 Check how many bytes were read, to prevent an endless loop.
1170 Searching in message bodies now works. This finishes the fix for
1171 projects.maemo.org bug NB#61007.
1173 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1176 Add a g_warning when the item is not a folder.
1178 * src/modest-ui-dimming-rules.c:
1179 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1180 when selected item is not a folder (for instance, an account), because
1181 the UI spec only talks about folders.
1182 I am not sure what the UI spec wants, so this might not totally fix
1183 projects.maemo.org bug NB#60794.
1185 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1187 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1188 (load_from_file): Sort the list. The unsorted list would be more noticeable
1189 in non-English locales.
1191 * src/maemo/modest-msg-edit-window.c:
1192 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1193 warning and fix the build.
1195 * src/maemo/modest-progress-bar-widget.c:
1196 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1197 avoid a g_warning, and probably to avoid a crash.
1199 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1201 * src/modest-search.c: (modest_search_folder): Check for a GError
1202 when calling tny_folder_get_headers(), to show that this is not the cause
1205 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1207 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1208 Actually set the body query instead of the subject query.
1210 * src/modest-search.c: (search_mime_part_ogs),
1211 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1212 which would probably cause it to fail if we got this far.
1214 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1215 to simplify the code.
1216 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1217 be causing search-in-body to fail.
1219 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1221 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1223 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1224 Better debug message when the folder cannot be found.
1225 This should help with fixing projects.maemo.org bug #61287.
1226 * src/modest-search.c: (add_hit): Do not leak the furl string.
1228 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1230 * src/modest-ui-actions.c:
1231 (modest_ui_actions_on_folder_selection_changed):
1232 Do not special-case TNY_MERGE_FOLDER here, because
1233 modest_tny_folder_get_account() already does that. This fixes
1234 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1235 shown when the Outbox was selected).
1237 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1239 * libmodest-dbus-client/libmodest-dbus-client.c:
1240 (_dbus_iter_get_string_or_null): Initialize the string variable in
1241 case this helps with Dirk's crash.
1243 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1245 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1246 though it is not implemented yet (this function is maybe not even used),
1247 to avoid breaking ABI in future.
1248 * libmodest-dbus-client/libmodest-dbus-client.c:
1249 (get_attachments_string): Moved some code into this generic function.
1250 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1251 sends email. It is maybe not used.
1252 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1253 (on_send_mail): Use attachments.
1255 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1256 * src/maemo/modest-msg-edit-window.c:
1257 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1258 a filename before using it, to fix projects.maemo.org bug NB#58233.
1260 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1263 Initialize the continue_download variable to fix the build, and probably
1264 to fix randome behaviour.
1266 2007-06-18 Armin Burgmeier <armin@openismus.com>
1268 * src/modest-tny-send-queue.h:
1269 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1270 the queue so we can later show it in the UI. Replaced
1271 modest_tny_send_queue_msg_is_being_sent() by
1272 modest_tny_send_queue_get_msg_status().
1274 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1276 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1277 gpointer. This probably was not harmful, but just to be sure.
1279 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1281 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1282 Fix the build, but leave the function broken on Bora, because
1283 hildon_uri_action_get_service() does not exist.
1284 osso_uri_action_get_service() does not exist either, it seems.
1286 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1288 * src/modest-tny-account.c:
1289 (modest_tny_account_new_from_server_account):
1290 Uncommented the url debug output again, because it is useful for
1291 debugging, as I said in the comment.
1293 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1295 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1297 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1298 for Mameo Bora, to fix the build.
1300 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1303 Fixed build with hildon < 0.99
1305 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1306 Check if the selected account is busy instead of checking all accounts
1308 * src/modest-account-mgr-priv.h:
1309 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1310 (modest_account_mgr_init), (compare_account_name),
1311 (modest_account_mgr_set_account_busy),
1312 (modest_account_mgr_account_is_busy):
1313 * src/modest-account-mgr.h:
1314 Added busy information to the account manager. It possible to
1315 set an account to busy or not busy now.
1317 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1318 (modest_mail_operation_update_account),
1319 (modest_mail_operation_notify_end):
1320 Set the account to busy/not busy depending on the operation state.
1322 * src/widgets/modest-account-view.c:
1323 (modest_account_view_finalize), (get_last_updated_string),
1324 (update_account_view), (on_account_busy_changed), (init_view):
1325 Show string "Refreshing..." if the account is currently busy.
1327 All this fixes projects.maemo.org bug NB#59711
1329 2007-06-14 Armin Burgmeier <armin@openismus.com>
1331 * src/widgets/modest-attachments-view.h:
1332 * src/widgets/modest-attachments-view.c: Added
1333 modest_attachments_view_has_attachments() and fixed coordinate
1334 transformation in get_att_view_at_coords(). This fixes attachment
1337 * src/widgets/modest-msg-view.c: Make use of
1338 modest_attachments_view_has_attachments() to decide whether to show
1339 attachments in the header.
1341 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1343 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1344 (on_change), (on_combo_security_changed),
1345 (modest_connection_specific_smtp_edit_window_init),
1346 (modest_connection_specific_smtp_edit_window_set_connection),
1347 (modest_connection_specific_smtp_edit_window_is_dirty):
1348 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1349 * src/maemo/modest-connection-specific-smtp-window.c:
1352 Show an comfirmation dialog for the smpt-edit-window if there are
1353 unsaved changes and the user hits cancel.
1354 (projects.maemo.org bug NB#60479)
1356 2007-06-14 Armin Burgmeier <armin@openismus.com>
1358 * src/maemo/easysetup/modest-easysetup-wizard.c:
1359 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1360 address" info in banner instead of node, and select all the text as
1361 per UI spec. This fixes projects.maemo.org bug NB#60550.
1363 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1365 reviewed by: <delete if not using a buddy>
1367 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1368 * src/modest-ui-actions.c: (folder_refreshed_cb):
1370 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1372 * src/widgets/modest-folder-view.c: (filter_row):
1373 Explictly filter out the per-account outbox accounts. I don't know why
1374 these only sometimes show up, but now they should never show up in the UI.
1375 This should fix projects.maemo.org bug NB#60160.
1377 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1379 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1380 when the toolbar does not exist yet.
1381 * src/modest-widget-memory.c: (save_settings_header_view):
1382 Added g_warnings() to help us to discover when we are trying to set
1383 an empty columns list in gconf.
1385 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1387 * src/modest-init.h:
1388 * src/modest-init.c:
1389 Added modest_init_get_default_header_view_column_ids().
1391 * src/modest-widget-memory.c: (restore_settings_header_view):
1392 Use the new function to get defaults, if the gconf key is empty,
1393 instead of not creating any columns. This seems to fix the
1394 empty right-hand pane problems.
1396 * src/widgets/modest-header-view.h: Improved documentation.
1398 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1400 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1401 Revert the use of the display name as the account name, because this
1402 is generally wrong and would break the code that follows.
1404 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1406 * src/maemo/easysetup/modest-easysetup-wizard.c:
1407 (check_for_supported_auth_methods), (on_before_next),
1410 More correct fix for projects.maemo.org bug NB# 58991
1411 Do not longer accept AUTH_PASSWORD as secure method and choose
1412 correct method when creating the account.
1414 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1416 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1417 Fixed projects.maemo.org bug NB# 58991
1419 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-init.c: (modest_init_init_core),
1422 (modest_init_local_folders): Fixed compilation errors.
1424 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1426 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1427 Remove unnecessary lib/include, though it is good in principle when needed.
1429 * src/modest-init.c: (modest_init_one_local_folder),
1430 (modest_init_local_folders):
1431 * src/modest-init.h: Initialize the .modest library for memory cards,
1432 instead of just doing nothing for them. This should allow us to create
1433 folders there, fixing projects.maemo.org bug NB#59297.
1435 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1437 * libmodest-dbus-client/libmodest-dbus-client.c:
1438 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1439 (libmodest_dbus_client_compose_mail),
1440 (libmodest_dbus_client_open_message),
1441 (libmodest_dbus_client_send_and_receive),
1442 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1444 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1445 (on_idle_open_message), (modest_dbus_req_handler),
1446 (search_result_to_message), (modest_dbus_req_filter):
1447 * src/modest-search.c: (add_hit), (modest_search_folder),
1448 (modest_search_all_accounts): Improved debug messages.
1450 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1452 * src/modest-tny-account-store.c:
1453 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1456 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1459 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1461 * src/modest-tny-account-store.c: (get_server_accounts):
1462 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1463 even when there are no accounts, so that the Outbox folder is always
1464 visible. This fixes projects.maemo.org bug NB#60158.
1466 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1468 * src/maemo/modest-main-window.c: (create_details_widget):
1469 Use the mcen_va_never logical ID.
1471 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1473 * src/dbus_api/modest-dbus-api.h:
1474 * src/dbus_api/modest-dbus-callbacks.c:
1475 (on_idle_open_default_inbox), (on_open_default_inbox),
1476 (modest_dbus_req_handler):
1477 Added a new OpenDefaultInbox method.
1479 * libmodest-dbus-client/libmodest-dbus-client.h:
1480 * libmodest-dbus-client/libmodest-dbus-client.c:
1481 Added libmodest_dbus_client_open_default_inbox() to call the new
1482 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1483 though it should maybe be used by a new osso-email-interface function.
1485 * tests/dbus_api/Makefile.am:
1486 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1489 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1491 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1492 NULL, so that the signals get all the keys. This should not actually
1493 change any behaviour because we currently update everything when anything
1496 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1498 * src/widgets/modest-folder-view.c: (text_cell_data),
1499 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1500 (find_inbox_iter): If tinymail tells us that the folder is
1501 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1502 This causes the inbox to be selected at startup, fixing part of
1503 projects.maemo.org bug NB#56305.
1505 * src/modest-ui-dimming-rules.c:
1506 (modest_ui_dimming_rules_on_tools_smtp_servers):
1507 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1508 the SMTP servers menu item.
1509 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1510 that the SMTP Servers menu item is dimmed when there are no accounts,
1511 as a future version of the UI spec will require. This fixes
1512 projects.maemo.org bug NB#56305.
1514 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1516 * src/maemo/modest-maemo-utils.c:
1517 (modest_maemo_utils_get_supported_secure_authentication_methods):
1518 Added label to dialog instead of unreadable title
1520 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1521 (modest_main_window_new):
1522 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1525 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1526 * src/modest-account-mgr.h:
1527 Added method to avoid code duplication
1529 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1530 (modest_ui_actions_on_send_receive):
1531 Use modest_account_mgr_has_accounts
1533 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1535 * src/maemo/easysetup/modest-presets.c:
1536 (modest_presets_get_info_server_security): Do not report secure auth
1538 * src/modest-protocol-info.c: Use the defines for the gconf key names
1539 for secure authentication. This was not working because we were writing
1540 Password and reading password, and the check was case sensitive.
1541 With this, gmail now works for receiving and sending when created via
1544 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1546 * src/maemo/easysetup/modest-presets.c:
1547 (modest_presets_get_info_server_security): Correct the key name for
1548 SecureSmtp, because it seems to be case-sensitive.
1549 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1550 Do not try to get the 0th notebook page if there are 0 pages, to
1551 avoid a g_warning().
1553 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1555 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1556 Prevent use of the new notification feature for now, because it currently
1557 shows one dialog for each new email, which is annoying.
1559 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1561 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1562 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1563 when no country was selected, so that we show the global ones.
1564 * src/maemo/easysetup/modest-presets.c:
1565 (modest_presets_get_providers): Return only the global providers, not
1566 all providers when mmc=0 was requested.
1568 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1570 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1571 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1572 provider ID in the combo.
1574 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1575 Do not show the page numbers, because it would be confusing when we add
1576 the 2 extra pages for the custom setup, when the user chooses the "Other"
1577 provider. This fixes projects.maemo.org bug NB#59028
1579 * src/modest-init.c: (modest_init_init_core),
1580 (modest_init_local_folders):
1581 * src/modest-init.h:
1582 * src/modest-tny-account.c:
1583 (modest_tny_account_new_for_local_folders): Do not create default folders
1584 for the memory card. This should fix projects.maemo.org bug NB#59328.
1586 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1589 Free the changed_conf_keys string items. They are already freed in the
1590 idle handler if that runs first.
1592 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1594 * src/modest-ui-actions.c:
1595 (modest_ui_actions_on_password_requested): Check that the server name
1596 is not NULL, because I just saw a password dialog with (null) as the
1599 * src/modest-tny-folder.[h|c]: Added
1600 modest_tny_folder_is_memory_card_folder().
1601 * src/modest-ui-dimming-rules.c:
1602 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1603 menu item for memory cards, as per the UI spec (section 7.4). This should
1604 fix projects.maemo.org bug NB#59297.
1606 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1608 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1609 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1610 is another problem with the code, see Murray's comment at line 772)
1612 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1614 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1615 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1616 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1617 (load_from_file), (easysetup_country_combo_box_init),
1618 (easysetup_country_combo_box_get_active_country_ids),
1619 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1620 instead of just one ID, to avoid duplicate country names in the UI.
1622 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1623 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1624 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1625 a single ID, avoiding duplicate providers.
1626 * src/maemo/easysetup/modest-easysetup-wizard.c:
1627 (on_combo_account_country): Adapt to use a list.
1629 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1632 keys changed in the last X seconds.
1634 * src/modest-account-mgr.h:
1635 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1636 (on_key_change), (modest_account_mgr_class_init),
1637 (modest_account_mgr_init), (modest_account_mgr_finalize):
1638 As the keys are changed, save them in a GSList* and signal that GSList*
1639 further every X seconds, to batch changes, to allow us to do just one
1640 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1641 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1643 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1644 changed signal signature.
1646 * src/modest-conf.c: (modest_conf_set_list),
1647 (modest_conf_on_change): Reenable notification.
1649 (modest_conf_maemo_fake_on_change): Comment out the hack that
1650 notified immediately instead of asynchronously.
1652 * src/widgets/modest-account-view.h:
1653 * src/widgets/modest-account-view.c:
1654 (update_account_view): Select the previously-selected account ID,
1655 if possible. This fixes projects.maemo.org bug NB#56933.
1657 (on_account_changed), (on_account_removed),
1658 (modest_account_view_select_account):
1660 Remove the block/unblock functions
1661 because they were not useful.
1663 * src/maemo/modest-account-view-window.c:
1664 (on_delete_button_clicked), (on_edit_button_clicked),
1665 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1667 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1669 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1670 Improve the error dialog to show Incorrect Account Settings, which seems
1671 clearer, and say that the internal error message (to be removed from the
1672 dialog later) is often misleading.
1673 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1675 * src/modest-tny-account.c:
1676 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1677 URL because this is so useful for debugging on the device.
1679 * src/widgets/modest-serversecurity-combo-box.c:
1680 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1682 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1684 * src/modest-mail-operation.c:
1685 (modest_mail_operation_send_new_mail):
1686 Added a comment about a nasty but apparently harmless message. Details
1687 added to the wiki g_warnings() page.
1689 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1691 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1692 (modest_tny_send_queue_class_init):
1693 Do not use the priv struct because it is empty, to avoid g_warnings
1694 about a non-existant priv struct.
1696 * src/modest-tny-account-store.c:
1697 (modest_tny_account_store_get_server_account),
1698 (modest_tny_account_store_get_transport_account_for_open_connection
1699 ): Do not try to get transport server accounts for local folders,
1700 because they don't have any. This avoids a g_warning().
1702 * src/maemo/modest-main-window.c:
1703 (modest_main_window_notify_send_receive_initied),
1704 (on_configuration_key_changed):
1705 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1706 * src/modest-defs.h:
1707 * src/modest-mail-operation.c:
1708 (modest_mail_operation_update_account):
1709 * src/modest-tny-account-store.h:
1710 * src/modest-tny-account.c:
1711 (modest_tny_account_get_special_folder),
1712 (modest_tny_account_new_for_local_folders),
1713 (modest_tny_account_new_for_per_account_local_outbox_folder):
1714 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1715 * src/modest-tny-local-folders-account.c:
1716 (add_account_folders_to_merged_folder):
1717 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1718 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1719 (modest_ui_actions_on_send):
1720 * src/widgets/modest-folder-view.c: (update_model):
1721 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1722 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1723 modest_tny_account_store_get_tny_account_by_account() to
1724 modest_tny_account_store_get_server_account() to make the code clearer.
1726 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1728 * src/dbus_api/modest-dbus-api.h:
1729 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1730 * src/maemo/modest-msg-edit-window.c:
1731 (modest_msg_edit_window_attach_file_noninteractive):
1732 added g_warning in case the file to be attached does not exist
1733 * tests/dbus_api/test_compose_mail.c: (main):
1734 removed obsolete comment, added generic files as test case
1736 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1738 * src/modest-tny-account-store.c: (get_server_accounts):
1739 Create the local folders account only once, not once for each outbox, and
1740 not only when there are some outboxes.
1742 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1744 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1745 code that is causing a crash at startup. Sergio says that he is fixing this.
1747 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1749 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1750 * src/maemo/modest-account-settings-dialog.c:
1751 (create_page_outgoing),
1752 (modest_account_settings_dialog_set_account_name),
1753 (save_configuration):
1754 - Fixed handling of the "Use secure authentication" toggle to comply with
1755 the ui specification. See also projects.maemo.org bug NB#58400
1757 - Restore the Secure connection setting combo correctly when loading
1760 * src/maemo/modest-maemo-utils.c:
1761 (on_camel_account_get_supported_secure_authentication),
1762 (modest_maemo_utils_get_supported_secure_authentication_methods):
1763 Fixed a crasher if operation is canceled
1765 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1766 (modest_protocol_info_auth_is_secure):
1767 * src/modest-protocol-info.h:
1769 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1770 the sense of the "Use secure authentication" toggle.
1772 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1774 * src/modest-tny-account-store.h:
1775 * src/modest-tny-account-store.c:
1776 Added modest_tny_account_store_get_local_folders_account().
1778 * src/modest-tny-folder.h:
1779 * src/modest-tny-folder.c:
1780 (modest_tny_folder_get_account):
1781 Added this replacement for tny_folder_get_account() which returns
1782 the local-folders account for TnyMergeFolders, to avoid the
1783 warning about the unimplemented get_account_func() vfunc().
1785 (modest_tny_folder_get_rules),
1786 * src/modest-ui-actions.c:
1787 (modest_ui_actions_on_folder_selection_changed):
1788 * src/modest-mail-operation.c:
1789 (modest_mail_operation_remove_folder),
1790 (modest_mail_operation_xfer_folder),
1791 (modest_mail_operation_rename_folder),
1792 (modest_mail_operation_get_msg),
1793 (modest_mail_operation_get_msgs_full),
1794 (modest_mail_operation_remove_msg),
1795 (modest_mail_operation_xfer_msgs),
1796 (modest_mail_operation_refresh_folder):
1797 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1799 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1802 (modest_server_account_set_security):
1803 * src/modest-defs.h: Add comments explaining that our
1804 UI spec means TLS when it says Normal, so these do not look like errors.
1806 * src/modest-tny-account.c:
1807 (modest_tny_account_new_from_server_account): Use the new tinymail
1808 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1809 for TLS. This should fix projects.maemo.org bug NB#58460.
1811 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1813 * src/maemo/easysetup/modest-easysetup-wizard.c:
1814 (create_account): Correct the position of the gconf sanity check warning.
1815 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1816 of using the g_idle_add() hack, because this does not seem to be necessary
1817 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1818 caused by something other than maemo's gconf.
1819 This fixes projects.maemo.org bug #59022.
1821 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1823 * src/modest-account-mgr-helpers.c:
1824 (modest_account_mgr_get_default_account): Do not check that the account
1825 exists if there is no default account (NULL), to fix a runtime warning.
1827 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1829 * src/widgets/modest-folder-view.c: (update_model):
1830 Do not unref the treemodel before we have finished with it.
1831 This prevents a valgrind warning and an occasional crash at startup.
1833 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1835 * libmodest-dbus-client/libmodest-dbus-client.h:
1836 added libmodest_dbus_client_compose_mail()
1837 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1839 added functions needed for SendAsMail() functionality
1840 * src/maemo/modest-msg-edit-window.c:
1841 (modest_msg_edit_window_attach_file_noninteractive):
1842 non interactively attaching files to message edit window
1843 * src/widgets/modest-msg-edit-window.h:
1844 * tests/dbus_api/Makefile.am:
1845 added test_compose_mail.c
1846 * tests/dbus_api/test_compose_mail.c: (main):
1848 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1850 * src/modest-account-view.c:
1851 Fixed bug projects.maemo.org bug NB#59307
1853 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1855 * src/maemo/easysetup/modest-easysetup-wizard.c:
1856 (get_serverport_incoming), (on_before_next), (create_account):
1857 * src/maemo/modest-account-settings-dialog.c:
1858 (modest_account_settings_dialog_set_account_name):
1859 * src/maemo/modest-maemo-utils.c:
1860 (on_camel_account_get_supported_secure_authentication_status),
1861 (on_camel_account_get_supported_secure_authentication),
1862 (on_secure_auth_cancel),
1863 (modest_maemo_utils_get_supported_secure_authentication_methods):
1865 Implemented security authentication for settings and easysetup.
1867 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1869 * src/maemo/modest-main-window.c: (create_details_widget):
1870 Show the total size for memory card accounts too, instead of showing
1871 the name again. Fixes bug projects.maemo.org bug NB#59307.
1873 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1876 * src/modest-tny-simple-folder-store.c:
1877 * src/modest-tny-simple-folder-store.h: Removed.
1879 * src/modest-tny-local-folders-account.h
1880 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1881 for the local-folders maildir, with an extra TnyMergedFolder containing
1882 the folders of the per-account outbox store accounts.
1883 * src/modest-tny-account-store.c: (get_server_accounts):
1884 Add the outboxes to the special local folders account after creating it.
1886 * src/modest-tny-account.c:
1887 (modest_tny_account_new_for_local_folders): Create the derived
1888 account when creating the main local-folders account.
1890 * src/maemo/modest-main-window.c: (create_details_widget),
1891 (modest_main_window_set_contents_style):
1892 Adapted to the use of the derived account instead of the folder store.
1894 * src/modest-ui-actions.c:
1895 (modest_ui_actions_on_folder_selection_changed):
1896 * src/modest-ui-dimming-rules.c:
1897 (modest_ui_dimming_rules_on_new_folder):
1898 * src/widgets/modest-folder-view.c: (text_cell_data),
1899 (icon_cell_data), (filter_row), (update_model),
1900 (get_cmp_rows_type_pos):
1903 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1904 Do not get the priv struct, because no priv struct has been set,
1905 to avoid a runtime warning.
1907 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1908 #ifelse with #else, to fix a warning, to fix the build.
1911 2007-06-05 Christian Kellner <ckellner@openismus.com>
1913 * libmodest-dbus-client/libmodest-dbus-client.c:
1914 Fix small typo in doc (why do you always see them
1915 AFTER committing stuff?)
1918 2007-06-05 Christian Kellner <ckellner@openismus.com>
1920 * libmodest-dbus-client/libmodest-dbus-client.c:
1921 (libmodest_dbus_client_search):
1922 Initialize hit list with NULL. Also set folder list
1923 to "" if NULL was supplied.
1926 2007-06-03 Christian Kellner <ckellner@openismus.com>
1928 * libmodest-dbus-client/libmodest-dbus-client.c:
1929 (modest_search_hit_list_free):
1930 Make it save to call it with NULL.
1932 * src/dbus_api/modest-dbus-callbacks.c:
1933 * src/modest-search.c:
1934 Return full ModestSearchHits as the search result list not TnyHeader
1935 since can't be around withouth the correspoding TnyFolder.
1937 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1939 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1940 Added currently commented code to check for secure auth
1942 * src/maemo/modest-account-settings-dialog.c: (on_response),
1943 (save_configuration), (show_ok):
1944 Fixed projects.maemo.org bugs NB #59248 and #59251
1946 * src/maemo/modest-maemo-utils.c:
1947 (on_camel_account_get_supported_secure_authentication_status),
1948 (on_camel_account_get_supported_secure_authentication),
1949 (modest_maemo_utils_get_supported_secure_authentication_methods):
1950 * src/maemo/modest-maemo-utils.h:
1951 Moved get_supported_secure_authentication() method here to be able
1952 to use it from easysetup wizard.
1954 * src/modest-pair.c: (on_pair_compare_as_string):
1955 Should compare string with first part of pair and not
1956 strcmp pairs which will crash.
1958 * src/modest-protocol-info.c:
1959 (modest_protocol_info_protocol_is_store):
1960 * src/modest-protocol-info.h:
1961 Added modest_protocol_info_get_auth_protocol_name()
1963 2007-06-03 Armin Burgmeier <armin@openismus.com>
1965 * src/modest-mail-operation.c:
1966 (modest_mail_operation_get_msgs_full): Set priv->account also when
1967 only retrieving a single message. This avoids a crash when canceling
1970 (modest_mail_operation_notify_end): Do not explicitely remove the
1971 operation from the queue but only emit the progress_changed signal.
1972 The queue itself listens to that signal to remove the operation when
1973 it is finished. This reduces coupling and removes a potential deadlock
1974 when modest_mail_operation_notify_end() is called from the queue
1975 itself. If that is a problem performance-wise, I would suggest to
1976 implement a status-changed signal or something.
1978 * src/modest-mail-operation-queue.c: Make sure to never call a
1979 function from another file while the queue is locked. This (hopefully)
1980 fixes another deadlock when exiting the application while retrieving
1983 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1985 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1986 Fixed build if libogs is not available
1988 2007-06-03 Christian Kellner <ckellner@openismus.com>
1990 * libmodest-dbus-client/libmodest-dbus-client.h:
1991 * libmodest-dbus-client/libmodest-dbus-client.c:
1992 (libmodest_dbus_client_delete_message):
1993 Implement deletion of messages (Client side).
1995 (modest_search_hit_free),
1996 (modest_search_hit_list_free):
1997 Utility functions to free the result hits.
1999 * src/dbus_api/modest-dbus-api.h:
2000 * src/dbus_api/modest-dbus-callbacks.c:
2001 (on_delete_message),
2002 (modest_dbus_req_handler):
2003 Implement deletion of messages (Server side).
2005 * tests/dbus_api/test_search.c: (main):
2008 * tests/dbus_api/Makefile.am:
2009 * tests/dbus_api/test_delete_message:
2010 Add little test for the message deletion logic
2012 2007-06-03 Armin Burgmeier <armin@openismus.com>
2014 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2015 when the operation queue was not empty. projects.maemo.org bug
2018 2007-06-03 Armin Burgmeier <armin@openismus.com>
2020 * src/widgets/modest-account-view.c
2021 (on_account_default_toggled): Toggle default account column
2022 explicitely instead of waiting for gconf notification (which is
2023 currently ignored). This should fix projects.maemo.org bug NB#56910
2024 for now. It should probably be removed when gconf notifications are
2027 2007-06-03 Christian Kellner <ckellner@openismus.com>
2029 * libmodest-dbus-client/libmodest-dbus-client.c:
2030 Removed debugging spew.
2032 * src/dbus_api/modest-dbus-callbacks.c:
2033 Added debugging info.
2035 * src/modest-search.c:
2036 (modest_search_all_accounts):
2037 Use tny_account_store_get_accounts () on the account store
2038 to get all accounts which is the way to get all accounts.
2040 * tests/dbus_api/test_search.c: (main):
2041 Make it possible to supply the search term on the command line.
2043 2007-06-03 Christian Kellner <ckellner@openismus.com>
2045 * libmodest-dbus-client/libmodest-dbus-client.c:
2046 * libmodest-dbus-client/libmodest-dbus-client.h:
2047 Implement searching for mesages over raw dbus. (Client side)
2049 * src/dbus_api/Makefile.am:
2050 * src/dbus_api/modest-dbus-api.h:
2051 * src/dbus_api/modest-dbus-callbacks.c:
2052 * src/dbus_api/modest-dbus-callbacks.h:
2053 Search framework (Server side). Also implement on_idle_open_message().
2055 * src/maemo/modest-platform.c: (modest_platform_init):
2056 Prepare for raw dbus/osso rpc interaction.
2058 * src/modest-search.h:
2059 Changed minsize from unspecific guint to guint32.
2061 * src/modest-search.c:
2063 Added strange hack which magically made tnymail work.
2065 (modest_search_folder),
2066 (modest_search_account),
2067 (modest_search_all_accounts):
2068 Implement helper functions to search all accounts, specific account
2071 * tests/dbus_api/Makefile.am:
2072 * tests/dbus_api/test_open_message.c:
2073 Read url to open from commandline.
2075 * tests/dbus_api/test_search.c:
2076 Implement small test for dbus search stuff
2078 2007-06-02 Armin Burgmeier <armin@openismus.com>
2080 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2081 include account type and account title. This fixes projects.maemo.org
2084 * src/maemo/modest-account-view-window.c: Set a title for the window.
2086 2007-06-02 Armin Burgmeier <armin@openismus.com>
2088 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2089 incoming and outgoing server name based on email address and server
2090 types as long as the names have not been edited manually. This fixes
2091 projects.maemo.org bug NB#58671.
2093 2007-06-02 Armin Burgmeier <armin@openismus.com>
2095 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2096 server type cannot be changed in future to the incoming details page
2097 when creating an account. This fixes projects.maemo.org bug NB#59029.
2099 2007-06-02 Armin Burgmeier <armin@openismus.com>
2101 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2102 and assigned max width chars so that they wrap instead of being
2103 truncated. Fixes projects.maemo.org bug NB#56126.
2105 2007-06-02 Armin Burgmeier <armin@openismus.com>
2107 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2108 introductory note to the connection specific smtp servers dialog, as
2109 section 8.12 of the email UI specification requires. This fixes
2110 projects.maemo.org bug NB#59212.
2112 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2115 Check for running mail operations, and offer to cancel them, as per the UI
2116 spec. This fixes projects.maemo.org bug NB#59041 .
2117 However, I suspect that tinymail may still use the network connection
2118 in ways that we cannot detect or cancel. But it should at least adapt to
2119 changes fairly well.
2121 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2123 * src/modest-tny-account-store.c: (recreate_all_accounts),
2124 (get_cached_accounts), (get_server_accounts): Do more sensible
2125 ref-counting of the temporarily-cached outbox accounts list. This seems
2126 to fix a crash when entering the password when the password was wrong.
2128 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2130 * src/gnome/modest-main-window.c: (connect_signals):
2131 * src/modest-tny-account-store.c: (get_password),
2132 (modest_tny_account_store_alert): Added comments and clues and
2133 commented-out code about how we currently fail to deal with connection
2134 errors and wrong passwords, and how we should.
2136 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2138 * src/widgets/modest-retrieve-combo-box.c:
2139 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2140 This fixes projects.maemo.org bug NB#58472 .
2142 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2144 * src/maemo/easysetup/modest-easysetup-wizard.c:
2145 (create_page_complete_easysetup):
2146 (create_page_complete_custom): Correct the last commit,
2147 putting the correct sentences in the correct pages.
2149 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2151 * src/maemo/easysetup/modest-easysetup-wizard.c:
2152 (create_page_complete_custom): Show the second sentence of text
2153 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2156 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2158 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2159 Set the leave-on-server conf key by default. This fixes
2160 projects.maemo.org bug NB#59258 .
2162 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2164 * src/maemo/modest-account-view-window.c:
2165 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2166 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2169 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2171 * src/maemo/easysetup/modest-easysetup-wizard.c:
2172 (create_caption_new_with_asterisk):
2173 * src/maemo/modest-account-settings-dialog.c:
2174 (create_caption_new_with_asterisk):
2175 Uncomment the code to add the asterisk, because they are no longer in the
2176 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2177 (update_incoming_server_title): Add an asterisk here too.
2179 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2181 * src/maemo/modest-maemo-global-settings-dialog.c:
2182 (current_connection): Check that we are even connected before trying to
2183 get the current connection name, to prevent a warning.
2185 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2186 Change the comments because tny_maemo_conic_device_connect() is now meant to
2188 * src/modest-mail-operation.c:
2189 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2190 make sure we have a connection and fail if we can't connect.
2192 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/modest-main-window.c:
2195 (on_account_store_connecting_finished): Do not try to get the
2196 connection ID if we are not really connected. I am surprised that
2197 this signal handler is called when we are not connected.
2199 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2201 * src/modest-error.h:
2202 * src/modest-ui-actions.c:
2203 (modest_ui_actions_get_msgs_full_error_handler):
2204 Renamed an enum, added comments, added an enum
2205 for retrieve-limit errors.
2207 * src/modest-mail-operation.c: (foreach_add_item),
2208 (internal_folder_observer_update), (update_account_thread),
2209 (modest_mail_operation_get_msgs_full):
2210 (modest_mail_operation_update_account),
2211 Added comments about how this works, and some code that should
2212 (but does not) check the retrieve-limit. See the TODO comment.
2214 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2216 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2217 Initialize help_id to fix the build. Warnings are good.
2219 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2221 * src/widgets/modest-hbox-cell-renderer.c:
2222 (modest_hbox_cell_renderer_append):
2223 * src/widgets/modest-vbox-cell-renderer.c:
2224 (modest_vbox_cell_renderer_append):
2225 Fix the last commit by doing an extra ref.
2227 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2229 * src/widgets/modest-hbox-cell-renderer.c:
2230 (modest_hbox_cell_renderer_append):
2231 * src/widgets/modest-vbox-cell-renderer.c:
2232 (modest_vbox_cell_renderer_append):
2233 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2234 to fix the build with Maemo Bora.
2235 However, there seems to be a remaining crash, probably due to reference
2238 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2240 * src/modest-tny-account.c:
2241 (modest_tny_account_new_for_local_folders):
2242 Use hildon_file_system_info_async_new() to get a better name for
2243 the memory card account, setting it as the account name.
2244 The timing seems to work, but this is probably
2245 not the best place to do this. See the TODO comment.
2246 * src/maemo/modest-main-window.c: (create_details_widget):
2247 * src/widgets/modest-folder-view.c: (text_cell_data):
2248 Use the tny account name instead of hardcoding a name.
2250 2007-05-30 Christian Kellner <ckellner@openismus.com>
2252 * src/modest-search.c: (modest_search):
2253 Correctly set part_search_func even if we have already parsed
2254 the query and thus a valid OgsTextSearcher object.
2256 2007-05-30 Christian Kellner <ckellner@openismus.com>
2259 Search and check for libogs.
2262 Incooparte the ogs build env.
2264 * src/modest-mime-part-search-stream.c:
2265 * src/modest-mime-part-search-stream.h:
2266 Removed since we do the real searching now in modest-search.c.
2268 * src/modest-search.c:
2269 * src/modest-search.h:
2270 Implement support for ogs. We use that if available and requested
2271 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2272 should now handle the corner case when the search term is spread
2273 across multiple reads.
2274 Also the logic in modest_search () was corrected to search all
2275 requested fields until one is found.
2277 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2279 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2281 * src/modest-init.h:
2282 * src/modest-init.c: Made modest_init_local_folders() take a
2283 path and be public so we can iniitialize maildir folders on
2286 * src/modest-local-folder-info.h:
2287 * src/modest-local-folder-info.c:
2288 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2290 * src/modest-tny-account.c:
2291 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2292 still means the standard local-folders path on the local volume.
2294 * src/modest-tny-account-store.c:
2295 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2296 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2297 all accounts when that happens.
2298 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2299 this too, so it shows up in the treeview.
2301 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2303 * src/maemo/modest-maemo-global-settings-dialog.c:
2304 (current_connection):
2305 * src/widgets/modest-global-settings-dialog.c:
2306 (current_connection_default):
2307 Use the enum values instead of 0, 1 and -1,
2308 to make the code clearer.
2310 * src/modest-account-mgr-helpers.c:
2311 (modest_account_mgr_get_connection_specific_smtp): Make this code
2314 * src/modest-runtime.h:
2315 * src/modest-runtime.c:
2316 Added modest_runtime_remove_all_send_queues().
2317 * src/maemo/modest-main-window.c:
2318 (on_account_store_connecting_finished): Recreate the send queues,
2319 using the appropriate transport accounts for this new connection.
2320 Some futher adapting might be needed if the old send queues are not
2321 automatically stopped at this point.
2323 * src/modest-tny-account-store.c: (get_server_accounts):
2324 Create the connection-specific transport accounts, so that they can
2325 be found later by their ID.
2327 * src/modest-tny-account.h:
2328 * src/modest-tny-account.c:
2329 Added modest_tny_account_new_from_server_account_name().
2330 modest_tny_account_new_from_server_account(): Do not create the
2331 send queues here, because they will be
2332 recreated anyway when the connection changes for the first time.
2334 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2336 * src/modest-local-folder-info.h:
2337 * src/modest-local-folder-info.c:
2338 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2339 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2340 tbox_folder): Take a modest account name instead of a server TnyAccount,
2341 so we can have per-modest-account rather than per-transport-account
2343 We must make sure that we change or recreate the exisitng send queues
2344 when the connection changes for connection-specific transport accounts.
2346 * src/modest-tny-account-store.c:
2347 (create_per_account_local_outbox_folders): Create outboxed per modest
2348 account, not per transport account.
2350 * src/modest-tny-account.h:
2351 * src/modest-tny-account.c:
2352 (modest_tny_account_get_special_folder): For outboxes, get the
2353 parent modest account name. The account is ignored for other folders.
2354 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2355 modest account name rather than a server TnyAccount.
2357 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2359 * src/modest-tny-account.c:
2360 (modest_tny_account_new_from_server_account):
2361 Call modest_runtime_get_send_queue() immediately after creating transport
2362 accounts, so that they start trying to send email from the outbox as soon
2363 as possible at startup. This is probably what we want.
2365 * src/modest-mail-operation.c: (update_account_thread):
2366 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2367 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2368 * src/modest-tny-send-queue.h:
2369 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2370 (modest_ui_actions_on_send):
2371 Added comments about how sending works, though it needs some more work.
2373 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2375 * src/modest-tny-account.c:
2376 (modest_tny_account_get_special_folder): Add TODO because this fails when
2377 the network is busy.
2378 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2379 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2380 Do not try to show this window when there is no active account. The UI
2381 specs does not tell us what to do in this case.
2383 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2387 * src/maemo/Makefile.am:
2388 * src/widgets/Makefile.am: Some dist fixes.
2390 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2392 * src/maemo/modest-connection-specific-smtp-window.c:
2393 (on_button_edit): Make the code clearer, to prevent a double free.
2395 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2397 * src/maemo/modest-account-settings-dialog.c:
2398 (modest_account_settings_dialog_set_account_name),
2399 Check the connection-specific smtp servers checkbox if there are any.
2401 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2402 (modest_connection_specific_smtp_edit_window_init):
2403 Start with a suitable port number.
2405 * src/modest-account-mgr-helpers.h:
2406 * src/modest-account-mgr-helpers.c: Added
2407 modest_account_mgr_get_has_connection_specific_smtp().
2409 (modest_account_mgr_set_connection_specific_smtp),
2410 (modest_account_mgr_remove_connection_specific_smtp),
2411 (modest_account_mgr_get_has_connection_specific_smtp),
2412 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2413 connection-specific smtp server accounts in the account, rather than
2414 the server account conf dir.
2416 This fixes bug projects.maemo.org bug NB#58263 .
2418 * src/modest-tny-account-store.c:
2419 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2420 if there are no server accounts yet, to prevent an infinite loop when there
2421 are no accounts. Document that one must be called before the other.
2423 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2425 * src/modest-account-mgr-helpers.c:
2426 (modest_account_mgr_get_default_account): Make sure that at least
2427 one account is always the default, if there are any enabled accounts.
2428 This is just a sanity check that shouldn't be necessary.
2430 * src/modest-account-mgr-priv.c:
2431 (_modest_account_mgr_account_from_key): Unescape the conf key to
2432 get the real account name. For instance, this is an issue if a space
2433 was in the account name, which can happen because the account name
2434 is generated from the display name.
2435 (_modest_account_mgr_get_account_keyname): Always escape the
2437 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2438 Unescape the conf keys to get the real account names.
2440 For instance, previously the is-default radio button in the accounts
2441 list was not checked for any accounts at first. This fixes that,
2442 and might fix several similar bugs.
2444 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2446 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2447 Removed some debug printfs.
2449 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2451 Modest on-disk outbox directories are now here, for instance:
2452 $HOME/.modest/outboxes/<account-id-1>/outbox
2453 $HOME/.modest/outboxes/<account-id-2>/outbox
2455 $HOME/.modest/local-folders/outbox
2456 so we can have a separate outbox for each account.
2457 But they are shown as one outbox in the GtkTreeView, by using a
2458 TnyMergeFolder in a ModestTnySimpleFolderStore.
2461 * src/modest-tny-simple-folder-store.c:
2462 * src/modest-tny-simple-folder-store.h:
2463 Added ModestTnySimpleFolderStore, used to contain folders from
2464 other folder stores, such as other accounts.
2466 * src/modest-tny-outbox-account.h:
2467 * src/modest-tny-outbox-account.c:
2468 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2469 used for the per-account local outbox folders.
2471 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2472 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2473 only use this (internally) now for the non-outbox local folders.
2475 * src/modest-init.h:
2476 * src/modest-init.c: Added modest_init_one_local_folder(), for
2477 setting up the directory structure for each local folder.
2479 * src/modest-local-folder-info.c:
2480 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2481 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2483 * src/modest-local-folder-info.h:
2484 * src/modest-tny-account-store.c: (on_account_removed),
2485 (on_account_changed), (create_per_account_local_outbox_folders),
2486 (get_server_accounts), (modest_tny_account_store_get_accounts),
2487 (modest_tny_account_store_get_tny_account_by_account),
2488 (modest_tny_folder_store_is_virtual_local_folders):
2490 * src/modest-tny-account.h:
2491 * src/modest-tny-account.c:
2492 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2493 to create an on-disk per-account local outbox folder for each
2495 (create_per_account_local_outbox_folders): Create a local outbox folder
2496 for each transport account.
2497 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2498 for all local folders.
2500 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2501 instead of using g_object_get/set() directly. It is clearer.
2503 (modest_tny_folder_store_get_message_count),
2504 (modest_tny_folder_store_get_local_size
2505 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2506 because we now use these with non-acount folder stores.
2508 (modest_tny_account_get_special_folder),
2509 (modest_tny_account_new_from_server_account),
2510 (modest_tny_account_new_from_account):
2511 (recurse_folders): Adjust to the new outbox system.
2513 * src/modest-tny-folder.h:
2514 * src/modest-tny-folder.c:
2515 (modest_tny_folder_is_local_folder),
2516 (modest_tny_folder_get_local_folder_type),
2517 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2519 * src/widgets/modest-main-window.h:
2520 * src/maemo/modest-main-window.c: (create_details_widget),
2521 (modest_main_window_set_contents_style): Show details for any folder store,
2524 (modest_tny_folder_get_rules):
2525 Remove the const. C does not support constness enough for this.
2527 * src/modest-ui-actions.c:
2528 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2529 make all outboxes appear as one, in the usual local-folders tree node.
2531 (set_active_account_from_tny_account),
2532 (modest_ui_actions_on_folder_selection_changed):
2533 * src/widgets/modest-folder-view.c: (text_cell_data),
2534 (icon_cell_data), (filter_row),
2535 (add_account_folders_to_merged_folder),
2536 (add_account_folders_to_simple_folder_store), (),
2537 (get_cmp_rows_type_pos), (cmp_rows),
2538 (modest_folder_view_set_account_id_of_visible_server_account):
2539 Adjust to the new outbox system, using generic folder stores and folders
2540 in the GtkTreeModel.
2542 2007-05-23 Christian Kellner <ckellner@openismus.com>
2544 * src/modest-mail-operation.c:
2545 (modest_mail_operation_update_account):
2546 Use info->max_size instead of unintialized local var [small
2547 build fix]. (Added TODO to review that change since I don't
2550 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2552 * libmodest-dbus-client/libmodest-dbus-client.c:
2553 (libmodest_dbus_client_compose_mail): function added
2554 * src/dbus_api/modest-dbus-api.h:
2555 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2556 (on_compose_mail): Implementation of the SendAsMail functionality
2558 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2560 * src/modest-account-mgr.c:
2561 (modest_account_mgr_add_server_account): Set the secure-connection
2562 conf key for transport accounts as well as store accounts. I don't know
2563 why the if was there. For instance, this makes sure that we use SSL
2564 for the gmail preset from the easysetup wizard.
2566 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2568 * src/gnome/modest-main-window.c:
2569 (on_account_store_connecting_finished), (connect_signals):
2570 * src/maemo/modest-main-window.c:
2571 (on_account_store_connecting_finished), (connect_signals),
2572 (modest_main_window_new):
2573 Handle TnyAccountStore::connecting-finished instead of
2574 TnyDevice::connection-changed, because we cannot actually perform
2575 operations on accounts until TnyAccountStore has itself responded to
2576 the TnyDevice::connection-changed signal. This prevents a GError from
2578 Do not try to update at startup, because we (at least on scratchbox)
2579 already do an update at startup when the device goes online.
2580 This prevents a GError from tinymail.
2581 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2582 Added TODO about stopping simultaneous operations.
2584 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2587 * src/modest-mail-operation-queue.c:
2588 (modest_mail_operation_queue_remove):
2589 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2590 about where they happened.
2592 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2594 * src/modest-ui-actions.c:
2595 (modest_ui_actions_on_password_requested): Make sure that the remember
2596 output parameter is always TRUE.
2598 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2600 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2601 Show a OK/Cancel dialog if the error is a question, though we still do not
2602 know anything more about what we are asking the user.
2603 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2604 Fix an uninitialized variable (helper). This is a logic error, however.
2606 2007-05-21 Christian Kellner <ckellner@openismus.com>
2608 * src/modest-search.h:
2609 Correct bit shifting in the ModestSearchFlags enum.
2611 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2613 * src/modest-tny-account.c:
2614 (modest_tny_account_new_from_server_account): Do not use the lsub and
2615 check-all hard-coded IMAP options when using POP.
2617 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2619 * src/modest-tny-account.c:
2620 (modest_tny_account_new_from_server_account):
2621 Use NULL for the secure-auth method for POP when Password auth has been
2622 specified by the user, as we already do for IMAP. "auth=Login" causes
2623 an error from camel or the server.
2625 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2627 * src/maemo/modest-account-settings-dialog.c:
2628 (create_page_account_details),
2629 (modest_account_settings_dialog_set_account_name):
2630 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2631 for the leave-on-server checkbox, rathr than just the checkbox, when
2632 the protocol is not POP.
2634 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2636 * src/widgets/modest-account-view.c:
2637 * src/widgets/modest-account-view.h:
2638 Added modest_account_view_select_account() which will be useful later
2639 to asynchronously re-select the edited account.
2641 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/modest-account-settings-dialog.c:
2644 (modest_account_settings_dialog_set_account_name):
2645 Automatically choose the port numbers based on the secure authentication
2646 methods, if they have not been chosen before.
2647 This fixes projects.maemo.org bug NB#56273 .
2649 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2651 * src/maemo/modest-main-window-ui.h:
2652 * src/modest-ui-actions.c:
2653 * src/modest-ui-actions.h:
2654 Connect the Tools/SMTP Servers menu item to
2655 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2656 SMTP servers dialog, as in the UI specification and saves changes when it
2657 is closed. This fixed projects.maemo.org bug NB#56305 .
2659 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2661 * src/maemo/modest-connection-specific-smtp-window.c:
2662 (modest_connection_specific_smtp_window_init):
2663 Use gtk_window_set_default_size() to make this window big enough, so
2664 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2666 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2669 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2670 (modest_connection_specific_smtp_edit_window_init),
2671 Do not try to connect to a combobox signal before the combobox exists.
2672 This fixes the cras in projects.maemo.org bug NB#56288 .
2673 (modest_connection_specific_smtp_edit_window_get_settings):
2674 Remove the server_account_name parameter which was being checked for NULL
2675 though it was not used.
2677 * src/maemo/modest-connection-specific-smtp-window.c:
2678 (modest_connection_specific_smtp_window_fill_with_connections),
2679 (on_button_edit), (modest_connection_specific_smtp_window_init):
2680 Correct the number of treemodel columns to prevent a warning.
2681 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2682 libconic does not work.
2684 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2686 * src/modest-tny-account.c:
2687 (modest_tny_account_new_from_server_account):
2688 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2689 SMTP when "None" was chosen by the user. However, with my SMTP server that
2690 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2693 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2695 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2696 to explain the memory management issue with the ID in the ModestPair.
2698 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2699 (add_sending_page), (modest_account_assistant_finalize):
2700 * src/gnome/modest-gnome-global-settings-dialog.c:
2701 (create_updating_page), (create_composing_page):
2702 * src/gnome/modest-msg-edit-window.c: (get_transports),
2703 (init_window), (modest_msg_edit_window_finalize),
2704 (modest_msg_edit_window_get_msg_data):
2705 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2706 * src/gnome/modest-transport-widget.c:
2707 (modest_transport_widget_finalize), (smtp_configuration):
2708 * src/maemo/modest-maemo-global-settings-dialog.c:
2709 (create_updating_page), (create_composing_page):
2710 * src/maemo/modest-msg-edit-window.c: (get_transports),
2711 (init_window), (modest_msg_edit_window_finalize),
2712 (modest_msg_edit_window_get_msg_data),
2713 (modest_msg_edit_window_free_msg_data):
2714 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2715 (modest_store_widget_finalize):
2716 * src/maemo/modest-transport-widget.c:
2717 (modest_transport_widget_finalize), (smtp_configuration):
2718 * src/modest-main.c: (send_mail):
2719 * src/widgets/modest-combo-box.h:
2720 * src/widgets/modest-global-settings-dialog-priv.h:
2721 * src/widgets/modest-global-settings-dialog.c:
2722 (modest_global_settings_dialog_finalize):
2723 * src/widgets/modest-msg-edit-window.h:
2724 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2725 as long as the combo box, to prevent use of freed memory for the ID.
2727 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2729 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2730 get_accounts(), to make this clearer. Do not check for the enabled gconf
2731 key, because we do not use this for server accounts (at least, not yet).
2732 This allows us to send email again.
2734 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/modest-platform.c:
2737 (on_modest_conf_update_interval_changed), (modest_platform_init):
2738 Only respond to this particular key change. All these strcmp()s cannot be
2741 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2743 * src/maemo/modest-maemo-global-settings-dialog.c:
2744 (current_connection): Prevent a crash in scratchbox when
2745 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2746 * src/maemo/modest-platform.c:
2747 (on_modest_conf_update_interval_changed), (modest_platform_init):
2748 Get the update interval from gconf and reset it when the gconf key changes.
2750 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2752 * src/modest-protocol-info.c:
2753 * src/modest-protocol-info.h: Adde enum-specific get functions,
2754 instead of using a ModestProtocolType enum parameter.
2756 * src/gnome/modest-account-assistant.c:
2757 * src/gnome/modest-store-widget.c:
2758 * src/gnome/modest-store-widget.h:
2759 * src/gnome/modest-transport-widget.c:
2760 * src/gnome/modest-transport-widget.h:
2761 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2762 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2763 * src/maemo/easysetup/modest-easysetup-wizard.c:
2764 * src/maemo/modest-account-settings-dialog.c:
2765 * src/maemo/modest-account-settings-dialog.h:
2766 * src/maemo/modest-store-widget.c:
2767 * src/maemo/modest-store-widget.h:
2768 * src/maemo/modest-transport-widget.c:
2769 * src/maemo/modest-transport-widget.h:
2770 * src/modest-account-mgr-helpers.c:
2771 * src/modest-account-mgr-helpers.h:
2772 * src/modest-account-mgr.c:
2773 * src/modest-account-mgr.h:
2774 * src/modest-tny-account.c:
2775 * src/modest-tny-folder.c:
2776 * src/widgets/modest-account-view.c:
2777 * src/widgets/modest-retrieve-combo-box.c:
2778 * src/widgets/modest-retrieve-combo-box.h:
2779 * src/widgets/modest-secureauth-combo-box.c:
2780 * src/widgets/modest-serversecurity-combo-box.c:
2781 * src/widgets/modest-serversecurity-combo-box.h:
2782 * tests/check_account-mgr.c:
2783 Use the specific functions, and use the re-renamed enum values for GNOME too.
2785 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2787 * src/modest-pair.h:
2788 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2789 so we can get the second based on the first.
2791 * src/maemo/modest-account-settings-dialog.h:
2792 * src/maemo/modest-account-settings-dialog.c:
2793 Added get_supported_secure_authentication_methods(), though it is mostly
2794 commented-out for now until the necessary API is committed to tinymail.
2795 (modest_account_settings_dialog_set_account_name),
2796 (save_configuration): Request the supported authentication methods from the
2797 server, so we can choose a working method.
2799 * src/modest-tny-account-store.h:
2800 * src/modest-tny-account-store.c:
2801 (modest_tny_account_store_get_session): Rename from
2802 tny_account_store_get_session().
2804 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2806 * src/modest-protocol-info.h: Split the ModestProtocol enum
2807 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2808 There was no need to have these unrelated values in one enum.
2810 * src/: many files: Adapted to changed enum. This makes the code a bit
2811 clearer, and the compiler could catch some errors.
2813 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2815 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2816 Show the detailed internal camel error message when an error happens
2817 during the configuration, so that our testers can give us more clues.
2818 For instance, in projects.maemo.org bug NB#56910 .
2820 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2822 * src/modest-tny-account.c:
2823 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2824 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2826 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2828 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2829 * src/maemo/modest-account-settings-dialog.c:
2830 (modest_account_settings_dialog_set_account_name),
2831 (save_configuration): For the incoming secure authentication checkbox,
2832 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2833 the UI specification. PLAIN does not seem to be supported for most IMAP
2834 servers anyway, and I am not sure what it would mean.
2835 However, we probably need to discover which of the secure-authentication
2836 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2837 * src/modest-account-mgr-helpers.c:
2838 (modest_account_mgr_get_server_account_data):
2840 * src/modest-tny-account.c:
2841 (modest_tny_account_new_from_server_account):
2842 Use tny_account_set_mech() to set secure-authentication methods,
2843 with some special-casing for IMAP, based on my observations of how
2846 * src/modest-account-mgr-helpers.h:
2847 * src/modest-account-mgr.c:
2848 * src/modest-defs.h: Comment that the URI is only used for local folders.
2850 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2852 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2853 parameter const, just to be neat.
2854 * src/modest-text-utils.c: (modest_text_utils_inline):
2855 End g_strconcat() with NULL, as its documentation says. This is almost
2856 certainly the cause of my crash at startup on the device. Interestingly,
2857 valgrind doesn't tell us about these errors.
2859 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2861 * scripts/build-packages: Added more precise comments about how to use
2862 this script, though I still get this error:
2863 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2864 error building tinymail
2866 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2868 * src/maemo/modest-main-window.c: (on_account_update):
2869 Very slight cleanup, hoping to make it simpler to discover what causes
2870 a crash here sometimes.
2872 * src/modest-tny-account.c:
2873 (modest_tny_account_new_from_server_account): Set the port. Added
2874 comments about the options and a TODO comment because I need to find out
2875 how to specify the secure authentication method.
2877 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2879 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2880 changed CFlags paths form modest to libmodest
2882 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2884 * src/modest-account-mgr-helpers.c:
2885 (modest_account_mgr_get_server_account_data),
2886 (modest_account_mgr_free_server_account_data):
2887 * src/modest-account-mgr-helpers.h:
2888 * src/modest-account-mgr.c:
2889 (modest_account_mgr_add_server_account):
2890 * src/modest-defs.h:
2891 * src/modest-tny-account.c:
2892 (modest_tny_account_new_from_server_account):
2893 Determine the options for tny_camel_account_add_option() here,
2894 based on the settings, rather than storing them directly in gconf.
2896 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2898 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2899 Show a more friendly error dialog now that we expect (from the tinymail
2900 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2902 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2904 * src/maemo/modest-main-window.c: (on_account_update): Check that
2905 account_name is not NULL, to prevent a crash at startup that I am
2906 seeing on the N800. I do wonder why it is NULL.
2908 * src/maemo/easysetup/modest-easysetup-wizard.c:
2909 (create_page_user_details):
2910 * src/maemo/modest-account-settings-dialog.c:
2911 (create_page_user_details), (create_page_outgoing):
2912 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2913 (modest_connection_specific_smtp_edit_window_init):
2914 * src/modest-ui-actions.c:
2915 (modest_ui_actions_on_password_requested):
2916 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2917 might do something useful with the on-screen keyboard.
2919 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2921 * src/maemo/modest-main-window.c: (on_account_update):
2922 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2923 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2925 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2927 * src/modest-tny-account-store.c: (on_account_changed):
2928 Correct the signature of this signal handler.
2930 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2932 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2933 Show a HildonNote instead of a GtkDialog for Maemo.
2935 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2937 * src/widgets/modest-account-view.h:
2938 * src/widgets/modest-account-view.c: (on_account_changed),
2939 (on_account_removed). Added a boolean flag, set/unset by
2940 modest_account_view_block_conf_updates(),
2941 modest_account_view_unblock_conf_updates() to prevent unnecessary
2942 updates, but this is not very useful because the gconf notifications are
2943 so delays (maybe only on Maemo Bora).
2944 So auto-updating is turned off, and these functions do an explicit
2945 update when necessary.
2946 However, something else is still doing too much work when adding/removing
2947 accounts, probably in another part of the application.
2949 * src/maemo/modest-account-view-window.c:
2950 (on_delete_button_clicked), (on_edit_button_clicked),
2951 (on_new_button_clicked): Use the new functions.
2953 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2955 * src/modest-account-mgr-helpers.c:
2956 (modest_account_mgr_set_first_account_as_default):
2957 Sort the list of names alphabetically-by-title, so we choose the first one
2959 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2960 alphabetically by the title.
2962 This fixes projects.maemo.org bug NB#56418 .
2964 * src/modest-account-mgr-priv.c:
2965 (_modest_account_mgr_account_from_key):
2966 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2967 avoid a valgrind error, and possible random behaviour.
2969 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2971 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2972 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2973 tinymail documentation to say that this can be expected.
2974 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2975 pretty, and should not happen, but I would prefer to know when it does.
2977 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2979 * configure.ac: When using the older hildon version, probably on Bora,
2980 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2982 * src/widgets/modest-attachment-view.c:
2983 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2986 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2988 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2989 Implemented the prototype. Can be tested with
2990 tests/dbus_api/test_open_message:
2992 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2994 * src/modest-tny-account-store.c:
2995 (modest_tny_account_store_instance_init), (get_password):
2996 * src/modest-ui-actions.c:
2997 (modest_ui_actions_on_password_requested):
2998 Do not store the password in gconf, because this function is called
2999 for non-remembered passwords. Actually use the cached (in the hash map)
3000 password instead of releasing it.
3001 The password will now not be remembered if it is asked via the protected
3002 password dialog, as per the UI spec.
3004 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3006 * src/modest-defs.h:
3007 * src/modest-account-mgr-helpers.h:
3008 * src/modest-account-mgr-helpers.c:
3009 Added modest_server_account_get_username_has_succeeded(),
3010 modest_server_account_set_username_has_succeeded().
3011 (modest_server_account_set_username),
3012 Reset the has-succeeded flag if the username changes.
3014 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3015 * src/maemo/modest-connection-specific-smtp-window.c:
3016 (modest_connection_specific_smtp_window_save_server_accounts):
3017 Use modest_server_account_set_username() instead of using
3018 modest_conf_set_string() directly, so that the has-succeeded flag is always
3021 * src/modest-ui-actions.c:
3022 (modest_ui_actions_on_password_requested): Dim the username entry if
3023 the username has ever worked, as per the UI spec.
3025 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3027 * src/modest-tny-account-store.c: (get_password):
3028 * src/modest-ui-actions.c:
3029 (modest_ui_actions_on_password_requested):
3030 Allow the username to be changed too, though there is more work to
3031 be done on exactly how this behaves.
3033 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3035 * src/modest-account-mgr-helpers.h:
3036 * src/modest-account-mgr-helpers.c:
3037 Added modest_account_mgr_get_display_name(),
3038 modest_server_account_get_username(),
3039 modest_server_account_set_username(),
3040 modest_server_account_set_password(),
3041 modest_server_account_get_hostname() functions so we do not need to
3042 use the conf API directly.
3044 * src/maemo/modest-main-window.c: (connect_signals):
3045 Actually connect ot the ModestAccountStore::request-password signal,
3046 so that we show the dialog when the password is requested by Tinymail,
3047 for isntance if it is empty.
3049 * src/modest-marshal.list:
3050 * src/modest-tny-account-store.c:
3051 (modest_tny_account_store_class_init), (get_password),
3052 (modest_tny_account_store_alert):
3053 * src/modest-tny-account-store.h:
3054 * src/modest-ui-actions.h:
3055 * src/modest-ui-actions.c:
3056 (modest_ui_actions_on_password_requested):
3057 Change the signal parameters, so it is obvious that we are providing
3058 the non human-readable server name, and receiving both the username
3059 and password, though changing of the username is not yet implemented.
3060 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3061 for the GNOME version.
3063 This should fix the projects.maemo.org bug NB#56209, though it does not
3064 work on Bora, because the gconf_client_get() for the password fails
3065 immediately after we save it with gconf_client_set().
3067 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3070 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3071 caused an undefined symbol error:
3072 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3074 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3076 * src/modest-tny-account-store.c:
3077 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3078 using a GError instead of a string message, so we can translate it in
3081 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3083 * src/maemo/modest-address-book.c:
3084 (modest_address_book_check_names):
3085 * src/maemo/modest-msg-view-window.c:
3086 (modest_msg_view_window_clipboard_owner_change):
3087 * src/modest-init.c: (modest_init_init_ui):
3088 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3089 (update_folders_cb), (modest_mail_operation_update_account):
3090 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3091 (modest_ui_actions_on_msg_attachment_clicked),
3092 (modest_ui_actions_on_msg_recpt_activated):
3093 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3094 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3095 (modest_msg_view_search_next):
3096 * src/widgets/modest-recpt-editor.c:
3097 (modest_recpt_editor_on_button_release_event),
3098 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3099 g_message(). At this point we should only be seeing interesting errors on
3100 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3102 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3104 (modest_wizard_dialog_force_title_update):
3105 * src/maemo/easysetup/modest-wizard-dialog.h:
3106 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3107 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3108 can update the title when appropriate. Otherwise the title is wrong if the
3109 pages are added after adding the notebook to the dialog.
3110 This must be a problem in HildonWizardDialog too.
3111 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3113 * src/maemo/easysetup/modest-easysetup-wizard.c:
3114 (create_subsequent_customsetup_pages),
3115 (create_subsequent_easysetup_pages):
3116 Call modest_wizard_dialog_force_title_update() so that the title is
3117 correct even with GTK+ < 2.10.
3118 This fixes projects.maemo.org bug NB#56145 .
3120 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3122 * src/maemo/modest-platform.c:
3123 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3124 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3127 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3129 * src/widgets/modest-window.h:
3130 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3131 and modest_window_save_state(), which invokes it.
3133 * src/widgets/modest-window-mgr.h:
3134 * src/widgets/modest-window-mgr.c:
3135 Added modest_window_mgr_save_state_for_all_windows(), which calls
3136 the save_state vfunc on all registered windows, if implemented.
3138 * src/gnome/modest-msg-edit-window.c:
3139 * src/gnome/modest-msg-view-window.c:
3140 * src/maemo/modest-msg-edit-window.c:
3141 * src/maemo/modest-msg-view-window.c:
3142 * src/maemo/modest-main-window.c:
3143 Specify the existing save_settings functions as implementations of
3144 ModestWindow::save_state_func().
3146 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3147 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3148 enabling hibernation, for instance.
3150 We may need to do the same thing for restoring settings.
3153 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3155 * src/widgets/modest-window-mgr.c:
3156 * src/widgets/modest-window-mgr.h:
3157 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3158 modest_window_mgr_get_hibernation_is_prevented().
3160 * src/maemo/modest-main-window.c:
3161 (on_hildon_program_is_topmost_notify): Prevent hibernation
3162 (possible when the application goes to the background in the WM),
3163 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3165 * src/maemo/easysetup/modest-easysetup-wizard.c:
3166 (modest_easysetup_wizard_dialog_init):
3167 * src/maemo/modest-account-settings-dialog.c:
3168 (modest_account_settings_dialog_init):
3169 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3170 (modest_connection_specific_smtp_edit_window_init):
3171 * src/maemo/modest-connection-specific-smtp-window.c:
3172 (modest_connection_specific_smtp_window_init):
3173 * src/maemo/modest-signature-editor-dialog.c:
3174 (modest_signature_editor_dialog_init):
3175 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3176 prevent hibernation while any of these account settings dialogs are open.
3178 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3180 * src/maemo/Makefile.am:
3181 * src/maemo/modest-osso-state-saving.c:
3182 * src/maemo/modest-osso-state-saving.h: Added
3183 modest_osso_load_state() and modest_osso_save_state() though they do
3184 nothing now. They should iterate through all the open windows and load/save
3186 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3187 save state when closing.
3189 * src/maemo/modest-main-window.c:
3190 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3191 Add a notification handler for the HildonProgram::is-topmost property,
3192 so we can allow hibernation when the application goes into the background.
3193 But we still need to detect when the accounts setup windows are open so
3194 we can stop hibernation when they are open.
3195 To do this, I also added the main window the HildonProgram. This might have
3196 other side-effects/benefits, and should maybe be done for other windows.
3198 * src/maemo/modest-osso-autosave-callbacks.h:
3199 * src/maemo/modest-osso-autosave-callbacks.c:
3200 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3201 though it does not do anything yet, and we might never need this to do
3202 anything. For instance, we already save drafts.
3204 * src/maemo/modest-platform.c: (modest_platform_init):
3205 Specify the libosso auto-save callback.
3207 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3209 * src/maemo/modest-platform.c:
3210 (modest_platform_set_update_interval):
3211 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3212 aparently stays valid between application instances, so we can use this
3213 to remove and reset it later. According to a maemo-developers email from
3216 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3218 * configure.ac: Depend on libalarm for Maemo.
3220 * src/dbus_api/modest-dbus-api.h:
3221 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3222 (on_send_receive), (modest_dbus_req_handler):
3223 Handle a SEND_RECEIVE D-Bus method.
3225 * libmodest-dbus-client/libmodest-dbus-client.c:
3226 (libmodest_dbus_client_send_and_receive):
3227 * libmodest-dbus-client/libmodest-dbus-client.h:
3228 Add C convenience functions for calling the new D-Bus method.
3230 * src/modest-platform.h:
3231 * src/gnome/modest-platform.c:
3232 * src/maemo/modest-platform.c:
3233 Added modest_platform_set_update_interval(), which uses the
3234 alarmd API on Maemo.
3235 (modest_platform_init),
3236 Call modest_platform_set_update_interval(), using a hard-coded
3237 interval for now (until the global settings dialog is implemented),
3238 though I am not sure that this makes sense yet.
3240 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3242 * src/dbus_api/modest-dbus-callbacks.c:
3243 (modest_osso_cb_hw_state_handler):
3244 * src/dbus_api/modest-dbus-callbacks.h:
3245 * src/maemo/modest-platform.c: (modest_platform_init):
3246 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3247 in case this has some effect on the ability for Maemo to ping the
3250 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3252 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3253 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3254 warning. It is probably a logic error, but I need to fix the build.
3256 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3258 * src/modest-account-mgr.h:
3259 * src/modest-account-mgr.c:
3260 (modest_account_mgr_account_names): Add a gboolean enabled_only
3261 parameter, so we can get lists of onlt the enabled accounts.
3263 (modest_account_mgr_add_account),,
3264 (modest_account_mgr_account_with_display_name_exists):
3265 * src/maemo/modest-msg-edit-window.c: (get_transports):
3266 * src/modest-account-mgr-helpers.c:
3267 (modest_account_mgr_set_first_account_as_default):
3268 * src/modest-init.c: (init_default_account_maybe):
3269 * src/modest-tny-account-store.c: (get_accounts):
3270 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3271 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3272 * tests/check_account-mgr.c: (START_TEST):
3273 Provide the extra parameter, as appropriate.
3275 * src/widgets/modest-account-view.c: (update_account_view):
3276 Do not show disabled accounts (meaning that there is no way to
3277 enable/disable accounts in the UI (the feature is not in our UI
3278 specification), so we can use this internally only to mark unfinished
3279 or temporary account data.
3281 * src/maemo/easysetup/modest-easysetup-wizard.c:
3282 (create_account): Add boolean enable parameter, so we can specify FALSE
3283 to create the temporary account.
3284 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3285 (on_before_next): When finishing, when there is a temporary account, just
3287 Also, use a timeout to delay the showing of the dialog until gconf is likely
3288 to return correct information, due to a maemo gconf bug that is fixed in
3289 osso 1.1, but not yet in Bora.
3290 However, the dialog stays on screen after it is destroyed.
3292 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3293 for invalid data when cancelling. Use a hildon note instead of a dialog
3294 to complain about invalid data. Do not show the account-saved note if the
3295 account is disabled (a temporary account that will not really be saved for use
3298 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3300 * src/modest-account-mgr-helpers.h:
3301 * src/modest-account-mgr-helpers.c:
3302 Added modest_account_mgr_unset_default_account(),
3303 Added modest_account_mgr_set_first_account_as_default().
3305 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3306 If it was the default account, unset the default account name.
3308 * src/maemo/modest-account-view-window.c:
3309 (on_delete_button_clicked): If it was the default account,
3310 set the first remaining account as the default instead.
3312 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3313 a NULL account or a NULL default account, to prevent a crash. This should
3314 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3317 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3319 * src/widgets/modest-recpt-editor.c:
3320 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3321 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3322 TODO comment for this. This fixes the build.
3324 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3325 be the best place for it. This will in future update all auto-update accounts,
3326 rather than just the current/default account, when that gconf key exists.
3327 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3328 if there are no accounts, before calling do_send_receive().
3329 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3331 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3332 * src/maemo/modest-main-window-ui.h:
3333 * src/maemo/modest-main-window.c: (on_connection_changed),
3334 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3335 directly, becaue the signal handler does more.
3337 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3339 * src/modest-account-mgr-helpers.c:
3340 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3341 for the case that the account does not exist.
3343 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3344 (equivalent to the modest account name) rather than the tinymail account name
3345 (equivalent to the modest account title - human readable) to get the account data.
3346 Check for null account data to prevent the crash, and add a TODO comment saying that
3347 this needs fixing because it is using the server account name instead of the account name.
3349 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3351 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3352 * src/maemo/modest-account-settings-dialog.c: (show_error),
3354 Use hildon_note_new_information() for informative and error messages,
3355 which seems to be expected for Maemo applications (no documentation that I know of
3356 says this). I am surprised that there is no distinction between info and error
3359 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3361 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3362 it is easy to find where this is used.
3364 * src/maemo/easysetup/modest-easysetup-wizard.c:
3365 (create_page_welcome), (create_page_account_details),
3366 (create_page_user_details), (create_page_complete_easysetup),
3367 (create_page_custom_incoming), (create_page_custom_outgoing),
3368 (create_page_complete_custom):
3369 * src/maemo/modest-account-settings-dialog.c:
3370 (create_page_account_details), (create_page_user_details),
3371 (create_page_incoming), (create_page_outgoing):
3372 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3373 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3374 (modest_connection_specific_smtp_edit_window_init):
3375 * src/maemo/modest-connection-specific-smtp-window.c:
3376 (modest_connection_specific_smtp_window_init):
3377 * src/maemo/modest-signature-editor-dialog.c:
3378 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3379 and scrolling policy as per the Email Application Layout Guide, if I have
3382 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3384 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3385 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3386 which were empty, because these vfuncs have been removed from TnyAccountStore.
3387 This fixes the build.
3389 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3391 * src/maemo/modest-main-window.c:
3392 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3393 showing/hiding it. Added TODO because it probably should not be NULL.
3394 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3395 because unnecessary g_warnings() make degugging difficult.
3397 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3399 * src/maemo/modest-msg-edit-window.c:
3400 (modest_msg_edit_window_select_color),
3401 (modest_msg_edit_window_select_background_color): 2 const corrections and
3402 moving 2 #endifs before closing brackets, to fix the build.
3404 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3406 * src/maemo/easysetup/modest-easysetup-wizard.h:
3407 * src/maemo/easysetup/modest-easysetup-wizard.c:
3408 (modest_easysetup_wizard_dialog_finalize),
3409 (on_button_edit_advanced_settings), (create_page_complete_custom),
3410 (on_response), (create_account):
3411 Implement the Advanced Settings edit button, by saving the account information,
3412 for the Advanded Settings dialog to use directly from gconf, and removing it
3413 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3414 Bug #5533 in the projects.maemo.org bugzilla.
3416 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3418 * src/maemo/modest-msg-view-window.c:
3419 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3420 when opening a message window.
3422 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3424 * src/maemo/easysetup/modest-easysetup-wizard.c:
3425 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3428 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3429 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3430 gconf settings. I probably added more checks than necessary, but that is safer.
3432 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3433 variable to fix the build, but this seems to be used when it is still NULL.
3435 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3437 * src/modest-platform.h:
3438 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3439 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3440 * src/modest-main.c: Implement this function so we can avoid using
3441 maemo-specific API from cross-platform code.
3443 * src/modest-tny-account-store.c:
3444 (get_smtp_specific_transport_account_for_open_connection):
3445 * src/modest-ui-actions.c: (check_for_connection),
3446 (modest_ui_actions_on_item_not_found):
3447 Use modest_platform_connect_and_wait() and put #idefs around other
3448 maemo-specific code, because only maemo currently has a way to
3449 identify connection names.
3451 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3453 * src/modest-tny-account-store.h:
3454 * src/modest-tny-account-store.c:
3455 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3456 the connection-specific SMTP server settings in the configuration.
3458 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3460 * src/maemo/modest-main-window.c: (on_connection_changed),
3462 * src/modest-main.c: (main), (start_ui), (send_mail):
3463 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3464 that is what is intended.
3466 * src/modest-ui-actions.c: (action_send), (action_receive),
3467 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3468 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3469 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3470 SMTP server is used when it is specified.
3472 (modest_ui_actions_on_send_receive):
3473 Check that a connection is open before proceeding.
3474 Receive and then send, instead of vice-versa, as per the specification.
3476 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3478 * src/modest-mail-operation.c:
3479 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3480 though I guess it should be something other than NULL.
3482 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3484 * src/maemo/easysetup/modest-easysetup-wizard.c:
3485 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3486 combo twice, to avoid an g_warning and to make it visible again.
3487 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3488 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3489 (already intended) dereference when detaching, because we then recreate the menu.
3490 But I am not sure why the warning was happening, and it is possible that this is a memory
3493 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3495 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3496 and uri_parse_mailto() utility functions.
3497 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3499 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3501 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3503 * src/dbus_api/modest-dbus-api.h:
3504 * src/dbus_api/modest-dbus-callbacks.c:
3505 Use an idle callback to execute the modest code in the application's own thread.
3506 Remove the helloworld example method.
3507 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3508 parsed, and the open-message method is not implemented because this is not yet implemented in
3510 * libmodest-dbus-client/libmodest-dbus-client.c:
3511 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3512 (libmodest_dbus_client_open_message):
3513 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3515 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3516 body without crashing.
3518 * tests/dbus_api/Makefile.am:
3519 * tests/dbus_api/test_mail_to.c:
3520 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3522 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3524 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3525 Added file to fix the build. Sorry.
3527 * src/dbus_api/Makefile.am:
3528 * src/dbus_api/modest-dbus-api.h:
3529 * src/dbus_api/modest-dbus-callbacks.h:
3530 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3531 (modest_dbus_req_handler):
3532 Put constants in a separate header so it can be reused by the
3533 client library, without duplication
3535 * libmodest-dbus-client/Makefile.am:
3536 * libmodest-dbus-client/libmodest-dbus-client.c:
3537 (libmodest_dbus_client_call_helloworld),
3538 (libmodfest_dbus_client_send_mail),
3539 (libmodfest_dbus_client_mailto),
3540 (libmodfest_dbus_client_open_message):
3541 * libmodest-dbus-client/libmodest-dbus-client.h:
3542 (Partly) Implement a send_mail D-Bus method.
3544 * tests/dbus_api/Makefile.am:
3545 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3546 the send_email D-Bus method.
3548 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3552 * libmodest-dbus-client/Makefile.am:
3553 * libmodest-dbus-client/libmodest-dbus-client.c:
3554 * libmodest-dbus-client/libmodest-dbus-client.h:
3555 * tests/dbus_api/Makefile.am:
3556 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3557 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3559 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3561 * src/maemo/easysetup/modest-easysetup-wizard.c:
3562 (create_page_account_details):
3563 * src/maemo/modest-account-settings-dialog.c:
3564 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3565 widgets, because this might not be the default in future versions of the Maemo GTK+.
3566 However, I can not not get capitalization to work even in a simple test case.
3568 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3570 * src/maemo/easysetup/modest-easysetup-wizard.c:
3571 (create_page_custom_incoming), (create_page_custom_outgoing):
3572 * src/maemo/modest-account-settings-dialog.c:
3573 (create_page_account_details), (create_page_incoming),
3574 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3575 instead of using gtk_check_button_with_label(), so they are aligned like the other
3576 widgets, as per the UI spec.
3578 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3580 * src/maemo/easysetup/modest-easysetup-wizard.c:
3581 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3582 * src/widgets/modest-validating-entry.c:
3583 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3584 Modest prefix instead of an EasySetup prefix.
3586 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3588 * src/widgets/modest-validating-entry.h:
3589 * src/widgets/modest-validating-entry.c: (on_insert_text),
3590 Added easysetup_validating_entry_set_max_func(), used to set a callback
3591 to call when the max number of characters is reached. GtkEntry has a max-length
3592 already but is silent about it.
3594 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3595 (create_page_account_details), (create_page_user_details),
3597 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3598 (create_page_account_details), (create_page_user_details),
3599 (create_page_outgoing):
3600 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3601 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3602 the UI spec, when the user tries to enter more than the max number of characters.
3604 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3606 * src/maemo/easysetup/modest-easysetup-wizard.c:
3607 (create_page_user_details), (create_page_custom_incoming),
3608 (create_page_custom_outgoing):
3609 * src/maemo/modest-account-settings-dialog.c:
3610 (create_page_user_details), (create_page_incoming),
3611 (create_page_outgoing):
3612 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3613 (modest_connection_specific_smtp_edit_window_init):
3614 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3615 not appropriate. Bad Maemo-specific defaults!.
3617 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3619 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3620 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3621 (modest_signature_editor_dialog_set_settings):
3622 Disable the label and textview when the checkbox is disabled, and use the
3623 specified (UI spec) default signature text.
3625 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3627 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3628 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3630 * src/modest-defs.h:
3631 * src/modest-account-mgr-helpers.h:
3632 * src/modest-account-mgr-helpers.c:
3633 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3635 * src/maemo/Makefile.am:
3636 * src/maemo/modest-signature-editor-dialog.c:
3637 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3640 * src/maemo/modest-account-settings-dialog.h:
3641 * src/maemo/modest-account-settings-dialog.c:
3642 (modest_account_settings_dialog_finalize), (on_button_signature),
3643 (save_configuration): Use the new dialog when the Edit button is pressed, and
3644 save the changes if necessary, as per the UI spec.
3646 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3648 * src/maemo/Makefile.am:
3649 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3650 based on maemo-develoers email from Dirk.
3652 * src/maemo/easysetup/modest-easysetup-wizard.c:
3653 (create_page_welcome), (create_page_account_details),
3654 (create_page_user_details), (create_page_complete_easysetup),
3655 (create_page_custom_incoming), (create_page_custom_outgoing),
3656 (create_page_complete_custom),
3657 (modest_easysetup_wizard_dialog_init):
3658 * src/maemo/modest-account-settings-dialog.c:
3659 (create_page_account_details), (create_page_user_details),
3660 (create_page_incoming), (create_page_outgoing),
3661 (modest_account_settings_dialog_init):
3662 * src/maemo/modest-connection-specific-smtp-window.c:
3663 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3665 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3667 * src/maemo/easysetup/modest-easysetup-wizard.c:
3668 (create_page_account_details), (create_page_custom_outgoing),
3669 (create_page_complete_custom):
3670 * src/maemo/modest-account-settings-dialog.c:
3671 (create_page_user_details), (create_page_incoming),
3672 (create_page_outgoing):
3673 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3674 (modest_connection_specific_smtp_edit_window_init):
3675 Use the correct (UI spec) port min/max, and use horizontal separators,
3678 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3680 * src/maemo/easysetup/modest-easysetup-wizard.c:
3681 (set_default_custom_servernames):
3682 * src/maemo/modest-account-settings-dialog.c:
3683 (create_page_incoming), (on_combo_outgoing_security_changed),
3684 (on_combo_incoming_security_changed), (create_page_outgoing),
3685 (modest_account_settings_dialog_set_account_name),
3686 (save_configuration):
3687 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3688 (on_combo_security_changed),
3689 (modest_connection_specific_smtp_edit_window_init),
3690 (modest_connection_specific_smtp_edit_window_set_connection),
3691 (modest_connection_specific_smtp_edit_window_get_settings):
3692 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3695 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3698 * src/maemo/easysetup/modest-easysetup-wizard.c:
3699 (create_page_custom_outgoing), (create_page_complete_custom):
3700 * src/maemo/modest-account-settings-dialog.c:
3701 (create_page_user_details), (create_page_outgoing):
3702 * src/maemo/modest-account-view-window.c: (button_box_new):
3703 Use changed logical IDs as per the most recent UI spec:
3704 mcen_bd_emailsetup_edit -> mcen_bd_edit
3705 mcen_bd_emailsetup_delete -> mcen_bd_delete
3706 mcen_bd_emailsetup_close -> mcen_bd_close
3708 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3712 * src/dbus_api/Makefile.am:
3713 * src/dbus_api/modest-dbus-callbacks.c:
3714 * src/dbus_api/modest-dbus-callbacks.h:
3715 * src/maemo/modest-platform.c: (modest_platform_init):
3716 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3718 * tests/Makefile.am:
3719 * tests/dbus_api/Makefile.am:
3720 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3722 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3724 * src/maemo/modest-account-settings-dialog.c:
3725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3726 Removed unnecessary includes.
3728 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3730 * src/maemo/easysetup/modest-easysetup-wizard.c:
3731 * src/maemo/modest-account-settings-dialog.c:
3732 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3733 * src/widgets/Makefile.am:
3734 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3735 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3736 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3737 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3738 * src/widgets/modest-secureauth-combo-box.c:
3739 * src/widgets/modest-secureauth-combo-box.h:
3740 * src/widgets/modest-serversecurity-combo-box.c:
3741 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3742 made the GObject names more consistent with the rest of the Modest code.
3744 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3746 * src/maemo/easysetup/Makefile.am:
3747 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3748 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3749 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3750 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3751 * src/maemo/easysetup/modest-easysetup-wizard.c:
3752 * src/maemo/easysetup/modest-validating-entry.c:
3753 * src/maemo/easysetup/modest-validating-entry.h:
3754 * src/maemo/modest-account-settings-dialog.c:
3755 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3756 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3757 widgets/ because they are used outside of easysetup too. After checking in,
3758 svn will allow me to rename them too.
3760 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3762 * src/gnome/modest-msg-edit-window.c:
3763 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3764 linker error, to fix the build on the GNOME platform.
3765 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3766 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3767 ifdefed out to avoid a warning.
3769 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3771 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3772 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3773 some alternative for GTK+ 2.6.
3775 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3777 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3779 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3780 specified for EmailAccountsDialog in UI spec.
3782 * src/maemo/easysetup/modest-easysetup-wizard.c:
3783 * src/maemo/easysetup/modest-easysetup-wizard.h:
3784 * src/maemo/modest-account-settings-dialog.c:
3785 * src/maemo/modest-account-settings-dialog.h:
3786 Reuse a member window widget for the connection-specific SMTP server accounts,
3787 so we can tell it to create/save the accounts only if we actually save changes.
3789 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3790 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3791 (modest_connection_specific_smtp_edit_window_get_settings):
3792 Return a struct instance for temporarily remembering the entered data.
3794 * src/maemo/modest-connection-specific-smtp-window.h:
3795 * src/maemo/modest-connection-specific-smtp-window.c:
3796 (modest_connection_specific_smtp_window_finalize),
3797 (modest_connection_specific_smtp_window_fill_with_connections),
3799 (modest_connection_specific_smtp_window_save_server_accounts),
3800 (update_model_server_names): Do not actually save data until asked,
3801 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3803 (on_selection_changed),
3804 (modest_connection_specific_smtp_window_init): Disable the edit
3805 button when nothing is selected.
3807 * src/modest-account-mgr-helpers.c:
3808 * src/modest-account-mgr-helpers.h:
3809 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3812 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3814 * src/modest-account-mgr-helpers.h:
3815 * src/modest-account-mgr-helpers.c:
3816 (modest_account_mgr_get_unused_account_name),
3817 (modest_account_mgr_get_unused_account_display_name): Added these
3818 utility functions, to avoid code duplication.
3820 * src/maemo/easysetup/modest-easysetup-wizard.c:
3821 (create_page_account_details), (create_account):
3822 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3823 (on_combo_security_changed),
3824 (modest_connection_specific_smtp_edit_window_init),
3825 (modest_connection_specific_smtp_edit_window_save_settings):
3826 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3827 * src/maemo/modest-connection-specific-smtp-window.c:
3828 (modest_connection_specific_smtp_window_finalize),
3829 (modest_connection_specific_smtp_window_fill_with_connections),
3830 (on_button_edit), (modest_connection_specific_smtp_window_init):
3831 * src/maemo/modest-connection-specific-smtp-window.h:
3832 Implementing saving of connection-specific server accounts.
3834 But I need to refactor this so we can save the data for each
3835 possible connection-specific account and only actually create the server accounts
3836 when the easysetup finished, or the OK button is pressed on the account settings
3839 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3841 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3842 (on_combo_security_changed):
3843 (modest_connection_specific_smtp_edit_window_init):
3844 Auto-fill the port number as in the account settings.
3846 (modest_connection_specific_smtp_edit_window_set_connection):
3847 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3848 * src/maemo/modest-connection-specific-smtp-window.c:
3849 (fill_with_connections), (on_button_edit),
3850 (modest_connection_specific_smtp_window_init):
3851 Turn the edit window into a dialog to simplify the code, and
3852 set a WM hint as in a GtkDialog, because only a popup can be on top of
3853 another window in Maemo, and popups usually have no WM decoration.
3855 * src/modest-defs.h:
3856 * src/modest-account-mgr-helpers.c:
3857 (modest_account_mgr_set_connection_specific_smtp),
3858 (modest_account_mgr_remove_connection_specific_smtp),
3859 (modest_account_mgr_get_connection_specific_smtp):
3860 * src/modest-account-mgr-helpers.h: Some functions to write the
3861 connection-specific SMTP server information. Not yet used.
3864 * src/widgets/modest-folder-view.c: (text_cell_data):
3865 Fix a warning about an uninitialized variable.
3866 (on_configuration_key_changed): Put an #ifdef around the use
3867 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3869 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3871 * src/maemo/modest-account-settings-dialog.h:
3872 * src/maemo/modest-account-settings-dialog.c:
3873 Added connect_for_modified() utility function to mark the new modified boolean.
3875 (create_page_account_details), (create_page_user_details),
3876 (create_page_incoming), (create_page_outgoing), (on_response),
3877 (modest_account_settings_dialog_init),
3878 (modest_account_settings_dialog_set_account_name):
3879 Only warn about unsaved changes when there are actually unsaved changes.
3881 * src/modest-account-mgr-helpers.c:
3882 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3883 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3884 to get the data from there in future.
3886 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3888 * src/modest-defs.h:
3890 * src/modest-account-mgr-helpers.h:
3891 * src/modest-account-mgr-helpers.c:
3892 Store the security account setting in a single conf key instead of using
3893 the options list, so that the list is left for just the to-be-removed camel hack,
3894 and because gconf_client_set_list() is failing for some reason.
3896 * src/modest-account-mgr.c:
3897 (modest_account_mgr_add_server_account):
3898 * src/maemo/modest-account-settings-dialog.c:
3899 (modest_account_settings_dialog_set_account_name),
3900 (save_configuration): Use the renamed functions.
3903 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3905 * src/widgets/Makefile.am:
3906 * src/widgets/modest-limit-retrieve-combo-box.c:
3907 * src/widgets/modest-limit-retrieve-combo-box.h:
3908 * src/widgets/modest-retrieve-combo-box.c:
3909 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3910 the account settings dialog.
3912 * src/modest-defs.h:
3913 * src/modest-account-mgr-helpers.h:
3914 * src/modest-account-mgr-helpers.c:
3915 (modest_server_account_get_option_secure_auth),
3916 (modest_server_account_set_option_secure_auth):
3917 * src/modest-account-mgr.c:
3918 (modest_account_mgr_add_server_account):
3919 Use the existing AUTH_MECH conf key for the secure-auth setting,
3920 instead of putting it in the list options, because this was actually used already.
3922 * src/maemo/modest-account-settings-dialog.c:
3923 (create_page_account_details),
3924 (modest_account_settings_dialog_set_account_name),
3925 (save_configuration):
3926 * src/maemo/modest-account-settings-dialog.h:
3927 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3928 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3930 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3932 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3933 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3934 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3936 * src/modest-defs.h:
3937 * src/maemo/modest-account-settings-dialog.c:
3938 (create_page_incoming), (on_combo_outgoing_security_changed),
3939 (on_combo_incoming_security_changed), (create_page_outgoing),
3940 (modest_account_settings_dialog_set_account_name),
3941 (save_configuration): Load/Save the port number, and change it when the
3942 security combo changes, to suitable defaults.
3944 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3946 * src/modest-account-mgr.c:
3947 (modest_account_mgr_add_server_account): Set the security and secure-auth
3948 options, and add a comment saying that the other camel-specific options should be
3951 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3953 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3955 * src/modest-tny-account-store.c: (account_list_free),
3956 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3957 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3960 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3962 * src/modest-protocol-info.c:
3963 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3964 is required by our UI spec. Maybe something in our implementation will use this eventually.
3965 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3966 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3967 instead of the previous 0 placeholder.
3969 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3970 secure-auth settings.
3971 * src/modest-account-mgr-helpers.h:
3972 * src/modest-account-mgr-helpers.c:
3973 (modest_server_account_data_get_option_secure_auth),
3974 (modest_server_account_set_option_secure_auth),
3975 (modest_server_account_data_get_option_security),
3976 (modest_server_account_set_option_security): Added this API for getting and setting the security
3977 and secure-auth settings.
3979 * src/maemo/modest-account-settings-dialog.h:
3980 * src/maemo/modest-account-settings-dialog.c:
3981 (modest_account_settings_dialog_finalize), (check_data),
3982 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3983 about changing titles.
3984 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3985 (save_configuration): Save the security and secure-auth settings.
3987 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3988 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3990 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3992 * src/modest-defs.h:
3993 * src/modest-account-mgr.c:
3994 (modest_account_mgr_add_server_account):
3995 Added and used defines for the options key and value pair strings,
3996 that are used so far, though they do not seem to correspond to anything in our
3997 UI specs or ModestProtocol enum.
3999 * src/modest-account-mgr-helpers.h:
4000 * src/modest-account-mgr-helpers.c:
4001 (compare_option_strings_for_name),
4002 (modest_server_account_data_get_option_value),
4003 (modest_server_account_data_get_option_bool),
4004 (modest_account_mgr_get_server_account_option):
4005 Added helper functions for parsing the options GSList.
4007 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4009 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4010 display name is based on the supplied account name.
4011 * src/modest-account-mgr.c:
4012 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4013 with an inefficient, but good-enough, implementation.
4015 * src/maemo/easysetup/modest-easysetup-wizard.c:
4016 (create_page_account_details), (on_before_next), (create_account):
4017 Check for existing display names rather than (non-user-visible) account names, and just
4018 create and set a unique account name at the end.
4020 * src/maemo/modest-account-settings-dialog.c:
4021 (modest_account_settings_dialog_init),
4022 (modest_account_settings_dialog_set_account_name),
4023 (create_page_incoming): Show the display name, instead of the account name.
4024 (on_response): Do some (not all) extra checks, as in the UI spec.
4025 (save_configuration): Save the display name if it was changed.
4027 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4029 * po/en_GB.po: Added needed logical ID and translation.
4030 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4031 (init_view): Made the is-default column clicking work.
4033 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4036 * src/maemo/easysetup/Makefile.am:
4037 * src/maemo/easysetup/modest-easysetup-wizard.c:
4038 (modest_easysetup_wizard_dialog_init):
4039 * src/maemo/easysetup/provider-data-test.keyfile:
4040 * src/maemo/easysetup/provider-data.keyfile:
4041 Moved the provider data file to the new modest-providers-data package and used it from there.
4043 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4045 * src/modest-local-folder-info.c:
4046 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4047 N_() was already used on the static strings, but this just marks it for translation without
4048 using the translation.
4050 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4052 * src/maemo/modest-account-settings-dialog.c:
4053 (create_page_incoming),
4054 (modest_account_settings_dialog_set_account_name):
4055 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4056 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4057 I will do this if nobody else gets there first.
4059 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4061 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4062 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4063 save the security stuff.
4065 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4067 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4068 Set the email address and user fullname, which I now see must be
4071 * src/maemo/modest-account-settings-dialog.h:
4072 * src/maemo/modest-account-settings-dialog.c:
4074 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4075 leave-on-server and authentication.
4076 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4079 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4082 * src/maemo/modest-account-settings-dialog.c:
4083 * src/maemo/modest-account-settings-dialog.h:
4084 Most (but not all) of the widgets are now present as specified by the UI spec.
4085 No changes are yet saved, and some details are not properly shown yet.
4087 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4089 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4091 * src/maemo/Makefile.am:
4092 * src/maemo/modest-account-settings-dialog.c:
4093 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4094 an existing account. Doesn't do much yet.
4096 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4097 Open the accounts settings dialog when Edit is clicked.
4099 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4101 * src/maemo/easysetup/Makefile.am:
4102 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4104 * src/maemo/easysetup/modest-easysetup-wizard.c:
4105 (modest_easysetup_wizard_dialog_init):
4106 Try to get the source directory from the build system,
4107 instead of hard-coding "./" into the source code, when opening our local
4108 copies of the configuration files.
4109 But this still fails when opening the wizard from the Accounts window,
4110 maybe because the working directory seems to change at runtime.
4111 So the wizard will fail the second time unless you copy the files into their
4112 proper locations - see the stdout warnings for the paths.
4114 (create_page_account_details),(on_before_next):
4115 Check for existing non-server accounts instead of server accounts,
4116 so the default account name is useful again, and to prevent trying to
4119 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4120 Show the wizard when New is clicked.
4122 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4123 (init_view): Show the column headers, and show the columns that are
4124 specified in the UI specs. However, something in Maemo's GTK+ prevents
4125 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4126 change the default account. This is despite unsetting the special properties.
4128 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4130 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4131 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4132 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4133 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4134 to make that clearer.
4135 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4137 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4139 * src/maemo/modest-account-view-window.c:
4140 (modest_account_view_window_init),
4141 (modest_account_view_window_new):
4142 Use the same buttons as specified in the
4143 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4144 the existing widgets, which never had a chance of working.
4145 Put the ModestAccountView treeview in a scrolled window.
4146 Do not repeat the initialization in both _init() and _new().
4148 * src/widgets/modest-account-view.c: (update_account_view):
4149 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4150 this widget and window shows no accounts.
4152 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4154 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4156 * src/maemo/easysetup/modest-easysetup-wizard.c:
4157 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4158 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4159 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4162 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4163 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4164 accounts exist yet, as in the UI spec.
4166 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4168 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4170 * src/maemo/Makefile.am:
4171 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4172 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4173 New window for editing connection-specific smtp details.
4174 Not fully implemented.
4176 * src/maemo/modest-connection-specific-smtp-window.c:
4177 (modest_connection_specific_smtp_window_finalize) :
4178 unref the tree model.
4179 (on_button_edit): Show the edit window.
4181 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4183 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4186 * src/maemo/Makefile.am:
4187 * src/maemo/modest-connection-specific-smtp-window.c:
4188 * src/maemo/modest-connection-specific-smtp-window.h:
4189 New window for showing the list of connections, for connection-specific
4190 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4191 * src/maemo/easysetup/modest-easysetup-wizard.c:
4192 (create_page_custom_outgoing): Show the new window when the button is clicked.
4194 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4196 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4197 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4198 * src/maemo/modest-msg-edit-window.c:
4199 (modest_msg_edit_window_insert_image):
4200 * src/modest-conf.c: (modest_conf_key_escape):
4201 * src/modest-mail-operation.c:
4202 (modest_mail_operation_send_new_mail):
4203 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4204 (modest_ui_actions_on_new_account):
4205 * src/widgets/modest-attachment-view.c: (update_filename_request):
4206 * src/widgets/modest-mail-header-view.c:
4207 Corrected warnings that were breaking the build, by commenting out unused variables,
4208 and a function, and by including a header.
4210 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4212 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4213 so we can #ifdef around platform-specific code when necessary.
4214 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4215 to allow this to build for the GNOME platform too.
4217 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4219 * src/maemo/easysetup/modest-easysetup-wizard.c:
4220 Added util_increment_name() and used it in create_page_account_details()
4221 to make sure that the default account name is always a new name.
4223 (modest_easysetup_wizard_dialog_init),
4224 (set_default_custom_servernames): Some minor memory management fixes.
4226 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4230 * src/modest-runtime.c: (init_i18n): Restored the translation
4231 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4232 are defined in config.h, and the translations are installed.
4234 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4235 is defined for translation.
4237 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4239 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4241 * src/maemo/easysetup/modest-easysetup-wizard.c:
4242 (modest_easysetup_wizard_dialog_init):
4243 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4244 Use realistic paths (though they should use $prefix generically) to the
4245 mcc_mapping and provider-data.keyfile files which might work when they
4246 are installed by the future version of the operator-wizard package,
4247 and then fallback to paths in our source code, with an explanatory
4250 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4254 * src/maemo/Makefile.am:
4255 * src/maemo/easysetup/: Added files from the previously-exernal
4256 osso-modest-easysetup.
4257 * src/maemo/modest-main-window-ui.h:
4258 * src/modest-ui-actions.c:
4259 * src/modest-ui-actions.h:
4260 Added modest_ui_actions_on_new_account() as a signal handler for the
4261 New Account menu item. It shows the easysetup wizard.
4262 * po/en_GB.po: Added additional needed logical IDs and translations.