1 2007-07-05 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.c: (on_connection_status_changed):
4 Really do not use tny_device_force_offline() here. See the previous comment.
6 2007-07-04 Murray Cumming <murrayc@murrayc.com>
8 * src/modest-tny-account.c: (on_connection_status_changed):
9 Do not use tny_device_force_offline() when tinymail says that something
10 went wrong with the connection. It seems to report this unnecessarily.
12 2007-07-04 Murray Cumming <murrayc@murrayc.com>
14 * src/maemo/modest-connection-specific-smtp-window.c:
15 (modest_connection_specific_smtp_window_init):
16 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
17 does not seem to have any effect in osso 1.1 (though it works in
18 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
20 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
22 * src/maemo/modest-connection-specific-smtp-window.c:
23 Fix UI specification problems with projects.meamo.org NB#60479
25 2007-07-04 Murray Cumming <murrayc@murrayc.com>
27 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
28 clue when this has failed, because the error dialog is not always shown
29 (at least in earlier version).
31 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
32 GError message, because the generic error dialog is not helpful.
34 'This message is not currently available (can't let a new connection go online)'
35 when trying to open an IMAP message.
37 (_modest_ui_actions_open): Offer a connection when some messages would
38 have to be downloaded and we are offline.
40 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
42 * src/widgets/modest-folder-view.c:
43 Don't check for MERGE type anymore as we use the correct type
45 NOTE: For the last two changes you need to update your tinymail copy
46 because of API changes!
48 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
50 * src/modest-tny-local-folders-account.c:
51 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
52 (see projects.maemo.org NB#61580)
54 2007-07-04 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-tny-account.c: (on_connection_status_changed):
57 Commented out the call to modest_platform_connect_and_wait() because this
58 seems to always hang, and I would like to know if this is the only thing
59 that causes a hang when showing the connection dialog.
60 It is not very useful anyway.
62 2007-07-04 Murray Cumming <murrayc@murrayc.com>
64 * src/maemo/modest-msg-view-window.c:
65 (modest_msg_view_window_select_next_message):
67 * src/modest-platform.h:
68 * src/maemo/modest-platform.c:
69 Added modest_platform_connect_and_wait(), which calls
70 tny_maemo_conic_device_connect() always in the main thread, by calling it
71 in an idle handler and waiting for the idle handler to run. It should be
72 in the main thread because it uses GTK+ UI code. It just returns TRUE
73 if the device is already online.
75 There is some nasty code to ensure that subsequent calls to
76 modest_platform_connect_and_wait() just wait for the first one to finish,
77 by checking repeatedly in another idle handler. This is necessary,
78 because other threads (or even the main thread, via another idle handler)
79 can call modest_platform_connect_and_wait() while
80 modest_platform_connect_and_wait() is running.
82 (modest_platform_connect_and_wait_if_network_account),
83 (modest_platform_connect_and_wait_if_network_folderstore):
84 Convenience functions that calls modest_platform_connect_and_wait() if
85 the account or folder might want network access.
87 * src/modest-mail-operation.c:
88 (modest_mail_operation_update_account):
89 * src/modest-ui-actions.c: (download_uncached_messages),
90 (modest_ui_actions_on_rename_folder), (delete_folder),
91 (modest_ui_actions_on_main_window_move_to),
92 (modest_ui_actions_on_msg_view_window_move_to):
93 * src/widgets/modest-folder-view.c:
94 (drag_and_drop_from_folder_view):
95 Offer a connection if we are offline.
97 * src/modest-tny-account.c: (on_connection_status_changed):
98 Document this as only handling errors during network operations in progress,
99 and replace the idle code with a simple call to
100 modest_platform_connect_and_wait(), which does this instead.
102 2007-07-03 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-tny-account.c:
105 (modest_tny_account_get_special_folder): (util_on_idle),
106 Handle the GError so we can see when tny_folder_store_get_folders()
107 fails, as it currently does while something else is connecting.
109 Added util_run_in_main_thread_and_wait()
110 which uses an idlen handler and mainloop to ensure that the function
111 is called in the main thread.
112 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
113 to make sure that we call attempt the connection in the mainloop only,
114 which might solve some hangs.
116 2007-07-03 Murray Cumming <murrayc@murrayc.com>
118 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
119 be found by their display name. This is never useful.
120 * src/modest-tny-account-store.c: (on_account_removed): Find the account
121 by its ID, instead of trying to use its ID as its display name.
123 * src/modest-tny-account-store.h:
124 * src/modest-tny-account.c:
125 (modest_tny_account_get_special_folder): Add a g_warning() when
126 tny_folder_store_get_folders() returns an empty list for the maildir.
128 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
129 Add a g_warning() when this returns NULL, because that it not allowed
132 2007-07-02 Armin Burgmeier <armin@openismus.com>
134 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
135 note when trying to cancel the wizard. This fixes projects.maemo.org
138 2007-07-02 Murray Cumming <murrayc@murrayc.com>
140 * src/modest-tny-account.h:
141 * src/modest-tny-account.c:
142 (modest_tny_account_new_from_server_account),
143 (modest_tny_account_new_from_server_account_name),
144 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
145 because this must now be set before setting the proto. This is usd in
146 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
147 warning in camel_session_get_service() caused by
148 tny_camel_transport_account_prepare().
150 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
153 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
155 * src/maemo/modest-connection-specific-smtp-edit-window.c:
157 (modest_connection_specific_smtp_edit_window_init):
159 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
162 2007-06-29 Murray Cumming <murrayc@murrayc.com>
164 * src/modest-tny-account.c:
165 (modest_tny_account_new_from_server_account):
166 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
167 now uses to request a connection when it needs one, and which it uses
168 to tell us that something is wrong with the connection, so we can force
169 the accounts offline to prevent further problems.
172 * src/modest-init.c: (init_default_settings):
173 * src/modest-mail-operation.c:
174 (modest_mail_operation_update_account):
175 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
176 This should not be necessary anymore. Do not set the conf key that
177 determined this (it was always TRUE and not set anywhere else).
179 * src/modest-ui-actions.h: Remove unused and unimplemented
180 modest_ui_actions_on_online_toggle_toggled().
182 2007-06-29 Murray Cumming <murrayc@murrayc.com
184 * src/maemo/modest-main-window.c: (connect_signals):
185 Don't connect to delete_event twice. Maybe this was harmless.
187 2007-06-29 Murray Cumming <murrayc@murrayc.com
189 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
190 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
191 Debug output to give some more clue when a folder move is not allowed.
193 2007-06-28 Murray Cumming <murrayc@murrayc.com
195 * src/modest-tny-account.c: (on_modest_file_system_info),
196 (modest_tny_account_get_mmc_account_name):
197 Always call the callback, without checking whether the name has changed.
198 * src/widgets/modest-folder-view.c: (strings_are_equal),
199 (on_model_foreach_set_name), (on_get_mmc_account_name),
200 (text_cell_data): Compare the name here, and use the name from
201 the account rather than from the
202 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
203 if the name was changed after the account was added to the model.
204 That's a tinymail bug but not one that I want to fix now.
206 This finally fixes projects.maemo.org bug NB#59301.
208 2007-06-27 Armin Burgmeier <armin@openismus.com>
210 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
213 2007-06-27 Murray Cumming <murrayc@murrayc.com
215 * src/modest-tny-account.h:
216 * src/modest-tny-account.c:
217 Added modest_tny_account_get_mmc_account_name(), to set the memory
218 card name asynchronously for the given account and then notify.
219 (modest_tny_account_new_for_local_folders): Use this new function instead
220 of using hildon_file_system_info_async_new() directly.
222 * src/widgets/modest-folder-view.c: (text_cell_data):
223 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
224 gtk_tree_model_row_changed() when it is available.
226 This should fix projects.maemo.org bug NB#59301.
228 2007-06-27 Murray Cumming <murrayc@murrayc.com
230 * src/modest-mail-operation.c: (update_account_thread),
231 (get_msgs_full_thread): Fix typo failures in the revert
234 2007-06-27 Murray Cumming <murrayc@murrayc.com
236 * src/maemo/modest-maemo-global-settings-dialog.c:
237 (idle_select_default_focus):
238 * src/modest-mail-operation.c: (idle_notify_progress),
239 (idle_notify_progress_once), (set_last_updated_idle),
240 (update_account_thread), (get_msgs_full_thread):
241 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
242 * src/widgets/modest-header-view.c:
243 (idle_notify_headers_count_changed_destroy),
244 (idle_notify_headers_count_changed):
245 Reverted the additions of gdk_threads_enter/leave(), in case this
246 helps with a startup hang on the device.
248 2007-06-26 Armin Burgmeier <armin@openismus.com>
250 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
251 for supported secure authentication methods from server by
252 gtk_dialog_run(), saving CPU time and a potential race condition.
254 2007-06-26 Armin Burgmeier <armin@openismus.com>
256 * src/maemo/modest-maemo-utils.h:
257 * src/maemo/modest-maemo-utils.c: Added a
258 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
259 only error code to tell the calling code when the user canceled the
262 * src/maemo/modest-account-settings-dialog.h:
263 * src/maemo/modest-account-settings-dialog.c:
264 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
265 message if the retrieval of secure authentication methods was canceled
266 by the user. Perform the check before saving anything to configuration
267 to not end up with half-committed configuration changes, do not show
268 a "Saving to configuration failed" note when authentication methods
269 could not be retrieved.
271 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
274 2007-06-26 Murray Cumming <murrayc@murrayc.com>
276 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
277 Only return the first level of folders under accounts, because the
278 osso-global-search UI spec doesn't want the rest.
279 This fixed projects.maemo.org bug NB#61811.
281 2007-06-26 Murray Cumming <murrayc@murrayc.com>
283 * src/modest-tny-account-store.c:
284 * src/modest-tny-account-store.h:
285 Added modest_tny_account_is_memory_card_account().
286 * src/maemo/modest-main-window.c: (create_details_widget):
287 Show the same information items for the memory card as we show for the
288 local-folders, to fix projects.maemo.org bug NB#59307.
290 2007-06-26 Murray Cumming <murrayc@murrayc.com>
292 * src/modest-tny-account-store.c: (get_password):
293 Added some checks for NULL to maybe prevent crashes, though I think
294 it was Philip's last commit that actually prevented the crash here
295 when creating a first new account.
296 But the new account is still not usable (no messages are shown)
297 until a restart of the application.
299 2007-06-26 Murray Cumming <murrayc@murrayc.com>
301 * src/maemo/modest-maemo-global-settings-dialog.c:
302 (idle_select_default_focus):
303 * src/modest-mail-operation.c: (idle_notify_progress),
304 (idle_notify_progress_once), (idle_notify_update_account_queue),
305 (set_last_updated_idle), (update_account_thread),
306 (notify_get_msgs_full), (get_msgs_full_destroyer),
307 (get_msgs_full_thread):
308 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
309 * src/widgets/modest-header-view.c:
310 (idle_notify_headers_count_changed_destroy),
311 (idle_notify_headers_count_changed):
312 Use gdk_threads_enter() and gdk_threads_enter_leave() in
313 all idle handlers, because some other thread could be blocking
314 the GDK lock, so that it can do GUI stuff.
316 2007-06-26 Murray Cumming <murrayc@murrayc.com>
318 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
319 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
320 (on_idle_send_receive), (on_idle_open_default_inbox):
321 * src/maemo/modest-msg-edit-window.c:
322 (modest_msg_edit_window_attach_file_noninteractive):
323 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
324 to prevent a hang. I don't quite understand why these are necessary,
325 beause we should already be in the main loop. I guess something outside
326 of the main loop is taking the lock.
328 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
329 we are really using URIs, and use files that are more likely to exist.
331 2007-06-26 Murray Cumming <murrayc@murrayc.com>
333 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
334 necessary because configure.ac now defines different variables.
336 2007-06-26 Murray Cumming <murrayc@murrayc.com>
338 * libmodest-dbus-client/libmodest-dbus-client.c:
339 * libmodest-dbus-client/libmodest-dbus-client.h:
340 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
341 libmodest_dbus_client_compose_mail() is what things actually use.
343 * src/dbus_api/modest-dbus-api.h:
344 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
345 * tests/dbus_api/Makefile.am:
346 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
349 2007-06-26 Murray Cumming <murrayc@murrayc.com>
351 * src/modest-init.c: (modest_init_local_folders):
352 For memory-card (or other non local-folders) maildir accounts,
353 always create an Archive folder, so that there is somewhere to put
354 messages. This should be less confusing, because the user does not need
355 to guess that the need to create a folder.
357 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
359 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
360 Fixed icon size by using (50, 50) which is the same as defined by
363 2007-06-25 Armin Burgmeier <armin@openismus.com>
365 * src/widgets/modest-window-mgr.c:
367 * configure.ac: Correctly recognize hildon-notify presence and fixed
368 the build without it being installed.
370 2007-06-25 Murray Cumming <murrayc@murrayc.com>
372 * libmodest-dbus-client/libmodest-dbus-client.c:
373 (libmodest_dbus_client_search): Fix the build. Sorry.
374 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
375 (reply_forward_cb): Initialize variables to fix the build.
377 * src/modest-tny-account-store.c:
378 (modest_tny_account_store_get_tny_account_by): Fix the account URI
379 comparison (a silly typo) so that email search results can be opened
380 when there are more than one account.
382 2007-06-25 Murray Cumming <murrayc@murrayc.com>
384 * libmodest-dbus-client/libmodest-dbus-client.c:
385 (libmodest_dbus_client_search),
386 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
387 instead of 1 second, because the search gets folders and messages from
388 the server, which can take a long time. When it times out,
389 osso-global-search will report no results.
391 We need to specify whether we should search only cached information
392 (maybe with a user preference), and the osso-email-search-plugin
393 API should really be improved to allow that option, and to allow results
394 to be delivered asynchronously in batches.
396 2007-06-25 Murray Cumming <murrayc@murrayc.com>
398 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
399 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
400 GTK_ICON_SIZE_DIALOG is probably the wrong size.
402 2007-06-25 Murray Cumming <murrayc@murrayc.com>
404 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
405 that is an empty string. D-Bus seems to give us these instead of NULL.
407 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
409 * src/dbus_api/modest-dbus-callbacks.c:
410 * src/maemo/easysetup/modest-easysetup-wizard.h:
411 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
412 * src/maemo/modest-connection-specific-smtp-edit-window.c:
413 (modest_connection_specific_smtp_edit_window_init):
414 * src/maemo/modest-maemo-global-settings-dialog.c:
416 * src/maemo/modest-maemo-utils.c:
417 (modest_maemo_utils_setup_images_filechooser):
418 * src/maemo/modest-main-window.c: (create_details_widget):
419 * src/maemo/modest-msg-edit-window.c:
420 (modest_msg_edit_window_attach_file_noninteractive),
421 (modest_msg_edit_window_color_button_change),
422 (modest_msg_edit_window_set_zoom):
423 * src/modest-mail-operation.c: (update_account_thread):
424 * src/modest-tny-account-store.c:
425 * src/modest-tny-account.c:
426 * src/widgets/modest-global-settings-dialog.c:
427 * src/widgets/modest-window.h:
431 2007-06-25 Murray Cumming <murrayc@murrayc.com>
433 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
434 * src/modest-search.c: (modest_search_folder),
435 (modest_search_all_accounts): Actually search only in the specified folder,
436 doing a simple match on the folder ID.
437 * src/modest-search.h: Added a folder field to the ModestSearch struct,
438 and added some documentation.
440 2007-06-22 Armin Burgmeier <armin@openismus.com>
442 * src/maemo/modest-maemo-utils.h:
443 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
444 modest_maemo_utils_get_supported_secure_authentication_methods.
446 * src/maemo/easysetup/modest-easysetup-wizard.c:
447 * src/maemo/modest-account-settings-dialog.c: Show correct error if
448 one occured, not just "Server does not support secure authentication".
450 2007-06-22 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-tny-account-store.c: (get_password):
453 Restored the call to tny_account_set_user() because Philip seems to have
454 stopped this from crashing (by not using the freed string). It still does
455 not work, but now we can test it.
457 2007-06-22 Murray Cumming <murrayc@murrayc.com>
459 * src/maemo/modest-msg-edit-window.c: (init_window):
460 Comment out use of an uninitialzed GtkScrolledWindow variable,
461 to fix the build and stop a crash. Yet again.
463 2007-06-22 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-tny-account-store.c: (get_password):
466 Remove the call to tny_account_set_user() because this actually crashes.
467 As mentioned in the last commit, it is known to not work anyway.
469 2007-06-22 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-tny-account-store.c: (get_password):
472 Use tny_account_set_username() to tell tinymail that the username might
473 have changed too. But tinymail ignores this: see projects.maemo.org
475 * src/modest-ui-actions.c:
476 (modest_ui_actions_on_password_requested): Remove the useless attempt to
477 reset the connection when changing the username, and improve the comments.
478 Save the changed username to gconf at least, so it is used when Modest is
481 2007-06-21 Murray Cumming <murrayc@murrayc.com>
483 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
484 Do not use a query, so that we get all folders, including for POP and
485 local-folders. They work as search criteria too.
486 This fixes projects.maemo.org bug NB#57740.
488 2007-06-21 Murray Cumming <murrayc@murrayc.com>
490 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
491 Comment out the use of hildon_notification_set_sound() because it is
492 not declared, to fix the build. Warnings are serious, people.
494 2007-06-21 Armin Burgmeier <armin@openismus.com>
496 * src/maemo/modest-maemo-utils.h:
497 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
498 modest_maemo_utils_get_supported_secure_authentication_methods()
499 to query authentication methods for a specific user. This should fix
500 projects.maemo.org bug NB#61369.
502 * src/maemo/easysetup/modest-easysetup-wizard.c:
503 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
506 2007-06-21 Murray Cumming <murrayc@murrayc.com>
508 * libmodest-dbus-client/libmodest-dbus-client.h:
509 * libmodest-dbus-client/libmodest-dbus-client.c:
510 (modest_dbus_message_iter_get_search_hit),
511 (libmodest_dbus_client_search):
512 Reorganised and commented this.
513 Removed modest_search_hit_free() from the public API because it
516 Added libmodest_dbus_client_get_folders() and
517 modest_folder_result_list_free().
519 * src/dbus_api/modest-dbus-api.h:
520 * src/dbus_api/modest-dbus-callbacks.c:
521 (modest_dbus_req_filter): Commented. Moved most code to
522 on_dbus_method_search() and added on_dbus_method_get_folders().
524 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
525 of the extra D-Bus handler.
527 * tests/dbus_api/Makefile.am:
528 * tests/dbus_api/test_get_folders.c: New test for
529 libmodest_dbus_client_get_folders(). This seems to return an empty list
530 at the moment. That could be the same error that causes the message list
531 to be empty sometimes.
532 This should help with projects.maemo.org bug NB#57740.
534 2007-06-21 Armin Burgmeier <armin@openismus.com>
536 * src/modest-mail-operation.c: Do not call
537 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
538 notify the operation's end after having set the status to CANCELED for
539 the operation queue to listen on. This fixes a deadlock when there
540 were mail operations in the queue during its finalization.
542 * src/modest-singletons.c: Reordered uninitialization of the account
543 manager to happen after the mail operation queue was uninitialized
544 because the mail operation's in the queue might still try to access
545 the account manager (see modest_mail_operation_notify_end()). This
546 fixes a potential crash when terminating the application.
548 2007-06-21 Murray Cumming <murrayc@murrayc.com>
550 * src/modest-search.c:
551 (search_mime_part_and_child_parts): Moved some code here so we
552 can search recursively in child folders.
553 (modest_search_folder): Search in the message as a mime part, instead
554 of just its child mime parts.
555 (read_chunk), (search_mime_part_ogs):
556 Check how many bytes were read, to prevent an endless loop.
557 Searching in message bodies now works. This finishes the fix for
558 projects.maemo.org bug NB#61007.
560 2007-06-20 Murray Cumming <murrayc@murrayc.com>
562 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
563 Add a g_warning when the item is not a folder.
565 * src/modest-ui-dimming-rules.c:
566 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
567 when selected item is not a folder (for instance, an account), because
568 the UI spec only talks about folders.
569 I am not sure what the UI spec wants, so this might not totally fix
570 projects.maemo.org bug NB#60794.
572 2007-06-20 Murray Cumming <murrayc@murrayc.com>
574 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
575 (load_from_file): Sort the list. The unsorted list would be more noticeable
576 in non-English locales.
578 * src/maemo/modest-msg-edit-window.c:
579 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
580 warning and fix the build.
582 * src/maemo/modest-progress-bar-widget.c:
583 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
584 avoid a g_warning, and probably to avoid a crash.
586 2007-06-20 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-search.c: (modest_search_folder): Check for a GError
589 when calling tny_folder_get_headers(), to show that this is not the cause
592 2007-06-20 Murray Cumming <murrayc@murrayc.com>
594 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
595 Actually set the body query instead of the subject query.
597 * src/modest-search.c: (search_mime_part_ogs),
598 (search_mime_part_strcmp): Remove extra space from the text/* regex,
599 which would probably cause it to fail if we got this far.
601 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
602 to simplify the code.
603 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
604 be causing search-in-body to fail.
606 2007-06-20 Murray Cumming <murrayc@murrayc.com>
608 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
610 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
611 Better debug message when the folder cannot be found.
612 This should help with fixing projects.maemo.org bug #61287.
613 * src/modest-search.c: (add_hit): Do not leak the furl string.
615 2007-06-20 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-ui-actions.c:
618 (modest_ui_actions_on_folder_selection_changed):
619 Do not special-case TNY_MERGE_FOLDER here, because
620 modest_tny_folder_get_account() already does that. This fixes
621 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
622 shown when the Outbox was selected).
624 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
626 * libmodest-dbus-client/libmodest-dbus-client.c:
627 (_dbus_iter_get_string_or_null): Initialize the string variable in
628 case this helps with Dirk's crash.
630 2007-06-19 Murray Cumming <murrayc@murrayc.com>
632 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
633 though it is not implemented yet (this function is maybe not even used),
634 to avoid breaking ABI in future.
635 * libmodest-dbus-client/libmodest-dbus-client.c:
636 (get_attachments_string): Moved some code into this generic function.
637 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
638 sends email. It is maybe not used.
639 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
640 (on_send_mail): Use attachments.
642 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
643 * src/maemo/modest-msg-edit-window.c:
644 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
645 a filename before using it, to fix projects.maemo.org bug NB#58233.
647 2007-06-19 Murray Cumming <murrayc@murrayc.com>
649 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
650 Initialize the continue_download variable to fix the build, and probably
651 to fix randome behaviour.
653 2007-06-18 Armin Burgmeier <armin@openismus.com>
655 * src/modest-tny-send-queue.h:
656 * src/modest-tny-send-queue.c: Keep track of the status of messages in
657 the queue so we can later show it in the UI. Replaced
658 modest_tny_send_queue_msg_is_being_sent() by
659 modest_tny_send_queue_get_msg_status().
661 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
663 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
664 gpointer. This probably was not harmful, but just to be sure.
666 2007-06-18 Murray Cumming <murrayc@murrayc.com>
668 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
669 Fix the build, but leave the function broken on Bora, because
670 hildon_uri_action_get_service() does not exist.
671 osso_uri_action_get_service() does not exist either, it seems.
673 2007-06-18 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-tny-account.c:
676 (modest_tny_account_new_from_server_account):
677 Uncommented the url debug output again, because it is useful for
678 debugging, as I said in the comment.
680 2007-06-18 Murray Cumming <murrayc@murrayc.com>
682 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
684 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
685 for Mameo Bora, to fix the build.
687 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
690 Fixed build with hildon < 0.99
692 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
693 Check if the selected account is busy instead of checking all accounts
695 * src/modest-account-mgr-priv.h:
696 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
697 (modest_account_mgr_init), (compare_account_name),
698 (modest_account_mgr_set_account_busy),
699 (modest_account_mgr_account_is_busy):
700 * src/modest-account-mgr.h:
701 Added busy information to the account manager. It possible to
702 set an account to busy or not busy now.
704 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
705 (modest_mail_operation_update_account),
706 (modest_mail_operation_notify_end):
707 Set the account to busy/not busy depending on the operation state.
709 * src/widgets/modest-account-view.c:
710 (modest_account_view_finalize), (get_last_updated_string),
711 (update_account_view), (on_account_busy_changed), (init_view):
712 Show string "Refreshing..." if the account is currently busy.
714 All this fixes projects.maemo.org bug NB#59711
716 2007-06-14 Armin Burgmeier <armin@openismus.com>
718 * src/widgets/modest-attachments-view.h:
719 * src/widgets/modest-attachments-view.c: Added
720 modest_attachments_view_has_attachments() and fixed coordinate
721 transformation in get_att_view_at_coords(). This fixes attachment
724 * src/widgets/modest-msg-view.c: Make use of
725 modest_attachments_view_has_attachments() to decide whether to show
726 attachments in the header.
728 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
730 * src/maemo/modest-connection-specific-smtp-edit-window.c:
731 (on_change), (on_combo_security_changed),
732 (modest_connection_specific_smtp_edit_window_init),
733 (modest_connection_specific_smtp_edit_window_set_connection),
734 (modest_connection_specific_smtp_edit_window_is_dirty):
735 * src/maemo/modest-connection-specific-smtp-edit-window.h:
736 * src/maemo/modest-connection-specific-smtp-window.c:
739 Show an comfirmation dialog for the smpt-edit-window if there are
740 unsaved changes and the user hits cancel.
741 (projects.maemo.org bug NB#60479)
743 2007-06-14 Armin Burgmeier <armin@openismus.com>
745 * src/maemo/easysetup/modest-easysetup-wizard.c:
746 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
747 address" info in banner instead of node, and select all the text as
748 per UI spec. This fixes projects.maemo.org bug NB#60550.
750 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
752 reviewed by: <delete if not using a buddy>
754 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
755 * src/modest-ui-actions.c: (folder_refreshed_cb):
757 2007-06-14 Murray Cumming <murrayc@murrayc.com>
759 * src/widgets/modest-folder-view.c: (filter_row):
760 Explictly filter out the per-account outbox accounts. I don't know why
761 these only sometimes show up, but now they should never show up in the UI.
762 This should fix projects.maemo.org bug NB#60160.
764 2007-06-14 Murray Cumming <murrayc@murrayc.com>
766 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
767 when the toolbar does not exist yet.
768 * src/modest-widget-memory.c: (save_settings_header_view):
769 Added g_warnings() to help us to discover when we are trying to set
770 an empty columns list in gconf.
772 2007-06-14 Murray Cumming <murrayc@murrayc.com>
776 Added modest_init_get_default_header_view_column_ids().
778 * src/modest-widget-memory.c: (restore_settings_header_view):
779 Use the new function to get defaults, if the gconf key is empty,
780 instead of not creating any columns. This seems to fix the
781 empty right-hand pane problems.
783 * src/widgets/modest-header-view.h: Improved documentation.
785 2007-06-13 Murray Cumming <murrayc@murrayc.com>
787 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
788 Revert the use of the display name as the account name, because this
789 is generally wrong and would break the code that follows.
791 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
793 * src/maemo/easysetup/modest-easysetup-wizard.c:
794 (check_for_supported_auth_methods), (on_before_next),
797 More correct fix for projects.maemo.org bug NB# 58991
798 Do not longer accept AUTH_PASSWORD as secure method and choose
799 correct method when creating the account.
801 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
803 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
804 Fixed projects.maemo.org bug NB# 58991
806 2007-06-13 Murray Cumming <murrayc@murrayc.com>
808 * src/modest-init.c: (modest_init_init_core),
809 (modest_init_local_folders): Fixed compilation errors.
811 2007-06-13 Murray Cumming <murrayc@murrayc.com>
813 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
814 Remove unnecessary lib/include, though it is good in principle when needed.
816 * src/modest-init.c: (modest_init_one_local_folder),
817 (modest_init_local_folders):
818 * src/modest-init.h: Initialize the .modest library for memory cards,
819 instead of just doing nothing for them. This should allow us to create
820 folders there, fixing projects.maemo.org bug NB#59297.
822 2007-06-13 Murray Cumming <murrayc@murrayc.com>
824 * libmodest-dbus-client/libmodest-dbus-client.c:
825 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
826 (libmodest_dbus_client_compose_mail),
827 (libmodest_dbus_client_open_message),
828 (libmodest_dbus_client_send_and_receive),
829 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
831 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
832 (on_idle_open_message), (modest_dbus_req_handler),
833 (search_result_to_message), (modest_dbus_req_filter):
834 * src/modest-search.c: (add_hit), (modest_search_folder),
835 (modest_search_all_accounts): Improved debug messages.
837 * tests/dbus_api/test_open_message.c: (main): Improved comments.
839 * src/modest-tny-account-store.c:
840 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
843 2007-06-13 Murray Cumming <murrayc@murrayc.com>
846 2007-06-12 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-tny-account-store.c: (get_server_accounts):
849 Call modest_tny_local_folders_account_add_merged_outbox_folders()
850 even when there are no accounts, so that the Outbox folder is always
851 visible. This fixes projects.maemo.org bug NB#60158.
853 2007-06-12 Murray Cumming <murrayc@murrayc.com>
855 * src/maemo/modest-main-window.c: (create_details_widget):
856 Use the mcen_va_never logical ID.
858 2007-06-12 Murray Cumming <murrayc@murrayc.com>
860 * src/dbus_api/modest-dbus-api.h:
861 * src/dbus_api/modest-dbus-callbacks.c:
862 (on_idle_open_default_inbox), (on_open_default_inbox),
863 (modest_dbus_req_handler):
864 Added a new OpenDefaultInbox method.
866 * libmodest-dbus-client/libmodest-dbus-client.h:
867 * libmodest-dbus-client/libmodest-dbus-client.c:
868 Added libmodest_dbus_client_open_default_inbox() to call the new
869 dbus method. This should be useful to projects.maemo.org bug NB#57214,
870 though it should maybe be used by a new osso-email-interface function.
872 * tests/dbus_api/Makefile.am:
873 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
876 2007-06-12 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
879 NULL, so that the signals get all the keys. This should not actually
880 change any behaviour because we currently update everything when anything
883 2007-06-12 Murray Cumming <murrayc@murrayc.com>
885 * src/widgets/modest-folder-view.c: (text_cell_data),
886 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
887 (find_inbox_iter): If tinymail tells us that the folder is
888 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
889 This causes the inbox to be selected at startup, fixing part of
890 projects.maemo.org bug NB#56305.
892 * src/modest-ui-dimming-rules.c:
893 (modest_ui_dimming_rules_on_tools_smtp_servers):
894 * src/modest-ui-dimming-rules.h: Added a callback function to dim
895 the SMTP servers menu item.
896 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
897 that the SMTP Servers menu item is dimmed when there are no accounts,
898 as a future version of the UI spec will require. This fixes
899 projects.maemo.org bug NB#56305.
901 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
903 * src/maemo/modest-maemo-utils.c:
904 (modest_maemo_utils_get_supported_secure_authentication_methods):
905 Added label to dialog instead of unreadable title
907 * src/maemo/modest-main-window.c: (sync_accounts_cb),
908 (modest_main_window_new):
909 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
912 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
913 * src/modest-account-mgr.h:
914 Added method to avoid code duplication
916 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
917 (modest_ui_actions_on_send_receive):
918 Use modest_account_mgr_has_accounts
920 2007-06-11 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/easysetup/modest-presets.c:
923 (modest_presets_get_info_server_security): Do not report secure auth
925 * src/modest-protocol-info.c: Use the defines for the gconf key names
926 for secure authentication. This was not working because we were writing
927 Password and reading password, and the check was case sensitive.
928 With this, gmail now works for receiving and sending when created via
931 2007-06-11 Murray Cumming <murrayc@murrayc.com>
933 * src/maemo/easysetup/modest-presets.c:
934 (modest_presets_get_info_server_security): Correct the key name for
935 SecureSmtp, because it seems to be case-sensitive.
936 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
937 Do not try to get the 0th notebook page if there are 0 pages, to
940 2007-06-11 Murray Cumming <murrayc@murrayc.com>
942 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
943 Prevent use of the new notification feature for now, because it currently
944 shows one dialog for each new email, which is annoying.
946 2007-06-11 Murray Cumming <murrayc@murrayc.com>
948 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
949 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
950 when no country was selected, so that we show the global ones.
951 * src/maemo/easysetup/modest-presets.c:
952 (modest_presets_get_providers): Return only the global providers, not
953 all providers when mmc=0 was requested.
955 2007-06-11 Murray Cumming <murrayc@murrayc.com>
957 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
958 (easysetup_provider_combo_box_fill): Remove debug code that showed the
959 provider ID in the combo.
961 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
962 Do not show the page numbers, because it would be confusing when we add
963 the 2 extra pages for the custom setup, when the user chooses the "Other"
964 provider. This fixes projects.maemo.org bug NB#59028
966 * src/modest-init.c: (modest_init_init_core),
967 (modest_init_local_folders):
969 * src/modest-tny-account.c:
970 (modest_tny_account_new_for_local_folders): Do not create default folders
971 for the memory card. This should fix projects.maemo.org bug NB#59328.
973 2007-06-11 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
976 Free the changed_conf_keys string items. They are already freed in the
977 idle handler if that runs first.
979 2007-06-11 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-ui-actions.c:
982 (modest_ui_actions_on_password_requested): Check that the server name
983 is not NULL, because I just saw a password dialog with (null) as the
986 * src/modest-tny-folder.[h|c]: Added
987 modest_tny_folder_is_memory_card_folder().
988 * src/modest-ui-dimming-rules.c:
989 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
990 menu item for memory cards, as per the UI spec (section 7.4). This should
991 fix projects.maemo.org bug NB#59297.
993 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
995 * src/maemo/modest-main-window.c: (sync_accounts_cb):
996 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
997 is another problem with the code, see Murray's comment at line 772)
999 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1001 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1002 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1003 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1004 (load_from_file), (easysetup_country_combo_box_init),
1005 (easysetup_country_combo_box_get_active_country_ids),
1006 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1007 instead of just one ID, to avoid duplicate country names in the UI.
1009 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1010 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1011 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1012 a single ID, avoiding duplicate providers.
1013 * src/maemo/easysetup/modest-easysetup-wizard.c:
1014 (on_combo_account_country): Adapt to use a list.
1016 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1019 keys changed in the last X seconds.
1021 * src/modest-account-mgr.h:
1022 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1023 (on_key_change), (modest_account_mgr_class_init),
1024 (modest_account_mgr_init), (modest_account_mgr_finalize):
1025 As the keys are changed, save them in a GSList* and signal that GSList*
1026 further every X seconds, to batch changes, to allow us to do just one
1027 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1028 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1030 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1031 changed signal signature.
1033 * src/modest-conf.c: (modest_conf_set_list),
1034 (modest_conf_on_change): Reenable notification.
1036 (modest_conf_maemo_fake_on_change): Comment out the hack that
1037 notified immediately instead of asynchronously.
1039 * src/widgets/modest-account-view.h:
1040 * src/widgets/modest-account-view.c:
1041 (update_account_view): Select the previously-selected account ID,
1042 if possible. This fixes projects.maemo.org bug NB#56933.
1044 (on_account_changed), (on_account_removed),
1045 (modest_account_view_select_account):
1047 Remove the block/unblock functions
1048 because they were not useful.
1050 * src/maemo/modest-account-view-window.c:
1051 (on_delete_button_clicked), (on_edit_button_clicked),
1052 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1054 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1056 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1057 Improve the error dialog to show Incorrect Account Settings, which seems
1058 clearer, and say that the internal error message (to be removed from the
1059 dialog later) is often misleading.
1060 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1062 * src/modest-tny-account.c:
1063 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1064 URL because this is so useful for debugging on the device.
1066 * src/widgets/modest-serversecurity-combo-box.c:
1067 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1069 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-mail-operation.c:
1072 (modest_mail_operation_send_new_mail):
1073 Added a comment about a nasty but apparently harmless message. Details
1074 added to the wiki g_warnings() page.
1076 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1078 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1079 (modest_tny_send_queue_class_init):
1080 Do not use the priv struct because it is empty, to avoid g_warnings
1081 about a non-existant priv struct.
1083 * src/modest-tny-account-store.c:
1084 (modest_tny_account_store_get_server_account),
1085 (modest_tny_account_store_get_transport_account_for_open_connection
1086 ): Do not try to get transport server accounts for local folders,
1087 because they don't have any. This avoids a g_warning().
1089 * src/maemo/modest-main-window.c:
1090 (modest_main_window_notify_send_receive_initied),
1091 (on_configuration_key_changed):
1092 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1093 * src/modest-defs.h:
1094 * src/modest-mail-operation.c:
1095 (modest_mail_operation_update_account):
1096 * src/modest-tny-account-store.h:
1097 * src/modest-tny-account.c:
1098 (modest_tny_account_get_special_folder),
1099 (modest_tny_account_new_for_local_folders),
1100 (modest_tny_account_new_for_per_account_local_outbox_folder):
1101 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1102 * src/modest-tny-local-folders-account.c:
1103 (add_account_folders_to_merged_folder):
1104 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1105 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1106 (modest_ui_actions_on_send):
1107 * src/widgets/modest-folder-view.c: (update_model):
1108 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1109 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1110 modest_tny_account_store_get_tny_account_by_account() to
1111 modest_tny_account_store_get_server_account() to make the code clearer.
1113 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1115 * src/dbus_api/modest-dbus-api.h:
1116 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1117 * src/maemo/modest-msg-edit-window.c:
1118 (modest_msg_edit_window_attach_file_noninteractive):
1119 added g_warning in case the file to be attached does not exist
1120 * tests/dbus_api/test_compose_mail.c: (main):
1121 removed obsolete comment, added generic files as test case
1123 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1125 * src/modest-tny-account-store.c: (get_server_accounts):
1126 Create the local folders account only once, not once for each outbox, and
1127 not only when there are some outboxes.
1129 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1131 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1132 code that is causing a crash at startup. Sergio says that he is fixing this.
1134 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1136 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1137 * src/maemo/modest-account-settings-dialog.c:
1138 (create_page_outgoing),
1139 (modest_account_settings_dialog_set_account_name),
1140 (save_configuration):
1141 - Fixed handling of the "Use secure authentication" toggle to comply with
1142 the ui specification. See also projects.maemo.org bug NB#58400
1144 - Restore the Secure connection setting combo correctly when loading
1147 * src/maemo/modest-maemo-utils.c:
1148 (on_camel_account_get_supported_secure_authentication),
1149 (modest_maemo_utils_get_supported_secure_authentication_methods):
1150 Fixed a crasher if operation is canceled
1152 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1153 (modest_protocol_info_auth_is_secure):
1154 * src/modest-protocol-info.h:
1156 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1157 the sense of the "Use secure authentication" toggle.
1159 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-tny-account-store.h:
1162 * src/modest-tny-account-store.c:
1163 Added modest_tny_account_store_get_local_folders_account().
1165 * src/modest-tny-folder.h:
1166 * src/modest-tny-folder.c:
1167 (modest_tny_folder_get_account):
1168 Added this replacement for tny_folder_get_account() which returns
1169 the local-folders account for TnyMergeFolders, to avoid the
1170 warning about the unimplemented get_account_func() vfunc().
1172 (modest_tny_folder_get_rules),
1173 * src/modest-ui-actions.c:
1174 (modest_ui_actions_on_folder_selection_changed):
1175 * src/modest-mail-operation.c:
1176 (modest_mail_operation_remove_folder),
1177 (modest_mail_operation_xfer_folder),
1178 (modest_mail_operation_rename_folder),
1179 (modest_mail_operation_get_msg),
1180 (modest_mail_operation_get_msgs_full),
1181 (modest_mail_operation_remove_msg),
1182 (modest_mail_operation_xfer_msgs),
1183 (modest_mail_operation_refresh_folder):
1184 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1186 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1188 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1189 (modest_server_account_set_security):
1190 * src/modest-defs.h: Add comments explaining that our
1191 UI spec means TLS when it says Normal, so these do not look like errors.
1193 * src/modest-tny-account.c:
1194 (modest_tny_account_new_from_server_account): Use the new tinymail
1195 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1196 for TLS. This should fix projects.maemo.org bug NB#58460.
1198 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1200 * src/maemo/easysetup/modest-easysetup-wizard.c:
1201 (create_account): Correct the position of the gconf sanity check warning.
1202 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1203 of using the g_idle_add() hack, because this does not seem to be necessary
1204 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1205 caused by something other than maemo's gconf.
1206 This fixes projects.maemo.org bug #59022.
1208 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-account-mgr-helpers.c:
1211 (modest_account_mgr_get_default_account): Do not check that the account
1212 exists if there is no default account (NULL), to fix a runtime warning.
1214 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1216 * src/widgets/modest-folder-view.c: (update_model):
1217 Do not unref the treemodel before we have finished with it.
1218 This prevents a valgrind warning and an occasional crash at startup.
1220 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1222 * libmodest-dbus-client/libmodest-dbus-client.h:
1223 added libmodest_dbus_client_compose_mail()
1224 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1226 added functions needed for SendAsMail() functionality
1227 * src/maemo/modest-msg-edit-window.c:
1228 (modest_msg_edit_window_attach_file_noninteractive):
1229 non interactively attaching files to message edit window
1230 * src/widgets/modest-msg-edit-window.h:
1231 * tests/dbus_api/Makefile.am:
1232 added test_compose_mail.c
1233 * tests/dbus_api/test_compose_mail.c: (main):
1235 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1237 * src/modest-account-view.c:
1238 Fixed bug projects.maemo.org bug NB#59307
1240 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1242 * src/maemo/easysetup/modest-easysetup-wizard.c:
1243 (get_serverport_incoming), (on_before_next), (create_account):
1244 * src/maemo/modest-account-settings-dialog.c:
1245 (modest_account_settings_dialog_set_account_name):
1246 * src/maemo/modest-maemo-utils.c:
1247 (on_camel_account_get_supported_secure_authentication_status),
1248 (on_camel_account_get_supported_secure_authentication),
1249 (on_secure_auth_cancel),
1250 (modest_maemo_utils_get_supported_secure_authentication_methods):
1252 Implemented security authentication for settings and easysetup.
1254 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1256 * src/maemo/modest-main-window.c: (create_details_widget):
1257 Show the total size for memory card accounts too, instead of showing
1258 the name again. Fixes bug projects.maemo.org bug NB#59307.
1260 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1263 * src/modest-tny-simple-folder-store.c:
1264 * src/modest-tny-simple-folder-store.h: Removed.
1266 * src/modest-tny-local-folders-account.h
1267 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1268 for the local-folders maildir, with an extra TnyMergedFolder containing
1269 the folders of the per-account outbox store accounts.
1270 * src/modest-tny-account-store.c: (get_server_accounts):
1271 Add the outboxes to the special local folders account after creating it.
1273 * src/modest-tny-account.c:
1274 (modest_tny_account_new_for_local_folders): Create the derived
1275 account when creating the main local-folders account.
1277 * src/maemo/modest-main-window.c: (create_details_widget),
1278 (modest_main_window_set_contents_style):
1279 Adapted to the use of the derived account instead of the folder store.
1281 * src/modest-ui-actions.c:
1282 (modest_ui_actions_on_folder_selection_changed):
1283 * src/modest-ui-dimming-rules.c:
1284 (modest_ui_dimming_rules_on_new_folder):
1285 * src/widgets/modest-folder-view.c: (text_cell_data),
1286 (icon_cell_data), (filter_row), (update_model),
1287 (get_cmp_rows_type_pos):
1290 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1291 Do not get the priv struct, because no priv struct has been set,
1292 to avoid a runtime warning.
1294 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1295 #ifelse with #else, to fix a warning, to fix the build.
1298 2007-06-05 Christian Kellner <ckellner@openismus.com>
1300 * libmodest-dbus-client/libmodest-dbus-client.c:
1301 Fix small typo in doc (why do you always see them
1302 AFTER committing stuff?)
1305 2007-06-05 Christian Kellner <ckellner@openismus.com>
1307 * libmodest-dbus-client/libmodest-dbus-client.c:
1308 (libmodest_dbus_client_search):
1309 Initialize hit list with NULL. Also set folder list
1310 to "" if NULL was supplied.
1313 2007-06-03 Christian Kellner <ckellner@openismus.com>
1315 * libmodest-dbus-client/libmodest-dbus-client.c:
1316 (modest_search_hit_list_free):
1317 Make it save to call it with NULL.
1319 * src/dbus_api/modest-dbus-callbacks.c:
1320 * src/modest-search.c:
1321 Return full ModestSearchHits as the search result list not TnyHeader
1322 since can't be around withouth the correspoding TnyFolder.
1324 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1326 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1327 Added currently commented code to check for secure auth
1329 * src/maemo/modest-account-settings-dialog.c: (on_response),
1330 (save_configuration), (show_ok):
1331 Fixed projects.maemo.org bugs NB #59248 and #59251
1333 * src/maemo/modest-maemo-utils.c:
1334 (on_camel_account_get_supported_secure_authentication_status),
1335 (on_camel_account_get_supported_secure_authentication),
1336 (modest_maemo_utils_get_supported_secure_authentication_methods):
1337 * src/maemo/modest-maemo-utils.h:
1338 Moved get_supported_secure_authentication() method here to be able
1339 to use it from easysetup wizard.
1341 * src/modest-pair.c: (on_pair_compare_as_string):
1342 Should compare string with first part of pair and not
1343 strcmp pairs which will crash.
1345 * src/modest-protocol-info.c:
1346 (modest_protocol_info_protocol_is_store):
1347 * src/modest-protocol-info.h:
1348 Added modest_protocol_info_get_auth_protocol_name()
1350 2007-06-03 Armin Burgmeier <armin@openismus.com>
1352 * src/modest-mail-operation.c:
1353 (modest_mail_operation_get_msgs_full): Set priv->account also when
1354 only retrieving a single message. This avoids a crash when canceling
1357 (modest_mail_operation_notify_end): Do not explicitely remove the
1358 operation from the queue but only emit the progress_changed signal.
1359 The queue itself listens to that signal to remove the operation when
1360 it is finished. This reduces coupling and removes a potential deadlock
1361 when modest_mail_operation_notify_end() is called from the queue
1362 itself. If that is a problem performance-wise, I would suggest to
1363 implement a status-changed signal or something.
1365 * src/modest-mail-operation-queue.c: Make sure to never call a
1366 function from another file while the queue is locked. This (hopefully)
1367 fixes another deadlock when exiting the application while retrieving
1370 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1372 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1373 Fixed build if libogs is not available
1375 2007-06-03 Christian Kellner <ckellner@openismus.com>
1377 * libmodest-dbus-client/libmodest-dbus-client.h:
1378 * libmodest-dbus-client/libmodest-dbus-client.c:
1379 (libmodest_dbus_client_delete_message):
1380 Implement deletion of messages (Client side).
1382 (modest_search_hit_free),
1383 (modest_search_hit_list_free):
1384 Utility functions to free the result hits.
1386 * src/dbus_api/modest-dbus-api.h:
1387 * src/dbus_api/modest-dbus-callbacks.c:
1388 (on_delete_message),
1389 (modest_dbus_req_handler):
1390 Implement deletion of messages (Server side).
1392 * tests/dbus_api/test_search.c: (main):
1395 * tests/dbus_api/Makefile.am:
1396 * tests/dbus_api/test_delete_message:
1397 Add little test for the message deletion logic
1399 2007-06-03 Armin Burgmeier <armin@openismus.com>
1401 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1402 when the operation queue was not empty. projects.maemo.org bug
1405 2007-06-03 Armin Burgmeier <armin@openismus.com>
1407 * src/widgets/modest-account-view.c
1408 (on_account_default_toggled): Toggle default account column
1409 explicitely instead of waiting for gconf notification (which is
1410 currently ignored). This should fix projects.maemo.org bug NB#56910
1411 for now. It should probably be removed when gconf notifications are
1414 2007-06-03 Christian Kellner <ckellner@openismus.com>
1416 * libmodest-dbus-client/libmodest-dbus-client.c:
1417 Removed debugging spew.
1419 * src/dbus_api/modest-dbus-callbacks.c:
1420 Added debugging info.
1422 * src/modest-search.c:
1423 (modest_search_all_accounts):
1424 Use tny_account_store_get_accounts () on the account store
1425 to get all accounts which is the way to get all accounts.
1427 * tests/dbus_api/test_search.c: (main):
1428 Make it possible to supply the search term on the command line.
1430 2007-06-03 Christian Kellner <ckellner@openismus.com>
1432 * libmodest-dbus-client/libmodest-dbus-client.c:
1433 * libmodest-dbus-client/libmodest-dbus-client.h:
1434 Implement searching for mesages over raw dbus. (Client side)
1436 * src/dbus_api/Makefile.am:
1437 * src/dbus_api/modest-dbus-api.h:
1438 * src/dbus_api/modest-dbus-callbacks.c:
1439 * src/dbus_api/modest-dbus-callbacks.h:
1440 Search framework (Server side). Also implement on_idle_open_message().
1442 * src/maemo/modest-platform.c: (modest_platform_init):
1443 Prepare for raw dbus/osso rpc interaction.
1445 * src/modest-search.h:
1446 Changed minsize from unspecific guint to guint32.
1448 * src/modest-search.c:
1450 Added strange hack which magically made tnymail work.
1452 (modest_search_folder),
1453 (modest_search_account),
1454 (modest_search_all_accounts):
1455 Implement helper functions to search all accounts, specific account
1458 * tests/dbus_api/Makefile.am:
1459 * tests/dbus_api/test_open_message.c:
1460 Read url to open from commandline.
1462 * tests/dbus_api/test_search.c:
1463 Implement small test for dbus search stuff
1465 2007-06-02 Armin Burgmeier <armin@openismus.com>
1467 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1468 include account type and account title. This fixes projects.maemo.org
1471 * src/maemo/modest-account-view-window.c: Set a title for the window.
1473 2007-06-02 Armin Burgmeier <armin@openismus.com>
1475 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1476 incoming and outgoing server name based on email address and server
1477 types as long as the names have not been edited manually. This fixes
1478 projects.maemo.org bug NB#58671.
1480 2007-06-02 Armin Burgmeier <armin@openismus.com>
1482 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1483 server type cannot be changed in future to the incoming details page
1484 when creating an account. This fixes projects.maemo.org bug NB#59029.
1486 2007-06-02 Armin Burgmeier <armin@openismus.com>
1488 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1489 and assigned max width chars so that they wrap instead of being
1490 truncated. Fixes projects.maemo.org bug NB#56126.
1492 2007-06-02 Armin Burgmeier <armin@openismus.com>
1494 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1495 introductory note to the connection specific smtp servers dialog, as
1496 section 8.12 of the email UI specification requires. This fixes
1497 projects.maemo.org bug NB#59212.
1499 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1501 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1502 Check for running mail operations, and offer to cancel them, as per the UI
1503 spec. This fixes projects.maemo.org bug NB#59041 .
1504 However, I suspect that tinymail may still use the network connection
1505 in ways that we cannot detect or cancel. But it should at least adapt to
1506 changes fairly well.
1508 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1510 * src/modest-tny-account-store.c: (recreate_all_accounts),
1511 (get_cached_accounts), (get_server_accounts): Do more sensible
1512 ref-counting of the temporarily-cached outbox accounts list. This seems
1513 to fix a crash when entering the password when the password was wrong.
1515 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1517 * src/gnome/modest-main-window.c: (connect_signals):
1518 * src/modest-tny-account-store.c: (get_password),
1519 (modest_tny_account_store_alert): Added comments and clues and
1520 commented-out code about how we currently fail to deal with connection
1521 errors and wrong passwords, and how we should.
1523 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1525 * src/widgets/modest-retrieve-combo-box.c:
1526 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1527 This fixes projects.maemo.org bug NB#58472 .
1529 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1531 * src/maemo/easysetup/modest-easysetup-wizard.c:
1532 (create_page_complete_easysetup):
1533 (create_page_complete_custom): Correct the last commit,
1534 putting the correct sentences in the correct pages.
1536 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1538 * src/maemo/easysetup/modest-easysetup-wizard.c:
1539 (create_page_complete_custom): Show the second sentence of text
1540 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1543 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1545 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1546 Set the leave-on-server conf key by default. This fixes
1547 projects.maemo.org bug NB#59258 .
1549 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1551 * src/maemo/modest-account-view-window.c:
1552 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1553 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1556 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1558 * src/maemo/easysetup/modest-easysetup-wizard.c:
1559 (create_caption_new_with_asterisk):
1560 * src/maemo/modest-account-settings-dialog.c:
1561 (create_caption_new_with_asterisk):
1562 Uncomment the code to add the asterisk, because they are no longer in the
1563 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1564 (update_incoming_server_title): Add an asterisk here too.
1566 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1568 * src/maemo/modest-maemo-global-settings-dialog.c:
1569 (current_connection): Check that we are even connected before trying to
1570 get the current connection name, to prevent a warning.
1572 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1573 Change the comments because tny_maemo_conic_device_connect() is now meant to
1575 * src/modest-mail-operation.c:
1576 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1577 make sure we have a connection and fail if we can't connect.
1579 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1581 * src/maemo/modest-main-window.c:
1582 (on_account_store_connecting_finished): Do not try to get the
1583 connection ID if we are not really connected. I am surprised that
1584 this signal handler is called when we are not connected.
1586 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-error.h:
1589 * src/modest-ui-actions.c:
1590 (modest_ui_actions_get_msgs_full_error_handler):
1591 Renamed an enum, added comments, added an enum
1592 for retrieve-limit errors.
1594 * src/modest-mail-operation.c: (foreach_add_item),
1595 (internal_folder_observer_update), (update_account_thread),
1596 (modest_mail_operation_get_msgs_full):
1597 (modest_mail_operation_update_account),
1598 Added comments about how this works, and some code that should
1599 (but does not) check the retrieve-limit. See the TODO comment.
1601 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1603 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1604 Initialize help_id to fix the build. Warnings are good.
1606 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1608 * src/widgets/modest-hbox-cell-renderer.c:
1609 (modest_hbox_cell_renderer_append):
1610 * src/widgets/modest-vbox-cell-renderer.c:
1611 (modest_vbox_cell_renderer_append):
1612 Fix the last commit by doing an extra ref.
1614 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1616 * src/widgets/modest-hbox-cell-renderer.c:
1617 (modest_hbox_cell_renderer_append):
1618 * src/widgets/modest-vbox-cell-renderer.c:
1619 (modest_vbox_cell_renderer_append):
1620 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1621 to fix the build with Maemo Bora.
1622 However, there seems to be a remaining crash, probably due to reference
1625 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1627 * src/modest-tny-account.c:
1628 (modest_tny_account_new_for_local_folders):
1629 Use hildon_file_system_info_async_new() to get a better name for
1630 the memory card account, setting it as the account name.
1631 The timing seems to work, but this is probably
1632 not the best place to do this. See the TODO comment.
1633 * src/maemo/modest-main-window.c: (create_details_widget):
1634 * src/widgets/modest-folder-view.c: (text_cell_data):
1635 Use the tny account name instead of hardcoding a name.
1637 2007-05-30 Christian Kellner <ckellner@openismus.com>
1639 * src/modest-search.c: (modest_search):
1640 Correctly set part_search_func even if we have already parsed
1641 the query and thus a valid OgsTextSearcher object.
1643 2007-05-30 Christian Kellner <ckellner@openismus.com>
1646 Search and check for libogs.
1649 Incooparte the ogs build env.
1651 * src/modest-mime-part-search-stream.c:
1652 * src/modest-mime-part-search-stream.h:
1653 Removed since we do the real searching now in modest-search.c.
1655 * src/modest-search.c:
1656 * src/modest-search.h:
1657 Implement support for ogs. We use that if available and requested
1658 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1659 should now handle the corner case when the search term is spread
1660 across multiple reads.
1661 Also the logic in modest_search () was corrected to search all
1662 requested fields until one is found.
1664 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1668 * src/modest-init.h:
1669 * src/modest-init.c: Made modest_init_local_folders() take a
1670 path and be public so we can iniitialize maildir folders on
1673 * src/modest-local-folder-info.h:
1674 * src/modest-local-folder-info.c:
1675 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1677 * src/modest-tny-account.c:
1678 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1679 still means the standard local-folders path on the local volume.
1681 * src/modest-tny-account-store.c:
1682 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1683 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1684 all accounts when that happens.
1685 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1686 this too, so it shows up in the treeview.
1688 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1690 * src/maemo/modest-maemo-global-settings-dialog.c:
1691 (current_connection):
1692 * src/widgets/modest-global-settings-dialog.c:
1693 (current_connection_default):
1694 Use the enum values instead of 0, 1 and -1,
1695 to make the code clearer.
1697 * src/modest-account-mgr-helpers.c:
1698 (modest_account_mgr_get_connection_specific_smtp): Make this code
1701 * src/modest-runtime.h:
1702 * src/modest-runtime.c:
1703 Added modest_runtime_remove_all_send_queues().
1704 * src/maemo/modest-main-window.c:
1705 (on_account_store_connecting_finished): Recreate the send queues,
1706 using the appropriate transport accounts for this new connection.
1707 Some futher adapting might be needed if the old send queues are not
1708 automatically stopped at this point.
1710 * src/modest-tny-account-store.c: (get_server_accounts):
1711 Create the connection-specific transport accounts, so that they can
1712 be found later by their ID.
1714 * src/modest-tny-account.h:
1715 * src/modest-tny-account.c:
1716 Added modest_tny_account_new_from_server_account_name().
1717 modest_tny_account_new_from_server_account(): Do not create the
1718 send queues here, because they will be
1719 recreated anyway when the connection changes for the first time.
1721 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1723 * src/modest-local-folder-info.h:
1724 * src/modest-local-folder-info.c:
1725 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1726 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1727 tbox_folder): Take a modest account name instead of a server TnyAccount,
1728 so we can have per-modest-account rather than per-transport-account
1730 We must make sure that we change or recreate the exisitng send queues
1731 when the connection changes for connection-specific transport accounts.
1733 * src/modest-tny-account-store.c:
1734 (create_per_account_local_outbox_folders): Create outboxed per modest
1735 account, not per transport account.
1737 * src/modest-tny-account.h:
1738 * src/modest-tny-account.c:
1739 (modest_tny_account_get_special_folder): For outboxes, get the
1740 parent modest account name. The account is ignored for other folders.
1741 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1742 modest account name rather than a server TnyAccount.
1744 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1746 * src/modest-tny-account.c:
1747 (modest_tny_account_new_from_server_account):
1748 Call modest_runtime_get_send_queue() immediately after creating transport
1749 accounts, so that they start trying to send email from the outbox as soon
1750 as possible at startup. This is probably what we want.
1752 * src/modest-mail-operation.c: (update_account_thread):
1753 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1754 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1755 * src/modest-tny-send-queue.h:
1756 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1757 (modest_ui_actions_on_send):
1758 Added comments about how sending works, though it needs some more work.
1760 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1762 * src/modest-tny-account.c:
1763 (modest_tny_account_get_special_folder): Add TODO because this fails when
1764 the network is busy.
1765 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1766 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1767 Do not try to show this window when there is no active account. The UI
1768 specs does not tell us what to do in this case.
1770 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1774 * src/maemo/Makefile.am:
1775 * src/widgets/Makefile.am: Some dist fixes.
1777 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1779 * src/maemo/modest-connection-specific-smtp-window.c:
1780 (on_button_edit): Make the code clearer, to prevent a double free.
1782 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1784 * src/maemo/modest-account-settings-dialog.c:
1785 (modest_account_settings_dialog_set_account_name),
1786 Check the connection-specific smtp servers checkbox if there are any.
1788 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1789 (modest_connection_specific_smtp_edit_window_init):
1790 Start with a suitable port number.
1792 * src/modest-account-mgr-helpers.h:
1793 * src/modest-account-mgr-helpers.c: Added
1794 modest_account_mgr_get_has_connection_specific_smtp().
1796 (modest_account_mgr_set_connection_specific_smtp),
1797 (modest_account_mgr_remove_connection_specific_smtp),
1798 (modest_account_mgr_get_has_connection_specific_smtp),
1799 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1800 connection-specific smtp server accounts in the account, rather than
1801 the server account conf dir.
1803 This fixes bug projects.maemo.org bug NB#58263 .
1805 * src/modest-tny-account-store.c:
1806 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1807 if there are no server accounts yet, to prevent an infinite loop when there
1808 are no accounts. Document that one must be called before the other.
1810 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1812 * src/modest-account-mgr-helpers.c:
1813 (modest_account_mgr_get_default_account): Make sure that at least
1814 one account is always the default, if there are any enabled accounts.
1815 This is just a sanity check that shouldn't be necessary.
1817 * src/modest-account-mgr-priv.c:
1818 (_modest_account_mgr_account_from_key): Unescape the conf key to
1819 get the real account name. For instance, this is an issue if a space
1820 was in the account name, which can happen because the account name
1821 is generated from the display name.
1822 (_modest_account_mgr_get_account_keyname): Always escape the
1824 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1825 Unescape the conf keys to get the real account names.
1827 For instance, previously the is-default radio button in the accounts
1828 list was not checked for any accounts at first. This fixes that,
1829 and might fix several similar bugs.
1831 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1833 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1834 Removed some debug printfs.
1836 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1838 Modest on-disk outbox directories are now here, for instance:
1839 $HOME/.modest/outboxes/<account-id-1>/outbox
1840 $HOME/.modest/outboxes/<account-id-2>/outbox
1842 $HOME/.modest/local-folders/outbox
1843 so we can have a separate outbox for each account.
1844 But they are shown as one outbox in the GtkTreeView, by using a
1845 TnyMergeFolder in a ModestTnySimpleFolderStore.
1848 * src/modest-tny-simple-folder-store.c:
1849 * src/modest-tny-simple-folder-store.h:
1850 Added ModestTnySimpleFolderStore, used to contain folders from
1851 other folder stores, such as other accounts.
1853 * src/modest-tny-outbox-account.h:
1854 * src/modest-tny-outbox-account.c:
1855 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1856 used for the per-account local outbox folders.
1858 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1859 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1860 only use this (internally) now for the non-outbox local folders.
1862 * src/modest-init.h:
1863 * src/modest-init.c: Added modest_init_one_local_folder(), for
1864 setting up the directory structure for each local folder.
1866 * src/modest-local-folder-info.c:
1867 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1868 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1870 * src/modest-local-folder-info.h:
1871 * src/modest-tny-account-store.c: (on_account_removed),
1872 (on_account_changed), (create_per_account_local_outbox_folders),
1873 (get_server_accounts), (modest_tny_account_store_get_accounts),
1874 (modest_tny_account_store_get_tny_account_by_account),
1875 (modest_tny_folder_store_is_virtual_local_folders):
1877 * src/modest-tny-account.h:
1878 * src/modest-tny-account.c:
1879 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1880 to create an on-disk per-account local outbox folder for each
1882 (create_per_account_local_outbox_folders): Create a local outbox folder
1883 for each transport account.
1884 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1885 for all local folders.
1887 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1888 instead of using g_object_get/set() directly. It is clearer.
1890 (modest_tny_folder_store_get_message_count),
1891 (modest_tny_folder_store_get_local_size
1892 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1893 because we now use these with non-acount folder stores.
1895 (modest_tny_account_get_special_folder),
1896 (modest_tny_account_new_from_server_account),
1897 (modest_tny_account_new_from_account):
1898 (recurse_folders): Adjust to the new outbox system.
1900 * src/modest-tny-folder.h:
1901 * src/modest-tny-folder.c:
1902 (modest_tny_folder_is_local_folder),
1903 (modest_tny_folder_get_local_folder_type),
1904 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1906 * src/widgets/modest-main-window.h:
1907 * src/maemo/modest-main-window.c: (create_details_widget),
1908 (modest_main_window_set_contents_style): Show details for any folder store,
1911 (modest_tny_folder_get_rules):
1912 Remove the const. C does not support constness enough for this.
1914 * src/modest-ui-actions.c:
1915 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1916 make all outboxes appear as one, in the usual local-folders tree node.
1918 (set_active_account_from_tny_account),
1919 (modest_ui_actions_on_folder_selection_changed):
1920 * src/widgets/modest-folder-view.c: (text_cell_data),
1921 (icon_cell_data), (filter_row),
1922 (add_account_folders_to_merged_folder),
1923 (add_account_folders_to_simple_folder_store), (),
1924 (get_cmp_rows_type_pos), (cmp_rows),
1925 (modest_folder_view_set_account_id_of_visible_server_account):
1926 Adjust to the new outbox system, using generic folder stores and folders
1927 in the GtkTreeModel.
1929 2007-05-23 Christian Kellner <ckellner@openismus.com>
1931 * src/modest-mail-operation.c:
1932 (modest_mail_operation_update_account):
1933 Use info->max_size instead of unintialized local var [small
1934 build fix]. (Added TODO to review that change since I don't
1937 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1939 * libmodest-dbus-client/libmodest-dbus-client.c:
1940 (libmodest_dbus_client_compose_mail): function added
1941 * src/dbus_api/modest-dbus-api.h:
1942 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1943 (on_compose_mail): Implementation of the SendAsMail functionality
1945 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1947 * src/modest-account-mgr.c:
1948 (modest_account_mgr_add_server_account): Set the secure-connection
1949 conf key for transport accounts as well as store accounts. I don't know
1950 why the if was there. For instance, this makes sure that we use SSL
1951 for the gmail preset from the easysetup wizard.
1953 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1955 * src/gnome/modest-main-window.c:
1956 (on_account_store_connecting_finished), (connect_signals):
1957 * src/maemo/modest-main-window.c:
1958 (on_account_store_connecting_finished), (connect_signals),
1959 (modest_main_window_new):
1960 Handle TnyAccountStore::connecting-finished instead of
1961 TnyDevice::connection-changed, because we cannot actually perform
1962 operations on accounts until TnyAccountStore has itself responded to
1963 the TnyDevice::connection-changed signal. This prevents a GError from
1965 Do not try to update at startup, because we (at least on scratchbox)
1966 already do an update at startup when the device goes online.
1967 This prevents a GError from tinymail.
1968 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1969 Added TODO about stopping simultaneous operations.
1971 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1973 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1974 * src/modest-mail-operation-queue.c:
1975 (modest_mail_operation_queue_remove):
1976 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1977 about where they happened.
1979 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-ui-actions.c:
1982 (modest_ui_actions_on_password_requested): Make sure that the remember
1983 output parameter is always TRUE.
1985 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1988 Show a OK/Cancel dialog if the error is a question, though we still do not
1989 know anything more about what we are asking the user.
1990 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1991 Fix an uninitialized variable (helper). This is a logic error, however.
1993 2007-05-21 Christian Kellner <ckellner@openismus.com>
1995 * src/modest-search.h:
1996 Correct bit shifting in the ModestSearchFlags enum.
1998 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2000 * src/modest-tny-account.c:
2001 (modest_tny_account_new_from_server_account): Do not use the lsub and
2002 check-all hard-coded IMAP options when using POP.
2004 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-tny-account.c:
2007 (modest_tny_account_new_from_server_account):
2008 Use NULL for the secure-auth method for POP when Password auth has been
2009 specified by the user, as we already do for IMAP. "auth=Login" causes
2010 an error from camel or the server.
2012 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/modest-account-settings-dialog.c:
2015 (create_page_account_details),
2016 (modest_account_settings_dialog_set_account_name):
2017 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2018 for the leave-on-server checkbox, rathr than just the checkbox, when
2019 the protocol is not POP.
2021 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2023 * src/widgets/modest-account-view.c:
2024 * src/widgets/modest-account-view.h:
2025 Added modest_account_view_select_account() which will be useful later
2026 to asynchronously re-select the edited account.
2028 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2030 * src/maemo/modest-account-settings-dialog.c:
2031 (modest_account_settings_dialog_set_account_name):
2032 Automatically choose the port numbers based on the secure authentication
2033 methods, if they have not been chosen before.
2034 This fixes projects.maemo.org bug NB#56273 .
2036 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2038 * src/maemo/modest-main-window-ui.h:
2039 * src/modest-ui-actions.c:
2040 * src/modest-ui-actions.h:
2041 Connect the Tools/SMTP Servers menu item to
2042 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2043 SMTP servers dialog, as in the UI specification and saves changes when it
2044 is closed. This fixed projects.maemo.org bug NB#56305 .
2046 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/modest-connection-specific-smtp-window.c:
2049 (modest_connection_specific_smtp_window_init):
2050 Use gtk_window_set_default_size() to make this window big enough, so
2051 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2053 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2055 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2056 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2057 (modest_connection_specific_smtp_edit_window_init),
2058 Do not try to connect to a combobox signal before the combobox exists.
2059 This fixes the cras in projects.maemo.org bug NB#56288 .
2060 (modest_connection_specific_smtp_edit_window_get_settings):
2061 Remove the server_account_name parameter which was being checked for NULL
2062 though it was not used.
2064 * src/maemo/modest-connection-specific-smtp-window.c:
2065 (modest_connection_specific_smtp_window_fill_with_connections),
2066 (on_button_edit), (modest_connection_specific_smtp_window_init):
2067 Correct the number of treemodel columns to prevent a warning.
2068 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2069 libconic does not work.
2071 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2073 * src/modest-tny-account.c:
2074 (modest_tny_account_new_from_server_account):
2075 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2076 SMTP when "None" was chosen by the user. However, with my SMTP server that
2077 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2080 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2082 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2083 to explain the memory management issue with the ID in the ModestPair.
2085 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2086 (add_sending_page), (modest_account_assistant_finalize):
2087 * src/gnome/modest-gnome-global-settings-dialog.c:
2088 (create_updating_page), (create_composing_page):
2089 * src/gnome/modest-msg-edit-window.c: (get_transports),
2090 (init_window), (modest_msg_edit_window_finalize),
2091 (modest_msg_edit_window_get_msg_data):
2092 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2093 * src/gnome/modest-transport-widget.c:
2094 (modest_transport_widget_finalize), (smtp_configuration):
2095 * src/maemo/modest-maemo-global-settings-dialog.c:
2096 (create_updating_page), (create_composing_page):
2097 * src/maemo/modest-msg-edit-window.c: (get_transports),
2098 (init_window), (modest_msg_edit_window_finalize),
2099 (modest_msg_edit_window_get_msg_data),
2100 (modest_msg_edit_window_free_msg_data):
2101 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2102 (modest_store_widget_finalize):
2103 * src/maemo/modest-transport-widget.c:
2104 (modest_transport_widget_finalize), (smtp_configuration):
2105 * src/modest-main.c: (send_mail):
2106 * src/widgets/modest-combo-box.h:
2107 * src/widgets/modest-global-settings-dialog-priv.h:
2108 * src/widgets/modest-global-settings-dialog.c:
2109 (modest_global_settings_dialog_finalize):
2110 * src/widgets/modest-msg-edit-window.h:
2111 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2112 as long as the combo box, to prevent use of freed memory for the ID.
2114 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2117 get_accounts(), to make this clearer. Do not check for the enabled gconf
2118 key, because we do not use this for server accounts (at least, not yet).
2119 This allows us to send email again.
2121 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2123 * src/maemo/modest-platform.c:
2124 (on_modest_conf_update_interval_changed), (modest_platform_init):
2125 Only respond to this particular key change. All these strcmp()s cannot be
2128 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2130 * src/maemo/modest-maemo-global-settings-dialog.c:
2131 (current_connection): Prevent a crash in scratchbox when
2132 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2133 * src/maemo/modest-platform.c:
2134 (on_modest_conf_update_interval_changed), (modest_platform_init):
2135 Get the update interval from gconf and reset it when the gconf key changes.
2137 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2139 * src/modest-protocol-info.c:
2140 * src/modest-protocol-info.h: Adde enum-specific get functions,
2141 instead of using a ModestProtocolType enum parameter.
2143 * src/gnome/modest-account-assistant.c:
2144 * src/gnome/modest-store-widget.c:
2145 * src/gnome/modest-store-widget.h:
2146 * src/gnome/modest-transport-widget.c:
2147 * src/gnome/modest-transport-widget.h:
2148 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2149 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2150 * src/maemo/easysetup/modest-easysetup-wizard.c:
2151 * src/maemo/modest-account-settings-dialog.c:
2152 * src/maemo/modest-account-settings-dialog.h:
2153 * src/maemo/modest-store-widget.c:
2154 * src/maemo/modest-store-widget.h:
2155 * src/maemo/modest-transport-widget.c:
2156 * src/maemo/modest-transport-widget.h:
2157 * src/modest-account-mgr-helpers.c:
2158 * src/modest-account-mgr-helpers.h:
2159 * src/modest-account-mgr.c:
2160 * src/modest-account-mgr.h:
2161 * src/modest-tny-account.c:
2162 * src/modest-tny-folder.c:
2163 * src/widgets/modest-account-view.c:
2164 * src/widgets/modest-retrieve-combo-box.c:
2165 * src/widgets/modest-retrieve-combo-box.h:
2166 * src/widgets/modest-secureauth-combo-box.c:
2167 * src/widgets/modest-serversecurity-combo-box.c:
2168 * src/widgets/modest-serversecurity-combo-box.h:
2169 * tests/check_account-mgr.c:
2170 Use the specific functions, and use the re-renamed enum values for GNOME too.
2172 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2174 * src/modest-pair.h:
2175 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2176 so we can get the second based on the first.
2178 * src/maemo/modest-account-settings-dialog.h:
2179 * src/maemo/modest-account-settings-dialog.c:
2180 Added get_supported_secure_authentication_methods(), though it is mostly
2181 commented-out for now until the necessary API is committed to tinymail.
2182 (modest_account_settings_dialog_set_account_name),
2183 (save_configuration): Request the supported authentication methods from the
2184 server, so we can choose a working method.
2186 * src/modest-tny-account-store.h:
2187 * src/modest-tny-account-store.c:
2188 (modest_tny_account_store_get_session): Rename from
2189 tny_account_store_get_session().
2191 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2193 * src/modest-protocol-info.h: Split the ModestProtocol enum
2194 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2195 There was no need to have these unrelated values in one enum.
2197 * src/: many files: Adapted to changed enum. This makes the code a bit
2198 clearer, and the compiler could catch some errors.
2200 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2202 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2203 Show the detailed internal camel error message when an error happens
2204 during the configuration, so that our testers can give us more clues.
2205 For instance, in projects.maemo.org bug NB#56910 .
2207 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2209 * src/modest-tny-account.c:
2210 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2211 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2213 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2216 * src/maemo/modest-account-settings-dialog.c:
2217 (modest_account_settings_dialog_set_account_name),
2218 (save_configuration): For the incoming secure authentication checkbox,
2219 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2220 the UI specification. PLAIN does not seem to be supported for most IMAP
2221 servers anyway, and I am not sure what it would mean.
2222 However, we probably need to discover which of the secure-authentication
2223 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2224 * src/modest-account-mgr-helpers.c:
2225 (modest_account_mgr_get_server_account_data):
2227 * src/modest-tny-account.c:
2228 (modest_tny_account_new_from_server_account):
2229 Use tny_account_set_mech() to set secure-authentication methods,
2230 with some special-casing for IMAP, based on my observations of how
2233 * src/modest-account-mgr-helpers.h:
2234 * src/modest-account-mgr.c:
2235 * src/modest-defs.h: Comment that the URI is only used for local folders.
2237 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2239 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2240 parameter const, just to be neat.
2241 * src/modest-text-utils.c: (modest_text_utils_inline):
2242 End g_strconcat() with NULL, as its documentation says. This is almost
2243 certainly the cause of my crash at startup on the device. Interestingly,
2244 valgrind doesn't tell us about these errors.
2246 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2248 * scripts/build-packages: Added more precise comments about how to use
2249 this script, though I still get this error:
2250 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2251 error building tinymail
2253 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2255 * src/maemo/modest-main-window.c: (on_account_update):
2256 Very slight cleanup, hoping to make it simpler to discover what causes
2257 a crash here sometimes.
2259 * src/modest-tny-account.c:
2260 (modest_tny_account_new_from_server_account): Set the port. Added
2261 comments about the options and a TODO comment because I need to find out
2262 how to specify the secure authentication method.
2264 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2266 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2267 changed CFlags paths form modest to libmodest
2269 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2271 * src/modest-account-mgr-helpers.c:
2272 (modest_account_mgr_get_server_account_data),
2273 (modest_account_mgr_free_server_account_data):
2274 * src/modest-account-mgr-helpers.h:
2275 * src/modest-account-mgr.c:
2276 (modest_account_mgr_add_server_account):
2277 * src/modest-defs.h:
2278 * src/modest-tny-account.c:
2279 (modest_tny_account_new_from_server_account):
2280 Determine the options for tny_camel_account_add_option() here,
2281 based on the settings, rather than storing them directly in gconf.
2283 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2285 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2286 Show a more friendly error dialog now that we expect (from the tinymail
2287 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2289 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2291 * src/maemo/modest-main-window.c: (on_account_update): Check that
2292 account_name is not NULL, to prevent a crash at startup that I am
2293 seeing on the N800. I do wonder why it is NULL.
2295 * src/maemo/easysetup/modest-easysetup-wizard.c:
2296 (create_page_user_details):
2297 * src/maemo/modest-account-settings-dialog.c:
2298 (create_page_user_details), (create_page_outgoing):
2299 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2300 (modest_connection_specific_smtp_edit_window_init):
2301 * src/modest-ui-actions.c:
2302 (modest_ui_actions_on_password_requested):
2303 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2304 might do something useful with the on-screen keyboard.
2306 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2308 * src/maemo/modest-main-window.c: (on_account_update):
2309 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2310 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2312 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2314 * src/modest-tny-account-store.c: (on_account_changed):
2315 Correct the signature of this signal handler.
2317 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2319 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2320 Show a HildonNote instead of a GtkDialog for Maemo.
2322 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2324 * src/widgets/modest-account-view.h:
2325 * src/widgets/modest-account-view.c: (on_account_changed),
2326 (on_account_removed). Added a boolean flag, set/unset by
2327 modest_account_view_block_conf_updates(),
2328 modest_account_view_unblock_conf_updates() to prevent unnecessary
2329 updates, but this is not very useful because the gconf notifications are
2330 so delays (maybe only on Maemo Bora).
2331 So auto-updating is turned off, and these functions do an explicit
2332 update when necessary.
2333 However, something else is still doing too much work when adding/removing
2334 accounts, probably in another part of the application.
2336 * src/maemo/modest-account-view-window.c:
2337 (on_delete_button_clicked), (on_edit_button_clicked),
2338 (on_new_button_clicked): Use the new functions.
2340 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2342 * src/modest-account-mgr-helpers.c:
2343 (modest_account_mgr_set_first_account_as_default):
2344 Sort the list of names alphabetically-by-title, so we choose the first one
2346 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2347 alphabetically by the title.
2349 This fixes projects.maemo.org bug NB#56418 .
2351 * src/modest-account-mgr-priv.c:
2352 (_modest_account_mgr_account_from_key):
2353 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2354 avoid a valgrind error, and possible random behaviour.
2356 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2358 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2359 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2360 tinymail documentation to say that this can be expected.
2361 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2362 pretty, and should not happen, but I would prefer to know when it does.
2364 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2366 * configure.ac: When using the older hildon version, probably on Bora,
2367 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2369 * src/widgets/modest-attachment-view.c:
2370 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2373 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2375 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2376 Implemented the prototype. Can be tested with
2377 tests/dbus_api/test_open_message:
2379 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2381 * src/modest-tny-account-store.c:
2382 (modest_tny_account_store_instance_init), (get_password):
2383 * src/modest-ui-actions.c:
2384 (modest_ui_actions_on_password_requested):
2385 Do not store the password in gconf, because this function is called
2386 for non-remembered passwords. Actually use the cached (in the hash map)
2387 password instead of releasing it.
2388 The password will now not be remembered if it is asked via the protected
2389 password dialog, as per the UI spec.
2391 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2393 * src/modest-defs.h:
2394 * src/modest-account-mgr-helpers.h:
2395 * src/modest-account-mgr-helpers.c:
2396 Added modest_server_account_get_username_has_succeeded(),
2397 modest_server_account_set_username_has_succeeded().
2398 (modest_server_account_set_username),
2399 Reset the has-succeeded flag if the username changes.
2401 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2402 * src/maemo/modest-connection-specific-smtp-window.c:
2403 (modest_connection_specific_smtp_window_save_server_accounts):
2404 Use modest_server_account_set_username() instead of using
2405 modest_conf_set_string() directly, so that the has-succeeded flag is always
2408 * src/modest-ui-actions.c:
2409 (modest_ui_actions_on_password_requested): Dim the username entry if
2410 the username has ever worked, as per the UI spec.
2412 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2414 * src/modest-tny-account-store.c: (get_password):
2415 * src/modest-ui-actions.c:
2416 (modest_ui_actions_on_password_requested):
2417 Allow the username to be changed too, though there is more work to
2418 be done on exactly how this behaves.
2420 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2422 * src/modest-account-mgr-helpers.h:
2423 * src/modest-account-mgr-helpers.c:
2424 Added modest_account_mgr_get_display_name(),
2425 modest_server_account_get_username(),
2426 modest_server_account_set_username(),
2427 modest_server_account_set_password(),
2428 modest_server_account_get_hostname() functions so we do not need to
2429 use the conf API directly.
2431 * src/maemo/modest-main-window.c: (connect_signals):
2432 Actually connect ot the ModestAccountStore::request-password signal,
2433 so that we show the dialog when the password is requested by Tinymail,
2434 for isntance if it is empty.
2436 * src/modest-marshal.list:
2437 * src/modest-tny-account-store.c:
2438 (modest_tny_account_store_class_init), (get_password),
2439 (modest_tny_account_store_alert):
2440 * src/modest-tny-account-store.h:
2441 * src/modest-ui-actions.h:
2442 * src/modest-ui-actions.c:
2443 (modest_ui_actions_on_password_requested):
2444 Change the signal parameters, so it is obvious that we are providing
2445 the non human-readable server name, and receiving both the username
2446 and password, though changing of the username is not yet implemented.
2447 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2448 for the GNOME version.
2450 This should fix the projects.maemo.org bug NB#56209, though it does not
2451 work on Bora, because the gconf_client_get() for the password fails
2452 immediately after we save it with gconf_client_set().
2454 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2457 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2458 caused an undefined symbol error:
2459 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2461 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2463 * src/modest-tny-account-store.c:
2464 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2465 using a GError instead of a string message, so we can translate it in
2468 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2470 * src/maemo/modest-address-book.c:
2471 (modest_address_book_check_names):
2472 * src/maemo/modest-msg-view-window.c:
2473 (modest_msg_view_window_clipboard_owner_change):
2474 * src/modest-init.c: (modest_init_init_ui):
2475 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2476 (update_folders_cb), (modest_mail_operation_update_account):
2477 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2478 (modest_ui_actions_on_msg_attachment_clicked),
2479 (modest_ui_actions_on_msg_recpt_activated):
2480 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2481 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2482 (modest_msg_view_search_next):
2483 * src/widgets/modest-recpt-editor.c:
2484 (modest_recpt_editor_on_button_release_event),
2485 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2486 g_message(). At this point we should only be seeing interesting errors on
2487 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2489 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2491 (modest_wizard_dialog_force_title_update):
2492 * src/maemo/easysetup/modest-wizard-dialog.h:
2493 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2494 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2495 can update the title when appropriate. Otherwise the title is wrong if the
2496 pages are added after adding the notebook to the dialog.
2497 This must be a problem in HildonWizardDialog too.
2498 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2500 * src/maemo/easysetup/modest-easysetup-wizard.c:
2501 (create_subsequent_customsetup_pages),
2502 (create_subsequent_easysetup_pages):
2503 Call modest_wizard_dialog_force_title_update() so that the title is
2504 correct even with GTK+ < 2.10.
2505 This fixes projects.maemo.org bug NB#56145 .
2507 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/modest-platform.c:
2510 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2511 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2514 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2516 * src/widgets/modest-window.h:
2517 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2518 and modest_window_save_state(), which invokes it.
2520 * src/widgets/modest-window-mgr.h:
2521 * src/widgets/modest-window-mgr.c:
2522 Added modest_window_mgr_save_state_for_all_windows(), which calls
2523 the save_state vfunc on all registered windows, if implemented.
2525 * src/gnome/modest-msg-edit-window.c:
2526 * src/gnome/modest-msg-view-window.c:
2527 * src/maemo/modest-msg-edit-window.c:
2528 * src/maemo/modest-msg-view-window.c:
2529 * src/maemo/modest-main-window.c:
2530 Specify the existing save_settings functions as implementations of
2531 ModestWindow::save_state_func().
2533 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2534 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2535 enabling hibernation, for instance.
2537 We may need to do the same thing for restoring settings.
2540 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2542 * src/widgets/modest-window-mgr.c:
2543 * src/widgets/modest-window-mgr.h:
2544 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2545 modest_window_mgr_get_hibernation_is_prevented().
2547 * src/maemo/modest-main-window.c:
2548 (on_hildon_program_is_topmost_notify): Prevent hibernation
2549 (possible when the application goes to the background in the WM),
2550 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2552 * src/maemo/easysetup/modest-easysetup-wizard.c:
2553 (modest_easysetup_wizard_dialog_init):
2554 * src/maemo/modest-account-settings-dialog.c:
2555 (modest_account_settings_dialog_init):
2556 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2557 (modest_connection_specific_smtp_edit_window_init):
2558 * src/maemo/modest-connection-specific-smtp-window.c:
2559 (modest_connection_specific_smtp_window_init):
2560 * src/maemo/modest-signature-editor-dialog.c:
2561 (modest_signature_editor_dialog_init):
2562 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2563 prevent hibernation while any of these account settings dialogs are open.
2565 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2567 * src/maemo/Makefile.am:
2568 * src/maemo/modest-osso-state-saving.c:
2569 * src/maemo/modest-osso-state-saving.h: Added
2570 modest_osso_load_state() and modest_osso_save_state() though they do
2571 nothing now. They should iterate through all the open windows and load/save
2573 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2574 save state when closing.
2576 * src/maemo/modest-main-window.c:
2577 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2578 Add a notification handler for the HildonProgram::is-topmost property,
2579 so we can allow hibernation when the application goes into the background.
2580 But we still need to detect when the accounts setup windows are open so
2581 we can stop hibernation when they are open.
2582 To do this, I also added the main window the HildonProgram. This might have
2583 other side-effects/benefits, and should maybe be done for other windows.
2585 * src/maemo/modest-osso-autosave-callbacks.h:
2586 * src/maemo/modest-osso-autosave-callbacks.c:
2587 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2588 though it does not do anything yet, and we might never need this to do
2589 anything. For instance, we already save drafts.
2591 * src/maemo/modest-platform.c: (modest_platform_init):
2592 Specify the libosso auto-save callback.
2594 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2596 * src/maemo/modest-platform.c:
2597 (modest_platform_set_update_interval):
2598 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2599 aparently stays valid between application instances, so we can use this
2600 to remove and reset it later. According to a maemo-developers email from
2603 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2605 * configure.ac: Depend on libalarm for Maemo.
2607 * src/dbus_api/modest-dbus-api.h:
2608 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2609 (on_send_receive), (modest_dbus_req_handler):
2610 Handle a SEND_RECEIVE D-Bus method.
2612 * libmodest-dbus-client/libmodest-dbus-client.c:
2613 (libmodest_dbus_client_send_and_receive):
2614 * libmodest-dbus-client/libmodest-dbus-client.h:
2615 Add C convenience functions for calling the new D-Bus method.
2617 * src/modest-platform.h:
2618 * src/gnome/modest-platform.c:
2619 * src/maemo/modest-platform.c:
2620 Added modest_platform_set_update_interval(), which uses the
2621 alarmd API on Maemo.
2622 (modest_platform_init),
2623 Call modest_platform_set_update_interval(), using a hard-coded
2624 interval for now (until the global settings dialog is implemented),
2625 though I am not sure that this makes sense yet.
2627 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2629 * src/dbus_api/modest-dbus-callbacks.c:
2630 (modest_osso_cb_hw_state_handler):
2631 * src/dbus_api/modest-dbus-callbacks.h:
2632 * src/maemo/modest-platform.c: (modest_platform_init):
2633 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2634 in case this has some effect on the ability for Maemo to ping the
2637 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2639 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2640 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2641 warning. It is probably a logic error, but I need to fix the build.
2643 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2645 * src/modest-account-mgr.h:
2646 * src/modest-account-mgr.c:
2647 (modest_account_mgr_account_names): Add a gboolean enabled_only
2648 parameter, so we can get lists of onlt the enabled accounts.
2650 (modest_account_mgr_add_account),,
2651 (modest_account_mgr_account_with_display_name_exists):
2652 * src/maemo/modest-msg-edit-window.c: (get_transports):
2653 * src/modest-account-mgr-helpers.c:
2654 (modest_account_mgr_set_first_account_as_default):
2655 * src/modest-init.c: (init_default_account_maybe):
2656 * src/modest-tny-account-store.c: (get_accounts):
2657 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2658 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2659 * tests/check_account-mgr.c: (START_TEST):
2660 Provide the extra parameter, as appropriate.
2662 * src/widgets/modest-account-view.c: (update_account_view):
2663 Do not show disabled accounts (meaning that there is no way to
2664 enable/disable accounts in the UI (the feature is not in our UI
2665 specification), so we can use this internally only to mark unfinished
2666 or temporary account data.
2668 * src/maemo/easysetup/modest-easysetup-wizard.c:
2669 (create_account): Add boolean enable parameter, so we can specify FALSE
2670 to create the temporary account.
2671 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2672 (on_before_next): When finishing, when there is a temporary account, just
2674 Also, use a timeout to delay the showing of the dialog until gconf is likely
2675 to return correct information, due to a maemo gconf bug that is fixed in
2676 osso 1.1, but not yet in Bora.
2677 However, the dialog stays on screen after it is destroyed.
2679 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2680 for invalid data when cancelling. Use a hildon note instead of a dialog
2681 to complain about invalid data. Do not show the account-saved note if the
2682 account is disabled (a temporary account that will not really be saved for use
2685 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2687 * src/modest-account-mgr-helpers.h:
2688 * src/modest-account-mgr-helpers.c:
2689 Added modest_account_mgr_unset_default_account(),
2690 Added modest_account_mgr_set_first_account_as_default().
2692 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2693 If it was the default account, unset the default account name.
2695 * src/maemo/modest-account-view-window.c:
2696 (on_delete_button_clicked): If it was the default account,
2697 set the first remaining account as the default instead.
2699 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2700 a NULL account or a NULL default account, to prevent a crash. This should
2701 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2704 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2706 * src/widgets/modest-recpt-editor.c:
2707 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2708 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2709 TODO comment for this. This fixes the build.
2711 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2712 be the best place for it. This will in future update all auto-update accounts,
2713 rather than just the current/default account, when that gconf key exists.
2714 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2715 if there are no accounts, before calling do_send_receive().
2716 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2718 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2719 * src/maemo/modest-main-window-ui.h:
2720 * src/maemo/modest-main-window.c: (on_connection_changed),
2721 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2722 directly, becaue the signal handler does more.
2724 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2726 * src/modest-account-mgr-helpers.c:
2727 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2728 for the case that the account does not exist.
2730 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2731 (equivalent to the modest account name) rather than the tinymail account name
2732 (equivalent to the modest account title - human readable) to get the account data.
2733 Check for null account data to prevent the crash, and add a TODO comment saying that
2734 this needs fixing because it is using the server account name instead of the account name.
2736 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2738 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2739 * src/maemo/modest-account-settings-dialog.c: (show_error),
2741 Use hildon_note_new_information() for informative and error messages,
2742 which seems to be expected for Maemo applications (no documentation that I know of
2743 says this). I am surprised that there is no distinction between info and error
2746 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2748 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2749 it is easy to find where this is used.
2751 * src/maemo/easysetup/modest-easysetup-wizard.c:
2752 (create_page_welcome), (create_page_account_details),
2753 (create_page_user_details), (create_page_complete_easysetup),
2754 (create_page_custom_incoming), (create_page_custom_outgoing),
2755 (create_page_complete_custom):
2756 * src/maemo/modest-account-settings-dialog.c:
2757 (create_page_account_details), (create_page_user_details),
2758 (create_page_incoming), (create_page_outgoing):
2759 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2760 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2761 (modest_connection_specific_smtp_edit_window_init):
2762 * src/maemo/modest-connection-specific-smtp-window.c:
2763 (modest_connection_specific_smtp_window_init):
2764 * src/maemo/modest-signature-editor-dialog.c:
2765 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2766 and scrolling policy as per the Email Application Layout Guide, if I have
2769 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2771 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2772 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2773 which were empty, because these vfuncs have been removed from TnyAccountStore.
2774 This fixes the build.
2776 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2778 * src/maemo/modest-main-window.c:
2779 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2780 showing/hiding it. Added TODO because it probably should not be NULL.
2781 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2782 because unnecessary g_warnings() make degugging difficult.
2784 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2786 * src/maemo/modest-msg-edit-window.c:
2787 (modest_msg_edit_window_select_color),
2788 (modest_msg_edit_window_select_background_color): 2 const corrections and
2789 moving 2 #endifs before closing brackets, to fix the build.
2791 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2793 * src/maemo/easysetup/modest-easysetup-wizard.h:
2794 * src/maemo/easysetup/modest-easysetup-wizard.c:
2795 (modest_easysetup_wizard_dialog_finalize),
2796 (on_button_edit_advanced_settings), (create_page_complete_custom),
2797 (on_response), (create_account):
2798 Implement the Advanced Settings edit button, by saving the account information,
2799 for the Advanded Settings dialog to use directly from gconf, and removing it
2800 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2801 Bug #5533 in the projects.maemo.org bugzilla.
2803 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2805 * src/maemo/modest-msg-view-window.c:
2806 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2807 when opening a message window.
2809 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/easysetup/modest-easysetup-wizard.c:
2812 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2815 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2816 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2817 gconf settings. I probably added more checks than necessary, but that is safer.
2819 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2820 variable to fix the build, but this seems to be used when it is still NULL.
2822 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2824 * src/modest-platform.h:
2825 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2826 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2827 * src/modest-main.c: Implement this function so we can avoid using
2828 maemo-specific API from cross-platform code.
2830 * src/modest-tny-account-store.c:
2831 (get_smtp_specific_transport_account_for_open_connection):
2832 * src/modest-ui-actions.c: (check_for_connection),
2833 (modest_ui_actions_on_item_not_found):
2834 Use modest_platform_connect_and_wait() and put #idefs around other
2835 maemo-specific code, because only maemo currently has a way to
2836 identify connection names.
2838 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2840 * src/modest-tny-account-store.h:
2841 * src/modest-tny-account-store.c:
2842 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2843 the connection-specific SMTP server settings in the configuration.
2845 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2847 * src/maemo/modest-main-window.c: (on_connection_changed),
2849 * src/modest-main.c: (main), (start_ui), (send_mail):
2850 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2851 that is what is intended.
2853 * src/modest-ui-actions.c: (action_send), (action_receive),
2854 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2855 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2856 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2857 SMTP server is used when it is specified.
2859 (modest_ui_actions_on_send_receive):
2860 Check that a connection is open before proceeding.
2861 Receive and then send, instead of vice-versa, as per the specification.
2863 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2865 * src/modest-mail-operation.c:
2866 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2867 though I guess it should be something other than NULL.
2869 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2871 * src/maemo/easysetup/modest-easysetup-wizard.c:
2872 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2873 combo twice, to avoid an g_warning and to make it visible again.
2874 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2875 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2876 (already intended) dereference when detaching, because we then recreate the menu.
2877 But I am not sure why the warning was happening, and it is possible that this is a memory
2880 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2882 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2883 and uri_parse_mailto() utility functions.
2884 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2886 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2888 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2890 * src/dbus_api/modest-dbus-api.h:
2891 * src/dbus_api/modest-dbus-callbacks.c:
2892 Use an idle callback to execute the modest code in the application's own thread.
2893 Remove the helloworld example method.
2894 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2895 parsed, and the open-message method is not implemented because this is not yet implemented in
2897 * libmodest-dbus-client/libmodest-dbus-client.c:
2898 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2899 (libmodest_dbus_client_open_message):
2900 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2902 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2903 body without crashing.
2905 * tests/dbus_api/Makefile.am:
2906 * tests/dbus_api/test_mail_to.c:
2907 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2909 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2911 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2912 Added file to fix the build. Sorry.
2914 * src/dbus_api/Makefile.am:
2915 * src/dbus_api/modest-dbus-api.h:
2916 * src/dbus_api/modest-dbus-callbacks.h:
2917 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2918 (modest_dbus_req_handler):
2919 Put constants in a separate header so it can be reused by the
2920 client library, without duplication
2922 * libmodest-dbus-client/Makefile.am:
2923 * libmodest-dbus-client/libmodest-dbus-client.c:
2924 (libmodest_dbus_client_call_helloworld),
2925 (libmodfest_dbus_client_send_mail),
2926 (libmodfest_dbus_client_mailto),
2927 (libmodfest_dbus_client_open_message):
2928 * libmodest-dbus-client/libmodest-dbus-client.h:
2929 (Partly) Implement a send_mail D-Bus method.
2931 * tests/dbus_api/Makefile.am:
2932 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2933 the send_email D-Bus method.
2935 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2939 * libmodest-dbus-client/Makefile.am:
2940 * libmodest-dbus-client/libmodest-dbus-client.c:
2941 * libmodest-dbus-client/libmodest-dbus-client.h:
2942 * tests/dbus_api/Makefile.am:
2943 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2944 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2946 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2948 * src/maemo/easysetup/modest-easysetup-wizard.c:
2949 (create_page_account_details):
2950 * src/maemo/modest-account-settings-dialog.c:
2951 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2952 widgets, because this might not be the default in future versions of the Maemo GTK+.
2953 However, I can not not get capitalization to work even in a simple test case.
2955 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2957 * src/maemo/easysetup/modest-easysetup-wizard.c:
2958 (create_page_custom_incoming), (create_page_custom_outgoing):
2959 * src/maemo/modest-account-settings-dialog.c:
2960 (create_page_account_details), (create_page_incoming),
2961 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2962 instead of using gtk_check_button_with_label(), so they are aligned like the other
2963 widgets, as per the UI spec.
2965 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/easysetup/modest-easysetup-wizard.c:
2968 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2969 * src/widgets/modest-validating-entry.c:
2970 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2971 Modest prefix instead of an EasySetup prefix.
2973 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2975 * src/widgets/modest-validating-entry.h:
2976 * src/widgets/modest-validating-entry.c: (on_insert_text),
2977 Added easysetup_validating_entry_set_max_func(), used to set a callback
2978 to call when the max number of characters is reached. GtkEntry has a max-length
2979 already but is silent about it.
2981 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2982 (create_page_account_details), (create_page_user_details),
2984 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2985 (create_page_account_details), (create_page_user_details),
2986 (create_page_outgoing):
2987 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2988 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2989 the UI spec, when the user tries to enter more than the max number of characters.
2991 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2993 * src/maemo/easysetup/modest-easysetup-wizard.c:
2994 (create_page_user_details), (create_page_custom_incoming),
2995 (create_page_custom_outgoing):
2996 * src/maemo/modest-account-settings-dialog.c:
2997 (create_page_user_details), (create_page_incoming),
2998 (create_page_outgoing):
2999 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3000 (modest_connection_specific_smtp_edit_window_init):
3001 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3002 not appropriate. Bad Maemo-specific defaults!.
3004 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3006 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3007 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3008 (modest_signature_editor_dialog_set_settings):
3009 Disable the label and textview when the checkbox is disabled, and use the
3010 specified (UI spec) default signature text.
3012 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3014 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3015 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3017 * src/modest-defs.h:
3018 * src/modest-account-mgr-helpers.h:
3019 * src/modest-account-mgr-helpers.c:
3020 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3022 * src/maemo/Makefile.am:
3023 * src/maemo/modest-signature-editor-dialog.c:
3024 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3027 * src/maemo/modest-account-settings-dialog.h:
3028 * src/maemo/modest-account-settings-dialog.c:
3029 (modest_account_settings_dialog_finalize), (on_button_signature),
3030 (save_configuration): Use the new dialog when the Edit button is pressed, and
3031 save the changes if necessary, as per the UI spec.
3033 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3035 * src/maemo/Makefile.am:
3036 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3037 based on maemo-develoers email from Dirk.
3039 * src/maemo/easysetup/modest-easysetup-wizard.c:
3040 (create_page_welcome), (create_page_account_details),
3041 (create_page_user_details), (create_page_complete_easysetup),
3042 (create_page_custom_incoming), (create_page_custom_outgoing),
3043 (create_page_complete_custom),
3044 (modest_easysetup_wizard_dialog_init):
3045 * src/maemo/modest-account-settings-dialog.c:
3046 (create_page_account_details), (create_page_user_details),
3047 (create_page_incoming), (create_page_outgoing),
3048 (modest_account_settings_dialog_init):
3049 * src/maemo/modest-connection-specific-smtp-window.c:
3050 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3052 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3054 * src/maemo/easysetup/modest-easysetup-wizard.c:
3055 (create_page_account_details), (create_page_custom_outgoing),
3056 (create_page_complete_custom):
3057 * src/maemo/modest-account-settings-dialog.c:
3058 (create_page_user_details), (create_page_incoming),
3059 (create_page_outgoing):
3060 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3061 (modest_connection_specific_smtp_edit_window_init):
3062 Use the correct (UI spec) port min/max, and use horizontal separators,
3065 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3067 * src/maemo/easysetup/modest-easysetup-wizard.c:
3068 (set_default_custom_servernames):
3069 * src/maemo/modest-account-settings-dialog.c:
3070 (create_page_incoming), (on_combo_outgoing_security_changed),
3071 (on_combo_incoming_security_changed), (create_page_outgoing),
3072 (modest_account_settings_dialog_set_account_name),
3073 (save_configuration):
3074 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3075 (on_combo_security_changed),
3076 (modest_connection_specific_smtp_edit_window_init),
3077 (modest_connection_specific_smtp_edit_window_set_connection),
3078 (modest_connection_specific_smtp_edit_window_get_settings):
3079 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3082 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3085 * src/maemo/easysetup/modest-easysetup-wizard.c:
3086 (create_page_custom_outgoing), (create_page_complete_custom):
3087 * src/maemo/modest-account-settings-dialog.c:
3088 (create_page_user_details), (create_page_outgoing):
3089 * src/maemo/modest-account-view-window.c: (button_box_new):
3090 Use changed logical IDs as per the most recent UI spec:
3091 mcen_bd_emailsetup_edit -> mcen_bd_edit
3092 mcen_bd_emailsetup_delete -> mcen_bd_delete
3093 mcen_bd_emailsetup_close -> mcen_bd_close
3095 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3099 * src/dbus_api/Makefile.am:
3100 * src/dbus_api/modest-dbus-callbacks.c:
3101 * src/dbus_api/modest-dbus-callbacks.h:
3102 * src/maemo/modest-platform.c: (modest_platform_init):
3103 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3105 * tests/Makefile.am:
3106 * tests/dbus_api/Makefile.am:
3107 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3109 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3111 * src/maemo/modest-account-settings-dialog.c:
3112 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3113 Removed unnecessary includes.
3115 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3117 * src/maemo/easysetup/modest-easysetup-wizard.c:
3118 * src/maemo/modest-account-settings-dialog.c:
3119 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3120 * src/widgets/Makefile.am:
3121 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3122 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3123 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3124 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3125 * src/widgets/modest-secureauth-combo-box.c:
3126 * src/widgets/modest-secureauth-combo-box.h:
3127 * src/widgets/modest-serversecurity-combo-box.c:
3128 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3129 made the GObject names more consistent with the rest of the Modest code.
3131 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3133 * src/maemo/easysetup/Makefile.am:
3134 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3135 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3136 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3137 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3138 * src/maemo/easysetup/modest-easysetup-wizard.c:
3139 * src/maemo/easysetup/modest-validating-entry.c:
3140 * src/maemo/easysetup/modest-validating-entry.h:
3141 * src/maemo/modest-account-settings-dialog.c:
3142 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3143 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3144 widgets/ because they are used outside of easysetup too. After checking in,
3145 svn will allow me to rename them too.
3147 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3149 * src/gnome/modest-msg-edit-window.c:
3150 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3151 linker error, to fix the build on the GNOME platform.
3152 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3153 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3154 ifdefed out to avoid a warning.
3156 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3158 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3159 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3160 some alternative for GTK+ 2.6.
3162 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3164 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3166 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3167 specified for EmailAccountsDialog in UI spec.
3169 * src/maemo/easysetup/modest-easysetup-wizard.c:
3170 * src/maemo/easysetup/modest-easysetup-wizard.h:
3171 * src/maemo/modest-account-settings-dialog.c:
3172 * src/maemo/modest-account-settings-dialog.h:
3173 Reuse a member window widget for the connection-specific SMTP server accounts,
3174 so we can tell it to create/save the accounts only if we actually save changes.
3176 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3177 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3178 (modest_connection_specific_smtp_edit_window_get_settings):
3179 Return a struct instance for temporarily remembering the entered data.
3181 * src/maemo/modest-connection-specific-smtp-window.h:
3182 * src/maemo/modest-connection-specific-smtp-window.c:
3183 (modest_connection_specific_smtp_window_finalize),
3184 (modest_connection_specific_smtp_window_fill_with_connections),
3186 (modest_connection_specific_smtp_window_save_server_accounts),
3187 (update_model_server_names): Do not actually save data until asked,
3188 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3190 (on_selection_changed),
3191 (modest_connection_specific_smtp_window_init): Disable the edit
3192 button when nothing is selected.
3194 * src/modest-account-mgr-helpers.c:
3195 * src/modest-account-mgr-helpers.h:
3196 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3199 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3201 * src/modest-account-mgr-helpers.h:
3202 * src/modest-account-mgr-helpers.c:
3203 (modest_account_mgr_get_unused_account_name),
3204 (modest_account_mgr_get_unused_account_display_name): Added these
3205 utility functions, to avoid code duplication.
3207 * src/maemo/easysetup/modest-easysetup-wizard.c:
3208 (create_page_account_details), (create_account):
3209 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3210 (on_combo_security_changed),
3211 (modest_connection_specific_smtp_edit_window_init),
3212 (modest_connection_specific_smtp_edit_window_save_settings):
3213 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3214 * src/maemo/modest-connection-specific-smtp-window.c:
3215 (modest_connection_specific_smtp_window_finalize),
3216 (modest_connection_specific_smtp_window_fill_with_connections),
3217 (on_button_edit), (modest_connection_specific_smtp_window_init):
3218 * src/maemo/modest-connection-specific-smtp-window.h:
3219 Implementing saving of connection-specific server accounts.
3221 But I need to refactor this so we can save the data for each
3222 possible connection-specific account and only actually create the server accounts
3223 when the easysetup finished, or the OK button is pressed on the account settings
3226 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3228 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3229 (on_combo_security_changed):
3230 (modest_connection_specific_smtp_edit_window_init):
3231 Auto-fill the port number as in the account settings.
3233 (modest_connection_specific_smtp_edit_window_set_connection):
3234 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3235 * src/maemo/modest-connection-specific-smtp-window.c:
3236 (fill_with_connections), (on_button_edit),
3237 (modest_connection_specific_smtp_window_init):
3238 Turn the edit window into a dialog to simplify the code, and
3239 set a WM hint as in a GtkDialog, because only a popup can be on top of
3240 another window in Maemo, and popups usually have no WM decoration.
3242 * src/modest-defs.h:
3243 * src/modest-account-mgr-helpers.c:
3244 (modest_account_mgr_set_connection_specific_smtp),
3245 (modest_account_mgr_remove_connection_specific_smtp),
3246 (modest_account_mgr_get_connection_specific_smtp):
3247 * src/modest-account-mgr-helpers.h: Some functions to write the
3248 connection-specific SMTP server information. Not yet used.
3251 * src/widgets/modest-folder-view.c: (text_cell_data):
3252 Fix a warning about an uninitialized variable.
3253 (on_configuration_key_changed): Put an #ifdef around the use
3254 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3256 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3258 * src/maemo/modest-account-settings-dialog.h:
3259 * src/maemo/modest-account-settings-dialog.c:
3260 Added connect_for_modified() utility function to mark the new modified boolean.
3262 (create_page_account_details), (create_page_user_details),
3263 (create_page_incoming), (create_page_outgoing), (on_response),
3264 (modest_account_settings_dialog_init),
3265 (modest_account_settings_dialog_set_account_name):
3266 Only warn about unsaved changes when there are actually unsaved changes.
3268 * src/modest-account-mgr-helpers.c:
3269 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3270 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3271 to get the data from there in future.
3273 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3275 * src/modest-defs.h:
3277 * src/modest-account-mgr-helpers.h:
3278 * src/modest-account-mgr-helpers.c:
3279 Store the security account setting in a single conf key instead of using
3280 the options list, so that the list is left for just the to-be-removed camel hack,
3281 and because gconf_client_set_list() is failing for some reason.
3283 * src/modest-account-mgr.c:
3284 (modest_account_mgr_add_server_account):
3285 * src/maemo/modest-account-settings-dialog.c:
3286 (modest_account_settings_dialog_set_account_name),
3287 (save_configuration): Use the renamed functions.
3290 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3292 * src/widgets/Makefile.am:
3293 * src/widgets/modest-limit-retrieve-combo-box.c:
3294 * src/widgets/modest-limit-retrieve-combo-box.h:
3295 * src/widgets/modest-retrieve-combo-box.c:
3296 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3297 the account settings dialog.
3299 * src/modest-defs.h:
3300 * src/modest-account-mgr-helpers.h:
3301 * src/modest-account-mgr-helpers.c:
3302 (modest_server_account_get_option_secure_auth),
3303 (modest_server_account_set_option_secure_auth):
3304 * src/modest-account-mgr.c:
3305 (modest_account_mgr_add_server_account):
3306 Use the existing AUTH_MECH conf key for the secure-auth setting,
3307 instead of putting it in the list options, because this was actually used already.
3309 * src/maemo/modest-account-settings-dialog.c:
3310 (create_page_account_details),
3311 (modest_account_settings_dialog_set_account_name),
3312 (save_configuration):
3313 * src/maemo/modest-account-settings-dialog.h:
3314 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3315 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3317 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3319 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3320 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3321 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3323 * src/modest-defs.h:
3324 * src/maemo/modest-account-settings-dialog.c:
3325 (create_page_incoming), (on_combo_outgoing_security_changed),
3326 (on_combo_incoming_security_changed), (create_page_outgoing),
3327 (modest_account_settings_dialog_set_account_name),
3328 (save_configuration): Load/Save the port number, and change it when the
3329 security combo changes, to suitable defaults.
3331 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3333 * src/modest-account-mgr.c:
3334 (modest_account_mgr_add_server_account): Set the security and secure-auth
3335 options, and add a comment saying that the other camel-specific options should be
3338 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3340 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3342 * src/modest-tny-account-store.c: (account_list_free),
3343 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3344 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3347 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3349 * src/modest-protocol-info.c:
3350 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3351 is required by our UI spec. Maybe something in our implementation will use this eventually.
3352 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3353 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3354 instead of the previous 0 placeholder.
3356 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3357 secure-auth settings.
3358 * src/modest-account-mgr-helpers.h:
3359 * src/modest-account-mgr-helpers.c:
3360 (modest_server_account_data_get_option_secure_auth),
3361 (modest_server_account_set_option_secure_auth),
3362 (modest_server_account_data_get_option_security),
3363 (modest_server_account_set_option_security): Added this API for getting and setting the security
3364 and secure-auth settings.
3366 * src/maemo/modest-account-settings-dialog.h:
3367 * src/maemo/modest-account-settings-dialog.c:
3368 (modest_account_settings_dialog_finalize), (check_data),
3369 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3370 about changing titles.
3371 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3372 (save_configuration): Save the security and secure-auth settings.
3374 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3375 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3377 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3379 * src/modest-defs.h:
3380 * src/modest-account-mgr.c:
3381 (modest_account_mgr_add_server_account):
3382 Added and used defines for the options key and value pair strings,
3383 that are used so far, though they do not seem to correspond to anything in our
3384 UI specs or ModestProtocol enum.
3386 * src/modest-account-mgr-helpers.h:
3387 * src/modest-account-mgr-helpers.c:
3388 (compare_option_strings_for_name),
3389 (modest_server_account_data_get_option_value),
3390 (modest_server_account_data_get_option_bool),
3391 (modest_account_mgr_get_server_account_option):
3392 Added helper functions for parsing the options GSList.
3394 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3396 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3397 display name is based on the supplied account name.
3398 * src/modest-account-mgr.c:
3399 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3400 with an inefficient, but good-enough, implementation.
3402 * src/maemo/easysetup/modest-easysetup-wizard.c:
3403 (create_page_account_details), (on_before_next), (create_account):
3404 Check for existing display names rather than (non-user-visible) account names, and just
3405 create and set a unique account name at the end.
3407 * src/maemo/modest-account-settings-dialog.c:
3408 (modest_account_settings_dialog_init),
3409 (modest_account_settings_dialog_set_account_name),
3410 (create_page_incoming): Show the display name, instead of the account name.
3411 (on_response): Do some (not all) extra checks, as in the UI spec.
3412 (save_configuration): Save the display name if it was changed.
3414 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3416 * po/en_GB.po: Added needed logical ID and translation.
3417 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3418 (init_view): Made the is-default column clicking work.
3420 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3423 * src/maemo/easysetup/Makefile.am:
3424 * src/maemo/easysetup/modest-easysetup-wizard.c:
3425 (modest_easysetup_wizard_dialog_init):
3426 * src/maemo/easysetup/provider-data-test.keyfile:
3427 * src/maemo/easysetup/provider-data.keyfile:
3428 Moved the provider data file to the new modest-providers-data package and used it from there.
3430 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3432 * src/modest-local-folder-info.c:
3433 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3434 N_() was already used on the static strings, but this just marks it for translation without
3435 using the translation.
3437 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3439 * src/maemo/modest-account-settings-dialog.c:
3440 (create_page_incoming),
3441 (modest_account_settings_dialog_set_account_name):
3442 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3443 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3444 I will do this if nobody else gets there first.
3446 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3448 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3449 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3450 save the security stuff.
3452 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3455 Set the email address and user fullname, which I now see must be
3458 * src/maemo/modest-account-settings-dialog.h:
3459 * src/maemo/modest-account-settings-dialog.c:
3461 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3462 leave-on-server and authentication.
3463 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3466 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3469 * src/maemo/modest-account-settings-dialog.c:
3470 * src/maemo/modest-account-settings-dialog.h:
3471 Most (but not all) of the widgets are now present as specified by the UI spec.
3472 No changes are yet saved, and some details are not properly shown yet.
3474 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3476 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3478 * src/maemo/Makefile.am:
3479 * src/maemo/modest-account-settings-dialog.c:
3480 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3481 an existing account. Doesn't do much yet.
3483 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3484 Open the accounts settings dialog when Edit is clicked.
3486 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3488 * src/maemo/easysetup/Makefile.am:
3489 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3491 * src/maemo/easysetup/modest-easysetup-wizard.c:
3492 (modest_easysetup_wizard_dialog_init):
3493 Try to get the source directory from the build system,
3494 instead of hard-coding "./" into the source code, when opening our local
3495 copies of the configuration files.
3496 But this still fails when opening the wizard from the Accounts window,
3497 maybe because the working directory seems to change at runtime.
3498 So the wizard will fail the second time unless you copy the files into their
3499 proper locations - see the stdout warnings for the paths.
3501 (create_page_account_details),(on_before_next):
3502 Check for existing non-server accounts instead of server accounts,
3503 so the default account name is useful again, and to prevent trying to
3506 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3507 Show the wizard when New is clicked.
3509 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3510 (init_view): Show the column headers, and show the columns that are
3511 specified in the UI specs. However, something in Maemo's GTK+ prevents
3512 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3513 change the default account. This is despite unsetting the special properties.
3515 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3517 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3518 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3519 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3520 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3521 to make that clearer.
3522 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3524 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/modest-account-view-window.c:
3527 (modest_account_view_window_init),
3528 (modest_account_view_window_new):
3529 Use the same buttons as specified in the
3530 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3531 the existing widgets, which never had a chance of working.
3532 Put the ModestAccountView treeview in a scrolled window.
3533 Do not repeat the initialization in both _init() and _new().
3535 * src/widgets/modest-account-view.c: (update_account_view):
3536 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3537 this widget and window shows no accounts.
3539 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3541 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3543 * src/maemo/easysetup/modest-easysetup-wizard.c:
3544 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3545 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3546 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3549 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3550 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3551 accounts exist yet, as in the UI spec.
3553 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3555 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3557 * src/maemo/Makefile.am:
3558 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3559 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3560 New window for editing connection-specific smtp details.
3561 Not fully implemented.
3563 * src/maemo/modest-connection-specific-smtp-window.c:
3564 (modest_connection_specific_smtp_window_finalize) :
3565 unref the tree model.
3566 (on_button_edit): Show the edit window.
3568 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3570 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3573 * src/maemo/Makefile.am:
3574 * src/maemo/modest-connection-specific-smtp-window.c:
3575 * src/maemo/modest-connection-specific-smtp-window.h:
3576 New window for showing the list of connections, for connection-specific
3577 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3578 * src/maemo/easysetup/modest-easysetup-wizard.c:
3579 (create_page_custom_outgoing): Show the new window when the button is clicked.
3581 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3583 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3584 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3585 * src/maemo/modest-msg-edit-window.c:
3586 (modest_msg_edit_window_insert_image):
3587 * src/modest-conf.c: (modest_conf_key_escape):
3588 * src/modest-mail-operation.c:
3589 (modest_mail_operation_send_new_mail):
3590 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3591 (modest_ui_actions_on_new_account):
3592 * src/widgets/modest-attachment-view.c: (update_filename_request):
3593 * src/widgets/modest-mail-header-view.c:
3594 Corrected warnings that were breaking the build, by commenting out unused variables,
3595 and a function, and by including a header.
3597 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3599 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3600 so we can #ifdef around platform-specific code when necessary.
3601 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3602 to allow this to build for the GNOME platform too.
3604 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3606 * src/maemo/easysetup/modest-easysetup-wizard.c:
3607 Added util_increment_name() and used it in create_page_account_details()
3608 to make sure that the default account name is always a new name.
3610 (modest_easysetup_wizard_dialog_init),
3611 (set_default_custom_servernames): Some minor memory management fixes.
3613 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3617 * src/modest-runtime.c: (init_i18n): Restored the translation
3618 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3619 are defined in config.h, and the translations are installed.
3621 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3622 is defined for translation.
3624 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3626 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3628 * src/maemo/easysetup/modest-easysetup-wizard.c:
3629 (modest_easysetup_wizard_dialog_init):
3630 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3631 Use realistic paths (though they should use $prefix generically) to the
3632 mcc_mapping and provider-data.keyfile files which might work when they
3633 are installed by the future version of the operator-wizard package,
3634 and then fallback to paths in our source code, with an explanatory
3637 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3641 * src/maemo/Makefile.am:
3642 * src/maemo/easysetup/: Added files from the previously-exernal
3643 osso-modest-easysetup.
3644 * src/maemo/modest-main-window-ui.h:
3645 * src/modest-ui-actions.c:
3646 * src/modest-ui-actions.h:
3647 Added modest_ui_actions_on_new_account() as a signal handler for the
3648 New Account menu item. It shows the easysetup wizard.
3649 * po/en_GB.po: Added additional needed logical IDs and translations.