1 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/widgets/modest-folder-view.c: (filter_row)
4 Do not show drafts folder (see UI specs)
6 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
8 * src/modest-ui-actions.c:
9 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
10 place and also not necessary.
12 * src/widgets/modest-folder-view.c: (filter_row)
13 Guess folder type and hide Sent & Outbox if necessary.
14 Fixed project.maemo.org NB#57328
16 2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
18 * src/modest-ui-actions.h:
19 * src/modest-ui-actions.c:
20 (modest_ui_actions_on_delete_message):
21 Move some code into a new
22 modest_ui_actions_refresh_message_window_after_delete()
23 function so we can use it from elsewhere.
25 * src/dbus_api/modest-dbus-callbacks.c:
26 (on_idle_delete_message), (on_delete_message): Used an idle
27 handler, as we do for the other D-Bus method handlers.
28 Call modest_ui_actions_refresh_message_window_after_delete()
29 if the deleted message was open in a window. This fixed
30 projects.maemo.org bug NB#62862.
32 2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
34 * src/modest-main.c: (main): Only show the UI at the start if
35 the showui command line option was given. For instance,
36 run-standalone src/modest showui
37 Otherwise, we wait for the top_application D-Bus method to
38 be sent by hildon-desktop when the application is selected
40 This allows us to run without a UI when osso-global-search
41 uses our D-Bus methods.
43 2007-07-11 Murray Cumming <murrayc@murrayc.com>
45 * src/dbus_api/modest-dbus-api.h: Added a define for a
46 top-application D-Bus method.
47 * src/dbus_api/modest-dbus-callbacks.c:
49 (modest_dbus_req_handler): Handle the top-application D-Bus
50 method, which might be an undocumented D-Bus signal sent by
51 hildon-desktop when it starts the application from the menu.
52 But I am not sure and I need to test it on the device, because
53 my scratchbox does not have the application in the menu now.
54 This method shows the main window, so that it can be invisible
55 when started, for instance, just for email searching from
58 * src/maemo/modest-main-window.c: (restore_settings),
59 (modest_main_window_new): Do not show the window immediately
60 upon creation. We show it later.
61 * src/modest-widget-memory.c: (save_settings_paned):
62 Try (unsuccessfully) to avoid saving the paned position when
63 it is not even visible.
64 (restore_settings_paned): Do not allow a silly paned position.
65 This seems necessary when not showing the window at first.
67 * tests/dbus_api/Makefile.am:
68 * tests/dbus_api/test_top_application.c: (main): Test for the
71 2007-07-10 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-ui-dimming-rules.c:
74 (modest_ui_dimming_rules_on_new_msg),
75 (modest_ui_dimming_rules_on_reply_msg),
76 (modest_ui_dimming_rules_on_delete_msg),
77 (modest_ui_dimming_rules_on_details),
78 (modest_ui_dimming_rules_on_view_window_move_to),
79 (modest_ui_dimming_rules_on_view_previous),
80 (modest_ui_dimming_rules_on_view_next),
81 (_invalid_folder_for_purge): Added checks before
82 casting the window. This looks like an actual
83 logic error in _invalid_folder_for_purge(), because it
84 tries to use a ModestMainWindow as a message window.
86 2007-07-10 Murray Cumming <murrayc@murrayc.com>
88 * src/maemo/modest-account-settings-dialog.c:
89 (show_error): Use the same implementation as in
90 modest-easysetup-wizard.c:
91 (on_entry_invalid_character): The logical ID contains a %s.
92 Guessed what it should be.
93 (on_entry_max), (check_data), (on_response): Adapt to
95 (create_page_account_details): Really call
96 modest_validating_entry_set_func() on the correct widgets.
97 * src/maemo/easysetup/modest-easysetup-wizard.c:
98 (on_entry_invalid_character): Fix the logical ID here too.
99 (create_page_account_details),
100 (create_page_user_details):
102 modest_validating_entry_set_func() on the correct widgets.
104 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
105 Do not try to use the account if it is NULL.
107 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
109 * src/modest-ui-actions.c: (create_move_to_dialog),
110 (modest_ui_actions_on_main_window_move_to),
111 (modest_ui_actions_on_msg_view_window_move_to):
112 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
113 (filter_row), (modest_folder_view_show_non_move_folders):
114 * src/widgets/modest-folder-view.h:
116 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
117 the Sent folder yet as it does not report the correct folder type.
119 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
121 * src/maemo/modest-msg-edit-window.c: (init_window):
124 2007-07-10 Murray Cumming <murrayc@murrayc.com>
126 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
127 Take a parent widget instead of a parent window, and
128 implement this with hildon_banner_show_information() instead.
129 Non-Maemo builds can just ifdef that there.
130 This fixed projects.maemo.org bug NB#62766.
132 (on_entry_invalid_character): Use show_error() again instead
133 of using hildon directly, and use the _CS() macro to use the correct
135 (create_account), (check_for_supported_auth_methods), (on_entry_max):
136 Pass a widget instead od a window to show_error().
138 2007-07-10 Murray Cumming <murrayc@murrayc.com>
140 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
141 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
142 This allows us to show the server name in the error message, fixing
143 projects.maemo.org bug NB#62904.
144 Also, use the appropriate logical ID message for the account protocol.
146 2007-07-10 Murray Cumming <murrayc@murrayc.com>
148 * src/modest-tny-account-store.c: (on_idle_wrong_password):
149 A compilation fix, though the build wasn't broken for me.
151 2007-07-09 Murray Cumming <murrayc@murrayc.com>
153 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
154 Do not try to unref a NULL folder store, to avoid a runtime warning.
155 This seems to happen sometimes when changing accounts settings.
157 2007-07-09 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-tny-account-store.c:
160 (modest_tny_account_store_instance_init),
161 (modest_tny_account_store_finalize),
162 (on_account_settings_hide), (on_idle_wrong_password):
163 Use a GHashTable to ensure that we only show one account settings
164 dialog per modest account. This avoids us having a dialog open for
165 both the store and transport accounts, or due to repeated get_password()
166 calls that shouldn't happen anyway.
168 2007-07-09 Murray Cumming <murrayc@murrayc.com>
170 * src/maemo/modest-maemo-utils.c: (on_hide),
171 (modest_maemo_show_dialog_and_forget): Handle the response, because
172 the window is not even hidden by default.
174 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
175 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
176 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
177 which seems to prevent some modality problems.
179 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
180 Ignore user cancellation errors.
182 * src/modest-account-mgr-helpers.h:
183 * src/modest-account-mgr-helpers.c:
184 Added modest_server_account_get_password() and
185 modest_server_account_get_has_password() to avoid direct use of
188 * src/maemo/modest-account-settings-dialog.h:
189 * src/maemo/modest-account-settings-dialog.c:
190 (modest_account_settings_dialog_init): Store the notebook so we can
192 Added modest_account_settings_dialog_switch_to_user_info().
194 * src/modest-tny-account-store.c:
195 (get_password): When the password in the account settings is wrong (we think),
196 show the relevant page of the account settings dialog, in the mainloop.
197 However, we currently get many of these at once because cancel does not
199 (forget_password): Do not forget the password
200 from the account settings, because this causes side-effects when
201 tinymail seems to call it at strange time, maybe because of how we
202 are cancelling get_password().
203 (modest_tny_account_store_alert): Ignore user cancellations.
205 2007-07-09 Murray Cumming <murrayc@murrayc.com>
207 * src/maemo/modest-maemo-utils.h:
208 * src/maemo/modest-maemo-utils.c:
209 Added modest_maemo_show_information_note_and_forget() for use instead of
210 gtk_dialog_run() when the response is not needed, to avoid an extra
211 mainloop which could cause a hang.
213 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
214 Use the logical IDs for the error message, though they are not
215 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
216 because gtk_dialog_run() caused a hang here (the window did not close).
217 This fixes projects.maemo.org bug NB#62646.
219 2007-07-09 Murray Cumming <murrayc@murrayc.com>
221 * src/modest-account-mgr-helpers.h:
222 * src/modest-account-mgr-helpers.c:
223 Added modest_account_mgr_get_store_protocol().
225 * src/maemo/modest-account-view-window.c:
226 (on_delete_button_clicked): Show different warning text depending on
227 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
228 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
231 2007-07-09 Murray Cumming <murrayc@murrayc.com>
233 * src/maemo/modest-msg-edit-window.c:
234 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
235 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
237 2007-07-07 Armin Burgmeier <armin@openismus.com>
239 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
240 ckdg_ib_maximum_characters_reached from correct package.
242 * src/modest-ui-actions.c: Show an error message when a folder could
243 not be created. Tinymail does not give us specific error codes about
244 what has gone wrong, so we assume that a folder with that name
245 already exists, though there might be other reasons.
247 2007-07-06 Murray Cumming <murrayc@murrayc.com>
249 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
250 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
251 give a more exact error message that can be partly translated.
253 2007-07-05 Murray Cumming <murrayc@murrayc.com>
255 * src/maemo/modest-address-book.c:
256 (select_email_addrs_for_contact): Specify a default window size for the
257 select-email-address dialog, so that it is probably big enough for the
258 title. This should fix projects.maemo.org bug NB#62277.
260 2007-07-05 Murray Cumming <murrayc@murrayc.com>
262 * src/maemo/easysetup/modest-easysetup-wizard.c:
263 (create_page_complete_easysetup): Use
264 gtk_widget_set_size() request to ensure that the text wraps
267 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
269 * src/maemo/easysetup/modest-easysetup-wizard.c:
270 (on_entry_invalid_character), (create_page_account_details),
271 (create_page_user_details):
272 Use new API of ModestValidatingEntry. But for some reason the banner is
273 not shown. I will have to investigate that further.
275 * src/widgets/modest-validating-entry.c: (on_insert_text),
276 (modest_validating_entry_set_func):
277 * src/widgets/modest-validating-entry.h:
278 Added a new callback function to be able to react to prevented
279 characters whitespaces to e.g show a banner.
281 2007-07-05 Armin Burgmeier <armin@openismus.com>
283 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
284 notification of HildonNumberEditor instead of remembering the port
285 number. Thanks to Johannes for pointing this out.
287 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
289 * src/maemo/easysetup/modest-easysetup-wizard.c:
290 Check if there are any user changes before showing a confirmation
291 dialog (projects.maemo.org NB#60946)
293 2007-07-05 Armin Burgmeier <armin@openismus.com>
295 * src/maemo/modest-account-settings-dialog.c: Remember custom port
296 number at the beginning of the dialog and set the modified flag at the
297 end if the port number has changed. This is necessary because
298 HildonNumberEditor does not support notification when the value has
301 2007-07-05 Murray Cumming <murrayc@murrayc.com>
303 * src/modest-ui-actions.c:
304 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
305 a connection before asking anything else. Correct the check for the destination
306 folder so that it succeeds when online.
307 This fixed projects.maemo.org bug NB#61645.
309 2007-07-05 Murray Cumming <murrayc@murrayc.com>
311 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
312 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
313 to fix projects.maemo.org bug NB#62439.
315 2007-07-05 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-tny-account.c: (on_connection_status_changed):
318 Really do not use tny_device_force_offline() here. See the previous comment.
320 2007-07-04 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-tny-account.c: (on_connection_status_changed):
323 Do not use tny_device_force_offline() when tinymail says that something
324 went wrong with the connection. It seems to report this unnecessarily.
326 2007-07-04 Murray Cumming <murrayc@murrayc.com>
328 * src/maemo/modest-connection-specific-smtp-window.c:
329 (modest_connection_specific_smtp_window_init):
330 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
331 does not seem to have any effect in osso 1.1 (though it works in
332 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
334 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
336 * src/maemo/modest-connection-specific-smtp-window.c:
337 Fix UI specification problems with projects.meamo.org NB#60479
339 2007-07-04 Murray Cumming <murrayc@murrayc.com>
341 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
342 clue when this has failed, because the error dialog is not always shown
343 (at least in earlier version).
345 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
346 GError message, because the generic error dialog is not helpful.
348 'This message is not currently available (can't let a new connection go online)'
349 when trying to open an IMAP message.
351 (_modest_ui_actions_open): Offer a connection when some messages would
352 have to be downloaded and we are offline.
354 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
356 * src/widgets/modest-folder-view.c:
357 Don't check for MERGE type anymore as we use the correct type
359 NOTE: For the last two changes you need to update your tinymail copy
360 because of API changes!
362 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
364 * src/modest-tny-local-folders-account.c:
365 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
366 (see projects.maemo.org NB#61580)
368 2007-07-04 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-tny-account.c: (on_connection_status_changed):
371 Commented out the call to modest_platform_connect_and_wait() because this
372 seems to always hang, and I would like to know if this is the only thing
373 that causes a hang when showing the connection dialog.
374 It is not very useful anyway.
376 2007-07-04 Murray Cumming <murrayc@murrayc.com>
378 * src/maemo/modest-msg-view-window.c:
379 (modest_msg_view_window_select_next_message):
381 * src/modest-platform.h:
382 * src/maemo/modest-platform.c:
383 Added modest_platform_connect_and_wait(), which calls
384 tny_maemo_conic_device_connect() always in the main thread, by calling it
385 in an idle handler and waiting for the idle handler to run. It should be
386 in the main thread because it uses GTK+ UI code. It just returns TRUE
387 if the device is already online.
389 There is some nasty code to ensure that subsequent calls to
390 modest_platform_connect_and_wait() just wait for the first one to finish,
391 by checking repeatedly in another idle handler. This is necessary,
392 because other threads (or even the main thread, via another idle handler)
393 can call modest_platform_connect_and_wait() while
394 modest_platform_connect_and_wait() is running.
396 (modest_platform_connect_and_wait_if_network_account),
397 (modest_platform_connect_and_wait_if_network_folderstore):
398 Convenience functions that calls modest_platform_connect_and_wait() if
399 the account or folder might want network access.
401 * src/modest-mail-operation.c:
402 (modest_mail_operation_update_account):
403 * src/modest-ui-actions.c: (download_uncached_messages),
404 (modest_ui_actions_on_rename_folder), (delete_folder),
405 (modest_ui_actions_on_main_window_move_to),
406 (modest_ui_actions_on_msg_view_window_move_to):
407 * src/widgets/modest-folder-view.c:
408 (drag_and_drop_from_folder_view):
409 Offer a connection if we are offline.
411 * src/modest-tny-account.c: (on_connection_status_changed):
412 Document this as only handling errors during network operations in progress,
413 and replace the idle code with a simple call to
414 modest_platform_connect_and_wait(), which does this instead.
416 2007-07-03 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-tny-account.c:
419 (modest_tny_account_get_special_folder): (util_on_idle),
420 Handle the GError so we can see when tny_folder_store_get_folders()
421 fails, as it currently does while something else is connecting.
423 Added util_run_in_main_thread_and_wait()
424 which uses an idlen handler and mainloop to ensure that the function
425 is called in the main thread.
426 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
427 to make sure that we call attempt the connection in the mainloop only,
428 which might solve some hangs.
430 2007-07-03 Murray Cumming <murrayc@murrayc.com>
432 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
433 be found by their display name. This is never useful.
434 * src/modest-tny-account-store.c: (on_account_removed): Find the account
435 by its ID, instead of trying to use its ID as its display name.
437 * src/modest-tny-account-store.h:
438 * src/modest-tny-account.c:
439 (modest_tny_account_get_special_folder): Add a g_warning() when
440 tny_folder_store_get_folders() returns an empty list for the maildir.
442 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
443 Add a g_warning() when this returns NULL, because that it not allowed
446 2007-07-02 Armin Burgmeier <armin@openismus.com>
448 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
449 note when trying to cancel the wizard. This fixes projects.maemo.org
452 2007-07-02 Murray Cumming <murrayc@murrayc.com>
454 * src/modest-tny-account.h:
455 * src/modest-tny-account.c:
456 (modest_tny_account_new_from_server_account),
457 (modest_tny_account_new_from_server_account_name),
458 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
459 because this must now be set before setting the proto. This is usd in
460 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
461 warning in camel_session_get_service() caused by
462 tny_camel_transport_account_prepare().
464 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
467 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
469 * src/maemo/modest-connection-specific-smtp-edit-window.c:
471 (modest_connection_specific_smtp_edit_window_init):
473 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
476 2007-06-29 Murray Cumming <murrayc@murrayc.com>
478 * src/modest-tny-account.c:
479 (modest_tny_account_new_from_server_account):
480 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
481 now uses to request a connection when it needs one, and which it uses
482 to tell us that something is wrong with the connection, so we can force
483 the accounts offline to prevent further problems.
486 * src/modest-init.c: (init_default_settings):
487 * src/modest-mail-operation.c:
488 (modest_mail_operation_update_account):
489 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
490 This should not be necessary anymore. Do not set the conf key that
491 determined this (it was always TRUE and not set anywhere else).
493 * src/modest-ui-actions.h: Remove unused and unimplemented
494 modest_ui_actions_on_online_toggle_toggled().
496 2007-06-29 Murray Cumming <murrayc@murrayc.com
498 * src/maemo/modest-main-window.c: (connect_signals):
499 Don't connect to delete_event twice. Maybe this was harmless.
501 2007-06-29 Murray Cumming <murrayc@murrayc.com
503 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
504 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
505 Debug output to give some more clue when a folder move is not allowed.
507 2007-06-28 Murray Cumming <murrayc@murrayc.com
509 * src/modest-tny-account.c: (on_modest_file_system_info),
510 (modest_tny_account_get_mmc_account_name):
511 Always call the callback, without checking whether the name has changed.
512 * src/widgets/modest-folder-view.c: (strings_are_equal),
513 (on_model_foreach_set_name), (on_get_mmc_account_name),
514 (text_cell_data): Compare the name here, and use the name from
515 the account rather than from the
516 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
517 if the name was changed after the account was added to the model.
518 That's a tinymail bug but not one that I want to fix now.
520 This finally fixes projects.maemo.org bug NB#59301.
522 2007-06-27 Armin Burgmeier <armin@openismus.com>
524 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
527 2007-06-27 Murray Cumming <murrayc@murrayc.com
529 * src/modest-tny-account.h:
530 * src/modest-tny-account.c:
531 Added modest_tny_account_get_mmc_account_name(), to set the memory
532 card name asynchronously for the given account and then notify.
533 (modest_tny_account_new_for_local_folders): Use this new function instead
534 of using hildon_file_system_info_async_new() directly.
536 * src/widgets/modest-folder-view.c: (text_cell_data):
537 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
538 gtk_tree_model_row_changed() when it is available.
540 This should fix projects.maemo.org bug NB#59301.
542 2007-06-27 Murray Cumming <murrayc@murrayc.com
544 * src/modest-mail-operation.c: (update_account_thread),
545 (get_msgs_full_thread): Fix typo failures in the revert
548 2007-06-27 Murray Cumming <murrayc@murrayc.com
550 * src/maemo/modest-maemo-global-settings-dialog.c:
551 (idle_select_default_focus):
552 * src/modest-mail-operation.c: (idle_notify_progress),
553 (idle_notify_progress_once), (set_last_updated_idle),
554 (update_account_thread), (get_msgs_full_thread):
555 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
556 * src/widgets/modest-header-view.c:
557 (idle_notify_headers_count_changed_destroy),
558 (idle_notify_headers_count_changed):
559 Reverted the additions of gdk_threads_enter/leave(), in case this
560 helps with a startup hang on the device.
562 2007-06-26 Armin Burgmeier <armin@openismus.com>
564 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
565 for supported secure authentication methods from server by
566 gtk_dialog_run(), saving CPU time and a potential race condition.
568 2007-06-26 Armin Burgmeier <armin@openismus.com>
570 * src/maemo/modest-maemo-utils.h:
571 * src/maemo/modest-maemo-utils.c: Added a
572 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
573 only error code to tell the calling code when the user canceled the
576 * src/maemo/modest-account-settings-dialog.h:
577 * src/maemo/modest-account-settings-dialog.c:
578 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
579 message if the retrieval of secure authentication methods was canceled
580 by the user. Perform the check before saving anything to configuration
581 to not end up with half-committed configuration changes, do not show
582 a "Saving to configuration failed" note when authentication methods
583 could not be retrieved.
585 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
588 2007-06-26 Murray Cumming <murrayc@murrayc.com>
590 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
591 Only return the first level of folders under accounts, because the
592 osso-global-search UI spec doesn't want the rest.
593 This fixed projects.maemo.org bug NB#61811.
595 2007-06-26 Murray Cumming <murrayc@murrayc.com>
597 * src/modest-tny-account-store.c:
598 * src/modest-tny-account-store.h:
599 Added modest_tny_account_is_memory_card_account().
600 * src/maemo/modest-main-window.c: (create_details_widget):
601 Show the same information items for the memory card as we show for the
602 local-folders, to fix projects.maemo.org bug NB#59307.
604 2007-06-26 Murray Cumming <murrayc@murrayc.com>
606 * src/modest-tny-account-store.c: (get_password):
607 Added some checks for NULL to maybe prevent crashes, though I think
608 it was Philip's last commit that actually prevented the crash here
609 when creating a first new account.
610 But the new account is still not usable (no messages are shown)
611 until a restart of the application.
613 2007-06-26 Murray Cumming <murrayc@murrayc.com>
615 * src/maemo/modest-maemo-global-settings-dialog.c:
616 (idle_select_default_focus):
617 * src/modest-mail-operation.c: (idle_notify_progress),
618 (idle_notify_progress_once), (idle_notify_update_account_queue),
619 (set_last_updated_idle), (update_account_thread),
620 (notify_get_msgs_full), (get_msgs_full_destroyer),
621 (get_msgs_full_thread):
622 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
623 * src/widgets/modest-header-view.c:
624 (idle_notify_headers_count_changed_destroy),
625 (idle_notify_headers_count_changed):
626 Use gdk_threads_enter() and gdk_threads_enter_leave() in
627 all idle handlers, because some other thread could be blocking
628 the GDK lock, so that it can do GUI stuff.
630 2007-06-26 Murray Cumming <murrayc@murrayc.com>
632 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
633 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
634 (on_idle_send_receive), (on_idle_open_default_inbox):
635 * src/maemo/modest-msg-edit-window.c:
636 (modest_msg_edit_window_attach_file_noninteractive):
637 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
638 to prevent a hang. I don't quite understand why these are necessary,
639 beause we should already be in the main loop. I guess something outside
640 of the main loop is taking the lock.
642 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
643 we are really using URIs, and use files that are more likely to exist.
645 2007-06-26 Murray Cumming <murrayc@murrayc.com>
647 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
648 necessary because configure.ac now defines different variables.
650 2007-06-26 Murray Cumming <murrayc@murrayc.com>
652 * libmodest-dbus-client/libmodest-dbus-client.c:
653 * libmodest-dbus-client/libmodest-dbus-client.h:
654 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
655 libmodest_dbus_client_compose_mail() is what things actually use.
657 * src/dbus_api/modest-dbus-api.h:
658 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
659 * tests/dbus_api/Makefile.am:
660 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
663 2007-06-26 Murray Cumming <murrayc@murrayc.com>
665 * src/modest-init.c: (modest_init_local_folders):
666 For memory-card (or other non local-folders) maildir accounts,
667 always create an Archive folder, so that there is somewhere to put
668 messages. This should be less confusing, because the user does not need
669 to guess that the need to create a folder.
671 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
673 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
674 Fixed icon size by using (50, 50) which is the same as defined by
677 2007-06-25 Armin Burgmeier <armin@openismus.com>
679 * src/widgets/modest-window-mgr.c:
681 * configure.ac: Correctly recognize hildon-notify presence and fixed
682 the build without it being installed.
684 2007-06-25 Murray Cumming <murrayc@murrayc.com>
686 * libmodest-dbus-client/libmodest-dbus-client.c:
687 (libmodest_dbus_client_search): Fix the build. Sorry.
688 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
689 (reply_forward_cb): Initialize variables to fix the build.
691 * src/modest-tny-account-store.c:
692 (modest_tny_account_store_get_tny_account_by): Fix the account URI
693 comparison (a silly typo) so that email search results can be opened
694 when there are more than one account.
696 2007-06-25 Murray Cumming <murrayc@murrayc.com>
698 * libmodest-dbus-client/libmodest-dbus-client.c:
699 (libmodest_dbus_client_search),
700 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
701 instead of 1 second, because the search gets folders and messages from
702 the server, which can take a long time. When it times out,
703 osso-global-search will report no results.
705 We need to specify whether we should search only cached information
706 (maybe with a user preference), and the osso-email-search-plugin
707 API should really be improved to allow that option, and to allow results
708 to be delivered asynchronously in batches.
710 2007-06-25 Murray Cumming <murrayc@murrayc.com>
712 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
713 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
714 GTK_ICON_SIZE_DIALOG is probably the wrong size.
716 2007-06-25 Murray Cumming <murrayc@murrayc.com>
718 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
719 that is an empty string. D-Bus seems to give us these instead of NULL.
721 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
723 * src/dbus_api/modest-dbus-callbacks.c:
724 * src/maemo/easysetup/modest-easysetup-wizard.h:
725 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
726 * src/maemo/modest-connection-specific-smtp-edit-window.c:
727 (modest_connection_specific_smtp_edit_window_init):
728 * src/maemo/modest-maemo-global-settings-dialog.c:
730 * src/maemo/modest-maemo-utils.c:
731 (modest_maemo_utils_setup_images_filechooser):
732 * src/maemo/modest-main-window.c: (create_details_widget):
733 * src/maemo/modest-msg-edit-window.c:
734 (modest_msg_edit_window_attach_file_noninteractive),
735 (modest_msg_edit_window_color_button_change),
736 (modest_msg_edit_window_set_zoom):
737 * src/modest-mail-operation.c: (update_account_thread):
738 * src/modest-tny-account-store.c:
739 * src/modest-tny-account.c:
740 * src/widgets/modest-global-settings-dialog.c:
741 * src/widgets/modest-window.h:
745 2007-06-25 Murray Cumming <murrayc@murrayc.com>
747 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
748 * src/modest-search.c: (modest_search_folder),
749 (modest_search_all_accounts): Actually search only in the specified folder,
750 doing a simple match on the folder ID.
751 * src/modest-search.h: Added a folder field to the ModestSearch struct,
752 and added some documentation.
754 2007-06-22 Armin Burgmeier <armin@openismus.com>
756 * src/maemo/modest-maemo-utils.h:
757 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
758 modest_maemo_utils_get_supported_secure_authentication_methods.
760 * src/maemo/easysetup/modest-easysetup-wizard.c:
761 * src/maemo/modest-account-settings-dialog.c: Show correct error if
762 one occured, not just "Server does not support secure authentication".
764 2007-06-22 Murray Cumming <murrayc@murrayc.com>
766 * src/modest-tny-account-store.c: (get_password):
767 Restored the call to tny_account_set_user() because Philip seems to have
768 stopped this from crashing (by not using the freed string). It still does
769 not work, but now we can test it.
771 2007-06-22 Murray Cumming <murrayc@murrayc.com>
773 * src/maemo/modest-msg-edit-window.c: (init_window):
774 Comment out use of an uninitialzed GtkScrolledWindow variable,
775 to fix the build and stop a crash. Yet again.
777 2007-06-22 Murray Cumming <murrayc@murrayc.com>
779 * src/modest-tny-account-store.c: (get_password):
780 Remove the call to tny_account_set_user() because this actually crashes.
781 As mentioned in the last commit, it is known to not work anyway.
783 2007-06-22 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-tny-account-store.c: (get_password):
786 Use tny_account_set_username() to tell tinymail that the username might
787 have changed too. But tinymail ignores this: see projects.maemo.org
789 * src/modest-ui-actions.c:
790 (modest_ui_actions_on_password_requested): Remove the useless attempt to
791 reset the connection when changing the username, and improve the comments.
792 Save the changed username to gconf at least, so it is used when Modest is
795 2007-06-21 Murray Cumming <murrayc@murrayc.com>
797 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
798 Do not use a query, so that we get all folders, including for POP and
799 local-folders. They work as search criteria too.
800 This fixes projects.maemo.org bug NB#57740.
802 2007-06-21 Murray Cumming <murrayc@murrayc.com>
804 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
805 Comment out the use of hildon_notification_set_sound() because it is
806 not declared, to fix the build. Warnings are serious, people.
808 2007-06-21 Armin Burgmeier <armin@openismus.com>
810 * src/maemo/modest-maemo-utils.h:
811 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
812 modest_maemo_utils_get_supported_secure_authentication_methods()
813 to query authentication methods for a specific user. This should fix
814 projects.maemo.org bug NB#61369.
816 * src/maemo/easysetup/modest-easysetup-wizard.c:
817 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
820 2007-06-21 Murray Cumming <murrayc@murrayc.com>
822 * libmodest-dbus-client/libmodest-dbus-client.h:
823 * libmodest-dbus-client/libmodest-dbus-client.c:
824 (modest_dbus_message_iter_get_search_hit),
825 (libmodest_dbus_client_search):
826 Reorganised and commented this.
827 Removed modest_search_hit_free() from the public API because it
830 Added libmodest_dbus_client_get_folders() and
831 modest_folder_result_list_free().
833 * src/dbus_api/modest-dbus-api.h:
834 * src/dbus_api/modest-dbus-callbacks.c:
835 (modest_dbus_req_filter): Commented. Moved most code to
836 on_dbus_method_search() and added on_dbus_method_get_folders().
838 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
839 of the extra D-Bus handler.
841 * tests/dbus_api/Makefile.am:
842 * tests/dbus_api/test_get_folders.c: New test for
843 libmodest_dbus_client_get_folders(). This seems to return an empty list
844 at the moment. That could be the same error that causes the message list
845 to be empty sometimes.
846 This should help with projects.maemo.org bug NB#57740.
848 2007-06-21 Armin Burgmeier <armin@openismus.com>
850 * src/modest-mail-operation.c: Do not call
851 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
852 notify the operation's end after having set the status to CANCELED for
853 the operation queue to listen on. This fixes a deadlock when there
854 were mail operations in the queue during its finalization.
856 * src/modest-singletons.c: Reordered uninitialization of the account
857 manager to happen after the mail operation queue was uninitialized
858 because the mail operation's in the queue might still try to access
859 the account manager (see modest_mail_operation_notify_end()). This
860 fixes a potential crash when terminating the application.
862 2007-06-21 Murray Cumming <murrayc@murrayc.com>
864 * src/modest-search.c:
865 (search_mime_part_and_child_parts): Moved some code here so we
866 can search recursively in child folders.
867 (modest_search_folder): Search in the message as a mime part, instead
868 of just its child mime parts.
869 (read_chunk), (search_mime_part_ogs):
870 Check how many bytes were read, to prevent an endless loop.
871 Searching in message bodies now works. This finishes the fix for
872 projects.maemo.org bug NB#61007.
874 2007-06-20 Murray Cumming <murrayc@murrayc.com>
876 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
877 Add a g_warning when the item is not a folder.
879 * src/modest-ui-dimming-rules.c:
880 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
881 when selected item is not a folder (for instance, an account), because
882 the UI spec only talks about folders.
883 I am not sure what the UI spec wants, so this might not totally fix
884 projects.maemo.org bug NB#60794.
886 2007-06-20 Murray Cumming <murrayc@murrayc.com>
888 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
889 (load_from_file): Sort the list. The unsorted list would be more noticeable
890 in non-English locales.
892 * src/maemo/modest-msg-edit-window.c:
893 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
894 warning and fix the build.
896 * src/maemo/modest-progress-bar-widget.c:
897 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
898 avoid a g_warning, and probably to avoid a crash.
900 2007-06-20 Murray Cumming <murrayc@murrayc.com>
902 * src/modest-search.c: (modest_search_folder): Check for a GError
903 when calling tny_folder_get_headers(), to show that this is not the cause
906 2007-06-20 Murray Cumming <murrayc@murrayc.com>
908 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
909 Actually set the body query instead of the subject query.
911 * src/modest-search.c: (search_mime_part_ogs),
912 (search_mime_part_strcmp): Remove extra space from the text/* regex,
913 which would probably cause it to fail if we got this far.
915 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
916 to simplify the code.
917 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
918 be causing search-in-body to fail.
920 2007-06-20 Murray Cumming <murrayc@murrayc.com>
922 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
924 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
925 Better debug message when the folder cannot be found.
926 This should help with fixing projects.maemo.org bug #61287.
927 * src/modest-search.c: (add_hit): Do not leak the furl string.
929 2007-06-20 Murray Cumming <murrayc@murrayc.com>
931 * src/modest-ui-actions.c:
932 (modest_ui_actions_on_folder_selection_changed):
933 Do not special-case TNY_MERGE_FOLDER here, because
934 modest_tny_folder_get_account() already does that. This fixes
935 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
936 shown when the Outbox was selected).
938 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
940 * libmodest-dbus-client/libmodest-dbus-client.c:
941 (_dbus_iter_get_string_or_null): Initialize the string variable in
942 case this helps with Dirk's crash.
944 2007-06-19 Murray Cumming <murrayc@murrayc.com>
946 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
947 though it is not implemented yet (this function is maybe not even used),
948 to avoid breaking ABI in future.
949 * libmodest-dbus-client/libmodest-dbus-client.c:
950 (get_attachments_string): Moved some code into this generic function.
951 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
952 sends email. It is maybe not used.
953 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
954 (on_send_mail): Use attachments.
956 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
957 * src/maemo/modest-msg-edit-window.c:
958 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
959 a filename before using it, to fix projects.maemo.org bug NB#58233.
961 2007-06-19 Murray Cumming <murrayc@murrayc.com>
963 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
964 Initialize the continue_download variable to fix the build, and probably
965 to fix randome behaviour.
967 2007-06-18 Armin Burgmeier <armin@openismus.com>
969 * src/modest-tny-send-queue.h:
970 * src/modest-tny-send-queue.c: Keep track of the status of messages in
971 the queue so we can later show it in the UI. Replaced
972 modest_tny_send_queue_msg_is_being_sent() by
973 modest_tny_send_queue_get_msg_status().
975 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
977 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
978 gpointer. This probably was not harmful, but just to be sure.
980 2007-06-18 Murray Cumming <murrayc@murrayc.com>
982 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
983 Fix the build, but leave the function broken on Bora, because
984 hildon_uri_action_get_service() does not exist.
985 osso_uri_action_get_service() does not exist either, it seems.
987 2007-06-18 Murray Cumming <murrayc@murrayc.com>
989 * src/modest-tny-account.c:
990 (modest_tny_account_new_from_server_account):
991 Uncommented the url debug output again, because it is useful for
992 debugging, as I said in the comment.
994 2007-06-18 Murray Cumming <murrayc@murrayc.com>
996 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
998 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
999 for Mameo Bora, to fix the build.
1001 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1004 Fixed build with hildon < 0.99
1006 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1007 Check if the selected account is busy instead of checking all accounts
1009 * src/modest-account-mgr-priv.h:
1010 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1011 (modest_account_mgr_init), (compare_account_name),
1012 (modest_account_mgr_set_account_busy),
1013 (modest_account_mgr_account_is_busy):
1014 * src/modest-account-mgr.h:
1015 Added busy information to the account manager. It possible to
1016 set an account to busy or not busy now.
1018 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1019 (modest_mail_operation_update_account),
1020 (modest_mail_operation_notify_end):
1021 Set the account to busy/not busy depending on the operation state.
1023 * src/widgets/modest-account-view.c:
1024 (modest_account_view_finalize), (get_last_updated_string),
1025 (update_account_view), (on_account_busy_changed), (init_view):
1026 Show string "Refreshing..." if the account is currently busy.
1028 All this fixes projects.maemo.org bug NB#59711
1030 2007-06-14 Armin Burgmeier <armin@openismus.com>
1032 * src/widgets/modest-attachments-view.h:
1033 * src/widgets/modest-attachments-view.c: Added
1034 modest_attachments_view_has_attachments() and fixed coordinate
1035 transformation in get_att_view_at_coords(). This fixes attachment
1038 * src/widgets/modest-msg-view.c: Make use of
1039 modest_attachments_view_has_attachments() to decide whether to show
1040 attachments in the header.
1042 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1044 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1045 (on_change), (on_combo_security_changed),
1046 (modest_connection_specific_smtp_edit_window_init),
1047 (modest_connection_specific_smtp_edit_window_set_connection),
1048 (modest_connection_specific_smtp_edit_window_is_dirty):
1049 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1050 * src/maemo/modest-connection-specific-smtp-window.c:
1053 Show an comfirmation dialog for the smpt-edit-window if there are
1054 unsaved changes and the user hits cancel.
1055 (projects.maemo.org bug NB#60479)
1057 2007-06-14 Armin Burgmeier <armin@openismus.com>
1059 * src/maemo/easysetup/modest-easysetup-wizard.c:
1060 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1061 address" info in banner instead of node, and select all the text as
1062 per UI spec. This fixes projects.maemo.org bug NB#60550.
1064 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1066 reviewed by: <delete if not using a buddy>
1068 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1069 * src/modest-ui-actions.c: (folder_refreshed_cb):
1071 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1073 * src/widgets/modest-folder-view.c: (filter_row):
1074 Explictly filter out the per-account outbox accounts. I don't know why
1075 these only sometimes show up, but now they should never show up in the UI.
1076 This should fix projects.maemo.org bug NB#60160.
1078 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1080 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1081 when the toolbar does not exist yet.
1082 * src/modest-widget-memory.c: (save_settings_header_view):
1083 Added g_warnings() to help us to discover when we are trying to set
1084 an empty columns list in gconf.
1086 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1088 * src/modest-init.h:
1089 * src/modest-init.c:
1090 Added modest_init_get_default_header_view_column_ids().
1092 * src/modest-widget-memory.c: (restore_settings_header_view):
1093 Use the new function to get defaults, if the gconf key is empty,
1094 instead of not creating any columns. This seems to fix the
1095 empty right-hand pane problems.
1097 * src/widgets/modest-header-view.h: Improved documentation.
1099 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1101 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1102 Revert the use of the display name as the account name, because this
1103 is generally wrong and would break the code that follows.
1105 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1107 * src/maemo/easysetup/modest-easysetup-wizard.c:
1108 (check_for_supported_auth_methods), (on_before_next),
1111 More correct fix for projects.maemo.org bug NB# 58991
1112 Do not longer accept AUTH_PASSWORD as secure method and choose
1113 correct method when creating the account.
1115 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1117 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1118 Fixed projects.maemo.org bug NB# 58991
1120 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1122 * src/modest-init.c: (modest_init_init_core),
1123 (modest_init_local_folders): Fixed compilation errors.
1125 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1127 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1128 Remove unnecessary lib/include, though it is good in principle when needed.
1130 * src/modest-init.c: (modest_init_one_local_folder),
1131 (modest_init_local_folders):
1132 * src/modest-init.h: Initialize the .modest library for memory cards,
1133 instead of just doing nothing for them. This should allow us to create
1134 folders there, fixing projects.maemo.org bug NB#59297.
1136 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1138 * libmodest-dbus-client/libmodest-dbus-client.c:
1139 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1140 (libmodest_dbus_client_compose_mail),
1141 (libmodest_dbus_client_open_message),
1142 (libmodest_dbus_client_send_and_receive),
1143 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1145 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1146 (on_idle_open_message), (modest_dbus_req_handler),
1147 (search_result_to_message), (modest_dbus_req_filter):
1148 * src/modest-search.c: (add_hit), (modest_search_folder),
1149 (modest_search_all_accounts): Improved debug messages.
1151 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1153 * src/modest-tny-account-store.c:
1154 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1157 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1160 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1162 * src/modest-tny-account-store.c: (get_server_accounts):
1163 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1164 even when there are no accounts, so that the Outbox folder is always
1165 visible. This fixes projects.maemo.org bug NB#60158.
1167 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/modest-main-window.c: (create_details_widget):
1170 Use the mcen_va_never logical ID.
1172 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1174 * src/dbus_api/modest-dbus-api.h:
1175 * src/dbus_api/modest-dbus-callbacks.c:
1176 (on_idle_open_default_inbox), (on_open_default_inbox),
1177 (modest_dbus_req_handler):
1178 Added a new OpenDefaultInbox method.
1180 * libmodest-dbus-client/libmodest-dbus-client.h:
1181 * libmodest-dbus-client/libmodest-dbus-client.c:
1182 Added libmodest_dbus_client_open_default_inbox() to call the new
1183 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1184 though it should maybe be used by a new osso-email-interface function.
1186 * tests/dbus_api/Makefile.am:
1187 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1190 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1192 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1193 NULL, so that the signals get all the keys. This should not actually
1194 change any behaviour because we currently update everything when anything
1197 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1199 * src/widgets/modest-folder-view.c: (text_cell_data),
1200 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1201 (find_inbox_iter): If tinymail tells us that the folder is
1202 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1203 This causes the inbox to be selected at startup, fixing part of
1204 projects.maemo.org bug NB#56305.
1206 * src/modest-ui-dimming-rules.c:
1207 (modest_ui_dimming_rules_on_tools_smtp_servers):
1208 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1209 the SMTP servers menu item.
1210 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1211 that the SMTP Servers menu item is dimmed when there are no accounts,
1212 as a future version of the UI spec will require. This fixes
1213 projects.maemo.org bug NB#56305.
1215 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1217 * src/maemo/modest-maemo-utils.c:
1218 (modest_maemo_utils_get_supported_secure_authentication_methods):
1219 Added label to dialog instead of unreadable title
1221 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1222 (modest_main_window_new):
1223 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1226 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1227 * src/modest-account-mgr.h:
1228 Added method to avoid code duplication
1230 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1231 (modest_ui_actions_on_send_receive):
1232 Use modest_account_mgr_has_accounts
1234 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1236 * src/maemo/easysetup/modest-presets.c:
1237 (modest_presets_get_info_server_security): Do not report secure auth
1239 * src/modest-protocol-info.c: Use the defines for the gconf key names
1240 for secure authentication. This was not working because we were writing
1241 Password and reading password, and the check was case sensitive.
1242 With this, gmail now works for receiving and sending when created via
1245 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1247 * src/maemo/easysetup/modest-presets.c:
1248 (modest_presets_get_info_server_security): Correct the key name for
1249 SecureSmtp, because it seems to be case-sensitive.
1250 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1251 Do not try to get the 0th notebook page if there are 0 pages, to
1252 avoid a g_warning().
1254 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1256 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1257 Prevent use of the new notification feature for now, because it currently
1258 shows one dialog for each new email, which is annoying.
1260 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1262 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1263 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1264 when no country was selected, so that we show the global ones.
1265 * src/maemo/easysetup/modest-presets.c:
1266 (modest_presets_get_providers): Return only the global providers, not
1267 all providers when mmc=0 was requested.
1269 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1271 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1272 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1273 provider ID in the combo.
1275 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1276 Do not show the page numbers, because it would be confusing when we add
1277 the 2 extra pages for the custom setup, when the user chooses the "Other"
1278 provider. This fixes projects.maemo.org bug NB#59028
1280 * src/modest-init.c: (modest_init_init_core),
1281 (modest_init_local_folders):
1282 * src/modest-init.h:
1283 * src/modest-tny-account.c:
1284 (modest_tny_account_new_for_local_folders): Do not create default folders
1285 for the memory card. This should fix projects.maemo.org bug NB#59328.
1287 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1289 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1290 Free the changed_conf_keys string items. They are already freed in the
1291 idle handler if that runs first.
1293 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1295 * src/modest-ui-actions.c:
1296 (modest_ui_actions_on_password_requested): Check that the server name
1297 is not NULL, because I just saw a password dialog with (null) as the
1300 * src/modest-tny-folder.[h|c]: Added
1301 modest_tny_folder_is_memory_card_folder().
1302 * src/modest-ui-dimming-rules.c:
1303 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1304 menu item for memory cards, as per the UI spec (section 7.4). This should
1305 fix projects.maemo.org bug NB#59297.
1307 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1309 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1310 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1311 is another problem with the code, see Murray's comment at line 772)
1313 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1315 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1316 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1317 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1318 (load_from_file), (easysetup_country_combo_box_init),
1319 (easysetup_country_combo_box_get_active_country_ids),
1320 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1321 instead of just one ID, to avoid duplicate country names in the UI.
1323 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1324 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1325 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1326 a single ID, avoiding duplicate providers.
1327 * src/maemo/easysetup/modest-easysetup-wizard.c:
1328 (on_combo_account_country): Adapt to use a list.
1330 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1332 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1333 keys changed in the last X seconds.
1335 * src/modest-account-mgr.h:
1336 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1337 (on_key_change), (modest_account_mgr_class_init),
1338 (modest_account_mgr_init), (modest_account_mgr_finalize):
1339 As the keys are changed, save them in a GSList* and signal that GSList*
1340 further every X seconds, to batch changes, to allow us to do just one
1341 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1342 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1344 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1345 changed signal signature.
1347 * src/modest-conf.c: (modest_conf_set_list),
1348 (modest_conf_on_change): Reenable notification.
1350 (modest_conf_maemo_fake_on_change): Comment out the hack that
1351 notified immediately instead of asynchronously.
1353 * src/widgets/modest-account-view.h:
1354 * src/widgets/modest-account-view.c:
1355 (update_account_view): Select the previously-selected account ID,
1356 if possible. This fixes projects.maemo.org bug NB#56933.
1358 (on_account_changed), (on_account_removed),
1359 (modest_account_view_select_account):
1361 Remove the block/unblock functions
1362 because they were not useful.
1364 * src/maemo/modest-account-view-window.c:
1365 (on_delete_button_clicked), (on_edit_button_clicked),
1366 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1368 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1370 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1371 Improve the error dialog to show Incorrect Account Settings, which seems
1372 clearer, and say that the internal error message (to be removed from the
1373 dialog later) is often misleading.
1374 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1376 * src/modest-tny-account.c:
1377 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1378 URL because this is so useful for debugging on the device.
1380 * src/widgets/modest-serversecurity-combo-box.c:
1381 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1383 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1385 * src/modest-mail-operation.c:
1386 (modest_mail_operation_send_new_mail):
1387 Added a comment about a nasty but apparently harmless message. Details
1388 added to the wiki g_warnings() page.
1390 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1392 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1393 (modest_tny_send_queue_class_init):
1394 Do not use the priv struct because it is empty, to avoid g_warnings
1395 about a non-existant priv struct.
1397 * src/modest-tny-account-store.c:
1398 (modest_tny_account_store_get_server_account),
1399 (modest_tny_account_store_get_transport_account_for_open_connection
1400 ): Do not try to get transport server accounts for local folders,
1401 because they don't have any. This avoids a g_warning().
1403 * src/maemo/modest-main-window.c:
1404 (modest_main_window_notify_send_receive_initied),
1405 (on_configuration_key_changed):
1406 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1407 * src/modest-defs.h:
1408 * src/modest-mail-operation.c:
1409 (modest_mail_operation_update_account):
1410 * src/modest-tny-account-store.h:
1411 * src/modest-tny-account.c:
1412 (modest_tny_account_get_special_folder),
1413 (modest_tny_account_new_for_local_folders),
1414 (modest_tny_account_new_for_per_account_local_outbox_folder):
1415 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1416 * src/modest-tny-local-folders-account.c:
1417 (add_account_folders_to_merged_folder):
1418 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1419 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1420 (modest_ui_actions_on_send):
1421 * src/widgets/modest-folder-view.c: (update_model):
1422 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1423 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1424 modest_tny_account_store_get_tny_account_by_account() to
1425 modest_tny_account_store_get_server_account() to make the code clearer.
1427 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1429 * src/dbus_api/modest-dbus-api.h:
1430 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1431 * src/maemo/modest-msg-edit-window.c:
1432 (modest_msg_edit_window_attach_file_noninteractive):
1433 added g_warning in case the file to be attached does not exist
1434 * tests/dbus_api/test_compose_mail.c: (main):
1435 removed obsolete comment, added generic files as test case
1437 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1439 * src/modest-tny-account-store.c: (get_server_accounts):
1440 Create the local folders account only once, not once for each outbox, and
1441 not only when there are some outboxes.
1443 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1445 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1446 code that is causing a crash at startup. Sergio says that he is fixing this.
1448 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1450 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1451 * src/maemo/modest-account-settings-dialog.c:
1452 (create_page_outgoing),
1453 (modest_account_settings_dialog_set_account_name),
1454 (save_configuration):
1455 - Fixed handling of the "Use secure authentication" toggle to comply with
1456 the ui specification. See also projects.maemo.org bug NB#58400
1458 - Restore the Secure connection setting combo correctly when loading
1461 * src/maemo/modest-maemo-utils.c:
1462 (on_camel_account_get_supported_secure_authentication),
1463 (modest_maemo_utils_get_supported_secure_authentication_methods):
1464 Fixed a crasher if operation is canceled
1466 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1467 (modest_protocol_info_auth_is_secure):
1468 * src/modest-protocol-info.h:
1470 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1471 the sense of the "Use secure authentication" toggle.
1473 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1475 * src/modest-tny-account-store.h:
1476 * src/modest-tny-account-store.c:
1477 Added modest_tny_account_store_get_local_folders_account().
1479 * src/modest-tny-folder.h:
1480 * src/modest-tny-folder.c:
1481 (modest_tny_folder_get_account):
1482 Added this replacement for tny_folder_get_account() which returns
1483 the local-folders account for TnyMergeFolders, to avoid the
1484 warning about the unimplemented get_account_func() vfunc().
1486 (modest_tny_folder_get_rules),
1487 * src/modest-ui-actions.c:
1488 (modest_ui_actions_on_folder_selection_changed):
1489 * src/modest-mail-operation.c:
1490 (modest_mail_operation_remove_folder),
1491 (modest_mail_operation_xfer_folder),
1492 (modest_mail_operation_rename_folder),
1493 (modest_mail_operation_get_msg),
1494 (modest_mail_operation_get_msgs_full),
1495 (modest_mail_operation_remove_msg),
1496 (modest_mail_operation_xfer_msgs),
1497 (modest_mail_operation_refresh_folder):
1498 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1500 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1503 (modest_server_account_set_security):
1504 * src/modest-defs.h: Add comments explaining that our
1505 UI spec means TLS when it says Normal, so these do not look like errors.
1507 * src/modest-tny-account.c:
1508 (modest_tny_account_new_from_server_account): Use the new tinymail
1509 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1510 for TLS. This should fix projects.maemo.org bug NB#58460.
1512 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1514 * src/maemo/easysetup/modest-easysetup-wizard.c:
1515 (create_account): Correct the position of the gconf sanity check warning.
1516 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1517 of using the g_idle_add() hack, because this does not seem to be necessary
1518 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1519 caused by something other than maemo's gconf.
1520 This fixes projects.maemo.org bug #59022.
1522 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1524 * src/modest-account-mgr-helpers.c:
1525 (modest_account_mgr_get_default_account): Do not check that the account
1526 exists if there is no default account (NULL), to fix a runtime warning.
1528 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1530 * src/widgets/modest-folder-view.c: (update_model):
1531 Do not unref the treemodel before we have finished with it.
1532 This prevents a valgrind warning and an occasional crash at startup.
1534 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1536 * libmodest-dbus-client/libmodest-dbus-client.h:
1537 added libmodest_dbus_client_compose_mail()
1538 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1540 added functions needed for SendAsMail() functionality
1541 * src/maemo/modest-msg-edit-window.c:
1542 (modest_msg_edit_window_attach_file_noninteractive):
1543 non interactively attaching files to message edit window
1544 * src/widgets/modest-msg-edit-window.h:
1545 * tests/dbus_api/Makefile.am:
1546 added test_compose_mail.c
1547 * tests/dbus_api/test_compose_mail.c: (main):
1549 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1551 * src/modest-account-view.c:
1552 Fixed bug projects.maemo.org bug NB#59307
1554 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1556 * src/maemo/easysetup/modest-easysetup-wizard.c:
1557 (get_serverport_incoming), (on_before_next), (create_account):
1558 * src/maemo/modest-account-settings-dialog.c:
1559 (modest_account_settings_dialog_set_account_name):
1560 * src/maemo/modest-maemo-utils.c:
1561 (on_camel_account_get_supported_secure_authentication_status),
1562 (on_camel_account_get_supported_secure_authentication),
1563 (on_secure_auth_cancel),
1564 (modest_maemo_utils_get_supported_secure_authentication_methods):
1566 Implemented security authentication for settings and easysetup.
1568 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1570 * src/maemo/modest-main-window.c: (create_details_widget):
1571 Show the total size for memory card accounts too, instead of showing
1572 the name again. Fixes bug projects.maemo.org bug NB#59307.
1574 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-tny-simple-folder-store.c:
1578 * src/modest-tny-simple-folder-store.h: Removed.
1580 * src/modest-tny-local-folders-account.h
1581 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1582 for the local-folders maildir, with an extra TnyMergedFolder containing
1583 the folders of the per-account outbox store accounts.
1584 * src/modest-tny-account-store.c: (get_server_accounts):
1585 Add the outboxes to the special local folders account after creating it.
1587 * src/modest-tny-account.c:
1588 (modest_tny_account_new_for_local_folders): Create the derived
1589 account when creating the main local-folders account.
1591 * src/maemo/modest-main-window.c: (create_details_widget),
1592 (modest_main_window_set_contents_style):
1593 Adapted to the use of the derived account instead of the folder store.
1595 * src/modest-ui-actions.c:
1596 (modest_ui_actions_on_folder_selection_changed):
1597 * src/modest-ui-dimming-rules.c:
1598 (modest_ui_dimming_rules_on_new_folder):
1599 * src/widgets/modest-folder-view.c: (text_cell_data),
1600 (icon_cell_data), (filter_row), (update_model),
1601 (get_cmp_rows_type_pos):
1604 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1605 Do not get the priv struct, because no priv struct has been set,
1606 to avoid a runtime warning.
1608 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1609 #ifelse with #else, to fix a warning, to fix the build.
1612 2007-06-05 Christian Kellner <ckellner@openismus.com>
1614 * libmodest-dbus-client/libmodest-dbus-client.c:
1615 Fix small typo in doc (why do you always see them
1616 AFTER committing stuff?)
1619 2007-06-05 Christian Kellner <ckellner@openismus.com>
1621 * libmodest-dbus-client/libmodest-dbus-client.c:
1622 (libmodest_dbus_client_search):
1623 Initialize hit list with NULL. Also set folder list
1624 to "" if NULL was supplied.
1627 2007-06-03 Christian Kellner <ckellner@openismus.com>
1629 * libmodest-dbus-client/libmodest-dbus-client.c:
1630 (modest_search_hit_list_free):
1631 Make it save to call it with NULL.
1633 * src/dbus_api/modest-dbus-callbacks.c:
1634 * src/modest-search.c:
1635 Return full ModestSearchHits as the search result list not TnyHeader
1636 since can't be around withouth the correspoding TnyFolder.
1638 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1640 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1641 Added currently commented code to check for secure auth
1643 * src/maemo/modest-account-settings-dialog.c: (on_response),
1644 (save_configuration), (show_ok):
1645 Fixed projects.maemo.org bugs NB #59248 and #59251
1647 * src/maemo/modest-maemo-utils.c:
1648 (on_camel_account_get_supported_secure_authentication_status),
1649 (on_camel_account_get_supported_secure_authentication),
1650 (modest_maemo_utils_get_supported_secure_authentication_methods):
1651 * src/maemo/modest-maemo-utils.h:
1652 Moved get_supported_secure_authentication() method here to be able
1653 to use it from easysetup wizard.
1655 * src/modest-pair.c: (on_pair_compare_as_string):
1656 Should compare string with first part of pair and not
1657 strcmp pairs which will crash.
1659 * src/modest-protocol-info.c:
1660 (modest_protocol_info_protocol_is_store):
1661 * src/modest-protocol-info.h:
1662 Added modest_protocol_info_get_auth_protocol_name()
1664 2007-06-03 Armin Burgmeier <armin@openismus.com>
1666 * src/modest-mail-operation.c:
1667 (modest_mail_operation_get_msgs_full): Set priv->account also when
1668 only retrieving a single message. This avoids a crash when canceling
1671 (modest_mail_operation_notify_end): Do not explicitely remove the
1672 operation from the queue but only emit the progress_changed signal.
1673 The queue itself listens to that signal to remove the operation when
1674 it is finished. This reduces coupling and removes a potential deadlock
1675 when modest_mail_operation_notify_end() is called from the queue
1676 itself. If that is a problem performance-wise, I would suggest to
1677 implement a status-changed signal or something.
1679 * src/modest-mail-operation-queue.c: Make sure to never call a
1680 function from another file while the queue is locked. This (hopefully)
1681 fixes another deadlock when exiting the application while retrieving
1684 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1686 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1687 Fixed build if libogs is not available
1689 2007-06-03 Christian Kellner <ckellner@openismus.com>
1691 * libmodest-dbus-client/libmodest-dbus-client.h:
1692 * libmodest-dbus-client/libmodest-dbus-client.c:
1693 (libmodest_dbus_client_delete_message):
1694 Implement deletion of messages (Client side).
1696 (modest_search_hit_free),
1697 (modest_search_hit_list_free):
1698 Utility functions to free the result hits.
1700 * src/dbus_api/modest-dbus-api.h:
1701 * src/dbus_api/modest-dbus-callbacks.c:
1702 (on_delete_message),
1703 (modest_dbus_req_handler):
1704 Implement deletion of messages (Server side).
1706 * tests/dbus_api/test_search.c: (main):
1709 * tests/dbus_api/Makefile.am:
1710 * tests/dbus_api/test_delete_message:
1711 Add little test for the message deletion logic
1713 2007-06-03 Armin Burgmeier <armin@openismus.com>
1715 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1716 when the operation queue was not empty. projects.maemo.org bug
1719 2007-06-03 Armin Burgmeier <armin@openismus.com>
1721 * src/widgets/modest-account-view.c
1722 (on_account_default_toggled): Toggle default account column
1723 explicitely instead of waiting for gconf notification (which is
1724 currently ignored). This should fix projects.maemo.org bug NB#56910
1725 for now. It should probably be removed when gconf notifications are
1728 2007-06-03 Christian Kellner <ckellner@openismus.com>
1730 * libmodest-dbus-client/libmodest-dbus-client.c:
1731 Removed debugging spew.
1733 * src/dbus_api/modest-dbus-callbacks.c:
1734 Added debugging info.
1736 * src/modest-search.c:
1737 (modest_search_all_accounts):
1738 Use tny_account_store_get_accounts () on the account store
1739 to get all accounts which is the way to get all accounts.
1741 * tests/dbus_api/test_search.c: (main):
1742 Make it possible to supply the search term on the command line.
1744 2007-06-03 Christian Kellner <ckellner@openismus.com>
1746 * libmodest-dbus-client/libmodest-dbus-client.c:
1747 * libmodest-dbus-client/libmodest-dbus-client.h:
1748 Implement searching for mesages over raw dbus. (Client side)
1750 * src/dbus_api/Makefile.am:
1751 * src/dbus_api/modest-dbus-api.h:
1752 * src/dbus_api/modest-dbus-callbacks.c:
1753 * src/dbus_api/modest-dbus-callbacks.h:
1754 Search framework (Server side). Also implement on_idle_open_message().
1756 * src/maemo/modest-platform.c: (modest_platform_init):
1757 Prepare for raw dbus/osso rpc interaction.
1759 * src/modest-search.h:
1760 Changed minsize from unspecific guint to guint32.
1762 * src/modest-search.c:
1764 Added strange hack which magically made tnymail work.
1766 (modest_search_folder),
1767 (modest_search_account),
1768 (modest_search_all_accounts):
1769 Implement helper functions to search all accounts, specific account
1772 * tests/dbus_api/Makefile.am:
1773 * tests/dbus_api/test_open_message.c:
1774 Read url to open from commandline.
1776 * tests/dbus_api/test_search.c:
1777 Implement small test for dbus search stuff
1779 2007-06-02 Armin Burgmeier <armin@openismus.com>
1781 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1782 include account type and account title. This fixes projects.maemo.org
1785 * src/maemo/modest-account-view-window.c: Set a title for the window.
1787 2007-06-02 Armin Burgmeier <armin@openismus.com>
1789 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1790 incoming and outgoing server name based on email address and server
1791 types as long as the names have not been edited manually. This fixes
1792 projects.maemo.org bug NB#58671.
1794 2007-06-02 Armin Burgmeier <armin@openismus.com>
1796 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1797 server type cannot be changed in future to the incoming details page
1798 when creating an account. This fixes projects.maemo.org bug NB#59029.
1800 2007-06-02 Armin Burgmeier <armin@openismus.com>
1802 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1803 and assigned max width chars so that they wrap instead of being
1804 truncated. Fixes projects.maemo.org bug NB#56126.
1806 2007-06-02 Armin Burgmeier <armin@openismus.com>
1808 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1809 introductory note to the connection specific smtp servers dialog, as
1810 section 8.12 of the email UI specification requires. This fixes
1811 projects.maemo.org bug NB#59212.
1813 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1816 Check for running mail operations, and offer to cancel them, as per the UI
1817 spec. This fixes projects.maemo.org bug NB#59041 .
1818 However, I suspect that tinymail may still use the network connection
1819 in ways that we cannot detect or cancel. But it should at least adapt to
1820 changes fairly well.
1822 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-tny-account-store.c: (recreate_all_accounts),
1825 (get_cached_accounts), (get_server_accounts): Do more sensible
1826 ref-counting of the temporarily-cached outbox accounts list. This seems
1827 to fix a crash when entering the password when the password was wrong.
1829 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1831 * src/gnome/modest-main-window.c: (connect_signals):
1832 * src/modest-tny-account-store.c: (get_password),
1833 (modest_tny_account_store_alert): Added comments and clues and
1834 commented-out code about how we currently fail to deal with connection
1835 errors and wrong passwords, and how we should.
1837 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1839 * src/widgets/modest-retrieve-combo-box.c:
1840 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1841 This fixes projects.maemo.org bug NB#58472 .
1843 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1845 * src/maemo/easysetup/modest-easysetup-wizard.c:
1846 (create_page_complete_easysetup):
1847 (create_page_complete_custom): Correct the last commit,
1848 putting the correct sentences in the correct pages.
1850 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/easysetup/modest-easysetup-wizard.c:
1853 (create_page_complete_custom): Show the second sentence of text
1854 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1857 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1859 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1860 Set the leave-on-server conf key by default. This fixes
1861 projects.maemo.org bug NB#59258 .
1863 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1865 * src/maemo/modest-account-view-window.c:
1866 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1867 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1870 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1872 * src/maemo/easysetup/modest-easysetup-wizard.c:
1873 (create_caption_new_with_asterisk):
1874 * src/maemo/modest-account-settings-dialog.c:
1875 (create_caption_new_with_asterisk):
1876 Uncomment the code to add the asterisk, because they are no longer in the
1877 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1878 (update_incoming_server_title): Add an asterisk here too.
1880 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1882 * src/maemo/modest-maemo-global-settings-dialog.c:
1883 (current_connection): Check that we are even connected before trying to
1884 get the current connection name, to prevent a warning.
1886 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1887 Change the comments because tny_maemo_conic_device_connect() is now meant to
1889 * src/modest-mail-operation.c:
1890 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1891 make sure we have a connection and fail if we can't connect.
1893 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1895 * src/maemo/modest-main-window.c:
1896 (on_account_store_connecting_finished): Do not try to get the
1897 connection ID if we are not really connected. I am surprised that
1898 this signal handler is called when we are not connected.
1900 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1902 * src/modest-error.h:
1903 * src/modest-ui-actions.c:
1904 (modest_ui_actions_get_msgs_full_error_handler):
1905 Renamed an enum, added comments, added an enum
1906 for retrieve-limit errors.
1908 * src/modest-mail-operation.c: (foreach_add_item),
1909 (internal_folder_observer_update), (update_account_thread),
1910 (modest_mail_operation_get_msgs_full):
1911 (modest_mail_operation_update_account),
1912 Added comments about how this works, and some code that should
1913 (but does not) check the retrieve-limit. See the TODO comment.
1915 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1917 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1918 Initialize help_id to fix the build. Warnings are good.
1920 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1922 * src/widgets/modest-hbox-cell-renderer.c:
1923 (modest_hbox_cell_renderer_append):
1924 * src/widgets/modest-vbox-cell-renderer.c:
1925 (modest_vbox_cell_renderer_append):
1926 Fix the last commit by doing an extra ref.
1928 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1930 * src/widgets/modest-hbox-cell-renderer.c:
1931 (modest_hbox_cell_renderer_append):
1932 * src/widgets/modest-vbox-cell-renderer.c:
1933 (modest_vbox_cell_renderer_append):
1934 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1935 to fix the build with Maemo Bora.
1936 However, there seems to be a remaining crash, probably due to reference
1939 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1941 * src/modest-tny-account.c:
1942 (modest_tny_account_new_for_local_folders):
1943 Use hildon_file_system_info_async_new() to get a better name for
1944 the memory card account, setting it as the account name.
1945 The timing seems to work, but this is probably
1946 not the best place to do this. See the TODO comment.
1947 * src/maemo/modest-main-window.c: (create_details_widget):
1948 * src/widgets/modest-folder-view.c: (text_cell_data):
1949 Use the tny account name instead of hardcoding a name.
1951 2007-05-30 Christian Kellner <ckellner@openismus.com>
1953 * src/modest-search.c: (modest_search):
1954 Correctly set part_search_func even if we have already parsed
1955 the query and thus a valid OgsTextSearcher object.
1957 2007-05-30 Christian Kellner <ckellner@openismus.com>
1960 Search and check for libogs.
1963 Incooparte the ogs build env.
1965 * src/modest-mime-part-search-stream.c:
1966 * src/modest-mime-part-search-stream.h:
1967 Removed since we do the real searching now in modest-search.c.
1969 * src/modest-search.c:
1970 * src/modest-search.h:
1971 Implement support for ogs. We use that if available and requested
1972 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1973 should now handle the corner case when the search term is spread
1974 across multiple reads.
1975 Also the logic in modest_search () was corrected to search all
1976 requested fields until one is found.
1978 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1980 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1982 * src/modest-init.h:
1983 * src/modest-init.c: Made modest_init_local_folders() take a
1984 path and be public so we can iniitialize maildir folders on
1987 * src/modest-local-folder-info.h:
1988 * src/modest-local-folder-info.c:
1989 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1991 * src/modest-tny-account.c:
1992 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1993 still means the standard local-folders path on the local volume.
1995 * src/modest-tny-account-store.c:
1996 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1997 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1998 all accounts when that happens.
1999 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2000 this too, so it shows up in the treeview.
2002 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2004 * src/maemo/modest-maemo-global-settings-dialog.c:
2005 (current_connection):
2006 * src/widgets/modest-global-settings-dialog.c:
2007 (current_connection_default):
2008 Use the enum values instead of 0, 1 and -1,
2009 to make the code clearer.
2011 * src/modest-account-mgr-helpers.c:
2012 (modest_account_mgr_get_connection_specific_smtp): Make this code
2015 * src/modest-runtime.h:
2016 * src/modest-runtime.c:
2017 Added modest_runtime_remove_all_send_queues().
2018 * src/maemo/modest-main-window.c:
2019 (on_account_store_connecting_finished): Recreate the send queues,
2020 using the appropriate transport accounts for this new connection.
2021 Some futher adapting might be needed if the old send queues are not
2022 automatically stopped at this point.
2024 * src/modest-tny-account-store.c: (get_server_accounts):
2025 Create the connection-specific transport accounts, so that they can
2026 be found later by their ID.
2028 * src/modest-tny-account.h:
2029 * src/modest-tny-account.c:
2030 Added modest_tny_account_new_from_server_account_name().
2031 modest_tny_account_new_from_server_account(): Do not create the
2032 send queues here, because they will be
2033 recreated anyway when the connection changes for the first time.
2035 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2037 * src/modest-local-folder-info.h:
2038 * src/modest-local-folder-info.c:
2039 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2040 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2041 tbox_folder): Take a modest account name instead of a server TnyAccount,
2042 so we can have per-modest-account rather than per-transport-account
2044 We must make sure that we change or recreate the exisitng send queues
2045 when the connection changes for connection-specific transport accounts.
2047 * src/modest-tny-account-store.c:
2048 (create_per_account_local_outbox_folders): Create outboxed per modest
2049 account, not per transport account.
2051 * src/modest-tny-account.h:
2052 * src/modest-tny-account.c:
2053 (modest_tny_account_get_special_folder): For outboxes, get the
2054 parent modest account name. The account is ignored for other folders.
2055 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2056 modest account name rather than a server TnyAccount.
2058 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2060 * src/modest-tny-account.c:
2061 (modest_tny_account_new_from_server_account):
2062 Call modest_runtime_get_send_queue() immediately after creating transport
2063 accounts, so that they start trying to send email from the outbox as soon
2064 as possible at startup. This is probably what we want.
2066 * src/modest-mail-operation.c: (update_account_thread):
2067 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2068 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2069 * src/modest-tny-send-queue.h:
2070 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2071 (modest_ui_actions_on_send):
2072 Added comments about how sending works, though it needs some more work.
2074 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2076 * src/modest-tny-account.c:
2077 (modest_tny_account_get_special_folder): Add TODO because this fails when
2078 the network is busy.
2079 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2080 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2081 Do not try to show this window when there is no active account. The UI
2082 specs does not tell us what to do in this case.
2084 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2088 * src/maemo/Makefile.am:
2089 * src/widgets/Makefile.am: Some dist fixes.
2091 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2093 * src/maemo/modest-connection-specific-smtp-window.c:
2094 (on_button_edit): Make the code clearer, to prevent a double free.
2096 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2098 * src/maemo/modest-account-settings-dialog.c:
2099 (modest_account_settings_dialog_set_account_name),
2100 Check the connection-specific smtp servers checkbox if there are any.
2102 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2103 (modest_connection_specific_smtp_edit_window_init):
2104 Start with a suitable port number.
2106 * src/modest-account-mgr-helpers.h:
2107 * src/modest-account-mgr-helpers.c: Added
2108 modest_account_mgr_get_has_connection_specific_smtp().
2110 (modest_account_mgr_set_connection_specific_smtp),
2111 (modest_account_mgr_remove_connection_specific_smtp),
2112 (modest_account_mgr_get_has_connection_specific_smtp),
2113 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2114 connection-specific smtp server accounts in the account, rather than
2115 the server account conf dir.
2117 This fixes bug projects.maemo.org bug NB#58263 .
2119 * src/modest-tny-account-store.c:
2120 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2121 if there are no server accounts yet, to prevent an infinite loop when there
2122 are no accounts. Document that one must be called before the other.
2124 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2126 * src/modest-account-mgr-helpers.c:
2127 (modest_account_mgr_get_default_account): Make sure that at least
2128 one account is always the default, if there are any enabled accounts.
2129 This is just a sanity check that shouldn't be necessary.
2131 * src/modest-account-mgr-priv.c:
2132 (_modest_account_mgr_account_from_key): Unescape the conf key to
2133 get the real account name. For instance, this is an issue if a space
2134 was in the account name, which can happen because the account name
2135 is generated from the display name.
2136 (_modest_account_mgr_get_account_keyname): Always escape the
2138 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2139 Unescape the conf keys to get the real account names.
2141 For instance, previously the is-default radio button in the accounts
2142 list was not checked for any accounts at first. This fixes that,
2143 and might fix several similar bugs.
2145 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2147 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2148 Removed some debug printfs.
2150 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2152 Modest on-disk outbox directories are now here, for instance:
2153 $HOME/.modest/outboxes/<account-id-1>/outbox
2154 $HOME/.modest/outboxes/<account-id-2>/outbox
2156 $HOME/.modest/local-folders/outbox
2157 so we can have a separate outbox for each account.
2158 But they are shown as one outbox in the GtkTreeView, by using a
2159 TnyMergeFolder in a ModestTnySimpleFolderStore.
2162 * src/modest-tny-simple-folder-store.c:
2163 * src/modest-tny-simple-folder-store.h:
2164 Added ModestTnySimpleFolderStore, used to contain folders from
2165 other folder stores, such as other accounts.
2167 * src/modest-tny-outbox-account.h:
2168 * src/modest-tny-outbox-account.c:
2169 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2170 used for the per-account local outbox folders.
2172 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2173 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2174 only use this (internally) now for the non-outbox local folders.
2176 * src/modest-init.h:
2177 * src/modest-init.c: Added modest_init_one_local_folder(), for
2178 setting up the directory structure for each local folder.
2180 * src/modest-local-folder-info.c:
2181 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2182 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2184 * src/modest-local-folder-info.h:
2185 * src/modest-tny-account-store.c: (on_account_removed),
2186 (on_account_changed), (create_per_account_local_outbox_folders),
2187 (get_server_accounts), (modest_tny_account_store_get_accounts),
2188 (modest_tny_account_store_get_tny_account_by_account),
2189 (modest_tny_folder_store_is_virtual_local_folders):
2191 * src/modest-tny-account.h:
2192 * src/modest-tny-account.c:
2193 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2194 to create an on-disk per-account local outbox folder for each
2196 (create_per_account_local_outbox_folders): Create a local outbox folder
2197 for each transport account.
2198 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2199 for all local folders.
2201 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2202 instead of using g_object_get/set() directly. It is clearer.
2204 (modest_tny_folder_store_get_message_count),
2205 (modest_tny_folder_store_get_local_size
2206 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2207 because we now use these with non-acount folder stores.
2209 (modest_tny_account_get_special_folder),
2210 (modest_tny_account_new_from_server_account),
2211 (modest_tny_account_new_from_account):
2212 (recurse_folders): Adjust to the new outbox system.
2214 * src/modest-tny-folder.h:
2215 * src/modest-tny-folder.c:
2216 (modest_tny_folder_is_local_folder),
2217 (modest_tny_folder_get_local_folder_type),
2218 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2220 * src/widgets/modest-main-window.h:
2221 * src/maemo/modest-main-window.c: (create_details_widget),
2222 (modest_main_window_set_contents_style): Show details for any folder store,
2225 (modest_tny_folder_get_rules):
2226 Remove the const. C does not support constness enough for this.
2228 * src/modest-ui-actions.c:
2229 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2230 make all outboxes appear as one, in the usual local-folders tree node.
2232 (set_active_account_from_tny_account),
2233 (modest_ui_actions_on_folder_selection_changed):
2234 * src/widgets/modest-folder-view.c: (text_cell_data),
2235 (icon_cell_data), (filter_row),
2236 (add_account_folders_to_merged_folder),
2237 (add_account_folders_to_simple_folder_store), (),
2238 (get_cmp_rows_type_pos), (cmp_rows),
2239 (modest_folder_view_set_account_id_of_visible_server_account):
2240 Adjust to the new outbox system, using generic folder stores and folders
2241 in the GtkTreeModel.
2243 2007-05-23 Christian Kellner <ckellner@openismus.com>
2245 * src/modest-mail-operation.c:
2246 (modest_mail_operation_update_account):
2247 Use info->max_size instead of unintialized local var [small
2248 build fix]. (Added TODO to review that change since I don't
2251 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2253 * libmodest-dbus-client/libmodest-dbus-client.c:
2254 (libmodest_dbus_client_compose_mail): function added
2255 * src/dbus_api/modest-dbus-api.h:
2256 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2257 (on_compose_mail): Implementation of the SendAsMail functionality
2259 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2261 * src/modest-account-mgr.c:
2262 (modest_account_mgr_add_server_account): Set the secure-connection
2263 conf key for transport accounts as well as store accounts. I don't know
2264 why the if was there. For instance, this makes sure that we use SSL
2265 for the gmail preset from the easysetup wizard.
2267 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2269 * src/gnome/modest-main-window.c:
2270 (on_account_store_connecting_finished), (connect_signals):
2271 * src/maemo/modest-main-window.c:
2272 (on_account_store_connecting_finished), (connect_signals),
2273 (modest_main_window_new):
2274 Handle TnyAccountStore::connecting-finished instead of
2275 TnyDevice::connection-changed, because we cannot actually perform
2276 operations on accounts until TnyAccountStore has itself responded to
2277 the TnyDevice::connection-changed signal. This prevents a GError from
2279 Do not try to update at startup, because we (at least on scratchbox)
2280 already do an update at startup when the device goes online.
2281 This prevents a GError from tinymail.
2282 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2283 Added TODO about stopping simultaneous operations.
2285 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2287 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2288 * src/modest-mail-operation-queue.c:
2289 (modest_mail_operation_queue_remove):
2290 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2291 about where they happened.
2293 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2295 * src/modest-ui-actions.c:
2296 (modest_ui_actions_on_password_requested): Make sure that the remember
2297 output parameter is always TRUE.
2299 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2301 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2302 Show a OK/Cancel dialog if the error is a question, though we still do not
2303 know anything more about what we are asking the user.
2304 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2305 Fix an uninitialized variable (helper). This is a logic error, however.
2307 2007-05-21 Christian Kellner <ckellner@openismus.com>
2309 * src/modest-search.h:
2310 Correct bit shifting in the ModestSearchFlags enum.
2312 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2314 * src/modest-tny-account.c:
2315 (modest_tny_account_new_from_server_account): Do not use the lsub and
2316 check-all hard-coded IMAP options when using POP.
2318 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2320 * src/modest-tny-account.c:
2321 (modest_tny_account_new_from_server_account):
2322 Use NULL for the secure-auth method for POP when Password auth has been
2323 specified by the user, as we already do for IMAP. "auth=Login" causes
2324 an error from camel or the server.
2326 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/modest-account-settings-dialog.c:
2329 (create_page_account_details),
2330 (modest_account_settings_dialog_set_account_name):
2331 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2332 for the leave-on-server checkbox, rathr than just the checkbox, when
2333 the protocol is not POP.
2335 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2337 * src/widgets/modest-account-view.c:
2338 * src/widgets/modest-account-view.h:
2339 Added modest_account_view_select_account() which will be useful later
2340 to asynchronously re-select the edited account.
2342 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2344 * src/maemo/modest-account-settings-dialog.c:
2345 (modest_account_settings_dialog_set_account_name):
2346 Automatically choose the port numbers based on the secure authentication
2347 methods, if they have not been chosen before.
2348 This fixes projects.maemo.org bug NB#56273 .
2350 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2352 * src/maemo/modest-main-window-ui.h:
2353 * src/modest-ui-actions.c:
2354 * src/modest-ui-actions.h:
2355 Connect the Tools/SMTP Servers menu item to
2356 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2357 SMTP servers dialog, as in the UI specification and saves changes when it
2358 is closed. This fixed projects.maemo.org bug NB#56305 .
2360 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2362 * src/maemo/modest-connection-specific-smtp-window.c:
2363 (modest_connection_specific_smtp_window_init):
2364 Use gtk_window_set_default_size() to make this window big enough, so
2365 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2367 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2369 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2370 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2371 (modest_connection_specific_smtp_edit_window_init),
2372 Do not try to connect to a combobox signal before the combobox exists.
2373 This fixes the cras in projects.maemo.org bug NB#56288 .
2374 (modest_connection_specific_smtp_edit_window_get_settings):
2375 Remove the server_account_name parameter which was being checked for NULL
2376 though it was not used.
2378 * src/maemo/modest-connection-specific-smtp-window.c:
2379 (modest_connection_specific_smtp_window_fill_with_connections),
2380 (on_button_edit), (modest_connection_specific_smtp_window_init):
2381 Correct the number of treemodel columns to prevent a warning.
2382 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2383 libconic does not work.
2385 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2387 * src/modest-tny-account.c:
2388 (modest_tny_account_new_from_server_account):
2389 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2390 SMTP when "None" was chosen by the user. However, with my SMTP server that
2391 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2394 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2396 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2397 to explain the memory management issue with the ID in the ModestPair.
2399 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2400 (add_sending_page), (modest_account_assistant_finalize):
2401 * src/gnome/modest-gnome-global-settings-dialog.c:
2402 (create_updating_page), (create_composing_page):
2403 * src/gnome/modest-msg-edit-window.c: (get_transports),
2404 (init_window), (modest_msg_edit_window_finalize),
2405 (modest_msg_edit_window_get_msg_data):
2406 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2407 * src/gnome/modest-transport-widget.c:
2408 (modest_transport_widget_finalize), (smtp_configuration):
2409 * src/maemo/modest-maemo-global-settings-dialog.c:
2410 (create_updating_page), (create_composing_page):
2411 * src/maemo/modest-msg-edit-window.c: (get_transports),
2412 (init_window), (modest_msg_edit_window_finalize),
2413 (modest_msg_edit_window_get_msg_data),
2414 (modest_msg_edit_window_free_msg_data):
2415 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2416 (modest_store_widget_finalize):
2417 * src/maemo/modest-transport-widget.c:
2418 (modest_transport_widget_finalize), (smtp_configuration):
2419 * src/modest-main.c: (send_mail):
2420 * src/widgets/modest-combo-box.h:
2421 * src/widgets/modest-global-settings-dialog-priv.h:
2422 * src/widgets/modest-global-settings-dialog.c:
2423 (modest_global_settings_dialog_finalize):
2424 * src/widgets/modest-msg-edit-window.h:
2425 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2426 as long as the combo box, to prevent use of freed memory for the ID.
2428 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2430 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2431 get_accounts(), to make this clearer. Do not check for the enabled gconf
2432 key, because we do not use this for server accounts (at least, not yet).
2433 This allows us to send email again.
2435 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2437 * src/maemo/modest-platform.c:
2438 (on_modest_conf_update_interval_changed), (modest_platform_init):
2439 Only respond to this particular key change. All these strcmp()s cannot be
2442 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2444 * src/maemo/modest-maemo-global-settings-dialog.c:
2445 (current_connection): Prevent a crash in scratchbox when
2446 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2447 * src/maemo/modest-platform.c:
2448 (on_modest_conf_update_interval_changed), (modest_platform_init):
2449 Get the update interval from gconf and reset it when the gconf key changes.
2451 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2453 * src/modest-protocol-info.c:
2454 * src/modest-protocol-info.h: Adde enum-specific get functions,
2455 instead of using a ModestProtocolType enum parameter.
2457 * src/gnome/modest-account-assistant.c:
2458 * src/gnome/modest-store-widget.c:
2459 * src/gnome/modest-store-widget.h:
2460 * src/gnome/modest-transport-widget.c:
2461 * src/gnome/modest-transport-widget.h:
2462 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2463 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2464 * src/maemo/easysetup/modest-easysetup-wizard.c:
2465 * src/maemo/modest-account-settings-dialog.c:
2466 * src/maemo/modest-account-settings-dialog.h:
2467 * src/maemo/modest-store-widget.c:
2468 * src/maemo/modest-store-widget.h:
2469 * src/maemo/modest-transport-widget.c:
2470 * src/maemo/modest-transport-widget.h:
2471 * src/modest-account-mgr-helpers.c:
2472 * src/modest-account-mgr-helpers.h:
2473 * src/modest-account-mgr.c:
2474 * src/modest-account-mgr.h:
2475 * src/modest-tny-account.c:
2476 * src/modest-tny-folder.c:
2477 * src/widgets/modest-account-view.c:
2478 * src/widgets/modest-retrieve-combo-box.c:
2479 * src/widgets/modest-retrieve-combo-box.h:
2480 * src/widgets/modest-secureauth-combo-box.c:
2481 * src/widgets/modest-serversecurity-combo-box.c:
2482 * src/widgets/modest-serversecurity-combo-box.h:
2483 * tests/check_account-mgr.c:
2484 Use the specific functions, and use the re-renamed enum values for GNOME too.
2486 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2488 * src/modest-pair.h:
2489 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2490 so we can get the second based on the first.
2492 * src/maemo/modest-account-settings-dialog.h:
2493 * src/maemo/modest-account-settings-dialog.c:
2494 Added get_supported_secure_authentication_methods(), though it is mostly
2495 commented-out for now until the necessary API is committed to tinymail.
2496 (modest_account_settings_dialog_set_account_name),
2497 (save_configuration): Request the supported authentication methods from the
2498 server, so we can choose a working method.
2500 * src/modest-tny-account-store.h:
2501 * src/modest-tny-account-store.c:
2502 (modest_tny_account_store_get_session): Rename from
2503 tny_account_store_get_session().
2505 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2507 * src/modest-protocol-info.h: Split the ModestProtocol enum
2508 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2509 There was no need to have these unrelated values in one enum.
2511 * src/: many files: Adapted to changed enum. This makes the code a bit
2512 clearer, and the compiler could catch some errors.
2514 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2516 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2517 Show the detailed internal camel error message when an error happens
2518 during the configuration, so that our testers can give us more clues.
2519 For instance, in projects.maemo.org bug NB#56910 .
2521 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2523 * src/modest-tny-account.c:
2524 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2525 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2527 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2529 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2530 * src/maemo/modest-account-settings-dialog.c:
2531 (modest_account_settings_dialog_set_account_name),
2532 (save_configuration): For the incoming secure authentication checkbox,
2533 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2534 the UI specification. PLAIN does not seem to be supported for most IMAP
2535 servers anyway, and I am not sure what it would mean.
2536 However, we probably need to discover which of the secure-authentication
2537 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2538 * src/modest-account-mgr-helpers.c:
2539 (modest_account_mgr_get_server_account_data):
2541 * src/modest-tny-account.c:
2542 (modest_tny_account_new_from_server_account):
2543 Use tny_account_set_mech() to set secure-authentication methods,
2544 with some special-casing for IMAP, based on my observations of how
2547 * src/modest-account-mgr-helpers.h:
2548 * src/modest-account-mgr.c:
2549 * src/modest-defs.h: Comment that the URI is only used for local folders.
2551 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2553 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2554 parameter const, just to be neat.
2555 * src/modest-text-utils.c: (modest_text_utils_inline):
2556 End g_strconcat() with NULL, as its documentation says. This is almost
2557 certainly the cause of my crash at startup on the device. Interestingly,
2558 valgrind doesn't tell us about these errors.
2560 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2562 * scripts/build-packages: Added more precise comments about how to use
2563 this script, though I still get this error:
2564 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2565 error building tinymail
2567 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2569 * src/maemo/modest-main-window.c: (on_account_update):
2570 Very slight cleanup, hoping to make it simpler to discover what causes
2571 a crash here sometimes.
2573 * src/modest-tny-account.c:
2574 (modest_tny_account_new_from_server_account): Set the port. Added
2575 comments about the options and a TODO comment because I need to find out
2576 how to specify the secure authentication method.
2578 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2580 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2581 changed CFlags paths form modest to libmodest
2583 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2585 * src/modest-account-mgr-helpers.c:
2586 (modest_account_mgr_get_server_account_data),
2587 (modest_account_mgr_free_server_account_data):
2588 * src/modest-account-mgr-helpers.h:
2589 * src/modest-account-mgr.c:
2590 (modest_account_mgr_add_server_account):
2591 * src/modest-defs.h:
2592 * src/modest-tny-account.c:
2593 (modest_tny_account_new_from_server_account):
2594 Determine the options for tny_camel_account_add_option() here,
2595 based on the settings, rather than storing them directly in gconf.
2597 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2599 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2600 Show a more friendly error dialog now that we expect (from the tinymail
2601 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2603 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/modest-main-window.c: (on_account_update): Check that
2606 account_name is not NULL, to prevent a crash at startup that I am
2607 seeing on the N800. I do wonder why it is NULL.
2609 * src/maemo/easysetup/modest-easysetup-wizard.c:
2610 (create_page_user_details):
2611 * src/maemo/modest-account-settings-dialog.c:
2612 (create_page_user_details), (create_page_outgoing):
2613 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2614 (modest_connection_specific_smtp_edit_window_init):
2615 * src/modest-ui-actions.c:
2616 (modest_ui_actions_on_password_requested):
2617 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2618 might do something useful with the on-screen keyboard.
2620 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2622 * src/maemo/modest-main-window.c: (on_account_update):
2623 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2624 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2626 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2628 * src/modest-tny-account-store.c: (on_account_changed):
2629 Correct the signature of this signal handler.
2631 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2633 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2634 Show a HildonNote instead of a GtkDialog for Maemo.
2636 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2638 * src/widgets/modest-account-view.h:
2639 * src/widgets/modest-account-view.c: (on_account_changed),
2640 (on_account_removed). Added a boolean flag, set/unset by
2641 modest_account_view_block_conf_updates(),
2642 modest_account_view_unblock_conf_updates() to prevent unnecessary
2643 updates, but this is not very useful because the gconf notifications are
2644 so delays (maybe only on Maemo Bora).
2645 So auto-updating is turned off, and these functions do an explicit
2646 update when necessary.
2647 However, something else is still doing too much work when adding/removing
2648 accounts, probably in another part of the application.
2650 * src/maemo/modest-account-view-window.c:
2651 (on_delete_button_clicked), (on_edit_button_clicked),
2652 (on_new_button_clicked): Use the new functions.
2654 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2656 * src/modest-account-mgr-helpers.c:
2657 (modest_account_mgr_set_first_account_as_default):
2658 Sort the list of names alphabetically-by-title, so we choose the first one
2660 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2661 alphabetically by the title.
2663 This fixes projects.maemo.org bug NB#56418 .
2665 * src/modest-account-mgr-priv.c:
2666 (_modest_account_mgr_account_from_key):
2667 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2668 avoid a valgrind error, and possible random behaviour.
2670 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2672 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2673 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2674 tinymail documentation to say that this can be expected.
2675 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2676 pretty, and should not happen, but I would prefer to know when it does.
2678 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2680 * configure.ac: When using the older hildon version, probably on Bora,
2681 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2683 * src/widgets/modest-attachment-view.c:
2684 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2687 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2689 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2690 Implemented the prototype. Can be tested with
2691 tests/dbus_api/test_open_message:
2693 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2695 * src/modest-tny-account-store.c:
2696 (modest_tny_account_store_instance_init), (get_password):
2697 * src/modest-ui-actions.c:
2698 (modest_ui_actions_on_password_requested):
2699 Do not store the password in gconf, because this function is called
2700 for non-remembered passwords. Actually use the cached (in the hash map)
2701 password instead of releasing it.
2702 The password will now not be remembered if it is asked via the protected
2703 password dialog, as per the UI spec.
2705 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2707 * src/modest-defs.h:
2708 * src/modest-account-mgr-helpers.h:
2709 * src/modest-account-mgr-helpers.c:
2710 Added modest_server_account_get_username_has_succeeded(),
2711 modest_server_account_set_username_has_succeeded().
2712 (modest_server_account_set_username),
2713 Reset the has-succeeded flag if the username changes.
2715 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2716 * src/maemo/modest-connection-specific-smtp-window.c:
2717 (modest_connection_specific_smtp_window_save_server_accounts):
2718 Use modest_server_account_set_username() instead of using
2719 modest_conf_set_string() directly, so that the has-succeeded flag is always
2722 * src/modest-ui-actions.c:
2723 (modest_ui_actions_on_password_requested): Dim the username entry if
2724 the username has ever worked, as per the UI spec.
2726 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2728 * src/modest-tny-account-store.c: (get_password):
2729 * src/modest-ui-actions.c:
2730 (modest_ui_actions_on_password_requested):
2731 Allow the username to be changed too, though there is more work to
2732 be done on exactly how this behaves.
2734 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2736 * src/modest-account-mgr-helpers.h:
2737 * src/modest-account-mgr-helpers.c:
2738 Added modest_account_mgr_get_display_name(),
2739 modest_server_account_get_username(),
2740 modest_server_account_set_username(),
2741 modest_server_account_set_password(),
2742 modest_server_account_get_hostname() functions so we do not need to
2743 use the conf API directly.
2745 * src/maemo/modest-main-window.c: (connect_signals):
2746 Actually connect ot the ModestAccountStore::request-password signal,
2747 so that we show the dialog when the password is requested by Tinymail,
2748 for isntance if it is empty.
2750 * src/modest-marshal.list:
2751 * src/modest-tny-account-store.c:
2752 (modest_tny_account_store_class_init), (get_password),
2753 (modest_tny_account_store_alert):
2754 * src/modest-tny-account-store.h:
2755 * src/modest-ui-actions.h:
2756 * src/modest-ui-actions.c:
2757 (modest_ui_actions_on_password_requested):
2758 Change the signal parameters, so it is obvious that we are providing
2759 the non human-readable server name, and receiving both the username
2760 and password, though changing of the username is not yet implemented.
2761 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2762 for the GNOME version.
2764 This should fix the projects.maemo.org bug NB#56209, though it does not
2765 work on Bora, because the gconf_client_get() for the password fails
2766 immediately after we save it with gconf_client_set().
2768 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2771 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2772 caused an undefined symbol error:
2773 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2775 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2777 * src/modest-tny-account-store.c:
2778 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2779 using a GError instead of a string message, so we can translate it in
2782 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2784 * src/maemo/modest-address-book.c:
2785 (modest_address_book_check_names):
2786 * src/maemo/modest-msg-view-window.c:
2787 (modest_msg_view_window_clipboard_owner_change):
2788 * src/modest-init.c: (modest_init_init_ui):
2789 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2790 (update_folders_cb), (modest_mail_operation_update_account):
2791 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2792 (modest_ui_actions_on_msg_attachment_clicked),
2793 (modest_ui_actions_on_msg_recpt_activated):
2794 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2795 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2796 (modest_msg_view_search_next):
2797 * src/widgets/modest-recpt-editor.c:
2798 (modest_recpt_editor_on_button_release_event),
2799 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2800 g_message(). At this point we should only be seeing interesting errors on
2801 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2803 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2805 (modest_wizard_dialog_force_title_update):
2806 * src/maemo/easysetup/modest-wizard-dialog.h:
2807 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2808 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2809 can update the title when appropriate. Otherwise the title is wrong if the
2810 pages are added after adding the notebook to the dialog.
2811 This must be a problem in HildonWizardDialog too.
2812 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2814 * src/maemo/easysetup/modest-easysetup-wizard.c:
2815 (create_subsequent_customsetup_pages),
2816 (create_subsequent_easysetup_pages):
2817 Call modest_wizard_dialog_force_title_update() so that the title is
2818 correct even with GTK+ < 2.10.
2819 This fixes projects.maemo.org bug NB#56145 .
2821 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2823 * src/maemo/modest-platform.c:
2824 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2825 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2828 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2830 * src/widgets/modest-window.h:
2831 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2832 and modest_window_save_state(), which invokes it.
2834 * src/widgets/modest-window-mgr.h:
2835 * src/widgets/modest-window-mgr.c:
2836 Added modest_window_mgr_save_state_for_all_windows(), which calls
2837 the save_state vfunc on all registered windows, if implemented.
2839 * src/gnome/modest-msg-edit-window.c:
2840 * src/gnome/modest-msg-view-window.c:
2841 * src/maemo/modest-msg-edit-window.c:
2842 * src/maemo/modest-msg-view-window.c:
2843 * src/maemo/modest-main-window.c:
2844 Specify the existing save_settings functions as implementations of
2845 ModestWindow::save_state_func().
2847 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2848 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2849 enabling hibernation, for instance.
2851 We may need to do the same thing for restoring settings.
2854 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2856 * src/widgets/modest-window-mgr.c:
2857 * src/widgets/modest-window-mgr.h:
2858 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2859 modest_window_mgr_get_hibernation_is_prevented().
2861 * src/maemo/modest-main-window.c:
2862 (on_hildon_program_is_topmost_notify): Prevent hibernation
2863 (possible when the application goes to the background in the WM),
2864 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2866 * src/maemo/easysetup/modest-easysetup-wizard.c:
2867 (modest_easysetup_wizard_dialog_init):
2868 * src/maemo/modest-account-settings-dialog.c:
2869 (modest_account_settings_dialog_init):
2870 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2871 (modest_connection_specific_smtp_edit_window_init):
2872 * src/maemo/modest-connection-specific-smtp-window.c:
2873 (modest_connection_specific_smtp_window_init):
2874 * src/maemo/modest-signature-editor-dialog.c:
2875 (modest_signature_editor_dialog_init):
2876 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2877 prevent hibernation while any of these account settings dialogs are open.
2879 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2881 * src/maemo/Makefile.am:
2882 * src/maemo/modest-osso-state-saving.c:
2883 * src/maemo/modest-osso-state-saving.h: Added
2884 modest_osso_load_state() and modest_osso_save_state() though they do
2885 nothing now. They should iterate through all the open windows and load/save
2887 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2888 save state when closing.
2890 * src/maemo/modest-main-window.c:
2891 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2892 Add a notification handler for the HildonProgram::is-topmost property,
2893 so we can allow hibernation when the application goes into the background.
2894 But we still need to detect when the accounts setup windows are open so
2895 we can stop hibernation when they are open.
2896 To do this, I also added the main window the HildonProgram. This might have
2897 other side-effects/benefits, and should maybe be done for other windows.
2899 * src/maemo/modest-osso-autosave-callbacks.h:
2900 * src/maemo/modest-osso-autosave-callbacks.c:
2901 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2902 though it does not do anything yet, and we might never need this to do
2903 anything. For instance, we already save drafts.
2905 * src/maemo/modest-platform.c: (modest_platform_init):
2906 Specify the libosso auto-save callback.
2908 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2910 * src/maemo/modest-platform.c:
2911 (modest_platform_set_update_interval):
2912 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2913 aparently stays valid between application instances, so we can use this
2914 to remove and reset it later. According to a maemo-developers email from
2917 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2919 * configure.ac: Depend on libalarm for Maemo.
2921 * src/dbus_api/modest-dbus-api.h:
2922 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2923 (on_send_receive), (modest_dbus_req_handler):
2924 Handle a SEND_RECEIVE D-Bus method.
2926 * libmodest-dbus-client/libmodest-dbus-client.c:
2927 (libmodest_dbus_client_send_and_receive):
2928 * libmodest-dbus-client/libmodest-dbus-client.h:
2929 Add C convenience functions for calling the new D-Bus method.
2931 * src/modest-platform.h:
2932 * src/gnome/modest-platform.c:
2933 * src/maemo/modest-platform.c:
2934 Added modest_platform_set_update_interval(), which uses the
2935 alarmd API on Maemo.
2936 (modest_platform_init),
2937 Call modest_platform_set_update_interval(), using a hard-coded
2938 interval for now (until the global settings dialog is implemented),
2939 though I am not sure that this makes sense yet.
2941 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2943 * src/dbus_api/modest-dbus-callbacks.c:
2944 (modest_osso_cb_hw_state_handler):
2945 * src/dbus_api/modest-dbus-callbacks.h:
2946 * src/maemo/modest-platform.c: (modest_platform_init):
2947 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2948 in case this has some effect on the ability for Maemo to ping the
2951 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2953 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2954 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2955 warning. It is probably a logic error, but I need to fix the build.
2957 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2959 * src/modest-account-mgr.h:
2960 * src/modest-account-mgr.c:
2961 (modest_account_mgr_account_names): Add a gboolean enabled_only
2962 parameter, so we can get lists of onlt the enabled accounts.
2964 (modest_account_mgr_add_account),,
2965 (modest_account_mgr_account_with_display_name_exists):
2966 * src/maemo/modest-msg-edit-window.c: (get_transports):
2967 * src/modest-account-mgr-helpers.c:
2968 (modest_account_mgr_set_first_account_as_default):
2969 * src/modest-init.c: (init_default_account_maybe):
2970 * src/modest-tny-account-store.c: (get_accounts):
2971 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2972 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2973 * tests/check_account-mgr.c: (START_TEST):
2974 Provide the extra parameter, as appropriate.
2976 * src/widgets/modest-account-view.c: (update_account_view):
2977 Do not show disabled accounts (meaning that there is no way to
2978 enable/disable accounts in the UI (the feature is not in our UI
2979 specification), so we can use this internally only to mark unfinished
2980 or temporary account data.
2982 * src/maemo/easysetup/modest-easysetup-wizard.c:
2983 (create_account): Add boolean enable parameter, so we can specify FALSE
2984 to create the temporary account.
2985 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2986 (on_before_next): When finishing, when there is a temporary account, just
2988 Also, use a timeout to delay the showing of the dialog until gconf is likely
2989 to return correct information, due to a maemo gconf bug that is fixed in
2990 osso 1.1, but not yet in Bora.
2991 However, the dialog stays on screen after it is destroyed.
2993 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2994 for invalid data when cancelling. Use a hildon note instead of a dialog
2995 to complain about invalid data. Do not show the account-saved note if the
2996 account is disabled (a temporary account that will not really be saved for use
2999 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3001 * src/modest-account-mgr-helpers.h:
3002 * src/modest-account-mgr-helpers.c:
3003 Added modest_account_mgr_unset_default_account(),
3004 Added modest_account_mgr_set_first_account_as_default().
3006 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3007 If it was the default account, unset the default account name.
3009 * src/maemo/modest-account-view-window.c:
3010 (on_delete_button_clicked): If it was the default account,
3011 set the first remaining account as the default instead.
3013 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3014 a NULL account or a NULL default account, to prevent a crash. This should
3015 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3018 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3020 * src/widgets/modest-recpt-editor.c:
3021 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3022 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3023 TODO comment for this. This fixes the build.
3025 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3026 be the best place for it. This will in future update all auto-update accounts,
3027 rather than just the current/default account, when that gconf key exists.
3028 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3029 if there are no accounts, before calling do_send_receive().
3030 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3032 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3033 * src/maemo/modest-main-window-ui.h:
3034 * src/maemo/modest-main-window.c: (on_connection_changed),
3035 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3036 directly, becaue the signal handler does more.
3038 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3040 * src/modest-account-mgr-helpers.c:
3041 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3042 for the case that the account does not exist.
3044 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3045 (equivalent to the modest account name) rather than the tinymail account name
3046 (equivalent to the modest account title - human readable) to get the account data.
3047 Check for null account data to prevent the crash, and add a TODO comment saying that
3048 this needs fixing because it is using the server account name instead of the account name.
3050 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3052 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3053 * src/maemo/modest-account-settings-dialog.c: (show_error),
3055 Use hildon_note_new_information() for informative and error messages,
3056 which seems to be expected for Maemo applications (no documentation that I know of
3057 says this). I am surprised that there is no distinction between info and error
3060 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3062 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3063 it is easy to find where this is used.
3065 * src/maemo/easysetup/modest-easysetup-wizard.c:
3066 (create_page_welcome), (create_page_account_details),
3067 (create_page_user_details), (create_page_complete_easysetup),
3068 (create_page_custom_incoming), (create_page_custom_outgoing),
3069 (create_page_complete_custom):
3070 * src/maemo/modest-account-settings-dialog.c:
3071 (create_page_account_details), (create_page_user_details),
3072 (create_page_incoming), (create_page_outgoing):
3073 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3074 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3075 (modest_connection_specific_smtp_edit_window_init):
3076 * src/maemo/modest-connection-specific-smtp-window.c:
3077 (modest_connection_specific_smtp_window_init):
3078 * src/maemo/modest-signature-editor-dialog.c:
3079 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3080 and scrolling policy as per the Email Application Layout Guide, if I have
3083 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3085 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3086 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3087 which were empty, because these vfuncs have been removed from TnyAccountStore.
3088 This fixes the build.
3090 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3092 * src/maemo/modest-main-window.c:
3093 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3094 showing/hiding it. Added TODO because it probably should not be NULL.
3095 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3096 because unnecessary g_warnings() make degugging difficult.
3098 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3100 * src/maemo/modest-msg-edit-window.c:
3101 (modest_msg_edit_window_select_color),
3102 (modest_msg_edit_window_select_background_color): 2 const corrections and
3103 moving 2 #endifs before closing brackets, to fix the build.
3105 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3107 * src/maemo/easysetup/modest-easysetup-wizard.h:
3108 * src/maemo/easysetup/modest-easysetup-wizard.c:
3109 (modest_easysetup_wizard_dialog_finalize),
3110 (on_button_edit_advanced_settings), (create_page_complete_custom),
3111 (on_response), (create_account):
3112 Implement the Advanced Settings edit button, by saving the account information,
3113 for the Advanded Settings dialog to use directly from gconf, and removing it
3114 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3115 Bug #5533 in the projects.maemo.org bugzilla.
3117 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3119 * src/maemo/modest-msg-view-window.c:
3120 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3121 when opening a message window.
3123 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3125 * src/maemo/easysetup/modest-easysetup-wizard.c:
3126 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3129 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3130 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3131 gconf settings. I probably added more checks than necessary, but that is safer.
3133 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3134 variable to fix the build, but this seems to be used when it is still NULL.
3136 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3138 * src/modest-platform.h:
3139 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3140 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3141 * src/modest-main.c: Implement this function so we can avoid using
3142 maemo-specific API from cross-platform code.
3144 * src/modest-tny-account-store.c:
3145 (get_smtp_specific_transport_account_for_open_connection):
3146 * src/modest-ui-actions.c: (check_for_connection),
3147 (modest_ui_actions_on_item_not_found):
3148 Use modest_platform_connect_and_wait() and put #idefs around other
3149 maemo-specific code, because only maemo currently has a way to
3150 identify connection names.
3152 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3154 * src/modest-tny-account-store.h:
3155 * src/modest-tny-account-store.c:
3156 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3157 the connection-specific SMTP server settings in the configuration.
3159 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3161 * src/maemo/modest-main-window.c: (on_connection_changed),
3163 * src/modest-main.c: (main), (start_ui), (send_mail):
3164 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3165 that is what is intended.
3167 * src/modest-ui-actions.c: (action_send), (action_receive),
3168 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3169 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3170 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3171 SMTP server is used when it is specified.
3173 (modest_ui_actions_on_send_receive):
3174 Check that a connection is open before proceeding.
3175 Receive and then send, instead of vice-versa, as per the specification.
3177 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3179 * src/modest-mail-operation.c:
3180 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3181 though I guess it should be something other than NULL.
3183 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3185 * src/maemo/easysetup/modest-easysetup-wizard.c:
3186 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3187 combo twice, to avoid an g_warning and to make it visible again.
3188 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3189 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3190 (already intended) dereference when detaching, because we then recreate the menu.
3191 But I am not sure why the warning was happening, and it is possible that this is a memory
3194 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3196 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3197 and uri_parse_mailto() utility functions.
3198 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3200 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3202 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3204 * src/dbus_api/modest-dbus-api.h:
3205 * src/dbus_api/modest-dbus-callbacks.c:
3206 Use an idle callback to execute the modest code in the application's own thread.
3207 Remove the helloworld example method.
3208 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3209 parsed, and the open-message method is not implemented because this is not yet implemented in
3211 * libmodest-dbus-client/libmodest-dbus-client.c:
3212 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3213 (libmodest_dbus_client_open_message):
3214 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3216 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3217 body without crashing.
3219 * tests/dbus_api/Makefile.am:
3220 * tests/dbus_api/test_mail_to.c:
3221 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3223 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3225 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3226 Added file to fix the build. Sorry.
3228 * src/dbus_api/Makefile.am:
3229 * src/dbus_api/modest-dbus-api.h:
3230 * src/dbus_api/modest-dbus-callbacks.h:
3231 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3232 (modest_dbus_req_handler):
3233 Put constants in a separate header so it can be reused by the
3234 client library, without duplication
3236 * libmodest-dbus-client/Makefile.am:
3237 * libmodest-dbus-client/libmodest-dbus-client.c:
3238 (libmodest_dbus_client_call_helloworld),
3239 (libmodfest_dbus_client_send_mail),
3240 (libmodfest_dbus_client_mailto),
3241 (libmodfest_dbus_client_open_message):
3242 * libmodest-dbus-client/libmodest-dbus-client.h:
3243 (Partly) Implement a send_mail D-Bus method.
3245 * tests/dbus_api/Makefile.am:
3246 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3247 the send_email D-Bus method.
3249 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3253 * libmodest-dbus-client/Makefile.am:
3254 * libmodest-dbus-client/libmodest-dbus-client.c:
3255 * libmodest-dbus-client/libmodest-dbus-client.h:
3256 * tests/dbus_api/Makefile.am:
3257 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3258 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3260 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3262 * src/maemo/easysetup/modest-easysetup-wizard.c:
3263 (create_page_account_details):
3264 * src/maemo/modest-account-settings-dialog.c:
3265 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3266 widgets, because this might not be the default in future versions of the Maemo GTK+.
3267 However, I can not not get capitalization to work even in a simple test case.
3269 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3271 * src/maemo/easysetup/modest-easysetup-wizard.c:
3272 (create_page_custom_incoming), (create_page_custom_outgoing):
3273 * src/maemo/modest-account-settings-dialog.c:
3274 (create_page_account_details), (create_page_incoming),
3275 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3276 instead of using gtk_check_button_with_label(), so they are aligned like the other
3277 widgets, as per the UI spec.
3279 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3281 * src/maemo/easysetup/modest-easysetup-wizard.c:
3282 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3283 * src/widgets/modest-validating-entry.c:
3284 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3285 Modest prefix instead of an EasySetup prefix.
3287 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3289 * src/widgets/modest-validating-entry.h:
3290 * src/widgets/modest-validating-entry.c: (on_insert_text),
3291 Added easysetup_validating_entry_set_max_func(), used to set a callback
3292 to call when the max number of characters is reached. GtkEntry has a max-length
3293 already but is silent about it.
3295 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3296 (create_page_account_details), (create_page_user_details),
3298 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3299 (create_page_account_details), (create_page_user_details),
3300 (create_page_outgoing):
3301 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3302 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3303 the UI spec, when the user tries to enter more than the max number of characters.
3305 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3307 * src/maemo/easysetup/modest-easysetup-wizard.c:
3308 (create_page_user_details), (create_page_custom_incoming),
3309 (create_page_custom_outgoing):
3310 * src/maemo/modest-account-settings-dialog.c:
3311 (create_page_user_details), (create_page_incoming),
3312 (create_page_outgoing):
3313 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3314 (modest_connection_specific_smtp_edit_window_init):
3315 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3316 not appropriate. Bad Maemo-specific defaults!.
3318 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3320 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3321 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3322 (modest_signature_editor_dialog_set_settings):
3323 Disable the label and textview when the checkbox is disabled, and use the
3324 specified (UI spec) default signature text.
3326 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3328 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3329 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3331 * src/modest-defs.h:
3332 * src/modest-account-mgr-helpers.h:
3333 * src/modest-account-mgr-helpers.c:
3334 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3336 * src/maemo/Makefile.am:
3337 * src/maemo/modest-signature-editor-dialog.c:
3338 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3341 * src/maemo/modest-account-settings-dialog.h:
3342 * src/maemo/modest-account-settings-dialog.c:
3343 (modest_account_settings_dialog_finalize), (on_button_signature),
3344 (save_configuration): Use the new dialog when the Edit button is pressed, and
3345 save the changes if necessary, as per the UI spec.
3347 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3349 * src/maemo/Makefile.am:
3350 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3351 based on maemo-develoers email from Dirk.
3353 * src/maemo/easysetup/modest-easysetup-wizard.c:
3354 (create_page_welcome), (create_page_account_details),
3355 (create_page_user_details), (create_page_complete_easysetup),
3356 (create_page_custom_incoming), (create_page_custom_outgoing),
3357 (create_page_complete_custom),
3358 (modest_easysetup_wizard_dialog_init):
3359 * src/maemo/modest-account-settings-dialog.c:
3360 (create_page_account_details), (create_page_user_details),
3361 (create_page_incoming), (create_page_outgoing),
3362 (modest_account_settings_dialog_init):
3363 * src/maemo/modest-connection-specific-smtp-window.c:
3364 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3366 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/easysetup/modest-easysetup-wizard.c:
3369 (create_page_account_details), (create_page_custom_outgoing),
3370 (create_page_complete_custom):
3371 * src/maemo/modest-account-settings-dialog.c:
3372 (create_page_user_details), (create_page_incoming),
3373 (create_page_outgoing):
3374 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3375 (modest_connection_specific_smtp_edit_window_init):
3376 Use the correct (UI spec) port min/max, and use horizontal separators,
3379 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3381 * src/maemo/easysetup/modest-easysetup-wizard.c:
3382 (set_default_custom_servernames):
3383 * src/maemo/modest-account-settings-dialog.c:
3384 (create_page_incoming), (on_combo_outgoing_security_changed),
3385 (on_combo_incoming_security_changed), (create_page_outgoing),
3386 (modest_account_settings_dialog_set_account_name),
3387 (save_configuration):
3388 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3389 (on_combo_security_changed),
3390 (modest_connection_specific_smtp_edit_window_init),
3391 (modest_connection_specific_smtp_edit_window_set_connection),
3392 (modest_connection_specific_smtp_edit_window_get_settings):
3393 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3396 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3399 * src/maemo/easysetup/modest-easysetup-wizard.c:
3400 (create_page_custom_outgoing), (create_page_complete_custom):
3401 * src/maemo/modest-account-settings-dialog.c:
3402 (create_page_user_details), (create_page_outgoing):
3403 * src/maemo/modest-account-view-window.c: (button_box_new):
3404 Use changed logical IDs as per the most recent UI spec:
3405 mcen_bd_emailsetup_edit -> mcen_bd_edit
3406 mcen_bd_emailsetup_delete -> mcen_bd_delete
3407 mcen_bd_emailsetup_close -> mcen_bd_close
3409 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3413 * src/dbus_api/Makefile.am:
3414 * src/dbus_api/modest-dbus-callbacks.c:
3415 * src/dbus_api/modest-dbus-callbacks.h:
3416 * src/maemo/modest-platform.c: (modest_platform_init):
3417 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3419 * tests/Makefile.am:
3420 * tests/dbus_api/Makefile.am:
3421 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3423 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3425 * src/maemo/modest-account-settings-dialog.c:
3426 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3427 Removed unnecessary includes.
3429 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3431 * src/maemo/easysetup/modest-easysetup-wizard.c:
3432 * src/maemo/modest-account-settings-dialog.c:
3433 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3434 * src/widgets/Makefile.am:
3435 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3436 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3437 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3438 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3439 * src/widgets/modest-secureauth-combo-box.c:
3440 * src/widgets/modest-secureauth-combo-box.h:
3441 * src/widgets/modest-serversecurity-combo-box.c:
3442 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3443 made the GObject names more consistent with the rest of the Modest code.
3445 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3447 * src/maemo/easysetup/Makefile.am:
3448 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3449 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3450 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3451 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3452 * src/maemo/easysetup/modest-easysetup-wizard.c:
3453 * src/maemo/easysetup/modest-validating-entry.c:
3454 * src/maemo/easysetup/modest-validating-entry.h:
3455 * src/maemo/modest-account-settings-dialog.c:
3456 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3457 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3458 widgets/ because they are used outside of easysetup too. After checking in,
3459 svn will allow me to rename them too.
3461 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3463 * src/gnome/modest-msg-edit-window.c:
3464 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3465 linker error, to fix the build on the GNOME platform.
3466 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3467 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3468 ifdefed out to avoid a warning.
3470 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3472 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3473 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3474 some alternative for GTK+ 2.6.
3476 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3478 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3480 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3481 specified for EmailAccountsDialog in UI spec.
3483 * src/maemo/easysetup/modest-easysetup-wizard.c:
3484 * src/maemo/easysetup/modest-easysetup-wizard.h:
3485 * src/maemo/modest-account-settings-dialog.c:
3486 * src/maemo/modest-account-settings-dialog.h:
3487 Reuse a member window widget for the connection-specific SMTP server accounts,
3488 so we can tell it to create/save the accounts only if we actually save changes.
3490 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3491 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3492 (modest_connection_specific_smtp_edit_window_get_settings):
3493 Return a struct instance for temporarily remembering the entered data.
3495 * src/maemo/modest-connection-specific-smtp-window.h:
3496 * src/maemo/modest-connection-specific-smtp-window.c:
3497 (modest_connection_specific_smtp_window_finalize),
3498 (modest_connection_specific_smtp_window_fill_with_connections),
3500 (modest_connection_specific_smtp_window_save_server_accounts),
3501 (update_model_server_names): Do not actually save data until asked,
3502 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3504 (on_selection_changed),
3505 (modest_connection_specific_smtp_window_init): Disable the edit
3506 button when nothing is selected.
3508 * src/modest-account-mgr-helpers.c:
3509 * src/modest-account-mgr-helpers.h:
3510 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3513 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3515 * src/modest-account-mgr-helpers.h:
3516 * src/modest-account-mgr-helpers.c:
3517 (modest_account_mgr_get_unused_account_name),
3518 (modest_account_mgr_get_unused_account_display_name): Added these
3519 utility functions, to avoid code duplication.
3521 * src/maemo/easysetup/modest-easysetup-wizard.c:
3522 (create_page_account_details), (create_account):
3523 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3524 (on_combo_security_changed),
3525 (modest_connection_specific_smtp_edit_window_init),
3526 (modest_connection_specific_smtp_edit_window_save_settings):
3527 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3528 * src/maemo/modest-connection-specific-smtp-window.c:
3529 (modest_connection_specific_smtp_window_finalize),
3530 (modest_connection_specific_smtp_window_fill_with_connections),
3531 (on_button_edit), (modest_connection_specific_smtp_window_init):
3532 * src/maemo/modest-connection-specific-smtp-window.h:
3533 Implementing saving of connection-specific server accounts.
3535 But I need to refactor this so we can save the data for each
3536 possible connection-specific account and only actually create the server accounts
3537 when the easysetup finished, or the OK button is pressed on the account settings
3540 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3542 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3543 (on_combo_security_changed):
3544 (modest_connection_specific_smtp_edit_window_init):
3545 Auto-fill the port number as in the account settings.
3547 (modest_connection_specific_smtp_edit_window_set_connection):
3548 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3549 * src/maemo/modest-connection-specific-smtp-window.c:
3550 (fill_with_connections), (on_button_edit),
3551 (modest_connection_specific_smtp_window_init):
3552 Turn the edit window into a dialog to simplify the code, and
3553 set a WM hint as in a GtkDialog, because only a popup can be on top of
3554 another window in Maemo, and popups usually have no WM decoration.
3556 * src/modest-defs.h:
3557 * src/modest-account-mgr-helpers.c:
3558 (modest_account_mgr_set_connection_specific_smtp),
3559 (modest_account_mgr_remove_connection_specific_smtp),
3560 (modest_account_mgr_get_connection_specific_smtp):
3561 * src/modest-account-mgr-helpers.h: Some functions to write the
3562 connection-specific SMTP server information. Not yet used.
3565 * src/widgets/modest-folder-view.c: (text_cell_data):
3566 Fix a warning about an uninitialized variable.
3567 (on_configuration_key_changed): Put an #ifdef around the use
3568 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3570 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3572 * src/maemo/modest-account-settings-dialog.h:
3573 * src/maemo/modest-account-settings-dialog.c:
3574 Added connect_for_modified() utility function to mark the new modified boolean.
3576 (create_page_account_details), (create_page_user_details),
3577 (create_page_incoming), (create_page_outgoing), (on_response),
3578 (modest_account_settings_dialog_init),
3579 (modest_account_settings_dialog_set_account_name):
3580 Only warn about unsaved changes when there are actually unsaved changes.
3582 * src/modest-account-mgr-helpers.c:
3583 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3584 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3585 to get the data from there in future.
3587 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3589 * src/modest-defs.h:
3591 * src/modest-account-mgr-helpers.h:
3592 * src/modest-account-mgr-helpers.c:
3593 Store the security account setting in a single conf key instead of using
3594 the options list, so that the list is left for just the to-be-removed camel hack,
3595 and because gconf_client_set_list() is failing for some reason.
3597 * src/modest-account-mgr.c:
3598 (modest_account_mgr_add_server_account):
3599 * src/maemo/modest-account-settings-dialog.c:
3600 (modest_account_settings_dialog_set_account_name),
3601 (save_configuration): Use the renamed functions.
3604 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3606 * src/widgets/Makefile.am:
3607 * src/widgets/modest-limit-retrieve-combo-box.c:
3608 * src/widgets/modest-limit-retrieve-combo-box.h:
3609 * src/widgets/modest-retrieve-combo-box.c:
3610 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3611 the account settings dialog.
3613 * src/modest-defs.h:
3614 * src/modest-account-mgr-helpers.h:
3615 * src/modest-account-mgr-helpers.c:
3616 (modest_server_account_get_option_secure_auth),
3617 (modest_server_account_set_option_secure_auth):
3618 * src/modest-account-mgr.c:
3619 (modest_account_mgr_add_server_account):
3620 Use the existing AUTH_MECH conf key for the secure-auth setting,
3621 instead of putting it in the list options, because this was actually used already.
3623 * src/maemo/modest-account-settings-dialog.c:
3624 (create_page_account_details),
3625 (modest_account_settings_dialog_set_account_name),
3626 (save_configuration):
3627 * src/maemo/modest-account-settings-dialog.h:
3628 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3629 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3631 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3633 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3634 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3635 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3637 * src/modest-defs.h:
3638 * src/maemo/modest-account-settings-dialog.c:
3639 (create_page_incoming), (on_combo_outgoing_security_changed),
3640 (on_combo_incoming_security_changed), (create_page_outgoing),
3641 (modest_account_settings_dialog_set_account_name),
3642 (save_configuration): Load/Save the port number, and change it when the
3643 security combo changes, to suitable defaults.
3645 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3647 * src/modest-account-mgr.c:
3648 (modest_account_mgr_add_server_account): Set the security and secure-auth
3649 options, and add a comment saying that the other camel-specific options should be
3652 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3654 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3656 * src/modest-tny-account-store.c: (account_list_free),
3657 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3658 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3661 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3663 * src/modest-protocol-info.c:
3664 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3665 is required by our UI spec. Maybe something in our implementation will use this eventually.
3666 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3667 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3668 instead of the previous 0 placeholder.
3670 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3671 secure-auth settings.
3672 * src/modest-account-mgr-helpers.h:
3673 * src/modest-account-mgr-helpers.c:
3674 (modest_server_account_data_get_option_secure_auth),
3675 (modest_server_account_set_option_secure_auth),
3676 (modest_server_account_data_get_option_security),
3677 (modest_server_account_set_option_security): Added this API for getting and setting the security
3678 and secure-auth settings.
3680 * src/maemo/modest-account-settings-dialog.h:
3681 * src/maemo/modest-account-settings-dialog.c:
3682 (modest_account_settings_dialog_finalize), (check_data),
3683 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3684 about changing titles.
3685 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3686 (save_configuration): Save the security and secure-auth settings.
3688 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3689 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3691 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3693 * src/modest-defs.h:
3694 * src/modest-account-mgr.c:
3695 (modest_account_mgr_add_server_account):
3696 Added and used defines for the options key and value pair strings,
3697 that are used so far, though they do not seem to correspond to anything in our
3698 UI specs or ModestProtocol enum.
3700 * src/modest-account-mgr-helpers.h:
3701 * src/modest-account-mgr-helpers.c:
3702 (compare_option_strings_for_name),
3703 (modest_server_account_data_get_option_value),
3704 (modest_server_account_data_get_option_bool),
3705 (modest_account_mgr_get_server_account_option):
3706 Added helper functions for parsing the options GSList.
3708 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3710 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3711 display name is based on the supplied account name.
3712 * src/modest-account-mgr.c:
3713 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3714 with an inefficient, but good-enough, implementation.
3716 * src/maemo/easysetup/modest-easysetup-wizard.c:
3717 (create_page_account_details), (on_before_next), (create_account):
3718 Check for existing display names rather than (non-user-visible) account names, and just
3719 create and set a unique account name at the end.
3721 * src/maemo/modest-account-settings-dialog.c:
3722 (modest_account_settings_dialog_init),
3723 (modest_account_settings_dialog_set_account_name),
3724 (create_page_incoming): Show the display name, instead of the account name.
3725 (on_response): Do some (not all) extra checks, as in the UI spec.
3726 (save_configuration): Save the display name if it was changed.
3728 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3730 * po/en_GB.po: Added needed logical ID and translation.
3731 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3732 (init_view): Made the is-default column clicking work.
3734 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3737 * src/maemo/easysetup/Makefile.am:
3738 * src/maemo/easysetup/modest-easysetup-wizard.c:
3739 (modest_easysetup_wizard_dialog_init):
3740 * src/maemo/easysetup/provider-data-test.keyfile:
3741 * src/maemo/easysetup/provider-data.keyfile:
3742 Moved the provider data file to the new modest-providers-data package and used it from there.
3744 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3746 * src/modest-local-folder-info.c:
3747 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3748 N_() was already used on the static strings, but this just marks it for translation without
3749 using the translation.
3751 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3753 * src/maemo/modest-account-settings-dialog.c:
3754 (create_page_incoming),
3755 (modest_account_settings_dialog_set_account_name):
3756 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3757 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3758 I will do this if nobody else gets there first.
3760 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3762 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3763 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3764 save the security stuff.
3766 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3768 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3769 Set the email address and user fullname, which I now see must be
3772 * src/maemo/modest-account-settings-dialog.h:
3773 * src/maemo/modest-account-settings-dialog.c:
3775 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3776 leave-on-server and authentication.
3777 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3780 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3783 * src/maemo/modest-account-settings-dialog.c:
3784 * src/maemo/modest-account-settings-dialog.h:
3785 Most (but not all) of the widgets are now present as specified by the UI spec.
3786 No changes are yet saved, and some details are not properly shown yet.
3788 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3790 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3792 * src/maemo/Makefile.am:
3793 * src/maemo/modest-account-settings-dialog.c:
3794 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3795 an existing account. Doesn't do much yet.
3797 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3798 Open the accounts settings dialog when Edit is clicked.
3800 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3802 * src/maemo/easysetup/Makefile.am:
3803 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3805 * src/maemo/easysetup/modest-easysetup-wizard.c:
3806 (modest_easysetup_wizard_dialog_init):
3807 Try to get the source directory from the build system,
3808 instead of hard-coding "./" into the source code, when opening our local
3809 copies of the configuration files.
3810 But this still fails when opening the wizard from the Accounts window,
3811 maybe because the working directory seems to change at runtime.
3812 So the wizard will fail the second time unless you copy the files into their
3813 proper locations - see the stdout warnings for the paths.
3815 (create_page_account_details),(on_before_next):
3816 Check for existing non-server accounts instead of server accounts,
3817 so the default account name is useful again, and to prevent trying to
3820 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3821 Show the wizard when New is clicked.
3823 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3824 (init_view): Show the column headers, and show the columns that are
3825 specified in the UI specs. However, something in Maemo's GTK+ prevents
3826 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3827 change the default account. This is despite unsetting the special properties.
3829 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3831 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3832 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3833 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3834 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3835 to make that clearer.
3836 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3838 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3840 * src/maemo/modest-account-view-window.c:
3841 (modest_account_view_window_init),
3842 (modest_account_view_window_new):
3843 Use the same buttons as specified in the
3844 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3845 the existing widgets, which never had a chance of working.
3846 Put the ModestAccountView treeview in a scrolled window.
3847 Do not repeat the initialization in both _init() and _new().
3849 * src/widgets/modest-account-view.c: (update_account_view):
3850 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3851 this widget and window shows no accounts.
3853 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3855 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3857 * src/maemo/easysetup/modest-easysetup-wizard.c:
3858 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3859 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3860 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3863 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3864 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3865 accounts exist yet, as in the UI spec.
3867 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3869 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3871 * src/maemo/Makefile.am:
3872 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3873 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3874 New window for editing connection-specific smtp details.
3875 Not fully implemented.
3877 * src/maemo/modest-connection-specific-smtp-window.c:
3878 (modest_connection_specific_smtp_window_finalize) :
3879 unref the tree model.
3880 (on_button_edit): Show the edit window.
3882 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3884 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3887 * src/maemo/Makefile.am:
3888 * src/maemo/modest-connection-specific-smtp-window.c:
3889 * src/maemo/modest-connection-specific-smtp-window.h:
3890 New window for showing the list of connections, for connection-specific
3891 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3892 * src/maemo/easysetup/modest-easysetup-wizard.c:
3893 (create_page_custom_outgoing): Show the new window when the button is clicked.
3895 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3897 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3898 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3899 * src/maemo/modest-msg-edit-window.c:
3900 (modest_msg_edit_window_insert_image):
3901 * src/modest-conf.c: (modest_conf_key_escape):
3902 * src/modest-mail-operation.c:
3903 (modest_mail_operation_send_new_mail):
3904 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3905 (modest_ui_actions_on_new_account):
3906 * src/widgets/modest-attachment-view.c: (update_filename_request):
3907 * src/widgets/modest-mail-header-view.c:
3908 Corrected warnings that were breaking the build, by commenting out unused variables,
3909 and a function, and by including a header.
3911 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3913 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3914 so we can #ifdef around platform-specific code when necessary.
3915 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3916 to allow this to build for the GNOME platform too.
3918 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3920 * src/maemo/easysetup/modest-easysetup-wizard.c:
3921 Added util_increment_name() and used it in create_page_account_details()
3922 to make sure that the default account name is always a new name.
3924 (modest_easysetup_wizard_dialog_init),
3925 (set_default_custom_servernames): Some minor memory management fixes.
3927 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3931 * src/modest-runtime.c: (init_i18n): Restored the translation
3932 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3933 are defined in config.h, and the translations are installed.
3935 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3936 is defined for translation.
3938 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3940 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3942 * src/maemo/easysetup/modest-easysetup-wizard.c:
3943 (modest_easysetup_wizard_dialog_init):
3944 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3945 Use realistic paths (though they should use $prefix generically) to the
3946 mcc_mapping and provider-data.keyfile files which might work when they
3947 are installed by the future version of the operator-wizard package,
3948 and then fallback to paths in our source code, with an explanatory
3951 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3955 * src/maemo/Makefile.am:
3956 * src/maemo/easysetup/: Added files from the previously-exernal
3957 osso-modest-easysetup.
3958 * src/maemo/modest-main-window-ui.h:
3959 * src/modest-ui-actions.c:
3960 * src/modest-ui-actions.h:
3961 Added modest_ui_actions_on_new_account() as a signal handler for the
3962 New Account menu item. It shows the easysetup wizard.
3963 * po/en_GB.po: Added additional needed logical IDs and translations.