1 2007-07-09 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-utils.c: (on_hide),
4 (modest_maemo_show_dialog_and_forget): Handle the response, because
5 the window is not even hidden by default.
7 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
8 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
9 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
10 which seems to prevent some modality problems.
12 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
13 Ignore user cancellation errors.
15 * src/modest-account-mgr-helpers.h:
16 * src/modest-account-mgr-helpers.c:
17 Added modest_server_account_get_password() and
18 modest_server_account_get_has_password() to avoid direct use of
21 * src/maemo/modest-account-settings-dialog.h:
22 * src/maemo/modest-account-settings-dialog.c:
23 (modest_account_settings_dialog_init): Store the notebook so we can
25 Added modest_account_settings_dialog_switch_to_user_info().
27 * src/modest-tny-account-store.c:
28 (get_password): When the password in the account settings is wrong (we think),
29 show the relevant page of the account settings dialog, in the mainloop.
30 However, we currently get many of these at once because cancel does not
32 (forget_password): Do not forget the password
33 from the account settings, because this causes side-effects when
34 tinymail seems to call it at strange time, maybe because of how we
35 are cancelling get_password().
36 (modest_tny_account_store_alert): Ignore user cancellations.
38 2007-07-09 Murray Cumming <murrayc@murrayc.com>
40 * src/maemo/modest-maemo-utils.h:
41 * src/maemo/modest-maemo-utils.c:
42 Added modest_maemo_show_information_note_and_forget() for use instead of
43 gtk_dialog_run() when the response is not needed, to avoid an extra
44 mainloop which could cause a hang.
46 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
47 Use the logical IDs for the error message, though they are not
48 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
49 because gtk_dialog_run() caused a hang here (the window did not close).
50 This fixes projects.maemo.org bug NB#62646.
52 2007-07-09 Murray Cumming <murrayc@murrayc.com>
54 * src/modest-account-mgr-helpers.h:
55 * src/modest-account-mgr-helpers.c:
56 Added modest_account_mgr_get_store_protocol().
58 * src/maemo/modest-account-view-window.c:
59 (on_delete_button_clicked): Show different warning text depending on
60 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
61 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
64 2007-07-09 Murray Cumming <murrayc@murrayc.com>
66 * src/maemo/modest-msg-edit-window.c:
67 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
68 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
70 2007-07-07 Armin Burgmeier <armin@openismus.com>
72 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
73 ckdg_ib_maximum_characters_reached from correct package.
75 * src/modest-ui-actions.c: Show an error message when a folder could
76 not be created. Tinymail does not give us specific error codes about
77 what has gone wrong, so we assume that a folder with that name
78 already exists, though there might be other reasons.
80 2007-07-06 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
83 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
84 give a more exact error message that can be partly translated.
86 2007-07-05 Murray Cumming <murrayc@murrayc.com>
88 * src/maemo/modest-address-book.c:
89 (select_email_addrs_for_contact): Specify a default window size for the
90 select-email-address dialog, so that it is probably big enough for the
91 title. This should fix projects.maemo.org bug NB#62277.
93 2007-07-05 Murray Cumming <murrayc@murrayc.com>
95 * src/maemo/easysetup/modest-easysetup-wizard.c:
96 (create_page_complete_easysetup): Use
97 gtk_widget_set_size() request to ensure that the text wraps
100 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
102 * src/maemo/easysetup/modest-easysetup-wizard.c:
103 (on_entry_invalid_character), (create_page_account_details),
104 (create_page_user_details):
105 Use new API of ModestValidatingEntry. But for some reason the banner is
106 not shown. I will have to investigate that further.
108 * src/widgets/modest-validating-entry.c: (on_insert_text),
109 (modest_validating_entry_set_func):
110 * src/widgets/modest-validating-entry.h:
111 Added a new callback function to be able to react to prevented
112 characters whitespaces to e.g show a banner.
114 2007-07-05 Armin Burgmeier <armin@openismus.com>
116 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
117 notification of HildonNumberEditor instead of remembering the port
118 number. Thanks to Johannes for pointing this out.
120 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
122 * src/maemo/easysetup/modest-easysetup-wizard.c:
123 Check if there are any user changes before showing a confirmation
124 dialog (projects.maemo.org NB#60946)
126 2007-07-05 Armin Burgmeier <armin@openismus.com>
128 * src/maemo/modest-account-settings-dialog.c: Remember custom port
129 number at the beginning of the dialog and set the modified flag at the
130 end if the port number has changed. This is necessary because
131 HildonNumberEditor does not support notification when the value has
134 2007-07-05 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-ui-actions.c:
137 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
138 a connection before asking anything else. Correct the check for the destination
139 folder so that it succeeds when online.
140 This fixed projects.maemo.org bug NB#61645.
142 2007-07-05 Murray Cumming <murrayc@murrayc.com>
144 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
145 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
146 to fix projects.maemo.org bug NB#62439.
148 2007-07-05 Murray Cumming <murrayc@murrayc.com>
150 * src/modest-tny-account.c: (on_connection_status_changed):
151 Really do not use tny_device_force_offline() here. See the previous comment.
153 2007-07-04 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-tny-account.c: (on_connection_status_changed):
156 Do not use tny_device_force_offline() when tinymail says that something
157 went wrong with the connection. It seems to report this unnecessarily.
159 2007-07-04 Murray Cumming <murrayc@murrayc.com>
161 * src/maemo/modest-connection-specific-smtp-window.c:
162 (modest_connection_specific_smtp_window_init):
163 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
164 does not seem to have any effect in osso 1.1 (though it works in
165 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
167 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
169 * src/maemo/modest-connection-specific-smtp-window.c:
170 Fix UI specification problems with projects.meamo.org NB#60479
172 2007-07-04 Murray Cumming <murrayc@murrayc.com>
174 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
175 clue when this has failed, because the error dialog is not always shown
176 (at least in earlier version).
178 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
179 GError message, because the generic error dialog is not helpful.
181 'This message is not currently available (can't let a new connection go online)'
182 when trying to open an IMAP message.
184 (_modest_ui_actions_open): Offer a connection when some messages would
185 have to be downloaded and we are offline.
187 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
189 * src/widgets/modest-folder-view.c:
190 Don't check for MERGE type anymore as we use the correct type
192 NOTE: For the last two changes you need to update your tinymail copy
193 because of API changes!
195 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
197 * src/modest-tny-local-folders-account.c:
198 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
199 (see projects.maemo.org NB#61580)
201 2007-07-04 Murray Cumming <murrayc@murrayc.com>
203 * src/modest-tny-account.c: (on_connection_status_changed):
204 Commented out the call to modest_platform_connect_and_wait() because this
205 seems to always hang, and I would like to know if this is the only thing
206 that causes a hang when showing the connection dialog.
207 It is not very useful anyway.
209 2007-07-04 Murray Cumming <murrayc@murrayc.com>
211 * src/maemo/modest-msg-view-window.c:
212 (modest_msg_view_window_select_next_message):
214 * src/modest-platform.h:
215 * src/maemo/modest-platform.c:
216 Added modest_platform_connect_and_wait(), which calls
217 tny_maemo_conic_device_connect() always in the main thread, by calling it
218 in an idle handler and waiting for the idle handler to run. It should be
219 in the main thread because it uses GTK+ UI code. It just returns TRUE
220 if the device is already online.
222 There is some nasty code to ensure that subsequent calls to
223 modest_platform_connect_and_wait() just wait for the first one to finish,
224 by checking repeatedly in another idle handler. This is necessary,
225 because other threads (or even the main thread, via another idle handler)
226 can call modest_platform_connect_and_wait() while
227 modest_platform_connect_and_wait() is running.
229 (modest_platform_connect_and_wait_if_network_account),
230 (modest_platform_connect_and_wait_if_network_folderstore):
231 Convenience functions that calls modest_platform_connect_and_wait() if
232 the account or folder might want network access.
234 * src/modest-mail-operation.c:
235 (modest_mail_operation_update_account):
236 * src/modest-ui-actions.c: (download_uncached_messages),
237 (modest_ui_actions_on_rename_folder), (delete_folder),
238 (modest_ui_actions_on_main_window_move_to),
239 (modest_ui_actions_on_msg_view_window_move_to):
240 * src/widgets/modest-folder-view.c:
241 (drag_and_drop_from_folder_view):
242 Offer a connection if we are offline.
244 * src/modest-tny-account.c: (on_connection_status_changed):
245 Document this as only handling errors during network operations in progress,
246 and replace the idle code with a simple call to
247 modest_platform_connect_and_wait(), which does this instead.
249 2007-07-03 Murray Cumming <murrayc@murrayc.com>
251 * src/modest-tny-account.c:
252 (modest_tny_account_get_special_folder): (util_on_idle),
253 Handle the GError so we can see when tny_folder_store_get_folders()
254 fails, as it currently does while something else is connecting.
256 Added util_run_in_main_thread_and_wait()
257 which uses an idlen handler and mainloop to ensure that the function
258 is called in the main thread.
259 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
260 to make sure that we call attempt the connection in the mainloop only,
261 which might solve some hangs.
263 2007-07-03 Murray Cumming <murrayc@murrayc.com>
265 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
266 be found by their display name. This is never useful.
267 * src/modest-tny-account-store.c: (on_account_removed): Find the account
268 by its ID, instead of trying to use its ID as its display name.
270 * src/modest-tny-account-store.h:
271 * src/modest-tny-account.c:
272 (modest_tny_account_get_special_folder): Add a g_warning() when
273 tny_folder_store_get_folders() returns an empty list for the maildir.
275 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
276 Add a g_warning() when this returns NULL, because that it not allowed
279 2007-07-02 Armin Burgmeier <armin@openismus.com>
281 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
282 note when trying to cancel the wizard. This fixes projects.maemo.org
285 2007-07-02 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-tny-account.h:
288 * src/modest-tny-account.c:
289 (modest_tny_account_new_from_server_account),
290 (modest_tny_account_new_from_server_account_name),
291 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
292 because this must now be set before setting the proto. This is usd in
293 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
294 warning in camel_session_get_service() caused by
295 tny_camel_transport_account_prepare().
297 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
300 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
302 * src/maemo/modest-connection-specific-smtp-edit-window.c:
304 (modest_connection_specific_smtp_edit_window_init):
306 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
309 2007-06-29 Murray Cumming <murrayc@murrayc.com>
311 * src/modest-tny-account.c:
312 (modest_tny_account_new_from_server_account):
313 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
314 now uses to request a connection when it needs one, and which it uses
315 to tell us that something is wrong with the connection, so we can force
316 the accounts offline to prevent further problems.
319 * src/modest-init.c: (init_default_settings):
320 * src/modest-mail-operation.c:
321 (modest_mail_operation_update_account):
322 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
323 This should not be necessary anymore. Do not set the conf key that
324 determined this (it was always TRUE and not set anywhere else).
326 * src/modest-ui-actions.h: Remove unused and unimplemented
327 modest_ui_actions_on_online_toggle_toggled().
329 2007-06-29 Murray Cumming <murrayc@murrayc.com
331 * src/maemo/modest-main-window.c: (connect_signals):
332 Don't connect to delete_event twice. Maybe this was harmless.
334 2007-06-29 Murray Cumming <murrayc@murrayc.com
336 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
337 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
338 Debug output to give some more clue when a folder move is not allowed.
340 2007-06-28 Murray Cumming <murrayc@murrayc.com
342 * src/modest-tny-account.c: (on_modest_file_system_info),
343 (modest_tny_account_get_mmc_account_name):
344 Always call the callback, without checking whether the name has changed.
345 * src/widgets/modest-folder-view.c: (strings_are_equal),
346 (on_model_foreach_set_name), (on_get_mmc_account_name),
347 (text_cell_data): Compare the name here, and use the name from
348 the account rather than from the
349 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
350 if the name was changed after the account was added to the model.
351 That's a tinymail bug but not one that I want to fix now.
353 This finally fixes projects.maemo.org bug NB#59301.
355 2007-06-27 Armin Burgmeier <armin@openismus.com>
357 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
360 2007-06-27 Murray Cumming <murrayc@murrayc.com
362 * src/modest-tny-account.h:
363 * src/modest-tny-account.c:
364 Added modest_tny_account_get_mmc_account_name(), to set the memory
365 card name asynchronously for the given account and then notify.
366 (modest_tny_account_new_for_local_folders): Use this new function instead
367 of using hildon_file_system_info_async_new() directly.
369 * src/widgets/modest-folder-view.c: (text_cell_data):
370 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
371 gtk_tree_model_row_changed() when it is available.
373 This should fix projects.maemo.org bug NB#59301.
375 2007-06-27 Murray Cumming <murrayc@murrayc.com
377 * src/modest-mail-operation.c: (update_account_thread),
378 (get_msgs_full_thread): Fix typo failures in the revert
381 2007-06-27 Murray Cumming <murrayc@murrayc.com
383 * src/maemo/modest-maemo-global-settings-dialog.c:
384 (idle_select_default_focus):
385 * src/modest-mail-operation.c: (idle_notify_progress),
386 (idle_notify_progress_once), (set_last_updated_idle),
387 (update_account_thread), (get_msgs_full_thread):
388 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
389 * src/widgets/modest-header-view.c:
390 (idle_notify_headers_count_changed_destroy),
391 (idle_notify_headers_count_changed):
392 Reverted the additions of gdk_threads_enter/leave(), in case this
393 helps with a startup hang on the device.
395 2007-06-26 Armin Burgmeier <armin@openismus.com>
397 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
398 for supported secure authentication methods from server by
399 gtk_dialog_run(), saving CPU time and a potential race condition.
401 2007-06-26 Armin Burgmeier <armin@openismus.com>
403 * src/maemo/modest-maemo-utils.h:
404 * src/maemo/modest-maemo-utils.c: Added a
405 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
406 only error code to tell the calling code when the user canceled the
409 * src/maemo/modest-account-settings-dialog.h:
410 * src/maemo/modest-account-settings-dialog.c:
411 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
412 message if the retrieval of secure authentication methods was canceled
413 by the user. Perform the check before saving anything to configuration
414 to not end up with half-committed configuration changes, do not show
415 a "Saving to configuration failed" note when authentication methods
416 could not be retrieved.
418 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
421 2007-06-26 Murray Cumming <murrayc@murrayc.com>
423 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
424 Only return the first level of folders under accounts, because the
425 osso-global-search UI spec doesn't want the rest.
426 This fixed projects.maemo.org bug NB#61811.
428 2007-06-26 Murray Cumming <murrayc@murrayc.com>
430 * src/modest-tny-account-store.c:
431 * src/modest-tny-account-store.h:
432 Added modest_tny_account_is_memory_card_account().
433 * src/maemo/modest-main-window.c: (create_details_widget):
434 Show the same information items for the memory card as we show for the
435 local-folders, to fix projects.maemo.org bug NB#59307.
437 2007-06-26 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-tny-account-store.c: (get_password):
440 Added some checks for NULL to maybe prevent crashes, though I think
441 it was Philip's last commit that actually prevented the crash here
442 when creating a first new account.
443 But the new account is still not usable (no messages are shown)
444 until a restart of the application.
446 2007-06-26 Murray Cumming <murrayc@murrayc.com>
448 * src/maemo/modest-maemo-global-settings-dialog.c:
449 (idle_select_default_focus):
450 * src/modest-mail-operation.c: (idle_notify_progress),
451 (idle_notify_progress_once), (idle_notify_update_account_queue),
452 (set_last_updated_idle), (update_account_thread),
453 (notify_get_msgs_full), (get_msgs_full_destroyer),
454 (get_msgs_full_thread):
455 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
456 * src/widgets/modest-header-view.c:
457 (idle_notify_headers_count_changed_destroy),
458 (idle_notify_headers_count_changed):
459 Use gdk_threads_enter() and gdk_threads_enter_leave() in
460 all idle handlers, because some other thread could be blocking
461 the GDK lock, so that it can do GUI stuff.
463 2007-06-26 Murray Cumming <murrayc@murrayc.com>
465 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
466 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
467 (on_idle_send_receive), (on_idle_open_default_inbox):
468 * src/maemo/modest-msg-edit-window.c:
469 (modest_msg_edit_window_attach_file_noninteractive):
470 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
471 to prevent a hang. I don't quite understand why these are necessary,
472 beause we should already be in the main loop. I guess something outside
473 of the main loop is taking the lock.
475 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
476 we are really using URIs, and use files that are more likely to exist.
478 2007-06-26 Murray Cumming <murrayc@murrayc.com>
480 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
481 necessary because configure.ac now defines different variables.
483 2007-06-26 Murray Cumming <murrayc@murrayc.com>
485 * libmodest-dbus-client/libmodest-dbus-client.c:
486 * libmodest-dbus-client/libmodest-dbus-client.h:
487 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
488 libmodest_dbus_client_compose_mail() is what things actually use.
490 * src/dbus_api/modest-dbus-api.h:
491 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
492 * tests/dbus_api/Makefile.am:
493 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
496 2007-06-26 Murray Cumming <murrayc@murrayc.com>
498 * src/modest-init.c: (modest_init_local_folders):
499 For memory-card (or other non local-folders) maildir accounts,
500 always create an Archive folder, so that there is somewhere to put
501 messages. This should be less confusing, because the user does not need
502 to guess that the need to create a folder.
504 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
506 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
507 Fixed icon size by using (50, 50) which is the same as defined by
510 2007-06-25 Armin Burgmeier <armin@openismus.com>
512 * src/widgets/modest-window-mgr.c:
514 * configure.ac: Correctly recognize hildon-notify presence and fixed
515 the build without it being installed.
517 2007-06-25 Murray Cumming <murrayc@murrayc.com>
519 * libmodest-dbus-client/libmodest-dbus-client.c:
520 (libmodest_dbus_client_search): Fix the build. Sorry.
521 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
522 (reply_forward_cb): Initialize variables to fix the build.
524 * src/modest-tny-account-store.c:
525 (modest_tny_account_store_get_tny_account_by): Fix the account URI
526 comparison (a silly typo) so that email search results can be opened
527 when there are more than one account.
529 2007-06-25 Murray Cumming <murrayc@murrayc.com>
531 * libmodest-dbus-client/libmodest-dbus-client.c:
532 (libmodest_dbus_client_search),
533 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
534 instead of 1 second, because the search gets folders and messages from
535 the server, which can take a long time. When it times out,
536 osso-global-search will report no results.
538 We need to specify whether we should search only cached information
539 (maybe with a user preference), and the osso-email-search-plugin
540 API should really be improved to allow that option, and to allow results
541 to be delivered asynchronously in batches.
543 2007-06-25 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
546 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
547 GTK_ICON_SIZE_DIALOG is probably the wrong size.
549 2007-06-25 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
552 that is an empty string. D-Bus seems to give us these instead of NULL.
554 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
556 * src/dbus_api/modest-dbus-callbacks.c:
557 * src/maemo/easysetup/modest-easysetup-wizard.h:
558 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
559 * src/maemo/modest-connection-specific-smtp-edit-window.c:
560 (modest_connection_specific_smtp_edit_window_init):
561 * src/maemo/modest-maemo-global-settings-dialog.c:
563 * src/maemo/modest-maemo-utils.c:
564 (modest_maemo_utils_setup_images_filechooser):
565 * src/maemo/modest-main-window.c: (create_details_widget):
566 * src/maemo/modest-msg-edit-window.c:
567 (modest_msg_edit_window_attach_file_noninteractive),
568 (modest_msg_edit_window_color_button_change),
569 (modest_msg_edit_window_set_zoom):
570 * src/modest-mail-operation.c: (update_account_thread):
571 * src/modest-tny-account-store.c:
572 * src/modest-tny-account.c:
573 * src/widgets/modest-global-settings-dialog.c:
574 * src/widgets/modest-window.h:
578 2007-06-25 Murray Cumming <murrayc@murrayc.com>
580 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
581 * src/modest-search.c: (modest_search_folder),
582 (modest_search_all_accounts): Actually search only in the specified folder,
583 doing a simple match on the folder ID.
584 * src/modest-search.h: Added a folder field to the ModestSearch struct,
585 and added some documentation.
587 2007-06-22 Armin Burgmeier <armin@openismus.com>
589 * src/maemo/modest-maemo-utils.h:
590 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
591 modest_maemo_utils_get_supported_secure_authentication_methods.
593 * src/maemo/easysetup/modest-easysetup-wizard.c:
594 * src/maemo/modest-account-settings-dialog.c: Show correct error if
595 one occured, not just "Server does not support secure authentication".
597 2007-06-22 Murray Cumming <murrayc@murrayc.com>
599 * src/modest-tny-account-store.c: (get_password):
600 Restored the call to tny_account_set_user() because Philip seems to have
601 stopped this from crashing (by not using the freed string). It still does
602 not work, but now we can test it.
604 2007-06-22 Murray Cumming <murrayc@murrayc.com>
606 * src/maemo/modest-msg-edit-window.c: (init_window):
607 Comment out use of an uninitialzed GtkScrolledWindow variable,
608 to fix the build and stop a crash. Yet again.
610 2007-06-22 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-tny-account-store.c: (get_password):
613 Remove the call to tny_account_set_user() because this actually crashes.
614 As mentioned in the last commit, it is known to not work anyway.
616 2007-06-22 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-tny-account-store.c: (get_password):
619 Use tny_account_set_username() to tell tinymail that the username might
620 have changed too. But tinymail ignores this: see projects.maemo.org
622 * src/modest-ui-actions.c:
623 (modest_ui_actions_on_password_requested): Remove the useless attempt to
624 reset the connection when changing the username, and improve the comments.
625 Save the changed username to gconf at least, so it is used when Modest is
628 2007-06-21 Murray Cumming <murrayc@murrayc.com>
630 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
631 Do not use a query, so that we get all folders, including for POP and
632 local-folders. They work as search criteria too.
633 This fixes projects.maemo.org bug NB#57740.
635 2007-06-21 Murray Cumming <murrayc@murrayc.com>
637 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
638 Comment out the use of hildon_notification_set_sound() because it is
639 not declared, to fix the build. Warnings are serious, people.
641 2007-06-21 Armin Burgmeier <armin@openismus.com>
643 * src/maemo/modest-maemo-utils.h:
644 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
645 modest_maemo_utils_get_supported_secure_authentication_methods()
646 to query authentication methods for a specific user. This should fix
647 projects.maemo.org bug NB#61369.
649 * src/maemo/easysetup/modest-easysetup-wizard.c:
650 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
653 2007-06-21 Murray Cumming <murrayc@murrayc.com>
655 * libmodest-dbus-client/libmodest-dbus-client.h:
656 * libmodest-dbus-client/libmodest-dbus-client.c:
657 (modest_dbus_message_iter_get_search_hit),
658 (libmodest_dbus_client_search):
659 Reorganised and commented this.
660 Removed modest_search_hit_free() from the public API because it
663 Added libmodest_dbus_client_get_folders() and
664 modest_folder_result_list_free().
666 * src/dbus_api/modest-dbus-api.h:
667 * src/dbus_api/modest-dbus-callbacks.c:
668 (modest_dbus_req_filter): Commented. Moved most code to
669 on_dbus_method_search() and added on_dbus_method_get_folders().
671 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
672 of the extra D-Bus handler.
674 * tests/dbus_api/Makefile.am:
675 * tests/dbus_api/test_get_folders.c: New test for
676 libmodest_dbus_client_get_folders(). This seems to return an empty list
677 at the moment. That could be the same error that causes the message list
678 to be empty sometimes.
679 This should help with projects.maemo.org bug NB#57740.
681 2007-06-21 Armin Burgmeier <armin@openismus.com>
683 * src/modest-mail-operation.c: Do not call
684 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
685 notify the operation's end after having set the status to CANCELED for
686 the operation queue to listen on. This fixes a deadlock when there
687 were mail operations in the queue during its finalization.
689 * src/modest-singletons.c: Reordered uninitialization of the account
690 manager to happen after the mail operation queue was uninitialized
691 because the mail operation's in the queue might still try to access
692 the account manager (see modest_mail_operation_notify_end()). This
693 fixes a potential crash when terminating the application.
695 2007-06-21 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-search.c:
698 (search_mime_part_and_child_parts): Moved some code here so we
699 can search recursively in child folders.
700 (modest_search_folder): Search in the message as a mime part, instead
701 of just its child mime parts.
702 (read_chunk), (search_mime_part_ogs):
703 Check how many bytes were read, to prevent an endless loop.
704 Searching in message bodies now works. This finishes the fix for
705 projects.maemo.org bug NB#61007.
707 2007-06-20 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
710 Add a g_warning when the item is not a folder.
712 * src/modest-ui-dimming-rules.c:
713 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
714 when selected item is not a folder (for instance, an account), because
715 the UI spec only talks about folders.
716 I am not sure what the UI spec wants, so this might not totally fix
717 projects.maemo.org bug NB#60794.
719 2007-06-20 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
722 (load_from_file): Sort the list. The unsorted list would be more noticeable
723 in non-English locales.
725 * src/maemo/modest-msg-edit-window.c:
726 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
727 warning and fix the build.
729 * src/maemo/modest-progress-bar-widget.c:
730 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
731 avoid a g_warning, and probably to avoid a crash.
733 2007-06-20 Murray Cumming <murrayc@murrayc.com>
735 * src/modest-search.c: (modest_search_folder): Check for a GError
736 when calling tny_folder_get_headers(), to show that this is not the cause
739 2007-06-20 Murray Cumming <murrayc@murrayc.com>
741 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
742 Actually set the body query instead of the subject query.
744 * src/modest-search.c: (search_mime_part_ogs),
745 (search_mime_part_strcmp): Remove extra space from the text/* regex,
746 which would probably cause it to fail if we got this far.
748 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
749 to simplify the code.
750 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
751 be causing search-in-body to fail.
753 2007-06-20 Murray Cumming <murrayc@murrayc.com>
755 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
757 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
758 Better debug message when the folder cannot be found.
759 This should help with fixing projects.maemo.org bug #61287.
760 * src/modest-search.c: (add_hit): Do not leak the furl string.
762 2007-06-20 Murray Cumming <murrayc@murrayc.com>
764 * src/modest-ui-actions.c:
765 (modest_ui_actions_on_folder_selection_changed):
766 Do not special-case TNY_MERGE_FOLDER here, because
767 modest_tny_folder_get_account() already does that. This fixes
768 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
769 shown when the Outbox was selected).
771 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
773 * libmodest-dbus-client/libmodest-dbus-client.c:
774 (_dbus_iter_get_string_or_null): Initialize the string variable in
775 case this helps with Dirk's crash.
777 2007-06-19 Murray Cumming <murrayc@murrayc.com>
779 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
780 though it is not implemented yet (this function is maybe not even used),
781 to avoid breaking ABI in future.
782 * libmodest-dbus-client/libmodest-dbus-client.c:
783 (get_attachments_string): Moved some code into this generic function.
784 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
785 sends email. It is maybe not used.
786 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
787 (on_send_mail): Use attachments.
789 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
790 * src/maemo/modest-msg-edit-window.c:
791 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
792 a filename before using it, to fix projects.maemo.org bug NB#58233.
794 2007-06-19 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
797 Initialize the continue_download variable to fix the build, and probably
798 to fix randome behaviour.
800 2007-06-18 Armin Burgmeier <armin@openismus.com>
802 * src/modest-tny-send-queue.h:
803 * src/modest-tny-send-queue.c: Keep track of the status of messages in
804 the queue so we can later show it in the UI. Replaced
805 modest_tny_send_queue_msg_is_being_sent() by
806 modest_tny_send_queue_get_msg_status().
808 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
810 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
811 gpointer. This probably was not harmful, but just to be sure.
813 2007-06-18 Murray Cumming <murrayc@murrayc.com>
815 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
816 Fix the build, but leave the function broken on Bora, because
817 hildon_uri_action_get_service() does not exist.
818 osso_uri_action_get_service() does not exist either, it seems.
820 2007-06-18 Murray Cumming <murrayc@murrayc.com>
822 * src/modest-tny-account.c:
823 (modest_tny_account_new_from_server_account):
824 Uncommented the url debug output again, because it is useful for
825 debugging, as I said in the comment.
827 2007-06-18 Murray Cumming <murrayc@murrayc.com>
829 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
831 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
832 for Mameo Bora, to fix the build.
834 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
837 Fixed build with hildon < 0.99
839 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
840 Check if the selected account is busy instead of checking all accounts
842 * src/modest-account-mgr-priv.h:
843 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
844 (modest_account_mgr_init), (compare_account_name),
845 (modest_account_mgr_set_account_busy),
846 (modest_account_mgr_account_is_busy):
847 * src/modest-account-mgr.h:
848 Added busy information to the account manager. It possible to
849 set an account to busy or not busy now.
851 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
852 (modest_mail_operation_update_account),
853 (modest_mail_operation_notify_end):
854 Set the account to busy/not busy depending on the operation state.
856 * src/widgets/modest-account-view.c:
857 (modest_account_view_finalize), (get_last_updated_string),
858 (update_account_view), (on_account_busy_changed), (init_view):
859 Show string "Refreshing..." if the account is currently busy.
861 All this fixes projects.maemo.org bug NB#59711
863 2007-06-14 Armin Burgmeier <armin@openismus.com>
865 * src/widgets/modest-attachments-view.h:
866 * src/widgets/modest-attachments-view.c: Added
867 modest_attachments_view_has_attachments() and fixed coordinate
868 transformation in get_att_view_at_coords(). This fixes attachment
871 * src/widgets/modest-msg-view.c: Make use of
872 modest_attachments_view_has_attachments() to decide whether to show
873 attachments in the header.
875 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
877 * src/maemo/modest-connection-specific-smtp-edit-window.c:
878 (on_change), (on_combo_security_changed),
879 (modest_connection_specific_smtp_edit_window_init),
880 (modest_connection_specific_smtp_edit_window_set_connection),
881 (modest_connection_specific_smtp_edit_window_is_dirty):
882 * src/maemo/modest-connection-specific-smtp-edit-window.h:
883 * src/maemo/modest-connection-specific-smtp-window.c:
886 Show an comfirmation dialog for the smpt-edit-window if there are
887 unsaved changes and the user hits cancel.
888 (projects.maemo.org bug NB#60479)
890 2007-06-14 Armin Burgmeier <armin@openismus.com>
892 * src/maemo/easysetup/modest-easysetup-wizard.c:
893 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
894 address" info in banner instead of node, and select all the text as
895 per UI spec. This fixes projects.maemo.org bug NB#60550.
897 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
899 reviewed by: <delete if not using a buddy>
901 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
902 * src/modest-ui-actions.c: (folder_refreshed_cb):
904 2007-06-14 Murray Cumming <murrayc@murrayc.com>
906 * src/widgets/modest-folder-view.c: (filter_row):
907 Explictly filter out the per-account outbox accounts. I don't know why
908 these only sometimes show up, but now they should never show up in the UI.
909 This should fix projects.maemo.org bug NB#60160.
911 2007-06-14 Murray Cumming <murrayc@murrayc.com>
913 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
914 when the toolbar does not exist yet.
915 * src/modest-widget-memory.c: (save_settings_header_view):
916 Added g_warnings() to help us to discover when we are trying to set
917 an empty columns list in gconf.
919 2007-06-14 Murray Cumming <murrayc@murrayc.com>
923 Added modest_init_get_default_header_view_column_ids().
925 * src/modest-widget-memory.c: (restore_settings_header_view):
926 Use the new function to get defaults, if the gconf key is empty,
927 instead of not creating any columns. This seems to fix the
928 empty right-hand pane problems.
930 * src/widgets/modest-header-view.h: Improved documentation.
932 2007-06-13 Murray Cumming <murrayc@murrayc.com>
934 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
935 Revert the use of the display name as the account name, because this
936 is generally wrong and would break the code that follows.
938 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
940 * src/maemo/easysetup/modest-easysetup-wizard.c:
941 (check_for_supported_auth_methods), (on_before_next),
944 More correct fix for projects.maemo.org bug NB# 58991
945 Do not longer accept AUTH_PASSWORD as secure method and choose
946 correct method when creating the account.
948 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
950 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
951 Fixed projects.maemo.org bug NB# 58991
953 2007-06-13 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-init.c: (modest_init_init_core),
956 (modest_init_local_folders): Fixed compilation errors.
958 2007-06-13 Murray Cumming <murrayc@murrayc.com>
960 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
961 Remove unnecessary lib/include, though it is good in principle when needed.
963 * src/modest-init.c: (modest_init_one_local_folder),
964 (modest_init_local_folders):
965 * src/modest-init.h: Initialize the .modest library for memory cards,
966 instead of just doing nothing for them. This should allow us to create
967 folders there, fixing projects.maemo.org bug NB#59297.
969 2007-06-13 Murray Cumming <murrayc@murrayc.com>
971 * libmodest-dbus-client/libmodest-dbus-client.c:
972 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
973 (libmodest_dbus_client_compose_mail),
974 (libmodest_dbus_client_open_message),
975 (libmodest_dbus_client_send_and_receive),
976 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
978 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
979 (on_idle_open_message), (modest_dbus_req_handler),
980 (search_result_to_message), (modest_dbus_req_filter):
981 * src/modest-search.c: (add_hit), (modest_search_folder),
982 (modest_search_all_accounts): Improved debug messages.
984 * tests/dbus_api/test_open_message.c: (main): Improved comments.
986 * src/modest-tny-account-store.c:
987 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
990 2007-06-13 Murray Cumming <murrayc@murrayc.com>
993 2007-06-12 Murray Cumming <murrayc@murrayc.com>
995 * src/modest-tny-account-store.c: (get_server_accounts):
996 Call modest_tny_local_folders_account_add_merged_outbox_folders()
997 even when there are no accounts, so that the Outbox folder is always
998 visible. This fixes projects.maemo.org bug NB#60158.
1000 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1002 * src/maemo/modest-main-window.c: (create_details_widget):
1003 Use the mcen_va_never logical ID.
1005 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1007 * src/dbus_api/modest-dbus-api.h:
1008 * src/dbus_api/modest-dbus-callbacks.c:
1009 (on_idle_open_default_inbox), (on_open_default_inbox),
1010 (modest_dbus_req_handler):
1011 Added a new OpenDefaultInbox method.
1013 * libmodest-dbus-client/libmodest-dbus-client.h:
1014 * libmodest-dbus-client/libmodest-dbus-client.c:
1015 Added libmodest_dbus_client_open_default_inbox() to call the new
1016 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1017 though it should maybe be used by a new osso-email-interface function.
1019 * tests/dbus_api/Makefile.am:
1020 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1023 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1025 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1026 NULL, so that the signals get all the keys. This should not actually
1027 change any behaviour because we currently update everything when anything
1030 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1032 * src/widgets/modest-folder-view.c: (text_cell_data),
1033 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1034 (find_inbox_iter): If tinymail tells us that the folder is
1035 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1036 This causes the inbox to be selected at startup, fixing part of
1037 projects.maemo.org bug NB#56305.
1039 * src/modest-ui-dimming-rules.c:
1040 (modest_ui_dimming_rules_on_tools_smtp_servers):
1041 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1042 the SMTP servers menu item.
1043 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1044 that the SMTP Servers menu item is dimmed when there are no accounts,
1045 as a future version of the UI spec will require. This fixes
1046 projects.maemo.org bug NB#56305.
1048 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1050 * src/maemo/modest-maemo-utils.c:
1051 (modest_maemo_utils_get_supported_secure_authentication_methods):
1052 Added label to dialog instead of unreadable title
1054 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1055 (modest_main_window_new):
1056 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1059 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1060 * src/modest-account-mgr.h:
1061 Added method to avoid code duplication
1063 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1064 (modest_ui_actions_on_send_receive):
1065 Use modest_account_mgr_has_accounts
1067 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/easysetup/modest-presets.c:
1070 (modest_presets_get_info_server_security): Do not report secure auth
1072 * src/modest-protocol-info.c: Use the defines for the gconf key names
1073 for secure authentication. This was not working because we were writing
1074 Password and reading password, and the check was case sensitive.
1075 With this, gmail now works for receiving and sending when created via
1078 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1080 * src/maemo/easysetup/modest-presets.c:
1081 (modest_presets_get_info_server_security): Correct the key name for
1082 SecureSmtp, because it seems to be case-sensitive.
1083 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1084 Do not try to get the 0th notebook page if there are 0 pages, to
1085 avoid a g_warning().
1087 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1089 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1090 Prevent use of the new notification feature for now, because it currently
1091 shows one dialog for each new email, which is annoying.
1093 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1096 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1097 when no country was selected, so that we show the global ones.
1098 * src/maemo/easysetup/modest-presets.c:
1099 (modest_presets_get_providers): Return only the global providers, not
1100 all providers when mmc=0 was requested.
1102 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1104 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1105 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1106 provider ID in the combo.
1108 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1109 Do not show the page numbers, because it would be confusing when we add
1110 the 2 extra pages for the custom setup, when the user chooses the "Other"
1111 provider. This fixes projects.maemo.org bug NB#59028
1113 * src/modest-init.c: (modest_init_init_core),
1114 (modest_init_local_folders):
1115 * src/modest-init.h:
1116 * src/modest-tny-account.c:
1117 (modest_tny_account_new_for_local_folders): Do not create default folders
1118 for the memory card. This should fix projects.maemo.org bug NB#59328.
1120 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1122 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1123 Free the changed_conf_keys string items. They are already freed in the
1124 idle handler if that runs first.
1126 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1128 * src/modest-ui-actions.c:
1129 (modest_ui_actions_on_password_requested): Check that the server name
1130 is not NULL, because I just saw a password dialog with (null) as the
1133 * src/modest-tny-folder.[h|c]: Added
1134 modest_tny_folder_is_memory_card_folder().
1135 * src/modest-ui-dimming-rules.c:
1136 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1137 menu item for memory cards, as per the UI spec (section 7.4). This should
1138 fix projects.maemo.org bug NB#59297.
1140 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1142 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1143 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1144 is another problem with the code, see Murray's comment at line 772)
1146 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1148 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1149 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1150 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1151 (load_from_file), (easysetup_country_combo_box_init),
1152 (easysetup_country_combo_box_get_active_country_ids),
1153 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1154 instead of just one ID, to avoid duplicate country names in the UI.
1156 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1157 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1158 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1159 a single ID, avoiding duplicate providers.
1160 * src/maemo/easysetup/modest-easysetup-wizard.c:
1161 (on_combo_account_country): Adapt to use a list.
1163 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1165 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1166 keys changed in the last X seconds.
1168 * src/modest-account-mgr.h:
1169 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1170 (on_key_change), (modest_account_mgr_class_init),
1171 (modest_account_mgr_init), (modest_account_mgr_finalize):
1172 As the keys are changed, save them in a GSList* and signal that GSList*
1173 further every X seconds, to batch changes, to allow us to do just one
1174 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1175 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1177 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1178 changed signal signature.
1180 * src/modest-conf.c: (modest_conf_set_list),
1181 (modest_conf_on_change): Reenable notification.
1183 (modest_conf_maemo_fake_on_change): Comment out the hack that
1184 notified immediately instead of asynchronously.
1186 * src/widgets/modest-account-view.h:
1187 * src/widgets/modest-account-view.c:
1188 (update_account_view): Select the previously-selected account ID,
1189 if possible. This fixes projects.maemo.org bug NB#56933.
1191 (on_account_changed), (on_account_removed),
1192 (modest_account_view_select_account):
1194 Remove the block/unblock functions
1195 because they were not useful.
1197 * src/maemo/modest-account-view-window.c:
1198 (on_delete_button_clicked), (on_edit_button_clicked),
1199 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1201 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1203 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1204 Improve the error dialog to show Incorrect Account Settings, which seems
1205 clearer, and say that the internal error message (to be removed from the
1206 dialog later) is often misleading.
1207 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1209 * src/modest-tny-account.c:
1210 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1211 URL because this is so useful for debugging on the device.
1213 * src/widgets/modest-serversecurity-combo-box.c:
1214 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1216 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1218 * src/modest-mail-operation.c:
1219 (modest_mail_operation_send_new_mail):
1220 Added a comment about a nasty but apparently harmless message. Details
1221 added to the wiki g_warnings() page.
1223 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1225 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1226 (modest_tny_send_queue_class_init):
1227 Do not use the priv struct because it is empty, to avoid g_warnings
1228 about a non-existant priv struct.
1230 * src/modest-tny-account-store.c:
1231 (modest_tny_account_store_get_server_account),
1232 (modest_tny_account_store_get_transport_account_for_open_connection
1233 ): Do not try to get transport server accounts for local folders,
1234 because they don't have any. This avoids a g_warning().
1236 * src/maemo/modest-main-window.c:
1237 (modest_main_window_notify_send_receive_initied),
1238 (on_configuration_key_changed):
1239 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1240 * src/modest-defs.h:
1241 * src/modest-mail-operation.c:
1242 (modest_mail_operation_update_account):
1243 * src/modest-tny-account-store.h:
1244 * src/modest-tny-account.c:
1245 (modest_tny_account_get_special_folder),
1246 (modest_tny_account_new_for_local_folders),
1247 (modest_tny_account_new_for_per_account_local_outbox_folder):
1248 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1249 * src/modest-tny-local-folders-account.c:
1250 (add_account_folders_to_merged_folder):
1251 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1252 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1253 (modest_ui_actions_on_send):
1254 * src/widgets/modest-folder-view.c: (update_model):
1255 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1256 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1257 modest_tny_account_store_get_tny_account_by_account() to
1258 modest_tny_account_store_get_server_account() to make the code clearer.
1260 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1262 * src/dbus_api/modest-dbus-api.h:
1263 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1264 * src/maemo/modest-msg-edit-window.c:
1265 (modest_msg_edit_window_attach_file_noninteractive):
1266 added g_warning in case the file to be attached does not exist
1267 * tests/dbus_api/test_compose_mail.c: (main):
1268 removed obsolete comment, added generic files as test case
1270 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-tny-account-store.c: (get_server_accounts):
1273 Create the local folders account only once, not once for each outbox, and
1274 not only when there are some outboxes.
1276 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1278 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1279 code that is causing a crash at startup. Sergio says that he is fixing this.
1281 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1283 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1284 * src/maemo/modest-account-settings-dialog.c:
1285 (create_page_outgoing),
1286 (modest_account_settings_dialog_set_account_name),
1287 (save_configuration):
1288 - Fixed handling of the "Use secure authentication" toggle to comply with
1289 the ui specification. See also projects.maemo.org bug NB#58400
1291 - Restore the Secure connection setting combo correctly when loading
1294 * src/maemo/modest-maemo-utils.c:
1295 (on_camel_account_get_supported_secure_authentication),
1296 (modest_maemo_utils_get_supported_secure_authentication_methods):
1297 Fixed a crasher if operation is canceled
1299 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1300 (modest_protocol_info_auth_is_secure):
1301 * src/modest-protocol-info.h:
1303 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1304 the sense of the "Use secure authentication" toggle.
1306 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1308 * src/modest-tny-account-store.h:
1309 * src/modest-tny-account-store.c:
1310 Added modest_tny_account_store_get_local_folders_account().
1312 * src/modest-tny-folder.h:
1313 * src/modest-tny-folder.c:
1314 (modest_tny_folder_get_account):
1315 Added this replacement for tny_folder_get_account() which returns
1316 the local-folders account for TnyMergeFolders, to avoid the
1317 warning about the unimplemented get_account_func() vfunc().
1319 (modest_tny_folder_get_rules),
1320 * src/modest-ui-actions.c:
1321 (modest_ui_actions_on_folder_selection_changed):
1322 * src/modest-mail-operation.c:
1323 (modest_mail_operation_remove_folder),
1324 (modest_mail_operation_xfer_folder),
1325 (modest_mail_operation_rename_folder),
1326 (modest_mail_operation_get_msg),
1327 (modest_mail_operation_get_msgs_full),
1328 (modest_mail_operation_remove_msg),
1329 (modest_mail_operation_xfer_msgs),
1330 (modest_mail_operation_refresh_folder):
1331 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1333 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1335 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1336 (modest_server_account_set_security):
1337 * src/modest-defs.h: Add comments explaining that our
1338 UI spec means TLS when it says Normal, so these do not look like errors.
1340 * src/modest-tny-account.c:
1341 (modest_tny_account_new_from_server_account): Use the new tinymail
1342 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1343 for TLS. This should fix projects.maemo.org bug NB#58460.
1345 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1347 * src/maemo/easysetup/modest-easysetup-wizard.c:
1348 (create_account): Correct the position of the gconf sanity check warning.
1349 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1350 of using the g_idle_add() hack, because this does not seem to be necessary
1351 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1352 caused by something other than maemo's gconf.
1353 This fixes projects.maemo.org bug #59022.
1355 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1357 * src/modest-account-mgr-helpers.c:
1358 (modest_account_mgr_get_default_account): Do not check that the account
1359 exists if there is no default account (NULL), to fix a runtime warning.
1361 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1363 * src/widgets/modest-folder-view.c: (update_model):
1364 Do not unref the treemodel before we have finished with it.
1365 This prevents a valgrind warning and an occasional crash at startup.
1367 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1369 * libmodest-dbus-client/libmodest-dbus-client.h:
1370 added libmodest_dbus_client_compose_mail()
1371 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1373 added functions needed for SendAsMail() functionality
1374 * src/maemo/modest-msg-edit-window.c:
1375 (modest_msg_edit_window_attach_file_noninteractive):
1376 non interactively attaching files to message edit window
1377 * src/widgets/modest-msg-edit-window.h:
1378 * tests/dbus_api/Makefile.am:
1379 added test_compose_mail.c
1380 * tests/dbus_api/test_compose_mail.c: (main):
1382 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1384 * src/modest-account-view.c:
1385 Fixed bug projects.maemo.org bug NB#59307
1387 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1389 * src/maemo/easysetup/modest-easysetup-wizard.c:
1390 (get_serverport_incoming), (on_before_next), (create_account):
1391 * src/maemo/modest-account-settings-dialog.c:
1392 (modest_account_settings_dialog_set_account_name):
1393 * src/maemo/modest-maemo-utils.c:
1394 (on_camel_account_get_supported_secure_authentication_status),
1395 (on_camel_account_get_supported_secure_authentication),
1396 (on_secure_auth_cancel),
1397 (modest_maemo_utils_get_supported_secure_authentication_methods):
1399 Implemented security authentication for settings and easysetup.
1401 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/modest-main-window.c: (create_details_widget):
1404 Show the total size for memory card accounts too, instead of showing
1405 the name again. Fixes bug projects.maemo.org bug NB#59307.
1407 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1410 * src/modest-tny-simple-folder-store.c:
1411 * src/modest-tny-simple-folder-store.h: Removed.
1413 * src/modest-tny-local-folders-account.h
1414 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1415 for the local-folders maildir, with an extra TnyMergedFolder containing
1416 the folders of the per-account outbox store accounts.
1417 * src/modest-tny-account-store.c: (get_server_accounts):
1418 Add the outboxes to the special local folders account after creating it.
1420 * src/modest-tny-account.c:
1421 (modest_tny_account_new_for_local_folders): Create the derived
1422 account when creating the main local-folders account.
1424 * src/maemo/modest-main-window.c: (create_details_widget),
1425 (modest_main_window_set_contents_style):
1426 Adapted to the use of the derived account instead of the folder store.
1428 * src/modest-ui-actions.c:
1429 (modest_ui_actions_on_folder_selection_changed):
1430 * src/modest-ui-dimming-rules.c:
1431 (modest_ui_dimming_rules_on_new_folder):
1432 * src/widgets/modest-folder-view.c: (text_cell_data),
1433 (icon_cell_data), (filter_row), (update_model),
1434 (get_cmp_rows_type_pos):
1437 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1438 Do not get the priv struct, because no priv struct has been set,
1439 to avoid a runtime warning.
1441 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1442 #ifelse with #else, to fix a warning, to fix the build.
1445 2007-06-05 Christian Kellner <ckellner@openismus.com>
1447 * libmodest-dbus-client/libmodest-dbus-client.c:
1448 Fix small typo in doc (why do you always see them
1449 AFTER committing stuff?)
1452 2007-06-05 Christian Kellner <ckellner@openismus.com>
1454 * libmodest-dbus-client/libmodest-dbus-client.c:
1455 (libmodest_dbus_client_search):
1456 Initialize hit list with NULL. Also set folder list
1457 to "" if NULL was supplied.
1460 2007-06-03 Christian Kellner <ckellner@openismus.com>
1462 * libmodest-dbus-client/libmodest-dbus-client.c:
1463 (modest_search_hit_list_free):
1464 Make it save to call it with NULL.
1466 * src/dbus_api/modest-dbus-callbacks.c:
1467 * src/modest-search.c:
1468 Return full ModestSearchHits as the search result list not TnyHeader
1469 since can't be around withouth the correspoding TnyFolder.
1471 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1473 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1474 Added currently commented code to check for secure auth
1476 * src/maemo/modest-account-settings-dialog.c: (on_response),
1477 (save_configuration), (show_ok):
1478 Fixed projects.maemo.org bugs NB #59248 and #59251
1480 * src/maemo/modest-maemo-utils.c:
1481 (on_camel_account_get_supported_secure_authentication_status),
1482 (on_camel_account_get_supported_secure_authentication),
1483 (modest_maemo_utils_get_supported_secure_authentication_methods):
1484 * src/maemo/modest-maemo-utils.h:
1485 Moved get_supported_secure_authentication() method here to be able
1486 to use it from easysetup wizard.
1488 * src/modest-pair.c: (on_pair_compare_as_string):
1489 Should compare string with first part of pair and not
1490 strcmp pairs which will crash.
1492 * src/modest-protocol-info.c:
1493 (modest_protocol_info_protocol_is_store):
1494 * src/modest-protocol-info.h:
1495 Added modest_protocol_info_get_auth_protocol_name()
1497 2007-06-03 Armin Burgmeier <armin@openismus.com>
1499 * src/modest-mail-operation.c:
1500 (modest_mail_operation_get_msgs_full): Set priv->account also when
1501 only retrieving a single message. This avoids a crash when canceling
1504 (modest_mail_operation_notify_end): Do not explicitely remove the
1505 operation from the queue but only emit the progress_changed signal.
1506 The queue itself listens to that signal to remove the operation when
1507 it is finished. This reduces coupling and removes a potential deadlock
1508 when modest_mail_operation_notify_end() is called from the queue
1509 itself. If that is a problem performance-wise, I would suggest to
1510 implement a status-changed signal or something.
1512 * src/modest-mail-operation-queue.c: Make sure to never call a
1513 function from another file while the queue is locked. This (hopefully)
1514 fixes another deadlock when exiting the application while retrieving
1517 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1519 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1520 Fixed build if libogs is not available
1522 2007-06-03 Christian Kellner <ckellner@openismus.com>
1524 * libmodest-dbus-client/libmodest-dbus-client.h:
1525 * libmodest-dbus-client/libmodest-dbus-client.c:
1526 (libmodest_dbus_client_delete_message):
1527 Implement deletion of messages (Client side).
1529 (modest_search_hit_free),
1530 (modest_search_hit_list_free):
1531 Utility functions to free the result hits.
1533 * src/dbus_api/modest-dbus-api.h:
1534 * src/dbus_api/modest-dbus-callbacks.c:
1535 (on_delete_message),
1536 (modest_dbus_req_handler):
1537 Implement deletion of messages (Server side).
1539 * tests/dbus_api/test_search.c: (main):
1542 * tests/dbus_api/Makefile.am:
1543 * tests/dbus_api/test_delete_message:
1544 Add little test for the message deletion logic
1546 2007-06-03 Armin Burgmeier <armin@openismus.com>
1548 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1549 when the operation queue was not empty. projects.maemo.org bug
1552 2007-06-03 Armin Burgmeier <armin@openismus.com>
1554 * src/widgets/modest-account-view.c
1555 (on_account_default_toggled): Toggle default account column
1556 explicitely instead of waiting for gconf notification (which is
1557 currently ignored). This should fix projects.maemo.org bug NB#56910
1558 for now. It should probably be removed when gconf notifications are
1561 2007-06-03 Christian Kellner <ckellner@openismus.com>
1563 * libmodest-dbus-client/libmodest-dbus-client.c:
1564 Removed debugging spew.
1566 * src/dbus_api/modest-dbus-callbacks.c:
1567 Added debugging info.
1569 * src/modest-search.c:
1570 (modest_search_all_accounts):
1571 Use tny_account_store_get_accounts () on the account store
1572 to get all accounts which is the way to get all accounts.
1574 * tests/dbus_api/test_search.c: (main):
1575 Make it possible to supply the search term on the command line.
1577 2007-06-03 Christian Kellner <ckellner@openismus.com>
1579 * libmodest-dbus-client/libmodest-dbus-client.c:
1580 * libmodest-dbus-client/libmodest-dbus-client.h:
1581 Implement searching for mesages over raw dbus. (Client side)
1583 * src/dbus_api/Makefile.am:
1584 * src/dbus_api/modest-dbus-api.h:
1585 * src/dbus_api/modest-dbus-callbacks.c:
1586 * src/dbus_api/modest-dbus-callbacks.h:
1587 Search framework (Server side). Also implement on_idle_open_message().
1589 * src/maemo/modest-platform.c: (modest_platform_init):
1590 Prepare for raw dbus/osso rpc interaction.
1592 * src/modest-search.h:
1593 Changed minsize from unspecific guint to guint32.
1595 * src/modest-search.c:
1597 Added strange hack which magically made tnymail work.
1599 (modest_search_folder),
1600 (modest_search_account),
1601 (modest_search_all_accounts):
1602 Implement helper functions to search all accounts, specific account
1605 * tests/dbus_api/Makefile.am:
1606 * tests/dbus_api/test_open_message.c:
1607 Read url to open from commandline.
1609 * tests/dbus_api/test_search.c:
1610 Implement small test for dbus search stuff
1612 2007-06-02 Armin Burgmeier <armin@openismus.com>
1614 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1615 include account type and account title. This fixes projects.maemo.org
1618 * src/maemo/modest-account-view-window.c: Set a title for the window.
1620 2007-06-02 Armin Burgmeier <armin@openismus.com>
1622 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1623 incoming and outgoing server name based on email address and server
1624 types as long as the names have not been edited manually. This fixes
1625 projects.maemo.org bug NB#58671.
1627 2007-06-02 Armin Burgmeier <armin@openismus.com>
1629 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1630 server type cannot be changed in future to the incoming details page
1631 when creating an account. This fixes projects.maemo.org bug NB#59029.
1633 2007-06-02 Armin Burgmeier <armin@openismus.com>
1635 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1636 and assigned max width chars so that they wrap instead of being
1637 truncated. Fixes projects.maemo.org bug NB#56126.
1639 2007-06-02 Armin Burgmeier <armin@openismus.com>
1641 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1642 introductory note to the connection specific smtp servers dialog, as
1643 section 8.12 of the email UI specification requires. This fixes
1644 projects.maemo.org bug NB#59212.
1646 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1648 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1649 Check for running mail operations, and offer to cancel them, as per the UI
1650 spec. This fixes projects.maemo.org bug NB#59041 .
1651 However, I suspect that tinymail may still use the network connection
1652 in ways that we cannot detect or cancel. But it should at least adapt to
1653 changes fairly well.
1655 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1657 * src/modest-tny-account-store.c: (recreate_all_accounts),
1658 (get_cached_accounts), (get_server_accounts): Do more sensible
1659 ref-counting of the temporarily-cached outbox accounts list. This seems
1660 to fix a crash when entering the password when the password was wrong.
1662 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1664 * src/gnome/modest-main-window.c: (connect_signals):
1665 * src/modest-tny-account-store.c: (get_password),
1666 (modest_tny_account_store_alert): Added comments and clues and
1667 commented-out code about how we currently fail to deal with connection
1668 errors and wrong passwords, and how we should.
1670 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1672 * src/widgets/modest-retrieve-combo-box.c:
1673 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1674 This fixes projects.maemo.org bug NB#58472 .
1676 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1678 * src/maemo/easysetup/modest-easysetup-wizard.c:
1679 (create_page_complete_easysetup):
1680 (create_page_complete_custom): Correct the last commit,
1681 putting the correct sentences in the correct pages.
1683 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/easysetup/modest-easysetup-wizard.c:
1686 (create_page_complete_custom): Show the second sentence of text
1687 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1690 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1692 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1693 Set the leave-on-server conf key by default. This fixes
1694 projects.maemo.org bug NB#59258 .
1696 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1698 * src/maemo/modest-account-view-window.c:
1699 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1700 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1703 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1705 * src/maemo/easysetup/modest-easysetup-wizard.c:
1706 (create_caption_new_with_asterisk):
1707 * src/maemo/modest-account-settings-dialog.c:
1708 (create_caption_new_with_asterisk):
1709 Uncomment the code to add the asterisk, because they are no longer in the
1710 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1711 (update_incoming_server_title): Add an asterisk here too.
1713 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1715 * src/maemo/modest-maemo-global-settings-dialog.c:
1716 (current_connection): Check that we are even connected before trying to
1717 get the current connection name, to prevent a warning.
1719 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1720 Change the comments because tny_maemo_conic_device_connect() is now meant to
1722 * src/modest-mail-operation.c:
1723 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1724 make sure we have a connection and fail if we can't connect.
1726 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1728 * src/maemo/modest-main-window.c:
1729 (on_account_store_connecting_finished): Do not try to get the
1730 connection ID if we are not really connected. I am surprised that
1731 this signal handler is called when we are not connected.
1733 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-error.h:
1736 * src/modest-ui-actions.c:
1737 (modest_ui_actions_get_msgs_full_error_handler):
1738 Renamed an enum, added comments, added an enum
1739 for retrieve-limit errors.
1741 * src/modest-mail-operation.c: (foreach_add_item),
1742 (internal_folder_observer_update), (update_account_thread),
1743 (modest_mail_operation_get_msgs_full):
1744 (modest_mail_operation_update_account),
1745 Added comments about how this works, and some code that should
1746 (but does not) check the retrieve-limit. See the TODO comment.
1748 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1750 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1751 Initialize help_id to fix the build. Warnings are good.
1753 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1755 * src/widgets/modest-hbox-cell-renderer.c:
1756 (modest_hbox_cell_renderer_append):
1757 * src/widgets/modest-vbox-cell-renderer.c:
1758 (modest_vbox_cell_renderer_append):
1759 Fix the last commit by doing an extra ref.
1761 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1763 * src/widgets/modest-hbox-cell-renderer.c:
1764 (modest_hbox_cell_renderer_append):
1765 * src/widgets/modest-vbox-cell-renderer.c:
1766 (modest_vbox_cell_renderer_append):
1767 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1768 to fix the build with Maemo Bora.
1769 However, there seems to be a remaining crash, probably due to reference
1772 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1774 * src/modest-tny-account.c:
1775 (modest_tny_account_new_for_local_folders):
1776 Use hildon_file_system_info_async_new() to get a better name for
1777 the memory card account, setting it as the account name.
1778 The timing seems to work, but this is probably
1779 not the best place to do this. See the TODO comment.
1780 * src/maemo/modest-main-window.c: (create_details_widget):
1781 * src/widgets/modest-folder-view.c: (text_cell_data):
1782 Use the tny account name instead of hardcoding a name.
1784 2007-05-30 Christian Kellner <ckellner@openismus.com>
1786 * src/modest-search.c: (modest_search):
1787 Correctly set part_search_func even if we have already parsed
1788 the query and thus a valid OgsTextSearcher object.
1790 2007-05-30 Christian Kellner <ckellner@openismus.com>
1793 Search and check for libogs.
1796 Incooparte the ogs build env.
1798 * src/modest-mime-part-search-stream.c:
1799 * src/modest-mime-part-search-stream.h:
1800 Removed since we do the real searching now in modest-search.c.
1802 * src/modest-search.c:
1803 * src/modest-search.h:
1804 Implement support for ogs. We use that if available and requested
1805 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1806 should now handle the corner case when the search term is spread
1807 across multiple reads.
1808 Also the logic in modest_search () was corrected to search all
1809 requested fields until one is found.
1811 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1813 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1815 * src/modest-init.h:
1816 * src/modest-init.c: Made modest_init_local_folders() take a
1817 path and be public so we can iniitialize maildir folders on
1820 * src/modest-local-folder-info.h:
1821 * src/modest-local-folder-info.c:
1822 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1824 * src/modest-tny-account.c:
1825 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1826 still means the standard local-folders path on the local volume.
1828 * src/modest-tny-account-store.c:
1829 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1830 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1831 all accounts when that happens.
1832 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1833 this too, so it shows up in the treeview.
1835 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1837 * src/maemo/modest-maemo-global-settings-dialog.c:
1838 (current_connection):
1839 * src/widgets/modest-global-settings-dialog.c:
1840 (current_connection_default):
1841 Use the enum values instead of 0, 1 and -1,
1842 to make the code clearer.
1844 * src/modest-account-mgr-helpers.c:
1845 (modest_account_mgr_get_connection_specific_smtp): Make this code
1848 * src/modest-runtime.h:
1849 * src/modest-runtime.c:
1850 Added modest_runtime_remove_all_send_queues().
1851 * src/maemo/modest-main-window.c:
1852 (on_account_store_connecting_finished): Recreate the send queues,
1853 using the appropriate transport accounts for this new connection.
1854 Some futher adapting might be needed if the old send queues are not
1855 automatically stopped at this point.
1857 * src/modest-tny-account-store.c: (get_server_accounts):
1858 Create the connection-specific transport accounts, so that they can
1859 be found later by their ID.
1861 * src/modest-tny-account.h:
1862 * src/modest-tny-account.c:
1863 Added modest_tny_account_new_from_server_account_name().
1864 modest_tny_account_new_from_server_account(): Do not create the
1865 send queues here, because they will be
1866 recreated anyway when the connection changes for the first time.
1868 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1870 * src/modest-local-folder-info.h:
1871 * src/modest-local-folder-info.c:
1872 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1873 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1874 tbox_folder): Take a modest account name instead of a server TnyAccount,
1875 so we can have per-modest-account rather than per-transport-account
1877 We must make sure that we change or recreate the exisitng send queues
1878 when the connection changes for connection-specific transport accounts.
1880 * src/modest-tny-account-store.c:
1881 (create_per_account_local_outbox_folders): Create outboxed per modest
1882 account, not per transport account.
1884 * src/modest-tny-account.h:
1885 * src/modest-tny-account.c:
1886 (modest_tny_account_get_special_folder): For outboxes, get the
1887 parent modest account name. The account is ignored for other folders.
1888 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1889 modest account name rather than a server TnyAccount.
1891 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1893 * src/modest-tny-account.c:
1894 (modest_tny_account_new_from_server_account):
1895 Call modest_runtime_get_send_queue() immediately after creating transport
1896 accounts, so that they start trying to send email from the outbox as soon
1897 as possible at startup. This is probably what we want.
1899 * src/modest-mail-operation.c: (update_account_thread):
1900 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1901 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1902 * src/modest-tny-send-queue.h:
1903 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1904 (modest_ui_actions_on_send):
1905 Added comments about how sending works, though it needs some more work.
1907 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1909 * src/modest-tny-account.c:
1910 (modest_tny_account_get_special_folder): Add TODO because this fails when
1911 the network is busy.
1912 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1913 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1914 Do not try to show this window when there is no active account. The UI
1915 specs does not tell us what to do in this case.
1917 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/Makefile.am:
1922 * src/widgets/Makefile.am: Some dist fixes.
1924 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/modest-connection-specific-smtp-window.c:
1927 (on_button_edit): Make the code clearer, to prevent a double free.
1929 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1931 * src/maemo/modest-account-settings-dialog.c:
1932 (modest_account_settings_dialog_set_account_name),
1933 Check the connection-specific smtp servers checkbox if there are any.
1935 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1936 (modest_connection_specific_smtp_edit_window_init):
1937 Start with a suitable port number.
1939 * src/modest-account-mgr-helpers.h:
1940 * src/modest-account-mgr-helpers.c: Added
1941 modest_account_mgr_get_has_connection_specific_smtp().
1943 (modest_account_mgr_set_connection_specific_smtp),
1944 (modest_account_mgr_remove_connection_specific_smtp),
1945 (modest_account_mgr_get_has_connection_specific_smtp),
1946 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1947 connection-specific smtp server accounts in the account, rather than
1948 the server account conf dir.
1950 This fixes bug projects.maemo.org bug NB#58263 .
1952 * src/modest-tny-account-store.c:
1953 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1954 if there are no server accounts yet, to prevent an infinite loop when there
1955 are no accounts. Document that one must be called before the other.
1957 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1959 * src/modest-account-mgr-helpers.c:
1960 (modest_account_mgr_get_default_account): Make sure that at least
1961 one account is always the default, if there are any enabled accounts.
1962 This is just a sanity check that shouldn't be necessary.
1964 * src/modest-account-mgr-priv.c:
1965 (_modest_account_mgr_account_from_key): Unescape the conf key to
1966 get the real account name. For instance, this is an issue if a space
1967 was in the account name, which can happen because the account name
1968 is generated from the display name.
1969 (_modest_account_mgr_get_account_keyname): Always escape the
1971 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1972 Unescape the conf keys to get the real account names.
1974 For instance, previously the is-default radio button in the accounts
1975 list was not checked for any accounts at first. This fixes that,
1976 and might fix several similar bugs.
1978 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1980 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1981 Removed some debug printfs.
1983 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1985 Modest on-disk outbox directories are now here, for instance:
1986 $HOME/.modest/outboxes/<account-id-1>/outbox
1987 $HOME/.modest/outboxes/<account-id-2>/outbox
1989 $HOME/.modest/local-folders/outbox
1990 so we can have a separate outbox for each account.
1991 But they are shown as one outbox in the GtkTreeView, by using a
1992 TnyMergeFolder in a ModestTnySimpleFolderStore.
1995 * src/modest-tny-simple-folder-store.c:
1996 * src/modest-tny-simple-folder-store.h:
1997 Added ModestTnySimpleFolderStore, used to contain folders from
1998 other folder stores, such as other accounts.
2000 * src/modest-tny-outbox-account.h:
2001 * src/modest-tny-outbox-account.c:
2002 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2003 used for the per-account local outbox folders.
2005 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2006 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2007 only use this (internally) now for the non-outbox local folders.
2009 * src/modest-init.h:
2010 * src/modest-init.c: Added modest_init_one_local_folder(), for
2011 setting up the directory structure for each local folder.
2013 * src/modest-local-folder-info.c:
2014 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2015 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2017 * src/modest-local-folder-info.h:
2018 * src/modest-tny-account-store.c: (on_account_removed),
2019 (on_account_changed), (create_per_account_local_outbox_folders),
2020 (get_server_accounts), (modest_tny_account_store_get_accounts),
2021 (modest_tny_account_store_get_tny_account_by_account),
2022 (modest_tny_folder_store_is_virtual_local_folders):
2024 * src/modest-tny-account.h:
2025 * src/modest-tny-account.c:
2026 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2027 to create an on-disk per-account local outbox folder for each
2029 (create_per_account_local_outbox_folders): Create a local outbox folder
2030 for each transport account.
2031 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2032 for all local folders.
2034 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2035 instead of using g_object_get/set() directly. It is clearer.
2037 (modest_tny_folder_store_get_message_count),
2038 (modest_tny_folder_store_get_local_size
2039 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2040 because we now use these with non-acount folder stores.
2042 (modest_tny_account_get_special_folder),
2043 (modest_tny_account_new_from_server_account),
2044 (modest_tny_account_new_from_account):
2045 (recurse_folders): Adjust to the new outbox system.
2047 * src/modest-tny-folder.h:
2048 * src/modest-tny-folder.c:
2049 (modest_tny_folder_is_local_folder),
2050 (modest_tny_folder_get_local_folder_type),
2051 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2053 * src/widgets/modest-main-window.h:
2054 * src/maemo/modest-main-window.c: (create_details_widget),
2055 (modest_main_window_set_contents_style): Show details for any folder store,
2058 (modest_tny_folder_get_rules):
2059 Remove the const. C does not support constness enough for this.
2061 * src/modest-ui-actions.c:
2062 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2063 make all outboxes appear as one, in the usual local-folders tree node.
2065 (set_active_account_from_tny_account),
2066 (modest_ui_actions_on_folder_selection_changed):
2067 * src/widgets/modest-folder-view.c: (text_cell_data),
2068 (icon_cell_data), (filter_row),
2069 (add_account_folders_to_merged_folder),
2070 (add_account_folders_to_simple_folder_store), (),
2071 (get_cmp_rows_type_pos), (cmp_rows),
2072 (modest_folder_view_set_account_id_of_visible_server_account):
2073 Adjust to the new outbox system, using generic folder stores and folders
2074 in the GtkTreeModel.
2076 2007-05-23 Christian Kellner <ckellner@openismus.com>
2078 * src/modest-mail-operation.c:
2079 (modest_mail_operation_update_account):
2080 Use info->max_size instead of unintialized local var [small
2081 build fix]. (Added TODO to review that change since I don't
2084 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2086 * libmodest-dbus-client/libmodest-dbus-client.c:
2087 (libmodest_dbus_client_compose_mail): function added
2088 * src/dbus_api/modest-dbus-api.h:
2089 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2090 (on_compose_mail): Implementation of the SendAsMail functionality
2092 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2094 * src/modest-account-mgr.c:
2095 (modest_account_mgr_add_server_account): Set the secure-connection
2096 conf key for transport accounts as well as store accounts. I don't know
2097 why the if was there. For instance, this makes sure that we use SSL
2098 for the gmail preset from the easysetup wizard.
2100 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2102 * src/gnome/modest-main-window.c:
2103 (on_account_store_connecting_finished), (connect_signals):
2104 * src/maemo/modest-main-window.c:
2105 (on_account_store_connecting_finished), (connect_signals),
2106 (modest_main_window_new):
2107 Handle TnyAccountStore::connecting-finished instead of
2108 TnyDevice::connection-changed, because we cannot actually perform
2109 operations on accounts until TnyAccountStore has itself responded to
2110 the TnyDevice::connection-changed signal. This prevents a GError from
2112 Do not try to update at startup, because we (at least on scratchbox)
2113 already do an update at startup when the device goes online.
2114 This prevents a GError from tinymail.
2115 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2116 Added TODO about stopping simultaneous operations.
2118 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2120 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2121 * src/modest-mail-operation-queue.c:
2122 (modest_mail_operation_queue_remove):
2123 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2124 about where they happened.
2126 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-ui-actions.c:
2129 (modest_ui_actions_on_password_requested): Make sure that the remember
2130 output parameter is always TRUE.
2132 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2134 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2135 Show a OK/Cancel dialog if the error is a question, though we still do not
2136 know anything more about what we are asking the user.
2137 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2138 Fix an uninitialized variable (helper). This is a logic error, however.
2140 2007-05-21 Christian Kellner <ckellner@openismus.com>
2142 * src/modest-search.h:
2143 Correct bit shifting in the ModestSearchFlags enum.
2145 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2147 * src/modest-tny-account.c:
2148 (modest_tny_account_new_from_server_account): Do not use the lsub and
2149 check-all hard-coded IMAP options when using POP.
2151 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2153 * src/modest-tny-account.c:
2154 (modest_tny_account_new_from_server_account):
2155 Use NULL for the secure-auth method for POP when Password auth has been
2156 specified by the user, as we already do for IMAP. "auth=Login" causes
2157 an error from camel or the server.
2159 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2161 * src/maemo/modest-account-settings-dialog.c:
2162 (create_page_account_details),
2163 (modest_account_settings_dialog_set_account_name):
2164 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2165 for the leave-on-server checkbox, rathr than just the checkbox, when
2166 the protocol is not POP.
2168 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2170 * src/widgets/modest-account-view.c:
2171 * src/widgets/modest-account-view.h:
2172 Added modest_account_view_select_account() which will be useful later
2173 to asynchronously re-select the edited account.
2175 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2177 * src/maemo/modest-account-settings-dialog.c:
2178 (modest_account_settings_dialog_set_account_name):
2179 Automatically choose the port numbers based on the secure authentication
2180 methods, if they have not been chosen before.
2181 This fixes projects.maemo.org bug NB#56273 .
2183 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2185 * src/maemo/modest-main-window-ui.h:
2186 * src/modest-ui-actions.c:
2187 * src/modest-ui-actions.h:
2188 Connect the Tools/SMTP Servers menu item to
2189 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2190 SMTP servers dialog, as in the UI specification and saves changes when it
2191 is closed. This fixed projects.maemo.org bug NB#56305 .
2193 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2195 * src/maemo/modest-connection-specific-smtp-window.c:
2196 (modest_connection_specific_smtp_window_init):
2197 Use gtk_window_set_default_size() to make this window big enough, so
2198 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2200 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2202 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2203 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2204 (modest_connection_specific_smtp_edit_window_init),
2205 Do not try to connect to a combobox signal before the combobox exists.
2206 This fixes the cras in projects.maemo.org bug NB#56288 .
2207 (modest_connection_specific_smtp_edit_window_get_settings):
2208 Remove the server_account_name parameter which was being checked for NULL
2209 though it was not used.
2211 * src/maemo/modest-connection-specific-smtp-window.c:
2212 (modest_connection_specific_smtp_window_fill_with_connections),
2213 (on_button_edit), (modest_connection_specific_smtp_window_init):
2214 Correct the number of treemodel columns to prevent a warning.
2215 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2216 libconic does not work.
2218 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2220 * src/modest-tny-account.c:
2221 (modest_tny_account_new_from_server_account):
2222 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2223 SMTP when "None" was chosen by the user. However, with my SMTP server that
2224 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2227 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2229 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2230 to explain the memory management issue with the ID in the ModestPair.
2232 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2233 (add_sending_page), (modest_account_assistant_finalize):
2234 * src/gnome/modest-gnome-global-settings-dialog.c:
2235 (create_updating_page), (create_composing_page):
2236 * src/gnome/modest-msg-edit-window.c: (get_transports),
2237 (init_window), (modest_msg_edit_window_finalize),
2238 (modest_msg_edit_window_get_msg_data):
2239 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2240 * src/gnome/modest-transport-widget.c:
2241 (modest_transport_widget_finalize), (smtp_configuration):
2242 * src/maemo/modest-maemo-global-settings-dialog.c:
2243 (create_updating_page), (create_composing_page):
2244 * src/maemo/modest-msg-edit-window.c: (get_transports),
2245 (init_window), (modest_msg_edit_window_finalize),
2246 (modest_msg_edit_window_get_msg_data),
2247 (modest_msg_edit_window_free_msg_data):
2248 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2249 (modest_store_widget_finalize):
2250 * src/maemo/modest-transport-widget.c:
2251 (modest_transport_widget_finalize), (smtp_configuration):
2252 * src/modest-main.c: (send_mail):
2253 * src/widgets/modest-combo-box.h:
2254 * src/widgets/modest-global-settings-dialog-priv.h:
2255 * src/widgets/modest-global-settings-dialog.c:
2256 (modest_global_settings_dialog_finalize):
2257 * src/widgets/modest-msg-edit-window.h:
2258 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2259 as long as the combo box, to prevent use of freed memory for the ID.
2261 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2263 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2264 get_accounts(), to make this clearer. Do not check for the enabled gconf
2265 key, because we do not use this for server accounts (at least, not yet).
2266 This allows us to send email again.
2268 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2270 * src/maemo/modest-platform.c:
2271 (on_modest_conf_update_interval_changed), (modest_platform_init):
2272 Only respond to this particular key change. All these strcmp()s cannot be
2275 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2277 * src/maemo/modest-maemo-global-settings-dialog.c:
2278 (current_connection): Prevent a crash in scratchbox when
2279 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2280 * src/maemo/modest-platform.c:
2281 (on_modest_conf_update_interval_changed), (modest_platform_init):
2282 Get the update interval from gconf and reset it when the gconf key changes.
2284 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2286 * src/modest-protocol-info.c:
2287 * src/modest-protocol-info.h: Adde enum-specific get functions,
2288 instead of using a ModestProtocolType enum parameter.
2290 * src/gnome/modest-account-assistant.c:
2291 * src/gnome/modest-store-widget.c:
2292 * src/gnome/modest-store-widget.h:
2293 * src/gnome/modest-transport-widget.c:
2294 * src/gnome/modest-transport-widget.h:
2295 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2296 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2297 * src/maemo/easysetup/modest-easysetup-wizard.c:
2298 * src/maemo/modest-account-settings-dialog.c:
2299 * src/maemo/modest-account-settings-dialog.h:
2300 * src/maemo/modest-store-widget.c:
2301 * src/maemo/modest-store-widget.h:
2302 * src/maemo/modest-transport-widget.c:
2303 * src/maemo/modest-transport-widget.h:
2304 * src/modest-account-mgr-helpers.c:
2305 * src/modest-account-mgr-helpers.h:
2306 * src/modest-account-mgr.c:
2307 * src/modest-account-mgr.h:
2308 * src/modest-tny-account.c:
2309 * src/modest-tny-folder.c:
2310 * src/widgets/modest-account-view.c:
2311 * src/widgets/modest-retrieve-combo-box.c:
2312 * src/widgets/modest-retrieve-combo-box.h:
2313 * src/widgets/modest-secureauth-combo-box.c:
2314 * src/widgets/modest-serversecurity-combo-box.c:
2315 * src/widgets/modest-serversecurity-combo-box.h:
2316 * tests/check_account-mgr.c:
2317 Use the specific functions, and use the re-renamed enum values for GNOME too.
2319 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2321 * src/modest-pair.h:
2322 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2323 so we can get the second based on the first.
2325 * src/maemo/modest-account-settings-dialog.h:
2326 * src/maemo/modest-account-settings-dialog.c:
2327 Added get_supported_secure_authentication_methods(), though it is mostly
2328 commented-out for now until the necessary API is committed to tinymail.
2329 (modest_account_settings_dialog_set_account_name),
2330 (save_configuration): Request the supported authentication methods from the
2331 server, so we can choose a working method.
2333 * src/modest-tny-account-store.h:
2334 * src/modest-tny-account-store.c:
2335 (modest_tny_account_store_get_session): Rename from
2336 tny_account_store_get_session().
2338 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2340 * src/modest-protocol-info.h: Split the ModestProtocol enum
2341 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2342 There was no need to have these unrelated values in one enum.
2344 * src/: many files: Adapted to changed enum. This makes the code a bit
2345 clearer, and the compiler could catch some errors.
2347 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2349 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2350 Show the detailed internal camel error message when an error happens
2351 during the configuration, so that our testers can give us more clues.
2352 For instance, in projects.maemo.org bug NB#56910 .
2354 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2356 * src/modest-tny-account.c:
2357 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2358 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2360 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2362 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2363 * src/maemo/modest-account-settings-dialog.c:
2364 (modest_account_settings_dialog_set_account_name),
2365 (save_configuration): For the incoming secure authentication checkbox,
2366 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2367 the UI specification. PLAIN does not seem to be supported for most IMAP
2368 servers anyway, and I am not sure what it would mean.
2369 However, we probably need to discover which of the secure-authentication
2370 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2371 * src/modest-account-mgr-helpers.c:
2372 (modest_account_mgr_get_server_account_data):
2374 * src/modest-tny-account.c:
2375 (modest_tny_account_new_from_server_account):
2376 Use tny_account_set_mech() to set secure-authentication methods,
2377 with some special-casing for IMAP, based on my observations of how
2380 * src/modest-account-mgr-helpers.h:
2381 * src/modest-account-mgr.c:
2382 * src/modest-defs.h: Comment that the URI is only used for local folders.
2384 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2386 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2387 parameter const, just to be neat.
2388 * src/modest-text-utils.c: (modest_text_utils_inline):
2389 End g_strconcat() with NULL, as its documentation says. This is almost
2390 certainly the cause of my crash at startup on the device. Interestingly,
2391 valgrind doesn't tell us about these errors.
2393 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2395 * scripts/build-packages: Added more precise comments about how to use
2396 this script, though I still get this error:
2397 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2398 error building tinymail
2400 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2402 * src/maemo/modest-main-window.c: (on_account_update):
2403 Very slight cleanup, hoping to make it simpler to discover what causes
2404 a crash here sometimes.
2406 * src/modest-tny-account.c:
2407 (modest_tny_account_new_from_server_account): Set the port. Added
2408 comments about the options and a TODO comment because I need to find out
2409 how to specify the secure authentication method.
2411 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2413 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2414 changed CFlags paths form modest to libmodest
2416 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2418 * src/modest-account-mgr-helpers.c:
2419 (modest_account_mgr_get_server_account_data),
2420 (modest_account_mgr_free_server_account_data):
2421 * src/modest-account-mgr-helpers.h:
2422 * src/modest-account-mgr.c:
2423 (modest_account_mgr_add_server_account):
2424 * src/modest-defs.h:
2425 * src/modest-tny-account.c:
2426 (modest_tny_account_new_from_server_account):
2427 Determine the options for tny_camel_account_add_option() here,
2428 based on the settings, rather than storing them directly in gconf.
2430 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2432 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2433 Show a more friendly error dialog now that we expect (from the tinymail
2434 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2436 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2438 * src/maemo/modest-main-window.c: (on_account_update): Check that
2439 account_name is not NULL, to prevent a crash at startup that I am
2440 seeing on the N800. I do wonder why it is NULL.
2442 * src/maemo/easysetup/modest-easysetup-wizard.c:
2443 (create_page_user_details):
2444 * src/maemo/modest-account-settings-dialog.c:
2445 (create_page_user_details), (create_page_outgoing):
2446 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2447 (modest_connection_specific_smtp_edit_window_init):
2448 * src/modest-ui-actions.c:
2449 (modest_ui_actions_on_password_requested):
2450 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2451 might do something useful with the on-screen keyboard.
2453 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2455 * src/maemo/modest-main-window.c: (on_account_update):
2456 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2457 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2459 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2461 * src/modest-tny-account-store.c: (on_account_changed):
2462 Correct the signature of this signal handler.
2464 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2466 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2467 Show a HildonNote instead of a GtkDialog for Maemo.
2469 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2471 * src/widgets/modest-account-view.h:
2472 * src/widgets/modest-account-view.c: (on_account_changed),
2473 (on_account_removed). Added a boolean flag, set/unset by
2474 modest_account_view_block_conf_updates(),
2475 modest_account_view_unblock_conf_updates() to prevent unnecessary
2476 updates, but this is not very useful because the gconf notifications are
2477 so delays (maybe only on Maemo Bora).
2478 So auto-updating is turned off, and these functions do an explicit
2479 update when necessary.
2480 However, something else is still doing too much work when adding/removing
2481 accounts, probably in another part of the application.
2483 * src/maemo/modest-account-view-window.c:
2484 (on_delete_button_clicked), (on_edit_button_clicked),
2485 (on_new_button_clicked): Use the new functions.
2487 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2489 * src/modest-account-mgr-helpers.c:
2490 (modest_account_mgr_set_first_account_as_default):
2491 Sort the list of names alphabetically-by-title, so we choose the first one
2493 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2494 alphabetically by the title.
2496 This fixes projects.maemo.org bug NB#56418 .
2498 * src/modest-account-mgr-priv.c:
2499 (_modest_account_mgr_account_from_key):
2500 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2501 avoid a valgrind error, and possible random behaviour.
2503 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2505 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2506 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2507 tinymail documentation to say that this can be expected.
2508 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2509 pretty, and should not happen, but I would prefer to know when it does.
2511 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2513 * configure.ac: When using the older hildon version, probably on Bora,
2514 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2516 * src/widgets/modest-attachment-view.c:
2517 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2520 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2522 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2523 Implemented the prototype. Can be tested with
2524 tests/dbus_api/test_open_message:
2526 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2528 * src/modest-tny-account-store.c:
2529 (modest_tny_account_store_instance_init), (get_password):
2530 * src/modest-ui-actions.c:
2531 (modest_ui_actions_on_password_requested):
2532 Do not store the password in gconf, because this function is called
2533 for non-remembered passwords. Actually use the cached (in the hash map)
2534 password instead of releasing it.
2535 The password will now not be remembered if it is asked via the protected
2536 password dialog, as per the UI spec.
2538 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2540 * src/modest-defs.h:
2541 * src/modest-account-mgr-helpers.h:
2542 * src/modest-account-mgr-helpers.c:
2543 Added modest_server_account_get_username_has_succeeded(),
2544 modest_server_account_set_username_has_succeeded().
2545 (modest_server_account_set_username),
2546 Reset the has-succeeded flag if the username changes.
2548 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2549 * src/maemo/modest-connection-specific-smtp-window.c:
2550 (modest_connection_specific_smtp_window_save_server_accounts):
2551 Use modest_server_account_set_username() instead of using
2552 modest_conf_set_string() directly, so that the has-succeeded flag is always
2555 * src/modest-ui-actions.c:
2556 (modest_ui_actions_on_password_requested): Dim the username entry if
2557 the username has ever worked, as per the UI spec.
2559 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2561 * src/modest-tny-account-store.c: (get_password):
2562 * src/modest-ui-actions.c:
2563 (modest_ui_actions_on_password_requested):
2564 Allow the username to be changed too, though there is more work to
2565 be done on exactly how this behaves.
2567 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2569 * src/modest-account-mgr-helpers.h:
2570 * src/modest-account-mgr-helpers.c:
2571 Added modest_account_mgr_get_display_name(),
2572 modest_server_account_get_username(),
2573 modest_server_account_set_username(),
2574 modest_server_account_set_password(),
2575 modest_server_account_get_hostname() functions so we do not need to
2576 use the conf API directly.
2578 * src/maemo/modest-main-window.c: (connect_signals):
2579 Actually connect ot the ModestAccountStore::request-password signal,
2580 so that we show the dialog when the password is requested by Tinymail,
2581 for isntance if it is empty.
2583 * src/modest-marshal.list:
2584 * src/modest-tny-account-store.c:
2585 (modest_tny_account_store_class_init), (get_password),
2586 (modest_tny_account_store_alert):
2587 * src/modest-tny-account-store.h:
2588 * src/modest-ui-actions.h:
2589 * src/modest-ui-actions.c:
2590 (modest_ui_actions_on_password_requested):
2591 Change the signal parameters, so it is obvious that we are providing
2592 the non human-readable server name, and receiving both the username
2593 and password, though changing of the username is not yet implemented.
2594 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2595 for the GNOME version.
2597 This should fix the projects.maemo.org bug NB#56209, though it does not
2598 work on Bora, because the gconf_client_get() for the password fails
2599 immediately after we save it with gconf_client_set().
2601 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2604 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2605 caused an undefined symbol error:
2606 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2608 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2610 * src/modest-tny-account-store.c:
2611 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2612 using a GError instead of a string message, so we can translate it in
2615 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2617 * src/maemo/modest-address-book.c:
2618 (modest_address_book_check_names):
2619 * src/maemo/modest-msg-view-window.c:
2620 (modest_msg_view_window_clipboard_owner_change):
2621 * src/modest-init.c: (modest_init_init_ui):
2622 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2623 (update_folders_cb), (modest_mail_operation_update_account):
2624 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2625 (modest_ui_actions_on_msg_attachment_clicked),
2626 (modest_ui_actions_on_msg_recpt_activated):
2627 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2628 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2629 (modest_msg_view_search_next):
2630 * src/widgets/modest-recpt-editor.c:
2631 (modest_recpt_editor_on_button_release_event),
2632 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2633 g_message(). At this point we should only be seeing interesting errors on
2634 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2636 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2638 (modest_wizard_dialog_force_title_update):
2639 * src/maemo/easysetup/modest-wizard-dialog.h:
2640 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2641 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2642 can update the title when appropriate. Otherwise the title is wrong if the
2643 pages are added after adding the notebook to the dialog.
2644 This must be a problem in HildonWizardDialog too.
2645 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2647 * src/maemo/easysetup/modest-easysetup-wizard.c:
2648 (create_subsequent_customsetup_pages),
2649 (create_subsequent_easysetup_pages):
2650 Call modest_wizard_dialog_force_title_update() so that the title is
2651 correct even with GTK+ < 2.10.
2652 This fixes projects.maemo.org bug NB#56145 .
2654 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2656 * src/maemo/modest-platform.c:
2657 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2658 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2661 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2663 * src/widgets/modest-window.h:
2664 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2665 and modest_window_save_state(), which invokes it.
2667 * src/widgets/modest-window-mgr.h:
2668 * src/widgets/modest-window-mgr.c:
2669 Added modest_window_mgr_save_state_for_all_windows(), which calls
2670 the save_state vfunc on all registered windows, if implemented.
2672 * src/gnome/modest-msg-edit-window.c:
2673 * src/gnome/modest-msg-view-window.c:
2674 * src/maemo/modest-msg-edit-window.c:
2675 * src/maemo/modest-msg-view-window.c:
2676 * src/maemo/modest-main-window.c:
2677 Specify the existing save_settings functions as implementations of
2678 ModestWindow::save_state_func().
2680 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2681 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2682 enabling hibernation, for instance.
2684 We may need to do the same thing for restoring settings.
2687 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2689 * src/widgets/modest-window-mgr.c:
2690 * src/widgets/modest-window-mgr.h:
2691 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2692 modest_window_mgr_get_hibernation_is_prevented().
2694 * src/maemo/modest-main-window.c:
2695 (on_hildon_program_is_topmost_notify): Prevent hibernation
2696 (possible when the application goes to the background in the WM),
2697 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2699 * src/maemo/easysetup/modest-easysetup-wizard.c:
2700 (modest_easysetup_wizard_dialog_init):
2701 * src/maemo/modest-account-settings-dialog.c:
2702 (modest_account_settings_dialog_init):
2703 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2704 (modest_connection_specific_smtp_edit_window_init):
2705 * src/maemo/modest-connection-specific-smtp-window.c:
2706 (modest_connection_specific_smtp_window_init):
2707 * src/maemo/modest-signature-editor-dialog.c:
2708 (modest_signature_editor_dialog_init):
2709 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2710 prevent hibernation while any of these account settings dialogs are open.
2712 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2714 * src/maemo/Makefile.am:
2715 * src/maemo/modest-osso-state-saving.c:
2716 * src/maemo/modest-osso-state-saving.h: Added
2717 modest_osso_load_state() and modest_osso_save_state() though they do
2718 nothing now. They should iterate through all the open windows and load/save
2720 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2721 save state when closing.
2723 * src/maemo/modest-main-window.c:
2724 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2725 Add a notification handler for the HildonProgram::is-topmost property,
2726 so we can allow hibernation when the application goes into the background.
2727 But we still need to detect when the accounts setup windows are open so
2728 we can stop hibernation when they are open.
2729 To do this, I also added the main window the HildonProgram. This might have
2730 other side-effects/benefits, and should maybe be done for other windows.
2732 * src/maemo/modest-osso-autosave-callbacks.h:
2733 * src/maemo/modest-osso-autosave-callbacks.c:
2734 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2735 though it does not do anything yet, and we might never need this to do
2736 anything. For instance, we already save drafts.
2738 * src/maemo/modest-platform.c: (modest_platform_init):
2739 Specify the libosso auto-save callback.
2741 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2743 * src/maemo/modest-platform.c:
2744 (modest_platform_set_update_interval):
2745 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2746 aparently stays valid between application instances, so we can use this
2747 to remove and reset it later. According to a maemo-developers email from
2750 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2752 * configure.ac: Depend on libalarm for Maemo.
2754 * src/dbus_api/modest-dbus-api.h:
2755 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2756 (on_send_receive), (modest_dbus_req_handler):
2757 Handle a SEND_RECEIVE D-Bus method.
2759 * libmodest-dbus-client/libmodest-dbus-client.c:
2760 (libmodest_dbus_client_send_and_receive):
2761 * libmodest-dbus-client/libmodest-dbus-client.h:
2762 Add C convenience functions for calling the new D-Bus method.
2764 * src/modest-platform.h:
2765 * src/gnome/modest-platform.c:
2766 * src/maemo/modest-platform.c:
2767 Added modest_platform_set_update_interval(), which uses the
2768 alarmd API on Maemo.
2769 (modest_platform_init),
2770 Call modest_platform_set_update_interval(), using a hard-coded
2771 interval for now (until the global settings dialog is implemented),
2772 though I am not sure that this makes sense yet.
2774 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2776 * src/dbus_api/modest-dbus-callbacks.c:
2777 (modest_osso_cb_hw_state_handler):
2778 * src/dbus_api/modest-dbus-callbacks.h:
2779 * src/maemo/modest-platform.c: (modest_platform_init):
2780 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2781 in case this has some effect on the ability for Maemo to ping the
2784 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2786 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2787 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2788 warning. It is probably a logic error, but I need to fix the build.
2790 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2792 * src/modest-account-mgr.h:
2793 * src/modest-account-mgr.c:
2794 (modest_account_mgr_account_names): Add a gboolean enabled_only
2795 parameter, so we can get lists of onlt the enabled accounts.
2797 (modest_account_mgr_add_account),,
2798 (modest_account_mgr_account_with_display_name_exists):
2799 * src/maemo/modest-msg-edit-window.c: (get_transports):
2800 * src/modest-account-mgr-helpers.c:
2801 (modest_account_mgr_set_first_account_as_default):
2802 * src/modest-init.c: (init_default_account_maybe):
2803 * src/modest-tny-account-store.c: (get_accounts):
2804 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2805 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2806 * tests/check_account-mgr.c: (START_TEST):
2807 Provide the extra parameter, as appropriate.
2809 * src/widgets/modest-account-view.c: (update_account_view):
2810 Do not show disabled accounts (meaning that there is no way to
2811 enable/disable accounts in the UI (the feature is not in our UI
2812 specification), so we can use this internally only to mark unfinished
2813 or temporary account data.
2815 * src/maemo/easysetup/modest-easysetup-wizard.c:
2816 (create_account): Add boolean enable parameter, so we can specify FALSE
2817 to create the temporary account.
2818 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2819 (on_before_next): When finishing, when there is a temporary account, just
2821 Also, use a timeout to delay the showing of the dialog until gconf is likely
2822 to return correct information, due to a maemo gconf bug that is fixed in
2823 osso 1.1, but not yet in Bora.
2824 However, the dialog stays on screen after it is destroyed.
2826 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2827 for invalid data when cancelling. Use a hildon note instead of a dialog
2828 to complain about invalid data. Do not show the account-saved note if the
2829 account is disabled (a temporary account that will not really be saved for use
2832 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2834 * src/modest-account-mgr-helpers.h:
2835 * src/modest-account-mgr-helpers.c:
2836 Added modest_account_mgr_unset_default_account(),
2837 Added modest_account_mgr_set_first_account_as_default().
2839 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2840 If it was the default account, unset the default account name.
2842 * src/maemo/modest-account-view-window.c:
2843 (on_delete_button_clicked): If it was the default account,
2844 set the first remaining account as the default instead.
2846 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2847 a NULL account or a NULL default account, to prevent a crash. This should
2848 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2851 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2853 * src/widgets/modest-recpt-editor.c:
2854 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2855 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2856 TODO comment for this. This fixes the build.
2858 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2859 be the best place for it. This will in future update all auto-update accounts,
2860 rather than just the current/default account, when that gconf key exists.
2861 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2862 if there are no accounts, before calling do_send_receive().
2863 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2865 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2866 * src/maemo/modest-main-window-ui.h:
2867 * src/maemo/modest-main-window.c: (on_connection_changed),
2868 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2869 directly, becaue the signal handler does more.
2871 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2873 * src/modest-account-mgr-helpers.c:
2874 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2875 for the case that the account does not exist.
2877 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2878 (equivalent to the modest account name) rather than the tinymail account name
2879 (equivalent to the modest account title - human readable) to get the account data.
2880 Check for null account data to prevent the crash, and add a TODO comment saying that
2881 this needs fixing because it is using the server account name instead of the account name.
2883 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2885 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2886 * src/maemo/modest-account-settings-dialog.c: (show_error),
2888 Use hildon_note_new_information() for informative and error messages,
2889 which seems to be expected for Maemo applications (no documentation that I know of
2890 says this). I am surprised that there is no distinction between info and error
2893 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2895 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2896 it is easy to find where this is used.
2898 * src/maemo/easysetup/modest-easysetup-wizard.c:
2899 (create_page_welcome), (create_page_account_details),
2900 (create_page_user_details), (create_page_complete_easysetup),
2901 (create_page_custom_incoming), (create_page_custom_outgoing),
2902 (create_page_complete_custom):
2903 * src/maemo/modest-account-settings-dialog.c:
2904 (create_page_account_details), (create_page_user_details),
2905 (create_page_incoming), (create_page_outgoing):
2906 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2907 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2908 (modest_connection_specific_smtp_edit_window_init):
2909 * src/maemo/modest-connection-specific-smtp-window.c:
2910 (modest_connection_specific_smtp_window_init):
2911 * src/maemo/modest-signature-editor-dialog.c:
2912 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2913 and scrolling policy as per the Email Application Layout Guide, if I have
2916 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2918 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2919 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2920 which were empty, because these vfuncs have been removed from TnyAccountStore.
2921 This fixes the build.
2923 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2925 * src/maemo/modest-main-window.c:
2926 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2927 showing/hiding it. Added TODO because it probably should not be NULL.
2928 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2929 because unnecessary g_warnings() make degugging difficult.
2931 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2933 * src/maemo/modest-msg-edit-window.c:
2934 (modest_msg_edit_window_select_color),
2935 (modest_msg_edit_window_select_background_color): 2 const corrections and
2936 moving 2 #endifs before closing brackets, to fix the build.
2938 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2940 * src/maemo/easysetup/modest-easysetup-wizard.h:
2941 * src/maemo/easysetup/modest-easysetup-wizard.c:
2942 (modest_easysetup_wizard_dialog_finalize),
2943 (on_button_edit_advanced_settings), (create_page_complete_custom),
2944 (on_response), (create_account):
2945 Implement the Advanced Settings edit button, by saving the account information,
2946 for the Advanded Settings dialog to use directly from gconf, and removing it
2947 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2948 Bug #5533 in the projects.maemo.org bugzilla.
2950 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/modest-msg-view-window.c:
2953 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2954 when opening a message window.
2956 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2958 * src/maemo/easysetup/modest-easysetup-wizard.c:
2959 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2962 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2963 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2964 gconf settings. I probably added more checks than necessary, but that is safer.
2966 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2967 variable to fix the build, but this seems to be used when it is still NULL.
2969 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2971 * src/modest-platform.h:
2972 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2973 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2974 * src/modest-main.c: Implement this function so we can avoid using
2975 maemo-specific API from cross-platform code.
2977 * src/modest-tny-account-store.c:
2978 (get_smtp_specific_transport_account_for_open_connection):
2979 * src/modest-ui-actions.c: (check_for_connection),
2980 (modest_ui_actions_on_item_not_found):
2981 Use modest_platform_connect_and_wait() and put #idefs around other
2982 maemo-specific code, because only maemo currently has a way to
2983 identify connection names.
2985 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2987 * src/modest-tny-account-store.h:
2988 * src/modest-tny-account-store.c:
2989 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2990 the connection-specific SMTP server settings in the configuration.
2992 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2994 * src/maemo/modest-main-window.c: (on_connection_changed),
2996 * src/modest-main.c: (main), (start_ui), (send_mail):
2997 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2998 that is what is intended.
3000 * src/modest-ui-actions.c: (action_send), (action_receive),
3001 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3002 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3003 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3004 SMTP server is used when it is specified.
3006 (modest_ui_actions_on_send_receive):
3007 Check that a connection is open before proceeding.
3008 Receive and then send, instead of vice-versa, as per the specification.
3010 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3012 * src/modest-mail-operation.c:
3013 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3014 though I guess it should be something other than NULL.
3016 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3018 * src/maemo/easysetup/modest-easysetup-wizard.c:
3019 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3020 combo twice, to avoid an g_warning and to make it visible again.
3021 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3022 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3023 (already intended) dereference when detaching, because we then recreate the menu.
3024 But I am not sure why the warning was happening, and it is possible that this is a memory
3027 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3029 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3030 and uri_parse_mailto() utility functions.
3031 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3033 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3035 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3037 * src/dbus_api/modest-dbus-api.h:
3038 * src/dbus_api/modest-dbus-callbacks.c:
3039 Use an idle callback to execute the modest code in the application's own thread.
3040 Remove the helloworld example method.
3041 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3042 parsed, and the open-message method is not implemented because this is not yet implemented in
3044 * libmodest-dbus-client/libmodest-dbus-client.c:
3045 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3046 (libmodest_dbus_client_open_message):
3047 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3049 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3050 body without crashing.
3052 * tests/dbus_api/Makefile.am:
3053 * tests/dbus_api/test_mail_to.c:
3054 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3056 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3058 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3059 Added file to fix the build. Sorry.
3061 * src/dbus_api/Makefile.am:
3062 * src/dbus_api/modest-dbus-api.h:
3063 * src/dbus_api/modest-dbus-callbacks.h:
3064 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3065 (modest_dbus_req_handler):
3066 Put constants in a separate header so it can be reused by the
3067 client library, without duplication
3069 * libmodest-dbus-client/Makefile.am:
3070 * libmodest-dbus-client/libmodest-dbus-client.c:
3071 (libmodest_dbus_client_call_helloworld),
3072 (libmodfest_dbus_client_send_mail),
3073 (libmodfest_dbus_client_mailto),
3074 (libmodfest_dbus_client_open_message):
3075 * libmodest-dbus-client/libmodest-dbus-client.h:
3076 (Partly) Implement a send_mail D-Bus method.
3078 * tests/dbus_api/Makefile.am:
3079 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3080 the send_email D-Bus method.
3082 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3086 * libmodest-dbus-client/Makefile.am:
3087 * libmodest-dbus-client/libmodest-dbus-client.c:
3088 * libmodest-dbus-client/libmodest-dbus-client.h:
3089 * tests/dbus_api/Makefile.am:
3090 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3091 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3093 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3095 * src/maemo/easysetup/modest-easysetup-wizard.c:
3096 (create_page_account_details):
3097 * src/maemo/modest-account-settings-dialog.c:
3098 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3099 widgets, because this might not be the default in future versions of the Maemo GTK+.
3100 However, I can not not get capitalization to work even in a simple test case.
3102 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3104 * src/maemo/easysetup/modest-easysetup-wizard.c:
3105 (create_page_custom_incoming), (create_page_custom_outgoing):
3106 * src/maemo/modest-account-settings-dialog.c:
3107 (create_page_account_details), (create_page_incoming),
3108 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3109 instead of using gtk_check_button_with_label(), so they are aligned like the other
3110 widgets, as per the UI spec.
3112 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3114 * src/maemo/easysetup/modest-easysetup-wizard.c:
3115 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3116 * src/widgets/modest-validating-entry.c:
3117 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3118 Modest prefix instead of an EasySetup prefix.
3120 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3122 * src/widgets/modest-validating-entry.h:
3123 * src/widgets/modest-validating-entry.c: (on_insert_text),
3124 Added easysetup_validating_entry_set_max_func(), used to set a callback
3125 to call when the max number of characters is reached. GtkEntry has a max-length
3126 already but is silent about it.
3128 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3129 (create_page_account_details), (create_page_user_details),
3131 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3132 (create_page_account_details), (create_page_user_details),
3133 (create_page_outgoing):
3134 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3135 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3136 the UI spec, when the user tries to enter more than the max number of characters.
3138 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3140 * src/maemo/easysetup/modest-easysetup-wizard.c:
3141 (create_page_user_details), (create_page_custom_incoming),
3142 (create_page_custom_outgoing):
3143 * src/maemo/modest-account-settings-dialog.c:
3144 (create_page_user_details), (create_page_incoming),
3145 (create_page_outgoing):
3146 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3147 (modest_connection_specific_smtp_edit_window_init):
3148 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3149 not appropriate. Bad Maemo-specific defaults!.
3151 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3153 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3154 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3155 (modest_signature_editor_dialog_set_settings):
3156 Disable the label and textview when the checkbox is disabled, and use the
3157 specified (UI spec) default signature text.
3159 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3161 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3162 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3164 * src/modest-defs.h:
3165 * src/modest-account-mgr-helpers.h:
3166 * src/modest-account-mgr-helpers.c:
3167 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3169 * src/maemo/Makefile.am:
3170 * src/maemo/modest-signature-editor-dialog.c:
3171 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3174 * src/maemo/modest-account-settings-dialog.h:
3175 * src/maemo/modest-account-settings-dialog.c:
3176 (modest_account_settings_dialog_finalize), (on_button_signature),
3177 (save_configuration): Use the new dialog when the Edit button is pressed, and
3178 save the changes if necessary, as per the UI spec.
3180 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3182 * src/maemo/Makefile.am:
3183 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3184 based on maemo-develoers email from Dirk.
3186 * src/maemo/easysetup/modest-easysetup-wizard.c:
3187 (create_page_welcome), (create_page_account_details),
3188 (create_page_user_details), (create_page_complete_easysetup),
3189 (create_page_custom_incoming), (create_page_custom_outgoing),
3190 (create_page_complete_custom),
3191 (modest_easysetup_wizard_dialog_init):
3192 * src/maemo/modest-account-settings-dialog.c:
3193 (create_page_account_details), (create_page_user_details),
3194 (create_page_incoming), (create_page_outgoing),
3195 (modest_account_settings_dialog_init):
3196 * src/maemo/modest-connection-specific-smtp-window.c:
3197 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3199 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3201 * src/maemo/easysetup/modest-easysetup-wizard.c:
3202 (create_page_account_details), (create_page_custom_outgoing),
3203 (create_page_complete_custom):
3204 * src/maemo/modest-account-settings-dialog.c:
3205 (create_page_user_details), (create_page_incoming),
3206 (create_page_outgoing):
3207 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3208 (modest_connection_specific_smtp_edit_window_init):
3209 Use the correct (UI spec) port min/max, and use horizontal separators,
3212 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3214 * src/maemo/easysetup/modest-easysetup-wizard.c:
3215 (set_default_custom_servernames):
3216 * src/maemo/modest-account-settings-dialog.c:
3217 (create_page_incoming), (on_combo_outgoing_security_changed),
3218 (on_combo_incoming_security_changed), (create_page_outgoing),
3219 (modest_account_settings_dialog_set_account_name),
3220 (save_configuration):
3221 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3222 (on_combo_security_changed),
3223 (modest_connection_specific_smtp_edit_window_init),
3224 (modest_connection_specific_smtp_edit_window_set_connection),
3225 (modest_connection_specific_smtp_edit_window_get_settings):
3226 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3229 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3232 * src/maemo/easysetup/modest-easysetup-wizard.c:
3233 (create_page_custom_outgoing), (create_page_complete_custom):
3234 * src/maemo/modest-account-settings-dialog.c:
3235 (create_page_user_details), (create_page_outgoing):
3236 * src/maemo/modest-account-view-window.c: (button_box_new):
3237 Use changed logical IDs as per the most recent UI spec:
3238 mcen_bd_emailsetup_edit -> mcen_bd_edit
3239 mcen_bd_emailsetup_delete -> mcen_bd_delete
3240 mcen_bd_emailsetup_close -> mcen_bd_close
3242 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3246 * src/dbus_api/Makefile.am:
3247 * src/dbus_api/modest-dbus-callbacks.c:
3248 * src/dbus_api/modest-dbus-callbacks.h:
3249 * src/maemo/modest-platform.c: (modest_platform_init):
3250 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3252 * tests/Makefile.am:
3253 * tests/dbus_api/Makefile.am:
3254 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3256 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3258 * src/maemo/modest-account-settings-dialog.c:
3259 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3260 Removed unnecessary includes.
3262 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3264 * src/maemo/easysetup/modest-easysetup-wizard.c:
3265 * src/maemo/modest-account-settings-dialog.c:
3266 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3267 * src/widgets/Makefile.am:
3268 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3269 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3270 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3271 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3272 * src/widgets/modest-secureauth-combo-box.c:
3273 * src/widgets/modest-secureauth-combo-box.h:
3274 * src/widgets/modest-serversecurity-combo-box.c:
3275 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3276 made the GObject names more consistent with the rest of the Modest code.
3278 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3280 * src/maemo/easysetup/Makefile.am:
3281 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3282 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3283 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3284 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3285 * src/maemo/easysetup/modest-easysetup-wizard.c:
3286 * src/maemo/easysetup/modest-validating-entry.c:
3287 * src/maemo/easysetup/modest-validating-entry.h:
3288 * src/maemo/modest-account-settings-dialog.c:
3289 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3290 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3291 widgets/ because they are used outside of easysetup too. After checking in,
3292 svn will allow me to rename them too.
3294 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3296 * src/gnome/modest-msg-edit-window.c:
3297 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3298 linker error, to fix the build on the GNOME platform.
3299 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3300 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3301 ifdefed out to avoid a warning.
3303 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3305 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3306 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3307 some alternative for GTK+ 2.6.
3309 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3311 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3313 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3314 specified for EmailAccountsDialog in UI spec.
3316 * src/maemo/easysetup/modest-easysetup-wizard.c:
3317 * src/maemo/easysetup/modest-easysetup-wizard.h:
3318 * src/maemo/modest-account-settings-dialog.c:
3319 * src/maemo/modest-account-settings-dialog.h:
3320 Reuse a member window widget for the connection-specific SMTP server accounts,
3321 so we can tell it to create/save the accounts only if we actually save changes.
3323 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3324 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3325 (modest_connection_specific_smtp_edit_window_get_settings):
3326 Return a struct instance for temporarily remembering the entered data.
3328 * src/maemo/modest-connection-specific-smtp-window.h:
3329 * src/maemo/modest-connection-specific-smtp-window.c:
3330 (modest_connection_specific_smtp_window_finalize),
3331 (modest_connection_specific_smtp_window_fill_with_connections),
3333 (modest_connection_specific_smtp_window_save_server_accounts),
3334 (update_model_server_names): Do not actually save data until asked,
3335 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3337 (on_selection_changed),
3338 (modest_connection_specific_smtp_window_init): Disable the edit
3339 button when nothing is selected.
3341 * src/modest-account-mgr-helpers.c:
3342 * src/modest-account-mgr-helpers.h:
3343 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3346 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3348 * src/modest-account-mgr-helpers.h:
3349 * src/modest-account-mgr-helpers.c:
3350 (modest_account_mgr_get_unused_account_name),
3351 (modest_account_mgr_get_unused_account_display_name): Added these
3352 utility functions, to avoid code duplication.
3354 * src/maemo/easysetup/modest-easysetup-wizard.c:
3355 (create_page_account_details), (create_account):
3356 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3357 (on_combo_security_changed),
3358 (modest_connection_specific_smtp_edit_window_init),
3359 (modest_connection_specific_smtp_edit_window_save_settings):
3360 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3361 * src/maemo/modest-connection-specific-smtp-window.c:
3362 (modest_connection_specific_smtp_window_finalize),
3363 (modest_connection_specific_smtp_window_fill_with_connections),
3364 (on_button_edit), (modest_connection_specific_smtp_window_init):
3365 * src/maemo/modest-connection-specific-smtp-window.h:
3366 Implementing saving of connection-specific server accounts.
3368 But I need to refactor this so we can save the data for each
3369 possible connection-specific account and only actually create the server accounts
3370 when the easysetup finished, or the OK button is pressed on the account settings
3373 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3375 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3376 (on_combo_security_changed):
3377 (modest_connection_specific_smtp_edit_window_init):
3378 Auto-fill the port number as in the account settings.
3380 (modest_connection_specific_smtp_edit_window_set_connection):
3381 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3382 * src/maemo/modest-connection-specific-smtp-window.c:
3383 (fill_with_connections), (on_button_edit),
3384 (modest_connection_specific_smtp_window_init):
3385 Turn the edit window into a dialog to simplify the code, and
3386 set a WM hint as in a GtkDialog, because only a popup can be on top of
3387 another window in Maemo, and popups usually have no WM decoration.
3389 * src/modest-defs.h:
3390 * src/modest-account-mgr-helpers.c:
3391 (modest_account_mgr_set_connection_specific_smtp),
3392 (modest_account_mgr_remove_connection_specific_smtp),
3393 (modest_account_mgr_get_connection_specific_smtp):
3394 * src/modest-account-mgr-helpers.h: Some functions to write the
3395 connection-specific SMTP server information. Not yet used.
3398 * src/widgets/modest-folder-view.c: (text_cell_data):
3399 Fix a warning about an uninitialized variable.
3400 (on_configuration_key_changed): Put an #ifdef around the use
3401 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3403 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3405 * src/maemo/modest-account-settings-dialog.h:
3406 * src/maemo/modest-account-settings-dialog.c:
3407 Added connect_for_modified() utility function to mark the new modified boolean.
3409 (create_page_account_details), (create_page_user_details),
3410 (create_page_incoming), (create_page_outgoing), (on_response),
3411 (modest_account_settings_dialog_init),
3412 (modest_account_settings_dialog_set_account_name):
3413 Only warn about unsaved changes when there are actually unsaved changes.
3415 * src/modest-account-mgr-helpers.c:
3416 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3417 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3418 to get the data from there in future.
3420 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3422 * src/modest-defs.h:
3424 * src/modest-account-mgr-helpers.h:
3425 * src/modest-account-mgr-helpers.c:
3426 Store the security account setting in a single conf key instead of using
3427 the options list, so that the list is left for just the to-be-removed camel hack,
3428 and because gconf_client_set_list() is failing for some reason.
3430 * src/modest-account-mgr.c:
3431 (modest_account_mgr_add_server_account):
3432 * src/maemo/modest-account-settings-dialog.c:
3433 (modest_account_settings_dialog_set_account_name),
3434 (save_configuration): Use the renamed functions.
3437 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3439 * src/widgets/Makefile.am:
3440 * src/widgets/modest-limit-retrieve-combo-box.c:
3441 * src/widgets/modest-limit-retrieve-combo-box.h:
3442 * src/widgets/modest-retrieve-combo-box.c:
3443 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3444 the account settings dialog.
3446 * src/modest-defs.h:
3447 * src/modest-account-mgr-helpers.h:
3448 * src/modest-account-mgr-helpers.c:
3449 (modest_server_account_get_option_secure_auth),
3450 (modest_server_account_set_option_secure_auth):
3451 * src/modest-account-mgr.c:
3452 (modest_account_mgr_add_server_account):
3453 Use the existing AUTH_MECH conf key for the secure-auth setting,
3454 instead of putting it in the list options, because this was actually used already.
3456 * src/maemo/modest-account-settings-dialog.c:
3457 (create_page_account_details),
3458 (modest_account_settings_dialog_set_account_name),
3459 (save_configuration):
3460 * src/maemo/modest-account-settings-dialog.h:
3461 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3462 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3464 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3466 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3467 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3468 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3470 * src/modest-defs.h:
3471 * src/maemo/modest-account-settings-dialog.c:
3472 (create_page_incoming), (on_combo_outgoing_security_changed),
3473 (on_combo_incoming_security_changed), (create_page_outgoing),
3474 (modest_account_settings_dialog_set_account_name),
3475 (save_configuration): Load/Save the port number, and change it when the
3476 security combo changes, to suitable defaults.
3478 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3480 * src/modest-account-mgr.c:
3481 (modest_account_mgr_add_server_account): Set the security and secure-auth
3482 options, and add a comment saying that the other camel-specific options should be
3485 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3487 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3489 * src/modest-tny-account-store.c: (account_list_free),
3490 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3491 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3494 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3496 * src/modest-protocol-info.c:
3497 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3498 is required by our UI spec. Maybe something in our implementation will use this eventually.
3499 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3500 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3501 instead of the previous 0 placeholder.
3503 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3504 secure-auth settings.
3505 * src/modest-account-mgr-helpers.h:
3506 * src/modest-account-mgr-helpers.c:
3507 (modest_server_account_data_get_option_secure_auth),
3508 (modest_server_account_set_option_secure_auth),
3509 (modest_server_account_data_get_option_security),
3510 (modest_server_account_set_option_security): Added this API for getting and setting the security
3511 and secure-auth settings.
3513 * src/maemo/modest-account-settings-dialog.h:
3514 * src/maemo/modest-account-settings-dialog.c:
3515 (modest_account_settings_dialog_finalize), (check_data),
3516 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3517 about changing titles.
3518 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3519 (save_configuration): Save the security and secure-auth settings.
3521 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3522 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3524 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3526 * src/modest-defs.h:
3527 * src/modest-account-mgr.c:
3528 (modest_account_mgr_add_server_account):
3529 Added and used defines for the options key and value pair strings,
3530 that are used so far, though they do not seem to correspond to anything in our
3531 UI specs or ModestProtocol enum.
3533 * src/modest-account-mgr-helpers.h:
3534 * src/modest-account-mgr-helpers.c:
3535 (compare_option_strings_for_name),
3536 (modest_server_account_data_get_option_value),
3537 (modest_server_account_data_get_option_bool),
3538 (modest_account_mgr_get_server_account_option):
3539 Added helper functions for parsing the options GSList.
3541 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3543 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3544 display name is based on the supplied account name.
3545 * src/modest-account-mgr.c:
3546 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3547 with an inefficient, but good-enough, implementation.
3549 * src/maemo/easysetup/modest-easysetup-wizard.c:
3550 (create_page_account_details), (on_before_next), (create_account):
3551 Check for existing display names rather than (non-user-visible) account names, and just
3552 create and set a unique account name at the end.
3554 * src/maemo/modest-account-settings-dialog.c:
3555 (modest_account_settings_dialog_init),
3556 (modest_account_settings_dialog_set_account_name),
3557 (create_page_incoming): Show the display name, instead of the account name.
3558 (on_response): Do some (not all) extra checks, as in the UI spec.
3559 (save_configuration): Save the display name if it was changed.
3561 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3563 * po/en_GB.po: Added needed logical ID and translation.
3564 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3565 (init_view): Made the is-default column clicking work.
3567 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3570 * src/maemo/easysetup/Makefile.am:
3571 * src/maemo/easysetup/modest-easysetup-wizard.c:
3572 (modest_easysetup_wizard_dialog_init):
3573 * src/maemo/easysetup/provider-data-test.keyfile:
3574 * src/maemo/easysetup/provider-data.keyfile:
3575 Moved the provider data file to the new modest-providers-data package and used it from there.
3577 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3579 * src/modest-local-folder-info.c:
3580 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3581 N_() was already used on the static strings, but this just marks it for translation without
3582 using the translation.
3584 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3586 * src/maemo/modest-account-settings-dialog.c:
3587 (create_page_incoming),
3588 (modest_account_settings_dialog_set_account_name):
3589 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3590 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3591 I will do this if nobody else gets there first.
3593 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3595 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3596 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3597 save the security stuff.
3599 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3601 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3602 Set the email address and user fullname, which I now see must be
3605 * src/maemo/modest-account-settings-dialog.h:
3606 * src/maemo/modest-account-settings-dialog.c:
3608 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3609 leave-on-server and authentication.
3610 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3613 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3616 * src/maemo/modest-account-settings-dialog.c:
3617 * src/maemo/modest-account-settings-dialog.h:
3618 Most (but not all) of the widgets are now present as specified by the UI spec.
3619 No changes are yet saved, and some details are not properly shown yet.
3621 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3623 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3625 * src/maemo/Makefile.am:
3626 * src/maemo/modest-account-settings-dialog.c:
3627 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3628 an existing account. Doesn't do much yet.
3630 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3631 Open the accounts settings dialog when Edit is clicked.
3633 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3635 * src/maemo/easysetup/Makefile.am:
3636 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3638 * src/maemo/easysetup/modest-easysetup-wizard.c:
3639 (modest_easysetup_wizard_dialog_init):
3640 Try to get the source directory from the build system,
3641 instead of hard-coding "./" into the source code, when opening our local
3642 copies of the configuration files.
3643 But this still fails when opening the wizard from the Accounts window,
3644 maybe because the working directory seems to change at runtime.
3645 So the wizard will fail the second time unless you copy the files into their
3646 proper locations - see the stdout warnings for the paths.
3648 (create_page_account_details),(on_before_next):
3649 Check for existing non-server accounts instead of server accounts,
3650 so the default account name is useful again, and to prevent trying to
3653 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3654 Show the wizard when New is clicked.
3656 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3657 (init_view): Show the column headers, and show the columns that are
3658 specified in the UI specs. However, something in Maemo's GTK+ prevents
3659 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3660 change the default account. This is despite unsetting the special properties.
3662 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3664 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3665 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3666 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3667 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3668 to make that clearer.
3669 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3671 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3673 * src/maemo/modest-account-view-window.c:
3674 (modest_account_view_window_init),
3675 (modest_account_view_window_new):
3676 Use the same buttons as specified in the
3677 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3678 the existing widgets, which never had a chance of working.
3679 Put the ModestAccountView treeview in a scrolled window.
3680 Do not repeat the initialization in both _init() and _new().
3682 * src/widgets/modest-account-view.c: (update_account_view):
3683 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3684 this widget and window shows no accounts.
3686 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3688 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3690 * src/maemo/easysetup/modest-easysetup-wizard.c:
3691 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3692 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3693 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3696 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3697 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3698 accounts exist yet, as in the UI spec.
3700 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3702 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3704 * src/maemo/Makefile.am:
3705 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3706 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3707 New window for editing connection-specific smtp details.
3708 Not fully implemented.
3710 * src/maemo/modest-connection-specific-smtp-window.c:
3711 (modest_connection_specific_smtp_window_finalize) :
3712 unref the tree model.
3713 (on_button_edit): Show the edit window.
3715 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3717 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3720 * src/maemo/Makefile.am:
3721 * src/maemo/modest-connection-specific-smtp-window.c:
3722 * src/maemo/modest-connection-specific-smtp-window.h:
3723 New window for showing the list of connections, for connection-specific
3724 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3725 * src/maemo/easysetup/modest-easysetup-wizard.c:
3726 (create_page_custom_outgoing): Show the new window when the button is clicked.
3728 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3730 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3731 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3732 * src/maemo/modest-msg-edit-window.c:
3733 (modest_msg_edit_window_insert_image):
3734 * src/modest-conf.c: (modest_conf_key_escape):
3735 * src/modest-mail-operation.c:
3736 (modest_mail_operation_send_new_mail):
3737 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3738 (modest_ui_actions_on_new_account):
3739 * src/widgets/modest-attachment-view.c: (update_filename_request):
3740 * src/widgets/modest-mail-header-view.c:
3741 Corrected warnings that were breaking the build, by commenting out unused variables,
3742 and a function, and by including a header.
3744 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3746 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3747 so we can #ifdef around platform-specific code when necessary.
3748 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3749 to allow this to build for the GNOME platform too.
3751 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3753 * src/maemo/easysetup/modest-easysetup-wizard.c:
3754 Added util_increment_name() and used it in create_page_account_details()
3755 to make sure that the default account name is always a new name.
3757 (modest_easysetup_wizard_dialog_init),
3758 (set_default_custom_servernames): Some minor memory management fixes.
3760 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3764 * src/modest-runtime.c: (init_i18n): Restored the translation
3765 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3766 are defined in config.h, and the translations are installed.
3768 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3769 is defined for translation.
3771 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3773 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3775 * src/maemo/easysetup/modest-easysetup-wizard.c:
3776 (modest_easysetup_wizard_dialog_init):
3777 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3778 Use realistic paths (though they should use $prefix generically) to the
3779 mcc_mapping and provider-data.keyfile files which might work when they
3780 are installed by the future version of the operator-wizard package,
3781 and then fallback to paths in our source code, with an explanatory
3784 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3788 * src/maemo/Makefile.am:
3789 * src/maemo/easysetup/: Added files from the previously-exernal
3790 osso-modest-easysetup.
3791 * src/maemo/modest-main-window-ui.h:
3792 * src/modest-ui-actions.c:
3793 * src/modest-ui-actions.h:
3794 Added modest_ui_actions_on_new_account() as a signal handler for the
3795 New Account menu item. It shows the easysetup wizard.
3796 * po/en_GB.po: Added additional needed logical IDs and translations.